ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_user.c (file contents), Revision 3156 by michael, Fri Mar 14 19:57:38 2014 UTC vs.
ircd-hybrid/trunk/src/user.c (file contents), Revision 3504 by michael, Sat May 10 19:51:29 2014 UTC

# Line 26 | Line 26
26  
27   #include "stdinc.h"
28   #include "list.h"
29 < #include "s_user.h"
30 < #include "s_misc.h"
29 > #include "user.h"
30   #include "channel.h"
31   #include "channel_mode.h"
32   #include "client.h"
# Line 39 | Line 38
38   #include "numeric.h"
39   #include "conf.h"
40   #include "log.h"
41 < #include "s_serv.h"
41 > #include "server.h"
42   #include "send.h"
43   #include "supported.h"
44   #include "memory.h"
45   #include "packet.h"
46   #include "rng_mt.h"
47   #include "userhost.h"
48 < #include "s_misc.h"
48 > #include "misc.h"
49   #include "parse.h"
50   #include "watch.h"
51  
52   static char umode_buffer[IRCD_BUFSIZE];
54
55 static void user_welcome(struct Client *);
56 static void report_and_set_user_flags(struct Client *, const struct MaskItem *);
57 static int check_xline(struct Client *);
58 static void introduce_client(struct Client *);
53   static const char *uid_get(void);
54  
55   /* Used for building up the isupport string,
56   * used with init_isupport, add_isupport, delete_isupport
57   */
64
58   struct Isupport
59   {
60    dlink_node node;
# Line 174 | Line 167 | show_lusers(struct Client *source_p)
167                         Count.invisi, dlink_list_length(&global_serv_list));
168    else
169      sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT,
170 <                       (Count.total-Count.invisi), Count.invisi, 1);
170 >                       (Count.total - Count.invisi), Count.invisi, 1);
171  
172 <  if (Count.oper > 0)
172 >  if (Count.oper)
173      sendto_one_numeric(source_p, &me, RPL_LUSEROP, Count.oper);
174  
175 <  if (dlink_list_length(&unknown_list) > 0)
175 >  if (dlink_list_length(&unknown_list))
176      sendto_one_numeric(source_p, &me, RPL_LUSERUNKNOWN, dlink_list_length(&unknown_list));
177  
178 <  if (dlink_list_length(&global_channel_list) > 0)
178 >  if (dlink_list_length(&global_channel_list))
179      sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&global_channel_list));
180  
181    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
# Line 224 | Line 217 | show_isupport(struct Client *source_p)
217      sendto_one_numeric(source_p, &me, RPL_ISUPPORT, ptr->data);
218   }
219  
220 < /*
221 < ** register_local_user
222 < **      This function is called when both NICK and USER messages
223 < **      have been accepted for the client, in whatever order. Only
224 < **      after this, is the USER message propagated.
225 < **
226 < **      NICK's must be propagated at once when received, although
227 < **      it would be better to delay them too until full info is
228 < **      available. Doing it is not so simple though, would have
229 < **      to implement the following:
230 < **
231 < **      (actually it has been implemented already for a while) -orabidoo
232 < **
233 < **      1) user telnets in and gives only "NICK foobar" and waits
234 < **      2) another user far away logs in normally with the nick
235 < **         "foobar" (quite legal, as this server didn't propagate
236 < **         it).
237 < **      3) now this server gets nick "foobar" from outside, but
238 < **         has alread the same defined locally. Current server
239 < **         would just issue "KILL foobar" to clean out dups. But,
240 < **         this is not fair. It should actually request another
241 < **         nick from local user or kill him/her...
242 < */
220 >
221 > /* report_and_set_user_flags()
222 > *
223 > * inputs       - pointer to source_p
224 > *              - pointer to conf for this user
225 > * output       - NONE
226 > * side effects - Report to user any special flags
227 > *                they are getting, and set them.
228 > */
229 > static void
230 > report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
231 > {
232 >  /* If this user is being spoofed, tell them so */
233 >  if (IsConfDoSpoofIp(conf))
234 >    sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
235 >
236 >  /* If this user is in the exception class, Set it "E lined" */
237 >  if (IsConfExemptKline(conf))
238 >  {
239 >    SetExemptKline(source_p);
240 >    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D/G lines. Congrats.");
241 >  }
242 >
243 >  /*
244 >   * The else here is to make sure that G line exempt users
245 >   * do not get noticed twice.
246 >   */
247 >  else if (IsConfExemptGline(conf))
248 >  {
249 >    SetExemptGline(source_p);
250 >    sendto_one_notice(source_p, &me, ":*** You are exempt from G lines. Congrats.");
251 >  }
252 >
253 >  if (IsConfExemptResv(conf))
254 >  {
255 >    SetExemptResv(source_p);
256 >    sendto_one_notice(source_p, &me, ":*** You are exempt from resvs. Congrats.");
257 >  }
258 >
259 >  /* If this user is exempt from user limits set it "F lined" */
260 >  if (IsConfExemptLimits(conf))
261 >  {
262 >    SetExemptLimits(source_p);
263 >    sendto_one_notice(source_p, &me, ":*** You are exempt from user limits. Congrats.");
264 >  }
265 >
266 >  if (IsConfCanFlood(conf))
267 >  {
268 >    SetCanFlood(source_p);
269 >    sendto_one_notice(source_p, &me, ":*** You are exempt from flood "
270 >                      "protection, aren't you fearsome.");
271 >  }
272 > }
273 >
274 > /* introduce_client()
275 > *
276 > * inputs       - source_p
277 > * output       - NONE
278 > * side effects - This common function introduces a client to the rest
279 > *                of the net, either from a local client connect or
280 > *                from a remote connect.
281 > */
282 > static void
283 > introduce_client(struct Client *source_p)
284 > {
285 >  dlink_node *ptr = NULL;
286 >  char ubuf[IRCD_BUFSIZE] = "";
287 >
288 >  if (MyClient(source_p))
289 >    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
290 >  else
291 >    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
292 >
293 >  watch_check_hash(source_p, RPL_LOGON);
294 >
295 >  if (ubuf[0] == '\0')
296 >  {
297 >    ubuf[0] = '+';
298 >    ubuf[1] = '\0';
299 >  }
300 >
301 >  DLINK_FOREACH(ptr, serv_list.head)
302 >  {
303 >    struct Client *server = ptr->data;
304 >
305 >    if (server == source_p->from)
306 >      continue;
307 >
308 >    if (IsCapable(server, CAP_SVS))
309 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
310 >                 source_p->servptr->id,
311 >                 source_p->name, source_p->hopcount+1,
312 >                 (unsigned long)source_p->tsinfo,
313 >                 ubuf, source_p->username, source_p->host,
314 >                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
315 >                 "0" : source_p->sockhost, source_p->id,
316 >                 source_p->svid,
317 >                 source_p->info);
318 >    else
319 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
320 >                 source_p->servptr->id,
321 >                 source_p->name, source_p->hopcount+1,
322 >                 (unsigned long)source_p->tsinfo,
323 >                 ubuf, source_p->username, source_p->host,
324 >                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
325 >                 "0" : source_p->sockhost, source_p->id, source_p->info);
326 >
327 >    if (!EmptyString(source_p->certfp))
328 >      sendto_one(server, ":%s CERTFP %s", source_p->id, source_p->certfp);
329 >  }
330 > }
331 >
332 > /* user_welcome()
333 > *
334 > * inputs       - client pointer to client to welcome
335 > * output       - NONE
336 > * side effects -
337 > */
338 > static void
339 > user_welcome(struct Client *source_p)
340 > {
341 > #if defined(__TIME__) && defined(__DATE__)
342 >  static const char built_date[] = __DATE__ " at " __TIME__;
343 > #else
344 >  static const char built_date[] = "unknown";
345 > #endif
346 >
347 > #ifdef HAVE_LIBCRYPTO
348 >  if (HasFlag(source_p, FLAGS_SSL))
349 >  {
350 >    AddUMode(source_p, UMODE_SSL);
351 >    sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
352 >                      ssl_get_cipher(source_p->localClient->fd.ssl));
353 >  }
354 > #endif
355 >
356 >  sendto_one_numeric(source_p, &me, RPL_WELCOME, ServerInfo.network_name,
357 >                     source_p->name);
358 >  sendto_one_numeric(source_p, &me, RPL_YOURHOST,
359 >                     get_listener_name(source_p->localClient->listener), ircd_version);
360 >  sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
361 >  sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
362 >  show_isupport(source_p);
363 >
364 >  if (source_p->id[0])
365 >    sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
366 >
367 >  show_lusers(source_p);
368 >  motd_signon(source_p);
369 > }
370 >
371 > /* check_xline()
372 > *
373 > * inputs       - pointer to client to test
374 > * outupt       - 1 if exiting 0 if ok
375 > * side effects -
376 > */
377 > static int
378 > check_xline(struct Client *source_p)
379 > {
380 >  struct MaskItem *conf = NULL;
381 >  const char *reason = NULL;
382 >
383 >  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
384 >  {
385 >    ++conf->count;
386 >
387 >    if (conf->reason)
388 >      reason = conf->reason;
389 >    else
390 >      reason = CONF_NOREASON;
391 >
392 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
393 >                         "X-line Rejecting [%s] [%s], user %s [%s]",
394 >                         source_p->info, reason,
395 >                         get_client_name(source_p, HIDE_IP),
396 >                         source_p->sockhost);
397 >
398 >    ++ServerStats.is_ref;
399 >    exit_client(source_p, "Bad user info");
400 >    return 1;
401 >  }
402 >
403 >  return 0;
404 > }
405 >
406 > /*! \brief This function is called when both NICK and USER messages
407 > *      have been accepted for the client, in whatever order. Only
408 > *      after this, is the UID message propagated.
409 > * \param source_p Pointer to given client to introduce
410 > */
411   void
412   register_local_user(struct Client *source_p)
413   {
414    const char *id = NULL;
415    const struct MaskItem *conf = NULL;
416  
256  assert(source_p != NULL);
417    assert(source_p == source_p->from);
418    assert(MyConnect(source_p));
419    assert(!source_p->localClient->registration);
# Line 297 | Line 457 | register_local_user(struct Client *sourc
457  
458    if (!IsGotId(source_p))
459    {
460 <    char username[USERLEN + 1];
460 >    char username[USERLEN + 1] = "";
461      const char *p = username;
462      unsigned int i = 0;
463  
# Line 306 | Line 466 | register_local_user(struct Client *sourc
466        ++ServerStats.is_ref;
467        sendto_one_notice(source_p, &me, ":*** Notice -- You need to install "
468                          "identd to use this server");
469 <      exit_client(source_p, &me, "Install identd");
469 >      exit_client(source_p, "Install identd");
470        return;
471      }
472  
# Line 322 | Line 482 | register_local_user(struct Client *sourc
482      source_p->username[i] = '\0';
483    }
484  
485 <  /* password check */
485 >  /* Password check */
486    if (!EmptyString(conf->passwd))
487    {
488      const char *pass = source_p->localClient->passwd;
# Line 332 | Line 492 | register_local_user(struct Client *sourc
492        ++ServerStats.is_ref;
493  
494        sendto_one_numeric(source_p, &me, ERR_PASSWDMISMATCH);
495 <      exit_client(source_p, &me, "Bad Password");
495 >      exit_client(source_p, "Bad Password");
496        return;
497      }
498    }
499  
500 <  /* don't free source_p->localClient->passwd here - it can be required
500 >  /*
501 >   * Don't free source_p->localClient->passwd here - it can be required
502     * by masked /stats I if there are auth{} blocks with need_password = no;
503     * --adx
504     */
505  
506 <  /* report if user has &^>= etc. and set flags as needed in source_p */
506 >  /*
507 >   * Report if user has &^>= etc. and set flags as needed in source_p
508 >   */
509    report_and_set_user_flags(source_p, conf);
510  
511    if (IsDead(source_p))
512      return;
513  
514 <  /* Limit clients -
514 >  /*
515 >   * Limit clients -
516     * We want to be able to have servers and F-line clients
517     * connect, so save room for "buffer" connections.
518     * Smaller servers may want to decrease this, and it should
519     * probably be just a percentage of the MAXCLIENTS...
520     *   -Taner
521     */
358  /* Except "F:" clients */
522    if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
523        (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
524    {
# Line 363 | Line 526 | register_local_user(struct Client *sourc
526                           "Too many clients, rejecting %s[%s].",
527                           source_p->name, source_p->host);
528      ++ServerStats.is_ref;
529 <    exit_client(source_p, &me, "Sorry, server is full - try later");
529 >    exit_client(source_p, "Sorry, server is full - try later");
530      return;
531    }
532  
370  /* valid user name check */
533    if (!valid_username(source_p->username, 1))
534    {
535 <    char tmpstr2[IRCD_BUFSIZE];
535 >    char buf[IRCD_BUFSIZE] = "";
536  
537      sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
538                           "Invalid username: %s (%s@%s)",
539                           source_p->name, source_p->username, source_p->host);
540      ++ServerStats.is_ref;
541 <    snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
542 <             source_p->username);
381 <    exit_client(source_p, &me, tmpstr2);
541 >    snprintf(buf, sizeof(buf), "Invalid username [%s]", source_p->username);
542 >    exit_client(source_p, buf);
543      return;
544    }
545  
546    if (check_xline(source_p))
547      return;
548  
549 <  while (hash_find_id((id = uid_get())) != NULL)
549 >  while (hash_find_id((id = uid_get())))
550      ;
551  
552    strlcpy(source_p->id, id, sizeof(source_p->id));
# Line 415 | Line 576 | register_local_user(struct Client *sourc
576                             Count.max_loc);
577    }
578  
418  /* Increment our total user count here */
579    if (++Count.total > Count.max_tot)
580      Count.max_tot = Count.total;
581    ++Count.totalrestartcount;
# Line 454 | Line 614 | register_remote_user(struct Client *sour
614   {
615    struct Client *target_p = NULL;
616  
457  assert(source_p != NULL);
617    assert(source_p->username != username);
618  
619    strlcpy(source_p->host, host, sizeof(source_p->host));
620    strlcpy(source_p->username, username, sizeof(source_p->username));
621  
622    /*
623 <   * coming from another server, take the servers word for it
623 >   * Coming from another server, take the servers word for it
624     */
625    source_p->servptr = hash_find_server(server);
626  
# Line 476 | Line 635 | register_remote_user(struct Client *sour
635                           "No server %s for user %s[%s@%s] from %s",
636                           server, source_p->name, source_p->username,
637                           source_p->host, source_p->from->name);
638 <    kill_client(source_p->from, source_p, "%s (Server doesn't exist)", me.name);
638 >    sendto_one(source_p->from,
639 >               ":%s KILL %s :%s (Ghosted, server %s doesn't exist)",
640 >               me.id, source_p->id, me.name, server);
641  
642      AddFlag(source_p, FLAGS_KILLED);
643 <    exit_client(source_p, &me, "Ghosted Client");
643 >    exit_client(source_p, "Ghosted Client");
644      return;
645    }
646  
# Line 490 | Line 651 | register_remote_user(struct Client *sour
651                           source_p->from->name, source_p->name, source_p->username,
652                           source_p->host, source_p->servptr->name,
653                           target_p->name, target_p->from->name);
654 <    kill_client(source_p->from, source_p,
655 <                "%s (NICK from wrong direction (%s != %s))",
656 <                me.name, source_p->servptr->name, target_p->from->name);
654 >    sendto_one(source_p->from,
655 >               ":%s KILL %s :%s (NICK from wrong direction (%s != %s))",
656 >               me.id, source_p->id, me.name, source_p->servptr->name,
657 >               target_p->from->name);
658 >
659      AddFlag(source_p, FLAGS_KILLED);
660 <    exit_client(source_p, &me, "USER server wrong direction");
660 >    exit_client(source_p, "USER server wrong direction");
661      return;
662    }
663  
# Line 505 | Line 668 | register_remote_user(struct Client *sour
668    if (HasFlag(source_p->servptr, FLAGS_SERVICE))
669      AddFlag(source_p, FLAGS_SERVICE);
670  
508  /* Increment our total user count here */
671    if (++Count.total > Count.max_tot)
672      Count.max_tot = Count.total;
673  
# Line 524 | Line 686 | register_remote_user(struct Client *sour
686    introduce_client(source_p);
687   }
688  
527 /* introduce_client()
528 *
529 * inputs       - source_p
530 * output       - NONE
531 * side effects - This common function introduces a client to the rest
532 *                of the net, either from a local client connect or
533 *                from a remote connect.
534 */
535 static void
536 introduce_client(struct Client *source_p)
537 {
538  dlink_node *server_node = NULL;
539  char ubuf[IRCD_BUFSIZE];
540
541  if (MyClient(source_p))
542    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
543  else
544    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
545
546  watch_check_hash(source_p, RPL_LOGON);
547
548  if (ubuf[0] == '\0')
549  {
550    ubuf[0] = '+';
551    ubuf[1] = '\0';
552  }
553
554  DLINK_FOREACH(server_node, serv_list.head)
555  {
556    struct Client *server = server_node->data;
557
558    if (server == source_p->from)
559        continue;
560
561    if (IsCapable(server, CAP_SVS))
562      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
563                 source_p->servptr->id,
564                 source_p->name, source_p->hopcount+1,
565                 (unsigned long)source_p->tsinfo,
566                 ubuf, source_p->username, source_p->host,
567                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
568                 "0" : source_p->sockhost, source_p->id,
569                 source_p->svid,
570                 source_p->info);
571    else
572      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
573                 source_p->servptr->id,
574                 source_p->name, source_p->hopcount+1,
575                 (unsigned long)source_p->tsinfo,
576                 ubuf, source_p->username, source_p->host,
577                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
578                 "0" : source_p->sockhost, source_p->id, source_p->info);
579
580    if (!EmptyString(source_p->certfp))
581      sendto_one(server, ":%s CERTFP %s", ID(source_p), source_p->certfp);
582  }
583 }
584
689   /* valid_hostname()
690   *
691   * Inputs       - pointer to hostname
# Line 596 | Line 700 | valid_hostname(const char *hostname)
700   {
701    const char *p = hostname;
702  
703 <  assert(p != NULL);
703 >  assert(p);
704  
705    if (EmptyString(p) || *p == '.' || *p == ':')
706      return 0;
# Line 625 | Line 729 | valid_username(const char *username, con
729    int dots      = 0;
730    const char *p = username;
731  
732 <  assert(p != NULL);
732 >  assert(p);
733  
734    if (*p == '~')
735      ++p;
# Line 674 | Line 778 | int
778   valid_nickname(const char *nickname, const int local)
779   {
780    const char *p = nickname;
781 +
782    assert(nickname && *nickname);
783  
784 <  /* nicks can't start with a digit or - or be 0 length */
785 <  /* This closer duplicates behaviour of hybrid-6 */
784 >  /*
785 >   * Nicks can't start with a digit or - or be 0 length.
786 >   */
787    if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
788      return 0;
789  
# Line 688 | Line 794 | valid_nickname(const char *nickname, con
794    return p - nickname <= NICKLEN;
795   }
796  
691 /* report_and_set_user_flags()
692 *
693 * inputs       - pointer to source_p
694 *              - pointer to conf for this user
695 * output       - NONE
696 * side effects - Report to user any special flags
697 *                they are getting, and set them.
698 */
699 static void
700 report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
701 {
702  /* If this user is being spoofed, tell them so */
703  if (IsConfDoSpoofIp(conf))
704    sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
705
706  /* If this user is in the exception class, Set it "E lined" */
707  if (IsConfExemptKline(conf))
708  {
709    SetExemptKline(source_p);
710    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D/G lines. Congrats.");
711  }
712
713  /*
714   * The else here is to make sure that G line exempt users
715   * do not get noticed twice.
716   */
717  else if (IsConfExemptGline(conf))
718  {
719    SetExemptGline(source_p);
720    sendto_one_notice(source_p, &me, ":*** You are exempt from G lines. Congrats.");
721  }
722
723  if (IsConfExemptResv(conf))
724  {
725    SetExemptResv(source_p);
726    sendto_one_notice(source_p, &me, ":*** You are exempt from resvs. Congrats.");
727  }
728
729  /* If this user is exempt from user limits set it "F lined" */
730  if (IsConfExemptLimits(conf))
731  {
732    SetExemptLimits(source_p);
733    sendto_one_notice(source_p, &me, ":*** You are exempt from user limits. Congrats.");
734  }
735
736  if (IsConfCanFlood(conf))
737  {
738    SetCanFlood(source_p);
739    sendto_one_notice(source_p, &me, ":*** You are exempt from flood "
740                      "protection, aren't you fearsome.");
741  }
742 }
743
744 /* set_user_mode()
745 *
746 * added 15/10/91 By Darren Reed.
747 * parv[0] - command
748 * parv[1] - username to change mode for
749 * parv[2] - modes to change
750 */
751 void
752 set_user_mode(struct Client *source_p, const int parc, char *parv[])
753 {
754  unsigned int flag, setflags;
755  char **p, *m, buf[IRCD_BUFSIZE];
756  struct Client *target_p;
757  int what = MODE_ADD, badflag = 0, i;
758
759  assert(!(parc < 2));
760
761  if ((target_p = find_person(source_p, parv[1])) == NULL)
762  {
763    if (MyConnect(source_p))
764      sendto_one_numeric(source_p, &me, ERR_NOSUCHCHANNEL, parv[1]);
765    return;
766  }
767
768  if (source_p != target_p)
769  {
770     sendto_one_numeric(source_p, &me, ERR_USERSDONTMATCH);
771     return;
772  }
773
774  if (parc < 3)
775  {
776    m = buf;
777    *m++ = '+';
778
779    for (i = 0; i < 128; ++i)
780      if (HasUMode(source_p, user_modes[i]))
781        *m++ = (char)i;
782    *m = '\0';
783
784    sendto_one_numeric(source_p, &me, RPL_UMODEIS, buf);
785    return;
786  }
787
788  /* find flags already set for user */
789  setflags = source_p->umodes;
790
791  /* parse mode change string(s) */
792  for (p = &parv[2]; p && *p; ++p)
793  {
794    for (m = *p; *m; ++m)
795    {
796      switch (*m)
797      {
798        case '+':
799          what = MODE_ADD;
800          break;
801        case '-':
802          what = MODE_DEL;
803          break;
804        case 'o':
805          if (what == MODE_ADD)
806          {
807            if (IsServer(source_p->from) && !HasUMode(source_p, UMODE_OPER))
808            {
809              ++Count.oper;
810              SetOper(source_p);
811            }
812          }
813          else
814          {
815            if (!HasUMode(source_p, UMODE_OPER))
816              break;
817
818            ClearOper(source_p);
819            Count.oper--;
820
821            if (MyConnect(source_p))
822            {
823              dlink_node *dm = NULL;
824
825              detach_conf(source_p, CONF_OPER);
826              ClrOFlag(source_p);
827              DelUMode(source_p, ConfigFileEntry.oper_only_umodes);
828
829              if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
830                free_dlink_node(dm);
831            }
832          }
833
834          break;
835
836        case 'S':  /* Only servers may set +S in a burst */
837        case 'W':  /* Only servers may set +W in a burst */
838        case 'r':  /* Only services may set +r */
839        case 'x':  /* Only services may set +x */
840          break;
841
842        default:
843          if ((flag = user_modes[(unsigned char)*m]))
844          {
845            if (MyConnect(source_p) && !HasUMode(source_p, UMODE_OPER) &&
846                (ConfigFileEntry.oper_only_umodes & flag))
847              badflag = 1;
848            else
849            {
850              if (what == MODE_ADD)
851                AddUMode(source_p, flag);
852              else
853                DelUMode(source_p, flag);
854            }
855          }
856          else if (MyConnect(source_p))
857            badflag = 1;
858
859          break;
860      }
861    }
862  }
863
864  if (badflag)
865    sendto_one_numeric(source_p, &me, ERR_UMODEUNKNOWNFLAG);
866
867  if (MyConnect(source_p) && HasUMode(source_p, UMODE_ADMIN) &&
868      !HasOFlag(source_p, OPER_FLAG_ADMIN))
869  {
870    sendto_one_notice(source_p, &me, ":*** You have no admin flag;");
871    DelUMode(source_p, UMODE_ADMIN);
872  }
873
874  if (!(setflags & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
875    ++Count.invisi;
876  if ((setflags & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
877    --Count.invisi;
878
879  /*
880   * compare new flags with old flags and send string which
881   * will cause servers to update correctly.
882   */
883  send_umode_out(source_p, source_p, setflags);
884 }
885
797   /* send_umode()
798   * send the MODE string for user (user) to connection client_p
799   * -avalon
# Line 900 | Line 811 | send_umode(struct Client *client_p, stru
811   {
812    char *m = umode_buf;
813    int what = 0;
903  unsigned int i;
904  unsigned int flag;
814  
815    /*
816 <   * build a string in umode_buf to represent the change in the user's
816 >   * Build a string in umode_buf to represent the change in the user's
817     * mode between the new (source_p->umodes) and 'old'.
818     */
819 <  for (i = 0; i < 128; ++i)
819 >  for (unsigned int i = 0; i < 128; ++i)
820    {
821 <    flag = user_modes[i];
821 >    unsigned int flag = user_modes[i];
822 >
823      if (!flag)
824        continue;
825  
# Line 958 | Line 868 | void
868   send_umode_out(struct Client *client_p, struct Client *source_p,
869                 unsigned int old)
870   {
871 <  char buf[IRCD_BUFSIZE] = { '\0' };
962 <  dlink_node *ptr = NULL;
871 >  char buf[IRCD_BUFSIZE] = "";
872  
873    send_umode(NULL, source_p, old, SEND_UMODES, buf);
874  
875    if (buf[0])
876      sendto_server(source_p, NOCAPS, NOCAPS, ":%s MODE %s :%s",
877 <                  ID(source_p), ID(source_p), buf);
877 >                  source_p->id, source_p->id, buf);
878  
879    if (client_p && MyClient(client_p))
880      send_umode(client_p, source_p, old, 0xffffffff, buf);
# Line 1017 | Line 926 | user_set_hostmask(struct Client *target_
926  
927    DLINK_FOREACH(ptr, target_p->channel.head)
928    {
929 <    char modebuf[4], nickbuf[NICKLEN * 3 + 3] = { '\0' };
929 >    char modebuf[4], nickbuf[NICKLEN * 3 + 3] = "";
930      char *p = modebuf;
931      int len = 0;
932      const struct Membership *ms = ptr->data;
# Line 1059 | Line 968 | user_set_hostmask(struct Client *target_
968                                   target_p->host, target_p->away);
969   }
970  
971 < /* user_welcome()
972 < *
973 < * inputs       - client pointer to client to welcome
1065 < * output       - NONE
1066 < * side effects -
1067 < */
1068 < static void
1069 < user_welcome(struct Client *source_p)
1070 < {
1071 < #if defined(__TIME__) && defined(__DATE__)
1072 <  static const char built_date[] = __DATE__ " at " __TIME__;
1073 < #else
1074 <  static const char built_date[] = "unknown";
1075 < #endif
1076 <
1077 < #ifdef HAVE_LIBCRYPTO
1078 <  if (HasFlag(source_p, FLAGS_SSL))
1079 <  {
1080 <    AddUMode(source_p, UMODE_SSL);
1081 <    sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
1082 <                      ssl_get_cipher(source_p->localClient->fd.ssl));
1083 <  }
1084 < #endif
1085 <
1086 <  sendto_one_numeric(source_p, &me, RPL_WELCOME, ServerInfo.network_name,
1087 <                     source_p->name);
1088 <  sendto_one_numeric(source_p, &me, RPL_YOURHOST,
1089 <                     get_listener_name(source_p->localClient->listener), ircd_version);
1090 <  sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
1091 <  sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
1092 <  show_isupport(source_p);
1093 <
1094 <  if (source_p->id[0] != '\0')
1095 <    sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
1096 <
1097 <  show_lusers(source_p);
1098 <  motd_signon(source_p);
1099 < }
1100 <
1101 < /* check_xline()
1102 < *
1103 < * inputs       - pointer to client to test
1104 < * outupt       - 1 if exiting 0 if ok
1105 < * side effects -
1106 < */
1107 < static int
1108 < check_xline(struct Client *source_p)
1109 < {
1110 <  struct MaskItem *conf = NULL;
1111 <  const char *reason = NULL;
1112 <
1113 <  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
1114 <  {
1115 <    ++conf->count;
1116 <
1117 <    if (conf->reason != NULL)
1118 <      reason = conf->reason;
1119 <    else
1120 <      reason = "No Reason";
1121 <
1122 <    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
1123 <                         "X-line Rejecting [%s] [%s], user %s [%s]",
1124 <                         source_p->info, reason,
1125 <                         get_client_name(source_p, HIDE_IP),
1126 <                         source_p->sockhost);
1127 <
1128 <    ++ServerStats.is_ref;
1129 <    exit_client(source_p, &me, "Bad user info");
1130 <    return 1;
1131 <  }
1132 <
1133 <  return 0;
1134 < }
1135 <
1136 < /* oper_up()
1137 < *
1138 < * inputs       - pointer to given client to oper
1139 < * output       - NONE
1140 < * side effects - Blindly opers up given source_p, using conf info
1141 < *                all checks on passwords have already been done.
1142 < *                This could also be used by rsa oper routines.
971 > /*! \brief Blindly opers up given source_p, using conf info.
972 > *         All checks on passwords have already been done.
973 > * \param source_p Pointer to given client to oper
974   */
975   void
976   oper_up(struct Client *source_p)
# Line 1176 | Line 1007 | oper_up(struct Client *source_p)
1007    sendto_one_numeric(source_p, &me, RPL_YOUREOPER);
1008   }
1009  
1010 < static char new_uid[TOTALSIDUID + 1];     /* allow for \0 */
1010 > static char new_uid[TOTALSIDUID + 1];  /* Allow for \0 */
1011  
1012   int
1013   valid_sid(const char *sid)
# Line 1201 | Line 1032 | valid_sid(const char *sid)
1032   void
1033   init_uid(void)
1034   {
1204  unsigned int i;
1205
1035    memset(new_uid, 0, sizeof(new_uid));
1036  
1037    if (!EmptyString(ServerInfo.sid))
1038      strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1039  
1040 <  for (i = 0; i < IRC_MAXSID; ++i)
1040 >  for (unsigned int i = 0; i < IRC_MAXSID; ++i)
1041      if (new_uid[i] == '\0')
1042        new_uid[i] = 'A';
1043  
# Line 1227 | Line 1056 | init_uid(void)
1056   static void
1057   add_one_to_uid(int i)
1058   {
1059 <  if (i != IRC_MAXSID)    /* Not reached server SID portion yet? */
1059 >  if (i != IRC_MAXSID)  /* Not reached server SID portion yet? */
1060    {
1061      if (new_uid[i] == 'Z')
1062        new_uid[i] = '0';
# Line 1259 | Line 1088 | add_one_to_uid(int i)
1088   static const char *
1089   uid_get(void)
1090   {
1091 <  add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1091 >  add_one_to_uid(TOTALSIDUID - 1);  /* Index from 0 */
1092    return new_uid;
1093   }
1094  
# Line 1317 | Line 1146 | add_isupport(const char *name, const cha
1146  
1147    if (ptr == NULL)
1148    {
1149 <    support = MyMalloc(sizeof(*support));
1149 >    support = MyCalloc(sizeof(*support));
1150      dlinkAddTail(support, &support->node, &support_list);
1151    }
1152  
1153    support->name = xstrdup(name);
1154 <  if (options != NULL)
1154 >  if (options)
1155      support->options = xstrdup(options);
1156    support->number = n;
1157  
# Line 1390 | Line 1219 | rebuild_isupport_message_line(void)
1219      p += (n = sprintf(p, "%s", support->name));
1220      len += n;
1221  
1222 <    if (support->options != NULL)
1222 >    if (support->options)
1223      {
1224        p += (n = sprintf(p, "=%s", support->options));
1225        len += n;
# Line 1418 | Line 1247 | rebuild_isupport_message_line(void)
1247      }
1248    }
1249  
1250 <  if (len != 0)
1250 >  if (len)
1251    {
1252      if (*--p == ' ')
1253        *p = '\0';

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)