ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_user.c (file contents), Revision 2125 by michael, Sun May 26 18:41:13 2013 UTC vs.
ircd-hybrid/trunk/src/user.c (file contents), Revision 3504 by michael, Sat May 10 19:51:29 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_user.c: User related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 18 | Line 17
17   *  along with this program; if not, write to the Free Software
18   *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file s_user.c
23 > * \brief User related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29 < #include "s_user.h"
28 < #include "s_misc.h"
29 > #include "user.h"
30   #include "channel.h"
31   #include "channel_mode.h"
32   #include "client.h"
32 #include "fdlist.h"
33   #include "hash.h"
34   #include "irc_string.h"
35 #include "s_bsd.h"
35   #include "ircd.h"
36   #include "listener.h"
37   #include "motd.h"
38   #include "numeric.h"
39   #include "conf.h"
40   #include "log.h"
41 < #include "s_serv.h"
41 > #include "server.h"
42   #include "send.h"
43   #include "supported.h"
45 #include "whowas.h"
44   #include "memory.h"
45   #include "packet.h"
46   #include "rng_mt.h"
47   #include "userhost.h"
48 < #include "hook.h"
51 < #include "s_misc.h"
48 > #include "misc.h"
49   #include "parse.h"
50   #include "watch.h"
51  
55
52   static char umode_buffer[IRCD_BUFSIZE];
57
58 static void user_welcome(struct Client *);
59 static void report_and_set_user_flags(struct Client *, const struct MaskItem *);
60 static int check_xline(struct Client *);
61 static void introduce_client(struct Client *);
53   static const char *uid_get(void);
54  
55   /* Used for building up the isupport string,
56   * used with init_isupport, add_isupport, delete_isupport
57   */
58 <
68 < struct Isupport
58 > struct Isupport
59   {
60    dlink_node node;
61    char *name;
# Line 73 | Line 63 | struct Isupport
63    int number;
64   };
65  
66 < static dlink_list support_list = { NULL, NULL, 0 };
67 < MessageFile *isupportFile;
66 > static dlink_list support_list;
67 > static dlink_list support_list_lines;
68  
69   /* memory is cheap. map 0-255 to equivalent mode */
70   const unsigned int user_modes[256] =
# Line 86 | Line 76 | const unsigned int user_modes[256] =
76    0,                  /* @ */
77    0,                  /* A */
78    0,                  /* B */
79 <  UMODE_CCONN_FULL,   /* C */
79 >  0,                  /* C */
80    UMODE_DEAF,         /* D */
81    0,                  /* E */
82    UMODE_FARCONNECT,   /* F */
# Line 102 | Line 92 | const unsigned int user_modes[256] =
92    0,                  /* P */
93    0,                  /* Q */
94    UMODE_REGONLY,      /* R */
95 <  0,                  /* S */
95 >  UMODE_SSL,          /* S */
96    0,                  /* T */
97    0,                  /* U */
98    0,                  /* V */
99 <  0,                  /* W */
99 >  UMODE_WEBIRC,       /* W */
100    0,                  /* X */
101    0,                  /* Y */
102    0,                  /* Z 0x5A */
103 <  0, 0, 0, 0, 0,      /* 0x5F   */
103 >  0, 0, 0, 0, 0,      /* 0x5F   */
104    0,                  /* 0x60   */
105    UMODE_ADMIN,        /* a */
106    UMODE_BOTS,         /* b */
# Line 135 | Line 125 | const unsigned int user_modes[256] =
125    UMODE_UNAUTH,       /* u */
126    0,                  /* v */
127    UMODE_WALLOP,       /* w */
128 <  0,                  /* x */
128 >  UMODE_HIDDENHOST,   /* x */
129    UMODE_SPY,          /* y */
130    UMODE_OPERWALL,     /* z      0x7A */
131    0,0,0,0,0,          /* 0x7B - 0x7F */
# Line 170 | Line 160 | assemble_umode_buffer(void)
160   * side effects - display to client user counts etc.
161   */
162   void
163 < show_lusers(struct Client *source_p)
163 > show_lusers(struct Client *source_p)
164   {
175  const char *from, *to;
176
177  if (!MyConnect(source_p) && IsCapable(source_p->from, CAP_TS6) && HasID(source_p))
178  {
179    from = me.id;
180    to = source_p->id;
181  }
182  else
183  {
184    from = me.name;
185    to = source_p->name;
186  }
187
165    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
166 <    sendto_one(source_p, form_str(RPL_LUSERCLIENT),
167 <               from, to, (Count.total-Count.invisi),
191 <               Count.invisi, dlink_list_length(&global_serv_list));
166 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total-Count.invisi),
167 >                       Count.invisi, dlink_list_length(&global_serv_list));
168    else
169 <    sendto_one(source_p, form_str(RPL_LUSERCLIENT), from, to,
170 <               (Count.total-Count.invisi), Count.invisi, 1);
169 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT,
170 >                       (Count.total - Count.invisi), Count.invisi, 1);
171 >
172 >  if (Count.oper)
173 >    sendto_one_numeric(source_p, &me, RPL_LUSEROP, Count.oper);
174 >
175 >  if (dlink_list_length(&unknown_list))
176 >    sendto_one_numeric(source_p, &me, RPL_LUSERUNKNOWN, dlink_list_length(&unknown_list));
177  
178 <  if (Count.oper > 0)
179 <    sendto_one(source_p, form_str(RPL_LUSEROP),
198 <               from, to, Count.oper);
199 <
200 <  if (dlink_list_length(&unknown_list) > 0)
201 <    sendto_one(source_p, form_str(RPL_LUSERUNKNOWN),
202 <               from, to, dlink_list_length(&unknown_list));
203 <
204 <  if (dlink_list_length(&global_channel_list) > 0)
205 <    sendto_one(source_p, form_str(RPL_LUSERCHANNELS),
206 <               from, to, dlink_list_length(&global_channel_list));
178 >  if (dlink_list_length(&global_channel_list))
179 >    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&global_channel_list));
180  
181    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
182    {
183 <    sendto_one(source_p, form_str(RPL_LUSERME),
184 <               from, to, Count.local, Count.myserver);
212 <    sendto_one(source_p, form_str(RPL_LOCALUSERS),
213 <               from, to, Count.local, Count.max_loc);
183 >    sendto_one_numeric(source_p, &me, RPL_LUSERME, Count.local, Count.myserver);
184 >    sendto_one_numeric(source_p, &me, RPL_LOCALUSERS, Count.local, Count.max_loc);
185    }
186    else
187    {
188 <    sendto_one(source_p, form_str(RPL_LUSERME),
189 <               from, to, Count.total, 0);
219 <    sendto_one(source_p, form_str(RPL_LOCALUSERS),
220 <               from, to, Count.total, Count.max_tot);
188 >    sendto_one_numeric(source_p, &me, RPL_LUSERME, Count.total, 0);
189 >    sendto_one_numeric(source_p, &me, RPL_LOCALUSERS, Count.total, Count.max_tot);
190    }
191  
192 <  sendto_one(source_p, form_str(RPL_GLOBALUSERS),
224 <             from, to, Count.total, Count.max_tot);
192 >  sendto_one_numeric(source_p, &me, RPL_GLOBALUSERS, Count.total, Count.max_tot);
193  
194    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
195 <    sendto_one(source_p, form_str(RPL_STATSCONN), from, to,
196 <               Count.max_loc_con, Count.max_loc_cli, Count.totalrestartcount);
195 >    sendto_one_numeric(source_p, &me, RPL_STATSCONN, Count.max_loc_con,
196 >                       Count.max_loc_cli, Count.totalrestartcount);
197  
198    if (Count.local > Count.max_loc_cli)
199      Count.max_loc_cli = Count.local;
200  
201    if ((Count.local + Count.myserver) > Count.max_loc_con)
202 <    Count.max_loc_con = Count.local + Count.myserver;
202 >    Count.max_loc_con = Count.local + Count.myserver;
203   }
204  
205   /* show_isupport()
# Line 241 | Line 209 | show_lusers(struct Client *source_p)
209   * side effects - display to client what we support (for them)
210   */
211   void
212 < show_isupport(struct Client *source_p)
212 > show_isupport(struct Client *source_p)
213   {
214 <  send_message_file(source_p, isupportFile);
214 >  const dlink_node *ptr = NULL;
215 >
216 >  DLINK_FOREACH(ptr, support_list_lines.head)
217 >    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, ptr->data);
218   }
219  
220 < /*
221 < ** register_local_user
222 < **      This function is called when both NICK and USER messages
223 < **      have been accepted for the client, in whatever order. Only
224 < **      after this, is the USER message propagated.
225 < **
226 < **      NICK's must be propagated at once when received, although
227 < **      it would be better to delay them too until full info is
228 < **      available. Doing it is not so simple though, would have
229 < **      to implement the following:
230 < **
231 < **      (actually it has been implemented already for a while) -orabidoo
232 < **
233 < **      1) user telnets in and gives only "NICK foobar" and waits
234 < **      2) another user far away logs in normally with the nick
235 < **         "foobar" (quite legal, as this server didn't propagate
236 < **         it).
237 < **      3) now this server gets nick "foobar" from outside, but
238 < **         has alread the same defined locally. Current server
239 < **         would just issue "KILL foobar" to clean out dups. But,
240 < **         this is not fair. It should actually request another
241 < **         nick from local user or kill him/her...
242 < */
220 >
221 > /* report_and_set_user_flags()
222 > *
223 > * inputs       - pointer to source_p
224 > *              - pointer to conf for this user
225 > * output       - NONE
226 > * side effects - Report to user any special flags
227 > *                they are getting, and set them.
228 > */
229 > static void
230 > report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
231 > {
232 >  /* If this user is being spoofed, tell them so */
233 >  if (IsConfDoSpoofIp(conf))
234 >    sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
235 >
236 >  /* If this user is in the exception class, Set it "E lined" */
237 >  if (IsConfExemptKline(conf))
238 >  {
239 >    SetExemptKline(source_p);
240 >    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D/G lines. Congrats.");
241 >  }
242 >
243 >  /*
244 >   * The else here is to make sure that G line exempt users
245 >   * do not get noticed twice.
246 >   */
247 >  else if (IsConfExemptGline(conf))
248 >  {
249 >    SetExemptGline(source_p);
250 >    sendto_one_notice(source_p, &me, ":*** You are exempt from G lines. Congrats.");
251 >  }
252 >
253 >  if (IsConfExemptResv(conf))
254 >  {
255 >    SetExemptResv(source_p);
256 >    sendto_one_notice(source_p, &me, ":*** You are exempt from resvs. Congrats.");
257 >  }
258 >
259 >  /* If this user is exempt from user limits set it "F lined" */
260 >  if (IsConfExemptLimits(conf))
261 >  {
262 >    SetExemptLimits(source_p);
263 >    sendto_one_notice(source_p, &me, ":*** You are exempt from user limits. Congrats.");
264 >  }
265 >
266 >  if (IsConfCanFlood(conf))
267 >  {
268 >    SetCanFlood(source_p);
269 >    sendto_one_notice(source_p, &me, ":*** You are exempt from flood "
270 >                      "protection, aren't you fearsome.");
271 >  }
272 > }
273 >
274 > /* introduce_client()
275 > *
276 > * inputs       - source_p
277 > * output       - NONE
278 > * side effects - This common function introduces a client to the rest
279 > *                of the net, either from a local client connect or
280 > *                from a remote connect.
281 > */
282 > static void
283 > introduce_client(struct Client *source_p)
284 > {
285 >  dlink_node *ptr = NULL;
286 >  char ubuf[IRCD_BUFSIZE] = "";
287 >
288 >  if (MyClient(source_p))
289 >    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
290 >  else
291 >    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
292 >
293 >  watch_check_hash(source_p, RPL_LOGON);
294 >
295 >  if (ubuf[0] == '\0')
296 >  {
297 >    ubuf[0] = '+';
298 >    ubuf[1] = '\0';
299 >  }
300 >
301 >  DLINK_FOREACH(ptr, serv_list.head)
302 >  {
303 >    struct Client *server = ptr->data;
304 >
305 >    if (server == source_p->from)
306 >      continue;
307 >
308 >    if (IsCapable(server, CAP_SVS))
309 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
310 >                 source_p->servptr->id,
311 >                 source_p->name, source_p->hopcount+1,
312 >                 (unsigned long)source_p->tsinfo,
313 >                 ubuf, source_p->username, source_p->host,
314 >                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
315 >                 "0" : source_p->sockhost, source_p->id,
316 >                 source_p->svid,
317 >                 source_p->info);
318 >    else
319 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
320 >                 source_p->servptr->id,
321 >                 source_p->name, source_p->hopcount+1,
322 >                 (unsigned long)source_p->tsinfo,
323 >                 ubuf, source_p->username, source_p->host,
324 >                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
325 >                 "0" : source_p->sockhost, source_p->id, source_p->info);
326 >
327 >    if (!EmptyString(source_p->certfp))
328 >      sendto_one(server, ":%s CERTFP %s", source_p->id, source_p->certfp);
329 >  }
330 > }
331 >
332 > /* user_welcome()
333 > *
334 > * inputs       - client pointer to client to welcome
335 > * output       - NONE
336 > * side effects -
337 > */
338 > static void
339 > user_welcome(struct Client *source_p)
340 > {
341 > #if defined(__TIME__) && defined(__DATE__)
342 >  static const char built_date[] = __DATE__ " at " __TIME__;
343 > #else
344 >  static const char built_date[] = "unknown";
345 > #endif
346 >
347 > #ifdef HAVE_LIBCRYPTO
348 >  if (HasFlag(source_p, FLAGS_SSL))
349 >  {
350 >    AddUMode(source_p, UMODE_SSL);
351 >    sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
352 >                      ssl_get_cipher(source_p->localClient->fd.ssl));
353 >  }
354 > #endif
355 >
356 >  sendto_one_numeric(source_p, &me, RPL_WELCOME, ServerInfo.network_name,
357 >                     source_p->name);
358 >  sendto_one_numeric(source_p, &me, RPL_YOURHOST,
359 >                     get_listener_name(source_p->localClient->listener), ircd_version);
360 >  sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
361 >  sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
362 >  show_isupport(source_p);
363 >
364 >  if (source_p->id[0])
365 >    sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
366 >
367 >  show_lusers(source_p);
368 >  motd_signon(source_p);
369 > }
370 >
371 > /* check_xline()
372 > *
373 > * inputs       - pointer to client to test
374 > * outupt       - 1 if exiting 0 if ok
375 > * side effects -
376 > */
377 > static int
378 > check_xline(struct Client *source_p)
379 > {
380 >  struct MaskItem *conf = NULL;
381 >  const char *reason = NULL;
382 >
383 >  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
384 >  {
385 >    ++conf->count;
386 >
387 >    if (conf->reason)
388 >      reason = conf->reason;
389 >    else
390 >      reason = CONF_NOREASON;
391 >
392 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
393 >                         "X-line Rejecting [%s] [%s], user %s [%s]",
394 >                         source_p->info, reason,
395 >                         get_client_name(source_p, HIDE_IP),
396 >                         source_p->sockhost);
397 >
398 >    ++ServerStats.is_ref;
399 >    exit_client(source_p, "Bad user info");
400 >    return 1;
401 >  }
402 >
403 >  return 0;
404 > }
405 >
406 > /*! \brief This function is called when both NICK and USER messages
407 > *      have been accepted for the client, in whatever order. Only
408 > *      after this, is the UID message propagated.
409 > * \param source_p Pointer to given client to introduce
410 > */
411   void
412   register_local_user(struct Client *source_p)
413   {
414    const char *id = NULL;
415    const struct MaskItem *conf = NULL;
416  
278  assert(source_p != NULL);
417    assert(source_p == source_p->from);
418    assert(MyConnect(source_p));
419    assert(!source_p->localClient->registration);
# Line 284 | Line 422 | register_local_user(struct Client *sourc
422  
423    if (ConfigFileEntry.ping_cookie)
424    {
425 <    if (!IsPingSent(source_p) && source_p->localClient->random_ping == 0)
425 >    if (!IsPingSent(source_p) && !source_p->localClient->random_ping)
426      {
427        do
428          source_p->localClient->random_ping = genrand_int32();
# Line 307 | Line 445 | register_local_user(struct Client *sourc
445    if (!check_client(source_p))
446      return;
447  
448 <  if (valid_hostname(source_p->host) == 0)
448 >  if (!valid_hostname(source_p->host))
449    {
450 <    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You have an illegal "
451 <               "character in your hostname", me.name, source_p->name);
450 >    sendto_one_notice(source_p, &me, ":*** Notice -- You have an illegal "
451 >                      "character in your hostname");
452      strlcpy(source_p->host, source_p->sockhost,
453              sizeof(source_p->host));
454    }
# Line 319 | Line 457 | register_local_user(struct Client *sourc
457  
458    if (!IsGotId(source_p))
459    {
460 <    char username[USERLEN + 1];
460 >    char username[USERLEN + 1] = "";
461      const char *p = username;
462      unsigned int i = 0;
463  
464      if (IsNeedIdentd(conf))
465      {
466        ++ServerStats.is_ref;
467 <      sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You need to install "
468 <                 "identd to use this server", me.name, source_p->name);
469 <      exit_client(source_p, &me, "Install identd");
467 >      sendto_one_notice(source_p, &me, ":*** Notice -- You need to install "
468 >                        "identd to use this server");
469 >      exit_client(source_p, "Install identd");
470        return;
471      }
472  
# Line 344 | Line 482 | register_local_user(struct Client *sourc
482      source_p->username[i] = '\0';
483    }
484  
485 <  /* password check */
485 >  /* Password check */
486    if (!EmptyString(conf->passwd))
487    {
488      const char *pass = source_p->localClient->passwd;
# Line 352 | Line 490 | register_local_user(struct Client *sourc
490      if (!match_conf_password(pass, conf))
491      {
492        ++ServerStats.is_ref;
493 <      sendto_one(source_p, form_str(ERR_PASSWDMISMATCH),
494 <                 me.name, source_p->name);
495 <      exit_client(source_p, &me, "Bad Password");
493 >
494 >      sendto_one_numeric(source_p, &me, ERR_PASSWDMISMATCH);
495 >      exit_client(source_p, "Bad Password");
496        return;
497      }
498    }
499  
500 <  /* don't free source_p->localClient->passwd here - it can be required
500 >  /*
501 >   * Don't free source_p->localClient->passwd here - it can be required
502     * by masked /stats I if there are auth{} blocks with need_password = no;
503     * --adx
504     */
505  
506 <  /* report if user has &^>= etc. and set flags as needed in source_p */
506 >  /*
507 >   * Report if user has &^>= etc. and set flags as needed in source_p
508 >   */
509    report_and_set_user_flags(source_p, conf);
510  
511    if (IsDead(source_p))
512      return;
513  
514 <  /* Limit clients -
514 >  /*
515 >   * Limit clients -
516     * We want to be able to have servers and F-line clients
517     * connect, so save room for "buffer" connections.
518     * Smaller servers may want to decrease this, and it should
519     * probably be just a percentage of the MAXCLIENTS...
520     *   -Taner
521     */
380  /* Except "F:" clients */
522    if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
523        (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
524    {
# Line 385 | Line 526 | register_local_user(struct Client *sourc
526                           "Too many clients, rejecting %s[%s].",
527                           source_p->name, source_p->host);
528      ++ServerStats.is_ref;
529 <    exit_client(source_p, &me, "Sorry, server is full - try later");
529 >    exit_client(source_p, "Sorry, server is full - try later");
530      return;
531    }
532  
533 <  /* valid user name check */
393 <  if (valid_username(source_p->username, 1) == 0)
533 >  if (!valid_username(source_p->username, 1))
534    {
535 <    char tmpstr2[IRCD_BUFSIZE];
535 >    char buf[IRCD_BUFSIZE] = "";
536  
537      sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
538                           "Invalid username: %s (%s@%s)",
539                           source_p->name, source_p->username, source_p->host);
540      ++ServerStats.is_ref;
541 <    snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
542 <             source_p->username);
403 <    exit_client(source_p, &me, tmpstr2);
541 >    snprintf(buf, sizeof(buf), "Invalid username [%s]", source_p->username);
542 >    exit_client(source_p, buf);
543      return;
544    }
545  
546    if (check_xline(source_p))
547      return;
548  
549 <  while (hash_find_id((id = uid_get())) != NULL)
549 >  while (hash_find_id((id = uid_get())))
550      ;
551  
552    strlcpy(source_p->id, id, sizeof(source_p->id));
# Line 421 | Line 560 | register_local_user(struct Client *sourc
560                         get_client_class(&source_p->localClient->confs),
561                         source_p->info, source_p->id);
562  
424  sendto_realops_flags(UMODE_CCONN_FULL, L_ALL, SEND_NOTICE,
425                       "CLICONN %s %s %s %s %s %s %s 0 %s",
426                       source_p->name, source_p->username, source_p->host,
427                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
428                       "255.255.255.255" : source_p->sockhost,
429                       get_client_class(&source_p->localClient->confs),
430                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
431                           "<hidden>" : source_p->localClient->client_host,
432                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
433                           "<hidden>" : source_p->localClient->client_server,
434                       source_p->info);
435
436
563    if (ConfigFileEntry.invisible_on_connect)
564    {
565      AddUMode(source_p, UMODE_INVISIBLE);
566      ++Count.invisi;
567    }
568  
569 <  if ((++Count.local) > Count.max_loc)
569 >  if (++Count.local > Count.max_loc)
570    {
571      Count.max_loc = Count.local;
572  
# Line 450 | Line 576 | register_local_user(struct Client *sourc
576                             Count.max_loc);
577    }
578  
453  /* Increment our total user count here */
579    if (++Count.total > Count.max_tot)
580      Count.max_tot = Count.total;
581    ++Count.totalrestartcount;
# Line 479 | Line 604 | register_local_user(struct Client *sourc
604   *              - username to register as
605   *              - host name to register as
606   *              - server name
482 *              - realname (gecos)
607   * output       - NONE
608   * side effects - This function is called when a remote client
609   *                is introduced by a server.
610   */
611   void
612 < register_remote_user(struct Client *source_p,
613 <                     const char *username, const char *host, const char *server,
490 <                     const char *realname)
612 > register_remote_user(struct Client *source_p, const char *username,
613 >                     const char *host, const char *server)
614   {
615    struct Client *target_p = NULL;
616  
494  assert(source_p != NULL);
617    assert(source_p->username != username);
618  
619 <  strlcpy(source_p->host, host, sizeof(source_p->host));
619 >  strlcpy(source_p->host, host, sizeof(source_p->host));
620    strlcpy(source_p->username, username, sizeof(source_p->username));
621  
622    /*
623 <   * coming from another server, take the servers word for it
623 >   * Coming from another server, take the servers word for it
624     */
625    source_p->servptr = hash_find_server(server);
626  
# Line 513 | Line 635 | register_remote_user(struct Client *sour
635                           "No server %s for user %s[%s@%s] from %s",
636                           server, source_p->name, source_p->username,
637                           source_p->host, source_p->from->name);
638 <    kill_client(source_p->from, source_p, "%s (Server doesn't exist)", me.name);
638 >    sendto_one(source_p->from,
639 >               ":%s KILL %s :%s (Ghosted, server %s doesn't exist)",
640 >               me.id, source_p->id, me.name, server);
641  
642      AddFlag(source_p, FLAGS_KILLED);
643 <    exit_client(source_p, &me, "Ghosted Client");
643 >    exit_client(source_p, "Ghosted Client");
644      return;
645    }
646  
# Line 527 | Line 651 | register_remote_user(struct Client *sour
651                           source_p->from->name, source_p->name, source_p->username,
652                           source_p->host, source_p->servptr->name,
653                           target_p->name, target_p->from->name);
654 <    kill_client(source_p->from, source_p,
655 <                "%s (NICK from wrong direction (%s != %s))",
656 <                me.name, source_p->servptr->name, target_p->from->name);
654 >    sendto_one(source_p->from,
655 >               ":%s KILL %s :%s (NICK from wrong direction (%s != %s))",
656 >               me.id, source_p->id, me.name, source_p->servptr->name,
657 >               target_p->from->name);
658 >
659      AddFlag(source_p, FLAGS_KILLED);
660 <    exit_client(source_p, &me, "USER server wrong direction");
660 >    exit_client(source_p, "USER server wrong direction");
661      return;
662    }
663  
# Line 542 | Line 668 | register_remote_user(struct Client *sour
668    if (HasFlag(source_p->servptr, FLAGS_SERVICE))
669      AddFlag(source_p, FLAGS_SERVICE);
670  
545  /* Increment our total user count here */
671    if (++Count.total > Count.max_tot)
672      Count.max_tot = Count.total;
673  
# Line 561 | Line 686 | register_remote_user(struct Client *sour
686    introduce_client(source_p);
687   }
688  
564 /* introduce_client()
565 *
566 * inputs       - source_p
567 * output       - NONE
568 * side effects - This common function introduces a client to the rest
569 *                of the net, either from a local client connect or
570 *                from a remote connect.
571 */
572 static void
573 introduce_client(struct Client *source_p)
574 {
575  dlink_node *server_node = NULL;
576  static char ubuf[12];
577
578  if (MyClient(source_p))
579    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
580  else
581    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
582
583  watch_check_hash(source_p, RPL_LOGON);
584
585  if (*ubuf == '\0')
586  {
587    ubuf[0] = '+';
588    ubuf[1] = '\0';
589  }
590
591  DLINK_FOREACH(server_node, serv_list.head)
592  {
593    struct Client *server = server_node->data;
594
595    if (server == source_p->from)
596        continue;
597
598    if (IsCapable(server, CAP_SVS))
599    {
600      if (IsCapable(server, CAP_TS6) && HasID(source_p))
601        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
602                   source_p->servptr->id,
603                   source_p->name, source_p->hopcount+1,
604                   (unsigned long)source_p->tsinfo,
605                   ubuf, source_p->username, source_p->host,
606                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
607                   "0" : source_p->sockhost, source_p->id,
608                   source_p->svid,
609                   source_p->info);
610      else
611        sendto_one(server, "NICK %s %d %lu %s %s %s %s %s :%s",
612                   source_p->name, source_p->hopcount+1,
613                   (unsigned long)source_p->tsinfo,
614                   ubuf, source_p->username, source_p->host,
615                   source_p->servptr->name, source_p->svid,
616                   source_p->info);
617
618    }
619    else
620    {
621      if (IsCapable(server, CAP_TS6) && HasID(source_p))
622        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
623                   source_p->servptr->id,
624                   source_p->name, source_p->hopcount+1,
625                   (unsigned long)source_p->tsinfo,
626                   ubuf, source_p->username, source_p->host,
627                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
628                   "0" : source_p->sockhost, source_p->id, source_p->info);
629      else
630        sendto_one(server, "NICK %s %d %lu %s %s %s %s :%s",
631                   source_p->name, source_p->hopcount+1,
632                   (unsigned long)source_p->tsinfo,
633                   ubuf, source_p->username, source_p->host,
634                   source_p->servptr->name, source_p->info);
635    }
636  }
637 }
638
689   /* valid_hostname()
690   *
691   * Inputs       - pointer to hostname
# Line 650 | Line 700 | valid_hostname(const char *hostname)
700   {
701    const char *p = hostname;
702  
703 <  assert(p != NULL);
703 >  assert(p);
704  
705 <  if (*p == '.' || *p == ':')
705 >  if (EmptyString(p) || *p == '.' || *p == ':')
706      return 0;
707  
708    for (; *p; ++p)
# Line 679 | Line 729 | valid_username(const char *username, con
729    int dots      = 0;
730    const char *p = username;
731  
732 <  assert(p != NULL);
732 >  assert(p);
733  
734    if (*p == '~')
735      ++p;
# Line 728 | Line 778 | int
778   valid_nickname(const char *nickname, const int local)
779   {
780    const char *p = nickname;
781 +
782    assert(nickname && *nickname);
783  
784 <  /* nicks can't start with a digit or - or be 0 length */
785 <  /* This closer duplicates behaviour of hybrid-6 */
784 >  /*
785 >   * Nicks can't start with a digit or - or be 0 length.
786 >   */
787    if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
788      return 0;
789  
# Line 742 | Line 794 | valid_nickname(const char *nickname, con
794    return p - nickname <= NICKLEN;
795   }
796  
745 /* report_and_set_user_flags()
746 *
747 * inputs       - pointer to source_p
748 *              - pointer to conf for this user
749 * output       - NONE
750 * side effects - Report to user any special flags
751 *                they are getting, and set them.
752 */
753 static void
754 report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
755 {
756  /* If this user is being spoofed, tell them so */
757  if (IsConfDoSpoofIp(conf))
758  {
759    sendto_one(source_p,
760               ":%s NOTICE %s :*** Spoofing your IP. Congrats.",
761               me.name, source_p->name);
762  }
763
764  /* If this user is in the exception class, Set it "E lined" */
765  if (IsConfExemptKline(conf))
766  {
767    SetExemptKline(source_p);
768    sendto_one(source_p,
769               ":%s NOTICE %s :*** You are exempt from K/D/G lines. Congrats.",
770               me.name, source_p->name);
771  }
772
773  /* The else here is to make sure that G line exempt users
774   * do not get noticed twice.
775   */
776  else if (IsConfExemptGline(conf))
777  {
778    SetExemptGline(source_p);
779    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from G lines. Congrats.",
780               me.name, source_p->name);
781  }
782
783  if (IsConfExemptResv(conf))
784  {
785    SetExemptResv(source_p);
786    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from resvs. Congrats.",
787               me.name, source_p->name);
788  }
789
790  /* If this user is exempt from user limits set it "F lined" */
791  if (IsConfExemptLimits(conf))
792  {
793    SetExemptLimits(source_p);
794    sendto_one(source_p,
795               ":%s NOTICE %s :*** You are exempt from user limits. Congrats.",
796               me.name,source_p->name);
797  }
798
799  if (IsConfCanFlood(conf))
800  {
801    SetCanFlood(source_p);
802    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from flood "
803               "protection, aren't you fearsome.",
804               me.name, source_p->name);
805  }
806 }
807
808 /* set_user_mode()
809 *
810 * added 15/10/91 By Darren Reed.
811 * parv[0] - sender
812 * parv[1] - username to change mode for
813 * parv[2] - modes to change
814 */
815 void
816 set_user_mode(struct Client *client_p, struct Client *source_p,
817              const int parc, char *parv[])
818 {
819  unsigned int flag, setflags;
820  char **p, *m, buf[IRCD_BUFSIZE];
821  struct Client *target_p;
822  int what = MODE_ADD, badflag = 0, i;
823
824  assert(!(parc < 2));
825
826  if ((target_p = find_person(client_p, parv[1])) == NULL)
827  {
828    if (MyConnect(source_p))
829      sendto_one(source_p, form_str(ERR_NOSUCHCHANNEL),
830                 me.name, source_p->name, parv[1]);
831    return;
832  }
833
834  if (source_p != target_p)
835  {
836     sendto_one(source_p, form_str(ERR_USERSDONTMATCH),
837                me.name, source_p->name);
838     return;
839  }
840
841  if (parc < 3)
842  {
843    m = buf;
844    *m++ = '+';
845
846    for (i = 0; i < 128; i++)
847      if (HasUMode(source_p, user_modes[i]))
848        *m++ = (char)i;
849    *m = '\0';
850
851    sendto_one(source_p, form_str(RPL_UMODEIS),
852               me.name, source_p->name, buf);
853    return;
854  }
855
856  /* find flags already set for user */
857  setflags = source_p->umodes;
858
859  /* parse mode change string(s) */
860  for (p = &parv[2]; p && *p; p++)
861  {
862    for (m = *p; *m; m++)
863    {
864      switch (*m)
865      {
866        case '+':
867          what = MODE_ADD;
868          break;
869        case '-':
870          what = MODE_DEL;
871          break;
872        case 'o':
873          if (what == MODE_ADD)
874          {
875            if (IsServer(client_p) && !HasUMode(source_p, UMODE_OPER))
876            {
877              ++Count.oper;
878              SetOper(source_p);
879            }
880          }
881          else
882          {
883            /* Only decrement the oper counts if an oper to begin with
884             * found by Pat Szuta, Perly , perly@xnet.com
885             */
886            if (!HasUMode(source_p, UMODE_OPER))
887              break;
888
889            ClearOper(source_p);
890            Count.oper--;
891
892            if (MyConnect(source_p))
893            {
894              dlink_node *dm;
895
896              detach_conf(source_p, CONF_OPER);
897              ClrOFlag(source_p);
898              DelUMode(source_p, ConfigFileEntry.oper_only_umodes);
899
900              if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
901                free_dlink_node(dm);
902            }
903          }
904
905          break;
906
907        case 'r':  /* Only services may set +r */
908          break;
909
910        default:
911          if ((flag = user_modes[(unsigned char)*m]))
912          {
913            if (MyConnect(source_p) && !HasUMode(source_p, UMODE_OPER) &&
914                (ConfigFileEntry.oper_only_umodes & flag))
915              badflag = 1;
916            else
917            {
918              if (what == MODE_ADD)
919                AddUMode(source_p, flag);
920              else
921                DelUMode(source_p, flag);
922            }
923          }
924          else
925          {
926            if (MyConnect(source_p))
927              badflag = 1;
928          }
929
930          break;
931      }
932    }
933  }
934
935  if (badflag)
936    sendto_one(source_p, form_str(ERR_UMODEUNKNOWNFLAG),
937               me.name, source_p->name);
938
939  if (MyConnect(source_p) && HasUMode(source_p, UMODE_ADMIN) &&
940      !HasOFlag(source_p, OPER_FLAG_ADMIN))
941  {
942    sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
943               me.name, source_p->name);
944    DelUMode(source_p, UMODE_ADMIN);
945  }
946
947  if (!(setflags & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
948    ++Count.invisi;
949  if ((setflags & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
950    --Count.invisi;
951
952  /*
953   * compare new flags with old flags and send string which
954   * will cause servers to update correctly.
955   */
956  send_umode_out(client_p, source_p, setflags);
957 }
958
797   /* send_umode()
798   * send the MODE string for user (user) to connection client_p
799   * -avalon
# Line 973 | Line 811 | send_umode(struct Client *client_p, stru
811   {
812    char *m = umode_buf;
813    int what = 0;
976  unsigned int i;
977  unsigned int flag;
814  
815    /*
816 <   * build a string in umode_buf to represent the change in the user's
816 >   * Build a string in umode_buf to represent the change in the user's
817     * mode between the new (source_p->umodes) and 'old'.
818     */
819 <  for (i = 0; i < 128; i++)
819 >  for (unsigned int i = 0; i < 128; ++i)
820    {
821 <    flag = user_modes[i];
821 >    unsigned int flag = user_modes[i];
822 >
823      if (!flag)
824        continue;
825  
# Line 1031 | Line 868 | void
868   send_umode_out(struct Client *client_p, struct Client *source_p,
869                 unsigned int old)
870   {
871 <  char buf[IRCD_BUFSIZE] = { '\0' };
1035 <  dlink_node *ptr = NULL;
871 >  char buf[IRCD_BUFSIZE] = "";
872  
873    send_umode(NULL, source_p, old, SEND_UMODES, buf);
874  
875    if (buf[0])
876 <  {
877 <    DLINK_FOREACH(ptr, serv_list.head)
1042 <    {
1043 <      struct Client *target_p = ptr->data;
1044 <
1045 <      if ((target_p != client_p) && (target_p != source_p))
1046 <        sendto_one(target_p, ":%s MODE %s :%s",
1047 <                   ID_or_name(source_p, target_p),
1048 <                   ID_or_name(source_p, target_p), buf);
1049 <    }
1050 <  }
876 >    sendto_server(source_p, NOCAPS, NOCAPS, ":%s MODE %s :%s",
877 >                  source_p->id, source_p->id, buf);
878  
879    if (client_p && MyClient(client_p))
880      send_umode(client_p, source_p, old, 0xffffffff, buf);
881   }
882  
883   void
884 < user_set_hostmask(struct Client *target_p, const char *hostname)
884 > user_set_hostmask(struct Client *target_p, const char *hostname, const int what)
885   {
886 <  if (!valid_hostname(hostname))
886 >  dlink_node *ptr = NULL;
887 >
888 >  if (!strcmp(target_p->host, hostname))
889      return;
890  
891 +  switch (what)
892 +  {
893 +    case MODE_ADD:
894 +      AddUMode(target_p, UMODE_HIDDENHOST);
895 +      AddFlag(target_p, FLAGS_IP_SPOOFING);
896 +      break;
897 +    case MODE_DEL:
898 +      DelUMode(target_p, UMODE_HIDDENHOST);
899 +
900 +      if (!HasFlag(target_p, FLAGS_AUTH_SPOOF))
901 +        DelFlag(target_p, FLAGS_IP_SPOOFING);
902 +      break;
903 +    default: return;
904 +  }
905 +
906 +  if (ConfigFileEntry.cycle_on_host_change)
907 +    sendto_common_channels_local(target_p, 0, 0, ":%s!%s@%s QUIT :Changing hostname",
908 +                                 target_p->name, target_p->username, target_p->host);
909 +
910    if (IsUserHostIp(target_p))
911      delete_user_host(target_p->username, target_p->host, !MyConnect(target_p));
912  
913    strlcpy(target_p->host, hostname, sizeof(target_p->host));
1066  SetIPSpoof(target_p);
914  
915    add_user_host(target_p->username, target_p->host, !MyConnect(target_p));
916    SetUserHost(target_p);
917  
918    if (MyClient(target_p))
919 +  {
920 +    sendto_one_numeric(target_p, &me, RPL_NEWHOSTIS, target_p->host);
921      clear_ban_cache_client(target_p);
922 < }
1074 <
1075 < /* user_welcome()
1076 < *
1077 < * inputs       - client pointer to client to welcome
1078 < * output       - NONE
1079 < * side effects -
1080 < */
1081 < static void
1082 < user_welcome(struct Client *source_p)
1083 < {
1084 < #if defined(__TIME__) && defined(__DATE__)
1085 <  static const char built_date[] = __DATE__ " at " __TIME__;
1086 < #else
1087 <  static const char built_date[] = "unknown";
1088 < #endif
1089 <
1090 < #ifdef HAVE_LIBCRYPTO
1091 <  if (source_p->localClient->fd.ssl != NULL)
1092 <    sendto_one(source_p, ":%s NOTICE %s :*** Connected securely via %s",
1093 <               me.name, source_p->name,
1094 <               ssl_get_cipher(source_p->localClient->fd.ssl));
1095 < #endif
1096 <
1097 <  sendto_one(source_p, form_str(RPL_WELCOME), me.name, source_p->name,
1098 <             ServerInfo.network_name, source_p->name);
1099 <  sendto_one(source_p, form_str(RPL_YOURHOST), me.name, source_p->name,
1100 <             get_listener_name(source_p->localClient->listener), ircd_version);
1101 <  sendto_one(source_p, form_str(RPL_CREATED),
1102 <             me.name, source_p->name, built_date);
1103 <  sendto_one(source_p, form_str(RPL_MYINFO),
1104 <             me.name, source_p->name, me.name, ircd_version, umode_buffer);
1105 <  show_isupport(source_p);
1106 <
1107 <  if (source_p->id[0] != '\0')
1108 <    sendto_one(source_p, form_str(RPL_YOURID), me.name,
1109 <               source_p->name, source_p->id);
922 >  }
923  
924 <  show_lusers(source_p);
924 >  if (!ConfigFileEntry.cycle_on_host_change)
925 >    return;
926  
927 <  if (ConfigFileEntry.short_motd)
927 >  DLINK_FOREACH(ptr, target_p->channel.head)
928    {
929 <    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- motd was last changed at %s",
930 <               me.name, source_p->name, ConfigFileEntry.motd.lastChangedDate);
931 <    sendto_one(source_p,
932 <               ":%s NOTICE %s :*** Notice -- Please read the motd if you haven't "
1119 <               "read it", me.name, source_p->name);
1120 <    sendto_one(source_p, form_str(RPL_MOTDSTART),
1121 <               me.name, source_p->name, me.name);
1122 <    sendto_one(source_p, form_str(RPL_MOTD),
1123 <               me.name, source_p->name,
1124 <               "*** This is the short motd ***");
1125 <    sendto_one(source_p, form_str(RPL_ENDOFMOTD),
1126 <               me.name, source_p->name);
1127 <  }
1128 <  else  
1129 <    send_message_file(source_p, &ConfigFileEntry.motd);
1130 < }
929 >    char modebuf[4], nickbuf[NICKLEN * 3 + 3] = "";
930 >    char *p = modebuf;
931 >    int len = 0;
932 >    const struct Membership *ms = ptr->data;
933  
934 < /* check_xline()
935 < *
936 < * inputs       - pointer to client to test
937 < * outupt       - 1 if exiting 0 if ok
938 < * side effects -
1137 < */
1138 < static int
1139 < check_xline(struct Client *source_p)
1140 < {
1141 <  struct MaskItem *conf = NULL;
1142 <  const char *reason = NULL;
934 >    if (has_member_flags(ms, CHFL_CHANOP))
935 >    {
936 >      *p++ = 'o';
937 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
938 >    }
939  
940 <  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
941 <  {
942 <    ++conf->count;
940 >    if (has_member_flags(ms, CHFL_HALFOP))
941 >    {
942 >      *p++ = 'h';
943 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
944 >    }
945  
946 <    if (conf->reason != NULL)
947 <      reason = conf->reason;
948 <    else
949 <      reason = "No Reason";
946 >    if (has_member_flags(ms, CHFL_VOICE))
947 >    {
948 >      *p++ = 'v';
949 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
950 >    }
951  
952 <    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
1154 <                         "X-line Rejecting [%s] [%s], user %s [%s]",
1155 <                         source_p->info, reason,
1156 <                         get_client_name(source_p, HIDE_IP),
1157 <                         source_p->sockhost);
952 >    *p = '\0';
953  
954 <    ++ServerStats.is_ref;
955 <    exit_client(source_p, &me, "Bad user info");
956 <    return 1;
957 <  }
954 >    sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s!%s@%s JOIN :%s",
955 >                                target_p->name, target_p->username, target_p->host,
956 >                                ms->chptr->chname);
957 >    if (nickbuf[0])
958 >      sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s MODE %s +%s %s",
959 >                                  target_p->servptr->name, ms->chptr->chname,
960 >                                  modebuf, nickbuf);
961  
962 <  return 0;
1165 < }
962 >  }
963  
964 < /* oper_up()
965 < *
966 < * inputs       - pointer to given client to oper
967 < * output       - NONE
968 < * side effects - Blindly opers up given source_p, using conf info
969 < *                all checks on passwords have already been done.
970 < *                This could also be used by rsa oper routines.
964 >  if (target_p->away[0])
965 >    sendto_common_channels_local(target_p, 0, CAP_AWAY_NOTIFY,
966 >                                 ":%s!%s@%s AWAY :%s",
967 >                                 target_p->name, target_p->username,
968 >                                 target_p->host, target_p->away);
969 > }
970 >
971 > /*! \brief Blindly opers up given source_p, using conf info.
972 > *         All checks on passwords have already been done.
973 > * \param source_p Pointer to given client to oper
974   */
975   void
976   oper_up(struct Client *source_p)
# Line 1204 | Line 1004 | oper_up(struct Client *source_p)
1004    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
1005                         get_oper_name(source_p));
1006    send_umode_out(source_p, source_p, old);
1007 <  sendto_one(source_p, form_str(RPL_YOUREOPER), me.name, source_p->name);
1007 >  sendto_one_numeric(source_p, &me, RPL_YOUREOPER);
1008   }
1009  
1010 < static char new_uid[TOTALSIDUID + 1];     /* allow for \0 */
1010 > static char new_uid[TOTALSIDUID + 1];  /* Allow for \0 */
1011  
1012   int
1013   valid_sid(const char *sid)
# Line 1222 | Line 1022 | valid_sid(const char *sid)
1022  
1023   /*
1024   * init_uid()
1025 < *
1025 > *
1026   * inputs       - NONE
1027   * output       - NONE
1028   * side effects - new_uid is filled in with server id portion (sid)
# Line 1232 | Line 1032 | valid_sid(const char *sid)
1032   void
1033   init_uid(void)
1034   {
1235  unsigned int i;
1236
1035    memset(new_uid, 0, sizeof(new_uid));
1036  
1037    if (!EmptyString(ServerInfo.sid))
1038      strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1039  
1040 <  for (i = 0; i < IRC_MAXSID; ++i)
1041 <    if (new_uid[i] == '\0')
1040 >  for (unsigned int i = 0; i < IRC_MAXSID; ++i)
1041 >    if (new_uid[i] == '\0')
1042        new_uid[i] = 'A';
1043  
1044    /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1247  /* Yes nenolod, I have known it was off by one ever since I wrote it
1248   * But *JUST* for you, though, it really doesn't look as *pretty*
1249   * -Dianora
1250   */
1045    memcpy(new_uid + IRC_MAXSID, "AAAAA@", IRC_MAXUID);
1046   }
1047  
# Line 1262 | Line 1056 | init_uid(void)
1056   static void
1057   add_one_to_uid(int i)
1058   {
1059 <  if (i != IRC_MAXSID)    /* Not reached server SID portion yet? */
1059 >  if (i != IRC_MAXSID)  /* Not reached server SID portion yet? */
1060    {
1061      if (new_uid[i] == 'Z')
1062        new_uid[i] = '0';
# Line 1294 | Line 1088 | add_one_to_uid(int i)
1088   static const char *
1089   uid_get(void)
1090   {
1091 <  add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1091 >  add_one_to_uid(TOTALSIDUID - 1);  /* Index from 0 */
1092    return new_uid;
1093   }
1094  
# Line 1308 | Line 1102 | uid_get(void)
1102   void
1103   init_isupport(void)
1104   {
1311  isupportFile = init_MessageLine();
1312
1105    add_isupport("CALLERID", NULL, -1);
1106    add_isupport("CASEMAPPING", CASEMAP, -1);
1107    add_isupport("DEAF", "D", -1);
# Line 1322 | Line 1114 | init_isupport(void)
1114    add_isupport("PREFIX", "(ov)@+", -1);
1115    add_isupport("STATUSMSG", "@+", -1);
1116   #endif
1117 +  add_isupport("EXCEPTS", "e", -1);
1118 +  add_isupport("INVEX", "I", -1);
1119   }
1120  
1121   /*
# Line 1352 | Line 1146 | add_isupport(const char *name, const cha
1146  
1147    if (ptr == NULL)
1148    {
1149 <    support = MyMalloc(sizeof(*support));
1149 >    support = MyCalloc(sizeof(*support));
1150      dlinkAddTail(support, &support->node, &support_list);
1151    }
1152  
1153    support->name = xstrdup(name);
1154 <  if (options != NULL)
1154 >  if (options)
1155      support->options = xstrdup(options);
1156    support->number = n;
1157  
# Line 1405 | Line 1199 | rebuild_isupport_message_line(void)
1199   {
1200    char isupportbuffer[IRCD_BUFSIZE];
1201    char *p = isupportbuffer;
1202 <  dlink_node *ptr = NULL;
1202 >  dlink_node *ptr = NULL, *ptr_next = NULL;
1203    int n = 0;
1204    int tokens = 0;
1205    size_t len = 0;
1206 <  size_t reserve = strlen(me.name) + HOSTLEN + strlen(form_str(RPL_ISUPPORT));
1206 >  size_t reserve = strlen(me.name) + HOSTLEN + strlen(numeric_form(RPL_ISUPPORT));
1207  
1208 <  destroy_MessageLine(isupportFile);
1208 >  DLINK_FOREACH_SAFE(ptr, ptr_next, support_list_lines.head)
1209 >  {
1210 >    dlinkDelete(ptr, &support_list_lines);
1211 >    MyFree(ptr->data);
1212 >    free_dlink_node(ptr);
1213 >  }
1214  
1215    DLINK_FOREACH(ptr, support_list.head)
1216    {
# Line 1420 | Line 1219 | rebuild_isupport_message_line(void)
1219      p += (n = sprintf(p, "%s", support->name));
1220      len += n;
1221  
1222 <    if (support->options != NULL)
1222 >    if (support->options)
1223      {
1224        p += (n = sprintf(p, "=%s", support->options));
1225        len += n;
# Line 1441 | Line 1240 | rebuild_isupport_message_line(void)
1240        if (*--p == ' ')
1241          *p = '\0';
1242  
1243 <      addto_MessageLine(isupportFile, isupportbuffer);
1243 >      dlinkAddTail(xstrdup(isupportbuffer), make_dlink_node(), &support_list_lines);
1244        p = isupportbuffer;
1245        len = 0;
1246        n = tokens = 0;
1247      }
1248    }
1249  
1250 <  if (len != 0)
1250 >  if (len)
1251    {
1252      if (*--p == ' ')
1253        *p = '\0';
1254 <    addto_MessageLine(isupportFile, isupportbuffer);
1254 >    dlinkAddTail(xstrdup(isupportbuffer), make_dlink_node(), &support_list_lines);
1255    }
1256   }

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)