ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_user.c (file contents), Revision 3176 by michael, Tue Mar 18 20:00:16 2014 UTC vs.
ircd-hybrid/trunk/src/user.c (file contents), Revision 4967 by michael, Mon Dec 1 14:34:29 2014 UTC

# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
# Line 26 | Line 26
26  
27   #include "stdinc.h"
28   #include "list.h"
29 < #include "s_user.h"
30 < #include "s_misc.h"
29 > #include "user.h"
30   #include "channel.h"
31   #include "channel_mode.h"
32   #include "client.h"
# Line 39 | Line 38
38   #include "numeric.h"
39   #include "conf.h"
40   #include "log.h"
41 < #include "s_serv.h"
41 > #include "server.h"
42   #include "send.h"
44 #include "supported.h"
43   #include "memory.h"
44   #include "packet.h"
45   #include "rng_mt.h"
46   #include "userhost.h"
47 < #include "s_misc.h"
47 > #include "misc.h"
48   #include "parse.h"
49   #include "watch.h"
50  
51   static char umode_buffer[IRCD_BUFSIZE];
54
55 static void user_welcome(struct Client *);
56 static void report_and_set_user_flags(struct Client *, const struct MaskItem *);
57 static int check_xline(struct Client *);
58 static void introduce_client(struct Client *);
52   static const char *uid_get(void);
53  
54   /* Used for building up the isupport string,
55   * used with init_isupport, add_isupport, delete_isupport
56   */
64
57   struct Isupport
58   {
59    dlink_node node;
# Line 124 | Line 116 | const unsigned int user_modes[256] =
116    0,                  /* m */
117    UMODE_NCHANGE,      /* n */
118    UMODE_OPER,         /* o */
119 <  0,                  /* p */
120 <  0,                  /* q */
119 >  UMODE_HIDECHANS,    /* p */
120 >  UMODE_HIDEIDLE,     /* q */
121    UMODE_REGISTERED,   /* r */
122    UMODE_SERVNOTICE,   /* s */
123    0,                  /* t */
# Line 134 | Line 126 | const unsigned int user_modes[256] =
126    UMODE_WALLOP,       /* w */
127    UMODE_HIDDENHOST,   /* x */
128    UMODE_SPY,          /* y */
129 <  UMODE_OPERWALL,     /* z      0x7A */
129 >  0,                  /* z      0x7A */
130    0,0,0,0,0,          /* 0x7B - 0x7F */
131  
132    /* 0x80 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x8F */
# Line 170 | Line 162 | void
162   show_lusers(struct Client *source_p)
163   {
164    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
165 <    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total-Count.invisi),
166 <                       Count.invisi, dlink_list_length(&global_serv_list));
165 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
166 >                       Count.invisi, dlink_list_length(&global_server_list));
167    else
168 <    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT,
169 <                       (Count.total-Count.invisi), Count.invisi, 1);
168 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
169 >                       Count.invisi, 1);
170  
171 <  if (Count.oper > 0)
171 >  if (Count.oper)
172      sendto_one_numeric(source_p, &me, RPL_LUSEROP, Count.oper);
173  
174 <  if (dlink_list_length(&unknown_list) > 0)
174 >  if (dlink_list_length(&unknown_list))
175      sendto_one_numeric(source_p, &me, RPL_LUSERUNKNOWN, dlink_list_length(&unknown_list));
176  
177 <  if (dlink_list_length(&global_channel_list) > 0)
178 <    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&global_channel_list));
177 >  if (dlink_list_length(&channel_list))
178 >    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&channel_list));
179  
180    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
181    {
# Line 218 | Line 210 | show_lusers(struct Client *source_p)
210   void
211   show_isupport(struct Client *source_p)
212   {
213 <  const dlink_node *ptr = NULL;
213 >  const dlink_node *node = NULL;
214  
215 <  DLINK_FOREACH(ptr, support_list_lines.head)
216 <    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, ptr->data);
215 >  DLINK_FOREACH(node, support_list_lines.head)
216 >    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, node->data);
217   }
218  
219 < /*
220 < ** register_local_user
221 < **      This function is called when both NICK and USER messages
222 < **      have been accepted for the client, in whatever order. Only
223 < **      after this, is the USER message propagated.
224 < **
225 < **      NICK's must be propagated at once when received, although
226 < **      it would be better to delay them too until full info is
227 < **      available. Doing it is not so simple though, would have
228 < **      to implement the following:
229 < **
230 < **      (actually it has been implemented already for a while) -orabidoo
231 < **
232 < **      1) user telnets in and gives only "NICK foobar" and waits
233 < **      2) another user far away logs in normally with the nick
234 < **         "foobar" (quite legal, as this server didn't propagate
235 < **         it).
236 < **      3) now this server gets nick "foobar" from outside, but
237 < **         has alread the same defined locally. Current server
238 < **         would just issue "KILL foobar" to clean out dups. But,
239 < **         this is not fair. It should actually request another
240 < **         nick from local user or kill him/her...
241 < */
219 >
220 > /* report_and_set_user_flags()
221 > *
222 > * inputs       - pointer to source_p
223 > *              - pointer to conf for this user
224 > * output       - NONE
225 > * side effects - Report to user any special flags
226 > *                they are getting, and set them.
227 > */
228 > static void
229 > report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
230 > {
231 >  /* If this user is being spoofed, tell them so */
232 >  if (IsConfDoSpoofIp(conf))
233 >    sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
234 >
235 >  /* If this user is in the exception class, set it "E lined" */
236 >  if (IsConfExemptKline(conf))
237 >  {
238 >    SetExemptKline(source_p);
239 >    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D/G lines. Congrats.");
240 >  }
241 >
242 >  /*
243 >   * The else here is to make sure that G line exempt users
244 >   * do not get noticed twice.
245 >   */
246 >  else if (IsConfExemptGline(conf))
247 >  {
248 >    SetExemptGline(source_p);
249 >    sendto_one_notice(source_p, &me, ":*** You are exempt from G lines. Congrats.");
250 >  }
251 >
252 >  if (IsConfExemptResv(conf))
253 >  {
254 >    SetExemptResv(source_p);
255 >    sendto_one_notice(source_p, &me, ":*** You are exempt from resvs. Congrats.");
256 >  }
257 >
258 >  /* If this user is exempt from user limits set it "F lined" */
259 >  if (IsConfExemptLimits(conf))
260 >  {
261 >    SetExemptLimits(source_p);
262 >    sendto_one_notice(source_p, &me, ":*** You are exempt from user limits. Congrats.");
263 >  }
264 >
265 >  if (IsConfCanFlood(conf))
266 >  {
267 >    SetCanFlood(source_p);
268 >    sendto_one_notice(source_p, &me, ":*** You are exempt from flood "
269 >                      "protection, aren't you fearsome.");
270 >  }
271 > }
272 >
273 > /* introduce_client()
274 > *
275 > * inputs       - source_p
276 > * output       - NONE
277 > * side effects - This common function introduces a client to the rest
278 > *                of the net, either from a local client connect or
279 > *                from a remote connect.
280 > */
281 > static void
282 > introduce_client(struct Client *source_p)
283 > {
284 >  dlink_node *node = NULL;
285 >  char ubuf[IRCD_BUFSIZE] = "";
286 >
287 >  if (MyClient(source_p))
288 >    send_umode(source_p, source_p, 0, ubuf);
289 >  else
290 >    send_umode(NULL, source_p, 0, ubuf);
291 >
292 >  watch_check_hash(source_p, RPL_LOGON);
293 >
294 >  if (ubuf[0] == '\0')
295 >  {
296 >    ubuf[0] = '+';
297 >    ubuf[1] = '\0';
298 >  }
299 >
300 >  DLINK_FOREACH(node, local_server_list.head)
301 >  {
302 >    struct Client *server = node->data;
303 >
304 >    if (server == source_p->from)
305 >      continue;
306 >
307 >    if (IsCapable(server, CAP_SVS))
308 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
309 >                 source_p->servptr->id,
310 >                 source_p->name, source_p->hopcount+1,
311 >                 (unsigned long)source_p->tsinfo,
312 >                 ubuf, source_p->username, source_p->host,
313 >                 source_p->sockhost, source_p->id,
314 >                 source_p->account,
315 >                 source_p->info);
316 >    else
317 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
318 >                 source_p->servptr->id,
319 >                 source_p->name, source_p->hopcount+1,
320 >                 (unsigned long)source_p->tsinfo,
321 >                 ubuf, source_p->username, source_p->host,
322 >                 source_p->sockhost, source_p->id, source_p->info);
323 >
324 >    if (!EmptyString(source_p->certfp))
325 >      sendto_one(server, ":%s CERTFP %s", source_p->id, source_p->certfp);
326 >  }
327 > }
328 >
329 > /* user_welcome()
330 > *
331 > * inputs       - client pointer to client to welcome
332 > * output       - NONE
333 > * side effects -
334 > */
335 > static void
336 > user_welcome(struct Client *source_p)
337 > {
338 > #if defined(__TIME__) && defined(__DATE__)
339 >  static const char built_date[] = __DATE__ " at " __TIME__;
340 > #else
341 >  static const char built_date[] = "unknown";
342 > #endif
343 >
344 > #ifdef HAVE_LIBCRYPTO
345 >  if (HasFlag(source_p, FLAGS_SSL))
346 >  {
347 >    AddUMode(source_p, UMODE_SSL);
348 >    sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
349 >                      ssl_get_cipher(source_p->connection->fd.ssl));
350 >  }
351 > #endif
352 >
353 >  sendto_one_numeric(source_p, &me, RPL_WELCOME, ConfigServerInfo.network_name,
354 >                     source_p->name);
355 >  sendto_one_numeric(source_p, &me, RPL_YOURHOST,
356 >                     get_listener_name(source_p->connection->listener), ircd_version);
357 >  sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
358 >  sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
359 >  show_isupport(source_p);
360 >  sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
361 >
362 >  show_lusers(source_p);
363 >  motd_signon(source_p);
364 > }
365 >
366 > /* check_xline()
367 > *
368 > * inputs       - pointer to client to test
369 > * outupt       - 1 if exiting 0 if ok
370 > * side effects -
371 > */
372 > static int
373 > check_xline(struct Client *source_p)
374 > {
375 >  struct MaskItem *conf = NULL;
376 >
377 >  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
378 >  {
379 >    ++conf->count;
380 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
381 >                         "X-line Rejecting [%s] [%s], user %s [%s]",
382 >                         source_p->info, conf->reason,
383 >                         get_client_name(source_p, HIDE_IP),
384 >                         source_p->sockhost);
385 >
386 >    ++ServerStats.is_ref;
387 >    exit_client(source_p, "Bad user info");
388 >    return 1;
389 >  }
390 >
391 >  return 0;
392 > }
393 >
394 > /*! \brief This function is called when both NICK and USER messages
395 > *      have been accepted for the client, in whatever order. Only
396 > *      after this, is the UID message propagated.
397 > * \param source_p Pointer to given client to introduce
398 > */
399   void
400   register_local_user(struct Client *source_p)
401   {
402    const char *id = NULL;
403    const struct MaskItem *conf = NULL;
404  
256  assert(source_p != NULL);
405    assert(source_p == source_p->from);
406    assert(MyConnect(source_p));
407 <  assert(!source_p->localClient->registration);
407 >  assert(!source_p->connection->registration);
408  
409    ClearCap(source_p, CAP_TS6);
410  
411 <  if (ConfigFileEntry.ping_cookie)
411 >  if (ConfigGeneral.ping_cookie)
412    {
413 <    if (!IsPingSent(source_p) && !source_p->localClient->random_ping)
413 >    if (!IsPingSent(source_p) && !source_p->connection->random_ping)
414      {
415        do
416 <        source_p->localClient->random_ping = genrand_int32();
417 <      while (!source_p->localClient->random_ping);
416 >        source_p->connection->random_ping = genrand_int32();
417 >      while (!source_p->connection->random_ping);
418  
419 <      sendto_one(source_p, "PING :%u",
272 <                 source_p->localClient->random_ping);
419 >      sendto_one(source_p, "PING :%u", source_p->connection->random_ping);
420        SetPingSent(source_p);
421        return;
422      }
# Line 278 | Line 425 | register_local_user(struct Client *sourc
425        return;
426    }
427  
428 <  source_p->localClient->last_privmsg = CurrentTime;
428 >  source_p->connection->last_privmsg = CurrentTime;
429    /* Straight up the maximum rate of flooding... */
430 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
430 >  source_p->connection->allow_read = MAX_FLOOD_BURST;
431  
432    if (!check_client(source_p))
433      return;
# Line 289 | Line 436 | register_local_user(struct Client *sourc
436    {
437      sendto_one_notice(source_p, &me, ":*** Notice -- You have an illegal "
438                        "character in your hostname");
439 <    strlcpy(source_p->host, source_p->sockhost,
293 <            sizeof(source_p->host));
439 >    strlcpy(source_p->host, source_p->sockhost, sizeof(source_p->host));
440    }
441  
442 <  conf = source_p->localClient->confs.head->data;
442 >  conf = source_p->connection->confs.head->data;
443  
444    if (!IsGotId(source_p))
445    {
446 <    char username[USERLEN + 1];
446 >    char username[USERLEN + 1] = "";
447      const char *p = username;
448      unsigned int i = 0;
449  
# Line 316 | Line 462 | register_local_user(struct Client *sourc
462        source_p->username[i++] = '~';
463  
464      for (; *p && i < USERLEN; ++p)
465 <      if (*p != '[')
320 <        source_p->username[i++] = *p;
465 >      source_p->username[i++] = *p;
466  
467      source_p->username[i] = '\0';
468    }
469  
470 <  /* password check */
470 >  /* Password check */
471    if (!EmptyString(conf->passwd))
472    {
473 <    const char *pass = source_p->localClient->passwd;
329 <
330 <    if (!match_conf_password(pass, conf))
473 >    if (!match_conf_password(source_p->connection->password, conf))
474      {
475        ++ServerStats.is_ref;
476  
# Line 337 | Line 480 | register_local_user(struct Client *sourc
480      }
481    }
482  
483 <  /* don't free source_p->localClient->passwd here - it can be required
484 <   * by masked /stats I if there are auth{} blocks with need_password = no;
483 >  /*
484 >   * Don't free source_p->connection->password here - it can be required
485 >   * by masked /stats I if there are auth {} blocks with need_password = no;
486     * --adx
487     */
488  
489 <  /* report if user has &^>= etc. and set flags as needed in source_p */
489 >  /*
490 >   * Report if user has &^>= etc. and set flags as needed in source_p
491 >   */
492    report_and_set_user_flags(source_p, conf);
493  
494    if (IsDead(source_p))
495      return;
496  
497 <  /* Limit clients -
497 >  /*
498 >   * Limit clients -
499     * We want to be able to have servers and F-line clients
500     * connect, so save room for "buffer" connections.
501     * Smaller servers may want to decrease this, and it should
502     * probably be just a percentage of the MAXCLIENTS...
503     *   -Taner
504     */
505 <  /* Except "F:" clients */
506 <  if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
360 <      (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
505 >  if ((Count.local >= ConfigServerInfo.max_clients + MAX_BUFFER) ||
506 >      (Count.local >= ConfigServerInfo.max_clients && !IsExemptLimits(source_p)))
507    {
508      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
509                           "Too many clients, rejecting %s[%s].",
# Line 367 | Line 513 | register_local_user(struct Client *sourc
513      return;
514    }
515  
370  /* valid user name check */
516    if (!valid_username(source_p->username, 1))
517    {
518 <    char tmpstr2[IRCD_BUFSIZE];
518 >    char buf[IRCD_BUFSIZE] = "";
519  
520      sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
521                           "Invalid username: %s (%s@%s)",
522                           source_p->name, source_p->username, source_p->host);
523      ++ServerStats.is_ref;
524 <    snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
525 <             source_p->username);
381 <    exit_client(source_p, tmpstr2);
524 >    snprintf(buf, sizeof(buf), "Invalid username [%s]", source_p->username);
525 >    exit_client(source_p, buf);
526      return;
527    }
528  
529    if (check_xline(source_p))
530      return;
531  
532 <  while (hash_find_id((id = uid_get())) != NULL)
532 >  while (hash_find_id((id = uid_get())))
533      ;
534  
535    strlcpy(source_p->id, id, sizeof(source_p->id));
# Line 394 | Line 538 | register_local_user(struct Client *sourc
538    sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
539                         "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
540                         source_p->name, source_p->username, source_p->host,
541 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
542 <                       "255.255.255.255" : source_p->sockhost,
399 <                       get_client_class(&source_p->localClient->confs),
541 >                       source_p->sockhost,
542 >                       get_client_class(&source_p->connection->confs),
543                         source_p->info, source_p->id);
544  
545 <  if (ConfigFileEntry.invisible_on_connect)
545 >  if (ConfigGeneral.invisible_on_connect)
546    {
547      AddUMode(source_p, UMODE_INVISIBLE);
548      ++Count.invisi;
# Line 411 | Line 554 | register_local_user(struct Client *sourc
554  
555      if (!(Count.max_loc % 10))
556        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
557 <                           "New Max Local Clients: %d",
557 >                           "New maximum local client connections: %u",
558                             Count.max_loc);
559    }
560  
418  /* Increment our total user count here */
561    if (++Count.total > Count.max_tot)
562      Count.max_tot = Count.total;
563    ++Count.totalrestartcount;
# Line 423 | Line 565 | register_local_user(struct Client *sourc
565    assert(source_p->servptr == &me);
566    SetClient(source_p);
567    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
568 <
427 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
568 >  dlinkAdd(source_p, &source_p->node, &global_client_list);
569  
570    assert(dlinkFind(&unknown_list, source_p));
571  
572 <  dlink_move_node(&source_p->localClient->lclient_node,
572 >  dlink_move_node(&source_p->connection->lclient_node,
573                    &unknown_list, &local_client_list);
574  
575    user_welcome(source_p);
# Line 449 | Line 590 | register_local_user(struct Client *sourc
590   *                is introduced by a server.
591   */
592   void
593 < register_remote_user(struct Client *source_p, const char *username,
453 <                     const char *host, const char *server)
593 > register_remote_user(struct Client *source_p)
594   {
595 <  struct Client *target_p = NULL;
456 <
457 <  assert(source_p != NULL);
458 <  assert(source_p->username != username);
459 <
460 <  strlcpy(source_p->host, host, sizeof(source_p->host));
461 <  strlcpy(source_p->username, username, sizeof(source_p->username));
462 <
463 <  /*
464 <   * coming from another server, take the servers word for it
465 <   */
466 <  source_p->servptr = hash_find_server(server);
467 <
468 <  /*
469 <   * Super GhostDetect:
470 <   * If we can't find the server the user is supposed to be on,
471 <   * then simply blow the user away.        -Taner
472 <   */
473 <  if (source_p->servptr == NULL)
474 <  {
475 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
476 <                         "No server %s for user %s[%s@%s] from %s",
477 <                         server, source_p->name, source_p->username,
478 <                         source_p->host, source_p->from->name);
479 <    sendto_one(source_p->from,
480 <               ":%s KILL %s :%s (Ghosted, server %s doesn't exist)",
481 <               ID(&me), ID(source_p), me.name, server);
482 <
483 <    AddFlag(source_p, FLAGS_KILLED);
484 <    exit_client(source_p, "Ghosted Client");
485 <    return;
486 <  }
595 >  const struct Client *target_p = NULL;
596  
597    if ((target_p = source_p->servptr) && target_p->from != source_p->from)
598    {
# Line 494 | Line 603 | register_remote_user(struct Client *sour
603                           target_p->name, target_p->from->name);
604      sendto_one(source_p->from,
605                 ":%s KILL %s :%s (NICK from wrong direction (%s != %s))",
606 <               ID(&me), ID(source_p), me.name, source_p->servptr->name,
606 >               me.id, source_p->id, me.name, source_p->servptr->name,
607                 target_p->from->name);
608  
609      AddFlag(source_p, FLAGS_KILLED);
# Line 509 | Line 618 | register_remote_user(struct Client *sour
618    if (HasFlag(source_p->servptr, FLAGS_SERVICE))
619      AddFlag(source_p, FLAGS_SERVICE);
620  
512  /* Increment our total user count here */
621    if (++Count.total > Count.max_tot)
622      Count.max_tot = Count.total;
623  
624    SetClient(source_p);
625    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
626 +  dlinkAdd(source_p, &source_p->node, &global_client_list);
627    add_user_host(source_p->username, source_p->host, 1);
628    SetUserHost(source_p);
629  
# Line 528 | Line 637 | register_remote_user(struct Client *sour
637    introduce_client(source_p);
638   }
639  
531 /* introduce_client()
532 *
533 * inputs       - source_p
534 * output       - NONE
535 * side effects - This common function introduces a client to the rest
536 *                of the net, either from a local client connect or
537 *                from a remote connect.
538 */
539 static void
540 introduce_client(struct Client *source_p)
541 {
542  dlink_node *server_node = NULL;
543  char ubuf[IRCD_BUFSIZE];
544
545  if (MyClient(source_p))
546    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
547  else
548    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
549
550  watch_check_hash(source_p, RPL_LOGON);
551
552  if (ubuf[0] == '\0')
553  {
554    ubuf[0] = '+';
555    ubuf[1] = '\0';
556  }
557
558  DLINK_FOREACH(server_node, serv_list.head)
559  {
560    struct Client *server = server_node->data;
561
562    if (server == source_p->from)
563        continue;
564
565    if (IsCapable(server, CAP_SVS))
566      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
567                 source_p->servptr->id,
568                 source_p->name, source_p->hopcount+1,
569                 (unsigned long)source_p->tsinfo,
570                 ubuf, source_p->username, source_p->host,
571                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
572                 "0" : source_p->sockhost, source_p->id,
573                 source_p->svid,
574                 source_p->info);
575    else
576      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
577                 source_p->servptr->id,
578                 source_p->name, source_p->hopcount+1,
579                 (unsigned long)source_p->tsinfo,
580                 ubuf, source_p->username, source_p->host,
581                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
582                 "0" : source_p->sockhost, source_p->id, source_p->info);
583
584    if (!EmptyString(source_p->certfp))
585      sendto_one(server, ":%s CERTFP %s", ID(source_p), source_p->certfp);
586  }
587 }
588
640   /* valid_hostname()
641   *
642   * Inputs       - pointer to hostname
# Line 600 | Line 651 | valid_hostname(const char *hostname)
651   {
652    const char *p = hostname;
653  
654 <  assert(p != NULL);
654 >  assert(p);
655  
656    if (EmptyString(p) || *p == '.' || *p == ':')
657      return 0;
# Line 626 | Line 677 | valid_hostname(const char *hostname)
677   int
678   valid_username(const char *username, const int local)
679   {
680 <  int dots      = 0;
680 >  unsigned int dots = 0;
681    const char *p = username;
682  
683 <  assert(p != NULL);
683 >  assert(p);
684  
685    if (*p == '~')
686      ++p;
# Line 646 | Line 697 | valid_username(const char *username, con
697    {
698      while (*++p)
699      {
700 <      if ((*p == '.') && ConfigFileEntry.dots_in_ident)
700 >      if (*p == '.' && ConfigGeneral.dots_in_ident)
701        {
702 <        if (++dots > ConfigFileEntry.dots_in_ident)
702 >        if (++dots > ConfigGeneral.dots_in_ident)
703            return 0;
704          if (!IsUserChar(*(p + 1)))
705            return 0;
# Line 664 | Line 715 | valid_username(const char *username, con
715          return 0;
716    }
717  
718 <  return  p - username <= USERLEN;;
718 >  return p - username <= USERLEN;
719   }
720  
721   /* clean_nick_name()
# Line 678 | Line 729 | int
729   valid_nickname(const char *nickname, const int local)
730   {
731    const char *p = nickname;
732 +
733    assert(nickname && *nickname);
734  
735 <  /* nicks can't start with a digit or - or be 0 length */
736 <  /* This closer duplicates behaviour of hybrid-6 */
737 <  if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
735 >  /*
736 >   * Nicks can't start with a digit or - or be 0 length.
737 >   */
738 >  if (EmptyString(p) || *p == '-' || (IsDigit(*p) && local))
739      return 0;
740  
741    for (; *p; ++p)
# Line 692 | Line 745 | valid_nickname(const char *nickname, con
745    return p - nickname <= NICKLEN;
746   }
747  
695 /* report_and_set_user_flags()
696 *
697 * inputs       - pointer to source_p
698 *              - pointer to conf for this user
699 * output       - NONE
700 * side effects - Report to user any special flags
701 *                they are getting, and set them.
702 */
703 static void
704 report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
705 {
706  /* If this user is being spoofed, tell them so */
707  if (IsConfDoSpoofIp(conf))
708    sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
709
710  /* If this user is in the exception class, Set it "E lined" */
711  if (IsConfExemptKline(conf))
712  {
713    SetExemptKline(source_p);
714    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D/G lines. Congrats.");
715  }
716
717  /*
718   * The else here is to make sure that G line exempt users
719   * do not get noticed twice.
720   */
721  else if (IsConfExemptGline(conf))
722  {
723    SetExemptGline(source_p);
724    sendto_one_notice(source_p, &me, ":*** You are exempt from G lines. Congrats.");
725  }
726
727  if (IsConfExemptResv(conf))
728  {
729    SetExemptResv(source_p);
730    sendto_one_notice(source_p, &me, ":*** You are exempt from resvs. Congrats.");
731  }
732
733  /* If this user is exempt from user limits set it "F lined" */
734  if (IsConfExemptLimits(conf))
735  {
736    SetExemptLimits(source_p);
737    sendto_one_notice(source_p, &me, ":*** You are exempt from user limits. Congrats.");
738  }
739
740  if (IsConfCanFlood(conf))
741  {
742    SetCanFlood(source_p);
743    sendto_one_notice(source_p, &me, ":*** You are exempt from flood "
744                      "protection, aren't you fearsome.");
745  }
746 }
747
748 /* set_user_mode()
749 *
750 * added 15/10/91 By Darren Reed.
751 * parv[0] - command
752 * parv[1] - username to change mode for
753 * parv[2] - modes to change
754 */
755 void
756 set_user_mode(struct Client *source_p, const int parc, char *parv[])
757 {
758  unsigned int flag, setflags;
759  char **p, *m, buf[IRCD_BUFSIZE];
760  struct Client *target_p;
761  int what = MODE_ADD, badflag = 0, i;
762
763  assert(!(parc < 2));
764
765  if ((target_p = find_person(source_p, parv[1])) == NULL)
766  {
767    if (MyConnect(source_p))
768      sendto_one_numeric(source_p, &me, ERR_NOSUCHCHANNEL, parv[1]);
769    return;
770  }
771
772  if (source_p != target_p)
773  {
774     sendto_one_numeric(source_p, &me, ERR_USERSDONTMATCH);
775     return;
776  }
777
778  if (parc < 3)
779  {
780    m = buf;
781    *m++ = '+';
782
783    for (i = 0; i < 128; ++i)
784      if (HasUMode(source_p, user_modes[i]))
785        *m++ = (char)i;
786    *m = '\0';
787
788    sendto_one_numeric(source_p, &me, RPL_UMODEIS, buf);
789    return;
790  }
791
792  /* find flags already set for user */
793  setflags = source_p->umodes;
794
795  /* parse mode change string(s) */
796  for (p = &parv[2]; p && *p; ++p)
797  {
798    for (m = *p; *m; ++m)
799    {
800      switch (*m)
801      {
802        case '+':
803          what = MODE_ADD;
804          break;
805        case '-':
806          what = MODE_DEL;
807          break;
808        case 'o':
809          if (what == MODE_ADD)
810          {
811            if (!MyConnect(source_p) && !HasUMode(source_p, UMODE_OPER))
812            {
813              ++Count.oper;
814              SetOper(source_p);
815            }
816          }
817          else
818          {
819            if (!HasUMode(source_p, UMODE_OPER))
820              break;
821
822            ClearOper(source_p);
823            Count.oper--;
824
825            if (MyConnect(source_p))
826            {
827              dlink_node *dm = NULL;
828
829              detach_conf(source_p, CONF_OPER);
830              ClrOFlag(source_p);
831              DelUMode(source_p, ConfigFileEntry.oper_only_umodes);
832
833              if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
834                free_dlink_node(dm);
835            }
836          }
837
838          break;
839
840        case 'S':  /* Only servers may set +S in a burst */
841        case 'W':  /* Only servers may set +W in a burst */
842        case 'r':  /* Only services may set +r */
843        case 'x':  /* Only services may set +x */
844          break;
845
846        default:
847          if ((flag = user_modes[(unsigned char)*m]))
848          {
849            if (MyConnect(source_p) && !HasUMode(source_p, UMODE_OPER) &&
850                (ConfigFileEntry.oper_only_umodes & flag))
851              badflag = 1;
852            else
853            {
854              if (what == MODE_ADD)
855                AddUMode(source_p, flag);
856              else
857                DelUMode(source_p, flag);
858            }
859          }
860          else if (MyConnect(source_p))
861            badflag = 1;
862
863          break;
864      }
865    }
866  }
867
868  if (badflag)
869    sendto_one_numeric(source_p, &me, ERR_UMODEUNKNOWNFLAG);
870
871  if (MyConnect(source_p) && HasUMode(source_p, UMODE_ADMIN) &&
872      !HasOFlag(source_p, OPER_FLAG_ADMIN))
873  {
874    sendto_one_notice(source_p, &me, ":*** You have no admin flag;");
875    DelUMode(source_p, UMODE_ADMIN);
876  }
877
878  if (!(setflags & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
879    ++Count.invisi;
880  if ((setflags & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
881    --Count.invisi;
882
883  /*
884   * compare new flags with old flags and send string which
885   * will cause servers to update correctly.
886   */
887  send_umode_out(source_p, source_p, setflags);
888 }
889
748   /* send_umode()
749   * send the MODE string for user (user) to connection client_p
750   * -avalon
# Line 900 | Line 758 | set_user_mode(struct Client *source_p, c
758   */
759   void
760   send_umode(struct Client *client_p, struct Client *source_p,
761 <           unsigned int old, unsigned int sendmask, char *umode_buf)
761 >           unsigned int old, char *umode_buf)
762   {
763    char *m = umode_buf;
764    int what = 0;
907  unsigned int i;
908  unsigned int flag;
765  
766    /*
767 <   * build a string in umode_buf to represent the change in the user's
767 >   * Build a string in umode_buf to represent the change in the user's
768     * mode between the new (source_p->umodes) and 'old'.
769     */
770 <  for (i = 0; i < 128; ++i)
770 >  for (unsigned int i = 0; i < 128; ++i)
771    {
772 <    flag = user_modes[i];
917 <    if (!flag)
918 <      continue;
772 >    unsigned int flag = user_modes[i];
773  
774 <    if (MyClient(source_p) && !(flag & sendmask))
774 >    if (!flag)
775        continue;
776  
777      if ((flag & old) && !HasUMode(source_p, flag))
# Line 948 | Line 802 | send_umode(struct Client *client_p, stru
802  
803    if (*umode_buf && client_p)
804      sendto_one(client_p, ":%s!%s@%s MODE %s :%s",
805 <               source_p->name, source_p->username,
806 <               source_p->host, source_p->name, umode_buf);
805 >               client_p->name, client_p->username,
806 >               client_p->host, client_p->name, umode_buf);
807   }
808  
809   /* send_umode_out()
# Line 959 | Line 813 | send_umode(struct Client *client_p, stru
813   * side effects - Only send ubuf out to servers that know about this client
814   */
815   void
816 < send_umode_out(struct Client *client_p, struct Client *source_p,
963 <               unsigned int old)
816 > send_umode_out(struct Client *source_p, unsigned int old)
817   {
818 <  char buf[IRCD_BUFSIZE] = { '\0' };
966 <  dlink_node *ptr = NULL;
818 >  char buf[IRCD_BUFSIZE] = "";
819  
820 <  send_umode(NULL, source_p, old, SEND_UMODES, buf);
820 >  send_umode(MyClient(source_p) ? source_p : NULL, source_p, old, buf);
821  
822    if (buf[0])
823 <    sendto_server(source_p, NOCAPS, NOCAPS, ":%s MODE %s :%s",
824 <                  ID(source_p), ID(source_p), buf);
973 <
974 <  if (client_p && MyClient(client_p))
975 <    send_umode(client_p, source_p, old, 0xffffffff, buf);
823 >    sendto_server(source_p, 0, 0, ":%s MODE %s :%s",
824 >                  source_p->id, source_p->id, buf);
825   }
826  
827   void
828   user_set_hostmask(struct Client *target_p, const char *hostname, const int what)
829   {
830 <  dlink_node *ptr = NULL;
830 >  dlink_node *node = NULL;
831  
832    if (!strcmp(target_p->host, hostname))
833      return;
# Line 987 | Line 836 | user_set_hostmask(struct Client *target_
836    {
837      case MODE_ADD:
838        AddUMode(target_p, UMODE_HIDDENHOST);
990      AddFlag(target_p, FLAGS_IP_SPOOFING);
839        break;
840      case MODE_DEL:
841        DelUMode(target_p, UMODE_HIDDENHOST);
994
995      if (!HasFlag(target_p, FLAGS_AUTH_SPOOF))
996        DelFlag(target_p, FLAGS_IP_SPOOFING);
842        break;
843      default: return;
844    }
845  
846 <  if (ConfigFileEntry.cycle_on_host_change)
846 >  if (ConfigGeneral.cycle_on_host_change)
847      sendto_common_channels_local(target_p, 0, 0, ":%s!%s@%s QUIT :Changing hostname",
848                                   target_p->name, target_p->username, target_p->host);
849  
# Line 1012 | Line 857 | user_set_hostmask(struct Client *target_
857  
858    if (MyClient(target_p))
859    {
860 <    sendto_one_numeric(target_p, &me, RPL_NEWHOSTIS, target_p->host);
860 >    sendto_one_numeric(target_p, &me, RPL_VISIBLEHOST, target_p->host);
861      clear_ban_cache_client(target_p);
862    }
863  
864 <  if (!ConfigFileEntry.cycle_on_host_change)
864 >  if (!ConfigGeneral.cycle_on_host_change)
865      return;
866  
867 <  DLINK_FOREACH(ptr, target_p->channel.head)
867 >  DLINK_FOREACH(node, target_p->channel.head)
868    {
869 <    char modebuf[4], nickbuf[NICKLEN * 3 + 3] = { '\0' };
869 >    char modebuf[4], nickbuf[NICKLEN * 3 + 3] = "";
870      char *p = modebuf;
871      int len = 0;
872 <    const struct Membership *ms = ptr->data;
872 >    const struct Membership *member = node->data;
873  
874 <    if (has_member_flags(ms, CHFL_CHANOP))
874 >    if (has_member_flags(member, CHFL_CHANOP))
875      {
876        *p++ = 'o';
877        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
878      }
879  
880 <    if (has_member_flags(ms, CHFL_HALFOP))
880 >    if (has_member_flags(member, CHFL_HALFOP))
881      {
882        *p++ = 'h';
883        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
884      }
885  
886 <    if (has_member_flags(ms, CHFL_VOICE))
886 >    if (has_member_flags(member, CHFL_VOICE))
887      {
888        *p++ = 'v';
889        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
# Line 1046 | Line 891 | user_set_hostmask(struct Client *target_
891  
892      *p = '\0';
893  
894 <    sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s!%s@%s JOIN :%s",
895 <                                target_p->name, target_p->username, target_p->host,
896 <                                ms->chptr->chname);
894 >
895 >    sendto_channel_local_butone(target_p, CAP_EXTENDED_JOIN, 0, member->chptr, ":%s!%s@%s JOIN %s %s :%s",
896 >                                target_p->name, target_p->username,
897 >                                target_p->host, member->chptr->name,
898 >                                (!IsDigit(target_p->account[0]) && target_p->account[0] != '*') ? target_p->account : "*",
899 >                                target_p->info);
900 >    sendto_channel_local_butone(target_p, 0, CAP_EXTENDED_JOIN, member->chptr, ":%s!%s@%s JOIN :%s",
901 >                                target_p->name, target_p->username,
902 >                                target_p->host, member->chptr->name);
903 >
904      if (nickbuf[0])
905 <      sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s MODE %s +%s %s",
906 <                                  target_p->servptr->name, ms->chptr->chname,
905 >      sendto_channel_local_butone(target_p, 0, 0, member->chptr, ":%s MODE %s +%s %s",
906 >                                  target_p->servptr->name, member->chptr->name,
907                                    modebuf, nickbuf);
908  
909    }
# Line 1063 | Line 915 | user_set_hostmask(struct Client *target_
915                                   target_p->host, target_p->away);
916   }
917  
918 < /* user_welcome()
919 < *
920 < * inputs       - client pointer to client to welcome
1069 < * output       - NONE
1070 < * side effects -
1071 < */
1072 < static void
1073 < user_welcome(struct Client *source_p)
1074 < {
1075 < #if defined(__TIME__) && defined(__DATE__)
1076 <  static const char built_date[] = __DATE__ " at " __TIME__;
1077 < #else
1078 <  static const char built_date[] = "unknown";
1079 < #endif
1080 <
1081 < #ifdef HAVE_LIBCRYPTO
1082 <  if (HasFlag(source_p, FLAGS_SSL))
1083 <  {
1084 <    AddUMode(source_p, UMODE_SSL);
1085 <    sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
1086 <                      ssl_get_cipher(source_p->localClient->fd.ssl));
1087 <  }
1088 < #endif
1089 <
1090 <  sendto_one_numeric(source_p, &me, RPL_WELCOME, ServerInfo.network_name,
1091 <                     source_p->name);
1092 <  sendto_one_numeric(source_p, &me, RPL_YOURHOST,
1093 <                     get_listener_name(source_p->localClient->listener), ircd_version);
1094 <  sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
1095 <  sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
1096 <  show_isupport(source_p);
1097 <
1098 <  if (source_p->id[0] != '\0')
1099 <    sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
1100 <
1101 <  show_lusers(source_p);
1102 <  motd_signon(source_p);
1103 < }
1104 <
1105 < /* check_xline()
1106 < *
1107 < * inputs       - pointer to client to test
1108 < * outupt       - 1 if exiting 0 if ok
1109 < * side effects -
1110 < */
1111 < static int
1112 < check_xline(struct Client *source_p)
1113 < {
1114 <  struct MaskItem *conf = NULL;
1115 <  const char *reason = NULL;
1116 <
1117 <  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
1118 <  {
1119 <    ++conf->count;
1120 <
1121 <    if (conf->reason != NULL)
1122 <      reason = conf->reason;
1123 <    else
1124 <      reason = "No Reason";
1125 <
1126 <    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
1127 <                         "X-line Rejecting [%s] [%s], user %s [%s]",
1128 <                         source_p->info, reason,
1129 <                         get_client_name(source_p, HIDE_IP),
1130 <                         source_p->sockhost);
1131 <
1132 <    ++ServerStats.is_ref;
1133 <    exit_client(source_p, "Bad user info");
1134 <    return 1;
1135 <  }
1136 <
1137 <  return 0;
1138 < }
1139 <
1140 < /* oper_up()
1141 < *
1142 < * inputs       - pointer to given client to oper
1143 < * output       - NONE
1144 < * side effects - Blindly opers up given source_p, using conf info
1145 < *                all checks on passwords have already been done.
1146 < *                This could also be used by rsa oper routines.
918 > /*! \brief Blindly opers up given source_p, using conf info.
919 > *         All checks on passwords have already been done.
920 > * \param source_p Pointer to given client to oper
921   */
922   void
923   oper_up(struct Client *source_p)
924   {
925    const unsigned int old = source_p->umodes;
926 <  const struct MaskItem *conf = source_p->localClient->confs.head->data;
926 >  const struct MaskItem *const conf = source_p->connection->confs.head->data;
927  
928 <  assert(source_p->localClient->confs.head);
928 >  assert(source_p->connection->confs.head);
929  
930    ++Count.oper;
931    SetOper(source_p);
932  
933    if (conf->modes)
934      AddUMode(source_p, conf->modes);
935 <  else if (ConfigFileEntry.oper_umodes)
936 <    AddUMode(source_p, ConfigFileEntry.oper_umodes);
935 >  else if (ConfigGeneral.oper_umodes)
936 >    AddUMode(source_p, ConfigGeneral.oper_umodes);
937  
938    if (!(old & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
939      ++Count.invisi;
# Line 1176 | Line 950 | oper_up(struct Client *source_p)
950  
951    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
952                         get_oper_name(source_p));
953 <  send_umode_out(source_p, source_p, old);
953 >  sendto_server(NULL, 0, 0, ":%s GLOBOPS :%s is now an operator",
954 >                me.id, get_oper_name(source_p));
955 >  send_umode_out(source_p, old);
956    sendto_one_numeric(source_p, &me, RPL_YOUREOPER);
957   }
958  
959 < static char new_uid[TOTALSIDUID + 1];     /* allow for \0 */
959 > static char new_uid[TOTALSIDUID + 1];  /* Allow for \0 */
960  
961   int
962   valid_sid(const char *sid)
# Line 1205 | Line 981 | valid_sid(const char *sid)
981   void
982   init_uid(void)
983   {
1208  unsigned int i;
1209
984    memset(new_uid, 0, sizeof(new_uid));
985  
986 <  if (!EmptyString(ServerInfo.sid))
987 <    strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
986 >  if (!EmptyString(ConfigServerInfo.sid))
987 >    strlcpy(new_uid, ConfigServerInfo.sid, sizeof(new_uid));
988  
989 <  for (i = 0; i < IRC_MAXSID; ++i)
989 >  for (unsigned int i = 0; i < IRC_MAXSID; ++i)
990      if (new_uid[i] == '\0')
991        new_uid[i] = 'A';
992  
# Line 1229 | Line 1003 | init_uid(void)
1003   *                note this is a recursive function
1004   */
1005   static void
1006 < add_one_to_uid(int i)
1006 > add_one_to_uid(unsigned int i)
1007   {
1008 <  if (i != IRC_MAXSID)    /* Not reached server SID portion yet? */
1008 >  if (i != IRC_MAXSID)  /* Not reached server SID portion yet? */
1009    {
1010      if (new_uid[i] == 'Z')
1011        new_uid[i] = '0';
1012      else if (new_uid[i] == '9')
1013      {
1014        new_uid[i] = 'A';
1015 <      add_one_to_uid(i-1);
1015 >      add_one_to_uid(i - 1);
1016      }
1017      else
1018        ++new_uid[i];
# Line 1263 | Line 1037 | add_one_to_uid(int i)
1037   static const char *
1038   uid_get(void)
1039   {
1040 <  add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1040 >  add_one_to_uid(TOTALSIDUID - 1);  /* Index from 0 */
1041    return new_uid;
1042   }
1043  
# Line 1278 | Line 1052 | void
1052   init_isupport(void)
1053   {
1054    add_isupport("CALLERID", NULL, -1);
1055 <  add_isupport("CASEMAPPING", CASEMAP, -1);
1055 >  add_isupport("CASEMAPPING", "rfc1459", -1);
1056    add_isupport("DEAF", "D", -1);
1057    add_isupport("KICKLEN", NULL, KICKLEN);
1058    add_isupport("MODES", NULL, MAXMODEPARAMS);
1285 #ifdef HALFOPS
1059    add_isupport("PREFIX", "(ohv)@%+", -1);
1060    add_isupport("STATUSMSG", "@%+", -1);
1061 < #else
1062 <  add_isupport("PREFIX", "(ov)@+", -1);
1290 <  add_isupport("STATUSMSG", "@+", -1);
1291 < #endif
1292 <  add_isupport("EXCEPTS", "e", -1);
1293 <  add_isupport("INVEX", "I", -1);
1061 >  add_isupport("EXCEPTS", NULL, -1);
1062 >  add_isupport("INVEX", NULL, -1);
1063   }
1064  
1065   /*
# Line 1305 | Line 1074 | init_isupport(void)
1074   void
1075   add_isupport(const char *name, const char *options, int n)
1076   {
1077 <  dlink_node *ptr;
1078 <  struct Isupport *support;
1077 >  dlink_node *node = NULL;
1078 >  struct Isupport *support = NULL;
1079  
1080 <  DLINK_FOREACH(ptr, support_list.head)
1080 >  DLINK_FOREACH(node, support_list.head)
1081    {
1082 <    support = ptr->data;
1082 >    support = node->data;
1083      if (irccmp(support->name, name) == 0)
1084      {
1085        MyFree(support->name);
# Line 1319 | Line 1088 | add_isupport(const char *name, const cha
1088      }
1089    }
1090  
1091 <  if (ptr == NULL)
1091 >  if (node == NULL)
1092    {
1093 <    support = MyMalloc(sizeof(*support));
1093 >    support = MyCalloc(sizeof(*support));
1094      dlinkAddTail(support, &support->node, &support_list);
1095    }
1096  
1097    support->name = xstrdup(name);
1098 <  if (options != NULL)
1098 >  if (options)
1099      support->options = xstrdup(options);
1100    support->number = n;
1101  
# Line 1343 | Line 1112 | add_isupport(const char *name, const cha
1112   void
1113   delete_isupport(const char *name)
1114   {
1115 <  dlink_node *ptr;
1347 <  struct Isupport *support;
1115 >  dlink_node *node = NULL;
1116  
1117 <  DLINK_FOREACH(ptr, support_list.head)
1117 >  DLINK_FOREACH(node, support_list.head)
1118    {
1119 <    support = ptr->data;
1119 >    struct Isupport *support = node->data;
1120 >
1121      if (irccmp(support->name, name) == 0)
1122      {
1123 <      dlinkDelete(ptr, &support_list);
1123 >      dlinkDelete(node, &support_list);
1124        MyFree(support->name);
1125        MyFree(support->options);
1126        MyFree(support);
# Line 1374 | Line 1143 | rebuild_isupport_message_line(void)
1143   {
1144    char isupportbuffer[IRCD_BUFSIZE];
1145    char *p = isupportbuffer;
1146 <  dlink_node *ptr = NULL, *ptr_next = NULL;
1146 >  dlink_node *node = NULL, *node_next = NULL;
1147    int n = 0;
1148    int tokens = 0;
1149    size_t len = 0;
1150    size_t reserve = strlen(me.name) + HOSTLEN + strlen(numeric_form(RPL_ISUPPORT));
1151  
1152 <  DLINK_FOREACH_SAFE(ptr, ptr_next, support_list_lines.head)
1152 >  DLINK_FOREACH_SAFE(node, node_next, support_list_lines.head)
1153    {
1154 <    dlinkDelete(ptr, &support_list_lines);
1155 <    MyFree(ptr->data);
1156 <    free_dlink_node(ptr);
1154 >    dlinkDelete(node, &support_list_lines);
1155 >    MyFree(node->data);
1156 >    free_dlink_node(node);
1157    }
1158  
1159 <  DLINK_FOREACH(ptr, support_list.head)
1159 >  DLINK_FOREACH(node, support_list.head)
1160    {
1161 <    struct Isupport *support = ptr->data;
1161 >    struct Isupport *support = node->data;
1162  
1163      p += (n = sprintf(p, "%s", support->name));
1164      len += n;
1165  
1166 <    if (support->options != NULL)
1166 >    if (support->options)
1167      {
1168        p += (n = sprintf(p, "=%s", support->options));
1169        len += n;
# Line 1422 | Line 1191 | rebuild_isupport_message_line(void)
1191      }
1192    }
1193  
1194 <  if (len != 0)
1194 >  if (len)
1195    {
1196      if (*--p == ' ')
1197        *p = '\0';

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)