ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing:
ircd-hybrid-7.2/src/s_user.c (file contents), Revision 849 by db, Mon Feb 19 19:41:59 2007 UTC vs.
ircd-hybrid-8/src/s_user.c (file contents), Revision 1156 by michael, Tue Aug 9 20:29:20 2011 UTC

# Line 23 | Line 23
23   */
24  
25   #include "stdinc.h"
26 < #include "tools.h"
26 > #include "list.h"
27   #include "s_user.h"
28   #include "s_misc.h"
29   #include "channel.h"
# Line 35 | Line 35
35   #include "irc_string.h"
36   #include "sprintf_irc.h"
37   #include "s_bsd.h"
38 #include "irc_getnameinfo.h"
38   #include "ircd.h"
40 #include "list.h"
39   #include "listener.h"
40   #include "motd.h"
41   #include "numeric.h"
42   #include "s_conf.h"
43   #include "s_log.h"
44   #include "s_serv.h"
47 #include "s_stats.h"
45   #include "send.h"
46   #include "supported.h"
47   #include "whowas.h"
48   #include "memory.h"
49   #include "packet.h"
50 + #include "rng_mt.h"
51   #include "userhost.h"
52   #include "hook.h"
53   #include "s_misc.h"
54   #include "msg.h"
55 < #include "pcre.h"
55 > #include "watch.h"
56 >
57  
59 int MaxClientCount     = 1;
60 int MaxConnectionCount = 1;
58   struct Callback *entering_umode_cb = NULL;
59   struct Callback *umode_cb = NULL;
63 struct Callback *uid_get_cb = NULL;
60  
61   static char umode_buffer[IRCD_BUFSIZE];
62  
63   static void user_welcome(struct Client *);
64   static void report_and_set_user_flags(struct Client *, const struct AccessItem *);
65   static int check_xline(struct Client *);
66 < static void introduce_client(struct Client *, struct Client *);
67 < static void *uid_get(va_list);
66 > static void introduce_client(struct Client *);
67 > static const char *uid_get(void);
68  
69   /* Used for building up the isupport string,
70   * used with init_isupport, add_isupport, delete_isupport
# Line 165 | Line 161 | assemble_umode_buffer(void)
161    unsigned int idx = 0;
162    char *umode_buffer_ptr = umode_buffer;
163  
164 <  for (; idx < (sizeof(user_modes) / sizeof(int)); ++idx)
164 >  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
165      if (user_modes[idx])
166        *umode_buffer_ptr++ = idx;
167  
# Line 237 | Line 233 | show_lusers(struct Client *source_p)
233  
234    if (!ConfigServerHide.hide_servers || IsOper(source_p))
235      sendto_one(source_p, form_str(RPL_STATSCONN), from, to,
236 <               MaxConnectionCount, MaxClientCount, Count.totalrestartcount);
236 >               Count.max_loc_con, Count.max_loc_cli, Count.totalrestartcount);
237  
238 <  if (Count.local > MaxClientCount)
239 <    MaxClientCount = Count.local;
238 >  if (Count.local > Count.max_loc_cli)
239 >    Count.max_loc_cli = Count.local;
240  
241 <  if ((Count.local + Count.myserver) > MaxConnectionCount)
242 <    MaxConnectionCount = Count.local + Count.myserver;
241 >  if ((Count.local + Count.myserver) > Count.max_loc_con)
242 >    Count.max_loc_con = Count.local + Count.myserver;
243   }
244  
245   /* show_isupport()
# Line 282 | Line 278 | show_isupport(struct Client *source_p)
278   **         nick from local user or kill him/her...
279   */
280   void
281 < register_local_user(struct Client *client_p, struct Client *source_p,
286 <                    const char *nick, const char *username)
281 > register_local_user(struct Client *source_p)
282   {
283 +  const char *id = NULL;
284    const struct AccessItem *aconf = NULL;
289  char ipaddr[HOSTIPLEN];
285    dlink_node *ptr = NULL;
291  dlink_node *m = NULL;
286  
287    assert(source_p != NULL);
288 +  assert(source_p == source_p->from);
289    assert(MyConnect(source_p));
295  assert(source_p->username != username);
290    assert(!source_p->localClient->registration);
291  
292 <  ClearCap(client_p, CAP_TS6);
292 >  ClearCap(source_p, CAP_TS6);
293  
294    if (ConfigFileEntry.ping_cookie)
295    {
296 <    if (!IsPingSent(source_p) &&
303 <       source_p->localClient->random_ping == 0)
296 >    if (!IsPingSent(source_p) && source_p->localClient->random_ping == 0)
297      {
298 <      source_p->localClient->random_ping = (unsigned long)rand();
299 <      sendto_one(source_p, "PING :%lu",
298 >      do
299 >        source_p->localClient->random_ping = genrand_int32();
300 >      while (!source_p->localClient->random_ping);
301 >
302 >      sendto_one(source_p, "PING :%u",
303                   source_p->localClient->random_ping);
304        SetPingSent(source_p);
305        return;
# Line 317 | Line 313 | register_local_user(struct Client *clien
313    /* Straight up the maximum rate of flooding... */
314    source_p->localClient->allow_read = MAX_FLOOD_BURST;
315  
316 <  if (!execute_callback(client_check_cb, source_p, username))
316 >  if (!execute_callback(client_check_cb, source_p, source_p->username))
317      return;
318  
319    if (valid_hostname(source_p->host) == 0)
# Line 333 | Line 329 | register_local_user(struct Client *clien
329  
330    if (!IsGotId(source_p))
331    {
332 <    const char *p = NULL;
332 >    char username[USERLEN + 1];
333 >    const char *p = username;
334      unsigned int i = 0;
335  
336      if (IsNeedIdentd(aconf))
337      {
338 <      ServerStats->is_ref++;
338 >      ++ServerStats.is_ref;
339        sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You need to install "
340                   "identd to use this server", me.name, source_p->name);
341        exit_client(source_p, &me, "Install identd");
342        return;
343      }
344  
345 <    p = username;
345 >    strlcpy(username, source_p->username, sizeof(username));
346  
347      if (!IsNoTilde(aconf))
348        source_p->username[i++] = '~';
349  
350 <    while (*p && i < USERLEN)
354 <    {
350 >    for (; *p && i < USERLEN; ++p)
351        if (*p != '[')
352          source_p->username[i++] = *p;
357      p++;
358    }
353  
354      source_p->username[i] = '\0';
355    }
# Line 367 | Line 361 | register_local_user(struct Client *clien
361  
362      if (!match_conf_password(pass, aconf))
363      {
364 <      ServerStats->is_ref++;
364 >      ++ServerStats.is_ref;
365        sendto_one(source_p, form_str(ERR_PASSWDMISMATCH),
366                   me.name, source_p->name);
367        exit_client(source_p, &me, "Bad Password");
# Line 383 | Line 377 | register_local_user(struct Client *clien
377    /* report if user has &^>= etc. and set flags as needed in source_p */
378    report_and_set_user_flags(source_p, aconf);
379  
380 +  if (IsDead(source_p))
381 +    return;
382 +
383    /* Limit clients -
384     * We want to be able to have servers and F-line clients
385     * connect, so save room for "buffer" connections.
# Line 396 | Line 393 | register_local_user(struct Client *clien
393    {
394      sendto_realops_flags(UMODE_FULL, L_ALL,
395                           "Too many clients, rejecting %s[%s].",
396 <                         nick, source_p->host);
397 <    ServerStats->is_ref++;
396 >                         source_p->name, source_p->host);
397 >    ++ServerStats.is_ref;
398      exit_client(source_p, &me, "Sorry, server is full - try later");
399      return;
400    }
# Line 408 | Line 405 | register_local_user(struct Client *clien
405      char tmpstr2[IRCD_BUFSIZE];
406  
407      sendto_realops_flags(UMODE_REJ, L_ALL, "Invalid username: %s (%s@%s)",
408 <                         nick, source_p->username, source_p->host);
409 <    ServerStats->is_ref++;
410 <    ircsprintf(tmpstr2, "Invalid username [%s]", source_p->username);
408 >                         source_p->name, source_p->username, source_p->host);
409 >    ++ServerStats.is_ref;
410 >    snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
411 >             source_p->username);
412      exit_client(source_p, &me, tmpstr2);
413      return;
414    }
415  
418  assert(source_p == client_p);
419
416    if (check_xline(source_p))
417      return;
418  
419 <  if (IsDead(client_p))
420 <    return;
425 <
426 <  if (me.id[0])
427 <  {
428 <    const char *id = execute_callback(uid_get_cb, source_p);
429 <
430 <    while (hash_find_id(id) != NULL)
431 <      id = uid_get(NULL);
419 >  while (hash_find_id((id = uid_get())) != NULL)
420 >    ;
421  
422 <    strlcpy(source_p->id, id, sizeof(source_p->id));
423 <    hash_add_id(source_p);
435 <  }
436 <
437 <  irc_getnameinfo((struct sockaddr *)&source_p->localClient->ip,
438 <                  source_p->localClient->ip.ss_len, ipaddr,
439 <                  HOSTIPLEN, NULL, 0, NI_NUMERICHOST);
422 >  strlcpy(source_p->id, id, sizeof(source_p->id));
423 >  hash_add_id(source_p);
424  
425    sendto_realops_flags(UMODE_CCONN, L_ALL,
426 <                       "Client connecting: %s (%s@%s) [%s] {%s} [%s]",
427 <                       nick, source_p->username, source_p->host,
426 >                       "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
427 >                       source_p->name, source_p->username, source_p->host,
428                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
429 <                       "255.255.255.255" : ipaddr, get_client_class(source_p),
430 <                       source_p->info);
429 >                       "255.255.255.255" : source_p->sockhost,
430 >                       get_client_class(source_p),
431 >                       source_p->info, source_p->id);
432  
433    sendto_realops_flags(UMODE_CCONN_FULL, L_ALL,
434                         "CLICONN %s %s %s %s %s %s %s 0 %s",
435 <                       nick, source_p->username, source_p->host,
435 >                       source_p->name, source_p->username, source_p->host,
436                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
437 <                       "255.255.255.255" : ipaddr,
437 >                       "255.255.255.255" : source_p->sockhost,
438                         get_client_class(source_p),
439                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
440 <                           "<hidden>" : source_p->client_host,
440 >                           "<hidden>" : source_p->localClient->client_host,
441                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
442 <                           "<hidden>" : source_p->client_server,
442 >                           "<hidden>" : source_p->localClient->client_server,
443                         source_p->info);
444  
445  
461  /* If they have died in send_* don't do anything. */
462  if (IsDead(source_p))
463    return;
464
446    if (ConfigFileEntry.invisible_on_connect)
447    {
448      source_p->umodes |= UMODE_INVISIBLE;
449 <    Count.invisi++;
449 >    ++Count.invisi;
450    }
451  
452    if ((++Count.local) > Count.max_loc)
# Line 477 | Line 458 | register_local_user(struct Client *clien
458                             Count.max_loc);
459    }
460  
480  SetClient(source_p);
481
482  source_p->servptr = &me;
483  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->users);
484
461    /* Increment our total user count here */
462    if (++Count.total > Count.max_tot)
463      Count.max_tot = Count.total;
464 <  Count.totalrestartcount++;
464 >  ++Count.totalrestartcount;
465 >
466 >  assert(source_p->servptr == &me);
467 >  SetClient(source_p);
468 >  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
469  
470    source_p->localClient->allow_read = MAX_FLOOD_BURST;
471  
472 <  if ((m = dlinkFindDelete(&unknown_list, source_p)) != NULL)
473 <  {
474 <    free_dlink_node(m);
475 <    dlinkAdd(source_p, &source_p->localClient->lclient_node, &local_client_list);
496 <  }
497 <  else assert(0);
472 >  assert(dlinkFind(&unknown_list, source_p));
473 >
474 >  dlink_move_node(&source_p->localClient->lclient_node,
475 >                  &unknown_list, &local_client_list);
476  
477    user_welcome(source_p);
478    add_user_host(source_p->username, source_p->host, 0);
479    SetUserHost(source_p);
480  
481 <  introduce_client(client_p, source_p);
481 >  introduce_client(source_p);
482   }
483  
484   /* register_remote_user()
485   *
486 < * inputs       - client_p directly connected client
509 < *              - source_p remote or directly connected client
486 > * inputs       - source_p remote or directly connected client
487   *              - username to register as
488   *              - host name to register as
489   *              - server name
# Line 516 | Line 493 | register_local_user(struct Client *clien
493   *                is introduced by a server.
494   */
495   void
496 < register_remote_user(struct Client *client_p, struct Client *source_p,
496 > register_remote_user(struct Client *source_p,
497                       const char *username, const char *host, const char *server,
498                       const char *realname)
499   {
# Line 526 | Line 503 | register_remote_user(struct Client *clie
503    assert(source_p->username != username);
504  
505    strlcpy(source_p->host, host, sizeof(source_p->host));
529  strlcpy(source_p->info, realname, sizeof(source_p->info));
506    strlcpy(source_p->username, username, sizeof(source_p->username));
507  
508    /*
# Line 544 | Line 520 | register_remote_user(struct Client *clie
520                           "No server %s for user %s[%s@%s] from %s",
521                           server, source_p->name, source_p->username,
522                           source_p->host, source_p->from->name);
523 <    kill_client(client_p, source_p, "%s (Server doesn't exist)", me.name);
523 >    kill_client(source_p->from, source_p, "%s (Server doesn't exist)", me.name);
524  
525      SetKilled(source_p);
526      exit_client(source_p, &me, "Ghosted Client");
# Line 555 | Line 531 | register_remote_user(struct Client *clie
531    {
532      sendto_realops_flags(UMODE_DEBUG, L_ALL,
533                           "Bad User [%s] :%s USER %s@%s %s, != %s[%s]",
534 <                         client_p->name, source_p->name, source_p->username,
534 >                         source_p->from->name, source_p->name, source_p->username,
535                           source_p->host, source_p->servptr->name,
536                           target_p->name, target_p->from->name);
537 <    kill_client(client_p, source_p,
537 >    kill_client(source_p->from, source_p,
538                  "%s (NICK from wrong direction (%s != %s))",
539                  me.name, source_p->servptr->name, target_p->from->name);
540      SetKilled(source_p);
# Line 570 | Line 546 | register_remote_user(struct Client *clie
546    if (++Count.total > Count.max_tot)
547      Count.max_tot = Count.total;
548  
573  ++source_p->from->serv->dep_users;
574
549    SetClient(source_p);
550 <  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->users);
550 >  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
551    add_user_host(source_p->username, source_p->host, 1);
552    SetUserHost(source_p);
553  
554 <  introduce_client(client_p, source_p);
554 >  introduce_client(source_p);
555   }
556  
557   /* introduce_client()
558   *
559 < * inputs       - client_p
586 < *              - source_p
559 > * inputs       - source_p
560   * output       - NONE
561   * side effects - This common function introduces a client to the rest
562   *                of the net, either from a local client connect or
563   *                from a remote connect.
564   */
565   static void
566 < introduce_client(struct Client *client_p, struct Client *source_p)
566 > introduce_client(struct Client *source_p)
567   {
568    dlink_node *server_node = NULL;
569    static char ubuf[12];
# Line 600 | Line 573 | introduce_client(struct Client *client_p
573    else
574      send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
575  
576 +  watch_check_hash(source_p, RPL_LOGON);
577 +
578    if (*ubuf == '\0')
579    {
580      ubuf[0] = '+';
581      ubuf[1] = '\0';
582    }
583  
584 <  /* arghhh one could try not introducing new nicks to ll leafs
610 <   * but then you have to introduce them "on the fly" in SJOIN
611 <   * not fun.
612 <   * Its not going to cost much more bandwidth to simply let new
613 <   * nicks just ride on through.
614 <   */
615 <
616 <  /* We now introduce nicks "on the fly" in SJOIN anyway --
617 <   * you _need_ to if you aren't going to burst everyone initially.
618 <   *
619 <   * Only send to non CAP_LL servers, unless we're a lazylink leaf,
620 <   * in that case just send it to the uplink.
621 <   * -davidt
622 <   * rewritten to cope with SIDs .. eww eww eww --is
623 <   */
624 <  if (!ServerInfo.hub && uplink && IsCapable(uplink, CAP_LL) &&
625 <      client_p != uplink)
584 >  DLINK_FOREACH(server_node, serv_list.head)
585    {
586 <    if (IsCapable(uplink, CAP_TS6) && HasID(source_p))
587 <    {
588 <      sendto_one(uplink, ":%s UID %s %d %lu %s %s %s %s %s :%s",
586 >    struct Client *server = server_node->data;
587 >
588 >    if (server == source_p->from)
589 >        continue;
590 >
591 >    if (IsCapable(server, CAP_TS6) && HasID(source_p))
592 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
593                   source_p->servptr->id,
594                   source_p->name, source_p->hopcount+1,
595                   (unsigned long)source_p->tsinfo,
596                   ubuf, source_p->username, source_p->host,
597                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
598                   "0" : source_p->sockhost, source_p->id, source_p->info);
636    }
599      else
600 <    {
639 <      sendto_one(uplink, "NICK %s %d %lu %s %s %s %s :%s",
600 >      sendto_one(server, "NICK %s %d %lu %s %s %s %s :%s",
601                   source_p->name, source_p->hopcount+1,
602                   (unsigned long)source_p->tsinfo,
603                   ubuf, source_p->username, source_p->host,
604                   source_p->servptr->name, source_p->info);
644    }
645  }
646  else
647  {
648    DLINK_FOREACH(server_node, serv_list.head)
649    {
650      struct Client *server = server_node->data;
651
652      if (IsCapable(server, CAP_LL) || server == client_p)
653        continue;
654
655      if (IsCapable(server, CAP_TS6) && HasID(source_p))
656        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
657                   source_p->servptr->id,
658                   source_p->name, source_p->hopcount+1,
659                   (unsigned long)source_p->tsinfo,
660                   ubuf, source_p->username, source_p->host,
661                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
662                   "0" : source_p->sockhost, source_p->id, source_p->info);
663      else
664        sendto_one(server, "NICK %s %d %lu %s %s %s %s :%s",
665                   source_p->name, source_p->hopcount+1,
666                   (unsigned long)source_p->tsinfo,
667                   ubuf, source_p->username, source_p->host,
668                   source_p->servptr->name, source_p->info);
669    }
605    }
606   }
607  
# Line 686 | Line 621 | valid_hostname(const char *hostname)
621  
622    assert(p != NULL);
623  
624 <  if ('.' == *p || ':' == *p)
624 >  if (*p == '.' || *p == ':')
625      return 0;
626  
627 <  while (*p)
693 <  {
627 >  for (; *p; ++p)
628      if (!IsHostChar(*p))
629        return 0;
696    p++;
697  }
630  
631    return 1;
632   }
# Line 718 | Line 650 | valid_username(const char *username)
650  
651    assert(p != NULL);
652  
653 <  if ('~' == *p)
653 >  if (*p == '~')
654      ++p;
655  
656    /* reject usernames that don't start with an alphanum
# Line 732 | Line 664 | valid_username(const char *username)
664    {
665      if ((*p == '.') && ConfigFileEntry.dots_in_ident)
666      {
667 <      dots++;
736 <
737 <      if (dots > ConfigFileEntry.dots_in_ident)
667 >      if (++dots > ConfigFileEntry.dots_in_ident)
668          return 0;
669 <      if (!IsUserChar(p[1]))
669 >      if (!IsUserChar(*(p + 1)))
670          return 0;
671      }
672      else if (!IsUserChar(*p))
# Line 818 | Line 748 | report_and_set_user_flags(struct Client
748    }
749   }
750  
821 /* do_local_user()
822 *
823 * inputs       -
824 * output       - NONE
825 * side effects -
826 */
827 void
828 do_local_user(const char *nick, struct Client *client_p, struct Client *source_p,
829              const char *username, const char *host, const char *server,
830              const char *realname)
831 {
832  assert(source_p != NULL);
833  assert(source_p->username != username);
834
835  if (source_p == NULL)
836    return;
837
838  if (!IsUnknown(source_p))
839  {
840    sendto_one(source_p, form_str(ERR_ALREADYREGISTRED),
841               me.name, nick);
842    return;
843  }
844
845  source_p->localClient->registration &= ~REG_NEED_USER;
846
847  /*
848   * don't take the clients word for it, ever
849   */
850  source_p->servptr = &me;
851
852  strlcpy(source_p->info, realname, sizeof(source_p->info));
853
854  /* stash for later */
855  strlcpy(source_p->client_host, host, sizeof(source_p->client_host));
856  strlcpy(source_p->client_server, server, sizeof(source_p->client_server));
857
858  if (!IsGotId(source_p))
859  {
860    /* save the username in the client
861     * If you move this you'll break ping cookies..you've been warned
862     */
863    strlcpy(source_p->username, username, sizeof(source_p->username));
864  }
865
866  if (!source_p->localClient->registration)
867    /* NICK already received, now I have USER... */
868    register_local_user(client_p, source_p, source_p->name, username);
869 }
870
751   /* change_simple_umode()
752   *
753   * this callback can be hooked to allow special handling of
# Line 927 | Line 807 | set_user_mode(struct Client *client_p, s
807       return;
808    }
809  
810 <  if (source_p != target_p || target_p->from != source_p->from)
810 >  if (source_p != target_p)
811    {
812       sendto_one(source_p, form_str(ERR_USERSDONTMATCH),
813                  me.name, source_p->name);
# Line 985 | Line 865 | set_user_mode(struct Client *client_p, s
865                break;
866  
867              ClearOper(source_p);
988            source_p->umodes &= ~ConfigFileEntry.oper_only_umodes;
868              Count.oper--;
869  
870              if (MyConnect(source_p))
# Line 994 | Line 873 | set_user_mode(struct Client *client_p, s
873  
874                detach_conf(source_p, OPER_TYPE);
875                ClearOperFlags(source_p);
876 +              source_p->umodes &= ~ConfigFileEntry.oper_only_umodes;
877  
878                if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
879                  free_dlink_node(dm);
# Line 1079 | Line 959 | void
959   send_umode(struct Client *client_p, struct Client *source_p,
960             unsigned int old, unsigned int sendmask, char *umode_buf)
961   {
962 +  char *m = umode_buf;
963    int what = 0;
964    unsigned int i;
965    unsigned int flag;
1085  char *m = umode_buf;
966  
967    /*
968     * build a string in umode_buf to represent the change in the user's
# Line 1152 | Line 1032 | send_umode_out(struct Client *client_p,
1032        struct Client *target_p = ptr->data;
1033  
1034        if ((target_p != client_p) && (target_p != source_p))
1035 <      {
1036 <        if ((!(ServerInfo.hub && IsCapable(target_p, CAP_LL))) ||
1037 <            (target_p->localClient->serverMask &
1158 <             source_p->lazyLinkClientExists))
1159 <          sendto_one(target_p, ":%s MODE %s :%s",
1160 <                     ID_or_name(source_p, target_p),
1161 <                     ID_or_name(source_p, target_p), buf);
1162 <      }
1035 >        sendto_one(target_p, ":%s MODE %s :%s",
1036 >                   ID_or_name(source_p, target_p),
1037 >                   ID_or_name(source_p, target_p), buf);
1038      }
1039    }
1040  
# Line 1207 | Line 1082 | user_welcome(struct Client *source_p)
1082  
1083    if (ConfigFileEntry.short_motd)
1084    {
1085 <    sendto_one(source_p, "NOTICE %s :*** Notice -- motd was last changed at %s",
1086 <               source_p->name, ConfigFileEntry.motd.lastChangedDate);
1085 >    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- motd was last changed at %s",
1086 >               me.name, source_p->name, ConfigFileEntry.motd.lastChangedDate);
1087      sendto_one(source_p,
1088 <               "NOTICE %s :*** Notice -- Please read the motd if you haven't "
1089 <               "read it", source_p->name);
1088 >               ":%s NOTICE %s :*** Notice -- Please read the motd if you haven't "
1089 >               "read it", me.name, source_p->name);
1090      sendto_one(source_p, form_str(RPL_MOTDSTART),
1091                 me.name, source_p->name, me.name);
1092      sendto_one(source_p, form_str(RPL_MOTD),
# Line 1254 | Line 1129 | check_xline(struct Client *source_p)
1129                           get_client_name(source_p, HIDE_IP),
1130                           source_p->sockhost);
1131  
1132 <    ServerStats->is_ref++;
1132 >    ++ServerStats.is_ref;
1133      if (REJECT_HOLD_TIME > 0)
1134      {
1135        sendto_one(source_p, ":%s NOTICE %s :Bad user info",
# Line 1299 | Line 1174 | oper_up(struct Client *source_p)
1174      source_p->umodes |= (UMODE_SERVNOTICE|UMODE_OPERWALL|
1175                           UMODE_WALLOP|UMODE_LOCOPS);
1176  
1177 +  if (!(old & UMODE_INVISIBLE) && IsInvisible(source_p))
1178 +    ++Count.invisi;
1179 +  if ((old & UMODE_INVISIBLE) && !IsInvisible(source_p))
1180 +    --Count.invisi;
1181 +
1182    assert(dlinkFind(&oper_list, source_p) == NULL);
1183    dlinkAdd(source_p, make_dlink_node(), &oper_list);
1184  
# Line 1325 | Line 1205 | static char new_uid[TOTALSIDUID + 1];
1205   int
1206   valid_sid(const char *sid)
1207   {
1328
1208    if (strlen(sid) == IRC_MAXSID)
1209      if (IsDigit(*sid))
1210        if (IsAlNum(*(sid + 1)) && IsAlNum(*(sid + 2)))
# Line 1350 | Line 1229 | init_uid(void)
1229  
1230    memset(new_uid, 0, sizeof(new_uid));
1231  
1232 <  if (ServerInfo.sid != NULL)
1354 <  {
1232 >  if (!EmptyString(ServerInfo.sid))
1233      strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1356    strlcpy(me.id, ServerInfo.sid, sizeof(me.id));
1234  
1235 <    hash_add_id(&me);
1359 <  }
1360 <
1361 <  for (i = 0; i < IRC_MAXSID; i++)
1235 >  for (i = 0; i < IRC_MAXSID; ++i)
1236      if (new_uid[i] == '\0')
1237        new_uid[i] = 'A';
1238  
# Line 1371 | Line 1245 | init_uid(void)
1245  
1246    entering_umode_cb = register_callback("entering_umode", NULL);
1247    umode_cb = register_callback("changing_umode", change_simple_umode);
1374  uid_get_cb = register_callback("uid_get", uid_get);
1248   }
1249  
1250   /*
# Line 1414 | Line 1287 | add_one_to_uid(int i)
1287   * output       - new UID is returned to caller
1288   * side effects - new_uid is incremented by one.
1289   */
1290 < static void *
1291 < uid_get(va_list args)
1290 > static const char *
1291 > uid_get(void)
1292   {
1293    add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1294    return new_uid;

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)