ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/user.c (file contents):
Revision 3896 by michael, Fri Jun 6 19:08:47 2014 UTC vs.
Revision 6156 by michael, Thu Jun 18 09:19:25 2015 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2015 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
22 < /*! \file s_user.c
22 > /*! \file user.c
23   * \brief User related functions.
24   * \version $Id$
25   */
# Line 40 | Line 40
40   #include "log.h"
41   #include "server.h"
42   #include "send.h"
43 #include "supported.h"
43   #include "memory.h"
44   #include "packet.h"
45   #include "rng_mt.h"
# Line 66 | Line 65 | struct Isupport
65   static dlink_list support_list;
66   static dlink_list support_list_lines;
67  
68 < /* memory is cheap. map 0-255 to equivalent mode */
69 < const unsigned int user_modes[256] =
68 > const struct user_modes *umode_map[256];
69 > const struct user_modes  umode_tab[] =
70   {
71 <  /* 0x00 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x0F */
72 <  /* 0x10 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x1F */
73 <  /* 0x20 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x2F */
74 <  /* 0x30 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x3F */
75 <  0,                  /* @ */
76 <  0,                  /* A */
77 <  0,                  /* B */
78 <  0,                  /* C */
79 <  UMODE_DEAF,         /* D */
80 <  0,                  /* E */
81 <  UMODE_FARCONNECT,   /* F */
82 <  UMODE_SOFTCALLERID, /* G */
83 <  UMODE_HIDDEN,       /* H */
84 <  0,                  /* I */
85 <  0,                  /* J */
86 <  0,                  /* K */
87 <  0,                  /* L */
88 <  0,                  /* M */
89 <  0,                  /* N */
90 <  0,                  /* O */
91 <  0,                  /* P */
92 <  0,                  /* Q */
93 <  UMODE_REGONLY,      /* R */
94 <  UMODE_SSL,          /* S */
95 <  0,                  /* T */
96 <  0,                  /* U */
97 <  0,                  /* V */
98 <  UMODE_WEBIRC,       /* W */
99 <  0,                  /* X */
101 <  0,                  /* Y */
102 <  0,                  /* Z 0x5A */
103 <  0, 0, 0, 0, 0,      /* 0x5F   */
104 <  0,                  /* 0x60   */
105 <  UMODE_ADMIN,        /* a */
106 <  UMODE_BOTS,         /* b */
107 <  UMODE_CCONN,        /* c */
108 <  UMODE_DEBUG,        /* d */
109 <  UMODE_EXTERNAL,     /* e */
110 <  UMODE_FULL,         /* f */
111 <  UMODE_CALLERID,     /* g */
112 <  0,                  /* h */
113 <  UMODE_INVISIBLE,    /* i */
114 <  UMODE_REJ,          /* j */
115 <  UMODE_SKILL,        /* k */
116 <  UMODE_LOCOPS,       /* l */
117 <  0,                  /* m */
118 <  UMODE_NCHANGE,      /* n */
119 <  UMODE_OPER,         /* o */
120 <  UMODE_HIDECHANS,    /* p */
121 <  UMODE_HIDEIDLE,     /* q */
122 <  UMODE_REGISTERED,   /* r */
123 <  UMODE_SERVNOTICE,   /* s */
124 <  0,                  /* t */
125 <  UMODE_UNAUTH,       /* u */
126 <  0,                  /* v */
127 <  UMODE_WALLOP,       /* w */
128 <  UMODE_HIDDENHOST,   /* x */
129 <  UMODE_SPY,          /* y */
130 <  0,                  /* z      0x7A */
131 <  0,0,0,0,0,          /* 0x7B - 0x7F */
132 <
133 <  /* 0x80 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x8F */
134 <  /* 0x90 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x9F */
135 <  /* 0xA0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xAF */
136 <  /* 0xB0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xBF */
137 <  /* 0xC0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xCF */
138 <  /* 0xD0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xDF */
139 <  /* 0xE0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xEF */
140 <  /* 0xF0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0  /* 0xFF */
71 >  { 'D', UMODE_DEAF         },
72 >  { 'F', UMODE_FARCONNECT   },
73 >  { 'G', UMODE_SOFTCALLERID },
74 >  { 'H', UMODE_HIDDEN       },
75 >  { 'R', UMODE_REGONLY      },
76 >  { 'S', UMODE_SSL          },
77 >  { 'W', UMODE_WEBIRC       },
78 >  { 'a', UMODE_ADMIN        },
79 >  { 'b', UMODE_BOTS         },
80 >  { 'c', UMODE_CCONN        },
81 >  { 'd', UMODE_DEBUG        },
82 >  { 'e', UMODE_EXTERNAL     },
83 >  { 'f', UMODE_FULL         },
84 >  { 'g', UMODE_CALLERID     },
85 >  { 'i', UMODE_INVISIBLE    },
86 >  { 'j', UMODE_REJ          },
87 >  { 'k', UMODE_SKILL        },
88 >  { 'l', UMODE_LOCOPS       },
89 >  { 'n', UMODE_NCHANGE      },
90 >  { 'o', UMODE_OPER         },
91 >  { 'p', UMODE_HIDECHANS    },
92 >  { 'q', UMODE_HIDEIDLE     },
93 >  { 'r', UMODE_REGISTERED   },
94 >  { 's', UMODE_SERVNOTICE   },
95 >  { 'u', UMODE_UNAUTH       },
96 >  { 'w', UMODE_WALLOP       },
97 >  { 'x', UMODE_HIDDENHOST   },
98 >  { 'y', UMODE_SPY          },
99 >  { '\0', 0 }
100   };
101  
102   void
103 < assemble_umode_buffer(void)
103 > user_usermodes_init(void)
104   {
146  unsigned int idx = 0;
105    char *umode_buffer_ptr = umode_buffer;
106  
107 <  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
108 <    if (user_modes[idx])
109 <      *umode_buffer_ptr++ = idx;
107 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
108 >  {
109 >    umode_map[tab->c] = tab;
110 >    *umode_buffer_ptr++ = tab->c;
111 >  }
112  
113    *umode_buffer_ptr = '\0';
114   }
# Line 163 | Line 123 | void
123   show_lusers(struct Client *source_p)
124   {
125    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
126 <    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total-Count.invisi),
127 <                       Count.invisi, dlink_list_length(&global_serv_list));
126 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
127 >                       Count.invisi, dlink_list_length(&global_server_list));
128    else
129 <    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT,
130 <                       (Count.total - Count.invisi), Count.invisi, 1);
129 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
130 >                       Count.invisi, 1);
131  
132    if (Count.oper)
133      sendto_one_numeric(source_p, &me, RPL_LUSEROP, Count.oper);
# Line 175 | Line 135 | show_lusers(struct Client *source_p)
135    if (dlink_list_length(&unknown_list))
136      sendto_one_numeric(source_p, &me, RPL_LUSERUNKNOWN, dlink_list_length(&unknown_list));
137  
138 <  if (dlink_list_length(&global_channel_list))
139 <    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&global_channel_list));
138 >  if (dlink_list_length(&channel_list))
139 >    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&channel_list));
140  
141    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
142    {
# Line 211 | Line 171 | show_lusers(struct Client *source_p)
171   void
172   show_isupport(struct Client *source_p)
173   {
174 <  const dlink_node *ptr = NULL;
174 >  const dlink_node *node = NULL;
175  
176 <  DLINK_FOREACH(ptr, support_list_lines.head)
177 <    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, ptr->data);
176 >  DLINK_FOREACH(node, support_list_lines.head)
177 >    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, node->data);
178   }
179  
180  
# Line 233 | Line 193 | report_and_set_user_flags(struct Client
193    if (IsConfDoSpoofIp(conf))
194      sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
195  
196 <  /* If this user is in the exception class, Set it "E lined" */
196 >  /* If this user is in the exception class, set it "E lined" */
197    if (IsConfExemptKline(conf))
198    {
199      SetExemptKline(source_p);
200 <    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D/G lines. Congrats.");
200 >    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D lines. Congrats.");
201    }
202  
203 <  /*
244 <   * The else here is to make sure that G line exempt users
245 <   * do not get noticed twice.
246 <   */
247 <  else if (IsConfExemptGline(conf))
203 >  if (IsConfExemptXline(conf))
204    {
205 <    SetExemptGline(source_p);
206 <    sendto_one_notice(source_p, &me, ":*** You are exempt from G lines. Congrats.");
205 >    SetExemptXline(source_p);
206 >    sendto_one_notice(source_p, &me, ":*** You are exempt from X lines. Congrats.");
207    }
208  
209    if (IsConfExemptResv(conf))
# Line 282 | Line 238 | report_and_set_user_flags(struct Client
238   static void
239   introduce_client(struct Client *source_p)
240   {
241 <  dlink_node *ptr = NULL;
241 >  dlink_node *node = NULL;
242    char ubuf[IRCD_BUFSIZE] = "";
243  
244    if (MyClient(source_p))
245 <    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
245 >    send_umode(source_p, source_p, 0, ubuf);
246    else
247 <    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
247 >    send_umode(NULL, source_p, 0, ubuf);
248  
249    watch_check_hash(source_p, RPL_LOGON);
250  
# Line 298 | Line 254 | introduce_client(struct Client *source_p
254      ubuf[1] = '\0';
255    }
256  
257 <  DLINK_FOREACH(ptr, serv_list.head)
257 >  DLINK_FOREACH(node, local_server_list.head)
258    {
259 <    struct Client *server = ptr->data;
259 >    struct Client *server = node->data;
260  
261      if (server == source_p->from)
262        continue;
263  
264      if (IsCapable(server, CAP_SVS))
265 <      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
265 >      sendto_one(server, ":%s UID %s %u %lu %s %s %s %s %s %s :%s",
266                   source_p->servptr->id,
267                   source_p->name, source_p->hopcount+1,
268                   (unsigned long)source_p->tsinfo,
269                   ubuf, source_p->username, source_p->host,
270 <                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
271 <                 "0" : source_p->sockhost, source_p->id,
316 <                 source_p->svid,
270 >                 source_p->sockhost, source_p->id,
271 >                 source_p->account,
272                   source_p->info);
273      else
274 <      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
274 >      sendto_one(server, ":%s UID %s %u %lu %s %s %s %s %s :%s",
275                   source_p->servptr->id,
276                   source_p->name, source_p->hopcount+1,
277                   (unsigned long)source_p->tsinfo,
278                   ubuf, source_p->username, source_p->host,
279 <                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
325 <                 "0" : source_p->sockhost, source_p->id, source_p->info);
279 >                 source_p->sockhost, source_p->id, source_p->info);
280  
281      if (!EmptyString(source_p->certfp))
282        sendto_one(server, ":%s CERTFP %s", source_p->id, source_p->certfp);
# Line 349 | Line 303 | user_welcome(struct Client *source_p)
303    {
304      AddUMode(source_p, UMODE_SSL);
305      sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
306 <                      ssl_get_cipher(source_p->localClient->fd.ssl));
306 >                      ssl_get_cipher(source_p->connection->fd.ssl));
307    }
308   #endif
309  
310 <  sendto_one_numeric(source_p, &me, RPL_WELCOME, ServerInfo.network_name,
310 >  sendto_one_numeric(source_p, &me, RPL_WELCOME, ConfigServerInfo.network_name,
311                       source_p->name);
312    sendto_one_numeric(source_p, &me, RPL_YOURHOST,
313 <                     get_listener_name(source_p->localClient->listener), ircd_version);
313 >                     get_listener_name(source_p->connection->listener), ircd_version);
314    sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
315    sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
316    show_isupport(source_p);
317 <
364 <  if (source_p->id[0])
365 <    sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
317 >  sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
318  
319    show_lusers(source_p);
320    motd_signon(source_p);
# Line 378 | Line 330 | static int
330   check_xline(struct Client *source_p)
331   {
332    struct MaskItem *conf = NULL;
333 <  const char *reason = NULL;
333 >
334 >  if (IsExemptXline(source_p))
335 >    return 0;
336  
337    if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
338    {
339      ++conf->count;
386
387    if (conf->reason)
388      reason = conf->reason;
389    else
390      reason = CONF_NOREASON;
391
340      sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
341                           "X-line Rejecting [%s] [%s], user %s [%s]",
342 <                         source_p->info, reason,
342 >                         source_p->info, conf->reason,
343                           get_client_name(source_p, HIDE_IP),
344                           source_p->sockhost);
345  
# Line 416 | Line 364 | register_local_user(struct Client *sourc
364  
365    assert(source_p == source_p->from);
366    assert(MyConnect(source_p));
367 <  assert(!source_p->localClient->registration);
367 >  assert(IsUnknown(source_p));
368 >  assert(!source_p->connection->registration);
369  
370 <  ClearCap(source_p, CAP_TS6);
422 <
423 <  if (ConfigFileEntry.ping_cookie)
370 >  if (ConfigGeneral.ping_cookie)
371    {
372 <    if (!IsPingSent(source_p) && !source_p->localClient->random_ping)
372 >    if (!IsPingSent(source_p) && !source_p->connection->random_ping)
373      {
374        do
375 <        source_p->localClient->random_ping = genrand_int32();
376 <      while (!source_p->localClient->random_ping);
375 >        source_p->connection->random_ping = genrand_int32();
376 >      while (!source_p->connection->random_ping);
377  
378 <      sendto_one(source_p, "PING :%u",
432 <                 source_p->localClient->random_ping);
378 >      sendto_one(source_p, "PING :%u", source_p->connection->random_ping);
379        SetPingSent(source_p);
380        return;
381      }
# Line 438 | Line 384 | register_local_user(struct Client *sourc
384        return;
385    }
386  
387 <  source_p->localClient->last_privmsg = CurrentTime;
387 >  source_p->connection->last_privmsg = CurrentTime;
388    /* Straight up the maximum rate of flooding... */
389 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
389 >  source_p->connection->allow_read = MAX_FLOOD_BURST;
390  
391    if (!check_client(source_p))
392      return;
# Line 449 | Line 395 | register_local_user(struct Client *sourc
395    {
396      sendto_one_notice(source_p, &me, ":*** Notice -- You have an illegal "
397                        "character in your hostname");
398 <    strlcpy(source_p->host, source_p->sockhost,
453 <            sizeof(source_p->host));
398 >    strlcpy(source_p->host, source_p->sockhost, sizeof(source_p->host));
399    }
400  
401 <  conf = source_p->localClient->confs.head->data;
401 >  conf = source_p->connection->confs.head->data;
402  
403    if (!IsGotId(source_p))
404    {
# Line 476 | Line 421 | register_local_user(struct Client *sourc
421        source_p->username[i++] = '~';
422  
423      for (; *p && i < USERLEN; ++p)
424 <      if (*p != '[')
480 <        source_p->username[i++] = *p;
424 >      source_p->username[i++] = *p;
425  
426      source_p->username[i] = '\0';
427    }
# Line 485 | Line 429 | register_local_user(struct Client *sourc
429    /* Password check */
430    if (!EmptyString(conf->passwd))
431    {
432 <    if (!match_conf_password(source_p->localClient->passwd, conf))
432 >    if (!match_conf_password(source_p->connection->password, conf))
433      {
434        ++ServerStats.is_ref;
435  
# Line 496 | Line 440 | register_local_user(struct Client *sourc
440    }
441  
442    /*
443 <   * Don't free source_p->localClient->passwd here - it can be required
444 <   * by masked /stats I if there are auth{} blocks with need_password = no;
443 >   * Don't free source_p->connection->password here - it can be required
444 >   * by masked /stats I if there are auth {} blocks with need_password = no;
445     * --adx
446     */
447  
# Line 517 | Line 461 | register_local_user(struct Client *sourc
461     * probably be just a percentage of the MAXCLIENTS...
462     *   -Taner
463     */
464 <  if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
465 <      (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
464 >  if ((Count.local >= GlobalSetOptions.maxclients + MAX_BUFFER) ||
465 >      (Count.local >= GlobalSetOptions.maxclients && !IsExemptLimits(source_p)))
466    {
467      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
468                           "Too many clients, rejecting %s[%s].",
# Line 553 | Line 497 | register_local_user(struct Client *sourc
497    sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
498                         "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
499                         source_p->name, source_p->username, source_p->host,
500 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
501 <                       "255.255.255.255" : source_p->sockhost,
558 <                       get_client_class(&source_p->localClient->confs),
500 >                       source_p->sockhost,
501 >                       get_client_class(&source_p->connection->confs),
502                         source_p->info, source_p->id);
503  
504 <  if (ConfigFileEntry.invisible_on_connect)
504 >  if (ConfigGeneral.invisible_on_connect)
505    {
506      AddUMode(source_p, UMODE_INVISIBLE);
507      ++Count.invisi;
# Line 570 | Line 513 | register_local_user(struct Client *sourc
513  
514      if (!(Count.max_loc % 10))
515        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
516 <                           "New Max Local Clients: %d",
516 >                           "New maximum local client connections: %u",
517                             Count.max_loc);
518    }
519  
# Line 581 | Line 524 | register_local_user(struct Client *sourc
524    assert(source_p->servptr == &me);
525    SetClient(source_p);
526    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
527 +  dlinkAdd(source_p, &source_p->node, &global_client_list);
528  
529    assert(dlinkFind(&unknown_list, source_p));
530  
531 <  dlink_move_node(&source_p->localClient->lclient_node,
531 >  dlink_move_node(&source_p->connection->lclient_node,
532                    &unknown_list, &local_client_list);
533  
534    user_welcome(source_p);
# Line 605 | Line 549 | register_local_user(struct Client *sourc
549   *                is introduced by a server.
550   */
551   void
552 < register_remote_user(struct Client *source_p, const char *username,
609 <                     const char *host, const char *server)
552 > register_remote_user(struct Client *source_p)
553   {
554 <  struct Client *target_p = NULL;
612 <
613 <  assert(source_p->username != username);
614 <
615 <  strlcpy(source_p->host, host, sizeof(source_p->host));
616 <  strlcpy(source_p->username, username, sizeof(source_p->username));
617 <
618 <  /*
619 <   * Coming from another server, take the servers word for it
620 <   */
621 <  source_p->servptr = hash_find_server(server);
622 <
623 <  /*
624 <   * Super GhostDetect:
625 <   * If we can't find the server the user is supposed to be on,
626 <   * then simply blow the user away.        -Taner
627 <   */
628 <  if (source_p->servptr == NULL)
629 <  {
630 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
631 <                         "No server %s for user %s[%s@%s] from %s",
632 <                         server, source_p->name, source_p->username,
633 <                         source_p->host, source_p->from->name);
634 <    sendto_one(source_p->from,
635 <               ":%s KILL %s :%s (Ghosted, server %s doesn't exist)",
636 <               me.id, source_p->id, me.name, server);
637 <
638 <    AddFlag(source_p, FLAGS_KILLED);
639 <    exit_client(source_p, "Ghosted Client");
640 <    return;
641 <  }
554 >  const struct Client *target_p = NULL;
555  
556    if ((target_p = source_p->servptr) && target_p->from != source_p->from)
557    {
# Line 648 | Line 561 | register_remote_user(struct Client *sour
561                           source_p->host, source_p->servptr->name,
562                           target_p->name, target_p->from->name);
563      sendto_one(source_p->from,
564 <               ":%s KILL %s :%s (NICK from wrong direction (%s != %s))",
564 >               ":%s KILL %s :%s (UID from wrong direction (%s != %s))",
565                 me.id, source_p->id, me.name, source_p->servptr->name,
566                 target_p->from->name);
567  
568      AddFlag(source_p, FLAGS_KILLED);
569 <    exit_client(source_p, "USER server wrong direction");
569 >    exit_client(source_p, "UID server wrong direction");
570      return;
571    }
572  
# Line 669 | Line 582 | register_remote_user(struct Client *sour
582  
583    SetClient(source_p);
584    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
585 +  dlinkAdd(source_p, &source_p->node, &global_client_list);
586    add_user_host(source_p->username, source_p->host, 1);
587    SetUserHost(source_p);
588  
589    if (HasFlag(source_p->servptr, FLAGS_EOB))
590      sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
591 <                         "Client connecting at %s: %s (%s@%s) [%s] <%s>",
591 >                         "Client connecting at %s: %s (%s@%s) [%s] [%s] <%s>",
592                           source_p->servptr->name,
593                           source_p->name, source_p->username, source_p->host,
594 <                         source_p->info, source_p->id);
594 >                         source_p->sockhost, source_p->info, source_p->id);
595  
596    introduce_client(source_p);
597   }
# Line 742 | Line 656 | valid_username(const char *username, con
656    {
657      while (*++p)
658      {
659 <      if (*p == '.' && ConfigFileEntry.dots_in_ident)
659 >      if (*p == '.' && ConfigGeneral.dots_in_ident)
660        {
661 <        if (++dots > ConfigFileEntry.dots_in_ident)
661 >        if (++dots > ConfigGeneral.dots_in_ident)
662            return 0;
663          if (!IsUserChar(*(p + 1)))
664            return 0;
# Line 775 | Line 689 | valid_nickname(const char *nickname, con
689   {
690    const char *p = nickname;
691  
692 <  assert(nickname && *nickname);
692 >  assert(p);
693  
694    /*
695     * Nicks can't start with a digit or - or be 0 length.
696     */
697 <  if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
697 >  if (EmptyString(p) || *p == '-' || (IsDigit(*p) && local))
698      return 0;
699  
700    for (; *p; ++p)
# Line 803 | Line 717 | valid_nickname(const char *nickname, con
717   */
718   void
719   send_umode(struct Client *client_p, struct Client *source_p,
720 <           unsigned int old, unsigned int sendmask, char *umode_buf)
720 >           unsigned int old, char *umode_buf)
721   {
722    char *m = umode_buf;
723    int what = 0;
# Line 812 | Line 726 | send_umode(struct Client *client_p, stru
726     * Build a string in umode_buf to represent the change in the user's
727     * mode between the new (source_p->umodes) and 'old'.
728     */
729 <  for (unsigned int i = 0; i < 128; ++i)
729 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
730    {
731 <    unsigned int flag = user_modes[i];
818 <
819 <    if (!flag)
820 <      continue;
821 <
822 <    if (MyClient(source_p) && !(flag & sendmask))
823 <      continue;
824 <
825 <    if ((flag & old) && !HasUMode(source_p, flag))
731 >    if ((tab->flag & old) && !HasUMode(source_p, tab->flag))
732      {
733        if (what == MODE_DEL)
734 <        *m++ = (char)i;
734 >        *m++ = tab->c;
735        else
736        {
737          what = MODE_DEL;
738          *m++ = '-';
739 <        *m++ = (char)i;
739 >        *m++ = tab->c;
740        }
741      }
742 <    else if (!(flag & old) && HasUMode(source_p, flag))
742 >    else if (!(tab->flag & old) && HasUMode(source_p, tab->flag))
743      {
744        if (what == MODE_ADD)
745 <        *m++ = (char)i;
745 >        *m++ = tab->c;
746        else
747        {
748          what = MODE_ADD;
749          *m++ = '+';
750 <        *m++ = (char)i;
750 >        *m++ = tab->c;
751        }
752      }
753    }
# Line 850 | Line 756 | send_umode(struct Client *client_p, stru
756  
757    if (*umode_buf && client_p)
758      sendto_one(client_p, ":%s!%s@%s MODE %s :%s",
759 <               source_p->name, source_p->username,
760 <               source_p->host, source_p->name, umode_buf);
759 >               client_p->name, client_p->username,
760 >               client_p->host, client_p->name, umode_buf);
761   }
762  
763   /* send_umode_out()
# Line 861 | Line 767 | send_umode(struct Client *client_p, stru
767   * side effects - Only send ubuf out to servers that know about this client
768   */
769   void
770 < send_umode_out(struct Client *client_p, struct Client *source_p,
865 <               unsigned int old)
770 > send_umode_out(struct Client *source_p, unsigned int old)
771   {
772    char buf[IRCD_BUFSIZE] = "";
773  
774 <  send_umode(NULL, source_p, old, SEND_UMODES, buf);
774 >  send_umode(MyClient(source_p) ? source_p : NULL, source_p, old, buf);
775  
776    if (buf[0])
777 <    sendto_server(source_p, NOCAPS, NOCAPS, ":%s MODE %s :%s",
777 >    sendto_server(source_p, 0, 0, ":%s MODE %s :%s",
778                    source_p->id, source_p->id, buf);
874
875  if (client_p && MyClient(client_p))
876    send_umode(client_p, source_p, old, 0xffffffff, buf);
779   }
780  
781   void
782   user_set_hostmask(struct Client *target_p, const char *hostname, const int what)
783   {
784 <  dlink_node *ptr = NULL;
784 >  dlink_node *node = NULL;
785  
786    if (!strcmp(target_p->host, hostname))
787      return;
# Line 888 | Line 790 | user_set_hostmask(struct Client *target_
790    {
791      case MODE_ADD:
792        AddUMode(target_p, UMODE_HIDDENHOST);
891      AddFlag(target_p, FLAGS_IP_SPOOFING);
793        break;
794      case MODE_DEL:
795        DelUMode(target_p, UMODE_HIDDENHOST);
895
896      if (!HasFlag(target_p, FLAGS_AUTH_SPOOF))
897        DelFlag(target_p, FLAGS_IP_SPOOFING);
796        break;
797      default: return;
798    }
799  
800 <  if (ConfigFileEntry.cycle_on_host_change)
800 >  if (ConfigGeneral.cycle_on_host_change)
801      sendto_common_channels_local(target_p, 0, 0, ":%s!%s@%s QUIT :Changing hostname",
802                                   target_p->name, target_p->username, target_p->host);
803  
# Line 913 | Line 811 | user_set_hostmask(struct Client *target_
811  
812    if (MyClient(target_p))
813    {
814 <    sendto_one_numeric(target_p, &me, RPL_NEWHOSTIS, target_p->host);
814 >    sendto_one_numeric(target_p, &me, RPL_VISIBLEHOST, target_p->host);
815      clear_ban_cache_client(target_p);
816    }
817  
818 <  if (!ConfigFileEntry.cycle_on_host_change)
818 >  if (!ConfigGeneral.cycle_on_host_change)
819      return;
820  
821 <  DLINK_FOREACH(ptr, target_p->channel.head)
821 >  DLINK_FOREACH(node, target_p->channel.head)
822    {
823      char modebuf[4], nickbuf[NICKLEN * 3 + 3] = "";
824      char *p = modebuf;
825      int len = 0;
826 <    const struct Membership *ms = ptr->data;
826 >    const struct Membership *member = node->data;
827  
828 <    if (has_member_flags(ms, CHFL_CHANOP))
828 >    if (has_member_flags(member, CHFL_CHANOP))
829      {
830        *p++ = 'o';
831        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
832      }
833  
834 <    if (has_member_flags(ms, CHFL_HALFOP))
834 >    if (has_member_flags(member, CHFL_HALFOP))
835      {
836        *p++ = 'h';
837        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
838      }
839  
840 <    if (has_member_flags(ms, CHFL_VOICE))
840 >    if (has_member_flags(member, CHFL_VOICE))
841      {
842        *p++ = 'v';
843        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
# Line 947 | Line 845 | user_set_hostmask(struct Client *target_
845  
846      *p = '\0';
847  
848 <    sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s!%s@%s JOIN :%s",
849 <                                target_p->name, target_p->username, target_p->host,
850 <                                ms->chptr->chname);
848 >
849 >    sendto_channel_local_butone(target_p, CAP_EXTENDED_JOIN, 0, member->chptr, ":%s!%s@%s JOIN %s %s :%s",
850 >                                target_p->name, target_p->username,
851 >                                target_p->host, member->chptr->name,
852 >                                (!IsDigit(target_p->account[0]) && target_p->account[0] != '*') ? target_p->account : "*",
853 >                                target_p->info);
854 >    sendto_channel_local_butone(target_p, 0, CAP_EXTENDED_JOIN, member->chptr, ":%s!%s@%s JOIN :%s",
855 >                                target_p->name, target_p->username,
856 >                                target_p->host, member->chptr->name);
857 >
858      if (nickbuf[0])
859 <      sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s MODE %s +%s %s",
860 <                                  target_p->servptr->name, ms->chptr->chname,
859 >      sendto_channel_local_butone(target_p, 0, 0, member->chptr, ":%s MODE %s +%s %s",
860 >                                  target_p->servptr->name, member->chptr->name,
861                                    modebuf, nickbuf);
862  
863    }
# Line 972 | Line 877 | void
877   oper_up(struct Client *source_p)
878   {
879    const unsigned int old = source_p->umodes;
880 <  const struct MaskItem *conf = source_p->localClient->confs.head->data;
880 >  const struct MaskItem *const conf = source_p->connection->confs.head->data;
881  
882 <  assert(source_p->localClient->confs.head);
882 >  assert(source_p->connection->confs.head);
883  
884    ++Count.oper;
885    SetOper(source_p);
886  
887    if (conf->modes)
888      AddUMode(source_p, conf->modes);
889 <  else if (ConfigFileEntry.oper_umodes)
890 <    AddUMode(source_p, ConfigFileEntry.oper_umodes);
889 >  else if (ConfigGeneral.oper_umodes)
890 >    AddUMode(source_p, ConfigGeneral.oper_umodes);
891  
892    if (!(old & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
893      ++Count.invisi;
# Line 997 | Line 902 | oper_up(struct Client *source_p)
902    if (HasOFlag(source_p, OPER_FLAG_ADMIN))
903      AddUMode(source_p, UMODE_ADMIN);
904  
905 +  if (!EmptyString(conf->whois))
906 +  {
907 +    client_attach_svstag(source_p, RPL_WHOISOPERATOR, "+", conf->whois);
908 +    sendto_server(source_p, 0, 0, ":%s SVSTAG %s %lu %u + :%s",
909 +                  me.id, source_p->id, (unsigned long)source_p->tsinfo,
910 +                  RPL_WHOISOPERATOR, conf->whois);
911 +  }
912 +
913    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
914                         get_oper_name(source_p));
915 <  send_umode_out(source_p, source_p, old);
915 >  sendto_server(NULL, 0, 0, ":%s GLOBOPS :%s is now an operator",
916 >                me.id, get_oper_name(source_p));
917 >  send_umode_out(source_p, old);
918    sendto_one_numeric(source_p, &me, RPL_YOUREOPER);
919   }
920  
# Line 1022 | Line 937 | valid_sid(const char *sid)
937   * inputs       - NONE
938   * output       - NONE
939   * side effects - new_uid is filled in with server id portion (sid)
940 < *                (first 3 bytes) or defaulted to 'A'.
941 < *                Rest is filled in with 'A'
940 > *                (first 3 bytes). Rest is filled in with '9'.
941 > *
942   */
943   void
944   init_uid(void)
945   {
946 <  memset(new_uid, 0, sizeof(new_uid));
1032 <
1033 <  if (!EmptyString(ServerInfo.sid))
1034 <    strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1035 <
1036 <  for (unsigned int i = 0; i < IRC_MAXSID; ++i)
1037 <    if (new_uid[i] == '\0')
1038 <      new_uid[i] = 'A';
1039 <
1040 <  /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1041 <  memcpy(new_uid + IRC_MAXSID, "AAAAA@", IRC_MAXUID);
946 >  snprintf(new_uid, sizeof(new_uid), "%s999999", me.id);
947   }
948  
949   /*
# Line 1052 | Line 957 | init_uid(void)
957   static void
958   add_one_to_uid(unsigned int i)
959   {
960 <  if (i != IRC_MAXSID)  /* Not reached server SID portion yet? */
960 >  if (i < IRC_MAXSID)
961 >    return;
962 >
963 >  if (new_uid[i] == 'Z')
964 >    new_uid[i] = '0';
965 >  else if (new_uid[i] == '9')
966    {
967 <    if (new_uid[i] == 'Z')
968 <      new_uid[i] = '0';
1059 <    else if (new_uid[i] == '9')
1060 <    {
1061 <      new_uid[i] = 'A';
1062 <      add_one_to_uid(i - 1);
1063 <    }
1064 <    else
1065 <      ++new_uid[i];
967 >    new_uid[i] = 'A';
968 >    add_one_to_uid(i - 1);
969    }
970    else
971 <  {
1069 <    /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1070 <    if (new_uid[i] == 'Z')
1071 <      memcpy(new_uid + IRC_MAXSID, "AAAAAA", IRC_MAXUID);
1072 <    else
1073 <      ++new_uid[i];
1074 <  }
971 >    ++new_uid[i];
972   }
973  
974   /*
# Line 1099 | Line 996 | void
996   init_isupport(void)
997   {
998    add_isupport("CALLERID", NULL, -1);
999 <  add_isupport("CASEMAPPING", CASEMAP, -1);
999 >  add_isupport("CASEMAPPING", "rfc1459", -1);
1000    add_isupport("DEAF", "D", -1);
1001    add_isupport("KICKLEN", NULL, KICKLEN);
1002    add_isupport("MODES", NULL, MAXMODEPARAMS);
1003    add_isupport("PREFIX", "(ohv)@%+", -1);
1004    add_isupport("STATUSMSG", "@%+", -1);
1005 <  add_isupport("EXCEPTS", "e", -1);
1006 <  add_isupport("INVEX", "I", -1);
1005 >  add_isupport("EXCEPTS", NULL, -1);
1006 >  add_isupport("INVEX", NULL, -1);
1007   }
1008  
1009   /*
# Line 1121 | Line 1018 | init_isupport(void)
1018   void
1019   add_isupport(const char *name, const char *options, int n)
1020   {
1021 <  dlink_node *ptr;
1021 >  dlink_node *node = NULL;
1022    struct Isupport *support = NULL;
1023  
1024 <  DLINK_FOREACH(ptr, support_list.head)
1024 >  DLINK_FOREACH(node, support_list.head)
1025    {
1026 <    support = ptr->data;
1026 >    support = node->data;
1027      if (irccmp(support->name, name) == 0)
1028      {
1029        MyFree(support->name);
# Line 1135 | Line 1032 | add_isupport(const char *name, const cha
1032      }
1033    }
1034  
1035 <  if (ptr == NULL)
1035 >  if (node == NULL)
1036    {
1037      support = MyCalloc(sizeof(*support));
1038      dlinkAddTail(support, &support->node, &support_list);
# Line 1159 | Line 1056 | add_isupport(const char *name, const cha
1056   void
1057   delete_isupport(const char *name)
1058   {
1059 <  dlink_node *ptr;
1163 <  struct Isupport *support;
1059 >  dlink_node *node = NULL;
1060  
1061 <  DLINK_FOREACH(ptr, support_list.head)
1061 >  DLINK_FOREACH(node, support_list.head)
1062    {
1063 <    support = ptr->data;
1063 >    struct Isupport *support = node->data;
1064 >
1065      if (irccmp(support->name, name) == 0)
1066      {
1067 <      dlinkDelete(ptr, &support_list);
1067 >      dlinkDelete(node, &support_list);
1068        MyFree(support->name);
1069        MyFree(support->options);
1070        MyFree(support);
# Line 1190 | Line 1087 | rebuild_isupport_message_line(void)
1087   {
1088    char isupportbuffer[IRCD_BUFSIZE];
1089    char *p = isupportbuffer;
1090 <  dlink_node *ptr = NULL, *ptr_next = NULL;
1090 >  dlink_node *node = NULL, *node_next = NULL;
1091    int n = 0;
1092    int tokens = 0;
1093    size_t len = 0;
1094    size_t reserve = strlen(me.name) + HOSTLEN + strlen(numeric_form(RPL_ISUPPORT));
1095  
1096 <  DLINK_FOREACH_SAFE(ptr, ptr_next, support_list_lines.head)
1096 >  DLINK_FOREACH_SAFE(node, node_next, support_list_lines.head)
1097    {
1098 <    dlinkDelete(ptr, &support_list_lines);
1099 <    MyFree(ptr->data);
1100 <    free_dlink_node(ptr);
1098 >    dlinkDelete(node, &support_list_lines);
1099 >    MyFree(node->data);
1100 >    free_dlink_node(node);
1101    }
1102  
1103 <  DLINK_FOREACH(ptr, support_list.head)
1103 >  DLINK_FOREACH(node, support_list.head)
1104    {
1105 <    struct Isupport *support = ptr->data;
1105 >    struct Isupport *support = node->data;
1106  
1107      p += (n = sprintf(p, "%s", support->name));
1108      len += n;

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)