ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing:
ircd-hybrid-7.2/src/s_user.c (file contents), Revision 889 by michael, Thu Nov 1 12:59:05 2007 UTC vs.
ircd-hybrid/trunk/src/user.c (file contents), Revision 4962 by michael, Mon Dec 1 13:08:31 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_user.c: User related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 16 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file s_user.c
23 > * \brief User related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28 < #include "tools.h"
29 < #include "s_user.h"
28 < #include "s_misc.h"
28 > #include "list.h"
29 > #include "user.h"
30   #include "channel.h"
31   #include "channel_mode.h"
32   #include "client.h"
32 #include "common.h"
33 #include "fdlist.h"
33   #include "hash.h"
34   #include "irc_string.h"
36 #include "sprintf_irc.h"
37 #include "s_bsd.h"
38 #include "irc_getnameinfo.h"
35   #include "ircd.h"
40 #include "list.h"
36   #include "listener.h"
37   #include "motd.h"
38   #include "numeric.h"
39 < #include "s_conf.h"
40 < #include "s_log.h"
41 < #include "s_serv.h"
47 < #include "s_stats.h"
39 > #include "conf.h"
40 > #include "log.h"
41 > #include "server.h"
42   #include "send.h"
49 #include "supported.h"
50 #include "whowas.h"
43   #include "memory.h"
44   #include "packet.h"
45 + #include "rng_mt.h"
46   #include "userhost.h"
47 < #include "hook.h"
48 < #include "s_misc.h"
56 < #include "msg.h"
57 < #include "pcre.h"
47 > #include "misc.h"
48 > #include "parse.h"
49   #include "watch.h"
50  
60 int MaxClientCount     = 1;
61 int MaxConnectionCount = 1;
62 struct Callback *entering_umode_cb = NULL;
63 struct Callback *umode_cb = NULL;
64 struct Callback *uid_get_cb = NULL;
65
51   static char umode_buffer[IRCD_BUFSIZE];
52 <
68 < static void user_welcome(struct Client *);
69 < static void report_and_set_user_flags(struct Client *, const struct AccessItem *);
70 < static int check_xline(struct Client *);
71 < static void introduce_client(struct Client *, struct Client *);
72 < static void *uid_get(va_list);
52 > static const char *uid_get(void);
53  
54   /* Used for building up the isupport string,
55   * used with init_isupport, add_isupport, delete_isupport
56   */
57 <
78 < struct Isupport
57 > struct Isupport
58   {
59    dlink_node node;
60    char *name;
# Line 83 | Line 62 | struct Isupport
62    int number;
63   };
64  
65 < static dlink_list support_list = { NULL, NULL, 0 };
66 < MessageFile *isupportFile;
65 > static dlink_list support_list;
66 > static dlink_list support_list_lines;
67  
68   /* memory is cheap. map 0-255 to equivalent mode */
69 < unsigned int user_modes[256] =
69 > const unsigned int user_modes[256] =
70   {
71    /* 0x00 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x0F */
72    /* 0x10 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x1F */
# Line 96 | Line 75 | unsigned int user_modes[256] =
75    0,                  /* @ */
76    0,                  /* A */
77    0,                  /* B */
78 <  UMODE_CCONN_FULL,   /* C */
78 >  0,                  /* C */
79    UMODE_DEAF,         /* D */
80    0,                  /* E */
81 <  0,                  /* F */
81 >  UMODE_FARCONNECT,   /* F */
82    UMODE_SOFTCALLERID, /* G */
83 <  0,                  /* H */
83 >  UMODE_HIDDEN,       /* H */
84    0,                  /* I */
85    0,                  /* J */
86    0,                  /* K */
# Line 111 | Line 90 | unsigned int user_modes[256] =
90    0,                  /* O */
91    0,                  /* P */
92    0,                  /* Q */
93 <  0,                  /* R */
94 <  0,                  /* S */
93 >  UMODE_REGONLY,      /* R */
94 >  UMODE_SSL,          /* S */
95    0,                  /* T */
96    0,                  /* U */
97    0,                  /* V */
98 <  0,                  /* W */
98 >  UMODE_WEBIRC,       /* W */
99    0,                  /* X */
100    0,                  /* Y */
101    0,                  /* Z 0x5A */
102 <  0, 0, 0, 0, 0,      /* 0x5F   */
102 >  0, 0, 0, 0, 0,      /* 0x5F   */
103    0,                  /* 0x60   */
104    UMODE_ADMIN,        /* a */
105    UMODE_BOTS,         /* b */
106    UMODE_CCONN,        /* c */
107    UMODE_DEBUG,        /* d */
108 <  0,                  /* e */
108 >  UMODE_EXTERNAL,     /* e */
109    UMODE_FULL,         /* f */
110    UMODE_CALLERID,     /* g */
111    0,                  /* h */
112    UMODE_INVISIBLE,    /* i */
113 <  0,                  /* j */
113 >  UMODE_REJ,          /* j */
114    UMODE_SKILL,        /* k */
115    UMODE_LOCOPS,       /* l */
116    0,                  /* m */
117    UMODE_NCHANGE,      /* n */
118    UMODE_OPER,         /* o */
119 <  0,                  /* p */
120 <  0,                  /* q */
121 <  UMODE_REJ,          /* r */
119 >  UMODE_HIDECHANS,    /* p */
120 >  UMODE_HIDEIDLE,     /* q */
121 >  UMODE_REGISTERED,   /* r */
122    UMODE_SERVNOTICE,   /* s */
123    0,                  /* t */
124    UMODE_UNAUTH,       /* u */
125    0,                  /* v */
126    UMODE_WALLOP,       /* w */
127 <  UMODE_EXTERNAL,     /* x */
127 >  UMODE_HIDDENHOST,   /* x */
128    UMODE_SPY,          /* y */
129 <  UMODE_OPERWALL,     /* z      0x7A */
129 >  0,                  /* z      0x7A */
130    0,0,0,0,0,          /* 0x7B - 0x7F */
131  
132    /* 0x80 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x8F */
# Line 166 | Line 145 | assemble_umode_buffer(void)
145    unsigned int idx = 0;
146    char *umode_buffer_ptr = umode_buffer;
147  
148 <  for (; idx < (sizeof(user_modes) / sizeof(int)); ++idx)
148 >  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
149      if (user_modes[idx])
150        *umode_buffer_ptr++ = idx;
151  
# Line 180 | Line 159 | assemble_umode_buffer(void)
159   * side effects - display to client user counts etc.
160   */
161   void
162 < show_lusers(struct Client *source_p)
162 > show_lusers(struct Client *source_p)
163   {
164 <  const char *from, *to;
164 >  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
165 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
166 >                       Count.invisi, dlink_list_length(&global_server_list));
167 >  else
168 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
169 >                       Count.invisi, 1);
170 >
171 >  if (Count.oper)
172 >    sendto_one_numeric(source_p, &me, RPL_LUSEROP, Count.oper);
173 >
174 >  if (dlink_list_length(&unknown_list))
175 >    sendto_one_numeric(source_p, &me, RPL_LUSERUNKNOWN, dlink_list_length(&unknown_list));
176  
177 <  if (!MyConnect(source_p) && IsCapable(source_p->from, CAP_TS6) && HasID(source_p))
177 >  if (dlink_list_length(&channel_list))
178 >    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&channel_list));
179 >
180 >  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
181    {
182 <    from = me.id;
183 <    to = source_p->id;
182 >    sendto_one_numeric(source_p, &me, RPL_LUSERME, Count.local, Count.myserver);
183 >    sendto_one_numeric(source_p, &me, RPL_LOCALUSERS, Count.local, Count.max_loc);
184    }
185    else
186    {
187 <    from = me.name;
188 <    to = source_p->name;
187 >    sendto_one_numeric(source_p, &me, RPL_LUSERME, Count.total, 0);
188 >    sendto_one_numeric(source_p, &me, RPL_LOCALUSERS, Count.total, Count.max_tot);
189    }
190  
191 <  if (!ConfigServerHide.hide_servers || IsOper(source_p))
199 <    sendto_one(source_p, form_str(RPL_LUSERCLIENT),
200 <               from, to, (Count.total-Count.invisi),
201 <               Count.invisi, dlink_list_length(&global_serv_list));
202 <  else
203 <    sendto_one(source_p, form_str(RPL_LUSERCLIENT), from, to,
204 <               (Count.total-Count.invisi), Count.invisi, 1);
191 >  sendto_one_numeric(source_p, &me, RPL_GLOBALUSERS, Count.total, Count.max_tot);
192  
193 <  if (Count.oper > 0)
194 <    sendto_one(source_p, form_str(RPL_LUSEROP),
195 <               from, to, Count.oper);
209 <
210 <  if (dlink_list_length(&unknown_list) > 0)
211 <    sendto_one(source_p, form_str(RPL_LUSERUNKNOWN),
212 <               from, to, dlink_list_length(&unknown_list));
213 <
214 <  if (dlink_list_length(&global_channel_list) > 0)
215 <    sendto_one(source_p, form_str(RPL_LUSERCHANNELS),
216 <               from, to, dlink_list_length(&global_channel_list));
217 <
218 <  if (!ConfigServerHide.hide_servers || IsOper(source_p))
219 <  {
220 <    sendto_one(source_p, form_str(RPL_LUSERME),
221 <               from, to, Count.local, Count.myserver);
222 <    sendto_one(source_p, form_str(RPL_LOCALUSERS),
223 <               from, to, Count.local, Count.max_loc,
224 <               Count.local, Count.max_loc);
225 <  }
226 <  else
227 <  {
228 <    sendto_one(source_p, form_str(RPL_LUSERME),
229 <               from, to, Count.total, 0);
230 <    sendto_one(source_p, form_str(RPL_LOCALUSERS),
231 <               from, to, Count.total, Count.max_tot,
232 <               Count.total, Count.max_tot);
233 <  }
234 <
235 <  sendto_one(source_p, form_str(RPL_GLOBALUSERS),
236 <             from, to, Count.total, Count.max_tot,
237 <             Count.total, Count.max_tot);
238 <
239 <  if (!ConfigServerHide.hide_servers || IsOper(source_p))
240 <    sendto_one(source_p, form_str(RPL_STATSCONN), from, to,
241 <               MaxConnectionCount, MaxClientCount, Count.totalrestartcount);
193 >  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
194 >    sendto_one_numeric(source_p, &me, RPL_STATSCONN, Count.max_loc_con,
195 >                       Count.max_loc_cli, Count.totalrestartcount);
196  
197 <  if (Count.local > MaxClientCount)
198 <    MaxClientCount = Count.local;
197 >  if (Count.local > Count.max_loc_cli)
198 >    Count.max_loc_cli = Count.local;
199  
200 <  if ((Count.local + Count.myserver) > MaxConnectionCount)
201 <    MaxConnectionCount = Count.local + Count.myserver;
200 >  if ((Count.local + Count.myserver) > Count.max_loc_con)
201 >    Count.max_loc_con = Count.local + Count.myserver;
202   }
203  
204   /* show_isupport()
# Line 254 | Line 208 | show_lusers(struct Client *source_p)
208   * side effects - display to client what we support (for them)
209   */
210   void
211 < show_isupport(struct Client *source_p)
211 > show_isupport(struct Client *source_p)
212   {
213 <  send_message_file(source_p, isupportFile);
213 >  const dlink_node *node = NULL;
214 >
215 >  DLINK_FOREACH(node, support_list_lines.head)
216 >    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, node->data);
217   }
218  
219 < /*
220 < ** register_local_user
221 < **      This function is called when both NICK and USER messages
222 < **      have been accepted for the client, in whatever order. Only
223 < **      after this, is the USER message propagated.
224 < **
225 < **      NICK's must be propagated at once when received, although
226 < **      it would be better to delay them too until full info is
227 < **      available. Doing it is not so simple though, would have
228 < **      to implement the following:
229 < **
230 < **      (actually it has been implemented already for a while) -orabidoo
231 < **
232 < **      1) user telnets in and gives only "NICK foobar" and waits
233 < **      2) another user far away logs in normally with the nick
234 < **         "foobar" (quite legal, as this server didn't propagate
235 < **         it).
236 < **      3) now this server gets nick "foobar" from outside, but
237 < **         has alread the same defined locally. Current server
238 < **         would just issue "KILL foobar" to clean out dups. But,
239 < **         this is not fair. It should actually request another
240 < **         nick from local user or kill him/her...
241 < */
219 >
220 > /* report_and_set_user_flags()
221 > *
222 > * inputs       - pointer to source_p
223 > *              - pointer to conf for this user
224 > * output       - NONE
225 > * side effects - Report to user any special flags
226 > *                they are getting, and set them.
227 > */
228 > static void
229 > report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
230 > {
231 >  /* If this user is being spoofed, tell them so */
232 >  if (IsConfDoSpoofIp(conf))
233 >    sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
234 >
235 >  /* If this user is in the exception class, set it "E lined" */
236 >  if (IsConfExemptKline(conf))
237 >  {
238 >    SetExemptKline(source_p);
239 >    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D/G lines. Congrats.");
240 >  }
241 >
242 >  /*
243 >   * The else here is to make sure that G line exempt users
244 >   * do not get noticed twice.
245 >   */
246 >  else if (IsConfExemptGline(conf))
247 >  {
248 >    SetExemptGline(source_p);
249 >    sendto_one_notice(source_p, &me, ":*** You are exempt from G lines. Congrats.");
250 >  }
251 >
252 >  if (IsConfExemptResv(conf))
253 >  {
254 >    SetExemptResv(source_p);
255 >    sendto_one_notice(source_p, &me, ":*** You are exempt from resvs. Congrats.");
256 >  }
257 >
258 >  /* If this user is exempt from user limits set it "F lined" */
259 >  if (IsConfExemptLimits(conf))
260 >  {
261 >    SetExemptLimits(source_p);
262 >    sendto_one_notice(source_p, &me, ":*** You are exempt from user limits. Congrats.");
263 >  }
264 >
265 >  if (IsConfCanFlood(conf))
266 >  {
267 >    SetCanFlood(source_p);
268 >    sendto_one_notice(source_p, &me, ":*** You are exempt from flood "
269 >                      "protection, aren't you fearsome.");
270 >  }
271 > }
272 >
273 > /* introduce_client()
274 > *
275 > * inputs       - source_p
276 > * output       - NONE
277 > * side effects - This common function introduces a client to the rest
278 > *                of the net, either from a local client connect or
279 > *                from a remote connect.
280 > */
281 > static void
282 > introduce_client(struct Client *source_p)
283 > {
284 >  dlink_node *node = NULL;
285 >  char ubuf[IRCD_BUFSIZE] = "";
286 >
287 >  if (MyClient(source_p))
288 >    send_umode(source_p, source_p, 0, ubuf);
289 >  else
290 >    send_umode(NULL, source_p, 0, ubuf);
291 >
292 >  watch_check_hash(source_p, RPL_LOGON);
293 >
294 >  if (ubuf[0] == '\0')
295 >  {
296 >    ubuf[0] = '+';
297 >    ubuf[1] = '\0';
298 >  }
299 >
300 >  DLINK_FOREACH(node, local_server_list.head)
301 >  {
302 >    struct Client *server = node->data;
303 >
304 >    if (server == source_p->from)
305 >      continue;
306 >
307 >    if (IsCapable(server, CAP_SVS))
308 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
309 >                 source_p->servptr->id,
310 >                 source_p->name, source_p->hopcount+1,
311 >                 (unsigned long)source_p->tsinfo,
312 >                 ubuf, source_p->username, source_p->host,
313 >                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
314 >                 "0" : source_p->sockhost, source_p->id,
315 >                 source_p->account,
316 >                 source_p->info);
317 >    else
318 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
319 >                 source_p->servptr->id,
320 >                 source_p->name, source_p->hopcount+1,
321 >                 (unsigned long)source_p->tsinfo,
322 >                 ubuf, source_p->username, source_p->host,
323 >                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
324 >                 "0" : source_p->sockhost, source_p->id, source_p->info);
325 >
326 >    if (!EmptyString(source_p->certfp))
327 >      sendto_one(server, ":%s CERTFP %s", source_p->id, source_p->certfp);
328 >  }
329 > }
330 >
331 > /* user_welcome()
332 > *
333 > * inputs       - client pointer to client to welcome
334 > * output       - NONE
335 > * side effects -
336 > */
337 > static void
338 > user_welcome(struct Client *source_p)
339 > {
340 > #if defined(__TIME__) && defined(__DATE__)
341 >  static const char built_date[] = __DATE__ " at " __TIME__;
342 > #else
343 >  static const char built_date[] = "unknown";
344 > #endif
345 >
346 > #ifdef HAVE_LIBCRYPTO
347 >  if (HasFlag(source_p, FLAGS_SSL))
348 >  {
349 >    AddUMode(source_p, UMODE_SSL);
350 >    sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
351 >                      ssl_get_cipher(source_p->connection->fd.ssl));
352 >  }
353 > #endif
354 >
355 >  sendto_one_numeric(source_p, &me, RPL_WELCOME, ConfigServerInfo.network_name,
356 >                     source_p->name);
357 >  sendto_one_numeric(source_p, &me, RPL_YOURHOST,
358 >                     get_listener_name(source_p->connection->listener), ircd_version);
359 >  sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
360 >  sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
361 >  show_isupport(source_p);
362 >  sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
363 >
364 >  show_lusers(source_p);
365 >  motd_signon(source_p);
366 > }
367 >
368 > /* check_xline()
369 > *
370 > * inputs       - pointer to client to test
371 > * outupt       - 1 if exiting 0 if ok
372 > * side effects -
373 > */
374 > static int
375 > check_xline(struct Client *source_p)
376 > {
377 >  struct MaskItem *conf = NULL;
378 >
379 >  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
380 >  {
381 >    ++conf->count;
382 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
383 >                         "X-line Rejecting [%s] [%s], user %s [%s]",
384 >                         source_p->info, conf->reason,
385 >                         get_client_name(source_p, HIDE_IP),
386 >                         source_p->sockhost);
387 >
388 >    ++ServerStats.is_ref;
389 >    exit_client(source_p, "Bad user info");
390 >    return 1;
391 >  }
392 >
393 >  return 0;
394 > }
395 >
396 > /*! \brief This function is called when both NICK and USER messages
397 > *      have been accepted for the client, in whatever order. Only
398 > *      after this, is the UID message propagated.
399 > * \param source_p Pointer to given client to introduce
400 > */
401   void
402 < register_local_user(struct Client *client_p, struct Client *source_p,
287 <                    const char *nick, const char *username)
402 > register_local_user(struct Client *source_p)
403   {
404 <  const struct AccessItem *aconf = NULL;
405 <  char ipaddr[HOSTIPLEN];
291 <  dlink_node *ptr = NULL;
292 <  dlink_node *m = NULL;
404 >  const char *id = NULL;
405 >  const struct MaskItem *conf = NULL;
406  
407 <  assert(source_p != NULL);
407 >  assert(source_p == source_p->from);
408    assert(MyConnect(source_p));
409 <  assert(source_p->username != username);
297 <  assert(!source_p->localClient->registration);
409 >  assert(!source_p->connection->registration);
410  
411 <  ClearCap(client_p, CAP_TS6);
411 >  ClearCap(source_p, CAP_TS6);
412  
413 <  if (ConfigFileEntry.ping_cookie)
413 >  if (ConfigGeneral.ping_cookie)
414    {
415 <    if (!IsPingSent(source_p) &&
304 <       source_p->localClient->random_ping == 0)
415 >    if (!IsPingSent(source_p) && !source_p->connection->random_ping)
416      {
417 <      source_p->localClient->random_ping = (unsigned long)rand();
418 <      sendto_one(source_p, "PING :%lu",
419 <                 source_p->localClient->random_ping);
417 >      do
418 >        source_p->connection->random_ping = genrand_int32();
419 >      while (!source_p->connection->random_ping);
420 >
421 >      sendto_one(source_p, "PING :%u", source_p->connection->random_ping);
422        SetPingSent(source_p);
423        return;
424      }
# Line 314 | Line 427 | register_local_user(struct Client *clien
427        return;
428    }
429  
430 <  source_p->localClient->last = CurrentTime;
430 >  source_p->connection->last_privmsg = CurrentTime;
431    /* Straight up the maximum rate of flooding... */
432 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
432 >  source_p->connection->allow_read = MAX_FLOOD_BURST;
433  
434 <  if (!execute_callback(client_check_cb, source_p, username))
434 >  if (!check_client(source_p))
435      return;
436  
437 <  if (valid_hostname(source_p->host) == 0)
437 >  if (!valid_hostname(source_p->host))
438    {
439 <    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You have an illegal "
440 <               "character in your hostname", me.name, source_p->name);
441 <    strlcpy(source_p->host, source_p->sockhost,
329 <            sizeof(source_p->host));
439 >    sendto_one_notice(source_p, &me, ":*** Notice -- You have an illegal "
440 >                      "character in your hostname");
441 >    strlcpy(source_p->host, source_p->sockhost, sizeof(source_p->host));
442    }
443  
444 <  ptr   = source_p->localClient->confs.head;
333 <  aconf = map_to_conf(ptr->data);
444 >  conf = source_p->connection->confs.head->data;
445  
446    if (!IsGotId(source_p))
447    {
448 <    const char *p = NULL;
448 >    char username[USERLEN + 1] = "";
449 >    const char *p = username;
450      unsigned int i = 0;
451  
452 <    if (IsNeedIdentd(aconf))
452 >    if (IsNeedIdentd(conf))
453      {
454 <      ServerStats->is_ref++;
455 <      sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You need to install "
456 <                 "identd to use this server", me.name, source_p->name);
457 <      exit_client(source_p, &me, "Install identd");
454 >      ++ServerStats.is_ref;
455 >      sendto_one_notice(source_p, &me, ":*** Notice -- You need to install "
456 >                        "identd to use this server");
457 >      exit_client(source_p, "Install identd");
458        return;
459      }
460  
461 <    p = username;
461 >    strlcpy(username, source_p->username, sizeof(username));
462  
463 <    if (!IsNoTilde(aconf))
463 >    if (!IsNoTilde(conf))
464        source_p->username[i++] = '~';
465  
466 <    while (*p && i < USERLEN)
467 <    {
356 <      if (*p != '[')
357 <        source_p->username[i++] = *p;
358 <      p++;
359 <    }
466 >    for (; *p && i < USERLEN; ++p)
467 >      source_p->username[i++] = *p;
468  
469      source_p->username[i] = '\0';
470    }
471  
472 <  /* password check */
473 <  if (!EmptyString(aconf->passwd))
472 >  /* Password check */
473 >  if (!EmptyString(conf->passwd))
474    {
475 <    const char *pass = source_p->localClient->passwd;
368 <
369 <    if (!match_conf_password(pass, aconf))
475 >    if (!match_conf_password(source_p->connection->password, conf))
476      {
477 <      ServerStats->is_ref++;
478 <      sendto_one(source_p, form_str(ERR_PASSWDMISMATCH),
479 <                 me.name, source_p->name);
480 <      exit_client(source_p, &me, "Bad Password");
477 >      ++ServerStats.is_ref;
478 >
479 >      sendto_one_numeric(source_p, &me, ERR_PASSWDMISMATCH);
480 >      exit_client(source_p, "Bad Password");
481        return;
482      }
483    }
484  
485 <  /* don't free source_p->localClient->passwd here - it can be required
486 <   * by masked /stats I if there are auth{} blocks with need_password = no;
485 >  /*
486 >   * Don't free source_p->connection->password here - it can be required
487 >   * by masked /stats I if there are auth {} blocks with need_password = no;
488     * --adx
489     */
490  
491 <  /* report if user has &^>= etc. and set flags as needed in source_p */
492 <  report_and_set_user_flags(source_p, aconf);
491 >  /*
492 >   * Report if user has &^>= etc. and set flags as needed in source_p
493 >   */
494 >  report_and_set_user_flags(source_p, conf);
495  
496 <  /* Limit clients -
496 >  if (IsDead(source_p))
497 >    return;
498 >
499 >  /*
500 >   * Limit clients -
501     * We want to be able to have servers and F-line clients
502     * connect, so save room for "buffer" connections.
503     * Smaller servers may want to decrease this, and it should
504     * probably be just a percentage of the MAXCLIENTS...
505     *   -Taner
506     */
507 <  /* Except "F:" clients */
508 <  if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
396 <      (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
507 >  if ((Count.local >= ConfigServerInfo.max_clients + MAX_BUFFER) ||
508 >      (Count.local >= ConfigServerInfo.max_clients && !IsExemptLimits(source_p)))
509    {
510 <    sendto_realops_flags(UMODE_FULL, L_ALL,
510 >    sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
511                           "Too many clients, rejecting %s[%s].",
512 <                         nick, source_p->host);
513 <    ServerStats->is_ref++;
514 <    exit_client(source_p, &me, "Sorry, server is full - try later");
512 >                         source_p->name, source_p->host);
513 >    ++ServerStats.is_ref;
514 >    exit_client(source_p, "Sorry, server is full - try later");
515      return;
516    }
517  
518 <  /* valid user name check */
407 <  if (valid_username(source_p->username) == 0)
518 >  if (!valid_username(source_p->username, 1))
519    {
520 <    char tmpstr2[IRCD_BUFSIZE];
520 >    char buf[IRCD_BUFSIZE] = "";
521  
522 <    sendto_realops_flags(UMODE_REJ, L_ALL, "Invalid username: %s (%s@%s)",
523 <                         nick, source_p->username, source_p->host);
524 <    ServerStats->is_ref++;
525 <    ircsprintf(tmpstr2, "Invalid username [%s]", source_p->username);
526 <    exit_client(source_p, &me, tmpstr2);
522 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
523 >                         "Invalid username: %s (%s@%s)",
524 >                         source_p->name, source_p->username, source_p->host);
525 >    ++ServerStats.is_ref;
526 >    snprintf(buf, sizeof(buf), "Invalid username [%s]", source_p->username);
527 >    exit_client(source_p, buf);
528      return;
529    }
530  
419  assert(source_p == client_p);
420
531    if (check_xline(source_p))
532      return;
533  
534 <  if (IsDead(client_p))
535 <    return;
426 <
427 <  if (me.id[0])
428 <  {
429 <    const char *id = execute_callback(uid_get_cb, source_p);
534 >  while (hash_find_id((id = uid_get())))
535 >    ;
536  
537 <    while (hash_find_id(id) != NULL)
538 <      id = uid_get(NULL);
537 >  strlcpy(source_p->id, id, sizeof(source_p->id));
538 >  hash_add_id(source_p);
539  
540 <    strlcpy(source_p->id, id, sizeof(source_p->id));
541 <    hash_add_id(source_p);
542 <  }
543 <
544 <  irc_getnameinfo((struct sockaddr *)&source_p->localClient->ip,
545 <                  source_p->localClient->ip.ss_len, ipaddr,
546 <                  HOSTIPLEN, NULL, 0, NI_NUMERICHOST);
441 <
442 <  sendto_realops_flags(UMODE_CCONN, L_ALL,
443 <                       "Client connecting: %s (%s@%s) [%s] {%s} [%s]",
444 <                       nick, source_p->username, source_p->host,
445 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
446 <                       "255.255.255.255" : ipaddr, get_client_class(source_p),
447 <                       source_p->info);
448 <
449 <  sendto_realops_flags(UMODE_CCONN_FULL, L_ALL,
450 <                       "CLICONN %s %s %s %s %s %s %s 0 %s",
451 <                       nick, source_p->username, source_p->host,
452 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
453 <                       "255.255.255.255" : ipaddr,
454 <                       get_client_class(source_p),
455 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
456 <                           "<hidden>" : source_p->client_host,
457 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
458 <                           "<hidden>" : source_p->client_server,
459 <                       source_p->info);
460 <
461 <
462 <  /* If they have died in send_* don't do anything. */
463 <  if (IsDead(source_p))
464 <    return;
540 >  sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
541 >                       "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
542 >                       source_p->name, source_p->username, source_p->host,
543 >                       ConfigGeneral.hide_spoof_ips && IsIPSpoof(source_p) ?
544 >                       "255.255.255.255" : source_p->sockhost,
545 >                       get_client_class(&source_p->connection->confs),
546 >                       source_p->info, source_p->id);
547  
548 <  if (ConfigFileEntry.invisible_on_connect)
548 >  if (ConfigGeneral.invisible_on_connect)
549    {
550 <    source_p->umodes |= UMODE_INVISIBLE;
551 <    Count.invisi++;
550 >    AddUMode(source_p, UMODE_INVISIBLE);
551 >    ++Count.invisi;
552    }
553  
554 <  if ((++Count.local) > Count.max_loc)
554 >  if (++Count.local > Count.max_loc)
555    {
556      Count.max_loc = Count.local;
557  
558      if (!(Count.max_loc % 10))
559 <      sendto_realops_flags(UMODE_ALL, L_ALL, "New Max Local Clients: %d",
559 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
560 >                           "New maximum local client connections: %u",
561                             Count.max_loc);
562    }
563  
481  SetClient(source_p);
482
483  source_p->servptr = &me;
484  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
485
486  /* Increment our total user count here */
564    if (++Count.total > Count.max_tot)
565      Count.max_tot = Count.total;
566 <  Count.totalrestartcount++;
566 >  ++Count.totalrestartcount;
567 >
568 >  assert(source_p->servptr == &me);
569 >  SetClient(source_p);
570 >  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
571 >  dlinkAdd(source_p, &source_p->node, &global_client_list);
572  
573 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
573 >  assert(dlinkFind(&unknown_list, source_p));
574  
575 <  if ((m = dlinkFindDelete(&unknown_list, source_p)) != NULL)
576 <  {
495 <    free_dlink_node(m);
496 <    dlinkAdd(source_p, &source_p->localClient->lclient_node, &local_client_list);
497 <  }
498 <  else assert(0);
575 >  dlink_move_node(&source_p->connection->lclient_node,
576 >                  &unknown_list, &local_client_list);
577  
578    user_welcome(source_p);
579    add_user_host(source_p->username, source_p->host, 0);
580    SetUserHost(source_p);
581  
582 <  introduce_client(client_p, source_p);
582 >  introduce_client(source_p);
583   }
584  
585   /* register_remote_user()
586   *
587 < * inputs       - client_p directly connected client
510 < *              - source_p remote or directly connected client
587 > * inputs       - source_p remote or directly connected client
588   *              - username to register as
589   *              - host name to register as
590   *              - server name
514 *              - realname (gecos)
591   * output       - NONE
592   * side effects - This function is called when a remote client
593   *                is introduced by a server.
594   */
595   void
596 < register_remote_user(struct Client *client_p, struct Client *source_p,
597 <                     const char *username, const char *host, const char *server,
598 <                     const char *realname)
523 < {
524 <  struct Client *target_p = NULL;
525 <
526 <  assert(source_p != NULL);
527 <  assert(source_p->username != username);
528 <
529 <  strlcpy(source_p->host, host, sizeof(source_p->host));
530 <  strlcpy(source_p->info, realname, sizeof(source_p->info));
531 <  strlcpy(source_p->username, username, sizeof(source_p->username));
532 <
533 <  /*
534 <   * coming from another server, take the servers word for it
535 <   */
536 <  source_p->servptr = find_server(server);
537 <
538 <  /* Super GhostDetect:
539 <   * If we can't find the server the user is supposed to be on,
540 <   * then simply blow the user away.        -Taner
541 <   */
542 <  if (source_p->servptr == NULL)
543 <  {
544 <    sendto_realops_flags(UMODE_ALL, L_ALL,
545 <                         "No server %s for user %s[%s@%s] from %s",
546 <                         server, source_p->name, source_p->username,
547 <                         source_p->host, source_p->from->name);
548 <    kill_client(client_p, source_p, "%s (Server doesn't exist)", me.name);
549 <
550 <    SetKilled(source_p);
551 <    exit_client(source_p, &me, "Ghosted Client");
552 <    return;
553 <  }
596 > register_remote_user(struct Client *source_p)
597 > {
598 >  const struct Client *target_p = NULL;
599  
600    if ((target_p = source_p->servptr) && target_p->from != source_p->from)
601    {
602 <    sendto_realops_flags(UMODE_DEBUG, L_ALL,
602 >    sendto_realops_flags(UMODE_DEBUG, L_ALL, SEND_NOTICE,
603                           "Bad User [%s] :%s USER %s@%s %s, != %s[%s]",
604 <                         client_p->name, source_p->name, source_p->username,
604 >                         source_p->from->name, source_p->name, source_p->username,
605                           source_p->host, source_p->servptr->name,
606                           target_p->name, target_p->from->name);
607 <    kill_client(client_p, source_p,
608 <                "%s (NICK from wrong direction (%s != %s))",
609 <                me.name, source_p->servptr->name, target_p->from->name);
610 <    SetKilled(source_p);
611 <    exit_client(source_p, &me, "USER server wrong direction");
607 >    sendto_one(source_p->from,
608 >               ":%s KILL %s :%s (NICK from wrong direction (%s != %s))",
609 >               me.id, source_p->id, me.name, source_p->servptr->name,
610 >               target_p->from->name);
611 >
612 >    AddFlag(source_p, FLAGS_KILLED);
613 >    exit_client(source_p, "USER server wrong direction");
614      return;
615    }
616  
617 <  /* Increment our total user count here */
617 >  /*
618 >   * If the nick has been introduced by a services server,
619 >   * make it a service as well.
620 >   */
621 >  if (HasFlag(source_p->servptr, FLAGS_SERVICE))
622 >    AddFlag(source_p, FLAGS_SERVICE);
623 >
624    if (++Count.total > Count.max_tot)
625      Count.max_tot = Count.total;
626  
627    SetClient(source_p);
628    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
629 +  dlinkAdd(source_p, &source_p->node, &global_client_list);
630    add_user_host(source_p->username, source_p->host, 1);
631    SetUserHost(source_p);
632  
633 <  introduce_client(client_p, source_p);
634 < }
633 >  if (HasFlag(source_p->servptr, FLAGS_EOB))
634 >    sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
635 >                         "Client connecting at %s: %s (%s@%s) [%s] <%s>",
636 >                         source_p->servptr->name,
637 >                         source_p->name, source_p->username, source_p->host,
638 >                         source_p->info, source_p->id);
639  
640 < /* introduce_client()
583 < *
584 < * inputs       - client_p
585 < *              - source_p
586 < * output       - NONE
587 < * side effects - This common function introduces a client to the rest
588 < *                of the net, either from a local client connect or
589 < *                from a remote connect.
590 < */
591 < static void
592 < introduce_client(struct Client *client_p, struct Client *source_p)
593 < {
594 <  dlink_node *server_node = NULL;
595 <  static char ubuf[12];
596 <
597 <  if (MyClient(source_p))
598 <    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
599 <  else
600 <    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
601 <
602 <  watch_check_hash(source_p, RPL_LOGON);
603 <
604 <  if (*ubuf == '\0')
605 <  {
606 <    ubuf[0] = '+';
607 <    ubuf[1] = '\0';
608 <  }
609 <
610 <  DLINK_FOREACH(server_node, serv_list.head)
611 <  {
612 <    struct Client *server = server_node->data;
613 <
614 <    if (server == client_p)
615 <        continue;
616 <
617 <    if (IsCapable(server, CAP_TS6) && HasID(source_p))
618 <      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
619 <                 source_p->servptr->id,
620 <                 source_p->name, source_p->hopcount+1,
621 <                 (unsigned long)source_p->tsinfo,
622 <                 ubuf, source_p->username, source_p->host,
623 <                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
624 <                 "0" : source_p->sockhost, source_p->id, source_p->info);
625 <    else
626 <      sendto_one(server, "NICK %s %d %lu %s %s %s %s :%s",
627 <                 source_p->name, source_p->hopcount+1,
628 <                 (unsigned long)source_p->tsinfo,
629 <                 ubuf, source_p->username, source_p->host,
630 <                 source_p->servptr->name, source_p->info);
631 <  }
640 >  introduce_client(source_p);
641   }
642  
643   /* valid_hostname()
# Line 645 | Line 654 | valid_hostname(const char *hostname)
654   {
655    const char *p = hostname;
656  
657 <  assert(p != NULL);
657 >  assert(p);
658  
659 <  if ('.' == *p || ':' == *p)
659 >  if (EmptyString(p) || *p == '.' || *p == ':')
660      return 0;
661  
662 <  while (*p)
654 <  {
662 >  for (; *p; ++p)
663      if (!IsHostChar(*p))
664        return 0;
657    p++;
658  }
665  
666 <  return 1;
666 >  return p - hostname <= HOSTLEN;
667   }
668  
669   /* valid_username()
# Line 672 | Line 678 | valid_hostname(const char *hostname)
678   * style of username
679   */
680   int
681 < valid_username(const char *username)
681 > valid_username(const char *username, const int local)
682   {
683 <  int dots      = 0;
683 >  unsigned int dots = 0;
684    const char *p = username;
685  
686 <  assert(p != NULL);
686 >  assert(p);
687  
688 <  if ('~' == *p)
688 >  if (*p == '~')
689      ++p;
690  
691 <  /* reject usernames that don't start with an alphanum
691 >  /*
692 >   * Reject usernames that don't start with an alphanum
693     * i.e. reject jokers who have '-@somehost' or '.@somehost'
694     * or "-hi-@somehost", "h-----@somehost" would still be accepted.
695     */
696    if (!IsAlNum(*p))
697      return 0;
698  
699 <  while (*++p)
699 >  if (local)
700    {
701 <    if ((*p == '.') && ConfigFileEntry.dots_in_ident)
701 >    while (*++p)
702      {
703 <      dots++;
704 <
705 <      if (dots > ConfigFileEntry.dots_in_ident)
706 <        return 0;
707 <      if (!IsUserChar(p[1]))
703 >      if (*p == '.' && ConfigGeneral.dots_in_ident)
704 >      {
705 >        if (++dots > ConfigGeneral.dots_in_ident)
706 >          return 0;
707 >        if (!IsUserChar(*(p + 1)))
708 >          return 0;
709 >      }
710 >      else if (!IsUserChar(*p))
711          return 0;
712      }
703    else if (!IsUserChar(*p))
704      return 0;
713    }
714 <
707 <  return 1;
708 < }
709 <
710 < /* report_and_set_user_flags()
711 < *
712 < * inputs       - pointer to source_p
713 < *              - pointer to aconf for this user
714 < * output       - NONE
715 < * side effects - Report to user any special flags
716 < *                they are getting, and set them.
717 < */
718 < static void
719 < report_and_set_user_flags(struct Client *source_p, const struct AccessItem *aconf)
720 < {
721 <  /* If this user is being spoofed, tell them so */
722 <  if (IsConfDoSpoofIp(aconf))
723 <  {
724 <    sendto_one(source_p,
725 <               ":%s NOTICE %s :*** Spoofing your IP. congrats.",
726 <               me.name, source_p->name);
727 <  }
728 <
729 <  /* If this user is in the exception class, Set it "E lined" */
730 <  if (IsConfExemptKline(aconf))
731 <  {
732 <    SetExemptKline(source_p);
733 <    sendto_one(source_p,
734 <               ":%s NOTICE %s :*** You are exempt from K/D/G lines. congrats.",
735 <               me.name, source_p->name);
736 <  }
737 <
738 <  /* The else here is to make sure that G line exempt users
739 <   * do not get noticed twice.
740 <   */
741 <  else if (IsConfExemptGline(aconf))
742 <  {
743 <    SetExemptGline(source_p);
744 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from G lines.",
745 <               me.name, source_p->name);
746 <  }
747 <
748 <  if (IsConfExemptResv(aconf))
749 <  {
750 <    SetExemptResv(source_p);
751 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from resvs.",
752 <               me.name, source_p->name);
753 <  }
754 <
755 <  /* If this user is exempt from user limits set it "F lined" */
756 <  if (IsConfExemptLimits(aconf))
757 <  {
758 <    SetExemptLimits(source_p);
759 <    sendto_one(source_p,
760 <               ":%s NOTICE %s :*** You are exempt from user limits. congrats.",
761 <               me.name,source_p->name);
762 <  }
763 <
764 <  /* If this user is exempt from idle time outs */
765 <  if (IsConfIdlelined(aconf))
714 >  else
715    {
716 <    SetIdlelined(source_p);
717 <    sendto_one(source_p,
718 <               ":%s NOTICE %s :*** You are exempt from idle limits. congrats.",
770 <               me.name, source_p->name);
716 >    while (*++p)
717 >      if (!IsUserChar(*p))
718 >        return 0;
719    }
720  
721 <  if (IsConfCanFlood(aconf))
774 <  {
775 <    SetCanFlood(source_p);
776 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from flood "
777 <               "protection, aren't you fearsome.",
778 <               me.name, source_p->name);
779 <  }
721 >  return p - username <= USERLEN;
722   }
723  
724 < /* do_local_user()
724 > /* clean_nick_name()
725   *
726 < * inputs       -
727 < * output       - NONE
728 < * side effects -
726 > * input        - nickname
727 > *              - whether it's a local nick (1) or remote (0)
728 > * output       - none
729 > * side effects - walks through the nickname, returning 0 if erroneous
730   */
731 < void
732 < do_local_user(const char *nick, struct Client *client_p, struct Client *source_p,
790 <              const char *username, const char *host, const char *server,
791 <              const char *realname)
731 > int
732 > valid_nickname(const char *nickname, const int local)
733   {
734 <  assert(source_p != NULL);
794 <  assert(source_p->username != username);
734 >  const char *p = nickname;
735  
736 <  if (source_p == NULL)
797 <    return;
798 <
799 <  if (!IsUnknown(source_p))
800 <  {
801 <    sendto_one(source_p, form_str(ERR_ALREADYREGISTRED),
802 <               me.name, nick);
803 <    return;
804 <  }
805 <
806 <  source_p->localClient->registration &= ~REG_NEED_USER;
736 >  assert(nickname && *nickname);
737  
738    /*
739 <   * don't take the clients word for it, ever
739 >   * Nicks can't start with a digit or - or be 0 length.
740     */
741 <  source_p->servptr = &me;
742 <
813 <  strlcpy(source_p->info, realname, sizeof(source_p->info));
814 <
815 <  /* stash for later */
816 <  strlcpy(source_p->client_host, host, sizeof(source_p->client_host));
817 <  strlcpy(source_p->client_server, server, sizeof(source_p->client_server));
818 <
819 <  if (!IsGotId(source_p))
820 <  {
821 <    /* save the username in the client
822 <     * If you move this you'll break ping cookies..you've been warned
823 <     */
824 <    strlcpy(source_p->username, username, sizeof(source_p->username));
825 <  }
826 <
827 <  if (!source_p->localClient->registration)
828 <    /* NICK already received, now I have USER... */
829 <    register_local_user(client_p, source_p, source_p->name, username);
830 < }
831 <
832 < /* change_simple_umode()
833 < *
834 < * this callback can be hooked to allow special handling of
835 < * certain usermodes
836 < */
837 < static void *
838 < change_simple_umode(va_list args)
839 < {
840 <  struct Client *client_p;
841 <  struct Client *source_p;
842 <  int what;
843 <  unsigned int flag;
844 <
845 <  client_p = va_arg(args, struct Client *);
846 <  source_p = va_arg(args, struct Client *);
847 <  what = va_arg(args, int);
848 <  flag = va_arg(args, unsigned int);
849 <
850 <  if (what == MODE_ADD)
851 <    source_p->umodes |= flag;
852 <  else
853 <    source_p->umodes &= ~flag;
854 <
855 <  return NULL;
856 < }
857 <
858 < /* set_user_mode()
859 < *
860 < * added 15/10/91 By Darren Reed.
861 < * parv[0] - sender
862 < * parv[1] - username to change mode for
863 < * parv[2] - modes to change
864 < */
865 < void
866 < set_user_mode(struct Client *client_p, struct Client *source_p,
867 <              int parc, char *parv[])
868 < {
869 <  unsigned int flag, setflags;
870 <  char **p, *m, buf[IRCD_BUFSIZE];
871 <  struct Client *target_p;
872 <  int what = MODE_ADD, badflag = 0, i;
873 <
874 <  assert(!(parc < 2));
875 <
876 <  if ((target_p = find_person(client_p, parv[1])) == NULL)
877 <  {
878 <    if (MyConnect(source_p))
879 <      sendto_one(source_p, form_str(ERR_NOSUCHCHANNEL),
880 <                 me.name, source_p->name, parv[1]);
881 <    return;
882 <  }
883 <
884 <  if (IsServer(source_p))
885 <  {
886 <     sendto_realops_flags(UMODE_ALL, L_ADMIN, "*** Mode for User %s from %s",
887 <                          parv[1], source_p->name);
888 <     return;
889 <  }
890 <
891 <  if (source_p != target_p || target_p->from != source_p->from)
892 <  {
893 <     sendto_one(source_p, form_str(ERR_USERSDONTMATCH),
894 <                me.name, source_p->name);
895 <     return;
896 <  }
897 <
898 <  if (parc < 3)
899 <  {
900 <    m = buf;
901 <    *m++ = '+';
902 <
903 <    for (i = 0; i < 128; i++)
904 <      if (source_p->umodes & user_modes[i])
905 <        *m++ = (char)i;
906 <    *m = '\0';
907 <
908 <    sendto_one(source_p, form_str(RPL_UMODEIS),
909 <               me.name, source_p->name, buf);
910 <    return;
911 <  }
912 <
913 <  execute_callback(entering_umode_cb, client_p, source_p);
914 <
915 <  /* find flags already set for user */
916 <  setflags = source_p->umodes;
917 <
918 <  /* parse mode change string(s) */
919 <  for (p = &parv[2]; p && *p; p++)
920 <  {
921 <    for (m = *p; *m; m++)
922 <    {
923 <      switch (*m)
924 <      {
925 <        case '+':
926 <          what = MODE_ADD;
927 <          break;
928 <        case '-':
929 <          what = MODE_DEL;
930 <          break;
931 <        case 'o':
932 <          if (what == MODE_ADD)
933 <          {
934 <            if (IsServer(client_p) && !IsOper(source_p))
935 <            {
936 <              ++Count.oper;
937 <              SetOper(source_p);
938 <            }
939 <          }
940 <          else
941 <          {
942 <            /* Only decrement the oper counts if an oper to begin with
943 <             * found by Pat Szuta, Perly , perly@xnet.com
944 <             */
945 <            if (!IsOper(source_p))
946 <              break;
947 <
948 <            ClearOper(source_p);
949 <            source_p->umodes &= ~ConfigFileEntry.oper_only_umodes;
950 <            Count.oper--;
951 <
952 <            if (MyConnect(source_p))
953 <            {
954 <              dlink_node *dm;
955 <
956 <              detach_conf(source_p, OPER_TYPE);
957 <              ClearOperFlags(source_p);
958 <
959 <              if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
960 <                free_dlink_node(dm);
961 <            }
962 <          }
963 <
964 <          break;
965 <
966 <        /* we may not get these,
967 <         * but they shouldnt be in default
968 <         */
969 <        case ' ' :
970 <        case '\n':
971 <        case '\r':
972 <        case '\t':
973 <          break;
974 <
975 <        default:
976 <          if ((flag = user_modes[(unsigned char)*m]))
977 <          {
978 <            if (MyConnect(source_p) && !IsOper(source_p) &&
979 <                (ConfigFileEntry.oper_only_umodes & flag))
980 <            {
981 <              badflag = 1;
982 <            }
983 <            else
984 <              execute_callback(umode_cb, client_p, source_p, what, flag);
985 <          }
986 <          else
987 <          {
988 <            if (MyConnect(source_p))
989 <              badflag = 1;
990 <          }
991 <
992 <          break;
993 <      }
994 <    }
995 <  }
996 <
997 <  if (badflag)
998 <    sendto_one(source_p, form_str(ERR_UMODEUNKNOWNFLAG),
999 <               me.name, source_p->name);
1000 <
1001 <  if ((source_p->umodes & UMODE_NCHANGE) && !IsOperN(source_p))
1002 <  {
1003 <    sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
1004 <               me.name, source_p->name);
1005 <    source_p->umodes &= ~UMODE_NCHANGE; /* only tcm's really need this */
1006 <  }
1007 <
1008 <  if (MyConnect(source_p) && (source_p->umodes & UMODE_ADMIN) &&
1009 <      !IsOperAdmin(source_p) && !IsOperHiddenAdmin(source_p))
1010 <  {
1011 <    sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
1012 <               me.name, source_p->name);
1013 <    source_p->umodes &= ~UMODE_ADMIN;
1014 <  }
741 >  if (EmptyString(p) || *p == '-' || (IsDigit(*p) && local))
742 >    return 0;
743  
744 <  if (!(setflags & UMODE_INVISIBLE) && IsInvisible(source_p))
745 <    ++Count.invisi;
746 <  if ((setflags & UMODE_INVISIBLE) && !IsInvisible(source_p))
1019 <    --Count.invisi;
744 >  for (; *p; ++p)
745 >    if (!IsNickChar(*p))
746 >      return 0;
747  
748 <  /*
1022 <   * compare new flags with old flags and send string which
1023 <   * will cause servers to update correctly.
1024 <   */
1025 <  send_umode_out(client_p, source_p, setflags);
748 >  return p - nickname <= NICKLEN;
749   }
750  
751   /* send_umode()
# Line 1038 | Line 761 | set_user_mode(struct Client *client_p, s
761   */
762   void
763   send_umode(struct Client *client_p, struct Client *source_p,
764 <           unsigned int old, unsigned int sendmask, char *umode_buf)
764 >           unsigned int old, char *umode_buf)
765   {
1043  int what = 0;
1044  unsigned int i;
1045  unsigned int flag;
766    char *m = umode_buf;
767 +  int what = 0;
768  
769    /*
770 <   * build a string in umode_buf to represent the change in the user's
770 >   * Build a string in umode_buf to represent the change in the user's
771     * mode between the new (source_p->umodes) and 'old'.
772     */
773 <  for (i = 0; i < 128; i++)
773 >  for (unsigned int i = 0; i < 128; ++i)
774    {
775 <    flag = user_modes[i];
1055 <    if (!flag)
1056 <      continue;
775 >    unsigned int flag = user_modes[i];
776  
777 <    if (MyClient(source_p) && !(flag & sendmask))
777 >    if (!flag)
778        continue;
779  
780 <    if ((flag & old) && !(source_p->umodes & flag))
780 >    if ((flag & old) && !HasUMode(source_p, flag))
781      {
782        if (what == MODE_DEL)
783          *m++ = (char)i;
# Line 1069 | Line 788 | send_umode(struct Client *client_p, stru
788          *m++ = (char)i;
789        }
790      }
791 <    else if (!(flag & old) && (source_p->umodes & flag))
791 >    else if (!(flag & old) && HasUMode(source_p, flag))
792      {
793        if (what == MODE_ADD)
794          *m++ = (char)i;
# Line 1086 | Line 805 | send_umode(struct Client *client_p, stru
805  
806    if (*umode_buf && client_p)
807      sendto_one(client_p, ":%s!%s@%s MODE %s :%s",
808 <               source_p->name, source_p->username,
809 <               source_p->host, source_p->name, umode_buf);
808 >               client_p->name, client_p->username,
809 >               client_p->host, client_p->name, umode_buf);
810   }
811  
812   /* send_umode_out()
# Line 1097 | Line 816 | send_umode(struct Client *client_p, stru
816   * side effects - Only send ubuf out to servers that know about this client
817   */
818   void
819 < send_umode_out(struct Client *client_p, struct Client *source_p,
1101 <               unsigned int old)
819 > send_umode_out(struct Client *source_p, unsigned int old)
820   {
821 <  char buf[IRCD_BUFSIZE] = { '\0' };
1104 <  dlink_node *ptr = NULL;
821 >  char buf[IRCD_BUFSIZE] = "";
822  
823 <  send_umode(NULL, source_p, old, IsOperHiddenAdmin(source_p) ?
1107 <             SEND_UMODES & ~UMODE_ADMIN : SEND_UMODES, buf);
823 >  send_umode(MyClient(source_p) ? source_p : NULL, source_p, old, buf);
824  
825    if (buf[0])
826 <  {
827 <    DLINK_FOREACH(ptr, serv_list.head)
1112 <    {
1113 <      struct Client *target_p = ptr->data;
1114 <
1115 <      if ((target_p != client_p) && (target_p != source_p))
1116 <        sendto_one(target_p, ":%s MODE %s :%s",
1117 <                   ID_or_name(source_p, target_p),
1118 <                   ID_or_name(source_p, target_p), buf);
1119 <    }
1120 <  }
1121 <
1122 <  if (client_p && MyClient(client_p))
1123 <    send_umode(client_p, source_p, old, 0xffffffff, buf);
826 >    sendto_server(source_p, 0, 0, ":%s MODE %s :%s",
827 >                  source_p->id, source_p->id, buf);
828   }
829  
830 < /* user_welcome()
831 < *
1128 < * inputs       - client pointer to client to welcome
1129 < * output       - NONE
1130 < * side effects -
1131 < */
1132 < static void
1133 < user_welcome(struct Client *source_p)
830 > void
831 > user_set_hostmask(struct Client *target_p, const char *hostname, const int what)
832   {
833 < #if defined(__TIME__) && defined(__DATE__)
1136 <  static const char built_date[] = __DATE__ " at " __TIME__;
1137 < #else
1138 <  static const char built_date[] = "unknown";
1139 < #endif
833 >  dlink_node *node = NULL;
834  
835 < #ifdef HAVE_LIBCRYPTO
836 <  if (source_p->localClient->fd.ssl != NULL)
1143 <    sendto_one(source_p, ":%s NOTICE %s :*** Connected securely via %s",
1144 <               me.name, source_p->name,
1145 <               ssl_get_cipher(source_p->localClient->fd.ssl));
1146 < #endif
835 >  if (!strcmp(target_p->host, hostname))
836 >    return;
837  
838 <  sendto_one(source_p, form_str(RPL_WELCOME), me.name, source_p->name,
839 <             ServerInfo.network_name, source_p->name);
840 <  sendto_one(source_p, form_str(RPL_YOURHOST), me.name, source_p->name,
841 <             get_listener_name(source_p->localClient->listener), ircd_version);
842 <  sendto_one(source_p, form_str(RPL_CREATED),
843 <             me.name, source_p->name, built_date);
844 <  sendto_one(source_p, form_str(RPL_MYINFO),
845 <             me.name, source_p->name, me.name, ircd_version, umode_buffer);
1156 <  show_isupport(source_p);
838 >  switch (what)
839 >  {
840 >    case MODE_ADD:
841 >      AddUMode(target_p, UMODE_HIDDENHOST);
842 >      AddFlag(target_p, FLAGS_IP_SPOOFING);
843 >      break;
844 >    case MODE_DEL:
845 >      DelUMode(target_p, UMODE_HIDDENHOST);
846  
847 <  if (source_p->id[0] != '\0')
848 <    sendto_one(source_p, form_str(RPL_YOURID), me.name,
849 <               source_p->name, source_p->id);
847 >      if (!HasFlag(target_p, FLAGS_AUTH_SPOOF))
848 >        DelFlag(target_p, FLAGS_IP_SPOOFING);
849 >      break;
850 >    default: return;
851 >  }
852  
853 <  show_lusers(source_p);
853 >  if (ConfigGeneral.cycle_on_host_change)
854 >    sendto_common_channels_local(target_p, 0, 0, ":%s!%s@%s QUIT :Changing hostname",
855 >                                 target_p->name, target_p->username, target_p->host);
856 >
857 >  if (IsUserHostIp(target_p))
858 >    delete_user_host(target_p->username, target_p->host, !MyConnect(target_p));
859 >
860 >  strlcpy(target_p->host, hostname, sizeof(target_p->host));
861 >
862 >  add_user_host(target_p->username, target_p->host, !MyConnect(target_p));
863 >  SetUserHost(target_p);
864  
865 <  if (ConfigFileEntry.short_motd)
865 >  if (MyClient(target_p))
866    {
867 <    sendto_one(source_p, "NOTICE %s :*** Notice -- motd was last changed at %s",
868 <               source_p->name, ConfigFileEntry.motd.lastChangedDate);
1168 <    sendto_one(source_p,
1169 <               "NOTICE %s :*** Notice -- Please read the motd if you haven't "
1170 <               "read it", source_p->name);
1171 <    sendto_one(source_p, form_str(RPL_MOTDSTART),
1172 <               me.name, source_p->name, me.name);
1173 <    sendto_one(source_p, form_str(RPL_MOTD),
1174 <               me.name, source_p->name,
1175 <               "*** This is the short motd ***");
1176 <    sendto_one(source_p, form_str(RPL_ENDOFMOTD),
1177 <               me.name, source_p->name);
867 >    sendto_one_numeric(target_p, &me, RPL_VISIBLEHOST, target_p->host);
868 >    clear_ban_cache_client(target_p);
869    }
1179  else  
1180    send_message_file(source_p, &ConfigFileEntry.motd);
1181 }
870  
871 < /* check_xline()
872 < *
1185 < * inputs       - pointer to client to test
1186 < * outupt       - 1 if exiting 0 if ok
1187 < * side effects -
1188 < */
1189 < static int
1190 < check_xline(struct Client *source_p)
1191 < {
1192 <  struct ConfItem *conf = NULL;
1193 <  const char *reason = NULL;
871 >  if (!ConfigGeneral.cycle_on_host_change)
872 >    return;
873  
874 <  if ((conf = find_matching_name_conf(XLINE_TYPE, source_p->info, NULL, NULL, 0)) ||
1196 <      (conf = find_matching_name_conf(RXLINE_TYPE, source_p->info, NULL, NULL, 0)))
874 >  DLINK_FOREACH(node, target_p->channel.head)
875    {
876 <    struct MatchItem *reg = map_to_conf(conf);
876 >    char modebuf[4], nickbuf[NICKLEN * 3 + 3] = "";
877 >    char *p = modebuf;
878 >    int len = 0;
879 >    const struct Membership *member = node->data;
880  
881 <    ++reg->count;
882 <
883 <    if (reg->reason != NULL)
884 <      reason = reg->reason;
885 <    else
1205 <      reason = "No Reason";
881 >    if (has_member_flags(member, CHFL_CHANOP))
882 >    {
883 >      *p++ = 'o';
884 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
885 >    }
886  
887 <    sendto_realops_flags(UMODE_REJ, L_ALL,
888 <                         "X-line Rejecting [%s] [%s], user %s [%s]",
889 <                         source_p->info, reason,
890 <                         get_client_name(source_p, HIDE_IP),
891 <                         source_p->sockhost);
887 >    if (has_member_flags(member, CHFL_HALFOP))
888 >    {
889 >      *p++ = 'h';
890 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
891 >    }
892  
893 <    ServerStats->is_ref++;
1214 <    if (REJECT_HOLD_TIME > 0)
893 >    if (has_member_flags(member, CHFL_VOICE))
894      {
895 <      sendto_one(source_p, ":%s NOTICE %s :Bad user info",
896 <                 me.name, source_p->name);
1218 <      source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
1219 <      SetCaptured(source_p);
895 >      *p++ = 'v';
896 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
897      }
1221    else
1222      exit_client(source_p, &me, "Bad user info");
1223    return 1;
1224  }
898  
899 <  return 0;
1227 < }
899 >    *p = '\0';
900  
901 < /* oper_up()
902 < *
903 < * inputs       - pointer to given client to oper
904 < * output       - NONE
905 < * side effects - Blindly opers up given source_p, using aconf info
906 < *                all checks on passwords have already been done.
907 < *                This could also be used by rsa oper routines.
901 >
902 >    sendto_channel_local_butone(target_p, CAP_EXTENDED_JOIN, 0, member->chptr, ":%s!%s@%s JOIN %s %s :%s",
903 >                                target_p->name, target_p->username,
904 >                                target_p->host, member->chptr->name,
905 >                                (!IsDigit(target_p->account[0]) && target_p->account[0] != '*') ? target_p->account : "*",
906 >                                target_p->info);
907 >    sendto_channel_local_butone(target_p, 0, CAP_EXTENDED_JOIN, member->chptr, ":%s!%s@%s JOIN :%s",
908 >                                target_p->name, target_p->username,
909 >                                target_p->host, member->chptr->name);
910 >
911 >    if (nickbuf[0])
912 >      sendto_channel_local_butone(target_p, 0, 0, member->chptr, ":%s MODE %s +%s %s",
913 >                                  target_p->servptr->name, member->chptr->name,
914 >                                  modebuf, nickbuf);
915 >
916 >  }
917 >
918 >  if (target_p->away[0])
919 >    sendto_common_channels_local(target_p, 0, CAP_AWAY_NOTIFY,
920 >                                 ":%s!%s@%s AWAY :%s",
921 >                                 target_p->name, target_p->username,
922 >                                 target_p->host, target_p->away);
923 > }
924 >
925 > /*! \brief Blindly opers up given source_p, using conf info.
926 > *         All checks on passwords have already been done.
927 > * \param source_p Pointer to given client to oper
928   */
929   void
930   oper_up(struct Client *source_p)
931   {
932 <  unsigned int old = source_p->umodes;
933 <  const char *operprivs = "";
1242 <  const struct AccessItem *oconf = NULL;
932 >  const unsigned int old = source_p->umodes;
933 >  const struct MaskItem *const conf = source_p->connection->confs.head->data;
934  
935 <  assert(source_p->localClient->confs.head);
1245 <  oconf = map_to_conf((source_p->localClient->confs.head)->data);
935 >  assert(source_p->connection->confs.head);
936  
937    ++Count.oper;
938    SetOper(source_p);
939  
940 <  if (oconf->modes)
941 <    source_p->umodes |= oconf->modes;
942 <  else if (ConfigFileEntry.oper_umodes)
943 <    source_p->umodes |= ConfigFileEntry.oper_umodes;
1254 <  else
1255 <    source_p->umodes |= (UMODE_SERVNOTICE|UMODE_OPERWALL|
1256 <                         UMODE_WALLOP|UMODE_LOCOPS);
940 >  if (conf->modes)
941 >    AddUMode(source_p, conf->modes);
942 >  else if (ConfigGeneral.oper_umodes)
943 >    AddUMode(source_p, ConfigGeneral.oper_umodes);
944  
945 <  if (!(old & UMODE_INVISIBLE) && IsInvisible(source_p))
945 >  if (!(old & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
946      ++Count.invisi;
947 <  if ((old & UMODE_INVISIBLE) && !IsInvisible(source_p))
947 >  if ((old & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
948      --Count.invisi;
949  
950    assert(dlinkFind(&oper_list, source_p) == NULL);
951    dlinkAdd(source_p, make_dlink_node(), &oper_list);
952  
953 <  operprivs = oper_privs_as_string(oconf->port);
1267 <
1268 <  SetOFlag(source_p, oconf->port);
953 >  AddOFlag(source_p, conf->port);
954  
955 <  if (IsOperAdmin(source_p) || IsOperHiddenAdmin(source_p))
956 <    source_p->umodes |= UMODE_ADMIN;
1272 <  if (!IsOperN(source_p))
1273 <    source_p->umodes &= ~UMODE_NCHANGE;
955 >  if (HasOFlag(source_p, OPER_FLAG_ADMIN))
956 >    AddUMode(source_p, UMODE_ADMIN);
957  
958 <  sendto_realops_flags(UMODE_ALL, L_ALL, "%s (%s@%s) is now an operator",
959 <                       source_p->name, source_p->username, source_p->host);
960 <  send_umode_out(source_p, source_p, old);
961 <  sendto_one(source_p, form_str(RPL_YOUREOPER), me.name, source_p->name);
962 <  sendto_one(source_p, ":%s NOTICE %s :*** Oper privs are %s",
963 <             me.name, source_p->name, operprivs);
1281 <  send_message_file(source_p, &ConfigFileEntry.opermotd);
958 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
959 >                       get_oper_name(source_p));
960 >  sendto_server(NULL, 0, 0, ":%s GLOBOPS :%s is now an operator",
961 >                me.id, get_oper_name(source_p));
962 >  send_umode_out(source_p, old);
963 >  sendto_one_numeric(source_p, &me, RPL_YOUREOPER);
964   }
965  
966 < static char new_uid[TOTALSIDUID + 1];     /* allow for \0 */
966 > static char new_uid[TOTALSIDUID + 1];  /* Allow for \0 */
967  
968   int
969   valid_sid(const char *sid)
970   {
1289
971    if (strlen(sid) == IRC_MAXSID)
972      if (IsDigit(*sid))
973        if (IsAlNum(*(sid + 1)) && IsAlNum(*(sid + 2)))
# Line 1297 | Line 978 | valid_sid(const char *sid)
978  
979   /*
980   * init_uid()
981 < *
981 > *
982   * inputs       - NONE
983   * output       - NONE
984   * side effects - new_uid is filled in with server id portion (sid)
# Line 1307 | Line 988 | valid_sid(const char *sid)
988   void
989   init_uid(void)
990   {
1310  int i;
1311
991    memset(new_uid, 0, sizeof(new_uid));
992  
993 <  if (ServerInfo.sid != NULL)
994 <  {
1316 <    strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1317 <    strlcpy(me.id, ServerInfo.sid, sizeof(me.id));
993 >  if (!EmptyString(ConfigServerInfo.sid))
994 >    strlcpy(new_uid, ConfigServerInfo.sid, sizeof(new_uid));
995  
996 <    hash_add_id(&me);
997 <  }
1321 <
1322 <  for (i = 0; i < IRC_MAXSID; i++)
1323 <    if (new_uid[i] == '\0')
996 >  for (unsigned int i = 0; i < IRC_MAXSID; ++i)
997 >    if (new_uid[i] == '\0')
998        new_uid[i] = 'A';
999  
1000    /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1327  /* Yes nenolod, I have known it was off by one ever since I wrote it
1328   * But *JUST* for you, though, it really doesn't look as *pretty*
1329   * -Dianora
1330   */
1001    memcpy(new_uid + IRC_MAXSID, "AAAAA@", IRC_MAXUID);
1332
1333  entering_umode_cb = register_callback("entering_umode", NULL);
1334  umode_cb = register_callback("changing_umode", change_simple_umode);
1335  uid_get_cb = register_callback("uid_get", uid_get);
1002   }
1003  
1004   /*
# Line 1344 | Line 1010 | init_uid(void)
1010   *                note this is a recursive function
1011   */
1012   static void
1013 < add_one_to_uid(int i)
1013 > add_one_to_uid(unsigned int i)
1014   {
1015 <  if (i != IRC_MAXSID)    /* Not reached server SID portion yet? */
1015 >  if (i != IRC_MAXSID)  /* Not reached server SID portion yet? */
1016    {
1017      if (new_uid[i] == 'Z')
1018        new_uid[i] = '0';
1019      else if (new_uid[i] == '9')
1020      {
1021        new_uid[i] = 'A';
1022 <      add_one_to_uid(i-1);
1022 >      add_one_to_uid(i - 1);
1023      }
1024      else
1025        ++new_uid[i];
# Line 1375 | Line 1041 | add_one_to_uid(int i)
1041   * output       - new UID is returned to caller
1042   * side effects - new_uid is incremented by one.
1043   */
1044 < static void *
1045 < uid_get(va_list args)
1044 > static const char *
1045 > uid_get(void)
1046   {
1047 <  add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1047 >  add_one_to_uid(TOTALSIDUID - 1);  /* Index from 0 */
1048    return new_uid;
1049   }
1050  
# Line 1392 | Line 1058 | uid_get(va_list args)
1058   void
1059   init_isupport(void)
1060   {
1395  isupportFile = init_MessageLine();
1396
1061    add_isupport("CALLERID", NULL, -1);
1062 <  add_isupport("CASEMAPPING", CASEMAP, -1);
1062 >  add_isupport("CASEMAPPING", "rfc1459", -1);
1063    add_isupport("DEAF", "D", -1);
1064    add_isupport("KICKLEN", NULL, KICKLEN);
1065    add_isupport("MODES", NULL, MAXMODEPARAMS);
1402  add_isupport("NICKLEN", NULL, NICKLEN-1);
1403 #ifdef HALFOPS
1066    add_isupport("PREFIX", "(ohv)@%+", -1);
1067    add_isupport("STATUSMSG", "@%+", -1);
1068 < #else
1069 <  add_isupport("PREFIX", "(ov)@+", -1);
1408 <  add_isupport("STATUSMSG", "@+", -1);
1409 < #endif
1410 <  add_isupport("TOPICLEN", NULL, TOPICLEN);
1068 >  add_isupport("EXCEPTS", NULL, -1);
1069 >  add_isupport("INVEX", NULL, -1);
1070   }
1071  
1072   /*
# Line 1422 | Line 1081 | init_isupport(void)
1081   void
1082   add_isupport(const char *name, const char *options, int n)
1083   {
1084 <  dlink_node *ptr;
1085 <  struct Isupport *support;
1084 >  dlink_node *node = NULL;
1085 >  struct Isupport *support = NULL;
1086  
1087 <  DLINK_FOREACH(ptr, support_list.head)
1087 >  DLINK_FOREACH(node, support_list.head)
1088    {
1089 <    support = ptr->data;
1089 >    support = node->data;
1090      if (irccmp(support->name, name) == 0)
1091      {
1092        MyFree(support->name);
# Line 1436 | Line 1095 | add_isupport(const char *name, const cha
1095      }
1096    }
1097  
1098 <  if (ptr == NULL)
1098 >  if (node == NULL)
1099    {
1100 <    support = MyMalloc(sizeof(*support));
1100 >    support = MyCalloc(sizeof(*support));
1101      dlinkAddTail(support, &support->node, &support_list);
1102    }
1103  
1104 <  DupString(support->name, name);
1105 <  if (options != NULL)
1106 <    DupString(support->options, options);
1104 >  support->name = xstrdup(name);
1105 >  if (options)
1106 >    support->options = xstrdup(options);
1107    support->number = n;
1108  
1109    rebuild_isupport_message_line();
# Line 1460 | Line 1119 | add_isupport(const char *name, const cha
1119   void
1120   delete_isupport(const char *name)
1121   {
1122 <  dlink_node *ptr;
1464 <  struct Isupport *support;
1122 >  dlink_node *node = NULL;
1123  
1124 <  DLINK_FOREACH(ptr, support_list.head)
1124 >  DLINK_FOREACH(node, support_list.head)
1125    {
1126 <    support = ptr->data;
1126 >    struct Isupport *support = node->data;
1127 >
1128      if (irccmp(support->name, name) == 0)
1129      {
1130 <      dlinkDelete(ptr, &support_list);
1130 >      dlinkDelete(node, &support_list);
1131        MyFree(support->name);
1132        MyFree(support->options);
1133        MyFree(support);
# Line 1491 | Line 1150 | rebuild_isupport_message_line(void)
1150   {
1151    char isupportbuffer[IRCD_BUFSIZE];
1152    char *p = isupportbuffer;
1153 <  dlink_node *ptr = NULL;
1153 >  dlink_node *node = NULL, *node_next = NULL;
1154    int n = 0;
1155    int tokens = 0;
1156    size_t len = 0;
1157 <  size_t reserve = strlen(me.name) + HOSTLEN + strlen(form_str(RPL_ISUPPORT));
1157 >  size_t reserve = strlen(me.name) + HOSTLEN + strlen(numeric_form(RPL_ISUPPORT));
1158  
1159 <  destroy_MessageLine(isupportFile);
1159 >  DLINK_FOREACH_SAFE(node, node_next, support_list_lines.head)
1160 >  {
1161 >    dlinkDelete(node, &support_list_lines);
1162 >    MyFree(node->data);
1163 >    free_dlink_node(node);
1164 >  }
1165  
1166 <  DLINK_FOREACH(ptr, support_list.head)
1166 >  DLINK_FOREACH(node, support_list.head)
1167    {
1168 <    struct Isupport *support = ptr->data;
1168 >    struct Isupport *support = node->data;
1169  
1170 <    p += (n = ircsprintf(p, "%s", support->name));
1170 >    p += (n = sprintf(p, "%s", support->name));
1171      len += n;
1172  
1173 <    if (support->options != NULL)
1173 >    if (support->options)
1174      {
1175 <      p += (n = ircsprintf(p, "=%s", support->options));
1175 >      p += (n = sprintf(p, "=%s", support->options));
1176        len += n;
1177      }
1178  
1179      if (support->number > 0)
1180      {
1181 <      p += (n = ircsprintf(p, "=%d", support->number));
1181 >      p += (n = sprintf(p, "=%d", support->number));
1182        len += n;
1183      }
1184  
# Line 1527 | Line 1191 | rebuild_isupport_message_line(void)
1191        if (*--p == ' ')
1192          *p = '\0';
1193  
1194 <      addto_MessageLine(isupportFile, isupportbuffer);
1194 >      dlinkAddTail(xstrdup(isupportbuffer), make_dlink_node(), &support_list_lines);
1195        p = isupportbuffer;
1196        len = 0;
1197        n = tokens = 0;
1198      }
1199    }
1200  
1201 <  if (len != 0)
1201 >  if (len)
1202    {
1203      if (*--p == ' ')
1204        *p = '\0';
1205 <    addto_MessageLine(isupportFile, isupportbuffer);
1205 >    dlinkAddTail(xstrdup(isupportbuffer), make_dlink_node(), &support_list_lines);
1206    }
1207   }

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)