ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/user.c (file contents):
Revision 4704 by michael, Sun Oct 5 16:25:02 2014 UTC vs.
Revision 5562 by michael, Sat Feb 14 20:03:35 2015 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2015 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 65 | Line 65 | struct Isupport
65   static dlink_list support_list;
66   static dlink_list support_list_lines;
67  
68 < /* memory is cheap. map 0-255 to equivalent mode */
69 < const unsigned int user_modes[256] =
68 > const struct user_modes *umode_map[256];
69 > const struct user_modes  umode_tab[] =
70   {
71 <  /* 0x00 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x0F */
72 <  /* 0x10 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x1F */
73 <  /* 0x20 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x2F */
74 <  /* 0x30 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x3F */
75 <  0,                  /* @ */
76 <  0,                  /* A */
77 <  0,                  /* B */
78 <  0,                  /* C */
79 <  UMODE_DEAF,         /* D */
80 <  0,                  /* E */
81 <  UMODE_FARCONNECT,   /* F */
82 <  UMODE_SOFTCALLERID, /* G */
83 <  UMODE_HIDDEN,       /* H */
84 <  0,                  /* I */
85 <  0,                  /* J */
86 <  0,                  /* K */
87 <  0,                  /* L */
88 <  0,                  /* M */
89 <  0,                  /* N */
90 <  0,                  /* O */
91 <  0,                  /* P */
92 <  0,                  /* Q */
93 <  UMODE_REGONLY,      /* R */
94 <  UMODE_SSL,          /* S */
95 <  0,                  /* T */
96 <  0,                  /* U */
97 <  0,                  /* V */
98 <  UMODE_WEBIRC,       /* W */
99 <  0,                  /* X */
100 <  0,                  /* Y */
101 <  0,                  /* Z 0x5A */
102 <  0, 0, 0, 0, 0,      /* 0x5F   */
103 <  0,                  /* 0x60   */
104 <  UMODE_ADMIN,        /* a */
105 <  UMODE_BOTS,         /* b */
106 <  UMODE_CCONN,        /* c */
107 <  UMODE_DEBUG,        /* d */
108 <  UMODE_EXTERNAL,     /* e */
109 <  UMODE_FULL,         /* f */
110 <  UMODE_CALLERID,     /* g */
111 <  0,                  /* h */
112 <  UMODE_INVISIBLE,    /* i */
113 <  UMODE_REJ,          /* j */
114 <  UMODE_SKILL,        /* k */
115 <  UMODE_LOCOPS,       /* l */
116 <  0,                  /* m */
117 <  UMODE_NCHANGE,      /* n */
118 <  UMODE_OPER,         /* o */
119 <  UMODE_HIDECHANS,    /* p */
120 <  UMODE_HIDEIDLE,     /* q */
121 <  UMODE_REGISTERED,   /* r */
122 <  UMODE_SERVNOTICE,   /* s */
123 <  0,                  /* t */
124 <  UMODE_UNAUTH,       /* u */
125 <  0,                  /* v */
126 <  UMODE_WALLOP,       /* w */
127 <  UMODE_HIDDENHOST,   /* x */
128 <  UMODE_SPY,          /* y */
129 <  0,                  /* z      0x7A */
130 <  0,0,0,0,0,          /* 0x7B - 0x7F */
131 <
132 <  /* 0x80 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x8F */
133 <  /* 0x90 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x9F */
134 <  /* 0xA0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xAF */
135 <  /* 0xB0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xBF */
136 <  /* 0xC0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xCF */
137 <  /* 0xD0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xDF */
138 <  /* 0xE0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xEF */
139 <  /* 0xF0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0  /* 0xFF */
71 >  { 'D', UMODE_DEAF         },
72 >  { 'F', UMODE_FARCONNECT   },
73 >  { 'G', UMODE_SOFTCALLERID },
74 >  { 'H', UMODE_HIDDEN       },
75 >  { 'R', UMODE_REGONLY      },
76 >  { 'S', UMODE_SSL          },
77 >  { 'W', UMODE_WEBIRC       },
78 >  { 'a', UMODE_ADMIN        },
79 >  { 'b', UMODE_BOTS         },
80 >  { 'c', UMODE_CCONN        },
81 >  { 'd', UMODE_DEBUG        },
82 >  { 'e', UMODE_EXTERNAL     },
83 >  { 'f', UMODE_FULL         },
84 >  { 'g', UMODE_CALLERID     },
85 >  { 'i', UMODE_INVISIBLE    },
86 >  { 'j', UMODE_REJ          },
87 >  { 'k', UMODE_SKILL        },
88 >  { 'l', UMODE_LOCOPS       },
89 >  { 'n', UMODE_NCHANGE      },
90 >  { 'o', UMODE_OPER         },
91 >  { 'p', UMODE_HIDECHANS    },
92 >  { 'q', UMODE_HIDEIDLE     },
93 >  { 'r', UMODE_REGISTERED   },
94 >  { 's', UMODE_SERVNOTICE   },
95 >  { 'u', UMODE_UNAUTH       },
96 >  { 'w', UMODE_WALLOP       },
97 >  { 'x', UMODE_HIDDENHOST   },
98 >  { 'y', UMODE_SPY          },
99 >  { '\0', 0 }
100   };
101  
102   void
103 < assemble_umode_buffer(void)
103 > user_usermodes_init(void)
104   {
145  unsigned int idx = 0;
105    char *umode_buffer_ptr = umode_buffer;
106  
107 <  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
108 <    if (user_modes[idx])
109 <      *umode_buffer_ptr++ = idx;
107 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
108 >  {
109 >    umode_map[tab->c] = tab;
110 >    *umode_buffer_ptr++ = tab->c;
111 >  }
112  
113    *umode_buffer_ptr = '\0';
114   }
# Line 162 | Line 123 | void
123   show_lusers(struct Client *source_p)
124   {
125    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
126 <    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total-Count.invisi),
126 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
127                         Count.invisi, dlink_list_length(&global_server_list));
128    else
129 <    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT,
130 <                       (Count.total - Count.invisi), Count.invisi, 1);
129 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
130 >                       Count.invisi, 1);
131  
132    if (Count.oper)
133      sendto_one_numeric(source_p, &me, RPL_LUSEROP, Count.oper);
# Line 210 | Line 171 | show_lusers(struct Client *source_p)
171   void
172   show_isupport(struct Client *source_p)
173   {
174 <  const dlink_node *ptr = NULL;
174 >  const dlink_node *node = NULL;
175  
176 <  DLINK_FOREACH(ptr, support_list_lines.head)
177 <    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, ptr->data);
176 >  DLINK_FOREACH(node, support_list_lines.head)
177 >    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, node->data);
178   }
179  
180  
# Line 232 | Line 193 | report_and_set_user_flags(struct Client
193    if (IsConfDoSpoofIp(conf))
194      sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
195  
196 <  /* If this user is in the exception class, Set it "E lined" */
196 >  /* If this user is in the exception class, set it "E lined" */
197    if (IsConfExemptKline(conf))
198    {
199      SetExemptKline(source_p);
# Line 281 | Line 242 | report_and_set_user_flags(struct Client
242   static void
243   introduce_client(struct Client *source_p)
244   {
245 <  dlink_node *ptr = NULL;
245 >  dlink_node *node = NULL;
246    char ubuf[IRCD_BUFSIZE] = "";
247  
248    if (MyClient(source_p))
# Line 297 | Line 258 | introduce_client(struct Client *source_p
258      ubuf[1] = '\0';
259    }
260  
261 <  DLINK_FOREACH(ptr, local_server_list.head)
261 >  DLINK_FOREACH(node, local_server_list.head)
262    {
263 <    struct Client *server = ptr->data;
263 >    struct Client *server = node->data;
264  
265      if (server == source_p->from)
266        continue;
# Line 310 | Line 271 | introduce_client(struct Client *source_p
271                   source_p->name, source_p->hopcount+1,
272                   (unsigned long)source_p->tsinfo,
273                   ubuf, source_p->username, source_p->host,
274 <                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
275 <                 "0" : source_p->sockhost, source_p->id,
315 <                 source_p->svid,
274 >                 source_p->sockhost, source_p->id,
275 >                 source_p->account,
276                   source_p->info);
277      else
278        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
# Line 320 | Line 280 | introduce_client(struct Client *source_p
280                   source_p->name, source_p->hopcount+1,
281                   (unsigned long)source_p->tsinfo,
282                   ubuf, source_p->username, source_p->host,
283 <                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
324 <                 "0" : source_p->sockhost, source_p->id, source_p->info);
283 >                 source_p->sockhost, source_p->id, source_p->info);
284  
285      if (!EmptyString(source_p->certfp))
286        sendto_one(server, ":%s CERTFP %s", source_p->id, source_p->certfp);
# Line 375 | Line 334 | static int
334   check_xline(struct Client *source_p)
335   {
336    struct MaskItem *conf = NULL;
378  const char *reason = NULL;
337  
338    if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
339    {
340      ++conf->count;
383
384    if (conf->reason)
385      reason = conf->reason;
386    else
387      reason = CONF_NOREASON;
388
341      sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
342                           "X-line Rejecting [%s] [%s], user %s [%s]",
343 <                         source_p->info, reason,
343 >                         source_p->info, conf->reason,
344                           get_client_name(source_p, HIDE_IP),
345                           source_p->sockhost);
346  
# Line 415 | Line 367 | register_local_user(struct Client *sourc
367    assert(MyConnect(source_p));
368    assert(!source_p->connection->registration);
369  
418  ClearCap(source_p, CAP_TS6);
419
370    if (ConfigGeneral.ping_cookie)
371    {
372      if (!IsPingSent(source_p) && !source_p->connection->random_ping)
# Line 425 | Line 375 | register_local_user(struct Client *sourc
375          source_p->connection->random_ping = genrand_int32();
376        while (!source_p->connection->random_ping);
377  
378 <      sendto_one(source_p, "PING :%u",
429 <                 source_p->connection->random_ping);
378 >      sendto_one(source_p, "PING :%u", source_p->connection->random_ping);
379        SetPingSent(source_p);
380        return;
381      }
# Line 446 | Line 395 | register_local_user(struct Client *sourc
395    {
396      sendto_one_notice(source_p, &me, ":*** Notice -- You have an illegal "
397                        "character in your hostname");
398 <    strlcpy(source_p->host, source_p->sockhost,
450 <            sizeof(source_p->host));
398 >    strlcpy(source_p->host, source_p->sockhost, sizeof(source_p->host));
399    }
400  
401    conf = source_p->connection->confs.head->data;
# Line 493 | Line 441 | register_local_user(struct Client *sourc
441  
442    /*
443     * Don't free source_p->connection->password here - it can be required
444 <   * by masked /stats I if there are auth{} blocks with need_password = no;
444 >   * by masked /stats I if there are auth {} blocks with need_password = no;
445     * --adx
446     */
447  
# Line 513 | Line 461 | register_local_user(struct Client *sourc
461     * probably be just a percentage of the MAXCLIENTS...
462     *   -Taner
463     */
464 <  if ((Count.local >= ConfigServerInfo.max_clients + MAX_BUFFER) ||
465 <      (Count.local >= ConfigServerInfo.max_clients && !IsExemptLimits(source_p)))
464 >  if ((Count.local >= GlobalSetOptions.maxclients + MAX_BUFFER) ||
465 >      (Count.local >= GlobalSetOptions.maxclients && !IsExemptLimits(source_p)))
466    {
467      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
468                           "Too many clients, rejecting %s[%s].",
# Line 549 | Line 497 | register_local_user(struct Client *sourc
497    sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
498                         "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
499                         source_p->name, source_p->username, source_p->host,
500 <                       ConfigGeneral.hide_spoof_ips && IsIPSpoof(source_p) ?
553 <                       "255.255.255.255" : source_p->sockhost,
500 >                       source_p->sockhost,
501                         get_client_class(&source_p->connection->confs),
502                         source_p->info, source_p->id);
503  
# Line 614 | Line 561 | register_remote_user(struct Client *sour
561                           source_p->host, source_p->servptr->name,
562                           target_p->name, target_p->from->name);
563      sendto_one(source_p->from,
564 <               ":%s KILL %s :%s (NICK from wrong direction (%s != %s))",
564 >               ":%s KILL %s :%s (UID from wrong direction (%s != %s))",
565                 me.id, source_p->id, me.name, source_p->servptr->name,
566                 target_p->from->name);
567  
568      AddFlag(source_p, FLAGS_KILLED);
569 <    exit_client(source_p, "USER server wrong direction");
569 >    exit_client(source_p, "UID server wrong direction");
570      return;
571    }
572  
# Line 640 | Line 587 | register_remote_user(struct Client *sour
587    SetUserHost(source_p);
588  
589    if (HasFlag(source_p->servptr, FLAGS_EOB))
590 <    sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
591 <                         "Client connecting at %s: %s (%s@%s) [%s] <%s>",
592 <                         source_p->servptr->name,
593 <                         source_p->name, source_p->username, source_p->host,
594 <                         source_p->info, source_p->id);
590 >  {
591 >    if (strcmp(source_p->sockhost, "0")) /* XXX: TBR */
592 >      sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
593 >                           "Client connecting at %s: %s (%s@%s) [%s] [%s] <%s>",
594 >                           source_p->servptr->name,
595 >                           source_p->name, source_p->username, source_p->host,
596 >                           source_p->sockhost, source_p->info, source_p->id);
597 >    else
598 >      sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
599 >                           "Client connecting at %s: %s (%s@%s) [%s] <%s>",
600 >                           source_p->servptr->name,
601 >                           source_p->name, source_p->username, source_p->host,
602 >                           source_p->info, source_p->id);
603 >  }
604  
605    introduce_client(source_p);
606   }
# Line 742 | Line 698 | valid_nickname(const char *nickname, con
698   {
699    const char *p = nickname;
700  
701 <  assert(nickname && *nickname);
701 >  assert(p);
702  
703    /*
704     * Nicks can't start with a digit or - or be 0 length.
705     */
706 <  if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
706 >  if (EmptyString(p) || *p == '-' || (IsDigit(*p) && local))
707      return 0;
708  
709    for (; *p; ++p)
# Line 779 | Line 735 | send_umode(struct Client *client_p, stru
735     * Build a string in umode_buf to represent the change in the user's
736     * mode between the new (source_p->umodes) and 'old'.
737     */
738 <  for (unsigned int i = 0; i < 128; ++i)
738 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
739    {
740 <    unsigned int flag = user_modes[i];
785 <
786 <    if (!flag)
787 <      continue;
788 <
789 <    if ((flag & old) && !HasUMode(source_p, flag))
740 >    if ((tab->flag & old) && !HasUMode(source_p, tab->flag))
741      {
742        if (what == MODE_DEL)
743 <        *m++ = (char)i;
743 >        *m++ = tab->c;
744        else
745        {
746          what = MODE_DEL;
747          *m++ = '-';
748 <        *m++ = (char)i;
748 >        *m++ = tab->c;
749        }
750      }
751 <    else if (!(flag & old) && HasUMode(source_p, flag))
751 >    else if (!(tab->flag & old) && HasUMode(source_p, tab->flag))
752      {
753        if (what == MODE_ADD)
754 <        *m++ = (char)i;
754 >        *m++ = tab->c;
755        else
756        {
757          what = MODE_ADD;
758          *m++ = '+';
759 <        *m++ = (char)i;
759 >        *m++ = tab->c;
760        }
761      }
762    }
# Line 825 | Line 776 | send_umode(struct Client *client_p, stru
776   * side effects - Only send ubuf out to servers that know about this client
777   */
778   void
779 < send_umode_out(struct Client *client_p, struct Client *source_p,
829 <               unsigned int old)
779 > send_umode_out(struct Client *source_p, unsigned int old)
780   {
781    char buf[IRCD_BUFSIZE] = "";
782  
783 <  send_umode(NULL, source_p, old, buf);
783 >  send_umode(MyClient(source_p) ? source_p : NULL, source_p, old, buf);
784  
785    if (buf[0])
786 <    sendto_server(source_p, NOCAPS, NOCAPS, ":%s MODE %s :%s",
786 >    sendto_server(source_p, 0, 0, ":%s MODE %s :%s",
787                    source_p->id, source_p->id, buf);
838
839  if (client_p && MyClient(client_p))
840    send_umode(client_p, source_p, old, buf);
788   }
789  
790   void
791   user_set_hostmask(struct Client *target_p, const char *hostname, const int what)
792   {
793 <  dlink_node *ptr = NULL;
793 >  dlink_node *node = NULL;
794  
795    if (!strcmp(target_p->host, hostname))
796      return;
# Line 852 | Line 799 | user_set_hostmask(struct Client *target_
799    {
800      case MODE_ADD:
801        AddUMode(target_p, UMODE_HIDDENHOST);
855      AddFlag(target_p, FLAGS_IP_SPOOFING);
802        break;
803      case MODE_DEL:
804        DelUMode(target_p, UMODE_HIDDENHOST);
859
860      if (!HasFlag(target_p, FLAGS_AUTH_SPOOF))
861        DelFlag(target_p, FLAGS_IP_SPOOFING);
805        break;
806      default: return;
807    }
# Line 884 | Line 827 | user_set_hostmask(struct Client *target_
827    if (!ConfigGeneral.cycle_on_host_change)
828      return;
829  
830 <  DLINK_FOREACH(ptr, target_p->channel.head)
830 >  DLINK_FOREACH(node, target_p->channel.head)
831    {
832      char modebuf[4], nickbuf[NICKLEN * 3 + 3] = "";
833      char *p = modebuf;
834      int len = 0;
835 <    const struct Membership *ms = ptr->data;
835 >    const struct Membership *member = node->data;
836  
837 <    if (has_member_flags(ms, CHFL_CHANOP))
837 >    if (has_member_flags(member, CHFL_CHANOP))
838      {
839        *p++ = 'o';
840        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
841      }
842  
843 <    if (has_member_flags(ms, CHFL_HALFOP))
843 >    if (has_member_flags(member, CHFL_HALFOP))
844      {
845        *p++ = 'h';
846        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
847      }
848  
849 <    if (has_member_flags(ms, CHFL_VOICE))
849 >    if (has_member_flags(member, CHFL_VOICE))
850      {
851        *p++ = 'v';
852        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
# Line 911 | Line 854 | user_set_hostmask(struct Client *target_
854  
855      *p = '\0';
856  
857 <    sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s!%s@%s JOIN :%s",
858 <                                target_p->name, target_p->username, target_p->host,
859 <                                ms->chptr->name);
857 >
858 >    sendto_channel_local_butone(target_p, CAP_EXTENDED_JOIN, 0, member->chptr, ":%s!%s@%s JOIN %s %s :%s",
859 >                                target_p->name, target_p->username,
860 >                                target_p->host, member->chptr->name,
861 >                                (!IsDigit(target_p->account[0]) && target_p->account[0] != '*') ? target_p->account : "*",
862 >                                target_p->info);
863 >    sendto_channel_local_butone(target_p, 0, CAP_EXTENDED_JOIN, member->chptr, ":%s!%s@%s JOIN :%s",
864 >                                target_p->name, target_p->username,
865 >                                target_p->host, member->chptr->name);
866 >
867      if (nickbuf[0])
868 <      sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s MODE %s +%s %s",
869 <                                  target_p->servptr->name, ms->chptr->name,
868 >      sendto_channel_local_butone(target_p, 0, 0, member->chptr, ":%s MODE %s +%s %s",
869 >                                  target_p->servptr->name, member->chptr->name,
870                                    modebuf, nickbuf);
871  
872    }
# Line 936 | Line 886 | void
886   oper_up(struct Client *source_p)
887   {
888    const unsigned int old = source_p->umodes;
889 <  const struct MaskItem *conf = source_p->connection->confs.head->data;
889 >  const struct MaskItem *const conf = source_p->connection->confs.head->data;
890  
891    assert(source_p->connection->confs.head);
892  
# Line 961 | Line 911 | oper_up(struct Client *source_p)
911    if (HasOFlag(source_p, OPER_FLAG_ADMIN))
912      AddUMode(source_p, UMODE_ADMIN);
913  
914 +  if (!EmptyString(conf->whois))
915 +  {
916 +    client_attach_svstag(source_p, RPL_WHOISOPERATOR, "+", conf->whois);
917 +    sendto_server(source_p, 0, 0, ":%s SVSTAG %s %lu %u + :%s",
918 +                  me.id, source_p->id, (unsigned long)source_p->tsinfo,
919 +                  RPL_WHOISOPERATOR, conf->whois);
920 +  }
921 +
922    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
923                         get_oper_name(source_p));
924 <  sendto_server(NULL, NOCAPS, NOCAPS, ":%s GLOBOPS :%s is now an operator",
924 >  sendto_server(NULL, 0, 0, ":%s GLOBOPS :%s is now an operator",
925                  me.id, get_oper_name(source_p));
926 <  send_umode_out(source_p, source_p, old);
926 >  send_umode_out(source_p, old);
927    sendto_one_numeric(source_p, &me, RPL_YOUREOPER);
928   }
929  
# Line 1071 | Line 1029 | init_isupport(void)
1029    add_isupport("MODES", NULL, MAXMODEPARAMS);
1030    add_isupport("PREFIX", "(ohv)@%+", -1);
1031    add_isupport("STATUSMSG", "@%+", -1);
1032 <  add_isupport("EXCEPTS", "e", -1);
1033 <  add_isupport("INVEX", "I", -1);
1032 >  add_isupport("EXCEPTS", NULL, -1);
1033 >  add_isupport("INVEX", NULL, -1);
1034   }
1035  
1036   /*
# Line 1087 | Line 1045 | init_isupport(void)
1045   void
1046   add_isupport(const char *name, const char *options, int n)
1047   {
1048 <  dlink_node *ptr;
1048 >  dlink_node *node = NULL;
1049    struct Isupport *support = NULL;
1050  
1051 <  DLINK_FOREACH(ptr, support_list.head)
1051 >  DLINK_FOREACH(node, support_list.head)
1052    {
1053 <    support = ptr->data;
1053 >    support = node->data;
1054      if (irccmp(support->name, name) == 0)
1055      {
1056        MyFree(support->name);
# Line 1101 | Line 1059 | add_isupport(const char *name, const cha
1059      }
1060    }
1061  
1062 <  if (ptr == NULL)
1062 >  if (node == NULL)
1063    {
1064      support = MyCalloc(sizeof(*support));
1065      dlinkAddTail(support, &support->node, &support_list);
# Line 1125 | Line 1083 | add_isupport(const char *name, const cha
1083   void
1084   delete_isupport(const char *name)
1085   {
1086 <  dlink_node *ptr;
1129 <  struct Isupport *support;
1086 >  dlink_node *node = NULL;
1087  
1088 <  DLINK_FOREACH(ptr, support_list.head)
1088 >  DLINK_FOREACH(node, support_list.head)
1089    {
1090 <    support = ptr->data;
1090 >    struct Isupport *support = node->data;
1091 >
1092      if (irccmp(support->name, name) == 0)
1093      {
1094 <      dlinkDelete(ptr, &support_list);
1094 >      dlinkDelete(node, &support_list);
1095        MyFree(support->name);
1096        MyFree(support->options);
1097        MyFree(support);
# Line 1156 | Line 1114 | rebuild_isupport_message_line(void)
1114   {
1115    char isupportbuffer[IRCD_BUFSIZE];
1116    char *p = isupportbuffer;
1117 <  dlink_node *ptr = NULL, *ptr_next = NULL;
1117 >  dlink_node *node = NULL, *node_next = NULL;
1118    int n = 0;
1119    int tokens = 0;
1120    size_t len = 0;
1121    size_t reserve = strlen(me.name) + HOSTLEN + strlen(numeric_form(RPL_ISUPPORT));
1122  
1123 <  DLINK_FOREACH_SAFE(ptr, ptr_next, support_list_lines.head)
1123 >  DLINK_FOREACH_SAFE(node, node_next, support_list_lines.head)
1124    {
1125 <    dlinkDelete(ptr, &support_list_lines);
1126 <    MyFree(ptr->data);
1127 <    free_dlink_node(ptr);
1125 >    dlinkDelete(node, &support_list_lines);
1126 >    MyFree(node->data);
1127 >    free_dlink_node(node);
1128    }
1129  
1130 <  DLINK_FOREACH(ptr, support_list.head)
1130 >  DLINK_FOREACH(node, support_list.head)
1131    {
1132 <    struct Isupport *support = ptr->data;
1132 >    struct Isupport *support = node->data;
1133  
1134      p += (n = sprintf(p, "%s", support->name));
1135      len += n;

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)