ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/user.c (file contents):
Revision 3655 by michael, Wed May 28 20:51:21 2014 UTC vs.
Revision 5728 by michael, Sun Mar 29 10:21:44 2015 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2015 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
22 < /*! \file s_user.c
22 > /*! \file user.c
23   * \brief User related functions.
24   * \version $Id$
25   */
# Line 40 | Line 40
40   #include "log.h"
41   #include "server.h"
42   #include "send.h"
43 #include "supported.h"
43   #include "memory.h"
44   #include "packet.h"
45   #include "rng_mt.h"
# Line 66 | Line 65 | struct Isupport
65   static dlink_list support_list;
66   static dlink_list support_list_lines;
67  
68 < /* memory is cheap. map 0-255 to equivalent mode */
69 < const unsigned int user_modes[256] =
68 > const struct user_modes *umode_map[256];
69 > const struct user_modes  umode_tab[] =
70   {
71 <  /* 0x00 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x0F */
72 <  /* 0x10 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x1F */
73 <  /* 0x20 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x2F */
74 <  /* 0x30 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x3F */
75 <  0,                  /* @ */
76 <  0,                  /* A */
77 <  0,                  /* B */
78 <  0,                  /* C */
79 <  UMODE_DEAF,         /* D */
80 <  0,                  /* E */
81 <  UMODE_FARCONNECT,   /* F */
82 <  UMODE_SOFTCALLERID, /* G */
83 <  UMODE_HIDDEN,       /* H */
84 <  0,                  /* I */
85 <  0,                  /* J */
86 <  0,                  /* K */
87 <  0,                  /* L */
88 <  0,                  /* M */
89 <  0,                  /* N */
90 <  0,                  /* O */
91 <  0,                  /* P */
92 <  0,                  /* Q */
93 <  UMODE_REGONLY,      /* R */
94 <  UMODE_SSL,          /* S */
95 <  0,                  /* T */
96 <  0,                  /* U */
97 <  0,                  /* V */
98 <  UMODE_WEBIRC,       /* W */
99 <  0,                  /* X */
101 <  0,                  /* Y */
102 <  0,                  /* Z 0x5A */
103 <  0, 0, 0, 0, 0,      /* 0x5F   */
104 <  0,                  /* 0x60   */
105 <  UMODE_ADMIN,        /* a */
106 <  UMODE_BOTS,         /* b */
107 <  UMODE_CCONN,        /* c */
108 <  UMODE_DEBUG,        /* d */
109 <  UMODE_EXTERNAL,     /* e */
110 <  UMODE_FULL,         /* f */
111 <  UMODE_CALLERID,     /* g */
112 <  0,                  /* h */
113 <  UMODE_INVISIBLE,    /* i */
114 <  UMODE_REJ,          /* j */
115 <  UMODE_SKILL,        /* k */
116 <  UMODE_LOCOPS,       /* l */
117 <  0,                  /* m */
118 <  UMODE_NCHANGE,      /* n */
119 <  UMODE_OPER,         /* o */
120 <  UMODE_HIDECHANS,    /* p */
121 <  UMODE_HIDEIDLE,     /* q */
122 <  UMODE_REGISTERED,   /* r */
123 <  UMODE_SERVNOTICE,   /* s */
124 <  0,                  /* t */
125 <  UMODE_UNAUTH,       /* u */
126 <  0,                  /* v */
127 <  UMODE_WALLOP,       /* w */
128 <  UMODE_HIDDENHOST,   /* x */
129 <  UMODE_SPY,          /* y */
130 <  UMODE_OPERWALL,     /* z      0x7A */
131 <  0,0,0,0,0,          /* 0x7B - 0x7F */
132 <
133 <  /* 0x80 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x8F */
134 <  /* 0x90 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x9F */
135 <  /* 0xA0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xAF */
136 <  /* 0xB0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xBF */
137 <  /* 0xC0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xCF */
138 <  /* 0xD0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xDF */
139 <  /* 0xE0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xEF */
140 <  /* 0xF0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0  /* 0xFF */
71 >  { 'D', UMODE_DEAF         },
72 >  { 'F', UMODE_FARCONNECT   },
73 >  { 'G', UMODE_SOFTCALLERID },
74 >  { 'H', UMODE_HIDDEN       },
75 >  { 'R', UMODE_REGONLY      },
76 >  { 'S', UMODE_SSL          },
77 >  { 'W', UMODE_WEBIRC       },
78 >  { 'a', UMODE_ADMIN        },
79 >  { 'b', UMODE_BOTS         },
80 >  { 'c', UMODE_CCONN        },
81 >  { 'd', UMODE_DEBUG        },
82 >  { 'e', UMODE_EXTERNAL     },
83 >  { 'f', UMODE_FULL         },
84 >  { 'g', UMODE_CALLERID     },
85 >  { 'i', UMODE_INVISIBLE    },
86 >  { 'j', UMODE_REJ          },
87 >  { 'k', UMODE_SKILL        },
88 >  { 'l', UMODE_LOCOPS       },
89 >  { 'n', UMODE_NCHANGE      },
90 >  { 'o', UMODE_OPER         },
91 >  { 'p', UMODE_HIDECHANS    },
92 >  { 'q', UMODE_HIDEIDLE     },
93 >  { 'r', UMODE_REGISTERED   },
94 >  { 's', UMODE_SERVNOTICE   },
95 >  { 'u', UMODE_UNAUTH       },
96 >  { 'w', UMODE_WALLOP       },
97 >  { 'x', UMODE_HIDDENHOST   },
98 >  { 'y', UMODE_SPY          },
99 >  { '\0', 0 }
100   };
101  
102   void
103 < assemble_umode_buffer(void)
103 > user_usermodes_init(void)
104   {
146  unsigned int idx = 0;
105    char *umode_buffer_ptr = umode_buffer;
106  
107 <  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
108 <    if (user_modes[idx])
109 <      *umode_buffer_ptr++ = idx;
107 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
108 >  {
109 >    umode_map[tab->c] = tab;
110 >    *umode_buffer_ptr++ = tab->c;
111 >  }
112  
113    *umode_buffer_ptr = '\0';
114   }
# Line 163 | Line 123 | void
123   show_lusers(struct Client *source_p)
124   {
125    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
126 <    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total-Count.invisi),
127 <                       Count.invisi, dlink_list_length(&global_serv_list));
126 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
127 >                       Count.invisi, dlink_list_length(&global_server_list));
128    else
129 <    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT,
130 <                       (Count.total - Count.invisi), Count.invisi, 1);
129 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
130 >                       Count.invisi, 1);
131  
132    if (Count.oper)
133      sendto_one_numeric(source_p, &me, RPL_LUSEROP, Count.oper);
# Line 175 | Line 135 | show_lusers(struct Client *source_p)
135    if (dlink_list_length(&unknown_list))
136      sendto_one_numeric(source_p, &me, RPL_LUSERUNKNOWN, dlink_list_length(&unknown_list));
137  
138 <  if (dlink_list_length(&global_channel_list))
139 <    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&global_channel_list));
138 >  if (dlink_list_length(&channel_list))
139 >    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&channel_list));
140  
141    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
142    {
# Line 211 | Line 171 | show_lusers(struct Client *source_p)
171   void
172   show_isupport(struct Client *source_p)
173   {
174 <  const dlink_node *ptr = NULL;
174 >  const dlink_node *node = NULL;
175  
176 <  DLINK_FOREACH(ptr, support_list_lines.head)
177 <    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, ptr->data);
176 >  DLINK_FOREACH(node, support_list_lines.head)
177 >    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, node->data);
178   }
179  
180  
# Line 233 | Line 193 | report_and_set_user_flags(struct Client
193    if (IsConfDoSpoofIp(conf))
194      sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
195  
196 <  /* If this user is in the exception class, Set it "E lined" */
196 >  /* If this user is in the exception class, set it "E lined" */
197    if (IsConfExemptKline(conf))
198    {
199      SetExemptKline(source_p);
# Line 282 | Line 242 | report_and_set_user_flags(struct Client
242   static void
243   introduce_client(struct Client *source_p)
244   {
245 <  dlink_node *ptr = NULL;
245 >  dlink_node *node = NULL;
246    char ubuf[IRCD_BUFSIZE] = "";
247  
248    if (MyClient(source_p))
249 <    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
249 >    send_umode(source_p, source_p, 0, ubuf);
250    else
251 <    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
251 >    send_umode(NULL, source_p, 0, ubuf);
252  
253    watch_check_hash(source_p, RPL_LOGON);
254  
# Line 298 | Line 258 | introduce_client(struct Client *source_p
258      ubuf[1] = '\0';
259    }
260  
261 <  DLINK_FOREACH(ptr, serv_list.head)
261 >  DLINK_FOREACH(node, local_server_list.head)
262    {
263 <    struct Client *server = ptr->data;
263 >    struct Client *server = node->data;
264  
265      if (server == source_p->from)
266        continue;
# Line 311 | Line 271 | introduce_client(struct Client *source_p
271                   source_p->name, source_p->hopcount+1,
272                   (unsigned long)source_p->tsinfo,
273                   ubuf, source_p->username, source_p->host,
274 <                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
275 <                 "0" : source_p->sockhost, source_p->id,
316 <                 source_p->svid,
274 >                 source_p->sockhost, source_p->id,
275 >                 source_p->account,
276                   source_p->info);
277      else
278        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
# Line 321 | Line 280 | introduce_client(struct Client *source_p
280                   source_p->name, source_p->hopcount+1,
281                   (unsigned long)source_p->tsinfo,
282                   ubuf, source_p->username, source_p->host,
283 <                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
325 <                 "0" : source_p->sockhost, source_p->id, source_p->info);
283 >                 source_p->sockhost, source_p->id, source_p->info);
284  
285      if (!EmptyString(source_p->certfp))
286        sendto_one(server, ":%s CERTFP %s", source_p->id, source_p->certfp);
# Line 349 | Line 307 | user_welcome(struct Client *source_p)
307    {
308      AddUMode(source_p, UMODE_SSL);
309      sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
310 <                      ssl_get_cipher(source_p->localClient->fd.ssl));
310 >                      ssl_get_cipher(source_p->connection->fd.ssl));
311    }
312   #endif
313  
314 <  sendto_one_numeric(source_p, &me, RPL_WELCOME, ServerInfo.network_name,
314 >  sendto_one_numeric(source_p, &me, RPL_WELCOME, ConfigServerInfo.network_name,
315                       source_p->name);
316    sendto_one_numeric(source_p, &me, RPL_YOURHOST,
317 <                     get_listener_name(source_p->localClient->listener), ircd_version);
317 >                     get_listener_name(source_p->connection->listener), ircd_version);
318    sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
319    sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
320    show_isupport(source_p);
321 <
364 <  if (source_p->id[0])
365 <    sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
321 >  sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
322  
323    show_lusers(source_p);
324    motd_signon(source_p);
# Line 378 | Line 334 | static int
334   check_xline(struct Client *source_p)
335   {
336    struct MaskItem *conf = NULL;
381  const char *reason = NULL;
337  
338    if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
339    {
340      ++conf->count;
386
387    if (conf->reason)
388      reason = conf->reason;
389    else
390      reason = CONF_NOREASON;
391
341      sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
342                           "X-line Rejecting [%s] [%s], user %s [%s]",
343 <                         source_p->info, reason,
343 >                         source_p->info, conf->reason,
344                           get_client_name(source_p, HIDE_IP),
345                           source_p->sockhost);
346  
# Line 416 | Line 365 | register_local_user(struct Client *sourc
365  
366    assert(source_p == source_p->from);
367    assert(MyConnect(source_p));
368 <  assert(!source_p->localClient->registration);
369 <
421 <  ClearCap(source_p, CAP_TS6);
368 >  assert(IsUnknown(source_p));
369 >  assert(!source_p->connection->registration);
370  
371 <  if (ConfigFileEntry.ping_cookie)
371 >  if (ConfigGeneral.ping_cookie)
372    {
373 <    if (!IsPingSent(source_p) && !source_p->localClient->random_ping)
373 >    if (!IsPingSent(source_p) && !source_p->connection->random_ping)
374      {
375        do
376 <        source_p->localClient->random_ping = genrand_int32();
377 <      while (!source_p->localClient->random_ping);
376 >        source_p->connection->random_ping = genrand_int32();
377 >      while (!source_p->connection->random_ping);
378  
379 <      sendto_one(source_p, "PING :%u",
432 <                 source_p->localClient->random_ping);
379 >      sendto_one(source_p, "PING :%u", source_p->connection->random_ping);
380        SetPingSent(source_p);
381        return;
382      }
# Line 438 | Line 385 | register_local_user(struct Client *sourc
385        return;
386    }
387  
388 <  source_p->localClient->last_privmsg = CurrentTime;
388 >  source_p->connection->last_privmsg = CurrentTime;
389    /* Straight up the maximum rate of flooding... */
390 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
390 >  source_p->connection->allow_read = MAX_FLOOD_BURST;
391  
392    if (!check_client(source_p))
393      return;
# Line 449 | Line 396 | register_local_user(struct Client *sourc
396    {
397      sendto_one_notice(source_p, &me, ":*** Notice -- You have an illegal "
398                        "character in your hostname");
399 <    strlcpy(source_p->host, source_p->sockhost,
453 <            sizeof(source_p->host));
399 >    strlcpy(source_p->host, source_p->sockhost, sizeof(source_p->host));
400    }
401  
402 <  conf = source_p->localClient->confs.head->data;
402 >  conf = source_p->connection->confs.head->data;
403  
404    if (!IsGotId(source_p))
405    {
# Line 476 | Line 422 | register_local_user(struct Client *sourc
422        source_p->username[i++] = '~';
423  
424      for (; *p && i < USERLEN; ++p)
425 <      if (*p != '[')
480 <        source_p->username[i++] = *p;
425 >      source_p->username[i++] = *p;
426  
427      source_p->username[i] = '\0';
428    }
# Line 485 | Line 430 | register_local_user(struct Client *sourc
430    /* Password check */
431    if (!EmptyString(conf->passwd))
432    {
433 <    if (!match_conf_password(source_p->localClient->passwd, conf))
433 >    if (!match_conf_password(source_p->connection->password, conf))
434      {
435        ++ServerStats.is_ref;
436  
# Line 496 | Line 441 | register_local_user(struct Client *sourc
441    }
442  
443    /*
444 <   * Don't free source_p->localClient->passwd here - it can be required
445 <   * by masked /stats I if there are auth{} blocks with need_password = no;
444 >   * Don't free source_p->connection->password here - it can be required
445 >   * by masked /stats I if there are auth {} blocks with need_password = no;
446     * --adx
447     */
448  
# Line 517 | Line 462 | register_local_user(struct Client *sourc
462     * probably be just a percentage of the MAXCLIENTS...
463     *   -Taner
464     */
465 <  if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
466 <      (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
465 >  if ((Count.local >= GlobalSetOptions.maxclients + MAX_BUFFER) ||
466 >      (Count.local >= GlobalSetOptions.maxclients && !IsExemptLimits(source_p)))
467    {
468      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
469                           "Too many clients, rejecting %s[%s].",
# Line 553 | Line 498 | register_local_user(struct Client *sourc
498    sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
499                         "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
500                         source_p->name, source_p->username, source_p->host,
501 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
502 <                       "255.255.255.255" : source_p->sockhost,
558 <                       get_client_class(&source_p->localClient->confs),
501 >                       source_p->sockhost,
502 >                       get_client_class(&source_p->connection->confs),
503                         source_p->info, source_p->id);
504  
505 <  if (ConfigFileEntry.invisible_on_connect)
505 >  if (ConfigGeneral.invisible_on_connect)
506    {
507      AddUMode(source_p, UMODE_INVISIBLE);
508      ++Count.invisi;
# Line 570 | Line 514 | register_local_user(struct Client *sourc
514  
515      if (!(Count.max_loc % 10))
516        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
517 <                           "New Max Local Clients: %d",
517 >                           "New maximum local client connections: %u",
518                             Count.max_loc);
519    }
520  
# Line 581 | Line 525 | register_local_user(struct Client *sourc
525    assert(source_p->servptr == &me);
526    SetClient(source_p);
527    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
528 +  dlinkAdd(source_p, &source_p->node, &global_client_list);
529  
530    assert(dlinkFind(&unknown_list, source_p));
531  
532 <  dlink_move_node(&source_p->localClient->lclient_node,
532 >  dlink_move_node(&source_p->connection->lclient_node,
533                    &unknown_list, &local_client_list);
534  
535    user_welcome(source_p);
# Line 605 | Line 550 | register_local_user(struct Client *sourc
550   *                is introduced by a server.
551   */
552   void
553 < register_remote_user(struct Client *source_p, const char *username,
609 <                     const char *host, const char *server)
553 > register_remote_user(struct Client *source_p)
554   {
555 <  struct Client *target_p = NULL;
612 <
613 <  assert(source_p->username != username);
614 <
615 <  strlcpy(source_p->host, host, sizeof(source_p->host));
616 <  strlcpy(source_p->username, username, sizeof(source_p->username));
617 <
618 <  /*
619 <   * Coming from another server, take the servers word for it
620 <   */
621 <  source_p->servptr = hash_find_server(server);
622 <
623 <  /*
624 <   * Super GhostDetect:
625 <   * If we can't find the server the user is supposed to be on,
626 <   * then simply blow the user away.        -Taner
627 <   */
628 <  if (source_p->servptr == NULL)
629 <  {
630 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
631 <                         "No server %s for user %s[%s@%s] from %s",
632 <                         server, source_p->name, source_p->username,
633 <                         source_p->host, source_p->from->name);
634 <    sendto_one(source_p->from,
635 <               ":%s KILL %s :%s (Ghosted, server %s doesn't exist)",
636 <               me.id, source_p->id, me.name, server);
637 <
638 <    AddFlag(source_p, FLAGS_KILLED);
639 <    exit_client(source_p, "Ghosted Client");
640 <    return;
641 <  }
555 >  const struct Client *target_p = NULL;
556  
557    if ((target_p = source_p->servptr) && target_p->from != source_p->from)
558    {
# Line 648 | Line 562 | register_remote_user(struct Client *sour
562                           source_p->host, source_p->servptr->name,
563                           target_p->name, target_p->from->name);
564      sendto_one(source_p->from,
565 <               ":%s KILL %s :%s (NICK from wrong direction (%s != %s))",
565 >               ":%s KILL %s :%s (UID from wrong direction (%s != %s))",
566                 me.id, source_p->id, me.name, source_p->servptr->name,
567                 target_p->from->name);
568  
569      AddFlag(source_p, FLAGS_KILLED);
570 <    exit_client(source_p, "USER server wrong direction");
570 >    exit_client(source_p, "UID server wrong direction");
571      return;
572    }
573  
# Line 669 | Line 583 | register_remote_user(struct Client *sour
583  
584    SetClient(source_p);
585    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
586 +  dlinkAdd(source_p, &source_p->node, &global_client_list);
587    add_user_host(source_p->username, source_p->host, 1);
588    SetUserHost(source_p);
589  
590    if (HasFlag(source_p->servptr, FLAGS_EOB))
591 <    sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
592 <                         "Client connecting at %s: %s (%s@%s) [%s] <%s>",
593 <                         source_p->servptr->name,
594 <                         source_p->name, source_p->username, source_p->host,
595 <                         source_p->info, source_p->id);
591 >  {
592 >    if (strcmp(source_p->sockhost, "0")) /* XXX: TBR */
593 >      sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
594 >                           "Client connecting at %s: %s (%s@%s) [%s] [%s] <%s>",
595 >                           source_p->servptr->name,
596 >                           source_p->name, source_p->username, source_p->host,
597 >                           source_p->sockhost, source_p->info, source_p->id);
598 >    else
599 >      sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
600 >                           "Client connecting at %s: %s (%s@%s) [%s] <%s>",
601 >                           source_p->servptr->name,
602 >                           source_p->name, source_p->username, source_p->host,
603 >                           source_p->info, source_p->id);
604 >  }
605  
606    introduce_client(source_p);
607   }
# Line 722 | Line 646 | valid_hostname(const char *hostname)
646   int
647   valid_username(const char *username, const int local)
648   {
649 <  int dots      = 0;
649 >  unsigned int dots = 0;
650    const char *p = username;
651  
652    assert(p);
# Line 742 | Line 666 | valid_username(const char *username, con
666    {
667      while (*++p)
668      {
669 <      if (*p == '.' && ConfigFileEntry.dots_in_ident)
669 >      if (*p == '.' && ConfigGeneral.dots_in_ident)
670        {
671 <        if (++dots > ConfigFileEntry.dots_in_ident)
671 >        if (++dots > ConfigGeneral.dots_in_ident)
672            return 0;
673          if (!IsUserChar(*(p + 1)))
674            return 0;
# Line 760 | Line 684 | valid_username(const char *username, con
684          return 0;
685    }
686  
687 <  return p - username <= USERLEN;;
687 >  return p - username <= USERLEN;
688   }
689  
690   /* clean_nick_name()
# Line 775 | Line 699 | valid_nickname(const char *nickname, con
699   {
700    const char *p = nickname;
701  
702 <  assert(nickname && *nickname);
702 >  assert(p);
703  
704    /*
705     * Nicks can't start with a digit or - or be 0 length.
706     */
707 <  if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
707 >  if (EmptyString(p) || *p == '-' || (IsDigit(*p) && local))
708      return 0;
709  
710    for (; *p; ++p)
# Line 803 | Line 727 | valid_nickname(const char *nickname, con
727   */
728   void
729   send_umode(struct Client *client_p, struct Client *source_p,
730 <           unsigned int old, unsigned int sendmask, char *umode_buf)
730 >           unsigned int old, char *umode_buf)
731   {
732    char *m = umode_buf;
733    int what = 0;
# Line 812 | Line 736 | send_umode(struct Client *client_p, stru
736     * Build a string in umode_buf to represent the change in the user's
737     * mode between the new (source_p->umodes) and 'old'.
738     */
739 <  for (unsigned int i = 0; i < 128; ++i)
739 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
740    {
741 <    unsigned int flag = user_modes[i];
818 <
819 <    if (!flag)
820 <      continue;
821 <
822 <    if (MyClient(source_p) && !(flag & sendmask))
823 <      continue;
824 <
825 <    if ((flag & old) && !HasUMode(source_p, flag))
741 >    if ((tab->flag & old) && !HasUMode(source_p, tab->flag))
742      {
743        if (what == MODE_DEL)
744 <        *m++ = (char)i;
744 >        *m++ = tab->c;
745        else
746        {
747          what = MODE_DEL;
748          *m++ = '-';
749 <        *m++ = (char)i;
749 >        *m++ = tab->c;
750        }
751      }
752 <    else if (!(flag & old) && HasUMode(source_p, flag))
752 >    else if (!(tab->flag & old) && HasUMode(source_p, tab->flag))
753      {
754        if (what == MODE_ADD)
755 <        *m++ = (char)i;
755 >        *m++ = tab->c;
756        else
757        {
758          what = MODE_ADD;
759          *m++ = '+';
760 <        *m++ = (char)i;
760 >        *m++ = tab->c;
761        }
762      }
763    }
# Line 850 | Line 766 | send_umode(struct Client *client_p, stru
766  
767    if (*umode_buf && client_p)
768      sendto_one(client_p, ":%s!%s@%s MODE %s :%s",
769 <               source_p->name, source_p->username,
770 <               source_p->host, source_p->name, umode_buf);
769 >               client_p->name, client_p->username,
770 >               client_p->host, client_p->name, umode_buf);
771   }
772  
773   /* send_umode_out()
# Line 861 | Line 777 | send_umode(struct Client *client_p, stru
777   * side effects - Only send ubuf out to servers that know about this client
778   */
779   void
780 < send_umode_out(struct Client *client_p, struct Client *source_p,
865 <               unsigned int old)
780 > send_umode_out(struct Client *source_p, unsigned int old)
781   {
782    char buf[IRCD_BUFSIZE] = "";
783  
784 <  send_umode(NULL, source_p, old, SEND_UMODES, buf);
784 >  send_umode(MyClient(source_p) ? source_p : NULL, source_p, old, buf);
785  
786    if (buf[0])
787 <    sendto_server(source_p, NOCAPS, NOCAPS, ":%s MODE %s :%s",
787 >    sendto_server(source_p, 0, 0, ":%s MODE %s :%s",
788                    source_p->id, source_p->id, buf);
874
875  if (client_p && MyClient(client_p))
876    send_umode(client_p, source_p, old, 0xffffffff, buf);
789   }
790  
791   void
792   user_set_hostmask(struct Client *target_p, const char *hostname, const int what)
793   {
794 <  dlink_node *ptr = NULL;
794 >  dlink_node *node = NULL;
795  
796    if (!strcmp(target_p->host, hostname))
797      return;
# Line 888 | Line 800 | user_set_hostmask(struct Client *target_
800    {
801      case MODE_ADD:
802        AddUMode(target_p, UMODE_HIDDENHOST);
891      AddFlag(target_p, FLAGS_IP_SPOOFING);
803        break;
804      case MODE_DEL:
805        DelUMode(target_p, UMODE_HIDDENHOST);
895
896      if (!HasFlag(target_p, FLAGS_AUTH_SPOOF))
897        DelFlag(target_p, FLAGS_IP_SPOOFING);
806        break;
807      default: return;
808    }
809  
810 <  if (ConfigFileEntry.cycle_on_host_change)
810 >  if (ConfigGeneral.cycle_on_host_change)
811      sendto_common_channels_local(target_p, 0, 0, ":%s!%s@%s QUIT :Changing hostname",
812                                   target_p->name, target_p->username, target_p->host);
813  
# Line 913 | Line 821 | user_set_hostmask(struct Client *target_
821  
822    if (MyClient(target_p))
823    {
824 <    sendto_one_numeric(target_p, &me, RPL_NEWHOSTIS, target_p->host);
824 >    sendto_one_numeric(target_p, &me, RPL_VISIBLEHOST, target_p->host);
825      clear_ban_cache_client(target_p);
826    }
827  
828 <  if (!ConfigFileEntry.cycle_on_host_change)
828 >  if (!ConfigGeneral.cycle_on_host_change)
829      return;
830  
831 <  DLINK_FOREACH(ptr, target_p->channel.head)
831 >  DLINK_FOREACH(node, target_p->channel.head)
832    {
833      char modebuf[4], nickbuf[NICKLEN * 3 + 3] = "";
834      char *p = modebuf;
835      int len = 0;
836 <    const struct Membership *ms = ptr->data;
836 >    const struct Membership *member = node->data;
837  
838 <    if (has_member_flags(ms, CHFL_CHANOP))
838 >    if (has_member_flags(member, CHFL_CHANOP))
839      {
840        *p++ = 'o';
841        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
842      }
843  
844 <    if (has_member_flags(ms, CHFL_HALFOP))
844 >    if (has_member_flags(member, CHFL_HALFOP))
845      {
846        *p++ = 'h';
847        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
848      }
849  
850 <    if (has_member_flags(ms, CHFL_VOICE))
850 >    if (has_member_flags(member, CHFL_VOICE))
851      {
852        *p++ = 'v';
853        len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
# Line 947 | Line 855 | user_set_hostmask(struct Client *target_
855  
856      *p = '\0';
857  
858 <    sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s!%s@%s JOIN :%s",
859 <                                target_p->name, target_p->username, target_p->host,
860 <                                ms->chptr->chname);
858 >
859 >    sendto_channel_local_butone(target_p, CAP_EXTENDED_JOIN, 0, member->chptr, ":%s!%s@%s JOIN %s %s :%s",
860 >                                target_p->name, target_p->username,
861 >                                target_p->host, member->chptr->name,
862 >                                (!IsDigit(target_p->account[0]) && target_p->account[0] != '*') ? target_p->account : "*",
863 >                                target_p->info);
864 >    sendto_channel_local_butone(target_p, 0, CAP_EXTENDED_JOIN, member->chptr, ":%s!%s@%s JOIN :%s",
865 >                                target_p->name, target_p->username,
866 >                                target_p->host, member->chptr->name);
867 >
868      if (nickbuf[0])
869 <      sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s MODE %s +%s %s",
870 <                                  target_p->servptr->name, ms->chptr->chname,
869 >      sendto_channel_local_butone(target_p, 0, 0, member->chptr, ":%s MODE %s +%s %s",
870 >                                  target_p->servptr->name, member->chptr->name,
871                                    modebuf, nickbuf);
872  
873    }
# Line 972 | Line 887 | void
887   oper_up(struct Client *source_p)
888   {
889    const unsigned int old = source_p->umodes;
890 <  const struct MaskItem *conf = source_p->localClient->confs.head->data;
890 >  const struct MaskItem *const conf = source_p->connection->confs.head->data;
891  
892 <  assert(source_p->localClient->confs.head);
892 >  assert(source_p->connection->confs.head);
893  
894    ++Count.oper;
895    SetOper(source_p);
896  
897    if (conf->modes)
898      AddUMode(source_p, conf->modes);
899 <  else if (ConfigFileEntry.oper_umodes)
900 <    AddUMode(source_p, ConfigFileEntry.oper_umodes);
899 >  else if (ConfigGeneral.oper_umodes)
900 >    AddUMode(source_p, ConfigGeneral.oper_umodes);
901  
902    if (!(old & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
903      ++Count.invisi;
# Line 997 | Line 912 | oper_up(struct Client *source_p)
912    if (HasOFlag(source_p, OPER_FLAG_ADMIN))
913      AddUMode(source_p, UMODE_ADMIN);
914  
915 +  if (!EmptyString(conf->whois))
916 +  {
917 +    client_attach_svstag(source_p, RPL_WHOISOPERATOR, "+", conf->whois);
918 +    sendto_server(source_p, 0, 0, ":%s SVSTAG %s %lu %u + :%s",
919 +                  me.id, source_p->id, (unsigned long)source_p->tsinfo,
920 +                  RPL_WHOISOPERATOR, conf->whois);
921 +  }
922 +
923    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
924                         get_oper_name(source_p));
925 <  send_umode_out(source_p, source_p, old);
925 >  sendto_server(NULL, 0, 0, ":%s GLOBOPS :%s is now an operator",
926 >                me.id, get_oper_name(source_p));
927 >  send_umode_out(source_p, old);
928    sendto_one_numeric(source_p, &me, RPL_YOUREOPER);
929   }
930  
# Line 1022 | Line 947 | valid_sid(const char *sid)
947   * inputs       - NONE
948   * output       - NONE
949   * side effects - new_uid is filled in with server id portion (sid)
950 < *                (first 3 bytes) or defaulted to 'A'.
951 < *                Rest is filled in with 'A'
950 > *                (first 3 bytes). Rest is filled in with '9'.
951 > *
952 > * NOTE: this function assumes that 'ConfigServerInfo.sid' has been set to a proper value
953   */
954   void
955   init_uid(void)
956   {
957 <  memset(new_uid, 0, sizeof(new_uid));
1032 <
1033 <  if (!EmptyString(ServerInfo.sid))
1034 <    strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1035 <
1036 <  for (unsigned int i = 0; i < IRC_MAXSID; ++i)
1037 <    if (new_uid[i] == '\0')
1038 <      new_uid[i] = 'A';
1039 <
1040 <  /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1041 <  memcpy(new_uid + IRC_MAXSID, "AAAAA@", IRC_MAXUID);
957 >  snprintf(new_uid, sizeof(new_uid), "%s999999", ConfigServerInfo.sid);
958   }
959  
960   /*
# Line 1052 | Line 968 | init_uid(void)
968   static void
969   add_one_to_uid(unsigned int i)
970   {
971 <  if (i != IRC_MAXSID)  /* Not reached server SID portion yet? */
971 >  if (i < IRC_MAXSID)
972 >    return;
973 >
974 >  if (new_uid[i] == 'Z')
975 >    new_uid[i] = '0';
976 >  else if (new_uid[i] == '9')
977    {
978 <    if (new_uid[i] == 'Z')
979 <      new_uid[i] = '0';
1059 <    else if (new_uid[i] == '9')
1060 <    {
1061 <      new_uid[i] = 'A';
1062 <      add_one_to_uid(i - 1);
1063 <    }
1064 <    else
1065 <      ++new_uid[i];
978 >    new_uid[i] = 'A';
979 >    add_one_to_uid(i - 1);
980    }
981    else
982 <  {
1069 <    /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1070 <    if (new_uid[i] == 'Z')
1071 <      memcpy(new_uid + IRC_MAXSID, "AAAAAA", IRC_MAXUID);
1072 <    else
1073 <      ++new_uid[i];
1074 <  }
982 >    ++new_uid[i];
983   }
984  
985   /*
# Line 1099 | Line 1007 | void
1007   init_isupport(void)
1008   {
1009    add_isupport("CALLERID", NULL, -1);
1010 <  add_isupport("CASEMAPPING", CASEMAP, -1);
1010 >  add_isupport("CASEMAPPING", "rfc1459", -1);
1011    add_isupport("DEAF", "D", -1);
1012    add_isupport("KICKLEN", NULL, KICKLEN);
1013    add_isupport("MODES", NULL, MAXMODEPARAMS);
1106 #ifdef HALFOPS
1014    add_isupport("PREFIX", "(ohv)@%+", -1);
1015    add_isupport("STATUSMSG", "@%+", -1);
1016 < #else
1017 <  add_isupport("PREFIX", "(ov)@+", -1);
1111 <  add_isupport("STATUSMSG", "@+", -1);
1112 < #endif
1113 <  add_isupport("EXCEPTS", "e", -1);
1114 <  add_isupport("INVEX", "I", -1);
1016 >  add_isupport("EXCEPTS", NULL, -1);
1017 >  add_isupport("INVEX", NULL, -1);
1018   }
1019  
1020   /*
# Line 1126 | Line 1029 | init_isupport(void)
1029   void
1030   add_isupport(const char *name, const char *options, int n)
1031   {
1032 <  dlink_node *ptr;
1033 <  struct Isupport *support;
1032 >  dlink_node *node = NULL;
1033 >  struct Isupport *support = NULL;
1034  
1035 <  DLINK_FOREACH(ptr, support_list.head)
1035 >  DLINK_FOREACH(node, support_list.head)
1036    {
1037 <    support = ptr->data;
1037 >    support = node->data;
1038      if (irccmp(support->name, name) == 0)
1039      {
1040        MyFree(support->name);
# Line 1140 | Line 1043 | add_isupport(const char *name, const cha
1043      }
1044    }
1045  
1046 <  if (ptr == NULL)
1046 >  if (node == NULL)
1047    {
1048      support = MyCalloc(sizeof(*support));
1049      dlinkAddTail(support, &support->node, &support_list);
# Line 1164 | Line 1067 | add_isupport(const char *name, const cha
1067   void
1068   delete_isupport(const char *name)
1069   {
1070 <  dlink_node *ptr;
1168 <  struct Isupport *support;
1070 >  dlink_node *node = NULL;
1071  
1072 <  DLINK_FOREACH(ptr, support_list.head)
1072 >  DLINK_FOREACH(node, support_list.head)
1073    {
1074 <    support = ptr->data;
1074 >    struct Isupport *support = node->data;
1075 >
1076      if (irccmp(support->name, name) == 0)
1077      {
1078 <      dlinkDelete(ptr, &support_list);
1078 >      dlinkDelete(node, &support_list);
1079        MyFree(support->name);
1080        MyFree(support->options);
1081        MyFree(support);
# Line 1195 | Line 1098 | rebuild_isupport_message_line(void)
1098   {
1099    char isupportbuffer[IRCD_BUFSIZE];
1100    char *p = isupportbuffer;
1101 <  dlink_node *ptr = NULL, *ptr_next = NULL;
1101 >  dlink_node *node = NULL, *node_next = NULL;
1102    int n = 0;
1103    int tokens = 0;
1104    size_t len = 0;
1105    size_t reserve = strlen(me.name) + HOSTLEN + strlen(numeric_form(RPL_ISUPPORT));
1106  
1107 <  DLINK_FOREACH_SAFE(ptr, ptr_next, support_list_lines.head)
1107 >  DLINK_FOREACH_SAFE(node, node_next, support_list_lines.head)
1108    {
1109 <    dlinkDelete(ptr, &support_list_lines);
1110 <    MyFree(ptr->data);
1111 <    free_dlink_node(ptr);
1109 >    dlinkDelete(node, &support_list_lines);
1110 >    MyFree(node->data);
1111 >    free_dlink_node(node);
1112    }
1113  
1114 <  DLINK_FOREACH(ptr, support_list.head)
1114 >  DLINK_FOREACH(node, support_list.head)
1115    {
1116 <    struct Isupport *support = ptr->data;
1116 >    struct Isupport *support = node->data;
1117  
1118      p += (n = sprintf(p, "%s", support->name));
1119      len += n;

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)