ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_user.c (file contents), Revision 2691 by michael, Tue Dec 17 18:55:59 2013 UTC vs.
ircd-hybrid/trunk/src/user.c (file contents), Revision 7771 by michael, Sat Oct 8 16:30:33 2016 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_user.c: User related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2016 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 16 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file user.c
23 > * \brief User related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29 < #include "s_user.h"
28 < #include "s_misc.h"
29 > #include "user.h"
30   #include "channel.h"
31   #include "channel_mode.h"
32   #include "client.h"
32 #include "fdlist.h"
33   #include "hash.h"
34 + #include "id.h"
35   #include "irc_string.h"
35 #include "s_bsd.h"
36   #include "ircd.h"
37   #include "listener.h"
38   #include "motd.h"
39   #include "numeric.h"
40   #include "conf.h"
41 + #include "conf_gecos.h"
42   #include "log.h"
43 < #include "s_serv.h"
43 > #include "server.h"
44   #include "send.h"
44 #include "supported.h"
45 #include "whowas.h"
45   #include "memory.h"
46   #include "packet.h"
47   #include "rng_mt.h"
48   #include "userhost.h"
49 < #include "hook.h"
51 < #include "s_misc.h"
49 > #include "misc.h"
50   #include "parse.h"
51   #include "watch.h"
52 + #include "isupport.h"
53 + #include "tls.h"
54  
55   static char umode_buffer[IRCD_BUFSIZE];
56  
57 < static void user_welcome(struct Client *);
58 < static void report_and_set_user_flags(struct Client *, const struct MaskItem *);
59 < static int check_xline(struct Client *);
60 < static void introduce_client(struct Client *);
61 < static const char *uid_get(void);
62 <
63 < /* Used for building up the isupport string,
64 < * used with init_isupport, add_isupport, delete_isupport
65 < */
66 <
67 < struct Isupport
57 > const struct user_modes *umode_map[256];
58 > const struct user_modes  umode_tab[] =
59   {
60 <  dlink_node node;
61 <  char *name;
62 <  char *options;
63 <  int number;
64 < };
65 <
66 < static dlink_list support_list;
67 < static dlink_list support_list_lines;
68 <
69 < /* memory is cheap. map 0-255 to equivalent mode */
70 < const unsigned int user_modes[256] =
71 < {
72 <  /* 0x00 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x0F */
73 <  /* 0x10 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x1F */
74 <  /* 0x20 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x2F */
75 <  /* 0x30 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x3F */
76 <  0,                  /* @ */
77 <  0,                  /* A */
78 <  0,                  /* B */
79 <  0,                  /* C */
80 <  UMODE_DEAF,         /* D */
81 <  0,                  /* E */
82 <  UMODE_FARCONNECT,   /* F */
83 <  UMODE_SOFTCALLERID, /* G */
84 <  UMODE_HIDDEN,       /* H */
85 <  0,                  /* I */
86 <  0,                  /* J */
87 <  0,                  /* K */
88 <  0,                  /* L */
98 <  0,                  /* M */
99 <  0,                  /* N */
100 <  0,                  /* O */
101 <  0,                  /* P */
102 <  0,                  /* Q */
103 <  UMODE_REGONLY,      /* R */
104 <  UMODE_SSL,          /* S */
105 <  0,                  /* T */
106 <  0,                  /* U */
107 <  0,                  /* V */
108 <  UMODE_WEBIRC,       /* W */
109 <  0,                  /* X */
110 <  0,                  /* Y */
111 <  0,                  /* Z 0x5A */
112 <  0, 0, 0, 0, 0,      /* 0x5F   */
113 <  0,                  /* 0x60   */
114 <  UMODE_ADMIN,        /* a */
115 <  UMODE_BOTS,         /* b */
116 <  UMODE_CCONN,        /* c */
117 <  UMODE_DEBUG,        /* d */
118 <  UMODE_EXTERNAL,     /* e */
119 <  UMODE_FULL,         /* f */
120 <  UMODE_CALLERID,     /* g */
121 <  0,                  /* h */
122 <  UMODE_INVISIBLE,    /* i */
123 <  UMODE_REJ,          /* j */
124 <  UMODE_SKILL,        /* k */
125 <  UMODE_LOCOPS,       /* l */
126 <  0,                  /* m */
127 <  UMODE_NCHANGE,      /* n */
128 <  UMODE_OPER,         /* o */
129 <  0,                  /* p */
130 <  0,                  /* q */
131 <  UMODE_REGISTERED,   /* r */
132 <  UMODE_SERVNOTICE,   /* s */
133 <  0,                  /* t */
134 <  UMODE_UNAUTH,       /* u */
135 <  0,                  /* v */
136 <  UMODE_WALLOP,       /* w */
137 <  UMODE_HIDDENHOST,   /* x */
138 <  UMODE_SPY,          /* y */
139 <  UMODE_OPERWALL,     /* z      0x7A */
140 <  0,0,0,0,0,          /* 0x7B - 0x7F */
141 <
142 <  /* 0x80 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x8F */
143 <  /* 0x90 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x9F */
144 <  /* 0xA0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xAF */
145 <  /* 0xB0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xBF */
146 <  /* 0xC0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xCF */
147 <  /* 0xD0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xDF */
148 <  /* 0xE0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xEF */
149 <  /* 0xF0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0  /* 0xFF */
60 >  { 'D', UMODE_DEAF         },
61 >  { 'F', UMODE_FARCONNECT   },
62 >  { 'G', UMODE_SOFTCALLERID },
63 >  { 'H', UMODE_HIDDEN       },
64 >  { 'R', UMODE_REGONLY      },
65 >  { 'S', UMODE_SSL          },
66 >  { 'W', UMODE_WEBIRC       },
67 >  { 'a', UMODE_ADMIN        },
68 >  { 'b', UMODE_BOTS         },
69 >  { 'c', UMODE_CCONN        },
70 >  { 'd', UMODE_DEBUG        },
71 >  { 'e', UMODE_EXTERNAL     },
72 >  { 'f', UMODE_FULL         },
73 >  { 'g', UMODE_CALLERID     },
74 >  { 'i', UMODE_INVISIBLE    },
75 >  { 'j', UMODE_REJ          },
76 >  { 'k', UMODE_SKILL        },
77 >  { 'l', UMODE_LOCOPS       },
78 >  { 'n', UMODE_NCHANGE      },
79 >  { 'o', UMODE_OPER         },
80 >  { 'p', UMODE_HIDECHANS    },
81 >  { 'q', UMODE_HIDEIDLE     },
82 >  { 'r', UMODE_REGISTERED   },
83 >  { 's', UMODE_SERVNOTICE   },
84 >  { 'u', UMODE_UNAUTH       },
85 >  { 'w', UMODE_WALLOP       },
86 >  { 'x', UMODE_HIDDENHOST   },
87 >  { 'y', UMODE_SPY          },
88 >  { '\0', 0 }
89   };
90  
91   void
92 < assemble_umode_buffer(void)
92 > user_modes_init(void)
93   {
155  unsigned int idx = 0;
94    char *umode_buffer_ptr = umode_buffer;
95  
96 <  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
97 <    if (user_modes[idx])
98 <      *umode_buffer_ptr++ = idx;
96 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
97 >  {
98 >    umode_map[tab->c] = tab;
99 >    *umode_buffer_ptr++ = tab->c;
100 >  }
101  
102    *umode_buffer_ptr = '\0';
103   }
# Line 169 | Line 109 | assemble_umode_buffer(void)
109   * side effects - display to client user counts etc.
110   */
111   void
112 < show_lusers(struct Client *source_p)
112 > show_lusers(struct Client *client_p)
113   {
114 <  const char *from, *to;
115 <
116 <  if (!MyConnect(source_p) && IsCapable(source_p->from, CAP_TS6) && HasID(source_p))
177 <  {
178 <    from = me.id;
179 <    to = source_p->id;
180 <  }
114 >  if (!ConfigServerHide.hide_servers || HasUMode(client_p, UMODE_OPER))
115 >    sendto_one_numeric(client_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
116 >                       Count.invisi, dlink_list_length(&global_server_list));
117    else
118 <  {
119 <    from = me.name;
184 <    to = source_p->name;
185 <  }
118 >    sendto_one_numeric(client_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
119 >                       Count.invisi, 1);
120  
121 <  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
122 <    sendto_one(source_p, form_str(RPL_LUSERCLIENT),
123 <               from, to, (Count.total-Count.invisi),
124 <               Count.invisi, dlink_list_length(&global_serv_list));
125 <  else
126 <    sendto_one(source_p, form_str(RPL_LUSERCLIENT), from, to,
127 <               (Count.total-Count.invisi), Count.invisi, 1);
121 >  if (Count.oper)
122 >    sendto_one_numeric(client_p, &me, RPL_LUSEROP, Count.oper);
123 >
124 >  if (dlink_list_length(&unknown_list))
125 >    sendto_one_numeric(client_p, &me, RPL_LUSERUNKNOWN, dlink_list_length(&unknown_list));
126 >
127 >  if (dlink_list_length(&channel_list))
128 >    sendto_one_numeric(client_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&channel_list));
129  
130 <  if (Count.oper > 0)
131 <    sendto_one(source_p, form_str(RPL_LUSEROP),
132 <               from, to, Count.oper);
133 <
199 <  if (dlink_list_length(&unknown_list) > 0)
200 <    sendto_one(source_p, form_str(RPL_LUSERUNKNOWN),
201 <               from, to, dlink_list_length(&unknown_list));
202 <
203 <  if (dlink_list_length(&global_channel_list) > 0)
204 <    sendto_one(source_p, form_str(RPL_LUSERCHANNELS),
205 <               from, to, dlink_list_length(&global_channel_list));
206 <
207 <  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
208 <  {
209 <    sendto_one(source_p, form_str(RPL_LUSERME),
210 <               from, to, Count.local, Count.myserver);
211 <    sendto_one(source_p, form_str(RPL_LOCALUSERS),
212 <               from, to, Count.local, Count.max_loc);
130 >  if (!ConfigServerHide.hide_servers || HasUMode(client_p, UMODE_OPER))
131 >  {
132 >    sendto_one_numeric(client_p, &me, RPL_LUSERME, Count.local, Count.myserver);
133 >    sendto_one_numeric(client_p, &me, RPL_LOCALUSERS, Count.local, Count.max_loc);
134    }
135    else
136    {
137 <    sendto_one(source_p, form_str(RPL_LUSERME),
138 <               from, to, Count.total, 0);
218 <    sendto_one(source_p, form_str(RPL_LOCALUSERS),
219 <               from, to, Count.total, Count.max_tot);
137 >    sendto_one_numeric(client_p, &me, RPL_LUSERME, Count.total, 0);
138 >    sendto_one_numeric(client_p, &me, RPL_LOCALUSERS, Count.total, Count.max_tot);
139    }
140  
141 <  sendto_one(source_p, form_str(RPL_GLOBALUSERS),
142 <             from, to, Count.total, Count.max_tot);
143 <
144 <  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
145 <    sendto_one(source_p, form_str(RPL_STATSCONN), from, to,
227 <               Count.max_loc_con, Count.max_loc_cli, Count.totalrestartcount);
141 >  sendto_one_numeric(client_p, &me, RPL_GLOBALUSERS, Count.total, Count.max_tot);
142 >
143 >  if (!ConfigServerHide.hide_servers || HasUMode(client_p, UMODE_OPER))
144 >    sendto_one_numeric(client_p, &me, RPL_STATSCONN, Count.max_loc_con,
145 >                       Count.max_loc_cli, Count.totalrestartcount);
146  
147    if (Count.local > Count.max_loc_cli)
148      Count.max_loc_cli = Count.local;
# Line 233 | Line 151 | show_lusers(struct Client *source_p)
151      Count.max_loc_con = Count.local + Count.myserver;
152   }
153  
154 < /* show_isupport()
154 > /* report_and_set_user_flags()
155   *
156 < * inputs       - pointer to client
156 > * inputs       - pointer to client_p
157 > *              - pointer to conf for this user
158   * output       - NONE
159 < * side effects - display to client what we support (for them)
159 > * side effects - Report to user any special flags
160 > *                they are getting, and set them.
161   */
162 < void
163 < show_isupport(struct Client *source_p)
162 > static void
163 > report_and_set_user_flags(struct Client *client_p, const struct MaskItem *conf)
164   {
165 <  const dlink_node *ptr = NULL;
165 >  /* If this user is being spoofed, tell them so */
166 >  if (IsConfDoSpoofIp(conf))
167 >    sendto_one_notice(client_p, &me, ":*** Spoofing your IP");
168 >
169 >  /* If this user is in the exception class, set it "E lined" */
170 >  if (IsConfExemptKline(conf))
171 >  {
172 >    AddFlag(client_p, FLAGS_EXEMPTKLINE);
173 >    sendto_one_notice(client_p, &me, ":*** You are exempt from K/D lines");
174 >  }
175 >
176 >  if (IsConfExemptXline(conf))
177 >  {
178 >    AddFlag(client_p, FLAGS_EXEMPTXLINE);
179 >    sendto_one_notice(client_p, &me, ":*** You are exempt from X lines");
180 >  }
181 >
182 >  if (IsConfExemptResv(conf))
183 >  {
184 >    AddFlag(client_p, FLAGS_EXEMPTRESV);
185 >    sendto_one_notice(client_p, &me, ":*** You are exempt from resvs");
186 >  }
187  
188 <  DLINK_FOREACH(ptr, support_list_lines.head)
189 <    sendto_one(source_p, form_str(RPL_ISUPPORT), me.name,
190 <               source_p->name, ptr->data);
188 >  /* If this user is exempt from user limits set it "F lined" */
189 >  if (IsConfExemptLimits(conf))
190 >  {
191 >    AddFlag(client_p, FLAGS_NOLIMIT);
192 >    sendto_one_notice(client_p, &me, ":*** You are exempt from user limits");
193 >  }
194 >
195 >  if (IsConfCanFlood(conf))
196 >  {
197 >    AddFlag(client_p, FLAGS_CANFLOOD);
198 >    sendto_one_notice(client_p, &me, ":*** You are exempt from flood protection");
199 >  }
200   }
201  
202 < /*
203 < ** register_local_user
204 < **      This function is called when both NICK and USER messages
205 < **      have been accepted for the client, in whatever order. Only
206 < **      after this, is the USER message propagated.
207 < **
208 < **      NICK's must be propagated at once when received, although
209 < **      it would be better to delay them too until full info is
210 < **      available. Doing it is not so simple though, would have
211 < **      to implement the following:
212 < **
213 < **      (actually it has been implemented already for a while) -orabidoo
214 < **
215 < **      1) user telnets in and gives only "NICK foobar" and waits
216 < **      2) another user far away logs in normally with the nick
217 < **         "foobar" (quite legal, as this server didn't propagate
218 < **         it).
219 < **      3) now this server gets nick "foobar" from outside, but
220 < **         has alread the same defined locally. Current server
221 < **         would just issue "KILL foobar" to clean out dups. But,
222 < **         this is not fair. It should actually request another
223 < **         nick from local user or kill him/her...
224 < */
202 > /* introduce_client()
203 > *
204 > * inputs       - client_p
205 > * output       - NONE
206 > * side effects - This common function introduces a client to the rest
207 > *                of the net, either from a local client connect or
208 > *                from a remote connect.
209 > */
210 > static void
211 > introduce_client(struct Client *client_p)
212 > {
213 >  dlink_node *node = NULL;
214 >  char ubuf[IRCD_BUFSIZE] = "";
215 >
216 >  send_umode(client_p, MyConnect(client_p), 0, ubuf);
217 >  watch_check_hash(client_p, RPL_LOGON);
218 >
219 >  if (ubuf[0] == '\0')
220 >  {
221 >    ubuf[0] = '+';
222 >    ubuf[1] = '\0';
223 >  }
224 >
225 >  DLINK_FOREACH(node, local_server_list.head)
226 >  {
227 >    struct Client *server_p = node->data;
228 >
229 >    if (server_p == client_p->from)
230 >      continue;
231 >
232 >    sendto_one(server_p, ":%s UID %s %u %ju %s %s %s %s %s %s :%s",
233 >               client_p->servptr->id,
234 >               client_p->name, client_p->hopcount+1,
235 >               client_p->tsinfo,
236 >               ubuf, client_p->username, client_p->host,
237 >               client_p->sockhost, client_p->id,
238 >               client_p->account,
239 >               client_p->info);
240 >
241 >    if (!EmptyString(client_p->certfp))
242 >      sendto_one(server_p, ":%s CERTFP %s", client_p->id, client_p->certfp);
243 >  }
244 > }
245 >
246 > /* user_welcome()
247 > *
248 > * inputs       - client pointer to client to welcome
249 > * output       - NONE
250 > * side effects -
251 > */
252 > static void
253 > user_welcome(struct Client *client_p)
254 > {
255 >  static const char built_date[] = __DATE__ " at " __TIME__;
256 >
257 >  if (HasFlag(client_p, FLAGS_SSL))
258 >  {
259 >    AddUMode(client_p, UMODE_SSL);
260 >    sendto_one_notice(client_p, &me, ":*** Connected securely via %s",
261 >                      tls_get_cipher(&client_p->connection->fd.ssl));
262 >  }
263 >
264 >  sendto_one_numeric(client_p, &me, RPL_WELCOME, ConfigServerInfo.network_name,
265 >                     client_p->name);
266 >  sendto_one_numeric(client_p, &me, RPL_YOURHOST,
267 >                     listener_get_name(client_p->connection->listener), ircd_version);
268 >  sendto_one_numeric(client_p, &me, RPL_CREATED, built_date);
269 >  sendto_one_numeric(client_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
270 >
271 >  isupport_show(client_p);
272 >  show_lusers(client_p);
273 >  motd_signon(client_p);
274 > }
275 >
276 > /* check_xline()
277 > *
278 > * inputs       - pointer to client to test
279 > * outupt       - 1 if exiting 0 if ok
280 > * side effects -
281 > */
282 > static int
283 > check_xline(struct Client *client_p)
284 > {
285 >  const struct GecosItem *gecos = NULL;
286 >
287 >  if (HasFlag(client_p, FLAGS_EXEMPTXLINE))
288 >    return 0;
289 >
290 >  if ((gecos = gecos_find(client_p->info, match)))
291 >  {
292 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
293 >                         "X-line Rejecting [%s] [%s], user %s [%s]",
294 >                         client_p->info, gecos->reason,
295 >                         get_client_name(client_p, HIDE_IP),
296 >                         client_p->sockhost);
297 >
298 >    ++ServerStats.is_ref;
299 >    exit_client(client_p, "Bad user info");
300 >    return 1;
301 >  }
302 >
303 >  return 0;
304 > }
305 >
306 > /*! \brief This function is called when both NICK and USER messages
307 > *      have been accepted for the client, in whatever order. Only
308 > *      after this, is the UID message propagated.
309 > * \param client_p Pointer to given client to introduce
310 > */
311   void
312 < register_local_user(struct Client *source_p)
312 > register_local_user(struct Client *client_p)
313   {
278  const char *id = NULL;
314    const struct MaskItem *conf = NULL;
315  
316 <  assert(source_p != NULL);
317 <  assert(source_p == source_p->from);
318 <  assert(MyConnect(source_p));
319 <  assert(!source_p->localClient->registration);
285 <
286 <  ClearCap(source_p, CAP_TS6);
316 >  assert(client_p == client_p->from);
317 >  assert(MyConnect(client_p));
318 >  assert(IsUnknown(client_p));
319 >  assert(!client_p->connection->registration);
320  
321 <  if (ConfigFileEntry.ping_cookie)
321 >  if (ConfigGeneral.ping_cookie)
322    {
323 <    if (!IsPingSent(source_p) && !source_p->localClient->random_ping)
323 >    if (!HasFlag(client_p, FLAGS_PINGSENT) && !client_p->connection->random_ping)
324      {
325        do
326 <        source_p->localClient->random_ping = genrand_int32();
327 <      while (!source_p->localClient->random_ping);
326 >        client_p->connection->random_ping = genrand_int32();
327 >      while (!client_p->connection->random_ping);
328  
329 <      sendto_one(source_p, "PING :%u",
330 <                 source_p->localClient->random_ping);
298 <      SetPingSent(source_p);
329 >      sendto_one(client_p, "PING :%u", client_p->connection->random_ping);
330 >      AddFlag(client_p, FLAGS_PINGSENT);
331        return;
332      }
333  
334 <    if (!HasPingCookie(source_p))
334 >    if (!HasFlag(client_p, FLAGS_PING_COOKIE))
335        return;
336    }
337  
338 <  source_p->localClient->last_privmsg = CurrentTime;
338 >  client_p->connection->last_privmsg = CurrentTime;
339    /* Straight up the maximum rate of flooding... */
340 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
340 >  client_p->connection->allow_read = MAX_FLOOD_BURST;
341  
342 <  if (!check_client(source_p))
342 >  if (!check_client(client_p))
343      return;
344  
345 <  if (!valid_hostname(source_p->host))
345 >  if (!valid_hostname(client_p->host))
346    {
347 <    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You have an illegal "
348 <               "character in your hostname", me.name, source_p->name);
349 <    strlcpy(source_p->host, source_p->sockhost,
318 <            sizeof(source_p->host));
347 >    sendto_one_notice(client_p, &me, ":*** Notice -- You have an illegal "
348 >                      "character in your hostname");
349 >    strlcpy(client_p->host, client_p->sockhost, sizeof(client_p->host));
350    }
351  
352 <  conf = source_p->localClient->confs.head->data;
352 >  conf = client_p->connection->confs.head->data;
353  
354 <  if (!IsGotId(source_p))
354 >  if (!HasFlag(client_p, FLAGS_GOTID))
355    {
356 <    char username[USERLEN + 1];
326 <    const char *p = username;
356 >    char username[USERLEN + 1] = "";
357      unsigned int i = 0;
358  
359      if (IsNeedIdentd(conf))
360      {
361        ++ServerStats.is_ref;
362 <      sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You need to install "
363 <                 "identd to use this server", me.name, source_p->name);
364 <      exit_client(source_p, &me, "Install identd");
362 >      sendto_one_notice(client_p, &me, ":*** Notice -- You need to install "
363 >                        "identd to use this server");
364 >      exit_client(client_p, "Install identd");
365        return;
366      }
367  
368 <    strlcpy(username, source_p->username, sizeof(username));
368 >    strlcpy(username, client_p->username, sizeof(username));
369  
370      if (!IsNoTilde(conf))
371 <      source_p->username[i++] = '~';
371 >      client_p->username[i++] = '~';
372  
373 <    for (; *p && i < USERLEN; ++p)
374 <      if (*p != '[')
345 <        source_p->username[i++] = *p;
373 >    for (const char *p = username; *p && i < USERLEN; ++p)
374 >      client_p->username[i++] = *p;
375  
376 <    source_p->username[i] = '\0';
376 >    client_p->username[i] = '\0';
377    }
378  
379 <  /* password check */
379 >  /* Password check */
380    if (!EmptyString(conf->passwd))
381    {
382 <    const char *pass = source_p->localClient->passwd;
354 <
355 <    if (!match_conf_password(pass, conf))
382 >    if (!match_conf_password(client_p->connection->password, conf))
383      {
384        ++ServerStats.is_ref;
385 <      sendto_one(source_p, form_str(ERR_PASSWDMISMATCH),
386 <                 me.name, source_p->name);
387 <      exit_client(source_p, &me, "Bad Password");
385 >
386 >      sendto_one_numeric(client_p, &me, ERR_PASSWDMISMATCH);
387 >      exit_client(client_p, "Bad Password");
388        return;
389      }
390    }
391  
392 <  /* don't free source_p->localClient->passwd here - it can be required
393 <   * by masked /stats I if there are auth{} blocks with need_password = no;
392 >  /*
393 >   * Don't free client_p->connection->password here - it can be required
394 >   * by masked /stats I if there are auth {} blocks with need_password = no;
395     * --adx
396     */
397  
398 <  /* report if user has &^>= etc. and set flags as needed in source_p */
399 <  report_and_set_user_flags(source_p, conf);
398 >  /*
399 >   * Report if user has &^>= etc. and set flags as needed in client_p
400 >   */
401 >  report_and_set_user_flags(client_p, conf);
402  
403 <  if (IsDead(source_p))
403 >  if (IsDead(client_p))
404      return;
405  
406 <  /* Limit clients -
406 >  /*
407 >   * Limit clients -
408     * We want to be able to have servers and F-line clients
409     * connect, so save room for "buffer" connections.
410     * Smaller servers may want to decrease this, and it should
411     * probably be just a percentage of the MAXCLIENTS...
412     *   -Taner
413     */
414 <  /* Except "F:" clients */
415 <  if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
385 <      (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
414 >  if ((Count.local >= GlobalSetOptions.maxclients + MAX_BUFFER) ||
415 >      (Count.local >= GlobalSetOptions.maxclients && !HasFlag(client_p, FLAGS_NOLIMIT)))
416    {
417      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
418                           "Too many clients, rejecting %s[%s].",
419 <                         source_p->name, source_p->host);
419 >                         client_p->name, client_p->host);
420      ++ServerStats.is_ref;
421 <    exit_client(source_p, &me, "Sorry, server is full - try later");
421 >    exit_client(client_p, "Sorry, server is full - try later");
422      return;
423    }
424  
425 <  /* valid user name check */
396 <  if (!valid_username(source_p->username, 1))
425 >  if (!valid_username(client_p->username, 1))
426    {
427 <    char tmpstr2[IRCD_BUFSIZE];
427 >    char buf[IRCD_BUFSIZE] = "";
428  
429      sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
430                           "Invalid username: %s (%s@%s)",
431 <                         source_p->name, source_p->username, source_p->host);
431 >                         client_p->name, client_p->username, client_p->host);
432      ++ServerStats.is_ref;
433 <    snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
434 <             source_p->username);
406 <    exit_client(source_p, &me, tmpstr2);
433 >    snprintf(buf, sizeof(buf), "Invalid username [%s]", client_p->username);
434 >    exit_client(client_p, buf);
435      return;
436    }
437  
438 <  if (check_xline(source_p))
438 >  if (check_xline(client_p))
439      return;
440  
441 <  while (hash_find_id((id = uid_get())) != NULL)
441 >  const char *id;
442 >  while (hash_find_id((id = uid_get())))
443      ;
444  
445 <  strlcpy(source_p->id, id, sizeof(source_p->id));
446 <  hash_add_id(source_p);
445 >  strlcpy(client_p->id, id, sizeof(client_p->id));
446 >  hash_add_id(client_p);
447  
448    sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
449                         "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
450 <                       source_p->name, source_p->username, source_p->host,
451 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
452 <                       "255.255.255.255" : source_p->sockhost,
453 <                       get_client_class(&source_p->localClient->confs),
425 <                       source_p->info, source_p->id);
450 >                       client_p->name, client_p->username, client_p->host,
451 >                       client_p->sockhost,
452 >                       get_client_class(&client_p->connection->confs),
453 >                       client_p->info, client_p->id);
454  
455 <  if (ConfigFileEntry.invisible_on_connect)
455 >  if (ConfigGeneral.invisible_on_connect)
456    {
457 <    AddUMode(source_p, UMODE_INVISIBLE);
457 >    AddUMode(client_p, UMODE_INVISIBLE);
458      ++Count.invisi;
459    }
460  
# Line 435 | Line 463 | register_local_user(struct Client *sourc
463      Count.max_loc = Count.local;
464  
465      if (!(Count.max_loc % 10))
466 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
467 <                           "New Max Local Clients: %d",
466 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
467 >                           "New maximum local client connections: %u",
468                             Count.max_loc);
469    }
470  
443  /* Increment our total user count here */
471    if (++Count.total > Count.max_tot)
472      Count.max_tot = Count.total;
473    ++Count.totalrestartcount;
474  
475 <  assert(source_p->servptr == &me);
476 <  SetClient(source_p);
477 <  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
475 >  assert(client_p->servptr == &me);
476 >  SetClient(client_p);
477 >  dlinkAdd(client_p, &client_p->lnode, &client_p->servptr->serv->client_list);
478 >  dlinkAdd(client_p, &client_p->node, &global_client_list);
479  
480 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
480 >  assert(dlinkFind(&unknown_list, client_p));
481  
482 <  assert(dlinkFind(&unknown_list, source_p));
455 <
456 <  dlink_move_node(&source_p->localClient->lclient_node,
482 >  dlink_move_node(&client_p->connection->lclient_node,
483                    &unknown_list, &local_client_list);
484  
485 <  user_welcome(source_p);
486 <  add_user_host(source_p->username, source_p->host, 0);
487 <  SetUserHost(source_p);
485 >  user_welcome(client_p);
486 >  userhost_add(client_p->sockhost, 0);
487 >  AddFlag(client_p, FLAGS_USERHOST);
488  
489 <  introduce_client(source_p);
489 >  introduce_client(client_p);
490   }
491  
492   /* register_remote_user()
493   *
494 < * inputs       - source_p remote or directly connected client
494 > * inputs       - client_p remote or directly connected client
495   *              - username to register as
496   *              - host name to register as
497   *              - server name
472 *              - realname (gecos)
498   * output       - NONE
499   * side effects - This function is called when a remote client
500   *                is introduced by a server.
501   */
502   void
503 < register_remote_user(struct Client *source_p,
479 <                     const char *username, const char *host, const char *server,
480 <                     const char *realname)
503 > register_remote_user(struct Client *client_p)
504   {
505 <  struct Client *target_p = NULL;
483 <
484 <  assert(source_p != NULL);
485 <  assert(source_p->username != username);
486 <
487 <  strlcpy(source_p->host, host, sizeof(source_p->host));
488 <  strlcpy(source_p->username, username, sizeof(source_p->username));
489 <
490 <  /*
491 <   * coming from another server, take the servers word for it
492 <   */
493 <  source_p->servptr = hash_find_server(server);
494 <
495 <  /*
496 <   * Super GhostDetect:
497 <   * If we can't find the server the user is supposed to be on,
498 <   * then simply blow the user away.        -Taner
499 <   */
500 <  if (source_p->servptr == NULL)
501 <  {
502 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
503 <                         "No server %s for user %s[%s@%s] from %s",
504 <                         server, source_p->name, source_p->username,
505 <                         source_p->host, source_p->from->name);
506 <    kill_client(source_p->from, source_p, "%s (Server doesn't exist)", me.name);
507 <
508 <    AddFlag(source_p, FLAGS_KILLED);
509 <    exit_client(source_p, &me, "Ghosted Client");
510 <    return;
511 <  }
512 <
513 <  if ((target_p = source_p->servptr) && target_p->from != source_p->from)
514 <  {
515 <    sendto_realops_flags(UMODE_DEBUG, L_ALL, SEND_NOTICE,
516 <                         "Bad User [%s] :%s USER %s@%s %s, != %s[%s]",
517 <                         source_p->from->name, source_p->name, source_p->username,
518 <                         source_p->host, source_p->servptr->name,
519 <                         target_p->name, target_p->from->name);
520 <    kill_client(source_p->from, source_p,
521 <                "%s (NICK from wrong direction (%s != %s))",
522 <                me.name, source_p->servptr->name, target_p->from->name);
523 <    AddFlag(source_p, FLAGS_KILLED);
524 <    exit_client(source_p, &me, "USER server wrong direction");
525 <    return;
526 <  }
505 >  assert(client_p->servptr->from == client_p->from);
506  
507    /*
508     * If the nick has been introduced by a services server,
509     * make it a service as well.
510     */
511 <  if (HasFlag(source_p->servptr, FLAGS_SERVICE))
512 <    AddFlag(source_p, FLAGS_SERVICE);
511 >  if (HasFlag(client_p->servptr, FLAGS_SERVICE))
512 >    AddFlag(client_p, FLAGS_SERVICE);
513  
535  /* Increment our total user count here */
514    if (++Count.total > Count.max_tot)
515      Count.max_tot = Count.total;
516  
517 <  SetClient(source_p);
518 <  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
519 <  add_user_host(source_p->username, source_p->host, 1);
520 <  SetUserHost(source_p);
517 >  SetClient(client_p);
518 >  dlinkAdd(client_p, &client_p->lnode, &client_p->servptr->serv->client_list);
519 >  dlinkAdd(client_p, &client_p->node, &global_client_list);
520 >  userhost_add(client_p->sockhost, 1);
521 >  AddFlag(client_p, FLAGS_USERHOST);
522  
523 <  if (HasFlag(source_p->servptr, FLAGS_EOB))
523 >  if (HasFlag(client_p->servptr, FLAGS_EOB))
524      sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
525 <                         "Client connecting at %s: %s (%s@%s) [%s] <%s>",
526 <                         source_p->servptr->name,
527 <                         source_p->name, source_p->username, source_p->host,
528 <                         source_p->info, source_p->id);
525 >                         "Client connecting at %s: %s (%s@%s) [%s] [%s] <%s>",
526 >                         client_p->servptr->name,
527 >                         client_p->name, client_p->username, client_p->host,
528 >                         client_p->sockhost, client_p->info, client_p->id);
529  
530 <  introduce_client(source_p);
552 < }
553 <
554 < /* introduce_client()
555 < *
556 < * inputs       - source_p
557 < * output       - NONE
558 < * side effects - This common function introduces a client to the rest
559 < *                of the net, either from a local client connect or
560 < *                from a remote connect.
561 < */
562 < static void
563 < introduce_client(struct Client *source_p)
564 < {
565 <  dlink_node *server_node = NULL;
566 <  char ubuf[IRCD_BUFSIZE];
567 <
568 <  if (MyClient(source_p))
569 <    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
570 <  else
571 <    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
572 <
573 <  watch_check_hash(source_p, RPL_LOGON);
574 <
575 <  if (ubuf[0] == '\0')
576 <  {
577 <    ubuf[0] = '+';
578 <    ubuf[1] = '\0';
579 <  }
580 <
581 <  DLINK_FOREACH(server_node, serv_list.head)
582 <  {
583 <    struct Client *server = server_node->data;
584 <
585 <    if (server == source_p->from)
586 <        continue;
587 <
588 <    if (IsCapable(server, CAP_SVS))
589 <    {
590 <      if (IsCapable(server, CAP_TS6) && HasID(source_p))
591 <        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
592 <                   source_p->servptr->id,
593 <                   source_p->name, source_p->hopcount+1,
594 <                   (unsigned long)source_p->tsinfo,
595 <                   ubuf, source_p->username, source_p->host,
596 <                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
597 <                   "0" : source_p->sockhost, source_p->id,
598 <                   source_p->svid,
599 <                   source_p->info);
600 <      else
601 <        sendto_one(server, "NICK %s %d %lu %s %s %s %s %s :%s",
602 <                   source_p->name, source_p->hopcount+1,
603 <                   (unsigned long)source_p->tsinfo,
604 <                   ubuf, source_p->username, source_p->host,
605 <                   source_p->servptr->name, source_p->svid,
606 <                   source_p->info);
607 <
608 <    }
609 <    else
610 <    {
611 <      if (IsCapable(server, CAP_TS6) && HasID(source_p))
612 <        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
613 <                   source_p->servptr->id,
614 <                   source_p->name, source_p->hopcount+1,
615 <                   (unsigned long)source_p->tsinfo,
616 <                   ubuf, source_p->username, source_p->host,
617 <                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
618 <                   "0" : source_p->sockhost, source_p->id, source_p->info);
619 <      else
620 <        sendto_one(server, "NICK %s %d %lu %s %s %s %s :%s",
621 <                   source_p->name, source_p->hopcount+1,
622 <                   (unsigned long)source_p->tsinfo,
623 <                   ubuf, source_p->username, source_p->host,
624 <                   source_p->servptr->name, source_p->info);
625 <    }
626 <
627 <    if (!EmptyString(source_p->certfp))
628 <      sendto_one(server, ":%s CERTFP %s", ID(source_p), source_p->certfp);
629 <  }
530 >  introduce_client(client_p);
531   }
532  
533   /* valid_hostname()
# Line 643 | Line 544 | valid_hostname(const char *hostname)
544   {
545    const char *p = hostname;
546  
547 <  assert(p != NULL);
547 >  assert(p);
548  
549    if (EmptyString(p) || *p == '.' || *p == ':')
550      return 0;
# Line 669 | Line 570 | valid_hostname(const char *hostname)
570   int
571   valid_username(const char *username, const int local)
572   {
672  int dots      = 0;
573    const char *p = username;
574  
575 <  assert(p != NULL);
575 >  assert(p);
576  
577    if (*p == '~')
578      ++p;
# Line 687 | Line 587 | valid_username(const char *username, con
587  
588    if (local)
589    {
590 +    unsigned int dots = 0;
591 +
592      while (*++p)
593      {
594 <      if ((*p == '.') && ConfigFileEntry.dots_in_ident)
594 >      if (*p == '.' && ConfigGeneral.dots_in_ident)
595        {
596 <        if (++dots > ConfigFileEntry.dots_in_ident)
596 >        if (++dots > ConfigGeneral.dots_in_ident)
597            return 0;
598          if (!IsUserChar(*(p + 1)))
599            return 0;
# Line 707 | Line 609 | valid_username(const char *username, con
609          return 0;
610    }
611  
612 <  return  p - username <= USERLEN;;
612 >  return p - username <= USERLEN;
613   }
614  
615   /* clean_nick_name()
# Line 721 | Line 623 | int
623   valid_nickname(const char *nickname, const int local)
624   {
625    const char *p = nickname;
724  assert(nickname && *nickname);
626  
627 <  /* nicks can't start with a digit or - or be 0 length */
628 <  /* This closer duplicates behaviour of hybrid-6 */
629 <  if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
627 >  assert(p);
628 >
629 >  /*
630 >   * Nicks can't start with a digit or - or be 0 length.
631 >   */
632 >  if (EmptyString(p) || *p == '-' || (IsDigit(*p) && local))
633      return 0;
634  
635    for (; *p; ++p)
# Line 735 | Line 639 | valid_nickname(const char *nickname, con
639    return p - nickname <= NICKLEN;
640   }
641  
642 < /* report_and_set_user_flags()
643 < *
644 < * inputs       - pointer to source_p
645 < *              - pointer to conf for this user
646 < * output       - NONE
743 < * side effects - Report to user any special flags
744 < *                they are getting, and set them.
745 < */
746 < static void
747 < report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
748 < {
749 <  /* If this user is being spoofed, tell them so */
750 <  if (IsConfDoSpoofIp(conf))
751 <    sendto_one(source_p,
752 <               ":%s NOTICE %s :*** Spoofing your IP. Congrats.",
753 <               me.name, source_p->name);
754 <
755 <  /* If this user is in the exception class, Set it "E lined" */
756 <  if (IsConfExemptKline(conf))
757 <  {
758 <    SetExemptKline(source_p);
759 <    sendto_one(source_p,
760 <               ":%s NOTICE %s :*** You are exempt from K/D/G lines. Congrats.",
761 <               me.name, source_p->name);
762 <  }
763 <
764 <  /*
765 <   * The else here is to make sure that G line exempt users
766 <   * do not get noticed twice.
767 <   */
768 <  else if (IsConfExemptGline(conf))
769 <  {
770 <    SetExemptGline(source_p);
771 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from G lines. Congrats.",
772 <               me.name, source_p->name);
773 <  }
774 <
775 <  if (IsConfExemptResv(conf))
776 <  {
777 <    SetExemptResv(source_p);
778 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from resvs. Congrats.",
779 <               me.name, source_p->name);
780 <  }
781 <
782 <  /* If this user is exempt from user limits set it "F lined" */
783 <  if (IsConfExemptLimits(conf))
784 <  {
785 <    SetExemptLimits(source_p);
786 <    sendto_one(source_p,
787 <               ":%s NOTICE %s :*** You are exempt from user limits. Congrats.",
788 <               me.name,source_p->name);
789 <  }
790 <
791 <  if (IsConfCanFlood(conf))
792 <  {
793 <    SetCanFlood(source_p);
794 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from flood "
795 <               "protection, aren't you fearsome.",
796 <               me.name, source_p->name);
797 <  }
798 < }
799 <
800 < /* set_user_mode()
801 < *
802 < * added 15/10/91 By Darren Reed.
803 < * parv[0] - sender
804 < * parv[1] - username to change mode for
805 < * parv[2] - modes to change
806 < */
807 < void
808 < set_user_mode(struct Client *client_p, struct Client *source_p,
809 <              const int parc, char *parv[])
810 < {
811 <  unsigned int flag, setflags;
812 <  char **p, *m, buf[IRCD_BUFSIZE];
813 <  struct Client *target_p;
814 <  int what = MODE_ADD, badflag = 0, i;
815 <
816 <  assert(!(parc < 2));
817 <
818 <  if ((target_p = find_person(client_p, parv[1])) == NULL)
819 <  {
820 <    if (MyConnect(source_p))
821 <      sendto_one(source_p, form_str(ERR_NOSUCHCHANNEL),
822 <                 me.name, source_p->name, parv[1]);
823 <    return;
824 <  }
825 <
826 <  if (source_p != target_p)
827 <  {
828 <     sendto_one(source_p, form_str(ERR_USERSDONTMATCH),
829 <                me.name, source_p->name);
830 <     return;
831 <  }
832 <
833 <  if (parc < 3)
834 <  {
835 <    m = buf;
836 <    *m++ = '+';
837 <
838 <    for (i = 0; i < 128; ++i)
839 <      if (HasUMode(source_p, user_modes[i]))
840 <        *m++ = (char)i;
841 <    *m = '\0';
842 <
843 <    sendto_one(source_p, form_str(RPL_UMODEIS),
844 <               me.name, source_p->name, buf);
845 <    return;
846 <  }
847 <
848 <  /* find flags already set for user */
849 <  setflags = source_p->umodes;
850 <
851 <  /* parse mode change string(s) */
852 <  for (p = &parv[2]; p && *p; ++p)
853 <  {
854 <    for (m = *p; *m; ++m)
855 <    {
856 <      switch (*m)
857 <      {
858 <        case '+':
859 <          what = MODE_ADD;
860 <          break;
861 <        case '-':
862 <          what = MODE_DEL;
863 <          break;
864 <        case 'o':
865 <          if (what == MODE_ADD)
866 <          {
867 <            if (IsServer(client_p) && !HasUMode(source_p, UMODE_OPER))
868 <            {
869 <              ++Count.oper;
870 <              SetOper(source_p);
871 <            }
872 <          }
873 <          else
874 <          {
875 <            if (!HasUMode(source_p, UMODE_OPER))
876 <              break;
877 <
878 <            ClearOper(source_p);
879 <            Count.oper--;
880 <
881 <            if (MyConnect(source_p))
882 <            {
883 <              dlink_node *dm = NULL;
884 <
885 <              detach_conf(source_p, CONF_OPER);
886 <              ClrOFlag(source_p);
887 <              DelUMode(source_p, ConfigFileEntry.oper_only_umodes);
888 <
889 <              if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
890 <                free_dlink_node(dm);
891 <            }
892 <          }
893 <
894 <          break;
895 <
896 <        case 'S':  /* Only servers may set +S in a burst */
897 <        case 'W':  /* Only servers may set +W in a burst */
898 <        case 'r':  /* Only services may set +r */
899 <        case 'x':  /* Only services may set +x */
900 <          break;
901 <
902 <        default:
903 <          if ((flag = user_modes[(unsigned char)*m]))
904 <          {
905 <            if (MyConnect(source_p) && !HasUMode(source_p, UMODE_OPER) &&
906 <                (ConfigFileEntry.oper_only_umodes & flag))
907 <              badflag = 1;
908 <            else
909 <            {
910 <              if (what == MODE_ADD)
911 <                AddUMode(source_p, flag);
912 <              else
913 <                DelUMode(source_p, flag);
914 <            }
915 <          }
916 <          else if (MyConnect(source_p))
917 <            badflag = 1;
918 <
919 <          break;
920 <      }
921 <    }
922 <  }
923 <
924 <  if (badflag)
925 <    sendto_one(source_p, form_str(ERR_UMODEUNKNOWNFLAG),
926 <               me.name, source_p->name);
927 <
928 <  if (MyConnect(source_p) && HasUMode(source_p, UMODE_ADMIN) &&
929 <      !HasOFlag(source_p, OPER_FLAG_ADMIN))
930 <  {
931 <    sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
932 <               me.name, source_p->name);
933 <    DelUMode(source_p, UMODE_ADMIN);
934 <  }
935 <
936 <  if (!(setflags & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
937 <    ++Count.invisi;
938 <  if ((setflags & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
939 <    --Count.invisi;
940 <
941 <  /*
942 <   * compare new flags with old flags and send string which
943 <   * will cause servers to update correctly.
944 <   */
945 <  send_umode_out(client_p, source_p, setflags);
946 < }
947 <
948 < /* send_umode()
949 < * send the MODE string for user (user) to connection client_p
950 < * -avalon
951 < *
952 < * inputs       - client_p
953 < *              - source_p
954 < *              - int old
955 < *              - sendmask mask of modes to send
956 < *              - suplied umode_buf
957 < * output       - NONE
642 > /*! \brief Builds a mode change string to buffer pointed by \a buf
643 > * \param client_p  Pointer to client
644 > * \param dispatch  Whether to send a MODE message to client_p
645 > * \param old       Old user mode to compare against when building new mode buffer
646 > * \param buf       Pointer to buffer to build string in
647   */
648   void
649 < send_umode(struct Client *client_p, struct Client *source_p,
650 <           unsigned int old, unsigned int sendmask, char *umode_buf)
649 > send_umode(struct Client *client_p, unsigned int dispatch,
650 >           unsigned int old, char *buf)
651   {
652 <  char *m = umode_buf;
652 >  char *m = buf;
653    int what = 0;
965  unsigned int i;
966  unsigned int flag;
654  
655    /*
656 <   * build a string in umode_buf to represent the change in the user's
657 <   * mode between the new (source_p->umodes) and 'old'.
656 >   * Build a string in umode_buf to represent the change in the user's
657 >   * mode between the new (client_p->umodes) and 'old'.
658     */
659 <  for (i = 0; i < 128; ++i)
659 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
660    {
661 <    flag = user_modes[i];
975 <    if (!flag)
976 <      continue;
977 <
978 <    if (MyClient(source_p) && !(flag & sendmask))
979 <      continue;
980 <
981 <    if ((flag & old) && !HasUMode(source_p, flag))
661 >    if ((tab->flag & old) && !HasUMode(client_p, tab->flag))
662      {
663        if (what == MODE_DEL)
664 <        *m++ = (char)i;
664 >        *m++ = tab->c;
665        else
666        {
667          what = MODE_DEL;
668          *m++ = '-';
669 <        *m++ = (char)i;
669 >        *m++ = tab->c;
670        }
671      }
672 <    else if (!(flag & old) && HasUMode(source_p, flag))
672 >    else if (!(tab->flag & old) && HasUMode(client_p, tab->flag))
673      {
674        if (what == MODE_ADD)
675 <        *m++ = (char)i;
675 >        *m++ = tab->c;
676        else
677        {
678          what = MODE_ADD;
679          *m++ = '+';
680 <        *m++ = (char)i;
680 >        *m++ = tab->c;
681        }
682      }
683    }
684  
685    *m = '\0';
686  
687 <  if (*umode_buf && client_p)
687 >  if (dispatch && *buf)
688      sendto_one(client_p, ":%s!%s@%s MODE %s :%s",
689 <               source_p->name, source_p->username,
690 <               source_p->host, source_p->name, umode_buf);
689 >               client_p->name, client_p->username,
690 >               client_p->host, client_p->name, buf);
691   }
692  
693   /* send_umode_out()
# Line 1017 | Line 697 | send_umode(struct Client *client_p, stru
697   * side effects - Only send ubuf out to servers that know about this client
698   */
699   void
700 < send_umode_out(struct Client *client_p, struct Client *source_p,
1021 <               unsigned int old)
700 > send_umode_out(struct Client *client_p, unsigned int old)
701   {
702 <  char buf[IRCD_BUFSIZE] = { '\0' };
1024 <  dlink_node *ptr = NULL;
702 >  char buf[IRCD_BUFSIZE] = "";
703  
704 <  send_umode(NULL, source_p, old, SEND_UMODES, buf);
704 >  send_umode(client_p, MyConnect(client_p), old, buf);
705  
706    if (buf[0])
707 <  {
708 <    DLINK_FOREACH(ptr, serv_list.head)
1031 <    {
1032 <      struct Client *target_p = ptr->data;
1033 <
1034 <      if ((target_p != client_p) && (target_p != source_p))
1035 <        sendto_one(target_p, ":%s MODE %s :%s",
1036 <                   ID_or_name(source_p, target_p),
1037 <                   ID_or_name(source_p, target_p), buf);
1038 <    }
1039 <  }
1040 <
1041 <  if (client_p && MyClient(client_p))
1042 <    send_umode(client_p, source_p, old, 0xffffffff, buf);
707 >    sendto_server(client_p, 0, 0, ":%s MODE %s :%s",
708 >                  client_p->id, client_p->id, buf);
709   }
710  
711   void
712 < user_set_hostmask(struct Client *target_p, const char *hostname, const int what)
712 > user_set_hostmask(struct Client *client_p, const char *hostname, const int what)
713   {
714 <  dlink_node *ptr = NULL;
714 >  dlink_node *node = NULL;
715  
716 <  if (!strcmp(target_p->host, hostname))
716 >  if (!strcmp(client_p->host, hostname))
717      return;
718  
719    switch (what)
720    {
721      case MODE_ADD:
722 <      AddUMode(target_p, UMODE_HIDDENHOST);
1057 <      AddFlag(target_p, FLAGS_IP_SPOOFING);
722 >      AddUMode(client_p, UMODE_HIDDENHOST);
723        break;
724      case MODE_DEL:
725 <      DelUMode(target_p, UMODE_HIDDENHOST);
1061 <
1062 <      if (!HasFlag(target_p, FLAGS_AUTH_SPOOF))
1063 <        DelFlag(target_p, FLAGS_IP_SPOOFING);
725 >      DelUMode(client_p, UMODE_HIDDENHOST);
726        break;
727      default: return;
728    }
729  
730 <  if (ConfigFileEntry.cycle_on_host_change)
731 <    sendto_common_channels_local(target_p, 0, 0, ":%s!%s@%s QUIT :Changing hostname",
732 <                                 target_p->name, target_p->username, target_p->host);
1071 <
1072 <  if (IsUserHostIp(target_p))
1073 <    delete_user_host(target_p->username, target_p->host, !MyConnect(target_p));
730 >  if (ConfigGeneral.cycle_on_host_change)
731 >    sendto_common_channels_local(client_p, 0, 0, CAP_CHGHOST, ":%s!%s@%s QUIT :Changing hostname",
732 >                                 client_p->name, client_p->username, client_p->host);
733  
734 <  strlcpy(target_p->host, hostname, sizeof(target_p->host));
734 >  sendto_common_channels_local(client_p, 0, CAP_CHGHOST, 0, ":%s!%s@%s CHGHOST %s %s",
735 >                               client_p->name, client_p->username,
736 >                               client_p->host, client_p->username, hostname);
737  
738 <  add_user_host(target_p->username, target_p->host, !MyConnect(target_p));
1078 <  SetUserHost(target_p);
738 >  strlcpy(client_p->host, hostname, sizeof(client_p->host));
739  
740 <  if (MyClient(target_p))
740 >  if (MyConnect(client_p))
741    {
742 <    sendto_one(target_p, form_str(RPL_NEWHOSTIS), me.name,
743 <               target_p->name, target_p->host);
1084 <    clear_ban_cache_client(target_p);
742 >    sendto_one_numeric(client_p, &me, RPL_VISIBLEHOST, client_p->host);
743 >    clear_ban_cache_list(&client_p->channel);
744    }
745  
746 <  if (!ConfigFileEntry.cycle_on_host_change)
746 >  if (!ConfigGeneral.cycle_on_host_change)
747      return;
748  
749 <  DLINK_FOREACH(ptr, target_p->channel.head)
749 >  DLINK_FOREACH(node, client_p->channel.head)
750    {
751 <    char modebuf[4], nickbuf[NICKLEN * 3 + 3] = { '\0' };
751 >    char modebuf[CMEMBER_STATUS_FLAGS_LEN + 1];
752 >    char nickbuf[CMEMBER_STATUS_FLAGS_LEN * NICKLEN + CMEMBER_STATUS_FLAGS_LEN] = "";
753      char *p = modebuf;
754      int len = 0;
755 <    const struct Membership *ms = ptr->data;
755 >    const struct Membership *member = node->data;
756  
757 <    if (has_member_flags(ms, CHFL_CHANOP))
757 >    if (has_member_flags(member, CHFL_CHANOP))
758      {
759        *p++ = 'o';
760 <      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
760 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", client_p->name);
761      }
762  
763 <    if (has_member_flags(ms, CHFL_HALFOP))
763 >    if (has_member_flags(member, CHFL_HALFOP))
764      {
765        *p++ = 'h';
766 <      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
766 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", client_p->name);
767      }
768  
769 <    if (has_member_flags(ms, CHFL_VOICE))
769 >    if (has_member_flags(member, CHFL_VOICE))
770      {
771        *p++ = 'v';
772 <      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
772 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", client_p->name);
773      }
774  
775      *p = '\0';
776  
777 <    sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s!%s@%s JOIN :%s",
778 <                                target_p->name, target_p->username, target_p->host,
779 <                                ms->chptr->chname);
780 <    if (nickbuf[0])
781 <      sendto_channel_local_butone(target_p, 0, 0, ms->chptr, ":%s MODE %s +%s %s",
782 <                                  target_p->servptr->name, ms->chptr->chname,
783 <                                  modebuf, nickbuf);
777 >    sendto_channel_local(client_p, member->chptr, 0, CAP_EXTENDED_JOIN, CAP_CHGHOST, ":%s!%s@%s JOIN %s %s :%s",
778 >                         client_p->name, client_p->username,
779 >                         client_p->host, member->chptr->name,
780 >                         client_p->account, client_p->info);
781 >    sendto_channel_local(client_p, member->chptr, 0, 0, CAP_EXTENDED_JOIN | CAP_CHGHOST, ":%s!%s@%s JOIN :%s",
782 >                         client_p->name, client_p->username,
783 >                         client_p->host, member->chptr->name);
784  
785 +    if (nickbuf[0])
786 +      sendto_channel_local(client_p, member->chptr, 0, 0, CAP_CHGHOST, ":%s MODE %s +%s %s",
787 +                           client_p->servptr->name, member->chptr->name,
788 +                           modebuf, nickbuf);
789    }
790  
791 <  if (target_p->away[0])
792 <    sendto_common_channels_local(target_p, 0, CAP_AWAY_NOTIFY,
791 >  if (client_p->away[0])
792 >    sendto_common_channels_local(client_p, 0, CAP_AWAY_NOTIFY, CAP_CHGHOST,
793                                   ":%s!%s@%s AWAY :%s",
794 <                                 target_p->name, target_p->username,
795 <                                 target_p->host, target_p->away);
1132 < }
1133 <
1134 < /* user_welcome()
1135 < *
1136 < * inputs       - client pointer to client to welcome
1137 < * output       - NONE
1138 < * side effects -
1139 < */
1140 < static void
1141 < user_welcome(struct Client *source_p)
1142 < {
1143 < #if defined(__TIME__) && defined(__DATE__)
1144 <  static const char built_date[] = __DATE__ " at " __TIME__;
1145 < #else
1146 <  static const char built_date[] = "unknown";
1147 < #endif
1148 <
1149 < #ifdef HAVE_LIBCRYPTO
1150 <  if (HasFlag(source_p, FLAGS_SSL))
1151 <  {
1152 <    AddUMode(source_p, UMODE_SSL);
1153 <    sendto_one(source_p, ":%s NOTICE %s :*** Connected securely via %s",
1154 <               me.name, source_p->name,
1155 <               ssl_get_cipher(source_p->localClient->fd.ssl));
1156 <  }
1157 < #endif
1158 <
1159 <  sendto_one(source_p, form_str(RPL_WELCOME), me.name, source_p->name,
1160 <             ServerInfo.network_name, source_p->name);
1161 <  sendto_one(source_p, form_str(RPL_YOURHOST), me.name, source_p->name,
1162 <             get_listener_name(source_p->localClient->listener), ircd_version);
1163 <  sendto_one(source_p, form_str(RPL_CREATED),
1164 <             me.name, source_p->name, built_date);
1165 <  sendto_one(source_p, form_str(RPL_MYINFO),
1166 <             me.name, source_p->name, me.name, ircd_version, umode_buffer);
1167 <  show_isupport(source_p);
1168 <
1169 <  if (source_p->id[0] != '\0')
1170 <    sendto_one(source_p, form_str(RPL_YOURID), me.name,
1171 <               source_p->name, source_p->id);
1172 <
1173 <  show_lusers(source_p);
1174 <  motd_signon(source_p);
1175 < }
1176 <
1177 < /* check_xline()
1178 < *
1179 < * inputs       - pointer to client to test
1180 < * outupt       - 1 if exiting 0 if ok
1181 < * side effects -
1182 < */
1183 < static int
1184 < check_xline(struct Client *source_p)
1185 < {
1186 <  struct MaskItem *conf = NULL;
1187 <  const char *reason = NULL;
1188 <
1189 <  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
1190 <  {
1191 <    ++conf->count;
1192 <
1193 <    if (conf->reason != NULL)
1194 <      reason = conf->reason;
1195 <    else
1196 <      reason = "No Reason";
1197 <
1198 <    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
1199 <                         "X-line Rejecting [%s] [%s], user %s [%s]",
1200 <                         source_p->info, reason,
1201 <                         get_client_name(source_p, HIDE_IP),
1202 <                         source_p->sockhost);
1203 <
1204 <    ++ServerStats.is_ref;
1205 <    exit_client(source_p, &me, "Bad user info");
1206 <    return 1;
1207 <  }
1208 <
1209 <  return 0;
1210 < }
1211 <
1212 < /* oper_up()
1213 < *
1214 < * inputs       - pointer to given client to oper
1215 < * output       - NONE
1216 < * side effects - Blindly opers up given source_p, using conf info
1217 < *                all checks on passwords have already been done.
1218 < *                This could also be used by rsa oper routines.
1219 < */
1220 < void
1221 < oper_up(struct Client *source_p)
1222 < {
1223 <  const unsigned int old = source_p->umodes;
1224 <  const struct MaskItem *conf = source_p->localClient->confs.head->data;
1225 <
1226 <  assert(source_p->localClient->confs.head);
1227 <
1228 <  ++Count.oper;
1229 <  SetOper(source_p);
1230 <
1231 <  if (conf->modes)
1232 <    AddUMode(source_p, conf->modes);
1233 <  else if (ConfigFileEntry.oper_umodes)
1234 <    AddUMode(source_p, ConfigFileEntry.oper_umodes);
1235 <
1236 <  if (!(old & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
1237 <    ++Count.invisi;
1238 <  if ((old & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
1239 <    --Count.invisi;
1240 <
1241 <  assert(dlinkFind(&oper_list, source_p) == NULL);
1242 <  dlinkAdd(source_p, make_dlink_node(), &oper_list);
1243 <
1244 <  AddOFlag(source_p, conf->port);
1245 <
1246 <  if (HasOFlag(source_p, OPER_FLAG_ADMIN))
1247 <    AddUMode(source_p, UMODE_ADMIN);
1248 <
1249 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
1250 <                       get_oper_name(source_p));
1251 <  send_umode_out(source_p, source_p, old);
1252 <  sendto_one(source_p, form_str(RPL_YOUREOPER), me.name, source_p->name);
1253 < }
1254 <
1255 < static char new_uid[TOTALSIDUID + 1];     /* allow for \0 */
1256 <
1257 < int
1258 < valid_sid(const char *sid)
1259 < {
1260 <  if (strlen(sid) == IRC_MAXSID)
1261 <    if (IsDigit(*sid))
1262 <      if (IsAlNum(*(sid + 1)) && IsAlNum(*(sid + 2)))
1263 <        return 1;
1264 <
1265 <  return 0;
1266 < }
1267 <
1268 < /*
1269 < * init_uid()
1270 < *
1271 < * inputs       - NONE
1272 < * output       - NONE
1273 < * side effects - new_uid is filled in with server id portion (sid)
1274 < *                (first 3 bytes) or defaulted to 'A'.
1275 < *                Rest is filled in with 'A'
1276 < */
1277 < void
1278 < init_uid(void)
1279 < {
1280 <  unsigned int i;
1281 <
1282 <  memset(new_uid, 0, sizeof(new_uid));
1283 <
1284 <  if (!EmptyString(ServerInfo.sid))
1285 <    strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1286 <
1287 <  for (i = 0; i < IRC_MAXSID; ++i)
1288 <    if (new_uid[i] == '\0')
1289 <      new_uid[i] = 'A';
1290 <
1291 <  /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1292 <  memcpy(new_uid + IRC_MAXSID, "AAAAA@", IRC_MAXUID);
1293 < }
1294 <
1295 < /*
1296 < * add_one_to_uid
1297 < *
1298 < * inputs       - index number into new_uid
1299 < * output       - NONE
1300 < * side effects - new_uid is incremented by one
1301 < *                note this is a recursive function
1302 < */
1303 < static void
1304 < add_one_to_uid(int i)
1305 < {
1306 <  if (i != IRC_MAXSID)    /* Not reached server SID portion yet? */
1307 <  {
1308 <    if (new_uid[i] == 'Z')
1309 <      new_uid[i] = '0';
1310 <    else if (new_uid[i] == '9')
1311 <    {
1312 <      new_uid[i] = 'A';
1313 <      add_one_to_uid(i-1);
1314 <    }
1315 <    else
1316 <      ++new_uid[i];
1317 <  }
1318 <  else
1319 <  {
1320 <    /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1321 <    if (new_uid[i] == 'Z')
1322 <      memcpy(new_uid + IRC_MAXSID, "AAAAAA", IRC_MAXUID);
1323 <    else
1324 <      ++new_uid[i];
1325 <  }
1326 < }
1327 <
1328 < /*
1329 < * uid_get
1330 < *
1331 < * inputs       - struct Client *
1332 < * output       - new UID is returned to caller
1333 < * side effects - new_uid is incremented by one.
1334 < */
1335 < static const char *
1336 < uid_get(void)
1337 < {
1338 <  add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1339 <  return new_uid;
1340 < }
1341 <
1342 < /*
1343 < * init_isupport()
1344 < *
1345 < * input        - NONE
1346 < * output       - NONE
1347 < * side effects - Must be called before isupport is enabled
1348 < */
1349 < void
1350 < init_isupport(void)
1351 < {
1352 <  add_isupport("CALLERID", NULL, -1);
1353 <  add_isupport("CASEMAPPING", CASEMAP, -1);
1354 <  add_isupport("DEAF", "D", -1);
1355 <  add_isupport("KICKLEN", NULL, KICKLEN);
1356 <  add_isupport("MODES", NULL, MAXMODEPARAMS);
1357 < #ifdef HALFOPS
1358 <  add_isupport("PREFIX", "(ohv)@%+", -1);
1359 <  add_isupport("STATUSMSG", "@%+", -1);
1360 < #else
1361 <  add_isupport("PREFIX", "(ov)@+", -1);
1362 <  add_isupport("STATUSMSG", "@+", -1);
1363 < #endif
1364 <  add_isupport("EXCEPTS", "e", -1);
1365 <  add_isupport("INVEX", "I", -1);
1366 < }
1367 <
1368 < /*
1369 < * add_isupport()
1370 < *
1371 < * input        - name of supported function
1372 < *              - options if any
1373 < *              - number if any
1374 < * output       - NONE
1375 < * side effects - Each supported item must call this when activated
1376 < */
1377 < void
1378 < add_isupport(const char *name, const char *options, int n)
1379 < {
1380 <  dlink_node *ptr;
1381 <  struct Isupport *support;
1382 <
1383 <  DLINK_FOREACH(ptr, support_list.head)
1384 <  {
1385 <    support = ptr->data;
1386 <    if (irccmp(support->name, name) == 0)
1387 <    {
1388 <      MyFree(support->name);
1389 <      MyFree(support->options);
1390 <      break;
1391 <    }
1392 <  }
1393 <
1394 <  if (ptr == NULL)
1395 <  {
1396 <    support = MyMalloc(sizeof(*support));
1397 <    dlinkAddTail(support, &support->node, &support_list);
1398 <  }
1399 <
1400 <  support->name = xstrdup(name);
1401 <  if (options != NULL)
1402 <    support->options = xstrdup(options);
1403 <  support->number = n;
1404 <
1405 <  rebuild_isupport_message_line();
1406 < }
1407 <
1408 < /*
1409 < * delete_isupport()
1410 < *
1411 < * input        - name of supported function
1412 < * output       - NONE
1413 < * side effects - Each supported item must call this when deactivated
1414 < */
1415 < void
1416 < delete_isupport(const char *name)
1417 < {
1418 <  dlink_node *ptr;
1419 <  struct Isupport *support;
1420 <
1421 <  DLINK_FOREACH(ptr, support_list.head)
1422 <  {
1423 <    support = ptr->data;
1424 <    if (irccmp(support->name, name) == 0)
1425 <    {
1426 <      dlinkDelete(ptr, &support_list);
1427 <      MyFree(support->name);
1428 <      MyFree(support->options);
1429 <      MyFree(support);
1430 <      break;
1431 <    }
1432 <  }
1433 <
1434 <  rebuild_isupport_message_line();
1435 < }
1436 <
1437 < /*
1438 < * rebuild_isupport_message_line
1439 < *
1440 < * input        - NONE
1441 < * output       - NONE
1442 < * side effects - Destroy the isupport MessageFile lines, and rebuild.
1443 < */
1444 < void
1445 < rebuild_isupport_message_line(void)
1446 < {
1447 <  char isupportbuffer[IRCD_BUFSIZE];
1448 <  char *p = isupportbuffer;
1449 <  dlink_node *ptr = NULL, *ptr_next = NULL;
1450 <  int n = 0;
1451 <  int tokens = 0;
1452 <  size_t len = 0;
1453 <  size_t reserve = strlen(me.name) + HOSTLEN + strlen(form_str(RPL_ISUPPORT));
1454 <
1455 <  DLINK_FOREACH_SAFE(ptr, ptr_next, support_list_lines.head)
1456 <  {
1457 <    dlinkDelete(ptr, &support_list_lines);
1458 <    MyFree(ptr->data);
1459 <    free_dlink_node(ptr);
1460 <  }
1461 <
1462 <  DLINK_FOREACH(ptr, support_list.head)
1463 <  {
1464 <    struct Isupport *support = ptr->data;
1465 <
1466 <    p += (n = sprintf(p, "%s", support->name));
1467 <    len += n;
1468 <
1469 <    if (support->options != NULL)
1470 <    {
1471 <      p += (n = sprintf(p, "=%s", support->options));
1472 <      len += n;
1473 <    }
1474 <
1475 <    if (support->number > 0)
1476 <    {
1477 <      p += (n = sprintf(p, "=%d", support->number));
1478 <      len += n;
1479 <    }
1480 <
1481 <    *p++ = ' ';
1482 <    len++;
1483 <    *p = '\0';
1484 <
1485 <    if (++tokens == (MAXPARA-2) || len >= (sizeof(isupportbuffer)-reserve))
1486 <    { /* arbritrary for now */
1487 <      if (*--p == ' ')
1488 <        *p = '\0';
1489 <
1490 <      dlinkAddTail(xstrdup(isupportbuffer), make_dlink_node(), &support_list_lines);
1491 <      p = isupportbuffer;
1492 <      len = 0;
1493 <      n = tokens = 0;
1494 <    }
1495 <  }
1496 <
1497 <  if (len != 0)
1498 <  {
1499 <    if (*--p == ' ')
1500 <      *p = '\0';
1501 <    dlinkAddTail(xstrdup(isupportbuffer), make_dlink_node(), &support_list_lines);
1502 <  }
794 >                                 client_p->name, client_p->username,
795 >                                 client_p->host, client_p->away);
796   }

Comparing:
ircd-hybrid/trunk/src/s_user.c (property svn:keywords), Revision 2691 by michael, Tue Dec 17 18:55:59 2013 UTC vs.
ircd-hybrid/trunk/src/user.c (property svn:keywords), Revision 7771 by michael, Sat Oct 8 16:30:33 2016 UTC

# Line 1 | Line 1
1 < Id Revision
1 > Id

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)