ViewVC Help

View File | Revision Log | Show Annotations | View Changeset | Root Listing

root/svn/ircd-hybrid/trunk/src/user.c

Comparing:
ircd-hybrid-7.2/src/s_user.c (file contents), Revision 982 by michael, Thu Aug 13 22:15:08 2009 UTC vs.
ircd-hybrid/trunk/src/s_user.c (file contents), Revision 1976 by michael, Wed May 8 19:33:06 2013 UTC

#	Line 23 | Line 23
23		*/
24
25		#include "stdinc.h"
26	<	#include "tools.h"
26	>	#include "list.h"
27		#include "s_user.h"
28		#include "s_misc.h"
29		#include "channel.h"
30		#include "channel_mode.h"
31		#include "client.h"
32	–	#include "common.h"
32		#include "fdlist.h"
33		#include "hash.h"
34		#include "irc_string.h"
36	–	#include "sprintf_irc.h"
35		#include "s_bsd.h"
36		#include "ircd.h"
39	–	#include "list.h"
37		#include "listener.h"
38		#include "motd.h"
39		#include "numeric.h"
40	<	#include "s_conf.h"
41	<	#include "s_log.h"
40	>	#include "conf.h"
41	>	#include "log.h"
42		#include "s_serv.h"
43		#include "send.h"
44		#include "supported.h"
#	Line 52 | Line 49
49		#include "userhost.h"
50		#include "hook.h"
51		#include "s_misc.h"
52	<	#include "msg.h"
56	<	#include "pcre.h"
52	>	#include "parse.h"
53		#include "watch.h"
54
55	<	int MaxClientCount     = 1;
60	<	int MaxConnectionCount = 1;
55	>
56		struct Callback *entering_umode_cb = NULL;
57		struct Callback *umode_cb = NULL;
63	–	struct Callback *uid_get_cb = NULL;
58
59		static char umode_buffer[IRCD_BUFSIZE];
60
61		static void user_welcome(struct Client *);
62	<	static void report_and_set_user_flags(struct Client *, const struct AccessItem *);
62	>	static void report_and_set_user_flags(struct Client *, const struct MaskItem *);
63		static int check_xline(struct Client *);
64	<	static void introduce_client(struct Client *, struct Client *);
65	<	static void *uid_get(va_list);
64	>	static void introduce_client(struct Client *);
65	>	static const char *uid_get(void);
66
67		/* Used for building up the isupport string,
68		* used with init_isupport, add_isupport, delete_isupport
#	Line 98 | Line 92 | unsigned int user_modes[256] =
92		UMODE_CCONN_FULL,   /* C */
93		UMODE_DEAF,         /* D */
94		0,                  /* E */
95	<	0,                  /* F */
95	>	UMODE_FARCONNECT,   /* F */
96		UMODE_SOFTCALLERID, /* G */
97	<	0,                  /* H */
97	>	UMODE_HIDDEN,       /* H */
98		0,                  /* I */
99		0,                  /* J */
100		0,                  /* K */
#	Line 110 | Line 104 | unsigned int user_modes[256] =
104		0,                  /* O */
105		0,                  /* P */
106		0,                  /* Q */
107	<	0,                  /* R */
107	>	UMODE_REGONLY,      /* R */
108		0,                  /* S */
109		0,                  /* T */
110		0,                  /* U */
#	Line 125 | Line 119 | unsigned int user_modes[256] =
119		UMODE_BOTS,         /* b */
120		UMODE_CCONN,        /* c */
121		UMODE_DEBUG,        /* d */
122	<	0,                  /* e */
122	>	UMODE_EXTERNAL,     /* e */
123		UMODE_FULL,         /* f */
124		UMODE_CALLERID,     /* g */
125		0,                  /* h */
126		UMODE_INVISIBLE,    /* i */
127	<	0,                  /* j */
127	>	UMODE_REJ,          /* j */
128		UMODE_SKILL,        /* k */
129		UMODE_LOCOPS,       /* l */
130		0,                  /* m */
#	Line 138 | Line 132 | unsigned int user_modes[256] =
132		UMODE_OPER,         /* o */
133		0,                  /* p */
134		0,                  /* q */
135	<	UMODE_REJ,          /* r */
135	>	UMODE_REGISTERED,   /* r */
136		UMODE_SERVNOTICE,   /* s */
137		0,                  /* t */
138		UMODE_UNAUTH,       /* u */
139		0,                  /* v */
140		UMODE_WALLOP,       /* w */
141	<	UMODE_EXTERNAL,     /* x */
141	>	0,                  /* x */
142		UMODE_SPY,          /* y */
143		UMODE_OPERWALL,     /* z      0x7A */
144		0,0,0,0,0,          /* 0x7B - 0x7F */
#	Line 165 | Line 159 | assemble_umode_buffer(void)
159		unsigned int idx = 0;
160		char *umode_buffer_ptr = umode_buffer;
161
162	<	for (; idx < (sizeof(user_modes) / sizeof(int)); ++idx)
162	>	for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
163		if (user_modes[idx])
164		*umode_buffer_ptr++ = idx;
165
#	Line 194 | Line 188 | show_lusers(struct Client *source_p)
188		to = source_p->name;
189		}
190
191	<	if (!ConfigServerHide.hide_servers || IsOper(source_p))
191	>	if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
192		sendto_one(source_p, form_str(RPL_LUSERCLIENT),
193		from, to, (Count.total-Count.invisi),
194		Count.invisi, dlink_list_length(&global_serv_list));
#	Line 214 | Line 208 | show_lusers(struct Client *source_p)
208		sendto_one(source_p, form_str(RPL_LUSERCHANNELS),
209		from, to, dlink_list_length(&global_channel_list));
210
211	<	if (!ConfigServerHide.hide_servers || IsOper(source_p))
211	>	if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
212		{
213		sendto_one(source_p, form_str(RPL_LUSERME),
214		from, to, Count.local, Count.myserver);
215		sendto_one(source_p, form_str(RPL_LOCALUSERS),
216	<	from, to, Count.local, Count.max_loc,
223	<	Count.local, Count.max_loc);
216	>	from, to, Count.local, Count.max_loc);
217		}
218		else
219		{
220		sendto_one(source_p, form_str(RPL_LUSERME),
221		from, to, Count.total, 0);
222		sendto_one(source_p, form_str(RPL_LOCALUSERS),
223	<	from, to, Count.total, Count.max_tot,
231	<	Count.total, Count.max_tot);
223	>	from, to, Count.total, Count.max_tot);
224		}
225
226		sendto_one(source_p, form_str(RPL_GLOBALUSERS),
227	<	from, to, Count.total, Count.max_tot,
236	<	Count.total, Count.max_tot);
227	>	from, to, Count.total, Count.max_tot);
228
229	<	if (!ConfigServerHide.hide_servers || IsOper(source_p))
229	>	if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
230		sendto_one(source_p, form_str(RPL_STATSCONN), from, to,
231	<	MaxConnectionCount, MaxClientCount, Count.totalrestartcount);
231	>	Count.max_loc_con, Count.max_loc_cli, Count.totalrestartcount);
232
233	<	if (Count.local > MaxClientCount)
234	<	MaxClientCount = Count.local;
233	>	if (Count.local > Count.max_loc_cli)
234	>	Count.max_loc_cli = Count.local;
235
236	<	if ((Count.local + Count.myserver) > MaxConnectionCount)
237	<	MaxConnectionCount = Count.local + Count.myserver;
236	>	if ((Count.local + Count.myserver) > Count.max_loc_con)
237	>	Count.max_loc_con = Count.local + Count.myserver;
238		}
239
240		/* show_isupport()
#	Line 282 | Line 273 | show_isupport(struct Client *source_p)
273		**         nick from local user or kill him/her...
274		*/
275		void
276	<	register_local_user(struct Client *client_p, struct Client *source_p,
286	<	const char *nick, const char *username)
276	>	register_local_user(struct Client *source_p)
277		{
278	<	const struct AccessItem *aconf = NULL;
279	<	dlink_node *ptr = NULL;
290	<	dlink_node *m = NULL;
278	>	const char *id = NULL;
279	>	const struct MaskItem *conf = NULL;
280
281		assert(source_p != NULL);
282	+	assert(source_p == source_p->from);
283		assert(MyConnect(source_p));
294	–	assert(source_p->username != username);
284		assert(!source_p->localClient->registration);
285
286	<	ClearCap(client_p, CAP_TS6);
286	>	ClearCap(source_p, CAP_TS6);
287
288		if (ConfigFileEntry.ping_cookie)
289		{
290	<	if (!IsPingSent(source_p) &&
302	<	source_p->localClient->random_ping == 0)
290	>	if (!IsPingSent(source_p) && source_p->localClient->random_ping == 0)
291		{
292	<	source_p->localClient->random_ping = genrand_int32();
292	>	do
293	>	source_p->localClient->random_ping = genrand_int32();
294	>	while (!source_p->localClient->random_ping);
295	>
296		sendto_one(source_p, "PING :%u",
297		source_p->localClient->random_ping);
298		SetPingSent(source_p);
#	Line 312 | Line 303 | register_local_user(struct Client *clien
303		return;
304		}
305
306	<	source_p->localClient->last = CurrentTime;
306	>	source_p->localClient->last_privmsg = CurrentTime;
307		/* Straight up the maximum rate of flooding... */
308		source_p->localClient->allow_read = MAX_FLOOD_BURST;
309
310	<	if (!execute_callback(client_check_cb, source_p, username))
310	>	if (!check_client(source_p))
311		return;
312
313		if (valid_hostname(source_p->host) == 0)
#	Line 327 | Line 318 | register_local_user(struct Client *clien
318		sizeof(source_p->host));
319		}
320
321	<	ptr   = source_p->localClient->confs.head;
331	<	aconf = map_to_conf(ptr->data);
321	>	conf = source_p->localClient->confs.head->data;
322
323		if (!IsGotId(source_p))
324		{
325	<	const char *p = NULL;
325	>	char username[USERLEN + 1];
326	>	const char *p = username;
327		unsigned int i = 0;
328
329	<	if (IsNeedIdentd(aconf))
329	>	if (IsNeedIdentd(conf))
330		{
331		++ServerStats.is_ref;
332		sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You need to install "
#	Line 344 | Line 335 | register_local_user(struct Client *clien
335		return;
336		}
337
338	<	p = username;
338	>	strlcpy(username, source_p->username, sizeof(username));
339
340	<	if (!IsNoTilde(aconf))
340	>	if (!IsNoTilde(conf))
341		source_p->username[i++] = '~';
342
343	<	while (*p && i < USERLEN)
353	<	{
343	>	for (; *p && i < USERLEN; ++p)
344		if (*p != '[')
345		source_p->username[i++] = *p;
356	–	p++;
357	–	}
346
347		source_p->username[i] = '\0';
348		}
349
350		/* password check */
351	<	if (!EmptyString(aconf->passwd))
351	>	if (!EmptyString(conf->passwd))
352		{
353		const char *pass = source_p->localClient->passwd;
354
355	<	if (!match_conf_password(pass, aconf))
355	>	if (!match_conf_password(pass, conf))
356		{
357		++ServerStats.is_ref;
358		sendto_one(source_p, form_str(ERR_PASSWDMISMATCH),
#	Line 380 | Line 368 | register_local_user(struct Client *clien
368		*/
369
370		/* report if user has &^>= etc. and set flags as needed in source_p */
371	<	report_and_set_user_flags(source_p, aconf);
371	>	report_and_set_user_flags(source_p, conf);
372
373	<	if (IsDead(client_p))
373	>	if (IsDead(source_p))
374		return;
375
376		/* Limit clients -
#	Line 396 | Line 384 | register_local_user(struct Client *clien
384		if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
385		(Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
386		{
387	<	sendto_realops_flags(UMODE_FULL, L_ALL,
387	>	sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
388		"Too many clients, rejecting %s[%s].",
389	<	nick, source_p->host);
389	>	source_p->name, source_p->host);
390		++ServerStats.is_ref;
391		exit_client(source_p, &me, "Sorry, server is full - try later");
392		return;
#	Line 409 | Line 397 | register_local_user(struct Client *clien
397		{
398		char tmpstr2[IRCD_BUFSIZE];
399
400	<	sendto_realops_flags(UMODE_REJ, L_ALL, "Invalid username: %s (%s@%s)",
401	<	nick, source_p->username, source_p->host);
400	>	sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
401	>	"Invalid username: %s (%s@%s)",
402	>	source_p->name, source_p->username, source_p->host);
403		++ServerStats.is_ref;
404	<	ircsprintf(tmpstr2, "Invalid username [%s]", source_p->username);
404	>	snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
405	>	source_p->username);
406		exit_client(source_p, &me, tmpstr2);
407		return;
408		}
409
420	–	assert(source_p == client_p);
421	–
410		if (check_xline(source_p))
411		return;
412
413	<	if (me.id[0])
414	<	{
427	<	const char *id = execute_callback(uid_get_cb, source_p);
428	<
429	<	while (hash_find_id(id) != NULL)
430	<	id = uid_get(NULL);
413	>	while (hash_find_id((id = uid_get())) != NULL)
414	>	;
415
416	<	strlcpy(source_p->id, id, sizeof(source_p->id));
417	<	hash_add_id(source_p);
434	<	}
416	>	strlcpy(source_p->id, id, sizeof(source_p->id));
417	>	hash_add_id(source_p);
418
419	<	sendto_realops_flags(UMODE_CCONN, L_ALL,
420	<	"Client connecting: %s (%s@%s) [%s] {%s} [%s]",
421	<	nick, source_p->username, source_p->host,
419	>	sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
420	>	"Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
421	>	source_p->name, source_p->username, source_p->host,
422		ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
423		"255.255.255.255" : source_p->sockhost,
424	<	get_client_class(source_p),
425	<	source_p->info);
424	>	get_client_class(&source_p->localClient->confs),
425	>	source_p->info, source_p->id);
426
427	<	sendto_realops_flags(UMODE_CCONN_FULL, L_ALL,
427	>	sendto_realops_flags(UMODE_CCONN_FULL, L_ALL, SEND_NOTICE,
428		"CLICONN %s %s %s %s %s %s %s 0 %s",
429	<	nick, source_p->username, source_p->host,
429	>	source_p->name, source_p->username, source_p->host,
430		ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
431		"255.255.255.255" : source_p->sockhost,
432	<	get_client_class(source_p),
432	>	get_client_class(&source_p->localClient->confs),
433		ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
434	<	"<hidden>" : source_p->client_host,
434	>	"<hidden>" : source_p->localClient->client_host,
435		ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
436	<	"<hidden>" : source_p->client_server,
436	>	"<hidden>" : source_p->localClient->client_server,
437		source_p->info);
438
439
440		if (ConfigFileEntry.invisible_on_connect)
441		{
442	<	source_p->umodes |= UMODE_INVISIBLE;
442	>	AddUMode(source_p, UMODE_INVISIBLE);
443		++Count.invisi;
444		}
445
#	Line 465 | Line 448 | register_local_user(struct Client *clien
448		Count.max_loc = Count.local;
449
450		if (!(Count.max_loc % 10))
451	<	sendto_realops_flags(UMODE_ALL, L_ALL, "New Max Local Clients: %d",
451	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
452	>	"New Max Local Clients: %d",
453		Count.max_loc);
454		}
455
472	–	SetClient(source_p);
473	–
474	–	source_p->servptr = &me;
475	–	dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
476	–
456		/* Increment our total user count here */
457		if (++Count.total > Count.max_tot)
458		Count.max_tot = Count.total;
459		++Count.totalrestartcount;
460
461	+	assert(source_p->servptr == &me);
462	+	SetClient(source_p);
463	+	dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
464	+
465		source_p->localClient->allow_read = MAX_FLOOD_BURST;
466
467	<	if ((m = dlinkFindDelete(&unknown_list, source_p)) != NULL)
468	<	{
469	<	free_dlink_node(m);
470	<	dlinkAdd(source_p, &source_p->localClient->lclient_node, &local_client_list);
488	<	}
489	<	else assert(0);
467	>	assert(dlinkFind(&unknown_list, source_p));
468	>
469	>	dlink_move_node(&source_p->localClient->lclient_node,
470	>	&unknown_list, &local_client_list);
471
472		user_welcome(source_p);
473		add_user_host(source_p->username, source_p->host, 0);
474		SetUserHost(source_p);
475
476	<	introduce_client(client_p, source_p);
476	>	introduce_client(source_p);
477		}
478
479		/* register_remote_user()
480		*
481	<	* inputs       - client_p directly connected client
501	<	*              - source_p remote or directly connected client
481	>	* inputs       - source_p remote or directly connected client
482		*              - username to register as
483		*              - host name to register as
484		*              - server name
#	Line 508 | Line 488 | register_local_user(struct Client *clien
488		*                is introduced by a server.
489		*/
490		void
491	<	register_remote_user(struct Client *client_p, struct Client *source_p,
491	>	register_remote_user(struct Client *source_p,
492		const char *username, const char *host, const char *server,
493		const char *realname)
494		{
#	Line 523 | Line 503 | register_remote_user(struct Client *clie
503		/*
504		* coming from another server, take the servers word for it
505		*/
506	<	source_p->servptr = find_server(server);
506	>	source_p->servptr = hash_find_server(server);
507
508	<	/* Super GhostDetect:
508	>	/*
509	>	* Super GhostDetect:
510		* If we can't find the server the user is supposed to be on,
511		* then simply blow the user away.        -Taner
512		*/
513		if (source_p->servptr == NULL)
514		{
515	<	sendto_realops_flags(UMODE_ALL, L_ALL,
515	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
516		"No server %s for user %s[%s@%s] from %s",
517		server, source_p->name, source_p->username,
518		source_p->host, source_p->from->name);
519	<	kill_client(client_p, source_p, "%s (Server doesn't exist)", me.name);
519	>	kill_client(source_p->from, source_p, "%s (Server doesn't exist)", me.name);
520
521	<	SetKilled(source_p);
521	>	AddFlag(source_p, FLAGS_KILLED);
522		exit_client(source_p, &me, "Ghosted Client");
523		return;
524		}
525
526		if ((target_p = source_p->servptr) && target_p->from != source_p->from)
527		{
528	<	sendto_realops_flags(UMODE_DEBUG, L_ALL,
528	>	sendto_realops_flags(UMODE_DEBUG, L_ALL, SEND_NOTICE,
529		"Bad User [%s] :%s USER %s@%s %s, != %s[%s]",
530	<	client_p->name, source_p->name, source_p->username,
530	>	source_p->from->name, source_p->name, source_p->username,
531		source_p->host, source_p->servptr->name,
532		target_p->name, target_p->from->name);
533	<	kill_client(client_p, source_p,
533	>	kill_client(source_p->from, source_p,
534		"%s (NICK from wrong direction (%s != %s))",
535		me.name, source_p->servptr->name, target_p->from->name);
536	<	SetKilled(source_p);
536	>	AddFlag(source_p, FLAGS_KILLED);
537		exit_client(source_p, &me, "USER server wrong direction");
538		return;
539		}
540
541	+	/*
542	+	* If the nick has been introduced by a services server,
543	+	* make it a service as well.
544	+	*/
545	+	if (HasFlag(source_p->servptr, FLAGS_SERVICE))
546	+	AddFlag(source_p, FLAGS_SERVICE);
547	+
548		/* Increment our total user count here */
549		if (++Count.total > Count.max_tot)
550		Count.max_tot = Count.total;
#	Line 566 | Line 554 | register_remote_user(struct Client *clie
554		add_user_host(source_p->username, source_p->host, 1);
555		SetUserHost(source_p);
556
557	<	introduce_client(client_p, source_p);
557	>	if (HasFlag(source_p->servptr, FLAGS_EOB))
558	>	sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
559	>	"Client connecting at %s: %s (%s@%s) [%s] <%s>",
560	>	source_p->servptr->name,
561	>	source_p->name, source_p->username, source_p->host,
562	>	source_p->info, source_p->id);
563	>
564	>	introduce_client(source_p);
565		}
566
567		/* introduce_client()
568		*
569	<	* inputs       - client_p
575	<	*              - source_p
569	>	* inputs       - source_p
570		* output       - NONE
571		* side effects - This common function introduces a client to the rest
572		*                of the net, either from a local client connect or
573		*                from a remote connect.
574		*/
575		static void
576	<	introduce_client(struct Client *client_p, struct Client *source_p)
576	>	introduce_client(struct Client *source_p)
577		{
578		dlink_node *server_node = NULL;
579		static char ubuf[12];
#	Line 601 | Line 595 | introduce_client(struct Client *client_p
595		{
596		struct Client *server = server_node->data;
597
598	<	if (server == client_p)
598	>	if (server == source_p->from)
599		continue;
600
601	<	if (IsCapable(server, CAP_TS6) && HasID(source_p))
602	<	sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
603	<	source_p->servptr->id,
604	<	source_p->name, source_p->hopcount+1,
605	<	(unsigned long)source_p->tsinfo,
606	<	ubuf, source_p->username, source_p->host,
607	<	(MyClient(source_p) && IsIPSpoof(source_p)) ?
608	<	"0" : source_p->sockhost, source_p->id, source_p->info);
601	>	if (IsCapable(server, CAP_SVS))
602	>	{
603	>	if (IsCapable(server, CAP_TS6) && HasID(source_p))
604	>	sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
605	>	source_p->servptr->id,
606	>	source_p->name, source_p->hopcount+1,
607	>	(unsigned long)source_p->tsinfo,
608	>	ubuf, source_p->username, source_p->host,
609	>	(MyClient(source_p) && IsIPSpoof(source_p)) ?
610	>	"0" : source_p->sockhost, source_p->id,
611	>	source_p->svid,
612	>	source_p->info);
613	>	else
614	>	sendto_one(server, "NICK %s %d %lu %s %s %s %s %s :%s",
615	>	source_p->name, source_p->hopcount+1,
616	>	(unsigned long)source_p->tsinfo,
617	>	ubuf, source_p->username, source_p->host,
618	>	source_p->servptr->name, source_p->svid,
619	>	source_p->info);
620	>
621	>	}
622		else
623	<	sendto_one(server, "NICK %s %d %lu %s %s %s %s :%s",
624	<	source_p->name, source_p->hopcount+1,
625	<	(unsigned long)source_p->tsinfo,
626	<	ubuf, source_p->username, source_p->host,
627	<	source_p->servptr->name, source_p->info);
623	>	{
624	>	if (IsCapable(server, CAP_TS6) && HasID(source_p))
625	>	sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
626	>	source_p->servptr->id,
627	>	source_p->name, source_p->hopcount+1,
628	>	(unsigned long)source_p->tsinfo,
629	>	ubuf, source_p->username, source_p->host,
630	>	(MyClient(source_p) && IsIPSpoof(source_p)) ?
631	>	"0" : source_p->sockhost, source_p->id, source_p->info);
632	>	else
633	>	sendto_one(server, "NICK %s %d %lu %s %s %s %s :%s",
634	>	source_p->name, source_p->hopcount+1,
635	>	(unsigned long)source_p->tsinfo,
636	>	ubuf, source_p->username, source_p->host,
637	>	source_p->servptr->name, source_p->info);
638	>	}
639		}
640		}
641
#	Line 637 | Line 655 | valid_hostname(const char *hostname)
655
656		assert(p != NULL);
657
658	<	if ('.' == *p || ':' == *p)
658	>	if (*p == '.' || *p == ':')
659		return 0;
660
661	<	while (*p)
644	<	{
661	>	for (; *p; ++p)
662		if (!IsHostChar(*p))
663		return 0;
647	–	p++;
648	–	}
664
665	<	return 1;
665	>	return p - hostname <= HOSTLEN;
666		}
667
668		/* valid_username()
#	Line 669 | Line 684 | valid_username(const char *username)
684
685		assert(p != NULL);
686
687	<	if ('~' == *p)
687	>	if (*p == '~')
688		++p;
689
690		/* reject usernames that don't start with an alphanum
#	Line 683 | Line 698 | valid_username(const char *username)
698		{
699		if ((*p == '.') && ConfigFileEntry.dots_in_ident)
700		{
701	<	dots++;
687	<
688	<	if (dots > ConfigFileEntry.dots_in_ident)
701	>	if (++dots > ConfigFileEntry.dots_in_ident)
702		return 0;
703	<	if (!IsUserChar(p[1]))
703	>	if (!IsUserChar(*(p + 1)))
704		return 0;
705		}
706		else if (!IsUserChar(*p))
#	Line 697 | Line 710 | valid_username(const char *username)
710		return 1;
711		}
712
713	+	/* clean_nick_name()
714	+	*
715	+	* input        - nickname
716	+	*              - whether it's a local nick (1) or remote (0)
717	+	* output       - none
718	+	* side effects - walks through the nickname, returning 0 if erroneous
719	+	*/
720	+	int
721	+	valid_nickname(const char *nickname, const int local)
722	+	{
723	+	const char *p = nickname;
724	+	assert(nickname && *nickname);
725	+
726	+	/* nicks can't start with a digit or - or be 0 length */
727	+	/* This closer duplicates behaviour of hybrid-6 */
728	+	if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
729	+	return 0;
730	+
731	+	for (; *p; ++p)
732	+	if (!IsNickChar(*p))
733	+	return 0;
734	+
735	+	return p - nickname <= NICKLEN;
736	+	}
737	+
738		/* report_and_set_user_flags()
739		*
740		* inputs       - pointer to source_p
741	<	*              - pointer to aconf for this user
741	>	*              - pointer to conf for this user
742		* output       - NONE
743		* side effects - Report to user any special flags
744		*                they are getting, and set them.
745		*/
746		static void
747	<	report_and_set_user_flags(struct Client *source_p, const struct AccessItem *aconf)
747	>	report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
748		{
749		/* If this user is being spoofed, tell them so */
750	<	if (IsConfDoSpoofIp(aconf))
750	>	if (IsConfDoSpoofIp(conf))
751		{
752		sendto_one(source_p,
753		":%s NOTICE %s :*** Spoofing your IP. congrats.",
#	Line 717 | Line 755 | report_and_set_user_flags(struct Client
755		}
756
757		/* If this user is in the exception class, Set it "E lined" */
758	<	if (IsConfExemptKline(aconf))
758	>	if (IsConfExemptKline(conf))
759		{
760		SetExemptKline(source_p);
761		sendto_one(source_p,
#	Line 728 | Line 766 | report_and_set_user_flags(struct Client
766		/* The else here is to make sure that G line exempt users
767		* do not get noticed twice.
768		*/
769	<	else if (IsConfExemptGline(aconf))
769	>	else if (IsConfExemptGline(conf))
770		{
771		SetExemptGline(source_p);
772		sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from G lines.",
773		me.name, source_p->name);
774		}
775
776	<	if (IsConfExemptResv(aconf))
776	>	if (IsConfExemptResv(conf))
777		{
778		SetExemptResv(source_p);
779		sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from resvs.",
#	Line 743 | Line 781 | report_and_set_user_flags(struct Client
781		}
782
783		/* If this user is exempt from user limits set it "F lined" */
784	<	if (IsConfExemptLimits(aconf))
784	>	if (IsConfExemptLimits(conf))
785		{
786		SetExemptLimits(source_p);
787		sendto_one(source_p,
#	Line 751 | Line 789 | report_and_set_user_flags(struct Client
789		me.name,source_p->name);
790		}
791
792	<	/* If this user is exempt from idle time outs */
755	<	if (IsConfIdlelined(aconf))
756	<	{
757	<	SetIdlelined(source_p);
758	<	sendto_one(source_p,
759	<	":%s NOTICE %s :*** You are exempt from idle limits. congrats.",
760	<	me.name, source_p->name);
761	<	}
762	<
763	<	if (IsConfCanFlood(aconf))
792	>	if (IsConfCanFlood(conf))
793		{
794		SetCanFlood(source_p);
795		sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from flood "
#	Line 769 | Line 798 | report_and_set_user_flags(struct Client
798		}
799		}
800
772	–	/* do_local_user()
773	–	*
774	–	* inputs       -
775	–	* output       - NONE
776	–	* side effects -
777	–	*/
778	–	void
779	–	do_local_user(const char *nick, struct Client *client_p, struct Client *source_p,
780	–	const char *username, const char *host, const char *server,
781	–	const char *realname)
782	–	{
783	–	assert(source_p != NULL);
784	–	assert(source_p->username != username);
785	–
786	–	if (source_p == NULL)
787	–	return;
788	–
789	–	if (!IsUnknown(source_p))
790	–	{
791	–	sendto_one(source_p, form_str(ERR_ALREADYREGISTRED),
792	–	me.name, nick);
793	–	return;
794	–	}
795	–
796	–	source_p->localClient->registration &= ~REG_NEED_USER;
797	–
798	–	/*
799	–	* don't take the clients word for it, ever
800	–	*/
801	–	source_p->servptr = &me;
802	–
803	–	strlcpy(source_p->info, realname, sizeof(source_p->info));
804	–
805	–	/* stash for later */
806	–	strlcpy(source_p->client_host, host, sizeof(source_p->client_host));
807	–	strlcpy(source_p->client_server, server, sizeof(source_p->client_server));
808	–
809	–	if (!IsGotId(source_p))
810	–	{
811	–	/* save the username in the client
812	–	* If you move this you'll break ping cookies..you've been warned
813	–	*/
814	–	strlcpy(source_p->username, username, sizeof(source_p->username));
815	–	}
816	–
817	–	if (!source_p->localClient->registration)
818	–	/* NICK already received, now I have USER... */
819	–	register_local_user(client_p, source_p, source_p->name, username);
820	–	}
821	–
801		/* change_simple_umode()
802		*
803		* this callback can be hooked to allow special handling of
#	Line 838 | Line 817 | change_simple_umode(va_list args)
817		flag = va_arg(args, unsigned int);
818
819		if (what == MODE_ADD)
820	<	source_p->umodes |= flag;
820	>	AddUMode(source_p, flag);
821		else
822	<	source_p->umodes &= ~flag;
822	>	DelUMode(source_p, flag);
823
824		return NULL;
825		}
#	Line 854 | Line 833 | change_simple_umode(va_list args)
833		*/
834		void
835		set_user_mode(struct Client *client_p, struct Client *source_p,
836	<	int parc, char *parv[])
836	>	const int parc, char *parv[])
837		{
838		unsigned int flag, setflags;
839		char **p, *m, buf[IRCD_BUFSIZE];
#	Line 871 | Line 850 | set_user_mode(struct Client *client_p, s
850		return;
851		}
852
853	<	if (IsServer(source_p))
875	<	{
876	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, "*** Mode for User %s from %s",
877	<	parv[1], source_p->name);
878	<	return;
879	<	}
880	<
881	<	if (source_p != target_p || target_p->from != source_p->from)
853	>	if (source_p != target_p)
854		{
855		sendto_one(source_p, form_str(ERR_USERSDONTMATCH),
856		me.name, source_p->name);
#	Line 891 | Line 863 | set_user_mode(struct Client *client_p, s
863		*m++ = '+';
864
865		for (i = 0; i < 128; i++)
866	<	if (source_p->umodes & user_modes[i])
866	>	if (HasUMode(source_p, user_modes[i]))
867		*m++ = (char)i;
868		*m = '\0';
869
#	Line 921 | Line 893 | set_user_mode(struct Client *client_p, s
893		case 'o':
894		if (what == MODE_ADD)
895		{
896	<	if (IsServer(client_p) && !IsOper(source_p))
896	>	if (IsServer(client_p) && !HasUMode(source_p, UMODE_OPER))
897		{
898		++Count.oper;
899		SetOper(source_p);
#	Line 932 | Line 904 | set_user_mode(struct Client *client_p, s
904		/* Only decrement the oper counts if an oper to begin with
905		* found by Pat Szuta, Perly , perly@xnet.com
906		*/
907	<	if (!IsOper(source_p))
907	>	if (!HasUMode(source_p, UMODE_OPER))
908		break;
909
910		ClearOper(source_p);
939	–	source_p->umodes &= ~ConfigFileEntry.oper_only_umodes;
911		Count.oper--;
912
913		if (MyConnect(source_p))
914		{
915		dlink_node *dm;
916
917	<	detach_conf(source_p, OPER_TYPE);
918	<	ClearOperFlags(source_p);
917	>	detach_conf(source_p, CONF_OPER);
918	>	ClrOFlag(source_p);
919	>	DelUMode(source_p, ConfigFileEntry.oper_only_umodes);
920
921		if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
922		free_dlink_node(dm);
#	Line 956 | Line 928 | set_user_mode(struct Client *client_p, s
928		/* we may not get these,
929		* but they shouldnt be in default
930		*/
931	+	case 'r':
932		case ' ' :
933		case '\n':
934		case '\r':
#	Line 965 | Line 938 | set_user_mode(struct Client *client_p, s
938		default:
939		if ((flag = user_modes[(unsigned char)*m]))
940		{
941	<	if (MyConnect(source_p) && !IsOper(source_p) &&
941	>	if (MyConnect(source_p) && !HasUMode(source_p, UMODE_OPER) &&
942		(ConfigFileEntry.oper_only_umodes & flag))
943		{
944		badflag = 1;
#	Line 988 | Line 961 | set_user_mode(struct Client *client_p, s
961		sendto_one(source_p, form_str(ERR_UMODEUNKNOWNFLAG),
962		me.name, source_p->name);
963
964	<	if ((source_p->umodes & UMODE_NCHANGE) && !IsOperN(source_p))
964	>	if (MyConnect(source_p) && HasUMode(source_p, UMODE_ADMIN) &&
965	>	!HasOFlag(source_p, OPER_FLAG_ADMIN))
966		{
967		sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
968		me.name, source_p->name);
969	<	source_p->umodes &= ~UMODE_NCHANGE; /* only tcm's really need this */
969	>	DelUMode(source_p, UMODE_ADMIN);
970		}
971
972	<	if (MyConnect(source_p) && (source_p->umodes & UMODE_ADMIN) &&
999	<	!IsOperAdmin(source_p) && !IsOperHiddenAdmin(source_p))
1000	<	{
1001	<	sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
1002	<	me.name, source_p->name);
1003	<	source_p->umodes &= ~UMODE_ADMIN;
1004	<	}
1005	<
1006	<	if (!(setflags & UMODE_INVISIBLE) && IsInvisible(source_p))
972	>	if (!(setflags & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
973		++Count.invisi;
974	<	if ((setflags & UMODE_INVISIBLE) && !IsInvisible(source_p))
974	>	if ((setflags & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
975		--Count.invisi;
976
977		/*
#	Line 1030 | Line 996 | void
996		send_umode(struct Client *client_p, struct Client *source_p,
997		unsigned int old, unsigned int sendmask, char *umode_buf)
998		{
999	+	char *m = umode_buf;
1000		int what = 0;
1001		unsigned int i;
1002		unsigned int flag;
1036	–	char *m = umode_buf;
1003
1004		/*
1005		* build a string in umode_buf to represent the change in the user's
#	Line 1048 | Line 1014 | send_umode(struct Client *client_p, stru
1014		if (MyClient(source_p) && !(flag & sendmask))
1015		continue;
1016
1017	<	if ((flag & old) && !(source_p->umodes & flag))
1017	>	if ((flag & old) && !HasUMode(source_p, flag))
1018		{
1019		if (what == MODE_DEL)
1020		*m++ = (char)i;
#	Line 1059 | Line 1025 | send_umode(struct Client *client_p, stru
1025		*m++ = (char)i;
1026		}
1027		}
1028	<	else if (!(flag & old) && (source_p->umodes & flag))
1028	>	else if (!(flag & old) && HasUMode(source_p, flag))
1029		{
1030		if (what == MODE_ADD)
1031		*m++ = (char)i;
#	Line 1093 | Line 1059 | send_umode_out(struct Client *client_p,
1059		char buf[IRCD_BUFSIZE] = { '\0' };
1060		dlink_node *ptr = NULL;
1061
1062	<	send_umode(NULL, source_p, old, IsOperHiddenAdmin(source_p) ?
1097	<	SEND_UMODES & ~UMODE_ADMIN : SEND_UMODES, buf);
1062	>	send_umode(NULL, source_p, old, SEND_UMODES, buf);
1063
1064		if (buf[0])
1065		{
#	Line 1113 | Line 1078 | send_umode_out(struct Client *client_p,
1078		send_umode(client_p, source_p, old, 0xffffffff, buf);
1079		}
1080
1081	+	void
1082	+	user_set_hostmask(struct Client *target_p, const char *hostname)
1083	+	{
1084	+	if (!valid_hostname(hostname))
1085	+	return;
1086	+
1087	+	if (IsUserHostIp(target_p))
1088	+	delete_user_host(target_p->username, target_p->host, !MyConnect(target_p));
1089	+
1090	+	strlcpy(target_p->host, hostname, sizeof(target_p->host));
1091	+	SetIPSpoof(target_p);
1092	+
1093	+	add_user_host(target_p->username, target_p->host, !MyConnect(target_p));
1094	+	SetUserHost(target_p);
1095	+
1096	+	if (MyClient(target_p))
1097	+	clear_ban_cache_client(target_p);
1098	+	}
1099	+
1100		/* user_welcome()
1101		*
1102		* inputs       - client pointer to client to welcome
#	Line 1136 | Line 1120 | user_welcome(struct Client *source_p)
1120		#endif
1121
1122		sendto_one(source_p, form_str(RPL_WELCOME), me.name, source_p->name,
1123	<	ServerInfo.network_name, source_p->name);
1123	>	ServerInfo.network_name, source_p->name,
1124	>	source_p->username, source_p->host);
1125		sendto_one(source_p, form_str(RPL_YOURHOST), me.name, source_p->name,
1126		get_listener_name(source_p->localClient->listener), ircd_version);
1127		sendto_one(source_p, form_str(RPL_CREATED),
#	Line 1153 | Line 1138 | user_welcome(struct Client *source_p)
1138
1139		if (ConfigFileEntry.short_motd)
1140		{
1141	<	sendto_one(source_p, "NOTICE %s :*** Notice -- motd was last changed at %s",
1142	<	source_p->name, ConfigFileEntry.motd.lastChangedDate);
1141	>	sendto_one(source_p, ":%s NOTICE %s :*** Notice -- motd was last changed at %s",
1142	>	me.name, source_p->name, ConfigFileEntry.motd.lastChangedDate);
1143		sendto_one(source_p,
1144	<	"NOTICE %s :*** Notice -- Please read the motd if you haven't "
1145	<	"read it", source_p->name);
1144	>	":%s NOTICE %s :*** Notice -- Please read the motd if you haven't "
1145	>	"read it", me.name, source_p->name);
1146		sendto_one(source_p, form_str(RPL_MOTDSTART),
1147		me.name, source_p->name, me.name);
1148		sendto_one(source_p, form_str(RPL_MOTD),
#	Line 1179 | Line 1164 | user_welcome(struct Client *source_p)
1164		static int
1165		check_xline(struct Client *source_p)
1166		{
1167	<	struct ConfItem *conf = NULL;
1167	>	struct MaskItem *conf = NULL;
1168		const char *reason = NULL;
1169
1170	<	if ((conf = find_matching_name_conf(XLINE_TYPE, source_p->info, NULL, NULL, 0)) ||
1186	<	(conf = find_matching_name_conf(RXLINE_TYPE, source_p->info, NULL, NULL, 0)))
1170	>	if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
1171		{
1172	<	struct MatchItem *reg = map_to_conf(conf);
1189	<
1190	<	++reg->count;
1172	>	++conf->count;
1173
1174	<	if (reg->reason != NULL)
1175	<	reason = reg->reason;
1174	>	if (conf->reason != NULL)
1175	>	reason = conf->reason;
1176		else
1177		reason = "No Reason";
1178
1179	<	sendto_realops_flags(UMODE_REJ, L_ALL,
1179	>	sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
1180		"X-line Rejecting [%s] [%s], user %s [%s]",
1181		source_p->info, reason,
1182		get_client_name(source_p, HIDE_IP),
1183		source_p->sockhost);
1184
1185		++ServerStats.is_ref;
1186	<	if (REJECT_HOLD_TIME > 0)
1205	<	{
1206	<	sendto_one(source_p, ":%s NOTICE %s :Bad user info",
1207	<	me.name, source_p->name);
1208	<	source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
1209	<	SetCaptured(source_p);
1210	<	}
1211	<	else
1212	<	exit_client(source_p, &me, "Bad user info");
1186	>	exit_client(source_p, &me, "Bad user info");
1187		return 1;
1188		}
1189
#	Line 1220 | Line 1194 | check_xline(struct Client *source_p)
1194		*
1195		* inputs       - pointer to given client to oper
1196		* output       - NONE
1197	<	* side effects - Blindly opers up given source_p, using aconf info
1197	>	* side effects - Blindly opers up given source_p, using conf info
1198		*                all checks on passwords have already been done.
1199		*                This could also be used by rsa oper routines.
1200		*/
1201		void
1202		oper_up(struct Client *source_p)
1203		{
1204	<	unsigned int old = source_p->umodes;
1205	<	const char *operprivs = "";
1232	<	const struct AccessItem *oconf = NULL;
1204	>	const unsigned int old = source_p->umodes;
1205	>	const struct MaskItem *conf = source_p->localClient->confs.head->data;
1206
1207		assert(source_p->localClient->confs.head);
1235	–	oconf = map_to_conf((source_p->localClient->confs.head)->data);
1208
1209		++Count.oper;
1210		SetOper(source_p);
1211
1212	<	if (oconf->modes)
1213	<	source_p->umodes |= oconf->modes;
1212	>	if (conf->modes)
1213	>	AddUMode(source_p, conf->modes);
1214		else if (ConfigFileEntry.oper_umodes)
1215	<	source_p->umodes |= ConfigFileEntry.oper_umodes;
1244	<	else
1245	<	source_p->umodes |= (UMODE_SERVNOTICE|UMODE_OPERWALL|
1246	<	UMODE_WALLOP|UMODE_LOCOPS);
1215	>	AddUMode(source_p, ConfigFileEntry.oper_umodes);
1216
1217	<	if (!(old & UMODE_INVISIBLE) && IsInvisible(source_p))
1217	>	if (!(old & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
1218		++Count.invisi;
1219	<	if ((old & UMODE_INVISIBLE) && !IsInvisible(source_p))
1219	>	if ((old & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
1220		--Count.invisi;
1221
1222		assert(dlinkFind(&oper_list, source_p) == NULL);
1223		dlinkAdd(source_p, make_dlink_node(), &oper_list);
1224
1225	<	operprivs = oper_privs_as_string(oconf->port);
1225	>	AddOFlag(source_p, conf->port);
1226
1227	<	SetOFlag(source_p, oconf->port);
1227	>	if (HasOFlag(source_p, OPER_FLAG_ADMIN))
1228	>	AddUMode(source_p, UMODE_ADMIN);
1229
1230	<	if (IsOperAdmin(source_p) || IsOperHiddenAdmin(source_p))
1231	<	source_p->umodes |= UMODE_ADMIN;
1262	<	if (!IsOperN(source_p))
1263	<	source_p->umodes &= ~UMODE_NCHANGE;
1264	<
1265	<	sendto_realops_flags(UMODE_ALL, L_ALL, "%s (%s@%s) is now an operator",
1266	<	source_p->name, source_p->username, source_p->host);
1230	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
1231	>	get_oper_name(source_p));
1232		send_umode_out(source_p, source_p, old);
1233		sendto_one(source_p, form_str(RPL_YOUREOPER), me.name, source_p->name);
1269	–	sendto_one(source_p, ":%s NOTICE %s :*** Oper privs are %s",
1270	–	me.name, source_p->name, operprivs);
1271	–	send_message_file(source_p, &ConfigFileEntry.opermotd);
1234		}
1235
1236		static char new_uid[TOTALSIDUID + 1];     /* allow for \0 */
#	Line 1276 | Line 1238 | static char new_uid[TOTALSIDUID + 1];
1238		int
1239		valid_sid(const char *sid)
1240		{
1279	–
1241		if (strlen(sid) == IRC_MAXSID)
1242		if (IsDigit(*sid))
1243		if (IsAlNum(*(sid + 1)) && IsAlNum(*(sid + 2)))
#	Line 1297 | Line 1258 | valid_sid(const char *sid)
1258		void
1259		init_uid(void)
1260		{
1261	<	int i;
1261	>	unsigned int i;
1262
1263		memset(new_uid, 0, sizeof(new_uid));
1264
1265	<	if (ServerInfo.sid != NULL)
1305	<	{
1265	>	if (!EmptyString(ServerInfo.sid))
1266		strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1307	–	strlcpy(me.id, ServerInfo.sid, sizeof(me.id));
1267
1268	<	hash_add_id(&me);
1310	<	}
1311	<
1312	<	for (i = 0; i < IRC_MAXSID; i++)
1268	>	for (i = 0; i < IRC_MAXSID; ++i)
1269		if (new_uid[i] == '\0')
1270		new_uid[i] = 'A';
1271
#	Line 1322 | Line 1278 | init_uid(void)
1278
1279		entering_umode_cb = register_callback("entering_umode", NULL);
1280		umode_cb = register_callback("changing_umode", change_simple_umode);
1325	–	uid_get_cb = register_callback("uid_get", uid_get);
1281		}
1282
1283		/*
#	Line 1365 | Line 1320 | add_one_to_uid(int i)
1320		* output       - new UID is returned to caller
1321		* side effects - new_uid is incremented by one.
1322		*/
1323	<	static void *
1324	<	uid_get(va_list args)
1323	>	static const char *
1324	>	uid_get(void)
1325		{
1326		add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1327		return new_uid;
#	Line 1389 | Line 1344 | init_isupport(void)
1344		add_isupport("DEAF", "D", -1);
1345		add_isupport("KICKLEN", NULL, KICKLEN);
1346		add_isupport("MODES", NULL, MAXMODEPARAMS);
1392	–	add_isupport("NICKLEN", NULL, NICKLEN-1);
1347		#ifdef HALFOPS
1348		add_isupport("PREFIX", "(ohv)@%+", -1);
1349		add_isupport("STATUSMSG", "@%+", -1);
#	Line 1397 | Line 1351 | init_isupport(void)
1351		add_isupport("PREFIX", "(ov)@+", -1);
1352		add_isupport("STATUSMSG", "@+", -1);
1353		#endif
1400	–	add_isupport("TOPICLEN", NULL, TOPICLEN);
1354		}
1355
1356		/*
#	Line 1432 | Line 1385 | add_isupport(const char *name, const cha
1385		dlinkAddTail(support, &support->node, &support_list);
1386		}
1387
1388	<	DupString(support->name, name);
1388	>	support->name = xstrdup(name);
1389		if (options != NULL)
1390	<	DupString(support->options, options);
1390	>	support->options = xstrdup(options);
1391		support->number = n;
1392
1393		rebuild_isupport_message_line();
#	Line 1493 | Line 1446 | rebuild_isupport_message_line(void)
1446		{
1447		struct Isupport *support = ptr->data;
1448
1449	<	p += (n = ircsprintf(p, "%s", support->name));
1449	>	p += (n = sprintf(p, "%s", support->name));
1450		len += n;
1451
1452		if (support->options != NULL)
1453		{
1454	<	p += (n = ircsprintf(p, "=%s", support->options));
1454	>	p += (n = sprintf(p, "=%s", support->options));
1455		len += n;
1456		}
1457
1458		if (support->number > 0)
1459		{
1460	<	p += (n = ircsprintf(p, "=%d", support->number));
1460	>	p += (n = sprintf(p, "=%d", support->number));
1461		len += n;
1462		}
1463

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines (old)
>	Changed lines (new)