ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing:
ircd-hybrid-8/src/s_user.c (file contents), Revision 1232 by michael, Thu Sep 22 20:25:00 2011 UTC vs.
ircd-hybrid/trunk/src/user.c (file contents), Revision 5558 by michael, Fri Feb 13 20:45:49 2015 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_user.c: User related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2015 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 16 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file s_user.c
23 > * \brief User related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29 < #include "s_user.h"
28 < #include "s_misc.h"
29 > #include "user.h"
30   #include "channel.h"
31   #include "channel_mode.h"
32   #include "client.h"
32 #include "common.h"
33 #include "fdlist.h"
33   #include "hash.h"
34   #include "irc_string.h"
36 #include "sprintf_irc.h"
37 #include "s_bsd.h"
35   #include "ircd.h"
36   #include "listener.h"
37   #include "motd.h"
38   #include "numeric.h"
39 < #include "s_conf.h"
40 < #include "s_log.h"
41 < #include "s_serv.h"
39 > #include "conf.h"
40 > #include "log.h"
41 > #include "server.h"
42   #include "send.h"
46 #include "supported.h"
47 #include "whowas.h"
43   #include "memory.h"
44   #include "packet.h"
45   #include "rng_mt.h"
46   #include "userhost.h"
47 < #include "hook.h"
48 < #include "s_misc.h"
54 < #include "msg.h"
47 > #include "misc.h"
48 > #include "parse.h"
49   #include "watch.h"
50  
57
58 struct Callback *entering_umode_cb = NULL;
59 struct Callback *umode_cb = NULL;
60
51   static char umode_buffer[IRCD_BUFSIZE];
62
63 static void user_welcome(struct Client *);
64 static void report_and_set_user_flags(struct Client *, const struct AccessItem *);
65 static int check_xline(struct Client *);
66 static void introduce_client(struct Client *);
52   static const char *uid_get(void);
53  
54   /* Used for building up the isupport string,
55   * used with init_isupport, add_isupport, delete_isupport
56   */
57 <
73 < struct Isupport
57 > struct Isupport
58   {
59    dlink_node node;
60    char *name;
# Line 78 | Line 62 | struct Isupport
62    int number;
63   };
64  
65 < static dlink_list support_list = { NULL, NULL, 0 };
66 < MessageFile *isupportFile;
65 > static dlink_list support_list;
66 > static dlink_list support_list_lines;
67  
68 < /* memory is cheap. map 0-255 to equivalent mode */
69 < unsigned int user_modes[256] =
68 > const struct user_modes *umode_map[256];
69 > const struct user_modes  umode_tab[] =
70   {
71 <  /* 0x00 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x0F */
72 <  /* 0x10 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x1F */
73 <  /* 0x20 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x2F */
74 <  /* 0x30 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x3F */
75 <  0,                  /* @ */
76 <  0,                  /* A */
77 <  0,                  /* B */
78 <  UMODE_CCONN_FULL,   /* C */
79 <  UMODE_DEAF,         /* D */
80 <  0,                  /* E */
81 <  0,                  /* F */
82 <  UMODE_SOFTCALLERID, /* G */
83 <  0,                  /* H */
84 <  0,                  /* I */
85 <  0,                  /* J */
86 <  0,                  /* K */
87 <  0,                  /* L */
88 <  0,                  /* M */
89 <  0,                  /* N */
90 <  0,                  /* O */
91 <  0,                  /* P */
92 <  0,                  /* Q */
93 <  UMODE_REGONLY,      /* R */
94 <  0,                  /* S */
95 <  0,                  /* T */
96 <  0,                  /* U */
97 <  0,                  /* V */
98 <  0,                  /* W */
99 <  0,                  /* X */
116 <  0,                  /* Y */
117 <  0,                  /* Z 0x5A */
118 <  0, 0, 0, 0, 0,      /* 0x5F   */
119 <  0,                  /* 0x60   */
120 <  UMODE_ADMIN,        /* a */
121 <  UMODE_BOTS,         /* b */
122 <  UMODE_CCONN,        /* c */
123 <  UMODE_DEBUG,        /* d */
124 <  0,                  /* e */
125 <  UMODE_FULL,         /* f */
126 <  UMODE_CALLERID,     /* g */
127 <  0,                  /* h */
128 <  UMODE_INVISIBLE,    /* i */
129 <  UMODE_REJ,          /* j */
130 <  UMODE_SKILL,        /* k */
131 <  UMODE_LOCOPS,       /* l */
132 <  0,                  /* m */
133 <  UMODE_NCHANGE,      /* n */
134 <  UMODE_OPER,         /* o */
135 <  0,                  /* p */
136 <  0,                  /* q */
137 <  UMODE_REGISTERED,   /* r */
138 <  UMODE_SERVNOTICE,   /* s */
139 <  0,                  /* t */
140 <  UMODE_UNAUTH,       /* u */
141 <  0,                  /* v */
142 <  UMODE_WALLOP,       /* w */
143 <  UMODE_EXTERNAL,     /* x */
144 <  UMODE_SPY,          /* y */
145 <  UMODE_OPERWALL,     /* z      0x7A */
146 <  0,0,0,0,0,          /* 0x7B - 0x7F */
147 <
148 <  /* 0x80 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x8F */
149 <  /* 0x90 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x9F */
150 <  /* 0xA0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xAF */
151 <  /* 0xB0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xBF */
152 <  /* 0xC0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xCF */
153 <  /* 0xD0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xDF */
154 <  /* 0xE0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0xEF */
155 <  /* 0xF0 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0  /* 0xFF */
71 >  { 'D', UMODE_DEAF         },
72 >  { 'F', UMODE_FARCONNECT   },
73 >  { 'G', UMODE_SOFTCALLERID },
74 >  { 'H', UMODE_HIDDEN       },
75 >  { 'R', UMODE_REGONLY      },
76 >  { 'S', UMODE_SSL          },
77 >  { 'W', UMODE_WEBIRC       },
78 >  { 'a', UMODE_ADMIN        },
79 >  { 'b', UMODE_BOTS         },
80 >  { 'c', UMODE_CCONN        },
81 >  { 'd', UMODE_DEBUG        },
82 >  { 'e', UMODE_EXTERNAL     },
83 >  { 'f', UMODE_FULL         },
84 >  { 'g', UMODE_CALLERID     },
85 >  { 'i', UMODE_INVISIBLE    },
86 >  { 'j', UMODE_REJ          },
87 >  { 'k', UMODE_SKILL        },
88 >  { 'l', UMODE_LOCOPS       },
89 >  { 'n', UMODE_NCHANGE      },
90 >  { 'o', UMODE_OPER         },
91 >  { 'p', UMODE_HIDECHANS    },
92 >  { 'q', UMODE_HIDEIDLE     },
93 >  { 'r', UMODE_REGISTERED   },
94 >  { 's', UMODE_SERVNOTICE   },
95 >  { 'u', UMODE_UNAUTH       },
96 >  { 'w', UMODE_WALLOP       },
97 >  { 'x', UMODE_HIDDENHOST   },
98 >  { 'y', UMODE_SPY          },
99 >  { '\0', 0 }
100   };
101  
102   void
103 < assemble_umode_buffer(void)
103 > user_usermodes_init(void)
104   {
161  unsigned int idx = 0;
105    char *umode_buffer_ptr = umode_buffer;
106  
107 <  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
108 <    if (user_modes[idx])
109 <      *umode_buffer_ptr++ = idx;
107 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
108 >  {
109 >    umode_map[tab->c] = tab;
110 >    *umode_buffer_ptr++ = tab->c;
111 >  }
112  
113    *umode_buffer_ptr = '\0';
114   }
# Line 175 | Line 120 | assemble_umode_buffer(void)
120   * side effects - display to client user counts etc.
121   */
122   void
123 < show_lusers(struct Client *source_p)
123 > show_lusers(struct Client *source_p)
124   {
180  const char *from, *to;
181
182  if (!MyConnect(source_p) && IsCapable(source_p->from, CAP_TS6) && HasID(source_p))
183  {
184    from = me.id;
185    to = source_p->id;
186  }
187  else
188  {
189    from = me.name;
190    to = source_p->name;
191  }
192
125    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
126 <    sendto_one(source_p, form_str(RPL_LUSERCLIENT),
127 <               from, to, (Count.total-Count.invisi),
196 <               Count.invisi, dlink_list_length(&global_serv_list));
126 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
127 >                       Count.invisi, dlink_list_length(&global_server_list));
128    else
129 <    sendto_one(source_p, form_str(RPL_LUSERCLIENT), from, to,
130 <               (Count.total-Count.invisi), Count.invisi, 1);
129 >    sendto_one_numeric(source_p, &me, RPL_LUSERCLIENT, (Count.total - Count.invisi),
130 >                       Count.invisi, 1);
131 >
132 >  if (Count.oper)
133 >    sendto_one_numeric(source_p, &me, RPL_LUSEROP, Count.oper);
134 >
135 >  if (dlink_list_length(&unknown_list))
136 >    sendto_one_numeric(source_p, &me, RPL_LUSERUNKNOWN, dlink_list_length(&unknown_list));
137  
138 <  if (Count.oper > 0)
139 <    sendto_one(source_p, form_str(RPL_LUSEROP),
203 <               from, to, Count.oper);
204 <
205 <  if (dlink_list_length(&unknown_list) > 0)
206 <    sendto_one(source_p, form_str(RPL_LUSERUNKNOWN),
207 <               from, to, dlink_list_length(&unknown_list));
208 <
209 <  if (dlink_list_length(&global_channel_list) > 0)
210 <    sendto_one(source_p, form_str(RPL_LUSERCHANNELS),
211 <               from, to, dlink_list_length(&global_channel_list));
138 >  if (dlink_list_length(&channel_list))
139 >    sendto_one_numeric(source_p, &me, RPL_LUSERCHANNELS, dlink_list_length(&channel_list));
140  
141    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
142    {
143 <    sendto_one(source_p, form_str(RPL_LUSERME),
144 <               from, to, Count.local, Count.myserver);
217 <    sendto_one(source_p, form_str(RPL_LOCALUSERS),
218 <               from, to, Count.local, Count.max_loc,
219 <               Count.local, Count.max_loc);
143 >    sendto_one_numeric(source_p, &me, RPL_LUSERME, Count.local, Count.myserver);
144 >    sendto_one_numeric(source_p, &me, RPL_LOCALUSERS, Count.local, Count.max_loc);
145    }
146    else
147    {
148 <    sendto_one(source_p, form_str(RPL_LUSERME),
149 <               from, to, Count.total, 0);
225 <    sendto_one(source_p, form_str(RPL_LOCALUSERS),
226 <               from, to, Count.total, Count.max_tot,
227 <               Count.total, Count.max_tot);
148 >    sendto_one_numeric(source_p, &me, RPL_LUSERME, Count.total, 0);
149 >    sendto_one_numeric(source_p, &me, RPL_LOCALUSERS, Count.total, Count.max_tot);
150    }
151  
152 <  sendto_one(source_p, form_str(RPL_GLOBALUSERS),
231 <             from, to, Count.total, Count.max_tot,
232 <             Count.total, Count.max_tot);
152 >  sendto_one_numeric(source_p, &me, RPL_GLOBALUSERS, Count.total, Count.max_tot);
153  
154    if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
155 <    sendto_one(source_p, form_str(RPL_STATSCONN), from, to,
156 <               Count.max_loc_con, Count.max_loc_cli, Count.totalrestartcount);
155 >    sendto_one_numeric(source_p, &me, RPL_STATSCONN, Count.max_loc_con,
156 >                       Count.max_loc_cli, Count.totalrestartcount);
157  
158    if (Count.local > Count.max_loc_cli)
159      Count.max_loc_cli = Count.local;
160  
161    if ((Count.local + Count.myserver) > Count.max_loc_con)
162 <    Count.max_loc_con = Count.local + Count.myserver;
162 >    Count.max_loc_con = Count.local + Count.myserver;
163   }
164  
165   /* show_isupport()
# Line 249 | Line 169 | show_lusers(struct Client *source_p)
169   * side effects - display to client what we support (for them)
170   */
171   void
172 < show_isupport(struct Client *source_p)
172 > show_isupport(struct Client *source_p)
173   {
174 <  send_message_file(source_p, isupportFile);
174 >  const dlink_node *node = NULL;
175 >
176 >  DLINK_FOREACH(node, support_list_lines.head)
177 >    sendto_one_numeric(source_p, &me, RPL_ISUPPORT, node->data);
178   }
179  
180 < /*
181 < ** register_local_user
182 < **      This function is called when both NICK and USER messages
183 < **      have been accepted for the client, in whatever order. Only
184 < **      after this, is the USER message propagated.
185 < **
186 < **      NICK's must be propagated at once when received, although
187 < **      it would be better to delay them too until full info is
188 < **      available. Doing it is not so simple though, would have
189 < **      to implement the following:
190 < **
191 < **      (actually it has been implemented already for a while) -orabidoo
192 < **
193 < **      1) user telnets in and gives only "NICK foobar" and waits
194 < **      2) another user far away logs in normally with the nick
195 < **         "foobar" (quite legal, as this server didn't propagate
196 < **         it).
197 < **      3) now this server gets nick "foobar" from outside, but
198 < **         has alread the same defined locally. Current server
199 < **         would just issue "KILL foobar" to clean out dups. But,
200 < **         this is not fair. It should actually request another
201 < **         nick from local user or kill him/her...
202 < */
180 >
181 > /* report_and_set_user_flags()
182 > *
183 > * inputs       - pointer to source_p
184 > *              - pointer to conf for this user
185 > * output       - NONE
186 > * side effects - Report to user any special flags
187 > *                they are getting, and set them.
188 > */
189 > static void
190 > report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
191 > {
192 >  /* If this user is being spoofed, tell them so */
193 >  if (IsConfDoSpoofIp(conf))
194 >    sendto_one_notice(source_p, &me, ":*** Spoofing your IP. Congrats.");
195 >
196 >  /* If this user is in the exception class, set it "E lined" */
197 >  if (IsConfExemptKline(conf))
198 >  {
199 >    SetExemptKline(source_p);
200 >    sendto_one_notice(source_p, &me, ":*** You are exempt from K/D/G lines. Congrats.");
201 >  }
202 >
203 >  /*
204 >   * The else here is to make sure that G line exempt users
205 >   * do not get noticed twice.
206 >   */
207 >  else if (IsConfExemptGline(conf))
208 >  {
209 >    SetExemptGline(source_p);
210 >    sendto_one_notice(source_p, &me, ":*** You are exempt from G lines. Congrats.");
211 >  }
212 >
213 >  if (IsConfExemptResv(conf))
214 >  {
215 >    SetExemptResv(source_p);
216 >    sendto_one_notice(source_p, &me, ":*** You are exempt from resvs. Congrats.");
217 >  }
218 >
219 >  /* If this user is exempt from user limits set it "F lined" */
220 >  if (IsConfExemptLimits(conf))
221 >  {
222 >    SetExemptLimits(source_p);
223 >    sendto_one_notice(source_p, &me, ":*** You are exempt from user limits. Congrats.");
224 >  }
225 >
226 >  if (IsConfCanFlood(conf))
227 >  {
228 >    SetCanFlood(source_p);
229 >    sendto_one_notice(source_p, &me, ":*** You are exempt from flood "
230 >                      "protection, aren't you fearsome.");
231 >  }
232 > }
233 >
234 > /* introduce_client()
235 > *
236 > * inputs       - source_p
237 > * output       - NONE
238 > * side effects - This common function introduces a client to the rest
239 > *                of the net, either from a local client connect or
240 > *                from a remote connect.
241 > */
242 > static void
243 > introduce_client(struct Client *source_p)
244 > {
245 >  dlink_node *node = NULL;
246 >  char ubuf[IRCD_BUFSIZE] = "";
247 >
248 >  if (MyClient(source_p))
249 >    send_umode(source_p, source_p, 0, ubuf);
250 >  else
251 >    send_umode(NULL, source_p, 0, ubuf);
252 >
253 >  watch_check_hash(source_p, RPL_LOGON);
254 >
255 >  if (ubuf[0] == '\0')
256 >  {
257 >    ubuf[0] = '+';
258 >    ubuf[1] = '\0';
259 >  }
260 >
261 >  DLINK_FOREACH(node, local_server_list.head)
262 >  {
263 >    struct Client *server = node->data;
264 >
265 >    if (server == source_p->from)
266 >      continue;
267 >
268 >    if (IsCapable(server, CAP_SVS))
269 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
270 >                 source_p->servptr->id,
271 >                 source_p->name, source_p->hopcount+1,
272 >                 (unsigned long)source_p->tsinfo,
273 >                 ubuf, source_p->username, source_p->host,
274 >                 source_p->sockhost, source_p->id,
275 >                 source_p->account,
276 >                 source_p->info);
277 >    else
278 >      sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
279 >                 source_p->servptr->id,
280 >                 source_p->name, source_p->hopcount+1,
281 >                 (unsigned long)source_p->tsinfo,
282 >                 ubuf, source_p->username, source_p->host,
283 >                 source_p->sockhost, source_p->id, source_p->info);
284 >
285 >    if (!EmptyString(source_p->certfp))
286 >      sendto_one(server, ":%s CERTFP %s", source_p->id, source_p->certfp);
287 >  }
288 > }
289 >
290 > /* user_welcome()
291 > *
292 > * inputs       - client pointer to client to welcome
293 > * output       - NONE
294 > * side effects -
295 > */
296 > static void
297 > user_welcome(struct Client *source_p)
298 > {
299 > #if defined(__TIME__) && defined(__DATE__)
300 >  static const char built_date[] = __DATE__ " at " __TIME__;
301 > #else
302 >  static const char built_date[] = "unknown";
303 > #endif
304 >
305 > #ifdef HAVE_LIBCRYPTO
306 >  if (HasFlag(source_p, FLAGS_SSL))
307 >  {
308 >    AddUMode(source_p, UMODE_SSL);
309 >    sendto_one_notice(source_p, &me, ":*** Connected securely via %s",
310 >                      ssl_get_cipher(source_p->connection->fd.ssl));
311 >  }
312 > #endif
313 >
314 >  sendto_one_numeric(source_p, &me, RPL_WELCOME, ConfigServerInfo.network_name,
315 >                     source_p->name);
316 >  sendto_one_numeric(source_p, &me, RPL_YOURHOST,
317 >                     get_listener_name(source_p->connection->listener), ircd_version);
318 >  sendto_one_numeric(source_p, &me, RPL_CREATED, built_date);
319 >  sendto_one_numeric(source_p, &me, RPL_MYINFO, me.name, ircd_version, umode_buffer);
320 >  show_isupport(source_p);
321 >  sendto_one_numeric(source_p, &me, RPL_YOURID, source_p->id);
322 >
323 >  show_lusers(source_p);
324 >  motd_signon(source_p);
325 > }
326 >
327 > /* check_xline()
328 > *
329 > * inputs       - pointer to client to test
330 > * outupt       - 1 if exiting 0 if ok
331 > * side effects -
332 > */
333 > static int
334 > check_xline(struct Client *source_p)
335 > {
336 >  struct MaskItem *conf = NULL;
337 >
338 >  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
339 >  {
340 >    ++conf->count;
341 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
342 >                         "X-line Rejecting [%s] [%s], user %s [%s]",
343 >                         source_p->info, conf->reason,
344 >                         get_client_name(source_p, HIDE_IP),
345 >                         source_p->sockhost);
346 >
347 >    ++ServerStats.is_ref;
348 >    exit_client(source_p, "Bad user info");
349 >    return 1;
350 >  }
351 >
352 >  return 0;
353 > }
354 >
355 > /*! \brief This function is called when both NICK and USER messages
356 > *      have been accepted for the client, in whatever order. Only
357 > *      after this, is the UID message propagated.
358 > * \param source_p Pointer to given client to introduce
359 > */
360   void
361   register_local_user(struct Client *source_p)
362   {
363    const char *id = NULL;
364 <  const struct AccessItem *aconf = NULL;
285 <  dlink_node *ptr = NULL;
364 >  const struct MaskItem *conf = NULL;
365  
287  assert(source_p != NULL);
366    assert(source_p == source_p->from);
367    assert(MyConnect(source_p));
368 <  assert(!source_p->localClient->registration);
368 >  assert(!source_p->connection->registration);
369  
370    ClearCap(source_p, CAP_TS6);
371  
372 <  if (ConfigFileEntry.ping_cookie)
372 >  if (ConfigGeneral.ping_cookie)
373    {
374 <    if (!IsPingSent(source_p) && source_p->localClient->random_ping == 0)
374 >    if (!IsPingSent(source_p) && !source_p->connection->random_ping)
375      {
376        do
377 <        source_p->localClient->random_ping = genrand_int32();
378 <      while (!source_p->localClient->random_ping);
377 >        source_p->connection->random_ping = genrand_int32();
378 >      while (!source_p->connection->random_ping);
379  
380 <      sendto_one(source_p, "PING :%u",
303 <                 source_p->localClient->random_ping);
380 >      sendto_one(source_p, "PING :%u", source_p->connection->random_ping);
381        SetPingSent(source_p);
382        return;
383      }
# Line 309 | Line 386 | register_local_user(struct Client *sourc
386        return;
387    }
388  
389 <  source_p->localClient->last_privmsg = CurrentTime;
389 >  source_p->connection->last_privmsg = CurrentTime;
390    /* Straight up the maximum rate of flooding... */
391 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
391 >  source_p->connection->allow_read = MAX_FLOOD_BURST;
392  
393 <  if (!execute_callback(client_check_cb, source_p, source_p->username))
393 >  if (!check_client(source_p))
394      return;
395  
396 <  if (valid_hostname(source_p->host) == 0)
396 >  if (!valid_hostname(source_p->host))
397    {
398 <    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You have an illegal "
399 <               "character in your hostname", me.name, source_p->name);
400 <    strlcpy(source_p->host, source_p->sockhost,
324 <            sizeof(source_p->host));
398 >    sendto_one_notice(source_p, &me, ":*** Notice -- You have an illegal "
399 >                      "character in your hostname");
400 >    strlcpy(source_p->host, source_p->sockhost, sizeof(source_p->host));
401    }
402  
403 <  ptr   = source_p->localClient->confs.head;
328 <  aconf = map_to_conf(ptr->data);
403 >  conf = source_p->connection->confs.head->data;
404  
405    if (!IsGotId(source_p))
406    {
407 <    char username[USERLEN + 1];
407 >    char username[USERLEN + 1] = "";
408      const char *p = username;
409      unsigned int i = 0;
410  
411 <    if (IsNeedIdentd(aconf))
411 >    if (IsNeedIdentd(conf))
412      {
413        ++ServerStats.is_ref;
414 <      sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You need to install "
415 <                 "identd to use this server", me.name, source_p->name);
416 <      exit_client(source_p, &me, "Install identd");
414 >      sendto_one_notice(source_p, &me, ":*** Notice -- You need to install "
415 >                        "identd to use this server");
416 >      exit_client(source_p, "Install identd");
417        return;
418      }
419  
420      strlcpy(username, source_p->username, sizeof(username));
421  
422 <    if (!IsNoTilde(aconf))
422 >    if (!IsNoTilde(conf))
423        source_p->username[i++] = '~';
424  
425      for (; *p && i < USERLEN; ++p)
426 <      if (*p != '[')
352 <        source_p->username[i++] = *p;
426 >      source_p->username[i++] = *p;
427  
428      source_p->username[i] = '\0';
429    }
430  
431 <  /* password check */
432 <  if (!EmptyString(aconf->passwd))
431 >  /* Password check */
432 >  if (!EmptyString(conf->passwd))
433    {
434 <    const char *pass = source_p->localClient->passwd;
361 <
362 <    if (!match_conf_password(pass, aconf))
434 >    if (!match_conf_password(source_p->connection->password, conf))
435      {
436        ++ServerStats.is_ref;
437 <      sendto_one(source_p, form_str(ERR_PASSWDMISMATCH),
438 <                 me.name, source_p->name);
439 <      exit_client(source_p, &me, "Bad Password");
437 >
438 >      sendto_one_numeric(source_p, &me, ERR_PASSWDMISMATCH);
439 >      exit_client(source_p, "Bad Password");
440        return;
441      }
442    }
443  
444 <  /* don't free source_p->localClient->passwd here - it can be required
445 <   * by masked /stats I if there are auth{} blocks with need_password = no;
444 >  /*
445 >   * Don't free source_p->connection->password here - it can be required
446 >   * by masked /stats I if there are auth {} blocks with need_password = no;
447     * --adx
448     */
449  
450 <  /* report if user has &^>= etc. and set flags as needed in source_p */
451 <  report_and_set_user_flags(source_p, aconf);
450 >  /*
451 >   * Report if user has &^>= etc. and set flags as needed in source_p
452 >   */
453 >  report_and_set_user_flags(source_p, conf);
454  
455    if (IsDead(source_p))
456      return;
457  
458 <  /* Limit clients -
458 >  /*
459 >   * Limit clients -
460     * We want to be able to have servers and F-line clients
461     * connect, so save room for "buffer" connections.
462     * Smaller servers may want to decrease this, and it should
463     * probably be just a percentage of the MAXCLIENTS...
464     *   -Taner
465     */
466 <  /* Except "F:" clients */
467 <  if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
392 <      (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
466 >  if ((Count.local >= GlobalSetOptions.maxclients + MAX_BUFFER) ||
467 >      (Count.local >= GlobalSetOptions.maxclients && !IsExemptLimits(source_p)))
468    {
469 <    sendto_realops_flags(UMODE_FULL, L_ALL,
469 >    sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
470                           "Too many clients, rejecting %s[%s].",
471                           source_p->name, source_p->host);
472      ++ServerStats.is_ref;
473 <    exit_client(source_p, &me, "Sorry, server is full - try later");
473 >    exit_client(source_p, "Sorry, server is full - try later");
474      return;
475    }
476  
477 <  /* valid user name check */
403 <  if (valid_username(source_p->username) == 0)
477 >  if (!valid_username(source_p->username, 1))
478    {
479 <    char tmpstr2[IRCD_BUFSIZE];
479 >    char buf[IRCD_BUFSIZE] = "";
480  
481 <    sendto_realops_flags(UMODE_REJ, L_ALL, "Invalid username: %s (%s@%s)",
481 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
482 >                         "Invalid username: %s (%s@%s)",
483                           source_p->name, source_p->username, source_p->host);
484      ++ServerStats.is_ref;
485 <    snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
486 <             source_p->username);
412 <    exit_client(source_p, &me, tmpstr2);
485 >    snprintf(buf, sizeof(buf), "Invalid username [%s]", source_p->username);
486 >    exit_client(source_p, buf);
487      return;
488    }
489  
490    if (check_xline(source_p))
491      return;
492  
493 <  while (hash_find_id((id = uid_get())) != NULL)
493 >  while (hash_find_id((id = uid_get())))
494      ;
495  
496    strlcpy(source_p->id, id, sizeof(source_p->id));
497    hash_add_id(source_p);
498  
499 <  sendto_realops_flags(UMODE_CCONN, L_ALL,
499 >  sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
500                         "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
501                         source_p->name, source_p->username, source_p->host,
502 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
503 <                       "255.255.255.255" : source_p->sockhost,
430 <                       get_client_class(source_p),
502 >                       source_p->sockhost,
503 >                       get_client_class(&source_p->connection->confs),
504                         source_p->info, source_p->id);
505  
506 <  sendto_realops_flags(UMODE_CCONN_FULL, L_ALL,
434 <                       "CLICONN %s %s %s %s %s %s %s 0 %s",
435 <                       source_p->name, source_p->username, source_p->host,
436 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
437 <                       "255.255.255.255" : source_p->sockhost,
438 <                       get_client_class(source_p),
439 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
440 <                           "<hidden>" : source_p->localClient->client_host,
441 <                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
442 <                           "<hidden>" : source_p->localClient->client_server,
443 <                       source_p->info);
444 <
445 <
446 <  if (ConfigFileEntry.invisible_on_connect)
506 >  if (ConfigGeneral.invisible_on_connect)
507    {
508      AddUMode(source_p, UMODE_INVISIBLE);
509      ++Count.invisi;
510    }
511  
512 <  if ((++Count.local) > Count.max_loc)
512 >  if (++Count.local > Count.max_loc)
513    {
514      Count.max_loc = Count.local;
515  
516      if (!(Count.max_loc % 10))
517 <      sendto_realops_flags(UMODE_ALL, L_ALL, "New Max Local Clients: %d",
517 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
518 >                           "New maximum local client connections: %u",
519                             Count.max_loc);
520    }
521  
461  /* Increment our total user count here */
522    if (++Count.total > Count.max_tot)
523      Count.max_tot = Count.total;
524    ++Count.totalrestartcount;
# Line 466 | Line 526 | register_local_user(struct Client *sourc
526    assert(source_p->servptr == &me);
527    SetClient(source_p);
528    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
529 <
470 <  source_p->localClient->allow_read = MAX_FLOOD_BURST;
529 >  dlinkAdd(source_p, &source_p->node, &global_client_list);
530  
531    assert(dlinkFind(&unknown_list, source_p));
532  
533 <  dlink_move_node(&source_p->localClient->lclient_node,
533 >  dlink_move_node(&source_p->connection->lclient_node,
534                    &unknown_list, &local_client_list);
535  
536    user_welcome(source_p);
# Line 487 | Line 546 | register_local_user(struct Client *sourc
546   *              - username to register as
547   *              - host name to register as
548   *              - server name
490 *              - realname (gecos)
549   * output       - NONE
550   * side effects - This function is called when a remote client
551   *                is introduced by a server.
552   */
553   void
554 < register_remote_user(struct Client *source_p,
497 <                     const char *username, const char *host, const char *server,
498 <                     const char *realname)
554 > register_remote_user(struct Client *source_p)
555   {
556 <  struct Client *target_p = NULL;
501 <
502 <  assert(source_p != NULL);
503 <  assert(source_p->username != username);
504 <
505 <  strlcpy(source_p->host, host, sizeof(source_p->host));
506 <  strlcpy(source_p->username, username, sizeof(source_p->username));
507 <
508 <  /*
509 <   * coming from another server, take the servers word for it
510 <   */
511 <  source_p->servptr = hash_find_server(server);
512 <
513 <  /* Super GhostDetect:
514 <   * If we can't find the server the user is supposed to be on,
515 <   * then simply blow the user away.        -Taner
516 <   */
517 <  if (source_p->servptr == NULL)
518 <  {
519 <    sendto_realops_flags(UMODE_ALL, L_ALL,
520 <                         "No server %s for user %s[%s@%s] from %s",
521 <                         server, source_p->name, source_p->username,
522 <                         source_p->host, source_p->from->name);
523 <    kill_client(source_p->from, source_p, "%s (Server doesn't exist)", me.name);
524 <
525 <    AddFlag(source_p, FLAGS_KILLED);
526 <    exit_client(source_p, &me, "Ghosted Client");
527 <    return;
528 <  }
556 >  const struct Client *target_p = NULL;
557  
558    if ((target_p = source_p->servptr) && target_p->from != source_p->from)
559    {
560 <    sendto_realops_flags(UMODE_DEBUG, L_ALL,
560 >    sendto_realops_flags(UMODE_DEBUG, L_ALL, SEND_NOTICE,
561                           "Bad User [%s] :%s USER %s@%s %s, != %s[%s]",
562                           source_p->from->name, source_p->name, source_p->username,
563                           source_p->host, source_p->servptr->name,
564                           target_p->name, target_p->from->name);
565 <    kill_client(source_p->from, source_p,
566 <                "%s (NICK from wrong direction (%s != %s))",
567 <                me.name, source_p->servptr->name, target_p->from->name);
565 >    sendto_one(source_p->from,
566 >               ":%s KILL %s :%s (UID from wrong direction (%s != %s))",
567 >               me.id, source_p->id, me.name, source_p->servptr->name,
568 >               target_p->from->name);
569 >
570      AddFlag(source_p, FLAGS_KILLED);
571 <    exit_client(source_p, &me, "USER server wrong direction");
571 >    exit_client(source_p, "UID server wrong direction");
572      return;
573    }
574  
# Line 549 | Line 579 | register_remote_user(struct Client *sour
579    if (HasFlag(source_p->servptr, FLAGS_SERVICE))
580      AddFlag(source_p, FLAGS_SERVICE);
581  
552  /* Increment our total user count here */
582    if (++Count.total > Count.max_tot)
583      Count.max_tot = Count.total;
584  
585    SetClient(source_p);
586    dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
587 +  dlinkAdd(source_p, &source_p->node, &global_client_list);
588    add_user_host(source_p->username, source_p->host, 1);
589    SetUserHost(source_p);
590  
591 <  introduce_client(source_p);
562 < }
563 <
564 < /* introduce_client()
565 < *
566 < * inputs       - source_p
567 < * output       - NONE
568 < * side effects - This common function introduces a client to the rest
569 < *                of the net, either from a local client connect or
570 < *                from a remote connect.
571 < */
572 < static void
573 < introduce_client(struct Client *source_p)
574 < {
575 <  dlink_node *server_node = NULL;
576 <  static char ubuf[12];
577 <
578 <  if (MyClient(source_p))
579 <    send_umode(source_p, source_p, 0, SEND_UMODES, ubuf);
580 <  else
581 <    send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
582 <
583 <  watch_check_hash(source_p, RPL_LOGON);
584 <
585 <  if (*ubuf == '\0')
591 >  if (HasFlag(source_p->servptr, FLAGS_EOB))
592    {
593 <    ubuf[0] = '+';
594 <    ubuf[1] = '\0';
595 <  }
596 <
597 <  DLINK_FOREACH(server_node, serv_list.head)
598 <  {
593 <    struct Client *server = server_node->data;
594 <
595 <    if (server == source_p->from)
596 <        continue;
597 <
598 <    if (IsCapable(server, CAP_SVS))
599 <    {
600 <      if (IsCapable(server, CAP_TS6) && HasID(source_p))
601 <        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %lu :%s",
602 <                   source_p->servptr->id,
603 <                   source_p->name, source_p->hopcount+1,
604 <                   (unsigned long)source_p->tsinfo,
605 <                   ubuf, source_p->username, source_p->host,
606 <                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
607 <                   "0" : source_p->sockhost, source_p->id,
608 <                   (unsigned long)source_p->servicestamp,
609 <                   source_p->info);
610 <      else
611 <        sendto_one(server, "NICK %s %d %lu %s %s %s %s %lu :%s",
612 <                   source_p->name, source_p->hopcount+1,
613 <                   (unsigned long)source_p->tsinfo,
614 <                   ubuf, source_p->username, source_p->host,
615 <                   source_p->servptr->name, (unsigned long)source_p->servicestamp,
616 <                   source_p->info);
617 <
618 <    }
593 >    if (strcmp(source_p->sockhost, "0")) /* XXX: TBR */
594 >      sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
595 >                           "Client connecting at %s: %s (%s@%s) [%s] [%s] <%s>",
596 >                           source_p->servptr->name,
597 >                           source_p->name, source_p->username, source_p->host,
598 >                           source_p->sockhost, source_p->info, source_p->id);
599      else
600 <    {
601 <      if (IsCapable(server, CAP_TS6) && HasID(source_p))
602 <        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
603 <                   source_p->servptr->id,
604 <                   source_p->name, source_p->hopcount+1,
625 <                   (unsigned long)source_p->tsinfo,
626 <                   ubuf, source_p->username, source_p->host,
627 <                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
628 <                   "0" : source_p->sockhost, source_p->id, source_p->info);
629 <      else
630 <        sendto_one(server, "NICK %s %d %lu %s %s %s %s :%s",
631 <                   source_p->name, source_p->hopcount+1,
632 <                   (unsigned long)source_p->tsinfo,
633 <                   ubuf, source_p->username, source_p->host,
634 <                   source_p->servptr->name, source_p->info);
635 <    }
600 >      sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
601 >                           "Client connecting at %s: %s (%s@%s) [%s] <%s>",
602 >                           source_p->servptr->name,
603 >                           source_p->name, source_p->username, source_p->host,
604 >                           source_p->info, source_p->id);
605    }
606 +
607 +  introduce_client(source_p);
608   }
609  
610   /* valid_hostname()
# Line 650 | Line 621 | valid_hostname(const char *hostname)
621   {
622    const char *p = hostname;
623  
624 <  assert(p != NULL);
624 >  assert(p);
625  
626 <  if (*p == '.' || *p == ':')
626 >  if (EmptyString(p) || *p == '.' || *p == ':')
627      return 0;
628  
629    for (; *p; ++p)
630      if (!IsHostChar(*p))
631        return 0;
632  
633 <  return 1;
633 >  return p - hostname <= HOSTLEN;
634   }
635  
636   /* valid_username()
# Line 674 | Line 645 | valid_hostname(const char *hostname)
645   * style of username
646   */
647   int
648 < valid_username(const char *username)
648 > valid_username(const char *username, const int local)
649   {
650 <  int dots      = 0;
650 >  unsigned int dots = 0;
651    const char *p = username;
652  
653 <  assert(p != NULL);
653 >  assert(p);
654  
655    if (*p == '~')
656      ++p;
657  
658 <  /* reject usernames that don't start with an alphanum
658 >  /*
659 >   * Reject usernames that don't start with an alphanum
660     * i.e. reject jokers who have '-@somehost' or '.@somehost'
661     * or "-hi-@somehost", "h-----@somehost" would still be accepted.
662     */
663    if (!IsAlNum(*p))
664      return 0;
665  
666 <  while (*++p)
666 >  if (local)
667    {
668 <    if ((*p == '.') && ConfigFileEntry.dots_in_ident)
668 >    while (*++p)
669      {
670 <      if (++dots > ConfigFileEntry.dots_in_ident)
671 <        return 0;
672 <      if (!IsUserChar(*(p + 1)))
670 >      if (*p == '.' && ConfigGeneral.dots_in_ident)
671 >      {
672 >        if (++dots > ConfigGeneral.dots_in_ident)
673 >          return 0;
674 >        if (!IsUserChar(*(p + 1)))
675 >          return 0;
676 >      }
677 >      else if (!IsUserChar(*p))
678          return 0;
679      }
680 <    else if (!IsUserChar(*p))
681 <      return 0;
680 >  }
681 >  else
682 >  {
683 >    while (*++p)
684 >      if (!IsUserChar(*p))
685 >        return 0;
686    }
687  
688 <  return 1;
688 >  return p - username <= USERLEN;
689   }
690  
691   /* clean_nick_name()
# Line 718 | Line 699 | int
699   valid_nickname(const char *nickname, const int local)
700   {
701    const char *p = nickname;
721  assert(nickname && *nickname);
702  
703 <  /* nicks can't start with a digit or - or be 0 length */
704 <  /* This closer duplicates behaviour of hybrid-6 */
705 <  if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
703 >  assert(p);
704 >
705 >  /*
706 >   * Nicks can't start with a digit or - or be 0 length.
707 >   */
708 >  if (EmptyString(p) || *p == '-' || (IsDigit(*p) && local))
709      return 0;
710  
711    for (; *p; ++p)
712      if (!IsNickChar(*p))
713        return 0;
714  
715 <  return p - nickname <= (NICKLEN - 1);
733 < }
734 <
735 < /* report_and_set_user_flags()
736 < *
737 < * inputs       - pointer to source_p
738 < *              - pointer to aconf for this user
739 < * output       - NONE
740 < * side effects - Report to user any special flags
741 < *                they are getting, and set them.
742 < */
743 < static void
744 < report_and_set_user_flags(struct Client *source_p, const struct AccessItem *aconf)
745 < {
746 <  /* If this user is being spoofed, tell them so */
747 <  if (IsConfDoSpoofIp(aconf))
748 <  {
749 <    sendto_one(source_p,
750 <               ":%s NOTICE %s :*** Spoofing your IP. congrats.",
751 <               me.name, source_p->name);
752 <  }
753 <
754 <  /* If this user is in the exception class, Set it "E lined" */
755 <  if (IsConfExemptKline(aconf))
756 <  {
757 <    SetExemptKline(source_p);
758 <    sendto_one(source_p,
759 <               ":%s NOTICE %s :*** You are exempt from K/D/G lines. congrats.",
760 <               me.name, source_p->name);
761 <  }
762 <
763 <  /* The else here is to make sure that G line exempt users
764 <   * do not get noticed twice.
765 <   */
766 <  else if (IsConfExemptGline(aconf))
767 <  {
768 <    SetExemptGline(source_p);
769 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from G lines.",
770 <               me.name, source_p->name);
771 <  }
772 <
773 <  if (IsConfExemptResv(aconf))
774 <  {
775 <    SetExemptResv(source_p);
776 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from resvs.",
777 <               me.name, source_p->name);
778 <  }
779 <
780 <  /* If this user is exempt from user limits set it "F lined" */
781 <  if (IsConfExemptLimits(aconf))
782 <  {
783 <    SetExemptLimits(source_p);
784 <    sendto_one(source_p,
785 <               ":%s NOTICE %s :*** You are exempt from user limits. congrats.",
786 <               me.name,source_p->name);
787 <  }
788 <
789 <  if (IsConfCanFlood(aconf))
790 <  {
791 <    SetCanFlood(source_p);
792 <    sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from flood "
793 <               "protection, aren't you fearsome.",
794 <               me.name, source_p->name);
795 <  }
796 < }
797 <
798 < /* change_simple_umode()
799 < *
800 < * this callback can be hooked to allow special handling of
801 < * certain usermodes
802 < */
803 < static void *
804 < change_simple_umode(va_list args)
805 < {
806 <  struct Client *client_p;
807 <  struct Client *source_p;
808 <  int what;
809 <  unsigned int flag;
810 <
811 <  client_p = va_arg(args, struct Client *);
812 <  source_p = va_arg(args, struct Client *);
813 <  what = va_arg(args, int);
814 <  flag = va_arg(args, unsigned int);
815 <
816 <  if (what == MODE_ADD)
817 <    AddUMode(source_p, flag);
818 <  else
819 <    DelUMode(source_p, flag);
820 <
821 <  return NULL;
822 < }
823 <
824 < /* set_user_mode()
825 < *
826 < * added 15/10/91 By Darren Reed.
827 < * parv[0] - sender
828 < * parv[1] - username to change mode for
829 < * parv[2] - modes to change
830 < */
831 < void
832 < set_user_mode(struct Client *client_p, struct Client *source_p,
833 <              int parc, char *parv[])
834 < {
835 <  unsigned int flag, setflags;
836 <  char **p, *m, buf[IRCD_BUFSIZE];
837 <  struct Client *target_p;
838 <  int what = MODE_ADD, badflag = 0, i;
839 <
840 <  assert(!(parc < 2));
841 <
842 <  if ((target_p = find_person(client_p, parv[1])) == NULL)
843 <  {
844 <    if (MyConnect(source_p))
845 <      sendto_one(source_p, form_str(ERR_NOSUCHCHANNEL),
846 <                 me.name, source_p->name, parv[1]);
847 <    return;
848 <  }
849 <
850 <  if (IsServer(source_p))
851 <  {
852 <     sendto_realops_flags(UMODE_ALL, L_ADMIN, "*** Mode for User %s from %s",
853 <                          parv[1], source_p->name);
854 <     return;
855 <  }
856 <
857 <  if (source_p != target_p)
858 <  {
859 <     sendto_one(source_p, form_str(ERR_USERSDONTMATCH),
860 <                me.name, source_p->name);
861 <     return;
862 <  }
863 <
864 <  if (parc < 3)
865 <  {
866 <    m = buf;
867 <    *m++ = '+';
868 <
869 <    for (i = 0; i < 128; i++)
870 <      if (HasUMode(source_p, user_modes[i]))
871 <        *m++ = (char)i;
872 <    *m = '\0';
873 <
874 <    sendto_one(source_p, form_str(RPL_UMODEIS),
875 <               me.name, source_p->name, buf);
876 <    return;
877 <  }
878 <
879 <  execute_callback(entering_umode_cb, client_p, source_p);
880 <
881 <  /* find flags already set for user */
882 <  setflags = source_p->umodes;
883 <
884 <  /* parse mode change string(s) */
885 <  for (p = &parv[2]; p && *p; p++)
886 <  {
887 <    for (m = *p; *m; m++)
888 <    {
889 <      switch (*m)
890 <      {
891 <        case '+':
892 <          what = MODE_ADD;
893 <          break;
894 <        case '-':
895 <          what = MODE_DEL;
896 <          break;
897 <        case 'o':
898 <          if (what == MODE_ADD)
899 <          {
900 <            if (IsServer(client_p) && !HasUMode(source_p, UMODE_OPER))
901 <            {
902 <              ++Count.oper;
903 <              SetOper(source_p);
904 <            }
905 <          }
906 <          else
907 <          {
908 <            /* Only decrement the oper counts if an oper to begin with
909 <             * found by Pat Szuta, Perly , perly@xnet.com
910 <             */
911 <            if (!HasUMode(source_p, UMODE_OPER))
912 <              break;
913 <
914 <            ClearOper(source_p);
915 <            Count.oper--;
916 <
917 <            if (MyConnect(source_p))
918 <            {
919 <              dlink_node *dm;
920 <
921 <              detach_conf(source_p, OPER_TYPE);
922 <              ClrOFlag(source_p);
923 <              DelUMode(source_p, ConfigFileEntry.oper_only_umodes);
924 <
925 <              if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
926 <                free_dlink_node(dm);
927 <            }
928 <          }
929 <
930 <          break;
931 <
932 <        /* we may not get these,
933 <         * but they shouldnt be in default
934 <         */
935 <        case 'r':
936 <        case ' ' :
937 <        case '\n':
938 <        case '\r':
939 <        case '\t':
940 <          break;
941 <
942 <        default:
943 <          if ((flag = user_modes[(unsigned char)*m]))
944 <          {
945 <            if (MyConnect(source_p) && !HasUMode(source_p, UMODE_OPER) &&
946 <                (ConfigFileEntry.oper_only_umodes & flag))
947 <            {
948 <              badflag = 1;
949 <            }
950 <            else
951 <              execute_callback(umode_cb, client_p, source_p, what, flag);
952 <          }
953 <          else
954 <          {
955 <            if (MyConnect(source_p))
956 <              badflag = 1;
957 <          }
958 <
959 <          break;
960 <      }
961 <    }
962 <  }
963 <
964 <  if (badflag)
965 <    sendto_one(source_p, form_str(ERR_UMODEUNKNOWNFLAG),
966 <               me.name, source_p->name);
967 <
968 <  if (HasUMode(source_p, UMODE_NCHANGE) && !HasOFlag(source_p, OPER_FLAG_N))
969 <  {
970 <    sendto_one(source_p, ":%s NOTICE %s :*** You have no nchange flag;",
971 <               me.name, source_p->name);
972 <    DelUMode(source_p, UMODE_NCHANGE);
973 <  }
974 <
975 <  if (MyConnect(source_p) && HasUMode(source_p, UMODE_ADMIN) &&
976 <      !HasOFlag(source_p, OPER_FLAG_HIDDEN_ADMIN|OPER_FLAG_ADMIN))
977 <  {
978 <    sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
979 <               me.name, source_p->name);
980 <    DelUMode(source_p, UMODE_ADMIN);
981 <  }
982 <
983 <  if (!(setflags & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
984 <    ++Count.invisi;
985 <  if ((setflags & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
986 <    --Count.invisi;
987 <
988 <  /*
989 <   * compare new flags with old flags and send string which
990 <   * will cause servers to update correctly.
991 <   */
992 <  send_umode_out(client_p, source_p, setflags);
715 >  return p - nickname <= NICKLEN;
716   }
717  
718   /* send_umode()
# Line 1005 | Line 728 | set_user_mode(struct Client *client_p, s
728   */
729   void
730   send_umode(struct Client *client_p, struct Client *source_p,
731 <           unsigned int old, unsigned int sendmask, char *umode_buf)
731 >           unsigned int old, char *umode_buf)
732   {
733    char *m = umode_buf;
734    int what = 0;
1012  unsigned int i;
1013  unsigned int flag;
735  
736    /*
737 <   * build a string in umode_buf to represent the change in the user's
737 >   * Build a string in umode_buf to represent the change in the user's
738     * mode between the new (source_p->umodes) and 'old'.
739     */
740 <  for (i = 0; i < 128; i++)
740 >  for (const struct user_modes *tab = umode_tab; tab->c; ++tab)
741    {
742 <    flag = user_modes[i];
1022 <    if (!flag)
1023 <      continue;
1024 <
1025 <    if (MyClient(source_p) && !(flag & sendmask))
1026 <      continue;
1027 <
1028 <    if ((flag & old) && !HasUMode(source_p, flag))
742 >    if ((tab->flag & old) && !HasUMode(source_p, tab->flag))
743      {
744        if (what == MODE_DEL)
745 <        *m++ = (char)i;
745 >        *m++ = tab->c;
746        else
747        {
748          what = MODE_DEL;
749          *m++ = '-';
750 <        *m++ = (char)i;
750 >        *m++ = tab->c;
751        }
752      }
753 <    else if (!(flag & old) && HasUMode(source_p, flag))
753 >    else if (!(tab->flag & old) && HasUMode(source_p, tab->flag))
754      {
755        if (what == MODE_ADD)
756 <        *m++ = (char)i;
756 >        *m++ = tab->c;
757        else
758        {
759          what = MODE_ADD;
760          *m++ = '+';
761 <        *m++ = (char)i;
761 >        *m++ = tab->c;
762        }
763      }
764    }
# Line 1053 | Line 767 | send_umode(struct Client *client_p, stru
767  
768    if (*umode_buf && client_p)
769      sendto_one(client_p, ":%s!%s@%s MODE %s :%s",
770 <               source_p->name, source_p->username,
771 <               source_p->host, source_p->name, umode_buf);
770 >               client_p->name, client_p->username,
771 >               client_p->host, client_p->name, umode_buf);
772   }
773  
774   /* send_umode_out()
# Line 1064 | Line 778 | send_umode(struct Client *client_p, stru
778   * side effects - Only send ubuf out to servers that know about this client
779   */
780   void
781 < send_umode_out(struct Client *client_p, struct Client *source_p,
1068 <               unsigned int old)
781 > send_umode_out(struct Client *source_p, unsigned int old)
782   {
783 <  char buf[IRCD_BUFSIZE] = { '\0' };
1071 <  dlink_node *ptr = NULL;
783 >  char buf[IRCD_BUFSIZE] = "";
784  
785 <  send_umode(NULL, source_p, old, HasOFlag(source_p, OPER_FLAG_HIDDEN_ADMIN) ?
1074 <             SEND_UMODES & ~UMODE_ADMIN : SEND_UMODES, buf);
785 >  send_umode(MyClient(source_p) ? source_p : NULL, source_p, old, buf);
786  
787    if (buf[0])
788 <  {
789 <    DLINK_FOREACH(ptr, serv_list.head)
1079 <    {
1080 <      struct Client *target_p = ptr->data;
1081 <
1082 <      if ((target_p != client_p) && (target_p != source_p))
1083 <        sendto_one(target_p, ":%s MODE %s :%s",
1084 <                   ID_or_name(source_p, target_p),
1085 <                   ID_or_name(source_p, target_p), buf);
1086 <    }
1087 <  }
1088 <
1089 <  if (client_p && MyClient(client_p))
1090 <    send_umode(client_p, source_p, old, 0xffffffff, buf);
788 >    sendto_server(source_p, 0, 0, ":%s MODE %s :%s",
789 >                  source_p->id, source_p->id, buf);
790   }
791  
792 < /* user_welcome()
793 < *
1095 < * inputs       - client pointer to client to welcome
1096 < * output       - NONE
1097 < * side effects -
1098 < */
1099 < static void
1100 < user_welcome(struct Client *source_p)
792 > void
793 > user_set_hostmask(struct Client *target_p, const char *hostname, const int what)
794   {
795 < #if defined(__TIME__) && defined(__DATE__)
1103 <  static const char built_date[] = __DATE__ " at " __TIME__;
1104 < #else
1105 <  static const char built_date[] = "unknown";
1106 < #endif
795 >  dlink_node *node = NULL;
796  
797 < #ifdef HAVE_LIBCRYPTO
798 <  if (source_p->localClient->fd.ssl != NULL)
1110 <    sendto_one(source_p, ":%s NOTICE %s :*** Connected securely via %s",
1111 <               me.name, source_p->name,
1112 <               ssl_get_cipher(source_p->localClient->fd.ssl));
1113 < #endif
797 >  if (!strcmp(target_p->host, hostname))
798 >    return;
799  
800 <  sendto_one(source_p, form_str(RPL_WELCOME), me.name, source_p->name,
801 <             ServerInfo.network_name, source_p->name);
802 <  sendto_one(source_p, form_str(RPL_YOURHOST), me.name, source_p->name,
803 <             get_listener_name(source_p->localClient->listener), ircd_version);
804 <  sendto_one(source_p, form_str(RPL_CREATED),
805 <             me.name, source_p->name, built_date);
806 <  sendto_one(source_p, form_str(RPL_MYINFO),
807 <             me.name, source_p->name, me.name, ircd_version, umode_buffer);
808 <  show_isupport(source_p);
800 >  switch (what)
801 >  {
802 >    case MODE_ADD:
803 >      AddUMode(target_p, UMODE_HIDDENHOST);
804 >      break;
805 >    case MODE_DEL:
806 >      DelUMode(target_p, UMODE_HIDDENHOST);
807 >      break;
808 >    default: return;
809 >  }
810  
811 <  if (source_p->id[0] != '\0')
812 <    sendto_one(source_p, form_str(RPL_YOURID), me.name,
813 <               source_p->name, source_p->id);
811 >  if (ConfigGeneral.cycle_on_host_change)
812 >    sendto_common_channels_local(target_p, 0, 0, ":%s!%s@%s QUIT :Changing hostname",
813 >                                 target_p->name, target_p->username, target_p->host);
814  
815 <  show_lusers(source_p);
815 >  if (IsUserHostIp(target_p))
816 >    delete_user_host(target_p->username, target_p->host, !MyConnect(target_p));
817 >
818 >  strlcpy(target_p->host, hostname, sizeof(target_p->host));
819 >
820 >  add_user_host(target_p->username, target_p->host, !MyConnect(target_p));
821 >  SetUserHost(target_p);
822  
823 <  if (ConfigFileEntry.short_motd)
823 >  if (MyClient(target_p))
824    {
825 <    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- motd was last changed at %s",
826 <               me.name, source_p->name, ConfigFileEntry.motd.lastChangedDate);
1135 <    sendto_one(source_p,
1136 <               ":%s NOTICE %s :*** Notice -- Please read the motd if you haven't "
1137 <               "read it", me.name, source_p->name);
1138 <    sendto_one(source_p, form_str(RPL_MOTDSTART),
1139 <               me.name, source_p->name, me.name);
1140 <    sendto_one(source_p, form_str(RPL_MOTD),
1141 <               me.name, source_p->name,
1142 <               "*** This is the short motd ***");
1143 <    sendto_one(source_p, form_str(RPL_ENDOFMOTD),
1144 <               me.name, source_p->name);
825 >    sendto_one_numeric(target_p, &me, RPL_VISIBLEHOST, target_p->host);
826 >    clear_ban_cache_client(target_p);
827    }
1146  else  
1147    send_message_file(source_p, &ConfigFileEntry.motd);
1148 }
828  
829 < /* check_xline()
830 < *
1152 < * inputs       - pointer to client to test
1153 < * outupt       - 1 if exiting 0 if ok
1154 < * side effects -
1155 < */
1156 < static int
1157 < check_xline(struct Client *source_p)
1158 < {
1159 <  struct ConfItem *conf = NULL;
1160 <  const char *reason = NULL;
829 >  if (!ConfigGeneral.cycle_on_host_change)
830 >    return;
831  
832 <  if ((conf = find_matching_name_conf(XLINE_TYPE, source_p->info, NULL, NULL, 0)) ||
1163 <      (conf = find_matching_name_conf(RXLINE_TYPE, source_p->info, NULL, NULL, 0)))
832 >  DLINK_FOREACH(node, target_p->channel.head)
833    {
834 <    struct MatchItem *reg = map_to_conf(conf);
835 <
836 <    ++reg->count;
834 >    char modebuf[4], nickbuf[NICKLEN * 3 + 3] = "";
835 >    char *p = modebuf;
836 >    int len = 0;
837 >    const struct Membership *member = node->data;
838  
839 <    if (reg->reason != NULL)
840 <      reason = reg->reason;
841 <    else
842 <      reason = "No Reason";
839 >    if (has_member_flags(member, CHFL_CHANOP))
840 >    {
841 >      *p++ = 'o';
842 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
843 >    }
844  
845 <    sendto_realops_flags(UMODE_REJ, L_ALL,
846 <                         "X-line Rejecting [%s] [%s], user %s [%s]",
847 <                         source_p->info, reason,
848 <                         get_client_name(source_p, HIDE_IP),
849 <                         source_p->sockhost);
845 >    if (has_member_flags(member, CHFL_HALFOP))
846 >    {
847 >      *p++ = 'h';
848 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
849 >    }
850  
851 <    ++ServerStats.is_ref;
1181 <    if (REJECT_HOLD_TIME > 0)
851 >    if (has_member_flags(member, CHFL_VOICE))
852      {
853 <      sendto_one(source_p, ":%s NOTICE %s :Bad user info",
854 <                 me.name, source_p->name);
1185 <      source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
1186 <      SetCaptured(source_p);
853 >      *p++ = 'v';
854 >      len += snprintf(nickbuf + len, sizeof(nickbuf) - len, len ? " %s" : "%s", target_p->name);
855      }
1188    else
1189      exit_client(source_p, &me, "Bad user info");
1190    return 1;
1191  }
856  
857 <  return 0;
1194 < }
857 >    *p = '\0';
858  
859 < /* oper_up()
860 < *
861 < * inputs       - pointer to given client to oper
862 < * output       - NONE
863 < * side effects - Blindly opers up given source_p, using aconf info
864 < *                all checks on passwords have already been done.
865 < *                This could also be used by rsa oper routines.
859 >
860 >    sendto_channel_local_butone(target_p, CAP_EXTENDED_JOIN, 0, member->chptr, ":%s!%s@%s JOIN %s %s :%s",
861 >                                target_p->name, target_p->username,
862 >                                target_p->host, member->chptr->name,
863 >                                (!IsDigit(target_p->account[0]) && target_p->account[0] != '*') ? target_p->account : "*",
864 >                                target_p->info);
865 >    sendto_channel_local_butone(target_p, 0, CAP_EXTENDED_JOIN, member->chptr, ":%s!%s@%s JOIN :%s",
866 >                                target_p->name, target_p->username,
867 >                                target_p->host, member->chptr->name);
868 >
869 >    if (nickbuf[0])
870 >      sendto_channel_local_butone(target_p, 0, 0, member->chptr, ":%s MODE %s +%s %s",
871 >                                  target_p->servptr->name, member->chptr->name,
872 >                                  modebuf, nickbuf);
873 >
874 >  }
875 >
876 >  if (target_p->away[0])
877 >    sendto_common_channels_local(target_p, 0, CAP_AWAY_NOTIFY,
878 >                                 ":%s!%s@%s AWAY :%s",
879 >                                 target_p->name, target_p->username,
880 >                                 target_p->host, target_p->away);
881 > }
882 >
883 > /*! \brief Blindly opers up given source_p, using conf info.
884 > *         All checks on passwords have already been done.
885 > * \param source_p Pointer to given client to oper
886   */
887   void
888   oper_up(struct Client *source_p)
889   {
890 <  unsigned int old = source_p->umodes;
891 <  const char *operprivs = "";
1209 <  const struct AccessItem *oconf = NULL;
890 >  const unsigned int old = source_p->umodes;
891 >  const struct MaskItem *const conf = source_p->connection->confs.head->data;
892  
893 <  assert(source_p->localClient->confs.head);
1212 <  oconf = map_to_conf((source_p->localClient->confs.head)->data);
893 >  assert(source_p->connection->confs.head);
894  
895    ++Count.oper;
896    SetOper(source_p);
897  
898 <  if (oconf->modes)
899 <    AddUMode(source_p, oconf->modes);
900 <  else if (ConfigFileEntry.oper_umodes)
901 <    AddUMode(source_p, ConfigFileEntry.oper_umodes);
898 >  if (conf->modes)
899 >    AddUMode(source_p, conf->modes);
900 >  else if (ConfigGeneral.oper_umodes)
901 >    AddUMode(source_p, ConfigGeneral.oper_umodes);
902  
903    if (!(old & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
904      ++Count.invisi;
# Line 1227 | Line 908 | oper_up(struct Client *source_p)
908    assert(dlinkFind(&oper_list, source_p) == NULL);
909    dlinkAdd(source_p, make_dlink_node(), &oper_list);
910  
911 <  operprivs = oper_privs_as_string(oconf->port);
911 >  AddOFlag(source_p, conf->port);
912  
913 <  AddOFlag(source_p, oconf->port);
1233 <
1234 <  if (HasOFlag(source_p, OPER_FLAG_HIDDEN_ADMIN|OPER_FLAG_ADMIN))
913 >  if (HasOFlag(source_p, OPER_FLAG_ADMIN))
914      AddUMode(source_p, UMODE_ADMIN);
1236  if (!HasOFlag(source_p, OPER_FLAG_N))
1237    DelUMode(source_p, UMODE_NCHANGE);
915  
916 <  sendto_realops_flags(UMODE_ALL, L_ALL, "%s (%s@%s) is now an operator",
917 <                       source_p->name, source_p->username, source_p->host);
918 <  send_umode_out(source_p, source_p, old);
919 <  sendto_one(source_p, form_str(RPL_YOUREOPER), me.name, source_p->name);
920 <  sendto_one(source_p, ":%s NOTICE %s :*** Oper privs are %s",
921 <             me.name, source_p->name, operprivs);
922 <  send_message_file(source_p, &ConfigFileEntry.opermotd);
916 >  if (!EmptyString(conf->whois))
917 >  {
918 >    client_attach_svstag(source_p, RPL_WHOISOPERATOR, "+", conf->whois);
919 >    sendto_server(source_p, 0, 0, ":%s SVSTAG %s %lu %u + :%s",
920 >                  me.id, source_p->id, (unsigned long)source_p->tsinfo,
921 >                  RPL_WHOISOPERATOR, conf->whois);
922 >  }
923 >
924 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
925 >                       get_oper_name(source_p));
926 >  sendto_server(NULL, 0, 0, ":%s GLOBOPS :%s is now an operator",
927 >                me.id, get_oper_name(source_p));
928 >  send_umode_out(source_p, old);
929 >  sendto_one_numeric(source_p, &me, RPL_YOUREOPER);
930   }
931  
932 < static char new_uid[TOTALSIDUID + 1];     /* allow for \0 */
932 > static char new_uid[TOTALSIDUID + 1];  /* Allow for \0 */
933  
934   int
935   valid_sid(const char *sid)
# Line 1260 | Line 944 | valid_sid(const char *sid)
944  
945   /*
946   * init_uid()
947 < *
947 > *
948   * inputs       - NONE
949   * output       - NONE
950   * side effects - new_uid is filled in with server id portion (sid)
# Line 1270 | Line 954 | valid_sid(const char *sid)
954   void
955   init_uid(void)
956   {
1273  int i;
1274
957    memset(new_uid, 0, sizeof(new_uid));
958  
959 <  if (!EmptyString(ServerInfo.sid))
960 <    strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
959 >  if (!EmptyString(ConfigServerInfo.sid))
960 >    strlcpy(new_uid, ConfigServerInfo.sid, sizeof(new_uid));
961  
962 <  for (i = 0; i < IRC_MAXSID; ++i)
963 <    if (new_uid[i] == '\0')
962 >  for (unsigned int i = 0; i < IRC_MAXSID; ++i)
963 >    if (new_uid[i] == '\0')
964        new_uid[i] = 'A';
965  
966    /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1285  /* Yes nenolod, I have known it was off by one ever since I wrote it
1286   * But *JUST* for you, though, it really doesn't look as *pretty*
1287   * -Dianora
1288   */
967    memcpy(new_uid + IRC_MAXSID, "AAAAA@", IRC_MAXUID);
1290
1291  entering_umode_cb = register_callback("entering_umode", NULL);
1292  umode_cb = register_callback("changing_umode", change_simple_umode);
968   }
969  
970   /*
# Line 1301 | Line 976 | init_uid(void)
976   *                note this is a recursive function
977   */
978   static void
979 < add_one_to_uid(int i)
979 > add_one_to_uid(unsigned int i)
980   {
981 <  if (i != IRC_MAXSID)    /* Not reached server SID portion yet? */
981 >  if (i != IRC_MAXSID)  /* Not reached server SID portion yet? */
982    {
983      if (new_uid[i] == 'Z')
984        new_uid[i] = '0';
985      else if (new_uid[i] == '9')
986      {
987        new_uid[i] = 'A';
988 <      add_one_to_uid(i-1);
988 >      add_one_to_uid(i - 1);
989      }
990      else
991        ++new_uid[i];
# Line 1335 | Line 1010 | add_one_to_uid(int i)
1010   static const char *
1011   uid_get(void)
1012   {
1013 <  add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1013 >  add_one_to_uid(TOTALSIDUID - 1);  /* Index from 0 */
1014    return new_uid;
1015   }
1016  
# Line 1349 | Line 1024 | uid_get(void)
1024   void
1025   init_isupport(void)
1026   {
1352  isupportFile = init_MessageLine();
1353
1027    add_isupport("CALLERID", NULL, -1);
1028 <  add_isupport("CASEMAPPING", CASEMAP, -1);
1028 >  add_isupport("CASEMAPPING", "rfc1459", -1);
1029    add_isupport("DEAF", "D", -1);
1030    add_isupport("KICKLEN", NULL, KICKLEN);
1031    add_isupport("MODES", NULL, MAXMODEPARAMS);
1359  add_isupport("NICKLEN", NULL, NICKLEN-1);
1360 #ifdef HALFOPS
1032    add_isupport("PREFIX", "(ohv)@%+", -1);
1033    add_isupport("STATUSMSG", "@%+", -1);
1034 < #else
1035 <  add_isupport("PREFIX", "(ov)@+", -1);
1365 <  add_isupport("STATUSMSG", "@+", -1);
1366 < #endif
1367 <  add_isupport("TOPICLEN", NULL, TOPICLEN);
1034 >  add_isupport("EXCEPTS", NULL, -1);
1035 >  add_isupport("INVEX", NULL, -1);
1036   }
1037  
1038   /*
# Line 1379 | Line 1047 | init_isupport(void)
1047   void
1048   add_isupport(const char *name, const char *options, int n)
1049   {
1050 <  dlink_node *ptr;
1051 <  struct Isupport *support;
1050 >  dlink_node *node = NULL;
1051 >  struct Isupport *support = NULL;
1052  
1053 <  DLINK_FOREACH(ptr, support_list.head)
1053 >  DLINK_FOREACH(node, support_list.head)
1054    {
1055 <    support = ptr->data;
1055 >    support = node->data;
1056      if (irccmp(support->name, name) == 0)
1057      {
1058        MyFree(support->name);
# Line 1393 | Line 1061 | add_isupport(const char *name, const cha
1061      }
1062    }
1063  
1064 <  if (ptr == NULL)
1064 >  if (node == NULL)
1065    {
1066 <    support = MyMalloc(sizeof(*support));
1066 >    support = MyCalloc(sizeof(*support));
1067      dlinkAddTail(support, &support->node, &support_list);
1068    }
1069  
1070 <  DupString(support->name, name);
1071 <  if (options != NULL)
1072 <    DupString(support->options, options);
1070 >  support->name = xstrdup(name);
1071 >  if (options)
1072 >    support->options = xstrdup(options);
1073    support->number = n;
1074  
1075    rebuild_isupport_message_line();
# Line 1417 | Line 1085 | add_isupport(const char *name, const cha
1085   void
1086   delete_isupport(const char *name)
1087   {
1088 <  dlink_node *ptr;
1421 <  struct Isupport *support;
1088 >  dlink_node *node = NULL;
1089  
1090 <  DLINK_FOREACH(ptr, support_list.head)
1090 >  DLINK_FOREACH(node, support_list.head)
1091    {
1092 <    support = ptr->data;
1092 >    struct Isupport *support = node->data;
1093 >
1094      if (irccmp(support->name, name) == 0)
1095      {
1096 <      dlinkDelete(ptr, &support_list);
1096 >      dlinkDelete(node, &support_list);
1097        MyFree(support->name);
1098        MyFree(support->options);
1099        MyFree(support);
# Line 1448 | Line 1116 | rebuild_isupport_message_line(void)
1116   {
1117    char isupportbuffer[IRCD_BUFSIZE];
1118    char *p = isupportbuffer;
1119 <  dlink_node *ptr = NULL;
1119 >  dlink_node *node = NULL, *node_next = NULL;
1120    int n = 0;
1121    int tokens = 0;
1122    size_t len = 0;
1123 <  size_t reserve = strlen(me.name) + HOSTLEN + strlen(form_str(RPL_ISUPPORT));
1123 >  size_t reserve = strlen(me.name) + HOSTLEN + strlen(numeric_form(RPL_ISUPPORT));
1124  
1125 <  destroy_MessageLine(isupportFile);
1125 >  DLINK_FOREACH_SAFE(node, node_next, support_list_lines.head)
1126 >  {
1127 >    dlinkDelete(node, &support_list_lines);
1128 >    MyFree(node->data);
1129 >    free_dlink_node(node);
1130 >  }
1131  
1132 <  DLINK_FOREACH(ptr, support_list.head)
1132 >  DLINK_FOREACH(node, support_list.head)
1133    {
1134 <    struct Isupport *support = ptr->data;
1134 >    struct Isupport *support = node->data;
1135  
1136 <    p += (n = ircsprintf(p, "%s", support->name));
1136 >    p += (n = sprintf(p, "%s", support->name));
1137      len += n;
1138  
1139 <    if (support->options != NULL)
1139 >    if (support->options)
1140      {
1141 <      p += (n = ircsprintf(p, "=%s", support->options));
1141 >      p += (n = sprintf(p, "=%s", support->options));
1142        len += n;
1143      }
1144  
1145      if (support->number > 0)
1146      {
1147 <      p += (n = ircsprintf(p, "=%d", support->number));
1147 >      p += (n = sprintf(p, "=%d", support->number));
1148        len += n;
1149      }
1150  
# Line 1484 | Line 1157 | rebuild_isupport_message_line(void)
1157        if (*--p == ' ')
1158          *p = '\0';
1159  
1160 <      addto_MessageLine(isupportFile, isupportbuffer);
1160 >      dlinkAddTail(xstrdup(isupportbuffer), make_dlink_node(), &support_list_lines);
1161        p = isupportbuffer;
1162        len = 0;
1163        n = tokens = 0;
1164      }
1165    }
1166  
1167 <  if (len != 0)
1167 >  if (len)
1168    {
1169      if (*--p == ' ')
1170        *p = '\0';
1171 <    addto_MessageLine(isupportFile, isupportbuffer);
1171 >    dlinkAddTail(xstrdup(isupportbuffer), make_dlink_node(), &support_list_lines);
1172    }
1173   }

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)