ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/user.c
(Generate patch)

Comparing:
ircd-hybrid-7.2/src/s_user.c (file contents), Revision 896 by michael, Sat Nov 3 08:54:09 2007 UTC vs.
ircd-hybrid-8/src/s_user.c (file contents), Revision 1165 by michael, Thu Aug 11 18:56:53 2011 UTC

# Line 23 | Line 23
23   */
24  
25   #include "stdinc.h"
26 < #include "tools.h"
26 > #include "list.h"
27   #include "s_user.h"
28   #include "s_misc.h"
29   #include "channel.h"
# Line 36 | Line 36
36   #include "sprintf_irc.h"
37   #include "s_bsd.h"
38   #include "ircd.h"
39 #include "list.h"
39   #include "listener.h"
40   #include "motd.h"
41   #include "numeric.h"
# Line 48 | Line 47
47   #include "whowas.h"
48   #include "memory.h"
49   #include "packet.h"
50 + #include "rng_mt.h"
51   #include "userhost.h"
52   #include "hook.h"
53   #include "s_misc.h"
54   #include "msg.h"
55 #include "pcre.h"
55   #include "watch.h"
56  
57 < int MaxClientCount     = 1;
59 < int MaxConnectionCount = 1;
57 >
58   struct Callback *entering_umode_cb = NULL;
59   struct Callback *umode_cb = NULL;
62 struct Callback *uid_get_cb = NULL;
60  
61   static char umode_buffer[IRCD_BUFSIZE];
62  
63   static void user_welcome(struct Client *);
64   static void report_and_set_user_flags(struct Client *, const struct AccessItem *);
65   static int check_xline(struct Client *);
66 < static void introduce_client(struct Client *, struct Client *);
67 < static void *uid_get(va_list);
66 > static void introduce_client(struct Client *);
67 > static const char *uid_get(void);
68  
69   /* Used for building up the isupport string,
70   * used with init_isupport, add_isupport, delete_isupport
# Line 129 | Line 126 | unsigned int user_modes[256] =
126    UMODE_CALLERID,     /* g */
127    0,                  /* h */
128    UMODE_INVISIBLE,    /* i */
129 <  0,                  /* j */
129 >  UMODE_REJ,          /* j */
130    UMODE_SKILL,        /* k */
131    UMODE_LOCOPS,       /* l */
132    0,                  /* m */
# Line 137 | Line 134 | unsigned int user_modes[256] =
134    UMODE_OPER,         /* o */
135    0,                  /* p */
136    0,                  /* q */
137 <  UMODE_REJ,          /* r */
137 >  UMODE_REGISTERED,   /* r */
138    UMODE_SERVNOTICE,   /* s */
139    0,                  /* t */
140    UMODE_UNAUTH,       /* u */
# Line 164 | Line 161 | assemble_umode_buffer(void)
161    unsigned int idx = 0;
162    char *umode_buffer_ptr = umode_buffer;
163  
164 <  for (; idx < (sizeof(user_modes) / sizeof(int)); ++idx)
164 >  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
165      if (user_modes[idx])
166        *umode_buffer_ptr++ = idx;
167  
# Line 236 | Line 233 | show_lusers(struct Client *source_p)
233  
234    if (!ConfigServerHide.hide_servers || IsOper(source_p))
235      sendto_one(source_p, form_str(RPL_STATSCONN), from, to,
236 <               MaxConnectionCount, MaxClientCount, Count.totalrestartcount);
236 >               Count.max_loc_con, Count.max_loc_cli, Count.totalrestartcount);
237  
238 <  if (Count.local > MaxClientCount)
239 <    MaxClientCount = Count.local;
238 >  if (Count.local > Count.max_loc_cli)
239 >    Count.max_loc_cli = Count.local;
240  
241 <  if ((Count.local + Count.myserver) > MaxConnectionCount)
242 <    MaxConnectionCount = Count.local + Count.myserver;
241 >  if ((Count.local + Count.myserver) > Count.max_loc_con)
242 >    Count.max_loc_con = Count.local + Count.myserver;
243   }
244  
245   /* show_isupport()
# Line 281 | Line 278 | show_isupport(struct Client *source_p)
278   **         nick from local user or kill him/her...
279   */
280   void
281 < register_local_user(struct Client *client_p, struct Client *source_p,
285 <                    const char *nick, const char *username)
281 > register_local_user(struct Client *source_p)
282   {
283 +  const char *id = NULL;
284    const struct AccessItem *aconf = NULL;
285    dlink_node *ptr = NULL;
289  dlink_node *m = NULL;
286  
287    assert(source_p != NULL);
288 +  assert(source_p == source_p->from);
289    assert(MyConnect(source_p));
293  assert(source_p->username != username);
290    assert(!source_p->localClient->registration);
291  
292 <  ClearCap(client_p, CAP_TS6);
292 >  ClearCap(source_p, CAP_TS6);
293  
294    if (ConfigFileEntry.ping_cookie)
295    {
296 <    if (!IsPingSent(source_p) &&
301 <       source_p->localClient->random_ping == 0)
296 >    if (!IsPingSent(source_p) && source_p->localClient->random_ping == 0)
297      {
298 <      source_p->localClient->random_ping = (unsigned long)rand();
299 <      sendto_one(source_p, "PING :%lu",
298 >      do
299 >        source_p->localClient->random_ping = genrand_int32();
300 >      while (!source_p->localClient->random_ping);
301 >
302 >      sendto_one(source_p, "PING :%u",
303                   source_p->localClient->random_ping);
304        SetPingSent(source_p);
305        return;
# Line 315 | Line 313 | register_local_user(struct Client *clien
313    /* Straight up the maximum rate of flooding... */
314    source_p->localClient->allow_read = MAX_FLOOD_BURST;
315  
316 <  if (!execute_callback(client_check_cb, source_p, username))
316 >  if (!execute_callback(client_check_cb, source_p, source_p->username))
317      return;
318  
319    if (valid_hostname(source_p->host) == 0)
# Line 331 | Line 329 | register_local_user(struct Client *clien
329  
330    if (!IsGotId(source_p))
331    {
332 <    const char *p = NULL;
332 >    char username[USERLEN + 1];
333 >    const char *p = username;
334      unsigned int i = 0;
335  
336      if (IsNeedIdentd(aconf))
# Line 343 | Line 342 | register_local_user(struct Client *clien
342        return;
343      }
344  
345 <    p = username;
345 >    strlcpy(username, source_p->username, sizeof(username));
346  
347      if (!IsNoTilde(aconf))
348        source_p->username[i++] = '~';
349  
350 <    while (*p && i < USERLEN)
352 <    {
350 >    for (; *p && i < USERLEN; ++p)
351        if (*p != '[')
352          source_p->username[i++] = *p;
355      p++;
356    }
353  
354      source_p->username[i] = '\0';
355    }
# Line 381 | Line 377 | register_local_user(struct Client *clien
377    /* report if user has &^>= etc. and set flags as needed in source_p */
378    report_and_set_user_flags(source_p, aconf);
379  
380 +  if (IsDead(source_p))
381 +    return;
382 +
383    /* Limit clients -
384     * We want to be able to have servers and F-line clients
385     * connect, so save room for "buffer" connections.
# Line 394 | Line 393 | register_local_user(struct Client *clien
393    {
394      sendto_realops_flags(UMODE_FULL, L_ALL,
395                           "Too many clients, rejecting %s[%s].",
396 <                         nick, source_p->host);
396 >                         source_p->name, source_p->host);
397      ++ServerStats.is_ref;
398      exit_client(source_p, &me, "Sorry, server is full - try later");
399      return;
# Line 406 | Line 405 | register_local_user(struct Client *clien
405      char tmpstr2[IRCD_BUFSIZE];
406  
407      sendto_realops_flags(UMODE_REJ, L_ALL, "Invalid username: %s (%s@%s)",
408 <                         nick, source_p->username, source_p->host);
408 >                         source_p->name, source_p->username, source_p->host);
409      ++ServerStats.is_ref;
410 <    ircsprintf(tmpstr2, "Invalid username [%s]", source_p->username);
410 >    snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
411 >             source_p->username);
412      exit_client(source_p, &me, tmpstr2);
413      return;
414    }
415  
416  assert(source_p == client_p);
417
416    if (check_xline(source_p))
417      return;
418  
419 <  if (IsDead(client_p))
420 <    return;
423 <
424 <  if (me.id[0])
425 <  {
426 <    const char *id = execute_callback(uid_get_cb, source_p);
427 <
428 <    while (hash_find_id(id) != NULL)
429 <      id = uid_get(NULL);
419 >  while (hash_find_id((id = uid_get())) != NULL)
420 >    ;
421  
422 <    strlcpy(source_p->id, id, sizeof(source_p->id));
423 <    hash_add_id(source_p);
433 <  }
422 >  strlcpy(source_p->id, id, sizeof(source_p->id));
423 >  hash_add_id(source_p);
424  
425    sendto_realops_flags(UMODE_CCONN, L_ALL,
426 <                       "Client connecting: %s (%s@%s) [%s] {%s} [%s]",
427 <                       nick, source_p->username, source_p->host,
426 >                       "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
427 >                       source_p->name, source_p->username, source_p->host,
428                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
429                         "255.255.255.255" : source_p->sockhost,
430                         get_client_class(source_p),
431 <                       source_p->info);
431 >                       source_p->info, source_p->id);
432  
433    sendto_realops_flags(UMODE_CCONN_FULL, L_ALL,
434                         "CLICONN %s %s %s %s %s %s %s 0 %s",
435 <                       nick, source_p->username, source_p->host,
435 >                       source_p->name, source_p->username, source_p->host,
436                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
437                         "255.255.255.255" : source_p->sockhost,
438                         get_client_class(source_p),
439                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
440 <                           "<hidden>" : source_p->client_host,
440 >                           "<hidden>" : source_p->localClient->client_host,
441                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
442 <                           "<hidden>" : source_p->client_server,
442 >                           "<hidden>" : source_p->localClient->client_server,
443                         source_p->info);
444  
445  
456  /* If they have died in send_* don't do anything. */
457  if (IsDead(source_p))
458    return;
459
446    if (ConfigFileEntry.invisible_on_connect)
447    {
448      source_p->umodes |= UMODE_INVISIBLE;
449 <    Count.invisi++;
449 >    ++Count.invisi;
450    }
451  
452    if ((++Count.local) > Count.max_loc)
# Line 472 | Line 458 | register_local_user(struct Client *clien
458                             Count.max_loc);
459    }
460  
475  SetClient(source_p);
476
477  source_p->servptr = &me;
478  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
479
461    /* Increment our total user count here */
462    if (++Count.total > Count.max_tot)
463      Count.max_tot = Count.total;
464 <  Count.totalrestartcount++;
464 >  ++Count.totalrestartcount;
465 >
466 >  assert(source_p->servptr == &me);
467 >  SetClient(source_p);
468 >  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
469  
470    source_p->localClient->allow_read = MAX_FLOOD_BURST;
471  
472 <  if ((m = dlinkFindDelete(&unknown_list, source_p)) != NULL)
473 <  {
474 <    free_dlink_node(m);
475 <    dlinkAdd(source_p, &source_p->localClient->lclient_node, &local_client_list);
491 <  }
492 <  else assert(0);
472 >  assert(dlinkFind(&unknown_list, source_p));
473 >
474 >  dlink_move_node(&source_p->localClient->lclient_node,
475 >                  &unknown_list, &local_client_list);
476  
477    user_welcome(source_p);
478    add_user_host(source_p->username, source_p->host, 0);
479    SetUserHost(source_p);
480  
481 <  introduce_client(client_p, source_p);
481 >  introduce_client(source_p);
482   }
483  
484   /* register_remote_user()
485   *
486 < * inputs       - client_p directly connected client
504 < *              - source_p remote or directly connected client
486 > * inputs       - source_p remote or directly connected client
487   *              - username to register as
488   *              - host name to register as
489   *              - server name
# Line 511 | Line 493 | register_local_user(struct Client *clien
493   *                is introduced by a server.
494   */
495   void
496 < register_remote_user(struct Client *client_p, struct Client *source_p,
496 > register_remote_user(struct Client *source_p,
497                       const char *username, const char *host, const char *server,
498                       const char *realname)
499   {
# Line 521 | Line 503 | register_remote_user(struct Client *clie
503    assert(source_p->username != username);
504  
505    strlcpy(source_p->host, host, sizeof(source_p->host));
524  strlcpy(source_p->info, realname, sizeof(source_p->info));
506    strlcpy(source_p->username, username, sizeof(source_p->username));
507  
508    /*
# Line 539 | Line 520 | register_remote_user(struct Client *clie
520                           "No server %s for user %s[%s@%s] from %s",
521                           server, source_p->name, source_p->username,
522                           source_p->host, source_p->from->name);
523 <    kill_client(client_p, source_p, "%s (Server doesn't exist)", me.name);
523 >    kill_client(source_p->from, source_p, "%s (Server doesn't exist)", me.name);
524  
525      SetKilled(source_p);
526      exit_client(source_p, &me, "Ghosted Client");
# Line 550 | Line 531 | register_remote_user(struct Client *clie
531    {
532      sendto_realops_flags(UMODE_DEBUG, L_ALL,
533                           "Bad User [%s] :%s USER %s@%s %s, != %s[%s]",
534 <                         client_p->name, source_p->name, source_p->username,
534 >                         source_p->from->name, source_p->name, source_p->username,
535                           source_p->host, source_p->servptr->name,
536                           target_p->name, target_p->from->name);
537 <    kill_client(client_p, source_p,
537 >    kill_client(source_p->from, source_p,
538                  "%s (NICK from wrong direction (%s != %s))",
539                  me.name, source_p->servptr->name, target_p->from->name);
540      SetKilled(source_p);
# Line 570 | Line 551 | register_remote_user(struct Client *clie
551    add_user_host(source_p->username, source_p->host, 1);
552    SetUserHost(source_p);
553  
554 <  introduce_client(client_p, source_p);
554 >  introduce_client(source_p);
555   }
556  
557   /* introduce_client()
558   *
559 < * inputs       - client_p
579 < *              - source_p
559 > * inputs       - source_p
560   * output       - NONE
561   * side effects - This common function introduces a client to the rest
562   *                of the net, either from a local client connect or
563   *                from a remote connect.
564   */
565   static void
566 < introduce_client(struct Client *client_p, struct Client *source_p)
566 > introduce_client(struct Client *source_p)
567   {
568    dlink_node *server_node = NULL;
569    static char ubuf[12];
# Line 605 | Line 585 | introduce_client(struct Client *client_p
585    {
586      struct Client *server = server_node->data;
587  
588 <    if (server == client_p)
588 >    if (server == source_p->from)
589          continue;
590  
591      if (IsCapable(server, CAP_TS6) && HasID(source_p))
# Line 641 | Line 621 | valid_hostname(const char *hostname)
621  
622    assert(p != NULL);
623  
624 <  if ('.' == *p || ':' == *p)
624 >  if (*p == '.' || *p == ':')
625      return 0;
626  
627 <  while (*p)
648 <  {
627 >  for (; *p; ++p)
628      if (!IsHostChar(*p))
629        return 0;
651    p++;
652  }
630  
631    return 1;
632   }
# Line 673 | Line 650 | valid_username(const char *username)
650  
651    assert(p != NULL);
652  
653 <  if ('~' == *p)
653 >  if (*p == '~')
654      ++p;
655  
656    /* reject usernames that don't start with an alphanum
# Line 687 | Line 664 | valid_username(const char *username)
664    {
665      if ((*p == '.') && ConfigFileEntry.dots_in_ident)
666      {
667 <      dots++;
691 <
692 <      if (dots > ConfigFileEntry.dots_in_ident)
667 >      if (++dots > ConfigFileEntry.dots_in_ident)
668          return 0;
669 <      if (!IsUserChar(p[1]))
669 >      if (!IsUserChar(*(p + 1)))
670          return 0;
671      }
672      else if (!IsUserChar(*p))
# Line 701 | Line 676 | valid_username(const char *username)
676    return 1;
677   }
678  
679 + /* clean_nick_name()
680 + *
681 + * input        - nickname
682 + *              - whether it's a local nick (1) or remote (0)
683 + * output       - none
684 + * side effects - walks through the nickname, returning 0 if erroneous
685 + */
686 + int
687 + valid_nickname(const char *nickname, const int local)
688 + {
689 +  const char *p = nickname;
690 +  assert(nickname && *nickname);
691 +
692 +  /* nicks can't start with a digit or - or be 0 length */
693 +  /* This closer duplicates behaviour of hybrid-6 */
694 +  if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
695 +    return 0;
696 +
697 +  for (; *p; ++p)
698 +    if (!IsNickChar(*p))
699 +      return 0;
700 +
701 +  return p - nickname <= (NICKLEN - 1);
702 + }
703 +
704   /* report_and_set_user_flags()
705   *
706   * inputs       - pointer to source_p
# Line 773 | Line 773 | report_and_set_user_flags(struct Client
773    }
774   }
775  
776 /* do_local_user()
777 *
778 * inputs       -
779 * output       - NONE
780 * side effects -
781 */
782 void
783 do_local_user(const char *nick, struct Client *client_p, struct Client *source_p,
784              const char *username, const char *host, const char *server,
785              const char *realname)
786 {
787  assert(source_p != NULL);
788  assert(source_p->username != username);
789
790  if (source_p == NULL)
791    return;
792
793  if (!IsUnknown(source_p))
794  {
795    sendto_one(source_p, form_str(ERR_ALREADYREGISTRED),
796               me.name, nick);
797    return;
798  }
799
800  source_p->localClient->registration &= ~REG_NEED_USER;
801
802  /*
803   * don't take the clients word for it, ever
804   */
805  source_p->servptr = &me;
806
807  strlcpy(source_p->info, realname, sizeof(source_p->info));
808
809  /* stash for later */
810  strlcpy(source_p->client_host, host, sizeof(source_p->client_host));
811  strlcpy(source_p->client_server, server, sizeof(source_p->client_server));
812
813  if (!IsGotId(source_p))
814  {
815    /* save the username in the client
816     * If you move this you'll break ping cookies..you've been warned
817     */
818    strlcpy(source_p->username, username, sizeof(source_p->username));
819  }
820
821  if (!source_p->localClient->registration)
822    /* NICK already received, now I have USER... */
823    register_local_user(client_p, source_p, source_p->name, username);
824 }
825
776   /* change_simple_umode()
777   *
778   * this callback can be hooked to allow special handling of
# Line 882 | Line 832 | set_user_mode(struct Client *client_p, s
832       return;
833    }
834  
835 <  if (source_p != target_p || target_p->from != source_p->from)
835 >  if (source_p != target_p)
836    {
837       sendto_one(source_p, form_str(ERR_USERSDONTMATCH),
838                  me.name, source_p->name);
# Line 940 | Line 890 | set_user_mode(struct Client *client_p, s
890                break;
891  
892              ClearOper(source_p);
943            source_p->umodes &= ~ConfigFileEntry.oper_only_umodes;
893              Count.oper--;
894  
895              if (MyConnect(source_p))
# Line 949 | Line 898 | set_user_mode(struct Client *client_p, s
898  
899                detach_conf(source_p, OPER_TYPE);
900                ClearOperFlags(source_p);
901 +              source_p->umodes &= ~ConfigFileEntry.oper_only_umodes;
902  
903                if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
904                  free_dlink_node(dm);
# Line 960 | Line 910 | set_user_mode(struct Client *client_p, s
910          /* we may not get these,
911           * but they shouldnt be in default
912           */
913 +        case 'r':
914          case ' ' :
915          case '\n':
916          case '\r':
# Line 992 | Line 943 | set_user_mode(struct Client *client_p, s
943      sendto_one(source_p, form_str(ERR_UMODEUNKNOWNFLAG),
944                 me.name, source_p->name);
945  
946 <  if ((source_p->umodes & UMODE_NCHANGE) && !IsOperN(source_p))
946 >  if (HasUMode(source_p, UMODE_NCHANGE) && !IsOperN(source_p))
947    {
948      sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
949                 me.name, source_p->name);
950 <    source_p->umodes &= ~UMODE_NCHANGE; /* only tcm's really need this */
950 >    DelUMode(source_p, UMODE_NCHANGE); /* only tcm's really need this */
951    }
952  
953    if (MyConnect(source_p) && (source_p->umodes & UMODE_ADMIN) &&
# Line 1034 | Line 985 | void
985   send_umode(struct Client *client_p, struct Client *source_p,
986             unsigned int old, unsigned int sendmask, char *umode_buf)
987   {
988 +  char *m = umode_buf;
989    int what = 0;
990    unsigned int i;
991    unsigned int flag;
1040  char *m = umode_buf;
992  
993    /*
994     * build a string in umode_buf to represent the change in the user's
# Line 1157 | Line 1108 | user_welcome(struct Client *source_p)
1108  
1109    if (ConfigFileEntry.short_motd)
1110    {
1111 <    sendto_one(source_p, "NOTICE %s :*** Notice -- motd was last changed at %s",
1112 <               source_p->name, ConfigFileEntry.motd.lastChangedDate);
1111 >    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- motd was last changed at %s",
1112 >               me.name, source_p->name, ConfigFileEntry.motd.lastChangedDate);
1113      sendto_one(source_p,
1114 <               "NOTICE %s :*** Notice -- Please read the motd if you haven't "
1115 <               "read it", source_p->name);
1114 >               ":%s NOTICE %s :*** Notice -- Please read the motd if you haven't "
1115 >               "read it", me.name, source_p->name);
1116      sendto_one(source_p, form_str(RPL_MOTDSTART),
1117                 me.name, source_p->name, me.name);
1118      sendto_one(source_p, form_str(RPL_MOTD),
# Line 1262 | Line 1213 | oper_up(struct Client *source_p)
1213    SetOFlag(source_p, oconf->port);
1214  
1215    if (IsOperAdmin(source_p) || IsOperHiddenAdmin(source_p))
1216 <    source_p->umodes |= UMODE_ADMIN;
1216 >    AddUMode(source_p, UMODE_ADMIN);
1217    if (!IsOperN(source_p))
1218 <    source_p->umodes &= ~UMODE_NCHANGE;
1218 >    DelUMode(source_p, UMODE_NCHANGE);
1219  
1220    sendto_realops_flags(UMODE_ALL, L_ALL, "%s (%s@%s) is now an operator",
1221                         source_p->name, source_p->username, source_p->host);
# Line 1280 | Line 1231 | static char new_uid[TOTALSIDUID + 1];
1231   int
1232   valid_sid(const char *sid)
1233   {
1283
1234    if (strlen(sid) == IRC_MAXSID)
1235      if (IsDigit(*sid))
1236        if (IsAlNum(*(sid + 1)) && IsAlNum(*(sid + 2)))
# Line 1305 | Line 1255 | init_uid(void)
1255  
1256    memset(new_uid, 0, sizeof(new_uid));
1257  
1258 <  if (ServerInfo.sid != NULL)
1309 <  {
1258 >  if (!EmptyString(ServerInfo.sid))
1259      strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1311    strlcpy(me.id, ServerInfo.sid, sizeof(me.id));
1260  
1261 <    hash_add_id(&me);
1314 <  }
1315 <
1316 <  for (i = 0; i < IRC_MAXSID; i++)
1261 >  for (i = 0; i < IRC_MAXSID; ++i)
1262      if (new_uid[i] == '\0')
1263        new_uid[i] = 'A';
1264  
# Line 1326 | Line 1271 | init_uid(void)
1271  
1272    entering_umode_cb = register_callback("entering_umode", NULL);
1273    umode_cb = register_callback("changing_umode", change_simple_umode);
1329  uid_get_cb = register_callback("uid_get", uid_get);
1274   }
1275  
1276   /*
# Line 1369 | Line 1313 | add_one_to_uid(int i)
1313   * output       - new UID is returned to caller
1314   * side effects - new_uid is incremented by one.
1315   */
1316 < static void *
1317 < uid_get(va_list args)
1316 > static const char *
1317 > uid_get(void)
1318   {
1319    add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1320    return new_uid;

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)