ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/server.c
(Generate patch)

Comparing:
ircd-hybrid-8/src/s_serv.c (file contents), Revision 1325 by michael, Sat Mar 31 10:29:02 2012 UTC vs.
ircd-hybrid/trunk/src/server.c (file contents), Revision 8500 by michael, Thu Apr 5 13:00:49 2018 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_serv.c: Server related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2005 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2018 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 16 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file server.c
23 > * \brief Server related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
26 #ifdef HAVE_LIBCRYPTO
27 #include <openssl/rsa.h>
28 #include "rsa.h"
29 #endif
28   #include "list.h"
31 #include "channel.h"
32 #include "channel_mode.h"
29   #include "client.h"
34 #include "dbuf.h"
30   #include "event.h"
36 #include "fdlist.h"
31   #include "hash.h"
32   #include "irc_string.h"
39 #include "sprintf_irc.h"
33   #include "ircd.h"
34   #include "ircd_defs.h"
35   #include "s_bsd.h"
43 #include "numeric.h"
36   #include "packet.h"
45 #include "irc_res.h"
37   #include "conf.h"
38 < #include "s_serv.h"
38 > #include "server.h"
39 > #include "server_capab.h"
40   #include "log.h"
49 #include "s_misc.h"
50 #include "s_user.h"
41   #include "send.h"
42   #include "memory.h"
53 #include "channel.h" /* chcap_usage_counts stuff...*/
43   #include "parse.h"
44  
56 #define MIN_CONN_FREQ 300
45  
46 < static dlink_list cap_list = { NULL, NULL, 0 };
47 < static void server_burst(struct Client *);
60 < static void burst_all(struct Client *);
61 < static void send_tb(struct Client *client_p, struct Channel *chptr);
46 > dlink_list flatten_links;
47 > static void server_connect_callback(fde_t *, int, void *);
48  
63 static CNCB serv_connect_callback;
64
65 static void burst_members(struct Client *, struct Channel *);
49  
50   /*
51   * write_links_file
# Line 73 | Line 56 | static void burst_members(struct Client
56   *                but in no particular order.
57   */
58   void
59 < write_links_file(void* notused)
59 > write_links_file(void *unused)
60   {
61 <  MessageFileLine *next_mptr = 0;
62 <  MessageFileLine *mptr = 0;
63 <  MessageFileLine *currentMessageLine = 0;
81 <  MessageFileLine *newMessageLine = 0;
82 <  MessageFile *MessageFileptr;
83 <  const char *p;
84 <  FILE *file;
85 <  char buff[512];
86 <  dlink_node *ptr;
87 <
88 <  MessageFileptr = &ConfigFileEntry.linksfile;
61 >  FILE *file = NULL;
62 >  dlink_node *node, *node_next;
63 >  char buff[IRCD_BUFSIZE] = "";
64  
65 <  if ((file = fopen(MessageFileptr->fileName, "w")) == NULL)
65 >  if (EmptyString(ConfigServerHide.flatten_links_file))
66      return;
67  
68 <  for (mptr = MessageFileptr->contentsOfFile; mptr; mptr = next_mptr)
68 >  if ((file = fopen(ConfigServerHide.flatten_links_file, "w")) == NULL)
69    {
70 <    next_mptr = mptr->next;
71 <    MyFree(mptr);
70 >    ilog(LOG_TYPE_IRCD, "Couldn't open \"%s\": %s", ConfigServerHide.flatten_links_file,
71 >         strerror(errno));
72 >    return;
73    }
74  
75 <  MessageFileptr->contentsOfFile = NULL;
76 <  currentMessageLine             = NULL;
75 >  DLINK_FOREACH_SAFE(node, node_next, flatten_links.head)
76 >  {
77 >    dlinkDelete(node, &flatten_links);
78 >    xfree(node->data);
79 >    free_dlink_node(node);
80 >  }
81  
82 <  DLINK_FOREACH(ptr, global_serv_list.head)
82 >  DLINK_FOREACH(node, global_server_list.head)
83    {
84 <    const struct Client *target_p = ptr->data;
84 >    const struct Client *target_p = node->data;
85  
86 <    /* skip ourselves, we send ourselves in /links */
87 <    if (IsMe(target_p))
86 >    /*
87 >     * Skip hidden servers, aswell as ourselves, since we already send
88 >     * ourselves in /links
89 >     */
90 >    if (IsHidden(target_p) || IsMe(target_p))
91        continue;
92  
93 <    /* skip hidden servers */
111 <    if (IsHidden(target_p) && !ConfigServerHide.disable_hidden)
93 >    if (HasFlag(target_p, FLAGS_SERVICE) && ConfigServerHide.hide_services)
94        continue;
95  
96 <    if (target_p->info[0])
97 <      p = target_p->info;
116 <    else
117 <      p = "(Unknown Location)";
118 <
119 <    newMessageLine = MyMalloc(sizeof(MessageFileLine));
120 <
121 <    /* Attempt to format the file in such a way it follows the usual links output
96 >    /*
97 >     * Attempt to format the file in such a way it follows the usual links output
98       * ie  "servername uplink :hops info"
99       * Mostly for aesthetic reasons - makes it look pretty in mIRC ;)
100       * - madmax
101       */
102 +    snprintf(buff, sizeof(buff), "%s %s :1 %s",   target_p->name,
103 +             me.name, target_p->info);
104 +    dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
105 +    snprintf(buff, sizeof(buff), "%s %s :1 %s\n", target_p->name,
106 +             me.name, target_p->info);
107  
108 <    /*
109 <     * For now, check this ircsprintf wont overflow - it shouldnt on a
129 <     * default config but it is configurable..
130 <     * This should be changed to an snprintf at some point, but I'm wanting to
131 <     * know if this is a cause of a bug - cryogen
132 <     */
133 <    assert(strlen(target_p->name) + strlen(me.name) + 6 + strlen(p) <=
134 <            MESSAGELINELEN);
135 <    snprintf(newMessageLine->line, sizeof(newMessageLine->line), "%s %s :1 %s",
136 <             target_p->name, me.name, p);
137 <    newMessageLine->next = NULL;
108 >    fputs(buff, file);
109 >  }
110  
111 <    if (MessageFileptr->contentsOfFile)
112 <    {
141 <      if (currentMessageLine)
142 <        currentMessageLine->next = newMessageLine;
143 <      currentMessageLine = newMessageLine;
144 <    }
145 <    else
146 <    {
147 <      MessageFileptr->contentsOfFile = newMessageLine;
148 <      currentMessageLine = newMessageLine;
149 <    }
111 >  fclose(file);
112 > }
113  
114 <    snprintf(buff, sizeof(buff), "%s %s :1 %s\n", target_p->name, me.name, p);
115 <    fputs(buff, file);
114 > void
115 > read_links_file(void)
116 > {
117 >  FILE *file = NULL;
118 >  char *p = NULL;
119 >  char buff[IRCD_BUFSIZE] = "";
120 >
121 >  if (EmptyString(ConfigServerHide.flatten_links_file))
122 >    return;
123 >
124 >  if ((file = fopen(ConfigServerHide.flatten_links_file, "r")) == NULL)
125 >  {
126 >    ilog(LOG_TYPE_IRCD, "Couldn't open \"%s\": %s", ConfigServerHide.flatten_links_file,
127 >         strerror(errno));
128 >    return;
129 >  }
130 >
131 >  while (fgets(buff, sizeof(buff), file))
132 >  {
133 >    if ((p = strchr(buff, '\n')))
134 >      *p = '\0';
135 >
136 >    dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
137    }
138  
139    fclose(file);
140   }
141  
142 < /* hunt_server()
142 > /* server_hunt()
143   *      Do the basic thing in delivering the message (command)
144   *      across the relays to the specific server (server) for
145   *      actions.
# Line 174 | Line 158 | write_links_file(void* notused)
158   *
159   *      returns: (see #defines)
160   */
161 < int
162 < hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
163 <            int server, int parc, char *parv[])
161 > const struct server_hunt *
162 > server_hunt(struct Client *source_p, const char *command,
163 >            const int server, const int parc, char *parv[])
164   {
165 <  struct Client *target_p = NULL;
166 <  struct Client *target_tmp = NULL;
167 <  dlink_node *ptr;
184 <  int wilds;
165 >  static struct server_hunt hunt;
166 >  struct server_hunt *const h = &hunt;
167 >  dlink_node *node;
168  
169 <  /* Assume it's me, if no server
170 <   */
171 <  if (parc <= server || EmptyString(parv[server]) ||
172 <      match(me.name, parv[server]) ||
173 <      match(parv[server], me.name) ||
174 <      !strcmp(parv[server], me.id))
175 <    return(HUNTED_ISME);
169 >  /* Assume it's me, if no server */
170 >  if (parc <= server || EmptyString(parv[server]))
171 >  {
172 >    h->target_p = &me;
173 >    h->ret = HUNTED_ISME;
174 >    return h;
175 >  }
176 >
177 >  if ((h->target_p = find_person(source_p, parv[server])) == NULL)
178 >    h->target_p = hash_find_server(parv[server]);
179  
180 <  /* These are to pickup matches that would cause the following
180 >  /*
181 >   * These are to pickup matches that would cause the following
182     * message to go in the wrong direction while doing quick fast
183     * non-matching lookups.
184     */
185 <  if (MyClient(source_p))
186 <    target_p = hash_find_client(parv[server]);
187 <  else
201 <    target_p = find_person(client_p, parv[server]);
202 <
203 <  if (target_p)
204 <    if (target_p->from == source_p->from && !MyConnect(target_p))
205 <      target_p = NULL;
185 >  if (h->target_p)
186 >    if (h->target_p->from == source_p->from && !MyConnect(h->target_p))
187 >      h->target_p = NULL;
188  
189 <  if (target_p == NULL && (target_p = hash_find_server(parv[server])))
208 <    if (target_p->from == source_p->from && !MyConnect(target_p))
209 <      target_p = NULL;
210 <
211 <  collapse(parv[server]);
212 <  wilds = (strchr(parv[server], '?') || strchr(parv[server], '*'));
213 <
214 <  /* Again, if there are no wild cards involved in the server
215 <   * name, use the hash lookup
216 <   */
217 <  if (target_p == NULL)
189 >  if (!h->target_p && has_wildcards(parv[server]))
190    {
191 <    if (!wilds)
191 >    DLINK_FOREACH(node, global_server_list.head)
192      {
193 <      if (!(target_p = hash_find_server(parv[server])))
193 >      struct Client *tmp = node->data;
194 >
195 >      assert(IsMe(tmp) || IsServer(tmp));
196 >      if (!match(parv[server], tmp->name))
197        {
198 <        sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
199 <                   me.name, source_p->name, parv[server]);
200 <        return(HUNTED_NOSUCH);
198 >        if (tmp->from == source_p->from && !MyConnect(tmp))
199 >          continue;
200 >
201 >        h->target_p = tmp;
202 >        break;
203        }
204      }
205 <    else
205 >
206 >    if (!h->target_p)
207      {
208 <      DLINK_FOREACH(ptr, global_client_list.head)
208 >      DLINK_FOREACH(node, global_client_list.head)
209        {
210 <        target_tmp = ptr->data;
210 >        struct Client *tmp = node->data;
211  
212 <        if (match(parv[server], target_tmp->name))
212 >        assert(IsClient(tmp));
213 >        if (!match(parv[server], tmp->name))
214          {
215 <          if (target_tmp->from == source_p->from && !MyConnect(target_tmp))
215 >          if (tmp->from == source_p->from && !MyConnect(tmp))
216              continue;
238          target_p = ptr->data;
217  
218 <          if (IsRegistered(target_p) && (target_p != client_p))
219 <            break;
218 >          h->target_p = tmp;
219 >          break;
220          }
221        }
222      }
223    }
224  
225 <  if (target_p != NULL)
225 >  if (h->target_p)
226    {
227 <    if(!IsRegistered(target_p))
227 >    assert(IsMe(h->target_p) || IsServer(h->target_p) || IsClient(h->target_p));
228 >    if (IsMe(h->target_p) || MyClient(h->target_p))
229      {
230 <      sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
231 <                 me.name, source_p->name, parv[server]);
253 <      return HUNTED_NOSUCH;
230 >      h->ret = HUNTED_ISME;
231 >      return h;
232      }
233  
234 <    if (IsMe(target_p) || MyClient(target_p))
235 <      return HUNTED_ISME;
258 <
259 <    if (!match(target_p->name, parv[server]))
260 <      parv[server] = target_p->name;
261 <
262 <    /* This is a little kludgy but should work... */
263 <    if (IsClient(source_p) &&
264 <        ((MyConnect(target_p) && IsCapable(target_p, CAP_TS6)) ||
265 <         (!MyConnect(target_p) && IsCapable(target_p->from, CAP_TS6))))
266 <      parv[0] = ID(source_p);
267 <
268 <    sendto_one(target_p, command, parv[0],
234 >    parv[server] = h->target_p->id;
235 >    sendto_one(h->target_p, command, source_p->id,
236                 parv[1], parv[2], parv[3], parv[4],
237                 parv[5], parv[6], parv[7], parv[8]);
238 <    return(HUNTED_PASS);
239 <  }
238 >    h->ret = HUNTED_PASS;
239 >    return h;
240 >  }
241  
242 <  sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
243 <             me.name, source_p->name, parv[server]);
244 <  return(HUNTED_NOSUCH);
242 >  sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
243 >  h->ret = HUNTED_NOSUCH;
244 >  return h;
245   }
246  
247   /* try_connections()
# Line 289 | Line 257 | hunt_server(struct Client *client_p, str
257   void
258   try_connections(void *unused)
259   {
260 <  dlink_node *ptr;
293 <  struct ConfItem *conf;
294 <  struct AccessItem *aconf;
295 <  struct ClassItem *cltmp;
296 <  int confrq;
260 >  dlink_node *node;
261  
298  /* TODO: change this to set active flag to 0 when added to event! --Habeeb */
262    if (GlobalSetOptions.autoconn == 0)
263      return;
264  
265 <  DLINK_FOREACH(ptr, server_items.head)
265 >  DLINK_FOREACH(node, connect_items.head)
266    {
267 <    conf = ptr->data;
305 <    aconf = map_to_conf(conf);
267 >    struct MaskItem *conf = node->data;
268  
269 <    /* Also when already connecting! (update holdtimes) --SRB
270 <     */
309 <    if (!(aconf->status & CONF_SERVER) || !aconf->port ||
310 <        !(IsConfAllowAutoConn(aconf)))
311 <      continue;
269 >    assert(conf->type == CONF_SERVER);
270 >    assert(conf->class);
271  
272 <    cltmp = map_to_conf(aconf->class_ptr);
272 >    /* Also when already connecting! (update holdtimes) --SRB */
273 >    if (conf->port == 0 || !IsConfAllowAutoConn(conf))
274 >      continue;
275  
276 <    /* Skip this entry if the use of it is still on hold until
276 >    /*
277 >     * Skip this entry if the use of it is still on hold until
278       * future. Otherwise handle this entry (and set it on hold
279       * until next time). Will reset only hold times, if already
280       * made one successfull connection... [this algorithm is
281       * a bit fuzzy... -- msa >;) ]
282       */
283 <    if (aconf->hold > CurrentTime)
283 >    if (conf->until > CurrentTime)
284        continue;
285  
286 <    if (cltmp == NULL)
325 <      confrq = DEFAULT_CONNECTFREQUENCY;
326 <    else
327 <    {
328 <      confrq = ConFreq(cltmp);
329 <      if (confrq < MIN_CONN_FREQ )
330 <        confrq = MIN_CONN_FREQ;
331 <    }
332 <
333 <    aconf->hold = CurrentTime + confrq;
286 >    conf->until = CurrentTime + conf->class->con_freq;
287  
288 <    /* Found a CONNECT config with port specified, scan clients
288 >    /*
289 >     * Found a CONNECT config with port specified, scan clients
290       * and see if this server is already connected?
291       */
292 <    if (hash_find_server(conf->name) != NULL)
292 >    if (hash_find_server(conf->name))
293        continue;
294  
295 <    if (CurrUserCount(cltmp) < MaxTotal(cltmp))
295 >    if (conf->class->ref_count < conf->class->max_total)
296      {
297 <      /* Go to the end of the list, if not already last */
298 <      if (ptr->next != NULL)
297 >      /* Move this entry to the end of the list, if not already last */
298 >      if (node->next)
299        {
300 <        dlinkDelete(ptr, &server_items);
301 <        dlinkAddTail(conf, &conf->node, &server_items);
300 >        dlinkDelete(node, &connect_items);
301 >        dlinkAddTail(conf, &conf->node, &connect_items);
302        }
303  
304        if (find_servconn_in_progress(conf->name))
305          return;
306  
307 <      /* We used to only print this if serv_connect() actually
307 >      /*
308 >       * We used to only print this if server_connect() actually
309         * succeeded, but since comm_tcp_connect() can call the callback
310         * immediately if there is an error, we were getting error messages
311         * in the wrong order. SO, we just print out the activated line,
312 <       * and let serv_connect() / serv_connect_callback() print an
312 >       * and let server_connect() / server_connect_callback() print an
313         * error afterwards if it fails.
314         *   -- adrian
315         */
316        if (ConfigServerHide.hide_server_ips)
317 <        sendto_realops_flags(UMODE_ALL, L_ALL, "Connection to %s activated.",
317 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
318 >                             "Connection to %s activated.",
319                               conf->name);
320        else
321 <        sendto_realops_flags(UMODE_ALL, L_ALL, "Connection to %s[%s] activated.",
322 <                             conf->name, aconf->host);
321 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
322 >                             "Connection to %s[%s] activated.",
323 >                             conf->name, conf->host);
324  
325 <      serv_connect(aconf, NULL);
325 >      server_connect(conf, NULL);
326        /* We connect only one at time... */
327        return;
328      }
# Line 373 | Line 330 | try_connections(void *unused)
330   }
331  
332   int
333 < valid_servname(const char *name)
333 > server_valid_name(const char *name)
334   {
335 <  unsigned int length = 0;
379 <  unsigned int dots   = 0;
335 >  unsigned int dots = 0;
336    const char *p = name;
337  
338    for (; *p; ++p)
# Line 384 | Line 340 | valid_servname(const char *name)
340      if (!IsServChar(*p))
341        return 0;
342  
387    ++length;
388
343      if (*p == '.')
344        ++dots;
345    }
346  
347 <  return dots != 0 && length <= HOSTLEN;
394 < }
395 <
396 < int
397 < check_server(const char *name, struct Client *client_p)
398 < {
399 <  dlink_node *ptr;
400 <  struct ConfItem *conf           = NULL;
401 <  struct ConfItem *server_conf    = NULL;
402 <  struct AccessItem *server_aconf = NULL;
403 <  struct AccessItem *aconf        = NULL;
404 <  int error = -1;
405 <
406 <  assert(client_p != NULL);
407 <
408 <  if (client_p == NULL)
409 <    return(error);
410 <
411 <  if (strlen(name) > HOSTLEN)
412 <    return(-4);
413 <
414 <  /* loop through looking for all possible connect items that might work */
415 <  DLINK_FOREACH(ptr, server_items.head)
416 <  {
417 <    conf = ptr->data;
418 <    aconf = map_to_conf(conf);
419 <
420 <    if (!match(name, conf->name))
421 <      continue;
422 <
423 <    error = -3;
424 <
425 <    /* XXX: Fix me for IPv6                    */
426 <    /* XXX sockhost is the IPv4 ip as a string */
427 <    if (match(aconf->host, client_p->host) ||
428 <        match(aconf->host, client_p->sockhost))
429 <    {
430 <      error = -2;
431 <      {
432 <        /* A NULL password is as good as a bad one */
433 <        if (EmptyString(client_p->localClient->passwd))
434 <          return(-2);
435 <
436 <        /* code in s_conf.c should not have allowed this to be NULL */
437 <        if (aconf->passwd == NULL)
438 <          return(-2);
439 <
440 <        if (IsConfEncrypted(aconf))
441 <        {
442 <          if (strcmp(aconf->passwd,
443 <              (const char *)crypt(client_p->localClient->passwd,
444 <                                  aconf->passwd)) == 0)
445 <            server_conf = conf;
446 <        }
447 <        else
448 <        {
449 <          if (strcmp(aconf->passwd, client_p->localClient->passwd) == 0)
450 <            server_conf = conf;
451 <        }
452 <      }
453 <    }
454 <  }
455 <
456 <  if (server_conf == NULL)
457 <    return(error);
458 <
459 <  attach_conf(client_p, server_conf);
460 <
461 <  /* Now find all leaf or hub config items for this server */
462 <  DLINK_FOREACH(ptr, hub_items.head)
463 <  {
464 <    conf = ptr->data;
465 <
466 <    if (!match(name, conf->name))
467 <      continue;
468 <    attach_conf(client_p, conf);
469 <  }
470 <
471 <  DLINK_FOREACH(ptr, leaf_items.head)
472 <  {
473 <    conf = ptr->data;
474 <
475 <    if (!match(name, conf->name))
476 <      continue;
477 <    attach_conf(client_p, conf);
478 <  }
479 <
480 <  server_aconf = map_to_conf(server_conf);
481 <
482 <  if (!IsConfTopicBurst(server_aconf))
483 <  {
484 <    ClearCap(client_p, CAP_TB);
485 <    ClearCap(client_p, CAP_TBURST);
486 <  }
487 <
488 <  if (aconf != NULL)
489 <  {
490 <    struct sockaddr_in *v4;
491 < #ifdef IPV6
492 <    struct sockaddr_in6 *v6;
493 < #endif
494 <    switch (aconf->aftype)
495 <    {
496 < #ifdef IPV6
497 <      case AF_INET6:
498 <        v6 = (struct sockaddr_in6 *)&aconf->ipnum;
499 <
500 <        if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
501 <          memcpy(&aconf->ipnum, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
502 <        break;
503 < #endif
504 <      case AF_INET:
505 <        v4 = (struct sockaddr_in *)&aconf->ipnum;
506 <
507 <        if (v4->sin_addr.s_addr == INADDR_NONE)
508 <          memcpy(&aconf->ipnum, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
509 <        break;
510 <    }
511 <  }
512 <
513 <  return(0);
514 < }
515 <
516 < /* add_capability()
517 < *
518 < * inputs       - string name of CAPAB
519 < *              - int flag of capability
520 < * output       - NONE
521 < * side effects - Adds given capability name and bit mask to
522 < *                current supported capabilities. This allows
523 < *                modules to dynamically add or subtract their capability.
524 < */
525 < void
526 < add_capability(const char *capab_name, int cap_flag, int add_to_default)
527 < {
528 <  struct Capability *cap = MyMalloc(sizeof(*cap));
529 <
530 <  DupString(cap->name, capab_name);
531 <  cap->cap = cap_flag;
532 <  dlinkAdd(cap, &cap->node, &cap_list);
533 <
534 <  if (add_to_default)
535 <    default_server_capabs |= cap_flag;
536 < }
537 <
538 < /* delete_capability()
539 < *
540 < * inputs       - string name of CAPAB
541 < * output       - NONE
542 < * side effects - delete given capability from ones known.
543 < */
544 < int
545 < delete_capability(const char *capab_name)
546 < {
547 <  dlink_node *ptr;
548 <  dlink_node *next_ptr;
549 <  struct Capability *cap;
550 <
551 <  DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
552 <  {
553 <    cap = ptr->data;
554 <
555 <    if (cap->cap != 0)
556 <    {
557 <      if (irccmp(cap->name, capab_name) == 0)
558 <      {
559 <        default_server_capabs &= ~(cap->cap);
560 <        dlinkDelete(ptr, &cap_list);
561 <        MyFree(cap->name);
562 <        cap->name = NULL;
563 <        MyFree(cap);
564 <      }
565 <    }
566 <  }
567 <
568 <  return 0;
347 >  return dots && (p - name) <= HOSTLEN;
348   }
349  
350 < /*
572 < * find_capability()
573 < *
574 < * inputs       - string name of capab to find
575 < * output       - 0 if not found CAPAB otherwise
576 < * side effects - none
577 < */
578 < int
579 < find_capability(const char *capab)
580 < {
581 <  const dlink_node *ptr = NULL;
582 <
583 <  DLINK_FOREACH(ptr, cap_list.head)
584 <  {
585 <    const struct Capability *cap = ptr->data;
586 <
587 <    if (cap->cap && !irccmp(cap->name, capab))
588 <      return cap->cap;
589 <  }
590 <
591 <  return 0;
592 < }
593 <
594 < /* send_capabilities()
595 < *
596 < * inputs       - Client pointer to send to
597 < *              - Pointer to AccessItem (for crypt)
598 < *              - int flag of capabilities that this server can send
599 < * output       - NONE
600 < * side effects - send the CAPAB line to a server  -orabidoo
601 < *
602 < */
603 < void
604 < send_capabilities(struct Client *client_p, struct AccessItem *aconf,
605 <                  int cap_can_send)
606 < {
607 <  struct Capability *cap=NULL;
608 <  char msgbuf[IRCD_BUFSIZE];
609 <  char *t;
610 <  int tl;
611 <  dlink_node *ptr;
612 <
613 <  t = msgbuf;
614 <
615 <  DLINK_FOREACH(ptr, cap_list.head)
616 <  {
617 <    cap = ptr->data;
618 <
619 <    if (cap->cap & (cap_can_send|default_server_capabs))
620 <    {
621 <      tl = ircsprintf(t, "%s ", cap->name);
622 <      t += tl;
623 <    }
624 <  }
625 <
626 <  *(t - 1) = '\0';
627 <  sendto_one(client_p, "CAPAB :%s", msgbuf);
628 < }
629 <
630 < /* sendnick_TS()
631 < *
632 < * inputs       - client (server) to send nick towards
633 < *          - client to send nick for
634 < * output       - NONE
635 < * side effects - NICK message is sent towards given client_p
636 < */
637 < void
638 < sendnick_TS(struct Client *client_p, struct Client *target_p)
639 < {
640 <  static char ubuf[12];
641 <
642 <  if (!IsClient(target_p))
643 <    return;
644 <
645 <  send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
646 <
647 <  if (ubuf[0] == '\0')
648 <  {
649 <    ubuf[0] = '+';
650 <    ubuf[1] = '\0';
651 <  }
652 <
653 <  /* XXX Both of these need to have a :me.name or :mySID!?!?! */
654 <  if (IsCapable(client_p, CAP_SVS))
655 <  {
656 <    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
657 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %lu :%s",
658 <                 target_p->servptr->id,
659 <                 target_p->name, target_p->hopcount + 1,
660 <                 (unsigned long) target_p->tsinfo,
661 <                 ubuf, target_p->username, target_p->host,
662 <                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
663 <                 "0" : target_p->sockhost, target_p->id,
664 <                 (unsigned long)target_p->servicestamp, target_p->info);
665 <    else
666 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s %lu :%s",
667 <                 target_p->name, target_p->hopcount + 1,
668 <                 (unsigned long) target_p->tsinfo,
669 <                 ubuf, target_p->username, target_p->host,
670 <                 target_p->servptr->name, (unsigned long)target_p->servicestamp,
671 <                 target_p->info);
672 <  }
673 <  else
674 <  {
675 <    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
676 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
677 <                 target_p->servptr->id,
678 <                 target_p->name, target_p->hopcount + 1,
679 <                 (unsigned long) target_p->tsinfo,
680 <                 ubuf, target_p->username, target_p->host,
681 <                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
682 <                 "0" : target_p->sockhost, target_p->id, target_p->info);
683 <    else
684 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s :%s",
685 <                 target_p->name, target_p->hopcount + 1,
686 <                 (unsigned long) target_p->tsinfo,
687 <                 ubuf, target_p->username, target_p->host,
688 <                 target_p->servptr->name, target_p->info);
689 <  }
690 <
691 <  if (IsConfAwayBurst((struct AccessItem *)map_to_conf(client_p->serv->sconf)))
692 <    if (!EmptyString(target_p->away))
693 <      sendto_one(client_p, ":%s AWAY :%s", target_p->name,
694 <                 target_p->away);
695 <
696 < }
697 <
698 < /*
699 < * show_capabilities - show current server capabilities
700 < *
701 < * inputs       - pointer to a struct Client
702 < * output       - pointer to static string
703 < * side effects - build up string representing capabilities of server listed
704 < */
705 < const char *
706 < show_capabilities(struct Client *target_p)
707 < {
708 <  static char msgbuf[IRCD_BUFSIZE];
709 <  char *t = msgbuf;
710 <  dlink_node *ptr;
711 <
712 <  t += ircsprintf(msgbuf, "TS ");
713 <
714 <  DLINK_FOREACH(ptr, cap_list.head)
715 <  {
716 <    const struct Capability *cap = ptr->data;
717 <
718 <    if (IsCapable(target_p, cap->cap))
719 <      t += ircsprintf(t, "%s ", cap->name);
720 <  }
721 <
722 <  *(t - 1) = '\0';
723 <  return msgbuf;
724 < }
725 <
726 < /* make_server()
350 > /* server_make()
351   *
352   * inputs       - pointer to client struct
353   * output       - pointer to struct Server
# Line 731 | Line 355 | show_capabilities(struct Client *target_
355   *                if it was not previously allocated.
356   */
357   struct Server *
358 < make_server(struct Client *client_p)
358 > server_make(struct Client *client_p)
359   {
360    if (client_p->serv == NULL)
361 <    client_p->serv = MyMalloc(sizeof(struct Server));
361 >    client_p->serv = xcalloc(sizeof(*client_p->serv));
362  
363    return client_p->serv;
364   }
365  
366 < /* server_estab()
366 > /* server_connect() - initiate a server connection
367   *
368 < * inputs       - pointer to a struct Client
745 < * output       -
746 < * side effects -
747 < */
748 < void
749 < server_estab(struct Client *client_p)
750 < {
751 <  struct Client *target_p;
752 <  struct ConfItem *conf;
753 <  struct AccessItem *aconf=NULL;
754 <  char *host;
755 <  const char *inpath;
756 <  static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
757 <  dlink_node *ptr;
758 < #ifdef HAVE_LIBCRYPTO
759 <  const COMP_METHOD *compression = NULL, *expansion = NULL;
760 < #endif
761 <
762 <  assert(client_p != NULL);
763 <
764 <  strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
765 <
766 <  inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
767 <  host   = client_p->name;
768 <
769 <  if ((conf = find_conf_name(&client_p->localClient->confs, host, SERVER_TYPE))
770 <      == NULL)
771 <  {
772 <    /* This shouldn't happen, better tell the ops... -A1kmm */
773 <    sendto_realops_flags(UMODE_ALL, L_ALL, "Warning: Lost connect{} block "
774 <                         "for server %s(this shouldn't happen)!", host);
775 <    exit_client(client_p, &me, "Lost connect{} block!");
776 <    return;
777 <  }
778 <
779 <  MyFree(client_p->localClient->passwd);
780 <  client_p->localClient->passwd = NULL;
781 <
782 <  /* Its got identd, since its a server */
783 <  SetGotId(client_p);
784 <
785 <  /* If there is something in the serv_list, it might be this
786 <   * connecting server..
787 <   */
788 <  if (!ServerInfo.hub && serv_list.head)  
789 <  {
790 <    if (client_p != serv_list.head->data || serv_list.head->next)
791 <    {
792 <      ++ServerStats.is_ref;
793 <      sendto_one(client_p, "ERROR :I'm a leaf not a hub");
794 <      exit_client(client_p, &me, "I'm a leaf");
795 <      return;
796 <    }
797 <  }
798 <
799 <  aconf = map_to_conf(conf);
800 <
801 <  if (IsUnknown(client_p))
802 <  {
803 <    /* jdc -- 1.  Use EmptyString(), not [0] index reference.
804 <     *        2.  Check aconf->spasswd, not aconf->passwd.
805 <     */
806 <    if (!EmptyString(aconf->spasswd))
807 <      sendto_one(client_p, "PASS %s TS %d %s",
808 <                 aconf->spasswd, TS_CURRENT, me.id);
809 <
810 <    /* Pass my info to the new server
811 <     *
812 <     * Pass on ZIP if supported
813 <     * Pass on TB if supported.
814 <     * - Dianora
815 <     */
816 <
817 <    send_capabilities(client_p, aconf,
818 <      (IsConfTopicBurst(aconf) ? CAP_TBURST|CAP_TB : 0));
819 <
820 <    sendto_one(client_p, "SERVER %s 1 :%s%s",
821 <               me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
822 <  }
823 <
824 <  sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
825 <             (unsigned long)CurrentTime);
826 <
827 <  /* assumption here is if they passed the correct TS version, they also passed an SID */
828 <  if (IsCapable(client_p, CAP_TS6))
829 <    hash_add_id(client_p);
830 <
831 <  /* XXX Does this ever happen? I don't think so -db */
832 <  detach_conf(client_p, OPER_TYPE);
833 <
834 <  /* *WARNING*
835 <  **    In the following code in place of plain server's
836 <  **    name we send what is returned by get_client_name
837 <  **    which may add the "sockhost" after the name. It's
838 <  **    *very* *important* that there is a SPACE between
839 <  **    the name and sockhost (if present). The receiving
840 <  **    server will start the information field from this
841 <  **    first blank and thus puts the sockhost into info.
842 <  **    ...a bit tricky, but you have been warned, besides
843 <  **    code is more neat this way...  --msa
844 <  */
845 <  client_p->servptr = &me;
846 <
847 <  if (IsClosing(client_p))
848 <    return;
849 <
850 <  SetServer(client_p);
851 <
852 <  /* Update the capability combination usage counts. -A1kmm */
853 <  set_chcap_usage_counts(client_p);
854 <
855 <  /* Some day, all these lists will be consolidated *sigh* */
856 <  dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
857 <
858 <  assert(dlinkFind(&unknown_list, client_p));
859 <
860 <  dlink_move_node(&client_p->localClient->lclient_node,
861 <                  &unknown_list, &serv_list);
862 <
863 <  Count.myserver++;
864 <
865 <  dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
866 <  hash_add_client(client_p);
867 <
868 <  /* doesnt duplicate client_p->serv if allocated this struct already */
869 <  make_server(client_p);
870 <
871 <  /* fixing eob timings.. -gnp */
872 <  client_p->localClient->firsttime = CurrentTime;
873 <
874 <  if (find_matching_name_conf(SERVICE_TYPE, client_p->name, NULL, NULL, 0))
875 <    AddFlag(client_p, FLAGS_SERVICE);
876 <
877 <  /* Show the real host/IP to admins */
878 < #ifdef HAVE_LIBCRYPTO
879 <  if (client_p->localClient->fd.ssl)
880 <  {
881 <    compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
882 <    expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
883 <
884 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
885 <                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
886 <                         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
887 <                         compression ? SSL_COMP_get_name(compression) : "NONE",
888 <                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
889 <                         show_capabilities(client_p));
890 <    /* Now show the masked hostname/IP to opers */
891 <    sendto_realops_flags(UMODE_ALL, L_OPER,
892 <                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
893 <                         inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
894 <                         compression ? SSL_COMP_get_name(compression) : "NONE",
895 <                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
896 <                         show_capabilities(client_p));
897 <    ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
898 <         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
899 <         compression ? SSL_COMP_get_name(compression) : "NONE",
900 <         expansion ? SSL_COMP_get_name(expansion) : "NONE",
901 <         show_capabilities(client_p));
902 <  }
903 <  else
904 < #endif
905 <  {
906 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
907 <                         "Link with %s established: (Capabilities: %s)",
908 <                         inpath_ip,show_capabilities(client_p));
909 <    /* Now show the masked hostname/IP to opers */
910 <    sendto_realops_flags(UMODE_ALL, L_OPER,
911 <                         "Link with %s established: (Capabilities: %s)",
912 <                         inpath,show_capabilities(client_p));
913 <    ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
914 <         inpath_ip, show_capabilities(client_p));
915 <  }
916 <
917 <  client_p->serv->sconf = conf;
918 <
919 <  fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
920 <
921 <  /* Old sendto_serv_but_one() call removed because we now
922 <  ** need to send different names to different servers
923 <  ** (domain name matching) Send new server to other servers.
924 <  */
925 <  DLINK_FOREACH(ptr, serv_list.head)
926 <  {
927 <    target_p = ptr->data;
928 <
929 <    if (target_p == client_p)
930 <      continue;
931 <
932 <    if (IsCapable(target_p, CAP_TS6) && HasID(client_p))
933 <      sendto_one(target_p, ":%s SID %s 2 %s :%s%s",
934 <                 me.id, client_p->name, client_p->id,
935 <                 IsHidden(client_p) ? "(H) " : "",
936 <                 client_p->info);
937 <    else
938 <      sendto_one(target_p,":%s SERVER %s 2 :%s%s",
939 <                 me.name, client_p->name,
940 <                 IsHidden(client_p) ? "(H) " : "",
941 <                 client_p->info);
942 <  }
943 <
944 <  /* Pass on my client information to the new server
945 <  **
946 <  ** First, pass only servers (idea is that if the link gets
947 <  ** cancelled beacause the server was already there,
948 <  ** there are no NICK's to be cancelled...). Of course,
949 <  ** if cancellation occurs, all this info is sent anyway,
950 <  ** and I guess the link dies when a read is attempted...? --msa
951 <  **
952 <  ** Note: Link cancellation to occur at this point means
953 <  ** that at least two servers from my fragment are building
954 <  ** up connection this other fragment at the same time, it's
955 <  ** a race condition, not the normal way of operation...
956 <  **
957 <  ** ALSO NOTE: using the get_client_name for server names--
958 <  **    see previous *WARNING*!!! (Also, original inpath
959 <  **    is destroyed...)
960 <  */
961 <
962 <  DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
963 <  {
964 <    target_p = ptr->data;
965 <
966 <    /* target_p->from == target_p for target_p == client_p */
967 <    if (IsMe(target_p) || target_p->from == client_p)
968 <      continue;
969 <
970 <    if (IsCapable(client_p, CAP_TS6))
971 <    {
972 <      if (HasID(target_p))
973 <        sendto_one(client_p, ":%s SID %s %d %s :%s%s",
974 <                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
975 <                   target_p->id, IsHidden(target_p) ? "(H) " : "",
976 <                   target_p->info);
977 <      else  /* introducing non-ts6 server */
978 <        sendto_one(client_p, ":%s SERVER %s %d :%s%s",
979 <                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
980 <                   IsHidden(target_p) ? "(H) " : "", target_p->info);
981 <    }
982 <    else
983 <      sendto_one(client_p, ":%s SERVER %s %d :%s%s",
984 <                 target_p->servptr->name, target_p->name, target_p->hopcount+1,
985 <                 IsHidden(target_p) ? "(H) " : "", target_p->info);
986 <  }
987 <
988 <  server_burst(client_p);
989 < }
990 <
991 < /* server_burst()
992 < *
993 < * inputs       - struct Client pointer server
994 < *              -
995 < * output       - none
996 < * side effects - send a server burst
997 < * bugs         - still too long
998 < */
999 < static void
1000 < server_burst(struct Client *client_p)
1001 < {
1002 <  /* Send it in the shortened format with the TS, if
1003 <  ** it's a TS server; walk the list of channels, sending
1004 <  ** all the nicks that haven't been sent yet for each
1005 <  ** channel, then send the channel itself -- it's less
1006 <  ** obvious than sending all nicks first, but on the
1007 <  ** receiving side memory will be allocated more nicely
1008 <  ** saving a few seconds in the handling of a split
1009 <  ** -orabidoo
1010 <  */
1011 <
1012 <  burst_all(client_p);
1013 <
1014 <  /* EOB stuff is now in burst_all */
1015 <  /* Always send a PING after connect burst is done */
1016 <  sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
1017 < }
1018 <
1019 < /* burst_all()
1020 < *
1021 < * inputs       - pointer to server to send burst to
1022 < * output       - NONE
1023 < * side effects - complete burst of channels/nicks is sent to client_p
1024 < */
1025 < static void
1026 < burst_all(struct Client *client_p)
1027 < {
1028 <  dlink_node *ptr = NULL;
1029 <
1030 <  DLINK_FOREACH(ptr, global_channel_list.head)
1031 <  {
1032 <    struct Channel *chptr = ptr->data;
1033 <
1034 <    if (dlink_list_length(&chptr->members) != 0)
1035 <    {
1036 <      burst_members(client_p, chptr);
1037 <      send_channel_modes(client_p, chptr);
1038 <
1039 <      if (IsCapable(client_p, CAP_TBURST) ||
1040 <          IsCapable(client_p, CAP_TB))
1041 <        send_tb(client_p, chptr);
1042 <    }
1043 <  }
1044 <
1045 <  /* also send out those that are not on any channel
1046 <   */
1047 <  DLINK_FOREACH(ptr, global_client_list.head)
1048 <  {
1049 <    struct Client *target_p = ptr->data;
1050 <
1051 <    if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
1052 <      sendnick_TS(client_p, target_p);
1053 <    
1054 <    DelFlag(target_p, FLAGS_BURSTED);
1055 <  }
1056 <
1057 <  /* We send the time we started the burst, and let the remote host determine an EOB time,
1058 <  ** as otherwise we end up sending a EOB of 0   Sending here means it gets sent last -- fl
1059 <  */
1060 <  /* Its simpler to just send EOB and use the time its been connected.. --fl_ */
1061 <  if (IsCapable(client_p, CAP_EOB))
1062 <    sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
1063 < }
1064 <
1065 < /*
1066 < * send_tb
1067 < *
1068 < * inputs       - pointer to Client
1069 < *              - pointer to channel
1070 < * output       - NONE
1071 < * side effects - Called on a server burst when
1072 < *                server is CAP_TB|CAP_TBURST capable
1073 < */
1074 < static void
1075 < send_tb(struct Client *client_p, struct Channel *chptr)
1076 < {
1077 <  /*
1078 <   * We may also send an empty topic here, but only if topic_time isn't 0,
1079 <   * i.e. if we had a topic that got unset.  This is required for syncing
1080 <   * topics properly.
1081 <   *
1082 <   * Imagine the following scenario: Our downlink introduces a channel
1083 <   * to us with a TS that is equal to ours, but the channel topic on
1084 <   * their side got unset while the servers were in splitmode, which means
1085 <   * their 'topic' is newer.  They simply wanted to unset it, so we have to
1086 <   * deal with it in a more sophisticated fashion instead of just resetting
1087 <   * it to their old topic they had before.  Read m_tburst.c:ms_tburst
1088 <   * for further information   -Michael
1089 <   */
1090 <  if (chptr->topic_time != 0)
1091 <  {
1092 <    if (IsCapable(client_p, CAP_TBURST))
1093 <      sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s",
1094 <                 me.name, (unsigned long)chptr->channelts, chptr->chname,
1095 <                 (unsigned long)chptr->topic_time,
1096 <                 chptr->topic_info,
1097 <                 chptr->topic);
1098 <    else if (IsCapable(client_p, CAP_TB))
1099 <    {
1100 <      if (ConfigChannel.burst_topicwho)
1101 <      {
1102 <        sendto_one(client_p, ":%s TB %s %lu %s :%s",
1103 <                   me.name, chptr->chname,
1104 <                   (unsigned long)chptr->topic_time,
1105 <                   chptr->topic_info, chptr->topic);
1106 <      }
1107 <      else
1108 <      {
1109 <        sendto_one(client_p, ":%s TB %s %lu :%s",
1110 <                   me.name, chptr->chname,
1111 <                   (unsigned long)chptr->topic_time,
1112 <                   chptr->topic);
1113 <      }
1114 <    }
1115 <  }
1116 < }
1117 <
1118 < /* burst_members()
1119 < *
1120 < * inputs       - pointer to server to send members to
1121 < *              - dlink_list pointer to membership list to send
1122 < * output       - NONE
1123 < * side effects -
1124 < */
1125 < static void
1126 < burst_members(struct Client *client_p, struct Channel *chptr)
1127 < {
1128 <  struct Client *target_p;
1129 <  struct Membership *ms;
1130 <  dlink_node *ptr;
1131 <
1132 <  DLINK_FOREACH(ptr, chptr->members.head)
1133 <  {
1134 <    ms       = ptr->data;
1135 <    target_p = ms->client_p;
1136 <
1137 <    if (!HasFlag(target_p, FLAGS_BURSTED))
1138 <    {
1139 <      AddFlag(target_p, FLAGS_BURSTED);
1140 <
1141 <      if (target_p->from != client_p)
1142 <        sendnick_TS(client_p, target_p);
1143 <    }
1144 <  }
1145 < }
1146 <
1147 < /* New server connection code
1148 < * Based upon the stuff floating about in s_bsd.c
1149 < *   -- adrian
1150 < */
1151 <
1152 < /* serv_connect() - initiate a server connection
1153 < *
1154 < * inputs       - pointer to conf
368 > * inputs       - pointer to conf
369   *              - pointer to client doing the connect
370   * output       -
371   * side effects -
# Line 1166 | Line 380 | burst_members(struct Client *client_p, s
380   * it suceeded or not, and 0 if it fails in here somewhere.
381   */
382   int
383 < serv_connect(struct AccessItem *aconf, struct Client *by)
383 > server_connect(struct MaskItem *conf, struct Client *by)
384   {
385 <  struct ConfItem *conf;
1172 <  struct Client *client_p;
1173 <  char buf[HOSTIPLEN];
385 >  char buf[HOSTIPLEN + 1] = "";
386  
387    /* conversion structs */
388    struct sockaddr_in *v4;
1177  /* Make sure aconf is useful */
1178  assert(aconf != NULL);
1179
1180  if(aconf == NULL)
1181    return (0);
389  
390 <  /* XXX should be passing struct ConfItem in the first place */
391 <  conf = unmap_conf_item(aconf);
390 >  /* Make sure conf is useful */
391 >  assert(conf);
392 >  assert(conf->type == CONF_SERVER);
393 >  assert(hash_find_server(conf->name) == NULL);  /* This should have been checked by the caller */
394  
395 <  /* log */
1187 <  getnameinfo((struct sockaddr *)&aconf->ipnum, aconf->ipnum.ss_len,
395 >  getnameinfo((const struct sockaddr *)&conf->addr, conf->addr.ss_len,
396                buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
397 <  ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", aconf->user, aconf->host,
1190 <       buf);
397 >  ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", conf->name, conf->host, buf);
398  
399    /* Still processing a DNS lookup? -> exit */
400 <  if (aconf->dns_pending)
400 >  if (conf->dns_pending)
401    {
402 <    sendto_realops_flags(UMODE_ALL, L_ALL,
402 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
403                           "Error connecting to %s: DNS lookup for connect{} in progress.",
404                           conf->name);
405 <    return (0);
405 >    return 0;
406    }
407  
408 <  if (aconf->dns_failed)
408 >  if (conf->dns_failed)
409    {
410 <    sendto_realops_flags(UMODE_ALL, L_ALL,
410 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
411                           "Error connecting to %s: DNS lookup for connect{} failed.",
412                           conf->name);
413 <    return (0);
413 >    return 0;
414    }
415  
416 <  /* Make sure this server isn't already connected
417 <   * Note: aconf should ALWAYS be a valid C: line
418 <   */
419 <  if ((client_p = hash_find_server(conf->name)) != NULL)
420 <  {
421 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
422 <                         "Server %s already present from %s",
1216 <                         conf->name, get_client_name(client_p, SHOW_IP));
1217 <    sendto_realops_flags(UMODE_ALL, L_OPER,
1218 <                         "Server %s already present from %s",
1219 <                         conf->name, get_client_name(client_p, MASK_IP));
1220 <    if (by && IsClient(by) && !MyClient(by))
1221 <      sendto_one(by, ":%s NOTICE %s :Server %s already present from %s",
1222 <                 me.name, by->name, conf->name,
1223 <                 get_client_name(client_p, MASK_IP));
1224 <    return (0);
416 >  /* Create a socket for the server connection */
417 >  int fd = comm_socket(conf->addr.ss.ss_family, SOCK_STREAM, 0);
418 >  if (fd == -1)
419 >  {
420 >    /* Eek, failure to create the socket */
421 >    report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
422 >    return 0;
423    }
424 <    
424 >
425    /* Create a local client */
426 <  client_p = make_client(NULL);
426 >  struct Client *client_p = client_make(NULL);
427  
428    /* Copy in the server, hostname, fd */
429    strlcpy(client_p->name, conf->name, sizeof(client_p->name));
430 <  strlcpy(client_p->host, aconf->host, sizeof(client_p->host));
430 >  strlcpy(client_p->host, conf->host, sizeof(client_p->host));
431  
432    /* We already converted the ip once, so lets use it - stu */
433    strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
434  
435 <  /* create a socket for the server connection */
1238 <  if (comm_open(&client_p->localClient->fd, aconf->ipnum.ss.ss_family,
1239 <                SOCK_STREAM, 0, NULL) < 0)
1240 <  {
1241 <    /* Eek, failure to create the socket */
1242 <    report_error(L_ALL,
1243 <                 "opening stream socket to %s: %s", conf->name, errno);
1244 <    SetDead(client_p);
1245 <    exit_client(client_p, &me, "Connection failed");
1246 <    return (0);
1247 <  }
435 >  client_p->connection->fd = fd_open(fd, 1, NULL);
436  
437 <  /* servernames are always guaranteed under HOSTLEN chars */
438 <  fd_note(&client_p->localClient->fd, "Server: %s", conf->name);
437 >  /* Server names are always guaranteed under HOSTLEN chars */
438 >  fd_note(client_p->connection->fd, "Server: %s", client_p->name);
439  
440 <  /* Attach config entries to client here rather than in
441 <   * serv_connect_callback(). This to avoid null pointer references.
440 >  /*
441 >   * Attach config entries to client here rather than in server_connect_callback().
442 >   * This to avoid null pointer references.
443     */
444 <  if (!attach_connect_block(client_p, conf->name, aconf->host))
1256 <  {
1257 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1258 <                         "Host %s is not enabled for connecting:no C/N-line",
1259 <                         conf->name);
1260 <    if (by && IsClient(by) && !MyClient(by))  
1261 <      sendto_one(by, ":%s NOTICE %s :Connect to host %s failed.",
1262 <                 me.name, by->name, client_p->name);
1263 <    SetDead(client_p);
1264 <    exit_client(client_p, client_p, "Connection failed");
1265 <    return (0);
1266 <  }
444 >  conf_attach(client_p, conf);
445  
446 <  /* at this point we have a connection in progress and C/N lines
1269 <   * attached to the client, the socket info should be saved in the
1270 <   * client and it should either be resolved or have a valid address.
1271 <   *
1272 <   * The socket has been connected or connect is in progress.
1273 <   */
1274 <  make_server(client_p);
446 >  server_make(client_p);
447  
448    if (by && IsClient(by))
449      strlcpy(client_p->serv->by, by->name, sizeof(client_p->serv->by));
# Line 1279 | Line 451 | serv_connect(struct AccessItem *aconf, s
451      strlcpy(client_p->serv->by, "AutoConn.", sizeof(client_p->serv->by));
452  
453    SetConnecting(client_p);
454 <  dlinkAdd(client_p, &client_p->node, &global_client_list);
1283 <  /* from def_fam */
1284 <  client_p->localClient->aftype = aconf->aftype;
454 >  client_p->ip.ss.ss_family = conf->aftype;
455  
456    /* Now, initiate the connection */
457 <  /* XXX assume that a non 0 type means a specific bind address
457 >  /* XXX assume that a non 0 type means a specific bind address
458     * for this connect.
459     */
460 <  switch (aconf->aftype)
460 >  switch (conf->aftype)
461    {
462      case AF_INET:
463 <      v4 = (struct sockaddr_in*)&aconf->my_ipnum;
464 <      if (v4->sin_addr.s_addr != 0)
463 >      v4 = (struct sockaddr_in*)&conf->bind;
464 >
465 >      if (v4->sin_addr.s_addr)
466        {
467          struct irc_ssaddr ipn;
468 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
468 >
469 >        memset(&ipn, 0, sizeof(ipn));
470          ipn.ss.ss_family = AF_INET;
471          ipn.ss_port = 0;
472 <        memcpy(&ipn, &aconf->my_ipnum, sizeof(struct irc_ssaddr));
473 <        comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
474 <                         (struct sockaddr *)&ipn, ipn.ss_len,
475 <                         serv_connect_callback, client_p, aconf->aftype,
476 <                         CONNECTTIMEOUT);
472 >        memcpy(&ipn, &conf->bind, sizeof(ipn));
473 >
474 >        comm_connect_tcp(client_p->connection->fd, conf->host, conf->port,
475 >                         (struct sockaddr *)&ipn, ipn.ss_len,
476 >                         server_connect_callback, client_p, conf->aftype,
477 >                         CONNECTTIMEOUT);
478        }
479 <      else if (ServerInfo.specific_ipv4_vhost)
479 >      else if (ConfigServerInfo.specific_ipv4_vhost)
480        {
481          struct irc_ssaddr ipn;
482 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
482 >
483 >        memset(&ipn, 0, sizeof(ipn));
484          ipn.ss.ss_family = AF_INET;
485          ipn.ss_port = 0;
486 <        memcpy(&ipn, &ServerInfo.ip, sizeof(struct irc_ssaddr));
487 <        comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
486 >        memcpy(&ipn, &ConfigServerInfo.ip, sizeof(ipn));
487 >
488 >        comm_connect_tcp(client_p->connection->fd, conf->host, conf->port,
489                           (struct sockaddr *)&ipn, ipn.ss_len,
490 <                         serv_connect_callback, client_p, aconf->aftype,
491 <                         CONNECTTIMEOUT);
490 >                         server_connect_callback, client_p, conf->aftype,
491 >                         CONNECTTIMEOUT);
492        }
493        else
494 <        comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
495 <                         NULL, 0, serv_connect_callback, client_p, aconf->aftype,
494 >        comm_connect_tcp(client_p->connection->fd, conf->host, conf->port,
495 >                         NULL, 0, server_connect_callback, client_p, conf->aftype,
496                           CONNECTTIMEOUT);
497        break;
1323 #ifdef IPV6
498      case AF_INET6:
499        {
500 <        struct irc_ssaddr ipn;
501 <        struct sockaddr_in6 *v6;
502 <        struct sockaddr_in6 *v6conf;
503 <
504 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
505 <        v6conf = (struct sockaddr_in6 *)&aconf->my_ipnum;
506 <        v6 = (struct sockaddr_in6 *)&ipn;
507 <
508 <        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr,
509 <                   sizeof(struct in6_addr)) != 0)
510 <        {
511 <          memcpy(&ipn, &aconf->my_ipnum, sizeof(struct irc_ssaddr));
512 <          ipn.ss.ss_family = AF_INET6;
513 <          ipn.ss_port = 0;
514 <          comm_connect_tcp(&client_p->localClient->fd,
515 <                           aconf->host, aconf->port,
516 <                           (struct sockaddr *)&ipn, ipn.ss_len,
517 <                           serv_connect_callback, client_p,
518 <                           aconf->aftype, CONNECTTIMEOUT);
519 <        }
520 <        else if (ServerInfo.specific_ipv6_vhost)
500 >        struct irc_ssaddr ipn;
501 >        struct sockaddr_in6 *v6;
502 >        struct sockaddr_in6 *v6conf;
503 >
504 >        memset(&ipn, 0, sizeof(ipn));
505 >        v6conf = (struct sockaddr_in6 *)&conf->bind;
506 >        v6 = (struct sockaddr_in6 *)&ipn;
507 >
508 >        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
509 >        {
510 >          memcpy(&ipn, &conf->bind, sizeof(ipn));
511 >          ipn.ss.ss_family = AF_INET6;
512 >          ipn.ss_port = 0;
513 >
514 >          comm_connect_tcp(client_p->connection->fd,
515 >                           conf->host, conf->port,
516 >                           (struct sockaddr *)&ipn, ipn.ss_len,
517 >                           server_connect_callback, client_p,
518 >                           conf->aftype, CONNECTTIMEOUT);
519 >        }
520 >        else if (ConfigServerInfo.specific_ipv6_vhost)
521          {
522 <          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
523 <          ipn.ss.ss_family = AF_INET6;
524 <          ipn.ss_port = 0;
525 <          comm_connect_tcp(&client_p->localClient->fd,
526 <                           aconf->host, aconf->port,
527 <                           (struct sockaddr *)&ipn, ipn.ss_len,
528 <                           serv_connect_callback, client_p,
529 <                           aconf->aftype, CONNECTTIMEOUT);
530 <        }
531 <        else
532 <          comm_connect_tcp(&client_p->localClient->fd,
533 <                           aconf->host, aconf->port,
534 <                           NULL, 0, serv_connect_callback, client_p,
535 <                           aconf->aftype, CONNECTTIMEOUT);
522 >          memcpy(&ipn, &ConfigServerInfo.ip6, sizeof(ipn));
523 >          ipn.ss.ss_family = AF_INET6;
524 >          ipn.ss_port = 0;
525 >
526 >          comm_connect_tcp(client_p->connection->fd,
527 >                           conf->host, conf->port,
528 >                           (struct sockaddr *)&ipn, ipn.ss_len,
529 >                           server_connect_callback, client_p,
530 >                           conf->aftype, CONNECTTIMEOUT);
531 >        }
532 >        else
533 >          comm_connect_tcp(client_p->connection->fd,
534 >                           conf->host, conf->port,
535 >                           NULL, 0, server_connect_callback, client_p,
536 >                           conf->aftype, CONNECTTIMEOUT);
537        }
1363 #endif
538    }
539 <  return (1);
539 >
540 >  /*
541 >   * At this point we have a connection in progress and a connect {} block
542 >   * attached to the client, the socket info should be saved in the client
543 >   * and it should either be resolved or have a valid address.
544 >   *
545 >   * The socket has been connected or connect is in progress.
546 >   */
547 >  return 1;
548   }
549  
1368 #ifdef HAVE_LIBCRYPTO
550   static void
551 < finish_ssl_server_handshake(struct Client *client_p)
551 > server_finish_tls_handshake(struct Client *client_p)
552   {
553 <  struct ConfItem *conf=NULL;
554 <  struct AccessItem *aconf=NULL;
555 <
556 <  conf = find_conf_name(&client_p->localClient->confs,
557 <                        client_p->name, SERVER_TYPE);
558 <  if (conf == NULL)
559 <  {
560 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
1380 <                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
1381 <    sendto_realops_flags(UMODE_ALL, L_OPER,
1382 <                         "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
553 >  const struct MaskItem *conf = find_conf_name(&client_p->connection->confs,
554 >                                                client_p->name, CONF_SERVER);
555 >  if (!conf)
556 >  {
557 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
558 >                         "Lost connect{} block for %s", client_get_name(client_p, SHOW_IP));
559 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
560 >                         "Lost connect{} block for %s", client_get_name(client_p, MASK_IP));
561  
562 <    exit_client(client_p, &me, "Lost connect{} block");
562 >    exit_client(client_p, "Lost connect{} block");
563      return;
564    }
565  
566 <  aconf = map_to_conf(conf);
566 >  sendto_one(client_p, "PASS %s TS %u %s", conf->spasswd, TS_CURRENT, me.id);
567  
568 <  /* jdc -- Check and send spasswd, not passwd. */
1391 <  if (!EmptyString(aconf->spasswd))
1392 <    sendto_one(client_p, "PASS %s TS %d %s",
1393 <               aconf->spasswd, TS_CURRENT, me.id);
1394 <
1395 <  send_capabilities(client_p, aconf,
1396 <                   (IsConfTopicBurst(aconf) ? CAP_TBURST|CAP_TB : 0));
568 >  sendto_one(client_p, "CAPAB :%s", capab_get(NULL));
569  
570    sendto_one(client_p, "SERVER %s 1 :%s%s",
571               me.name, ConfigServerHide.hidden ? "(H) " : "",
572               me.info);
573  
1402  /* If we've been marked dead because a send failed, just exit
1403   * here now and save everyone the trouble of us ever existing.
1404   */
1405  if (IsDead(client_p))
1406  {
1407      sendto_realops_flags(UMODE_ALL, L_ADMIN,
1408                           "%s[%s] went dead during handshake",
1409                           client_p->name,
1410                           client_p->host);
1411      sendto_realops_flags(UMODE_ALL, L_OPER,
1412                           "%s went dead during handshake", client_p->name);
1413      return;
1414  }
1415
1416  /* don't move to serv_list yet -- we haven't sent a burst! */
574    /* If we get here, we're ok, so lets start reading some data */
575 <  comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ, read_packet, client_p, 0);
575 >  read_packet(client_p->connection->fd, client_p);
576   }
577  
578   static void
579 < ssl_server_handshake(fde_t *fd, struct Client *client_p)
579 > server_tls_handshake(fde_t *F, void *data)
580   {
581 <  int ret;
582 <  int err;
581 >  struct Client *client_p = data;
582 >  const char *sslerr = NULL;
583  
584 <  ret = SSL_connect(client_p->localClient->fd.ssl);
584 >  assert(client_p);
585 >  assert(client_p->connection);
586 >  assert(client_p->connection->fd);
587 >  assert(client_p->connection->fd == F);
588  
589 <  if (ret <= 0)
589 >  tls_handshake_status_t ret = tls_handshake(&F->ssl, TLS_ROLE_CLIENT, &sslerr);
590 >  if (ret != TLS_HANDSHAKE_DONE)
591    {
592 <    switch ((err = SSL_get_error(client_p->localClient->fd.ssl, ret)))
592 >    if ((CurrentTime - client_p->connection->firsttime) > CONNECTTIMEOUT)
593 >    {
594 >      exit_client(client_p, "Timeout during TLS handshake");
595 >      return;
596 >    }
597 >
598 >    switch (ret)
599      {
600 <      case SSL_ERROR_WANT_WRITE:
601 <        comm_setselect(&client_p->localClient->fd, COMM_SELECT_WRITE,
602 <                       (PF *)ssl_server_handshake, client_p, 0);
600 >      case TLS_HANDSHAKE_WANT_WRITE:
601 >        comm_setselect(F, COMM_SELECT_WRITE,
602 >                       server_tls_handshake, client_p, CONNECTTIMEOUT);
603          return;
604 <      case SSL_ERROR_WANT_READ:
605 <        comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ,
606 <                       (PF *)ssl_server_handshake, client_p, 0);
604 >      case TLS_HANDSHAKE_WANT_READ:
605 >        comm_setselect(F, COMM_SELECT_READ,
606 >                       server_tls_handshake, client_p, CONNECTTIMEOUT);
607          return;
608        default:
609        {
610 <        const char *sslerr = ERR_error_string(ERR_get_error(), NULL);
1444 <        sendto_realops_flags(UMODE_ALL, L_ALL,
610 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
611                               "Error connecting to %s: %s", client_p->name,
612 <                             sslerr ? sslerr : "unknown SSL error");
613 <        exit_client(client_p, client_p, "Error during SSL handshake");
612 >                             sslerr ? sslerr : "unknown TLS error");
613 >        exit_client(client_p, "Error during TLS handshake");
614          return;
615        }
616      }
617    }
618  
619 <  finish_ssl_server_handshake(client_p);
619 >  comm_settimeout(F, 0, NULL, NULL);
620 >
621 >  if (!tls_verify_cert(&F->ssl, ConfigServerInfo.message_digest_algorithm, &client_p->certfp))
622 >    ilog(LOG_TYPE_IRCD, "Server %s!%s@%s gave bad TLS client certificate",
623 >         client_p->name, client_p->username, client_p->host);
624 >
625 >  server_finish_tls_handshake(client_p);
626   }
627  
628   static void
629 < ssl_connect_init(struct Client *client_p, struct AccessItem *aconf, fde_t *fd)
629 > server_tls_connect_init(struct Client *client_p, const struct MaskItem *conf, fde_t *F)
630   {
631 <  if ((client_p->localClient->fd.ssl = SSL_new(ServerInfo.client_ctx)) == NULL)
631 >  assert(client_p);
632 >  assert(client_p->connection);
633 >  assert(client_p->connection->fd);
634 >  assert(client_p->connection->fd == F);
635 >
636 >  if (!tls_new(&F->ssl, F->fd, TLS_ROLE_CLIENT))
637    {
1461    ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
1462         ERR_error_string(ERR_get_error(), NULL));
638      SetDead(client_p);
639 <    exit_client(client_p, client_p, "SSL_new failed");
639 >    exit_client(client_p, "TLS context initialization failed");
640      return;
641    }
642  
643 <  SSL_set_fd(fd->ssl, fd->fd);
644 <
1470 <  if (!EmptyString(aconf->cipher_list))
1471 <    SSL_set_cipher_list(client_p->localClient->fd.ssl, aconf->cipher_list);
643 >  if (!EmptyString(conf->cipher_list))
644 >    tls_set_ciphers(&F->ssl, conf->cipher_list);
645  
646 <  ssl_server_handshake(NULL, client_p);
646 >  server_tls_handshake(F, client_p);
647   }
1475 #endif
648  
649 < /* serv_connect_callback() - complete a server connection.
650 < *
649 > /* server_connect_callback() - complete a server connection.
650 > *
651   * This routine is called after the server connection attempt has
652   * completed. If unsucessful, an error is sent to ops and the client
653   * is closed. If sucessful, it goes through the initialisation/check
# Line 1483 | Line 655 | ssl_connect_init(struct Client *client_p
655   * marked for reading.
656   */
657   static void
658 < serv_connect_callback(fde_t *fd, int status, void *data)
658 > server_connect_callback(fde_t *F, int status, void *data)
659   {
660 <  struct Client *client_p = data;
1489 <  struct ConfItem *conf=NULL;
1490 <  struct AccessItem *aconf=NULL;
660 >  struct Client *const client_p = data;
661  
662 <  /* First, make sure its a real client! */
663 <  assert(client_p != NULL);
664 <  assert(&client_p->localClient->fd == fd);
662 >  /* First, make sure it's a real client! */
663 >  assert(client_p);
664 >  assert(client_p->connection);
665 >  assert(client_p->connection->fd);
666 >  assert(client_p->connection->fd == F);
667  
668    /* Next, for backward purposes, record the ip of the server */
669 <  memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
670 <         sizeof(struct irc_ssaddr));
669 >  memcpy(&client_p->ip, &F->connect.hostaddr, sizeof(client_p->ip));
670 >
671    /* Check the status */
672    if (status != COMM_OK)
673    {
674 <    /* We have an error, so report it and quit
675 <     * Admins get to see any IP, mere opers don't *sigh*
674 >    /* We have an error, so report it and quit */
675 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
676 >                         "Error connecting to %s: %s",
677 >                         client_get_name(client_p, SHOW_IP), comm_errstr(status));
678 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
679 >                         "Error connecting to %s: %s",
680 >                         client_get_name(client_p, MASK_IP), comm_errstr(status));
681 >
682 >    /*
683 >     * If a fd goes bad, call dead_link() the socket is no
684 >     * longer valid for reading or writing.
685       */
686 <     if (ConfigServerHide.hide_server_ips)
687 <       sendto_realops_flags(UMODE_ALL, L_ADMIN,
1507 <                            "Error connecting to %s: %s",
1508 <                            client_p->name, comm_errstr(status));
1509 <     else
1510 <       sendto_realops_flags(UMODE_ALL, L_ADMIN,
1511 <                            "Error connecting to %s[%s]: %s", client_p->name,
1512 <                            client_p->host, comm_errstr(status));
1513 <
1514 <     sendto_realops_flags(UMODE_ALL, L_OPER,
1515 <                          "Error connecting to %s: %s",
1516 <                          client_p->name, comm_errstr(status));
1517 <
1518 <     /* If a fd goes bad, call dead_link() the socket is no
1519 <      * longer valid for reading or writing.
1520 <      */
1521 <     dead_link_on_write(client_p, 0);
1522 <     return;
686 >    dead_link_on_write(client_p, 0);
687 >    return;
688    }
689  
690    /* COMM_OK, so continue the connection procedure */
691 <  /* Get the C/N lines */
692 <  conf = find_conf_name(&client_p->localClient->confs,
693 <                        client_p->name, SERVER_TYPE);
694 <  if (conf == NULL)
695 <  {
696 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
697 <                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
698 <    sendto_realops_flags(UMODE_ALL, L_OPER,
699 <                         "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
691 >  /* Get the connect {} block */
692 >  const struct MaskItem *conf = find_conf_name(&client_p->connection->confs,
693 >                                                client_p->name, CONF_SERVER);
694 >  if (!conf)
695 >  {
696 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
697 >                         "Lost connect{} block for %s", client_get_name(client_p, SHOW_IP));
698 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
699 >                         "Lost connect{} block for %s", client_get_name(client_p, MASK_IP));
700  
701 <    exit_client(client_p, &me, "Lost connect{} block");
701 >    exit_client(client_p, "Lost connect{} block");
702      return;
703    }
704  
1540  aconf = map_to_conf(conf);
705    /* Next, send the initial handshake */
706    SetHandshake(client_p);
707  
708 < #ifdef HAVE_LIBCRYPTO
1545 <  if (IsConfSSL(aconf))
708 >  if (IsConfSSL(conf))
709    {
710 <    ssl_connect_init(client_p, aconf, fd);
710 >    server_tls_connect_init(client_p, conf, F);
711      return;
712    }
1550 #endif
713  
714 <  /* jdc -- Check and send spasswd, not passwd. */
1553 <  if (!EmptyString(aconf->spasswd))
1554 <    sendto_one(client_p, "PASS %s TS %d %s",
1555 <               aconf->spasswd, TS_CURRENT, me.id);
714 >  sendto_one(client_p, "PASS %s TS %u %s", conf->spasswd, TS_CURRENT, me.id);
715  
716 <  send_capabilities(client_p, aconf,
1558 <                   (IsConfTopicBurst(aconf) ? CAP_TBURST|CAP_TB : 0));
716 >  sendto_one(client_p, "CAPAB :%s", capab_get(NULL));
717  
718 <  sendto_one(client_p, "SERVER %s 1 :%s%s",
719 <             me.name, ConfigServerHide.hidden ? "(H) " : "",
1562 <             me.info);
718 >  sendto_one(client_p, "SERVER %s 1 :%s%s", me.name,
719 >             ConfigServerHide.hidden ? "(H) " : "", me.info);
720  
1564  /* If we've been marked dead because a send failed, just exit
1565   * here now and save everyone the trouble of us ever existing.
1566   */
1567  if (IsDead(client_p))
1568  {
1569      sendto_realops_flags(UMODE_ALL, L_ADMIN,
1570                           "%s[%s] went dead during handshake",
1571                           client_p->name,
1572                           client_p->host);
1573      sendto_realops_flags(UMODE_ALL, L_OPER,
1574                           "%s went dead during handshake", client_p->name);
1575      return;
1576  }
1577
1578  /* don't move to serv_list yet -- we haven't sent a burst! */
721    /* If we get here, we're ok, so lets start reading some data */
722 <  comm_setselect(fd, COMM_SELECT_READ, read_packet, client_p, 0);
722 >  read_packet(client_p->connection->fd, client_p);
723   }
724  
725   struct Client *
726   find_servconn_in_progress(const char *name)
727   {
728    dlink_node *ptr;
1587  struct Client *cptr;
729  
730    DLINK_FOREACH(ptr, unknown_list.head)
731    {
732 <    cptr = ptr->data;
732 >    struct Client *cptr = ptr->data;
733  
734 <    if (cptr && cptr->name[0])
735 <      if (match(name, cptr->name))
734 >    if (cptr->name[0])
735 >      if (!irccmp(name, cptr->name))
736          return cptr;
737    }
738 <  
738 >
739    return NULL;
740   }

Comparing:
ircd-hybrid-8/src/s_serv.c (property svn:keywords), Revision 1325 by michael, Sat Mar 31 10:29:02 2012 UTC vs.
ircd-hybrid/trunk/src/server.c (property svn:keywords), Revision 8500 by michael, Thu Apr 5 13:00:49 2018 UTC

# Line 1 | Line 1
1 < Id Revision
1 > Id

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)