ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/server.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_serv.c (file contents), Revision 3246 by michael, Sun Mar 30 17:37:13 2014 UTC vs.
ircd-hybrid/trunk/src/server.c (file contents), Revision 8403 by michael, Sun Mar 18 19:14:36 2018 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2018 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
# Line 25 | Line 25
25   */
26  
27   #include "stdinc.h"
28 #ifdef HAVE_LIBCRYPTO
29 #include <openssl/rsa.h>
30 #include "rsa.h"
31 #endif
28   #include "list.h"
33 #include "channel.h"
34 #include "channel_mode.h"
29   #include "client.h"
30   #include "event.h"
37 #include "fdlist.h"
31   #include "hash.h"
32   #include "irc_string.h"
33   #include "ircd.h"
34   #include "ircd_defs.h"
35   #include "s_bsd.h"
43 #include "numeric.h"
36   #include "packet.h"
45 #include "irc_res.h"
37   #include "conf.h"
38 < #include "s_serv.h"
38 > #include "server.h"
39 > #include "server_capab.h"
40   #include "log.h"
49 #include "s_misc.h"
50 #include "s_user.h"
41   #include "send.h"
42   #include "memory.h"
53 #include "channel.h"
43   #include "parse.h"
44  
56 #define MIN_CONN_FREQ 300
45  
46   dlink_list flatten_links;
47 < static dlink_list cap_list = { NULL, NULL, 0 };
60 < static void server_burst(struct Client *);
61 < static void burst_all(struct Client *);
62 < static void send_tb(struct Client *client_p, struct Channel *chptr);
47 > static void serv_connect_callback(fde_t *, int, void *);
48  
64 static CNCB serv_connect_callback;
65
66 static void burst_members(struct Client *, struct Channel *);
49  
50   /*
51   * write_links_file
# Line 74 | Line 56 | static void burst_members(struct Client
56   *                but in no particular order.
57   */
58   void
59 < write_links_file(void *notused)
59 > write_links_file(void *unused)
60   {
61    FILE *file = NULL;
62 <  dlink_node *ptr = NULL, *ptr_next = NULL;
62 >  dlink_node *node, *node_next;
63    char buff[IRCD_BUFSIZE] = "";
64  
65 <  if ((file = fopen(LIPATH, "w")) == NULL)
65 >  if (EmptyString(ConfigServerHide.flatten_links_file))
66      return;
67  
68 <  DLINK_FOREACH_SAFE(ptr, ptr_next, flatten_links.head)
68 >  if ((file = fopen(ConfigServerHide.flatten_links_file, "w")) == NULL)
69 >  {
70 >    ilog(LOG_TYPE_IRCD, "Couldn't open \"%s\": %s", ConfigServerHide.flatten_links_file,
71 >         strerror(errno));
72 >    return;
73 >  }
74 >
75 >  DLINK_FOREACH_SAFE(node, node_next, flatten_links.head)
76    {
77 <    dlinkDelete(ptr, &flatten_links);
78 <    MyFree(ptr->data);
79 <    free_dlink_node(ptr);
77 >    dlinkDelete(node, &flatten_links);
78 >    xfree(node->data);
79 >    free_dlink_node(node);
80    }
81  
82 <  DLINK_FOREACH(ptr, global_serv_list.head)
82 >  DLINK_FOREACH(node, global_server_list.head)
83    {
84 <    const struct Client *target_p = ptr->data;
84 >    const struct Client *target_p = node->data;
85  
86      /*
87       * Skip hidden servers, aswell as ourselves, since we already send
# Line 129 | Line 118 | read_links_file(void)
118    char *p = NULL;
119    char buff[IRCD_BUFSIZE] = "";
120  
121 <  if ((file = fopen(LIPATH, "r")) == NULL)
121 >  if (EmptyString(ConfigServerHide.flatten_links_file))
122      return;
123  
124 +  if ((file = fopen(ConfigServerHide.flatten_links_file, "r")) == NULL)
125 +  {
126 +    ilog(LOG_TYPE_IRCD, "Couldn't open \"%s\": %s", ConfigServerHide.flatten_links_file,
127 +         strerror(errno));
128 +    return;
129 +  }
130 +
131    while (fgets(buff, sizeof(buff), file))
132    {
133      if ((p = strchr(buff, '\n')))
# Line 143 | Line 139 | read_links_file(void)
139    fclose(file);
140   }
141  
142 < /* hunt_server()
142 > /* server_hunt()
143   *      Do the basic thing in delivering the message (command)
144   *      across the relays to the specific server (server) for
145   *      actions.
# Line 162 | Line 158 | read_links_file(void)
158   *
159   *      returns: (see #defines)
160   */
161 < int
162 < hunt_server(struct Client *source_p, const char *command,
161 > const struct server_hunt *
162 > server_hunt(struct Client *source_p, const char *command,
163              const int server, const int parc, char *parv[])
164   {
165 <  struct Client *target_p = NULL;
166 <  struct Client *target_tmp = NULL;
167 <  dlink_node *ptr;
172 <  int wilds;
165 >  static struct server_hunt hunt;
166 >  struct server_hunt *const h = &hunt;
167 >  dlink_node *node;
168  
169    /* Assume it's me, if no server */
170    if (parc <= server || EmptyString(parv[server]))
171 <    return HUNTED_ISME;
171 >  {
172 >    h->target_p = &me;
173 >    h->ret = HUNTED_ISME;
174 >    return h;
175 >  }
176  
177 <  if (!strcmp(parv[server], me.id) || !match(parv[server], me.name))
178 <    return HUNTED_ISME;
177 >  if ((h->target_p = find_person(source_p, parv[server])) == NULL)
178 >    h->target_p = hash_find_server(parv[server]);
179  
180 <  /* These are to pickup matches that would cause the following
180 >  /*
181 >   * These are to pickup matches that would cause the following
182     * message to go in the wrong direction while doing quick fast
183     * non-matching lookups.
184     */
185 <  if (MyClient(source_p))
186 <    target_p = hash_find_client(parv[server]);
187 <  else
188 <    target_p = find_person(source_p, parv[server]);
185 >  if (h->target_p)
186 >    if (h->target_p->from == source_p->from && !MyConnect(h->target_p))
187 >      h->target_p = NULL;
188  
189 <  if (target_p)
191 <    if (target_p->from == source_p->from && !MyConnect(target_p))
192 <      target_p = NULL;
193 <
194 <  if (target_p == NULL && (target_p = hash_find_server(parv[server])))
195 <    if (target_p->from == source_p->from && !MyConnect(target_p))
196 <      target_p = NULL;
197 <
198 <  wilds = has_wildcards(parv[server]);
199 <
200 <  /* Again, if there are no wild cards involved in the server
201 <   * name, use the hash lookup
202 <   */
203 <  if (target_p == NULL)
189 >  if (!h->target_p && has_wildcards(parv[server]))
190    {
191 <    if (!wilds)
191 >    DLINK_FOREACH(node, global_server_list.head)
192      {
193 <      if (!(target_p = hash_find_server(parv[server])))
193 >      struct Client *tmp = node->data;
194 >
195 >      assert(IsMe(tmp) || IsServer(tmp));
196 >      if (!match(parv[server], tmp->name))
197        {
198 <        sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
199 <        return HUNTED_NOSUCH;
198 >        if (tmp->from == source_p->from && !MyConnect(tmp))
199 >          continue;
200 >
201 >        h->target_p = tmp;
202 >        break;
203        }
204      }
205 <    else
205 >
206 >    if (!h->target_p)
207      {
208 <      DLINK_FOREACH(ptr, global_client_list.head)
208 >      DLINK_FOREACH(node, global_client_list.head)
209        {
210 <        target_tmp = ptr->data;
210 >        struct Client *tmp = node->data;
211  
212 <        if (!match(parv[server], target_tmp->name))
212 >        assert(IsClient(tmp));
213 >        if (!match(parv[server], tmp->name))
214          {
215 <          if (target_tmp->from == source_p->from && !MyConnect(target_tmp))
215 >          if (tmp->from == source_p->from && !MyConnect(tmp))
216              continue;
223          target_p = ptr->data;
217  
218 <          if (IsRegistered(target_p) && (target_p != source_p->from))
219 <            break;
218 >          h->target_p = tmp;
219 >          break;
220          }
221        }
222      }
223    }
224  
225 <  if (target_p)
225 >  if (h->target_p)
226    {
227 <    if (!IsRegistered(target_p))
227 >    assert(IsMe(h->target_p) || IsServer(h->target_p) || IsClient(h->target_p));
228 >    if (IsMe(h->target_p) || MyClient(h->target_p))
229      {
230 <      sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
231 <      return HUNTED_NOSUCH;
230 >      h->ret = HUNTED_ISME;
231 >      return h;
232      }
233  
234 <    if (IsMe(target_p) || MyClient(target_p))
235 <      return HUNTED_ISME;
242 <
243 <    if (match(target_p->name, parv[server]))
244 <      parv[server] = target_p->name;
245 <
246 <    /* This is a little kludgy but should work... */
247 <    sendto_one(target_p, command, ID_or_name(source_p, target_p),
234 >    parv[server] = h->target_p->id;
235 >    sendto_one(h->target_p, command, source_p->id,
236                 parv[1], parv[2], parv[3], parv[4],
237                 parv[5], parv[6], parv[7], parv[8]);
238 <    return HUNTED_PASS;
238 >    h->ret = HUNTED_PASS;
239 >    return h;
240    }
241  
242    sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
243 <  return HUNTED_NOSUCH;
243 >  h->ret = HUNTED_NOSUCH;
244 >  return h;
245   }
246  
247   /* try_connections()
# Line 267 | Line 257 | hunt_server(struct Client *source_p, con
257   void
258   try_connections(void *unused)
259   {
260 <  dlink_node *ptr = NULL;
271 <  struct MaskItem *conf;
272 <  int confrq;
260 >  dlink_node *node;
261  
274  /* TODO: change this to set active flag to 0 when added to event! --Habeeb */
262    if (GlobalSetOptions.autoconn == 0)
263      return;
264  
265 <  DLINK_FOREACH(ptr, server_items.head)
265 >  DLINK_FOREACH(node, connect_items.head)
266    {
267 <    conf = ptr->data;
267 >    struct MaskItem *conf = node->data;
268  
269      assert(conf->type == CONF_SERVER);
270 +    assert(conf->class);
271  
272 <    /* Also when already connecting! (update holdtimes) --SRB
273 <     */
286 <    if (!conf->port ||!IsConfAllowAutoConn(conf))
272 >    /* Also when already connecting! (update holdtimes) --SRB */
273 >    if (!conf->port || !IsConfAllowAutoConn(conf))
274        continue;
275  
276 <
277 <    /* Skip this entry if the use of it is still on hold until
276 >    /*
277 >     * Skip this entry if the use of it is still on hold until
278       * future. Otherwise handle this entry (and set it on hold
279       * until next time). Will reset only hold times, if already
280       * made one successfull connection... [this algorithm is
# Line 296 | Line 283 | try_connections(void *unused)
283      if (conf->until > CurrentTime)
284        continue;
285  
286 <    if (conf->class == NULL)
300 <      confrq = DEFAULT_CONNECTFREQUENCY;
301 <    else
302 <    {
303 <      confrq = conf->class->con_freq;
304 <      if (confrq < MIN_CONN_FREQ)
305 <        confrq = MIN_CONN_FREQ;
306 <    }
307 <
308 <    conf->until = CurrentTime + confrq;
286 >    conf->until = CurrentTime + conf->class->con_freq;
287  
288      /*
289       * Found a CONNECT config with port specified, scan clients
# Line 316 | Line 294 | try_connections(void *unused)
294  
295      if (conf->class->ref_count < conf->class->max_total)
296      {
297 <      /* Go to the end of the list, if not already last */
298 <      if (ptr->next)
297 >      /* Move this entry to the end of the list, if not already last */
298 >      if (node->next)
299        {
300 <        dlinkDelete(ptr, &server_items);
301 <        dlinkAddTail(conf, &conf->node, &server_items);
300 >        dlinkDelete(node, &connect_items);
301 >        dlinkAddTail(conf, &conf->node, &connect_items);
302        }
303  
304        if (find_servconn_in_progress(conf->name))
# Line 336 | Line 314 | try_connections(void *unused)
314         *   -- adrian
315         */
316        if (ConfigServerHide.hide_server_ips)
317 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
317 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
318                               "Connection to %s activated.",
319                               conf->name);
320        else
321 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
321 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
322                               "Connection to %s[%s] activated.",
323                               conf->name, conf->host);
324  
# Line 354 | Line 332 | try_connections(void *unused)
332   int
333   valid_servname(const char *name)
334   {
335 <  unsigned int length = 0;
358 <  unsigned int dots   = 0;
335 >  unsigned int dots = 0;
336    const char *p = name;
337  
338    for (; *p; ++p)
# Line 363 | Line 340 | valid_servname(const char *name)
340      if (!IsServChar(*p))
341        return 0;
342  
366    ++length;
367
343      if (*p == '.')
344        ++dots;
345    }
346  
347 <  return dots && length <= HOSTLEN;
373 < }
374 <
375 < int
376 < check_server(const char *name, struct Client *client_p)
377 < {
378 <  dlink_node *ptr;
379 <  struct MaskItem *conf        = NULL;
380 <  struct MaskItem *server_conf = NULL;
381 <  int error = -1;
382 <
383 <  assert(client_p);
384 <
385 <  /* loop through looking for all possible connect items that might work */
386 <  DLINK_FOREACH(ptr, server_items.head)
387 <  {
388 <    conf = ptr->data;
389 <
390 <    if (match(name, conf->name))
391 <      continue;
392 <
393 <    error = -3;
394 <
395 <    /* XXX: Fix me for IPv6                    */
396 <    /* XXX sockhost is the IPv4 ip as a string */
397 <    if (!match(conf->host, client_p->host) ||
398 <        !match(conf->host, client_p->sockhost))
399 <    {
400 <      error = -2;
401 <
402 <      if (!match_conf_password(client_p->localClient->passwd, conf))
403 <        return -2;
404 <
405 <      if (!EmptyString(conf->certfp))
406 <        if (EmptyString(client_p->certfp) || strcasecmp(client_p->certfp, conf->certfp))
407 <          return -4;
408 <
409 <      server_conf = conf;
410 <    }
411 <  }
412 <
413 <  if (server_conf == NULL)
414 <    return error;
415 <
416 <  attach_conf(client_p, server_conf);
417 <
418 <
419 <  if (server_conf)
420 <  {
421 <    struct sockaddr_in *v4;
422 < #ifdef IPV6
423 <    struct sockaddr_in6 *v6;
424 < #endif
425 <    switch (server_conf->aftype)
426 <    {
427 < #ifdef IPV6
428 <      case AF_INET6:
429 <        v6 = (struct sockaddr_in6 *)&server_conf->addr;
430 <
431 <        if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
432 <          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
433 <        break;
434 < #endif
435 <      case AF_INET:
436 <        v4 = (struct sockaddr_in *)&server_conf->addr;
437 <
438 <        if (v4->sin_addr.s_addr == INADDR_NONE)
439 <          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
440 <        break;
441 <    }
442 <  }
443 <
444 <  return 0;
445 < }
446 <
447 < /* add_capability()
448 < *
449 < * inputs       - string name of CAPAB
450 < *              - int flag of capability
451 < * output       - NONE
452 < * side effects - Adds given capability name and bit mask to
453 < *                current supported capabilities. This allows
454 < *                modules to dynamically add or subtract their capability.
455 < */
456 < void
457 < add_capability(const char *capab_name, int cap_flag, int add_to_default)
458 < {
459 <  struct Capability *cap = MyMalloc(sizeof(*cap));
460 <
461 <  cap->name = xstrdup(capab_name);
462 <  cap->cap = cap_flag;
463 <  dlinkAdd(cap, &cap->node, &cap_list);
464 <
465 <  if (add_to_default)
466 <    default_server_capabs |= cap_flag;
467 < }
468 <
469 < /* delete_capability()
470 < *
471 < * inputs       - string name of CAPAB
472 < * output       - NONE
473 < * side effects - delete given capability from ones known.
474 < */
475 < int
476 < delete_capability(const char *capab_name)
477 < {
478 <  dlink_node *ptr;
479 <  dlink_node *next_ptr;
480 <  struct Capability *cap;
481 <
482 <  DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
483 <  {
484 <    cap = ptr->data;
485 <
486 <    if (cap->cap != 0)
487 <    {
488 <      if (irccmp(cap->name, capab_name) == 0)
489 <      {
490 <        default_server_capabs &= ~(cap->cap);
491 <        dlinkDelete(ptr, &cap_list);
492 <        MyFree(cap->name);
493 <        MyFree(cap);
494 <      }
495 <    }
496 <  }
497 <
498 <  return 0;
499 < }
500 <
501 < /*
502 < * find_capability()
503 < *
504 < * inputs       - string name of capab to find
505 < * output       - 0 if not found CAPAB otherwise
506 < * side effects - none
507 < */
508 < unsigned int
509 < find_capability(const char *capab)
510 < {
511 <  const dlink_node *ptr = NULL;
512 <
513 <  DLINK_FOREACH(ptr, cap_list.head)
514 <  {
515 <    const struct Capability *cap = ptr->data;
516 <
517 <    if (cap->cap && !irccmp(cap->name, capab))
518 <      return cap->cap;
519 <  }
520 <
521 <  return 0;
522 < }
523 <
524 < /* send_capabilities()
525 < *
526 < * inputs       - Client pointer to send to
527 < *              - int flag of capabilities that this server can send
528 < * output       - NONE
529 < * side effects - send the CAPAB line to a server  -orabidoo
530 < *
531 < */
532 < void
533 < send_capabilities(struct Client *client_p, int cap_can_send)
534 < {
535 <  char msgbuf[IRCD_BUFSIZE] = "";
536 <  char *t = msgbuf;
537 <  int tl;
538 <  dlink_node *ptr = NULL;
539 <
540 <  DLINK_FOREACH(ptr, cap_list.head)
541 <  {
542 <    struct Capability *cap = ptr->data;
543 <
544 <    if (cap->cap & (cap_can_send|default_server_capabs))
545 <    {
546 <      tl = sprintf(t, "%s ", cap->name);
547 <      t += tl;
548 <    }
549 <  }
550 <
551 <  *(t - 1) = '\0';
552 <  sendto_one(client_p, "CAPAB :%s", msgbuf);
553 < }
554 <
555 < /* sendnick_TS()
556 < *
557 < * inputs       - client (server) to send nick towards
558 < *          - client to send nick for
559 < * output       - NONE
560 < * side effects - NICK message is sent towards given client_p
561 < */
562 < void
563 < sendnick_TS(struct Client *client_p, struct Client *target_p)
564 < {
565 <  char ubuf[IRCD_BUFSIZE] = "";
566 <
567 <  if (!IsClient(target_p))
568 <    return;
569 <
570 <  send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
571 <
572 <  if (ubuf[0] == '\0')
573 <  {
574 <    ubuf[0] = '+';
575 <    ubuf[1] = '\0';
576 <  }
577 <
578 <  if (IsCapable(client_p, CAP_SVS))
579 <    sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
580 <               target_p->servptr->id,
581 <               target_p->name, target_p->hopcount + 1,
582 <               (unsigned long) target_p->tsinfo,
583 <               ubuf, target_p->username, target_p->host,
584 <               (MyClient(target_p) && IsIPSpoof(target_p)) ?
585 <               "0" : target_p->sockhost, target_p->id,
586 <               target_p->svid, target_p->info);
587 <  else
588 <    sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
589 <               target_p->servptr->id,
590 <               target_p->name, target_p->hopcount + 1,
591 <               (unsigned long) target_p->tsinfo,
592 <               ubuf, target_p->username, target_p->host,
593 <               (MyClient(target_p) && IsIPSpoof(target_p)) ?
594 <               "0" : target_p->sockhost, target_p->id, target_p->info);
595 <
596 <  if (!EmptyString(target_p->certfp))
597 <    sendto_one(client_p, ":%s CERTFP %s", target_p->id, target_p->certfp);
598 <
599 <  if (target_p->away[0])
600 <    sendto_one(client_p, ":%s AWAY :%s", target_p->id, target_p->away);
601 <
602 < }
603 <
604 < /*
605 < * show_capabilities - show current server capabilities
606 < *
607 < * inputs       - pointer to a struct Client
608 < * output       - pointer to static string
609 < * side effects - build up string representing capabilities of server listed
610 < */
611 < const char *
612 < show_capabilities(const struct Client *target_p)
613 < {
614 <  static char msgbuf[IRCD_BUFSIZE] = "";
615 <  const dlink_node *ptr = NULL;
616 <
617 <  strlcpy(msgbuf, "TS", sizeof(msgbuf));
618 <
619 <  DLINK_FOREACH(ptr, cap_list.head)
620 <  {
621 <    const struct Capability *cap = ptr->data;
622 <
623 <    if (!IsCapable(target_p, cap->cap))
624 <      continue;
625 <
626 <    strlcat(msgbuf,       " ", sizeof(msgbuf));
627 <    strlcat(msgbuf, cap->name, sizeof(msgbuf));
628 <  }
629 <
630 <  return msgbuf;
347 >  return dots && (p - name) <= HOSTLEN;
348   }
349  
350   /* make_server()
# Line 641 | Line 358 | struct Server *
358   make_server(struct Client *client_p)
359   {
360    if (client_p->serv == NULL)
361 <    client_p->serv = MyMalloc(sizeof(struct Server));
361 >    client_p->serv = xcalloc(sizeof(*client_p->serv));
362  
363    return client_p->serv;
364   }
365  
649 /* server_estab()
650 *
651 * inputs       - pointer to a struct Client
652 * output       -
653 * side effects -
654 */
655 void
656 server_estab(struct Client *client_p)
657 {
658  struct MaskItem *conf = NULL;
659  char *host;
660  const char *inpath;
661  static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
662  dlink_node *ptr;
663 #ifdef HAVE_LIBCRYPTO
664  const COMP_METHOD *compression = NULL, *expansion = NULL;
665 #endif
666
667  assert(client_p);
668
669  strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
670
671  inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
672  host   = client_p->name;
673
674  if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
675      == NULL)
676  {
677    /* This shouldn't happen, better tell the ops... -A1kmm */
678    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
679                         "Warning: Lost connect{} block "
680                         "for server %s(this shouldn't happen)!", host);
681    exit_client(client_p, "Lost connect{} block!");
682    return;
683  }
684
685  MyFree(client_p->localClient->passwd);
686  client_p->localClient->passwd = NULL;
687
688  /* Its got identd, since its a server */
689  SetGotId(client_p);
690
691  /* If there is something in the serv_list, it might be this
692   * connecting server..
693   */
694  if (!ServerInfo.hub && serv_list.head)
695  {
696    if (client_p != serv_list.head->data || serv_list.head->next)
697    {
698      ++ServerStats.is_ref;
699      sendto_one(client_p, "ERROR :I'm a leaf not a hub");
700      exit_client(client_p, "I'm a leaf");
701      return;
702    }
703  }
704
705  if (IsUnknown(client_p))
706  {
707    sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
708
709    send_capabilities(client_p, 0);
710
711    sendto_one(client_p, "SERVER %s 1 :%s%s",
712               me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
713  }
714
715  sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
716             (unsigned long)CurrentTime);
717
718  /* XXX Does this ever happen? I don't think so -db */
719  detach_conf(client_p, CONF_OPER);
720
721  /* *WARNING*
722  **    In the following code in place of plain server's
723  **    name we send what is returned by get_client_name
724  **    which may add the "sockhost" after the name. It's
725  **    *very* *important* that there is a SPACE between
726  **    the name and sockhost (if present). The receiving
727  **    server will start the information field from this
728  **    first blank and thus puts the sockhost into info.
729  **    ...a bit tricky, but you have been warned, besides
730  **    code is more neat this way...  --msa
731  */
732  client_p->servptr = &me;
733
734  if (IsClosing(client_p))
735    return;
736
737  SetServer(client_p);
738
739  /* Some day, all these lists will be consolidated *sigh* */
740  dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
741
742  assert(dlinkFind(&unknown_list, client_p));
743
744  dlink_move_node(&client_p->localClient->lclient_node,
745                  &unknown_list, &serv_list);
746
747  Count.myserver++;
748
749  dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
750  hash_add_client(client_p);
751  hash_add_id(client_p);
752
753  /* doesnt duplicate client_p->serv if allocated this struct already */
754  make_server(client_p);
755
756  /* fixing eob timings.. -gnp */
757  client_p->localClient->firsttime = CurrentTime;
758
759  if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
760    AddFlag(client_p, FLAGS_SERVICE);
761
762  /* Show the real host/IP to admins */
763 #ifdef HAVE_LIBCRYPTO
764  if (client_p->localClient->fd.ssl)
765  {
766    compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
767    expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
768
769    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
770                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
771                         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
772                         compression ? SSL_COMP_get_name(compression) : "NONE",
773                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
774                         show_capabilities(client_p));
775    /* Now show the masked hostname/IP to opers */
776    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
777                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
778                         inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
779                         compression ? SSL_COMP_get_name(compression) : "NONE",
780                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
781                         show_capabilities(client_p));
782    ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
783         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
784         compression ? SSL_COMP_get_name(compression) : "NONE",
785         expansion ? SSL_COMP_get_name(expansion) : "NONE",
786         show_capabilities(client_p));
787  }
788  else
789 #endif
790  {
791    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
792                         "Link with %s established: (Capabilities: %s)",
793                         inpath_ip, show_capabilities(client_p));
794    /* Now show the masked hostname/IP to opers */
795    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
796                         "Link with %s established: (Capabilities: %s)",
797                         inpath, show_capabilities(client_p));
798    ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
799         inpath_ip, show_capabilities(client_p));
800  }
801
802  fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
803
804  sendto_server(client_p, NOCAPS, NOCAPS, ":%s SID %s 2 %s :%s%s",
805                me.id, client_p->name, client_p->id,
806                IsHidden(client_p) ? "(H) " : "", client_p->info);
807
808  /*
809   * Pass on my client information to the new server
810   *
811   * First, pass only servers (idea is that if the link gets
812   * cancelled beacause the server was already there,
813   * there are no NICK's to be cancelled...). Of course,
814   * if cancellation occurs, all this info is sent anyway,
815   * and I guess the link dies when a read is attempted...? --msa
816   *
817   * Note: Link cancellation to occur at this point means
818   * that at least two servers from my fragment are building
819   * up connection this other fragment at the same time, it's
820   * a race condition, not the normal way of operation...
821   *
822   * ALSO NOTE: using the get_client_name for server names--
823   *    see previous *WARNING*!!! (Also, original inpath
824   *    is destroyed...)
825   */
826
827  DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
828  {
829    struct Client *target_p = ptr->data;
830
831    /* target_p->from == target_p for target_p == client_p */
832    if (IsMe(target_p) || target_p->from == client_p)
833      continue;
834
835    sendto_one(client_p, ":%s SID %s %d %s :%s%s",
836               target_p->servptr->id, target_p->name, target_p->hopcount+1,
837               target_p->id, IsHidden(target_p) ? "(H) " : "",
838               target_p->info);
839
840    if (HasFlag(target_p, FLAGS_EOB))
841      sendto_one(client_p, ":%s EOB", target_p->id, client_p);
842  }
843
844  server_burst(client_p);
845 }
846
847 /* server_burst()
848 *
849 * inputs       - struct Client pointer server
850 *              -
851 * output       - none
852 * side effects - send a server burst
853 * bugs         - still too long
854 */
855 static void
856 server_burst(struct Client *client_p)
857 {
858  /* Send it in the shortened format with the TS, if
859  ** it's a TS server; walk the list of channels, sending
860  ** all the nicks that haven't been sent yet for each
861  ** channel, then send the channel itself -- it's less
862  ** obvious than sending all nicks first, but on the
863  ** receiving side memory will be allocated more nicely
864  ** saving a few seconds in the handling of a split
865  ** -orabidoo
866  */
867
868  burst_all(client_p);
869
870  /* EOB stuff is now in burst_all */
871  /* Always send a PING after connect burst is done */
872  sendto_one(client_p, "PING :%s", me.id);
873 }
874
875 /* burst_all()
876 *
877 * inputs       - pointer to server to send burst to
878 * output       - NONE
879 * side effects - complete burst of channels/nicks is sent to client_p
880 */
881 static void
882 burst_all(struct Client *client_p)
883 {
884  dlink_node *ptr = NULL;
885
886  DLINK_FOREACH(ptr, global_channel_list.head)
887  {
888    struct Channel *chptr = ptr->data;
889
890    if (dlink_list_length(&chptr->members))
891    {
892      burst_members(client_p, chptr);
893      send_channel_modes(client_p, chptr);
894
895      if (IsCapable(client_p, CAP_TBURST))
896        send_tb(client_p, chptr);
897    }
898  }
899
900  /* also send out those that are not on any channel
901   */
902  DLINK_FOREACH(ptr, global_client_list.head)
903  {
904    struct Client *target_p = ptr->data;
905
906    if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
907      sendnick_TS(client_p, target_p);
908
909    DelFlag(target_p, FLAGS_BURSTED);
910  }
911
912  if (IsCapable(client_p, CAP_EOB))
913    sendto_one(client_p, ":%s EOB", me.id);
914 }
915
916 /*
917 * send_tb
918 *
919 * inputs       - pointer to Client
920 *              - pointer to channel
921 * output       - NONE
922 * side effects - Called on a server burst when
923 *                server is CAP_TBURST capable
924 */
925 static void
926 send_tb(struct Client *client_p, struct Channel *chptr)
927 {
928  /*
929   * We may also send an empty topic here, but only if topic_time isn't 0,
930   * i.e. if we had a topic that got unset.  This is required for syncing
931   * topics properly.
932   *
933   * Imagine the following scenario: Our downlink introduces a channel
934   * to us with a TS that is equal to ours, but the channel topic on
935   * their side got unset while the servers were in splitmode, which means
936   * their 'topic' is newer.  They simply wanted to unset it, so we have to
937   * deal with it in a more sophisticated fashion instead of just resetting
938   * it to their old topic they had before.  Read m_tburst.c:ms_tburst
939   * for further information   -Michael
940   */
941  if (chptr->topic_time)
942    sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s", me.id,
943               (unsigned long)chptr->channelts, chptr->chname,
944               (unsigned long)chptr->topic_time,
945               chptr->topic_info,
946               chptr->topic);
947 }
948
949 /* burst_members()
950 *
951 * inputs       - pointer to server to send members to
952 *              - dlink_list pointer to membership list to send
953 * output       - NONE
954 * side effects -
955 */
956 static void
957 burst_members(struct Client *client_p, struct Channel *chptr)
958 {
959  struct Client *target_p;
960  struct Membership *ms;
961  dlink_node *ptr;
962
963  DLINK_FOREACH(ptr, chptr->members.head)
964  {
965    ms       = ptr->data;
966    target_p = ms->client_p;
967
968    if (!HasFlag(target_p, FLAGS_BURSTED))
969    {
970      AddFlag(target_p, FLAGS_BURSTED);
971
972      if (target_p->from != client_p)
973        sendnick_TS(client_p, target_p);
974    }
975  }
976 }
977
366   /* New server connection code
367   * Based upon the stuff floating about in s_bsd.c
368   *   -- adrian
# Line 999 | Line 387 | burst_members(struct Client *client_p, s
387   int
388   serv_connect(struct MaskItem *conf, struct Client *by)
389   {
1002  struct Client *client_p = NULL;
390    char buf[HOSTIPLEN + 1] = "";
391  
392    /* conversion structs */
# Line 1007 | Line 394 | serv_connect(struct MaskItem *conf, stru
394  
395    /* Make sure conf is useful */
396    assert(conf);
397 +  assert(conf->type == CONF_SERVER);
398 +  assert(hash_find_server(conf->name) == NULL);  /* This should have been checked by the caller */
399  
400 <  getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
400 >  getnameinfo((const struct sockaddr *)&conf->addr, conf->addr.ss_len,
401                buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
402    ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", conf->name, conf->host,
403         buf);
# Line 1016 | Line 405 | serv_connect(struct MaskItem *conf, stru
405    /* Still processing a DNS lookup? -> exit */
406    if (conf->dns_pending)
407    {
408 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
408 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
409                           "Error connecting to %s: DNS lookup for connect{} in progress.",
410                           conf->name);
411      return 0;
# Line 1024 | Line 413 | serv_connect(struct MaskItem *conf, stru
413  
414    if (conf->dns_failed)
415    {
416 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
416 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
417                           "Error connecting to %s: DNS lookup for connect{} failed.",
418                           conf->name);
419      return 0;
420    }
421  
422 <  /* Make sure this server isn't already connected
423 <   * Note: conf should ALWAYS be a valid C: line
424 <   */
1036 <  if ((client_p = hash_find_server(conf->name)))
422 >  /* Create a socket for the server connection */
423 >  int fd = comm_socket(conf->addr.ss.ss_family, SOCK_STREAM, 0);
424 >  if (fd == -1)
425    {
426 <    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
427 <                         "Server %s already present from %s",
1040 <                         conf->name, get_client_name(client_p, SHOW_IP));
1041 <    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1042 <                         "Server %s already present from %s",
1043 <                         conf->name, get_client_name(client_p, MASK_IP));
1044 <    if (by && IsClient(by) && !MyClient(by))
1045 <      sendto_one_notice(by, &me, ":Server %s already present from %s",
1046 <                        conf->name, get_client_name(client_p, MASK_IP));
426 >    /* Eek, failure to create the socket */
427 >    report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
428      return 0;
429    }
430  
431    /* Create a local client */
432 <  client_p = make_client(NULL);
432 >  struct Client *client_p = client_make(NULL);
433  
434    /* Copy in the server, hostname, fd */
435    strlcpy(client_p->name, conf->name, sizeof(client_p->name));
# Line 1057 | Line 438 | serv_connect(struct MaskItem *conf, stru
438    /* We already converted the ip once, so lets use it - stu */
439    strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
440  
441 <  /* create a socket for the server connection */
1061 <  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1062 <                SOCK_STREAM, 0, NULL) < 0)
1063 <  {
1064 <    /* Eek, failure to create the socket */
1065 <    report_error(L_ALL, "opening stream socket to %s: %s",
1066 <                 conf->name, errno);
1067 <    SetDead(client_p);
1068 <    exit_client(client_p, "Connection failed");
1069 <    return 0;
1070 <  }
441 >  client_p->connection->fd = fd_open(fd, 1, NULL);
442  
443 <  /* servernames are always guaranteed under HOSTLEN chars */
444 <  fd_note(&client_p->localClient->fd, "Server: %s", conf->name);
443 >  /* Server names are always guaranteed under HOSTLEN chars */
444 >  fd_note(client_p->connection->fd, "Server: %s", client_p->name);
445  
446 <  /* Attach config entries to client here rather than in
447 <   * serv_connect_callback(). This to avoid null pointer references.
446 >  /*
447 >   * Attach config entries to client here rather than in serv_connect_callback().
448 >   * This to avoid null pointer references.
449     */
450 <  if (!attach_connect_block(client_p, conf->name, conf->host))
1079 <  {
1080 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1081 <                         "Host %s is not enabled for connecting: no connect{} block",
1082 <                         conf->name);
1083 <    if (by && IsClient(by) && !MyClient(by))
1084 <      sendto_one_notice(by, &me, ":Connect to host %s failed.", client_p->name);
450 >  conf_attach(client_p, conf);
451  
452 <    SetDead(client_p);
453 <    exit_client(client_p, "Connection failed");
454 <    return 0;
455 <  }
1090 <
1091 <  /* at this point we have a connection in progress and C/N lines
1092 <   * attached to the client, the socket info should be saved in the
1093 <   * client and it should either be resolved or have a valid address.
452 >  /*
453 >   * At this point we have a connection in progress and a connect {} block
454 >   * attached to the client, the socket info should be saved in the client
455 >   * and it should either be resolved or have a valid address.
456     *
457     * The socket has been connected or connect is in progress.
458     */
# Line 1102 | Line 464 | serv_connect(struct MaskItem *conf, stru
464      strlcpy(client_p->serv->by, "AutoConn.", sizeof(client_p->serv->by));
465  
466    SetConnecting(client_p);
467 <  dlinkAdd(client_p, &client_p->node, &global_client_list);
1106 <  /* from def_fam */
1107 <  client_p->localClient->aftype = conf->aftype;
467 >  client_p->connection->aftype = conf->aftype;
468  
469    /* Now, initiate the connection */
470    /* XXX assume that a non 0 type means a specific bind address
# Line 1114 | Line 474 | serv_connect(struct MaskItem *conf, stru
474    {
475      case AF_INET:
476        v4 = (struct sockaddr_in*)&conf->bind;
477 +
478        if (v4->sin_addr.s_addr)
479        {
480          struct irc_ssaddr ipn;
481 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
481 >
482 >        memset(&ipn, 0, sizeof(ipn));
483          ipn.ss.ss_family = AF_INET;
484          ipn.ss_port = 0;
485 <        memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
486 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
485 >        memcpy(&ipn, &conf->bind, sizeof(ipn));
486 >
487 >        comm_connect_tcp(client_p->connection->fd, conf->host, conf->port,
488                           (struct sockaddr *)&ipn, ipn.ss_len,
489                           serv_connect_callback, client_p, conf->aftype,
490                           CONNECTTIMEOUT);
491        }
492 <      else if (ServerInfo.specific_ipv4_vhost)
492 >      else if (ConfigServerInfo.specific_ipv4_vhost)
493        {
494          struct irc_ssaddr ipn;
495 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
495 >
496 >        memset(&ipn, 0, sizeof(ipn));
497          ipn.ss.ss_family = AF_INET;
498          ipn.ss_port = 0;
499 <        memcpy(&ipn, &ServerInfo.ip, sizeof(struct irc_ssaddr));
500 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
499 >        memcpy(&ipn, &ConfigServerInfo.ip, sizeof(ipn));
500 >
501 >        comm_connect_tcp(client_p->connection->fd, conf->host, conf->port,
502                           (struct sockaddr *)&ipn, ipn.ss_len,
503                           serv_connect_callback, client_p, conf->aftype,
504                           CONNECTTIMEOUT);
505        }
506        else
507 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
507 >        comm_connect_tcp(client_p->connection->fd, conf->host, conf->port,
508                           NULL, 0, serv_connect_callback, client_p, conf->aftype,
509                           CONNECTTIMEOUT);
510        break;
1146 #ifdef IPV6
511      case AF_INET6:
512        {
513          struct irc_ssaddr ipn;
514          struct sockaddr_in6 *v6;
515          struct sockaddr_in6 *v6conf;
516  
517 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
517 >        memset(&ipn, 0, sizeof(ipn));
518          v6conf = (struct sockaddr_in6 *)&conf->bind;
519          v6 = (struct sockaddr_in6 *)&ipn;
520  
521          if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
522          {
523 <          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
523 >          memcpy(&ipn, &conf->bind, sizeof(ipn));
524            ipn.ss.ss_family = AF_INET6;
525            ipn.ss_port = 0;
526 <          comm_connect_tcp(&client_p->localClient->fd,
526 >
527 >          comm_connect_tcp(client_p->connection->fd,
528                             conf->host, conf->port,
529                             (struct sockaddr *)&ipn, ipn.ss_len,
530                             serv_connect_callback, client_p,
531                             conf->aftype, CONNECTTIMEOUT);
532          }
533 <        else if (ServerInfo.specific_ipv6_vhost)
533 >        else if (ConfigServerInfo.specific_ipv6_vhost)
534          {
535 <          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
535 >          memcpy(&ipn, &ConfigServerInfo.ip6, sizeof(ipn));
536            ipn.ss.ss_family = AF_INET6;
537            ipn.ss_port = 0;
538 <          comm_connect_tcp(&client_p->localClient->fd,
538 >
539 >          comm_connect_tcp(client_p->connection->fd,
540                             conf->host, conf->port,
541                             (struct sockaddr *)&ipn, ipn.ss_len,
542                             serv_connect_callback, client_p,
543                             conf->aftype, CONNECTTIMEOUT);
544          }
545          else
546 <          comm_connect_tcp(&client_p->localClient->fd,
546 >          comm_connect_tcp(client_p->connection->fd,
547                             conf->host, conf->port,
548                             NULL, 0, serv_connect_callback, client_p,
549                             conf->aftype, CONNECTTIMEOUT);
550        }
1185 #endif
551    }
552 +
553    return 1;
554   }
555  
1190 #ifdef HAVE_LIBCRYPTO
556   static void
557   finish_ssl_server_handshake(struct Client *client_p)
558   {
559 <  struct MaskItem *conf = NULL;
560 <
561 <  conf = find_conf_name(&client_p->localClient->confs,
562 <                        client_p->name, CONF_SERVER);
563 <  if (conf == NULL)
564 <  {
565 <    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
566 <                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
1202 <    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1203 <                         "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
559 >  const struct MaskItem *conf = find_conf_name(&client_p->connection->confs,
560 >                                                client_p->name, CONF_SERVER);
561 >  if (!conf)
562 >  {
563 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
564 >                         "Lost connect{} block for %s", client_get_name(client_p, SHOW_IP));
565 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
566 >                         "Lost connect{} block for %s", client_get_name(client_p, MASK_IP));
567  
568      exit_client(client_p, "Lost connect{} block");
569      return;
570    }
571  
572 <  sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
572 >  sendto_one(client_p, "PASS %s TS %u %s", conf->spasswd, TS_CURRENT, me.id);
573  
574 <  send_capabilities(client_p, 0);
574 >  sendto_one(client_p, "CAPAB :%s", capab_get(NULL));
575  
576    sendto_one(client_p, "SERVER %s 1 :%s%s",
577               me.name, ConfigServerHide.hidden ? "(H) " : "",
578               me.info);
579  
1217  /* If we've been marked dead because a send failed, just exit
1218   * here now and save everyone the trouble of us ever existing.
1219   */
1220  if (IsDead(client_p))
1221  {
1222      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1223                           "%s[%s] went dead during handshake",
1224                           client_p->name,
1225                           client_p->host);
1226      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1227                           "%s went dead during handshake", client_p->name);
1228      return;
1229  }
1230
1231  /* don't move to serv_list yet -- we haven't sent a burst! */
580    /* If we get here, we're ok, so lets start reading some data */
581 <  comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ, read_packet, client_p, 0);
581 >  read_packet(client_p->connection->fd, client_p);
582   }
583  
584   static void
585 < ssl_server_handshake(fde_t *fd, struct Client *client_p)
585 > ssl_server_handshake(fde_t *F, void *data)
586   {
587 <  X509 *cert = NULL;
588 <  int ret = 0;
587 >  struct Client *client_p = data;
588 >  const char *sslerr = NULL;
589  
590 <  if ((ret = SSL_connect(client_p->localClient->fd.ssl)) <= 0)
590 >  assert(client_p);
591 >  assert(client_p->connection);
592 >  assert(client_p->connection->fd);
593 >  assert(client_p->connection->fd == F);
594 >
595 >  tls_handshake_status_t ret = tls_handshake(&F->ssl, TLS_ROLE_CLIENT, &sslerr);
596 >  if (ret != TLS_HANDSHAKE_DONE)
597    {
598 <    switch (SSL_get_error(client_p->localClient->fd.ssl, ret))
598 >    if ((CurrentTime - client_p->connection->firsttime) > CONNECTTIMEOUT)
599      {
600 <      case SSL_ERROR_WANT_WRITE:
601 <        comm_setselect(&client_p->localClient->fd, COMM_SELECT_WRITE,
602 <                       (PF *)ssl_server_handshake, client_p, 0);
600 >      exit_client(client_p, "Timeout during TLS handshake");
601 >      return;
602 >    }
603 >
604 >    switch (ret)
605 >    {
606 >      case TLS_HANDSHAKE_WANT_WRITE:
607 >        comm_setselect(F, COMM_SELECT_WRITE,
608 >                       ssl_server_handshake, client_p, CONNECTTIMEOUT);
609          return;
610 <      case SSL_ERROR_WANT_READ:
611 <        comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ,
612 <                       (PF *)ssl_server_handshake, client_p, 0);
610 >      case TLS_HANDSHAKE_WANT_READ:
611 >        comm_setselect(F, COMM_SELECT_READ,
612 >                       ssl_server_handshake, client_p, CONNECTTIMEOUT);
613          return;
614        default:
615        {
616 <        const char *sslerr = ERR_error_string(ERR_get_error(), NULL);
1257 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
616 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
617                               "Error connecting to %s: %s", client_p->name,
618 <                             sslerr ? sslerr : "unknown SSL error");
619 <        exit_client(client_p, "Error during SSL handshake");
618 >                             sslerr ? sslerr : "unknown TLS error");
619 >        exit_client(client_p, "Error during TLS handshake");
620          return;
621        }
622      }
623    }
624  
625 <  if ((cert = SSL_get_peer_certificate(client_p->localClient->fd.ssl)))
1267 <  {
1268 <    int res = SSL_get_verify_result(client_p->localClient->fd.ssl);
1269 <    char buf[EVP_MAX_MD_SIZE * 2 + 1] = { '\0' };
1270 <    unsigned char md[EVP_MAX_MD_SIZE] = { '\0' };
1271 <
1272 <    if (res == X509_V_OK || res == X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN ||
1273 <        res == X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE ||
1274 <        res == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT)
1275 <    {
1276 <      unsigned int i = 0, n = 0;
625 >  comm_settimeout(F, 0, NULL, NULL);
626  
627 <      if (X509_digest(cert, EVP_sha256(), md, &n))
628 <      {
629 <        for (; i < n; ++i)
1281 <          snprintf(buf + 2 * i, 3, "%02X", md[i]);
1282 <        client_p->certfp = xstrdup(buf);
1283 <      }
1284 <    }
1285 <    else
1286 <      ilog(LOG_TYPE_IRCD, "Server %s!%s@%s gave bad SSL client certificate: %d",
1287 <           client_p->name, client_p->username, client_p->host, res);
1288 <    X509_free(cert);
1289 <  }
627 >  if (!tls_verify_cert(&F->ssl, ConfigServerInfo.message_digest_algorithm, &client_p->certfp))
628 >    ilog(LOG_TYPE_IRCD, "Server %s!%s@%s gave bad TLS client certificate",
629 >         client_p->name, client_p->username, client_p->host);
630  
631    finish_ssl_server_handshake(client_p);
632   }
633  
634   static void
635 < ssl_connect_init(struct Client *client_p, struct MaskItem *conf, fde_t *fd)
635 > ssl_connect_init(struct Client *client_p, const struct MaskItem *conf, fde_t *F)
636   {
637 <  if ((client_p->localClient->fd.ssl = SSL_new(ServerInfo.client_ctx)) == NULL)
637 >  assert(client_p);
638 >  assert(client_p->connection);
639 >  assert(client_p->connection->fd);
640 >  assert(client_p->connection->fd == F);
641 >
642 >  if (!tls_new(&F->ssl, F->fd, TLS_ROLE_CLIENT))
643    {
1299    ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
1300         ERR_error_string(ERR_get_error(), NULL));
644      SetDead(client_p);
645 <    exit_client(client_p, "SSL_new failed");
645 >    exit_client(client_p, "TLS context initialization failed");
646      return;
647    }
648  
1306  SSL_set_fd(fd->ssl, fd->fd);
1307
649    if (!EmptyString(conf->cipher_list))
650 <    SSL_set_cipher_list(client_p->localClient->fd.ssl, conf->cipher_list);
650 >    tls_set_ciphers(&F->ssl, conf->cipher_list);
651  
652 <  ssl_server_handshake(NULL, client_p);
652 >  ssl_server_handshake(F, client_p);
653   }
1313 #endif
654  
655   /* serv_connect_callback() - complete a server connection.
656   *
# Line 1321 | Line 661 | ssl_connect_init(struct Client *client_p
661   * marked for reading.
662   */
663   static void
664 < serv_connect_callback(fde_t *fd, int status, void *data)
664 > serv_connect_callback(fde_t *F, int status, void *data)
665   {
666 <  struct Client *client_p = data;
1327 <  struct MaskItem *conf = NULL;
666 >  struct Client *const client_p = data;
667  
668 <  /* First, make sure its a real client! */
668 >  /* First, make sure it's a real client! */
669    assert(client_p);
670 <  assert(&client_p->localClient->fd == fd);
670 >  assert(client_p->connection);
671 >  assert(client_p->connection->fd);
672 >  assert(client_p->connection->fd == F);
673  
674    /* Next, for backward purposes, record the ip of the server */
675 <  memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
1335 <         sizeof(struct irc_ssaddr));
675 >  memcpy(&client_p->connection->ip, &F->connect.hostaddr, sizeof(client_p->connection->ip));
676  
677    /* Check the status */
678    if (status != COMM_OK)
679    {
680 <    /* We have an error, so report it and quit
681 <     * Admins get to see any IP, mere opers don't *sigh*
680 >    /* We have an error, so report it and quit */
681 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
682 >                         "Error connecting to %s: %s",
683 >                         client_get_name(client_p, SHOW_IP), comm_errstr(status));
684 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
685 >                         "Error connecting to %s: %s",
686 >                         client_get_name(client_p, MASK_IP), comm_errstr(status));
687 >
688 >    /*
689 >     * If a fd goes bad, call dead_link() the socket is no
690 >     * longer valid for reading or writing.
691       */
692 <     if (ConfigServerHide.hide_server_ips)
693 <       sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1345 <                            "Error connecting to %s: %s",
1346 <                            client_p->name, comm_errstr(status));
1347 <     else
1348 <       sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1349 <                            "Error connecting to %s[%s]: %s", client_p->name,
1350 <                            client_p->host, comm_errstr(status));
1351 <
1352 <     sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1353 <                          "Error connecting to %s: %s",
1354 <                          client_p->name, comm_errstr(status));
1355 <
1356 <     /* If a fd goes bad, call dead_link() the socket is no
1357 <      * longer valid for reading or writing.
1358 <      */
1359 <     dead_link_on_write(client_p, 0);
1360 <     return;
692 >    dead_link_on_write(client_p, 0);
693 >    return;
694    }
695  
696    /* COMM_OK, so continue the connection procedure */
697 <  /* Get the C/N lines */
698 <  conf = find_conf_name(&client_p->localClient->confs,
699 <                        client_p->name, CONF_SERVER);
700 <  if (conf == NULL)
701 <  {
702 <    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
703 <                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
704 <    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
705 <                         "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
697 >  /* Get the connect {} block */
698 >  const struct MaskItem *conf = find_conf_name(&client_p->connection->confs,
699 >                                                client_p->name, CONF_SERVER);
700 >  if (!conf)
701 >  {
702 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
703 >                         "Lost connect{} block for %s", client_get_name(client_p, SHOW_IP));
704 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
705 >                         "Lost connect{} block for %s", client_get_name(client_p, MASK_IP));
706  
707      exit_client(client_p, "Lost connect{} block");
708      return;
# Line 1378 | Line 711 | serv_connect_callback(fde_t *fd, int sta
711    /* Next, send the initial handshake */
712    SetHandshake(client_p);
713  
1381 #ifdef HAVE_LIBCRYPTO
714    if (IsConfSSL(conf))
715    {
716 <    ssl_connect_init(client_p, conf, fd);
716 >    ssl_connect_init(client_p, conf, F);
717      return;
718    }
1387 #endif
719  
720 <  sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
720 >  sendto_one(client_p, "PASS %s TS %u %s", conf->spasswd, TS_CURRENT, me.id);
721  
722 <  send_capabilities(client_p, 0);
722 >  sendto_one(client_p, "CAPAB :%s", capab_get(NULL));
723  
724    sendto_one(client_p, "SERVER %s 1 :%s%s", me.name,
725               ConfigServerHide.hidden ? "(H) " : "", me.info);
726  
1396  /* If we've been marked dead because a send failed, just exit
1397   * here now and save everyone the trouble of us ever existing.
1398   */
1399  if (IsDead(client_p))
1400  {
1401      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1402                           "%s[%s] went dead during handshake",
1403                           client_p->name,
1404                           client_p->host);
1405      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1406                           "%s went dead during handshake", client_p->name);
1407      return;
1408  }
1409
1410  /* don't move to serv_list yet -- we haven't sent a burst! */
727    /* If we get here, we're ok, so lets start reading some data */
728 <  comm_setselect(fd, COMM_SELECT_READ, read_packet, client_p, 0);
728 >  read_packet(client_p->connection->fd, client_p);
729   }
730  
731   struct Client *
732   find_servconn_in_progress(const char *name)
733   {
734    dlink_node *ptr;
1419  struct Client *cptr;
735  
736    DLINK_FOREACH(ptr, unknown_list.head)
737    {
738 <    cptr = ptr->data;
738 >    struct Client *cptr = ptr->data;
739  
740 <    if (cptr && cptr->name[0])
741 <      if (!match(name, cptr->name))
740 >    if (cptr->name[0])
741 >      if (!irccmp(name, cptr->name))
742          return cptr;
743    }
744  

Comparing:
ircd-hybrid/trunk/src/s_serv.c (property svn:keywords), Revision 3246 by michael, Sun Mar 30 17:37:13 2014 UTC vs.
ircd-hybrid/trunk/src/server.c (property svn:keywords), Revision 8403 by michael, Sun Mar 18 19:14:36 2018 UTC

# Line 1 | Line 1
1 < Id Revision
1 > Id

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)