ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/server.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_serv.c (file contents), Revision 3246 by michael, Sun Mar 30 17:37:13 2014 UTC vs.
ircd-hybrid/trunk/src/server.c (file contents), Revision 7957 by michael, Sun Mar 5 11:53:49 2017 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2017 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
# Line 25 | Line 25
25   */
26  
27   #include "stdinc.h"
28 #ifdef HAVE_LIBCRYPTO
29 #include <openssl/rsa.h>
30 #include "rsa.h"
31 #endif
28   #include "list.h"
33 #include "channel.h"
34 #include "channel_mode.h"
29   #include "client.h"
30   #include "event.h"
37 #include "fdlist.h"
31   #include "hash.h"
32   #include "irc_string.h"
33   #include "ircd.h"
34   #include "ircd_defs.h"
35   #include "s_bsd.h"
43 #include "numeric.h"
36   #include "packet.h"
45 #include "irc_res.h"
37   #include "conf.h"
38 < #include "s_serv.h"
38 > #include "server.h"
39   #include "log.h"
49 #include "s_misc.h"
50 #include "s_user.h"
40   #include "send.h"
41   #include "memory.h"
53 #include "channel.h"
42   #include "parse.h"
43  
56 #define MIN_CONN_FREQ 300
44  
45   dlink_list flatten_links;
46 < static dlink_list cap_list = { NULL, NULL, 0 };
47 < static void server_burst(struct Client *);
61 < static void burst_all(struct Client *);
62 < static void send_tb(struct Client *client_p, struct Channel *chptr);
46 > static dlink_list server_capabilities_list;
47 > static void serv_connect_callback(fde_t *, int, void *);
48  
64 static CNCB serv_connect_callback;
65
66 static void burst_members(struct Client *, struct Channel *);
49  
50   /*
51   * write_links_file
# Line 74 | Line 56 | static void burst_members(struct Client
56   *                but in no particular order.
57   */
58   void
59 < write_links_file(void *notused)
59 > write_links_file(void *unused)
60   {
61    FILE *file = NULL;
62 <  dlink_node *ptr = NULL, *ptr_next = NULL;
62 >  dlink_node *node = NULL, *node_next = NULL;
63    char buff[IRCD_BUFSIZE] = "";
64  
65 <  if ((file = fopen(LIPATH, "w")) == NULL)
65 >  if (EmptyString(ConfigServerHide.flatten_links_file))
66 >    return;
67 >
68 >  if ((file = fopen(ConfigServerHide.flatten_links_file, "w")) == NULL)
69 >  {
70 >    ilog(LOG_TYPE_IRCD, "Couldn't open \"%s\": %s", ConfigServerHide.flatten_links_file,
71 >         strerror(errno));
72      return;
73 +  }
74  
75 <  DLINK_FOREACH_SAFE(ptr, ptr_next, flatten_links.head)
75 >  DLINK_FOREACH_SAFE(node, node_next, flatten_links.head)
76    {
77 <    dlinkDelete(ptr, &flatten_links);
78 <    MyFree(ptr->data);
79 <    free_dlink_node(ptr);
77 >    dlinkDelete(node, &flatten_links);
78 >    xfree(node->data);
79 >    free_dlink_node(node);
80    }
81  
82 <  DLINK_FOREACH(ptr, global_serv_list.head)
82 >  DLINK_FOREACH(node, global_server_list.head)
83    {
84 <    const struct Client *target_p = ptr->data;
84 >    const struct Client *target_p = node->data;
85  
86      /*
87       * Skip hidden servers, aswell as ourselves, since we already send
# Line 129 | Line 118 | read_links_file(void)
118    char *p = NULL;
119    char buff[IRCD_BUFSIZE] = "";
120  
121 <  if ((file = fopen(LIPATH, "r")) == NULL)
121 >  if (EmptyString(ConfigServerHide.flatten_links_file))
122 >    return;
123 >
124 >  if ((file = fopen(ConfigServerHide.flatten_links_file, "r")) == NULL)
125 >  {
126 >    ilog(LOG_TYPE_IRCD, "Couldn't open \"%s\": %s", ConfigServerHide.flatten_links_file,
127 >         strerror(errno));
128      return;
129 +  }
130  
131    while (fgets(buff, sizeof(buff), file))
132    {
# Line 143 | Line 139 | read_links_file(void)
139    fclose(file);
140   }
141  
142 < /* hunt_server()
142 > /* server_hunt()
143   *      Do the basic thing in delivering the message (command)
144   *      across the relays to the specific server (server) for
145   *      actions.
# Line 163 | Line 159 | read_links_file(void)
159   *      returns: (see #defines)
160   */
161   int
162 < hunt_server(struct Client *source_p, const char *command,
162 > server_hunt(struct Client *source_p, const char *command,
163              const int server, const int parc, char *parv[])
164   {
165    struct Client *target_p = NULL;
166 <  struct Client *target_tmp = NULL;
171 <  dlink_node *ptr;
172 <  int wilds;
166 >  dlink_node *node = NULL;
167  
168    /* Assume it's me, if no server */
169    if (parc <= server || EmptyString(parv[server]))
170      return HUNTED_ISME;
171  
172 <  if (!strcmp(parv[server], me.id) || !match(parv[server], me.name))
173 <    return HUNTED_ISME;
172 >  if ((target_p = find_person(source_p, parv[server])) == NULL)
173 >    target_p = hash_find_server(parv[server]);
174  
175 <  /* These are to pickup matches that would cause the following
175 >  /*
176 >   * These are to pickup matches that would cause the following
177     * message to go in the wrong direction while doing quick fast
178     * non-matching lookups.
179     */
185  if (MyClient(source_p))
186    target_p = hash_find_client(parv[server]);
187  else
188    target_p = find_person(source_p, parv[server]);
189
180    if (target_p)
181      if (target_p->from == source_p->from && !MyConnect(target_p))
182        target_p = NULL;
183  
184 <  if (target_p == NULL && (target_p = hash_find_server(parv[server])))
195 <    if (target_p->from == source_p->from && !MyConnect(target_p))
196 <      target_p = NULL;
197 <
198 <  wilds = has_wildcards(parv[server]);
199 <
200 <  /* Again, if there are no wild cards involved in the server
201 <   * name, use the hash lookup
202 <   */
203 <  if (target_p == NULL)
184 >  if (!target_p && has_wildcards(parv[server]))
185    {
186 <    if (!wilds)
186 >    DLINK_FOREACH(node, global_server_list.head)
187      {
188 <      if (!(target_p = hash_find_server(parv[server])))
188 >      struct Client *tmp = node->data;
189 >
190 >      assert(IsMe(tmp) || IsServer(tmp));
191 >      if (!match(parv[server], tmp->name))
192        {
193 <        sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
194 <        return HUNTED_NOSUCH;
193 >        if (tmp->from == source_p->from && !MyConnect(tmp))
194 >          continue;
195 >
196 >        target_p = node->data;
197 >        break;
198        }
199      }
200 <    else
200 >
201 >    if (!target_p)
202      {
203 <      DLINK_FOREACH(ptr, global_client_list.head)
203 >      DLINK_FOREACH(node, global_client_list.head)
204        {
205 <        target_tmp = ptr->data;
205 >        struct Client *tmp = node->data;
206  
207 <        if (!match(parv[server], target_tmp->name))
207 >        assert(IsMe(tmp) || IsServer(tmp) || IsClient(tmp));
208 >        if (!match(parv[server], tmp->name))
209          {
210 <          if (target_tmp->from == source_p->from && !MyConnect(target_tmp))
210 >          if (tmp->from == source_p->from && !MyConnect(tmp))
211              continue;
223          target_p = ptr->data;
212  
213 <          if (IsRegistered(target_p) && (target_p != source_p->from))
214 <            break;
213 >          target_p = node->data;
214 >          break;
215          }
216        }
217      }
# Line 231 | Line 219 | hunt_server(struct Client *source_p, con
219  
220    if (target_p)
221    {
222 <    if (!IsRegistered(target_p))
235 <    {
236 <      sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
237 <      return HUNTED_NOSUCH;
238 <    }
239 <
222 >    assert(IsMe(target_p) || IsServer(target_p) || IsClient(target_p));
223      if (IsMe(target_p) || MyClient(target_p))
224        return HUNTED_ISME;
225  
226 <    if (match(target_p->name, parv[server]))
227 <      parv[server] = target_p->name;
245 <
246 <    /* This is a little kludgy but should work... */
247 <    sendto_one(target_p, command, ID_or_name(source_p, target_p),
226 >    parv[server] = target_p->id;
227 >    sendto_one(target_p, command, source_p->id,
228                 parv[1], parv[2], parv[3], parv[4],
229                 parv[5], parv[6], parv[7], parv[8]);
230      return HUNTED_PASS;
# Line 267 | Line 247 | hunt_server(struct Client *source_p, con
247   void
248   try_connections(void *unused)
249   {
250 <  dlink_node *ptr = NULL;
271 <  struct MaskItem *conf;
272 <  int confrq;
250 >  dlink_node *node = NULL;
251  
274  /* TODO: change this to set active flag to 0 when added to event! --Habeeb */
252    if (GlobalSetOptions.autoconn == 0)
253      return;
254  
255 <  DLINK_FOREACH(ptr, server_items.head)
255 >  DLINK_FOREACH(node, connect_items.head)
256    {
257 <    conf = ptr->data;
257 >    struct MaskItem *conf = node->data;
258  
259      assert(conf->type == CONF_SERVER);
260  
261 <    /* Also when already connecting! (update holdtimes) --SRB
262 <     */
286 <    if (!conf->port ||!IsConfAllowAutoConn(conf))
261 >    /* Also when already connecting! (update holdtimes) --SRB */
262 >    if (!conf->port || !IsConfAllowAutoConn(conf))
263        continue;
264  
265 <
266 <    /* Skip this entry if the use of it is still on hold until
265 >    /*
266 >     * Skip this entry if the use of it is still on hold until
267       * future. Otherwise handle this entry (and set it on hold
268       * until next time). Will reset only hold times, if already
269       * made one successfull connection... [this algorithm is
# Line 296 | Line 272 | try_connections(void *unused)
272      if (conf->until > CurrentTime)
273        continue;
274  
275 <    if (conf->class == NULL)
300 <      confrq = DEFAULT_CONNECTFREQUENCY;
301 <    else
302 <    {
303 <      confrq = conf->class->con_freq;
304 <      if (confrq < MIN_CONN_FREQ)
305 <        confrq = MIN_CONN_FREQ;
306 <    }
275 >    assert(conf->class);
276  
277 <    conf->until = CurrentTime + confrq;
277 >    conf->until = CurrentTime + conf->class->con_freq;
278  
279      /*
280       * Found a CONNECT config with port specified, scan clients
# Line 316 | Line 285 | try_connections(void *unused)
285  
286      if (conf->class->ref_count < conf->class->max_total)
287      {
288 <      /* Go to the end of the list, if not already last */
289 <      if (ptr->next)
288 >      /* Move this entry to the end of the list, if not already last */
289 >      if (node->next)
290        {
291 <        dlinkDelete(ptr, &server_items);
292 <        dlinkAddTail(conf, &conf->node, &server_items);
291 >        dlinkDelete(node, &connect_items);
292 >        dlinkAddTail(conf, &conf->node, &connect_items);
293        }
294  
295        if (find_servconn_in_progress(conf->name))
# Line 336 | Line 305 | try_connections(void *unused)
305         *   -- adrian
306         */
307        if (ConfigServerHide.hide_server_ips)
308 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
308 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
309                               "Connection to %s activated.",
310                               conf->name);
311        else
312 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
312 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
313                               "Connection to %s[%s] activated.",
314                               conf->name, conf->host);
315  
# Line 354 | Line 323 | try_connections(void *unused)
323   int
324   valid_servname(const char *name)
325   {
326 <  unsigned int length = 0;
358 <  unsigned int dots   = 0;
326 >  unsigned int dots = 0;
327    const char *p = name;
328  
329    for (; *p; ++p)
# Line 363 | Line 331 | valid_servname(const char *name)
331      if (!IsServChar(*p))
332        return 0;
333  
366    ++length;
367
334      if (*p == '.')
335        ++dots;
336    }
337  
338 <  return dots && length <= HOSTLEN;
338 >  return dots && (p - name) <= HOSTLEN;
339   }
340  
341 < int
342 < check_server(const char *name, struct Client *client_p)
341 > /* server_capab_init()
342 > *
343 > * inputs       - none
344 > * output       - none
345 > */
346 > void
347 > server_capab_init(void)
348   {
349 <  dlink_node *ptr;
350 <  struct MaskItem *conf        = NULL;
351 <  struct MaskItem *server_conf = NULL;
352 <  int error = -1;
353 <
354 <  assert(client_p);
384 <
385 <  /* loop through looking for all possible connect items that might work */
386 <  DLINK_FOREACH(ptr, server_items.head)
387 <  {
388 <    conf = ptr->data;
389 <
390 <    if (match(name, conf->name))
391 <      continue;
392 <
393 <    error = -3;
394 <
395 <    /* XXX: Fix me for IPv6                    */
396 <    /* XXX sockhost is the IPv4 ip as a string */
397 <    if (!match(conf->host, client_p->host) ||
398 <        !match(conf->host, client_p->sockhost))
399 <    {
400 <      error = -2;
401 <
402 <      if (!match_conf_password(client_p->localClient->passwd, conf))
403 <        return -2;
404 <
405 <      if (!EmptyString(conf->certfp))
406 <        if (EmptyString(client_p->certfp) || strcasecmp(client_p->certfp, conf->certfp))
407 <          return -4;
408 <
409 <      server_conf = conf;
410 <    }
411 <  }
412 <
413 <  if (server_conf == NULL)
414 <    return error;
415 <
416 <  attach_conf(client_p, server_conf);
417 <
418 <
419 <  if (server_conf)
420 <  {
421 <    struct sockaddr_in *v4;
422 < #ifdef IPV6
423 <    struct sockaddr_in6 *v6;
424 < #endif
425 <    switch (server_conf->aftype)
426 <    {
427 < #ifdef IPV6
428 <      case AF_INET6:
429 <        v6 = (struct sockaddr_in6 *)&server_conf->addr;
430 <
431 <        if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
432 <          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
433 <        break;
434 < #endif
435 <      case AF_INET:
436 <        v4 = (struct sockaddr_in *)&server_conf->addr;
437 <
438 <        if (v4->sin_addr.s_addr == INADDR_NONE)
439 <          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
440 <        break;
441 <    }
442 <  }
443 <
444 <  return 0;
349 >  add_capability("QS", CAPAB_QS);
350 >  add_capability("EOB", CAPAB_EOB);
351 >  add_capability("CLUSTER", CAPAB_CLUSTER);
352 >  add_capability("SVS", CAPAB_SVS);
353 >  add_capability("CHW", CAPAB_CHW);
354 >  add_capability("HOPS", CAPAB_HOPS);
355   }
356  
357   /* add_capability()
# Line 454 | Line 364 | check_server(const char *name, struct Cl
364   *                modules to dynamically add or subtract their capability.
365   */
366   void
367 < add_capability(const char *capab_name, int cap_flag, int add_to_default)
367 > add_capability(const char *name, unsigned int flag)
368   {
369 <  struct Capability *cap = MyMalloc(sizeof(*cap));
460 <
461 <  cap->name = xstrdup(capab_name);
462 <  cap->cap = cap_flag;
463 <  dlinkAdd(cap, &cap->node, &cap_list);
369 >  struct Capability *cap = xcalloc(sizeof(*cap));
370  
371 <  if (add_to_default)
372 <    default_server_capabs |= cap_flag;
371 >  cap->name = xstrdup(name);
372 >  cap->cap = flag;
373 >  dlinkAdd(cap, &cap->node, &server_capabilities_list);
374   }
375  
376   /* delete_capability()
# Line 472 | Line 379 | add_capability(const char *capab_name, i
379   * output       - NONE
380   * side effects - delete given capability from ones known.
381   */
382 < int
383 < delete_capability(const char *capab_name)
382 > void
383 > delete_capability(const char *name)
384   {
385 <  dlink_node *ptr;
479 <  dlink_node *next_ptr;
480 <  struct Capability *cap;
385 >  dlink_node *node = NULL, *node_next = NULL;
386  
387 <  DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
387 >  DLINK_FOREACH_SAFE(node, node_next, server_capabilities_list.head)
388    {
389 <    cap = ptr->data;
389 >    struct Capability *cap = node->data;
390  
391 <    if (cap->cap != 0)
391 >    if (!irccmp(cap->name, name))
392      {
393 <      if (irccmp(cap->name, capab_name) == 0)
394 <      {
395 <        default_server_capabs &= ~(cap->cap);
491 <        dlinkDelete(ptr, &cap_list);
492 <        MyFree(cap->name);
493 <        MyFree(cap);
494 <      }
393 >      dlinkDelete(node, &server_capabilities_list);
394 >      xfree(cap->name);
395 >      xfree(cap);
396      }
397    }
497
498  return 0;
398   }
399  
400   /*
# Line 506 | Line 405 | delete_capability(const char *capab_name
405   * side effects - none
406   */
407   unsigned int
408 < find_capability(const char *capab)
408 > find_capability(const char *name)
409   {
410 <  const dlink_node *ptr = NULL;
410 >  dlink_node *node;
411  
412 <  DLINK_FOREACH(ptr, cap_list.head)
412 >  DLINK_FOREACH(node, server_capabilities_list.head)
413    {
414 <    const struct Capability *cap = ptr->data;
414 >    const struct Capability *cap = node->data;
415  
416 <    if (cap->cap && !irccmp(cap->name, capab))
416 >    if (!irccmp(cap->name, name))
417        return cap->cap;
418    }
419  
420    return 0;
421   }
422  
524 /* send_capabilities()
525 *
526 * inputs       - Client pointer to send to
527 *              - int flag of capabilities that this server can send
528 * output       - NONE
529 * side effects - send the CAPAB line to a server  -orabidoo
530 *
531 */
532 void
533 send_capabilities(struct Client *client_p, int cap_can_send)
534 {
535  char msgbuf[IRCD_BUFSIZE] = "";
536  char *t = msgbuf;
537  int tl;
538  dlink_node *ptr = NULL;
539
540  DLINK_FOREACH(ptr, cap_list.head)
541  {
542    struct Capability *cap = ptr->data;
543
544    if (cap->cap & (cap_can_send|default_server_capabs))
545    {
546      tl = sprintf(t, "%s ", cap->name);
547      t += tl;
548    }
549  }
550
551  *(t - 1) = '\0';
552  sendto_one(client_p, "CAPAB :%s", msgbuf);
553 }
554
555 /* sendnick_TS()
556 *
557 * inputs       - client (server) to send nick towards
558 *          - client to send nick for
559 * output       - NONE
560 * side effects - NICK message is sent towards given client_p
561 */
562 void
563 sendnick_TS(struct Client *client_p, struct Client *target_p)
564 {
565  char ubuf[IRCD_BUFSIZE] = "";
566
567  if (!IsClient(target_p))
568    return;
569
570  send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
571
572  if (ubuf[0] == '\0')
573  {
574    ubuf[0] = '+';
575    ubuf[1] = '\0';
576  }
577
578  if (IsCapable(client_p, CAP_SVS))
579    sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
580               target_p->servptr->id,
581               target_p->name, target_p->hopcount + 1,
582               (unsigned long) target_p->tsinfo,
583               ubuf, target_p->username, target_p->host,
584               (MyClient(target_p) && IsIPSpoof(target_p)) ?
585               "0" : target_p->sockhost, target_p->id,
586               target_p->svid, target_p->info);
587  else
588    sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
589               target_p->servptr->id,
590               target_p->name, target_p->hopcount + 1,
591               (unsigned long) target_p->tsinfo,
592               ubuf, target_p->username, target_p->host,
593               (MyClient(target_p) && IsIPSpoof(target_p)) ?
594               "0" : target_p->sockhost, target_p->id, target_p->info);
595
596  if (!EmptyString(target_p->certfp))
597    sendto_one(client_p, ":%s CERTFP %s", target_p->id, target_p->certfp);
598
599  if (target_p->away[0])
600    sendto_one(client_p, ":%s AWAY :%s", target_p->id, target_p->away);
601
602 }
603
423   /*
424   * show_capabilities - show current server capabilities
425   *
# Line 609 | Line 428 | sendnick_TS(struct Client *client_p, str
428   * side effects - build up string representing capabilities of server listed
429   */
430   const char *
431 < show_capabilities(const struct Client *target_p)
431 > get_capabilities(const struct Client *client_p)
432   {
433 <  static char msgbuf[IRCD_BUFSIZE] = "";
434 <  const dlink_node *ptr = NULL;
433 >  static char buf[IRCD_BUFSIZE] = "";
434 >  dlink_node *node;
435  
436 <  strlcpy(msgbuf, "TS", sizeof(msgbuf));
436 >  buf[0] = '\0';
437  
438 <  DLINK_FOREACH(ptr, cap_list.head)
438 >  DLINK_FOREACH(node, server_capabilities_list.head)
439    {
440 <    const struct Capability *cap = ptr->data;
440 >    const struct Capability *cap = node->data;
441  
442 <    if (!IsCapable(target_p, cap->cap))
442 >    if (client_p && !IsCapable(client_p, cap->cap))
443        continue;
444  
445 <    strlcat(msgbuf,       " ", sizeof(msgbuf));
446 <    strlcat(msgbuf, cap->name, sizeof(msgbuf));
445 >    strlcat(buf, cap->name, sizeof(buf));
446 >
447 >    if (node->next)
448 >      strlcat(buf, " ", sizeof(buf));
449    }
450  
451 <  return msgbuf;
451 >  return buf;
452   }
453  
454   /* make_server()
# Line 641 | Line 462 | struct Server *
462   make_server(struct Client *client_p)
463   {
464    if (client_p->serv == NULL)
465 <    client_p->serv = MyMalloc(sizeof(struct Server));
465 >    client_p->serv = xcalloc(sizeof(struct Server));
466  
467    return client_p->serv;
468   }
469  
649 /* server_estab()
650 *
651 * inputs       - pointer to a struct Client
652 * output       -
653 * side effects -
654 */
655 void
656 server_estab(struct Client *client_p)
657 {
658  struct MaskItem *conf = NULL;
659  char *host;
660  const char *inpath;
661  static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
662  dlink_node *ptr;
663 #ifdef HAVE_LIBCRYPTO
664  const COMP_METHOD *compression = NULL, *expansion = NULL;
665 #endif
666
667  assert(client_p);
668
669  strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
670
671  inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
672  host   = client_p->name;
673
674  if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
675      == NULL)
676  {
677    /* This shouldn't happen, better tell the ops... -A1kmm */
678    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
679                         "Warning: Lost connect{} block "
680                         "for server %s(this shouldn't happen)!", host);
681    exit_client(client_p, "Lost connect{} block!");
682    return;
683  }
684
685  MyFree(client_p->localClient->passwd);
686  client_p->localClient->passwd = NULL;
687
688  /* Its got identd, since its a server */
689  SetGotId(client_p);
690
691  /* If there is something in the serv_list, it might be this
692   * connecting server..
693   */
694  if (!ServerInfo.hub && serv_list.head)
695  {
696    if (client_p != serv_list.head->data || serv_list.head->next)
697    {
698      ++ServerStats.is_ref;
699      sendto_one(client_p, "ERROR :I'm a leaf not a hub");
700      exit_client(client_p, "I'm a leaf");
701      return;
702    }
703  }
704
705  if (IsUnknown(client_p))
706  {
707    sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
708
709    send_capabilities(client_p, 0);
710
711    sendto_one(client_p, "SERVER %s 1 :%s%s",
712               me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
713  }
714
715  sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
716             (unsigned long)CurrentTime);
717
718  /* XXX Does this ever happen? I don't think so -db */
719  detach_conf(client_p, CONF_OPER);
720
721  /* *WARNING*
722  **    In the following code in place of plain server's
723  **    name we send what is returned by get_client_name
724  **    which may add the "sockhost" after the name. It's
725  **    *very* *important* that there is a SPACE between
726  **    the name and sockhost (if present). The receiving
727  **    server will start the information field from this
728  **    first blank and thus puts the sockhost into info.
729  **    ...a bit tricky, but you have been warned, besides
730  **    code is more neat this way...  --msa
731  */
732  client_p->servptr = &me;
733
734  if (IsClosing(client_p))
735    return;
736
737  SetServer(client_p);
738
739  /* Some day, all these lists will be consolidated *sigh* */
740  dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
741
742  assert(dlinkFind(&unknown_list, client_p));
743
744  dlink_move_node(&client_p->localClient->lclient_node,
745                  &unknown_list, &serv_list);
746
747  Count.myserver++;
748
749  dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
750  hash_add_client(client_p);
751  hash_add_id(client_p);
752
753  /* doesnt duplicate client_p->serv if allocated this struct already */
754  make_server(client_p);
755
756  /* fixing eob timings.. -gnp */
757  client_p->localClient->firsttime = CurrentTime;
758
759  if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
760    AddFlag(client_p, FLAGS_SERVICE);
761
762  /* Show the real host/IP to admins */
763 #ifdef HAVE_LIBCRYPTO
764  if (client_p->localClient->fd.ssl)
765  {
766    compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
767    expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
768
769    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
770                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
771                         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
772                         compression ? SSL_COMP_get_name(compression) : "NONE",
773                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
774                         show_capabilities(client_p));
775    /* Now show the masked hostname/IP to opers */
776    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
777                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
778                         inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
779                         compression ? SSL_COMP_get_name(compression) : "NONE",
780                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
781                         show_capabilities(client_p));
782    ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
783         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
784         compression ? SSL_COMP_get_name(compression) : "NONE",
785         expansion ? SSL_COMP_get_name(expansion) : "NONE",
786         show_capabilities(client_p));
787  }
788  else
789 #endif
790  {
791    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
792                         "Link with %s established: (Capabilities: %s)",
793                         inpath_ip, show_capabilities(client_p));
794    /* Now show the masked hostname/IP to opers */
795    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
796                         "Link with %s established: (Capabilities: %s)",
797                         inpath, show_capabilities(client_p));
798    ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
799         inpath_ip, show_capabilities(client_p));
800  }
801
802  fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
803
804  sendto_server(client_p, NOCAPS, NOCAPS, ":%s SID %s 2 %s :%s%s",
805                me.id, client_p->name, client_p->id,
806                IsHidden(client_p) ? "(H) " : "", client_p->info);
807
808  /*
809   * Pass on my client information to the new server
810   *
811   * First, pass only servers (idea is that if the link gets
812   * cancelled beacause the server was already there,
813   * there are no NICK's to be cancelled...). Of course,
814   * if cancellation occurs, all this info is sent anyway,
815   * and I guess the link dies when a read is attempted...? --msa
816   *
817   * Note: Link cancellation to occur at this point means
818   * that at least two servers from my fragment are building
819   * up connection this other fragment at the same time, it's
820   * a race condition, not the normal way of operation...
821   *
822   * ALSO NOTE: using the get_client_name for server names--
823   *    see previous *WARNING*!!! (Also, original inpath
824   *    is destroyed...)
825   */
826
827  DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
828  {
829    struct Client *target_p = ptr->data;
830
831    /* target_p->from == target_p for target_p == client_p */
832    if (IsMe(target_p) || target_p->from == client_p)
833      continue;
834
835    sendto_one(client_p, ":%s SID %s %d %s :%s%s",
836               target_p->servptr->id, target_p->name, target_p->hopcount+1,
837               target_p->id, IsHidden(target_p) ? "(H) " : "",
838               target_p->info);
839
840    if (HasFlag(target_p, FLAGS_EOB))
841      sendto_one(client_p, ":%s EOB", target_p->id, client_p);
842  }
843
844  server_burst(client_p);
845 }
846
847 /* server_burst()
848 *
849 * inputs       - struct Client pointer server
850 *              -
851 * output       - none
852 * side effects - send a server burst
853 * bugs         - still too long
854 */
855 static void
856 server_burst(struct Client *client_p)
857 {
858  /* Send it in the shortened format with the TS, if
859  ** it's a TS server; walk the list of channels, sending
860  ** all the nicks that haven't been sent yet for each
861  ** channel, then send the channel itself -- it's less
862  ** obvious than sending all nicks first, but on the
863  ** receiving side memory will be allocated more nicely
864  ** saving a few seconds in the handling of a split
865  ** -orabidoo
866  */
867
868  burst_all(client_p);
869
870  /* EOB stuff is now in burst_all */
871  /* Always send a PING after connect burst is done */
872  sendto_one(client_p, "PING :%s", me.id);
873 }
874
875 /* burst_all()
876 *
877 * inputs       - pointer to server to send burst to
878 * output       - NONE
879 * side effects - complete burst of channels/nicks is sent to client_p
880 */
881 static void
882 burst_all(struct Client *client_p)
883 {
884  dlink_node *ptr = NULL;
885
886  DLINK_FOREACH(ptr, global_channel_list.head)
887  {
888    struct Channel *chptr = ptr->data;
889
890    if (dlink_list_length(&chptr->members))
891    {
892      burst_members(client_p, chptr);
893      send_channel_modes(client_p, chptr);
894
895      if (IsCapable(client_p, CAP_TBURST))
896        send_tb(client_p, chptr);
897    }
898  }
899
900  /* also send out those that are not on any channel
901   */
902  DLINK_FOREACH(ptr, global_client_list.head)
903  {
904    struct Client *target_p = ptr->data;
905
906    if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
907      sendnick_TS(client_p, target_p);
908
909    DelFlag(target_p, FLAGS_BURSTED);
910  }
911
912  if (IsCapable(client_p, CAP_EOB))
913    sendto_one(client_p, ":%s EOB", me.id);
914 }
915
916 /*
917 * send_tb
918 *
919 * inputs       - pointer to Client
920 *              - pointer to channel
921 * output       - NONE
922 * side effects - Called on a server burst when
923 *                server is CAP_TBURST capable
924 */
925 static void
926 send_tb(struct Client *client_p, struct Channel *chptr)
927 {
928  /*
929   * We may also send an empty topic here, but only if topic_time isn't 0,
930   * i.e. if we had a topic that got unset.  This is required for syncing
931   * topics properly.
932   *
933   * Imagine the following scenario: Our downlink introduces a channel
934   * to us with a TS that is equal to ours, but the channel topic on
935   * their side got unset while the servers were in splitmode, which means
936   * their 'topic' is newer.  They simply wanted to unset it, so we have to
937   * deal with it in a more sophisticated fashion instead of just resetting
938   * it to their old topic they had before.  Read m_tburst.c:ms_tburst
939   * for further information   -Michael
940   */
941  if (chptr->topic_time)
942    sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s", me.id,
943               (unsigned long)chptr->channelts, chptr->chname,
944               (unsigned long)chptr->topic_time,
945               chptr->topic_info,
946               chptr->topic);
947 }
948
949 /* burst_members()
950 *
951 * inputs       - pointer to server to send members to
952 *              - dlink_list pointer to membership list to send
953 * output       - NONE
954 * side effects -
955 */
956 static void
957 burst_members(struct Client *client_p, struct Channel *chptr)
958 {
959  struct Client *target_p;
960  struct Membership *ms;
961  dlink_node *ptr;
962
963  DLINK_FOREACH(ptr, chptr->members.head)
964  {
965    ms       = ptr->data;
966    target_p = ms->client_p;
967
968    if (!HasFlag(target_p, FLAGS_BURSTED))
969    {
970      AddFlag(target_p, FLAGS_BURSTED);
971
972      if (target_p->from != client_p)
973        sendnick_TS(client_p, target_p);
974    }
975  }
976 }
977
470   /* New server connection code
471   * Based upon the stuff floating about in s_bsd.c
472   *   -- adrian
# Line 1008 | Line 500 | serv_connect(struct MaskItem *conf, stru
500    /* Make sure conf is useful */
501    assert(conf);
502  
503 <  getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
503 >  getnameinfo((const struct sockaddr *)&conf->addr, conf->addr.ss_len,
504                buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
505    ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", conf->name, conf->host,
506         buf);
# Line 1016 | Line 508 | serv_connect(struct MaskItem *conf, stru
508    /* Still processing a DNS lookup? -> exit */
509    if (conf->dns_pending)
510    {
511 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
511 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
512                           "Error connecting to %s: DNS lookup for connect{} in progress.",
513                           conf->name);
514      return 0;
# Line 1024 | Line 516 | serv_connect(struct MaskItem *conf, stru
516  
517    if (conf->dns_failed)
518    {
519 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
519 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
520                           "Error connecting to %s: DNS lookup for connect{} failed.",
521                           conf->name);
522      return 0;
523    }
524  
525 <  /* Make sure this server isn't already connected
526 <   * Note: conf should ALWAYS be a valid C: line
525 >  /*
526 >   * Make sure this server isn't already connected.
527 >   * Note: conf should ALWAYS be a valid connect {} block
528     */
529    if ((client_p = hash_find_server(conf->name)))
530    {
531 <    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
531 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
532                           "Server %s already present from %s",
533                           conf->name, get_client_name(client_p, SHOW_IP));
534 <    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
534 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
535                           "Server %s already present from %s",
536                           conf->name, get_client_name(client_p, MASK_IP));
537      if (by && IsClient(by) && !MyClient(by))
# Line 1048 | Line 541 | serv_connect(struct MaskItem *conf, stru
541    }
542  
543    /* Create a local client */
544 <  client_p = make_client(NULL);
544 >  client_p = client_make(NULL);
545  
546    /* Copy in the server, hostname, fd */
547    strlcpy(client_p->name, conf->name, sizeof(client_p->name));
# Line 1057 | Line 550 | serv_connect(struct MaskItem *conf, stru
550    /* We already converted the ip once, so lets use it - stu */
551    strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
552  
553 <  /* create a socket for the server connection */
554 <  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1062 <                SOCK_STREAM, 0, NULL) < 0)
553 >  /* Create a socket for the server connection */
554 >  if (comm_open(&client_p->connection->fd, conf->addr.ss.ss_family, SOCK_STREAM, 0, NULL) < 0)
555    {
556      /* Eek, failure to create the socket */
557 <    report_error(L_ALL, "opening stream socket to %s: %s",
558 <                 conf->name, errno);
557 >    report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
558 >
559      SetDead(client_p);
560      exit_client(client_p, "Connection failed");
561      return 0;
562    }
563  
564 <  /* servernames are always guaranteed under HOSTLEN chars */
565 <  fd_note(&client_p->localClient->fd, "Server: %s", conf->name);
564 >  /* Server names are always guaranteed under HOSTLEN chars */
565 >  fd_note(&client_p->connection->fd, "Server: %s", client_p->name);
566  
567 <  /* Attach config entries to client here rather than in
568 <   * serv_connect_callback(). This to avoid null pointer references.
567 >  /*
568 >   * Attach config entries to client here rather than in serv_connect_callback().
569 >   * This to avoid null pointer references.
570     */
571    if (!attach_connect_block(client_p, conf->name, conf->host))
572    {
573 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
574 <                         "Host %s is not enabled for connecting: no connect{} block",
573 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
574 >                         "Host %s is not enabled for connecting: no connect {} block",
575                           conf->name);
576      if (by && IsClient(by) && !MyClient(by))
577 <      sendto_one_notice(by, &me, ":Connect to host %s failed.", client_p->name);
577 >      sendto_one_notice(by, &me, ":Connect to host %s failed: no connect {} block", client_p->name);
578  
579      SetDead(client_p);
580      exit_client(client_p, "Connection failed");
581      return 0;
582    }
583  
584 <  /* at this point we have a connection in progress and C/N lines
585 <   * attached to the client, the socket info should be saved in the
586 <   * client and it should either be resolved or have a valid address.
584 >  /*
585 >   * At this point we have a connection in progress and a connect {} block
586 >   * attached to the client, the socket info should be saved in the client
587 >   * and it should either be resolved or have a valid address.
588     *
589     * The socket has been connected or connect is in progress.
590     */
# Line 1102 | Line 596 | serv_connect(struct MaskItem *conf, stru
596      strlcpy(client_p->serv->by, "AutoConn.", sizeof(client_p->serv->by));
597  
598    SetConnecting(client_p);
599 <  dlinkAdd(client_p, &client_p->node, &global_client_list);
1106 <  /* from def_fam */
1107 <  client_p->localClient->aftype = conf->aftype;
599 >  client_p->connection->aftype = conf->aftype;
600  
601    /* Now, initiate the connection */
602    /* XXX assume that a non 0 type means a specific bind address
# Line 1121 | Line 613 | serv_connect(struct MaskItem *conf, stru
613          ipn.ss.ss_family = AF_INET;
614          ipn.ss_port = 0;
615          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
616 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
616 >        comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
617                           (struct sockaddr *)&ipn, ipn.ss_len,
618                           serv_connect_callback, client_p, conf->aftype,
619                           CONNECTTIMEOUT);
620        }
621 <      else if (ServerInfo.specific_ipv4_vhost)
621 >      else if (ConfigServerInfo.specific_ipv4_vhost)
622        {
623          struct irc_ssaddr ipn;
624          memset(&ipn, 0, sizeof(struct irc_ssaddr));
625          ipn.ss.ss_family = AF_INET;
626          ipn.ss_port = 0;
627 <        memcpy(&ipn, &ServerInfo.ip, sizeof(struct irc_ssaddr));
628 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
627 >        memcpy(&ipn, &ConfigServerInfo.ip, sizeof(struct irc_ssaddr));
628 >        comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
629                           (struct sockaddr *)&ipn, ipn.ss_len,
630                           serv_connect_callback, client_p, conf->aftype,
631                           CONNECTTIMEOUT);
632        }
633        else
634 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
634 >        comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
635                           NULL, 0, serv_connect_callback, client_p, conf->aftype,
636                           CONNECTTIMEOUT);
637        break;
1146 #ifdef IPV6
638      case AF_INET6:
639        {
640          struct irc_ssaddr ipn;
# Line 1159 | Line 650 | serv_connect(struct MaskItem *conf, stru
650            memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
651            ipn.ss.ss_family = AF_INET6;
652            ipn.ss_port = 0;
653 <          comm_connect_tcp(&client_p->localClient->fd,
653 >          comm_connect_tcp(&client_p->connection->fd,
654                             conf->host, conf->port,
655                             (struct sockaddr *)&ipn, ipn.ss_len,
656                             serv_connect_callback, client_p,
657                             conf->aftype, CONNECTTIMEOUT);
658          }
659 <        else if (ServerInfo.specific_ipv6_vhost)
659 >        else if (ConfigServerInfo.specific_ipv6_vhost)
660          {
661 <          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
661 >          memcpy(&ipn, &ConfigServerInfo.ip6, sizeof(struct irc_ssaddr));
662            ipn.ss.ss_family = AF_INET6;
663            ipn.ss_port = 0;
664 <          comm_connect_tcp(&client_p->localClient->fd,
664 >          comm_connect_tcp(&client_p->connection->fd,
665                             conf->host, conf->port,
666                             (struct sockaddr *)&ipn, ipn.ss_len,
667                             serv_connect_callback, client_p,
668                             conf->aftype, CONNECTTIMEOUT);
669          }
670          else
671 <          comm_connect_tcp(&client_p->localClient->fd,
671 >          comm_connect_tcp(&client_p->connection->fd,
672                             conf->host, conf->port,
673                             NULL, 0, serv_connect_callback, client_p,
674                             conf->aftype, CONNECTTIMEOUT);
675        }
1185 #endif
676    }
677 +
678    return 1;
679   }
680  
1190 #ifdef HAVE_LIBCRYPTO
681   static void
682   finish_ssl_server_handshake(struct Client *client_p)
683   {
684 <  struct MaskItem *conf = NULL;
685 <
686 <  conf = find_conf_name(&client_p->localClient->confs,
687 <                        client_p->name, CONF_SERVER);
688 <  if (conf == NULL)
689 <  {
690 <    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1201 <                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
1202 <    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
684 >  const struct MaskItem *conf = find_conf_name(&client_p->connection->confs,
685 >                                                client_p->name, CONF_SERVER);
686 >  if (!conf)
687 >  {
688 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
689 >                         "Lost connect{} block for %s", get_client_name(client_p, SHOW_IP));
690 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
691                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
692  
693      exit_client(client_p, "Lost connect{} block");
694      return;
695    }
696  
697 <  sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
697 >  sendto_one(client_p, "PASS %s TS %u %s", conf->spasswd, TS_CURRENT, me.id);
698  
699 <  send_capabilities(client_p, 0);
699 >  sendto_one(client_p, "CAPAB :%s", get_capabilities(NULL));
700  
701    sendto_one(client_p, "SERVER %s 1 :%s%s",
702               me.name, ConfigServerHide.hidden ? "(H) " : "",
703               me.info);
704  
705 <  /* If we've been marked dead because a send failed, just exit
705 >  /*
706 >   * If we've been marked dead because a send failed, just exit
707     * here now and save everyone the trouble of us ever existing.
708     */
709    if (IsDead(client_p))
710    {
711 <      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
712 <                           "%s[%s] went dead during handshake",
713 <                           client_p->name,
714 <                           client_p->host);
715 <      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1227 <                           "%s went dead during handshake", client_p->name);
1228 <      return;
711 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
712 >                         "%s went dead during handshake", get_client_name(client_p, SHOW_IP));
713 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
714 >                         "%s went dead during handshake", get_client_name(client_p, MASK_IP));
715 >    return;
716    }
717  
718    /* don't move to serv_list yet -- we haven't sent a burst! */
719    /* If we get here, we're ok, so lets start reading some data */
720 <  comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ, read_packet, client_p, 0);
720 >  comm_setselect(&client_p->connection->fd, COMM_SELECT_READ, read_packet, client_p, 0);
721   }
722  
723   static void
724 < ssl_server_handshake(fde_t *fd, struct Client *client_p)
724 > ssl_server_handshake(fde_t *fd, void *data)
725   {
726 <  X509 *cert = NULL;
727 <  int ret = 0;
726 >  struct Client *client_p = data;
727 >  const char *sslerr = NULL;
728  
729 <  if ((ret = SSL_connect(client_p->localClient->fd.ssl)) <= 0)
729 >  tls_handshake_status_t ret = tls_handshake(&client_p->connection->fd.ssl, TLS_ROLE_CLIENT, &sslerr);
730 >  if (ret != TLS_HANDSHAKE_DONE)
731    {
732 <    switch (SSL_get_error(client_p->localClient->fd.ssl, ret))
732 >    if ((CurrentTime - client_p->connection->firsttime) > CONNECTTIMEOUT)
733      {
734 <      case SSL_ERROR_WANT_WRITE:
735 <        comm_setselect(&client_p->localClient->fd, COMM_SELECT_WRITE,
736 <                       (PF *)ssl_server_handshake, client_p, 0);
734 >      exit_client(client_p, "Timeout during TLS handshake");
735 >      return;
736 >    }
737 >
738 >    switch (ret)
739 >    {
740 >      case TLS_HANDSHAKE_WANT_WRITE:
741 >        comm_setselect(&client_p->connection->fd, COMM_SELECT_WRITE,
742 >                       ssl_server_handshake, client_p, CONNECTTIMEOUT);
743          return;
744 <      case SSL_ERROR_WANT_READ:
745 <        comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ,
746 <                       (PF *)ssl_server_handshake, client_p, 0);
744 >      case TLS_HANDSHAKE_WANT_READ:
745 >        comm_setselect(&client_p->connection->fd, COMM_SELECT_READ,
746 >                       ssl_server_handshake, client_p, CONNECTTIMEOUT);
747          return;
748        default:
749        {
750 <        const char *sslerr = ERR_error_string(ERR_get_error(), NULL);
1257 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
750 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
751                               "Error connecting to %s: %s", client_p->name,
752 <                             sslerr ? sslerr : "unknown SSL error");
753 <        exit_client(client_p, "Error during SSL handshake");
752 >                             sslerr ? sslerr : "unknown TLS error");
753 >        exit_client(client_p, "Error during TLS handshake");
754          return;
755        }
756      }
757    }
758  
759 <  if ((cert = SSL_get_peer_certificate(client_p->localClient->fd.ssl)))
1267 <  {
1268 <    int res = SSL_get_verify_result(client_p->localClient->fd.ssl);
1269 <    char buf[EVP_MAX_MD_SIZE * 2 + 1] = { '\0' };
1270 <    unsigned char md[EVP_MAX_MD_SIZE] = { '\0' };
1271 <
1272 <    if (res == X509_V_OK || res == X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN ||
1273 <        res == X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE ||
1274 <        res == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT)
1275 <    {
1276 <      unsigned int i = 0, n = 0;
759 >  comm_settimeout(&client_p->connection->fd, 0, NULL, NULL);
760  
761 <      if (X509_digest(cert, EVP_sha256(), md, &n))
762 <      {
763 <        for (; i < n; ++i)
1281 <          snprintf(buf + 2 * i, 3, "%02X", md[i]);
1282 <        client_p->certfp = xstrdup(buf);
1283 <      }
1284 <    }
1285 <    else
1286 <      ilog(LOG_TYPE_IRCD, "Server %s!%s@%s gave bad SSL client certificate: %d",
1287 <           client_p->name, client_p->username, client_p->host, res);
1288 <    X509_free(cert);
1289 <  }
761 >  if (!tls_verify_cert(&client_p->connection->fd.ssl, ConfigServerInfo.message_digest_algorithm, &client_p->certfp))
762 >    ilog(LOG_TYPE_IRCD, "Server %s!%s@%s gave bad TLS client certificate",
763 >         client_p->name, client_p->username, client_p->host);
764  
765    finish_ssl_server_handshake(client_p);
766   }
767  
768   static void
769 < ssl_connect_init(struct Client *client_p, struct MaskItem *conf, fde_t *fd)
769 > ssl_connect_init(struct Client *client_p, const struct MaskItem *conf, fde_t *fd)
770   {
771 <  if ((client_p->localClient->fd.ssl = SSL_new(ServerInfo.client_ctx)) == NULL)
771 >  if (!tls_new(&client_p->connection->fd.ssl, fd->fd, TLS_ROLE_CLIENT))
772    {
1299    ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
1300         ERR_error_string(ERR_get_error(), NULL));
773      SetDead(client_p);
774 <    exit_client(client_p, "SSL_new failed");
774 >    exit_client(client_p, "TLS context initialization failed");
775      return;
776    }
777  
1306  SSL_set_fd(fd->ssl, fd->fd);
1307
778    if (!EmptyString(conf->cipher_list))
779 <    SSL_set_cipher_list(client_p->localClient->fd.ssl, conf->cipher_list);
779 >    tls_set_ciphers(&client_p->connection->fd.ssl, conf->cipher_list);
780  
781    ssl_server_handshake(NULL, client_p);
782   }
1313 #endif
783  
784   /* serv_connect_callback() - complete a server connection.
785   *
# Line 1323 | Line 792 | ssl_connect_init(struct Client *client_p
792   static void
793   serv_connect_callback(fde_t *fd, int status, void *data)
794   {
795 <  struct Client *client_p = data;
1327 <  struct MaskItem *conf = NULL;
795 >  struct Client *const client_p = data;
796  
797 <  /* First, make sure its a real client! */
797 >  /* First, make sure it's a real client! */
798    assert(client_p);
799 <  assert(&client_p->localClient->fd == fd);
799 >  assert(&client_p->connection->fd == fd);
800  
801    /* Next, for backward purposes, record the ip of the server */
802 <  memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
1335 <         sizeof(struct irc_ssaddr));
802 >  memcpy(&client_p->connection->ip, &fd->connect.hostaddr, sizeof(struct irc_ssaddr));
803  
804    /* Check the status */
805    if (status != COMM_OK)
806    {
807 <    /* We have an error, so report it and quit
808 <     * Admins get to see any IP, mere opers don't *sigh*
807 >    /* We have an error, so report it and quit */
808 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
809 >                         "Error connecting to %s: %s",
810 >                         get_client_name(client_p, SHOW_IP), comm_errstr(status));
811 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
812 >                         "Error connecting to %s: %s",
813 >                         get_client_name(client_p, MASK_IP), comm_errstr(status));
814 >
815 >    /*
816 >     * If a fd goes bad, call dead_link() the socket is no
817 >     * longer valid for reading or writing.
818       */
819 <     if (ConfigServerHide.hide_server_ips)
820 <       sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1345 <                            "Error connecting to %s: %s",
1346 <                            client_p->name, comm_errstr(status));
1347 <     else
1348 <       sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1349 <                            "Error connecting to %s[%s]: %s", client_p->name,
1350 <                            client_p->host, comm_errstr(status));
1351 <
1352 <     sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1353 <                          "Error connecting to %s: %s",
1354 <                          client_p->name, comm_errstr(status));
1355 <
1356 <     /* If a fd goes bad, call dead_link() the socket is no
1357 <      * longer valid for reading or writing.
1358 <      */
1359 <     dead_link_on_write(client_p, 0);
1360 <     return;
819 >    dead_link_on_write(client_p, 0);
820 >    return;
821    }
822  
823    /* COMM_OK, so continue the connection procedure */
824 <  /* Get the C/N lines */
825 <  conf = find_conf_name(&client_p->localClient->confs,
826 <                        client_p->name, CONF_SERVER);
827 <  if (conf == NULL)
828 <  {
829 <    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
830 <                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
831 <    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
824 >  /* Get the connect {} block */
825 >  const struct MaskItem *conf = find_conf_name(&client_p->connection->confs,
826 >                                                client_p->name, CONF_SERVER);
827 >  if (!conf)
828 >  {
829 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
830 >                         "Lost connect{} block for %s", get_client_name(client_p, SHOW_IP));
831 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
832                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
833  
834      exit_client(client_p, "Lost connect{} block");
# Line 1378 | Line 838 | serv_connect_callback(fde_t *fd, int sta
838    /* Next, send the initial handshake */
839    SetHandshake(client_p);
840  
1381 #ifdef HAVE_LIBCRYPTO
841    if (IsConfSSL(conf))
842    {
843      ssl_connect_init(client_p, conf, fd);
844      return;
845    }
1387 #endif
846  
847 <  sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
847 >  sendto_one(client_p, "PASS %s TS %u %s", conf->spasswd, TS_CURRENT, me.id);
848  
849 <  send_capabilities(client_p, 0);
849 >  sendto_one(client_p, "CAPAB :%s", get_capabilities(NULL));
850  
851    sendto_one(client_p, "SERVER %s 1 :%s%s", me.name,
852               ConfigServerHide.hidden ? "(H) " : "", me.info);
853  
854 <  /* If we've been marked dead because a send failed, just exit
854 >  /*
855 >   * If we've been marked dead because a send failed, just exit
856     * here now and save everyone the trouble of us ever existing.
857     */
858    if (IsDead(client_p))
859    {
860 <      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
861 <                           "%s[%s] went dead during handshake",
862 <                           client_p->name,
863 <                           client_p->host);
864 <      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1406 <                           "%s went dead during handshake", client_p->name);
1407 <      return;
860 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
861 >                         "%s went dead during handshake", get_client_name(client_p, SHOW_IP));
862 >    sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
863 >                         "%s went dead during handshake", get_client_name(client_p, MASK_IP));
864 >    return;
865    }
866  
867    /* don't move to serv_list yet -- we haven't sent a burst! */
# Line 1416 | Line 873 | struct Client *
873   find_servconn_in_progress(const char *name)
874   {
875    dlink_node *ptr;
1419  struct Client *cptr;
876  
877    DLINK_FOREACH(ptr, unknown_list.head)
878    {
879 <    cptr = ptr->data;
879 >    struct Client *cptr = ptr->data;
880  
881 <    if (cptr && cptr->name[0])
882 <      if (!match(name, cptr->name))
881 >    if (cptr->name[0])
882 >      if (!irccmp(name, cptr->name))
883          return cptr;
884    }
885  

Comparing:
ircd-hybrid/trunk/src/s_serv.c (property svn:keywords), Revision 3246 by michael, Sun Mar 30 17:37:13 2014 UTC vs.
ircd-hybrid/trunk/src/server.c (property svn:keywords), Revision 7957 by michael, Sun Mar 5 11:53:49 2017 UTC

# Line 1 | Line 1
1 < Id Revision
1 > Id

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)