ViewVC Help

View File | Revision Log | Show Annotations | View Changeset | Root Listing

root/svn/ircd-hybrid/trunk/src/server.c

Comparing:
ircd-hybrid/trunk/src/s_serv.c (file contents), Revision 3136 by michael, Tue Mar 11 18:24:03 2014 UTC vs.
ircd-hybrid/trunk/src/server.c (file contents), Revision 6633 by michael, Sat Oct 24 15:15:33 2015 UTC

#	Line 1 | Line 1
1		/*
2		*  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3		*
4	<	*  Copyright (c) 1997-2014 ircd-hybrid development team
4	>	*  Copyright (c) 1997-2015 ircd-hybrid development team
5		*
6		*  This program is free software; you can redistribute it and/or modify
7		*  it under the terms of the GNU General Public License as published by
#	Line 15 | Line 15
15		*
16		*  You should have received a copy of the GNU General Public License
17		*  along with this program; if not, write to the Free Software
18	<	*  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18	>	*  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19		*  USA
20		*/
21
#	Line 30 | Line 30
30		#include "rsa.h"
31		#endif
32		#include "list.h"
33	–	#include "channel.h"
34	–	#include "channel_mode.h"
33		#include "client.h"
34		#include "event.h"
37	–	#include "fdlist.h"
35		#include "hash.h"
36		#include "irc_string.h"
37		#include "ircd.h"
#	Line 42 | Line 39
39		#include "s_bsd.h"
40		#include "numeric.h"
41		#include "packet.h"
45	–	#include "irc_res.h"
42		#include "conf.h"
43	<	#include "s_serv.h"
43	>	#include "server.h"
44		#include "log.h"
45	<	#include "s_misc.h"
50	<	#include "s_user.h"
45	>	#include "user.h"
46		#include "send.h"
47		#include "memory.h"
48		#include "channel.h"
49		#include "parse.h"
50
56	–	#define MIN_CONN_FREQ 300
51
52		dlink_list flatten_links;
53	<	static dlink_list cap_list = { NULL, NULL, 0 };
54	<	static void server_burst(struct Client *);
61	<	static void burst_all(struct Client *);
62	<	static void send_tb(struct Client *client_p, struct Channel *chptr);
63	<
64	<	static CNCB serv_connect_callback;
53	>	static dlink_list server_capabilities_list;
54	>	static void serv_connect_callback(fde_t *, int, void *);
55
66	–	static void burst_members(struct Client *, struct Channel *);
56
57		/*
58		* write_links_file
#	Line 74 | Line 63 | static void burst_members(struct Client
63		*                but in no particular order.
64		*/
65		void
66	<	write_links_file(void *notused)
66	>	write_links_file(void *unused)
67		{
68		FILE *file = NULL;
69	<	dlink_node *ptr = NULL, *ptr_next = NULL;
70	<	char buff[IRCD_BUFSIZE] = { '\0' };
69	>	dlink_node *node = NULL, *node_next = NULL;
70	>	char buff[IRCD_BUFSIZE] = "";
71
72	<	if ((file = fopen(LIPATH, "w")) == NULL)
72	>	if (EmptyString(ConfigServerHide.flatten_links_file))
73		return;
74
75	<	DLINK_FOREACH_SAFE(ptr, ptr_next, flatten_links.head)
75	>	if ((file = fopen(ConfigServerHide.flatten_links_file, "w")) == NULL)
76		{
77	<	dlinkDelete(ptr, &flatten_links);
78	<	MyFree(ptr->data);
79	<	free_dlink_node(ptr);
77	>	ilog(LOG_TYPE_IRCD, "Couldn't open \"%s\": %s", ConfigServerHide.flatten_links_file,
78	>	strerror(errno));
79	>	return;
80		}
81
82	<	DLINK_FOREACH(ptr, global_serv_list.head)
82	>	DLINK_FOREACH_SAFE(node, node_next, flatten_links.head)
83		{
84	<	const struct Client *target_p = ptr->data;
84	>	dlinkDelete(node, &flatten_links);
85	>	MyFree(node->data);
86	>	free_dlink_node(node);
87	>	}
88	>
89	>	DLINK_FOREACH(node, global_server_list.head)
90	>	{
91	>	const struct Client *target_p = node->data;
92
93		/*
94		* Skip hidden servers, aswell as ourselves, since we already send
#	Line 127 | Line 123 | read_links_file(void)
123		{
124		FILE *file = NULL;
125		char *p = NULL;
126	<	char buff[IRCD_BUFSIZE] = { '\0' };
126	>	char buff[IRCD_BUFSIZE] = "";
127	>
128	>	if (EmptyString(ConfigServerHide.flatten_links_file))
129	>	return;
130
131	<	if ((file = fopen(LIPATH, "r")) == NULL)
131	>	if ((file = fopen(ConfigServerHide.flatten_links_file, "r")) == NULL)
132	>	{
133	>	ilog(LOG_TYPE_IRCD, "Couldn't open \"%s\": %s", ConfigServerHide.flatten_links_file,
134	>	strerror(errno));
135		return;
136	+	}
137
138		while (fgets(buff, sizeof(buff), file))
139		{
140	<	if ((p = strchr(buff, '\n')) != NULL)
140	>	if ((p = strchr(buff, '\n')))
141		*p = '\0';
142
143		dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
#	Line 163 | Line 166 | read_links_file(void)
166		*      returns: (see #defines)
167		*/
168		int
169	<	hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
169	>	hunt_server(struct Client *source_p, const char *command,
170		const int server, const int parc, char *parv[])
171		{
172		struct Client *target_p = NULL;
173	<	struct Client *target_tmp = NULL;
171	<	dlink_node *ptr;
172	<	int wilds;
173	>	dlink_node *node = NULL;
174
175		/* Assume it's me, if no server */
176		if (parc <= server || EmptyString(parv[server]))
177		return HUNTED_ISME;
178
179	<	if (!strcmp(parv[server], me.id) || !match(parv[server], me.name))
180	<	return HUNTED_ISME;
179	>	if ((target_p = find_person(source_p, parv[server])) == NULL)
180	>	target_p = hash_find_server(parv[server]);
181
182	<	/* These are to pickup matches that would cause the following
182	>	/*
183	>	* These are to pickup matches that would cause the following
184		* message to go in the wrong direction while doing quick fast
185		* non-matching lookups.
186		*/
185	–	if (MyClient(source_p))
186	–	target_p = hash_find_client(parv[server]);
187	–	else
188	–	target_p = find_person(client_p, parv[server]);
189	–
187		if (target_p)
188		if (target_p->from == source_p->from && !MyConnect(target_p))
189		target_p = NULL;
190
191	<	if (target_p == NULL && (target_p = hash_find_server(parv[server])))
195	<	if (target_p->from == source_p->from && !MyConnect(target_p))
196	<	target_p = NULL;
197	<
198	<	wilds = has_wildcards(parv[server]);
199	<
200	<	/* Again, if there are no wild cards involved in the server
201	<	* name, use the hash lookup
202	<	*/
203	<	if (target_p == NULL)
191	>	if (!target_p && has_wildcards(parv[server]))
192		{
193	<	if (!wilds)
193	>	DLINK_FOREACH(node, global_server_list.head)
194		{
195	<	if (!(target_p = hash_find_server(parv[server])))
195	>	struct Client *tmp = node->data;
196	>
197	>	assert(IsMe(tmp) || IsServer(tmp));
198	>	if (!match(parv[server], tmp->name))
199		{
200	<	sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
201	<	return HUNTED_NOSUCH;
200	>	if (tmp->from == source_p->from && !MyConnect(tmp))
201	>	continue;
202	>
203	>	target_p = node->data;
204	>	break;
205		}
206		}
207	<	else
207	>
208	>	if (!target_p)
209		{
210	<	DLINK_FOREACH(ptr, global_client_list.head)
210	>	DLINK_FOREACH(node, global_client_list.head)
211		{
212	<	target_tmp = ptr->data;
212	>	struct Client *tmp = node->data;
213
214	<	if (!match(parv[server], target_tmp->name))
214	>	assert(IsMe(tmp) || IsServer(tmp) || IsClient(tmp));
215	>	if (!match(parv[server], tmp->name))
216		{
217	<	if (target_tmp->from == source_p->from && !MyConnect(target_tmp))
217	>	if (tmp->from == source_p->from && !MyConnect(tmp))
218		continue;
223	–	target_p = ptr->data;
219
220	<	if (IsRegistered(target_p) && (target_p != client_p))
221	<	break;
220	>	target_p = node->data;
221	>	break;
222		}
223		}
224		}
225		}
226
227	<	if (target_p != NULL)
227	>	if (target_p)
228		{
229	<	if(!IsRegistered(target_p))
235	<	{
236	<	sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
237	<	return HUNTED_NOSUCH;
238	<	}
239	<
229	>	assert(IsMe(target_p) || IsServer(target_p) || IsClient(target_p));
230		if (IsMe(target_p) || MyClient(target_p))
231		return HUNTED_ISME;
232
233	<	if (match(target_p->name, parv[server]))
234	<	parv[server] = target_p->name;
245	<
246	<	/* This is a little kludgy but should work... */
247	<	sendto_one(target_p, command, ID_or_name(source_p, target_p),
233	>	parv[server] = target_p->id;
234	>	sendto_one(target_p, command, source_p->id,
235		parv[1], parv[2], parv[3], parv[4],
236		parv[5], parv[6], parv[7], parv[8]);
237		return HUNTED_PASS;
#	Line 267 | Line 254 | hunt_server(struct Client *client_p, str
254		void
255		try_connections(void *unused)
256		{
257	<	dlink_node *ptr = NULL;
271	<	struct MaskItem *conf;
272	<	int confrq;
257	>	dlink_node *node = NULL;
258
259		/* TODO: change this to set active flag to 0 when added to event! --Habeeb */
260		if (GlobalSetOptions.autoconn == 0)
261		return;
262
263	<	DLINK_FOREACH(ptr, server_items.head)
263	>	DLINK_FOREACH(node, server_items.head)
264		{
265	<	conf = ptr->data;
265	>	struct MaskItem *conf = node->data;
266
267		assert(conf->type == CONF_SERVER);
268
269		/* Also when already connecting! (update holdtimes) --SRB
270		*/
271	<	if (!conf->port ||!IsConfAllowAutoConn(conf))
271	>	if (!conf->port || !IsConfAllowAutoConn(conf))
272		continue;
273
274
#	Line 296 | Line 281 | try_connections(void *unused)
281		if (conf->until > CurrentTime)
282		continue;
283
284	<	if (conf->class == NULL)
300	<	confrq = DEFAULT_CONNECTFREQUENCY;
301	<	else
302	<	{
303	<	confrq = conf->class->con_freq;
304	<	if (confrq < MIN_CONN_FREQ)
305	<	confrq = MIN_CONN_FREQ;
306	<	}
284	>	assert(conf->class);
285
286	<	conf->until = CurrentTime + confrq;
286	>	conf->until = CurrentTime + conf->class->con_freq;
287
288	<	/* Found a CONNECT config with port specified, scan clients
288	>	/*
289	>	* Found a CONNECT config with port specified, scan clients
290		* and see if this server is already connected?
291		*/
292	<	if (hash_find_server(conf->name) != NULL)
292	>	if (hash_find_server(conf->name))
293		continue;
294
295		if (conf->class->ref_count < conf->class->max_total)
296		{
297	<	/* Go to the end of the list, if not already last */
298	<	if (ptr->next != NULL)
297	>	/* Move this entry to the end of the list, if not already last */
298	>	if (node->next)
299		{
300	<	dlinkDelete(ptr, &server_items);
300	>	dlinkDelete(node, &server_items);
301		dlinkAddTail(conf, &conf->node, &server_items);
302		}
303
304		if (find_servconn_in_progress(conf->name))
305		return;
306
307	<	/* We used to only print this if serv_connect() actually
307	>	/*
308	>	* We used to only print this if serv_connect() actually
309		* succeeded, but since comm_tcp_connect() can call the callback
310		* immediately if there is an error, we were getting error messages
311		* in the wrong order. SO, we just print out the activated line,
#	Line 334 | Line 314 | try_connections(void *unused)
314		*   -- adrian
315		*/
316		if (ConfigServerHide.hide_server_ips)
317	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
317	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
318		"Connection to %s activated.",
319		conf->name);
320		else
321	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
321	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
322		"Connection to %s[%s] activated.",
323		conf->name, conf->host);
324
#	Line 352 | Line 332 | try_connections(void *unused)
332		int
333		valid_servname(const char *name)
334		{
335	<	unsigned int length = 0;
356	<	unsigned int dots   = 0;
335	>	unsigned int dots = 0;
336		const char *p = name;
337
338		for (; *p; ++p)
#	Line 361 | Line 340 | valid_servname(const char *name)
340		if (!IsServChar(*p))
341		return 0;
342
364	–	++length;
365	–
343		if (*p == '.')
344		++dots;
345		}
346
347	<	return dots != 0 && length <= HOSTLEN;
347	>	return dots && (p - name) <= HOSTLEN;
348		}
349
350		int
351		check_server(const char *name, struct Client *client_p)
352		{
353	<	dlink_node *ptr;
353	>	dlink_node *node = NULL;
354		struct MaskItem *conf        = NULL;
355		struct MaskItem *server_conf = NULL;
356		int error = -1;
357
358	<	assert(client_p != NULL);
358	>	assert(client_p);
359
360	<	/* loop through looking for all possible connect items that might work */
361	<	DLINK_FOREACH(ptr, server_items.head)
360	>	/* Loop through looking for all possible connect items that might work */
361	>	DLINK_FOREACH(node, server_items.head)
362		{
363	<	conf = ptr->data;
363	>	conf = node->data;
364
365		if (match(name, conf->name))
366		continue;
#	Line 397 | Line 374 | check_server(const char *name, struct Cl
374		{
375		error = -2;
376
377	<	if (!match_conf_password(client_p->localClient->passwd, conf))
377	>	if (!match_conf_password(client_p->connection->password, conf))
378		return -2;
379
380		if (!EmptyString(conf->certfp))
#	Line 413 | Line 390 | check_server(const char *name, struct Cl
390
391		attach_conf(client_p, server_conf);
392
393	<
417	<	if (server_conf != NULL)
393	>	switch (server_conf->aftype)
394		{
395	<	struct sockaddr_in *v4;
420	<	#ifdef IPV6
421	<	struct sockaddr_in6 *v6;
422	<	#endif
423	<	switch (server_conf->aftype)
395	>	case AF_INET6:
396		{
397	<	#ifdef IPV6
426	<	case AF_INET6:
427	<	v6 = (struct sockaddr_in6 *)&server_conf->addr;
397	>	const struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)&server_conf->addr;
398
399	<	if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
400	<	memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
401	<	break;
402	<	#endif
403	<	case AF_INET:
404	<	v4 = (struct sockaddr_in *)&server_conf->addr;
399	>	if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
400	>	memcpy(&server_conf->addr, &client_p->connection->ip, sizeof(struct irc_ssaddr));
401	>	break;
402	>	}
403	>	case AF_INET:
404	>	{
405	>	const struct sockaddr_in *v4 = (struct sockaddr_in *)&server_conf->addr;
406
407	<	if (v4->sin_addr.s_addr == INADDR_NONE)
408	<	memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
409	<	break;
407	>	if (v4->sin_addr.s_addr == INADDR_NONE)
408	>	memcpy(&server_conf->addr, &client_p->connection->ip, sizeof(struct irc_ssaddr));
409	>	break;
410		}
411		}
412
#	Line 452 | Line 423 | check_server(const char *name, struct Cl
423		*                modules to dynamically add or subtract their capability.
424		*/
425		void
426	<	add_capability(const char *capab_name, int cap_flag, int add_to_default)
426	>	add_capability(const char *name, unsigned int flag)
427		{
428	<	struct Capability *cap = MyMalloc(sizeof(*cap));
458	<
459	<	cap->name = xstrdup(capab_name);
460	<	cap->cap = cap_flag;
461	<	dlinkAdd(cap, &cap->node, &cap_list);
428	>	struct Capability *cap = MyCalloc(sizeof(*cap));
429
430	<	if (add_to_default)
431	<	default_server_capabs |= cap_flag;
430	>	cap->name = xstrdup(name);
431	>	cap->cap = flag;
432	>	dlinkAdd(cap, &cap->node, &server_capabilities_list);
433		}
434
435		/* delete_capability()
#	Line 470 | Line 438 | add_capability(const char *capab_name, i
438		* output       - NONE
439		* side effects - delete given capability from ones known.
440		*/
441	<	int
442	<	delete_capability(const char *capab_name)
441	>	void
442	>	delete_capability(const char *name)
443		{
444	<	dlink_node *ptr;
477	<	dlink_node *next_ptr;
478	<	struct Capability *cap;
444	>	dlink_node *node = NULL, *node_next = NULL;
445
446	<	DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
446	>	DLINK_FOREACH_SAFE(node, node_next, server_capabilities_list.head)
447		{
448	<	cap = ptr->data;
448	>	struct Capability *cap = node->data;
449
450	<	if (cap->cap != 0)
450	>	if (!irccmp(cap->name, name))
451		{
452	<	if (irccmp(cap->name, capab_name) == 0)
453	<	{
454	<	default_server_capabs &= ~(cap->cap);
489	<	dlinkDelete(ptr, &cap_list);
490	<	MyFree(cap->name);
491	<	MyFree(cap);
492	<	}
452	>	dlinkDelete(node, &server_capabilities_list);
453	>	MyFree(cap->name);
454	>	MyFree(cap);
455		}
456		}
495	–
496	–	return 0;
457		}
458
459		/*
#	Line 504 | Line 464 | delete_capability(const char *capab_name
464		* side effects - none
465		*/
466		unsigned int
467	<	find_capability(const char *capab)
467	>	find_capability(const char *name)
468		{
469	<	const dlink_node *ptr = NULL;
469	>	const dlink_node *node = NULL;
470
471	<	DLINK_FOREACH(ptr, cap_list.head)
471	>	DLINK_FOREACH(node, server_capabilities_list.head)
472		{
473	<	const struct Capability *cap = ptr->data;
473	>	const struct Capability *cap = node->data;
474
475	<	if (cap->cap && !irccmp(cap->name, capab))
475	>	if (!irccmp(cap->name, name))
476		return cap->cap;
477		}
478
#	Line 528 | Line 488 | find_capability(const char *capab)
488		*
489		*/
490		void
491	<	send_capabilities(struct Client *client_p, int cap_can_send)
491	>	send_capabilities(struct Client *client_p)
492		{
493	<	struct Capability *cap=NULL;
494	<	char msgbuf[IRCD_BUFSIZE];
535	<	char *t;
536	<	int tl;
537	<	dlink_node *ptr;
493	>	char buf[IRCD_BUFSIZE] = "";
494	>	const dlink_node *node = NULL;
495
496	<	t = msgbuf;
540	<
541	<	DLINK_FOREACH(ptr, cap_list.head)
496	>	DLINK_FOREACH(node, server_capabilities_list.head)
497		{
498	<	cap = ptr->data;
498	>	const struct Capability *cap = node->data;
499
500	<	if (cap->cap & (cap_can_send|default_server_capabs))
546	<	{
547	<	tl = sprintf(t, "%s ", cap->name);
548	<	t += tl;
549	<	}
550	<	}
551	<
552	<	*(t - 1) = '\0';
553	<	sendto_one(client_p, "CAPAB :%s", msgbuf);
554	<	}
555	<
556	<	/* sendnick_TS()
557	<	*
558	<	* inputs       - client (server) to send nick towards
559	<	*          - client to send nick for
560	<	* output       - NONE
561	<	* side effects - NICK message is sent towards given client_p
562	<	*/
563	<	void
564	<	sendnick_TS(struct Client *client_p, struct Client *target_p)
565	<	{
566	<	char ubuf[IRCD_BUFSIZE];
567	<
568	<	if (!IsClient(target_p))
569	<	return;
500	>	strlcat(buf, cap->name, sizeof(buf));
501
502	<	send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
503	<
573	<	if (ubuf[0] == '\0')
574	<	{
575	<	ubuf[0] = '+';
576	<	ubuf[1] = '\0';
502	>	if (node->next)
503	>	strlcat(buf, " ", sizeof(buf));
504		}
505
506	<	if (IsCapable(client_p, CAP_SVS))
580	<	sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
581	<	target_p->servptr->id,
582	<	target_p->name, target_p->hopcount + 1,
583	<	(unsigned long) target_p->tsinfo,
584	<	ubuf, target_p->username, target_p->host,
585	<	(MyClient(target_p) && IsIPSpoof(target_p)) ?
586	<	"0" : target_p->sockhost, target_p->id,
587	<	target_p->svid, target_p->info);
588	<	else
589	<	sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
590	<	target_p->servptr->id,
591	<	target_p->name, target_p->hopcount + 1,
592	<	(unsigned long) target_p->tsinfo,
593	<	ubuf, target_p->username, target_p->host,
594	<	(MyClient(target_p) && IsIPSpoof(target_p)) ?
595	<	"0" : target_p->sockhost, target_p->id, target_p->info);
596	<
597	<	if (!EmptyString(target_p->certfp))
598	<	sendto_one(client_p, ":%s CERTFP %s",
599	<	ID_or_name(target_p, client_p), target_p->certfp);
600	<
601	<	if (target_p->away[0])
602	<	sendto_one(client_p, ":%s AWAY :%s", ID_or_name(target_p, client_p),
603	<	target_p->away);
604	<
506	>	sendto_one(client_p, "CAPAB :%s", buf);
507		}
508
509		/*
#	Line 615 | Line 517 | const char *
517		show_capabilities(const struct Client *target_p)
518		{
519		static char msgbuf[IRCD_BUFSIZE] = "";
520	<	const dlink_node *ptr = NULL;
520	>	const dlink_node *node = NULL;
521
522		strlcpy(msgbuf, "TS", sizeof(msgbuf));
523
524	<	DLINK_FOREACH(ptr, cap_list.head)
524	>	DLINK_FOREACH(node, server_capabilities_list.head)
525		{
526	<	const struct Capability *cap = ptr->data;
526	>	const struct Capability *cap = node->data;
527
528		if (!IsCapable(target_p, cap->cap))
529		continue;
#	Line 644 | Line 546 | struct Server *
546		make_server(struct Client *client_p)
547		{
548		if (client_p->serv == NULL)
549	<	client_p->serv = MyMalloc(sizeof(struct Server));
549	>	client_p->serv = MyCalloc(sizeof(struct Server));
550
551		return client_p->serv;
552		}
553
652	–	/* server_estab()
653	–	*
654	–	* inputs       - pointer to a struct Client
655	–	* output       -
656	–	* side effects -
657	–	*/
658	–	void
659	–	server_estab(struct Client *client_p)
660	–	{
661	–	struct Client *target_p;
662	–	struct MaskItem *conf = NULL;
663	–	char *host;
664	–	const char *inpath;
665	–	static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
666	–	dlink_node *ptr;
667	–	#ifdef HAVE_LIBCRYPTO
668	–	const COMP_METHOD *compression = NULL, *expansion = NULL;
669	–	#endif
670	–
671	–	assert(client_p != NULL);
672	–
673	–	strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
674	–
675	–	inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
676	–	host   = client_p->name;
677	–
678	–	if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
679	–	== NULL)
680	–	{
681	–	/* This shouldn't happen, better tell the ops... -A1kmm */
682	–	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
683	–	"Warning: Lost connect{} block "
684	–	"for server %s(this shouldn't happen)!", host);
685	–	exit_client(client_p, &me, "Lost connect{} block!");
686	–	return;
687	–	}
688	–
689	–	MyFree(client_p->localClient->passwd);
690	–	client_p->localClient->passwd = NULL;
691	–
692	–	/* Its got identd, since its a server */
693	–	SetGotId(client_p);
694	–
695	–	/* If there is something in the serv_list, it might be this
696	–	* connecting server..
697	–	*/
698	–	if (!ServerInfo.hub && serv_list.head)
699	–	{
700	–	if (client_p != serv_list.head->data || serv_list.head->next)
701	–	{
702	–	++ServerStats.is_ref;
703	–	sendto_one(client_p, "ERROR :I'm a leaf not a hub");
704	–	exit_client(client_p, &me, "I'm a leaf");
705	–	return;
706	–	}
707	–	}
708	–
709	–	if (IsUnknown(client_p))
710	–	{
711	–	sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
712	–
713	–	send_capabilities(client_p, 0);
714	–
715	–	sendto_one(client_p, "SERVER %s 1 :%s%s",
716	–	me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
717	–	}
718	–
719	–	sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
720	–	(unsigned long)CurrentTime);
721	–
722	–	if (HasID(client_p))
723	–	hash_add_id(client_p);
724	–
725	–	/* XXX Does this ever happen? I don't think so -db */
726	–	detach_conf(client_p, CONF_OPER);
727	–
728	–	/* *WARNING*
729	–	**    In the following code in place of plain server's
730	–	**    name we send what is returned by get_client_name
731	–	**    which may add the "sockhost" after the name. It's
732	–	**    *very* *important* that there is a SPACE between
733	–	**    the name and sockhost (if present). The receiving
734	–	**    server will start the information field from this
735	–	**    first blank and thus puts the sockhost into info.
736	–	**    ...a bit tricky, but you have been warned, besides
737	–	**    code is more neat this way...  --msa
738	–	*/
739	–	client_p->servptr = &me;
740	–
741	–	if (IsClosing(client_p))
742	–	return;
743	–
744	–	SetServer(client_p);
745	–
746	–	/* Update the capability combination usage counts. -A1kmm */
747	–	set_chcap_usage_counts(client_p);
748	–
749	–	/* Some day, all these lists will be consolidated *sigh* */
750	–	dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
751	–
752	–	assert(dlinkFind(&unknown_list, client_p));
753	–
754	–	dlink_move_node(&client_p->localClient->lclient_node,
755	–	&unknown_list, &serv_list);
756	–
757	–	Count.myserver++;
758	–
759	–	dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
760	–	hash_add_client(client_p);
761	–
762	–	/* doesnt duplicate client_p->serv if allocated this struct already */
763	–	make_server(client_p);
764	–
765	–	/* fixing eob timings.. -gnp */
766	–	client_p->localClient->firsttime = CurrentTime;
767	–
768	–	if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
769	–	AddFlag(client_p, FLAGS_SERVICE);
770	–
771	–	/* Show the real host/IP to admins */
772	–	#ifdef HAVE_LIBCRYPTO
773	–	if (client_p->localClient->fd.ssl)
774	–	{
775	–	compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
776	–	expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
777	–
778	–	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
779	–	"Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
780	–	inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
781	–	compression ? SSL_COMP_get_name(compression) : "NONE",
782	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
783	–	show_capabilities(client_p));
784	–	/* Now show the masked hostname/IP to opers */
785	–	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
786	–	"Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
787	–	inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
788	–	compression ? SSL_COMP_get_name(compression) : "NONE",
789	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
790	–	show_capabilities(client_p));
791	–	ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
792	–	inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
793	–	compression ? SSL_COMP_get_name(compression) : "NONE",
794	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
795	–	show_capabilities(client_p));
796	–	}
797	–	else
798	–	#endif
799	–	{
800	–	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
801	–	"Link with %s established: (Capabilities: %s)",
802	–	inpath_ip, show_capabilities(client_p));
803	–	/* Now show the masked hostname/IP to opers */
804	–	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
805	–	"Link with %s established: (Capabilities: %s)",
806	–	inpath, show_capabilities(client_p));
807	–	ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
808	–	inpath_ip, show_capabilities(client_p));
809	–	}
810	–
811	–	fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
812	–
813	–	sendto_server(client_p, NOCAPS, NOCAPS, ":%s SID %s 2 %s :%s%s",
814	–	me.id, client_p->name, client_p->id,
815	–	IsHidden(client_p) ? "(H) " : "", client_p->info);
816	–
817	–	/*
818	–	* Pass on my client information to the new server
819	–	*
820	–	* First, pass only servers (idea is that if the link gets
821	–	* cancelled beacause the server was already there,
822	–	* there are no NICK's to be cancelled...). Of course,
823	–	* if cancellation occurs, all this info is sent anyway,
824	–	* and I guess the link dies when a read is attempted...? --msa
825	–	*
826	–	* Note: Link cancellation to occur at this point means
827	–	* that at least two servers from my fragment are building
828	–	* up connection this other fragment at the same time, it's
829	–	* a race condition, not the normal way of operation...
830	–	*
831	–	* ALSO NOTE: using the get_client_name for server names--
832	–	*    see previous *WARNING*!!! (Also, original inpath
833	–	*    is destroyed...)
834	–	*/
835	–
836	–	DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
837	–	{
838	–	target_p = ptr->data;
839	–
840	–	/* target_p->from == target_p for target_p == client_p */
841	–	if (IsMe(target_p) || target_p->from == client_p)
842	–	continue;
843	–
844	–	sendto_one(client_p, ":%s SID %s %d %s :%s%s",
845	–	ID(target_p->servptr), target_p->name, target_p->hopcount+1,
846	–	target_p->id, IsHidden(target_p) ? "(H) " : "",
847	–	target_p->info);
848	–
849	–	if (HasFlag(target_p, FLAGS_EOB))
850	–	sendto_one(client_p, ":%s EOB", ID_or_name(target_p, client_p));
851	–	}
852	–
853	–	server_burst(client_p);
854	–	}
855	–
856	–	/* server_burst()
857	–	*
858	–	* inputs       - struct Client pointer server
859	–	*              -
860	–	* output       - none
861	–	* side effects - send a server burst
862	–	* bugs         - still too long
863	–	*/
864	–	static void
865	–	server_burst(struct Client *client_p)
866	–	{
867	–	/* Send it in the shortened format with the TS, if
868	–	** it's a TS server; walk the list of channels, sending
869	–	** all the nicks that haven't been sent yet for each
870	–	** channel, then send the channel itself -- it's less
871	–	** obvious than sending all nicks first, but on the
872	–	** receiving side memory will be allocated more nicely
873	–	** saving a few seconds in the handling of a split
874	–	** -orabidoo
875	–	*/
876	–
877	–	burst_all(client_p);
878	–
879	–	/* EOB stuff is now in burst_all */
880	–	/* Always send a PING after connect burst is done */
881	–	sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
882	–	}
883	–
884	–	/* burst_all()
885	–	*
886	–	* inputs       - pointer to server to send burst to
887	–	* output       - NONE
888	–	* side effects - complete burst of channels/nicks is sent to client_p
889	–	*/
890	–	static void
891	–	burst_all(struct Client *client_p)
892	–	{
893	–	dlink_node *ptr = NULL;
894	–
895	–	DLINK_FOREACH(ptr, global_channel_list.head)
896	–	{
897	–	struct Channel *chptr = ptr->data;
898	–
899	–	if (dlink_list_length(&chptr->members) != 0)
900	–	{
901	–	burst_members(client_p, chptr);
902	–	send_channel_modes(client_p, chptr);
903	–
904	–	if (IsCapable(client_p, CAP_TBURST))
905	–	send_tb(client_p, chptr);
906	–	}
907	–	}
908	–
909	–	/* also send out those that are not on any channel
910	–	*/
911	–	DLINK_FOREACH(ptr, global_client_list.head)
912	–	{
913	–	struct Client *target_p = ptr->data;
914	–
915	–	if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
916	–	sendnick_TS(client_p, target_p);
917	–
918	–	DelFlag(target_p, FLAGS_BURSTED);
919	–	}
920	–
921	–	if (IsCapable(client_p, CAP_EOB))
922	–	sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
923	–	}
924	–
925	–	/*
926	–	* send_tb
927	–	*
928	–	* inputs       - pointer to Client
929	–	*              - pointer to channel
930	–	* output       - NONE
931	–	* side effects - Called on a server burst when
932	–	*                server is CAP_TBURST capable
933	–	*/
934	–	static void
935	–	send_tb(struct Client *client_p, struct Channel *chptr)
936	–	{
937	–	/*
938	–	* We may also send an empty topic here, but only if topic_time isn't 0,
939	–	* i.e. if we had a topic that got unset.  This is required for syncing
940	–	* topics properly.
941	–	*
942	–	* Imagine the following scenario: Our downlink introduces a channel
943	–	* to us with a TS that is equal to ours, but the channel topic on
944	–	* their side got unset while the servers were in splitmode, which means
945	–	* their 'topic' is newer.  They simply wanted to unset it, so we have to
946	–	* deal with it in a more sophisticated fashion instead of just resetting
947	–	* it to their old topic they had before.  Read m_tburst.c:ms_tburst
948	–	* for further information   -Michael
949	–	*/
950	–	if (chptr->topic_time != 0)
951	–	sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s",
952	–	ID_or_name(&me, client_p),
953	–	(unsigned long)chptr->channelts, chptr->chname,
954	–	(unsigned long)chptr->topic_time,
955	–	chptr->topic_info,
956	–	chptr->topic);
957	–	}
958	–
959	–	/* burst_members()
960	–	*
961	–	* inputs       - pointer to server to send members to
962	–	*              - dlink_list pointer to membership list to send
963	–	* output       - NONE
964	–	* side effects -
965	–	*/
966	–	static void
967	–	burst_members(struct Client *client_p, struct Channel *chptr)
968	–	{
969	–	struct Client *target_p;
970	–	struct Membership *ms;
971	–	dlink_node *ptr;
972	–
973	–	DLINK_FOREACH(ptr, chptr->members.head)
974	–	{
975	–	ms       = ptr->data;
976	–	target_p = ms->client_p;
977	–
978	–	if (!HasFlag(target_p, FLAGS_BURSTED))
979	–	{
980	–	AddFlag(target_p, FLAGS_BURSTED);
981	–
982	–	if (target_p->from != client_p)
983	–	sendnick_TS(client_p, target_p);
984	–	}
985	–	}
986	–	}
987	–
554		/* New server connection code
555		* Based upon the stuff floating about in s_bsd.c
556		*   -- adrian
#	Line 1009 | Line 575 | burst_members(struct Client *client_p, s
575		int
576		serv_connect(struct MaskItem *conf, struct Client *by)
577		{
578	<	struct Client *client_p;
579	<	char buf[HOSTIPLEN + 1];
578	>	struct Client *client_p = NULL;
579	>	char buf[HOSTIPLEN + 1] = "";
580
581		/* conversion structs */
582		struct sockaddr_in *v4;
1017	–	/* Make sure conf is useful */
1018	–	assert(conf != NULL);
583
584	+	/* Make sure conf is useful */
585	+	assert(conf);
586
587	<	getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
587	>	getnameinfo((const struct sockaddr *)&conf->addr, conf->addr.ss_len,
588		buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
589		ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", conf->name, conf->host,
590		buf);
#	Line 1026 | Line 592 | serv_connect(struct MaskItem *conf, stru
592		/* Still processing a DNS lookup? -> exit */
593		if (conf->dns_pending)
594		{
595	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
595	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
596		"Error connecting to %s: DNS lookup for connect{} in progress.",
597		conf->name);
598	<	return (0);
598	>	return 0;
599		}
600
601		if (conf->dns_failed)
602		{
603	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
603	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
604		"Error connecting to %s: DNS lookup for connect{} failed.",
605		conf->name);
606	<	return (0);
606	>	return 0;
607		}
608
609		/* Make sure this server isn't already connected
610		* Note: conf should ALWAYS be a valid C: line
611		*/
612	<	if ((client_p = hash_find_server(conf->name)) != NULL)
612	>	if ((client_p = hash_find_server(conf->name)))
613		{
614	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
614	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
615		"Server %s already present from %s",
616		conf->name, get_client_name(client_p, SHOW_IP));
617	<	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
617	>	sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
618		"Server %s already present from %s",
619		conf->name, get_client_name(client_p, MASK_IP));
620		if (by && IsClient(by) && !MyClient(by))
#	Line 1068 | Line 634 | serv_connect(struct MaskItem *conf, stru
634		strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
635
636		/* create a socket for the server connection */
637	<	if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1072	<	SOCK_STREAM, 0, NULL) < 0)
637	>	if (comm_open(&client_p->connection->fd, conf->addr.ss.ss_family, SOCK_STREAM, 0, NULL) < 0)
638		{
639		/* Eek, failure to create the socket */
640	<	report_error(L_ALL, "opening stream socket to %s: %s",
641	<	conf->name, errno);
640	>	report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
641	>
642		SetDead(client_p);
643	<	exit_client(client_p, &me, "Connection failed");
643	>	exit_client(client_p, "Connection failed");
644		return 0;
645		}
646
647		/* servernames are always guaranteed under HOSTLEN chars */
648	<	fd_note(&client_p->localClient->fd, "Server: %s", conf->name);
648	>	fd_note(&client_p->connection->fd, "Server: %s", client_p->name);
649
650		/* Attach config entries to client here rather than in
651		* serv_connect_callback(). This to avoid null pointer references.
652		*/
653		if (!attach_connect_block(client_p, conf->name, conf->host))
654		{
655	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
656	<	"Host %s is not enabled for connecting: no connect{} block",
655	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
656	>	"Host %s is not enabled for connecting: no connect {} block",
657		conf->name);
658		if (by && IsClient(by) && !MyClient(by))
659	<	sendto_one_notice(by, &me, ":Connect to host %s failed.", client_p->name);
659	>	sendto_one_notice(by, &me, ":Connect to host %s failed: no connect {} block", client_p->name);
660
661		SetDead(client_p);
662	<	exit_client(client_p, client_p, "Connection failed");
662	>	exit_client(client_p, "Connection failed");
663		return 0;
664		}
665
#	Line 1112 | Line 677 | serv_connect(struct MaskItem *conf, stru
677		strlcpy(client_p->serv->by, "AutoConn.", sizeof(client_p->serv->by));
678
679		SetConnecting(client_p);
680	<	dlinkAdd(client_p, &client_p->node, &global_client_list);
1116	<	/* from def_fam */
1117	<	client_p->localClient->aftype = conf->aftype;
680	>	client_p->connection->aftype = conf->aftype;
681
682		/* Now, initiate the connection */
683		/* XXX assume that a non 0 type means a specific bind address
#	Line 1124 | Line 687 | serv_connect(struct MaskItem *conf, stru
687		{
688		case AF_INET:
689		v4 = (struct sockaddr_in*)&conf->bind;
690	<	if (v4->sin_addr.s_addr != 0)
690	>	if (v4->sin_addr.s_addr)
691		{
692		struct irc_ssaddr ipn;
693		memset(&ipn, 0, sizeof(struct irc_ssaddr));
694		ipn.ss.ss_family = AF_INET;
695		ipn.ss_port = 0;
696		memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
697	<	comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
697	>	comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
698		(struct sockaddr *)&ipn, ipn.ss_len,
699		serv_connect_callback, client_p, conf->aftype,
700		CONNECTTIMEOUT);
701		}
702	<	else if (ServerInfo.specific_ipv4_vhost)
702	>	else if (ConfigServerInfo.specific_ipv4_vhost)
703		{
704		struct irc_ssaddr ipn;
705		memset(&ipn, 0, sizeof(struct irc_ssaddr));
706		ipn.ss.ss_family = AF_INET;
707		ipn.ss_port = 0;
708	<	memcpy(&ipn, &ServerInfo.ip, sizeof(struct irc_ssaddr));
709	<	comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
708	>	memcpy(&ipn, &ConfigServerInfo.ip, sizeof(struct irc_ssaddr));
709	>	comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
710		(struct sockaddr *)&ipn, ipn.ss_len,
711		serv_connect_callback, client_p, conf->aftype,
712		CONNECTTIMEOUT);
713		}
714		else
715	<	comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
715	>	comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
716		NULL, 0, serv_connect_callback, client_p, conf->aftype,
717		CONNECTTIMEOUT);
718		break;
1156	–	#ifdef IPV6
719		case AF_INET6:
720		{
721		struct irc_ssaddr ipn;
#	Line 1164 | Line 726 | serv_connect(struct MaskItem *conf, stru
726		v6conf = (struct sockaddr_in6 *)&conf->bind;
727		v6 = (struct sockaddr_in6 *)&ipn;
728
729	<	if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)) != 0)
729	>	if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
730		{
731		memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
732		ipn.ss.ss_family = AF_INET6;
733		ipn.ss_port = 0;
734	<	comm_connect_tcp(&client_p->localClient->fd,
734	>	comm_connect_tcp(&client_p->connection->fd,
735		conf->host, conf->port,
736		(struct sockaddr *)&ipn, ipn.ss_len,
737		serv_connect_callback, client_p,
738		conf->aftype, CONNECTTIMEOUT);
739		}
740	<	else if (ServerInfo.specific_ipv6_vhost)
740	>	else if (ConfigServerInfo.specific_ipv6_vhost)
741		{
742	<	memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
742	>	memcpy(&ipn, &ConfigServerInfo.ip6, sizeof(struct irc_ssaddr));
743		ipn.ss.ss_family = AF_INET6;
744		ipn.ss_port = 0;
745	<	comm_connect_tcp(&client_p->localClient->fd,
745	>	comm_connect_tcp(&client_p->connection->fd,
746		conf->host, conf->port,
747		(struct sockaddr *)&ipn, ipn.ss_len,
748		serv_connect_callback, client_p,
749		conf->aftype, CONNECTTIMEOUT);
750		}
751		else
752	<	comm_connect_tcp(&client_p->localClient->fd,
752	>	comm_connect_tcp(&client_p->connection->fd,
753		conf->host, conf->port,
754		NULL, 0, serv_connect_callback, client_p,
755		conf->aftype, CONNECTTIMEOUT);
756		}
1195	–	#endif
757		}
758	+
759		return 1;
760		}
761
#	Line 1203 | Line 765 | finish_ssl_server_handshake(struct Clien
765		{
766		struct MaskItem *conf = NULL;
767
768	<	conf = find_conf_name(&client_p->localClient->confs,
768	>	conf = find_conf_name(&client_p->connection->confs,
769		client_p->name, CONF_SERVER);
770		if (conf == NULL)
771		{
772	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
773	<	"Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
774	<	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
772	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
773	>	"Lost connect{} block for %s", get_client_name(client_p, SHOW_IP));
774	>	sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
775		"Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
776
777	<	exit_client(client_p, &me, "Lost connect{} block");
777	>	exit_client(client_p, "Lost connect{} block");
778		return;
779		}
780
781		sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
782
783	<	send_capabilities(client_p, 0);
783	>	send_capabilities(client_p);
784
785		sendto_one(client_p, "SERVER %s 1 :%s%s",
786		me.name, ConfigServerHide.hidden ? "(H) " : "",
787		me.info);
788
789	<	/* If we've been marked dead because a send failed, just exit
789	>	/*
790	>	* If we've been marked dead because a send failed, just exit
791		* here now and save everyone the trouble of us ever existing.
792		*/
793		if (IsDead(client_p))
794		{
795	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
796	<	"%s[%s] went dead during handshake",
797	<	client_p->name,
798	<	client_p->host);
799	<	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1237	<	"%s went dead during handshake", client_p->name);
1238	<	return;
795	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
796	>	"%s went dead during handshake", get_client_name(client_p, SHOW_IP));
797	>	sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
798	>	"%s went dead during handshake", get_client_name(client_p, MASK_IP));
799	>	return;
800		}
801
802		/* don't move to serv_list yet -- we haven't sent a burst! */
803		/* If we get here, we're ok, so lets start reading some data */
804	<	comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ, read_packet, client_p, 0);
804	>	comm_setselect(&client_p->connection->fd, COMM_SELECT_READ, read_packet, client_p, 0);
805		}
806
807		static void
808	<	ssl_server_handshake(fde_t *fd, struct Client *client_p)
808	>	ssl_server_handshake(fde_t *fd, void *data)
809		{
810	+	struct Client *client_p = data;
811		X509 *cert = NULL;
812		int ret = 0;
813
814	<	if ((ret = SSL_connect(client_p->localClient->fd.ssl)) <= 0)
814	>	if ((ret = SSL_connect(client_p->connection->fd.ssl)) <= 0)
815		{
816	<	switch (SSL_get_error(client_p->localClient->fd.ssl, ret))
816	>	if ((CurrentTime - client_p->connection->firsttime) > CONNECTTIMEOUT)
817	>	{
818	>	exit_client(client_p, "Timeout during SSL handshake");
819	>	return;
820	>	}
821	>
822	>	switch (SSL_get_error(client_p->connection->fd.ssl, ret))
823		{
824		case SSL_ERROR_WANT_WRITE:
825	<	comm_setselect(&client_p->localClient->fd, COMM_SELECT_WRITE,
826	<	(PF *)ssl_server_handshake, client_p, 0);
825	>	comm_setselect(&client_p->connection->fd, COMM_SELECT_WRITE,
826	>	ssl_server_handshake, client_p, CONNECTTIMEOUT);
827		return;
828		case SSL_ERROR_WANT_READ:
829	<	comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ,
830	<	(PF *)ssl_server_handshake, client_p, 0);
829	>	comm_setselect(&client_p->connection->fd, COMM_SELECT_READ,
830	>	ssl_server_handshake, client_p, CONNECTTIMEOUT);
831		return;
832		default:
833		{
834		const char *sslerr = ERR_error_string(ERR_get_error(), NULL);
835	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
835	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
836		"Error connecting to %s: %s", client_p->name,
837		sslerr ? sslerr : "unknown SSL error");
838	<	exit_client(client_p, client_p, "Error during SSL handshake");
838	>	exit_client(client_p, "Error during SSL handshake");
839		return;
840		}
841		}
842		}
843
844	<	if ((cert = SSL_get_peer_certificate(client_p->localClient->fd.ssl)))
844	>	comm_settimeout(&client_p->connection->fd, 0, NULL, NULL);
845	>
846	>	if ((cert = SSL_get_peer_certificate(client_p->connection->fd.ssl)))
847		{
848	<	int res = SSL_get_verify_result(client_p->localClient->fd.ssl);
849	<	char buf[EVP_MAX_MD_SIZE * 2 + 1] = { '\0' };
850	<	unsigned char md[EVP_MAX_MD_SIZE] = { '\0' };
848	>	int res = SSL_get_verify_result(client_p->connection->fd.ssl);
849	>	char buf[EVP_MAX_MD_SIZE * 2 + 1] = "";
850	>	unsigned char md[EVP_MAX_MD_SIZE] = "";
851
852		if (res == X509_V_OK || res == X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN ||
853		res == X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE ||
854		res == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT)
855		{
856	<	unsigned int i = 0, n = 0;
856	>	unsigned int n = 0;
857
858	<	if (X509_digest(cert, EVP_sha256(), md, &n))
858	>	if (X509_digest(cert, ConfigServerInfo.message_digest_algorithm, md, &n))
859		{
860	<	for (; i < n; ++i)
1291	<	snprintf(buf + 2 * i, 3, "%02X", md[i]);
860	>	binary_to_hex(md, buf, n);
861		client_p->certfp = xstrdup(buf);
862		}
863		}
#	Line 1302 | Line 871 | ssl_server_handshake(fde_t *fd, struct C
871		}
872
873		static void
874	<	ssl_connect_init(struct Client *client_p, struct MaskItem *conf, fde_t *fd)
874	>	ssl_connect_init(struct Client *client_p, const struct MaskItem *conf, fde_t *fd)
875		{
876	<	if ((client_p->localClient->fd.ssl = SSL_new(ServerInfo.client_ctx)) == NULL)
876	>	if ((client_p->connection->fd.ssl = SSL_new(ConfigServerInfo.client_ctx)) == NULL)
877		{
878		ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
879		ERR_error_string(ERR_get_error(), NULL));
880		SetDead(client_p);
881	<	exit_client(client_p, client_p, "SSL_new failed");
881	>	exit_client(client_p, "SSL_new failed");
882		return;
883		}
884
885		SSL_set_fd(fd->ssl, fd->fd);
886
887		if (!EmptyString(conf->cipher_list))
888	<	SSL_set_cipher_list(client_p->localClient->fd.ssl, conf->cipher_list);
888	>	SSL_set_cipher_list(client_p->connection->fd.ssl, conf->cipher_list);
889
890		ssl_server_handshake(NULL, client_p);
891		}
#	Line 1333 | Line 902 | ssl_connect_init(struct Client *client_p
902		static void
903		serv_connect_callback(fde_t *fd, int status, void *data)
904		{
905	<	struct Client *client_p = data;
906	<	struct MaskItem *conf = NULL;
905	>	struct Client *const client_p = data;
906	>	const struct MaskItem *conf = NULL;
907
908	<	/* First, make sure its a real client! */
909	<	assert(client_p != NULL);
910	<	assert(&client_p->localClient->fd == fd);
908	>	/* First, make sure it's a real client! */
909	>	assert(client_p);
910	>	assert(&client_p->connection->fd == fd);
911
912		/* Next, for backward purposes, record the ip of the server */
913	<	memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
913	>	memcpy(&client_p->connection->ip, &fd->connect.hostaddr,
914		sizeof(struct irc_ssaddr));
915	+
916		/* Check the status */
917		if (status != COMM_OK)
918		{
919	<	/* We have an error, so report it and quit
920	<	* Admins get to see any IP, mere opers don't *sigh*
919	>	/* We have an error, so report it and quit */
920	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
921	>	"Error connecting to %s: %s",
922	>	get_client_name(client_p, SHOW_IP), comm_errstr(status));
923	>	sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
924	>	"Error connecting to %s: %s",
925	>	get_client_name(client_p, MASK_IP), comm_errstr(status));
926	>
927	>	/*
928	>	* If a fd goes bad, call dead_link() the socket is no
929	>	* longer valid for reading or writing.
930		*/
931	<	if (ConfigServerHide.hide_server_ips)
932	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1354	<	"Error connecting to %s: %s",
1355	<	client_p->name, comm_errstr(status));
1356	<	else
1357	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1358	<	"Error connecting to %s[%s]: %s", client_p->name,
1359	<	client_p->host, comm_errstr(status));
1360	<
1361	<	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1362	<	"Error connecting to %s: %s",
1363	<	client_p->name, comm_errstr(status));
1364	<
1365	<	/* If a fd goes bad, call dead_link() the socket is no
1366	<	* longer valid for reading or writing.
1367	<	*/
1368	<	dead_link_on_write(client_p, 0);
1369	<	return;
931	>	dead_link_on_write(client_p, 0);
932	>	return;
933		}
934
935		/* COMM_OK, so continue the connection procedure */
936		/* Get the C/N lines */
937	<	conf = find_conf_name(&client_p->localClient->confs,
937	>	conf = find_conf_name(&client_p->connection->confs,
938		client_p->name, CONF_SERVER);
939		if (conf == NULL)
940		{
941	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
942	<	"Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
943	<	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
941	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
942	>	"Lost connect{} block for %s", get_client_name(client_p, SHOW_IP));
943	>	sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
944		"Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
945
946	<	exit_client(client_p, &me, "Lost connect{} block");
946	>	exit_client(client_p, "Lost connect{} block");
947		return;
948		}
949
#	Line 1397 | Line 960 | serv_connect_callback(fde_t *fd, int sta
960
961		sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
962
963	<	send_capabilities(client_p, 0);
963	>	send_capabilities(client_p);
964
965		sendto_one(client_p, "SERVER %s 1 :%s%s", me.name,
966		ConfigServerHide.hidden ? "(H) " : "", me.info);
967
968	<	/* If we've been marked dead because a send failed, just exit
968	>	/*
969	>	* If we've been marked dead because a send failed, just exit
970		* here now and save everyone the trouble of us ever existing.
971		*/
972		if (IsDead(client_p))
973		{
974	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
975	<	"%s[%s] went dead during handshake",
976	<	client_p->name,
977	<	client_p->host);
978	<	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1415	<	"%s went dead during handshake", client_p->name);
1416	<	return;
974	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
975	>	"%s went dead during handshake", get_client_name(client_p, SHOW_IP));
976	>	sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
977	>	"%s went dead during handshake", get_client_name(client_p, MASK_IP));
978	>	return;
979		}
980
981		/* don't move to serv_list yet -- we haven't sent a burst! */

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines (old)
>	Changed lines (new)