ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/server.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_serv.c (file contents), Revision 1851 by michael, Wed Apr 24 18:31:06 2013 UTC vs.
ircd-hybrid/trunk/src/server.c (file contents), Revision 4113 by michael, Tue Jul 1 16:02:52 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_serv.c: Server related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2005 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 18 | Line 17
17   *  along with this program; if not, write to the Free Software
18   *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file s_serv.c
23 > * \brief Server related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
# Line 28 | Line 30
30   #include "rsa.h"
31   #endif
32   #include "list.h"
31 #include "channel.h"
32 #include "channel_mode.h"
33   #include "client.h"
34 #include "dbuf.h"
34   #include "event.h"
36 #include "fdlist.h"
35   #include "hash.h"
36   #include "irc_string.h"
37   #include "ircd.h"
# Line 41 | Line 39
39   #include "s_bsd.h"
40   #include "numeric.h"
41   #include "packet.h"
44 #include "irc_res.h"
42   #include "conf.h"
43 < #include "s_serv.h"
43 > #include "server.h"
44   #include "log.h"
45 < #include "s_misc.h"
49 < #include "s_user.h"
45 > #include "user.h"
46   #include "send.h"
47   #include "memory.h"
48 < #include "channel.h" /* chcap_usage_counts stuff...*/
48 > #include "channel.h"
49   #include "parse.h"
50  
51   #define MIN_CONN_FREQ 300
52  
53 + dlink_list flatten_links;
54   static dlink_list cap_list = { NULL, NULL, 0 };
58 static void server_burst(struct Client *);
59 static void burst_all(struct Client *);
60 static void send_tb(struct Client *client_p, struct Channel *chptr);
61
55   static CNCB serv_connect_callback;
56  
64 static void burst_members(struct Client *, struct Channel *);
57  
58   /*
59   * write_links_file
# Line 72 | Line 64 | static void burst_members(struct Client
64   *                but in no particular order.
65   */
66   void
67 < write_links_file(void* notused)
67 > write_links_file(void *notused)
68   {
69 <  MessageFileLine *next_mptr = NULL;
70 <  MessageFileLine *mptr = NULL;
71 <  MessageFileLine *currentMessageLine = NULL;
80 <  MessageFileLine *newMessageLine = NULL;
81 <  MessageFile *MessageFileptr = &ConfigFileEntry.linksfile;
82 <  FILE *file;
83 <  char buff[512];
84 <  dlink_node *ptr;
69 >  FILE *file = NULL;
70 >  dlink_node *ptr = NULL, *ptr_next = NULL;
71 >  char buff[IRCD_BUFSIZE] = "";
72  
73 <  if ((file = fopen(MessageFileptr->fileName, "w")) == NULL)
73 >  if ((file = fopen(LIPATH, "w")) == NULL)
74      return;
75  
76 <  for (mptr = MessageFileptr->contentsOfFile; mptr; mptr = next_mptr)
76 >  DLINK_FOREACH_SAFE(ptr, ptr_next, flatten_links.head)
77    {
78 <    next_mptr = mptr->next;
79 <    MyFree(mptr);
78 >    dlinkDelete(ptr, &flatten_links);
79 >    MyFree(ptr->data);
80 >    free_dlink_node(ptr);
81    }
82  
95  MessageFileptr->contentsOfFile = NULL;
96
83    DLINK_FOREACH(ptr, global_serv_list.head)
84    {
85      const struct Client *target_p = ptr->data;
86  
87 <    /* skip ourselves, we send ourselves in /links */
88 <    if (IsMe(target_p))
89 <      continue;
90 <
91 <    /* skip hidden servers */
106 <    if (IsHidden(target_p))
87 >    /*
88 >     * Skip hidden servers, aswell as ourselves, since we already send
89 >     * ourselves in /links
90 >     */
91 >    if (IsHidden(target_p) || IsMe(target_p))
92        continue;
93  
94      if (HasFlag(target_p, FLAGS_SERVICE) && ConfigServerHide.hide_services)
95        continue;
96  
112    newMessageLine = MyMalloc(sizeof(MessageFileLine));
113
97      /*
98       * Attempt to format the file in such a way it follows the usual links output
99       * ie  "servername uplink :hops info"
100       * Mostly for aesthetic reasons - makes it look pretty in mIRC ;)
101       * - madmax
102       */
103 <    snprintf(newMessageLine->line, sizeof(newMessageLine->line), "%s %s :1 %s",
104 <             target_p->name, me.name, target_p->info);
103 >    snprintf(buff, sizeof(buff), "%s %s :1 %s",   target_p->name,
104 >             me.name, target_p->info);
105 >    dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
106 >    snprintf(buff, sizeof(buff), "%s %s :1 %s\n", target_p->name,
107 >             me.name, target_p->info);
108  
123    if (MessageFileptr->contentsOfFile)
124    {
125      if (currentMessageLine)
126        currentMessageLine->next = newMessageLine;
127      currentMessageLine = newMessageLine;
128    }
129    else
130    {
131      MessageFileptr->contentsOfFile = newMessageLine;
132      currentMessageLine = newMessageLine;
133    }
134
135    snprintf(buff, sizeof(buff), "%s %s :1 %s\n",
136             target_p->name, me.name, target_p->info);
109      fputs(buff, file);
110    }
111  
112    fclose(file);
113   }
114  
115 + void
116 + read_links_file(void)
117 + {
118 +  FILE *file = NULL;
119 +  char *p = NULL;
120 +  char buff[IRCD_BUFSIZE] = "";
121 +
122 +  if ((file = fopen(LIPATH, "r")) == NULL)
123 +    return;
124 +
125 +  while (fgets(buff, sizeof(buff), file))
126 +  {
127 +    if ((p = strchr(buff, '\n')))
128 +      *p = '\0';
129 +
130 +    dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
131 +  }
132 +
133 +  fclose(file);
134 + }
135 +
136   /* hunt_server()
137   *      Do the basic thing in delivering the message (command)
138   *      across the relays to the specific server (server) for
# Line 160 | Line 153 | write_links_file(void* notused)
153   *      returns: (see #defines)
154   */
155   int
156 < hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
157 <            int server, int parc, char *parv[])
156 > hunt_server(struct Client *source_p, const char *command,
157 >            const int server, const int parc, char *parv[])
158   {
159    struct Client *target_p = NULL;
160    struct Client *target_tmp = NULL;
161    dlink_node *ptr;
169  int wilds;
162  
163    /* Assume it's me, if no server */
164    if (parc <= server || EmptyString(parv[server]))
# Line 182 | Line 174 | hunt_server(struct Client *client_p, str
174    if (MyClient(source_p))
175      target_p = hash_find_client(parv[server]);
176    else
177 <    target_p = find_person(client_p, parv[server]);
177 >    target_p = find_person(source_p, parv[server]);
178  
179    if (target_p)
180      if (target_p->from == source_p->from && !MyConnect(target_p))
# Line 192 | Line 184 | hunt_server(struct Client *client_p, str
184      if (target_p->from == source_p->from && !MyConnect(target_p))
185        target_p = NULL;
186  
195  collapse(parv[server]);
196  wilds = has_wildcards(parv[server]);
197
187    /* Again, if there are no wild cards involved in the server
188     * name, use the hash lookup
189     */
190    if (target_p == NULL)
191    {
192 <    if (!wilds)
192 >    if (!has_wildcards(parv[server]))
193      {
194        if (!(target_p = hash_find_server(parv[server])))
195        {
196 <        sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
197 <                   me.name, source_p->name, parv[server]);
209 <        return(HUNTED_NOSUCH);
196 >        sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
197 >        return HUNTED_NOSUCH;
198        }
199      }
200      else
# Line 221 | Line 209 | hunt_server(struct Client *client_p, str
209              continue;
210            target_p = ptr->data;
211  
212 <          if (IsRegistered(target_p) && (target_p != client_p))
212 >          if (IsRegistered(target_p) && (target_p != source_p->from))
213              break;
214          }
215        }
216      }
217    }
218  
219 <  if (target_p != NULL)
219 >  if (target_p)
220    {
221 <    if(!IsRegistered(target_p))
221 >    if (!IsRegistered(target_p))
222      {
223 <      sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
236 <                 me.name, source_p->name, parv[server]);
223 >      sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
224        return HUNTED_NOSUCH;
225      }
226  
# Line 244 | Line 231 | hunt_server(struct Client *client_p, str
231        parv[server] = target_p->name;
232  
233      /* This is a little kludgy but should work... */
234 <    if (IsClient(source_p) &&
248 <        ((MyConnect(target_p) && IsCapable(target_p, CAP_TS6)) ||
249 <         (!MyConnect(target_p) && IsCapable(target_p->from, CAP_TS6))))
250 <      parv[0] = ID(source_p);
251 <
252 <    sendto_one(target_p, command, parv[0],
234 >    sendto_one(target_p, command, ID_or_name(source_p, target_p),
235                 parv[1], parv[2], parv[3], parv[4],
236                 parv[5], parv[6], parv[7], parv[8]);
237 <    return(HUNTED_PASS);
238 <  }
237 >    return HUNTED_PASS;
238 >  }
239  
240 <  sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
241 <             me.name, source_p->name, parv[server]);
260 <  return(HUNTED_NOSUCH);
240 >  sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
241 >  return HUNTED_NOSUCH;
242   }
243  
244   /* try_connections()
# Line 274 | Line 255 | void
255   try_connections(void *unused)
256   {
257    dlink_node *ptr = NULL;
258 <  struct MaskItem *conf;
278 <  int confrq;
258 >  int confrq = 0;
259  
260    /* TODO: change this to set active flag to 0 when added to event! --Habeeb */
261    if (GlobalSetOptions.autoconn == 0)
# Line 283 | Line 263 | try_connections(void *unused)
263  
264    DLINK_FOREACH(ptr, server_items.head)
265    {
266 <    conf = ptr->data;
266 >    struct MaskItem *conf = ptr->data;
267  
268      assert(conf->type == CONF_SERVER);
269  
270 <    /* Also when already connecting! (update holdtimes) --SRB
270 >    /* Also when already connecting! (update holdtimes) --SRB
271       */
272      if (!conf->port ||!IsConfAllowAutoConn(conf))
273        continue;
# Line 302 | Line 282 | try_connections(void *unused)
282      if (conf->until > CurrentTime)
283        continue;
284  
285 <    if (conf->class == NULL)
286 <      confrq = DEFAULT_CONNECTFREQUENCY;
287 <    else
288 <    {
289 <      confrq = conf->class->con_freq;
310 <      if (confrq < MIN_CONN_FREQ)
311 <        confrq = MIN_CONN_FREQ;
312 <    }
285 >    assert(conf->class);
286 >
287 >    confrq = conf->class->con_freq;
288 >    if (confrq < MIN_CONN_FREQ)
289 >      confrq = MIN_CONN_FREQ;
290  
291      conf->until = CurrentTime + confrq;
292  
293 <    /* Found a CONNECT config with port specified, scan clients
293 >    /*
294 >     * Found a CONNECT config with port specified, scan clients
295       * and see if this server is already connected?
296       */
297 <    if (hash_find_server(conf->name) != NULL)
297 >    if (hash_find_server(conf->name))
298        continue;
299  
300      if (conf->class->ref_count < conf->class->max_total)
301      {
302        /* Go to the end of the list, if not already last */
303 <      if (ptr->next != NULL)
303 >      if (ptr->next)
304        {
305          dlinkDelete(ptr, &server_items);
306          dlinkAddTail(conf, &conf->node, &server_items);
# Line 331 | Line 309 | try_connections(void *unused)
309        if (find_servconn_in_progress(conf->name))
310          return;
311  
312 <      /* We used to only print this if serv_connect() actually
312 >      /*
313 >       * We used to only print this if serv_connect() actually
314         * succeeded, but since comm_tcp_connect() can call the callback
315         * immediately if there is an error, we were getting error messages
316         * in the wrong order. SO, we just print out the activated line,
# Line 358 | Line 337 | try_connections(void *unused)
337   int
338   valid_servname(const char *name)
339   {
340 <  unsigned int length = 0;
362 <  unsigned int dots   = 0;
340 >  unsigned int dots = 0;
341    const char *p = name;
342  
343    for (; *p; ++p)
# Line 367 | Line 345 | valid_servname(const char *name)
345      if (!IsServChar(*p))
346        return 0;
347  
370    ++length;
371
348      if (*p == '.')
349        ++dots;
350    }
351  
352 <  return dots != 0 && length <= HOSTLEN;
352 >  return dots && (p - name) <= HOSTLEN;
353   }
354  
355   int
# Line 384 | Line 360 | check_server(const char *name, struct Cl
360    struct MaskItem *server_conf = NULL;
361    int error = -1;
362  
363 <  assert(client_p != NULL);
363 >  assert(client_p);
364  
365    /* loop through looking for all possible connect items that might work */
366    DLINK_FOREACH(ptr, server_items.head)
# Line 398 | Line 374 | check_server(const char *name, struct Cl
374  
375      /* XXX: Fix me for IPv6                    */
376      /* XXX sockhost is the IPv4 ip as a string */
377 <    if (!match(conf->host, client_p->host) ||
377 >    if (!match(conf->host, client_p->host) ||
378          !match(conf->host, client_p->sockhost))
379      {
380        error = -2;
# Line 406 | Line 382 | check_server(const char *name, struct Cl
382        if (!match_conf_password(client_p->localClient->passwd, conf))
383          return -2;
384  
385 +      if (!EmptyString(conf->certfp))
386 +        if (EmptyString(client_p->certfp) || strcasecmp(client_p->certfp, conf->certfp))
387 +          return -4;
388 +
389        server_conf = conf;
390      }
391    }
392  
393    if (server_conf == NULL)
394 <    return(error);
394 >    return error;
395  
396    attach_conf(client_p, server_conf);
397  
398  
399 <  if (server_conf != NULL)
399 >  if (server_conf)
400    {
401      struct sockaddr_in *v4;
402   #ifdef IPV6
# Line 425 | Line 405 | check_server(const char *name, struct Cl
405      switch (server_conf->aftype)
406      {
407   #ifdef IPV6
408 <      case AF_INET6:
408 >      case AF_INET6:
409          v6 = (struct sockaddr_in6 *)&server_conf->addr;
410  
411          if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
# Line 436 | Line 416 | check_server(const char *name, struct Cl
416          v4 = (struct sockaddr_in *)&server_conf->addr;
417  
418          if (v4->sin_addr.s_addr == INADDR_NONE)
419 <          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
419 >          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
420          break;
421      }
422    }
423  
424 <  return(0);
424 >  return 0;
425   }
426  
427   /* add_capability()
# Line 456 | Line 436 | check_server(const char *name, struct Cl
436   void
437   add_capability(const char *capab_name, int cap_flag, int add_to_default)
438   {
439 <  struct Capability *cap = MyMalloc(sizeof(*cap));
439 >  struct Capability *cap = MyCalloc(sizeof(*cap));
440  
441    cap->name = xstrdup(capab_name);
442    cap->cap = cap_flag;
# Line 475 | Line 455 | add_capability(const char *capab_name, i
455   int
456   delete_capability(const char *capab_name)
457   {
458 <  dlink_node *ptr;
479 <  dlink_node *next_ptr;
480 <  struct Capability *cap;
458 >  dlink_node *ptr = NULL, *ptr_next = NULL;
459  
460 <  DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
460 >  DLINK_FOREACH_SAFE(ptr, ptr_next, cap_list.head)
461    {
462 <    cap = ptr->data;
462 >    struct Capability *cap = ptr->data;
463  
464 <    if (cap->cap != 0)
464 >    if (cap->cap)
465      {
466 <      if (irccmp(cap->name, capab_name) == 0)
466 >      if (!irccmp(cap->name, capab_name))
467        {
468 <        default_server_capabs &= ~(cap->cap);
469 <        dlinkDelete(ptr, &cap_list);
470 <        MyFree(cap->name);
471 <        cap->name = NULL;
494 <        MyFree(cap);
468 >        default_server_capabs &= ~(cap->cap);
469 >        dlinkDelete(ptr, &cap_list);
470 >        MyFree(cap->name);
471 >        MyFree(cap);
472        }
473      }
474    }
# Line 506 | Line 483 | delete_capability(const char *capab_name
483   * output       - 0 if not found CAPAB otherwise
484   * side effects - none
485   */
486 < int
486 > unsigned int
487   find_capability(const char *capab)
488   {
489    const dlink_node *ptr = NULL;
# Line 533 | Line 510 | find_capability(const char *capab)
510   void
511   send_capabilities(struct Client *client_p, int cap_can_send)
512   {
513 <  struct Capability *cap=NULL;
514 <  char msgbuf[IRCD_BUFSIZE];
538 <  char *t;
539 <  int tl;
540 <  dlink_node *ptr;
541 <
542 <  t = msgbuf;
513 >  char buf[IRCD_BUFSIZE] = "";
514 >  const dlink_node *ptr = NULL;
515  
516    DLINK_FOREACH(ptr, cap_list.head)
517    {
518 <    cap = ptr->data;
518 >    const struct Capability *cap = ptr->data;
519  
520      if (cap->cap & (cap_can_send|default_server_capabs))
521      {
522 <      tl = sprintf(t, "%s ", cap->name);
523 <      t += tl;
522 >      strlcat(buf, cap->name, sizeof(buf));
523 >      if (ptr->next)
524 >        strlcat(buf, " ", sizeof(buf));
525      }
526    }
527  
528 <  *(t - 1) = '\0';
556 <  sendto_one(client_p, "CAPAB :%s", msgbuf);
557 < }
558 <
559 < /* sendnick_TS()
560 < *
561 < * inputs       - client (server) to send nick towards
562 < *          - client to send nick for
563 < * output       - NONE
564 < * side effects - NICK message is sent towards given client_p
565 < */
566 < void
567 < sendnick_TS(struct Client *client_p, struct Client *target_p)
568 < {
569 <  static char ubuf[12];
570 <
571 <  if (!IsClient(target_p))
572 <    return;
573 <
574 <  send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
575 <
576 <  if (ubuf[0] == '\0')
577 <  {
578 <    ubuf[0] = '+';
579 <    ubuf[1] = '\0';
580 <  }
581 <
582 <  if (IsCapable(client_p, CAP_SVS))
583 <  {
584 <    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
585 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
586 <                 target_p->servptr->id,
587 <                 target_p->name, target_p->hopcount + 1,
588 <                 (unsigned long) target_p->tsinfo,
589 <                 ubuf, target_p->username, target_p->host,
590 <                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
591 <                 "0" : target_p->sockhost, target_p->id,
592 <                 target_p->svid, target_p->info);
593 <    else
594 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s %s :%s",
595 <                 target_p->name, target_p->hopcount + 1,
596 <                 (unsigned long) target_p->tsinfo,
597 <                 ubuf, target_p->username, target_p->host,
598 <                 target_p->servptr->name, target_p->svid,
599 <                 target_p->info);
600 <  }
601 <  else
602 <  {
603 <    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
604 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
605 <                 target_p->servptr->id,
606 <                 target_p->name, target_p->hopcount + 1,
607 <                 (unsigned long) target_p->tsinfo,
608 <                 ubuf, target_p->username, target_p->host,
609 <                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
610 <                 "0" : target_p->sockhost, target_p->id, target_p->info);
611 <    else
612 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s :%s",
613 <                 target_p->name, target_p->hopcount + 1,
614 <                 (unsigned long) target_p->tsinfo,
615 <                 ubuf, target_p->username, target_p->host,
616 <                 target_p->servptr->name, target_p->info);
617 <  }
618 <
619 <  if (target_p->away[0])
620 <    sendto_one(client_p, ":%s AWAY :%s", ID_or_name(target_p, client_p),
621 <               target_p->away);
622 <
528 >  sendto_one(client_p, "CAPAB :%s", buf);
529   }
530  
531   /*
# Line 630 | Line 536 | sendnick_TS(struct Client *client_p, str
536   * side effects - build up string representing capabilities of server listed
537   */
538   const char *
539 < show_capabilities(struct Client *target_p)
539 > show_capabilities(const struct Client *target_p)
540   {
541 <  static char msgbuf[IRCD_BUFSIZE];
542 <  char *t = msgbuf;
637 <  dlink_node *ptr;
541 >  static char msgbuf[IRCD_BUFSIZE] = "";
542 >  const dlink_node *ptr = NULL;
543  
544 <  t += sprintf(msgbuf, "TS ");
544 >  strlcpy(msgbuf, "TS", sizeof(msgbuf));
545  
546    DLINK_FOREACH(ptr, cap_list.head)
547    {
548      const struct Capability *cap = ptr->data;
549  
550 <    if (IsCapable(target_p, cap->cap))
551 <      t += sprintf(t, "%s ", cap->name);
550 >    if (!IsCapable(target_p, cap->cap))
551 >      continue;
552 >
553 >    strlcat(msgbuf,       " ", sizeof(msgbuf));
554 >    strlcat(msgbuf, cap->name, sizeof(msgbuf));
555    }
556  
649  *(t - 1) = '\0';
557    return msgbuf;
558   }
559  
# Line 661 | Line 568 | struct Server *
568   make_server(struct Client *client_p)
569   {
570    if (client_p->serv == NULL)
571 <    client_p->serv = MyMalloc(sizeof(struct Server));
571 >    client_p->serv = MyCalloc(sizeof(struct Server));
572  
573    return client_p->serv;
574   }
575  
669 /* server_estab()
670 *
671 * inputs       - pointer to a struct Client
672 * output       -
673 * side effects -
674 */
675 void
676 server_estab(struct Client *client_p)
677 {
678  struct Client *target_p;
679  struct MaskItem *conf = NULL;
680  char *host;
681  const char *inpath;
682  static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
683  dlink_node *ptr;
684 #ifdef HAVE_LIBCRYPTO
685  const COMP_METHOD *compression = NULL, *expansion = NULL;
686 #endif
687
688  assert(client_p != NULL);
689
690  strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
691
692  inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
693  host   = client_p->name;
694
695  if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
696      == NULL)
697  {
698    /* This shouldn't happen, better tell the ops... -A1kmm */
699    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
700                         "Warning: Lost connect{} block "
701                         "for server %s(this shouldn't happen)!", host);
702    exit_client(client_p, &me, "Lost connect{} block!");
703    return;
704  }
705
706  MyFree(client_p->localClient->passwd);
707  client_p->localClient->passwd = NULL;
708
709  /* Its got identd, since its a server */
710  SetGotId(client_p);
711
712  /* If there is something in the serv_list, it might be this
713   * connecting server..
714   */
715  if (!ServerInfo.hub && serv_list.head)  
716  {
717    if (client_p != serv_list.head->data || serv_list.head->next)
718    {
719      ++ServerStats.is_ref;
720      sendto_one(client_p, "ERROR :I'm a leaf not a hub");
721      exit_client(client_p, &me, "I'm a leaf");
722      return;
723    }
724  }
725
726  if (IsUnknown(client_p))
727  {
728    /* jdc -- 1.  Use EmptyString(), not [0] index reference.
729     *        2.  Check conf->spasswd, not conf->passwd.
730     */
731    if (!EmptyString(conf->spasswd))
732      sendto_one(client_p, "PASS %s TS %d %s",
733                 conf->spasswd, TS_CURRENT, me.id);
734
735    send_capabilities(client_p, 0);
736
737    sendto_one(client_p, "SERVER %s 1 :%s%s",
738               me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
739  }
740
741  sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
742             (unsigned long)CurrentTime);
743
744  /* assumption here is if they passed the correct TS version, they also passed an SID */
745  if (IsCapable(client_p, CAP_TS6))
746    hash_add_id(client_p);
747
748  /* XXX Does this ever happen? I don't think so -db */
749  detach_conf(client_p, CONF_OPER);
750
751  /* *WARNING*
752  **    In the following code in place of plain server's
753  **    name we send what is returned by get_client_name
754  **    which may add the "sockhost" after the name. It's
755  **    *very* *important* that there is a SPACE between
756  **    the name and sockhost (if present). The receiving
757  **    server will start the information field from this
758  **    first blank and thus puts the sockhost into info.
759  **    ...a bit tricky, but you have been warned, besides
760  **    code is more neat this way...  --msa
761  */
762  client_p->servptr = &me;
763
764  if (IsClosing(client_p))
765    return;
766
767  SetServer(client_p);
768
769  /* Update the capability combination usage counts. -A1kmm */
770  set_chcap_usage_counts(client_p);
771
772  /* Some day, all these lists will be consolidated *sigh* */
773  dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
774
775  assert(dlinkFind(&unknown_list, client_p));
776
777  dlink_move_node(&client_p->localClient->lclient_node,
778                  &unknown_list, &serv_list);
779
780  Count.myserver++;
781
782  dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
783  hash_add_client(client_p);
784
785  /* doesnt duplicate client_p->serv if allocated this struct already */
786  make_server(client_p);
787
788  /* fixing eob timings.. -gnp */
789  client_p->localClient->firsttime = CurrentTime;
790
791  if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
792    AddFlag(client_p, FLAGS_SERVICE);
793
794  /* Show the real host/IP to admins */
795 #ifdef HAVE_LIBCRYPTO
796  if (client_p->localClient->fd.ssl)
797  {
798    compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
799    expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
800
801    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
802                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
803                         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
804                         compression ? SSL_COMP_get_name(compression) : "NONE",
805                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
806                         show_capabilities(client_p));
807    /* Now show the masked hostname/IP to opers */
808    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
809                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
810                         inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
811                         compression ? SSL_COMP_get_name(compression) : "NONE",
812                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
813                         show_capabilities(client_p));
814    ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
815         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
816         compression ? SSL_COMP_get_name(compression) : "NONE",
817         expansion ? SSL_COMP_get_name(expansion) : "NONE",
818         show_capabilities(client_p));
819  }
820  else
821 #endif
822  {
823    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
824                         "Link with %s established: (Capabilities: %s)",
825                         inpath_ip, show_capabilities(client_p));
826    /* Now show the masked hostname/IP to opers */
827    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
828                         "Link with %s established: (Capabilities: %s)",
829                         inpath, show_capabilities(client_p));
830    ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
831         inpath_ip, show_capabilities(client_p));
832  }
833
834  fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
835
836  /* Old sendto_serv_but_one() call removed because we now
837  ** need to send different names to different servers
838  ** (domain name matching) Send new server to other servers.
839  */
840  DLINK_FOREACH(ptr, serv_list.head)
841  {
842    target_p = ptr->data;
843
844    if (target_p == client_p)
845      continue;
846
847    if (IsCapable(target_p, CAP_TS6) && HasID(client_p))
848      sendto_one(target_p, ":%s SID %s 2 %s :%s%s",
849                 me.id, client_p->name, client_p->id,
850                 IsHidden(client_p) ? "(H) " : "",
851                 client_p->info);
852    else
853      sendto_one(target_p,":%s SERVER %s 2 :%s%s",
854                 me.name, client_p->name,
855                 IsHidden(client_p) ? "(H) " : "",
856                 client_p->info);
857  }
858
859  /* Pass on my client information to the new server
860  **
861  ** First, pass only servers (idea is that if the link gets
862  ** cancelled beacause the server was already there,
863  ** there are no NICK's to be cancelled...). Of course,
864  ** if cancellation occurs, all this info is sent anyway,
865  ** and I guess the link dies when a read is attempted...? --msa
866  **
867  ** Note: Link cancellation to occur at this point means
868  ** that at least two servers from my fragment are building
869  ** up connection this other fragment at the same time, it's
870  ** a race condition, not the normal way of operation...
871  **
872  ** ALSO NOTE: using the get_client_name for server names--
873  **    see previous *WARNING*!!! (Also, original inpath
874  **    is destroyed...)
875  */
876
877  DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
878  {
879    target_p = ptr->data;
880
881    /* target_p->from == target_p for target_p == client_p */
882    if (IsMe(target_p) || target_p->from == client_p)
883      continue;
884
885    if (IsCapable(client_p, CAP_TS6))
886    {
887      if (HasID(target_p))
888        sendto_one(client_p, ":%s SID %s %d %s :%s%s",
889                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
890                   target_p->id, IsHidden(target_p) ? "(H) " : "",
891                   target_p->info);
892      else  /* introducing non-ts6 server */
893        sendto_one(client_p, ":%s SERVER %s %d :%s%s",
894                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
895                   IsHidden(target_p) ? "(H) " : "", target_p->info);
896    }
897    else
898      sendto_one(client_p, ":%s SERVER %s %d :%s%s",
899                 target_p->servptr->name, target_p->name, target_p->hopcount+1,
900                 IsHidden(target_p) ? "(H) " : "", target_p->info);
901  }
902
903  server_burst(client_p);
904 }
905
906 /* server_burst()
907 *
908 * inputs       - struct Client pointer server
909 *              -
910 * output       - none
911 * side effects - send a server burst
912 * bugs         - still too long
913 */
914 static void
915 server_burst(struct Client *client_p)
916 {
917  /* Send it in the shortened format with the TS, if
918  ** it's a TS server; walk the list of channels, sending
919  ** all the nicks that haven't been sent yet for each
920  ** channel, then send the channel itself -- it's less
921  ** obvious than sending all nicks first, but on the
922  ** receiving side memory will be allocated more nicely
923  ** saving a few seconds in the handling of a split
924  ** -orabidoo
925  */
926
927  burst_all(client_p);
928
929  /* EOB stuff is now in burst_all */
930  /* Always send a PING after connect burst is done */
931  sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
932 }
933
934 /* burst_all()
935 *
936 * inputs       - pointer to server to send burst to
937 * output       - NONE
938 * side effects - complete burst of channels/nicks is sent to client_p
939 */
940 static void
941 burst_all(struct Client *client_p)
942 {
943  dlink_node *ptr = NULL;
944
945  DLINK_FOREACH(ptr, global_channel_list.head)
946  {
947    struct Channel *chptr = ptr->data;
948
949    if (dlink_list_length(&chptr->members) != 0)
950    {
951      burst_members(client_p, chptr);
952      send_channel_modes(client_p, chptr);
953
954      if (IsCapable(client_p, CAP_TBURST))
955        send_tb(client_p, chptr);
956    }
957  }
958
959  /* also send out those that are not on any channel
960   */
961  DLINK_FOREACH(ptr, global_client_list.head)
962  {
963    struct Client *target_p = ptr->data;
964
965    if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
966      sendnick_TS(client_p, target_p);
967    
968    DelFlag(target_p, FLAGS_BURSTED);
969  }
970
971  /* We send the time we started the burst, and let the remote host determine an EOB time,
972  ** as otherwise we end up sending a EOB of 0   Sending here means it gets sent last -- fl
973  */
974  /* Its simpler to just send EOB and use the time its been connected.. --fl_ */
975  if (IsCapable(client_p, CAP_EOB))
976    sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
977 }
978
979 /*
980 * send_tb
981 *
982 * inputs       - pointer to Client
983 *              - pointer to channel
984 * output       - NONE
985 * side effects - Called on a server burst when
986 *                server is CAP_TBURST capable
987 */
988 static void
989 send_tb(struct Client *client_p, struct Channel *chptr)
990 {
991  /*
992   * We may also send an empty topic here, but only if topic_time isn't 0,
993   * i.e. if we had a topic that got unset.  This is required for syncing
994   * topics properly.
995   *
996   * Imagine the following scenario: Our downlink introduces a channel
997   * to us with a TS that is equal to ours, but the channel topic on
998   * their side got unset while the servers were in splitmode, which means
999   * their 'topic' is newer.  They simply wanted to unset it, so we have to
1000   * deal with it in a more sophisticated fashion instead of just resetting
1001   * it to their old topic they had before.  Read m_tburst.c:ms_tburst
1002   * for further information   -Michael
1003   */
1004  if (chptr->topic_time != 0)
1005    sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s",
1006               ID_or_name(&me, client_p),
1007               (unsigned long)chptr->channelts, chptr->chname,
1008               (unsigned long)chptr->topic_time,
1009               chptr->topic_info,
1010               chptr->topic);
1011 }
1012
1013 /* burst_members()
1014 *
1015 * inputs       - pointer to server to send members to
1016 *              - dlink_list pointer to membership list to send
1017 * output       - NONE
1018 * side effects -
1019 */
1020 static void
1021 burst_members(struct Client *client_p, struct Channel *chptr)
1022 {
1023  struct Client *target_p;
1024  struct Membership *ms;
1025  dlink_node *ptr;
1026
1027  DLINK_FOREACH(ptr, chptr->members.head)
1028  {
1029    ms       = ptr->data;
1030    target_p = ms->client_p;
1031
1032    if (!HasFlag(target_p, FLAGS_BURSTED))
1033    {
1034      AddFlag(target_p, FLAGS_BURSTED);
1035
1036      if (target_p->from != client_p)
1037        sendnick_TS(client_p, target_p);
1038    }
1039  }
1040 }
1041
576   /* New server connection code
577   * Based upon the stuff floating about in s_bsd.c
578   *   -- adrian
# Line 1046 | Line 580 | burst_members(struct Client *client_p, s
580  
581   /* serv_connect() - initiate a server connection
582   *
583 < * inputs       - pointer to conf
583 > * inputs       - pointer to conf
584   *              - pointer to client doing the connect
585   * output       -
586   * side effects -
# Line 1063 | Line 597 | burst_members(struct Client *client_p, s
597   int
598   serv_connect(struct MaskItem *conf, struct Client *by)
599   {
600 <  struct Client *client_p;
601 <  char buf[HOSTIPLEN + 1];
600 >  struct Client *client_p = NULL;
601 >  char buf[HOSTIPLEN + 1] = "";
602  
603    /* conversion structs */
604    struct sockaddr_in *v4;
1071  /* Make sure conf is useful */
1072  assert(conf != NULL);
605  
606 +  /* Make sure conf is useful */
607 +  assert(conf);
608  
609    getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
610                buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
# Line 1083 | Line 617 | serv_connect(struct MaskItem *conf, stru
617      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
618                           "Error connecting to %s: DNS lookup for connect{} in progress.",
619                           conf->name);
620 <    return (0);
620 >    return 0;
621    }
622  
623    if (conf->dns_failed)
# Line 1091 | Line 625 | serv_connect(struct MaskItem *conf, stru
625      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
626                           "Error connecting to %s: DNS lookup for connect{} failed.",
627                           conf->name);
628 <    return (0);
628 >    return 0;
629    }
630  
631    /* Make sure this server isn't already connected
632     * Note: conf should ALWAYS be a valid C: line
633     */
634 <  if ((client_p = hash_find_server(conf->name)) != NULL)
635 <  {
634 >  if ((client_p = hash_find_server(conf->name)))
635 >  {
636      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
637 <                         "Server %s already present from %s",
638 <                         conf->name, get_client_name(client_p, SHOW_IP));
637 >                         "Server %s already present from %s",
638 >                         conf->name, get_client_name(client_p, SHOW_IP));
639      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
640 <                         "Server %s already present from %s",
641 <                         conf->name, get_client_name(client_p, MASK_IP));
640 >                         "Server %s already present from %s",
641 >                         conf->name, get_client_name(client_p, MASK_IP));
642      if (by && IsClient(by) && !MyClient(by))
643 <      sendto_one(by, ":%s NOTICE %s :Server %s already present from %s",
644 <                 me.name, by->name, conf->name,
645 <                 get_client_name(client_p, MASK_IP));
1112 <    return (0);
643 >      sendto_one_notice(by, &me, ":Server %s already present from %s",
644 >                        conf->name, get_client_name(client_p, MASK_IP));
645 >    return 0;
646    }
647 <    
647 >
648    /* Create a local client */
649    client_p = make_client(NULL);
650  
# Line 1122 | Line 655 | serv_connect(struct MaskItem *conf, stru
655    /* We already converted the ip once, so lets use it - stu */
656    strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
657  
658 <  /* create a socket for the server connection */
659 <  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1127 <                SOCK_STREAM, 0, NULL) < 0)
658 >  /* create a socket for the server connection */
659 >  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family, SOCK_STREAM, 0, NULL) < 0)
660    {
661      /* Eek, failure to create the socket */
662 <    report_error(L_ALL,
663 <                 "opening stream socket to %s: %s", conf->name, errno);
662 >    report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
663 >
664      SetDead(client_p);
665 <    exit_client(client_p, &me, "Connection failed");
666 <    return (0);
665 >    exit_client(client_p, "Connection failed");
666 >    return 0;
667    }
668  
669    /* servernames are always guaranteed under HOSTLEN chars */
# Line 1143 | Line 675 | serv_connect(struct MaskItem *conf, stru
675    if (!attach_connect_block(client_p, conf->name, conf->host))
676    {
677      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
678 <                         "Host %s is not enabled for connecting: no connect{} block",
679 <                         conf->name);
680 <    if (by && IsClient(by) && !MyClient(by))  
681 <      sendto_one(by, ":%s NOTICE %s :Connect to host %s failed.",
682 <                 me.name, by->name, client_p->name);
678 >                         "Host %s is not enabled for connecting: no connect{} block",
679 >                         conf->name);
680 >    if (by && IsClient(by) && !MyClient(by))
681 >      sendto_one_notice(by, &me, ":Connect to host %s failed.", client_p->name);
682 >
683      SetDead(client_p);
684 <    exit_client(client_p, client_p, "Connection failed");
685 <    return (0);
684 >    exit_client(client_p, "Connection failed");
685 >    return 0;
686    }
687  
688    /* at this point we have a connection in progress and C/N lines
# Line 1168 | Line 700 | serv_connect(struct MaskItem *conf, stru
700  
701    SetConnecting(client_p);
702    dlinkAdd(client_p, &client_p->node, &global_client_list);
703 <  /* from def_fam */
703 >
704    client_p->localClient->aftype = conf->aftype;
705  
706    /* Now, initiate the connection */
707 <  /* XXX assume that a non 0 type means a specific bind address
707 >  /* XXX assume that a non 0 type means a specific bind address
708     * for this connect.
709     */
710    switch (conf->aftype)
711    {
712      case AF_INET:
713        v4 = (struct sockaddr_in*)&conf->bind;
714 <      if (v4->sin_addr.s_addr != 0)
714 >      if (v4->sin_addr.s_addr)
715        {
716          struct irc_ssaddr ipn;
717          memset(&ipn, 0, sizeof(struct irc_ssaddr));
718          ipn.ss.ss_family = AF_INET;
719          ipn.ss_port = 0;
720          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
721 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
722 <                         (struct sockaddr *)&ipn, ipn.ss_len,
723 <                         serv_connect_callback, client_p, conf->aftype,
724 <                         CONNECTTIMEOUT);
721 >        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
722 >                         (struct sockaddr *)&ipn, ipn.ss_len,
723 >                         serv_connect_callback, client_p, conf->aftype,
724 >                         CONNECTTIMEOUT);
725        }
726        else if (ServerInfo.specific_ipv4_vhost)
727        {
# Line 1201 | Line 733 | serv_connect(struct MaskItem *conf, stru
733          comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
734                           (struct sockaddr *)&ipn, ipn.ss_len,
735                           serv_connect_callback, client_p, conf->aftype,
736 <                         CONNECTTIMEOUT);
736 >                         CONNECTTIMEOUT);
737        }
738        else
739 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
740 <                         NULL, 0, serv_connect_callback, client_p, conf->aftype,
739 >        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
740 >                         NULL, 0, serv_connect_callback, client_p, conf->aftype,
741                           CONNECTTIMEOUT);
742        break;
743   #ifdef IPV6
744      case AF_INET6:
745        {
746 <        struct irc_ssaddr ipn;
747 <        struct sockaddr_in6 *v6;
748 <        struct sockaddr_in6 *v6conf;
749 <
750 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
751 <        v6conf = (struct sockaddr_in6 *)&conf->bind;
752 <        v6 = (struct sockaddr_in6 *)&ipn;
753 <
754 <        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr,
755 <                   sizeof(struct in6_addr)) != 0)
756 <        {
757 <          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
758 <          ipn.ss.ss_family = AF_INET6;
759 <          ipn.ss_port = 0;
760 <          comm_connect_tcp(&client_p->localClient->fd,
761 <                           conf->host, conf->port,
762 <                           (struct sockaddr *)&ipn, ipn.ss_len,
763 <                           serv_connect_callback, client_p,
764 <                           conf->aftype, CONNECTTIMEOUT);
765 <        }
1234 <        else if (ServerInfo.specific_ipv6_vhost)
746 >        struct irc_ssaddr ipn;
747 >        struct sockaddr_in6 *v6;
748 >        struct sockaddr_in6 *v6conf;
749 >
750 >        memset(&ipn, 0, sizeof(struct irc_ssaddr));
751 >        v6conf = (struct sockaddr_in6 *)&conf->bind;
752 >        v6 = (struct sockaddr_in6 *)&ipn;
753 >
754 >        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
755 >        {
756 >          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
757 >          ipn.ss.ss_family = AF_INET6;
758 >          ipn.ss_port = 0;
759 >          comm_connect_tcp(&client_p->localClient->fd,
760 >                           conf->host, conf->port,
761 >                           (struct sockaddr *)&ipn, ipn.ss_len,
762 >                           serv_connect_callback, client_p,
763 >                           conf->aftype, CONNECTTIMEOUT);
764 >        }
765 >        else if (ServerInfo.specific_ipv6_vhost)
766          {
767 <          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
768 <          ipn.ss.ss_family = AF_INET6;
769 <          ipn.ss_port = 0;
770 <          comm_connect_tcp(&client_p->localClient->fd,
771 <                           conf->host, conf->port,
772 <                           (struct sockaddr *)&ipn, ipn.ss_len,
773 <                           serv_connect_callback, client_p,
774 <                           conf->aftype, CONNECTTIMEOUT);
775 <        }
776 <        else
777 <          comm_connect_tcp(&client_p->localClient->fd,
778 <                           conf->host, conf->port,
779 <                           NULL, 0, serv_connect_callback, client_p,
780 <                           conf->aftype, CONNECTTIMEOUT);
767 >          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
768 >          ipn.ss.ss_family = AF_INET6;
769 >          ipn.ss_port = 0;
770 >          comm_connect_tcp(&client_p->localClient->fd,
771 >                           conf->host, conf->port,
772 >                           (struct sockaddr *)&ipn, ipn.ss_len,
773 >                           serv_connect_callback, client_p,
774 >                           conf->aftype, CONNECTTIMEOUT);
775 >        }
776 >        else
777 >          comm_connect_tcp(&client_p->localClient->fd,
778 >                           conf->host, conf->port,
779 >                           NULL, 0, serv_connect_callback, client_p,
780 >                           conf->aftype, CONNECTTIMEOUT);
781        }
782   #endif
783    }
784 <  return (1);
784 >  return 1;
785   }
786  
787   #ifdef HAVE_LIBCRYPTO
# Line 1268 | Line 799 | finish_ssl_server_handshake(struct Clien
799      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
800                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
801  
802 <    exit_client(client_p, &me, "Lost connect{} block");
802 >    exit_client(client_p, "Lost connect{} block");
803      return;
804    }
805  
806 <  /* jdc -- Check and send spasswd, not passwd. */
1276 <  if (!EmptyString(conf->spasswd))
1277 <    sendto_one(client_p, "PASS %s TS %d %s",
1278 <               conf->spasswd, TS_CURRENT, me.id);
806 >  sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
807  
808    send_capabilities(client_p, 0);
809  
# Line 1305 | Line 833 | finish_ssl_server_handshake(struct Clien
833   static void
834   ssl_server_handshake(fde_t *fd, struct Client *client_p)
835   {
836 <  int ret;
837 <  int err;
1310 <
1311 <  ret = SSL_connect(client_p->localClient->fd.ssl);
836 >  X509 *cert = NULL;
837 >  int ret = 0;
838  
839 <  if (ret <= 0)
839 >  if ((ret = SSL_connect(client_p->localClient->fd.ssl)) <= 0)
840    {
841 <    switch ((err = SSL_get_error(client_p->localClient->fd.ssl, ret)))
841 >    switch (SSL_get_error(client_p->localClient->fd.ssl, ret))
842      {
843        case SSL_ERROR_WANT_WRITE:
844          comm_setselect(&client_p->localClient->fd, COMM_SELECT_WRITE,
# Line 1328 | Line 854 | ssl_server_handshake(fde_t *fd, struct C
854          sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
855                               "Error connecting to %s: %s", client_p->name,
856                               sslerr ? sslerr : "unknown SSL error");
857 <        exit_client(client_p, client_p, "Error during SSL handshake");
857 >        exit_client(client_p, "Error during SSL handshake");
858          return;
859        }
860      }
861    }
862  
863 +  if ((cert = SSL_get_peer_certificate(client_p->localClient->fd.ssl)))
864 +  {
865 +    int res = SSL_get_verify_result(client_p->localClient->fd.ssl);
866 +    char buf[EVP_MAX_MD_SIZE * 2 + 1] = "";
867 +    unsigned char md[EVP_MAX_MD_SIZE] = "";
868 +
869 +    if (res == X509_V_OK || res == X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN ||
870 +        res == X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE ||
871 +        res == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT)
872 +    {
873 +      unsigned int n = 0;
874 +
875 +      if (X509_digest(cert, EVP_sha256(), md, &n))
876 +      {
877 +        binary_to_hex(md, buf, n);
878 +        client_p->certfp = xstrdup(buf);
879 +      }
880 +    }
881 +    else
882 +      ilog(LOG_TYPE_IRCD, "Server %s!%s@%s gave bad SSL client certificate: %d",
883 +           client_p->name, client_p->username, client_p->host, res);
884 +    X509_free(cert);
885 +  }
886 +
887    finish_ssl_server_handshake(client_p);
888   }
889  
# Line 1345 | Line 895 | ssl_connect_init(struct Client *client_p
895      ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
896           ERR_error_string(ERR_get_error(), NULL));
897      SetDead(client_p);
898 <    exit_client(client_p, client_p, "SSL_new failed");
898 >    exit_client(client_p, "SSL_new failed");
899      return;
900    }
901  
# Line 1359 | Line 909 | ssl_connect_init(struct Client *client_p
909   #endif
910  
911   /* serv_connect_callback() - complete a server connection.
912 < *
912 > *
913   * This routine is called after the server connection attempt has
914   * completed. If unsucessful, an error is sent to ops and the client
915   * is closed. If sucessful, it goes through the initialisation/check
# Line 1373 | Line 923 | serv_connect_callback(fde_t *fd, int sta
923    struct MaskItem *conf = NULL;
924  
925    /* First, make sure its a real client! */
926 <  assert(client_p != NULL);
926 >  assert(client_p);
927    assert(&client_p->localClient->fd == fd);
928  
929    /* Next, for backward purposes, record the ip of the server */
930    memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
931           sizeof(struct irc_ssaddr));
932 +
933    /* Check the status */
934    if (status != COMM_OK)
935    {
# Line 1391 | Line 942 | serv_connect_callback(fde_t *fd, int sta
942                              client_p->name, comm_errstr(status));
943       else
944         sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
945 <                            "Error connecting to %s[%s]: %s", client_p->name,
946 <                            client_p->host, comm_errstr(status));
945 >                            "Error connecting to %s[%s]: %s", client_p->name,
946 >                            client_p->host, comm_errstr(status));
947  
948       sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
949 <                          "Error connecting to %s: %s",
950 <                          client_p->name, comm_errstr(status));
949 >                          "Error connecting to %s: %s",
950 >                          client_p->name, comm_errstr(status));
951  
952       /* If a fd goes bad, call dead_link() the socket is no
953        * longer valid for reading or writing.
# Line 1408 | Line 959 | serv_connect_callback(fde_t *fd, int sta
959    /* COMM_OK, so continue the connection procedure */
960    /* Get the C/N lines */
961    conf = find_conf_name(&client_p->localClient->confs,
962 <                        client_p->name, CONF_SERVER);
962 >                        client_p->name, CONF_SERVER);
963    if (conf == NULL)
964    {
965      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
966 <                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
966 >                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
967      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
968 <                         "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
968 >                         "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
969  
970 <    exit_client(client_p, &me, "Lost connect{} block");
970 >    exit_client(client_p, "Lost connect{} block");
971      return;
972    }
973  
# Line 1431 | Line 982 | serv_connect_callback(fde_t *fd, int sta
982    }
983   #endif
984  
985 <  /* jdc -- Check and send spasswd, not passwd. */
1435 <  if (!EmptyString(conf->spasswd))
1436 <    sendto_one(client_p, "PASS %s TS %d %s",
1437 <               conf->spasswd, TS_CURRENT, me.id);
985 >  sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
986  
987    send_capabilities(client_p, 0);
988  
989 <  sendto_one(client_p, "SERVER %s 1 :%s%s",
990 <             me.name, ConfigServerHide.hidden ? "(H) " : "",
1443 <             me.info);
989 >  sendto_one(client_p, "SERVER %s 1 :%s%s", me.name,
990 >             ConfigServerHide.hidden ? "(H) " : "", me.info);
991  
992    /* If we've been marked dead because a send failed, just exit
993     * here now and save everyone the trouble of us ever existing.
994     */
995 <  if (IsDead(client_p))
995 >  if (IsDead(client_p))
996    {
997        sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
998 <                           "%s[%s] went dead during handshake",
998 >                           "%s[%s] went dead during handshake",
999                             client_p->name,
1000 <                           client_p->host);
1000 >                           client_p->host);
1001        sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1002 <                           "%s went dead during handshake", client_p->name);
1002 >                           "%s went dead during handshake", client_p->name);
1003        return;
1004    }
1005  
# Line 1475 | Line 1022 | find_servconn_in_progress(const char *na
1022        if (!match(name, cptr->name))
1023          return cptr;
1024    }
1025 <  
1025 >
1026    return NULL;
1027   }

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)