ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/send.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/send.c (file contents):
Revision 3103 by michael, Thu Mar 6 00:05:12 2014 UTC vs.
Revision 3805 by michael, Tue Jun 3 18:27:44 2014 UTC

# Line 35 | Line 35
35   #include "numeric.h"
36   #include "fdlist.h"
37   #include "s_bsd.h"
38 < #include "s_serv.h"
38 > #include "server.h"
39   #include "conf.h"
40   #include "log.h"
41   #include "memory.h"
# Line 47 | Line 47 | static unsigned int current_serial = 0;
47  
48   /* send_format()
49   *
50 < * inputs       - buffer to format into
51 < *              - size of the buffer
50 > * inputs
51 > *              - buffer
52   *              - format pattern to use
53   *              - var args
54   * output       - number of bytes formatted output
55   * side effects - modifies sendbuf
56   */
57 < static inline int
58 < send_format(char *lsendbuf, int bufsize, const char *pattern, va_list args)
57 > static void
58 > send_format(struct dbuf_block *buffer, const char *pattern, va_list args)
59   {
60  int len;
61
60    /*
61     * from rfc1459
62     *
# Line 71 | Line 69 | send_format(char *lsendbuf, int bufsize,
69     * continuation message lines.  See section 7 for more details about
70     * current implementations.
71     */
72 <  len = vsnprintf(lsendbuf, bufsize - 1, pattern, args);
73 <  if (len > bufsize - 2)
74 <    len = bufsize - 2;  /* required by some versions of vsnprintf */
75 <
76 <  lsendbuf[len++] = '\r';
77 <  lsendbuf[len++] = '\n';
78 <  return len;
72 >  dbuf_put_args(buffer, pattern, args);
73 >
74 >  if (buffer->size > sizeof(buffer->data) - 2)
75 >    buffer->size = sizeof(buffer->data) - 2;
76 >
77 >  buffer->data[buffer->size++] = '\r';
78 >  buffer->data[buffer->size++] = '\n';
79   }
80  
81   /*
# Line 86 | Line 84 | send_format(char *lsendbuf, int bufsize,
84   **      sendq.
85   */
86   static void
87 < send_message(struct Client *to, char *buf, int len)
87 > send_message(struct Client *to, struct dbuf_block *buf)
88   {
89    assert(!IsMe(to));
90    assert(to != &me);
91  
92 <  if (dbuf_length(&to->localClient->buf_sendq) + len > get_sendq(&to->localClient->confs))
92 >  if (dbuf_length(&to->localClient->buf_sendq) + buf->size > get_sendq(&to->localClient->confs))
93    {
94      if (IsServer(to))
95        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
96                             "Max SendQ limit exceeded for %s: %lu > %u",
97                             get_client_name(to, HIDE_IP),
98 <                           (unsigned long)(dbuf_length(&to->localClient->buf_sendq) + len),
98 >                           (unsigned long)(dbuf_length(&to->localClient->buf_sendq) + buf->size),
99                             get_sendq(&to->localClient->confs));
100      if (IsClient(to))
101        SetSendQExceeded(to);
102 +
103      dead_link_on_write(to, 0);
104      return;
105    }
106  
107 <  dbuf_put(&to->localClient->buf_sendq, buf, len);
107 >  dbuf_add(&to->localClient->buf_sendq, buf);
108  
109    /*
110 <   ** Update statistics. The following is slightly incorrect
111 <   ** because it counts messages even if queued, but bytes
112 <   ** only really sent. Queued bytes get updated in SendQueued.
110 >   * Update statistics. The following is slightly incorrect because
111 >   * it counts messages even if queued, but bytes only really sent.
112 >   * Queued bytes get updated in send_queued_write().
113     */
114    ++to->localClient->send.messages;
115    ++me.localClient->send.messages;
# Line 122 | Line 121 | send_message(struct Client *to, char *bu
121   *
122   * inputs       - pointer to client from message is being sent
123   *              - pointer to client to send to
124 < *              - pointer to preformatted buffer
126 < *              - length of input buffer
124 > *              - pointer to buffer
125   * output       - none
126   * side effects - Despite the function name, this only sends to directly
127   *                connected clients.
128   *
129   */
130   static void
131 < send_message_remote(struct Client *to, struct Client *from,
134 <                    char *buf, int len)
131 > send_message_remote(struct Client *to, struct Client *from, struct dbuf_block *buf)
132   {
133 <  if (to->from)
137 <    to = to->from;
133 >  to = to->from;
134  
135    if (!MyConnect(to))
136    {
# Line 163 | Line 159 | send_message_remote(struct Client *to, s
159                           from->name, from->username, from->host,
160                           to->from->name);
161  
162 <    sendto_server(NULL, CAP_TS6, NOCAPS,
162 >    sendto_server(NULL, NOCAPS, NOCAPS,
163                    ":%s KILL %s :%s (%s[%s@%s] Ghosted %s)",
164 <                  me.id, to->name, me.name, to->name,
169 <                  to->username, to->host, to->from->name);
170 <    sendto_server(NULL, NOCAPS, CAP_TS6,
171 <                  ":%s KILL %s :%s (%s[%s@%s] Ghosted %s)",
172 <                  me.name, to->name, me.name, to->name,
164 >                  me.id, to->id, me.name, to->name,
165                    to->username, to->host, to->from->name);
166  
167      AddFlag(to, FLAGS_KILLED);
168  
169      if (IsClient(from))
170 <      sendto_one(from, form_str(ERR_GHOSTEDCLIENT),
171 <                 me.name, from->name, to->name, to->username,
180 <                 to->host, to->from);
170 >      sendto_one_numeric(from, &me, ERR_GHOSTEDCLIENT, to->name,
171 >                         to->username, to->host, to->from);
172  
173 <    exit_client(to, &me, "Ghosted client");
173 >    exit_client(to, "Ghosted client");
174      return;
175    }
176  
177 <  send_message(to, buf, len);
177 >  send_message(to, buf);
178   }
179  
180   /*
# Line 194 | Line 185 | void
185   sendq_unblocked(fde_t *fd, struct Client *client_p)
186   {
187    assert(fd == &client_p->localClient->fd);
188 +
189 +  DelFlag(client_p, FLAGS_BLOCKED);
190    send_queued_write(client_p);
191   }
192  
# Line 207 | Line 200 | void
200   send_queued_write(struct Client *to)
201   {
202    int retlen = 0;
210  struct dbuf_block *first = NULL;
203  
204    /*
205     ** Once socket is marked dead, we cannot start writing to it,
206     ** even if the error is removed...
207     */
208 <  if (IsDead(to))
208 >  if (IsDead(to) || HasFlag(to, FLAGS_BLOCKED))
209      return;  /* no use calling send() now */
210  
211    /* Next, lets try to write some data */
# Line 221 | Line 213 | send_queued_write(struct Client *to)
213    {
214      do
215      {
216 <      first = to->localClient->buf_sendq.blocks.head->data;
216 >      struct dbuf_block *first = to->localClient->buf_sendq.blocks.head->data;
217  
218   #ifdef HAVE_LIBCRYPTO
219        if (to->localClient->fd.ssl)
220        {
221 <        retlen = SSL_write(to->localClient->fd.ssl, first->data, first->size);
221 >        retlen = SSL_write(to->localClient->fd.ssl, first->data + to->localClient->buf_sendq.pos, first->size - to->localClient->buf_sendq.pos);
222  
223          /* translate openssl error codes, sigh */
224          if (retlen < 0)
# Line 249 | Line 241 | send_queued_write(struct Client *to)
241        }
242        else
243   #endif
244 <        retlen = send(to->localClient->fd.fd, first->data, first->size, 0);
244 >        retlen = send(to->localClient->fd.fd, first->data + to->localClient->buf_sendq.pos, first->size - to->localClient->buf_sendq.pos, 0);
245  
246        if (retlen <= 0)
247          break;
# Line 261 | Line 253 | send_queued_write(struct Client *to)
253        me.localClient->send.bytes += retlen;
254      } while (dbuf_length(&to->localClient->buf_sendq));
255  
256 <    if ((retlen < 0) && (ignoreErrno(errno)))
256 >    if (retlen < 0 && ignoreErrno(errno))
257      {
258 +      AddFlag(to, FLAGS_BLOCKED);
259 +
260        /* we have a non-fatal error, reschedule a write */
261        comm_setselect(&to->localClient->fd, COMM_SELECT_WRITE,
262                       (PF *)sendq_unblocked, to, 0);
# Line 317 | Line 311 | void
311   sendto_one(struct Client *to, const char *pattern, ...)
312   {
313    va_list args;
314 <  char buffer[IRCD_BUFSIZE];
315 <  int len;
314 >  struct dbuf_block *buffer = NULL;
315 >
316 >  if (IsDead(to->from))
317 >    return;  /* This socket has already been marked as dead */
318  
319 <  if (to->from != NULL)
324 <    to = to->from;
325 <  if (IsDead(to))
326 <    return; /* This socket has already been marked as dead */
319 >  buffer = dbuf_alloc();
320  
321    va_start(args, pattern);
322 <  len = send_format(buffer, sizeof(buffer), pattern, args);
322 >  send_format(buffer, pattern, args);
323    va_end(args);
324  
325 <  send_message(to, buffer, len);
325 >  send_message(to->from, buffer);
326 >
327 >  dbuf_ref_free(buffer);
328 > }
329 >
330 > void
331 > sendto_one_numeric(struct Client *to, struct Client *from, enum irc_numerics numeric, ...)
332 > {
333 >  struct dbuf_block *buffer = NULL;
334 >  const char *dest = NULL, *numstr = NULL;
335 >  va_list args;
336 >
337 >  if (IsDead(to->from))
338 >    return;
339 >
340 >  dest = ID_or_name(to, to);
341 >
342 >  if (EmptyString(dest))
343 >    dest = "*";
344 >
345 >  buffer = dbuf_alloc();
346 >
347 >  dbuf_put_fmt(buffer, ":%s %03d %s ", ID_or_name(from, to), numeric & ~SND_EXPLICIT, dest);
348 >
349 >  va_start(args, numeric);
350 >
351 >  if (numeric & SND_EXPLICIT)
352 >    numstr = va_arg(args, const char *);
353 >  else
354 >    numstr = numeric_form(numeric);
355 >  send_format(buffer, numstr, args);
356 >  va_end(args);
357 >
358 >  send_message(to->from, buffer);
359 >
360 >  dbuf_ref_free(buffer);
361 > }
362 >
363 > void
364 > sendto_one_notice(struct Client *to, struct Client *from, const char *pattern, ...)
365 > {
366 >  struct dbuf_block *buffer = NULL;
367 >  const char *dest = NULL;
368 >  va_list args;
369 >
370 >  if (IsDead(to->from))
371 >    return;
372 >
373 >  dest = ID_or_name(to, to);
374 >
375 >  if (EmptyString(dest))
376 >    dest = "*";
377 >
378 >  buffer = dbuf_alloc();
379 >
380 >  dbuf_put_fmt(buffer, ":%s NOTICE %s ", ID_or_name(from, to), dest);
381 >
382 >  va_start(args, pattern);
383 >  send_format(buffer, pattern, args);
384 >  va_end(args);
385 >
386 >  send_message(to->from, buffer);
387 >
388 >  dbuf_ref_free(buffer);
389   }
390  
391   /* sendto_channel_butone()
# Line 348 | Line 404 | sendto_channel_butone(struct Client *one
404                        struct Channel *chptr, unsigned int type,
405                        const char *pattern, ...)
406   {
407 <  va_list alocal, aremote, auid;
408 <  char local_buf[IRCD_BUFSIZE];
353 <  char remote_buf[IRCD_BUFSIZE];
354 <  char uid_buf[IRCD_BUFSIZE];
355 <  int local_len, remote_len, uid_len;
407 >  va_list alocal, aremote;
408 >  struct dbuf_block *local_buf, *remote_buf;
409    dlink_node *ptr = NULL, *ptr_next = NULL;
410  
411 <  if (IsServer(from))
412 <    local_len = snprintf(local_buf, sizeof(local_buf), ":%s ",
413 <                        from->name);
411 >  local_buf = dbuf_alloc(), remote_buf = dbuf_alloc();
412 >
413 >  if (IsClient(from))
414 >    dbuf_put_fmt(local_buf, ":%s!%s@%s ", from->name, from->username, from->host);
415    else
416 <    local_len = snprintf(local_buf, sizeof(local_buf), ":%s!%s@%s ",
417 <                         from->name, from->username, from->host);
418 <  remote_len = snprintf(remote_buf, sizeof(remote_buf), ":%s ",
365 <                        from->name);
366 <  uid_len = snprintf(uid_buf, sizeof(uid_buf), ":%s ", ID(from));
416 >    dbuf_put_fmt(local_buf, ":%s ", from->name);
417 >
418 >  dbuf_put_fmt(remote_buf, ":%s ", from->id);
419  
420    va_start(alocal, pattern);
421    va_start(aremote, pattern);
422 <  va_start(auid, pattern);
423 <  local_len += send_format(&local_buf[local_len], IRCD_BUFSIZE - local_len,
424 <                           pattern, alocal);
373 <  remote_len += send_format(&remote_buf[remote_len], IRCD_BUFSIZE - remote_len,
374 <                            pattern, aremote);
375 <  uid_len += send_format(&uid_buf[uid_len], IRCD_BUFSIZE - uid_len, pattern,
376 <                         auid);
377 <  va_end(auid);
422 >  send_format(local_buf, pattern, alocal);
423 >  send_format(remote_buf, pattern, aremote);
424 >
425    va_end(aremote);
426    va_end(alocal);
427  
# Line 387 | Line 434 | sendto_channel_butone(struct Client *one
434  
435      assert(IsClient(target_p));
436  
437 <    if (IsDefunct(target_p) || HasUMode(target_p, UMODE_DEAF) || target_p->from == one)
437 >    if (IsDefunct(target_p) || HasUMode(target_p, UMODE_DEAF) ||
438 >        (one && target_p->from == one->from))
439        continue;
440  
441 <    if (type != 0 && (ms->flags & type) == 0)
441 >    if (type && (ms->flags & type) == 0)
442        continue;
443  
444      if (MyConnect(target_p))
# Line 399 | Line 447 | sendto_channel_butone(struct Client *one
447        send_message_remote(target_p->from, from, remote_buf);
448      target_p->from->localClient->serial = current_serial;
449    }
450 +
451 +  dbuf_ref_free(local_buf);
452 +  dbuf_ref_free(remote_buf);
453   }
454  
455   /* sendto_server()
# Line 427 | Line 478 | sendto_server(struct Client *one,
478   {
479    va_list args;
480    dlink_node *ptr = NULL;
481 <  char buffer[IRCD_BUFSIZE];
482 <  int len = 0;
481 >  struct dbuf_block *buffer;
482 >
483 >  buffer = dbuf_alloc();
484  
485    va_start(args, format);
486 <  len = send_format(buffer, sizeof(buffer), format, args);
486 >  send_format(buffer, format, args);
487    va_end(args);
488  
489    DLINK_FOREACH(ptr, serv_list.head)
# Line 442 | Line 494 | sendto_server(struct Client *one,
494      if (IsDead(client_p))
495        continue;
496      /* check against 'one' */
497 <    if (one != NULL && (client_p == one->from))
497 >    if (one && (client_p == one->from))
498        continue;
499      /* check we have required capabs */
500      if ((client_p->localClient->caps & caps) != caps)
501        continue;
502      /* check we don't have any forbidden capabs */
503 <    if ((client_p->localClient->caps & nocaps) != 0)
503 >    if ((client_p->localClient->caps & nocaps))
504        continue;
505  
506 <    send_message(client_p, buffer, len);
506 >    send_message(client_p, buffer);
507    }
508 +
509 +  dbuf_ref_free(buffer);
510   }
511  
512   /* sendto_common_channels_local()
# Line 474 | Line 528 | sendto_common_channels_local(struct Clie
528    struct Channel *chptr;
529    struct Membership *ms;
530    struct Client *target_p;
531 <  char buffer[IRCD_BUFSIZE];
532 <  int len;
531 >  struct dbuf_block *buffer;
532 >
533 >  buffer = dbuf_alloc();
534  
535    va_start(args, pattern);
536 <  len = send_format(buffer, sizeof(buffer), pattern, args);
536 >  send_format(buffer, pattern, args);
537    va_end(args);
538  
539    ++current_serial;
# Line 486 | Line 541 | sendto_common_channels_local(struct Clie
541    DLINK_FOREACH(cptr, user->channel.head)
542    {
543      chptr = ((struct Membership *)cptr->data)->chptr;
489    assert(chptr != NULL);
544  
545      DLINK_FOREACH(uptr, chptr->members.head)
546      {
547        ms = uptr->data;
548        target_p = ms->client_p;
495      assert(target_p != NULL);
549  
550        if (!MyConnect(target_p) || target_p == user || IsDefunct(target_p) ||
551            target_p->localClient->serial == current_serial)
# Line 502 | Line 555 | sendto_common_channels_local(struct Clie
555          continue;
556  
557        target_p->localClient->serial = current_serial;
558 <      send_message(target_p, buffer, len);
558 >      send_message(target_p, buffer);
559      }
560    }
561  
562    if (touser && MyConnect(user) && !IsDead(user) &&
563        user->localClient->serial != current_serial)
564      if (HasCap(user, cap) == cap)
565 <      send_message(user, buffer, len);
565 >      send_message(user, buffer);
566 >
567 >  dbuf_ref_free(buffer);
568   }
569  
570   /* sendto_channel_local()
# Line 527 | Line 582 | sendto_channel_local(unsigned int type,
582                       const char *pattern, ...)
583   {
584    va_list args;
530  char buffer[IRCD_BUFSIZE];
531  int len = 0;
585    dlink_node *ptr = NULL;
586 +  struct dbuf_block *buffer;
587 +
588 +  buffer = dbuf_alloc();
589  
590    va_start(args, pattern);
591 <  len = send_format(buffer, sizeof(buffer), pattern, args);
591 >  send_format(buffer, pattern, args);
592    va_end(args);
593  
594    DLINK_FOREACH(ptr, chptr->members.head)
# Line 540 | Line 596 | sendto_channel_local(unsigned int type,
596      struct Membership *ms = ptr->data;
597      struct Client *target_p = ms->client_p;
598  
599 <    if (type != 0 && (ms->flags & type) == 0)
599 >    if (type && (ms->flags & type) == 0)
600        continue;
601  
602      if (!MyConnect(target_p) || IsDefunct(target_p) ||
603          (nodeaf && HasUMode(target_p, UMODE_DEAF)))
604        continue;
605  
606 <    send_message(target_p, buffer, len);
606 >    send_message(target_p, buffer);
607    }
608 +
609 +  dbuf_ref_free(buffer);
610   }
611  
612   /* sendto_channel_local_butone()
# Line 568 | Line 626 | sendto_channel_local_butone(struct Clien
626                              struct Channel *chptr, const char *pattern, ...)
627   {
628    va_list args;
571  char buffer[IRCD_BUFSIZE];
572  int len = 0;
629    dlink_node *ptr = NULL;
630 +  struct dbuf_block *buffer;
631 +
632 +  buffer = dbuf_alloc();
633  
634    va_start(args, pattern);
635 <  len = send_format(buffer, sizeof(buffer), pattern, args);
635 >  send_format(buffer, pattern, args);
636    va_end(args);
637  
638    DLINK_FOREACH(ptr, chptr->members.head)
# Line 581 | Line 640 | sendto_channel_local_butone(struct Clien
640      struct Membership *ms = ptr->data;
641      struct Client *target_p = ms->client_p;
642  
643 <    if (type != 0 && (ms->flags & type) == 0)
643 >    if (type && (ms->flags & type) == 0)
644 >      continue;
645 >
646 >    if (!MyConnect(target_p) || (one && target_p == one->from))
647        continue;
648  
649 <    if (!MyConnect(target_p) || target_p == one ||
588 <        IsDefunct(target_p) || HasUMode(target_p, UMODE_DEAF))
649 >    if (IsDefunct(target_p) || HasUMode(target_p, UMODE_DEAF))
650        continue;
651  
652      if (HasCap(target_p, cap) != cap)
653        continue;
654  
655 <    send_message(target_p, buffer, len);
655 >    send_message(target_p, buffer);
656    }
657 +
658 +  dbuf_ref_free(buffer);
659   }
660  
661   /*
# Line 629 | Line 692 | match_it(const struct Client *one, const
692   * ugh. ONLY used by m_message.c to send an "oper magic" message. ugh.
693   */
694   void
695 < sendto_match_butone(struct Client *one, struct Client *from, char *mask,
695 > sendto_match_butone(struct Client *one, struct Client *from, const char *mask,
696                      int what, const char *pattern, ...)
697   {
698    va_list alocal, aremote;
699 <  struct Client *client_p;
700 <  dlink_node *ptr, *ptr_next;
701 <  char local_buf[IRCD_BUFSIZE], remote_buf[IRCD_BUFSIZE];
702 <  int local_len = snprintf(local_buf, sizeof(local_buf), ":%s!%s@%s ",
703 <                           from->name, from->username, from->host);
704 <  int remote_len = snprintf(remote_buf, sizeof(remote_buf), ":%s ",
705 <                            from->name);
699 >  dlink_node *ptr = NULL, *ptr_next = NULL;
700 >  struct dbuf_block *local_buf, *remote_buf;
701 >
702 >  local_buf = dbuf_alloc(), remote_buf = dbuf_alloc();
703 >
704 >  dbuf_put_fmt(local_buf, ":%s!%s@%s ", from->name, from->username, from->host);
705 >  dbuf_put_fmt(remote_buf, ":%s ", from->id);
706  
707    va_start(alocal, pattern);
708    va_start(aremote, pattern);
709 <  local_len += send_format(&local_buf[local_len], IRCD_BUFSIZE - local_len,
710 <                           pattern, alocal);
648 <  remote_len += send_format(&remote_buf[remote_len], IRCD_BUFSIZE - remote_len,
649 <                            pattern, aremote);
709 >  send_format(local_buf, pattern, alocal);
710 >  send_format(remote_buf, pattern, aremote);
711    va_end(aremote);
712    va_end(alocal);
713  
714    /* scan the local clients */
715    DLINK_FOREACH(ptr, local_client_list.head)
716    {
717 <    client_p = ptr->data;
717 >    struct Client *client_p = ptr->data;
718  
719 <    if (client_p != one && !IsDefunct(client_p) &&
719 >    if ((!one || client_p != one->from) && !IsDefunct(client_p) &&
720          match_it(client_p, mask, what))
721 <      send_message(client_p, local_buf, local_len);
721 >      send_message(client_p, local_buf);
722    }
723  
724    /* Now scan servers */
725    DLINK_FOREACH_SAFE(ptr, ptr_next, serv_list.head)
726    {
727 <    client_p = ptr->data;
727 >    struct Client *client_p = ptr->data;
728  
729      /*
730       * The old code looped through every client on the
# Line 689 | Line 750 | sendto_match_butone(struct Client *one,
750       * server deal with it.
751       * -wnder
752       */
753 <    if (client_p != one && !IsDefunct(client_p))
754 <      send_message_remote(client_p, from, remote_buf, remote_len);
753 >    if ((!one || client_p != one->from) && !IsDefunct(client_p))
754 >      send_message_remote(client_p, from, remote_buf);
755    }
756 +
757 +  dbuf_ref_free(local_buf);
758 +  dbuf_ref_free(remote_buf);
759   }
760  
761   /* sendto_match_servs()
# Line 708 | Line 772 | sendto_match_servs(struct Client *source
772                     const char *pattern, ...)
773   {
774    va_list args;
775 <  dlink_node *ptr = NULL;
776 <  char buff_suid[IRCD_BUFSIZE];
713 <  char buff_name[IRCD_BUFSIZE];
714 <  int len_suid = 0;
715 <  int len_name = 0;
775 >  dlink_node *ptr = NULL, *ptr_next = NULL;
776 >  struct dbuf_block *buff_suid;
777  
778 <  va_start(args, pattern);
718 <  len_suid  = snprintf(buff_suid, sizeof(buff_suid), ":%s ", ID(source_p));
719 <  len_suid += send_format(&buff_suid[len_suid], sizeof(buff_suid) - len_suid,
720 <                          pattern, args);
721 <  va_end(args);
778 >  buff_suid = dbuf_alloc();
779  
780    va_start(args, pattern);
781 <  len_name = snprintf(buff_name, sizeof(buff_name), ":%s ", source_p->name);
782 <  len_name += send_format(&buff_name[len_name], sizeof(buff_name) - len_name,
726 <                          pattern, args);
781 >  dbuf_put_fmt(buff_suid, ":%s ", source_p->id);
782 >  dbuf_put_args(buff_suid, pattern, args);
783    va_end(args);
784  
785    ++current_serial;
786  
787 <  DLINK_FOREACH(ptr, global_serv_list.head)
787 >  DLINK_FOREACH_SAFE(ptr, ptr_next, global_serv_list.head)
788    {
789      struct Client *target_p = ptr->data;
790  
# Line 750 | Line 806 | sendto_match_servs(struct Client *source
806        if (!IsCapable(target_p->from, cap))
807          continue;
808  
809 <      if (HasID(target_p->from))
754 <        send_message_remote(target_p->from, source_p, buff_suid, len_suid);
755 <      else
756 <        send_message_remote(target_p->from, source_p, buff_name, len_name);
809 >      send_message_remote(target_p->from, source_p, buff_suid);
810      }
811    }
812 +
813 +  dbuf_ref_free(buff_suid);
814   }
815  
816   /* sendto_anywhere()
# Line 773 | Line 828 | sendto_anywhere(struct Client *to, struc
828                  const char *pattern, ...)
829   {
830    va_list args;
831 <  char buffer[IRCD_BUFSIZE];
777 <  int len = 0;
831 >  struct dbuf_block *buffer = NULL;
832  
833    if (IsDead(to->from))
834      return;
835  
836 <  if (MyClient(to))
837 <  {
838 <    if (IsServer(from))
839 <      len = snprintf(buffer, sizeof(buffer), ":%s %s %s ",
840 <                     from->name, command, to->name);
787 <    else
788 <      len = snprintf(buffer, sizeof(buffer), ":%s!%s@%s %s %s ",
789 <                     from->name, from->username, from->host, command, to->name);
790 <  }
836 >  buffer = dbuf_alloc();
837 >
838 >  if (MyClient(to) && IsClient(from))
839 >    dbuf_put_fmt(buffer, ":%s!%s@%s %s %s ", from->name, from->username,
840 >                 from->host, command, to->name);
841    else
842 <    len = snprintf(buffer, sizeof(buffer), ":%s %s %s ",
843 <                   ID_or_name(from, to), command,
794 <                   ID_or_name(to, to));
842 >    dbuf_put_fmt(buffer, ":%s %s %s ", ID_or_name(from, to),
843 >                 command, ID_or_name(to, to));
844  
845    va_start(args, pattern);
846 <  len += send_format(&buffer[len], sizeof(buffer) - len, pattern, args);
846 >  send_format(buffer, pattern, args);
847    va_end(args);
848  
849    if (MyClient(to))
850 <    send_message(to, buffer, len);
850 >    send_message(to, buffer);
851    else
852 <    send_message_remote(to, from, buffer, len);
852 >    send_message_remote(to, from, buffer);
853 >
854 >  dbuf_ref_free(buffer);
855   }
856  
857   /* sendto_realops_flags()
# Line 816 | Line 867 | sendto_realops_flags(unsigned int flags,
867   {
868    const char *ntype = NULL;
869    dlink_node *ptr = NULL;
870 <  char nbuf[IRCD_BUFSIZE];
870 >  char nbuf[IRCD_BUFSIZE] = "";
871    va_list args;
872  
873    va_start(args, pattern);
# Line 857 | Line 908 | sendto_realops_flags(unsigned int flags,
908    }
909   }
910  
860 /* sendto_wallops_flags()
861 *
862 * inputs       - flag types of messages to show to real opers
863 *              - client sending request
864 *              - var args input message
865 * output       - NONE
866 * side effects - Send a wallops to local opers
867 */
868 void
869 sendto_wallops_flags(unsigned int flags, struct Client *source_p,
870                     const char *pattern, ...)
871 {
872  dlink_node *ptr = NULL;
873  va_list args;
874  char buffer[IRCD_BUFSIZE];
875  int len;
876
877  if (IsClient(source_p))
878    len = snprintf(buffer, sizeof(buffer), ":%s!%s@%s WALLOPS :",
879                   source_p->name, source_p->username,
880                   source_p->host);
881  else
882    len = snprintf(buffer, sizeof(buffer), ":%s WALLOPS :",
883                   source_p->name);
884
885  va_start(args, pattern);
886  len += send_format(&buffer[len], IRCD_BUFSIZE - len, pattern, args);
887  va_end(args);
888
889  DLINK_FOREACH(ptr, oper_list.head)
890  {
891    struct Client *client_p = ptr->data;
892    assert(client_p->umodes & UMODE_OPER);
893
894    if (HasUMode(client_p, flags) && !IsDefunct(client_p))
895      send_message(client_p, buffer, len);
896  }
897 }
898
911   /* ts_warn()
912   *
913 < * inputs       - var args message
914 < * output       - NONE
915 < * side effects - Call sendto_realops_flags, with some flood checking
916 < *                (at most 5 warnings every 5 seconds)
913 > * inputs       - var args message
914 > * output       - NONE
915 > * side effects - Call sendto_realops_flags, with some flood checking
916 > *                (at most 5 warnings every 5 seconds)
917   */
918   void
919   sendto_realops_flags_ratelimited(const char *pattern, ...)
920   {
921    va_list args;
922 <  char buffer[IRCD_BUFSIZE];
922 >  char buffer[IRCD_BUFSIZE] = "";
923    static time_t last = 0;
924    static int warnings = 0;
925  
914  /*
915   ** if we're running with TS_WARNINGS enabled and someone does
916   ** something silly like (remotely) connecting a nonTS server,
917   ** we'll get a ton of warnings, so we make sure we don't send
918   ** more than 5 every 5 seconds.  -orabidoo
919   */
920
926    if (CurrentTime - last < 5)
927    {
928      if (++warnings > 5)
# Line 937 | Line 942 | sendto_realops_flags_ratelimited(const c
942    ilog(LOG_TYPE_IRCD, "%s", buffer);
943   }
944  
945 < /* kill_client()
945 > /* sendto_wallops_flags()
946   *
947 < * inputs       - client to send kill towards
948 < *              - pointer to client to kill
949 < *              - reason for kill
950 < * output       - NONE
951 < * side effects - NONE
947 > * inputs       - flag types of messages to show to real opers
948 > *              - client sending request
949 > *              - var args input message
950 > * output       - NONE
951 > * side effects - Send a wallops to local opers
952   */
953   void
954 < kill_client(struct Client *client_p, struct Client *diedie,
955 <            const char *pattern, ...)
954 > sendto_wallops_flags(unsigned int flags, struct Client *source_p,
955 >                     const char *pattern, ...)
956   {
957 +  dlink_node *ptr = NULL;
958    va_list args;
959 <  char buffer[IRCD_BUFSIZE];
954 <  int len;
955 <
956 <  if (client_p->from != NULL)
957 <    client_p = client_p->from;
958 <  if (IsDead(client_p))
959 <    return;
960 <
961 <  len = snprintf(buffer, sizeof(buffer), ":%s KILL %s :",
962 <                 ID_or_name(&me, client_p),
963 <                 ID_or_name(diedie, client_p));
964 <
965 <  va_start(args, pattern);
966 <  len += send_format(&buffer[len], IRCD_BUFSIZE - len, pattern, args);
967 <  va_end(args);
968 <
969 <  send_message(client_p, buffer, len);
970 < }
959 >  struct dbuf_block *buffer;
960  
961 < /* kill_client_ll_serv_butone()
973 < *
974 < * inputs       - pointer to client to not send to
975 < *              - pointer to client to kill
976 < * output       - NONE
977 < * side effects - Send a KILL for the given client
978 < *                message to all connected servers
979 < *                except the client 'one'. Also deal with
980 < *                client being unknown to leaf, as in lazylink...
981 < */
982 < void
983 < kill_client_serv_butone(struct Client *one, struct Client *source_p,
984 <                        const char *pattern, ...)
985 < {
986 <  va_list args;
987 <  int have_uid = 0;
988 <  dlink_node *ptr = NULL;
989 <  char buf_uid[IRCD_BUFSIZE], buf_nick[IRCD_BUFSIZE];
990 <  int len_uid = 0, len_nick = 0;
961 >  buffer = dbuf_alloc();
962  
963 <  if (HasID(source_p))
964 <  {
965 <    have_uid = 1;
966 <    va_start(args, pattern);
996 <    len_uid = snprintf(buf_uid, sizeof(buf_uid), ":%s KILL %s :",
997 <                       me.id, ID(source_p));
998 <    len_uid += send_format(&buf_uid[len_uid], IRCD_BUFSIZE - len_uid, pattern, args);
999 <    va_end(args);
1000 <  }
963 >  if (IsClient(source_p))
964 >    dbuf_put_fmt(buffer, ":%s!%s@%s WALLOPS :", source_p->name, source_p->username, source_p->host);
965 >  else
966 >    dbuf_put_fmt(buffer, ":%s WALLOPS :", source_p->name);
967  
968    va_start(args, pattern);
969 <  len_nick = snprintf(buf_nick, sizeof(buf_nick), ":%s KILL %s :",
1004 <                      me.name, source_p->name);
1005 <  len_nick += send_format(&buf_nick[len_nick], IRCD_BUFSIZE - len_nick, pattern, args);
969 >  send_format(buffer, pattern, args);
970    va_end(args);
971  
972 <  DLINK_FOREACH(ptr, serv_list.head)
972 >  DLINK_FOREACH(ptr, oper_list.head)
973    {
974      struct Client *client_p = ptr->data;
975 +    assert(client_p->umodes & UMODE_OPER);
976  
977 <    if (one != NULL && (client_p == one->from))
978 <      continue;
1014 <    if (IsDefunct(client_p))
1015 <      continue;
1016 <
1017 <    if (have_uid && IsCapable(client_p, CAP_TS6))
1018 <      send_message(client_p, buf_uid, len_uid);
1019 <    else
1020 <      send_message(client_p, buf_nick, len_nick);
977 >    if (HasUMode(client_p, flags) && !IsDefunct(client_p))
978 >      send_message(client_p, buffer);
979    }
980 +
981 +  dbuf_ref_free(buffer);
982   }

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)