ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/client.c
(Generate patch)

Comparing:
ircd-hybrid/src/client.c (file contents), Revision 31 by knight, Sun Oct 2 20:34:05 2005 UTC vs.
ircd-hybrid/trunk/src/client.c (file contents), Revision 7668 by michael, Wed Jul 20 17:09:49 2016 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  client.c: Controls clients.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2016 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 16 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file client.c
23 > * \brief Controls clients.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28 < #include "tools.h"
28 > #include "list.h"
29   #include "client.h"
28 #include "channel_mode.h"
29 #include "common.h"
30   #include "event.h"
31 #include "fdlist.h"
31   #include "hash.h"
32   #include "irc_string.h"
34 #include "sprintf_irc.h"
33   #include "ircd.h"
36 #include "list.h"
37 #include "s_gline.h"
34   #include "numeric.h"
35 < #include "packet.h"
40 < #include "s_auth.h"
35 > #include "auth.h"
36   #include "s_bsd.h"
37 < #include "s_conf.h"
38 < #include "s_log.h"
39 < #include "s_misc.h"
40 < #include "s_serv.h"
37 > #include "conf.h"
38 > #include "conf_gecos.h"
39 > #include "log.h"
40 > #include "misc.h"
41 > #include "server.h"
42   #include "send.h"
43   #include "whowas.h"
44 < #include "s_user.h"
49 < #include "dbuf.h"
44 > #include "user.h"
45   #include "memory.h"
46 + #include "mempool.h"
47   #include "hostmask.h"
52 #include "balloc.h"
48   #include "listener.h"
54 #include "irc_res.h"
49   #include "userhost.h"
50 + #include "watch.h"
51 + #include "rng_mt.h"
52 + #include "parse.h"
53 + #include "ipcache.h"
54 +
55 +
56 + dlink_list listing_client_list;
57 + dlink_list unknown_list;
58 + dlink_list local_client_list;
59 + dlink_list local_server_list;
60 + dlink_list global_client_list;
61 + dlink_list global_server_list;
62 + dlink_list oper_list;
63  
64 < dlink_list listing_client_list = { NULL, NULL, 0 };
65 < /* Pointer to beginning of Client list */
59 < dlink_list global_client_list = {NULL, NULL, 0};
60 < /* unknown/client pointer lists */
61 < dlink_list unknown_list = {NULL, NULL, 0};
62 < dlink_list local_client_list = {NULL, NULL, 0};
63 < dlink_list serv_list = {NULL, NULL, 0};
64 < dlink_list global_serv_list = {NULL, NULL, 0};
65 < dlink_list oper_list = {NULL, NULL, 0};
66 <
67 < static EVH check_pings;
68 <
69 < static BlockHeap *client_heap  = NULL;
70 < static BlockHeap *lclient_heap = NULL;
71 <
72 < static dlink_list dead_list  = { NULL, NULL, 0};
73 < static dlink_list abort_list = { NULL, NULL, 0};
74 <
64 > static mp_pool_t *client_pool, *connection_pool;
65 > static dlink_list dead_list, abort_list;
66   static dlink_node *eac_next;  /* next aborted client to exit */
67  
77 static void check_pings_list(dlink_list *);
78 static void check_unknowns_list(void);
79 static void ban_them(struct Client *client_p, struct ConfItem *conf);
80
81
82 /* init_client()
83 *
84 * inputs       - NONE
85 * output       - NONE
86 * side effects - initialize client free memory
87 */
88 void
89 init_client(void)
90 {
91  /* start off the check ping event ..  -- adrian
92   * Every 30 seconds is plenty -- db
93   */
94  client_heap = BlockHeapCreate("client", sizeof(struct Client), CLIENT_HEAP_SIZE);
95  lclient_heap = BlockHeapCreate("local client", sizeof(struct LocalUser), LCLIENT_HEAP_SIZE);
96  eventAdd("check_pings", check_pings, NULL, 5);
97 }
68  
69   /*
70   * make_client - create a new Client struct and set it to initial state.
# Line 114 | Line 84 | init_client(void)
84   struct Client *
85   make_client(struct Client *from)
86   {
87 <  struct Client *client_p = BlockHeapAlloc(client_heap);
87 >  struct Client *const client_p = mp_pool_get(client_pool);
88  
89 <  if (from == NULL)
89 >  if (!from)
90    {
91 <    client_p->from  = client_p; /* 'from' of local client is self! */
92 <    client_p->since = client_p->lasttime = client_p->firsttime = CurrentTime;
91 >    client_p->from = client_p;  /* 'from' of local client is self! */
92 >    client_p->connection = mp_pool_get(connection_pool);
93 >    client_p->connection->since = CurrentTime;
94 >    client_p->connection->lasttime = CurrentTime;
95 >    client_p->connection->firsttime = CurrentTime;
96 >    client_p->connection->registration = REG_INIT;
97  
124    client_p->localClient = BlockHeapAlloc(lclient_heap);
98      /* as good a place as any... */
99 <    dlinkAdd(client_p, make_dlink_node(), &unknown_list);
99 >    dlinkAdd(client_p, &client_p->connection->lclient_node, &unknown_list);
100    }
101    else
102 <    client_p->from = from; /* 'from' of local client is self! */
102 >    client_p->from = from;
103  
104 <  client_p->hnext  = client_p;
105 <  client_p->status = STAT_UNKNOWN;
104 >  client_p->idhnext = client_p;
105 >  client_p->hnext = client_p;
106 >  SetUnknown(client_p);
107    strcpy(client_p->username, "unknown");
108 +  strcpy(client_p->account, "*");
109  
110    return client_p;
111   }
# Line 145 | Line 120 | make_client(struct Client *from)
120   static void
121   free_client(struct Client *client_p)
122   {
148  assert(client_p != NULL);
123    assert(client_p != &me);
124    assert(client_p->hnext == client_p);
125 <  assert(client_p->invited.head == NULL);
125 >  assert(client_p->idhnext == client_p);
126    assert(client_p->channel.head == NULL);
153  assert(dlink_list_length(&client_p->invited) == 0);
127    assert(dlink_list_length(&client_p->channel) == 0);
128 +  assert(dlink_list_length(&client_p->whowas_list) == 0);
129 +  assert(dlink_list_length(&client_p->svstags) == 0);
130  
131 <  MyFree(client_p->away);
132 <  MyFree(client_p->serv);
131 >  xfree(client_p->serv);
132 >  xfree(client_p->certfp);
133  
134    if (MyConnect(client_p))
135    {
136 <    assert(IsClosing(client_p) && IsDead(client_p));
137 <
138 <    MyFree(client_p->localClient->response);
139 <    MyFree(client_p->localClient->auth_oper);
136 >    assert(client_p->connection->invited.head == NULL);
137 >    assert(dlink_list_length(&client_p->connection->invited) == 0);
138 >    assert(dlink_list_length(&client_p->connection->watches) == 0);
139 >    assert(HasFlag(client_p, FLAGS_CLOSING) && IsDead(client_p));
140  
141      /*
142 <     * clean up extra sockets from P-lines which have been discarded.
142 >     * Clean up extra sockets from listen {} blocks which have been discarded.
143       */
144 <    if (client_p->localClient->listener)
144 >    if (client_p->connection->listener)
145      {
146 <      assert(0 < client_p->localClient->listener->ref_count);
147 <      if (0 == --client_p->localClient->listener->ref_count &&
173 <          !client_p->localClient->listener->active)
174 <        free_listener(client_p->localClient->listener);
146 >      listener_release(client_p->connection->listener);
147 >      client_p->connection->listener = NULL;
148      }
149  
150 <    dbuf_clear(&client_p->localClient->buf_recvq);
151 <    dbuf_clear(&client_p->localClient->buf_sendq);
150 >    dbuf_clear(&client_p->connection->buf_recvq);
151 >    dbuf_clear(&client_p->connection->buf_sendq);
152  
153 <    BlockHeapFree(lclient_heap, client_p->localClient);
153 >    mp_pool_release(client_p->connection);
154    }
155  
156 <  BlockHeapFree(client_heap, client_p);
156 >  mp_pool_release(client_p);
157   }
158  
159 < /*
160 < * check_pings - go through the local client list and check activity
161 < * kill off stuff that should die
162 < *
163 < * inputs       - NOT USED (from event)
191 < * output       - next time_t when check_pings() should be called again
192 < * side effects -
193 < *
194 < *
195 < * A PING can be sent to clients as necessary.
196 < *
197 < * Client/Server ping outs are handled.
198 < */
159 > void
160 > client_attach_svstag(struct Client *client_p, unsigned int numeric,
161 >                     const char *umodes, const char *tag)
162 > {
163 >  const struct user_modes *tab = NULL;
164  
165 < /*
166 < * Addon from adrian. We used to call this after nextping seconds,
202 < * however I've changed it to run once a second. This is only for
203 < * PING timeouts, not K/etc-line checks (thanks dianora!). Having it
204 < * run once a second makes life a lot easier - when a new client connects
205 < * and they need a ping in 4 seconds, if nextping was set to 20 seconds
206 < * we end up waiting 20 seconds. This is stupid. :-)
207 < * I will optimise (hah!) check_pings() once I've finished working on
208 < * tidying up other network IO evilnesses.
209 < *     -- adrian
210 < */
165 >  if (numeric >= ERR_LAST_ERR_MSG || *umodes != '+')
166 >    return;
167  
168 < static void
169 < check_pings(void *notused)
170 < {              
171 <  check_pings_list(&local_client_list);
172 <  check_pings_list(&serv_list);
173 <  check_unknowns_list();
168 >  struct ServicesTag *svstag = xcalloc(sizeof(*svstag));
169 >  svstag->numeric = numeric;
170 >  svstag->tag = xstrdup(tag);
171 >
172 >  for (const char *m = umodes + 1; *m; ++m)
173 >    if ((tab = umode_map[(unsigned char)*m]))
174 >      svstag->umodes |= tab->flag;
175 >
176 >  if (numeric != RPL_WHOISOPERATOR)
177 >    dlinkAddTail(svstag, &svstag->node, &client_p->svstags);
178 >  else
179 >    dlinkAdd(svstag, &svstag->node, &client_p->svstags);
180 > }
181 >
182 > void
183 > client_clear_svstags(struct Client *client_p)
184 > {
185 >  while (client_p->svstags.head)
186 >  {
187 >    struct ServicesTag *svstag = client_p->svstags.head->data;
188 >
189 >    dlinkDelete(&svstag->node, &client_p->svstags);
190 >    xfree(svstag->tag);
191 >    xfree(svstag);
192 >  }
193   }
194  
195   /* check_pings_list()
196   *
197   * inputs       - pointer to list to check
198   * output       - NONE
199 < * side effects -
199 > * side effects -
200   */
201   static void
202   check_pings_list(dlink_list *list)
203   {
204 <  char scratch[32];        /* way too generous but... */
205 <  struct Client *client_p; /* current local client_p being examined */
206 <  int ping, pingwarn;      /* ping time value from client */
232 <  dlink_node *ptr, *next_ptr;
204 >  char buf[32] = "";  /* 32 = sizeof("Ping timeout: 999999999 seconds") */
205 >  unsigned int ping = 0;      /* ping time value from client */
206 >  dlink_node *node = NULL, *node_next = NULL;
207  
208 <  DLINK_FOREACH_SAFE(ptr, next_ptr, list->head)
208 >  DLINK_FOREACH_SAFE(node, node_next, list->head)
209    {
210 <    client_p = ptr->data;
210 >    struct Client *client_p = node->data;
211  
238    /*
239    ** Note: No need to notify opers here. It's
240    ** already done when "FLAGS_DEADSOCKET" is set.
241    */
212      if (IsDead(client_p))
213 <    {
244 <      /* Ignore it, its been exited already */
245 <      continue;
246 <    }
247 <
248 <    if (client_p->localClient->reject_delay > 0)
249 <    {
250 <      if (client_p->localClient->reject_delay <= CurrentTime)
251 <        exit_client(client_p, &me, "Rejected");
252 <      continue;
253 <    }
213 >      continue;  /* Ignore it, its been exited already */
214  
215 <    if (GlobalSetOptions.idletime && IsClient(client_p))
216 <    {
257 <      if (!IsExemptKline(client_p) && !IsOper(client_p) &&
258 <          !IsIdlelined(client_p) &&
259 <          ((CurrentTime - client_p->localClient->last) > GlobalSetOptions.idletime))
260 <      {
261 <        struct ConfItem *conf;
262 <        struct AccessItem *aconf;
263 <
264 <        conf = make_conf_item(KLINE_TYPE);
265 <        aconf = (struct AccessItem *)map_to_conf(conf);
266 <
267 <        DupString(aconf->host, client_p->host);
268 <        DupString(aconf->reason, "idle exceeder");
269 <        DupString(aconf->user, client_p->username);
270 <        aconf->hold = CurrentTime + 60;
271 <        add_temp_line(conf);
272 <
273 <        sendto_realops_flags(UMODE_ALL, L_ALL,
274 <                             "Idle time limit exceeded for %s - temp k-lining",
275 <                             get_client_name(client_p, HIDE_IP));
276 <        exit_client(client_p, &me, aconf->reason);
277 <        continue;
278 <      }
279 <    }
280 <
281 <    if (!IsRegistered(client_p))
282 <      ping = CONNECTTIMEOUT, pingwarn = 0;
215 >    if (IsClient(client_p) || IsServer(client_p))
216 >      ping = get_client_ping(&client_p->connection->confs);
217      else
218 <      ping = get_client_ping(client_p, &pingwarn);
218 >      ping = CONNECTTIMEOUT;
219  
220 <    if (ping < CurrentTime - client_p->lasttime)
220 >    if (ping < CurrentTime - client_p->connection->lasttime)
221      {
222 <      if (!IsPingSent(client_p))
222 >      if (!HasFlag(client_p, FLAGS_PINGSENT))
223        {
224 <        /*
225 <         * if we havent PINGed the connection and we havent
226 <         * heard from it in a while, PING it to make sure
227 <         * it is still alive.
228 <         */
229 <        SetPingSent(client_p);
230 <        ClearPingWarning(client_p);
231 <        client_p->lasttime = CurrentTime - ping;
298 <        sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
224 >        /*
225 >         * If we haven't PINGed the connection and we haven't
226 >         * heard from it in a while, PING it to make sure
227 >         * it is still alive.
228 >         */
229 >        AddFlag(client_p, FLAGS_PINGSENT);
230 >        client_p->connection->lasttime = CurrentTime - ping;
231 >        sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
232        }
233        else
234        {
235 <        if (CurrentTime - client_p->lasttime >= 2 * ping)
235 >        if (CurrentTime - client_p->connection->lasttime >= 2 * ping)
236          {
237            /*
238             * If the client/server hasn't talked to us in 2*ping seconds
239             * and it has a ping time, then close its connection.
240             */
241            if (IsServer(client_p) || IsHandshake(client_p))
242 <          {
243 <            sendto_realops_flags(UMODE_ALL, L_ADMIN,
244 <                                 "No response from %s, closing link",
245 <                                 get_client_name(client_p, HIDE_IP));
246 <            sendto_realops_flags(UMODE_ALL, L_OPER,
247 <                                 "No response from %s, closing link",
248 <                                 get_client_name(client_p, MASK_IP));
249 <            ilog(L_NOTICE, "No response from %s, closing link",
250 <                 get_client_name(client_p, HIDE_IP));
251 <          }
252 <          ircsprintf(scratch, "Ping timeout: %d seconds",
253 <                     (int)(CurrentTime - client_p->lasttime));
254 <
255 <          exit_client(client_p, &me, scratch);
323 <        }
324 <        else if (!IsPingWarning(client_p) && pingwarn > 0 &&
325 <                 (IsServer(client_p) || IsHandshake(client_p)) &&
326 <                 CurrentTime - client_p->lasttime >= ping + pingwarn)
327 <        {
328 <          /*
329 <           * If the server hasn't replied in pingwarn seconds after sending
330 <           * the PING, notify the opers so that they are aware of the problem.
331 <           */
332 <          SetPingWarning(client_p);
333 <          sendto_realops_flags(UMODE_ALL, L_ADMIN,
334 <                               "Warning, no response from %s in %d seconds",
335 <                               get_client_name(client_p, HIDE_IP), pingwarn);
336 <          sendto_realops_flags(UMODE_ALL, L_OPER,
337 <                               "Warning, no response from %s in %d seconds",
338 <                               get_client_name(client_p, MASK_IP), pingwarn);
339 <          ilog(L_NOTICE, "No response from %s in %d seconds",
340 <               get_client_name(client_p, HIDE_IP), pingwarn);
242 >          {
243 >            sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
244 >                                 "No response from %s, closing link",
245 >                                 get_client_name(client_p, SHOW_IP));
246 >            sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
247 >                                 "No response from %s, closing link",
248 >                                 get_client_name(client_p, MASK_IP));
249 >            ilog(LOG_TYPE_IRCD, "No response from %s, closing link",
250 >                 get_client_name(client_p, SHOW_IP));
251 >          }
252 >
253 >          snprintf(buf, sizeof(buf), "Ping timeout: %ji seconds",
254 >                   (CurrentTime - client_p->connection->lasttime));
255 >          exit_client(client_p, buf);
256          }
257        }
258      }
# Line 353 | Line 268 | check_pings_list(dlink_list *list)
268   static void
269   check_unknowns_list(void)
270   {
271 <  dlink_node *ptr, *next_ptr;
271 >  dlink_node *node = NULL, *node_next = NULL;
272  
273 <  DLINK_FOREACH_SAFE(ptr, next_ptr, unknown_list.head)
273 >  DLINK_FOREACH_SAFE(node, node_next, unknown_list.head)
274    {
275 <    struct Client *client_p = ptr->data;
361 <
362 <    if (client_p->localClient->reject_delay > 0)
363 <    {
364 <      if (client_p->localClient->reject_delay <= CurrentTime)
365 <        exit_client(client_p, &me, "Rejected");
366 <      continue;
367 <    }
275 >    struct Client *client_p = node->data;
276  
277 <    /* Check UNKNOWN connections - if they have been in this state
277 >    /*
278 >     * Check UNKNOWN connections - if they have been in this state
279       * for > 30s, close them.
280       */
281 <    if (client_p->firsttime ? ((CurrentTime - client_p->firsttime) > 30) : 0)
282 <      exit_client(client_p, &me, "Connection timed out");
281 >    if (HasFlag(client_p, FLAGS_FINISHED_AUTH) && (CurrentTime - client_p->connection->firsttime) > 30)
282 >      exit_client(client_p, "Registration timed out");
283    }
284   }
285  
286 + /*
287 + * check_pings - go through the local client list and check activity
288 + * kill off stuff that should die
289 + *
290 + * inputs       - NOT USED (from event)
291 + * side effects -
292 + *
293 + *
294 + * A PING can be sent to clients as necessary.
295 + *
296 + * Client/Server ping outs are handled.
297 + */
298 +
299 + /*
300 + * Addon from adrian. We used to call this after nextping seconds,
301 + * however I've changed it to run once a second. This is only for
302 + * PING timeouts, not K/etc-line checks (thanks dianora!). Having it
303 + * run once a second makes life a lot easier - when a new client connects
304 + * and they need a ping in 4 seconds, if nextping was set to 20 seconds
305 + * we end up waiting 20 seconds. This is stupid. :-)
306 + * I will optimise (hah!) check_pings() once I've finished working on
307 + * tidying up other network IO evilnesses.
308 + *     -- adrian
309 + */
310 +
311 + static void
312 + check_pings(void *unused)
313 + {
314 +  check_pings_list(&local_client_list);
315 +  check_pings_list(&local_server_list);
316 +  check_unknowns_list();
317 + }
318 +
319   /* check_conf_klines()
320   *
321   * inputs       - NONE
# Line 381 | Line 323 | check_unknowns_list(void)
323   * side effects - Check all connections for a pending kline against the
324   *                client, exit the client if a kline matches.
325   */
326 < void
326 > void
327   check_conf_klines(void)
328 < {              
329 <  struct Client *client_p = NULL;       /* current local client_p being examined */
330 <  struct AccessItem *aconf = NULL;
389 <  struct ConfItem *conf = NULL;
390 <  dlink_node *ptr, *next_ptr;
328 > {
329 >  dlink_node *node = NULL, *node_next = NULL;
330 >  const void *ptr;
331  
332 <  DLINK_FOREACH_SAFE(ptr, next_ptr, local_client_list.head)
332 >  DLINK_FOREACH_SAFE(node, node_next, local_client_list.head)
333    {
334 <    client_p = ptr->data;
334 >    struct Client *client_p = node->data;
335  
336 <    /* If a client is already being exited
337 <     */
398 <    if (IsDead(client_p) || !IsClient(client_p))
336 >    /* If a client is already being exited */
337 >    if (IsDead(client_p))
338        continue;
339  
340 <    /* if there is a returned struct ConfItem then kill it */
341 <    if ((aconf = find_dline_conf(&client_p->localClient->ip,
403 <                                  client_p->localClient->aftype)) != NULL)
340 >    if ((ptr = find_conf_by_address(NULL, &client_p->connection->ip, CONF_DLINE,
341 >                                    client_p->connection->aftype, NULL, NULL, 1)))
342      {
343 <      if (aconf->status & CONF_EXEMPTDLINE)
344 <        continue;
345 <
408 <      conf = unmap_conf_item(aconf);
409 <      ban_them(client_p, conf);
410 <      continue; /* and go examine next fd/client_p */
343 >      const struct MaskItem *conf = ptr;
344 >      conf_try_ban(client_p, CLIENT_BAN_DLINE, conf->reason);
345 >      continue;  /* and go examine next Client */
346      }
347  
348 <    if (ConfigFileEntry.glines && (aconf = find_gline(client_p)))
349 <    {
350 <      if (IsExemptKline(client_p) ||
416 <          IsExemptGline(client_p))
417 <      {
418 <        sendto_realops_flags(UMODE_ALL, L_ALL,
419 <                             "GLINE over-ruled for %s, client is %sline_exempt",
420 <                             get_client_name(client_p, HIDE_IP), IsExemptKline(client_p) ? "k" : "g");
421 <        continue;
422 <      }
423 <
424 <      conf = unmap_conf_item(aconf);
425 <      ban_them(client_p, conf);
426 <      /* and go examine next fd/client_p */    
427 <      continue;
428 <    }
429 <
430 <    if ((aconf = find_kill(client_p)) != NULL)
348 >    if ((ptr = find_conf_by_address(client_p->host, &client_p->connection->ip,
349 >                                    CONF_KLINE, client_p->connection->aftype,
350 >                                    client_p->username, NULL, 1)))
351      {
352 <
353 <      /* if there is a returned struct AccessItem.. then kill it */
354 <      if (IsExemptKline(client_p))
435 <      {
436 <        sendto_realops_flags(UMODE_ALL, L_ALL,
437 <                             "KLINE over-ruled for %s, client is kline_exempt",
438 <                             get_client_name(client_p, HIDE_IP));
439 <        continue;
440 <      }
441 <
442 <      conf = unmap_conf_item(aconf);
443 <      ban_them(client_p, conf);
444 <      continue;
352 >      const struct MaskItem *conf = ptr;
353 >      conf_try_ban(client_p, CLIENT_BAN_KLINE, conf->reason);
354 >      continue;  /* and go examine next Client */
355      }
356  
357 <    /* if there is a returned struct MatchItem then kill it */
448 <    if ((conf = find_matching_name_conf(XLINE_TYPE,  client_p->info,
449 <                                        NULL, NULL, 0)) != NULL ||
450 <        (conf = find_matching_name_conf(RXLINE_TYPE, client_p->info,
451 <                                        NULL, NULL, 0)) != NULL)
357 >    if ((ptr = gecos_find(client_p->info, match)))
358      {
359 <      ban_them(client_p, conf);
360 <      continue;
359 >      const struct GecosItem *conf = ptr;
360 >      conf_try_ban(client_p, CLIENT_BAN_XLINE, conf->reason);
361 >      continue;  /* and go examine next Client */
362      }
363    }
364  
365 <  /* also check the unknowns list for new dlines */
366 <  DLINK_FOREACH_SAFE(ptr, next_ptr, unknown_list.head)
365 >  /* Also check the unknowns list for new dlines */
366 >  DLINK_FOREACH_SAFE(node, node_next, unknown_list.head)
367    {
368 <    client_p = ptr->data;
368 >    struct Client *client_p = node->data;
369  
370 <    if ((aconf = find_dline_conf(&client_p->localClient->ip,
371 <                                  client_p->localClient->aftype)))
370 >    if ((ptr = find_conf_by_address(NULL, &client_p->connection->ip, CONF_DLINE,
371 >                                    client_p->connection->aftype, NULL, NULL, 1)))
372      {
373 <      if (aconf->status & CONF_EXEMPTDLINE)
374 <        continue;
375 <
469 <      exit_client(client_p, &me, "D-lined");
373 >      const struct MaskItem *conf = ptr;
374 >      conf_try_ban(client_p, CLIENT_BAN_DLINE, conf->reason);
375 >      continue;  /* and go examine next Client */
376      }
377    }
378   }
379  
380   /*
381 < * ban_them
381 > * conf_try_ban
382   *
383   * inputs       - pointer to client to ban
384 < *              - pointer to ConfItem
384 > *              - pointer to MaskItem
385   * output       - NONE
386   * side effects - given client_p is banned
387   */
388 < static void
389 < ban_them(struct Client *client_p, struct ConfItem *conf)
388 > void
389 > conf_try_ban(struct Client *client_p, int type, const char *reason)
390   {
391 <  const char *user_reason = NULL;       /* What is sent to user */
392 <  const char *channel_reason = NULL;    /* What is sent to channel */
393 <  struct AccessItem *aconf = NULL;
394 <  struct MatchItem *xconf = NULL;
395 <  const char *type_string = NULL;
396 <  const char dline_string[] = "D-line";
397 <  const char kline_string[] = "K-line";
398 <  const char gline_string[] = "G-line";
399 <  const char xline_string[] = "X-line";
400 <
401 <  switch (conf->type)
402 <  {
403 <    case RKLINE_TYPE:
404 <    case KLINE_TYPE:
499 <      type_string = kline_string;
500 <      aconf = map_to_conf(conf);
501 <      break;
502 <    case DLINE_TYPE:
503 <      type_string = dline_string;
504 <      aconf = map_to_conf(conf);
391 >  char ban_type = '?';
392 >
393 >  switch (type)
394 >  {
395 >    case CLIENT_BAN_KLINE:
396 >      if (HasFlag(client_p, FLAGS_EXEMPTKLINE))
397 >      {
398 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
399 >                             "KLINE over-ruled for %s, client is kline_exempt",
400 >                             get_client_name(client_p, HIDE_IP));
401 >        return;
402 >      }
403 >
404 >      ban_type = 'K';
405        break;
406 <    case GLINE_TYPE:
407 <      type_string = gline_string;
408 <      aconf = map_to_conf(conf);
406 >    case CLIENT_BAN_DLINE:
407 >      if (find_conf_by_address(NULL, &client_p->connection->ip, CONF_EXEMPT,
408 >                               client_p->connection->aftype, NULL, NULL, 1))
409 >        return;
410 >      ban_type = 'D';
411        break;
412 <    case RXLINE_TYPE:
413 <    case XLINE_TYPE:
414 <      type_string = xline_string;
415 <      xconf = map_to_conf(conf);
416 <      ++xconf->count;
412 >    case CLIENT_BAN_XLINE:
413 >      if (HasFlag(client_p, FLAGS_EXEMPTXLINE))
414 >      {
415 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
416 >                             "XLINE over-ruled for %s, client is xline_exempt",
417 >                             get_client_name(client_p, HIDE_IP));
418 >        return;
419 >      }
420 >
421 >      ban_type = 'X';
422        break;
423      default:
424        assert(0);
425        break;
426    }
427  
428 <  if (ConfigFileEntry.kline_with_reason)
429 <  {
523 <    if (aconf != NULL)
524 <      user_reason = aconf->reason ? aconf->reason : type_string;
525 <    if (xconf != NULL)
526 <      user_reason = xconf->reason ? xconf->reason : type_string;
527 <  }
528 <  else
529 <    user_reason = type_string;
530 <
531 <  if (ConfigFileEntry.kline_reason != NULL)
532 <    channel_reason = ConfigFileEntry.kline_reason;
533 <  else
534 <    channel_reason = user_reason;
535 <
536 <  sendto_realops_flags(UMODE_ALL, L_ALL, "%s active for %s",
537 <                       type_string, get_client_name(client_p, HIDE_IP));
428 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE, "%c-line active for %s",
429 >                       ban_type, get_client_name(client_p, HIDE_IP));
430  
431    if (IsClient(client_p))
432 <    sendto_one(client_p, form_str(ERR_YOUREBANNEDCREEP),
541 <               me.name, client_p->name, user_reason);
432 >    sendto_one_numeric(client_p, &me, ERR_YOUREBANNEDCREEP, reason);
433  
434 <  exit_client(client_p, &me, channel_reason);
434 >  exit_client(client_p, reason);
435   }
436  
437   /* update_client_exit_stats()
438   *
439   * input        - pointer to client
440   * output       - NONE
441 < * side effects -
441 > * side effects -
442   */
443   static void
444   update_client_exit_stats(struct Client *client_p)
445   {
446 <  if (IsServer(client_p))
556 <  {
557 <    sendto_realops_flags(UMODE_EXTERNAL, L_ALL,
558 <                         "Server %s split from %s",
559 <                         client_p->name, client_p->servptr->name);
560 <  }
561 <  else if (IsClient(client_p))
446 >  if (IsClient(client_p))
447    {
448 +    assert(Count.total > 0);
449 +
450      --Count.total;
451 <    if (IsOper(client_p))
451 >    if (HasUMode(client_p, UMODE_OPER))
452        --Count.oper;
453 <    if (IsInvisible(client_p))
453 >    if (HasUMode(client_p, UMODE_INVISIBLE))
454        --Count.invisi;
455    }
456 <
457 <  if (splitchecking && !splitmode)
458 <    check_splitmode(NULL);
456 >  else if (IsServer(client_p))
457 >    sendto_realops_flags(UMODE_EXTERNAL, L_ALL, SEND_NOTICE,
458 >                         "Server %s split from %s",
459 >                         client_p->name, client_p->servptr->name);
460   }
461  
462   /* find_person()
# Line 577 | Line 465 | update_client_exit_stats(struct Client *
465   * output       - return client pointer
466   * side effects - find person by (nick)name
467   */
580 /* XXX - ugly wrapper */
468   struct Client *
469 < find_person(const struct Client *client_p, const char *name)
469 > find_person(const struct Client *source_p, const char *name)
470   {
471 <  struct Client *c2ptr;
471 >  struct Client *target_p = NULL;
472  
473    if (IsDigit(*name))
474    {
475 <    if ((c2ptr = hash_find_id(name)) != NULL)
476 <    {
590 <      /* invisible users shall not be found by UID guessing */
591 <      if (IsInvisible(c2ptr) && !IsServer(client_p))
592 <        c2ptr = NULL;
593 <    }
475 >    if (IsServer(source_p->from))
476 >      target_p = hash_find_id(name);
477    }
478    else
479 <    c2ptr = find_client(name);
479 >    target_p = hash_find_client(name);
480  
481 <  return ((c2ptr != NULL && IsClient(c2ptr)) ? c2ptr : NULL);
481 >  return (target_p && IsClient(target_p)) ? target_p : NULL;
482   }
483  
484   /*
485 < * find_chasing - find the client structure for a nick name (user)
486 < *      using history mechanism if necessary. If the client is not found,
487 < *      an error message (NO SUCH NICK) is generated. If the client was found
605 < *      through the history, chasing will be 1 and otherwise 0.
485 > * find_chasing - find the client structure for a nick name (name)
486 > *      using history mechanism if necessary. If the client is not found,
487 > *      an error message (NO SUCH NICK) is generated.
488   */
489   struct Client *
490 < find_chasing(struct Client *client_p, struct Client *source_p, const char *user, int *chasing)
490 > find_chasing(struct Client *source_p, const char *name)
491   {
492 <  struct Client *who = find_person(client_p, user);
492 >  struct Client *target_p = find_person(source_p, name);
493  
494 <  if (chasing)
495 <    *chasing = 0;
494 >  if (target_p)
495 >    return target_p;
496  
497 <  if (who)
498 <    return(who);
497 >  if (IsDigit(*name))
498 >    return NULL;
499  
500 <  if (IsDigit(*user))
619 <    return(NULL);
500 >  target_p = whowas_get_history(name, ConfigGeneral.kill_chase_time_limit);
501  
502 <  if ((who = get_history(user,
622 <                        (time_t)ConfigFileEntry.kill_chase_time_limit))
623 <                         == NULL)
502 >  if (!target_p)
503    {
504 <    sendto_one(source_p, form_str(ERR_NOSUCHNICK),
505 <               me.name, source_p->name, user);
627 <    return(NULL);
504 >    sendto_one_numeric(source_p, &me, ERR_NOSUCHNICK, name);
505 >    return NULL;
506    }
507  
508 <  if (chasing)
631 <    *chasing = 1;
632 <
633 <  return(who);
508 >  return target_p;
509   }
510  
511   /*
# Line 642 | Line 517 | find_chasing(struct Client *client_p, st
517   *        But, this can be used to any client structure.
518   *
519   * NOTE 1:
520 < *        Watch out the allocation of "nbuf", if either source_p->name
520 > *        Watch out the allocation of "buf", if either source_p->name
521   *        or source_p->sockhost gets changed into pointers instead of
522   *        directly allocated within the structure...
523   *
524   * NOTE 2:
525   *        Function return either a pointer to the structure (source_p) or
526 < *        to internal buffer (nbuf). *NEVER* use the returned pointer
526 > *        to internal buffer (buf). *NEVER* use the returned pointer
527   *        to modify what it points!!!
528   */
529   const char *
530 < get_client_name(struct Client *client, int showip)
530 > get_client_name(const struct Client *client_p, enum addr_mask_type type)
531   {
532 <  static char nbuf[HOSTLEN * 2 + USERLEN + 5];
658 <
659 <  assert(client != NULL);
532 >  static char buf[HOSTLEN * 2 + USERLEN + 4];  /* +4 for [,@,],\0 */
533  
534 <  if (irccmp(client->name, client->host) == 0)
535 <    return(client->name);
534 >  if (!MyConnect(client_p))
535 >    return client_p->name;
536  
537 <  if (ConfigServerHide.hide_server_ips)
538 <    if (IsServer(client) || IsConnecting(client) || IsHandshake(client))
539 <      showip = MASK_IP;
540 <
541 <  if (ConfigFileEntry.hide_spoof_ips)
542 <    if (showip == SHOW_IP && IsIPSpoof(client))
543 <      showip = MASK_IP;
537 >  if (IsServer(client_p) || IsConnecting(client_p) || IsHandshake(client_p))
538 >  {
539 >    if (!irccmp(client_p->name, client_p->host))
540 >      return client_p->name;
541 >    else if (ConfigServerHide.hide_server_ips)
542 >      type = MASK_IP;
543 >  }
544  
545    /* And finally, let's get the host information, ip or name */
546 <  switch (showip)
546 >  switch (type)
547    {
548      case SHOW_IP:
549 <      if (MyConnect(client))
550 <      {
551 <        ircsprintf(nbuf, "%s[%s@%s]", client->name, client->username,
552 <                   client->sockhost);
680 <        break;
681 <      }
549 >      snprintf(buf, sizeof(buf), "%s[%s@%s]",
550 >               client_p->name,
551 >               client_p->username, client_p->sockhost);
552 >      break;
553      case MASK_IP:
554 <      ircsprintf(nbuf, "%s[%s@255.255.255.255]", client->name,
555 <                 client->username);
554 >      if (client_p->connection->aftype == AF_INET)
555 >        snprintf(buf, sizeof(buf), "%s[%s@255.255.255.255]",
556 >                 client_p->name, client_p->username);
557 >      else
558 >        snprintf(buf, sizeof(buf), "%s[%s@ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]",
559 >                 client_p->name, client_p->username);
560        break;
561 <    default:
562 <      ircsprintf(nbuf, "%s[%s@%s]", client->name, client->username,
563 <                 client->host);
561 >    default:  /* HIDE_IP */
562 >      snprintf(buf, sizeof(buf), "%s[%s@%s]",
563 >               client_p->name,
564 >               client_p->username, client_p->host);
565    }
566  
567 <  return(nbuf);
567 >  return buf;
568   }
569  
570   void
571   free_exited_clients(void)
572   {
573 <  dlink_node *ptr, *next;
698 <  struct Client *target_p;
699 <  
700 <  DLINK_FOREACH_SAFE(ptr, next, dead_list.head)
701 <  {
702 <    target_p = ptr->data;
703 <
704 <    if (ptr->data == NULL)
705 <    {
706 <      sendto_realops_flags(UMODE_ALL, L_ALL,
707 <                           "Warning: null client on dead_list!");
708 <      dlinkDelete(ptr, &dead_list);
709 <      free_dlink_node(ptr);
710 <      continue;
711 <    }
573 >  dlink_node *node = NULL, *node_next = NULL;
574  
575 <    free_client(target_p);
576 <    dlinkDelete(ptr, &dead_list);
577 <    free_dlink_node(ptr);
575 >  DLINK_FOREACH_SAFE(node, node_next, dead_list.head)
576 >  {
577 >    free_client(node->data);
578 >    dlinkDelete(node, &dead_list);
579 >    free_dlink_node(node);
580    }
581   }
582  
# Line 723 | Line 587 | free_exited_clients(void)
587   * The only messages generated are QUITs on channels.
588   */
589   static void
590 < exit_one_client(struct Client *source_p, const char *quitmsg)
590 > exit_one_client(struct Client *source_p, const char *comment)
591   {
592 <  dlink_node *lp = NULL, *next_lp = NULL;
592 >  dlink_node *node = NULL, *node_next = NULL;
593  
594    assert(!IsMe(source_p));
595 +  assert(source_p != &me);
596  
597 <  if (IsServer(source_p))
597 >  if (IsClient(source_p))
598    {
599 <    dlinkDelete(&source_p->lnode, &source_p->servptr->serv->servers);
599 >    dlinkDelete(&source_p->lnode, &source_p->servptr->serv->client_list);
600 >    dlinkDelete(&source_p->node, &global_client_list);
601 >
602 >    /*
603 >     * If a person is on a channel, send a QUIT notice
604 >     * to every client (person) on the same channel (so
605 >     * that the client can show the "**signoff" message).
606 >     * (Note: The notice is to the local clients *only*)
607 >     */
608 >    sendto_common_channels_local(source_p, 0, 0, 0, ":%s!%s@%s QUIT :%s",
609 >                                 source_p->name, source_p->username,
610 >                                 source_p->host, comment);
611 >
612 >    DLINK_FOREACH_SAFE(node, node_next, source_p->channel.head)
613 >      remove_user_from_channel(node->data);
614 >
615 >    client_clear_svstags(source_p);
616  
617 <    if ((lp = dlinkFindDelete(&global_serv_list, source_p)) != NULL)
618 <      free_dlink_node(lp);
617 >    whowas_add_history(source_p, 0);
618 >    whowas_off_history(source_p);
619  
620 <    if (!MyConnect(source_p))
620 >    watch_check_hash(source_p, RPL_LOGOFF);
621 >
622 >    if (MyConnect(source_p))
623      {
624 <      source_p->from->serv->dep_servers--;
625 <      assert(source_p->from->serv->dep_servers > 0);
624 >      clear_invites_client(source_p);
625 >      del_all_accepts(source_p);
626      }
627    }
628 <  else if (IsClient(source_p))
628 >  else if (IsServer(source_p))
629    {
630 <    if (source_p->servptr->serv != NULL)
631 <      dlinkDelete(&source_p->lnode, &source_p->servptr->serv->users);
749 <
750 <    /* If a person is on a channel, send a QUIT notice
751 <    ** to every client (person) on the same channel (so
752 <    ** that the client can show the "**signoff" message).
753 <    ** (Note: The notice is to the local clients *only*)
754 <    */
755 <    sendto_common_channels_local(source_p, 0, ":%s!%s@%s QUIT :%s",
756 <                                 source_p->name, source_p->username,
757 <                                 source_p->host, quitmsg);
758 <    DLINK_FOREACH_SAFE(lp, next_lp, source_p->channel.head)
759 <      remove_user_from_channel(lp->data);
760 <
761 <    /* Clean up invitefield */
762 <    DLINK_FOREACH_SAFE(lp, next_lp, source_p->invited.head)
763 <      del_invite(lp->data, source_p);
764 <
765 <    /* Clean up allow lists */
766 <    del_all_accepts(source_p);
767 <    add_history(source_p, 0);
768 <    off_history(source_p);
630 >    dlinkDelete(&source_p->lnode, &source_p->servptr->serv->server_list);
631 >    dlinkDelete(&source_p->node, &global_client_list);
632  
633 <    if (!MyConnect(source_p))
634 <    {
772 <      source_p->from->serv->dep_users--;
773 <      assert(source_p->from->serv->dep_users >= 0);
774 <    }
633 >    if ((node = dlinkFindDelete(&global_server_list, source_p)))
634 >      free_dlink_node(node);
635    }
636  
637    /* Remove source_p from the client lists */
638 <  if (HasID(source_p))
638 >  if (source_p->id[0])
639      hash_del_id(source_p);
640 +
641    if (source_p->name[0])
642      hash_del_client(source_p);
643  
644 <  if (IsUserHostIp(source_p))
645 <    delete_user_host(source_p->username, source_p->host, !MyConnect(source_p));
785 <
786 <  /* remove from global client list
787 <   * NOTE: source_p->node.next cannot be NULL if the client is added
788 <   *       to global_client_list (there is always &me at its end)
789 <   */
790 <  if (source_p != NULL && source_p->node.next != NULL)
791 <    dlinkDelete(&source_p->node, &global_client_list);
644 >  if (HasFlag(source_p, FLAGS_USERHOST))
645 >    userhost_del(source_p->sockhost, !MyConnect(source_p));
646  
647    update_client_exit_stats(source_p);
648  
# Line 800 | Line 654 | exit_one_client(struct Client *source_p,
654    dlinkAdd(source_p, make_dlink_node(), &dead_list);
655   }
656  
657 < /* Recursively send QUITs and SQUITs for source_p and all its dependent clients
804 < * and servers to those servers that need them.  A server needs the client
805 < * QUITs if it can't figure them out from the SQUIT (ie pre-TS4) or if it
806 < * isn't getting the SQUIT because of @#(*&@)# hostmasking.  With TS4, once
807 < * a link gets a SQUIT, it doesn't need any QUIT/SQUITs for clients depending
808 < * on that one -orabidoo
809 < *
810 < * This is now called on each local server -adx
811 < */
812 < static void
813 < recurse_send_quits(struct Client *original_source_p, struct Client *source_p,
814 <                   struct Client *from, struct Client *to, const char *comment,
815 <                   const char *splitstr, const char *myname)
816 < {
817 <  dlink_node *ptr, *next;
818 <  struct Client *target_p;
819 <  int hidden = match(myname, source_p->name);
820 <
821 <  assert(to != source_p);  /* should be already removed from serv_list */
822 <
823 <  /* If this server can handle quit storm (QS) removal
824 <   * of dependents, just send the SQUIT
825 <   *
826 <   * Always check *all* dependent servers if some of them are
827 <   * hidden behind fakename. If so, send out the QUITs -adx
828 <   */
829 <  if (hidden || !IsCapable(to, CAP_QS))
830 <    DLINK_FOREACH_SAFE(ptr, next, source_p->serv->users.head)
831 <    {
832 <      target_p = ptr->data;
833 <      sendto_one(to, ":%s QUIT :%s", target_p->name, splitstr);
834 <    }
835 <
836 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->servers.head)
837 <    recurse_send_quits(original_source_p, ptr->data, from, to,
838 <                       comment, splitstr, myname);
839 <
840 <  if (!hidden && ((source_p == original_source_p && to != from) ||
841 <                  !IsCapable(to, CAP_QS)))
842 <  {
843 <    /* don't use a prefix here - we have to be 100% sure the message
844 <     * will be accepted without Unknown prefix etc.. */
845 <    sendto_one(to, "SQUIT %s :%s", ID_or_name(source_p, to), comment);
846 <  }
847 < }
848 <
849 < /*
657 > /*
658   * Remove all clients that depend on source_p; assumes all (S)QUITs have
659 < * already been sent.  we make sure to exit a server's dependent clients
660 < * and servers before the server itself; exit_one_client takes care of
659 > * already been sent.  we make sure to exit a server's dependent clients
660 > * and servers before the server itself; exit_one_client takes care of
661   * actually removing things off llists.   tweaked from +CSr31  -orabidoo
662   */
663   static void
664 < recurse_remove_clients(struct Client *source_p, const char *quitmsg)
664 > recurse_remove_clients(struct Client *source_p, const char *comment)
665   {
666 <  dlink_node *ptr, *next;
666 >  dlink_node *node = NULL, *node_next = NULL;
667  
668 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->users.head)
669 <    exit_one_client(ptr->data, quitmsg);
668 >  DLINK_FOREACH_SAFE(node, node_next, source_p->serv->client_list.head)
669 >    exit_one_client(node->data, comment);
670  
671 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->servers.head)
671 >  DLINK_FOREACH_SAFE(node, node_next, source_p->serv->server_list.head)
672    {
673 <    recurse_remove_clients(ptr->data, quitmsg);
674 <    exit_one_client(ptr->data, quitmsg);
673 >    recurse_remove_clients(node->data, comment);
674 >    exit_one_client(node->data, comment);
675    }
868
869  assert(source_p->serv->dep_servers == 1);
870  assert(source_p->serv->dep_users == 0);
871 }
872
873 /*
874 ** Remove *everything* that depends on source_p, from all lists, and sending
875 ** all necessary QUITs and SQUITs.  source_p itself is still on the lists,
876 ** and its SQUITs have been sent except for the upstream one  -orabidoo
877 */
878 static void
879 remove_dependents(struct Client *source_p, struct Client *from,
880                  const char *comment, const char *splitstr)
881 {
882  struct Client *to;
883  struct ConfItem *conf;
884  static char myname[HOSTLEN+1];
885  dlink_node *ptr;
886
887  DLINK_FOREACH(ptr, serv_list.head)
888  {
889    to = ptr->data;
890
891    if ((conf = to->serv->sconf) != NULL)
892      strlcpy(myname, my_name_for_link(conf), sizeof(myname));
893    else
894      strlcpy(myname, me.name, sizeof(myname));
895    recurse_send_quits(source_p, source_p, from, to,
896                       comment, splitstr, myname);
897  }
898
899  recurse_remove_clients(source_p, splitstr);
676   }
677  
678   /*
# Line 904 | Line 680 | remove_dependents(struct Client *source_
680   * this on any struct Client, regardless of its state.
681   *
682   * Note, you shouldn't exit remote _users_ without first doing
683 < * SetKilled and propagating a kill or similar message. However,
684 < * it is perfectly correct to call exit_client to force a _server_
683 > * AddFlag(x, FLAGS_KILLED) and propagating a kill or similar message.
684 > *
685 > * However, it is perfectly correct to call exit_client to force a _server_
686   * quit (either local or remote one).
687   *
688 + *
689   * inputs:       - a client pointer that is going to be exited
912 *               - for servers, the second argument is a pointer to who
913 *                 is firing the server. This side won't get any generated
914 *                 messages. NEVER NULL!
690   * output:       none
691   * side effects: the client is delinked from all lists, disconnected,
692   *               and the rest of IRC network is notified of the exit.
693   *               Client memory is scheduled to be freed
694   */
695   void
696 < exit_client(struct Client *source_p, struct Client *from, const char *comment)
696 > exit_client(struct Client *source_p, const char *comment)
697   {
698 <  dlink_node *m;
698 >  dlink_node *node = NULL;
699 >
700 >  assert(!IsMe(source_p));
701 >  assert(source_p != &me);
702  
703    if (MyConnect(source_p))
704    {
705      /* DO NOT REMOVE. exit_client can be called twice after a failed
706       * read/write.
707       */
708 <    if (IsClosing(source_p))
708 >    if (HasFlag(source_p, FLAGS_CLOSING))
709        return;
710  
711 <    SetClosing(source_p);
711 >    AddFlag(source_p, FLAGS_CLOSING);
712  
713 <    if (IsIpHash(source_p))
714 <      remove_one_ip(&source_p->localClient->ip);
713 >    if (HasFlag(source_p, FLAGS_IPHASH))
714 >    {
715 >      DelFlag(source_p, FLAGS_IPHASH);
716 >      ipcache_remove_address(&source_p->connection->ip);
717 >    }
718  
719 <    delete_auth(source_p);
719 >    delete_auth(&source_p->connection->auth);
720  
721 <    /* This source_p could have status of one of STAT_UNKNOWN, STAT_CONNECTING
941 <     * STAT_HANDSHAKE or STAT_UNKNOWN
942 <     * all of which are lumped together into unknown_list
943 <     *
944 <     * In all above cases IsRegistered() will not be true.
945 <     */
946 <    if (!IsRegistered(source_p))
721 >    if (IsClient(source_p))
722      {
723 <      if ((m = dlinkFindDelete(&unknown_list, source_p)) != NULL)
724 <        free_dlink_node(m);
723 >      assert(Count.local > 0);
724 >
725 >      --Count.local;
726 >
727 >      if (HasUMode(source_p, UMODE_OPER))
728 >        if ((node = dlinkFindDelete(&oper_list, source_p)))
729 >          free_dlink_node(node);
730 >
731 >      assert(dlinkFind(&local_client_list, source_p));
732 >      dlinkDelete(&source_p->connection->lclient_node, &local_client_list);
733 >
734 >      if (source_p->connection->list_task)
735 >        free_list_task(source_p);
736 >
737 >      watch_del_watch_list(source_p);
738 >
739 >      sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
740 >                           "Client exiting: %s (%s@%s) [%s] [%s]",
741 >                           source_p->name, source_p->username, source_p->host,
742 >                           source_p->sockhost, comment);
743 >
744 >      ilog(LOG_TYPE_USER, "%s (%ju): %s!%s@%s %s %s %ju/%ju :%s",
745 >           date_ctime(source_p->connection->firsttime),
746 >           CurrentTime - source_p->connection->firsttime,
747 >           source_p->name, source_p->username, source_p->host,
748 >           source_p->sockhost, source_p->account,
749 >           source_p->connection->send.bytes >> 10,
750 >           source_p->connection->recv.bytes >> 10, source_p->info);
751      }
752 <    else if (IsClient(source_p))
752 >    else if (IsServer(source_p))
753      {
754 <      Count.local--;
754 >      assert(Count.myserver > 0);
755  
756 <      if (IsOper(source_p))
956 <      {
957 <        if ((m = dlinkFindDelete(&oper_list, source_p)) != NULL)
958 <          free_dlink_node(m);
959 <      }
756 >      --Count.myserver;
757  
758 <      dlinkDelete(&source_p->localClient->lclient_node, &local_client_list);
759 <      if (source_p->localClient->list_task != NULL)
963 <        free_list_task(source_p->localClient->list_task, source_p);
964 <
965 <      sendto_realops_flags(UMODE_CCONN, L_ALL, "Client exiting: %s (%s@%s) [%s] [%s]",
966 <                           source_p->name, source_p->username, source_p->host, comment,
967 <                           ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
968 <                           "255.255.255.255" : source_p->sockhost);
758 >      assert(dlinkFind(&local_server_list, source_p));
759 >      dlinkDelete(&source_p->connection->lclient_node, &local_server_list);
760      }
761 <
971 <    /* As soon as a client is known to be a server of some sort
972 <     * it has to be put on the serv_list, or SJOIN's to this new server
973 <     * from the connect burst will not be seen.
974 <     */
975 <    if (IsServer(source_p) || IsConnecting(source_p) ||
976 <        IsHandshake(source_p))
761 >    else
762      {
763 <      if ((m = dlinkFindDelete(&serv_list, source_p)) != NULL)
764 <      {
980 <        free_dlink_node(m);
981 <        unset_chcap_usage_counts(source_p);
982 <      }
983 <
984 <      if (IsServer(source_p))
985 <      {
986 <        Count.myserver--;
987 <        if (ServerInfo.hub)
988 <          remove_lazylink_flags(source_p->localClient->serverMask);
989 <        else
990 <          uplink = NULL;
991 <      }
763 >      assert(dlinkFind(&unknown_list, source_p));
764 >      dlinkDelete(&source_p->connection->lclient_node, &unknown_list);
765      }
766  
994    log_user_exit(source_p);
995
767      if (!IsDead(source_p))
768      {
769        if (IsServer(source_p))
770        {
771 <        /* for them, we are exiting the network */
772 <        sendto_one(source_p, ":%s SQUIT %s :%s",
773 <                   ID_or_name(from, source_p), me.name, comment);
771 >        if (!HasFlag(source_p, FLAGS_SQUIT))
772 >        {
773 >          /* for them, we are exiting the network */
774 >          sendto_one(source_p, ":%s SQUIT %s :%s",
775 >                     me.id, me.id, comment);
776 >        }
777        }
778  
779        sendto_one(source_p, "ERROR :Closing Link: %s (%s)",
780                   source_p->host, comment);
781      }
782  
1009    /*
1010    ** Currently only server connections can have
1011    ** depending remote clients here, but it does no
1012    ** harm to check for all local clients. In
1013    ** future some other clients than servers might
1014    ** have remotes too...
1015    **
1016    ** Close the Client connection first and mark it
1017    ** so that no messages are attempted to send to it.
1018    ** Remember it makes source_p->from == NULL.
1019    */
783      close_connection(source_p);
784    }
785 +  else if (IsClient(source_p) && HasFlag(source_p->servptr, FLAGS_EOB))
786 +    sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
787 +                         "Client exiting at %s: %s (%s@%s) [%s] [%s]",
788 +                         source_p->servptr->name, source_p->name,
789 +                         source_p->username, source_p->host, source_p->sockhost, comment);
790  
791    if (IsServer(source_p))
792    {
793 <    char splitstr[HOSTLEN + HOSTLEN + 2];
793 >    char splitstr[HOSTLEN + HOSTLEN + 2] = "";
794  
795 <    /* This shouldn't ever happen */
796 <    assert(source_p->serv != NULL && source_p->servptr != NULL);
795 >    assert(source_p->serv);
796 >    assert(source_p->servptr);
797  
798      if (ConfigServerHide.hide_servers)
799 <      /* set netsplit message to "*.net *.split" to still show
799 >      /*
800 >       * Set netsplit message to "*.net *.split" to still show
801         * that its a split, but hide the servers splitting
802         */
803 <      strcpy(splitstr, "*.net *.split");
803 >      strlcpy(splitstr, "*.net *.split", sizeof(splitstr));
804      else
805        snprintf(splitstr, sizeof(splitstr), "%s %s",
806                 source_p->servptr->name, source_p->name);
807  
808 <    remove_dependents(source_p, from->from, comment, splitstr);
809 <
810 <    if (source_p->servptr == &me)
811 <    {
812 <      sendto_realops_flags(UMODE_ALL, L_ALL,
813 <                           "%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
814 <                           source_p->name, (int)(CurrentTime - source_p->firsttime),
815 <                           source_p->localClient->send.bytes >> 10,
816 <                           source_p->localClient->recv.bytes >> 10);
817 <      ilog(L_NOTICE, "%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
818 <           source_p->name, (int)(CurrentTime - source_p->firsttime),
819 <           source_p->localClient->send.bytes >> 10,
820 <           source_p->localClient->recv.bytes >> 10);
821 <    }
822 <  }
823 <  else if (IsClient(source_p) && !IsKilled(source_p))
824 <  {
825 <    sendto_server(NULL, source_p, NULL, CAP_TS6, NOCAPS, NOFLAGS,
826 <                  ":%s QUIT :%s", ID(source_p), comment);
827 <    sendto_server(NULL, source_p, NULL, NOCAPS, CAP_TS6, NOFLAGS,
828 <                  ":%s QUIT :%s", source_p->name, comment);
829 <  }
808 >    /* Send SQUIT for source_p in every direction. source_p is already off of local_server_list here */
809 >    if (!HasFlag(source_p, FLAGS_SQUIT))
810 >      sendto_server(NULL, 0, 0, "SQUIT %s :%s", source_p->id, comment);
811 >
812 >    /* Now exit the clients internally */
813 >    recurse_remove_clients(source_p, splitstr);
814 >
815 >    if (MyConnect(source_p))
816 >    {
817 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
818 >                           "%s was connected for %s. %ju/%ju sendK/recvK.",
819 >                           source_p->name, time_dissect(CurrentTime - source_p->connection->firsttime),
820 >                           source_p->connection->send.bytes >> 10,
821 >                           source_p->connection->recv.bytes >> 10);
822 >      ilog(LOG_TYPE_IRCD, "%s was connected for %s. %ju/%ju sendK/recvK.",
823 >           source_p->name, time_dissect(CurrentTime - source_p->connection->firsttime),
824 >           source_p->connection->send.bytes >> 10,
825 >           source_p->connection->recv.bytes >> 10);
826 >    }
827 >  }
828 >  else if (IsClient(source_p) && !HasFlag(source_p, FLAGS_KILLED))
829 >    sendto_server(source_p->from, 0, 0, ":%s QUIT :%s",
830 >                  source_p->id, comment);
831  
832    /* The client *better* be off all of the lists */
833    assert(dlinkFind(&unknown_list, source_p) == NULL);
834    assert(dlinkFind(&local_client_list, source_p) == NULL);
835 <  assert(dlinkFind(&serv_list, source_p) == NULL);
835 >  assert(dlinkFind(&local_server_list, source_p) == NULL);
836    assert(dlinkFind(&oper_list, source_p) == NULL);
837  
838    exit_one_client(source_p, comment);
# Line 1075 | Line 845 | exit_client(struct Client *source_p, str
845   void
846   dead_link_on_write(struct Client *client_p, int ierrno)
847   {
848 <  dlink_node *ptr;
848 >  dlink_node *node;
849  
850    if (IsDefunct(client_p))
851      return;
852  
853 <  dbuf_clear(&client_p->localClient->buf_recvq);
854 <  dbuf_clear(&client_p->localClient->buf_sendq);
853 >  dbuf_clear(&client_p->connection->buf_recvq);
854 >  dbuf_clear(&client_p->connection->buf_sendq);
855  
856    assert(dlinkFind(&abort_list, client_p) == NULL);
857 <  ptr = make_dlink_node();
857 >  node = make_dlink_node();
858    /* don't let exit_aborted_clients() finish yet */
859 <  dlinkAddTail(client_p, ptr, &abort_list);
859 >  dlinkAddTail(client_p, node, &abort_list);
860  
861    if (eac_next == NULL)
862 <    eac_next = ptr;
862 >    eac_next = node;
863  
864    SetDead(client_p); /* You are dead my friend */
865   }
# Line 1101 | Line 871 | dead_link_on_write(struct Client *client
871   void
872   dead_link_on_read(struct Client *client_p, int error)
873   {
874 <  char errmsg[255];
874 >  char errmsg[IRCD_BUFSIZE];
875    int current_error;
876  
877    if (IsDefunct(client_p))
878      return;
879  
880 <  dbuf_clear(&client_p->localClient->buf_recvq);
881 <  dbuf_clear(&client_p->localClient->buf_sendq);
880 >  dbuf_clear(&client_p->connection->buf_recvq);
881 >  dbuf_clear(&client_p->connection->buf_sendq);
882  
883 <  current_error = get_sockerr(client_p->localClient->fd.fd);
883 >  current_error = get_sockerr(client_p->connection->fd.fd);
884  
885    if (IsServer(client_p) || IsHandshake(client_p))
886    {
1117    int connected = CurrentTime - client_p->firsttime;
1118      
887      if (error == 0)
888      {
889        /* Admins get the real IP */
890 <      sendto_realops_flags(UMODE_ALL, L_ADMIN,
891 <                           "Server %s closed the connection",
892 <                           get_client_name(client_p, SHOW_IP));
890 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
891 >                           "Server %s closed the connection",
892 >                           get_client_name(client_p, SHOW_IP));
893  
894        /* Opers get a masked IP */
895 <      sendto_realops_flags(UMODE_ALL, L_OPER,
896 <                           "Server %s closed the connection",
897 <                           get_client_name(client_p, MASK_IP));
895 >      sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
896 >                           "Server %s closed the connection",
897 >                           get_client_name(client_p, MASK_IP));
898  
899 <      ilog(L_NOTICE, "Server %s closed the connection",
900 <           get_client_name(client_p, SHOW_IP));
899 >      ilog(LOG_TYPE_IRCD, "Server %s closed the connection",
900 >           get_client_name(client_p, SHOW_IP));
901      }
902      else
903      {
904 <      report_error(L_ADMIN, "Lost connection to %s: %d",
905 <                   get_client_name(client_p, SHOW_IP), current_error);
906 <      report_error(L_OPER, "Lost connection to %s: %d",
907 <                   get_client_name(client_p, MASK_IP), current_error);
904 >      report_error(L_ADMIN, "Lost connection to %s: %s",
905 >                   get_client_name(client_p, SHOW_IP), current_error);
906 >      report_error(L_OPER, "Lost connection to %s: %s",
907 >                   get_client_name(client_p, MASK_IP), current_error);
908      }
909  
910 <    sendto_realops_flags(UMODE_ALL, L_ALL,
911 <                         "%s had been connected for %d day%s, %2d:%02d:%02d",
912 <                         client_p->name, connected/86400,
1145 <                         (connected/86400 == 1) ? "" : "s",
1146 <                         (connected % 86400) / 3600, (connected % 3600) / 60,
1147 <                         connected % 60);
910 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
911 >                         "%s was connected for %s",
912 >                         client_p->name, time_dissect(CurrentTime - client_p->connection->firsttime));
913    }
914  
915    if (error == 0)
916      strlcpy(errmsg, "Remote host closed the connection",
917              sizeof(errmsg));
918    else
919 <    ircsprintf(errmsg, "Read error: %s",
920 <               strerror(current_error));
919 >    snprintf(errmsg, sizeof(errmsg), "Read error: %s",
920 >             strerror(current_error));
921  
922 <  exit_client(client_p, &me, errmsg);
922 >  exit_client(client_p, errmsg);
923   }
924  
925   void
# Line 1171 | Line 936 | exit_aborted_clients(void)
936  
937      if (target_p == NULL)
938      {
939 <      sendto_realops_flags(UMODE_ALL, L_ALL,
939 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
940                             "Warning: null client on abort_list!");
941        dlinkDelete(ptr, &abort_list);
942        free_dlink_node(ptr);
# Line 1180 | Line 945 | exit_aborted_clients(void)
945  
946      dlinkDelete(ptr, &abort_list);
947  
948 <    if (IsSendQExceeded(target_p))
948 >    if (HasFlag(target_p, FLAGS_SENDQEX))
949        notice = "Max SendQ exceeded";
950      else
951        notice = "Write error: connection closed";
952  
953 <    exit_client(target_p, &me, notice);  
953 >    exit_client(target_p, notice);
954      free_dlink_node(ptr);
955    }
956   }
957  
958   /*
959   * accept processing, this adds a form of "caller ID" to ircd
960 < *
960 > *
961   * If a client puts themselves into "caller ID only" mode,
962 < * only clients that match a client pointer they have put on
962 > * only clients that match a client pointer they have put on
963   * the accept list will be allowed to message them.
964   *
965 < * [ source.on_allow_list ] -> [ target1 ] -> [ target2 ]
1201 < *
1202 < * [target.allow_list] -> [ source1 ] -> [source2 ]
1203 < *
1204 < * i.e. a target will have a link list of source pointers it will allow
1205 < * each source client then has a back pointer pointing back
1206 < * to the client that has it on its accept list.
1207 < * This allows for exit_one_client to remove these now bogus entries
1208 < * from any client having an accept on them.
965 > * Diane Bruce, "Dianora" db@db.net
966   */
967  
968 < /* accept_message()
969 < *
1213 < * inputs       - pointer to source client
1214 < *              - pointer to target client
1215 < * output       - 1 if accept this message 0 if not
1216 < * side effects - See if source is on target's allow list
1217 < */
1218 < int
1219 < accept_message(struct Client *source, struct Client *target)
968 > void
969 > del_accept(struct split_nuh_item *accept_p, struct Client *client_p)
970   {
971 <  dlink_node *ptr;
971 >  dlinkDelete(&accept_p->node, &client_p->connection->acceptlist);
972  
973 <  DLINK_FOREACH(ptr, target->allow_list.head)
974 <  {
975 <    struct Client *target_p = ptr->data;
973 >  xfree(accept_p->nickptr);
974 >  xfree(accept_p->userptr);
975 >  xfree(accept_p->hostptr);
976 >  xfree(accept_p);
977 > }
978  
979 <    if (source == target_p)
980 <      return (1);
981 <  }
979 > struct split_nuh_item *
980 > find_accept(const char *nick, const char *user,
981 >            const char *host, struct Client *client_p,
982 >            int (*cmpfunc)(const char *, const char *))
983 > {
984 >  dlink_node *node = NULL;
985  
986 <  if (IsSoftCallerId(target))
986 >  DLINK_FOREACH(node, client_p->connection->acceptlist.head)
987    {
988 <    DLINK_FOREACH(ptr, target->channel.head)
989 <      if (IsMember(source, ptr->data))
990 <        return (1);
988 >    struct split_nuh_item *accept_p = node->data;
989 >
990 >    if (!cmpfunc(accept_p->nickptr, nick) &&
991 >        !cmpfunc(accept_p->userptr, user) &&
992 >        !cmpfunc(accept_p->hostptr, host))
993 >      return accept_p;
994    }
995  
996 <  return (0);
996 >  return NULL;
997   }
998  
999 < /* del_from_accept()
1242 < *
1243 < * inputs       - pointer to source client
1244 < *              - pointer to target client
1245 < * output       - NONE
1246 < * side effects - Delete's source pointer to targets allow list
999 > /* accept_message()
1000   *
1001 < * Walk through the target's accept list, remove if source is found,
1002 < * Then walk through the source's on_accept_list remove target if found.
1001 > * inputs       - pointer to source client
1002 > *              - pointer to target client
1003 > * output       - 1 if accept this message 0 if not
1004 > * side effects - See if source is on target's allow list
1005   */
1006 < void
1007 < del_from_accept(struct Client *source, struct Client *target)
1006 > int
1007 > accept_message(struct Client *source,
1008 >               struct Client *target)
1009   {
1010 <  dlink_node *ptr;
1255 <  dlink_node *ptr2;
1256 <  dlink_node *next_ptr;
1257 <  dlink_node *next_ptr2;
1258 <  struct Client *target_p;
1010 >  dlink_node *node = NULL;
1011  
1012 <  DLINK_FOREACH_SAFE(ptr, next_ptr, target->allow_list.head)
1013 <  {
1014 <    target_p = ptr->data;
1012 >  if (HasFlag(source, FLAGS_SERVICE) ||
1013 >      (HasUMode(source, UMODE_OPER) && ConfigGeneral.opers_bypass_callerid))
1014 >    return 1;
1015  
1016 <    if (source == target_p)
1017 <    {
1018 <      dlinkDelete(ptr, &target->allow_list);
1267 <      free_dlink_node(ptr);
1016 >  if (source == target || find_accept(source->name, source->username,
1017 >                                      source->host, target, match))
1018 >    return 1;
1019  
1020 <      DLINK_FOREACH_SAFE(ptr2, next_ptr2, source->on_allow_list.head)
1021 <      {
1022 <        target_p = ptr2->data;
1020 >  if (!HasUMode(target, UMODE_CALLERID) && HasUMode(target, UMODE_SOFTCALLERID))
1021 >    DLINK_FOREACH(node, target->channel.head)
1022 >      if (IsMember(source, ((struct Membership *)node->data)->chptr))
1023 >        return 1;
1024  
1025 <        if (target == target_p)
1274 <        {
1275 <          dlinkDelete(ptr2, &source->on_allow_list);
1276 <          free_dlink_node(ptr2);
1277 <        }
1278 <      }
1279 <    }
1280 <  }
1025 >  return 0;
1026   }
1027  
1028   /* del_all_accepts()
1029   *
1030 < * inputs       - pointer to exiting client
1031 < * output       - NONE
1032 < * side effects - Walk through given clients allow_list and on_allow_list
1288 < *                remove all references to this client
1030 > * inputs       - pointer to exiting client
1031 > * output       - NONE
1032 > * side effects - Walk through given clients acceptlist and remove all entries
1033   */
1034   void
1035   del_all_accepts(struct Client *client_p)
1036   {
1037 <  dlink_node *ptr, *next_ptr;
1294 <
1295 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->allow_list.head)
1296 <    del_from_accept(ptr->data, client_p);
1037 >  dlink_node *node = NULL, *node_next = NULL;
1038  
1039 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->on_allow_list.head)
1040 <    del_from_accept(client_p, ptr->data);
1039 >  DLINK_FOREACH_SAFE(node, node_next, client_p->connection->acceptlist.head)
1040 >    del_accept(node->data, client_p);
1041   }
1042  
1043 < /* del_all_their_accepts()
1044 < *
1045 < * inputs       - pointer to exiting client
1305 < * output       - NONE
1306 < * side effects - Walk through given clients on_allow_list
1307 < *                remove all references to this client,
1308 < *                allow this client to keep their own allow_list
1309 < */
1310 < void
1311 < del_all_their_accepts(struct Client *client_p)
1043 > unsigned int
1044 > client_get_idle_time(const struct Client *source_p,
1045 >                     const struct Client *target_p)
1046   {
1047 <  dlink_node *ptr, *next_ptr;
1047 >  unsigned int idle = 0;
1048 >  unsigned int min_idle = 0;
1049 >  unsigned int max_idle = 0;
1050 >  const struct ClassItem *const class = get_class_ptr(&target_p->connection->confs);
1051  
1052 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->on_allow_list.head)
1053 <    del_from_accept(client_p, ptr->data);
1317 < }
1052 >  if (!(class->flags & CLASS_FLAGS_FAKE_IDLE) || target_p == source_p)
1053 >    return CurrentTime - target_p->connection->last_privmsg;
1054  
1055 < /* set_initial_nick()
1056 < *
1057 < * inputs
1322 < * output
1323 < * side effects -
1324 < *
1325 < * This function is only called to set up an initially registering
1326 < * client.
1327 < */
1328 < void
1329 < set_initial_nick(struct Client *client_p, struct Client *source_p,
1330 <                 const char *nick)
1331 < {
1332 < char buf[USERLEN + 1];
1055 >  if (HasUMode(source_p, UMODE_OPER) &&
1056 >      !(class->flags & CLASS_FLAGS_HIDE_IDLE_FROM_OPERS))
1057 >    return CurrentTime - target_p->connection->last_privmsg;
1058  
1059 <  /* Client setting NICK the first time */
1060 <  
1336 <  /* This had to be copied here to avoid problems.. */
1337 <  source_p->tsinfo = CurrentTime;
1059 >  min_idle = class->min_idle;
1060 >  max_idle = class->max_idle;
1061  
1062 <  if (source_p->name[0])
1063 <    hash_del_client(source_p);
1062 >  if (min_idle == max_idle)
1063 >    return min_idle;
1064  
1065 <  strlcpy(source_p->name, nick, sizeof(source_p->name));
1066 <  hash_add_client(source_p);
1065 >  if (class->flags & CLASS_FLAGS_RANDOM_IDLE)
1066 >    idle = genrand_int32();
1067 >  else
1068 >    idle = CurrentTime - target_p->connection->last_privmsg;
1069  
1070 <  /* fd_desc is long enough */
1071 <  fd_note(&client_p->localClient->fd, "Nick: %s", nick);
1072 <  
1073 <  /* They have the nick they want now.. */
1349 <  client_p->llname[0] = '\0';
1070 >  if (!max_idle)
1071 >    idle = 0;
1072 >  else
1073 >    idle %= max_idle;
1074  
1075 <  if (source_p->flags & FLAGS_GOTUSER)
1076 <  {
1353 <    strlcpy(buf, source_p->username, sizeof(buf));
1075 >  if (idle < min_idle)
1076 >    idle = min_idle + (idle % (max_idle - min_idle));
1077  
1078 <    /*
1356 <     * USER already received, now we have NICK.
1357 <     * *NOTE* For servers "NICK" *must* precede the
1358 <     * user message (giving USER before NICK is possible
1359 <     * only for local client connection!). register_user
1360 <     * may reject the client and call exit_client for it
1361 <     * --must test this and exit m_nick too!!!
1362 <     */
1363 <    register_local_user(client_p, source_p, nick, buf);
1364 <  }
1078 >  return idle;
1079   }
1080  
1081 < /* change_local_nick()
1081 > /* client_init()
1082   *
1083 < * inputs       - pointer to server
1084 < *              - pointer to client
1085 < *              - nick
1372 < * output       -
1373 < * side effects - changes nick of a LOCAL user
1083 > * inputs       - NONE
1084 > * output       - NONE
1085 > * side effects - initialize client free memory
1086   */
1087   void
1088 < change_local_nick(struct Client *client_p, struct Client *source_p, const char *nick)
1088 > client_init(void)
1089   {
1090 <  /*
1379 <  ** Client just changing his/her nick. If he/she is
1380 <  ** on a channel, send note of change to all clients
1381 <  ** on that channel. Propagate notice to other servers.
1382 <  */
1383 <  if ((source_p->localClient->last_nick_change +
1384 <       ConfigFileEntry.max_nick_time) < CurrentTime)
1385 <    source_p->localClient->number_of_nick_changes = 0;
1386 <  source_p->localClient->last_nick_change = CurrentTime;
1387 <  source_p->localClient->number_of_nick_changes++;
1388 <
1389 <  if ((ConfigFileEntry.anti_nick_flood &&
1390 <      (source_p->localClient->number_of_nick_changes
1391 <       <= ConfigFileEntry.max_nick_changes)) ||
1392 <     !ConfigFileEntry.anti_nick_flood ||
1393 <     (IsOper(source_p) && ConfigFileEntry.no_oper_flood))
1394 <  {
1395 <    if (irccmp(source_p->name, nick))
1396 <      source_p->tsinfo = CurrentTime;
1397 <
1398 <    /* XXX - the format of this notice should eventually be changed
1399 <     * to either %s[%s@%s], or even better would be get_client_name() -bill
1400 <     */
1401 <    sendto_realops_flags(UMODE_NCHANGE, L_ALL, "Nick change: From %s to %s [%s@%s]",
1402 <                         source_p->name, nick, source_p->username, source_p->host);
1403 <    sendto_common_channels_local(source_p, 1, ":%s!%s@%s NICK :%s",
1404 <                                 source_p->name, source_p->username,
1405 <                                 source_p->host, nick);
1406 <
1407 <    add_history(source_p, 1);
1408 <          
1409 <         /* Only hubs care about lazy link nicks not being sent on yet
1410 <           * lazylink leafs/leafs always send their nicks up to hub,
1411 <           * hence must always propagate nick changes.
1412 <           * hubs might not propagate a nick change, if the leaf
1413 <           * does not know about that client yet.
1414 <           */
1415 <    sendto_server(client_p, source_p, NULL, CAP_TS6, NOCAPS, NOFLAGS,
1416 <                  ":%s NICK %s :%lu",
1417 <                  ID(source_p), nick, (unsigned long)source_p->tsinfo);
1418 <    sendto_server(client_p, source_p, NULL, NOCAPS, CAP_TS6, NOFLAGS,
1419 <                  ":%s NICK %s :%lu",
1420 <                  source_p->name, nick, (unsigned long)source_p->tsinfo);
1421 <  }
1422 <  else
1090 >  static struct event event_ping =
1091    {
1092 <    sendto_one(source_p, form_str(ERR_NICKTOOFAST),
1093 <               me.name, source_p->name, source_p->name,
1094 <               nick, ConfigFileEntry.max_nick_time);
1095 <    return;
1096 <  }
1097 <
1098 <  /* Finally, add to hash */
1099 <  if (source_p->name[0])
1432 <    hash_del_client(source_p);
1433 <
1434 <  strcpy(source_p->name, nick);
1435 <  hash_add_client(source_p);
1436 <
1437 <  /* Make sure everyone that has this client on its accept list
1438 <   * loses that reference.
1439 <   */
1440 <  del_all_their_accepts(source_p);
1441 <
1442 <  /* fd_desc is long enough */
1443 <  fd_note(&client_p->localClient->fd, "Nick: %s", nick);
1092 >    .name = "check_pings",
1093 >    .handler = check_pings,
1094 >    .when = 5
1095 >  };
1096 >
1097 >  client_pool = mp_pool_new(sizeof(struct Client), MP_CHUNK_SIZE_CLIENT);
1098 >  connection_pool = mp_pool_new(sizeof(struct Connection), MP_CHUNK_SIZE_CONNECTION);
1099 >  event_add(&event_ping, NULL);
1100   }

Comparing:
ircd-hybrid/src/client.c (property svn:keywords), Revision 31 by knight, Sun Oct 2 20:34:05 2005 UTC vs.
ircd-hybrid/trunk/src/client.c (property svn:keywords), Revision 7668 by michael, Wed Jul 20 17:09:49 2016 UTC

# Line 1 | Line 1
1 < "Id Revision"
1 > Id

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)