ViewVC Help

View File | Revision Log | Show Annotations | View Changeset | Root Listing

root/svn/ircd-hybrid/trunk/src/client.c

Comparing ircd-hybrid/trunk/src/client.c (file contents):
Revision 3247 by michael, Sun Mar 30 17:54:34 2014 UTC vs.
Revision 6325 by michael, Sat Aug 8 17:54:22 2015 UTC

#	Line 1 | Line 1
1		/*
2		*  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3		*
4	<	*  Copyright (c) 1997-2014 ircd-hybrid development team
4	>	*  Copyright (c) 1997-2015 ircd-hybrid development team
5		*
6		*  This program is free software; you can redistribute it and/or modify
7		*  it under the terms of the GNU General Public License as published by
#	Line 15 | Line 15
15		*
16		*  You should have received a copy of the GNU General Public License
17		*  along with this program; if not, write to the Free Software
18	<	*  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18	>	*  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19		*  USA
20		*/
21
#	Line 27 | Line 27
27		#include "stdinc.h"
28		#include "list.h"
29		#include "client.h"
30	–	#include "channel_mode.h"
30		#include "event.h"
32	–	#include "fdlist.h"
31		#include "hash.h"
32		#include "irc_string.h"
33		#include "ircd.h"
36	–	#include "s_gline.h"
34		#include "numeric.h"
35	<	#include "packet.h"
39	<	#include "s_auth.h"
35	>	#include "auth.h"
36		#include "s_bsd.h"
37		#include "conf.h"
38		#include "log.h"
39	<	#include "s_misc.h"
40	<	#include "s_serv.h"
39	>	#include "misc.h"
40	>	#include "server.h"
41		#include "send.h"
42		#include "whowas.h"
43	<	#include "s_user.h"
48	<	#include "dbuf.h"
43	>	#include "user.h"
44		#include "memory.h"
45		#include "mempool.h"
46		#include "hostmask.h"
47		#include "listener.h"
53	–	#include "irc_res.h"
48		#include "userhost.h"
49		#include "watch.h"
50		#include "rng_mt.h"
51		#include "parse.h"
52	+	#include "ipcache.h"
53
59	–	dlink_list listing_client_list = { NULL, NULL, 0 };
60	–	/* Pointer to beginning of Client list */
61	–	dlink_list global_client_list = {NULL, NULL, 0};
62	–	/* unknown/client pointer lists */
63	–	dlink_list unknown_list = {NULL, NULL, 0};
64	–	dlink_list local_client_list = {NULL, NULL, 0};
65	–	dlink_list serv_list = {NULL, NULL, 0};
66	–	dlink_list global_serv_list = {NULL, NULL, 0};
67	–	dlink_list oper_list = {NULL, NULL, 0};
54
55	<	static EVH check_pings;
56	<
57	<	static mp_pool_t *client_pool  = NULL;
58	<	static mp_pool_t *lclient_pool = NULL;
59	<
60	<	static dlink_list dead_list  = { NULL, NULL, 0};
61	<	static dlink_list abort_list = { NULL, NULL, 0};
55	>	dlink_list listing_client_list;
56	>	dlink_list unknown_list;
57	>	dlink_list local_client_list;
58	>	dlink_list local_server_list;
59	>	dlink_list global_client_list;
60	>	dlink_list global_server_list;
61	>	dlink_list oper_list;
62
63	+	static mp_pool_t *client_pool, *connection_pool;
64	+	static dlink_list dead_list, abort_list;
65		static dlink_node *eac_next;  /* next aborted client to exit */
66
79	–	static void check_pings_list(dlink_list *);
80	–	static void check_unknowns_list(void);
81	–
82	–
83	–	/* client_init()
84	–	*
85	–	* inputs       - NONE
86	–	* output       - NONE
87	–	* side effects - initialize client free memory
88	–	*/
89	–	void
90	–	client_init(void)
91	–	{
92	–	/* start off the check ping event ..  -- adrian
93	–	* Every 30 seconds is plenty -- db
94	–	*/
95	–	client_pool = mp_pool_new(sizeof(struct Client), MP_CHUNK_SIZE_CLIENT);
96	–	lclient_pool = mp_pool_new(sizeof(struct LocalUser), MP_CHUNK_SIZE_LCLIENT);
97	–	eventAdd("check_pings", check_pings, NULL, 5);
98	–	}
67
68		/*
69		* make_client - create a new Client struct and set it to initial state.
#	Line 115 | Line 83 | client_init(void)
83		struct Client *
84		make_client(struct Client *from)
85		{
86	<	struct Client *client_p = mp_pool_get(client_pool);
119	<
120	<	memset(client_p, 0, sizeof(*client_p));
86	>	struct Client *const client_p = mp_pool_get(client_pool);
87
88		if (!from)
89		{
90	<	client_p->from                      = client_p; /* 'from' of local client is self! */
91	<	client_p->localClient               = mp_pool_get(lclient_pool);
92	<
93	<	memset(client_p->localClient, 0, sizeof(*client_p->localClient));
94	<
95	<	client_p->localClient->since        = CurrentTime;
130	<	client_p->localClient->lasttime     = CurrentTime;
131	<	client_p->localClient->firsttime    = CurrentTime;
132	<	client_p->localClient->registration = REG_INIT;
90	>	client_p->from = client_p;  /* 'from' of local client is self! */
91	>	client_p->connection = mp_pool_get(connection_pool);
92	>	client_p->connection->since = CurrentTime;
93	>	client_p->connection->lasttime = CurrentTime;
94	>	client_p->connection->firsttime = CurrentTime;
95	>	client_p->connection->registration = REG_INIT;
96
97		/* as good a place as any... */
98	<	dlinkAdd(client_p, &client_p->localClient->lclient_node, &unknown_list);
98	>	dlinkAdd(client_p, &client_p->connection->lclient_node, &unknown_list);
99		}
100		else
101	<	client_p->from = from; /* 'from' of local client is self! */
101	>	client_p->from = from;
102
103		client_p->idhnext = client_p;
104	<	client_p->hnext  = client_p;
104	>	client_p->hnext = client_p;
105		SetUnknown(client_p);
106		strcpy(client_p->username, "unknown");
107	<	strcpy(client_p->svid, "0");
107	>	strcpy(client_p->account, "*");
108
109		return client_p;
110		}
#	Line 156 | Line 119 | make_client(struct Client *from)
119		static void
120		free_client(struct Client *client_p)
121		{
159	–	assert(client_p);
122		assert(client_p != &me);
123		assert(client_p->hnext == client_p);
124		assert(client_p->idhnext == client_p);
125		assert(client_p->channel.head == NULL);
126		assert(dlink_list_length(&client_p->channel) == 0);
127		assert(dlink_list_length(&client_p->whowas) == 0);
128	<	assert(!IsServer(client_p) || (IsServer(client_p) && client_p->serv));
128	>	assert(dlink_list_length(&client_p->svstags) == 0);
129
130		MyFree(client_p->serv);
131		MyFree(client_p->certfp);
132
133		if (MyConnect(client_p))
134		{
135	<	assert(client_p->localClient->invited.head == NULL);
136	<	assert(dlink_list_length(&client_p->localClient->invited) == 0);
137	<	assert(dlink_list_length(&client_p->localClient->watches) == 0);
135	>	assert(client_p->connection->invited.head == NULL);
136	>	assert(dlink_list_length(&client_p->connection->invited) == 0);
137	>	assert(dlink_list_length(&client_p->connection->watches) == 0);
138		assert(IsClosing(client_p) && IsDead(client_p));
139
140	<	MyFree(client_p->localClient->response);
141	<	MyFree(client_p->localClient->auth_oper);
140	>	MyFree(client_p->connection->challenge_response);
141	>	client_p->connection->challenge_response = NULL;
142	>	MyFree(client_p->connection->challenge_operator);
143	>	client_p->connection->challenge_operator = NULL;
144
145		/*
146	<	* clean up extra sockets from P-lines which have been discarded.
146	>	* Clean up extra sockets from listen {} blocks which have been discarded.
147		*/
148	<	if (client_p->localClient->listener)
148	>	if (client_p->connection->listener)
149		{
150	<	assert(0 < client_p->localClient->listener->ref_count);
151	<	if (0 == --client_p->localClient->listener->ref_count &&
188	<	!client_p->localClient->listener->active)
189	<	free_listener(client_p->localClient->listener);
150	>	listener_release(client_p->connection->listener);
151	>	client_p->connection->listener = NULL;
152		}
153
154	<	dbuf_clear(&client_p->localClient->buf_recvq);
155	<	dbuf_clear(&client_p->localClient->buf_sendq);
154	>	dbuf_clear(&client_p->connection->buf_recvq);
155	>	dbuf_clear(&client_p->connection->buf_sendq);
156
157	<	mp_pool_release(client_p->localClient);
157	>	mp_pool_release(client_p->connection);
158		}
159
160		mp_pool_release(client_p);
161		}
162
163	<	/*
164	<	* check_pings - go through the local client list and check activity
165	<	* kill off stuff that should die
166	<	*
167	<	* inputs       - NOT USED (from event)
168	<	* output       - next time_t when check_pings() should be called again
207	<	* side effects -
208	<	*
209	<	*
210	<	* A PING can be sent to clients as necessary.
211	<	*
212	<	* Client/Server ping outs are handled.
213	<	*/
163	>	void
164	>	client_attach_svstag(struct Client *client_p, unsigned int numeric,
165	>	const char *umodes, const char *const tag)
166	>	{
167	>	struct ServicesTag *svstag = NULL;
168	>	const struct user_modes *tab = NULL;
169
170	<	/*
171	<	* Addon from adrian. We used to call this after nextping seconds,
217	<	* however I've changed it to run once a second. This is only for
218	<	* PING timeouts, not K/etc-line checks (thanks dianora!). Having it
219	<	* run once a second makes life a lot easier - when a new client connects
220	<	* and they need a ping in 4 seconds, if nextping was set to 20 seconds
221	<	* we end up waiting 20 seconds. This is stupid. :-)
222	<	* I will optimise (hah!) check_pings() once I've finished working on
223	<	* tidying up other network IO evilnesses.
224	<	*     -- adrian
225	<	*/
170	>	if (numeric >= ERR_LAST_ERR_MSG || *umodes != '+')
171	>	return;
172
173	<	static void
174	<	check_pings(void *notused)
173	>	svstag = MyCalloc(sizeof(*svstag));
174	>	svstag->numeric = numeric;
175	>	svstag->tag = xstrdup(tag);
176	>
177	>	for (const char *m = umodes + 1; *m; ++m)
178	>	if ((tab = umode_map[(unsigned char)*m]))
179	>	svstag->umodes |= tab->flag;
180	>
181	>	if (numeric != RPL_WHOISOPERATOR)
182	>	dlinkAddTail(svstag, &svstag->node, &client_p->svstags);
183	>	else
184	>	dlinkAdd(svstag, &svstag->node, &client_p->svstags);
185	>	}
186	>
187	>	void
188	>	client_clear_svstags(struct Client *client_p)
189		{
190	<	check_pings_list(&local_client_list);
191	<	check_pings_list(&serv_list);
192	<	check_unknowns_list();
190	>	dlink_node *node = NULL, *node_next = NULL;
191	>
192	>	DLINK_FOREACH_SAFE(node, node_next, client_p->svstags.head)
193	>	{
194	>	struct ServicesTag *svstag = node->data;
195	>
196	>	dlinkDelete(&svstag->node, &client_p->svstags);
197	>	MyFree(svstag->tag);
198	>	MyFree(svstag);
199	>	}
200		}
201
202		/* check_pings_list()
#	Line 241 | Line 208 | check_pings(void *notused)
208		static void
209		check_pings_list(dlink_list *list)
210		{
211	<	char scratch[IRCD_BUFSIZE];
211	>	char buf[IRCD_BUFSIZE] = "";
212		int ping = 0;      /* ping time value from client */
213	<	dlink_node *ptr = NULL, *next_ptr = NULL;
213	>	dlink_node *node = NULL, *node_next = NULL;
214
215	<	DLINK_FOREACH_SAFE(ptr, next_ptr, list->head)
215	>	DLINK_FOREACH_SAFE(node, node_next, list->head)
216		{
217	<	struct Client *client_p = ptr->data;
217	>	struct Client *client_p = node->data;
218
252	–	/*
253	–	** Note: No need to notify opers here. It's
254	–	** already done when "FLAGS_DEADSOCKET" is set.
255	–	*/
219		if (IsDead(client_p))
220	<	{
258	<	/* Ignore it, its been exited already */
259	<	continue;
260	<	}
220	>	continue;  /* Ignore it, its been exited already */
221
222	<	if (!IsRegistered(client_p))
223	<	ping = CONNECTTIMEOUT;
222	>	if (IsClient(client_p) || IsServer(client_p))
223	>	ping = get_client_ping(&client_p->connection->confs);
224		else
225	<	ping = get_client_ping(&client_p->localClient->confs);
225	>	ping = CONNECTTIMEOUT;
226
227	<	if (ping < CurrentTime - client_p->localClient->lasttime)
227	>	if (ping < CurrentTime - client_p->connection->lasttime)
228		{
229	<	if (!IsPingSent(client_p))
229	>	if (!HasFlag(client_p, FLAGS_PINGSENT))
230		{
231		/*
232	<	* if we havent PINGed the connection and we havent
232	>	* If we haven't PINGed the connection and we haven't
233		* heard from it in a while, PING it to make sure
234		* it is still alive.
235		*/
236	<	SetPingSent(client_p);
237	<	client_p->localClient->lasttime = CurrentTime - ping;
236	>	AddFlag(client_p, FLAGS_PINGSENT);
237	>	client_p->connection->lasttime = CurrentTime - ping;
238		sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
239		}
240		else
241		{
242	<	if (CurrentTime - client_p->localClient->lasttime >= 2 * ping)
242	>	if (CurrentTime - client_p->connection->lasttime >= 2 * ping)
243		{
244		/*
245		* If the client/server hasn't talked to us in 2*ping seconds
#	Line 287 | Line 247 | check_pings_list(dlink_list *list)
247		*/
248		if (IsServer(client_p) || IsHandshake(client_p))
249		{
250	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
250	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
251		"No response from %s, closing link",
252		get_client_name(client_p, HIDE_IP));
253	<	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
253	>	sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
254		"No response from %s, closing link",
255		get_client_name(client_p, MASK_IP));
256		ilog(LOG_TYPE_IRCD, "No response from %s, closing link",
257		get_client_name(client_p, HIDE_IP));
258		}
259
260	<	snprintf(scratch, sizeof(scratch), "Ping timeout: %d seconds",
261	<	(int)(CurrentTime - client_p->localClient->lasttime));
262	<	exit_client(client_p, scratch);
260	>	snprintf(buf, sizeof(buf), "Ping timeout: %d seconds",
261	>	(int)(CurrentTime - client_p->connection->lasttime));
262	>	exit_client(client_p, buf);
263		}
264		}
265		}
#	Line 315 | Line 275 | check_pings_list(dlink_list *list)
275		static void
276		check_unknowns_list(void)
277		{
278	<	dlink_node *ptr = NULL, *ptr_next = NULL;
278	>	dlink_node *node = NULL, *node_next = NULL;
279
280	<	DLINK_FOREACH_SAFE(ptr, ptr_next, unknown_list.head)
280	>	DLINK_FOREACH_SAFE(node, node_next, unknown_list.head)
281		{
282	<	struct Client *client_p = ptr->data;
282	>	struct Client *client_p = node->data;
283
284		/*
285		* Check UNKNOWN connections - if they have been in this state
286		* for > 30s, close them.
287		*/
288	<	if (IsAuthFinished(client_p) && (CurrentTime - client_p->localClient->firsttime) > 30)
288	>	if (IsAuthFinished(client_p) && (CurrentTime - client_p->connection->firsttime) > 30)
289		exit_client(client_p, "Registration timed out");
290		}
291		}
292
293	+	/*
294	+	* check_pings - go through the local client list and check activity
295	+	* kill off stuff that should die
296	+	*
297	+	* inputs       - NOT USED (from event)
298	+	* output       - next time_t when check_pings() should be called again
299	+	* side effects -
300	+	*
301	+	*
302	+	* A PING can be sent to clients as necessary.
303	+	*
304	+	* Client/Server ping outs are handled.
305	+	*/
306	+
307	+	/*
308	+	* Addon from adrian. We used to call this after nextping seconds,
309	+	* however I've changed it to run once a second. This is only for
310	+	* PING timeouts, not K/etc-line checks (thanks dianora!). Having it
311	+	* run once a second makes life a lot easier - when a new client connects
312	+	* and they need a ping in 4 seconds, if nextping was set to 20 seconds
313	+	* we end up waiting 20 seconds. This is stupid. :-)
314	+	* I will optimise (hah!) check_pings() once I've finished working on
315	+	* tidying up other network IO evilnesses.
316	+	*     -- adrian
317	+	*/
318	+
319	+	static void
320	+	check_pings(void *unused)
321	+	{
322	+	check_pings_list(&local_client_list);
323	+	check_pings_list(&local_server_list);
324	+	check_unknowns_list();
325	+	}
326	+
327		/* check_conf_klines()
328		*
329		* inputs       - NONE
#	Line 340 | Line 334 | check_unknowns_list(void)
334		void
335		check_conf_klines(void)
336		{
343	–	struct Client *client_p = NULL;       /* current local client_p being examined */
337		struct MaskItem *conf = NULL;
338	<	dlink_node *ptr, *next_ptr;
338	>	dlink_node *node = NULL, *node_next = NULL;
339
340	<	DLINK_FOREACH_SAFE(ptr, next_ptr, local_client_list.head)
340	>	DLINK_FOREACH_SAFE(node, node_next, local_client_list.head)
341		{
342	<	client_p = ptr->data;
342	>	struct Client *client_p = node->data;
343
344	<	/* If a client is already being exited
345	<	*/
353	<	if (IsDead(client_p) || !IsClient(client_p))
344	>	/* If a client is already being exited */
345	>	if (IsDead(client_p))
346		continue;
347
348	<	if ((conf = find_dline_conf(&client_p->localClient->ip,
349	<	client_p->localClient->aftype)))
348	>	if ((conf = find_conf_by_address(NULL, &client_p->connection->ip, CONF_DLINE,
349	>	client_p->connection->aftype, NULL, NULL, 1)))
350		{
359	–	if (conf->type == CONF_EXEMPT)
360	–	continue;
361	–
351		conf_try_ban(client_p, conf);
352	<	continue; /* and go examine next fd/client_p */
364	<	}
365	<
366	<	if (ConfigFileEntry.glines)
367	<	{
368	<	if ((conf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
369	<	CONF_GLINE, client_p->localClient->aftype,
370	<	client_p->username, NULL, 1)))
371	<	{
372	<	conf_try_ban(client_p, conf);
373	<	/* and go examine next fd/client_p */
374	<	continue;
375	<	}
352	>	continue;  /* and go examine next Client */
353		}
354
355	<	if ((conf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
356	<	CONF_KLINE, client_p->localClient->aftype,
355	>	if ((conf = find_conf_by_address(client_p->host, &client_p->connection->ip,
356	>	CONF_KLINE, client_p->connection->aftype,
357		client_p->username, NULL, 1)))
358		{
359		conf_try_ban(client_p, conf);
360	<	continue;
360	>	continue;  /* and go examine next Client */
361		}
362
363	<	if ((conf = find_matching_name_conf(CONF_XLINE,  client_p->info,
363	>	if ((conf = find_matching_name_conf(CONF_XLINE, client_p->info,
364		NULL, NULL, 0)))
365		{
366		conf_try_ban(client_p, conf);
367	<	continue;
367	>	continue;  /* and go examine next Client */
368		}
369		}
370
371	<	/* also check the unknowns list for new dlines */
372	<	DLINK_FOREACH_SAFE(ptr, next_ptr, unknown_list.head)
371	>	/* Also check the unknowns list for new dlines */
372	>	DLINK_FOREACH_SAFE(node, node_next, unknown_list.head)
373		{
374	<	client_p = ptr->data;
374	>	struct Client *client_p = node->data;
375
376	<	if ((conf = find_dline_conf(&client_p->localClient->ip,
377	<	client_p->localClient->aftype)))
376	>	if ((conf = find_conf_by_address(NULL, &client_p->connection->ip, CONF_DLINE,
377	>	client_p->connection->aftype, NULL, NULL, 1)))
378		{
379	<	if (conf->type == CONF_EXEMPT)
380	<	continue;
404	<
405	<	exit_client(client_p, "D-lined");
379	>	conf_try_ban(client_p, conf);
380	>	continue;  /* and go examine next Client */
381		}
382		}
383		}
#	Line 418 | Line 393 | check_conf_klines(void)
393		void
394		conf_try_ban(struct Client *client_p, struct MaskItem *conf)
395		{
396	<	const char *user_reason = NULL;  /* What is sent to user */
422	<	const char *type_string = NULL;
423	<	const char dline_string[] = "D-line";
424	<	const char kline_string[] = "K-line";
425	<	const char gline_string[] = "G-line";
426	<	const char xline_string[] = "X-line";
396	>	char ban_type = '\0';
397
398		switch (conf->type)
399		{
400		case CONF_KLINE:
401	<	if (IsExemptKline(client_p))
401	>	if (HasFlag(client_p, FLAGS_EXEMPTKLINE))
402		{
403	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
403	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
404		"KLINE over-ruled for %s, client is kline_exempt",
405		get_client_name(client_p, HIDE_IP));
406		return;
407		}
408
409	<	type_string = kline_string;
409	>	ban_type = 'K';
410		break;
411		case CONF_DLINE:
412	<	type_string = dline_string;
412	>	if (find_conf_by_address(NULL, &client_p->connection->ip, CONF_EXEMPT,
413	>	client_p->connection->aftype, NULL, NULL, 1))
414	>	return;
415	>	ban_type = 'D';
416		break;
417	<	case CONF_GLINE:
418	<	if (IsExemptKline(client_p) ||
446	<	IsExemptGline(client_p))
417	>	case CONF_XLINE:
418	>	if (HasFlag(client_p, FLAGS_EXEMPTXLINE))
419		{
420	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
421	<	"GLINE over-ruled for %s, client is %sline_exempt",
422	<	get_client_name(client_p, HIDE_IP), IsExemptKline(client_p) ? "k" : "g");
420	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
421	>	"XLINE over-ruled for %s, client is xline_exempt",
422	>	get_client_name(client_p, HIDE_IP));
423		return;
424		}
425
426	<	type_string = gline_string;
455	<	break;
456	<	case CONF_XLINE:
457	<	type_string = xline_string;
426	>	ban_type = 'X';
427		++conf->count;
428		break;
429		default:
#	Line 462 | Line 431 | conf_try_ban(struct Client *client_p, st
431		break;
432		}
433
434	<	user_reason = conf->reason ? conf->reason : type_string;
435	<
467	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s active for %s",
468	<	type_string, get_client_name(client_p, HIDE_IP));
434	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE, "%c-line active for %s",
435	>	ban_type, get_client_name(client_p, HIDE_IP));
436
437		if (IsClient(client_p))
438	<	sendto_one_numeric(client_p, &me, ERR_YOUREBANNEDCREEP, user_reason);
438	>	sendto_one_numeric(client_p, &me, ERR_YOUREBANNEDCREEP, conf->reason);
439
440	<	exit_client(client_p, user_reason);
440	>	exit_client(client_p, conf->reason);
441		}
442
443		/* update_client_exit_stats()
#	Line 485 | Line 452 | update_client_exit_stats(struct Client *
452		if (IsClient(client_p))
453		{
454		assert(Count.total > 0);
455	+
456		--Count.total;
457		if (HasUMode(client_p, UMODE_OPER))
458		--Count.oper;
#	Line 530 | Line 498 | find_person(const struct Client *const s
498		struct Client *
499		find_chasing(struct Client *source_p, const char *name)
500		{
501	<	struct Client *who = find_person(source_p, name);
501	>	struct Client *target_p = find_person(source_p, name);
502
503	<	if (who)
504	<	return who;
503	>	if (target_p)
504	>	return target_p;
505
506		if (IsDigit(*name))
507		return NULL;
508
509	<	if ((who = whowas_get_history(name,
510	<	(time_t)ConfigFileEntry.kill_chase_time_limit))
511	<	== NULL)
509	>	target_p = whowas_get_history(name, (time_t)ConfigGeneral.kill_chase_time_limit);
510	>
511	>	if (!target_p)
512		{
513		sendto_one_numeric(source_p, &me, ERR_NOSUCHNICK, name);
514		return NULL;
515		}
516
517	<	return who;
517	>	return target_p;
518		}
519
520		/*
#	Line 558 | Line 526 | find_chasing(struct Client *source_p, co
526		*        But, this can be used to any client structure.
527		*
528		* NOTE 1:
529	<	*        Watch out the allocation of "nbuf", if either source_p->name
529	>	*        Watch out the allocation of "buf", if either source_p->name
530		*        or source_p->sockhost gets changed into pointers instead of
531		*        directly allocated within the structure...
532		*
533		* NOTE 2:
534		*        Function return either a pointer to the structure (source_p) or
535	<	*        to internal buffer (nbuf). *NEVER* use the returned pointer
535	>	*        to internal buffer (buf). *NEVER* use the returned pointer
536		*        to modify what it points!!!
537		*/
538		const char *
539		get_client_name(const struct Client *client_p, enum addr_mask_type type)
540		{
541	<	static char nbuf[HOSTLEN * 2 + USERLEN + 5];
574	<
575	<	assert(client_p);
541	>	static char buf[HOSTLEN * 2 + USERLEN + 5];
542
543		if (!MyConnect(client_p))
544		return client_p->name;
#	Line 585 | Line 551 | get_client_name(const struct Client *cli
551		type = MASK_IP;
552		}
553
588	–	if (ConfigFileEntry.hide_spoof_ips)
589	–	if (type == SHOW_IP && IsIPSpoof(client_p))
590	–	type = MASK_IP;
591	–
554		/* And finally, let's get the host information, ip or name */
555		switch (type)
556		{
557		case SHOW_IP:
558	<	snprintf(nbuf, sizeof(nbuf), "%s[%s@%s]",
558	>	snprintf(buf, sizeof(buf), "%s[%s@%s]",
559		client_p->name,
560		client_p->username, client_p->sockhost);
561		break;
562		case MASK_IP:
563	<	if (client_p->localClient->aftype == AF_INET)
564	<	snprintf(nbuf, sizeof(nbuf), "%s[%s@255.255.255.255]",
563	>	if (client_p->connection->aftype == AF_INET)
564	>	snprintf(buf, sizeof(buf), "%s[%s@255.255.255.255]",
565		client_p->name, client_p->username);
566		else
567	<	snprintf(nbuf, sizeof(nbuf), "%s[%s@ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]",
567	>	snprintf(buf, sizeof(buf), "%s[%s@ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]",
568		client_p->name, client_p->username);
569		break;
570	<	default:
571	<	snprintf(nbuf, sizeof(nbuf), "%s[%s@%s]",
570	>	default:  /* HIDE_IP */
571	>	snprintf(buf, sizeof(buf), "%s[%s@%s]",
572		client_p->name,
573		client_p->username, client_p->host);
574		}
575
576	<	return nbuf;
576	>	return buf;
577		}
578
579		void
580		free_exited_clients(void)
581		{
582	<	dlink_node *ptr = NULL, *next = NULL;
582	>	dlink_node *node = NULL, *node_next = NULL;
583
584	<	DLINK_FOREACH_SAFE(ptr, next, dead_list.head)
584	>	DLINK_FOREACH_SAFE(node, node_next, dead_list.head)
585		{
586	<	free_client(ptr->data);
587	<	dlinkDelete(ptr, &dead_list);
588	<	free_dlink_node(ptr);
586	>	free_client(node->data);
587	>	dlinkDelete(node, &dead_list);
588	>	free_dlink_node(node);
589		}
590		}
591
#	Line 634 | Line 596 | free_exited_clients(void)
596		* The only messages generated are QUITs on channels.
597		*/
598		static void
599	<	exit_one_client(struct Client *source_p, const char *quitmsg)
599	>	exit_one_client(struct Client *source_p, const char *comment)
600		{
601	<	dlink_node *ptr = NULL, *ptr_next = NULL;
601	>	dlink_node *node = NULL, *node_next = NULL;
602
603		assert(!IsMe(source_p));
604	+	assert(source_p != &me);
605
606		if (IsClient(source_p))
607		{
608		dlinkDelete(&source_p->lnode, &source_p->servptr->serv->client_list);
609	+	dlinkDelete(&source_p->node, &global_client_list);
610
611		/*
612		* If a person is on a channel, send a QUIT notice
#	Line 652 | Line 616 | exit_one_client(struct Client *source_p,
616		*/
617		sendto_common_channels_local(source_p, 0, 0, ":%s!%s@%s QUIT :%s",
618		source_p->name, source_p->username,
619	<	source_p->host, quitmsg);
620	<	DLINK_FOREACH_SAFE(ptr, ptr_next, source_p->channel.head)
621	<	remove_user_from_channel(ptr->data);
619	>	source_p->host, comment);
620	>
621	>	DLINK_FOREACH_SAFE(node, node_next, source_p->channel.head)
622	>	remove_user_from_channel(node->data);
623
624		whowas_add_history(source_p, 0);
625		whowas_off_history(source_p);
#	Line 663 | Line 628 | exit_one_client(struct Client *source_p,
628
629		if (MyConnect(source_p))
630		{
631	<	/* Clean up invitefield */
667	<	DLINK_FOREACH_SAFE(ptr, ptr_next, source_p->localClient->invited.head)
668	<	del_invite(ptr->data, source_p);
669	<
631	>	clear_invites_client(source_p);
632		del_all_accepts(source_p);
633		}
634		}
635		else if (IsServer(source_p))
636		{
637		dlinkDelete(&source_p->lnode, &source_p->servptr->serv->server_list);
638	+	dlinkDelete(&source_p->node, &global_client_list);
639
640	<	if ((ptr = dlinkFindDelete(&global_serv_list, source_p)))
641	<	free_dlink_node(ptr);
640	>	if ((node = dlinkFindDelete(&global_server_list, source_p)))
641	>	free_dlink_node(node);
642		}
643
644		/* Remove source_p from the client lists */
645		if (source_p->id[0])
646		hash_del_id(source_p);
647	+
648		if (source_p->name[0])
649		hash_del_client(source_p);
650
651	<	if (IsUserHostIp(source_p))
651	>	if (HasFlag(source_p, FLAGS_USERHOST))
652		delete_user_host(source_p->username, source_p->host, !MyConnect(source_p));
653
690	–	/* remove from global client list
691	–	* NOTE: source_p->node.next cannot be NULL if the client is added
692	–	*       to global_client_list (there is always &me at its end)
693	–	*/
694	–	if (source_p->node.next) /* XXX: not needed? */
695	–	dlinkDelete(&source_p->node, &global_client_list);
696	–
654		update_client_exit_stats(source_p);
655
656		/* Check to see if the client isn't already on the dead list */
#	Line 711 | Line 668 | exit_one_client(struct Client *source_p,
668		* actually removing things off llists.   tweaked from +CSr31  -orabidoo
669		*/
670		static void
671	<	recurse_remove_clients(struct Client *source_p, const char *quitmsg)
671	>	recurse_remove_clients(struct Client *source_p, const char *comment)
672		{
673	<	dlink_node *ptr = NULL, *ptr_next = NULL;
673	>	dlink_node *node = NULL, *node_next = NULL;
674
675	<	DLINK_FOREACH_SAFE(ptr, ptr_next, source_p->serv->client_list.head)
676	<	exit_one_client(ptr->data, quitmsg);
675	>	DLINK_FOREACH_SAFE(node, node_next, source_p->serv->client_list.head)
676	>	exit_one_client(node->data, comment);
677
678	<	DLINK_FOREACH_SAFE(ptr, ptr_next, source_p->serv->server_list.head)
678	>	DLINK_FOREACH_SAFE(node, node_next, source_p->serv->server_list.head)
679		{
680	<	recurse_remove_clients(ptr->data, quitmsg);
681	<	exit_one_client(ptr->data, quitmsg);
680	>	recurse_remove_clients(node->data, comment);
681	>	exit_one_client(node->data, comment);
682		}
683		}
684
#	Line 745 | Line 702 | recurse_remove_clients(struct Client *so
702		void
703		exit_client(struct Client *source_p, const char *comment)
704		{
705	<	dlink_node *m = NULL;
705	>	dlink_node *node = NULL;
706	>
707	>	assert(!IsMe(source_p));
708	>	assert(source_p != &me);
709
710		if (MyConnect(source_p))
711		{
#	Line 757 | Line 717 | exit_client(struct Client *source_p, con
717
718		SetClosing(source_p);
719
720	<	if (IsIpHash(source_p))
721	<	remove_one_ip(&source_p->localClient->ip);
720	>	if (HasFlag(source_p, FLAGS_IPHASH))
721	>	{
722	>	DelFlag(source_p, FLAGS_IPHASH);
723	>	ipcache_remove_address(&source_p->connection->ip);
724	>	}
725
726	<	delete_auth(&source_p->localClient->auth);
726	>	delete_auth(&source_p->connection->auth);
727
728	<	/*
766	<	* This source_p could have status of one of STAT_UNKNOWN, STAT_CONNECTING
767	<	* STAT_HANDSHAKE or STAT_UNKNOWN
768	<	* all of which are lumped together into unknown_list
769	<	*
770	<	* In all above cases IsRegistered() will not be true.
771	<	*/
772	<	if (!IsRegistered(source_p))
728	>	if (IsClient(source_p))
729		{
730	<	assert(dlinkFind(&unknown_list, source_p));
730	>	time_t on_for = CurrentTime - source_p->connection->firsttime;
731
776	–	dlinkDelete(&source_p->localClient->lclient_node, &unknown_list);
777	–	}
778	–	else if (IsClient(source_p))
779	–	{
780	–	time_t on_for = CurrentTime - source_p->localClient->firsttime;
732		assert(Count.local > 0);
733	<	Count.local--;
733	>
734	>	--Count.local;
735
736		if (HasUMode(source_p, UMODE_OPER))
737	<	if ((m = dlinkFindDelete(&oper_list, source_p)))
738	<	free_dlink_node(m);
737	>	if ((node = dlinkFindDelete(&oper_list, source_p)))
738	>	free_dlink_node(node);
739
740		assert(dlinkFind(&local_client_list, source_p));
741	<	dlinkDelete(&source_p->localClient->lclient_node, &local_client_list);
741	>	dlinkDelete(&source_p->connection->lclient_node, &local_client_list);
742
743	<	if (source_p->localClient->list_task)
744	<	free_list_task(source_p->localClient->list_task, source_p);
743	>	if (source_p->connection->list_task)
744	>	free_list_task(source_p);
745
746		watch_del_watch_list(source_p);
747	+	client_clear_svstags(source_p);
748	+
749		sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
750		"Client exiting: %s (%s@%s) [%s] [%s]",
751		source_p->name, source_p->username, source_p->host, comment,
752	<	ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
753	<	"255.255.255.255" : source_p->sockhost);
752	>	source_p->sockhost);
753	>
754		ilog(LOG_TYPE_USER, "%s (%3u:%02u:%02u): %s!%s@%s %llu/%llu",
755	<	myctime(source_p->localClient->firsttime), (unsigned int)(on_for / 3600),
755	>	myctime(source_p->connection->firsttime), (unsigned int)(on_for / 3600),
756		(unsigned int)((on_for % 3600)/60), (unsigned int)(on_for % 60),
757		source_p->name, source_p->username, source_p->host,
758	<	source_p->localClient->send.bytes>>10,
759	<	source_p->localClient->recv.bytes>>10);
758	>	source_p->connection->send.bytes>>10,
759	>	source_p->connection->recv.bytes>>10);
760		}
761		else if (IsServer(source_p))
762		{
763		assert(Count.myserver > 0);
764	+
765		--Count.myserver;
766
767	<	assert(dlinkFind(&serv_list, source_p));
768	<	dlinkDelete(&source_p->localClient->lclient_node, &serv_list);
767	>	assert(dlinkFind(&local_server_list, source_p));
768	>	dlinkDelete(&source_p->connection->lclient_node, &local_server_list);
769	>	}
770	>	else
771	>	{
772	>	assert(dlinkFind(&unknown_list, source_p));
773	>	dlinkDelete(&source_p->connection->lclient_node, &unknown_list);
774		}
775
776		if (!IsDead(source_p))
#	Line 829 | Line 789 | exit_client(struct Client *source_p, con
789		source_p->host, comment);
790		}
791
832	–	/*
833	–	** Currently only server connections can have
834	–	** depending remote clients here, but it does no
835	–	** harm to check for all local clients. In
836	–	** future some other clients than servers might
837	–	** have remotes too...
838	–	**
839	–	** Close the Client connection first and mark it
840	–	** so that no messages are attempted to send to it.
841	–	** Remember it makes source_p->from == NULL.
842	–	*/
792		close_connection(source_p);
793		}
794		else if (IsClient(source_p) && HasFlag(source_p->servptr, FLAGS_EOB))
#	Line 852 | Line 801 | exit_client(struct Client *source_p, con
801		{
802		char splitstr[HOSTLEN + HOSTLEN + 2] = "";
803
804	<	/* This shouldn't ever happen */
805	<	assert(source_p->serv && source_p->servptr);
804	>	assert(source_p->serv);
805	>	assert(source_p->servptr);
806
807		if (ConfigServerHide.hide_servers)
808		/*
#	Line 865 | Line 814 | exit_client(struct Client *source_p, con
814		snprintf(splitstr, sizeof(splitstr), "%s %s",
815		source_p->servptr->name, source_p->name);
816
817	<	/* Send SQUIT for source_p in every direction. source_p is already off of serv_list here */
817	>	/* Send SQUIT for source_p in every direction. source_p is already off of local_server_list here */
818		if (!HasFlag(source_p, FLAGS_SQUIT))
819	<	sendto_server(NULL, NOCAPS, NOCAPS, "SQUIT %s :%s", source_p->id, comment);
819	>	sendto_server(NULL, 0, 0, "SQUIT %s :%s", source_p->id, comment);
820
821		/* Now exit the clients internally */
822		recurse_remove_clients(source_p, splitstr);
823
824		if (MyConnect(source_p))
825		{
826	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
827	<	"%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
828	<	source_p->name, (int)(CurrentTime - source_p->localClient->firsttime),
829	<	source_p->localClient->send.bytes >> 10,
830	<	source_p->localClient->recv.bytes >> 10);
831	<	ilog(LOG_TYPE_IRCD, "%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
832	<	source_p->name, (int)(CurrentTime - source_p->localClient->firsttime),
833	<	source_p->localClient->send.bytes >> 10,
834	<	source_p->localClient->recv.bytes >> 10);
826	>	int connected = CurrentTime - source_p->connection->firsttime;
827	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
828	>	"%s was connected for %d day%s, %2d:%02d:%02d. %llu/%llu sendK/recvK.",
829	>	source_p->name, connected/86400, (connected/86400 == 1) ? "" : "s",
830	>	(connected % 86400) / 3600, (connected % 3600) / 60, connected % 60,
831	>	source_p->connection->send.bytes >> 10,
832	>	source_p->connection->recv.bytes >> 10);
833	>	ilog(LOG_TYPE_IRCD, "%s was connected for %d day%s, %2d:%02d:%02d. %llu/%llu sendK/recvK.",
834	>	source_p->name, connected/86400, (connected/86400 == 1) ? "" : "s",
835	>	(connected % 86400) / 3600, (connected % 3600) / 60, connected % 60,
836	>	source_p->connection->send.bytes >> 10,
837	>	source_p->connection->recv.bytes >> 10);
838		}
839		}
840		else if (IsClient(source_p) && !HasFlag(source_p, FLAGS_KILLED))
841	<	sendto_server(source_p->from, NOCAPS, NOCAPS, ":%s QUIT :%s",
841	>	sendto_server(source_p->from, 0, 0, ":%s QUIT :%s",
842		source_p->id, comment);
843
844		/* The client *better* be off all of the lists */
845		assert(dlinkFind(&unknown_list, source_p) == NULL);
846		assert(dlinkFind(&local_client_list, source_p) == NULL);
847	<	assert(dlinkFind(&serv_list, source_p) == NULL);
847	>	assert(dlinkFind(&local_server_list, source_p) == NULL);
848		assert(dlinkFind(&oper_list, source_p) == NULL);
849
850		exit_one_client(source_p, comment);
#	Line 905 | Line 857 | exit_client(struct Client *source_p, con
857		void
858		dead_link_on_write(struct Client *client_p, int ierrno)
859		{
860	<	dlink_node *ptr;
860	>	dlink_node *node;
861
862		if (IsDefunct(client_p))
863		return;
864
865	<	dbuf_clear(&client_p->localClient->buf_recvq);
866	<	dbuf_clear(&client_p->localClient->buf_sendq);
865	>	dbuf_clear(&client_p->connection->buf_recvq);
866	>	dbuf_clear(&client_p->connection->buf_sendq);
867
868		assert(dlinkFind(&abort_list, client_p) == NULL);
869	<	ptr = make_dlink_node();
869	>	node = make_dlink_node();
870		/* don't let exit_aborted_clients() finish yet */
871	<	dlinkAddTail(client_p, ptr, &abort_list);
871	>	dlinkAddTail(client_p, node, &abort_list);
872
873		if (eac_next == NULL)
874	<	eac_next = ptr;
874	>	eac_next = node;
875
876		SetDead(client_p); /* You are dead my friend */
877		}
#	Line 937 | Line 889 | dead_link_on_read(struct Client *client_
889		if (IsDefunct(client_p))
890		return;
891
892	<	dbuf_clear(&client_p->localClient->buf_recvq);
893	<	dbuf_clear(&client_p->localClient->buf_sendq);
892	>	dbuf_clear(&client_p->connection->buf_recvq);
893	>	dbuf_clear(&client_p->connection->buf_sendq);
894
895	<	current_error = get_sockerr(client_p->localClient->fd.fd);
895	>	current_error = get_sockerr(client_p->connection->fd.fd);
896
897		if (IsServer(client_p) || IsHandshake(client_p))
898		{
899	<	int connected = CurrentTime - client_p->localClient->firsttime;
899	>	int connected = CurrentTime - client_p->connection->firsttime;
900
901		if (error == 0)
902		{
903		/* Admins get the real IP */
904	<	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
904	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
905		"Server %s closed the connection",
906		get_client_name(client_p, SHOW_IP));
907
908		/* Opers get a masked IP */
909	<	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
909	>	sendto_realops_flags(UMODE_SERVNOTICE, L_OPER, SEND_NOTICE,
910		"Server %s closed the connection",
911		get_client_name(client_p, MASK_IP));
912
#	Line 969 | Line 921 | dead_link_on_read(struct Client *client_
921		get_client_name(client_p, MASK_IP), current_error);
922		}
923
924	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
925	<	"%s had been connected for %d day%s, %2d:%02d:%02d",
924	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
925	>	"%s was connected for %d day%s, %2d:%02d:%02d",
926		client_p->name, connected/86400,
927		(connected/86400 == 1) ? "" : "s",
928		(connected % 86400) / 3600, (connected % 3600) / 60,
#	Line 1001 | Line 953 | exit_aborted_clients(void)
953
954		if (target_p == NULL)
955		{
956	<	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
956	>	sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
957		"Warning: null client on abort_list!");
958		dlinkDelete(ptr, &abort_list);
959		free_dlink_node(ptr);
#	Line 1010 | Line 962 | exit_aborted_clients(void)
962
963		dlinkDelete(ptr, &abort_list);
964
965	<	if (IsSendQExceeded(target_p))
965	>	if (HasFlag(target_p, FLAGS_SENDQEX))
966		notice = "Max SendQ exceeded";
967		else
968		notice = "Write error: connection closed";
#	Line 1033 | Line 985 | exit_aborted_clients(void)
985		void
986		del_accept(struct split_nuh_item *accept_p, struct Client *client_p)
987		{
988	<	dlinkDelete(&accept_p->node, &client_p->localClient->acceptlist);
988	>	dlinkDelete(&accept_p->node, &client_p->connection->acceptlist);
989
990		MyFree(accept_p->nickptr);
991		MyFree(accept_p->userptr);
#	Line 1046 | Line 998 | find_accept(const char *nick, const char
998		const char *host, struct Client *client_p,
999		int (*cmpfunc)(const char *, const char *))
1000		{
1001	<	dlink_node *ptr = NULL;
1001	>	dlink_node *node = NULL;
1002
1003	<	DLINK_FOREACH(ptr, client_p->localClient->acceptlist.head)
1003	>	DLINK_FOREACH(node, client_p->connection->acceptlist.head)
1004		{
1005	<	struct split_nuh_item *accept_p = ptr->data;
1005	>	struct split_nuh_item *accept_p = node->data;
1006
1007		if (!cmpfunc(accept_p->nickptr, nick) &&
1008		!cmpfunc(accept_p->userptr, user) &&
#	Line 1072 | Line 1024 | int
1024		accept_message(struct Client *source,
1025		struct Client *target)
1026		{
1027	<	dlink_node *ptr = NULL;
1027	>	dlink_node *node = NULL;
1028	>
1029	>	if (HasFlag(source, FLAGS_SERVICE) ||
1030	>	(HasUMode(source, UMODE_OPER) && ConfigGeneral.opers_bypass_callerid))
1031	>	return 1;
1032
1033		if (source == target || find_accept(source->name, source->username,
1034		source->host, target, match))
1035		return 1;
1036
1037	<	if (HasUMode(target, UMODE_SOFTCALLERID))
1038	<	DLINK_FOREACH(ptr, target->channel.head)
1039	<	if (IsMember(source, ((struct Membership *)ptr->data)->chptr))
1037	>	if (!HasUMode(target, UMODE_CALLERID) && HasUMode(target, UMODE_SOFTCALLERID))
1038	>	DLINK_FOREACH(node, target->channel.head)
1039	>	if (IsMember(source, ((struct Membership *)node->data)->chptr))
1040		return 1;
1041
1042		return 0;
#	Line 1095 | Line 1051 | accept_message(struct Client *source,
1051		void
1052		del_all_accepts(struct Client *client_p)
1053		{
1054	<	dlink_node *ptr = NULL, *ptr_next = NULL;
1054	>	dlink_node *node = NULL, *node_next = NULL;
1055
1056	<	DLINK_FOREACH_SAFE(ptr, ptr_next, client_p->localClient->acceptlist.head)
1057	<	del_accept(ptr->data, client_p);
1056	>	DLINK_FOREACH_SAFE(node, node_next, client_p->connection->acceptlist.head)
1057	>	del_accept(node->data, client_p);
1058		}
1059
1060		unsigned int
1061	<	idle_time_get(const struct Client *source_p, const struct Client *target_p)
1061	>	client_get_idle_time(const struct Client *source_p,
1062	>	const struct Client *target_p)
1063		{
1064		unsigned int idle = 0;
1065		unsigned int min_idle = 0;
1066		unsigned int max_idle = 0;
1067	<	const struct ClassItem *class = get_class_ptr(&target_p->localClient->confs);
1067	>	const struct ClassItem *const class = get_class_ptr(&target_p->connection->confs);
1068
1069		if (!(class->flags & CLASS_FLAGS_FAKE_IDLE) || target_p == source_p)
1070	<	return CurrentTime - target_p->localClient->last_privmsg;
1070	>	return CurrentTime - target_p->connection->last_privmsg;
1071	>
1072		if (HasUMode(source_p, UMODE_OPER) &&
1073		!(class->flags & CLASS_FLAGS_HIDE_IDLE_FROM_OPERS))
1074	<	return CurrentTime - target_p->localClient->last_privmsg;
1074	>	return CurrentTime - target_p->connection->last_privmsg;
1075
1076		min_idle = class->min_idle;
1077		max_idle = class->max_idle;
#	Line 1124 | Line 1082 | idle_time_get(const struct Client *sourc
1082		if (class->flags & CLASS_FLAGS_RANDOM_IDLE)
1083		idle = genrand_int32();
1084		else
1085	<	idle = CurrentTime - target_p->localClient->last_privmsg;
1085	>	idle = CurrentTime - target_p->connection->last_privmsg;
1086
1087		if (!max_idle)
1088		idle = 0;
#	Line 1136 | Line 1094 | idle_time_get(const struct Client *sourc
1094
1095		return idle;
1096		}
1097	+
1098	+	/* client_init()
1099	+	*
1100	+	* inputs       - NONE
1101	+	* output       - NONE
1102	+	* side effects - initialize client free memory
1103	+	*/
1104	+	void
1105	+	client_init(void)
1106	+	{
1107	+	static struct event event_ping =
1108	+	{
1109	+	.name = "check_pings",
1110	+	.handler = check_pings,
1111	+	.when = 5
1112	+	};
1113	+
1114	+	client_pool = mp_pool_new(sizeof(struct Client), MP_CHUNK_SIZE_CLIENT);
1115	+	connection_pool = mp_pool_new(sizeof(struct Connection), MP_CHUNK_SIZE_CONNECTION);
1116	+	event_add(&event_ping, NULL);
1117	+	}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines (old)
>	Changed lines (new)