ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/client.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/client.c (file contents):
Revision 1644 by michael, Tue Nov 6 22:20:16 2012 UTC vs.
Revision 5980 by michael, Mon May 25 14:24:26 2015 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  client.c: Controls clients.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2015 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 16 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file client.c
23 > * \brief Controls clients.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29   #include "client.h"
28 #include "channel_mode.h"
30   #include "event.h"
30 #include "fdlist.h"
31   #include "hash.h"
32   #include "irc_string.h"
33   #include "ircd.h"
34 #include "s_gline.h"
34   #include "numeric.h"
35 < #include "packet.h"
37 < #include "s_auth.h"
35 > #include "auth.h"
36   #include "s_bsd.h"
37   #include "conf.h"
38   #include "log.h"
39 < #include "s_misc.h"
40 < #include "s_serv.h"
39 > #include "misc.h"
40 > #include "server.h"
41   #include "send.h"
42   #include "whowas.h"
43 < #include "s_user.h"
46 < #include "dbuf.h"
43 > #include "user.h"
44   #include "memory.h"
45 + #include "mempool.h"
46   #include "hostmask.h"
49 #include "balloc.h"
47   #include "listener.h"
51 #include "irc_res.h"
48   #include "userhost.h"
49   #include "watch.h"
50 + #include "rng_mt.h"
51 + #include "parse.h"
52 + #include "ipcache.h"
53  
55 dlink_list listing_client_list = { NULL, NULL, 0 };
56 /* Pointer to beginning of Client list */
57 dlink_list global_client_list = {NULL, NULL, 0};
58 /* unknown/client pointer lists */
59 dlink_list unknown_list = {NULL, NULL, 0};
60 dlink_list local_client_list = {NULL, NULL, 0};
61 dlink_list serv_list = {NULL, NULL, 0};
62 dlink_list global_serv_list = {NULL, NULL, 0};
63 dlink_list oper_list = {NULL, NULL, 0};
64
65 static EVH check_pings;
54  
55 < static BlockHeap *client_heap  = NULL;
56 < static BlockHeap *lclient_heap = NULL;
57 <
58 < static dlink_list dead_list  = { NULL, NULL, 0};
59 < static dlink_list abort_list = { NULL, NULL, 0};
55 > dlink_list listing_client_list;
56 > dlink_list unknown_list;
57 > dlink_list local_client_list;
58 > dlink_list local_server_list;
59 > dlink_list global_client_list;
60 > dlink_list global_server_list;
61 > dlink_list oper_list;
62  
63 + static mp_pool_t *client_pool, *connection_pool;
64 + static dlink_list dead_list, abort_list;
65   static dlink_node *eac_next;  /* next aborted client to exit */
66  
75 static void check_pings_list(dlink_list *);
76 static void check_unknowns_list(void);
77 static void ban_them(struct Client *, struct MaskItem *);
78
79
80 /* init_client()
81 *
82 * inputs       - NONE
83 * output       - NONE
84 * side effects - initialize client free memory
85 */
86 void
87 init_client(void)
88 {
89  /* start off the check ping event ..  -- adrian
90   * Every 30 seconds is plenty -- db
91   */
92  client_heap = BlockHeapCreate("client", sizeof(struct Client), CLIENT_HEAP_SIZE);
93  lclient_heap = BlockHeapCreate("local client", sizeof(struct LocalUser), LCLIENT_HEAP_SIZE);
94  eventAdd("check_pings", check_pings, NULL, 5);
95 }
67  
68   /*
69   * make_client - create a new Client struct and set it to initial state.
# Line 112 | Line 83 | init_client(void)
83   struct Client *
84   make_client(struct Client *from)
85   {
86 <  struct Client *client_p = BlockHeapAlloc(client_heap);
86 >  struct Client *const client_p = mp_pool_get(client_pool);
87  
88 <  if (from == NULL)
88 >  if (!from)
89    {
90 <    client_p->from                      = client_p; /* 'from' of local client is self! */
91 <    client_p->localClient               = BlockHeapAlloc(lclient_heap);
92 <    client_p->localClient->since        = CurrentTime;
93 <    client_p->localClient->lasttime     = CurrentTime;
94 <    client_p->localClient->firsttime    = CurrentTime;
95 <    client_p->localClient->registration = REG_INIT;
90 >    client_p->from = client_p;  /* 'from' of local client is self! */
91 >    client_p->connection = mp_pool_get(connection_pool);
92 >    client_p->connection->since = CurrentTime;
93 >    client_p->connection->lasttime = CurrentTime;
94 >    client_p->connection->firsttime = CurrentTime;
95 >    client_p->connection->registration = REG_INIT;
96  
97      /* as good a place as any... */
98 <    dlinkAdd(client_p, &client_p->localClient->lclient_node, &unknown_list);
98 >    dlinkAdd(client_p, &client_p->connection->lclient_node, &unknown_list);
99    }
100    else
101 <    client_p->from = from; /* 'from' of local client is self! */
101 >    client_p->from = from;
102  
103    client_p->idhnext = client_p;
104 <  client_p->hnext  = client_p;
105 <  client_p->status = STAT_UNKNOWN;
104 >  client_p->hnext = client_p;
105 >  SetUnknown(client_p);
106    strcpy(client_p->username, "unknown");
107 <  strcpy(client_p->svid, "0");
107 >  strcpy(client_p->account, "*");
108  
109    return client_p;
110   }
# Line 148 | Line 119 | make_client(struct Client *from)
119   static void
120   free_client(struct Client *client_p)
121   {
151  assert(client_p != NULL);
122    assert(client_p != &me);
123    assert(client_p->hnext == client_p);
124    assert(client_p->idhnext == client_p);
125    assert(client_p->channel.head == NULL);
126    assert(dlink_list_length(&client_p->channel) == 0);
127    assert(dlink_list_length(&client_p->whowas) == 0);
128 <  assert(!IsServer(client_p) || IsServer(client_p) && client_p->serv);
128 >  assert(dlink_list_length(&client_p->svstags) == 0);
129  
130    MyFree(client_p->serv);
131 +  MyFree(client_p->certfp);
132  
133    if (MyConnect(client_p))
134    {
135 <    assert(client_p->localClient->invited.head == NULL);
136 <    assert(dlink_list_length(&client_p->localClient->invited) == 0);
137 <    assert(dlink_list_length(&client_p->localClient->watches) == 0);
135 >    assert(client_p->connection->invited.head == NULL);
136 >    assert(dlink_list_length(&client_p->connection->invited) == 0);
137 >    assert(dlink_list_length(&client_p->connection->watches) == 0);
138      assert(IsClosing(client_p) && IsDead(client_p));
139  
140 <    MyFree(client_p->localClient->response);
141 <    MyFree(client_p->localClient->auth_oper);
140 >    MyFree(client_p->connection->challenge_response);
141 >    client_p->connection->challenge_response = NULL;
142 >    MyFree(client_p->connection->challenge_operator);
143 >    client_p->connection->challenge_operator = NULL;
144  
145      /*
146 <     * clean up extra sockets from P-lines which have been discarded.
146 >     * Clean up extra sockets from listen {} blocks which have been discarded.
147       */
148 <    if (client_p->localClient->listener)
148 >    if (client_p->connection->listener)
149      {
150 <      assert(0 < client_p->localClient->listener->ref_count);
151 <      if (0 == --client_p->localClient->listener->ref_count &&
179 <          !client_p->localClient->listener->active)
180 <        free_listener(client_p->localClient->listener);
150 >      listener_release(client_p->connection->listener);
151 >      client_p->connection->listener = NULL;
152      }
153  
154 <    dbuf_clear(&client_p->localClient->buf_recvq);
155 <    dbuf_clear(&client_p->localClient->buf_sendq);
154 >    dbuf_clear(&client_p->connection->buf_recvq);
155 >    dbuf_clear(&client_p->connection->buf_sendq);
156  
157 <    BlockHeapFree(lclient_heap, client_p->localClient);
157 >    mp_pool_release(client_p->connection);
158    }
159  
160 <  BlockHeapFree(client_heap, client_p);
160 >  mp_pool_release(client_p);
161   }
162  
163 < /*
164 < * check_pings - go through the local client list and check activity
165 < * kill off stuff that should die
166 < *
167 < * inputs       - NOT USED (from event)
168 < * output       - next time_t when check_pings() should be called again
198 < * side effects -
199 < *
200 < *
201 < * A PING can be sent to clients as necessary.
202 < *
203 < * Client/Server ping outs are handled.
204 < */
163 > void
164 > client_attach_svstag(struct Client *client_p, unsigned int numeric,
165 >                     const char *umodes, const char *const tag)
166 > {
167 >  struct ServicesTag *svstag = NULL;
168 >  const struct user_modes *tab = NULL;
169  
170 < /*
171 < * Addon from adrian. We used to call this after nextping seconds,
208 < * however I've changed it to run once a second. This is only for
209 < * PING timeouts, not K/etc-line checks (thanks dianora!). Having it
210 < * run once a second makes life a lot easier - when a new client connects
211 < * and they need a ping in 4 seconds, if nextping was set to 20 seconds
212 < * we end up waiting 20 seconds. This is stupid. :-)
213 < * I will optimise (hah!) check_pings() once I've finished working on
214 < * tidying up other network IO evilnesses.
215 < *     -- adrian
216 < */
170 >  if (numeric >= ERR_LAST_ERR_MSG || *umodes != '+')
171 >    return;
172  
173 < static void
174 < check_pings(void *notused)
175 < {              
176 <  check_pings_list(&local_client_list);
177 <  check_pings_list(&serv_list);
178 <  check_unknowns_list();
173 >  svstag = MyCalloc(sizeof(*svstag));
174 >  svstag->numeric = numeric;
175 >  svstag->tag = xstrdup(tag);
176 >
177 >  for (const char *m = umodes + 1; *m; ++m)
178 >    if ((tab = umode_map[(unsigned char)*m]))
179 >      svstag->umodes |= tab->flag;
180 >
181 >  if (numeric != RPL_WHOISOPERATOR)
182 >    dlinkAddTail(svstag, &svstag->node, &client_p->svstags);
183 >  else
184 >    dlinkAdd(svstag, &svstag->node, &client_p->svstags);
185 > }
186 >
187 > void
188 > client_clear_svstags(struct Client *client_p)
189 > {
190 >  dlink_node *node = NULL, *node_next = NULL;
191 >
192 >  DLINK_FOREACH_SAFE(node, node_next, client_p->svstags.head)
193 >  {
194 >    struct ServicesTag *svstag = node->data;
195 >
196 >    dlinkDelete(&svstag->node, &client_p->svstags);
197 >    MyFree(svstag->tag);
198 >    MyFree(svstag);
199 >  }
200   }
201  
202   /* check_pings_list()
203   *
204   * inputs       - pointer to list to check
205   * output       - NONE
206 < * side effects -
206 > * side effects -
207   */
208   static void
209   check_pings_list(dlink_list *list)
210   {
211 <  char scratch[32];        /* way too generous but... */
211 >  char buf[IRCD_BUFSIZE] = "";
212    int ping = 0;      /* ping time value from client */
213 <  dlink_node *ptr = NULL, *next_ptr = NULL;
213 >  dlink_node *node = NULL, *node_next = NULL;
214  
215 <  DLINK_FOREACH_SAFE(ptr, next_ptr, list->head)
215 >  DLINK_FOREACH_SAFE(node, node_next, list->head)
216    {
217 <    struct Client *client_p = ptr->data;
217 >    struct Client *client_p = node->data;
218  
243    /*
244    ** Note: No need to notify opers here. It's
245    ** already done when "FLAGS_DEADSOCKET" is set.
246    */
219      if (IsDead(client_p))
220 <    {
249 <      /* Ignore it, its been exited already */
250 <      continue;
251 <    }
220 >      continue;  /* Ignore it, its been exited already */
221  
222      if (!IsRegistered(client_p))
223        ping = CONNECTTIMEOUT;
224      else
225 <      ping = get_client_ping(&client_p->localClient->confs);
225 >      ping = get_client_ping(&client_p->connection->confs);
226  
227 <    if (ping < CurrentTime - client_p->localClient->lasttime)
227 >    if (ping < CurrentTime - client_p->connection->lasttime)
228      {
229        if (!IsPingSent(client_p))
230        {
231 <        /*
232 <         * if we havent PINGed the connection and we havent
233 <         * heard from it in a while, PING it to make sure
234 <         * it is still alive.
235 <         */
236 <        SetPingSent(client_p);
237 <        client_p->localClient->lasttime = CurrentTime - ping;
238 <        sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
231 >        /*
232 >         * If we haven't PINGed the connection and we haven't
233 >         * heard from it in a while, PING it to make sure
234 >         * it is still alive.
235 >         */
236 >        SetPingSent(client_p);
237 >        client_p->connection->lasttime = CurrentTime - ping;
238 >        sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
239        }
240        else
241        {
242 <        if (CurrentTime - client_p->localClient->lasttime >= 2 * ping)
242 >        if (CurrentTime - client_p->connection->lasttime >= 2 * ping)
243          {
244            /*
245             * If the client/server hasn't talked to us in 2*ping seconds
246             * and it has a ping time, then close its connection.
247             */
248            if (IsServer(client_p) || IsHandshake(client_p))
249 <          {
250 <            sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
251 <                                 "No response from %s, closing link",
252 <                                 get_client_name(client_p, HIDE_IP));
253 <            sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
254 <                                 "No response from %s, closing link",
255 <                                 get_client_name(client_p, MASK_IP));
256 <            ilog(LOG_TYPE_IRCD, "No response from %s, closing link",
257 <                 get_client_name(client_p, HIDE_IP));
258 <          }
259 <
260 <          snprintf(scratch, sizeof(scratch), "Ping timeout: %d seconds",
261 <                   (int)(CurrentTime - client_p->localClient->lasttime));
262 <          exit_client(client_p, &me, scratch);
249 >          {
250 >            sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
251 >                                 "No response from %s, closing link",
252 >                                 get_client_name(client_p, HIDE_IP));
253 >            sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
254 >                                 "No response from %s, closing link",
255 >                                 get_client_name(client_p, MASK_IP));
256 >            ilog(LOG_TYPE_IRCD, "No response from %s, closing link",
257 >                 get_client_name(client_p, HIDE_IP));
258 >          }
259 >
260 >          snprintf(buf, sizeof(buf), "Ping timeout: %d seconds",
261 >                   (int)(CurrentTime - client_p->connection->lasttime));
262 >          exit_client(client_p, buf);
263          }
264        }
265      }
# Line 306 | Line 275 | check_pings_list(dlink_list *list)
275   static void
276   check_unknowns_list(void)
277   {
278 <  dlink_node *ptr, *next_ptr;
278 >  dlink_node *node = NULL, *node_next = NULL;
279  
280 <  DLINK_FOREACH_SAFE(ptr, next_ptr, unknown_list.head)
280 >  DLINK_FOREACH_SAFE(node, node_next, unknown_list.head)
281    {
282 <    struct Client *client_p = ptr->data;
282 >    struct Client *client_p = node->data;
283  
284      /*
285       * Check UNKNOWN connections - if they have been in this state
286       * for > 30s, close them.
287       */
288 <    if (IsAuthFinished(client_p) && (CurrentTime - client_p->localClient->firsttime) > 30)
289 <      exit_client(client_p, &me, "Registration timed out");
288 >    if (IsAuthFinished(client_p) && (CurrentTime - client_p->connection->firsttime) > 30)
289 >      exit_client(client_p, "Registration timed out");
290    }
291   }
292  
293 + /*
294 + * check_pings - go through the local client list and check activity
295 + * kill off stuff that should die
296 + *
297 + * inputs       - NOT USED (from event)
298 + * output       - next time_t when check_pings() should be called again
299 + * side effects -
300 + *
301 + *
302 + * A PING can be sent to clients as necessary.
303 + *
304 + * Client/Server ping outs are handled.
305 + */
306 +
307 + /*
308 + * Addon from adrian. We used to call this after nextping seconds,
309 + * however I've changed it to run once a second. This is only for
310 + * PING timeouts, not K/etc-line checks (thanks dianora!). Having it
311 + * run once a second makes life a lot easier - when a new client connects
312 + * and they need a ping in 4 seconds, if nextping was set to 20 seconds
313 + * we end up waiting 20 seconds. This is stupid. :-)
314 + * I will optimise (hah!) check_pings() once I've finished working on
315 + * tidying up other network IO evilnesses.
316 + *     -- adrian
317 + */
318 +
319 + static void
320 + check_pings(void *unused)
321 + {
322 +  check_pings_list(&local_client_list);
323 +  check_pings_list(&local_server_list);
324 +  check_unknowns_list();
325 + }
326 +
327   /* check_conf_klines()
328   *
329   * inputs       - NONE
# Line 328 | Line 331 | check_unknowns_list(void)
331   * side effects - Check all connections for a pending kline against the
332   *                client, exit the client if a kline matches.
333   */
334 < void
334 > void
335   check_conf_klines(void)
336 < {              
334 <  struct Client *client_p = NULL;       /* current local client_p being examined */
336 > {
337    struct MaskItem *conf = NULL;
338 <  dlink_node *ptr, *next_ptr;
338 >  dlink_node *node = NULL, *node_next = NULL;
339  
340 <  DLINK_FOREACH_SAFE(ptr, next_ptr, local_client_list.head)
340 >  DLINK_FOREACH_SAFE(node, node_next, local_client_list.head)
341    {
342 <    client_p = ptr->data;
342 >    struct Client *client_p = node->data;
343  
344 <    /* If a client is already being exited
345 <     */
344 <    if (IsDead(client_p) || !IsClient(client_p))
344 >    /* If a client is already being exited */
345 >    if (IsDead(client_p))
346        continue;
347  
348 <    if ((conf = find_dline_conf(&client_p->localClient->ip,
349 <                                  client_p->localClient->aftype)) != NULL)
348 >    if ((conf = find_conf_by_address(NULL, &client_p->connection->ip, CONF_DLINE,
349 >                                     client_p->connection->aftype, NULL, NULL, 1)))
350      {
351 <      if (conf->type == CONF_EXEMPT)
352 <        continue;
352 <
353 <      ban_them(client_p, conf);
354 <      continue; /* and go examine next fd/client_p */
351 >      conf_try_ban(client_p, conf);
352 >      continue;  /* and go examine next Client */
353      }
354  
355 <    if (ConfigFileEntry.glines && (conf = find_gline(client_p)))
356 <    {
357 <      if (IsExemptKline(client_p) ||
360 <          IsExemptGline(client_p))
361 <      {
362 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
363 <                             "GLINE over-ruled for %s, client is %sline_exempt",
364 <                             get_client_name(client_p, HIDE_IP), IsExemptKline(client_p) ? "k" : "g");
365 <        continue;
366 <      }
367 <
368 <      ban_them(client_p, conf);
369 <      /* and go examine next fd/client_p */    
370 <      continue;
371 <    }
372 <
373 <    if ((conf = find_kill(client_p)) != NULL)
355 >    if ((conf = find_conf_by_address(client_p->host, &client_p->connection->ip,
356 >                                     CONF_KLINE, client_p->connection->aftype,
357 >                                     client_p->username, NULL, 1)))
358      {
359 <      if (IsExemptKline(client_p))
360 <      {
377 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
378 <                             "KLINE over-ruled for %s, client is kline_exempt",
379 <                             get_client_name(client_p, HIDE_IP));
380 <        continue;
381 <      }
382 <
383 <      ban_them(client_p, conf);
384 <      continue;
359 >      conf_try_ban(client_p, conf);
360 >      continue;  /* and go examine next Client */
361      }
362  
363 <    if ((conf = find_matching_name_conf(CONF_XLINE,  client_p->info,
364 <                                        NULL, NULL, 0)) != NULL ||
389 <        (conf = find_matching_name_conf(CONF_RXLINE, client_p->info,
390 <                                        NULL, NULL, 0)) != NULL)
363 >    if ((conf = find_matching_name_conf(CONF_XLINE, client_p->info,
364 >                                        NULL, NULL, 0)))
365      {
366 <      ban_them(client_p, conf);
367 <      continue;
366 >      conf_try_ban(client_p, conf);
367 >      continue;  /* and go examine next Client */
368      }
369    }
370  
371 <  /* also check the unknowns list for new dlines */
372 <  DLINK_FOREACH_SAFE(ptr, next_ptr, unknown_list.head)
371 >  /* Also check the unknowns list for new dlines */
372 >  DLINK_FOREACH_SAFE(node, node_next, unknown_list.head)
373    {
374 <    client_p = ptr->data;
374 >    struct Client *client_p = node->data;
375  
376 <    if ((conf = find_dline_conf(&client_p->localClient->ip,
377 <                                 client_p->localClient->aftype)))
376 >    if ((conf = find_conf_by_address(NULL, &client_p->connection->ip, CONF_DLINE,
377 >                                     client_p->connection->aftype, NULL, NULL, 1)))
378      {
379 <      if (conf->type == CONF_EXEMPT)
380 <        continue;
407 <
408 <      exit_client(client_p, &me, "D-lined");
379 >      conf_try_ban(client_p, conf);
380 >      continue;  /* and go examine next Client */
381      }
382    }
383   }
384  
385   /*
386 < * ban_them
386 > * conf_try_ban
387   *
388   * inputs       - pointer to client to ban
389   *              - pointer to MaskItem
390   * output       - NONE
391   * side effects - given client_p is banned
392   */
393 < static void
394 < ban_them(struct Client *client_p, struct MaskItem *conf)
393 > void
394 > conf_try_ban(struct Client *client_p, struct MaskItem *conf)
395   {
396 <  const char *user_reason = NULL;       /* What is sent to user */
425 <  const char *type_string = NULL;
426 <  const char dline_string[] = "D-line";
427 <  const char kline_string[] = "K-line";
428 <  const char gline_string[] = "G-line";
429 <  const char xline_string[] = "X-line";
396 >  char ban_type = '\0';
397  
398    switch (conf->type)
399    {
433    case CONF_RKLINE:
400      case CONF_KLINE:
401 <      type_string = kline_string;
401 >      if (IsExemptKline(client_p))
402 >      {
403 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
404 >                             "KLINE over-ruled for %s, client is kline_exempt",
405 >                             get_client_name(client_p, HIDE_IP));
406 >        return;
407 >      }
408 >
409 >      ban_type = 'K';
410        break;
411      case CONF_DLINE:
412 <      type_string = dline_string;
413 <      break;
414 <    case CONF_GLINE:
415 <      type_string = gline_string;
412 >      if (find_conf_by_address(NULL, &client_p->connection->ip, CONF_EXEMPT,
413 >                               client_p->connection->aftype, NULL, NULL, 1))
414 >        return;
415 >      ban_type = 'D';
416        break;
443    case CONF_RXLINE:
417      case CONF_XLINE:
418 <      type_string = xline_string;
418 >      ban_type = 'X';
419        ++conf->count;
420        break;
421      default:
# Line 450 | Line 423 | ban_them(struct Client *client_p, struct
423        break;
424    }
425  
426 <  user_reason = conf->reason ? conf->reason : type_string;
427 <
455 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s active for %s",
456 <                       type_string, get_client_name(client_p, HIDE_IP));
426 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%c-line active for %s",
427 >                       ban_type, get_client_name(client_p, HIDE_IP));
428  
429    if (IsClient(client_p))
430 <    sendto_one(client_p, form_str(ERR_YOUREBANNEDCREEP),
460 <               me.name, client_p->name, user_reason);
430 >    sendto_one_numeric(client_p, &me, ERR_YOUREBANNEDCREEP, conf->reason);
431  
432 <  exit_client(client_p, &me, user_reason);
432 >  exit_client(client_p, conf->reason);
433   }
434  
435   /* update_client_exit_stats()
436   *
437   * input        - pointer to client
438   * output       - NONE
439 < * side effects -
439 > * side effects -
440   */
441   static void
442   update_client_exit_stats(struct Client *client_p)
# Line 474 | Line 444 | update_client_exit_stats(struct Client *
444    if (IsClient(client_p))
445    {
446      assert(Count.total > 0);
447 +
448      --Count.total;
449      if (HasUMode(client_p, UMODE_OPER))
450        --Count.oper;
# Line 496 | Line 467 | update_client_exit_stats(struct Client *
467   * side effects - find person by (nick)name
468   */
469   struct Client *
470 < find_person(const struct Client *client_p, const char *name)
470 > find_person(const struct Client *const source_p, const char *name)
471   {
472 <  struct Client *c2ptr = NULL;
472 >  struct Client *target_p = NULL;
473  
474    if (IsDigit(*name))
475    {
476 <    if ((c2ptr = hash_find_id(name)) != NULL)
477 <    {
507 <      /* invisible users shall not be found by UID guessing */
508 <      if (HasUMode(c2ptr, UMODE_INVISIBLE))
509 <        if (!IsServer(client_p) && !HasFlag(client_p, FLAGS_SERVICE))
510 <          c2ptr = NULL;
511 <    }
476 >    if (IsServer(source_p->from))
477 >      target_p = hash_find_id(name);
478    }
479    else
480 <    c2ptr = hash_find_client(name);
480 >    target_p = hash_find_client(name);
481  
482 <  return ((c2ptr != NULL && IsClient(c2ptr)) ? c2ptr : NULL);
482 >  return (target_p && IsClient(target_p)) ? target_p : NULL;
483   }
484  
485   /*
486 < * find_chasing - find the client structure for a nick name (user)
487 < *      using history mechanism if necessary. If the client is not found,
488 < *      an error message (NO SUCH NICK) is generated. If the client was found
523 < *      through the history, chasing will be 1 and otherwise 0.
486 > * find_chasing - find the client structure for a nick name (name)
487 > *      using history mechanism if necessary. If the client is not found,
488 > *      an error message (NO SUCH NICK) is generated.
489   */
490   struct Client *
491 < find_chasing(struct Client *client_p, struct Client *source_p, const char *user, int *chasing)
491 > find_chasing(struct Client *source_p, const char *name)
492   {
493 <  struct Client *who = find_person(client_p, user);
529 <
530 <  if (chasing)
531 <    *chasing = 0;
493 >  struct Client *target_p = find_person(source_p, name);
494  
495 <  if (who)
496 <    return who;
495 >  if (target_p)
496 >    return target_p;
497  
498 <  if (IsDigit(*user))
498 >  if (IsDigit(*name))
499      return NULL;
500  
501 <  if ((who = get_history(user,
502 <                        (time_t)ConfigFileEntry.kill_chase_time_limit))
503 <                         == NULL)
501 >  target_p = whowas_get_history(name, (time_t)ConfigGeneral.kill_chase_time_limit);
502 >
503 >  if (!target_p)
504    {
505 <    sendto_one(source_p, form_str(ERR_NOSUCHNICK),
544 <               me.name, source_p->name, user);
505 >    sendto_one_numeric(source_p, &me, ERR_NOSUCHNICK, name);
506      return NULL;
507    }
508  
509 <  if (chasing)
549 <    *chasing = 1;
550 <
551 <  return who;
509 >  return target_p;
510   }
511  
512   /*
# Line 560 | Line 518 | find_chasing(struct Client *client_p, st
518   *        But, this can be used to any client structure.
519   *
520   * NOTE 1:
521 < *        Watch out the allocation of "nbuf", if either source_p->name
521 > *        Watch out the allocation of "buf", if either source_p->name
522   *        or source_p->sockhost gets changed into pointers instead of
523   *        directly allocated within the structure...
524   *
525   * NOTE 2:
526   *        Function return either a pointer to the structure (source_p) or
527 < *        to internal buffer (nbuf). *NEVER* use the returned pointer
527 > *        to internal buffer (buf). *NEVER* use the returned pointer
528   *        to modify what it points!!!
529   */
530   const char *
531 < get_client_name(const struct Client *client, enum addr_mask_type type)
531 > get_client_name(const struct Client *client_p, enum addr_mask_type type)
532   {
533 <  static char nbuf[HOSTLEN * 2 + USERLEN + 5];
533 >  static char buf[HOSTLEN * 2 + USERLEN + 5];
534  
535 <  assert(client != NULL);
535 >  if (!MyConnect(client_p))
536 >    return client_p->name;
537  
538 <  if (!MyConnect(client))
580 <    return client->name;
581 <
582 <  if (IsServer(client) || IsConnecting(client) || IsHandshake(client))
538 >  if (IsServer(client_p) || IsConnecting(client_p) || IsHandshake(client_p))
539    {
540 <    if (!irccmp(client->name, client->host))
541 <      return client->name;
540 >    if (!irccmp(client_p->name, client_p->host))
541 >      return client_p->name;
542      else if (ConfigServerHide.hide_server_ips)
543        type = MASK_IP;
544    }
545  
590  if (ConfigFileEntry.hide_spoof_ips)
591    if (type == SHOW_IP && IsIPSpoof(client))
592      type = MASK_IP;
593
546    /* And finally, let's get the host information, ip or name */
547    switch (type)
548    {
549      case SHOW_IP:
550 <      snprintf(nbuf, sizeof(nbuf), "%s[%s@%s]",
551 <               client->name,
552 <               client->username, client->sockhost);
550 >      snprintf(buf, sizeof(buf), "%s[%s@%s]",
551 >               client_p->name,
552 >               client_p->username, client_p->sockhost);
553        break;
554      case MASK_IP:
555 <      if (client->localClient->aftype == AF_INET)
556 <        snprintf(nbuf, sizeof(nbuf), "%s[%s@255.255.255.255]",
557 <                 client->name, client->username);
555 >      if (client_p->connection->aftype == AF_INET)
556 >        snprintf(buf, sizeof(buf), "%s[%s@255.255.255.255]",
557 >                 client_p->name, client_p->username);
558        else
559 <        snprintf(nbuf, sizeof(nbuf), "%s[%s@ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]",
560 <                 client->name, client->username);
559 >        snprintf(buf, sizeof(buf), "%s[%s@ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]",
560 >                 client_p->name, client_p->username);
561        break;
562      default:
563 <      snprintf(nbuf, sizeof(nbuf), "%s[%s@%s]",
564 <               client->name,
565 <               client->username, client->host);
563 >      snprintf(buf, sizeof(buf), "%s[%s@%s]",
564 >               client_p->name,
565 >               client_p->username, client_p->host);
566    }
567  
568 <  return nbuf;
568 >  return buf;
569   }
570  
571   void
572   free_exited_clients(void)
573   {
574 <  dlink_node *ptr = NULL, *next = NULL;
575 <  
576 <  DLINK_FOREACH_SAFE(ptr, next, dead_list.head)
574 >  dlink_node *node = NULL, *node_next = NULL;
575 >
576 >  DLINK_FOREACH_SAFE(node, node_next, dead_list.head)
577    {
578 <    free_client(ptr->data);
579 <    dlinkDelete(ptr, &dead_list);
580 <    free_dlink_node(ptr);
578 >    free_client(node->data);
579 >    dlinkDelete(node, &dead_list);
580 >    free_dlink_node(node);
581    }
582   }
583  
# Line 636 | Line 588 | free_exited_clients(void)
588   * The only messages generated are QUITs on channels.
589   */
590   static void
591 < exit_one_client(struct Client *source_p, const char *quitmsg)
591 > exit_one_client(struct Client *source_p, const char *comment)
592   {
593 <  dlink_node *lp = NULL, *next_lp = NULL;
593 >  dlink_node *node = NULL, *node_next = NULL;
594  
595    assert(!IsMe(source_p));
596 +  assert(source_p != &me);
597  
598    if (IsClient(source_p))
599    {
600 <    if (source_p->servptr->serv != NULL)
601 <      dlinkDelete(&source_p->lnode, &source_p->servptr->serv->client_list);
600 >    dlinkDelete(&source_p->lnode, &source_p->servptr->serv->client_list);
601 >    dlinkDelete(&source_p->node, &global_client_list);
602  
603      /*
604       * If a person is on a channel, send a QUIT notice
# Line 653 | Line 606 | exit_one_client(struct Client *source_p,
606       * that the client can show the "**signoff" message).
607       * (Note: The notice is to the local clients *only*)
608       */
609 <    sendto_common_channels_local(source_p, 0, ":%s!%s@%s QUIT :%s",
609 >    sendto_common_channels_local(source_p, 0, 0, ":%s!%s@%s QUIT :%s",
610                                   source_p->name, source_p->username,
611 <                                 source_p->host, quitmsg);
612 <    DLINK_FOREACH_SAFE(lp, next_lp, source_p->channel.head)
613 <      remove_user_from_channel(lp->data);
611 >                                 source_p->host, comment);
612 >
613 >    DLINK_FOREACH_SAFE(node, node_next, source_p->channel.head)
614 >      remove_user_from_channel(node->data);
615  
616 <    add_history(source_p, 0);
617 <    off_history(source_p);
616 >    whowas_add_history(source_p, 0);
617 >    whowas_off_history(source_p);
618  
619      watch_check_hash(source_p, RPL_LOGOFF);
620  
621      if (MyConnect(source_p))
622      {
623 <      /* Clean up invitefield */
670 <      DLINK_FOREACH_SAFE(lp, next_lp, source_p->localClient->invited.head)
671 <        del_invite(lp->data, source_p);
672 <
623 >      clear_invites_client(source_p);
624        del_all_accepts(source_p);
625      }
626    }
627    else if (IsServer(source_p))
628    {
629      dlinkDelete(&source_p->lnode, &source_p->servptr->serv->server_list);
630 +    dlinkDelete(&source_p->node, &global_client_list);
631  
632 <    if ((lp = dlinkFindDelete(&global_serv_list, source_p)) != NULL)
633 <      free_dlink_node(lp);
632 >    if ((node = dlinkFindDelete(&global_server_list, source_p)))
633 >      free_dlink_node(node);
634    }
635  
636    /* Remove source_p from the client lists */
637 <  if (HasID(source_p))
637 >  if (source_p->id[0])
638      hash_del_id(source_p);
639 +
640    if (source_p->name[0])
641      hash_del_client(source_p);
642  
643    if (IsUserHostIp(source_p))
644      delete_user_host(source_p->username, source_p->host, !MyConnect(source_p));
645  
693  /* remove from global client list
694   * NOTE: source_p->node.next cannot be NULL if the client is added
695   *       to global_client_list (there is always &me at its end)
696   */
697  if (source_p != NULL && source_p->node.next != NULL)
698    dlinkDelete(&source_p->node, &global_client_list);
699
646    update_client_exit_stats(source_p);
647  
648    /* Check to see if the client isn't already on the dead list */
# Line 707 | Line 653 | exit_one_client(struct Client *source_p,
653    dlinkAdd(source_p, make_dlink_node(), &dead_list);
654   }
655  
656 < /* Recursively send QUITs and SQUITs for source_p and all its dependent clients
711 < * and servers to those servers that need them.  A server needs the client
712 < * QUITs if it can't figure them out from the SQUIT (ie pre-TS4) or if it
713 < * isn't getting the SQUIT because of @#(*&@)# hostmasking.  With TS4, once
714 < * a link gets a SQUIT, it doesn't need any QUIT/SQUITs for clients depending
715 < * on that one -orabidoo
716 < *
717 < * This is now called on each local server -adx
718 < */
719 < static void
720 < recurse_send_quits(struct Client *original_source_p, struct Client *source_p,
721 <                   struct Client *from, struct Client *to, const char *comment,
722 <                   const char *splitstr)
723 < {
724 <  dlink_node *ptr, *next;
725 <  struct Client *target_p;
726 <
727 <  assert(to != source_p);  /* should be already removed from serv_list */
728 <
729 <  /* If this server can handle quit storm (QS) removal
730 <   * of dependents, just send the SQUIT
731 <   */
732 <  if (!IsCapable(to, CAP_QS))
733 <    DLINK_FOREACH_SAFE(ptr, next, source_p->serv->client_list.head)
734 <    {
735 <      target_p = ptr->data;
736 <      sendto_one(to, ":%s QUIT :%s", target_p->name, splitstr);
737 <    }
738 <
739 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->server_list.head)
740 <    recurse_send_quits(original_source_p, ptr->data, from, to,
741 <                       comment, splitstr);
742 <
743 <  if ((source_p == original_source_p && to != from) ||
744 <                  !IsCapable(to, CAP_QS))
745 <  {
746 <    /* don't use a prefix here - we have to be 100% sure the message
747 <     * will be accepted without Unknown prefix etc.. */
748 <    sendto_one(to, "SQUIT %s :%s", ID_or_name(source_p, to), comment);
749 <  }
750 < }
751 <
752 < /*
656 > /*
657   * Remove all clients that depend on source_p; assumes all (S)QUITs have
658 < * already been sent.  we make sure to exit a server's dependent clients
659 < * and servers before the server itself; exit_one_client takes care of
658 > * already been sent.  we make sure to exit a server's dependent clients
659 > * and servers before the server itself; exit_one_client takes care of
660   * actually removing things off llists.   tweaked from +CSr31  -orabidoo
661   */
662   static void
663 < recurse_remove_clients(struct Client *source_p, const char *quitmsg)
663 > recurse_remove_clients(struct Client *source_p, const char *comment)
664   {
665 <  dlink_node *ptr, *next;
665 >  dlink_node *node = NULL, *node_next = NULL;
666  
667 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->client_list.head)
668 <    exit_one_client(ptr->data, quitmsg);
667 >  DLINK_FOREACH_SAFE(node, node_next, source_p->serv->client_list.head)
668 >    exit_one_client(node->data, comment);
669  
670 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->server_list.head)
670 >  DLINK_FOREACH_SAFE(node, node_next, source_p->serv->server_list.head)
671    {
672 <    recurse_remove_clients(ptr->data, quitmsg);
673 <    exit_one_client(ptr->data, quitmsg);
672 >    recurse_remove_clients(node->data, comment);
673 >    exit_one_client(node->data, comment);
674    }
675   }
676  
677   /*
774 ** Remove *everything* that depends on source_p, from all lists, and sending
775 ** all necessary QUITs and SQUITs.  source_p itself is still on the lists,
776 ** and its SQUITs have been sent except for the upstream one  -orabidoo
777 */
778 static void
779 remove_dependents(struct Client *source_p, struct Client *from,
780                  const char *comment, const char *splitstr)
781 {
782  dlink_node *ptr = NULL;
783
784  DLINK_FOREACH(ptr, serv_list.head)
785    recurse_send_quits(source_p, source_p, from, ptr->data,
786                       comment, splitstr);
787
788  recurse_remove_clients(source_p, splitstr);
789 }
790
791 /*
678   * exit_client - exit a client of any type. Generally, you can use
679   * this on any struct Client, regardless of its state.
680   *
681   * Note, you shouldn't exit remote _users_ without first doing
682   * AddFlag(x, FLAGS_KILLED) and propagating a kill or similar message.
683 + *
684   * However, it is perfectly correct to call exit_client to force a _server_
685   * quit (either local or remote one).
686   *
687 + *
688   * inputs:       - a client pointer that is going to be exited
801 *               - for servers, the second argument is a pointer to who
802 *                 is firing the server. This side won't get any generated
803 *                 messages. NEVER NULL!
689   * output:       none
690   * side effects: the client is delinked from all lists, disconnected,
691   *               and the rest of IRC network is notified of the exit.
692   *               Client memory is scheduled to be freed
693   */
694   void
695 < exit_client(struct Client *source_p, struct Client *from, const char *comment)
695 > exit_client(struct Client *source_p, const char *comment)
696   {
697 <  dlink_node *m = NULL;
697 >  dlink_node *node = NULL;
698 >
699 >  assert(!IsMe(source_p));
700 >  assert(source_p != &me);
701  
702    if (MyConnect(source_p))
703    {
# Line 821 | Line 709 | exit_client(struct Client *source_p, str
709  
710      SetClosing(source_p);
711  
712 <    if (IsIpHash(source_p))
825 <      remove_one_ip(&source_p->localClient->ip);
826 <
827 <    if (source_p->localClient->auth)
712 >    if (HasFlag(source_p, FLAGS_IPHASH))
713      {
714 <      delete_auth(source_p->localClient->auth);
715 <      source_p->localClient->auth = NULL;
714 >      DelFlag(source_p, FLAGS_IPHASH);
715 >      ipcache_remove_address(&source_p->connection->ip);
716      }
717  
718 +    delete_auth(&source_p->connection->auth);
719 +
720      /*
721       * This source_p could have status of one of STAT_UNKNOWN, STAT_CONNECTING
722       * STAT_HANDSHAKE or STAT_UNKNOWN
# Line 841 | Line 728 | exit_client(struct Client *source_p, str
728      {
729        assert(dlinkFind(&unknown_list, source_p));
730  
731 <      dlinkDelete(&source_p->localClient->lclient_node, &unknown_list);
731 >      dlinkDelete(&source_p->connection->lclient_node, &unknown_list);
732      }
733      else if (IsClient(source_p))
734      {
735 <      time_t on_for = CurrentTime - source_p->localClient->firsttime;
735 >      time_t on_for = CurrentTime - source_p->connection->firsttime;
736 >
737        assert(Count.local > 0);
738 <      Count.local--;
738 >
739 >      --Count.local;
740  
741        if (HasUMode(source_p, UMODE_OPER))
742 <        if ((m = dlinkFindDelete(&oper_list, source_p)) != NULL)
743 <          free_dlink_node(m);
742 >        if ((node = dlinkFindDelete(&oper_list, source_p)))
743 >          free_dlink_node(node);
744  
745        assert(dlinkFind(&local_client_list, source_p));
746 <      dlinkDelete(&source_p->localClient->lclient_node, &local_client_list);
746 >      dlinkDelete(&source_p->connection->lclient_node, &local_client_list);
747  
748 <      if (source_p->localClient->list_task != NULL)
749 <        free_list_task(source_p->localClient->list_task, source_p);
748 >      if (source_p->connection->list_task)
749 >        free_list_task(source_p);
750  
751        watch_del_watch_list(source_p);
752 +      client_clear_svstags(source_p);
753 +
754        sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
755                             "Client exiting: %s (%s@%s) [%s] [%s]",
756                             source_p->name, source_p->username, source_p->host, comment,
757 <                           ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
758 <                           "255.255.255.255" : source_p->sockhost);
868 <      sendto_realops_flags(UMODE_CCONN_FULL, L_ALL, SEND_NOTICE,
869 <                           "CLIEXIT: %s %s %s %s 0 %s",
870 <                           source_p->name,
871 <                           source_p->username,
872 <                           source_p->host,
873 <                           ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
874 <                           "255.255.255.255" : source_p->sockhost,
875 <                           comment);
757 >                           source_p->sockhost);
758 >
759        ilog(LOG_TYPE_USER, "%s (%3u:%02u:%02u): %s!%s@%s %llu/%llu",
760 <           myctime(source_p->localClient->firsttime), (unsigned int)(on_for / 3600),
760 >           myctime(source_p->connection->firsttime), (unsigned int)(on_for / 3600),
761             (unsigned int)((on_for % 3600)/60), (unsigned int)(on_for % 60),
762             source_p->name, source_p->username, source_p->host,
763 <           source_p->localClient->send.bytes>>10,
764 <           source_p->localClient->recv.bytes>>10);
763 >           source_p->connection->send.bytes>>10,
764 >           source_p->connection->recv.bytes>>10);
765      }
766      else if (IsServer(source_p))
767      {
768        assert(Count.myserver > 0);
769 +
770        --Count.myserver;
771  
772 <      assert(dlinkFind(&serv_list, source_p));
773 <      dlinkDelete(&source_p->localClient->lclient_node, &serv_list);
890 <      unset_chcap_usage_counts(source_p);
772 >      assert(dlinkFind(&local_server_list, source_p));
773 >      dlinkDelete(&source_p->connection->lclient_node, &local_server_list);
774      }
775  
776      if (!IsDead(source_p))
777      {
778        if (IsServer(source_p))
779        {
780 <        /* for them, we are exiting the network */
781 <        sendto_one(source_p, ":%s SQUIT %s :%s",
782 <                   ID_or_name(from, source_p), me.name, comment);
780 >        if (!HasFlag(source_p, FLAGS_SQUIT))
781 >        {
782 >          /* for them, we are exiting the network */
783 >          sendto_one(source_p, ":%s SQUIT %s :%s",
784 >                     me.id, me.id, comment);
785 >        }
786        }
787  
788        sendto_one(source_p, "ERROR :Closing Link: %s (%s)",
789                   source_p->host, comment);
790      }
791  
906    /*
907    ** Currently only server connections can have
908    ** depending remote clients here, but it does no
909    ** harm to check for all local clients. In
910    ** future some other clients than servers might
911    ** have remotes too...
912    **
913    ** Close the Client connection first and mark it
914    ** so that no messages are attempted to send to it.
915    ** Remember it makes source_p->from == NULL.
916    */
792      close_connection(source_p);
793    }
794 +  else if (IsClient(source_p) && HasFlag(source_p->servptr, FLAGS_EOB))
795 +    sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
796 +                         "Client exiting at %s: %s (%s@%s) [%s]",
797 +                         source_p->servptr->name, source_p->name,
798 +                         source_p->username, source_p->host, comment);
799  
800    if (IsServer(source_p))
801    {
802 <    char splitstr[HOSTLEN + HOSTLEN + 2];
802 >    char splitstr[HOSTLEN + HOSTLEN + 2] = "";
803  
804 <    /* This shouldn't ever happen */
805 <    assert(source_p->serv != NULL && source_p->servptr != NULL);
804 >    assert(source_p->serv);
805 >    assert(source_p->servptr);
806  
807      if (ConfigServerHide.hide_servers)
808        /*
809 <       * Set netsplit message to "*.net *.split" to still show
809 >       * Set netsplit message to "*.net *.split" to still show
810         * that its a split, but hide the servers splitting
811         */
812 <      strcpy(splitstr, "*.net *.split");
812 >      strlcpy(splitstr, "*.net *.split", sizeof(splitstr));
813      else
814        snprintf(splitstr, sizeof(splitstr), "%s %s",
815                 source_p->servptr->name, source_p->name);
816  
817 <    remove_dependents(source_p, from->from, comment, splitstr);
817 >    /* Send SQUIT for source_p in every direction. source_p is already off of local_server_list here */
818 >    if (!HasFlag(source_p, FLAGS_SQUIT))
819 >      sendto_server(NULL, 0, 0, "SQUIT %s :%s", source_p->id, comment);
820 >
821 >    /* Now exit the clients internally */
822 >    recurse_remove_clients(source_p, splitstr);
823  
824 <    if (source_p->servptr == &me)
824 >    if (MyConnect(source_p))
825      {
826 +      int connected = CurrentTime - source_p->connection->firsttime;
827        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
828 <                           "%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
829 <                           source_p->name, (int)(CurrentTime - source_p->localClient->firsttime),
830 <                           source_p->localClient->send.bytes >> 10,
831 <                           source_p->localClient->recv.bytes >> 10);
832 <      ilog(LOG_TYPE_IRCD, "%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
833 <           source_p->name, (int)(CurrentTime - source_p->localClient->firsttime),
834 <           source_p->localClient->send.bytes >> 10,
835 <           source_p->localClient->recv.bytes >> 10);
828 >                           "%s was connected for %d day%s, %2d:%02d:%02d. %llu/%llu sendK/recvK.",
829 >                           source_p->name, connected/86400, (connected/86400 == 1) ? "" : "s",
830 >                           (connected % 86400) / 3600, (connected % 3600) / 60, connected % 60,
831 >                           source_p->connection->send.bytes >> 10,
832 >                           source_p->connection->recv.bytes >> 10);
833 >      ilog(LOG_TYPE_IRCD, "%s was connected for %d day%s, %2d:%02d:%02d. %llu/%llu sendK/recvK.",
834 >           source_p->name, connected/86400, (connected/86400 == 1) ? "" : "s",
835 >           (connected % 86400) / 3600, (connected % 3600) / 60, connected % 60,
836 >           source_p->connection->send.bytes >> 10,
837 >           source_p->connection->recv.bytes >> 10);
838      }
839    }
840    else if (IsClient(source_p) && !HasFlag(source_p, FLAGS_KILLED))
841 <  {
842 <    sendto_server(from->from, CAP_TS6, NOCAPS,
955 <                  ":%s QUIT :%s", ID(source_p), comment);
956 <    sendto_server(from->from, NOCAPS, CAP_TS6,
957 <                  ":%s QUIT :%s", source_p->name, comment);
958 <  }
841 >    sendto_server(source_p->from, 0, 0, ":%s QUIT :%s",
842 >                  source_p->id, comment);
843  
844    /* The client *better* be off all of the lists */
845    assert(dlinkFind(&unknown_list, source_p) == NULL);
846    assert(dlinkFind(&local_client_list, source_p) == NULL);
847 <  assert(dlinkFind(&serv_list, source_p) == NULL);
847 >  assert(dlinkFind(&local_server_list, source_p) == NULL);
848    assert(dlinkFind(&oper_list, source_p) == NULL);
849  
850    exit_one_client(source_p, comment);
# Line 973 | Line 857 | exit_client(struct Client *source_p, str
857   void
858   dead_link_on_write(struct Client *client_p, int ierrno)
859   {
860 <  dlink_node *ptr;
860 >  dlink_node *node;
861  
862    if (IsDefunct(client_p))
863      return;
864  
865 <  dbuf_clear(&client_p->localClient->buf_recvq);
866 <  dbuf_clear(&client_p->localClient->buf_sendq);
865 >  dbuf_clear(&client_p->connection->buf_recvq);
866 >  dbuf_clear(&client_p->connection->buf_sendq);
867  
868    assert(dlinkFind(&abort_list, client_p) == NULL);
869 <  ptr = make_dlink_node();
869 >  node = make_dlink_node();
870    /* don't let exit_aborted_clients() finish yet */
871 <  dlinkAddTail(client_p, ptr, &abort_list);
871 >  dlinkAddTail(client_p, node, &abort_list);
872  
873    if (eac_next == NULL)
874 <    eac_next = ptr;
874 >    eac_next = node;
875  
876    SetDead(client_p); /* You are dead my friend */
877   }
# Line 999 | Line 883 | dead_link_on_write(struct Client *client
883   void
884   dead_link_on_read(struct Client *client_p, int error)
885   {
886 <  char errmsg[255];
886 >  char errmsg[IRCD_BUFSIZE];
887    int current_error;
888  
889    if (IsDefunct(client_p))
890      return;
891  
892 <  dbuf_clear(&client_p->localClient->buf_recvq);
893 <  dbuf_clear(&client_p->localClient->buf_sendq);
892 >  dbuf_clear(&client_p->connection->buf_recvq);
893 >  dbuf_clear(&client_p->connection->buf_sendq);
894  
895 <  current_error = get_sockerr(client_p->localClient->fd.fd);
895 >  current_error = get_sockerr(client_p->connection->fd.fd);
896  
897    if (IsServer(client_p) || IsHandshake(client_p))
898    {
899 <    int connected = CurrentTime - client_p->localClient->firsttime;
900 <      
899 >    int connected = CurrentTime - client_p->connection->firsttime;
900 >
901      if (error == 0)
902      {
903        /* Admins get the real IP */
904        sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
905 <                           "Server %s closed the connection",
906 <                           get_client_name(client_p, SHOW_IP));
905 >                           "Server %s closed the connection",
906 >                           get_client_name(client_p, SHOW_IP));
907  
908        /* Opers get a masked IP */
909        sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
910 <                           "Server %s closed the connection",
911 <                           get_client_name(client_p, MASK_IP));
910 >                           "Server %s closed the connection",
911 >                           get_client_name(client_p, MASK_IP));
912  
913        ilog(LOG_TYPE_IRCD, "Server %s closed the connection",
914 <           get_client_name(client_p, SHOW_IP));
914 >           get_client_name(client_p, SHOW_IP));
915      }
916      else
917      {
918        report_error(L_ADMIN, "Lost connection to %s: %s",
919 <                   get_client_name(client_p, SHOW_IP), current_error);
919 >                   get_client_name(client_p, SHOW_IP), current_error);
920        report_error(L_OPER, "Lost connection to %s: %s",
921 <                   get_client_name(client_p, MASK_IP), current_error);
921 >                   get_client_name(client_p, MASK_IP), current_error);
922      }
923  
924      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
925 <                         "%s had been connected for %d day%s, %2d:%02d:%02d",
926 <                         client_p->name, connected/86400,
927 <                         (connected/86400 == 1) ? "" : "s",
928 <                         (connected % 86400) / 3600, (connected % 3600) / 60,
929 <                         connected % 60);
925 >                         "%s was connected for %d day%s, %2d:%02d:%02d",
926 >                         client_p->name, connected/86400,
927 >                         (connected/86400 == 1) ? "" : "s",
928 >                         (connected % 86400) / 3600, (connected % 3600) / 60,
929 >                         connected % 60);
930    }
931  
932    if (error == 0)
# Line 1052 | Line 936 | dead_link_on_read(struct Client *client_
936      snprintf(errmsg, sizeof(errmsg), "Read error: %s",
937               strerror(current_error));
938  
939 <  exit_client(client_p, &me, errmsg);
939 >  exit_client(client_p, errmsg);
940   }
941  
942   void
# Line 1083 | Line 967 | exit_aborted_clients(void)
967      else
968        notice = "Write error: connection closed";
969  
970 <    exit_client(target_p, &me, notice);  
970 >    exit_client(target_p, notice);
971      free_dlink_node(ptr);
972    }
973   }
# Line 1101 | Line 985 | exit_aborted_clients(void)
985   void
986   del_accept(struct split_nuh_item *accept_p, struct Client *client_p)
987   {
988 <  dlinkDelete(&accept_p->node, &client_p->localClient->acceptlist);
988 >  dlinkDelete(&accept_p->node, &client_p->connection->acceptlist);
989  
990    MyFree(accept_p->nickptr);
991    MyFree(accept_p->userptr);
# Line 1111 | Line 995 | del_accept(struct split_nuh_item *accept
995  
996   struct split_nuh_item *
997   find_accept(const char *nick, const char *user,
998 <            const char *host, struct Client *client_p, int do_match)
998 >            const char *host, struct Client *client_p,
999 >            int (*cmpfunc)(const char *, const char *))
1000   {
1001 <  dlink_node *ptr = NULL;
1117 <  /* XXX We wouldn't need that if match() would return 0 on match */
1118 <  int (*cmpfunc)(const char *, const char *) = do_match ? match : irccmp;
1001 >  dlink_node *node = NULL;
1002  
1003 <  DLINK_FOREACH(ptr, client_p->localClient->acceptlist.head)
1003 >  DLINK_FOREACH(node, client_p->connection->acceptlist.head)
1004    {
1005 <    struct split_nuh_item *accept_p = ptr->data;
1005 >    struct split_nuh_item *accept_p = node->data;
1006  
1007 <    if (cmpfunc(accept_p->nickptr, nick) == do_match &&
1008 <        cmpfunc(accept_p->userptr, user) == do_match &&
1009 <        cmpfunc(accept_p->hostptr, host) == do_match)
1007 >    if (!cmpfunc(accept_p->nickptr, nick) &&
1008 >        !cmpfunc(accept_p->userptr, user) &&
1009 >        !cmpfunc(accept_p->hostptr, host))
1010        return accept_p;
1011    }
1012  
# Line 1141 | Line 1024 | int
1024   accept_message(struct Client *source,
1025                 struct Client *target)
1026   {
1027 <  dlink_node *ptr = NULL;
1027 >  dlink_node *node = NULL;
1028 >
1029 >  if (HasFlag(source, FLAGS_SERVICE) ||
1030 >      (HasUMode(source, UMODE_OPER) && ConfigGeneral.opers_bypass_callerid))
1031 >    return 1;
1032  
1033    if (source == target || find_accept(source->name, source->username,
1034 <                                      source->host, target, 1))
1034 >                                      source->host, target, match))
1035      return 1;
1036  
1037 <  if (HasUMode(target, UMODE_SOFTCALLERID))
1038 <    DLINK_FOREACH(ptr, target->channel.head)
1039 <      if (IsMember(source, ((struct Membership *)ptr->data)->chptr))
1037 >  if (!HasUMode(target, UMODE_CALLERID) && HasUMode(target, UMODE_SOFTCALLERID))
1038 >    DLINK_FOREACH(node, target->channel.head)
1039 >      if (IsMember(source, ((struct Membership *)node->data)->chptr))
1040          return 1;
1041  
1042    return 0;
# Line 1164 | Line 1051 | accept_message(struct Client *source,
1051   void
1052   del_all_accepts(struct Client *client_p)
1053   {
1054 <  dlink_node *ptr = NULL, *next_ptr = NULL;
1054 >  dlink_node *node = NULL, *node_next = NULL;
1055 >
1056 >  DLINK_FOREACH_SAFE(node, node_next, client_p->connection->acceptlist.head)
1057 >    del_accept(node->data, client_p);
1058 > }
1059 >
1060 > unsigned int
1061 > client_get_idle_time(const struct Client *source_p,
1062 >                     const struct Client *target_p)
1063 > {
1064 >  unsigned int idle = 0;
1065 >  unsigned int min_idle = 0;
1066 >  unsigned int max_idle = 0;
1067 >  const struct ClassItem *const class = get_class_ptr(&target_p->connection->confs);
1068 >
1069 >  if (!(class->flags & CLASS_FLAGS_FAKE_IDLE) || target_p == source_p)
1070 >    return CurrentTime - target_p->connection->last_privmsg;
1071 >
1072 >  if (HasUMode(source_p, UMODE_OPER) &&
1073 >      !(class->flags & CLASS_FLAGS_HIDE_IDLE_FROM_OPERS))
1074 >    return CurrentTime - target_p->connection->last_privmsg;
1075 >
1076 >  min_idle = class->min_idle;
1077 >  max_idle = class->max_idle;
1078 >
1079 >  if (min_idle == max_idle)
1080 >    return min_idle;
1081 >
1082 >  if (class->flags & CLASS_FLAGS_RANDOM_IDLE)
1083 >    idle = genrand_int32();
1084 >  else
1085 >    idle = CurrentTime - target_p->connection->last_privmsg;
1086  
1087 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->localClient->acceptlist.head)
1088 <    del_accept(ptr->data, client_p);
1087 >  if (!max_idle)
1088 >    idle = 0;
1089 >  else
1090 >    idle %= max_idle;
1091 >
1092 >  if (idle < min_idle)
1093 >    idle = min_idle + (idle % (max_idle - min_idle));
1094 >
1095 >  return idle;
1096 > }
1097 >
1098 > /* client_init()
1099 > *
1100 > * inputs       - NONE
1101 > * output       - NONE
1102 > * side effects - initialize client free memory
1103 > */
1104 > void
1105 > client_init(void)
1106 > {
1107 >  static struct event event_ping =
1108 >  {
1109 >    .name = "check_pings",
1110 >    .handler = check_pings,
1111 >    .when = 5
1112 >  };
1113 >
1114 >  client_pool = mp_pool_new(sizeof(struct Client), MP_CHUNK_SIZE_CLIENT);
1115 >  connection_pool = mp_pool_new(sizeof(struct Connection), MP_CHUNK_SIZE_CONNECTION);
1116 >  event_add(&event_ping, NULL);
1117   }

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)