ViewVC Help

View File | Revision Log | Show Annotations | View Changeset | Root Listing

root/svn/ircd-hybrid/trunk/src/auth.c

Comparing:
ircd-hybrid-7.2/src/s_auth.c (file contents), Revision 998 by michael, Sun Aug 23 12:43:17 2009 UTC vs.
ircd-hybrid/trunk/src/auth.c (file contents), Revision 4854 by michael, Thu Nov 6 17:39:26 2014 UTC

#	Line 1 | Line 1
1		/*
2	<	*  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3	<	*  s_auth.c: Functions for querying a users ident.
2	>	*  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3		*
4	<	*  Copyright (C) 2002 by the past and present ircd coders, and others.
4	>	*  Copyright (c) 1997-2014 ircd-hybrid development team
5		*
6		*  This program is free software; you can redistribute it and/or modify
7		*  it under the terms of the GNU General Public License as published by
#	Line 16 | Line 15
15		*
16		*  You should have received a copy of the GNU General Public License
17		*  along with this program; if not, write to the Free Software
18	<	*  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18	>	*  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19		*  USA
20	<	*
21	<	*  $Id$
20	>	*/
21	>
22	>	/*! \file auth.c
23	>	* \brief Functions for querying a users ident.
24	>	* \version $Id$
25		*/
26
27		/*
#	Line 32 | Line 34
34		*     any messages from it.
35		*     --Bleep  Thomas Helvey <tomh@inxpress.net>
36		*/
37	+
38		#include "stdinc.h"
36	–	#include "tools.h"
39		#include "list.h"
40	<	#include "s_auth.h"
41	<	#include "s_conf.h"
42	<	#include "balloc.h"
40	>	#include "ircd_defs.h"
41	>	#include "fdlist.h"
42	>	#include "auth.h"
43	>	#include "conf.h"
44		#include "client.h"
42	–	#include "common.h"
45		#include "event.h"
44	–	#include "fdlist.h"              /* fdlist_add */
45	–	#include "hook.h"
46		#include "irc_string.h"
47	–	#include "sprintf_irc.h"
47		#include "ircd.h"
49	–	#include "numeric.h"
48		#include "packet.h"
49	<	#include "irc_res.h"
49	>	#include "res.h"
50		#include "s_bsd.h"
51	<	#include "s_log.h"
51	>	#include "log.h"
52		#include "send.h"
53	<	#include "memory.h"
53	>	#include "mempool.h"
54
55	<	static const char *HeaderMessages[] = {
56	<	":%s NOTICE AUTH :*** Looking up your hostname...",
57	<	":%s NOTICE AUTH :*** Found your hostname",
58	<	":%s NOTICE AUTH :*** Couldn't look up your hostname",
59	<	":%s NOTICE AUTH :*** Checking Ident",
60	<	":%s NOTICE AUTH :*** Got Ident response",
61	<	":%s NOTICE AUTH :*** No Ident response",
62	<	":%s NOTICE AUTH :*** Your forward and reverse DNS do not match, ignoring hostname.",
63	<	":%s NOTICE AUTH :*** Your hostname is too long, ignoring hostname"
55	>
56	>	static const char *const HeaderMessages[] =
57	>	{
58	>	":*** Looking up your hostname",
59	>	":*** Found your hostname",
60	>	":*** Couldn't look up your hostname",
61	>	":*** Checking Ident",
62	>	":*** Got Ident response",
63	>	":*** No Ident response",
64	>	":*** Your forward and reverse DNS do not match, ignoring hostname",
65	>	":*** Your hostname is too long, ignoring hostname"
66		};
67
68	<	enum {
68	>	enum
69	>	{
70		REPORT_DO_DNS,
71		REPORT_FIN_DNS,
72		REPORT_FAIL_DNS,
#	Line 76 | Line 77 | enum {
77		REPORT_HOST_TOOLONG
78		};
79
80	<	#define sendheader(c, i) sendto_one((c), HeaderMessages[(i)], me.name)
80	<
81	<	static BlockHeap *auth_heap = NULL;
82	<	static dlink_list auth_doing_list = { NULL, NULL, 0 };
80	>	#define sendheader(c, i) sendto_one_notice((c), &me, HeaderMessages[(i)])
81
82	<	static EVH timeout_auth_queries_event;
82	>	static dlink_list auth_pending_list;
83	>	static void read_auth_reply(fde_t *, void *);
84	>	static void auth_connect_callback(fde_t *, int, void *);
85
86	–	static PF read_auth_reply;
87	–	static CNCB auth_connect_callback;
88	–	static CBFUNC start_auth;
89	–
90	–	struct Callback *auth_cb = NULL;
91	–
92	–	/* init_auth()
93	–	*
94	–	* Initialise the auth code
95	–	*/
96	–	void
97	–	init_auth(void)
98	–	{
99	–	auth_heap = BlockHeapCreate("auth", sizeof(struct AuthRequest), AUTH_HEAP_SIZE);
100	–	auth_cb = register_callback("start_auth", start_auth);
101	–	eventAddIsh("timeout_auth_queries_event", timeout_auth_queries_event, NULL, 1);
102	–	}
86
87		/*
88		* make_auth_request - allocate a new auth request
#	Line 107 | Line 90 | init_auth(void)
90		static struct AuthRequest *
91		make_auth_request(struct Client *client)
92		{
93	<	struct AuthRequest *request = BlockHeapAlloc(auth_heap);
93	>	struct AuthRequest *const request = &client->connection->auth;
94	>
95	>	memset(request, 0, sizeof(*request));
96
97	<	client->localClient->auth = request;
98	<	request->client           = client;
114	<	request->timeout          = CurrentTime + CONNECTTIMEOUT;
97	>	request->client  = client;
98	>	request->timeout = CurrentTime + CONNECTTIMEOUT;
99
100		return request;
101		}
#	Line 124 | Line 108 | make_auth_request(struct Client *client)
108		void
109		release_auth_client(struct AuthRequest *auth)
110		{
111	<	struct Client *client = auth->client;
111	>	struct Client *const client = auth->client;
112
113		if (IsDoingAuth(auth) || IsDNSPending(auth))
114		return;
115
116	<	client->localClient->auth = NULL;
117	<	dlinkDelete(&auth->node, &auth_doing_list);
118	<	BlockHeapFree(auth_heap, auth);
116	>	if (IsInAuth(auth))
117	>	{
118	>	dlinkDelete(&auth->node, &auth_pending_list);
119	>	ClearInAuth(auth);
120	>	}
121
122		/*
123		* When a client has auth'ed, we want to start reading what it sends
124		* us. This is what read_packet() does.
125		*     -- adrian
126		*/
127	<	client->localClient->allow_read = MAX_FLOOD;
128	<	comm_setflush(&client->localClient->fd, 1000, flood_recalc, client);
127	>	client->connection->allow_read = MAX_FLOOD;
128	>	comm_setflush(&client->connection->fd, 1000, flood_recalc, client);
129
130	<	dlinkAdd(client, &client->node, &global_client_list);
131	<
132	<	client->since  = client->lasttime = client->firsttime = CurrentTime;
130	>	client->connection->since     = CurrentTime;
131	>	client->connection->lasttime  = CurrentTime;
132	>	client->connection->firsttime = CurrentTime;
133		client->flags |= FLAGS_FINISHED_AUTH;
134
135	<	read_packet(&client->localClient->fd, client);
135	>	read_packet(&client->connection->fd, client);
136		}
137	<
137	>
138		/*
139		* auth_dns_callback - called when resolver query finishes
140		* if the query resulted in a successful search, name will contain
#	Line 157 | Line 143 | release_auth_client(struct AuthRequest *
143		* of success of failure
144		*/
145		static void
146	<	auth_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
146	>	auth_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name, size_t namelength)
147		{
148	<	struct AuthRequest *auth = vptr;
148	>	struct AuthRequest *const auth = vptr;
149
150		ClearDNSPending(auth);
151
152	<	if (name != NULL)
152	>	if (!EmptyString(name))
153		{
154		const struct sockaddr_in *v4, *v4dns;
169	–	#ifdef IPV6
155		const struct sockaddr_in6 *v6, *v6dns;
171	–	#endif
172	–	int good = 1;
156
157	<	#ifdef IPV6
175	<	if (auth->client->localClient->ip.ss.ss_family == AF_INET6)
157	>	if (auth->client->connection->ip.ss.ss_family == AF_INET6)
158		{
159	<	v6 = (const struct sockaddr_in6 *)&auth->client->localClient->ip;
159	>	v6 = (const struct sockaddr_in6 *)&auth->client->connection->ip;
160		v6dns = (const struct sockaddr_in6 *)addr;
161	+
162		if (memcmp(&v6->sin6_addr, &v6dns->sin6_addr, sizeof(struct in6_addr)) != 0)
163		{
164		sendheader(auth->client, REPORT_IP_MISMATCH);
165	<	good = 0;
165	>	release_auth_client(auth);
166	>	return;
167		}
168		}
169		else
186	–	#endif
170		{
171	<	v4 = (const struct sockaddr_in *)&auth->client->localClient->ip;
171	>	v4 = (const struct sockaddr_in *)&auth->client->connection->ip;
172		v4dns = (const struct sockaddr_in *)addr;
173	<	if(v4->sin_addr.s_addr != v4dns->sin_addr.s_addr)
173	>
174	>	if (v4->sin_addr.s_addr != v4dns->sin_addr.s_addr)
175		{
176		sendheader(auth->client, REPORT_IP_MISMATCH);
177	<	good = 0;
177	>	release_auth_client(auth);
178	>	return;
179		}
180		}
181	<	if (good && strlen(name) <= HOSTLEN)
181	>
182	>	if (namelength > HOSTLEN)
183	>	sendheader(auth->client, REPORT_HOST_TOOLONG);
184	>	else
185		{
186	<	strlcpy(auth->client->host, name,
199	<	sizeof(auth->client->host));
186	>	strlcpy(auth->client->host, name, sizeof(auth->client->host));
187		sendheader(auth->client, REPORT_FIN_DNS);
188		}
202	–	else if (strlen(name) > HOSTLEN)
203	–	sendheader(auth->client, REPORT_HOST_TOOLONG);
189		}
190		else
191		sendheader(auth->client, REPORT_FAIL_DNS);
#	Line 226 | Line 211 | auth_error(struct AuthRequest *auth)
211		}
212
213		/*
214	<	* start_auth_query - Flag the client to show that an attempt to
214	>	* start_auth_query - Flag the client to show that an attempt to
215		* contact the ident server on
216		* the client's host.  The connect and subsequently the socket are all put
217		* into 'non-blocking' mode.  Should the connect or any later phase of the
#	Line 238 | Line 223 | start_auth_query(struct AuthRequest *aut
223		{
224		struct irc_ssaddr localaddr;
225		socklen_t locallen = sizeof(struct irc_ssaddr);
241	–	#ifdef IPV6
226		struct sockaddr_in6 *v6;
243	–	#else
244	–	struct sockaddr_in *v4;
245	–	#endif
227
228		/* open a socket of the same type as the client socket */
229	<	if (comm_open(&auth->fd, auth->client->localClient->ip.ss.ss_family,
229	>	if (comm_open(&auth->fd, auth->client->connection->ip.ss.ss_family,
230		SOCK_STREAM, 0, "ident") == -1)
231		{
232	<	report_error(L_ALL, "creating auth stream socket %s:%s",
233	<	get_client_name(auth->client, SHOW_IP), errno);
253	<	ilog(L_ERROR, "Unable to create auth socket for %s",
254	<	get_client_name(auth->client, SHOW_IP));
232	>	report_error(L_ALL, "creating auth stream socket %s:%s",
233	>	get_client_name(auth->client, SHOW_IP), errno);
234		++ServerStats.is_abad;
235		return 0;
236		}
237
238		sendheader(auth->client, REPORT_DO_ID);
239
240	<	/*
240	>	/*
241		* get the local address of the client and bind to that to
242		* make the auth request.  This used to be done only for
243		* ifdef VIRTUAL_HOST, but needs to be done for all clients
#	Line 266 | Line 245 | start_auth_query(struct AuthRequest *aut
245		* and machines with multiple IP addresses are common now
246		*/
247		memset(&localaddr, 0, locallen);
248	<	getsockname(auth->client->localClient->fd.fd, (struct sockaddr*)&localaddr,
248	>	getsockname(auth->client->connection->fd.fd, (struct sockaddr*)&localaddr,
249		&locallen);
250
272	–	#ifdef IPV6
251		remove_ipv6_mapping(&localaddr);
252		v6 = (struct sockaddr_in6 *)&localaddr;
253		v6->sin6_port = htons(0);
276	–	#else
277	–	localaddr.ss_len = locallen;
278	–	v4 = (struct sockaddr_in *)&localaddr;
279	–	v4->sin_port = htons(0);
280	–	#endif
254		localaddr.ss_port = htons(0);
255
256	<	comm_connect_tcp(&auth->fd, auth->client->sockhost, 113,
257	<	(struct sockaddr *)&localaddr, localaddr.ss_len, auth_connect_callback,
258	<	auth, auth->client->localClient->ip.ss.ss_family,
256	>	comm_connect_tcp(&auth->fd, auth->client->sockhost, RFC1413_PORT,
257	>	(struct sockaddr *)&localaddr, localaddr.ss_len, auth_connect_callback,
258	>	auth, auth->client->connection->ip.ss.ss_family,
259		GlobalSetOptions.ident_timeout);
260		return 1; /* We suceed here for now */
261		}
262
263		/*
264	<	* GetValidIdent - parse ident query reply from identd server
292	<	*
293	<	* Inputs        - pointer to ident buf
294	<	* Output        - NULL if no valid ident found, otherwise pointer to name
295	<	* Side effects  -
296	<	*/
297	<	/*
298	<	* A few questions have been asked about this mess, obviously
299	<	* it should have been commented better the first time.
300	<	* The original idea was to remove all references to libc from ircd-hybrid.
301	<	* Instead of having to write a replacement for sscanf(), I did a
302	<	* rather gruseome parser here so we could remove this function call.
303	<	* Note, that I had also removed a few floating point printfs as well (though
304	<	* now we are still stuck with a few...)
305	<	* Remember, we have a replacement ircd sprintf, we have bleeps fputs lib
306	<	* it would have been nice to remove some unneeded code.
307	<	* Oh well. If we don't remove libc stuff totally, then it would be
308	<	* far cleaner to use sscanf()
309	<	*
310	<	* - Dianora
311	<	*/
312	<	static char *
313	<	GetValidIdent(char *buf)
314	<	{
315	<	int   remp = 0;
316	<	int   locp = 0;
317	<	char* colon1Ptr;
318	<	char* colon2Ptr;
319	<	char* colon3Ptr;
320	<	char* commaPtr;
321	<	char* remotePortString;
322	<
323	<	/* All this to get rid of a sscanf() fun. */
324	<	remotePortString = buf;
325	<
326	<	if ((colon1Ptr = strchr(remotePortString,':')) == NULL)
327	<	return 0;
328	<	*colon1Ptr = '\0';
329	<	colon1Ptr++;
330	<
331	<	if ((colon2Ptr = strchr(colon1Ptr,':')) == NULL)
332	<	return 0;
333	<	*colon2Ptr = '\0';
334	<	colon2Ptr++;
335	<
336	<	if ((commaPtr = strchr(remotePortString, ',')) == NULL)
337	<	return 0;
338	<	*commaPtr = '\0';
339	<	commaPtr++;
340	<
341	<	if ((remp = atoi(remotePortString)) == 0)
342	<	return 0;
343	<
344	<	if ((locp = atoi(commaPtr)) == 0)
345	<	return 0;
346	<
347	<	/* look for USERID bordered by first pair of colons */
348	<	if (strstr(colon1Ptr, "USERID") == NULL)
349	<	return 0;
350	<
351	<	if ((colon3Ptr = strchr(colon2Ptr,':')) == NULL)
352	<	return 0;
353	<	*colon3Ptr = '\0';
354	<	colon3Ptr++;
355	<	return (colon3Ptr);
356	<	}
357	<
358	<	/*
359	<	* start_auth
264	>	* start_auth
265		*
266		* inputs       - pointer to client to auth
267		* output       - NONE
268		* side effects - starts auth (identd) and dns queries for a client
269		*/
270	<	static void *
271	<	start_auth(va_list args)
270	>	void
271	>	start_auth(struct Client *client_p)
272		{
273	<	struct Client *client = va_arg(args, struct Client *);
369	<	struct AuthRequest *auth = NULL;
370	<
371	<	assert(client != NULL);
273	>	struct AuthRequest *const auth = make_auth_request(client_p);
274
275	<	auth = make_auth_request(client);
275	>	SetInAuth(auth);
276	>	dlinkAddTail(auth, &auth->node, &auth_pending_list);
277
278	<	sendheader(client, REPORT_DO_DNS);
278	>	sendheader(client_p, REPORT_DO_DNS);
279
280		SetDNSPending(auth);
281
282	<	if (ConfigFileEntry.disable_auth == 0)
282	>	if (ConfigGeneral.disable_auth == 0)
283		{
284		SetDoingAuth(auth);
285		start_auth_query(auth);
286		}
287
288	<	dlinkAdd(auth, &auth->node, &auth_doing_list);
386	<
387	<	gethost_byaddr(auth_dns_callback, auth, &client->localClient->ip);
388	<
389	<	return NULL;
288	>	gethost_byaddr(auth_dns_callback, auth, &client_p->connection->ip);
289		}
290
291		/*
#	Line 396 | Line 295 | start_auth(va_list args)
295		static void
296		timeout_auth_queries_event(void *notused)
297		{
298	<	dlink_node *ptr = NULL, *next_ptr = NULL;
298	>	dlink_node *node = NULL, *node_next = NULL;
299
300	<	DLINK_FOREACH_SAFE(ptr, next_ptr, auth_doing_list.head)
300	>	DLINK_FOREACH_SAFE(node, node_next, auth_pending_list.head)
301		{
302	<	struct AuthRequest *auth = ptr->data;
302	>	struct AuthRequest *auth = node->data;
303
304		if (auth->timeout > CurrentTime)
305	<	continue;
407	<
408	<	fd_close(&auth->fd);
305	>	break;
306
307		if (IsDoingAuth(auth))
308	<	{
308	>	{
309		++ServerStats.is_abad;
310	+	fd_close(&auth->fd);
311		ClearAuth(auth);
312		sendheader(auth->client, REPORT_FAIL_ID);
313		}
#	Line 421 | Line 319 | timeout_auth_queries_event(void *notused
319		sendheader(auth->client, REPORT_FAIL_DNS);
320		}
321
424	–	ilog(L_INFO, "DNS/AUTH timeout %s",
425	–	get_client_name(auth->client, SHOW_IP));
322		release_auth_client(auth);
323		}
324		}
#	Line 447 | Line 343 | auth_connect_callback(fde_t *fd, int err
343		char authbuf[32];
344		socklen_t ulen = sizeof(struct irc_ssaddr);
345		socklen_t tlen = sizeof(struct irc_ssaddr);
346	<	u_int16_t uport, tport;
451	<	#ifdef IPV6
346	>	uint16_t uport, tport;
347		struct sockaddr_in6 *v6;
453	–	#else
454	–	struct sockaddr_in *v4;
455	–	#endif
348
349		if (error != COMM_OK)
350		{
#	Line 460 | Line 352 | auth_connect_callback(fde_t *fd, int err
352		return;
353		}
354
355	<	if (getsockname(auth->client->localClient->fd.fd, (struct sockaddr *) &us,
356	<	(socklen_t *) &ulen) ||
465	<	getpeername(auth->client->localClient->fd.fd, (struct sockaddr *) &them,
466	<	(socklen_t *) &tlen))
355	>	if (getsockname(auth->client->connection->fd.fd, (struct sockaddr *)&us, &ulen) ||
356	>	getpeername(auth->client->connection->fd.fd, (struct sockaddr *)&them, &tlen))
357		{
358	<	ilog(L_INFO, "auth get{sock,peer}name error for %s",
359	<	get_client_name(auth->client, SHOW_IP));
358	>	ilog(LOG_TYPE_IRCD, "auth get{sock,peer}name error for %s",
359	>	get_client_name(auth->client, SHOW_IP));
360		auth_error(auth);
361		return;
362		}
363
474	–	#ifdef IPV6
364		v6 = (struct sockaddr_in6 *)&us;
365		uport = ntohs(v6->sin6_port);
366		v6 = (struct sockaddr_in6 *)&them;
367		tport = ntohs(v6->sin6_port);
368		remove_ipv6_mapping(&us);
369		remove_ipv6_mapping(&them);
370	<	#else
371	<	v4 = (struct sockaddr_in *)&us;
483	<	uport = ntohs(v4->sin_port);
484	<	v4 = (struct sockaddr_in *)&them;
485	<	tport = ntohs(v4->sin_port);
486	<	us.ss_len = ulen;
487	<	them.ss_len = tlen;
488	<	#endif
489	<
490	<	ircsprintf(authbuf, "%u , %u\r\n", tport, uport);
370	>
371	>	snprintf(authbuf, sizeof(authbuf), "%u, %u\r\n", tport, uport);
372
373		if (send(fd->fd, authbuf, strlen(authbuf), 0) == -1)
374		{
#	Line 495 | Line 376 | auth_connect_callback(fde_t *fd, int err
376		return;
377		}
378
379	<	read_auth_reply(&auth->fd, auth);
379	>	comm_setselect(fd, COMM_SELECT_READ, read_auth_reply, auth, 0);
380	>	}
381	>
382	>	/** Enum used to index ident reply fields in a human-readable way. */
383	>	enum IdentReplyFields
384	>	{
385	>	IDENT_PORT_NUMBERS,
386	>	IDENT_REPLY_TYPE,
387	>	IDENT_OS_TYPE,
388	>	IDENT_INFO,
389	>	USERID_TOKEN_COUNT
390	>	};
391	>
392	>	/** Parse an ident reply line and extract the userid from it.
393	>	* \param reply The ident reply line.
394	>	* \return The userid, or NULL on parse failure.
395	>	*/
396	>	static const char *
397	>	check_ident_reply(char *reply)
398	>	{
399	>	char *token = NULL, *end = NULL;
400	>	char *vector[USERID_TOKEN_COUNT];
401	>	int count = token_vector(reply, ':', vector, USERID_TOKEN_COUNT);
402	>
403	>	if (USERID_TOKEN_COUNT != count)
404	>	return NULL;
405	>
406	>	/*
407	>	* Second token is the reply type
408	>	*/
409	>	token = vector[IDENT_REPLY_TYPE];
410	>
411	>	if (EmptyString(token))
412	>	return NULL;
413	>
414	>	while (IsSpace(*token))
415	>	++token;
416	>
417	>	if (strncmp(token, "USERID", 6))
418	>	return NULL;
419	>
420	>	/*
421	>	* Third token is the os type
422	>	*/
423	>	token = vector[IDENT_OS_TYPE];
424	>
425	>	if (EmptyString(token))
426	>	return NULL;
427	>
428	>	while (IsSpace(*token))
429	>	++token;
430	>
431	>	/*
432	>	* Unless "OTHER" is specified as the operating system type, the server
433	>	* is expected to return the "normal" user identification of the owner
434	>	* of this connection. "Normal" in this context may be taken to mean a
435	>	* string of characters which uniquely identifies the connection owner
436	>	* such as a user identifier assigned by the system administrator and
437	>	* used by such user as a mail identifier, or as the "user" part of a
438	>	* user/password pair used to gain access to system resources. When an
439	>	* operating system is specified (e.g., anything but "OTHER"), the user
440	>	* identifier is expected to be in a more or less immediately useful
441	>	* form - e.g., something that could be used as an argument to "finger"
442	>	* or as a mail address.
443	>	*/
444	>	if (!strncmp(token, "OTHER", 5))
445	>	return NULL;
446	>
447	>	/*
448	>	* Fourth token is the username
449	>	*/
450	>	token = vector[IDENT_INFO];
451	>
452	>	if (EmptyString(token))
453	>	return NULL;
454	>
455	>	while (IsSpace(*token))
456	>	++token;
457	>
458	>	while (*token == '~' || *token == '^')
459	>	++token;
460	>
461	>	/*
462	>	* Look for the end of the username, terminators are '\0, @, <SPACE>, :'
463	>	*/
464	>	for (end = token; *end; ++end)
465	>	if (IsSpace(*end) || '@' == *end || ':' == *end)
466	>	break;
467	>	*end = '\0';
468	>
469	>	return token;
470		}
471
472		/*
473	<	* read_auth_reply - read the reply (if any) from the ident server
473	>	* read_auth_reply - read the reply (if any) from the ident server
474		* we connected to.
475		* We only give it one shot, if the reply isn't good the first time
476		* fail the authentication entirely. --Bleep
477		*/
507	–	#define AUTH_BUFSIZ 128
508	–
478		static void
479		read_auth_reply(fde_t *fd, void *data)
480		{
481	<	struct AuthRequest *auth = data;
482	<	char *s = NULL;
483	<	char *t = NULL;
484	<	int len;
516	<	int count;
517	<	char buf[AUTH_BUFSIZ + 1]; /* buffer to read auth reply into */
518	<
519	<	/* Why?
520	<	* Well, recv() on many POSIX systems is a per-packet operation,
521	<	* and we do not necessarily want this, because on lowspec machines,
522	<	* the ident response may come back fragmented, thus resulting in an
523	<	* invalid ident response, even if the ident response was really OK.
524	<	*
525	<	* So PLEASE do not change this code to recv without being aware of the
526	<	* consequences.
527	<	*
528	<	*    --nenolod
529	<	*/
530	<	#ifndef _WIN32
531	<	len = read(fd->fd, buf, AUTH_BUFSIZ);
532	<	#else
533	<	len = recv(fd->fd, buf, AUTH_BUFSIZ, 0);
534	<	#endif
535	<
536	<	if (len < 0)
537	<	{
538	<	#ifdef _WIN32
539	<	errno = WSAGetLastError();
540	<	#endif
541	<	if (ignoreErrno(errno))
542	<	comm_setselect(fd, COMM_SELECT_READ, read_auth_reply, auth, 0);
543	<	else
544	<	auth_error(auth);
545	<	return;
546	<	}
481	>	struct AuthRequest *const auth = data;
482	>	const char *username = NULL;
483	>	ssize_t len = 0;
484	>	char buf[RFC1413_BUFSIZ + 1];
485
486	<	if (len > 0)
486	>	if ((len = recv(fd->fd, buf, RFC1413_BUFSIZ, 0)) > 0)
487		{
488		buf[len] = '\0';
489	<
552	<	if ((s = GetValidIdent(buf)))
553	<	{
554	<	t = auth->client->username;
555	<
556	<	while (*s == '~' || *s == '^')
557	<	s++;
558	<
559	<	for (count = USERLEN; *s && count; s++)
560	<	{
561	<	if (*s == '@')
562	<	break;
563	<	if (!IsSpace(*s) && *s != ':' && *s != '[')
564	<	{
565	<	*t++ = *s;
566	<	count--;
567	<	}
568	<	}
569	<
570	<	*t = '\0';
571	<	}
489	>	username = check_ident_reply(buf);
490		}
491
492		fd_close(fd);
493
494		ClearAuth(auth);
495
496	<	if (s == NULL)
496	>	if (EmptyString(username))
497		{
498		sendheader(auth->client, REPORT_FAIL_ID);
499		++ServerStats.is_abad;
500		}
501		else
502		{
503	+	strlcpy(auth->client->username, username, sizeof(auth->client->username));
504		sendheader(auth->client, REPORT_FIN_ID);
505		++ServerStats.is_asuc;
506		SetGotId(auth->client);
#	Line 593 | Line 512 | read_auth_reply(fde_t *fd, void *data)
512		/*
513		* delete_auth()
514		*/
515	<	void
515	>	void
516		delete_auth(struct AuthRequest *auth)
517		{
518		if (IsDNSPending(auth))
519		delete_resolver_queries(auth);
520
521	<	fd_close(&auth->fd);
522	<	dlinkDelete(&auth->node, &auth_doing_list);
523	<	BlockHeapFree(auth_heap, auth);
521	>	if (IsDoingAuth(auth))
522	>	fd_close(&auth->fd);
523	>
524	>	if (IsInAuth(auth))
525	>	{
526	>	dlinkDelete(&auth->node, &auth_pending_list);
527	>	ClearInAuth(auth);
528	>	}
529	>	}
530	>
531	>	/* auth_init
532	>	*
533	>	* Initialise the auth code
534	>	*/
535	>	void
536	>	auth_init(void)
537	>	{
538	>	static struct event timeout_auth_queries =
539	>	{
540	>	.name = "timeout_auth_queries_event",
541	>	.handler = timeout_auth_queries_event,
542	>	.when = 1
543	>	};
544	>
545	>	event_add(&timeout_auth_queries, NULL);
546		}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines (old)
>	Changed lines (new)