ViewVC Help

View File | Revision Log | Show Annotations | View Changeset | Root Listing

root/svn/ircd-hybrid/branches/8.2.x/src/server.c

Comparing ircd-hybrid/trunk/src/s_serv.c (file contents):
Revision 3136 by michael, Tue Mar 11 18:24:03 2014 UTC vs.
Revision 3335 by michael, Thu Apr 17 18:55:31 2014 UTC

#	Line 30 | Line 30
30		#include "rsa.h"
31		#endif
32		#include "list.h"
33	–	#include "channel.h"
34	–	#include "channel_mode.h"
33		#include "client.h"
34		#include "event.h"
37	–	#include "fdlist.h"
35		#include "hash.h"
36		#include "irc_string.h"
37		#include "ircd.h"
#	Line 42 | Line 39
39		#include "s_bsd.h"
40		#include "numeric.h"
41		#include "packet.h"
45	–	#include "irc_res.h"
42		#include "conf.h"
43		#include "s_serv.h"
44		#include "log.h"
49	–	#include "s_misc.h"
45		#include "s_user.h"
46		#include "send.h"
47		#include "memory.h"
#	Line 57 | Line 52
52
53		dlink_list flatten_links;
54		static dlink_list cap_list = { NULL, NULL, 0 };
60	–	static void server_burst(struct Client *);
61	–	static void burst_all(struct Client *);
62	–	static void send_tb(struct Client *client_p, struct Channel *chptr);
63	–
55		static CNCB serv_connect_callback;
56
66	–	static void burst_members(struct Client *, struct Channel *);
57
58		/*
59		* write_links_file
#	Line 78 | Line 68 | write_links_file(void *notused)
68		{
69		FILE *file = NULL;
70		dlink_node *ptr = NULL, *ptr_next = NULL;
71	<	char buff[IRCD_BUFSIZE] = { '\0' };
71	>	char buff[IRCD_BUFSIZE] = "";
72
73		if ((file = fopen(LIPATH, "w")) == NULL)
74		return;
#	Line 127 | Line 117 | read_links_file(void)
117		{
118		FILE *file = NULL;
119		char *p = NULL;
120	<	char buff[IRCD_BUFSIZE] = { '\0' };
120	>	char buff[IRCD_BUFSIZE] = "";
121
122		if ((file = fopen(LIPATH, "r")) == NULL)
123		return;
124
125		while (fgets(buff, sizeof(buff), file))
126		{
127	<	if ((p = strchr(buff, '\n')) != NULL)
127	>	if ((p = strchr(buff, '\n')))
128		*p = '\0';
129
130		dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
#	Line 163 | Line 153 | read_links_file(void)
153		*      returns: (see #defines)
154		*/
155		int
156	<	hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
156	>	hunt_server(struct Client *source_p, const char *command,
157		const int server, const int parc, char *parv[])
158		{
159		struct Client *target_p = NULL;
#	Line 185 | Line 175 | hunt_server(struct Client *client_p, str
175		if (MyClient(source_p))
176		target_p = hash_find_client(parv[server]);
177		else
178	<	target_p = find_person(client_p, parv[server]);
178	>	target_p = find_person(source_p, parv[server]);
179
180		if (target_p)
181		if (target_p->from == source_p->from && !MyConnect(target_p))
#	Line 222 | Line 212 | hunt_server(struct Client *client_p, str
212		continue;
213		target_p = ptr->data;
214
215	<	if (IsRegistered(target_p) && (target_p != client_p))
215	>	if (IsRegistered(target_p) && (target_p != source_p->from))
216		break;
217		}
218		}
219		}
220		}
221
222	<	if (target_p != NULL)
222	>	if (target_p)
223		{
224	<	if(!IsRegistered(target_p))
224	>	if (!IsRegistered(target_p))
225		{
226		sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
227		return HUNTED_NOSUCH;
#	Line 268 | Line 258 | void
258		try_connections(void *unused)
259		{
260		dlink_node *ptr = NULL;
261	<	struct MaskItem *conf;
272	<	int confrq;
261	>	int confrq = 0;
262
263		/* TODO: change this to set active flag to 0 when added to event! --Habeeb */
264		if (GlobalSetOptions.autoconn == 0)
#	Line 277 | Line 266 | try_connections(void *unused)
266
267		DLINK_FOREACH(ptr, server_items.head)
268		{
269	<	conf = ptr->data;
269	>	struct MaskItem *conf = ptr->data;
270
271		assert(conf->type == CONF_SERVER);
272
#	Line 307 | Line 296 | try_connections(void *unused)
296
297		conf->until = CurrentTime + confrq;
298
299	<	/* Found a CONNECT config with port specified, scan clients
299	>	/*
300	>	* Found a CONNECT config with port specified, scan clients
301		* and see if this server is already connected?
302		*/
303	<	if (hash_find_server(conf->name) != NULL)
303	>	if (hash_find_server(conf->name))
304		continue;
305
306		if (conf->class->ref_count < conf->class->max_total)
307		{
308		/* Go to the end of the list, if not already last */
309	<	if (ptr->next != NULL)
309	>	if (ptr->next)
310		{
311		dlinkDelete(ptr, &server_items);
312		dlinkAddTail(conf, &conf->node, &server_items);
#	Line 325 | Line 315 | try_connections(void *unused)
315		if (find_servconn_in_progress(conf->name))
316		return;
317
318	<	/* We used to only print this if serv_connect() actually
318	>	/*
319	>	* We used to only print this if serv_connect() actually
320		* succeeded, but since comm_tcp_connect() can call the callback
321		* immediately if there is an error, we were getting error messages
322		* in the wrong order. SO, we just print out the activated line,
#	Line 367 | Line 358 | valid_servname(const char *name)
358		++dots;
359		}
360
361	<	return dots != 0 && length <= HOSTLEN;
361	>	return dots && length <= HOSTLEN;
362		}
363
364		int
#	Line 378 | Line 369 | check_server(const char *name, struct Cl
369		struct MaskItem *server_conf = NULL;
370		int error = -1;
371
372	<	assert(client_p != NULL);
372	>	assert(client_p);
373
374		/* loop through looking for all possible connect items that might work */
375		DLINK_FOREACH(ptr, server_items.head)
#	Line 414 | Line 405 | check_server(const char *name, struct Cl
405		attach_conf(client_p, server_conf);
406
407
408	<	if (server_conf != NULL)
408	>	if (server_conf)
409		{
410		struct sockaddr_in *v4;
411		#ifdef IPV6
#	Line 473 | Line 464 | add_capability(const char *capab_name, i
464		int
465		delete_capability(const char *capab_name)
466		{
467	<	dlink_node *ptr;
477	<	dlink_node *next_ptr;
478	<	struct Capability *cap;
467	>	dlink_node *ptr = NULL, *ptr_next = NULL;
468
469	<	DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
469	>	DLINK_FOREACH_SAFE(ptr, ptr_next, cap_list.head)
470		{
471	<	cap = ptr->data;
471	>	struct Capability *cap = ptr->data;
472
473	<	if (cap->cap != 0)
473	>	if (cap->cap)
474		{
475	<	if (irccmp(cap->name, capab_name) == 0)
475	>	if (!irccmp(cap->name, capab_name))
476		{
477		default_server_capabs &= ~(cap->cap);
478		dlinkDelete(ptr, &cap_list);
#	Line 530 | Line 519 | find_capability(const char *capab)
519		void
520		send_capabilities(struct Client *client_p, int cap_can_send)
521		{
522	<	struct Capability *cap=NULL;
523	<	char msgbuf[IRCD_BUFSIZE];
535	<	char *t;
522	>	char msgbuf[IRCD_BUFSIZE] = "";
523	>	char *t = msgbuf;
524		int tl;
525	<	dlink_node *ptr;
538	<
539	<	t = msgbuf;
525	>	dlink_node *ptr = NULL;
526
527		DLINK_FOREACH(ptr, cap_list.head)
528		{
529	<	cap = ptr->data;
529	>	struct Capability *cap = ptr->data;
530
531		if (cap->cap & (cap_can_send|default_server_capabs))
532		{
#	Line 553 | Line 539 | send_capabilities(struct Client *client_
539		sendto_one(client_p, "CAPAB :%s", msgbuf);
540		}
541
556	–	/* sendnick_TS()
557	–	*
558	–	* inputs       - client (server) to send nick towards
559	–	*          - client to send nick for
560	–	* output       - NONE
561	–	* side effects - NICK message is sent towards given client_p
562	–	*/
563	–	void
564	–	sendnick_TS(struct Client *client_p, struct Client *target_p)
565	–	{
566	–	char ubuf[IRCD_BUFSIZE];
567	–
568	–	if (!IsClient(target_p))
569	–	return;
570	–
571	–	send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
572	–
573	–	if (ubuf[0] == '\0')
574	–	{
575	–	ubuf[0] = '+';
576	–	ubuf[1] = '\0';
577	–	}
578	–
579	–	if (IsCapable(client_p, CAP_SVS))
580	–	sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
581	–	target_p->servptr->id,
582	–	target_p->name, target_p->hopcount + 1,
583	–	(unsigned long) target_p->tsinfo,
584	–	ubuf, target_p->username, target_p->host,
585	–	(MyClient(target_p) && IsIPSpoof(target_p)) ?
586	–	"0" : target_p->sockhost, target_p->id,
587	–	target_p->svid, target_p->info);
588	–	else
589	–	sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
590	–	target_p->servptr->id,
591	–	target_p->name, target_p->hopcount + 1,
592	–	(unsigned long) target_p->tsinfo,
593	–	ubuf, target_p->username, target_p->host,
594	–	(MyClient(target_p) && IsIPSpoof(target_p)) ?
595	–	"0" : target_p->sockhost, target_p->id, target_p->info);
596	–
597	–	if (!EmptyString(target_p->certfp))
598	–	sendto_one(client_p, ":%s CERTFP %s",
599	–	ID_or_name(target_p, client_p), target_p->certfp);
600	–
601	–	if (target_p->away[0])
602	–	sendto_one(client_p, ":%s AWAY :%s", ID_or_name(target_p, client_p),
603	–	target_p->away);
604	–
605	–	}
606	–
542		/*
543		* show_capabilities - show current server capabilities
544		*
#	Line 649 | Line 584 | make_server(struct Client *client_p)
584		return client_p->serv;
585		}
586
652	–	/* server_estab()
653	–	*
654	–	* inputs       - pointer to a struct Client
655	–	* output       -
656	–	* side effects -
657	–	*/
658	–	void
659	–	server_estab(struct Client *client_p)
660	–	{
661	–	struct Client *target_p;
662	–	struct MaskItem *conf = NULL;
663	–	char *host;
664	–	const char *inpath;
665	–	static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
666	–	dlink_node *ptr;
667	–	#ifdef HAVE_LIBCRYPTO
668	–	const COMP_METHOD *compression = NULL, *expansion = NULL;
669	–	#endif
670	–
671	–	assert(client_p != NULL);
672	–
673	–	strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
674	–
675	–	inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
676	–	host   = client_p->name;
677	–
678	–	if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
679	–	== NULL)
680	–	{
681	–	/* This shouldn't happen, better tell the ops... -A1kmm */
682	–	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
683	–	"Warning: Lost connect{} block "
684	–	"for server %s(this shouldn't happen)!", host);
685	–	exit_client(client_p, &me, "Lost connect{} block!");
686	–	return;
687	–	}
688	–
689	–	MyFree(client_p->localClient->passwd);
690	–	client_p->localClient->passwd = NULL;
691	–
692	–	/* Its got identd, since its a server */
693	–	SetGotId(client_p);
694	–
695	–	/* If there is something in the serv_list, it might be this
696	–	* connecting server..
697	–	*/
698	–	if (!ServerInfo.hub && serv_list.head)
699	–	{
700	–	if (client_p != serv_list.head->data || serv_list.head->next)
701	–	{
702	–	++ServerStats.is_ref;
703	–	sendto_one(client_p, "ERROR :I'm a leaf not a hub");
704	–	exit_client(client_p, &me, "I'm a leaf");
705	–	return;
706	–	}
707	–	}
708	–
709	–	if (IsUnknown(client_p))
710	–	{
711	–	sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
712	–
713	–	send_capabilities(client_p, 0);
714	–
715	–	sendto_one(client_p, "SERVER %s 1 :%s%s",
716	–	me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
717	–	}
718	–
719	–	sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
720	–	(unsigned long)CurrentTime);
721	–
722	–	if (HasID(client_p))
723	–	hash_add_id(client_p);
724	–
725	–	/* XXX Does this ever happen? I don't think so -db */
726	–	detach_conf(client_p, CONF_OPER);
727	–
728	–	/* *WARNING*
729	–	**    In the following code in place of plain server's
730	–	**    name we send what is returned by get_client_name
731	–	**    which may add the "sockhost" after the name. It's
732	–	**    *very* *important* that there is a SPACE between
733	–	**    the name and sockhost (if present). The receiving
734	–	**    server will start the information field from this
735	–	**    first blank and thus puts the sockhost into info.
736	–	**    ...a bit tricky, but you have been warned, besides
737	–	**    code is more neat this way...  --msa
738	–	*/
739	–	client_p->servptr = &me;
740	–
741	–	if (IsClosing(client_p))
742	–	return;
743	–
744	–	SetServer(client_p);
745	–
746	–	/* Update the capability combination usage counts. -A1kmm */
747	–	set_chcap_usage_counts(client_p);
748	–
749	–	/* Some day, all these lists will be consolidated *sigh* */
750	–	dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
751	–
752	–	assert(dlinkFind(&unknown_list, client_p));
753	–
754	–	dlink_move_node(&client_p->localClient->lclient_node,
755	–	&unknown_list, &serv_list);
756	–
757	–	Count.myserver++;
758	–
759	–	dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
760	–	hash_add_client(client_p);
761	–
762	–	/* doesnt duplicate client_p->serv if allocated this struct already */
763	–	make_server(client_p);
764	–
765	–	/* fixing eob timings.. -gnp */
766	–	client_p->localClient->firsttime = CurrentTime;
767	–
768	–	if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
769	–	AddFlag(client_p, FLAGS_SERVICE);
770	–
771	–	/* Show the real host/IP to admins */
772	–	#ifdef HAVE_LIBCRYPTO
773	–	if (client_p->localClient->fd.ssl)
774	–	{
775	–	compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
776	–	expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
777	–
778	–	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
779	–	"Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
780	–	inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
781	–	compression ? SSL_COMP_get_name(compression) : "NONE",
782	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
783	–	show_capabilities(client_p));
784	–	/* Now show the masked hostname/IP to opers */
785	–	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
786	–	"Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
787	–	inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
788	–	compression ? SSL_COMP_get_name(compression) : "NONE",
789	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
790	–	show_capabilities(client_p));
791	–	ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
792	–	inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
793	–	compression ? SSL_COMP_get_name(compression) : "NONE",
794	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
795	–	show_capabilities(client_p));
796	–	}
797	–	else
798	–	#endif
799	–	{
800	–	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
801	–	"Link with %s established: (Capabilities: %s)",
802	–	inpath_ip, show_capabilities(client_p));
803	–	/* Now show the masked hostname/IP to opers */
804	–	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
805	–	"Link with %s established: (Capabilities: %s)",
806	–	inpath, show_capabilities(client_p));
807	–	ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
808	–	inpath_ip, show_capabilities(client_p));
809	–	}
810	–
811	–	fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
812	–
813	–	sendto_server(client_p, NOCAPS, NOCAPS, ":%s SID %s 2 %s :%s%s",
814	–	me.id, client_p->name, client_p->id,
815	–	IsHidden(client_p) ? "(H) " : "", client_p->info);
816	–
817	–	/*
818	–	* Pass on my client information to the new server
819	–	*
820	–	* First, pass only servers (idea is that if the link gets
821	–	* cancelled beacause the server was already there,
822	–	* there are no NICK's to be cancelled...). Of course,
823	–	* if cancellation occurs, all this info is sent anyway,
824	–	* and I guess the link dies when a read is attempted...? --msa
825	–	*
826	–	* Note: Link cancellation to occur at this point means
827	–	* that at least two servers from my fragment are building
828	–	* up connection this other fragment at the same time, it's
829	–	* a race condition, not the normal way of operation...
830	–	*
831	–	* ALSO NOTE: using the get_client_name for server names--
832	–	*    see previous *WARNING*!!! (Also, original inpath
833	–	*    is destroyed...)
834	–	*/
835	–
836	–	DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
837	–	{
838	–	target_p = ptr->data;
839	–
840	–	/* target_p->from == target_p for target_p == client_p */
841	–	if (IsMe(target_p) || target_p->from == client_p)
842	–	continue;
843	–
844	–	sendto_one(client_p, ":%s SID %s %d %s :%s%s",
845	–	ID(target_p->servptr), target_p->name, target_p->hopcount+1,
846	–	target_p->id, IsHidden(target_p) ? "(H) " : "",
847	–	target_p->info);
848	–
849	–	if (HasFlag(target_p, FLAGS_EOB))
850	–	sendto_one(client_p, ":%s EOB", ID_or_name(target_p, client_p));
851	–	}
852	–
853	–	server_burst(client_p);
854	–	}
855	–
856	–	/* server_burst()
857	–	*
858	–	* inputs       - struct Client pointer server
859	–	*              -
860	–	* output       - none
861	–	* side effects - send a server burst
862	–	* bugs         - still too long
863	–	*/
864	–	static void
865	–	server_burst(struct Client *client_p)
866	–	{
867	–	/* Send it in the shortened format with the TS, if
868	–	** it's a TS server; walk the list of channels, sending
869	–	** all the nicks that haven't been sent yet for each
870	–	** channel, then send the channel itself -- it's less
871	–	** obvious than sending all nicks first, but on the
872	–	** receiving side memory will be allocated more nicely
873	–	** saving a few seconds in the handling of a split
874	–	** -orabidoo
875	–	*/
876	–
877	–	burst_all(client_p);
878	–
879	–	/* EOB stuff is now in burst_all */
880	–	/* Always send a PING after connect burst is done */
881	–	sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
882	–	}
883	–
884	–	/* burst_all()
885	–	*
886	–	* inputs       - pointer to server to send burst to
887	–	* output       - NONE
888	–	* side effects - complete burst of channels/nicks is sent to client_p
889	–	*/
890	–	static void
891	–	burst_all(struct Client *client_p)
892	–	{
893	–	dlink_node *ptr = NULL;
894	–
895	–	DLINK_FOREACH(ptr, global_channel_list.head)
896	–	{
897	–	struct Channel *chptr = ptr->data;
898	–
899	–	if (dlink_list_length(&chptr->members) != 0)
900	–	{
901	–	burst_members(client_p, chptr);
902	–	send_channel_modes(client_p, chptr);
903	–
904	–	if (IsCapable(client_p, CAP_TBURST))
905	–	send_tb(client_p, chptr);
906	–	}
907	–	}
908	–
909	–	/* also send out those that are not on any channel
910	–	*/
911	–	DLINK_FOREACH(ptr, global_client_list.head)
912	–	{
913	–	struct Client *target_p = ptr->data;
914	–
915	–	if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
916	–	sendnick_TS(client_p, target_p);
917	–
918	–	DelFlag(target_p, FLAGS_BURSTED);
919	–	}
920	–
921	–	if (IsCapable(client_p, CAP_EOB))
922	–	sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
923	–	}
924	–
925	–	/*
926	–	* send_tb
927	–	*
928	–	* inputs       - pointer to Client
929	–	*              - pointer to channel
930	–	* output       - NONE
931	–	* side effects - Called on a server burst when
932	–	*                server is CAP_TBURST capable
933	–	*/
934	–	static void
935	–	send_tb(struct Client *client_p, struct Channel *chptr)
936	–	{
937	–	/*
938	–	* We may also send an empty topic here, but only if topic_time isn't 0,
939	–	* i.e. if we had a topic that got unset.  This is required for syncing
940	–	* topics properly.
941	–	*
942	–	* Imagine the following scenario: Our downlink introduces a channel
943	–	* to us with a TS that is equal to ours, but the channel topic on
944	–	* their side got unset while the servers were in splitmode, which means
945	–	* their 'topic' is newer.  They simply wanted to unset it, so we have to
946	–	* deal with it in a more sophisticated fashion instead of just resetting
947	–	* it to their old topic they had before.  Read m_tburst.c:ms_tburst
948	–	* for further information   -Michael
949	–	*/
950	–	if (chptr->topic_time != 0)
951	–	sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s",
952	–	ID_or_name(&me, client_p),
953	–	(unsigned long)chptr->channelts, chptr->chname,
954	–	(unsigned long)chptr->topic_time,
955	–	chptr->topic_info,
956	–	chptr->topic);
957	–	}
958	–
959	–	/* burst_members()
960	–	*
961	–	* inputs       - pointer to server to send members to
962	–	*              - dlink_list pointer to membership list to send
963	–	* output       - NONE
964	–	* side effects -
965	–	*/
966	–	static void
967	–	burst_members(struct Client *client_p, struct Channel *chptr)
968	–	{
969	–	struct Client *target_p;
970	–	struct Membership *ms;
971	–	dlink_node *ptr;
972	–
973	–	DLINK_FOREACH(ptr, chptr->members.head)
974	–	{
975	–	ms       = ptr->data;
976	–	target_p = ms->client_p;
977	–
978	–	if (!HasFlag(target_p, FLAGS_BURSTED))
979	–	{
980	–	AddFlag(target_p, FLAGS_BURSTED);
981	–
982	–	if (target_p->from != client_p)
983	–	sendnick_TS(client_p, target_p);
984	–	}
985	–	}
986	–	}
987	–
587		/* New server connection code
588		* Based upon the stuff floating about in s_bsd.c
589		*   -- adrian
#	Line 1009 | Line 608 | burst_members(struct Client *client_p, s
608		int
609		serv_connect(struct MaskItem *conf, struct Client *by)
610		{
611	<	struct Client *client_p;
612	<	char buf[HOSTIPLEN + 1];
611	>	struct Client *client_p = NULL;
612	>	char buf[HOSTIPLEN + 1] = "";
613
614		/* conversion structs */
615		struct sockaddr_in *v4;
1017	–	/* Make sure conf is useful */
1018	–	assert(conf != NULL);
616
617	+	/* Make sure conf is useful */
618	+	assert(conf);
619
620		getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
621		buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
#	Line 1029 | Line 628 | serv_connect(struct MaskItem *conf, stru
628		sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
629		"Error connecting to %s: DNS lookup for connect{} in progress.",
630		conf->name);
631	<	return (0);
631	>	return 0;
632		}
633
634		if (conf->dns_failed)
#	Line 1037 | Line 636 | serv_connect(struct MaskItem *conf, stru
636		sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
637		"Error connecting to %s: DNS lookup for connect{} failed.",
638		conf->name);
639	<	return (0);
639	>	return 0;
640		}
641
642		/* Make sure this server isn't already connected
643		* Note: conf should ALWAYS be a valid C: line
644		*/
645	<	if ((client_p = hash_find_server(conf->name)) != NULL)
645	>	if ((client_p = hash_find_server(conf->name)))
646		{
647		sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
648		"Server %s already present from %s",
#	Line 1068 | Line 667 | serv_connect(struct MaskItem *conf, stru
667		strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
668
669		/* create a socket for the server connection */
670	<	if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1072	<	SOCK_STREAM, 0, NULL) < 0)
670	>	if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family, SOCK_STREAM, 0, NULL) < 0)
671		{
672		/* Eek, failure to create the socket */
673	<	report_error(L_ALL, "opening stream socket to %s: %s",
674	<	conf->name, errno);
673	>	report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
674	>
675		SetDead(client_p);
676	<	exit_client(client_p, &me, "Connection failed");
676	>	exit_client(client_p, "Connection failed");
677		return 0;
678		}
679
#	Line 1094 | Line 692 | serv_connect(struct MaskItem *conf, stru
692		sendto_one_notice(by, &me, ":Connect to host %s failed.", client_p->name);
693
694		SetDead(client_p);
695	<	exit_client(client_p, client_p, "Connection failed");
695	>	exit_client(client_p, "Connection failed");
696		return 0;
697		}
698
#	Line 1113 | Line 711 | serv_connect(struct MaskItem *conf, stru
711
712		SetConnecting(client_p);
713		dlinkAdd(client_p, &client_p->node, &global_client_list);
714	<	/* from def_fam */
714	>
715		client_p->localClient->aftype = conf->aftype;
716
717		/* Now, initiate the connection */
#	Line 1124 | Line 722 | serv_connect(struct MaskItem *conf, stru
722		{
723		case AF_INET:
724		v4 = (struct sockaddr_in*)&conf->bind;
725	<	if (v4->sin_addr.s_addr != 0)
725	>	if (v4->sin_addr.s_addr)
726		{
727		struct irc_ssaddr ipn;
728		memset(&ipn, 0, sizeof(struct irc_ssaddr));
#	Line 1164 | Line 762 | serv_connect(struct MaskItem *conf, stru
762		v6conf = (struct sockaddr_in6 *)&conf->bind;
763		v6 = (struct sockaddr_in6 *)&ipn;
764
765	<	if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)) != 0)
765	>	if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
766		{
767		memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
768		ipn.ss.ss_family = AF_INET6;
#	Line 1212 | Line 810 | finish_ssl_server_handshake(struct Clien
810		sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
811		"Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
812
813	<	exit_client(client_p, &me, "Lost connect{} block");
813	>	exit_client(client_p, "Lost connect{} block");
814		return;
815		}
816
#	Line 1267 | Line 865 | ssl_server_handshake(fde_t *fd, struct C
865		sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
866		"Error connecting to %s: %s", client_p->name,
867		sslerr ? sslerr : "unknown SSL error");
868	<	exit_client(client_p, client_p, "Error during SSL handshake");
868	>	exit_client(client_p, "Error during SSL handshake");
869		return;
870		}
871		}
#	Line 1309 | Line 907 | ssl_connect_init(struct Client *client_p
907		ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
908		ERR_error_string(ERR_get_error(), NULL));
909		SetDead(client_p);
910	<	exit_client(client_p, client_p, "SSL_new failed");
910	>	exit_client(client_p, "SSL_new failed");
911		return;
912		}
913
#	Line 1337 | Line 935 | serv_connect_callback(fde_t *fd, int sta
935		struct MaskItem *conf = NULL;
936
937		/* First, make sure its a real client! */
938	<	assert(client_p != NULL);
938	>	assert(client_p);
939		assert(&client_p->localClient->fd == fd);
940
941		/* Next, for backward purposes, record the ip of the server */
942		memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
943		sizeof(struct irc_ssaddr));
944	+
945		/* Check the status */
946		if (status != COMM_OK)
947		{
#	Line 1380 | Line 979 | serv_connect_callback(fde_t *fd, int sta
979		sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
980		"Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
981
982	<	exit_client(client_p, &me, "Lost connect{} block");
982	>	exit_client(client_p, "Lost connect{} block");
983		return;
984		}
985

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines (old)
>	Changed lines (new)