ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/branches/8.2.x/src/server.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/s_serv.c (file contents):
Revision 2691 by michael, Tue Dec 17 18:55:59 2013 UTC vs.
Revision 3335 by michael, Thu Apr 17 18:55:31 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_serv.c: Server related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2005 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 18 | Line 17
17   *  along with this program; if not, write to the Free Software
18   *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file s_serv.c
23 > * \brief Server related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
# Line 28 | Line 30
30   #include "rsa.h"
31   #endif
32   #include "list.h"
31 #include "channel.h"
32 #include "channel_mode.h"
33   #include "client.h"
34 #include "dbuf.h"
34   #include "event.h"
36 #include "fdlist.h"
35   #include "hash.h"
36   #include "irc_string.h"
37   #include "ircd.h"
# Line 41 | Line 39
39   #include "s_bsd.h"
40   #include "numeric.h"
41   #include "packet.h"
44 #include "irc_res.h"
42   #include "conf.h"
43   #include "s_serv.h"
44   #include "log.h"
48 #include "s_misc.h"
45   #include "s_user.h"
46   #include "send.h"
47   #include "memory.h"
48 < #include "channel.h" /* chcap_usage_counts stuff...*/
48 > #include "channel.h"
49   #include "parse.h"
50  
51   #define MIN_CONN_FREQ 300
52  
53   dlink_list flatten_links;
54   static dlink_list cap_list = { NULL, NULL, 0 };
59 static void server_burst(struct Client *);
60 static void burst_all(struct Client *);
61 static void send_tb(struct Client *client_p, struct Channel *chptr);
62
55   static CNCB serv_connect_callback;
56  
65 static void burst_members(struct Client *, struct Channel *);
57  
58   /*
59   * write_links_file
# Line 77 | Line 68 | write_links_file(void *notused)
68   {
69    FILE *file = NULL;
70    dlink_node *ptr = NULL, *ptr_next = NULL;
71 <  char buff[IRCD_BUFSIZE] = { '\0' };
71 >  char buff[IRCD_BUFSIZE] = "";
72  
73    if ((file = fopen(LIPATH, "w")) == NULL)
74      return;
# Line 126 | Line 117 | read_links_file(void)
117   {
118    FILE *file = NULL;
119    char *p = NULL;
120 <  char buff[IRCD_BUFSIZE] = { '\0' };
120 >  char buff[IRCD_BUFSIZE] = "";
121  
122    if ((file = fopen(LIPATH, "r")) == NULL)
123      return;
124  
125    while (fgets(buff, sizeof(buff), file))
126    {
127 <    if ((p = strchr(buff, '\n')) != NULL)
127 >    if ((p = strchr(buff, '\n')))
128        *p = '\0';
129  
130      dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
# Line 162 | Line 153 | read_links_file(void)
153   *      returns: (see #defines)
154   */
155   int
156 < hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
156 > hunt_server(struct Client *source_p, const char *command,
157              const int server, const int parc, char *parv[])
158   {
159    struct Client *target_p = NULL;
# Line 184 | Line 175 | hunt_server(struct Client *client_p, str
175    if (MyClient(source_p))
176      target_p = hash_find_client(parv[server]);
177    else
178 <    target_p = find_person(client_p, parv[server]);
178 >    target_p = find_person(source_p, parv[server]);
179  
180    if (target_p)
181      if (target_p->from == source_p->from && !MyConnect(target_p))
# Line 205 | Line 196 | hunt_server(struct Client *client_p, str
196      {
197        if (!(target_p = hash_find_server(parv[server])))
198        {
199 <        sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
209 <                   me.name, source_p->name, parv[server]);
199 >        sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
200          return HUNTED_NOSUCH;
201        }
202      }
# Line 222 | Line 212 | hunt_server(struct Client *client_p, str
212              continue;
213            target_p = ptr->data;
214  
215 <          if (IsRegistered(target_p) && (target_p != client_p))
215 >          if (IsRegistered(target_p) && (target_p != source_p->from))
216              break;
217          }
218        }
219      }
220    }
221  
222 <  if (target_p != NULL)
222 >  if (target_p)
223    {
224 <    if(!IsRegistered(target_p))
224 >    if (!IsRegistered(target_p))
225      {
226 <      sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
237 <                 me.name, source_p->name, parv[server]);
226 >      sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
227        return HUNTED_NOSUCH;
228      }
229  
# Line 245 | Line 234 | hunt_server(struct Client *client_p, str
234        parv[server] = target_p->name;
235  
236      /* This is a little kludgy but should work... */
237 <    if (IsClient(source_p) &&
249 <        ((MyConnect(target_p) && IsCapable(target_p, CAP_TS6)) ||
250 <         (!MyConnect(target_p) && IsCapable(target_p->from, CAP_TS6))))
251 <      parv[0] = ID(source_p);
252 <
253 <    sendto_one(target_p, command, parv[0],
237 >    sendto_one(target_p, command, ID_or_name(source_p, target_p),
238                 parv[1], parv[2], parv[3], parv[4],
239                 parv[5], parv[6], parv[7], parv[8]);
240      return HUNTED_PASS;
241    }
242  
243 <  sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
260 <             me.name, source_p->name, parv[server]);
243 >  sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
244    return HUNTED_NOSUCH;
245   }
246  
# Line 275 | Line 258 | void
258   try_connections(void *unused)
259   {
260    dlink_node *ptr = NULL;
261 <  struct MaskItem *conf;
279 <  int confrq;
261 >  int confrq = 0;
262  
263    /* TODO: change this to set active flag to 0 when added to event! --Habeeb */
264    if (GlobalSetOptions.autoconn == 0)
# Line 284 | Line 266 | try_connections(void *unused)
266  
267    DLINK_FOREACH(ptr, server_items.head)
268    {
269 <    conf = ptr->data;
269 >    struct MaskItem *conf = ptr->data;
270  
271      assert(conf->type == CONF_SERVER);
272  
# Line 314 | Line 296 | try_connections(void *unused)
296  
297      conf->until = CurrentTime + confrq;
298  
299 <    /* Found a CONNECT config with port specified, scan clients
299 >    /*
300 >     * Found a CONNECT config with port specified, scan clients
301       * and see if this server is already connected?
302       */
303 <    if (hash_find_server(conf->name) != NULL)
303 >    if (hash_find_server(conf->name))
304        continue;
305  
306      if (conf->class->ref_count < conf->class->max_total)
307      {
308        /* Go to the end of the list, if not already last */
309 <      if (ptr->next != NULL)
309 >      if (ptr->next)
310        {
311          dlinkDelete(ptr, &server_items);
312          dlinkAddTail(conf, &conf->node, &server_items);
# Line 332 | Line 315 | try_connections(void *unused)
315        if (find_servconn_in_progress(conf->name))
316          return;
317  
318 <      /* We used to only print this if serv_connect() actually
318 >      /*
319 >       * We used to only print this if serv_connect() actually
320         * succeeded, but since comm_tcp_connect() can call the callback
321         * immediately if there is an error, we were getting error messages
322         * in the wrong order. SO, we just print out the activated line,
# Line 374 | Line 358 | valid_servname(const char *name)
358        ++dots;
359    }
360  
361 <  return dots != 0 && length <= HOSTLEN;
361 >  return dots && length <= HOSTLEN;
362   }
363  
364   int
# Line 385 | Line 369 | check_server(const char *name, struct Cl
369    struct MaskItem *server_conf = NULL;
370    int error = -1;
371  
372 <  assert(client_p != NULL);
372 >  assert(client_p);
373  
374    /* loop through looking for all possible connect items that might work */
375    DLINK_FOREACH(ptr, server_items.head)
# Line 421 | Line 405 | check_server(const char *name, struct Cl
405    attach_conf(client_p, server_conf);
406  
407  
408 <  if (server_conf != NULL)
408 >  if (server_conf)
409    {
410      struct sockaddr_in *v4;
411   #ifdef IPV6
# Line 480 | Line 464 | add_capability(const char *capab_name, i
464   int
465   delete_capability(const char *capab_name)
466   {
467 <  dlink_node *ptr;
484 <  dlink_node *next_ptr;
485 <  struct Capability *cap;
467 >  dlink_node *ptr = NULL, *ptr_next = NULL;
468  
469 <  DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
469 >  DLINK_FOREACH_SAFE(ptr, ptr_next, cap_list.head)
470    {
471 <    cap = ptr->data;
471 >    struct Capability *cap = ptr->data;
472  
473 <    if (cap->cap != 0)
473 >    if (cap->cap)
474      {
475 <      if (irccmp(cap->name, capab_name) == 0)
475 >      if (!irccmp(cap->name, capab_name))
476        {
477          default_server_capabs &= ~(cap->cap);
478          dlinkDelete(ptr, &cap_list);
# Line 537 | Line 519 | find_capability(const char *capab)
519   void
520   send_capabilities(struct Client *client_p, int cap_can_send)
521   {
522 <  struct Capability *cap=NULL;
523 <  char msgbuf[IRCD_BUFSIZE];
542 <  char *t;
522 >  char msgbuf[IRCD_BUFSIZE] = "";
523 >  char *t = msgbuf;
524    int tl;
525 <  dlink_node *ptr;
545 <
546 <  t = msgbuf;
525 >  dlink_node *ptr = NULL;
526  
527    DLINK_FOREACH(ptr, cap_list.head)
528    {
529 <    cap = ptr->data;
529 >    struct Capability *cap = ptr->data;
530  
531      if (cap->cap & (cap_can_send|default_server_capabs))
532      {
# Line 560 | Line 539 | send_capabilities(struct Client *client_
539    sendto_one(client_p, "CAPAB :%s", msgbuf);
540   }
541  
563 /* sendnick_TS()
564 *
565 * inputs       - client (server) to send nick towards
566 *          - client to send nick for
567 * output       - NONE
568 * side effects - NICK message is sent towards given client_p
569 */
570 void
571 sendnick_TS(struct Client *client_p, struct Client *target_p)
572 {
573  char ubuf[IRCD_BUFSIZE];
574
575  if (!IsClient(target_p))
576    return;
577
578  send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
579
580  if (ubuf[0] == '\0')
581  {
582    ubuf[0] = '+';
583    ubuf[1] = '\0';
584  }
585
586  if (IsCapable(client_p, CAP_SVS))
587  {
588    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
589      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
590                 target_p->servptr->id,
591                 target_p->name, target_p->hopcount + 1,
592                 (unsigned long) target_p->tsinfo,
593                 ubuf, target_p->username, target_p->host,
594                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
595                 "0" : target_p->sockhost, target_p->id,
596                 target_p->svid, target_p->info);
597    else
598      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s %s :%s",
599                 target_p->name, target_p->hopcount + 1,
600                 (unsigned long) target_p->tsinfo,
601                 ubuf, target_p->username, target_p->host,
602                 target_p->servptr->name, target_p->svid,
603                 target_p->info);
604  }
605  else
606  {
607    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
608      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
609                 target_p->servptr->id,
610                 target_p->name, target_p->hopcount + 1,
611                 (unsigned long) target_p->tsinfo,
612                 ubuf, target_p->username, target_p->host,
613                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
614                 "0" : target_p->sockhost, target_p->id, target_p->info);
615    else
616      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s :%s",
617                 target_p->name, target_p->hopcount + 1,
618                 (unsigned long) target_p->tsinfo,
619                 ubuf, target_p->username, target_p->host,
620                 target_p->servptr->name, target_p->info);
621  }
622
623  if (!EmptyString(target_p->certfp))
624    sendto_one(client_p, ":%s CERTFP %s",
625               ID_or_name(target_p, client_p), target_p->certfp);
626
627  if (target_p->away[0])
628    sendto_one(client_p, ":%s AWAY :%s", ID_or_name(target_p, client_p),
629               target_p->away);
630
631 }
632
542   /*
543   * show_capabilities - show current server capabilities
544   *
# Line 675 | Line 584 | make_server(struct Client *client_p)
584    return client_p->serv;
585   }
586  
678 /* server_estab()
679 *
680 * inputs       - pointer to a struct Client
681 * output       -
682 * side effects -
683 */
684 void
685 server_estab(struct Client *client_p)
686 {
687  struct Client *target_p;
688  struct MaskItem *conf = NULL;
689  char *host;
690  const char *inpath;
691  static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
692  dlink_node *ptr;
693 #ifdef HAVE_LIBCRYPTO
694  const COMP_METHOD *compression = NULL, *expansion = NULL;
695 #endif
696
697  assert(client_p != NULL);
698
699  strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
700
701  inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
702  host   = client_p->name;
703
704  if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
705      == NULL)
706  {
707    /* This shouldn't happen, better tell the ops... -A1kmm */
708    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
709                         "Warning: Lost connect{} block "
710                         "for server %s(this shouldn't happen)!", host);
711    exit_client(client_p, &me, "Lost connect{} block!");
712    return;
713  }
714
715  MyFree(client_p->localClient->passwd);
716  client_p->localClient->passwd = NULL;
717
718  /* Its got identd, since its a server */
719  SetGotId(client_p);
720
721  /* If there is something in the serv_list, it might be this
722   * connecting server..
723   */
724  if (!ServerInfo.hub && serv_list.head)
725  {
726    if (client_p != serv_list.head->data || serv_list.head->next)
727    {
728      ++ServerStats.is_ref;
729      sendto_one(client_p, "ERROR :I'm a leaf not a hub");
730      exit_client(client_p, &me, "I'm a leaf");
731      return;
732    }
733  }
734
735  if (IsUnknown(client_p))
736  {
737    sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
738
739    send_capabilities(client_p, 0);
740
741    sendto_one(client_p, "SERVER %s 1 :%s%s",
742               me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
743  }
744
745  sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
746             (unsigned long)CurrentTime);
747
748  /* assumption here is if they passed the correct TS version, they also passed an SID */
749  if (IsCapable(client_p, CAP_TS6))
750    hash_add_id(client_p);
751
752  /* XXX Does this ever happen? I don't think so -db */
753  detach_conf(client_p, CONF_OPER);
754
755  /* *WARNING*
756  **    In the following code in place of plain server's
757  **    name we send what is returned by get_client_name
758  **    which may add the "sockhost" after the name. It's
759  **    *very* *important* that there is a SPACE between
760  **    the name and sockhost (if present). The receiving
761  **    server will start the information field from this
762  **    first blank and thus puts the sockhost into info.
763  **    ...a bit tricky, but you have been warned, besides
764  **    code is more neat this way...  --msa
765  */
766  client_p->servptr = &me;
767
768  if (IsClosing(client_p))
769    return;
770
771  SetServer(client_p);
772
773  /* Update the capability combination usage counts. -A1kmm */
774  set_chcap_usage_counts(client_p);
775
776  /* Some day, all these lists will be consolidated *sigh* */
777  dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
778
779  assert(dlinkFind(&unknown_list, client_p));
780
781  dlink_move_node(&client_p->localClient->lclient_node,
782                  &unknown_list, &serv_list);
783
784  Count.myserver++;
785
786  dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
787  hash_add_client(client_p);
788
789  /* doesnt duplicate client_p->serv if allocated this struct already */
790  make_server(client_p);
791
792  /* fixing eob timings.. -gnp */
793  client_p->localClient->firsttime = CurrentTime;
794
795  if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
796    AddFlag(client_p, FLAGS_SERVICE);
797
798  /* Show the real host/IP to admins */
799 #ifdef HAVE_LIBCRYPTO
800  if (client_p->localClient->fd.ssl)
801  {
802    compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
803    expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
804
805    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
806                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
807                         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
808                         compression ? SSL_COMP_get_name(compression) : "NONE",
809                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
810                         show_capabilities(client_p));
811    /* Now show the masked hostname/IP to opers */
812    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
813                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
814                         inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
815                         compression ? SSL_COMP_get_name(compression) : "NONE",
816                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
817                         show_capabilities(client_p));
818    ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
819         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
820         compression ? SSL_COMP_get_name(compression) : "NONE",
821         expansion ? SSL_COMP_get_name(expansion) : "NONE",
822         show_capabilities(client_p));
823  }
824  else
825 #endif
826  {
827    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
828                         "Link with %s established: (Capabilities: %s)",
829                         inpath_ip, show_capabilities(client_p));
830    /* Now show the masked hostname/IP to opers */
831    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
832                         "Link with %s established: (Capabilities: %s)",
833                         inpath, show_capabilities(client_p));
834    ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
835         inpath_ip, show_capabilities(client_p));
836  }
837
838  fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
839
840  /* Old sendto_serv_but_one() call removed because we now
841  ** need to send different names to different servers
842  ** (domain name matching) Send new server to other servers.
843  */
844  DLINK_FOREACH(ptr, serv_list.head)
845  {
846    target_p = ptr->data;
847
848    if (target_p == client_p)
849      continue;
850
851    if (IsCapable(target_p, CAP_TS6) && HasID(client_p))
852      sendto_one(target_p, ":%s SID %s 2 %s :%s%s",
853                 me.id, client_p->name, client_p->id,
854                 IsHidden(client_p) ? "(H) " : "",
855                 client_p->info);
856    else
857      sendto_one(target_p,":%s SERVER %s 2 :%s%s",
858                 me.name, client_p->name,
859                 IsHidden(client_p) ? "(H) " : "",
860                 client_p->info);
861  }
862
863  /*
864   * Pass on my client information to the new server
865   *
866   * First, pass only servers (idea is that if the link gets
867   * cancelled beacause the server was already there,
868   * there are no NICK's to be cancelled...). Of course,
869   * if cancellation occurs, all this info is sent anyway,
870   * and I guess the link dies when a read is attempted...? --msa
871   *
872   * Note: Link cancellation to occur at this point means
873   * that at least two servers from my fragment are building
874   * up connection this other fragment at the same time, it's
875   * a race condition, not the normal way of operation...
876   *
877   * ALSO NOTE: using the get_client_name for server names--
878   *    see previous *WARNING*!!! (Also, original inpath
879   *    is destroyed...)
880   */
881
882  DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
883  {
884    target_p = ptr->data;
885
886    /* target_p->from == target_p for target_p == client_p */
887    if (IsMe(target_p) || target_p->from == client_p)
888      continue;
889
890    if (IsCapable(client_p, CAP_TS6))
891    {
892      if (HasID(target_p))
893        sendto_one(client_p, ":%s SID %s %d %s :%s%s",
894                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
895                   target_p->id, IsHidden(target_p) ? "(H) " : "",
896                   target_p->info);
897      else  /* introducing non-ts6 server */
898        sendto_one(client_p, ":%s SERVER %s %d :%s%s",
899                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
900                   IsHidden(target_p) ? "(H) " : "", target_p->info);
901    }
902    else
903      sendto_one(client_p, ":%s SERVER %s %d :%s%s",
904                 target_p->servptr->name, target_p->name, target_p->hopcount+1,
905                 IsHidden(target_p) ? "(H) " : "", target_p->info);
906
907    if (HasFlag(target_p, FLAGS_EOB))
908      sendto_one(client_p, ":%s EOB", ID_or_name(client_p, target_p));
909  }
910
911  server_burst(client_p);
912 }
913
914 /* server_burst()
915 *
916 * inputs       - struct Client pointer server
917 *              -
918 * output       - none
919 * side effects - send a server burst
920 * bugs         - still too long
921 */
922 static void
923 server_burst(struct Client *client_p)
924 {
925  /* Send it in the shortened format with the TS, if
926  ** it's a TS server; walk the list of channels, sending
927  ** all the nicks that haven't been sent yet for each
928  ** channel, then send the channel itself -- it's less
929  ** obvious than sending all nicks first, but on the
930  ** receiving side memory will be allocated more nicely
931  ** saving a few seconds in the handling of a split
932  ** -orabidoo
933  */
934
935  burst_all(client_p);
936
937  /* EOB stuff is now in burst_all */
938  /* Always send a PING after connect burst is done */
939  sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
940 }
941
942 /* burst_all()
943 *
944 * inputs       - pointer to server to send burst to
945 * output       - NONE
946 * side effects - complete burst of channels/nicks is sent to client_p
947 */
948 static void
949 burst_all(struct Client *client_p)
950 {
951  dlink_node *ptr = NULL;
952
953  DLINK_FOREACH(ptr, global_channel_list.head)
954  {
955    struct Channel *chptr = ptr->data;
956
957    if (dlink_list_length(&chptr->members) != 0)
958    {
959      burst_members(client_p, chptr);
960      send_channel_modes(client_p, chptr);
961
962      if (IsCapable(client_p, CAP_TBURST))
963        send_tb(client_p, chptr);
964    }
965  }
966
967  /* also send out those that are not on any channel
968   */
969  DLINK_FOREACH(ptr, global_client_list.head)
970  {
971    struct Client *target_p = ptr->data;
972
973    if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
974      sendnick_TS(client_p, target_p);
975
976    DelFlag(target_p, FLAGS_BURSTED);
977  }
978
979  if (IsCapable(client_p, CAP_EOB))
980    sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
981 }
982
983 /*
984 * send_tb
985 *
986 * inputs       - pointer to Client
987 *              - pointer to channel
988 * output       - NONE
989 * side effects - Called on a server burst when
990 *                server is CAP_TBURST capable
991 */
992 static void
993 send_tb(struct Client *client_p, struct Channel *chptr)
994 {
995  /*
996   * We may also send an empty topic here, but only if topic_time isn't 0,
997   * i.e. if we had a topic that got unset.  This is required for syncing
998   * topics properly.
999   *
1000   * Imagine the following scenario: Our downlink introduces a channel
1001   * to us with a TS that is equal to ours, but the channel topic on
1002   * their side got unset while the servers were in splitmode, which means
1003   * their 'topic' is newer.  They simply wanted to unset it, so we have to
1004   * deal with it in a more sophisticated fashion instead of just resetting
1005   * it to their old topic they had before.  Read m_tburst.c:ms_tburst
1006   * for further information   -Michael
1007   */
1008  if (chptr->topic_time != 0)
1009    sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s",
1010               ID_or_name(&me, client_p),
1011               (unsigned long)chptr->channelts, chptr->chname,
1012               (unsigned long)chptr->topic_time,
1013               chptr->topic_info,
1014               chptr->topic);
1015 }
1016
1017 /* burst_members()
1018 *
1019 * inputs       - pointer to server to send members to
1020 *              - dlink_list pointer to membership list to send
1021 * output       - NONE
1022 * side effects -
1023 */
1024 static void
1025 burst_members(struct Client *client_p, struct Channel *chptr)
1026 {
1027  struct Client *target_p;
1028  struct Membership *ms;
1029  dlink_node *ptr;
1030
1031  DLINK_FOREACH(ptr, chptr->members.head)
1032  {
1033    ms       = ptr->data;
1034    target_p = ms->client_p;
1035
1036    if (!HasFlag(target_p, FLAGS_BURSTED))
1037    {
1038      AddFlag(target_p, FLAGS_BURSTED);
1039
1040      if (target_p->from != client_p)
1041        sendnick_TS(client_p, target_p);
1042    }
1043  }
1044 }
1045
587   /* New server connection code
588   * Based upon the stuff floating about in s_bsd.c
589   *   -- adrian
# Line 1067 | Line 608 | burst_members(struct Client *client_p, s
608   int
609   serv_connect(struct MaskItem *conf, struct Client *by)
610   {
611 <  struct Client *client_p;
612 <  char buf[HOSTIPLEN + 1];
611 >  struct Client *client_p = NULL;
612 >  char buf[HOSTIPLEN + 1] = "";
613  
614    /* conversion structs */
615    struct sockaddr_in *v4;
1075  /* Make sure conf is useful */
1076  assert(conf != NULL);
616  
617 +  /* Make sure conf is useful */
618 +  assert(conf);
619  
620    getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
621                buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
# Line 1087 | Line 628 | serv_connect(struct MaskItem *conf, stru
628      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
629                           "Error connecting to %s: DNS lookup for connect{} in progress.",
630                           conf->name);
631 <    return (0);
631 >    return 0;
632    }
633  
634    if (conf->dns_failed)
# Line 1095 | Line 636 | serv_connect(struct MaskItem *conf, stru
636      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
637                           "Error connecting to %s: DNS lookup for connect{} failed.",
638                           conf->name);
639 <    return (0);
639 >    return 0;
640    }
641  
642    /* Make sure this server isn't already connected
643     * Note: conf should ALWAYS be a valid C: line
644     */
645 <  if ((client_p = hash_find_server(conf->name)) != NULL)
645 >  if ((client_p = hash_find_server(conf->name)))
646    {
647      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
648                           "Server %s already present from %s",
# Line 1110 | Line 651 | serv_connect(struct MaskItem *conf, stru
651                           "Server %s already present from %s",
652                           conf->name, get_client_name(client_p, MASK_IP));
653      if (by && IsClient(by) && !MyClient(by))
654 <      sendto_one(by, ":%s NOTICE %s :Server %s already present from %s",
655 <                 me.name, by->name, conf->name,
1115 <                 get_client_name(client_p, MASK_IP));
654 >      sendto_one_notice(by, &me, ":Server %s already present from %s",
655 >                        conf->name, get_client_name(client_p, MASK_IP));
656      return 0;
657    }
658  
# Line 1127 | Line 667 | serv_connect(struct MaskItem *conf, stru
667    strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
668  
669    /* create a socket for the server connection */
670 <  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1131 <                SOCK_STREAM, 0, NULL) < 0)
670 >  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family, SOCK_STREAM, 0, NULL) < 0)
671    {
672      /* Eek, failure to create the socket */
673 <    report_error(L_ALL, "opening stream socket to %s: %s",
674 <                 conf->name, errno);
673 >    report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
674 >
675      SetDead(client_p);
676 <    exit_client(client_p, &me, "Connection failed");
676 >    exit_client(client_p, "Connection failed");
677      return 0;
678    }
679  
# Line 1150 | Line 689 | serv_connect(struct MaskItem *conf, stru
689                           "Host %s is not enabled for connecting: no connect{} block",
690                           conf->name);
691      if (by && IsClient(by) && !MyClient(by))
692 <      sendto_one(by, ":%s NOTICE %s :Connect to host %s failed.",
693 <                 me.name, by->name, client_p->name);
692 >      sendto_one_notice(by, &me, ":Connect to host %s failed.", client_p->name);
693 >
694      SetDead(client_p);
695 <    exit_client(client_p, client_p, "Connection failed");
695 >    exit_client(client_p, "Connection failed");
696      return 0;
697    }
698  
# Line 1172 | Line 711 | serv_connect(struct MaskItem *conf, stru
711  
712    SetConnecting(client_p);
713    dlinkAdd(client_p, &client_p->node, &global_client_list);
714 <  /* from def_fam */
714 >
715    client_p->localClient->aftype = conf->aftype;
716  
717    /* Now, initiate the connection */
# Line 1183 | Line 722 | serv_connect(struct MaskItem *conf, stru
722    {
723      case AF_INET:
724        v4 = (struct sockaddr_in*)&conf->bind;
725 <      if (v4->sin_addr.s_addr != 0)
725 >      if (v4->sin_addr.s_addr)
726        {
727          struct irc_ssaddr ipn;
728          memset(&ipn, 0, sizeof(struct irc_ssaddr));
# Line 1223 | Line 762 | serv_connect(struct MaskItem *conf, stru
762          v6conf = (struct sockaddr_in6 *)&conf->bind;
763          v6 = (struct sockaddr_in6 *)&ipn;
764  
765 <        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)) != 0)
765 >        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
766          {
767            memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
768            ipn.ss.ss_family = AF_INET6;
# Line 1271 | Line 810 | finish_ssl_server_handshake(struct Clien
810      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
811                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
812  
813 <    exit_client(client_p, &me, "Lost connect{} block");
813 >    exit_client(client_p, "Lost connect{} block");
814      return;
815    }
816  
# Line 1326 | Line 865 | ssl_server_handshake(fde_t *fd, struct C
865          sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
866                               "Error connecting to %s: %s", client_p->name,
867                               sslerr ? sslerr : "unknown SSL error");
868 <        exit_client(client_p, client_p, "Error during SSL handshake");
868 >        exit_client(client_p, "Error during SSL handshake");
869          return;
870        }
871      }
# Line 1368 | Line 907 | ssl_connect_init(struct Client *client_p
907      ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
908           ERR_error_string(ERR_get_error(), NULL));
909      SetDead(client_p);
910 <    exit_client(client_p, client_p, "SSL_new failed");
910 >    exit_client(client_p, "SSL_new failed");
911      return;
912    }
913  
# Line 1396 | Line 935 | serv_connect_callback(fde_t *fd, int sta
935    struct MaskItem *conf = NULL;
936  
937    /* First, make sure its a real client! */
938 <  assert(client_p != NULL);
938 >  assert(client_p);
939    assert(&client_p->localClient->fd == fd);
940  
941    /* Next, for backward purposes, record the ip of the server */
942    memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
943           sizeof(struct irc_ssaddr));
944 +
945    /* Check the status */
946    if (status != COMM_OK)
947    {
# Line 1439 | Line 979 | serv_connect_callback(fde_t *fd, int sta
979      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
980                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
981  
982 <    exit_client(client_p, &me, "Lost connect{} block");
982 >    exit_client(client_p, "Lost connect{} block");
983      return;
984    }
985  

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)