ViewVC Help

View File | Revision Log | Show Annotations | View Changeset | Root Listing

root/svn/ircd-hybrid/branches/8.2.x/src/server.c

Comparing:
ircd-hybrid-8/src/s_serv.c (file contents), Revision 1377 by michael, Mon Apr 30 19:35:16 2012 UTC vs.
ircd-hybrid/branches/8.2.x/src/server.c (file contents), Revision 4115 by michael, Tue Jul 1 16:49:54 2014 UTC

#	Line 1 | Line 1
1		/*
2	<	*  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3	<	*  s_serv.c: Server related functions.
2	>	*  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3		*
4	<	*  Copyright (C) 2005 by the past and present ircd coders, and others.
4	>	*  Copyright (c) 1997-2014 ircd-hybrid development team
5		*
6		*  This program is free software; you can redistribute it and/or modify
7		*  it under the terms of the GNU General Public License as published by
#	Line 18 | Line 17
17		*  along with this program; if not, write to the Free Software
18		*  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19		*  USA
20	<	*
21	<	*  $Id$
20	>	*/
21	>
22	>	/*! \file s_serv.c
23	>	* \brief Server related functions.
24	>	* \version $Id$
25		*/
26
27		#include "stdinc.h"
#	Line 28 | Line 30
30		#include "rsa.h"
31		#endif
32		#include "list.h"
31	–	#include "channel.h"
32	–	#include "channel_mode.h"
33		#include "client.h"
34	–	#include "dbuf.h"
34		#include "event.h"
36	–	#include "fdlist.h"
35		#include "hash.h"
36		#include "irc_string.h"
39	–	#include "sprintf_irc.h"
37		#include "ircd.h"
38		#include "ircd_defs.h"
39		#include "s_bsd.h"
40		#include "numeric.h"
41		#include "packet.h"
45	–	#include "irc_res.h"
42		#include "conf.h"
43	<	#include "s_serv.h"
43	>	#include "server.h"
44		#include "log.h"
45	<	#include "s_misc.h"
50	<	#include "s_user.h"
45	>	#include "user.h"
46		#include "send.h"
47		#include "memory.h"
48	<	#include "channel.h" /* chcap_usage_counts stuff...*/
48	>	#include "channel.h"
49		#include "parse.h"
50
51		#define MIN_CONN_FREQ 300
52
53	+	dlink_list flatten_links;
54		static dlink_list cap_list = { NULL, NULL, 0 };
59	–	static void server_burst(struct Client *);
60	–	static void burst_all(struct Client *);
61	–	static void send_tb(struct Client *client_p, struct Channel *chptr);
62	–
55		static CNCB serv_connect_callback;
56
65	–	static void burst_members(struct Client *, struct Channel *);
57
58		/*
59		* write_links_file
#	Line 73 | Line 64 | static void burst_members(struct Client
64		*                but in no particular order.
65		*/
66		void
67	<	write_links_file(void* notused)
67	>	write_links_file(void *notused)
68		{
69	<	MessageFileLine *next_mptr = 0;
70	<	MessageFileLine *mptr = 0;
71	<	MessageFileLine *currentMessageLine = 0;
81	<	MessageFileLine *newMessageLine = 0;
82	<	MessageFile *MessageFileptr;
83	<	const char *p;
84	<	FILE *file;
85	<	char buff[512];
86	<	dlink_node *ptr;
69	>	FILE *file = NULL;
70	>	dlink_node *ptr = NULL, *ptr_next = NULL;
71	>	char buff[IRCD_BUFSIZE] = "";
72
73	<	MessageFileptr = &ConfigFileEntry.linksfile;
89	<
90	<	if ((file = fopen(MessageFileptr->fileName, "w")) == NULL)
73	>	if ((file = fopen(LIPATH, "w")) == NULL)
74		return;
75
76	<	for (mptr = MessageFileptr->contentsOfFile; mptr; mptr = next_mptr)
76	>	DLINK_FOREACH_SAFE(ptr, ptr_next, flatten_links.head)
77		{
78	<	next_mptr = mptr->next;
79	<	MyFree(mptr);
78	>	dlinkDelete(ptr, &flatten_links);
79	>	MyFree(ptr->data);
80	>	free_dlink_node(ptr);
81		}
82
99	–	MessageFileptr->contentsOfFile = NULL;
100	–	currentMessageLine             = NULL;
101	–
83		DLINK_FOREACH(ptr, global_serv_list.head)
84		{
85		const struct Client *target_p = ptr->data;
86
87	<	/* skip ourselves, we send ourselves in /links */
88	<	if (IsMe(target_p))
87	>	/*
88	>	* Skip hidden servers, aswell as ourselves, since we already send
89	>	* ourselves in /links
90	>	*/
91	>	if (IsHidden(target_p) || IsMe(target_p))
92		continue;
93
94	<	/* skip hidden servers */
111	<	if (IsHidden(target_p) && !ConfigServerHide.disable_hidden)
94	>	if (HasFlag(target_p, FLAGS_SERVICE) && ConfigServerHide.hide_services)
95		continue;
96
97	<	if (target_p->info[0])
98	<	p = target_p->info;
116	<	else
117	<	p = "(Unknown Location)";
118	<
119	<	newMessageLine = MyMalloc(sizeof(MessageFileLine));
120	<
121	<	/* Attempt to format the file in such a way it follows the usual links output
97	>	/*
98	>	* Attempt to format the file in such a way it follows the usual links output
99		* ie  "servername uplink :hops info"
100		* Mostly for aesthetic reasons - makes it look pretty in mIRC ;)
101		* - madmax
102		*/
103	+	snprintf(buff, sizeof(buff), "%s %s :1 %s",   target_p->name,
104	+	me.name, target_p->info);
105	+	dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
106	+	snprintf(buff, sizeof(buff), "%s %s :1 %s\n", target_p->name,
107	+	me.name, target_p->info);
108
109	<	/*
110	<	* For now, check this ircsprintf wont overflow - it shouldnt on a
129	<	* default config but it is configurable..
130	<	* This should be changed to an snprintf at some point, but I'm wanting to
131	<	* know if this is a cause of a bug - cryogen
132	<	*/
133	<	assert(strlen(target_p->name) + strlen(me.name) + 6 + strlen(p) <=
134	<	MESSAGELINELEN);
135	<	snprintf(newMessageLine->line, sizeof(newMessageLine->line), "%s %s :1 %s",
136	<	target_p->name, me.name, p);
137	<	newMessageLine->next = NULL;
109	>	fputs(buff, file);
110	>	}
111
112	<	if (MessageFileptr->contentsOfFile)
113	<	{
141	<	if (currentMessageLine)
142	<	currentMessageLine->next = newMessageLine;
143	<	currentMessageLine = newMessageLine;
144	<	}
145	<	else
146	<	{
147	<	MessageFileptr->contentsOfFile = newMessageLine;
148	<	currentMessageLine = newMessageLine;
149	<	}
112	>	fclose(file);
113	>	}
114
115	<	snprintf(buff, sizeof(buff), "%s %s :1 %s\n", target_p->name, me.name, p);
116	<	fputs(buff, file);
115	>	void
116	>	read_links_file(void)
117	>	{
118	>	FILE *file = NULL;
119	>	char *p = NULL;
120	>	char buff[IRCD_BUFSIZE] = "";
121	>
122	>	if ((file = fopen(LIPATH, "r")) == NULL)
123	>	return;
124	>
125	>	while (fgets(buff, sizeof(buff), file))
126	>	{
127	>	if ((p = strchr(buff, '\n')))
128	>	*p = '\0';
129	>
130	>	dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
131		}
132
133		fclose(file);
#	Line 175 | Line 153 | write_links_file(void* notused)
153		*      returns: (see #defines)
154		*/
155		int
156	<	hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
157	<	int server, int parc, char *parv[])
156	>	hunt_server(struct Client *source_p, const char *command,
157	>	const int server, const int parc, char *parv[])
158		{
159		struct Client *target_p = NULL;
160		struct Client *target_tmp = NULL;
161		dlink_node *ptr;
184	–	int wilds;
162
163		/* Assume it's me, if no server */
164		if (parc <= server || EmptyString(parv[server]))
165		return HUNTED_ISME;
166
167	<	if (!strcmp(parv[server], me.id) || match(parv[server], me.name))
167	>	if (!strcmp(parv[server], me.id) || !match(parv[server], me.name))
168		return HUNTED_ISME;
169
170		/* These are to pickup matches that would cause the following
#	Line 197 | Line 174 | hunt_server(struct Client *client_p, str
174		if (MyClient(source_p))
175		target_p = hash_find_client(parv[server]);
176		else
177	<	target_p = find_person(client_p, parv[server]);
177	>	target_p = find_person(source_p, parv[server]);
178
179		if (target_p)
180		if (target_p->from == source_p->from && !MyConnect(target_p))
#	Line 207 | Line 184 | hunt_server(struct Client *client_p, str
184		if (target_p->from == source_p->from && !MyConnect(target_p))
185		target_p = NULL;
186
210	–	collapse(parv[server]);
211	–	wilds = (strchr(parv[server], '?') || strchr(parv[server], '*'));
212	–
187		/* Again, if there are no wild cards involved in the server
188		* name, use the hash lookup
189		*/
190		if (target_p == NULL)
191		{
192	<	if (!wilds)
192	>	if (!has_wildcards(parv[server]))
193		{
194		if (!(target_p = hash_find_server(parv[server])))
195		{
196	<	sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
197	<	me.name, source_p->name, parv[server]);
224	<	return(HUNTED_NOSUCH);
196	>	sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
197	>	return HUNTED_NOSUCH;
198		}
199		}
200		else
#	Line 230 | Line 203 | hunt_server(struct Client *client_p, str
203		{
204		target_tmp = ptr->data;
205
206	<	if (match(parv[server], target_tmp->name))
206	>	if (!match(parv[server], target_tmp->name))
207		{
208		if (target_tmp->from == source_p->from && !MyConnect(target_tmp))
209		continue;
210		target_p = ptr->data;
211
212	<	if (IsRegistered(target_p) && (target_p != client_p))
212	>	if (IsRegistered(target_p) && (target_p != source_p->from))
213		break;
214		}
215		}
216		}
217		}
218
219	<	if (target_p != NULL)
219	>	if (target_p)
220		{
221	<	if(!IsRegistered(target_p))
221	>	if (!IsRegistered(target_p))
222		{
223	<	sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
251	<	me.name, source_p->name, parv[server]);
223	>	sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
224		return HUNTED_NOSUCH;
225		}
226
227		if (IsMe(target_p) || MyClient(target_p))
228		return HUNTED_ISME;
229
230	<	if (!match(target_p->name, parv[server]))
230	>	if (match(target_p->name, parv[server]))
231		parv[server] = target_p->name;
232
233		/* This is a little kludgy but should work... */
234	<	if (IsClient(source_p) &&
263	<	((MyConnect(target_p) && IsCapable(target_p, CAP_TS6)) ||
264	<	(!MyConnect(target_p) && IsCapable(target_p->from, CAP_TS6))))
265	<	parv[0] = ID(source_p);
266	<
267	<	sendto_one(target_p, command, parv[0],
234	>	sendto_one(target_p, command, ID_or_name(source_p, target_p),
235		parv[1], parv[2], parv[3], parv[4],
236		parv[5], parv[6], parv[7], parv[8]);
237	<	return(HUNTED_PASS);
238	<	}
237	>	return HUNTED_PASS;
238	>	}
239
240	<	sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
241	<	me.name, source_p->name, parv[server]);
275	<	return(HUNTED_NOSUCH);
240	>	sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
241	>	return HUNTED_NOSUCH;
242		}
243
244		/* try_connections()
#	Line 288 | Line 254 | hunt_server(struct Client *client_p, str
254		void
255		try_connections(void *unused)
256		{
257	<	dlink_node *ptr;
258	<	struct ConfItem *conf;
293	<	struct AccessItem *aconf;
294	<	struct ClassItem *cltmp;
295	<	int confrq;
257	>	dlink_node *ptr = NULL;
258	>	int confrq = 0;
259
260		/* TODO: change this to set active flag to 0 when added to event! --Habeeb */
261		if (GlobalSetOptions.autoconn == 0)
#	Line 300 | Line 263 | try_connections(void *unused)
263
264		DLINK_FOREACH(ptr, server_items.head)
265		{
266	<	conf = ptr->data;
267	<	aconf = map_to_conf(conf);
266	>	struct MaskItem *conf = ptr->data;
267	>
268	>	assert(conf->type == CONF_SERVER);
269
270	<	/* Also when already connecting! (update holdtimes) --SRB
270	>	/* Also when already connecting! (update holdtimes) --SRB
271		*/
272	<	if (!(aconf->status & CONF_SERVER) || !aconf->port ||
309	<	!(IsConfAllowAutoConn(aconf)))
272	>	if (!conf->port ||!IsConfAllowAutoConn(conf))
273		continue;
274
312	–	cltmp = map_to_conf(aconf->class_ptr);
275
276		/* Skip this entry if the use of it is still on hold until
277		* future. Otherwise handle this entry (and set it on hold
#	Line 317 | Line 279 | try_connections(void *unused)
279		* made one successfull connection... [this algorithm is
280		* a bit fuzzy... -- msa >;) ]
281		*/
282	<	if (aconf->hold > CurrentTime)
282	>	if (conf->until > CurrentTime)
283		continue;
284
285	<	if (cltmp == NULL)
286	<	confrq = DEFAULT_CONNECTFREQUENCY;
287	<	else
288	<	{
289	<	confrq = cltmp->con_freq;
328	<	if (confrq < MIN_CONN_FREQ)
329	<	confrq = MIN_CONN_FREQ;
330	<	}
285	>	assert(conf->class);
286	>
287	>	confrq = conf->class->con_freq;
288	>	if (confrq < MIN_CONN_FREQ)
289	>	confrq = MIN_CONN_FREQ;
290
291	<	aconf->hold = CurrentTime + confrq;
291	>	conf->until = CurrentTime + confrq;
292
293	<	/* Found a CONNECT config with port specified, scan clients
293	>	/*
294	>	* Found a CONNECT config with port specified, scan clients
295		* and see if this server is already connected?
296		*/
297	<	if (hash_find_server(conf->name) != NULL)
297	>	if (hash_find_server(conf->name))
298		continue;
299
300	<	if (cltmp->curr_user_count < cltmp->max_total)
300	>	if (conf->class->ref_count < conf->class->max_total)
301		{
302		/* Go to the end of the list, if not already last */
303	<	if (ptr->next != NULL)
303	>	if (ptr->next)
304		{
305		dlinkDelete(ptr, &server_items);
306		dlinkAddTail(conf, &conf->node, &server_items);
#	Line 349 | Line 309 | try_connections(void *unused)
309		if (find_servconn_in_progress(conf->name))
310		return;
311
312	<	/* We used to only print this if serv_connect() actually
312	>	/*
313	>	* We used to only print this if serv_connect() actually
314		* succeeded, but since comm_tcp_connect() can call the callback
315		* immediately if there is an error, we were getting error messages
316		* in the wrong order. SO, we just print out the activated line,
#	Line 358 | Line 319 | try_connections(void *unused)
319		*   -- adrian
320		*/
321		if (ConfigServerHide.hide_server_ips)
322	<	sendto_realops_flags(UMODE_ALL, L_ALL, "Connection to %s activated.",
322	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
323	>	"Connection to %s activated.",
324		conf->name);
325		else
326	<	sendto_realops_flags(UMODE_ALL, L_ALL, "Connection to %s[%s] activated.",
327	<	conf->name, aconf->host);
326	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
327	>	"Connection to %s[%s] activated.",
328	>	conf->name, conf->host);
329
330	<	serv_connect(aconf, NULL);
330	>	serv_connect(conf, NULL);
331		/* We connect only one at time... */
332		return;
333		}
#	Line 374 | Line 337 | try_connections(void *unused)
337		int
338		valid_servname(const char *name)
339		{
340	<	unsigned int length = 0;
378	<	unsigned int dots   = 0;
340	>	unsigned int dots = 0;
341		const char *p = name;
342
343		for (; *p; ++p)
#	Line 383 | Line 345 | valid_servname(const char *name)
345		if (!IsServChar(*p))
346		return 0;
347
386	–	++length;
387	–
348		if (*p == '.')
349		++dots;
350		}
351
352	<	return dots != 0 && length <= HOSTLEN;
352	>	return dots && (p - name) <= HOSTLEN;
353		}
354
355		int
356		check_server(const char *name, struct Client *client_p)
357		{
358		dlink_node *ptr;
359	<	struct ConfItem *conf           = NULL;
360	<	struct ConfItem *server_conf    = NULL;
401	<	struct AccessItem *server_aconf = NULL;
402	<	struct AccessItem *aconf        = NULL;
359	>	struct MaskItem *conf        = NULL;
360	>	struct MaskItem *server_conf = NULL;
361		int error = -1;
362
363	<	assert(client_p != NULL);
406	<
407	<	if (client_p == NULL)
408	<	return(error);
409	<
410	<	if (strlen(name) > HOSTLEN)
411	<	return(-4);
363	>	assert(client_p);
364
365		/* loop through looking for all possible connect items that might work */
366		DLINK_FOREACH(ptr, server_items.head)
367		{
368		conf = ptr->data;
417	–	aconf = map_to_conf(conf);
369
370	<	if (!match(name, conf->name))
370	>	if (match(name, conf->name))
371		continue;
372
373		error = -3;
374
375		/* XXX: Fix me for IPv6                    */
376		/* XXX sockhost is the IPv4 ip as a string */
377	<	if (match(aconf->host, client_p->host) ||
378	<	match(aconf->host, client_p->sockhost))
377	>	if (!match(conf->host, client_p->host) ||
378	>	!match(conf->host, client_p->sockhost))
379		{
380		error = -2;
430	–	{
431	–	/* A NULL password is as good as a bad one */
432	–	if (EmptyString(client_p->localClient->passwd))
433	–	return(-2);
434	–
435	–	/* code in s_conf.c should not have allowed this to be NULL */
436	–	if (aconf->passwd == NULL)
437	–	return(-2);
381
382	<	if (IsConfEncrypted(aconf))
383	<	{
384	<	if (strcmp(aconf->passwd,
385	<	(const char *)crypt(client_p->localClient->passwd,
386	<	aconf->passwd)) == 0)
387	<	server_conf = conf;
388	<	}
389	<	else
447	<	{
448	<	if (strcmp(aconf->passwd, client_p->localClient->passwd) == 0)
449	<	server_conf = conf;
450	<	}
451	<	}
382	>	if (!match_conf_password(client_p->localClient->passwd, conf))
383	>	return -2;
384	>
385	>	if (!EmptyString(conf->certfp))
386	>	if (EmptyString(client_p->certfp) || strcasecmp(client_p->certfp, conf->certfp))
387	>	return -4;
388	>
389	>	server_conf = conf;
390		}
391		}
392
393		if (server_conf == NULL)
394	<	return(error);
394	>	return error;
395
396		attach_conf(client_p, server_conf);
397
460	–	/* Now find all leaf or hub config items for this server */
461	–	DLINK_FOREACH(ptr, hub_items.head)
462	–	{
463	–	conf = ptr->data;
464	–
465	–	if (!match(name, conf->name))
466	–	continue;
467	–	attach_conf(client_p, conf);
468	–	}
469	–
470	–	DLINK_FOREACH(ptr, leaf_items.head)
471	–	{
472	–	conf = ptr->data;
473	–
474	–	if (!match(name, conf->name))
475	–	continue;
476	–	attach_conf(client_p, conf);
477	–	}
478	–
479	–	server_aconf = map_to_conf(server_conf);
480	–
481	–	if (!IsConfTopicBurst(server_aconf))
482	–	{
483	–	ClearCap(client_p, CAP_TB);
484	–	ClearCap(client_p, CAP_TBURST);
485	–	}
398
399	<	if (aconf != NULL)
399	>	if (server_conf)
400		{
401		struct sockaddr_in *v4;
402		#ifdef IPV6
403		struct sockaddr_in6 *v6;
404		#endif
405	<	switch (aconf->aftype)
405	>	switch (server_conf->aftype)
406		{
407		#ifdef IPV6
408	<	case AF_INET6:
409	<	v6 = (struct sockaddr_in6 *)&aconf->ipnum;
408	>	case AF_INET6:
409	>	v6 = (struct sockaddr_in6 *)&server_conf->addr;
410
411		if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
412	<	memcpy(&aconf->ipnum, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
412	>	memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
413		break;
414		#endif
415		case AF_INET:
416	<	v4 = (struct sockaddr_in *)&aconf->ipnum;
416	>	v4 = (struct sockaddr_in *)&server_conf->addr;
417
418		if (v4->sin_addr.s_addr == INADDR_NONE)
419	<	memcpy(&aconf->ipnum, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
419	>	memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
420		break;
421		}
422		}
423
424	<	return(0);
424	>	return 0;
425		}
426
427		/* add_capability()
#	Line 524 | Line 436 | check_server(const char *name, struct Cl
436		void
437		add_capability(const char *capab_name, int cap_flag, int add_to_default)
438		{
439	<	struct Capability *cap = MyMalloc(sizeof(*cap));
439	>	struct Capability *cap = MyCalloc(sizeof(*cap));
440
441	<	DupString(cap->name, capab_name);
441	>	cap->name = xstrdup(capab_name);
442		cap->cap = cap_flag;
443		dlinkAdd(cap, &cap->node, &cap_list);
444
#	Line 543 | Line 455 | add_capability(const char *capab_name, i
455		int
456		delete_capability(const char *capab_name)
457		{
458	<	dlink_node *ptr;
547	<	dlink_node *next_ptr;
548	<	struct Capability *cap;
458	>	dlink_node *ptr = NULL, *ptr_next = NULL;
459
460	<	DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
460	>	DLINK_FOREACH_SAFE(ptr, ptr_next, cap_list.head)
461		{
462	<	cap = ptr->data;
462	>	struct Capability *cap = ptr->data;
463
464	<	if (cap->cap != 0)
464	>	if (cap->cap)
465		{
466	<	if (irccmp(cap->name, capab_name) == 0)
466	>	if (!irccmp(cap->name, capab_name))
467		{
468	<	default_server_capabs &= ~(cap->cap);
469	<	dlinkDelete(ptr, &cap_list);
470	<	MyFree(cap->name);
471	<	cap->name = NULL;
562	<	MyFree(cap);
468	>	default_server_capabs &= ~(cap->cap);
469	>	dlinkDelete(ptr, &cap_list);
470	>	MyFree(cap->name);
471	>	MyFree(cap);
472		}
473		}
474		}
#	Line 574 | Line 483 | delete_capability(const char *capab_name
483		* output       - 0 if not found CAPAB otherwise
484		* side effects - none
485		*/
486	<	int
486	>	unsigned int
487		find_capability(const char *capab)
488		{
489		const dlink_node *ptr = NULL;
#	Line 593 | Line 502 | find_capability(const char *capab)
502		/* send_capabilities()
503		*
504		* inputs       - Client pointer to send to
596	–	*              - Pointer to AccessItem (for crypt)
505		*              - int flag of capabilities that this server can send
506		* output       - NONE
507		* side effects - send the CAPAB line to a server  -orabidoo
508		*
509		*/
510		void
511	<	send_capabilities(struct Client *client_p, struct AccessItem *aconf,
604	<	int cap_can_send)
511	>	send_capabilities(struct Client *client_p, int cap_can_send)
512		{
513	<	struct Capability *cap=NULL;
514	<	char msgbuf[IRCD_BUFSIZE];
608	<	char *t;
609	<	int tl;
610	<	dlink_node *ptr;
611	<
612	<	t = msgbuf;
513	>	char buf[IRCD_BUFSIZE] = "";
514	>	const dlink_node *ptr = NULL;
515
516		DLINK_FOREACH(ptr, cap_list.head)
517		{
518	<	cap = ptr->data;
518	>	const struct Capability *cap = ptr->data;
519
520		if (cap->cap & (cap_can_send|default_server_capabs))
521		{
522	<	tl = ircsprintf(t, "%s ", cap->name);
523	<	t += tl;
522	>	strlcat(buf, cap->name, sizeof(buf));
523	>	if (ptr->next)
524	>	strlcat(buf, " ", sizeof(buf));
525		}
526		}
527
528	<	*(t - 1) = '\0';
626	<	sendto_one(client_p, "CAPAB :%s", msgbuf);
627	<	}
628	<
629	<	/* sendnick_TS()
630	<	*
631	<	* inputs       - client (server) to send nick towards
632	<	*          - client to send nick for
633	<	* output       - NONE
634	<	* side effects - NICK message is sent towards given client_p
635	<	*/
636	<	void
637	<	sendnick_TS(struct Client *client_p, struct Client *target_p)
638	<	{
639	<	static char ubuf[12];
640	<
641	<	if (!IsClient(target_p))
642	<	return;
643	<
644	<	send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
645	<
646	<	if (ubuf[0] == '\0')
647	<	{
648	<	ubuf[0] = '+';
649	<	ubuf[1] = '\0';
650	<	}
651	<
652	<	/* XXX Both of these need to have a :me.name or :mySID!?!?! */
653	<	if (IsCapable(client_p, CAP_SVS))
654	<	{
655	<	if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
656	<	sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %lu :%s",
657	<	target_p->servptr->id,
658	<	target_p->name, target_p->hopcount + 1,
659	<	(unsigned long) target_p->tsinfo,
660	<	ubuf, target_p->username, target_p->host,
661	<	(MyClient(target_p) && IsIPSpoof(target_p)) ?
662	<	"0" : target_p->sockhost, target_p->id,
663	<	(unsigned long)target_p->servicestamp, target_p->info);
664	<	else
665	<	sendto_one(client_p, "NICK %s %d %lu %s %s %s %s %lu :%s",
666	<	target_p->name, target_p->hopcount + 1,
667	<	(unsigned long) target_p->tsinfo,
668	<	ubuf, target_p->username, target_p->host,
669	<	target_p->servptr->name, (unsigned long)target_p->servicestamp,
670	<	target_p->info);
671	<	}
672	<	else
673	<	{
674	<	if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
675	<	sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
676	<	target_p->servptr->id,
677	<	target_p->name, target_p->hopcount + 1,
678	<	(unsigned long) target_p->tsinfo,
679	<	ubuf, target_p->username, target_p->host,
680	<	(MyClient(target_p) && IsIPSpoof(target_p)) ?
681	<	"0" : target_p->sockhost, target_p->id, target_p->info);
682	<	else
683	<	sendto_one(client_p, "NICK %s %d %lu %s %s %s %s :%s",
684	<	target_p->name, target_p->hopcount + 1,
685	<	(unsigned long) target_p->tsinfo,
686	<	ubuf, target_p->username, target_p->host,
687	<	target_p->servptr->name, target_p->info);
688	<	}
689	<
690	<	if (IsConfAwayBurst((struct AccessItem *)map_to_conf(client_p->serv->sconf)))
691	<	if (!EmptyString(target_p->away))
692	<	sendto_one(client_p, ":%s AWAY :%s", target_p->name,
693	<	target_p->away);
694	<
528	>	sendto_one(client_p, "CAPAB :%s", buf);
529		}
530
531		/*
#	Line 702 | Line 536 | sendnick_TS(struct Client *client_p, str
536		* side effects - build up string representing capabilities of server listed
537		*/
538		const char *
539	<	show_capabilities(struct Client *target_p)
539	>	show_capabilities(const struct Client *target_p)
540		{
541	<	static char msgbuf[IRCD_BUFSIZE];
542	<	char *t = msgbuf;
709	<	dlink_node *ptr;
541	>	static char msgbuf[IRCD_BUFSIZE] = "";
542	>	const dlink_node *ptr = NULL;
543
544	<	t += ircsprintf(msgbuf, "TS ");
544	>	strlcpy(msgbuf, "TS", sizeof(msgbuf));
545
546		DLINK_FOREACH(ptr, cap_list.head)
547		{
548		const struct Capability *cap = ptr->data;
549
550	<	if (IsCapable(target_p, cap->cap))
551	<	t += ircsprintf(t, "%s ", cap->name);
550	>	if (!IsCapable(target_p, cap->cap))
551	>	continue;
552	>
553	>	strlcat(msgbuf,       " ", sizeof(msgbuf));
554	>	strlcat(msgbuf, cap->name, sizeof(msgbuf));
555		}
556
721	–	*(t - 1) = '\0';
557		return msgbuf;
558		}
559
#	Line 733 | Line 568 | struct Server *
568		make_server(struct Client *client_p)
569		{
570		if (client_p->serv == NULL)
571	<	client_p->serv = MyMalloc(sizeof(struct Server));
571	>	client_p->serv = MyCalloc(sizeof(struct Server));
572
573		return client_p->serv;
574		}
575
741	–	/* server_estab()
742	–	*
743	–	* inputs       - pointer to a struct Client
744	–	* output       -
745	–	* side effects -
746	–	*/
747	–	void
748	–	server_estab(struct Client *client_p)
749	–	{
750	–	struct Client *target_p;
751	–	struct ConfItem *conf;
752	–	struct AccessItem *aconf=NULL;
753	–	char *host;
754	–	const char *inpath;
755	–	static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
756	–	dlink_node *ptr;
757	–	#ifdef HAVE_LIBCRYPTO
758	–	const COMP_METHOD *compression = NULL, *expansion = NULL;
759	–	#endif
760	–
761	–	assert(client_p != NULL);
762	–
763	–	strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
764	–
765	–	inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
766	–	host   = client_p->name;
767	–
768	–	if ((conf = find_conf_name(&client_p->localClient->confs, host, SERVER_TYPE))
769	–	== NULL)
770	–	{
771	–	/* This shouldn't happen, better tell the ops... -A1kmm */
772	–	sendto_realops_flags(UMODE_ALL, L_ALL, "Warning: Lost connect{} block "
773	–	"for server %s(this shouldn't happen)!", host);
774	–	exit_client(client_p, &me, "Lost connect{} block!");
775	–	return;
776	–	}
777	–
778	–	MyFree(client_p->localClient->passwd);
779	–	client_p->localClient->passwd = NULL;
780	–
781	–	/* Its got identd, since its a server */
782	–	SetGotId(client_p);
783	–
784	–	/* If there is something in the serv_list, it might be this
785	–	* connecting server..
786	–	*/
787	–	if (!ServerInfo.hub && serv_list.head)
788	–	{
789	–	if (client_p != serv_list.head->data || serv_list.head->next)
790	–	{
791	–	++ServerStats.is_ref;
792	–	sendto_one(client_p, "ERROR :I'm a leaf not a hub");
793	–	exit_client(client_p, &me, "I'm a leaf");
794	–	return;
795	–	}
796	–	}
797	–
798	–	aconf = map_to_conf(conf);
799	–
800	–	if (IsUnknown(client_p))
801	–	{
802	–	/* jdc -- 1.  Use EmptyString(), not [0] index reference.
803	–	*        2.  Check aconf->spasswd, not aconf->passwd.
804	–	*/
805	–	if (!EmptyString(aconf->spasswd))
806	–	sendto_one(client_p, "PASS %s TS %d %s",
807	–	aconf->spasswd, TS_CURRENT, me.id);
808	–
809	–	/* Pass my info to the new server
810	–	*
811	–	* Pass on ZIP if supported
812	–	* Pass on TB if supported.
813	–	* - Dianora
814	–	*/
815	–
816	–	send_capabilities(client_p, aconf,
817	–	(IsConfTopicBurst(aconf) ? CAP_TBURST|CAP_TB : 0));
818	–
819	–	sendto_one(client_p, "SERVER %s 1 :%s%s",
820	–	me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
821	–	}
822	–
823	–	sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
824	–	(unsigned long)CurrentTime);
825	–
826	–	/* assumption here is if they passed the correct TS version, they also passed an SID */
827	–	if (IsCapable(client_p, CAP_TS6))
828	–	hash_add_id(client_p);
829	–
830	–	/* XXX Does this ever happen? I don't think so -db */
831	–	detach_conf(client_p, OPER_TYPE);
832	–
833	–	/* *WARNING*
834	–	**    In the following code in place of plain server's
835	–	**    name we send what is returned by get_client_name
836	–	**    which may add the "sockhost" after the name. It's
837	–	**    *very* *important* that there is a SPACE between
838	–	**    the name and sockhost (if present). The receiving
839	–	**    server will start the information field from this
840	–	**    first blank and thus puts the sockhost into info.
841	–	**    ...a bit tricky, but you have been warned, besides
842	–	**    code is more neat this way...  --msa
843	–	*/
844	–	client_p->servptr = &me;
845	–
846	–	if (IsClosing(client_p))
847	–	return;
848	–
849	–	SetServer(client_p);
850	–
851	–	/* Update the capability combination usage counts. -A1kmm */
852	–	set_chcap_usage_counts(client_p);
853	–
854	–	/* Some day, all these lists will be consolidated *sigh* */
855	–	dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
856	–
857	–	assert(dlinkFind(&unknown_list, client_p));
858	–
859	–	dlink_move_node(&client_p->localClient->lclient_node,
860	–	&unknown_list, &serv_list);
861	–
862	–	Count.myserver++;
863	–
864	–	dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
865	–	hash_add_client(client_p);
866	–
867	–	/* doesnt duplicate client_p->serv if allocated this struct already */
868	–	make_server(client_p);
869	–
870	–	/* fixing eob timings.. -gnp */
871	–	client_p->localClient->firsttime = CurrentTime;
872	–
873	–	if (find_matching_name_conf(SERVICE_TYPE, client_p->name, NULL, NULL, 0))
874	–	AddFlag(client_p, FLAGS_SERVICE);
875	–
876	–	/* Show the real host/IP to admins */
877	–	#ifdef HAVE_LIBCRYPTO
878	–	if (client_p->localClient->fd.ssl)
879	–	{
880	–	compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
881	–	expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
882	–
883	–	sendto_realops_flags(UMODE_ALL, L_ADMIN,
884	–	"Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
885	–	inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
886	–	compression ? SSL_COMP_get_name(compression) : "NONE",
887	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
888	–	show_capabilities(client_p));
889	–	/* Now show the masked hostname/IP to opers */
890	–	sendto_realops_flags(UMODE_ALL, L_OPER,
891	–	"Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
892	–	inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
893	–	compression ? SSL_COMP_get_name(compression) : "NONE",
894	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
895	–	show_capabilities(client_p));
896	–	ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
897	–	inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
898	–	compression ? SSL_COMP_get_name(compression) : "NONE",
899	–	expansion ? SSL_COMP_get_name(expansion) : "NONE",
900	–	show_capabilities(client_p));
901	–	}
902	–	else
903	–	#endif
904	–	{
905	–	sendto_realops_flags(UMODE_ALL, L_ADMIN,
906	–	"Link with %s established: (Capabilities: %s)",
907	–	inpath_ip,show_capabilities(client_p));
908	–	/* Now show the masked hostname/IP to opers */
909	–	sendto_realops_flags(UMODE_ALL, L_OPER,
910	–	"Link with %s established: (Capabilities: %s)",
911	–	inpath,show_capabilities(client_p));
912	–	ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
913	–	inpath_ip, show_capabilities(client_p));
914	–	}
915	–
916	–	client_p->serv->sconf = conf;
917	–
918	–	fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
919	–
920	–	/* Old sendto_serv_but_one() call removed because we now
921	–	** need to send different names to different servers
922	–	** (domain name matching) Send new server to other servers.
923	–	*/
924	–	DLINK_FOREACH(ptr, serv_list.head)
925	–	{
926	–	target_p = ptr->data;
927	–
928	–	if (target_p == client_p)
929	–	continue;
930	–
931	–	if (IsCapable(target_p, CAP_TS6) && HasID(client_p))
932	–	sendto_one(target_p, ":%s SID %s 2 %s :%s%s",
933	–	me.id, client_p->name, client_p->id,
934	–	IsHidden(client_p) ? "(H) " : "",
935	–	client_p->info);
936	–	else
937	–	sendto_one(target_p,":%s SERVER %s 2 :%s%s",
938	–	me.name, client_p->name,
939	–	IsHidden(client_p) ? "(H) " : "",
940	–	client_p->info);
941	–	}
942	–
943	–	/* Pass on my client information to the new server
944	–	**
945	–	** First, pass only servers (idea is that if the link gets
946	–	** cancelled beacause the server was already there,
947	–	** there are no NICK's to be cancelled...). Of course,
948	–	** if cancellation occurs, all this info is sent anyway,
949	–	** and I guess the link dies when a read is attempted...? --msa
950	–	**
951	–	** Note: Link cancellation to occur at this point means
952	–	** that at least two servers from my fragment are building
953	–	** up connection this other fragment at the same time, it's
954	–	** a race condition, not the normal way of operation...
955	–	**
956	–	** ALSO NOTE: using the get_client_name for server names--
957	–	**    see previous *WARNING*!!! (Also, original inpath
958	–	**    is destroyed...)
959	–	*/
960	–
961	–	DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
962	–	{
963	–	target_p = ptr->data;
964	–
965	–	/* target_p->from == target_p for target_p == client_p */
966	–	if (IsMe(target_p) || target_p->from == client_p)
967	–	continue;
968	–
969	–	if (IsCapable(client_p, CAP_TS6))
970	–	{
971	–	if (HasID(target_p))
972	–	sendto_one(client_p, ":%s SID %s %d %s :%s%s",
973	–	ID(target_p->servptr), target_p->name, target_p->hopcount+1,
974	–	target_p->id, IsHidden(target_p) ? "(H) " : "",
975	–	target_p->info);
976	–	else  /* introducing non-ts6 server */
977	–	sendto_one(client_p, ":%s SERVER %s %d :%s%s",
978	–	ID(target_p->servptr), target_p->name, target_p->hopcount+1,
979	–	IsHidden(target_p) ? "(H) " : "", target_p->info);
980	–	}
981	–	else
982	–	sendto_one(client_p, ":%s SERVER %s %d :%s%s",
983	–	target_p->servptr->name, target_p->name, target_p->hopcount+1,
984	–	IsHidden(target_p) ? "(H) " : "", target_p->info);
985	–	}
986	–
987	–	server_burst(client_p);
988	–	}
989	–
990	–	/* server_burst()
991	–	*
992	–	* inputs       - struct Client pointer server
993	–	*              -
994	–	* output       - none
995	–	* side effects - send a server burst
996	–	* bugs         - still too long
997	–	*/
998	–	static void
999	–	server_burst(struct Client *client_p)
1000	–	{
1001	–	/* Send it in the shortened format with the TS, if
1002	–	** it's a TS server; walk the list of channels, sending
1003	–	** all the nicks that haven't been sent yet for each
1004	–	** channel, then send the channel itself -- it's less
1005	–	** obvious than sending all nicks first, but on the
1006	–	** receiving side memory will be allocated more nicely
1007	–	** saving a few seconds in the handling of a split
1008	–	** -orabidoo
1009	–	*/
1010	–
1011	–	burst_all(client_p);
1012	–
1013	–	/* EOB stuff is now in burst_all */
1014	–	/* Always send a PING after connect burst is done */
1015	–	sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
1016	–	}
1017	–
1018	–	/* burst_all()
1019	–	*
1020	–	* inputs       - pointer to server to send burst to
1021	–	* output       - NONE
1022	–	* side effects - complete burst of channels/nicks is sent to client_p
1023	–	*/
1024	–	static void
1025	–	burst_all(struct Client *client_p)
1026	–	{
1027	–	dlink_node *ptr = NULL;
1028	–
1029	–	DLINK_FOREACH(ptr, global_channel_list.head)
1030	–	{
1031	–	struct Channel *chptr = ptr->data;
1032	–
1033	–	if (dlink_list_length(&chptr->members) != 0)
1034	–	{
1035	–	burst_members(client_p, chptr);
1036	–	send_channel_modes(client_p, chptr);
1037	–
1038	–	if (IsCapable(client_p, CAP_TBURST) ||
1039	–	IsCapable(client_p, CAP_TB))
1040	–	send_tb(client_p, chptr);
1041	–	}
1042	–	}
1043	–
1044	–	/* also send out those that are not on any channel
1045	–	*/
1046	–	DLINK_FOREACH(ptr, global_client_list.head)
1047	–	{
1048	–	struct Client *target_p = ptr->data;
1049	–
1050	–	if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
1051	–	sendnick_TS(client_p, target_p);
1052	–
1053	–	DelFlag(target_p, FLAGS_BURSTED);
1054	–	}
1055	–
1056	–	/* We send the time we started the burst, and let the remote host determine an EOB time,
1057	–	** as otherwise we end up sending a EOB of 0   Sending here means it gets sent last -- fl
1058	–	*/
1059	–	/* Its simpler to just send EOB and use the time its been connected.. --fl_ */
1060	–	if (IsCapable(client_p, CAP_EOB))
1061	–	sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
1062	–	}
1063	–
1064	–	/*
1065	–	* send_tb
1066	–	*
1067	–	* inputs       - pointer to Client
1068	–	*              - pointer to channel
1069	–	* output       - NONE
1070	–	* side effects - Called on a server burst when
1071	–	*                server is CAP_TB|CAP_TBURST capable
1072	–	*/
1073	–	static void
1074	–	send_tb(struct Client *client_p, struct Channel *chptr)
1075	–	{
1076	–	/*
1077	–	* We may also send an empty topic here, but only if topic_time isn't 0,
1078	–	* i.e. if we had a topic that got unset.  This is required for syncing
1079	–	* topics properly.
1080	–	*
1081	–	* Imagine the following scenario: Our downlink introduces a channel
1082	–	* to us with a TS that is equal to ours, but the channel topic on
1083	–	* their side got unset while the servers were in splitmode, which means
1084	–	* their 'topic' is newer.  They simply wanted to unset it, so we have to
1085	–	* deal with it in a more sophisticated fashion instead of just resetting
1086	–	* it to their old topic they had before.  Read m_tburst.c:ms_tburst
1087	–	* for further information   -Michael
1088	–	*/
1089	–	if (chptr->topic_time != 0)
1090	–	{
1091	–	if (IsCapable(client_p, CAP_TBURST))
1092	–	sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s",
1093	–	me.name, (unsigned long)chptr->channelts, chptr->chname,
1094	–	(unsigned long)chptr->topic_time,
1095	–	chptr->topic_info,
1096	–	chptr->topic);
1097	–	else if (IsCapable(client_p, CAP_TB))
1098	–	{
1099	–	if (ConfigChannel.burst_topicwho)
1100	–	{
1101	–	sendto_one(client_p, ":%s TB %s %lu %s :%s",
1102	–	me.name, chptr->chname,
1103	–	(unsigned long)chptr->topic_time,
1104	–	chptr->topic_info, chptr->topic);
1105	–	}
1106	–	else
1107	–	{
1108	–	sendto_one(client_p, ":%s TB %s %lu :%s",
1109	–	me.name, chptr->chname,
1110	–	(unsigned long)chptr->topic_time,
1111	–	chptr->topic);
1112	–	}
1113	–	}
1114	–	}
1115	–	}
1116	–
1117	–	/* burst_members()
1118	–	*
1119	–	* inputs       - pointer to server to send members to
1120	–	*              - dlink_list pointer to membership list to send
1121	–	* output       - NONE
1122	–	* side effects -
1123	–	*/
1124	–	static void
1125	–	burst_members(struct Client *client_p, struct Channel *chptr)
1126	–	{
1127	–	struct Client *target_p;
1128	–	struct Membership *ms;
1129	–	dlink_node *ptr;
1130	–
1131	–	DLINK_FOREACH(ptr, chptr->members.head)
1132	–	{
1133	–	ms       = ptr->data;
1134	–	target_p = ms->client_p;
1135	–
1136	–	if (!HasFlag(target_p, FLAGS_BURSTED))
1137	–	{
1138	–	AddFlag(target_p, FLAGS_BURSTED);
1139	–
1140	–	if (target_p->from != client_p)
1141	–	sendnick_TS(client_p, target_p);
1142	–	}
1143	–	}
1144	–	}
1145	–
576		/* New server connection code
577		* Based upon the stuff floating about in s_bsd.c
578		*   -- adrian
#	Line 1150 | Line 580 | burst_members(struct Client *client_p, s
580
581		/* serv_connect() - initiate a server connection
582		*
583	<	* inputs       - pointer to conf
583	>	* inputs       - pointer to conf
584		*              - pointer to client doing the connect
585		* output       -
586		* side effects -
#	Line 1165 | Line 595 | burst_members(struct Client *client_p, s
595		* it suceeded or not, and 0 if it fails in here somewhere.
596		*/
597		int
598	<	serv_connect(struct AccessItem *aconf, struct Client *by)
598	>	serv_connect(struct MaskItem *conf, struct Client *by)
599		{
600	<	struct ConfItem *conf;
601	<	struct Client *client_p;
1172	<	char buf[HOSTIPLEN];
600	>	struct Client *client_p = NULL;
601	>	char buf[HOSTIPLEN + 1] = "";
602
603		/* conversion structs */
604		struct sockaddr_in *v4;
1176	–	/* Make sure aconf is useful */
1177	–	assert(aconf != NULL);
605
606	<	if(aconf == NULL)
607	<	return (0);
606	>	/* Make sure conf is useful */
607	>	assert(conf);
608
609	<	/* XXX should be passing struct ConfItem in the first place */
1183	<	conf = unmap_conf_item(aconf);
1184	<
1185	<	/* log */
1186	<	getnameinfo((struct sockaddr *)&aconf->ipnum, aconf->ipnum.ss_len,
609	>	getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
610		buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
611	<	ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", aconf->user, aconf->host,
611	>	ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", conf->name, conf->host,
612		buf);
613
614		/* Still processing a DNS lookup? -> exit */
615	<	if (aconf->dns_pending)
615	>	if (conf->dns_pending)
616		{
617	<	sendto_realops_flags(UMODE_ALL, L_ALL,
617	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
618		"Error connecting to %s: DNS lookup for connect{} in progress.",
619		conf->name);
620	<	return (0);
620	>	return 0;
621		}
622
623	<	if (aconf->dns_failed)
623	>	if (conf->dns_failed)
624		{
625	<	sendto_realops_flags(UMODE_ALL, L_ALL,
625	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
626		"Error connecting to %s: DNS lookup for connect{} failed.",
627		conf->name);
628	<	return (0);
628	>	return 0;
629		}
630
631		/* Make sure this server isn't already connected
632	<	* Note: aconf should ALWAYS be a valid C: line
632	>	* Note: conf should ALWAYS be a valid C: line
633		*/
634	<	if ((client_p = hash_find_server(conf->name)) != NULL)
635	<	{
636	<	sendto_realops_flags(UMODE_ALL, L_ADMIN,
637	<	"Server %s already present from %s",
638	<	conf->name, get_client_name(client_p, SHOW_IP));
639	<	sendto_realops_flags(UMODE_ALL, L_OPER,
640	<	"Server %s already present from %s",
641	<	conf->name, get_client_name(client_p, MASK_IP));
634	>	if ((client_p = hash_find_server(conf->name)))
635	>	{
636	>	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
637	>	"Server %s already present from %s",
638	>	conf->name, get_client_name(client_p, SHOW_IP));
639	>	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
640	>	"Server %s already present from %s",
641	>	conf->name, get_client_name(client_p, MASK_IP));
642		if (by && IsClient(by) && !MyClient(by))
643	<	sendto_one(by, ":%s NOTICE %s :Server %s already present from %s",
644	<	me.name, by->name, conf->name,
645	<	get_client_name(client_p, MASK_IP));
1223	<	return (0);
643	>	sendto_one_notice(by, &me, ":Server %s already present from %s",
644	>	conf->name, get_client_name(client_p, MASK_IP));
645	>	return 0;
646		}
647	<
647	>
648		/* Create a local client */
649		client_p = make_client(NULL);
650
651		/* Copy in the server, hostname, fd */
652		strlcpy(client_p->name, conf->name, sizeof(client_p->name));
653	<	strlcpy(client_p->host, aconf->host, sizeof(client_p->host));
653	>	strlcpy(client_p->host, conf->host, sizeof(client_p->host));
654
655		/* We already converted the ip once, so lets use it - stu */
656		strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
657
658	<	/* create a socket for the server connection */
659	<	if (comm_open(&client_p->localClient->fd, aconf->ipnum.ss.ss_family,
1238	<	SOCK_STREAM, 0, NULL) < 0)
658	>	/* create a socket for the server connection */
659	>	if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family, SOCK_STREAM, 0, NULL) < 0)
660		{
661		/* Eek, failure to create the socket */
662	<	report_error(L_ALL,
663	<	"opening stream socket to %s: %s", conf->name, errno);
662	>	report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
663	>
664		SetDead(client_p);
665	<	exit_client(client_p, &me, "Connection failed");
666	<	return (0);
665	>	exit_client(client_p, "Connection failed");
666	>	return 0;
667		}
668
669		/* servernames are always guaranteed under HOSTLEN chars */
#	Line 1251 | Line 672 | serv_connect(struct AccessItem *aconf, s
672		/* Attach config entries to client here rather than in
673		* serv_connect_callback(). This to avoid null pointer references.
674		*/
675	<	if (!attach_connect_block(client_p, conf->name, aconf->host))
675	>	if (!attach_connect_block(client_p, conf->name, conf->host))
676		{
677	<	sendto_realops_flags(UMODE_ALL, L_ALL,
678	<	"Host %s is not enabled for connecting:no C/N-line",
679	<	conf->name);
680	<	if (by && IsClient(by) && !MyClient(by))
681	<	sendto_one(by, ":%s NOTICE %s :Connect to host %s failed.",
682	<	me.name, by->name, client_p->name);
677	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
678	>	"Host %s is not enabled for connecting: no connect{} block",
679	>	conf->name);
680	>	if (by && IsClient(by) && !MyClient(by))
681	>	sendto_one_notice(by, &me, ":Connect to host %s failed.", client_p->name);
682	>
683		SetDead(client_p);
684	<	exit_client(client_p, client_p, "Connection failed");
685	<	return (0);
684	>	exit_client(client_p, "Connection failed");
685	>	return 0;
686		}
687
688		/* at this point we have a connection in progress and C/N lines
#	Line 1279 | Line 700 | serv_connect(struct AccessItem *aconf, s
700
701		SetConnecting(client_p);
702		dlinkAdd(client_p, &client_p->node, &global_client_list);
703	<	/* from def_fam */
704	<	client_p->localClient->aftype = aconf->aftype;
703	>
704	>	client_p->localClient->aftype = conf->aftype;
705
706		/* Now, initiate the connection */
707	<	/* XXX assume that a non 0 type means a specific bind address
707	>	/* XXX assume that a non 0 type means a specific bind address
708		* for this connect.
709		*/
710	<	switch (aconf->aftype)
710	>	switch (conf->aftype)
711		{
712		case AF_INET:
713	<	v4 = (struct sockaddr_in*)&aconf->my_ipnum;
714	<	if (v4->sin_addr.s_addr != 0)
713	>	v4 = (struct sockaddr_in*)&conf->bind;
714	>	if (v4->sin_addr.s_addr)
715		{
716		struct irc_ssaddr ipn;
717		memset(&ipn, 0, sizeof(struct irc_ssaddr));
718		ipn.ss.ss_family = AF_INET;
719		ipn.ss_port = 0;
720	<	memcpy(&ipn, &aconf->my_ipnum, sizeof(struct irc_ssaddr));
721	<	comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
722	<	(struct sockaddr *)&ipn, ipn.ss_len,
723	<	serv_connect_callback, client_p, aconf->aftype,
724	<	CONNECTTIMEOUT);
720	>	memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
721	>	comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
722	>	(struct sockaddr *)&ipn, ipn.ss_len,
723	>	serv_connect_callback, client_p, conf->aftype,
724	>	CONNECTTIMEOUT);
725		}
726		else if (ServerInfo.specific_ipv4_vhost)
727		{
#	Line 1309 | Line 730 | serv_connect(struct AccessItem *aconf, s
730		ipn.ss.ss_family = AF_INET;
731		ipn.ss_port = 0;
732		memcpy(&ipn, &ServerInfo.ip, sizeof(struct irc_ssaddr));
733	<	comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
733	>	comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
734		(struct sockaddr *)&ipn, ipn.ss_len,
735	<	serv_connect_callback, client_p, aconf->aftype,
736	<	CONNECTTIMEOUT);
735	>	serv_connect_callback, client_p, conf->aftype,
736	>	CONNECTTIMEOUT);
737		}
738		else
739	<	comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
740	<	NULL, 0, serv_connect_callback, client_p, aconf->aftype,
739	>	comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
740	>	NULL, 0, serv_connect_callback, client_p, conf->aftype,
741		CONNECTTIMEOUT);
742		break;
743		#ifdef IPV6
744		case AF_INET6:
745		{
746	<	struct irc_ssaddr ipn;
747	<	struct sockaddr_in6 *v6;
748	<	struct sockaddr_in6 *v6conf;
749	<
750	<	memset(&ipn, 0, sizeof(struct irc_ssaddr));
751	<	v6conf = (struct sockaddr_in6 *)&aconf->my_ipnum;
752	<	v6 = (struct sockaddr_in6 *)&ipn;
753	<
754	<	if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr,
1334	<	sizeof(struct in6_addr)) != 0)
1335	<	{
1336	<	memcpy(&ipn, &aconf->my_ipnum, sizeof(struct irc_ssaddr));
1337	<	ipn.ss.ss_family = AF_INET6;
1338	<	ipn.ss_port = 0;
1339	<	comm_connect_tcp(&client_p->localClient->fd,
1340	<	aconf->host, aconf->port,
1341	<	(struct sockaddr *)&ipn, ipn.ss_len,
1342	<	serv_connect_callback, client_p,
1343	<	aconf->aftype, CONNECTTIMEOUT);
1344	<	}
1345	<	else if (ServerInfo.specific_ipv6_vhost)
746	>	struct irc_ssaddr ipn;
747	>	struct sockaddr_in6 *v6;
748	>	struct sockaddr_in6 *v6conf;
749	>
750	>	memset(&ipn, 0, sizeof(struct irc_ssaddr));
751	>	v6conf = (struct sockaddr_in6 *)&conf->bind;
752	>	v6 = (struct sockaddr_in6 *)&ipn;
753	>
754	>	if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
755		{
756	<	memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
757	<	ipn.ss.ss_family = AF_INET6;
758	<	ipn.ss_port = 0;
759	<	comm_connect_tcp(&client_p->localClient->fd,
760	<	aconf->host, aconf->port,
761	<	(struct sockaddr *)&ipn, ipn.ss_len,
762	<	serv_connect_callback, client_p,
763	<	aconf->aftype, CONNECTTIMEOUT);
764	<	}
765	<	else
766	<	comm_connect_tcp(&client_p->localClient->fd,
767	<	aconf->host, aconf->port,
768	<	NULL, 0, serv_connect_callback, client_p,
769	<	aconf->aftype, CONNECTTIMEOUT);
756	>	memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
757	>	ipn.ss.ss_family = AF_INET6;
758	>	ipn.ss_port = 0;
759	>	comm_connect_tcp(&client_p->localClient->fd,
760	>	conf->host, conf->port,
761	>	(struct sockaddr *)&ipn, ipn.ss_len,
762	>	serv_connect_callback, client_p,
763	>	conf->aftype, CONNECTTIMEOUT);
764	>	}
765	>	else if (ServerInfo.specific_ipv6_vhost)
766	>	{
767	>	memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
768	>	ipn.ss.ss_family = AF_INET6;
769	>	ipn.ss_port = 0;
770	>	comm_connect_tcp(&client_p->localClient->fd,
771	>	conf->host, conf->port,
772	>	(struct sockaddr *)&ipn, ipn.ss_len,
773	>	serv_connect_callback, client_p,
774	>	conf->aftype, CONNECTTIMEOUT);
775	>	}
776	>	else
777	>	comm_connect_tcp(&client_p->localClient->fd,
778	>	conf->host, conf->port,
779	>	NULL, 0, serv_connect_callback, client_p,
780	>	conf->aftype, CONNECTTIMEOUT);
781		}
782		#endif
783		}
784	<	return (1);
784	>	return 1;
785		}
786
787		#ifdef HAVE_LIBCRYPTO
788		static void
789		finish_ssl_server_handshake(struct Client *client_p)
790		{
791	<	struct ConfItem *conf=NULL;
1372	<	struct AccessItem *aconf=NULL;
791	>	struct MaskItem *conf = NULL;
792
793		conf = find_conf_name(&client_p->localClient->confs,
794	<	client_p->name, SERVER_TYPE);
794	>	client_p->name, CONF_SERVER);
795		if (conf == NULL)
796		{
797	<	sendto_realops_flags(UMODE_ALL, L_ADMIN,
797	>	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
798		"Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
799	<	sendto_realops_flags(UMODE_ALL, L_OPER,
799	>	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
800		"Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
801
802	<	exit_client(client_p, &me, "Lost connect{} block");
802	>	exit_client(client_p, "Lost connect{} block");
803		return;
804		}
805
806	<	aconf = map_to_conf(conf);
806	>	sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
807
808	<	/* jdc -- Check and send spasswd, not passwd. */
1390	<	if (!EmptyString(aconf->spasswd))
1391	<	sendto_one(client_p, "PASS %s TS %d %s",
1392	<	aconf->spasswd, TS_CURRENT, me.id);
1393	<
1394	<	send_capabilities(client_p, aconf,
1395	<	(IsConfTopicBurst(aconf) ? CAP_TBURST|CAP_TB : 0));
808	>	send_capabilities(client_p, 0);
809
810		sendto_one(client_p, "SERVER %s 1 :%s%s",
811		me.name, ConfigServerHide.hidden ? "(H) " : "",
#	Line 1403 | Line 816 | finish_ssl_server_handshake(struct Clien
816		*/
817		if (IsDead(client_p))
818		{
819	<	sendto_realops_flags(UMODE_ALL, L_ADMIN,
819	>	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
820		"%s[%s] went dead during handshake",
821		client_p->name,
822		client_p->host);
823	<	sendto_realops_flags(UMODE_ALL, L_OPER,
823	>	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
824		"%s went dead during handshake", client_p->name);
825		return;
826		}
#	Line 1420 | Line 833 | finish_ssl_server_handshake(struct Clien
833		static void
834		ssl_server_handshake(fde_t *fd, struct Client *client_p)
835		{
836	<	int ret;
837	<	int err;
1425	<
1426	<	ret = SSL_connect(client_p->localClient->fd.ssl);
836	>	X509 *cert = NULL;
837	>	int ret = 0;
838
839	<	if (ret <= 0)
839	>	if ((ret = SSL_connect(client_p->localClient->fd.ssl)) <= 0)
840		{
841	<	switch ((err = SSL_get_error(client_p->localClient->fd.ssl, ret)))
841	>	switch (SSL_get_error(client_p->localClient->fd.ssl, ret))
842		{
843		case SSL_ERROR_WANT_WRITE:
844		comm_setselect(&client_p->localClient->fd, COMM_SELECT_WRITE,
#	Line 1440 | Line 851 | ssl_server_handshake(fde_t *fd, struct C
851		default:
852		{
853		const char *sslerr = ERR_error_string(ERR_get_error(), NULL);
854	<	sendto_realops_flags(UMODE_ALL, L_ALL,
854	>	sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
855		"Error connecting to %s: %s", client_p->name,
856		sslerr ? sslerr : "unknown SSL error");
857	<	exit_client(client_p, client_p, "Error during SSL handshake");
857	>	exit_client(client_p, "Error during SSL handshake");
858		return;
859		}
860		}
861		}
862
863	+	if ((cert = SSL_get_peer_certificate(client_p->localClient->fd.ssl)))
864	+	{
865	+	int res = SSL_get_verify_result(client_p->localClient->fd.ssl);
866	+	char buf[EVP_MAX_MD_SIZE * 2 + 1] = "";
867	+	unsigned char md[EVP_MAX_MD_SIZE] = "";
868	+
869	+	if (res == X509_V_OK || res == X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN ||
870	+	res == X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE ||
871	+	res == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT)
872	+	{
873	+	unsigned int n = 0;
874	+
875	+	if (X509_digest(cert, ServerInfo.message_digest_algorithm, md, &n))
876	+	{
877	+	binary_to_hex(md, buf, n);
878	+	client_p->certfp = xstrdup(buf);
879	+	}
880	+	}
881	+	else
882	+	ilog(LOG_TYPE_IRCD, "Server %s!%s@%s gave bad SSL client certificate: %d",
883	+	client_p->name, client_p->username, client_p->host, res);
884	+	X509_free(cert);
885	+	}
886	+
887		finish_ssl_server_handshake(client_p);
888		}
889
890		static void
891	<	ssl_connect_init(struct Client *client_p, struct AccessItem *aconf, fde_t *fd)
891	>	ssl_connect_init(struct Client *client_p, struct MaskItem *conf, fde_t *fd)
892		{
893		if ((client_p->localClient->fd.ssl = SSL_new(ServerInfo.client_ctx)) == NULL)
894		{
895		ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
896		ERR_error_string(ERR_get_error(), NULL));
897		SetDead(client_p);
898	<	exit_client(client_p, client_p, "SSL_new failed");
898	>	exit_client(client_p, "SSL_new failed");
899		return;
900		}
901
902		SSL_set_fd(fd->ssl, fd->fd);
903
904	<	if (!EmptyString(aconf->cipher_list))
905	<	SSL_set_cipher_list(client_p->localClient->fd.ssl, aconf->cipher_list);
904	>	if (!EmptyString(conf->cipher_list))
905	>	SSL_set_cipher_list(client_p->localClient->fd.ssl, conf->cipher_list);
906
907		ssl_server_handshake(NULL, client_p);
908		}
909		#endif
910
911		/* serv_connect_callback() - complete a server connection.
912	<	*
912	>	*
913		* This routine is called after the server connection attempt has
914		* completed. If unsucessful, an error is sent to ops and the client
915		* is closed. If sucessful, it goes through the initialisation/check
#	Line 1485 | Line 920 | static void
920		serv_connect_callback(fde_t *fd, int status, void *data)
921		{
922		struct Client *client_p = data;
923	<	struct ConfItem *conf=NULL;
1489	<	struct AccessItem *aconf=NULL;
923	>	struct MaskItem *conf = NULL;
924
925		/* First, make sure its a real client! */
926	<	assert(client_p != NULL);
926	>	assert(client_p);
927		assert(&client_p->localClient->fd == fd);
928
929		/* Next, for backward purposes, record the ip of the server */
930		memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
931		sizeof(struct irc_ssaddr));
932	+
933		/* Check the status */
934		if (status != COMM_OK)
935		{
#	Line 1502 | Line 937 | serv_connect_callback(fde_t *fd, int sta
937		* Admins get to see any IP, mere opers don't *sigh*
938		*/
939		if (ConfigServerHide.hide_server_ips)
940	<	sendto_realops_flags(UMODE_ALL, L_ADMIN,
940	>	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
941		"Error connecting to %s: %s",
942		client_p->name, comm_errstr(status));
943		else
944	<	sendto_realops_flags(UMODE_ALL, L_ADMIN,
945	<	"Error connecting to %s[%s]: %s", client_p->name,
946	<	client_p->host, comm_errstr(status));
947	<
948	<	sendto_realops_flags(UMODE_ALL, L_OPER,
949	<	"Error connecting to %s: %s",
950	<	client_p->name, comm_errstr(status));
944	>	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
945	>	"Error connecting to %s[%s]: %s", client_p->name,
946	>	client_p->host, comm_errstr(status));
947	>
948	>	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
949	>	"Error connecting to %s: %s",
950	>	client_p->name, comm_errstr(status));
951
952		/* If a fd goes bad, call dead_link() the socket is no
953		* longer valid for reading or writing.
#	Line 1524 | Line 959 | serv_connect_callback(fde_t *fd, int sta
959		/* COMM_OK, so continue the connection procedure */
960		/* Get the C/N lines */
961		conf = find_conf_name(&client_p->localClient->confs,
962	<	client_p->name, SERVER_TYPE);
962	>	client_p->name, CONF_SERVER);
963		if (conf == NULL)
964		{
965	<	sendto_realops_flags(UMODE_ALL, L_ADMIN,
966	<	"Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
967	<	sendto_realops_flags(UMODE_ALL, L_OPER,
968	<	"Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
965	>	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
966	>	"Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
967	>	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
968	>	"Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
969
970	<	exit_client(client_p, &me, "Lost connect{} block");
970	>	exit_client(client_p, "Lost connect{} block");
971		return;
972		}
973
1539	–	aconf = map_to_conf(conf);
974		/* Next, send the initial handshake */
975		SetHandshake(client_p);
976
977		#ifdef HAVE_LIBCRYPTO
978	<	if (IsConfSSL(aconf))
978	>	if (IsConfSSL(conf))
979		{
980	<	ssl_connect_init(client_p, aconf, fd);
980	>	ssl_connect_init(client_p, conf, fd);
981		return;
982		}
983		#endif
984
985	<	/* jdc -- Check and send spasswd, not passwd. */
1552	<	if (!EmptyString(aconf->spasswd))
1553	<	sendto_one(client_p, "PASS %s TS %d %s",
1554	<	aconf->spasswd, TS_CURRENT, me.id);
985	>	sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
986
987	<	send_capabilities(client_p, aconf,
1557	<	(IsConfTopicBurst(aconf) ? CAP_TBURST|CAP_TB : 0));
987	>	send_capabilities(client_p, 0);
988
989	<	sendto_one(client_p, "SERVER %s 1 :%s%s",
990	<	me.name, ConfigServerHide.hidden ? "(H) " : "",
1561	<	me.info);
989	>	sendto_one(client_p, "SERVER %s 1 :%s%s", me.name,
990	>	ConfigServerHide.hidden ? "(H) " : "", me.info);
991
992		/* If we've been marked dead because a send failed, just exit
993		* here now and save everyone the trouble of us ever existing.
994		*/
995	<	if (IsDead(client_p))
995	>	if (IsDead(client_p))
996		{
997	<	sendto_realops_flags(UMODE_ALL, L_ADMIN,
998	<	"%s[%s] went dead during handshake",
997	>	sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
998	>	"%s[%s] went dead during handshake",
999		client_p->name,
1000	<	client_p->host);
1001	<	sendto_realops_flags(UMODE_ALL, L_OPER,
1002	<	"%s went dead during handshake", client_p->name);
1000	>	client_p->host);
1001	>	sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1002	>	"%s went dead during handshake", client_p->name);
1003		return;
1004		}
1005
#	Line 1590 | Line 1019 | find_servconn_in_progress(const char *na
1019		cptr = ptr->data;
1020
1021		if (cptr && cptr->name[0])
1022	<	if (match(name, cptr->name))
1022	>	if (!match(name, cptr->name))
1023		return cptr;
1024		}
1025	<
1025	>
1026		return NULL;
1027		}

Diff Legend

–	Removed lines
+	Added lines
<	Changed lines (old)
>	Changed lines (new)