ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/server.c
(Generate patch)

Comparing:
ircd-hybrid-8/src/s_serv.c (file contents), Revision 1472 by michael, Sun Jul 22 12:03:18 2012 UTC vs.
ircd-hybrid/trunk/src/s_serv.c (file contents), Revision 2216 by michael, Thu Jun 6 17:35:45 2013 UTC

# Line 36 | Line 36
36   #include "fdlist.h"
37   #include "hash.h"
38   #include "irc_string.h"
39 – #include "sprintf_irc.h"
39   #include "ircd.h"
40   #include "ircd_defs.h"
41   #include "s_bsd.h"
# Line 55 | Line 54
54  
55   #define MIN_CONN_FREQ 300
56  
57 + dlink_list flatten_links;
58   static dlink_list cap_list = { NULL, NULL, 0 };
59   static void server_burst(struct Client *);
60   static void burst_all(struct Client *);
# Line 73 | Line 73 | static void burst_members(struct Client
73   *                but in no particular order.
74   */
75   void
76 < write_links_file(void* notused)
76 > write_links_file(void *notused)
77   {
78 <  MessageFileLine *next_mptr = 0;
79 <  MessageFileLine *mptr = 0;
80 <  MessageFileLine *currentMessageLine = 0;
81 <  MessageFileLine *newMessageLine = 0;
82 <  MessageFile *MessageFileptr;
83 <  const char *p;
84 <  FILE *file;
85 <  char buff[512];
86 <  dlink_node *ptr;
87 <
88 <  MessageFileptr = &ConfigFileEntry.linksfile;
78 >  FILE *file = NULL;
79 >  dlink_node *ptr = NULL, *ptr_next = NULL;
80 >  char buff[IRCD_BUFSIZE] = { '\0' };
81  
82 <  if ((file = fopen(MessageFileptr->fileName, "w")) == NULL)
82 >  if ((file = fopen(LIPATH, "w")) == NULL)
83      return;
84  
85 <  for (mptr = MessageFileptr->contentsOfFile; mptr; mptr = next_mptr)
85 >  DLINK_FOREACH_SAFE(ptr, ptr_next, flatten_links.head)
86    {
87 <    next_mptr = mptr->next;
88 <    MyFree(mptr);
87 >    dlinkDelete(ptr, &flatten_links);
88 >    MyFree(ptr->data);
89 >    free_dlink_node(ptr);
90    }
91  
99 –  MessageFileptr->contentsOfFile = NULL;
100 –  currentMessageLine             = NULL;
101 –
92    DLINK_FOREACH(ptr, global_serv_list.head)
93    {
94      const struct Client *target_p = ptr->data;
95  
96 <    /* skip ourselves, we send ourselves in /links */
97 <    if (IsMe(target_p))
96 >    /*
97 >     * Skip hidden servers, aswell as ourselves, since we already send
98 >     * ourselves in /links
99 >     */
100 >    if (IsHidden(target_p) || IsMe(target_p))
101        continue;
102  
103 <    /* skip hidden servers */
111 <    if (IsHidden(target_p) && !ConfigServerHide.disable_hidden)
103 >    if (HasFlag(target_p, FLAGS_SERVICE) && ConfigServerHide.hide_services)
104        continue;
105  
106 <    if (target_p->info[0])
107 <      p = target_p->info;
116 <    else
117 <      p = "(Unknown Location)";
118 <
119 <    newMessageLine = MyMalloc(sizeof(MessageFileLine));
120 <
121 <    /* Attempt to format the file in such a way it follows the usual links output
106 >    /*
107 >     * Attempt to format the file in such a way it follows the usual links output
108       * ie  "servername uplink :hops info"
109       * Mostly for aesthetic reasons - makes it look pretty in mIRC ;)
110       * - madmax
111       */
112 +    snprintf(buff, sizeof(buff), "%s %s :1 %s",   target_p->name,
113 +             me.name, target_p->info);
114 +    dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
115 +    snprintf(buff, sizeof(buff), "%s %s :1 %s\n", target_p->name,
116 +             me.name, target_p->info);
117  
118 <    /*
119 <     * For now, check this ircsprintf wont overflow - it shouldnt on a
129 <     * default config but it is configurable..
130 <     * This should be changed to an snprintf at some point, but I'm wanting to
131 <     * know if this is a cause of a bug - cryogen
132 <     */
133 <    assert(strlen(target_p->name) + strlen(me.name) + 6 + strlen(p) <=
134 <            MESSAGELINELEN);
135 <    snprintf(newMessageLine->line, sizeof(newMessageLine->line), "%s %s :1 %s",
136 <             target_p->name, me.name, p);
137 <    newMessageLine->next = NULL;
118 >    fputs(buff, file);
119 >  }
120  
121 <    if (MessageFileptr->contentsOfFile)
122 <    {
141 <      if (currentMessageLine)
142 <        currentMessageLine->next = newMessageLine;
143 <      currentMessageLine = newMessageLine;
144 <    }
145 <    else
146 <    {
147 <      MessageFileptr->contentsOfFile = newMessageLine;
148 <      currentMessageLine = newMessageLine;
149 <    }
121 >  fclose(file);
122 > }
123  
124 <    snprintf(buff, sizeof(buff), "%s %s :1 %s\n", target_p->name, me.name, p);
125 <    fputs(buff, file);
124 > void
125 > read_links_file(void)
126 > {
127 >  FILE *file = NULL;
128 >  char *p = NULL;
129 >  char buff[IRCD_BUFSIZE] = { '\0' };
130 >
131 >  if ((file = fopen(LIPATH, "r")) == NULL)
132 >    return;
133 >
134 >  while (fgets(buff, sizeof(buff), file))
135 >  {
136 >    if ((p = strchr(buff, '\n')) != NULL)
137 >      *p = '\0';
138 >
139 >    dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
140    }
141  
142    fclose(file);
# Line 176 | Line 163 | write_links_file(void* notused)
163   */
164   int
165   hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
166 <            int server, int parc, char *parv[])
166 >            const int server, const int parc, char *parv[])
167   {
168    struct Client *target_p = NULL;
169    struct Client *target_tmp = NULL;
# Line 187 | Line 174 | hunt_server(struct Client *client_p, str
174    if (parc <= server || EmptyString(parv[server]))
175      return HUNTED_ISME;
176  
177 <  if (!strcmp(parv[server], me.id) || match(parv[server], me.name))
177 >  if (!strcmp(parv[server], me.id) || !match(parv[server], me.name))
178      return HUNTED_ISME;
179  
180    /* These are to pickup matches that would cause the following
# Line 207 | Line 194 | hunt_server(struct Client *client_p, str
194      if (target_p->from == source_p->from && !MyConnect(target_p))
195        target_p = NULL;
196  
210 –  collapse(parv[server]);
197    wilds = has_wildcards(parv[server]);
198  
199    /* Again, if there are no wild cards involved in the server
# Line 221 | Line 207 | hunt_server(struct Client *client_p, str
207        {
208          sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
209                     me.name, source_p->name, parv[server]);
210 <        return(HUNTED_NOSUCH);
210 >        return HUNTED_NOSUCH;
211        }
212      }
213      else
# Line 230 | Line 216 | hunt_server(struct Client *client_p, str
216        {
217          target_tmp = ptr->data;
218  
219 <        if (match(parv[server], target_tmp->name))
219 >        if (!match(parv[server], target_tmp->name))
220          {
221            if (target_tmp->from == source_p->from && !MyConnect(target_tmp))
222              continue;
# Line 255 | Line 241 | hunt_server(struct Client *client_p, str
241      if (IsMe(target_p) || MyClient(target_p))
242        return HUNTED_ISME;
243  
244 <    if (!match(target_p->name, parv[server]))
244 >    if (match(target_p->name, parv[server]))
245        parv[server] = target_p->name;
246  
247      /* This is a little kludgy but should work... */
# Line 267 | Line 253 | hunt_server(struct Client *client_p, str
253      sendto_one(target_p, command, parv[0],
254                 parv[1], parv[2], parv[3], parv[4],
255                 parv[5], parv[6], parv[7], parv[8]);
256 <    return(HUNTED_PASS);
256 >    return HUNTED_PASS;
257    }
258  
259    sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
260               me.name, source_p->name, parv[server]);
261 <  return(HUNTED_NOSUCH);
261 >  return HUNTED_NOSUCH;
262   }
263  
264   /* try_connections()
# Line 288 | Line 274 | hunt_server(struct Client *client_p, str
274   void
275   try_connections(void *unused)
276   {
277 <  dlink_node *ptr;
278 <  struct ConfItem *conf;
293 <  struct AccessItem *aconf;
294 <  struct ClassItem *cltmp;
277 >  dlink_node *ptr = NULL;
278 >  struct MaskItem *conf;
279    int confrq;
280  
281    /* TODO: change this to set active flag to 0 when added to event! --Habeeb */
# Line 301 | Line 285 | try_connections(void *unused)
285    DLINK_FOREACH(ptr, server_items.head)
286    {
287      conf = ptr->data;
288 <    aconf = map_to_conf(conf);
288 >
289 >    assert(conf->type == CONF_SERVER);
290  
291      /* Also when already connecting! (update holdtimes) --SRB
292       */
293 <    if (!(aconf->status & CONF_SERVER) || !aconf->port ||
309 <        !(IsConfAllowAutoConn(aconf)))
293 >    if (!conf->port ||!IsConfAllowAutoConn(conf))
294        continue;
295  
312 –    cltmp = map_to_conf(aconf->class_ptr);
296  
297      /* Skip this entry if the use of it is still on hold until
298       * future. Otherwise handle this entry (and set it on hold
# Line 317 | Line 300 | try_connections(void *unused)
300       * made one successfull connection... [this algorithm is
301       * a bit fuzzy... -- msa >;) ]
302       */
303 <    if (aconf->hold > CurrentTime)
303 >    if (conf->until > CurrentTime)
304        continue;
305  
306 <    if (cltmp == NULL)
306 >    if (conf->class == NULL)
307        confrq = DEFAULT_CONNECTFREQUENCY;
308      else
309      {
310 <      confrq = cltmp->con_freq;
310 >      confrq = conf->class->con_freq;
311        if (confrq < MIN_CONN_FREQ)
312 <        confrq = MIN_CONN_FREQ;
312 >        confrq = MIN_CONN_FREQ;
313      }
314  
315 <    aconf->hold = CurrentTime + confrq;
315 >    conf->until = CurrentTime + confrq;
316  
317      /* Found a CONNECT config with port specified, scan clients
318       * and see if this server is already connected?
# Line 337 | Line 320 | try_connections(void *unused)
320      if (hash_find_server(conf->name) != NULL)
321        continue;
322  
323 <    if (cltmp->curr_user_count < cltmp->max_total)
323 >    if (conf->class->ref_count < conf->class->max_total)
324      {
325        /* Go to the end of the list, if not already last */
326        if (ptr->next != NULL)
# Line 358 | Line 341 | try_connections(void *unused)
341         *   -- adrian
342         */
343        if (ConfigServerHide.hide_server_ips)
344 <        sendto_realops_flags(UMODE_ALL, L_ALL, "Connection to %s activated.",
344 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
345 >                             "Connection to %s activated.",
346                               conf->name);
347        else
348 <        sendto_realops_flags(UMODE_ALL, L_ALL, "Connection to %s[%s] activated.",
349 <                             conf->name, aconf->host);
348 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
349 >                             "Connection to %s[%s] activated.",
350 >                             conf->name, conf->host);
351  
352 <      serv_connect(aconf, NULL);
352 >      serv_connect(conf, NULL);
353        /* We connect only one at time... */
354        return;
355      }
# Line 396 | Line 381 | int
381   check_server(const char *name, struct Client *client_p)
382   {
383    dlink_node *ptr;
384 <  struct ConfItem *conf           = NULL;
385 <  struct ConfItem *server_conf    = NULL;
401 <  struct AccessItem *server_aconf = NULL;
402 <  struct AccessItem *aconf        = NULL;
384 >  struct MaskItem *conf        = NULL;
385 >  struct MaskItem *server_conf = NULL;
386    int error = -1;
387  
388    assert(client_p != NULL);
# Line 408 | Line 391 | check_server(const char *name, struct Cl
391    DLINK_FOREACH(ptr, server_items.head)
392    {
393      conf = ptr->data;
411 –    aconf = map_to_conf(conf);
394  
395 <    if (!match(name, conf->name))
395 >    if (match(name, conf->name))
396        continue;
397  
398      error = -3;
399  
400      /* XXX: Fix me for IPv6                    */
401      /* XXX sockhost is the IPv4 ip as a string */
402 <    if (match(aconf->host, client_p->host) ||
403 <        match(aconf->host, client_p->sockhost))
402 >    if (!match(conf->host, client_p->host) ||
403 >        !match(conf->host, client_p->sockhost))
404      {
405        error = -2;
406  
407 <      if (!match_conf_password(client_p->localClient->passwd, aconf))
407 >      if (!match_conf_password(client_p->localClient->passwd, conf))
408          return -2;
409  
410        server_conf = conf;
# Line 430 | Line 412 | check_server(const char *name, struct Cl
412    }
413  
414    if (server_conf == NULL)
415 <    return(error);
415 >    return error;
416  
417    attach_conf(client_p, server_conf);
418  
437 –  server_aconf = map_to_conf(server_conf);
419  
420 <  if (!IsConfTopicBurst(server_aconf))
440 <    ClearCap(client_p, CAP_TBURST);
441 <
442 <  if (aconf != NULL)
420 >  if (server_conf != NULL)
421    {
422      struct sockaddr_in *v4;
423   #ifdef IPV6
424      struct sockaddr_in6 *v6;
425   #endif
426 <    switch (aconf->aftype)
426 >    switch (server_conf->aftype)
427      {
428   #ifdef IPV6
429        case AF_INET6:
430 <        v6 = (struct sockaddr_in6 *)&aconf->addr;
430 >        v6 = (struct sockaddr_in6 *)&server_conf->addr;
431  
432          if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
433 <          memcpy(&aconf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
433 >          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
434          break;
435   #endif
436        case AF_INET:
437 <        v4 = (struct sockaddr_in *)&aconf->addr;
437 >        v4 = (struct sockaddr_in *)&server_conf->addr;
438  
439          if (v4->sin_addr.s_addr == INADDR_NONE)
440 <          memcpy(&aconf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
440 >          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
441          break;
442      }
443    }
444  
445 <  return(0);
445 >  return 0;
446   }
447  
448   /* add_capability()
# Line 481 | Line 459 | add_capability(const char *capab_name, i
459   {
460    struct Capability *cap = MyMalloc(sizeof(*cap));
461  
462 <  DupString(cap->name, capab_name);
462 >  cap->name = xstrdup(capab_name);
463    cap->cap = cap_flag;
464    dlinkAdd(cap, &cap->node, &cap_list);
465  
# Line 510 | Line 488 | delete_capability(const char *capab_name
488      {
489        if (irccmp(cap->name, capab_name) == 0)
490        {
491 <        default_server_capabs &= ~(cap->cap);
492 <        dlinkDelete(ptr, &cap_list);
493 <        MyFree(cap->name);
494 <        cap->name = NULL;
517 <        MyFree(cap);
491 >        default_server_capabs &= ~(cap->cap);
492 >        dlinkDelete(ptr, &cap_list);
493 >        MyFree(cap->name);
494 >        MyFree(cap);
495        }
496      }
497    }
# Line 529 | Line 506 | delete_capability(const char *capab_name
506   * output       - 0 if not found CAPAB otherwise
507   * side effects - none
508   */
509 < int
509 > unsigned int
510   find_capability(const char *capab)
511   {
512    const dlink_node *ptr = NULL;
# Line 548 | Line 525 | find_capability(const char *capab)
525   /* send_capabilities()
526   *
527   * inputs       - Client pointer to send to
551 – *              - Pointer to AccessItem (for crypt)
528   *              - int flag of capabilities that this server can send
529   * output       - NONE
530   * side effects - send the CAPAB line to a server  -orabidoo
531   *
532   */
533   void
534 < send_capabilities(struct Client *client_p, struct AccessItem *aconf,
559 <                  int cap_can_send)
534 > send_capabilities(struct Client *client_p, int cap_can_send)
535   {
536    struct Capability *cap=NULL;
537    char msgbuf[IRCD_BUFSIZE];
# Line 572 | Line 547 | send_capabilities(struct Client *client_
547  
548      if (cap->cap & (cap_can_send|default_server_capabs))
549      {
550 <      tl = ircsprintf(t, "%s ", cap->name);
550 >      tl = sprintf(t, "%s ", cap->name);
551        t += tl;
552      }
553    }
# Line 604 | Line 579 | sendnick_TS(struct Client *client_p, str
579      ubuf[1] = '\0';
580    }
581  
607 –  /* XXX Both of these need to have a :me.name or :mySID!?!?! */
582    if (IsCapable(client_p, CAP_SVS))
583    {
584      if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
585 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %lu :%s",
585 >      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
586                   target_p->servptr->id,
587                   target_p->name, target_p->hopcount + 1,
588                   (unsigned long) target_p->tsinfo,
589                   ubuf, target_p->username, target_p->host,
590                   (MyClient(target_p) && IsIPSpoof(target_p)) ?
591                   "0" : target_p->sockhost, target_p->id,
592 <                 (unsigned long)target_p->servicestamp, target_p->info);
592 >                 target_p->svid, target_p->info);
593      else
594 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s %lu :%s",
594 >      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s %s :%s",
595                   target_p->name, target_p->hopcount + 1,
596                   (unsigned long) target_p->tsinfo,
597                   ubuf, target_p->username, target_p->host,
598 <                 target_p->servptr->name, (unsigned long)target_p->servicestamp,
598 >                 target_p->servptr->name, target_p->svid,
599                   target_p->info);
600    }
601    else
# Line 642 | Line 616 | sendnick_TS(struct Client *client_p, str
616                   target_p->servptr->name, target_p->info);
617    }
618  
619 <  if (IsConfAwayBurst((struct AccessItem *)map_to_conf(client_p->localClient->confs.head->data)))
620 <    if (!EmptyString(target_p->away))
621 <      sendto_one(client_p, ":%s AWAY :%s", ID_or_name(target_p, client_p),
648 <                 target_p->away);
619 >  if (target_p->away[0])
620 >    sendto_one(client_p, ":%s AWAY :%s", ID_or_name(target_p, client_p),
621 >               target_p->away);
622  
623   }
624  
# Line 663 | Line 636 | show_capabilities(struct Client *target_
636    char *t = msgbuf;
637    dlink_node *ptr;
638  
639 <  t += ircsprintf(msgbuf, "TS ");
639 >  t += sprintf(msgbuf, "TS ");
640  
641    DLINK_FOREACH(ptr, cap_list.head)
642    {
643      const struct Capability *cap = ptr->data;
644  
645      if (IsCapable(target_p, cap->cap))
646 <      t += ircsprintf(t, "%s ", cap->name);
646 >      t += sprintf(t, "%s ", cap->name);
647    }
648  
649    *(t - 1) = '\0';
# Line 703 | Line 676 | void
676   server_estab(struct Client *client_p)
677   {
678    struct Client *target_p;
679 <  struct ConfItem *conf;
707 <  struct AccessItem *aconf=NULL;
679 >  struct MaskItem *conf = NULL;
680    char *host;
681    const char *inpath;
682    static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
# Line 720 | Line 692 | server_estab(struct Client *client_p)
692    inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
693    host   = client_p->name;
694  
695 <  if ((conf = find_conf_name(&client_p->localClient->confs, host, SERVER_TYPE))
695 >  if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
696        == NULL)
697    {
698      /* This shouldn't happen, better tell the ops... -A1kmm */
699 <    sendto_realops_flags(UMODE_ALL, L_ALL, "Warning: Lost connect{} block "
699 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
700 >                         "Warning: Lost connect{} block "
701                           "for server %s(this shouldn't happen)!", host);
702      exit_client(client_p, &me, "Lost connect{} block!");
703      return;
# Line 750 | Line 723 | server_estab(struct Client *client_p)
723      }
724    }
725  
753 –  aconf = map_to_conf(conf);
754 –
726    if (IsUnknown(client_p))
727    {
728 <    /* jdc -- 1.  Use EmptyString(), not [0] index reference.
758 <     *        2.  Check aconf->spasswd, not aconf->passwd.
759 <     */
760 <    if (!EmptyString(aconf->spasswd))
761 <      sendto_one(client_p, "PASS %s TS %d %s",
762 <                 aconf->spasswd, TS_CURRENT, me.id);
763 <
764 <    /* Pass my info to the new server
765 <     *
766 <     * Pass on ZIP if supported
767 <     * Pass on TB if supported.
768 <     * - Dianora
769 <     */
728 >    sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
729  
730 <    send_capabilities(client_p, aconf,
772 <      (IsConfTopicBurst(aconf) ? CAP_TBURST : 0));
730 >    send_capabilities(client_p, 0);
731  
732      sendto_one(client_p, "SERVER %s 1 :%s%s",
733                 me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
# Line 783 | Line 741 | server_estab(struct Client *client_p)
741      hash_add_id(client_p);
742  
743    /* XXX Does this ever happen? I don't think so -db */
744 <  detach_conf(client_p, OPER_TYPE);
744 >  detach_conf(client_p, CONF_OPER);
745  
746    /* *WARNING*
747    **    In the following code in place of plain server's
# Line 825 | Line 783 | server_estab(struct Client *client_p)
783    /* fixing eob timings.. -gnp */
784    client_p->localClient->firsttime = CurrentTime;
785  
786 <  if (find_matching_name_conf(SERVICE_TYPE, client_p->name, NULL, NULL, 0))
786 >  if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
787      AddFlag(client_p, FLAGS_SERVICE);
788  
789    /* Show the real host/IP to admins */
# Line 835 | Line 793 | server_estab(struct Client *client_p)
793      compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
794      expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
795  
796 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
796 >    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
797                           "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
798                           inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
799                           compression ? SSL_COMP_get_name(compression) : "NONE",
800                           expansion ? SSL_COMP_get_name(expansion) : "NONE",
801                           show_capabilities(client_p));
802      /* Now show the masked hostname/IP to opers */
803 <    sendto_realops_flags(UMODE_ALL, L_OPER,
803 >    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
804                           "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
805                           inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
806                           compression ? SSL_COMP_get_name(compression) : "NONE",
# Line 857 | Line 815 | server_estab(struct Client *client_p)
815    else
816   #endif
817    {
818 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
818 >    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
819                           "Link with %s established: (Capabilities: %s)",
820 <                         inpath_ip,show_capabilities(client_p));
820 >                         inpath_ip, show_capabilities(client_p));
821      /* Now show the masked hostname/IP to opers */
822 <    sendto_realops_flags(UMODE_ALL, L_OPER,
822 >    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
823                           "Link with %s established: (Capabilities: %s)",
824 <                         inpath,show_capabilities(client_p));
824 >                         inpath, show_capabilities(client_p));
825      ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
826           inpath_ip, show_capabilities(client_p));
827    }
# Line 935 | Line 893 | server_estab(struct Client *client_p)
893        sendto_one(client_p, ":%s SERVER %s %d :%s%s",
894                   target_p->servptr->name, target_p->name, target_p->hopcount+1,
895                   IsHidden(target_p) ? "(H) " : "", target_p->info);
896 +
897 +    if (HasFlag(target_p, FLAGS_EOB))
898 +      sendto_one(client_p, ":%s EOB", ID_or_name(client_p, target_p));
899    }
900  
901    server_burst(client_p);
# Line 989 | Line 950 | burst_all(struct Client *client_p)
950        send_channel_modes(client_p, chptr);
951  
952        if (IsCapable(client_p, CAP_TBURST))
953 <        send_tb(client_p, chptr);
953 >        send_tb(client_p, chptr);
954      }
955    }
956  
# Line 1005 | Line 966 | burst_all(struct Client *client_p)
966      DelFlag(target_p, FLAGS_BURSTED);
967    }
968  
1008 –  /* We send the time we started the burst, and let the remote host determine an EOB time,
1009 –  ** as otherwise we end up sending a EOB of 0   Sending here means it gets sent last -- fl
1010 –  */
1011 –  /* Its simpler to just send EOB and use the time its been connected.. --fl_ */
969    if (IsCapable(client_p, CAP_EOB))
970      sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
971   }
# Line 1098 | Line 1055 | burst_members(struct Client *client_p, s
1055   * it suceeded or not, and 0 if it fails in here somewhere.
1056   */
1057   int
1058 < serv_connect(struct AccessItem *aconf, struct Client *by)
1058 > serv_connect(struct MaskItem *conf, struct Client *by)
1059   {
1103 –  struct ConfItem *conf;
1060    struct Client *client_p;
1061    char buf[HOSTIPLEN + 1];
1062  
1063    /* conversion structs */
1064    struct sockaddr_in *v4;
1065 <  /* Make sure aconf is useful */
1066 <  assert(aconf != NULL);
1065 >  /* Make sure conf is useful */
1066 >  assert(conf != NULL);
1067  
1112 –  /* XXX should be passing struct ConfItem in the first place */
1113 –  conf = unmap_conf_item(aconf);
1068  
1069 <  /* log */
1116 <  getnameinfo((struct sockaddr *)&aconf->addr, aconf->addr.ss_len,
1069 >  getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
1070                buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
1071 <  ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", conf->name, aconf->host,
1071 >  ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", conf->name, conf->host,
1072         buf);
1073  
1074    /* Still processing a DNS lookup? -> exit */
1075 <  if (aconf->dns_pending)
1075 >  if (conf->dns_pending)
1076    {
1077 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1077 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1078                           "Error connecting to %s: DNS lookup for connect{} in progress.",
1079                           conf->name);
1080      return (0);
1081    }
1082  
1083 <  if (aconf->dns_failed)
1083 >  if (conf->dns_failed)
1084    {
1085 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1085 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1086                           "Error connecting to %s: DNS lookup for connect{} failed.",
1087                           conf->name);
1088      return (0);
1089    }
1090  
1091    /* Make sure this server isn't already connected
1092 <   * Note: aconf should ALWAYS be a valid C: line
1092 >   * Note: conf should ALWAYS be a valid C: line
1093     */
1094    if ((client_p = hash_find_server(conf->name)) != NULL)
1095    {
1096 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
1097 <                         "Server %s already present from %s",
1098 <                         conf->name, get_client_name(client_p, SHOW_IP));
1099 <    sendto_realops_flags(UMODE_ALL, L_OPER,
1100 <                         "Server %s already present from %s",
1101 <                         conf->name, get_client_name(client_p, MASK_IP));
1096 >    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1097 >                         "Server %s already present from %s",
1098 >                         conf->name, get_client_name(client_p, SHOW_IP));
1099 >    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1100 >                         "Server %s already present from %s",
1101 >                         conf->name, get_client_name(client_p, MASK_IP));
1102      if (by && IsClient(by) && !MyClient(by))
1103        sendto_one(by, ":%s NOTICE %s :Server %s already present from %s",
1104 <                 me.name, by->name, conf->name,
1105 <                 get_client_name(client_p, MASK_IP));
1106 <    return (0);
1104 >                 me.name, by->name, conf->name,
1105 >                 get_client_name(client_p, MASK_IP));
1106 >    return 0;
1107    }
1108      
1109    /* Create a local client */
# Line 1158 | Line 1111 | serv_connect(struct AccessItem *aconf, s
1111  
1112    /* Copy in the server, hostname, fd */
1113    strlcpy(client_p->name, conf->name, sizeof(client_p->name));
1114 <  strlcpy(client_p->host, aconf->host, sizeof(client_p->host));
1114 >  strlcpy(client_p->host, conf->host, sizeof(client_p->host));
1115  
1116    /* We already converted the ip once, so lets use it - stu */
1117    strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
1118  
1119    /* create a socket for the server connection */
1120 <  if (comm_open(&client_p->localClient->fd, aconf->addr.ss.ss_family,
1120 >  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1121                  SOCK_STREAM, 0, NULL) < 0)
1122    {
1123      /* Eek, failure to create the socket */
1124 <    report_error(L_ALL,
1125 <                 "opening stream socket to %s: %s", conf->name, errno);
1124 >    report_error(L_ALL, "opening stream socket to %s: %s",
1125 >                 conf->name, errno);
1126      SetDead(client_p);
1127      exit_client(client_p, &me, "Connection failed");
1128 <    return (0);
1128 >    return 0;
1129    }
1130  
1131    /* servernames are always guaranteed under HOSTLEN chars */
# Line 1181 | Line 1134 | serv_connect(struct AccessItem *aconf, s
1134    /* Attach config entries to client here rather than in
1135     * serv_connect_callback(). This to avoid null pointer references.
1136     */
1137 <  if (!attach_connect_block(client_p, conf->name, aconf->host))
1137 >  if (!attach_connect_block(client_p, conf->name, conf->host))
1138    {
1139 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1140 <                         "Host %s is not enabled for connecting:no C/N-line",
1141 <                         conf->name);
1139 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1140 >                         "Host %s is not enabled for connecting: no connect{} block",
1141 >                         conf->name);
1142      if (by && IsClient(by) && !MyClient(by))  
1143        sendto_one(by, ":%s NOTICE %s :Connect to host %s failed.",
1144 <                 me.name, by->name, client_p->name);
1144 >                 me.name, by->name, client_p->name);
1145      SetDead(client_p);
1146      exit_client(client_p, client_p, "Connection failed");
1147 <    return (0);
1147 >    return 0;
1148    }
1149  
1150    /* at this point we have a connection in progress and C/N lines
# Line 1210 | Line 1163 | serv_connect(struct AccessItem *aconf, s
1163    SetConnecting(client_p);
1164    dlinkAdd(client_p, &client_p->node, &global_client_list);
1165    /* from def_fam */
1166 <  client_p->localClient->aftype = aconf->aftype;
1166 >  client_p->localClient->aftype = conf->aftype;
1167  
1168    /* Now, initiate the connection */
1169    /* XXX assume that a non 0 type means a specific bind address
1170     * for this connect.
1171     */
1172 <  switch (aconf->aftype)
1172 >  switch (conf->aftype)
1173    {
1174      case AF_INET:
1175 <      v4 = (struct sockaddr_in*)&aconf->bind;
1175 >      v4 = (struct sockaddr_in*)&conf->bind;
1176        if (v4->sin_addr.s_addr != 0)
1177        {
1178          struct irc_ssaddr ipn;
1179          memset(&ipn, 0, sizeof(struct irc_ssaddr));
1180          ipn.ss.ss_family = AF_INET;
1181          ipn.ss_port = 0;
1182 <        memcpy(&ipn, &aconf->bind, sizeof(struct irc_ssaddr));
1183 <        comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
1184 <                         (struct sockaddr *)&ipn, ipn.ss_len,
1185 <                         serv_connect_callback, client_p, aconf->aftype,
1186 <                         CONNECTTIMEOUT);
1182 >        memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
1183 >        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
1184 >                         (struct sockaddr *)&ipn, ipn.ss_len,
1185 >                         serv_connect_callback, client_p, conf->aftype,
1186 >                         CONNECTTIMEOUT);
1187        }
1188        else if (ServerInfo.specific_ipv4_vhost)
1189        {
# Line 1239 | Line 1192 | serv_connect(struct AccessItem *aconf, s
1192          ipn.ss.ss_family = AF_INET;
1193          ipn.ss_port = 0;
1194          memcpy(&ipn, &ServerInfo.ip, sizeof(struct irc_ssaddr));
1195 <        comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
1195 >        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
1196                           (struct sockaddr *)&ipn, ipn.ss_len,
1197 <                         serv_connect_callback, client_p, aconf->aftype,
1198 <                         CONNECTTIMEOUT);
1197 >                         serv_connect_callback, client_p, conf->aftype,
1198 >                         CONNECTTIMEOUT);
1199        }
1200        else
1201 <        comm_connect_tcp(&client_p->localClient->fd, aconf->host, aconf->port,
1202 <                         NULL, 0, serv_connect_callback, client_p, aconf->aftype,
1201 >        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
1202 >                         NULL, 0, serv_connect_callback, client_p, conf->aftype,
1203                           CONNECTTIMEOUT);
1204        break;
1205   #ifdef IPV6
1206      case AF_INET6:
1207        {
1208 <        struct irc_ssaddr ipn;
1209 <        struct sockaddr_in6 *v6;
1210 <        struct sockaddr_in6 *v6conf;
1211 <
1212 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
1213 <        v6conf = (struct sockaddr_in6 *)&aconf->bind;
1214 <        v6 = (struct sockaddr_in6 *)&ipn;
1215 <
1216 <        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr,
1264 <                   sizeof(struct in6_addr)) != 0)
1265 <        {
1266 <          memcpy(&ipn, &aconf->bind, sizeof(struct irc_ssaddr));
1267 <          ipn.ss.ss_family = AF_INET6;
1268 <          ipn.ss_port = 0;
1269 <          comm_connect_tcp(&client_p->localClient->fd,
1270 <                           aconf->host, aconf->port,
1271 <                           (struct sockaddr *)&ipn, ipn.ss_len,
1272 <                           serv_connect_callback, client_p,
1273 <                           aconf->aftype, CONNECTTIMEOUT);
1274 <        }
1275 <        else if (ServerInfo.specific_ipv6_vhost)
1208 >        struct irc_ssaddr ipn;
1209 >        struct sockaddr_in6 *v6;
1210 >        struct sockaddr_in6 *v6conf;
1211 >
1212 >        memset(&ipn, 0, sizeof(struct irc_ssaddr));
1213 >        v6conf = (struct sockaddr_in6 *)&conf->bind;
1214 >        v6 = (struct sockaddr_in6 *)&ipn;
1215 >
1216 >        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)) != 0)
1217          {
1218 <          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
1219 <          ipn.ss.ss_family = AF_INET6;
1220 <          ipn.ss_port = 0;
1221 <          comm_connect_tcp(&client_p->localClient->fd,
1222 <                           aconf->host, aconf->port,
1223 <                           (struct sockaddr *)&ipn, ipn.ss_len,
1224 <                           serv_connect_callback, client_p,
1225 <                           aconf->aftype, CONNECTTIMEOUT);
1226 <        }
1227 <        else
1228 <          comm_connect_tcp(&client_p->localClient->fd,
1229 <                           aconf->host, aconf->port,
1230 <                           NULL, 0, serv_connect_callback, client_p,
1231 <                           aconf->aftype, CONNECTTIMEOUT);
1218 >          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
1219 >          ipn.ss.ss_family = AF_INET6;
1220 >          ipn.ss_port = 0;
1221 >          comm_connect_tcp(&client_p->localClient->fd,
1222 >                           conf->host, conf->port,
1223 >                           (struct sockaddr *)&ipn, ipn.ss_len,
1224 >                           serv_connect_callback, client_p,
1225 >                           conf->aftype, CONNECTTIMEOUT);
1226 >        }
1227 >        else if (ServerInfo.specific_ipv6_vhost)
1228 >        {
1229 >          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
1230 >          ipn.ss.ss_family = AF_INET6;
1231 >          ipn.ss_port = 0;
1232 >          comm_connect_tcp(&client_p->localClient->fd,
1233 >                           conf->host, conf->port,
1234 >                           (struct sockaddr *)&ipn, ipn.ss_len,
1235 >                           serv_connect_callback, client_p,
1236 >                           conf->aftype, CONNECTTIMEOUT);
1237 >        }
1238 >        else
1239 >          comm_connect_tcp(&client_p->localClient->fd,
1240 >                           conf->host, conf->port,
1241 >                           NULL, 0, serv_connect_callback, client_p,
1242 >                           conf->aftype, CONNECTTIMEOUT);
1243        }
1244   #endif
1245    }
1246 <  return (1);
1246 >  return 1;
1247   }
1248  
1249   #ifdef HAVE_LIBCRYPTO
1250   static void
1251   finish_ssl_server_handshake(struct Client *client_p)
1252   {
1253 <  struct ConfItem *conf=NULL;
1302 <  struct AccessItem *aconf=NULL;
1253 >  struct MaskItem *conf = NULL;
1254  
1255    conf = find_conf_name(&client_p->localClient->confs,
1256 <                        client_p->name, SERVER_TYPE);
1256 >                        client_p->name, CONF_SERVER);
1257    if (conf == NULL)
1258    {
1259 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
1259 >    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1260                           "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
1261 <    sendto_realops_flags(UMODE_ALL, L_OPER,
1261 >    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1262                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
1263  
1264      exit_client(client_p, &me, "Lost connect{} block");
1265      return;
1266    }
1267  
1268 <  aconf = map_to_conf(conf);
1268 >  sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
1269  
1270 <  /* jdc -- Check and send spasswd, not passwd. */
1320 <  if (!EmptyString(aconf->spasswd))
1321 <    sendto_one(client_p, "PASS %s TS %d %s",
1322 <               aconf->spasswd, TS_CURRENT, me.id);
1323 <
1324 <  send_capabilities(client_p, aconf,
1325 <                   (IsConfTopicBurst(aconf) ? CAP_TBURST : 0));
1270 >  send_capabilities(client_p, 0);
1271  
1272    sendto_one(client_p, "SERVER %s 1 :%s%s",
1273               me.name, ConfigServerHide.hidden ? "(H) " : "",
# Line 1333 | Line 1278 | finish_ssl_server_handshake(struct Clien
1278     */
1279    if (IsDead(client_p))
1280    {
1281 <      sendto_realops_flags(UMODE_ALL, L_ADMIN,
1281 >      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1282                             "%s[%s] went dead during handshake",
1283                             client_p->name,
1284                             client_p->host);
1285 <      sendto_realops_flags(UMODE_ALL, L_OPER,
1285 >      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1286                             "%s went dead during handshake", client_p->name);
1287        return;
1288    }
# Line 1370 | Line 1315 | ssl_server_handshake(fde_t *fd, struct C
1315        default:
1316        {
1317          const char *sslerr = ERR_error_string(ERR_get_error(), NULL);
1318 <        sendto_realops_flags(UMODE_ALL, L_ALL,
1318 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1319                               "Error connecting to %s: %s", client_p->name,
1320                               sslerr ? sslerr : "unknown SSL error");
1321          exit_client(client_p, client_p, "Error during SSL handshake");
# Line 1383 | Line 1328 | ssl_server_handshake(fde_t *fd, struct C
1328   }
1329  
1330   static void
1331 < ssl_connect_init(struct Client *client_p, struct AccessItem *aconf, fde_t *fd)
1331 > ssl_connect_init(struct Client *client_p, struct MaskItem *conf, fde_t *fd)
1332   {
1333    if ((client_p->localClient->fd.ssl = SSL_new(ServerInfo.client_ctx)) == NULL)
1334    {
# Line 1396 | Line 1341 | ssl_connect_init(struct Client *client_p
1341  
1342    SSL_set_fd(fd->ssl, fd->fd);
1343  
1344 <  if (!EmptyString(aconf->cipher_list))
1345 <    SSL_set_cipher_list(client_p->localClient->fd.ssl, aconf->cipher_list);
1344 >  if (!EmptyString(conf->cipher_list))
1345 >    SSL_set_cipher_list(client_p->localClient->fd.ssl, conf->cipher_list);
1346  
1347    ssl_server_handshake(NULL, client_p);
1348   }
# Line 1415 | Line 1360 | static void
1360   serv_connect_callback(fde_t *fd, int status, void *data)
1361   {
1362    struct Client *client_p = data;
1363 <  struct ConfItem *conf=NULL;
1419 <  struct AccessItem *aconf=NULL;
1363 >  struct MaskItem *conf = NULL;
1364  
1365    /* First, make sure its a real client! */
1366    assert(client_p != NULL);
# Line 1432 | Line 1376 | serv_connect_callback(fde_t *fd, int sta
1376       * Admins get to see any IP, mere opers don't *sigh*
1377       */
1378       if (ConfigServerHide.hide_server_ips)
1379 <       sendto_realops_flags(UMODE_ALL, L_ADMIN,
1379 >       sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1380                              "Error connecting to %s: %s",
1381                              client_p->name, comm_errstr(status));
1382       else
1383 <       sendto_realops_flags(UMODE_ALL, L_ADMIN,
1384 <                            "Error connecting to %s[%s]: %s", client_p->name,
1385 <                            client_p->host, comm_errstr(status));
1386 <
1387 <     sendto_realops_flags(UMODE_ALL, L_OPER,
1388 <                          "Error connecting to %s: %s",
1389 <                          client_p->name, comm_errstr(status));
1383 >       sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1384 >                            "Error connecting to %s[%s]: %s", client_p->name,
1385 >                            client_p->host, comm_errstr(status));
1386 >
1387 >     sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1388 >                          "Error connecting to %s: %s",
1389 >                          client_p->name, comm_errstr(status));
1390  
1391       /* If a fd goes bad, call dead_link() the socket is no
1392        * longer valid for reading or writing.
# Line 1454 | Line 1398 | serv_connect_callback(fde_t *fd, int sta
1398    /* COMM_OK, so continue the connection procedure */
1399    /* Get the C/N lines */
1400    conf = find_conf_name(&client_p->localClient->confs,
1401 <                        client_p->name, SERVER_TYPE);
1401 >                        client_p->name, CONF_SERVER);
1402    if (conf == NULL)
1403    {
1404 <    sendto_realops_flags(UMODE_ALL, L_ADMIN,
1405 <                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
1406 <    sendto_realops_flags(UMODE_ALL, L_OPER,
1407 <                         "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
1404 >    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1405 >                         "Lost connect{} block for %s", get_client_name(client_p, HIDE_IP));
1406 >    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1407 >                         "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
1408  
1409      exit_client(client_p, &me, "Lost connect{} block");
1410      return;
1411    }
1412  
1469 –  aconf = map_to_conf(conf);
1413    /* Next, send the initial handshake */
1414    SetHandshake(client_p);
1415  
1416   #ifdef HAVE_LIBCRYPTO
1417 <  if (IsConfSSL(aconf))
1417 >  if (IsConfSSL(conf))
1418    {
1419 <    ssl_connect_init(client_p, aconf, fd);
1419 >    ssl_connect_init(client_p, conf, fd);
1420      return;
1421    }
1422   #endif
1423  
1424 <  /* jdc -- Check and send spasswd, not passwd. */
1482 <  if (!EmptyString(aconf->spasswd))
1483 <    sendto_one(client_p, "PASS %s TS %d %s",
1484 <               aconf->spasswd, TS_CURRENT, me.id);
1424 >  sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
1425  
1426 <  send_capabilities(client_p, aconf,
1487 <                   (IsConfTopicBurst(aconf) ? CAP_TBURST : 0));
1426 >  send_capabilities(client_p, 0);
1427  
1428 <  sendto_one(client_p, "SERVER %s 1 :%s%s",
1429 <             me.name, ConfigServerHide.hidden ? "(H) " : "",
1491 <             me.info);
1428 >  sendto_one(client_p, "SERVER %s 1 :%s%s", me.name,
1429 >             ConfigServerHide.hidden ? "(H) " : "", me.info);
1430  
1431    /* If we've been marked dead because a send failed, just exit
1432     * here now and save everyone the trouble of us ever existing.
1433     */
1434    if (IsDead(client_p))
1435    {
1436 <      sendto_realops_flags(UMODE_ALL, L_ADMIN,
1437 <                           "%s[%s] went dead during handshake",
1436 >      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1437 >                           "%s[%s] went dead during handshake",
1438                             client_p->name,
1439 <                           client_p->host);
1440 <      sendto_realops_flags(UMODE_ALL, L_OPER,
1441 <                           "%s went dead during handshake", client_p->name);
1439 >                           client_p->host);
1440 >      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1441 >                           "%s went dead during handshake", client_p->name);
1442        return;
1443    }
1444  
# Line 1520 | Line 1458 | find_servconn_in_progress(const char *na
1458      cptr = ptr->data;
1459  
1460      if (cptr && cptr->name[0])
1461 <      if (match(name, cptr->name))
1461 >      if (!match(name, cptr->name))
1462          return cptr;
1463    }
1464    

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)