ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/send.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/send.c (file contents):
Revision 4780 by michael, Tue Oct 21 16:30:03 2014 UTC vs.
Revision 8036 by michael, Fri Mar 17 17:49:22 2017 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2017 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 32 | Line 32
32   #include "dbuf.h"
33   #include "irc_string.h"
34   #include "ircd.h"
35 – #include "numeric.h"
36 – #include "fdlist.h"
35   #include "s_bsd.h"
36   #include "server.h"
37 < #include "conf.h"
37 > #include "conf_class.h"
38   #include "log.h"
41 – #include "memory.h"
42 – #include "packet.h"
39  
40  
41 < static uint64_t current_serial;
41 > static uintmax_t current_serial;
42  
43  
44   /* send_format()
# Line 88 | Line 84 | send_message(struct Client *to, struct d
84   {
85    assert(!IsMe(to));
86    assert(to != &me);
87 +  assert(MyConnect(to));
88  
89    if (dbuf_length(&to->connection->buf_sendq) + buf->size > get_sendq(&to->connection->confs))
90    {
91      if (IsServer(to))
92 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
93 <                           "Max SendQ limit exceeded for %s: %lu > %u",
94 <                           get_client_name(to, HIDE_IP),
95 <                           (unsigned long)(dbuf_length(&to->connection->buf_sendq) + buf->size),
92 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
93 >                           "Max SendQ limit exceeded for %s: %zu > %u",
94 >                           client_get_name(to, HIDE_IP),
95 >                           (dbuf_length(&to->connection->buf_sendq) + buf->size),
96                             get_sendq(&to->connection->confs));
97 +
98      if (IsClient(to))
99 <      SetSendQExceeded(to);
99 >      AddFlag(to, FLAGS_SENDQEX);
100  
101      dead_link_on_write(to, 0);
102      return;
# Line 128 | Line 126 | send_message(struct Client *to, struct d
126   *
127   */
128   static void
129 < send_message_remote(struct Client *to, struct Client *from, struct dbuf_block *buf)
129 > send_message_remote(struct Client *to, const struct Client *from, struct dbuf_block *buf)
130   {
131 <  to = to->from;
131 >  assert(MyConnect(to));
132 >  assert(IsServer(to));
133 >  assert(!IsMe(to));
134 >  assert(to->from == to);
135  
136 <  if (!MyConnect(to))
136 >  if (to == from->from)
137    {
138 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
139 <                         "Server send message to %s [%s] dropped from %s(Not local server)",
140 <                         to->name, to->from->name, from->name);
140 <    return;
141 <  }
142 <
143 <  /* Optimize by checking if (from && to) before everything */
144 <  /* we set to->from up there.. */
145 <
146 <  if (!MyClient(from) && IsClient(to) && (to == from->from))
147 <  {
148 <    if (IsServer(from))
149 <    {
150 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
151 <                           "Send message to %s [%s] dropped from %s(Fake Dir)",
152 <                           to->name, to->from->name, from->name);
153 <      return;
154 <    }
155 <
156 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
157 <                         "Ghosted: %s[%s@%s] from %s[%s@%s] (%s)",
158 <                         to->name, to->username, to->host,
159 <                         from->name, from->username, from->host,
160 <                         to->from->name);
161 <
162 <    sendto_server(NULL, NOCAPS, NOCAPS,
163 <                  ":%s KILL %s :%s (%s[%s@%s] Ghosted %s)",
164 <                  me.id, to->id, me.name, to->name,
165 <                  to->username, to->host, to->from->name);
166 <
167 <    AddFlag(to, FLAGS_KILLED);
168 <
169 <    if (IsClient(from))
170 <      sendto_one_numeric(from, &me, ERR_GHOSTEDCLIENT, to->name,
171 <                         to->username, to->host, to->from);
172 <
173 <    exit_client(to, "Ghosted client");
138 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
139 >                         "Send message to %s dropped from %s (Fake Dir)",
140 >                         to->name, from->name);
141      return;
142    }
143  
# Line 184 | Line 151 | send_message_remote(struct Client *to, s
151   void
152   sendq_unblocked(fde_t *fd, void *data)
153   {
154 <  struct Client *client_p = data;
154 >  struct Client *const client_p = data;
155    assert(fd == &client_p->connection->fd);
156  
157    DelFlag(client_p, FLAGS_BLOCKED);
# Line 201 | Line 168 | void
168   send_queued_write(struct Client *to)
169   {
170    int retlen = 0;
171 +  int want_read = 0;
172  
173    /*
174     ** Once socket is marked dead, we cannot start writing to it,
# Line 214 | Line 182 | send_queued_write(struct Client *to)
182    {
183      do
184      {
185 <      struct dbuf_block *first = to->connection->buf_sendq.blocks.head->data;
185 >      const struct dbuf_block *first = to->connection->buf_sendq.blocks.head->data;
186  
187 < #ifdef HAVE_LIBCRYPTO
220 <      if (to->connection->fd.ssl)
187 >      if (tls_isusing(&to->connection->fd.ssl))
188        {
189 <        retlen = SSL_write(to->connection->fd.ssl, first->data + to->connection->buf_sendq.pos, first->size - to->connection->buf_sendq.pos);
189 >        retlen = tls_write(&to->connection->fd.ssl, first->data + to->connection->buf_sendq.pos,
190 >                                                    first->size - to->connection->buf_sendq.pos, &want_read);
191  
192 <        /* translate openssl error codes, sigh */
193 <        if (retlen < 0)
226 <        {
227 <          switch (SSL_get_error(to->connection->fd.ssl, retlen))
228 <          {
229 <            case SSL_ERROR_WANT_READ:
230 <              return;  /* retry later, don't register for write events */
231 <            case SSL_ERROR_WANT_WRITE:
232 <              errno = EWOULDBLOCK;
233 <            case SSL_ERROR_SYSCALL:
234 <              break;
235 <            case SSL_ERROR_SSL:
236 <              if (errno == EAGAIN)
237 <                break;
238 <            default:
239 <              retlen = errno = 0;  /* either an SSL-specific error or EOF */
240 <          }
241 <        }
192 >        if (want_read)
193 >          return;  /* Retry later, don't register for write events */
194        }
195        else
196 < #endif
197 <        retlen = send(to->connection->fd.fd, first->data + to->connection->buf_sendq.pos, first->size - to->connection->buf_sendq.pos, 0);
196 >        retlen = send(to->connection->fd.fd, first->data + to->connection->buf_sendq.pos,
197 >                                             first->size - to->connection->buf_sendq.pos, 0);
198  
199        if (retlen <= 0)
200          break;
# Line 259 | Line 211 | send_queued_write(struct Client *to)
211        AddFlag(to, FLAGS_BLOCKED);
212  
213        /* we have a non-fatal error, reschedule a write */
214 <      comm_setselect(&to->connection->fd, COMM_SELECT_WRITE,
263 <                     sendq_unblocked, to, 0);
214 >      comm_setselect(&to->connection->fd, COMM_SELECT_WRITE, sendq_unblocked, to, 0);
215      }
216      else if (retlen <= 0)
217      {
# Line 279 | Line 230 | send_queued_write(struct Client *to)
230   void
231   send_queued_all(void)
232   {
233 <  dlink_node *ptr;
233 >  dlink_node *node = NULL;
234  
235    /* Servers are processed first, mainly because this can generate
236     * a notice to opers, which is to be delivered by this function.
237     */
238 <  DLINK_FOREACH(ptr, local_server_list.head)
239 <    send_queued_write(ptr->data);
238 >  DLINK_FOREACH(node, local_server_list.head)
239 >    send_queued_write(node->data);
240  
241 <  DLINK_FOREACH(ptr, unknown_list.head)
242 <    send_queued_write(ptr->data);
241 >  DLINK_FOREACH(node, unknown_list.head)
242 >    send_queued_write(node->data);
243  
244 <  DLINK_FOREACH(ptr, local_client_list.head)
245 <    send_queued_write(ptr->data);
244 >  DLINK_FOREACH(node, local_client_list.head)
245 >    send_queued_write(node->data);
246  
247    /* NOTE: This can still put clients on aborted_list; unfortunately,
248     * exit_aborted_clients takes precedence over send_queued_all,
# Line 312 | Line 263 | void
263   sendto_one(struct Client *to, const char *pattern, ...)
264   {
265    va_list args;
315 –  struct dbuf_block *buffer = NULL;
266  
267    if (IsDead(to->from))
268      return;  /* This socket has already been marked as dead */
269  
320 –  buffer = dbuf_alloc();
321 –
270    va_start(args, pattern);
271 +
272 +  struct dbuf_block *buffer = dbuf_alloc();
273    send_format(buffer, pattern, args);
274 +
275    va_end(args);
276  
277    send_message(to->from, buffer);
# Line 329 | Line 280 | sendto_one(struct Client *to, const char
280   }
281  
282   void
283 < sendto_one_numeric(struct Client *to, struct Client *from, enum irc_numerics numeric, ...)
283 > sendto_one_numeric(struct Client *to, const struct Client *from, enum irc_numerics numeric, ...)
284   {
334 –  struct dbuf_block *buffer = NULL;
335 –  const char *dest = NULL, *numstr = NULL;
285    va_list args;
286 +  const char *numstr = NULL;
287  
288    if (IsDead(to->from))
289      return;
290  
291 <  dest = ID_or_name(to, to);
342 <
291 >  const char *dest = ID_or_name(to, to);
292    if (EmptyString(dest))
293      dest = "*";
294  
295 <  buffer = dbuf_alloc();
347 <
295 >  struct dbuf_block *buffer = dbuf_alloc();
296    dbuf_put_fmt(buffer, ":%s %03d %s ", ID_or_name(from, to), numeric & ~SND_EXPLICIT, dest);
297  
298    va_start(args, numeric);
# Line 353 | Line 301 | sendto_one_numeric(struct Client *to, st
301      numstr = va_arg(args, const char *);
302    else
303      numstr = numeric_form(numeric);
304 +
305    send_format(buffer, numstr, args);
306    va_end(args);
307  
# Line 362 | Line 311 | sendto_one_numeric(struct Client *to, st
311   }
312  
313   void
314 < sendto_one_notice(struct Client *to, struct Client *from, const char *pattern, ...)
314 > sendto_one_notice(struct Client *to, const struct Client *from, const char *pattern, ...)
315   {
367 –  struct dbuf_block *buffer = NULL;
368 –  const char *dest = NULL;
316    va_list args;
317  
318    if (IsDead(to->from))
319      return;
320  
321 <  dest = ID_or_name(to, to);
375 <
321 >  const char *dest = ID_or_name(to, to);
322    if (EmptyString(dest))
323      dest = "*";
324  
325 <  buffer = dbuf_alloc();
380 <
325 >  struct dbuf_block *buffer = dbuf_alloc();
326    dbuf_put_fmt(buffer, ":%s NOTICE %s ", ID_or_name(from, to), dest);
327  
328    va_start(args, pattern);
# Line 401 | Line 346 | sendto_one_notice(struct Client *to, str
346   * WARNING - +D clients are ignored
347   */
348   void
349 < sendto_channel_butone(struct Client *one, struct Client *from,
349 > sendto_channel_butone(struct Client *one, const struct Client *from,
350                        struct Channel *chptr, unsigned int type,
351                        const char *pattern, ...)
352   {
353    va_list alocal, aremote;
354    struct dbuf_block *local_buf, *remote_buf;
355 <  dlink_node *ptr = NULL, *ptr_next = NULL;
355 >  dlink_node *node = NULL;
356  
357    local_buf = dbuf_alloc(), remote_buf = dbuf_alloc();
358  
# Line 428 | Line 373 | sendto_channel_butone(struct Client *one
373  
374    ++current_serial;
375  
376 <  DLINK_FOREACH_SAFE(ptr, ptr_next, chptr->members.head)
376 >  DLINK_FOREACH(node, chptr->members.head)
377    {
378 <    struct Membership *ms = ptr->data;
379 <    struct Client *target_p = ms->client_p;
378 >    struct Membership *member = node->data;
379 >    struct Client *target_p = member->client_p;
380  
381      assert(IsClient(target_p));
382  
383 <    if (IsDefunct(target_p) || HasUMode(target_p, UMODE_DEAF) ||
384 <        (one && target_p->from == one->from))
383 >    if (IsDefunct(target_p->from))
384 >      continue;
385 >
386 >    if (one && (target_p->from == one->from))
387 >      continue;
388 >
389 >    if (type && (member->flags & type) == 0)
390        continue;
391  
392 <    if (type && (ms->flags & type) == 0)
392 >    if (HasUMode(target_p, UMODE_DEAF))
393        continue;
394  
395      if (MyConnect(target_p))
396        send_message(target_p, local_buf);
397      else if (target_p->from->connection->serial != current_serial)
398        send_message_remote(target_p->from, from, remote_buf);
399 +
400      target_p->from->connection->serial = current_serial;
401    }
402  
# Line 472 | Line 423 | sendto_channel_butone(struct Client *one
423   * -davidt
424   */
425   void
426 < sendto_server(struct Client *one,
426 > sendto_server(const struct Client *one,
427                const unsigned int caps,
428                const unsigned int nocaps,
429                const char *format, ...)
430   {
431    va_list args;
432 <  dlink_node *ptr = NULL;
482 <  struct dbuf_block *buffer;
483 <
484 <  buffer = dbuf_alloc();
432 >  dlink_node *node;
433  
434    va_start(args, format);
435 +
436 +  struct dbuf_block *buffer = dbuf_alloc();
437    send_format(buffer, format, args);
438 +
439    va_end(args);
440  
441 <  DLINK_FOREACH(ptr, local_server_list.head)
441 >  DLINK_FOREACH(node, local_server_list.head)
442    {
443 <    struct Client *client_p = ptr->data;
443 >    struct Client *client_p = node->data;
444  
445      /* If dead already skip */
446      if (IsDead(client_p))
447        continue;
448 +
449      /* check against 'one' */
450      if (one && (client_p == one->from))
451        continue;
452 +
453      /* check we have required capabs */
454      if ((client_p->connection->caps & caps) != caps)
455        continue;
456 +
457      /* check we don't have any forbidden capabs */
458      if ((client_p->connection->caps & nocaps))
459        continue;
# Line 520 | Line 474 | sendto_server(struct Client *one,
474   *                used by m_nick.c and exit_one_client.
475   */
476   void
477 < sendto_common_channels_local(struct Client *user, int touser, unsigned int cap,
478 <                             const char *pattern, ...)
477 > sendto_common_channels_local(struct Client *user, int touser, unsigned int poscap,
478 >                             unsigned int negcap, const char *pattern, ...)
479   {
480    va_list args;
481    dlink_node *uptr;
482    dlink_node *cptr;
483    struct Channel *chptr;
484 <  struct Membership *ms;
484 >  struct Membership *member;
485    struct Client *target_p;
486 <  struct dbuf_block *buffer;
533 <
534 <  buffer = dbuf_alloc();
486 >  struct dbuf_block *buffer = dbuf_alloc();
487  
488    va_start(args, pattern);
489    send_format(buffer, pattern, args);
# Line 545 | Line 497 | sendto_common_channels_local(struct Clie
497  
498      DLINK_FOREACH(uptr, chptr->locmembers.head)
499      {
500 <      ms = uptr->data;
501 <      target_p = ms->client_p;
500 >      member = uptr->data;
501 >      target_p = member->client_p;
502  
503        if (target_p == user || IsDefunct(target_p) ||
504            target_p->connection->serial == current_serial)
505          continue;
506  
507 <      if (HasCap(target_p, cap) != cap)
507 >      if (poscap && HasCap(target_p, poscap) != poscap)
508 >        continue;
509 >
510 >      if (negcap && HasCap(target_p, negcap))
511          continue;
512  
513        target_p->connection->serial = current_serial;
# Line 562 | Line 517 | sendto_common_channels_local(struct Clie
517  
518    if (touser && MyConnect(user) && !IsDead(user) &&
519        user->connection->serial != current_serial)
520 <    if (HasCap(user, cap) == cap)
520 >    if (HasCap(user, poscap) == poscap)
521        send_message(user, buffer);
522  
523    dbuf_ref_free(buffer);
524   }
525  
526 < /* sendto_channel_local()
527 < *
528 < * inputs       - member status mask, e.g. CHFL_CHANOP | CHFL_VOICE
529 < *              - whether to ignore +D clients (YES/NO)
530 < *              - pointer to channel to send to
531 < *              - var args pattern
532 < * output       - NONE
578 < * side effects - Send a message to all members of a channel that are
579 < *                locally connected to this server.
526 > /*! \brief Send a message to members of a channel that are locally connected to this server.
527 > * \param one      Client to skip; can be NULL
528 > * \param chptr    Destination channel
529 > * \param status   Channel member status flags clients must have
530 > * \param poscap   Positive client capabilities flags (CAP)
531 > * \param negcap   Negative client capabilities flags (CAP)
532 > * \param pattern  Format string for command arguments
533   */
534   void
535 < sendto_channel_local(unsigned int type, int nodeaf, struct Channel *chptr,
536 <                     const char *pattern, ...)
535 > sendto_channel_local(const struct Client *one, struct Channel *chptr, unsigned int status,
536 >                     unsigned int poscap, unsigned int negcap, const char *pattern, ...)
537   {
538    va_list args;
539 <  dlink_node *ptr = NULL;
540 <  struct dbuf_block *buffer;
588 <
589 <  buffer = dbuf_alloc();
539 >  dlink_node *node = NULL;
540 >  struct dbuf_block *buffer = dbuf_alloc();
541  
542    va_start(args, pattern);
543    send_format(buffer, pattern, args);
544    va_end(args);
545  
546 <  DLINK_FOREACH(ptr, chptr->locmembers.head)
546 >  DLINK_FOREACH(node, chptr->locmembers.head)
547    {
548 <    struct Membership *ms = ptr->data;
549 <    struct Client *target_p = ms->client_p;
599 <
600 <    if (type && (ms->flags & type) == 0)
601 <      continue;
548 >    struct Membership *member = node->data;
549 >    struct Client *target_p = member->client_p;
550  
551 <    if (IsDefunct(target_p) ||
604 <        (nodeaf && HasUMode(target_p, UMODE_DEAF)))
551 >    if (IsDefunct(target_p))
552        continue;
553  
554 <    send_message(target_p, buffer);
608 <  }
609 <
610 <  dbuf_ref_free(buffer);
611 < }
612 <
613 < /* sendto_channel_local_butone()
614 < *
615 < * inputs       - pointer to client to NOT send message to
616 < *              - member status mask, e.g. CHFL_CHANOP | CHFL_VOICE
617 < *              - pointer to channel to send to
618 < *              - var args pattern
619 < * output       - NONE
620 < * side effects - Send a message to all members of a channel that are
621 < *                locally connected to this server except one.
622 < *
623 < * WARNING - +D clients are omitted
624 < */
625 < void
626 < sendto_channel_local_butone(struct Client *one, unsigned int type, unsigned int cap,
627 <                            struct Channel *chptr, const char *pattern, ...)
628 < {
629 <  va_list args;
630 <  dlink_node *ptr = NULL;
631 <  struct dbuf_block *buffer;
632 <
633 <  buffer = dbuf_alloc();
634 <
635 <  va_start(args, pattern);
636 <  send_format(buffer, pattern, args);
637 <  va_end(args);
638 <
639 <  DLINK_FOREACH(ptr, chptr->locmembers.head)
640 <  {
641 <    struct Membership *ms = ptr->data;
642 <    struct Client *target_p = ms->client_p;
643 <
644 <    if (type && (ms->flags & type) == 0)
554 >    if (one && target_p == one->from)
555        continue;
556  
557 <    if (one && target_p == one->from)
557 >    if (status && (member->flags & status) == 0)
558        continue;
559  
560 <    if (IsDefunct(target_p) || HasUMode(target_p, UMODE_DEAF))
560 >    if (poscap && HasCap(target_p, poscap) != poscap)
561        continue;
562  
563 <    if (HasCap(target_p, cap) != cap)
563 >    if (negcap && HasCap(target_p, negcap))
564        continue;
565  
566      send_message(target_p, buffer);
# Line 693 | Line 603 | match_it(const struct Client *one, const
603   * ugh. ONLY used by m_message.c to send an "oper magic" message. ugh.
604   */
605   void
606 < sendto_match_butone(struct Client *one, struct Client *from, const char *mask,
607 <                    int what, const char *pattern, ...)
606 > sendto_match_butone(const struct Client *one, const struct Client *from,
607 >                    const char *mask, int what, const char *pattern, ...)
608   {
609    va_list alocal, aremote;
610 <  dlink_node *ptr = NULL, *ptr_next = NULL;
610 >  dlink_node *node = NULL;
611    struct dbuf_block *local_buf, *remote_buf;
612  
613    local_buf = dbuf_alloc(), remote_buf = dbuf_alloc();
# Line 713 | Line 623 | sendto_match_butone(struct Client *one,
623    va_end(alocal);
624  
625    /* scan the local clients */
626 <  DLINK_FOREACH(ptr, local_client_list.head)
626 >  DLINK_FOREACH(node, local_client_list.head)
627    {
628 <    struct Client *client_p = ptr->data;
628 >    struct Client *client_p = node->data;
629  
630      if ((!one || client_p != one->from) && !IsDefunct(client_p) &&
631          match_it(client_p, mask, what))
# Line 723 | Line 633 | sendto_match_butone(struct Client *one,
633    }
634  
635    /* Now scan servers */
636 <  DLINK_FOREACH_SAFE(ptr, ptr_next, local_server_list.head)
636 >  DLINK_FOREACH(node, local_server_list.head)
637    {
638 <    struct Client *client_p = ptr->data;
638 >    struct Client *client_p = node->data;
639  
640      /*
641       * The old code looped through every client on the
# Line 769 | Line 679 | sendto_match_butone(struct Client *one,
679   * side effects - data sent to servers matching with capab
680   */
681   void
682 < sendto_match_servs(struct Client *source_p, const char *mask, unsigned int cap,
682 > sendto_match_servs(const struct Client *source_p, const char *mask, unsigned int cap,
683                     const char *pattern, ...)
684   {
685    va_list args;
686 <  dlink_node *ptr = NULL, *ptr_next = NULL;
687 <  struct dbuf_block *buffer;
778 <
779 <  buffer = dbuf_alloc();
686 >  dlink_node *node = NULL;
687 >  struct dbuf_block *buffer = dbuf_alloc();
688  
689    dbuf_put_fmt(buffer, ":%s ", source_p->id);
690    va_start(args, pattern);
# Line 785 | Line 693 | sendto_match_servs(struct Client *source
693  
694    ++current_serial;
695  
696 <  DLINK_FOREACH_SAFE(ptr, ptr_next, global_server_list.head)
696 >  DLINK_FOREACH(node, global_server_list.head)
697    {
698 <    struct Client *target_p = ptr->data;
698 >    struct Client *target_p = node->data;
699  
700      /* Do not attempt to send to ourselves, or the source */
701      if (IsMe(target_p) || target_p->from == source_p->from)
# Line 796 | Line 704 | sendto_match_servs(struct Client *source
704      if (target_p->from->connection->serial == current_serial)
705        continue;
706  
707 <    if (!match(mask, target_p->name))
708 <    {
801 <      /*
802 <       * if we set the serial here, then we'll never do a
803 <       * match() again, if !IsCapable()
804 <       */
805 <      target_p->from->connection->serial = current_serial;
707 >    if (match(mask, target_p->name))
708 >      continue;
709  
710 <      if (!IsCapable(target_p->from, cap))
711 <        continue;
710 >    if (cap && IsCapable(target_p->from, cap) != cap)
711 >      continue;
712  
713 <      send_message_remote(target_p->from, source_p, buffer);
714 <    }
713 >    target_p->from->connection->serial = current_serial;
714 >    send_message_remote(target_p->from, source_p, buffer);
715    }
716  
717    dbuf_ref_free(buffer);
# Line 824 | Line 727 | sendto_match_servs(struct Client *source
727   *                but useful when one does not know where target "lives"
728   */
729   void
730 < sendto_anywhere(struct Client *to, struct Client *from,
730 > sendto_anywhere(struct Client *to, const struct Client *from,
731                  const char *command,
732                  const char *pattern, ...)
733   {
734    va_list args;
832 –  struct dbuf_block *buffer = NULL;
735  
736    if (IsDead(to->from))
737      return;
738  
739 <  buffer = dbuf_alloc();
838 <
739 >  struct dbuf_block *buffer = dbuf_alloc();
740    if (MyClient(to) && IsClient(from))
741      dbuf_put_fmt(buffer, ":%s!%s@%s %s %s ", from->name, from->username,
742                   from->host, command, to->name);
# Line 847 | Line 748 | sendto_anywhere(struct Client *to, struc
748    send_format(buffer, pattern, args);
749    va_end(args);
750  
751 <  if (MyClient(to))
751 >  if (MyConnect(to))
752      send_message(to, buffer);
753    else
754 <    send_message_remote(to, from, buffer);
754 >    send_message_remote(to->from, from, buffer);
755  
756    dbuf_ref_free(buffer);
757   }
# Line 866 | Line 767 | sendto_anywhere(struct Client *to, struc
767   void
768   sendto_realops_flags(unsigned int flags, int level, int type, const char *pattern, ...)
769   {
770 <  const char *ntype = NULL;
771 <  dlink_node *ptr = NULL;
871 <  char nbuf[IRCD_BUFSIZE] = "";
770 >  const char *ntype = "???";
771 >  dlink_node *node;
772    va_list args;
773  
874 –  va_start(args, pattern);
875 –  vsnprintf(nbuf, sizeof(nbuf), pattern, args);
876 –  va_end(args);
877 –
774    switch (type)
775    {
776      case SEND_NOTICE:
# Line 890 | Line 786 | sendto_realops_flags(unsigned int flags,
786        assert(0);
787    }
788  
789 <  DLINK_FOREACH(ptr, oper_list.head)
789 >  struct dbuf_block *buffer = dbuf_alloc();
790 >  dbuf_put_fmt(buffer, ":%s NOTICE * :*** %s -- ", me.name, ntype);
791 >
792 >  va_start(args, pattern);
793 >  send_format(buffer, pattern, args);
794 >  va_end(args);
795 >
796 >  DLINK_FOREACH(node, oper_list.head)
797    {
798 <    struct Client *client_p = ptr->data;
798 >    struct Client *client_p = node->data;
799      assert(HasUMode(client_p, UMODE_OPER));
800  
801      /*
# Line 903 | Line 806 | sendto_realops_flags(unsigned int flags,
806          ((level == L_OPER) && HasUMode(client_p, UMODE_ADMIN)))
807        continue;
808  
809 <    if (HasUMode(client_p, flags))
810 <      sendto_one(client_p, ":%s NOTICE %s :*** %s -- %s",
908 <                 me.name, client_p->name, ntype, nbuf);
809 >    if (HasUMode(client_p, flags) && !IsDead(client_p))
810 >      send_message(client_p, buffer);
811    }
812 +
813 +  dbuf_ref_free(buffer);
814   }
815  
816   /* ts_warn()
# Line 917 | Line 821 | sendto_realops_flags(unsigned int flags,
821   *                (at most 5 warnings every 5 seconds)
822   */
823   void
824 < sendto_realops_flags_ratelimited(time_t *rate, const char *pattern, ...)
824 > sendto_realops_flags_ratelimited(uintmax_t *rate, const char *pattern, ...)
825   {
826    va_list args;
827    char buffer[IRCD_BUFSIZE] = "";
828  
829    if ((CurrentTime - *rate) < 20)
830      return;
831 +
832    *rate = CurrentTime;
833  
834    va_start(args, pattern);
835    vsnprintf(buffer, sizeof(buffer), pattern, args);
836    va_end(args);
837  
838 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s", buffer);
838 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE, "%s", buffer);
839    ilog(LOG_TYPE_IRCD, "%s", buffer);
840   }
841  
# Line 943 | Line 848 | sendto_realops_flags_ratelimited(time_t
848   * side effects - Send a wallops to local opers
849   */
850   void
851 < sendto_wallops_flags(unsigned int flags, struct Client *source_p,
851 > sendto_wallops_flags(unsigned int flags, const struct Client *source_p,
852                       const char *pattern, ...)
853   {
854 <  dlink_node *ptr = NULL;
854 >  dlink_node *node = NULL;
855    va_list args;
856 <  struct dbuf_block *buffer;
952 <
953 <  buffer = dbuf_alloc();
856 >  struct dbuf_block *buffer = dbuf_alloc();
857  
858    if (IsClient(source_p))
859      dbuf_put_fmt(buffer, ":%s!%s@%s WALLOPS :", source_p->name, source_p->username, source_p->host);
# Line 961 | Line 864 | sendto_wallops_flags(unsigned int flags,
864    send_format(buffer, pattern, args);
865    va_end(args);
866  
867 <  DLINK_FOREACH(ptr, oper_list.head)
867 >  DLINK_FOREACH(node, oper_list.head)
868    {
869 <    struct Client *client_p = ptr->data;
869 >    struct Client *client_p = node->data;
870      assert(client_p->umodes & UMODE_OPER);
871  
872 <    if (HasUMode(client_p, flags) && !IsDefunct(client_p))
872 >    if (HasUMode(client_p, flags) && !IsDead(client_p))
873        send_message(client_p, buffer);
874    }
875  

Comparing ircd-hybrid/trunk/src/send.c (property svn:keywords):
Revision 4780 by michael, Tue Oct 21 16:30:03 2014 UTC vs.
Revision 8036 by michael, Fri Mar 17 17:49:22 2017 UTC

# Line 1 | Line 1
1 < Id Revision
1 > Id

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)