ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/s_user.c
(Generate patch)

Comparing:
ircd-hybrid-7.2/src/s_user.c (file contents), Revision 528 by michael, Sat Mar 18 15:13:11 2006 UTC vs.
ircd-hybrid/trunk/src/s_user.c (file contents), Revision 2069 by michael, Thu May 16 14:48:34 2013 UTC

# Line 23 | Line 23
23   */
24  
25   #include "stdinc.h"
26 < #include "tools.h"
26 > #include "list.h"
27   #include "s_user.h"
28   #include "s_misc.h"
29   #include "channel.h"
30   #include "channel_mode.h"
31   #include "client.h"
32 #include "common.h"
32   #include "fdlist.h"
33   #include "hash.h"
34   #include "irc_string.h"
36 #include "sprintf_irc.h"
35   #include "s_bsd.h"
38 #include "irc_getnameinfo.h"
36   #include "ircd.h"
40 #include "list.h"
37   #include "listener.h"
38   #include "motd.h"
39   #include "numeric.h"
40 < #include "s_conf.h"
41 < #include "s_log.h"
40 > #include "conf.h"
41 > #include "log.h"
42   #include "s_serv.h"
47 #include "s_stats.h"
43   #include "send.h"
44   #include "supported.h"
45   #include "whowas.h"
46   #include "memory.h"
47   #include "packet.h"
48 + #include "rng_mt.h"
49   #include "userhost.h"
50   #include "hook.h"
51   #include "s_misc.h"
52 < #include "msg.h"
53 < #include "pcre.h"
52 > #include "parse.h"
53 > #include "watch.h"
54  
59 int MaxClientCount     = 1;
60 int MaxConnectionCount = 1;
61 struct Callback *entering_umode_cb = NULL;
62 struct Callback *umode_cb = NULL;
63 struct Callback *uid_get_cb = NULL;
55  
56   static char umode_buffer[IRCD_BUFSIZE];
57  
58   static void user_welcome(struct Client *);
59 < static void report_and_set_user_flags(struct Client *, const struct AccessItem *);
59 > static void report_and_set_user_flags(struct Client *, const struct MaskItem *);
60   static int check_xline(struct Client *);
61 < static int check_regexp_xline(struct Client *);
62 < static void introduce_client(struct Client *, struct Client *);
72 < static void *uid_get(va_list);
61 > static void introduce_client(struct Client *);
62 > static const char *uid_get(void);
63  
64   /* Used for building up the isupport string,
65   * used with init_isupport, add_isupport, delete_isupport
# Line 87 | Line 77 | static dlink_list support_list = { NULL,
77   MessageFile *isupportFile;
78  
79   /* memory is cheap. map 0-255 to equivalent mode */
80 < unsigned int user_modes[256] =
80 > const unsigned int user_modes[256] =
81   {
82    /* 0x00 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x0F */
83    /* 0x10 */ 0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0, /* 0x1F */
# Line 96 | Line 86 | unsigned int user_modes[256] =
86    0,                  /* @ */
87    0,                  /* A */
88    0,                  /* B */
89 <  0,                  /* C */
89 >  UMODE_CCONN_FULL,   /* C */
90    UMODE_DEAF,         /* D */
91    0,                  /* E */
92 <  0,                  /* F */
92 >  UMODE_FARCONNECT,   /* F */
93    UMODE_SOFTCALLERID, /* G */
94 <  0,                  /* H */
94 >  UMODE_HIDDEN,       /* H */
95    0,                  /* I */
96    0,                  /* J */
97    0,                  /* K */
# Line 111 | Line 101 | unsigned int user_modes[256] =
101    0,                  /* O */
102    0,                  /* P */
103    0,                  /* Q */
104 <  0,                  /* R */
104 >  UMODE_REGONLY,      /* R */
105    0,                  /* S */
106    0,                  /* T */
107    0,                  /* U */
# Line 126 | Line 116 | unsigned int user_modes[256] =
116    UMODE_BOTS,         /* b */
117    UMODE_CCONN,        /* c */
118    UMODE_DEBUG,        /* d */
119 <  0,                  /* e */
119 >  UMODE_EXTERNAL,     /* e */
120    UMODE_FULL,         /* f */
121    UMODE_CALLERID,     /* g */
122    0,                  /* h */
123    UMODE_INVISIBLE,    /* i */
124 <  0,                  /* j */
124 >  UMODE_REJ,          /* j */
125    UMODE_SKILL,        /* k */
126    UMODE_LOCOPS,       /* l */
127    0,                  /* m */
# Line 139 | Line 129 | unsigned int user_modes[256] =
129    UMODE_OPER,         /* o */
130    0,                  /* p */
131    0,                  /* q */
132 <  UMODE_REJ,          /* r */
132 >  UMODE_REGISTERED,   /* r */
133    UMODE_SERVNOTICE,   /* s */
134    0,                  /* t */
135    UMODE_UNAUTH,       /* u */
136    0,                  /* v */
137    UMODE_WALLOP,       /* w */
138 <  UMODE_EXTERNAL,     /* x */
138 >  0,                  /* x */
139    UMODE_SPY,          /* y */
140    UMODE_OPERWALL,     /* z      0x7A */
141    0,0,0,0,0,          /* 0x7B - 0x7F */
# Line 166 | Line 156 | assemble_umode_buffer(void)
156    unsigned int idx = 0;
157    char *umode_buffer_ptr = umode_buffer;
158  
159 <  for (; idx < (sizeof(user_modes) / sizeof(int)); ++idx)
159 >  for (; idx < (sizeof(user_modes) / sizeof(user_modes[0])); ++idx)
160      if (user_modes[idx])
161        *umode_buffer_ptr++ = idx;
162  
# Line 195 | Line 185 | show_lusers(struct Client *source_p)
185      to = source_p->name;
186    }
187  
188 <  if (!ConfigServerHide.hide_servers || IsOper(source_p))
188 >  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
189      sendto_one(source_p, form_str(RPL_LUSERCLIENT),
190                 from, to, (Count.total-Count.invisi),
191                 Count.invisi, dlink_list_length(&global_serv_list));
# Line 215 | Line 205 | show_lusers(struct Client *source_p)
205      sendto_one(source_p, form_str(RPL_LUSERCHANNELS),
206                 from, to, dlink_list_length(&global_channel_list));
207  
208 <  if (!ConfigServerHide.hide_servers || IsOper(source_p))
208 >  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
209    {
210      sendto_one(source_p, form_str(RPL_LUSERME),
211                 from, to, Count.local, Count.myserver);
212      sendto_one(source_p, form_str(RPL_LOCALUSERS),
213 <               from, to, Count.local, Count.max_loc,
224 <               Count.local, Count.max_loc);
213 >               from, to, Count.local, Count.max_loc);
214    }
215    else
216    {
217      sendto_one(source_p, form_str(RPL_LUSERME),
218                 from, to, Count.total, 0);
219      sendto_one(source_p, form_str(RPL_LOCALUSERS),
220 <               from, to, Count.total, Count.max_tot,
232 <               Count.total, Count.max_tot);
220 >               from, to, Count.total, Count.max_tot);
221    }
222  
223    sendto_one(source_p, form_str(RPL_GLOBALUSERS),
224 <             from, to, Count.total, Count.max_tot,
237 <             Count.total, Count.max_tot);
224 >             from, to, Count.total, Count.max_tot);
225  
226 <  if (!ConfigServerHide.hide_servers || IsOper(source_p))
226 >  if (!ConfigServerHide.hide_servers || HasUMode(source_p, UMODE_OPER))
227      sendto_one(source_p, form_str(RPL_STATSCONN), from, to,
228 <               MaxConnectionCount, MaxClientCount, Count.totalrestartcount);
228 >               Count.max_loc_con, Count.max_loc_cli, Count.totalrestartcount);
229  
230 <  if (Count.local > MaxClientCount)
231 <    MaxClientCount = Count.local;
230 >  if (Count.local > Count.max_loc_cli)
231 >    Count.max_loc_cli = Count.local;
232  
233 <  if ((Count.local + Count.myserver) > MaxConnectionCount)
234 <    MaxConnectionCount = Count.local + Count.myserver;
233 >  if ((Count.local + Count.myserver) > Count.max_loc_con)
234 >    Count.max_loc_con = Count.local + Count.myserver;
235   }
236  
237   /* show_isupport()
# Line 283 | Line 270 | show_isupport(struct Client *source_p)
270   **         nick from local user or kill him/her...
271   */
272   void
273 < register_local_user(struct Client *client_p, struct Client *source_p,
287 <                    const char *nick, const char *username)
273 > register_local_user(struct Client *source_p)
274   {
275 <  const struct AccessItem *aconf = NULL;
276 <  char ipaddr[HOSTIPLEN];
291 <  dlink_node *ptr = NULL;
292 <  dlink_node *m = NULL;
275 >  const char *id = NULL;
276 >  const struct MaskItem *conf = NULL;
277  
278    assert(source_p != NULL);
279 +  assert(source_p == source_p->from);
280    assert(MyConnect(source_p));
296  assert(source_p->username != username);
281    assert(!source_p->localClient->registration);
282  
283 +  ClearCap(source_p, CAP_TS6);
284 +
285    if (ConfigFileEntry.ping_cookie)
286    {
287 <    if (!IsPingSent(source_p) &&
302 <       source_p->localClient->random_ping == 0)
287 >    if (!IsPingSent(source_p) && source_p->localClient->random_ping == 0)
288      {
289 <      source_p->localClient->random_ping = (unsigned long)rand();
290 <      sendto_one(source_p, "PING :%lu",
289 >      do
290 >        source_p->localClient->random_ping = genrand_int32();
291 >      while (!source_p->localClient->random_ping);
292 >
293 >      sendto_one(source_p, "PING :%u",
294                   source_p->localClient->random_ping);
295        SetPingSent(source_p);
296        return;
# Line 312 | Line 300 | register_local_user(struct Client *clien
300        return;
301    }
302  
303 <  source_p->localClient->last = CurrentTime;
303 >  source_p->localClient->last_privmsg = CurrentTime;
304    /* Straight up the maximum rate of flooding... */
305    source_p->localClient->allow_read = MAX_FLOOD_BURST;
306  
307 <  if (!execute_callback(client_check_cb, source_p, username))
307 >  if (!check_client(source_p))
308      return;
309  
310    if (valid_hostname(source_p->host) == 0)
# Line 327 | Line 315 | register_local_user(struct Client *clien
315              sizeof(source_p->host));
316    }
317  
318 <  ptr   = source_p->localClient->confs.head;
331 <  aconf = map_to_conf(ptr->data);
318 >  conf = source_p->localClient->confs.head->data;
319  
320    if (!IsGotId(source_p))
321    {
322 <    const char *p = NULL;
322 >    char username[USERLEN + 1];
323 >    const char *p = username;
324      unsigned int i = 0;
325  
326 <    if (IsNeedIdentd(aconf))
326 >    if (IsNeedIdentd(conf))
327      {
328 <      ServerStats->is_ref++;
328 >      ++ServerStats.is_ref;
329        sendto_one(source_p, ":%s NOTICE %s :*** Notice -- You need to install "
330                   "identd to use this server", me.name, source_p->name);
331        exit_client(source_p, &me, "Install identd");
332        return;
333      }
334  
335 <    p = username;
335 >    strlcpy(username, source_p->username, sizeof(username));
336  
337 <    if (!IsNoTilde(aconf))
337 >    if (!IsNoTilde(conf))
338        source_p->username[i++] = '~';
339  
340 <    while (*p && i < USERLEN)
353 <    {
340 >    for (; *p && i < USERLEN; ++p)
341        if (*p != '[')
342          source_p->username[i++] = *p;
356      p++;
357    }
343  
344      source_p->username[i] = '\0';
345    }
346  
347    /* password check */
348 <  if (!EmptyString(aconf->passwd))
348 >  if (!EmptyString(conf->passwd))
349    {
350      const char *pass = source_p->localClient->passwd;
351  
352 <    if (!match_conf_password(pass, aconf))
352 >    if (!match_conf_password(pass, conf))
353      {
354 <      ServerStats->is_ref++;
354 >      ++ServerStats.is_ref;
355        sendto_one(source_p, form_str(ERR_PASSWDMISMATCH),
356                   me.name, source_p->name);
357        exit_client(source_p, &me, "Bad Password");
# Line 380 | Line 365 | register_local_user(struct Client *clien
365     */
366  
367    /* report if user has &^>= etc. and set flags as needed in source_p */
368 <  report_and_set_user_flags(source_p, aconf);
368 >  report_and_set_user_flags(source_p, conf);
369 >
370 >  if (IsDead(source_p))
371 >    return;
372  
373    /* Limit clients -
374     * We want to be able to have servers and F-line clients
# Line 393 | Line 381 | register_local_user(struct Client *clien
381    if ((Count.local >= ServerInfo.max_clients + MAX_BUFFER) ||
382        (Count.local >= ServerInfo.max_clients && !IsExemptLimits(source_p)))
383    {
384 <    sendto_realops_flags(UMODE_FULL, L_ALL,
384 >    sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
385                           "Too many clients, rejecting %s[%s].",
386 <                         nick, source_p->host);
387 <    ServerStats->is_ref++;
386 >                         source_p->name, source_p->host);
387 >    ++ServerStats.is_ref;
388      exit_client(source_p, &me, "Sorry, server is full - try later");
389      return;
390    }
391  
392    /* valid user name check */
393 <  if (valid_username(source_p->username) == 0)
393 >  if (valid_username(source_p->username, 1) == 0)
394    {
395      char tmpstr2[IRCD_BUFSIZE];
396  
397 <    sendto_realops_flags(UMODE_REJ, L_ALL, "Invalid username: %s (%s@%s)",
398 <                         nick, source_p->username, source_p->host);
399 <    ServerStats->is_ref++;
400 <    ircsprintf(tmpstr2, "Invalid username [%s]", source_p->username);
397 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
398 >                         "Invalid username: %s (%s@%s)",
399 >                         source_p->name, source_p->username, source_p->host);
400 >    ++ServerStats.is_ref;
401 >    snprintf(tmpstr2, sizeof(tmpstr2), "Invalid username [%s]",
402 >             source_p->username);
403      exit_client(source_p, &me, tmpstr2);
404      return;
405    }
406  
407 <  assert(source_p == client_p);
418 <
419 <  /* end of valid user name check */
420 <  if (check_xline(source_p) || check_regexp_xline(source_p))
407 >  if (check_xline(source_p))
408      return;
409  
410 <  if (IsDead(client_p))
411 <    return;
410 >  while (hash_find_id((id = uid_get())) != NULL)
411 >    ;
412  
413 <  if (source_p->id[0] == '\0' && me.id[0])
414 <  {
428 <    char *id = (char *)execute_callback(uid_get_cb, source_p);
429 <    while (hash_find_id(id) != NULL)
430 <      id = uid_get(NULL);
413 >  strlcpy(source_p->id, id, sizeof(source_p->id));
414 >  hash_add_id(source_p);
415  
416 <    strlcpy(source_p->id, id, sizeof(source_p->id));
417 <    hash_add_id(source_p);
418 <  }
419 <
420 <  irc_getnameinfo((struct sockaddr *)&source_p->localClient->ip,
421 <                  source_p->localClient->ip.ss_len, ipaddr,
422 <                  HOSTIPLEN, NULL, 0, NI_NUMERICHOST);
423 <
424 <  sendto_realops_flags(UMODE_CCONN, L_ALL,
425 <                       "Client connecting: %s (%s@%s) [%s] {%s} [%s]",
426 <                       nick, source_p->username, source_p->host,
416 >  sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
417 >                       "Client connecting: %s (%s@%s) [%s] {%s} [%s] <%s>",
418 >                       source_p->name, source_p->username, source_p->host,
419 >                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
420 >                       "255.255.255.255" : source_p->sockhost,
421 >                       get_client_class(&source_p->localClient->confs),
422 >                       source_p->info, source_p->id);
423 >
424 >  sendto_realops_flags(UMODE_CCONN_FULL, L_ALL, SEND_NOTICE,
425 >                       "CLICONN %s %s %s %s %s %s %s 0 %s",
426 >                       source_p->name, source_p->username, source_p->host,
427                         ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
428 <                       "255.255.255.255" : ipaddr, get_client_class(source_p),
428 >                       "255.255.255.255" : source_p->sockhost,
429 >                       get_client_class(&source_p->localClient->confs),
430 >                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
431 >                           "<hidden>" : source_p->localClient->client_host,
432 >                       ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
433 >                           "<hidden>" : source_p->localClient->client_server,
434                         source_p->info);
435  
447  /* If they have died in send_* don't do anything. */
448  if (IsDead(source_p))
449    return;
436  
437    if (ConfigFileEntry.invisible_on_connect)
438    {
439 <    source_p->umodes |= UMODE_INVISIBLE;
440 <    Count.invisi++;
439 >    AddUMode(source_p, UMODE_INVISIBLE);
440 >    ++Count.invisi;
441    }
442  
443    if ((++Count.local) > Count.max_loc)
# Line 459 | Line 445 | register_local_user(struct Client *clien
445      Count.max_loc = Count.local;
446  
447      if (!(Count.max_loc % 10))
448 <      sendto_realops_flags(UMODE_ALL, L_ALL, "New Max Local Clients: %d",
448 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
449 >                           "New Max Local Clients: %d",
450                             Count.max_loc);
451    }
452  
466  SetClient(source_p);
467
468  source_p->servptr = &me;
469  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->users);
470
453    /* Increment our total user count here */
454    if (++Count.total > Count.max_tot)
455      Count.max_tot = Count.total;
456 <  Count.totalrestartcount++;
456 >  ++Count.totalrestartcount;
457 >
458 >  assert(source_p->servptr == &me);
459 >  SetClient(source_p);
460 >  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
461  
462    source_p->localClient->allow_read = MAX_FLOOD_BURST;
463  
464 <  if ((m = dlinkFindDelete(&unknown_list, source_p)) != NULL)
465 <  {
466 <    free_dlink_node(m);
467 <    dlinkAdd(source_p, &source_p->localClient->lclient_node, &local_client_list);
482 <  }
483 <  else assert(0);
464 >  assert(dlinkFind(&unknown_list, source_p));
465 >
466 >  dlink_move_node(&source_p->localClient->lclient_node,
467 >                  &unknown_list, &local_client_list);
468  
469    user_welcome(source_p);
470    add_user_host(source_p->username, source_p->host, 0);
471    SetUserHost(source_p);
472  
473 <  introduce_client(client_p, source_p);
473 >  introduce_client(source_p);
474   }
475  
476   /* register_remote_user()
477   *
478 < * inputs       - client_p directly connected client
495 < *              - source_p remote or directly connected client
478 > * inputs       - source_p remote or directly connected client
479   *              - username to register as
480   *              - host name to register as
481   *              - server name
# Line 502 | Line 485 | register_local_user(struct Client *clien
485   *                is introduced by a server.
486   */
487   void
488 < register_remote_user(struct Client *client_p, struct Client *source_p,
488 > register_remote_user(struct Client *source_p,
489                       const char *username, const char *host, const char *server,
490                       const char *realname)
491   {
# Line 512 | Line 495 | register_remote_user(struct Client *clie
495    assert(source_p->username != username);
496  
497    strlcpy(source_p->host, host, sizeof(source_p->host));
515  strlcpy(source_p->info, realname, sizeof(source_p->info));
498    strlcpy(source_p->username, username, sizeof(source_p->username));
499  
500    /*
501     * coming from another server, take the servers word for it
502     */
503 <  source_p->servptr = find_server(server);
503 >  source_p->servptr = hash_find_server(server);
504  
505 <  /* Super GhostDetect:
505 >  /*
506 >   * Super GhostDetect:
507     * If we can't find the server the user is supposed to be on,
508     * then simply blow the user away.        -Taner
509     */
510    if (source_p->servptr == NULL)
511    {
512 <    sendto_realops_flags(UMODE_ALL, L_ALL,
512 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
513                           "No server %s for user %s[%s@%s] from %s",
514                           server, source_p->name, source_p->username,
515                           source_p->host, source_p->from->name);
516 <    kill_client(client_p, source_p, "%s (Server doesn't exist)", me.name);
516 >    kill_client(source_p->from, source_p, "%s (Server doesn't exist)", me.name);
517  
518 <    SetKilled(source_p);
518 >    AddFlag(source_p, FLAGS_KILLED);
519      exit_client(source_p, &me, "Ghosted Client");
520      return;
521    }
522  
523    if ((target_p = source_p->servptr) && target_p->from != source_p->from)
524    {
525 <    sendto_realops_flags(UMODE_DEBUG, L_ALL,
525 >    sendto_realops_flags(UMODE_DEBUG, L_ALL, SEND_NOTICE,
526                           "Bad User [%s] :%s USER %s@%s %s, != %s[%s]",
527 <                         client_p->name, source_p->name, source_p->username,
527 >                         source_p->from->name, source_p->name, source_p->username,
528                           source_p->host, source_p->servptr->name,
529                           target_p->name, target_p->from->name);
530 <    kill_client(client_p, source_p,
530 >    kill_client(source_p->from, source_p,
531                  "%s (NICK from wrong direction (%s != %s))",
532                  me.name, source_p->servptr->name, target_p->from->name);
533 <    SetKilled(source_p);
533 >    AddFlag(source_p, FLAGS_KILLED);
534      exit_client(source_p, &me, "USER server wrong direction");
535      return;
536    }
537  
538 +  /*
539 +   * If the nick has been introduced by a services server,
540 +   * make it a service as well.
541 +   */
542 +  if (HasFlag(source_p->servptr, FLAGS_SERVICE))
543 +    AddFlag(source_p, FLAGS_SERVICE);
544 +
545    /* Increment our total user count here */
546    if (++Count.total > Count.max_tot)
547      Count.max_tot = Count.total;
548  
559  ++source_p->from->serv->dep_users;
560
549    SetClient(source_p);
550 <  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->users);
550 >  dlinkAdd(source_p, &source_p->lnode, &source_p->servptr->serv->client_list);
551    add_user_host(source_p->username, source_p->host, 1);
552    SetUserHost(source_p);
553  
554 <  introduce_client(client_p, source_p);
554 >  if (HasFlag(source_p->servptr, FLAGS_EOB))
555 >    sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
556 >                         "Client connecting at %s: %s (%s@%s) [%s] <%s>",
557 >                         source_p->servptr->name,
558 >                         source_p->name, source_p->username, source_p->host,
559 >                         source_p->info, source_p->id);
560 >
561 >  introduce_client(source_p);
562   }
563  
564   /* introduce_client()
565   *
566 < * inputs       - client_p
572 < *              - source_p
566 > * inputs       - source_p
567   * output       - NONE
568   * side effects - This common function introduces a client to the rest
569   *                of the net, either from a local client connect or
570   *                from a remote connect.
571   */
572   static void
573 < introduce_client(struct Client *client_p, struct Client *source_p)
573 > introduce_client(struct Client *source_p)
574   {
575    dlink_node *server_node = NULL;
576    static char ubuf[12];
# Line 586 | Line 580 | introduce_client(struct Client *client_p
580    else
581      send_umode(NULL, source_p, 0, SEND_UMODES, ubuf);
582  
583 +  watch_check_hash(source_p, RPL_LOGON);
584 +
585    if (*ubuf == '\0')
586    {
587      ubuf[0] = '+';
588      ubuf[1] = '\0';
589    }
590  
591 <  /* arghhh one could try not introducing new nicks to ll leafs
596 <   * but then you have to introduce them "on the fly" in SJOIN
597 <   * not fun.
598 <   * Its not going to cost much more bandwidth to simply let new
599 <   * nicks just ride on through.
600 <   */
601 <
602 <  /* We now introduce nicks "on the fly" in SJOIN anyway --
603 <   * you _need_ to if you aren't going to burst everyone initially.
604 <   *
605 <   * Only send to non CAP_LL servers, unless we're a lazylink leaf,
606 <   * in that case just send it to the uplink.
607 <   * -davidt
608 <   * rewritten to cope with SIDs .. eww eww eww --is
609 <   */
610 <  if (!ServerInfo.hub && uplink && IsCapable(uplink, CAP_LL) &&
611 <      client_p != uplink)
591 >  DLINK_FOREACH(server_node, serv_list.head)
592    {
593 <    if (IsCapable(uplink, CAP_TS6) && HasID(source_p))
593 >    struct Client *server = server_node->data;
594 >
595 >    if (server == source_p->from)
596 >        continue;
597 >
598 >    if (IsCapable(server, CAP_SVS))
599      {
600 <      sendto_one(uplink, ":%s UID %s %d %lu %s %s %s %s %s :%s",
601 <                 source_p->servptr->id,
602 <                 source_p->name, source_p->hopcount+1,
603 <                 (unsigned long)source_p->tsinfo,
604 <                 ubuf, source_p->username, source_p->host,
605 <                 (MyClient(source_p) && IsIPSpoof(source_p)) ?
606 <                 "0" : source_p->sockhost, source_p->id, source_p->info);
600 >      if (IsCapable(server, CAP_TS6) && HasID(source_p))
601 >        sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
602 >                   source_p->servptr->id,
603 >                   source_p->name, source_p->hopcount+1,
604 >                   (unsigned long)source_p->tsinfo,
605 >                   ubuf, source_p->username, source_p->host,
606 >                   (MyClient(source_p) && IsIPSpoof(source_p)) ?
607 >                   "0" : source_p->sockhost, source_p->id,
608 >                   source_p->svid,
609 >                   source_p->info);
610 >      else
611 >        sendto_one(server, "NICK %s %d %lu %s %s %s %s %s :%s",
612 >                   source_p->name, source_p->hopcount+1,
613 >                   (unsigned long)source_p->tsinfo,
614 >                   ubuf, source_p->username, source_p->host,
615 >                   source_p->servptr->name, source_p->svid,
616 >                   source_p->info);
617 >
618      }
619      else
620      {
625      sendto_one(uplink, "NICK %s %d %lu %s %s %s %s :%s",
626                 source_p->name, source_p->hopcount+1,
627                 (unsigned long)source_p->tsinfo,
628                 ubuf, source_p->username, source_p->host,
629                 source_p->servptr->name, source_p->info);
630    }
631  }
632  else
633  {
634    DLINK_FOREACH(server_node, serv_list.head)
635    {
636      struct Client *server = server_node->data;
637
638      if (IsCapable(server, CAP_LL) || server == client_p)
639        continue;
640
621        if (IsCapable(server, CAP_TS6) && HasID(source_p))
622          sendto_one(server, ":%s UID %s %d %lu %s %s %s %s %s :%s",
623                     source_p->servptr->id,
# Line 672 | Line 652 | valid_hostname(const char *hostname)
652  
653    assert(p != NULL);
654  
655 <  if ('.' == *p || ':' == *p)
655 >  if (*p == '.' || *p == ':')
656      return 0;
657  
658 <  while (*p)
679 <  {
658 >  for (; *p; ++p)
659      if (!IsHostChar(*p))
660        return 0;
682    p++;
683  }
661  
662 <  return 1;
662 >  return p - hostname <= HOSTLEN;
663   }
664  
665   /* valid_username()
# Line 697 | Line 674 | valid_hostname(const char *hostname)
674   * style of username
675   */
676   int
677 < valid_username(const char *username)
677 > valid_username(const char *username, const int local)
678   {
679    int dots      = 0;
680    const char *p = username;
681  
682    assert(p != NULL);
683  
684 <  if ('~' == *p)
684 >  if (*p == '~')
685      ++p;
686  
687 <  /* reject usernames that don't start with an alphanum
687 >  /*
688 >   * Reject usernames that don't start with an alphanum
689     * i.e. reject jokers who have '-@somehost' or '.@somehost'
690     * or "-hi-@somehost", "h-----@somehost" would still be accepted.
691     */
692    if (!IsAlNum(*p))
693      return 0;
694  
695 <  while (*++p)
695 >  if (local)
696    {
697 <    if ((*p == '.') && ConfigFileEntry.dots_in_ident)
697 >    while (*++p)
698      {
699 <      dots++;
700 <
701 <      if (dots > ConfigFileEntry.dots_in_ident)
702 <        return 0;
703 <      if (!IsUserChar(p[1]))
699 >      if ((*p == '.') && ConfigFileEntry.dots_in_ident)
700 >      {
701 >        if (++dots > ConfigFileEntry.dots_in_ident)
702 >          return 0;
703 >        if (!IsUserChar(*(p + 1)))
704 >          return 0;
705 >      }
706 >      else if (!IsUserChar(*p))
707          return 0;
708      }
709 <    else if (!IsUserChar(*p))
710 <      return 0;
709 >  }
710 >  else
711 >  {
712 >    while (*++p)
713 >      if (!IsUserChar(*p))
714 >        return 0;
715    }
716  
717 <  return 1;
717 >  return  p - username <= USERLEN;;
718 > }
719 >
720 > /* clean_nick_name()
721 > *
722 > * input        - nickname
723 > *              - whether it's a local nick (1) or remote (0)
724 > * output       - none
725 > * side effects - walks through the nickname, returning 0 if erroneous
726 > */
727 > int
728 > valid_nickname(const char *nickname, const int local)
729 > {
730 >  const char *p = nickname;
731 >  assert(nickname && *nickname);
732 >
733 >  /* nicks can't start with a digit or - or be 0 length */
734 >  /* This closer duplicates behaviour of hybrid-6 */
735 >  if (*p == '-' || (IsDigit(*p) && local) || *p == '\0')
736 >    return 0;
737 >
738 >  for (; *p; ++p)
739 >    if (!IsNickChar(*p))
740 >      return 0;
741 >
742 >  return p - nickname <= NICKLEN;
743   }
744  
745   /* report_and_set_user_flags()
746   *
747   * inputs       - pointer to source_p
748 < *              - pointer to aconf for this user
748 > *              - pointer to conf for this user
749   * output       - NONE
750   * side effects - Report to user any special flags
751   *                they are getting, and set them.
752   */
753   static void
754 < report_and_set_user_flags(struct Client *source_p, const struct AccessItem *aconf)
754 > report_and_set_user_flags(struct Client *source_p, const struct MaskItem *conf)
755   {
756    /* If this user is being spoofed, tell them so */
757 <  if (IsConfDoSpoofIp(aconf))
757 >  if (IsConfDoSpoofIp(conf))
758    {
759      sendto_one(source_p,
760                 ":%s NOTICE %s :*** Spoofing your IP. congrats.",
# Line 752 | Line 762 | report_and_set_user_flags(struct Client
762    }
763  
764    /* If this user is in the exception class, Set it "E lined" */
765 <  if (IsConfExemptKline(aconf))
765 >  if (IsConfExemptKline(conf))
766    {
767      SetExemptKline(source_p);
768      sendto_one(source_p,
# Line 763 | Line 773 | report_and_set_user_flags(struct Client
773    /* The else here is to make sure that G line exempt users
774     * do not get noticed twice.
775     */
776 <  else if (IsConfExemptGline(aconf))
776 >  else if (IsConfExemptGline(conf))
777    {
778      SetExemptGline(source_p);
779      sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from G lines.",
780                 me.name, source_p->name);
781    }
782  
783 <  if (IsConfExemptResv(aconf))
783 >  if (IsConfExemptResv(conf))
784    {
785      SetExemptResv(source_p);
786      sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from resvs.",
# Line 778 | Line 788 | report_and_set_user_flags(struct Client
788    }
789  
790    /* If this user is exempt from user limits set it "F lined" */
791 <  if (IsConfExemptLimits(aconf))
791 >  if (IsConfExemptLimits(conf))
792    {
793      SetExemptLimits(source_p);
794      sendto_one(source_p,
# Line 786 | Line 796 | report_and_set_user_flags(struct Client
796                 me.name,source_p->name);
797    }
798  
799 <  /* If this user is exempt from idle time outs */
790 <  if (IsConfIdlelined(aconf))
791 <  {
792 <    SetIdlelined(source_p);
793 <    sendto_one(source_p,
794 <               ":%s NOTICE %s :*** You are exempt from idle limits. congrats.",
795 <               me.name, source_p->name);
796 <  }
797 <
798 <  if (IsConfCanFlood(aconf))
799 >  if (IsConfCanFlood(conf))
800    {
801      SetCanFlood(source_p);
802      sendto_one(source_p, ":%s NOTICE %s :*** You are exempt from flood "
# Line 804 | Line 805 | report_and_set_user_flags(struct Client
805    }
806   }
807  
807 /* do_local_user()
808 *
809 * inputs       -
810 * output       - NONE
811 * side effects -
812 */
813 void
814 do_local_user(const char *nick, struct Client *client_p, struct Client *source_p,
815              const char *username, const char *host, const char *server,
816              const char *realname)
817 {
818  assert(source_p != NULL);
819  assert(source_p->username != username);
820
821  if (source_p == NULL)
822    return;
823
824  if (!IsUnknown(source_p))
825  {
826    sendto_one(source_p, form_str(ERR_ALREADYREGISTRED),
827               me.name, nick);
828    return;
829  }
830
831  source_p->localClient->registration &= ~REG_NEED_USER;
832
833  /*
834   * don't take the clients word for it, ever
835   */
836  source_p->servptr = &me;
837
838  strlcpy(source_p->info, realname, sizeof(source_p->info));
839
840  if (!IsGotId(source_p))
841  {
842    /* save the username in the client
843     * If you move this you'll break ping cookies..you've been warned
844     */
845    strlcpy(source_p->username, username, sizeof(source_p->username));
846  }
847
848  if (!source_p->localClient->registration)
849    /* NICK already received, now I have USER... */
850    register_local_user(client_p, source_p, source_p->name, username);
851 }
852
853 /* change_simple_umode()
854 *
855 * this callback can be hooked to allow special handling of
856 * certain usermodes
857 */
858 static void *
859 change_simple_umode(va_list args)
860 {
861  struct Client *source_p;
862  int what;
863  unsigned int flag;
864
865  va_arg(args, struct Client *);
866  source_p = va_arg(args, struct Client *);
867  what = va_arg(args, int);
868  flag = va_arg(args, unsigned int);
869
870  if (what == MODE_ADD)
871    source_p->umodes |= flag;
872  else
873    source_p->umodes &= ~flag;
874
875  return NULL;
876 }
877
808   /* set_user_mode()
809   *
810   * added 15/10/91 By Darren Reed.
# Line 884 | Line 814 | change_simple_umode(va_list args)
814   */
815   void
816   set_user_mode(struct Client *client_p, struct Client *source_p,
817 <              int parc, char *parv[])
817 >              const int parc, char *parv[])
818   {
819    unsigned int flag, setflags;
820    char **p, *m, buf[IRCD_BUFSIZE];
# Line 901 | Line 831 | set_user_mode(struct Client *client_p, s
831      return;
832    }
833  
834 <  if (IsServer(source_p))
905 <  {
906 <     sendto_realops_flags(UMODE_ALL, L_ADMIN, "*** Mode for User %s from %s",
907 <                          parv[1], source_p->name);
908 <     return;
909 <  }
910 <
911 <  if (source_p != target_p || target_p->from != source_p->from)
834 >  if (source_p != target_p)
835    {
836       sendto_one(source_p, form_str(ERR_USERSDONTMATCH),
837                  me.name, source_p->name);
# Line 921 | Line 844 | set_user_mode(struct Client *client_p, s
844      *m++ = '+';
845  
846      for (i = 0; i < 128; i++)
847 <      if (source_p->umodes & user_modes[i])
847 >      if (HasUMode(source_p, user_modes[i]))
848          *m++ = (char)i;
849      *m = '\0';
850  
# Line 930 | Line 853 | set_user_mode(struct Client *client_p, s
853      return;
854    }
855  
933  execute_callback(entering_umode_cb, client_p, source_p);
934
856    /* find flags already set for user */
857    setflags = source_p->umodes;
858  
# Line 951 | Line 872 | set_user_mode(struct Client *client_p, s
872          case 'o':
873            if (what == MODE_ADD)
874            {
875 <            if (IsServer(client_p) && !IsOper(source_p))
875 >            if (IsServer(client_p) && !HasUMode(source_p, UMODE_OPER))
876              {
877                ++Count.oper;
878                SetOper(source_p);
# Line 962 | Line 883 | set_user_mode(struct Client *client_p, s
883              /* Only decrement the oper counts if an oper to begin with
884               * found by Pat Szuta, Perly , perly@xnet.com
885               */
886 <            if (!IsOper(source_p))
886 >            if (!HasUMode(source_p, UMODE_OPER))
887                break;
888  
889              ClearOper(source_p);
969            source_p->umodes &= ~ConfigFileEntry.oper_only_umodes;
890              Count.oper--;
891  
892              if (MyConnect(source_p))
893              {
894                dlink_node *dm;
895  
896 <              detach_conf(source_p, OPER_TYPE);
897 <              ClearOperFlags(source_p);
896 >              detach_conf(source_p, CONF_OPER);
897 >              ClrOFlag(source_p);
898 >              DelUMode(source_p, ConfigFileEntry.oper_only_umodes);
899  
900                if ((dm = dlinkFindDelete(&oper_list, source_p)) != NULL)
901                  free_dlink_node(dm);
# Line 983 | Line 904 | set_user_mode(struct Client *client_p, s
904  
905            break;
906  
907 <        /* we may not get these,
987 <         * but they shouldnt be in default
988 <         */
989 <        case ' ' :
990 <        case '\n':
991 <        case '\r':
992 <        case '\t':
907 >        case 'r':  /* Only services may set +r */
908            break;
909  
910          default:
911            if ((flag = user_modes[(unsigned char)*m]))
912            {
913 <            if (MyConnect(source_p) && !IsOper(source_p) &&
913 >            if (MyConnect(source_p) && !HasUMode(source_p, UMODE_OPER) &&
914                  (ConfigFileEntry.oper_only_umodes & flag))
1000            {
915                badflag = 1;
1002            }
916              else
917 <              execute_callback(umode_cb, client_p, source_p, what, flag);
917 >            {
918 >              if (what == MODE_ADD)
919 >                AddUMode(source_p, flag);
920 >              else
921 >                DelUMode(source_p, flag);
922 >            }
923            }
924            else
925            {
# Line 1018 | Line 936 | set_user_mode(struct Client *client_p, s
936      sendto_one(source_p, form_str(ERR_UMODEUNKNOWNFLAG),
937                 me.name, source_p->name);
938  
939 <  if ((source_p->umodes & UMODE_NCHANGE) && !IsOperN(source_p))
939 >  if (MyConnect(source_p) && HasUMode(source_p, UMODE_ADMIN) &&
940 >      !HasOFlag(source_p, OPER_FLAG_ADMIN))
941    {
942      sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
943                 me.name, source_p->name);
944 <    source_p->umodes &= ~UMODE_NCHANGE; /* only tcm's really need this */
944 >    DelUMode(source_p, UMODE_ADMIN);
945    }
946  
947 <  if (MyConnect(source_p) && (source_p->umodes & UMODE_ADMIN) &&
1029 <      !IsOperAdmin(source_p) && !IsOperHiddenAdmin(source_p))
1030 <  {
1031 <    sendto_one(source_p, ":%s NOTICE %s :*** You have no admin flag;",
1032 <               me.name, source_p->name);
1033 <    source_p->umodes &= ~UMODE_ADMIN;
1034 <  }
1035 <
1036 <  if (!(setflags & UMODE_INVISIBLE) && IsInvisible(source_p))
947 >  if (!(setflags & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
948      ++Count.invisi;
949 <  if ((setflags & UMODE_INVISIBLE) && !IsInvisible(source_p))
949 >  if ((setflags & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
950      --Count.invisi;
951  
952    /*
# Line 1048 | Line 959 | set_user_mode(struct Client *client_p, s
959   /* send_umode()
960   * send the MODE string for user (user) to connection client_p
961   * -avalon
962 + *
963 + * inputs       - client_p
964 + *              - source_p
965 + *              - int old
966 + *              - sendmask mask of modes to send
967 + *              - suplied umode_buf
968 + * output       - NONE
969   */
970   void
971   send_umode(struct Client *client_p, struct Client *source_p,
972             unsigned int old, unsigned int sendmask, char *umode_buf)
973   {
974 +  char *m = umode_buf;
975    int what = 0;
976    unsigned int i;
977    unsigned int flag;
1059  char *m = umode_buf;
978  
979    /*
980     * build a string in umode_buf to represent the change in the user's
# Line 1071 | Line 989 | send_umode(struct Client *client_p, stru
989      if (MyClient(source_p) && !(flag & sendmask))
990        continue;
991  
992 <    if ((flag & old) && !(source_p->umodes & flag))
992 >    if ((flag & old) && !HasUMode(source_p, flag))
993      {
994        if (what == MODE_DEL)
995          *m++ = (char)i;
# Line 1082 | Line 1000 | send_umode(struct Client *client_p, stru
1000          *m++ = (char)i;
1001        }
1002      }
1003 <    else if (!(flag & old) && (source_p->umodes & flag))
1003 >    else if (!(flag & old) && HasUMode(source_p, flag))
1004      {
1005        if (what == MODE_ADD)
1006          *m++ = (char)i;
# Line 1113 | Line 1031 | void
1031   send_umode_out(struct Client *client_p, struct Client *source_p,
1032                 unsigned int old)
1033   {
1034 <  char buf[IRCD_BUFSIZE];
1034 >  char buf[IRCD_BUFSIZE] = { '\0' };
1035    dlink_node *ptr = NULL;
1036  
1037 <  send_umode(NULL, source_p, old, IsOperHiddenAdmin(source_p) ?
1120 <             SEND_UMODES & ~UMODE_ADMIN : SEND_UMODES, buf);
1037 >  send_umode(NULL, source_p, old, SEND_UMODES, buf);
1038  
1039 <  if (*buf)
1039 >  if (buf[0])
1040    {
1041      DLINK_FOREACH(ptr, serv_list.head)
1042      {
1043        struct Client *target_p = ptr->data;
1044  
1045        if ((target_p != client_p) && (target_p != source_p))
1046 <      {
1047 <        if ((!(ServerInfo.hub && IsCapable(target_p, CAP_LL))) ||
1048 <            (target_p->localClient->serverMask &
1132 <             source_p->lazyLinkClientExists))
1133 <          sendto_one(target_p, ":%s MODE %s :%s",
1134 <                     ID_or_name(source_p, target_p),
1135 <                     ID_or_name(source_p, target_p), buf);
1136 <      }
1046 >        sendto_one(target_p, ":%s MODE %s :%s",
1047 >                   ID_or_name(source_p, target_p),
1048 >                   ID_or_name(source_p, target_p), buf);
1049      }
1050    }
1051  
# Line 1141 | Line 1053 | send_umode_out(struct Client *client_p,
1053      send_umode(client_p, source_p, old, 0xffffffff, buf);
1054   }
1055  
1056 + void
1057 + user_set_hostmask(struct Client *target_p, const char *hostname)
1058 + {
1059 +  if (!valid_hostname(hostname))
1060 +    return;
1061 +
1062 +  if (IsUserHostIp(target_p))
1063 +    delete_user_host(target_p->username, target_p->host, !MyConnect(target_p));
1064 +
1065 +  strlcpy(target_p->host, hostname, sizeof(target_p->host));
1066 +  SetIPSpoof(target_p);
1067 +
1068 +  add_user_host(target_p->username, target_p->host, !MyConnect(target_p));
1069 +  SetUserHost(target_p);
1070 +
1071 +  if (MyClient(target_p))
1072 +    clear_ban_cache_client(target_p);
1073 + }
1074 +
1075   /* user_welcome()
1076   *
1077   * inputs       - client pointer to client to welcome
# Line 1164 | Line 1095 | user_welcome(struct Client *source_p)
1095   #endif
1096  
1097    sendto_one(source_p, form_str(RPL_WELCOME), me.name, source_p->name,
1098 <             ServerInfo.network_name, source_p->name);
1098 >             ServerInfo.network_name, source_p->name,
1099 >             source_p->username, source_p->host);
1100    sendto_one(source_p, form_str(RPL_YOURHOST), me.name, source_p->name,
1101               get_listener_name(source_p->localClient->listener), ircd_version);
1102    sendto_one(source_p, form_str(RPL_CREATED),
# Line 1181 | Line 1113 | user_welcome(struct Client *source_p)
1113  
1114    if (ConfigFileEntry.short_motd)
1115    {
1116 <    sendto_one(source_p, "NOTICE %s :*** Notice -- motd was last changed at %s",
1117 <               source_p->name, ConfigFileEntry.motd.lastChangedDate);
1116 >    sendto_one(source_p, ":%s NOTICE %s :*** Notice -- motd was last changed at %s",
1117 >               me.name, source_p->name, ConfigFileEntry.motd.lastChangedDate);
1118      sendto_one(source_p,
1119 <               "NOTICE %s :*** Notice -- Please read the motd if you haven't "
1120 <               "read it", source_p->name);
1119 >               ":%s NOTICE %s :*** Notice -- Please read the motd if you haven't "
1120 >               "read it", me.name, source_p->name);
1121      sendto_one(source_p, form_str(RPL_MOTDSTART),
1122                 me.name, source_p->name, me.name);
1123      sendto_one(source_p, form_str(RPL_MOTD),
# Line 1207 | Line 1139 | user_welcome(struct Client *source_p)
1139   static int
1140   check_xline(struct Client *source_p)
1141   {
1142 <  struct ConfItem *conf;
1211 <  struct MatchItem *xconf;
1212 <  const char *reason;
1213 <
1214 <  if ((conf = find_matching_name_conf(XLINE_TYPE, source_p->info,
1215 <                                      NULL, NULL, 0)) != NULL)
1216 <  {
1217 <    xconf = map_to_conf(conf);
1218 <    xconf->count++;
1219 <
1220 <    if (xconf->reason != NULL)
1221 <      reason = xconf->reason;
1222 <    else
1223 <      reason = "No Reason";
1224 <
1225 <    sendto_realops_flags(UMODE_REJ, L_ALL,
1226 <                         "X-line Rejecting [%s] [%s], user %s [%s]",
1227 <                         source_p->info, reason,
1228 <                         get_client_name(source_p, HIDE_IP),
1229 <                         source_p->sockhost);
1230 <
1231 <    ServerStats->is_ref++;      
1232 <    if (REJECT_HOLD_TIME > 0)
1233 <    {
1234 <      sendto_one(source_p, ":%s NOTICE %s :Bad user info",
1235 <                 me.name, source_p->name);
1236 <      source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
1237 <      SetCaptured(source_p);
1238 <    }
1239 <    else
1240 <      exit_client(source_p, &me, "Bad user info");
1241 <    return 1;
1242 <  }
1243 <
1244 <  return 0;
1245 < }
1246 <
1247 < static int
1248 < check_regexp_xline(struct Client *source_p)
1249 < {
1250 <  struct ConfItem *conf = NULL;
1142 >  struct MaskItem *conf = NULL;
1143    const char *reason = NULL;
1144  
1145 <  if ((conf = find_matching_name_conf(RXLINE_TYPE, source_p->info, NULL, NULL, 0)))
1145 >  if ((conf = find_matching_name_conf(CONF_XLINE, source_p->info, NULL, NULL, 0)))
1146    {
1147 <    struct MatchItem *reg = map_to_conf(conf);
1256 <
1257 <    ++reg->count;
1147 >    ++conf->count;
1148  
1149 <    if (reg->reason != NULL)
1150 <      reason = reg->reason;
1149 >    if (conf->reason != NULL)
1150 >      reason = conf->reason;
1151      else
1152        reason = "No Reason";
1153  
1154 <    sendto_realops_flags(UMODE_REJ, L_ALL,
1155 <                         "X-line (REGEX) Rejecting [%s] [%s], user %s [%s]",
1154 >    sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE,
1155 >                         "X-line Rejecting [%s] [%s], user %s [%s]",
1156                           source_p->info, reason,
1157                           get_client_name(source_p, HIDE_IP),
1158                           source_p->sockhost);
1159  
1160 <    ServerStats->is_ref++;
1160 >    ++ServerStats.is_ref;
1161      exit_client(source_p, &me, "Bad user info");
1162      return 1;
1163    }
# Line 1279 | Line 1169 | check_regexp_xline(struct Client *source
1169   *
1170   * inputs       - pointer to given client to oper
1171   * output       - NONE
1172 < * side effects - Blindly opers up given source_p, using aconf info
1172 > * side effects - Blindly opers up given source_p, using conf info
1173   *                all checks on passwords have already been done.
1174   *                This could also be used by rsa oper routines.
1175   */
1176   void
1177   oper_up(struct Client *source_p)
1178   {
1179 <  unsigned int old = source_p->umodes;
1180 <  const char *operprivs = "";
1291 <  const struct AccessItem *oconf = NULL;
1179 >  const unsigned int old = source_p->umodes;
1180 >  const struct MaskItem *conf = source_p->localClient->confs.head->data;
1181  
1182    assert(source_p->localClient->confs.head);
1294  oconf = map_to_conf((source_p->localClient->confs.head)->data);
1183  
1184    ++Count.oper;
1185    SetOper(source_p);
1186  
1187 <  if (oconf->modes)
1188 <    source_p->umodes |= oconf->modes;
1187 >  if (conf->modes)
1188 >    AddUMode(source_p, conf->modes);
1189    else if (ConfigFileEntry.oper_umodes)
1190 <    source_p->umodes |= ConfigFileEntry.oper_umodes;
1191 <  else
1192 <    source_p->umodes |= (UMODE_SERVNOTICE|UMODE_OPERWALL|
1193 <                         UMODE_WALLOP|UMODE_LOCOPS);
1190 >    AddUMode(source_p, ConfigFileEntry.oper_umodes);
1191 >
1192 >  if (!(old & UMODE_INVISIBLE) && HasUMode(source_p, UMODE_INVISIBLE))
1193 >    ++Count.invisi;
1194 >  if ((old & UMODE_INVISIBLE) && !HasUMode(source_p, UMODE_INVISIBLE))
1195 >    --Count.invisi;
1196  
1197    assert(dlinkFind(&oper_list, source_p) == NULL);
1198    dlinkAdd(source_p, make_dlink_node(), &oper_list);
1199  
1200 <  operprivs = oper_privs_as_string(oconf->port);
1311 <
1312 <  SetOFlag(source_p, oconf->port);
1200 >  AddOFlag(source_p, conf->port);
1201  
1202 <  if (IsOperAdmin(source_p) || IsOperHiddenAdmin(source_p))
1203 <    source_p->umodes |= UMODE_ADMIN;
1316 <  if (!IsOperN(source_p))
1317 <    source_p->umodes &= ~UMODE_NCHANGE;
1202 >  if (HasOFlag(source_p, OPER_FLAG_ADMIN))
1203 >    AddUMode(source_p, UMODE_ADMIN);
1204  
1205 <  sendto_realops_flags(UMODE_ALL, L_ALL, "%s (%s@%s) is now an operator",
1206 <                       source_p->name, source_p->username, source_p->host);
1205 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s is now an operator",
1206 >                       get_oper_name(source_p));
1207    send_umode_out(source_p, source_p, old);
1208    sendto_one(source_p, form_str(RPL_YOUREOPER), me.name, source_p->name);
1323  sendto_one(source_p, ":%s NOTICE %s :*** Oper privs are %s",
1324             me.name, source_p->name, operprivs);
1325  send_message_file(source_p, &ConfigFileEntry.opermotd);
1209   }
1210  
1211 < /*
1329 < * Quick and dirty UID code for new proposed SID on EFnet
1330 < *
1331 < */
1211 > static char new_uid[TOTALSIDUID + 1];     /* allow for \0 */
1212  
1213 < static char new_uid[TOTALSIDUID+1];     /* allow for \0 */
1214 < static void add_one_to_uid(int i);
1213 > int
1214 > valid_sid(const char *sid)
1215 > {
1216 >  if (strlen(sid) == IRC_MAXSID)
1217 >    if (IsDigit(*sid))
1218 >      if (IsAlNum(*(sid + 1)) && IsAlNum(*(sid + 2)))
1219 >        return 1;
1220 >
1221 >  return 0;
1222 > }
1223  
1224   /*
1225   * init_uid()
# Line 1345 | Line 1233 | static void add_one_to_uid(int i);
1233   void
1234   init_uid(void)
1235   {
1236 <  int i;
1236 >  unsigned int i;
1237  
1238    memset(new_uid, 0, sizeof(new_uid));
1239  
1240 <  if (ServerInfo.sid != NULL)
1241 <  {
1354 <    memcpy(new_uid, ServerInfo.sid, IRCD_MIN(strlen(ServerInfo.sid),
1355 <                                             IRC_MAXSID));
1356 <    memcpy(&me.id, ServerInfo.sid, IRCD_MIN(strlen(ServerInfo.sid),
1357 <                                            IRC_MAXSID));
1358 <    hash_add_id(&me);
1359 <  }
1240 >  if (!EmptyString(ServerInfo.sid))
1241 >    strlcpy(new_uid, ServerInfo.sid, sizeof(new_uid));
1242  
1243 <  for (i = 0; i < IRC_MAXSID; i++)
1243 >  for (i = 0; i < IRC_MAXSID; ++i)
1244      if (new_uid[i] == '\0')
1245        new_uid[i] = 'A';
1246  
1247 <  /* XXX if IRC_MAXUID != 6, this will have to be rewritten */
1247 >  /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1248    /* Yes nenolod, I have known it was off by one ever since I wrote it
1249     * But *JUST* for you, though, it really doesn't look as *pretty*
1250     * -Dianora
1251     */
1252 <  memcpy(new_uid+IRC_MAXSID, "AAAAA@", IRC_MAXUID);
1371 <
1372 <  entering_umode_cb = register_callback("entering_umode", NULL);
1373 <  umode_cb = register_callback("changing_umode", change_simple_umode);
1374 <  uid_get_cb = register_callback("uid_get", uid_get);
1375 < }
1376 <
1377 < /*
1378 < * uid_get
1379 < *
1380 < * inputs       - struct Client *
1381 < * output       - new UID is returned to caller
1382 < * side effects - new_uid is incremented by one.
1383 < */
1384 < static void *
1385 < uid_get(va_list args)
1386 < {
1387 <  add_one_to_uid(TOTALSIDUID-1);    /* index from 0 */
1388 <  return ((void *) new_uid);
1252 >  memcpy(new_uid + IRC_MAXSID, "AAAAA@", IRC_MAXUID);
1253   }
1254  
1255   /*
# Line 1408 | Line 1272 | add_one_to_uid(int i)
1272        new_uid[i] = 'A';
1273        add_one_to_uid(i-1);
1274      }
1275 <    else new_uid[i] = new_uid[i] + 1;
1275 >    else
1276 >      ++new_uid[i];
1277    }
1278    else
1279    {
1280 <    /* XXX if IRC_MAXUID != 6, this will have to be rewritten */
1280 >    /* NOTE: if IRC_MAXUID != 6, this will have to be rewritten */
1281      if (new_uid[i] == 'Z')
1282 <      memcpy(new_uid+IRC_MAXSID, "AAAAAA", IRC_MAXUID);
1282 >      memcpy(new_uid + IRC_MAXSID, "AAAAAA", IRC_MAXUID);
1283      else
1284 <      new_uid[i] = new_uid[i] + 1;
1284 >      ++new_uid[i];
1285    }
1286   }
1287  
1288   /*
1289 + * uid_get
1290 + *
1291 + * inputs       - struct Client *
1292 + * output       - new UID is returned to caller
1293 + * side effects - new_uid is incremented by one.
1294 + */
1295 + static const char *
1296 + uid_get(void)
1297 + {
1298 +  add_one_to_uid(TOTALSIDUID - 1);    /* index from 0 */
1299 +  return new_uid;
1300 + }
1301 +
1302 + /*
1303   * init_isupport()
1304   *
1305   * input        - NONE
# Line 1434 | Line 1313 | init_isupport(void)
1313  
1314    add_isupport("CALLERID", NULL, -1);
1315    add_isupport("CASEMAPPING", CASEMAP, -1);
1316 +  add_isupport("DEAF", "D", -1);
1317    add_isupport("KICKLEN", NULL, KICKLEN);
1318    add_isupport("MODES", NULL, MAXMODEPARAMS);
1439  add_isupport("NICKLEN", NULL, NICKLEN-1);
1319   #ifdef HALFOPS
1320    add_isupport("PREFIX", "(ohv)@%+", -1);
1321    add_isupport("STATUSMSG", "@%+", -1);
# Line 1444 | Line 1323 | init_isupport(void)
1323    add_isupport("PREFIX", "(ov)@+", -1);
1324    add_isupport("STATUSMSG", "@+", -1);
1325   #endif
1447  add_isupport("TOPICLEN", NULL, TOPICLEN);
1326   }
1327  
1328   /*
# Line 1479 | Line 1357 | add_isupport(const char *name, const cha
1357      dlinkAddTail(support, &support->node, &support_list);
1358    }
1359  
1360 <  DupString(support->name, name);
1360 >  support->name = xstrdup(name);
1361    if (options != NULL)
1362 <    DupString(support->options, options);
1362 >    support->options = xstrdup(options);
1363    support->number = n;
1364  
1365    rebuild_isupport_message_line();
# Line 1540 | Line 1418 | rebuild_isupport_message_line(void)
1418    {
1419      struct Isupport *support = ptr->data;
1420  
1421 <    p += (n = ircsprintf(p, "%s", support->name));
1421 >    p += (n = sprintf(p, "%s", support->name));
1422      len += n;
1423  
1424      if (support->options != NULL)
1425      {
1426 <      p += (n = ircsprintf(p, "=%s", support->options));
1426 >      p += (n = sprintf(p, "=%s", support->options));
1427        len += n;
1428      }
1429  
1430      if (support->number > 0)
1431      {
1432 <      p += (n = ircsprintf(p, "=%d", support->number));
1432 >      p += (n = sprintf(p, "=%d", support->number));
1433        len += n;
1434      }
1435  

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)