/[svn]/ircd-hybrid/trunk/src/parse.c
ViewVC logotype

Diff of /ircd-hybrid/trunk/src/parse.c

Parent Directory Parent Directory | Revision Log Revision Log | View Patch Patch

revision 1680 by michael, Tue Oct 30 21:04:38 2012 UTC revision 1681 by michael, Tue Dec 18 18:43:55 2012 UTC
# Line 712  handle_numeric(char numeric[], struct Cl Line 712  handle_numeric(char numeric[], struct Cl
712         * unfortunately, it did not work. --Dianora         * unfortunately, it did not work. --Dianora
713         */         */
714    
715    
716          /*
717           * Also ignoring ERR_NOTREGISTERED for now. A connecting server may send this
718           * in response to the "NOTICE AUTH ..." message upon registration. Normally
719           * the !IsServer() test in handle_numeric() would take care of this situation,
720           * but due to the fact that read_packet() in s_auth.c:release_auth_client() is
721           * called for the very first time _after_ ident/dns registration, it looks like
722           * the numeric (451) messages are queued up whereas meanwhile the serverlink
723           * succesfully establishes. Right after that, after IsServer() is true, the queued
724           * numeric messages will then be processed, and a notice is falsely sent to operators.
725           * The I/O engine will be rewritten soon (a mixture of libevent), so maybe this also
726           * will fix described behavior above, but for now we're just going to drop this message
727           * (no problem at all, we propably shouldn't process numeric destined to servers anyway)
728           * -Michael
729           */
730        /* Yes, a good compiler would have optimised this, but        /* Yes, a good compiler would have optimised this, but
731         * this is probably easier to read. -db         * this is probably easier to read. -db
732         */         */
733        num = atoi(numeric);        num = atoi(numeric);
734    
735        if ((num != ERR_NOSUCHNICK))        if ((num != ERR_NOSUCHNICK) && (num != ERR_NOTREGISTERED))
736          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
737                               "*** %s(via %s) sent a %s numeric to me: %s",                               "*** %s(via %s) sent a %s numeric to me: %s",
738                               source_p->name, client_p->name, numeric, buffer);                               source_p->name, client_p->name, numeric, buffer);

Legend:
Removed from v.1680  
changed lines
  Added in v.1681

svnadmin@ircd-hybrid.org
ViewVC Help
Powered by ViewVC 1.1.28