ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/conf.c (file contents):
Revision 3347 by michael, Sun Apr 20 14:03:06 2014 UTC vs.
Revision 9880 by michael, Thu Jan 14 13:31:12 2021 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2021 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
# Line 27 | Line 27
27   #include "stdinc.h"
28   #include "list.h"
29   #include "ircd_defs.h"
30 + #include "parse.h"
31   #include "conf.h"
32 + #include "conf_cluster.h"
33 + #include "conf_gecos.h"
34 + #include "conf_pseudo.h"
35 + #include "conf_resv.h"
36 + #include "conf_service.h"
37 + #include "conf_shared.h"
38   #include "server.h"
32 – #include "resv.h"
39   #include "channel.h"
40   #include "client.h"
41   #include "event.h"
# Line 44 | Line 50
50   #include "log.h"
51   #include "send.h"
52   #include "memory.h"
47 – #include "mempool.h"
53   #include "res.h"
49 – #include "userhost.h"
54   #include "user.h"
55   #include "channel_mode.h"
52 – #include "parse.h"
56   #include "misc.h"
57   #include "conf_db.h"
58   #include "conf_class.h"
59   #include "motd.h"
60 + #include "ipcache.h"
61 + #include "isupport.h"
62 + #include "whowas.h"
63  
64  
65   struct config_channel_entry ConfigChannel;
66 < struct config_server_hide ConfigServerHide;
67 < struct config_file_entry ConfigFileEntry;
68 < struct logging_entry ConfigLoggingEntry = { .use_logging = 1 };
69 < struct server_info ServerInfo;
70 < struct admin_info AdminInfo;
66 > struct config_serverhide_entry ConfigServerHide;
67 > struct config_general_entry ConfigGeneral;
68 > struct config_log_entry ConfigLog = { .use_logging = 1 };
69 > struct config_serverinfo_entry ConfigServerInfo;
70 > struct config_admin_entry ConfigAdminInfo;
71 > struct conf_parser_context conf_parser_ctx;
72  
73   /* general conf items link list root, other than k lines etc. */
74 < dlink_list service_items = { NULL, NULL, 0 };
75 < dlink_list server_items  = { NULL, NULL, 0 };
69 < dlink_list cluster_items = { NULL, NULL, 0 };
70 < dlink_list oconf_items   = { NULL, NULL, 0 };
71 < dlink_list uconf_items   = { NULL, NULL, 0 };
72 < dlink_list xconf_items   = { NULL, NULL, 0 };
73 < dlink_list nresv_items   = { NULL, NULL, 0 };
74 < dlink_list cresv_items = { NULL, NULL, 0 };
74 > dlink_list connect_items;
75 > dlink_list operator_items;
76  
77   extern unsigned int lineno;
78   extern char linebuf[];
79   extern char conffilebuf[IRCD_BUFSIZE];
80   extern int yyparse(); /* defined in y.tab.c */
81  
81 – struct conf_parser_context conf_parser_ctx = { 0, 0, NULL };
82 –
83 – /* internally defined functions */
84 – static void read_conf(FILE *);
85 – static void clear_out_old_conf(void);
86 – static void expire_tklines(dlink_list *);
87 – static void garbage_collect_ip_entries(void);
88 – static int hash_ip(struct irc_ssaddr *);
89 – static int verify_access(struct Client *);
90 – static int attach_iline(struct Client *, struct MaskItem *);
91 – static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
92 – static dlink_list *map_to_list(enum maskitem_type);
93 – static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
94 –
95 –
96 – /* usually, with hash tables, you use a prime number...
97 – * but in this case I am dealing with ip addresses,
98 – * not ascii strings.
99 – */
100 – #define IP_HASH_SIZE 0x1000
101 –
102 – struct ip_entry
103 – {
104 –  struct irc_ssaddr ip;
105 –  unsigned int count;
106 –  time_t last_attempt;
107 –  struct ip_entry *next;
108 – };
109 –
110 – static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
111 – static mp_pool_t *ip_entry_pool = NULL;
112 – static int ip_entries_count = 0;
113 –
82  
83   /* conf_dns_callback()
84   *
# Line 123 | Line 91 | static int ip_entries_count = 0;
91   * if successful save hp in the conf item it was called with
92   */
93   static void
94 < conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
94 > conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name, size_t namelength)
95   {
96 <  struct MaskItem *conf = vptr;
96 >  struct MaskItem *const conf = vptr;
97  
98 <  conf->dns_pending = 0;
98 >  conf->dns_pending = false;
99  
100    if (addr)
101 <    memcpy(&conf->addr, addr, sizeof(conf->addr));
101 >    *conf->addr = *addr;
102    else
103 <    conf->dns_failed = 1;
103 >    conf->dns_failed = true;
104   }
105  
106 < /* conf_dns_lookup()
106 > /* conf_resolve_host()
107   *
108 < * do a nameserver lookup of the conf host
109 < * if the conf entry is currently doing a ns lookup do nothing, otherwise
142 < * allocate a dns_query and start ns lookup.
108 > * start DNS lookups of all hostnames in the conf
109 > * line and convert an IP addresses in a.b.c.d number for to IP#s.
110   */
111 < static void
111 > void
112   conf_dns_lookup(struct MaskItem *conf)
113   {
114 <  if (!conf->dns_pending)
114 >  struct addrinfo hints, *res;
115 >
116 >  /*
117 >   * Do name lookup now on hostnames given and store the
118 >   * ip numbers in conf structure.
119 >   */
120 >  memset(&hints, 0, sizeof(hints));
121 >
122 >  hints.ai_family = AF_UNSPEC;
123 >  hints.ai_socktype = SOCK_STREAM;
124 >
125 >  /* Get us ready for a bind() and don't bother doing dns lookup */
126 >  hints.ai_flags = AI_PASSIVE | AI_NUMERICHOST;
127 >
128 >  if (getaddrinfo(conf->host, NULL, &hints, &res))
129 >  {
130 >    /*
131 >     * By this point conf->host possibly is not a numerical network address. Do a nameserver
132 >     * lookup of the conf host. If the conf entry is currently doing a ns lookup do nothing.
133 >     */
134 >    if (conf->dns_pending == true)
135 >      return;
136 >
137 >    conf->dns_pending = true;
138 >
139 >    if (conf->aftype == AF_INET)
140 >      gethost_byname_type(conf_dns_callback, conf, conf->host, T_A);
141 >    else
142 >      gethost_byname_type(conf_dns_callback, conf, conf->host, T_AAAA);
143 >    return;
144 >  }
145 >
146 >  assert(res);
147 >
148 >  memcpy(conf->addr, res->ai_addr, res->ai_addrlen);
149 >  conf->addr->ss_len = res->ai_addrlen;
150 >
151 >  freeaddrinfo(res);
152 > }
153 >
154 > /* map_to_list()
155 > *
156 > * inputs       - ConfType conf
157 > * output       - pointer to dlink_list to use
158 > * side effects - none
159 > */
160 > static dlink_list *
161 > map_to_list(enum maskitem_type type)
162 > {
163 >  switch (type)
164    {
165 <    conf->dns_pending = 1;
166 <    gethost_byname(conf_dns_callback, conf, conf->host);
165 >    case CONF_OPER:
166 >      return &operator_items;
167 >      break;
168 >    case CONF_SERVER:
169 >      return &connect_items;
170 >      break;
171 >    default:
172 >      return NULL;
173    }
174   }
175  
176   struct MaskItem *
177   conf_make(enum maskitem_type type)
178   {
179 <  struct MaskItem *conf = MyMalloc(sizeof(*conf));
179 >  struct MaskItem *const conf = xcalloc(sizeof(*conf));
180    dlink_list *list = NULL;
181  
182    conf->type   = type;
183 <  conf->active = 1;
183 >  conf->active = true;
184    conf->aftype = AF_INET;
185  
186    if ((list = map_to_list(type)))
# Line 169 | Line 191 | conf_make(enum maskitem_type type)
191   void
192   conf_free(struct MaskItem *conf)
193   {
194 <  dlink_node *ptr = NULL, *ptr_next = NULL;
194 >  dlink_node *node = NULL, *node_next = NULL;
195    dlink_list *list = NULL;
196  
197 <  if (conf->node.next)
198 <    if ((list = map_to_list(conf->type)))
177 <      dlinkDelete(&conf->node, list);
197 >  if ((list = map_to_list(conf->type)))
198 >    dlinkFindDelete(list, conf);
199  
200 <  MyFree(conf->name);
200 >  xfree(conf->name);
201  
202 <  if (conf->dns_pending)
202 >  if (conf->dns_pending == true)
203      delete_resolver_queries(conf);
204    if (conf->passwd)
205      memset(conf->passwd, 0, strlen(conf->passwd));
# Line 187 | Line 208 | conf_free(struct MaskItem *conf)
208  
209    conf->class = NULL;
210  
211 <  MyFree(conf->passwd);
212 <  MyFree(conf->spasswd);
213 <  MyFree(conf->reason);
214 <  MyFree(conf->certfp);
215 <  MyFree(conf->user);
216 <  MyFree(conf->host);
217 < #ifdef HAVE_LIBCRYPTO
218 <  MyFree(conf->cipher_list);
211 >  xfree(conf->passwd);
212 >  xfree(conf->spasswd);
213 >  xfree(conf->reason);
214 >  xfree(conf->certfp);
215 >  xfree(conf->whois);
216 >  xfree(conf->user);
217 >  xfree(conf->host);
218 >  xfree(conf->addr);
219 >  xfree(conf->bind);
220 >  xfree(conf->cipher_list);
221  
222 <  if (conf->rsa_public_key)
200 <    RSA_free(conf->rsa_public_key);
201 < #endif
202 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->hub_list.head)
222 >  DLINK_FOREACH_SAFE(node, node_next, conf->hub_list.head)
223    {
224 <    MyFree(ptr->data);
225 <    dlinkDelete(ptr, &conf->hub_list);
226 <    free_dlink_node(ptr);
224 >    xfree(node->data);
225 >    dlinkDelete(node, &conf->hub_list);
226 >    free_dlink_node(node);
227    }
228  
229 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->leaf_list.head)
229 >  DLINK_FOREACH_SAFE(node, node_next, conf->leaf_list.head)
230    {
231 <    MyFree(ptr->data);
232 <    dlinkDelete(ptr, &conf->leaf_list);
233 <    free_dlink_node(ptr);
231 >    xfree(node->data);
232 >    dlinkDelete(node, &conf->leaf_list);
233 >    free_dlink_node(node);
234    }
235  
236 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->exempt_list.head)
217 <  {
218 <    struct exempt *exptr = ptr->data;
219 <
220 <    dlinkDelete(ptr, &conf->exempt_list);
221 <    MyFree(exptr->name);
222 <    MyFree(exptr->user);
223 <    MyFree(exptr->host);
224 <    MyFree(exptr);
225 <  }
226 <
227 <  MyFree(conf);
236 >  xfree(conf);
237   }
238  
239 < /* check_client()
239 > /* attach_iline()
240   *
241 < * inputs       - pointer to client
242 < * output       - 0 = Success
243 < *                NOT_AUTHORIZED    (-1) = Access denied (no I line match)
244 < *                IRCD_SOCKET_ERROR (-2) = Bad socket.
236 < *                I_LINE_FULL       (-3) = I-line is full
237 < *                TOO_MANY          (-4) = Too many connections from hostname
238 < *                BANNED_CLIENT     (-5) = K-lined
239 < * side effects - Ordinary client access check.
240 < *                Look for conf lines which have the same
241 < *                status as the flags passed.
241 > * inputs       - client pointer
242 > *              - conf pointer
243 > * output       -
244 > * side effects - do actual attach
245   */
246 < int
247 < check_client(struct Client *source_p)
246 > static int
247 > attach_iline(struct Client *client, struct MaskItem *conf)
248   {
249 <  int i;
249 >  const struct ClassItem *const class = conf->class;
250 >  bool a_limit_reached = false;
251  
252 <  if ((i = verify_access(source_p)))
253 <    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
254 <         source_p->name, source_p->sockhost);
252 >  struct ip_entry *ipcache = ipcache_record_find_or_add(&client->ip);
253 >  ++ipcache->count_local;
254 >  AddFlag(client, FLAGS_IPHASH);
255 >
256 >  if (class->max_total && class->ref_count >= class->max_total)
257 >    a_limit_reached = true;
258 >  else if (class->max_perip_local && ipcache->count_local > class->max_perip_local)
259 >    a_limit_reached = true;
260 >  else if (class->max_perip_global &&
261 >           (ipcache->count_local + ipcache->count_remote) > class->max_perip_global)
262 >    a_limit_reached = true;
263  
264 <  switch (i)
264 >  if (a_limit_reached == true)
265    {
266 <    case TOO_MANY:
267 <      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
256 <                           "Too many on IP for %s (%s).",
257 <                           get_client_name(source_p, SHOW_IP),
258 <                           source_p->sockhost);
259 <      ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
260 <           get_client_name(source_p, SHOW_IP));
261 <      ++ServerStats.is_ref;
262 <      exit_client(source_p, "No more connections allowed on that IP");
263 <      break;
264 <
265 <    case I_LINE_FULL:
266 <      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
267 <                           "auth{} block is full for %s (%s).",
268 <                           get_client_name(source_p, SHOW_IP),
269 <                           source_p->sockhost);
270 <      ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
271 <           get_client_name(source_p, SHOW_IP));
272 <      ++ServerStats.is_ref;
273 <      exit_client(source_p, "No more connections allowed in your connection class");
274 <      break;
275 <
276 <    case NOT_AUTHORIZED:
277 <      ++ServerStats.is_ref;
278 <      /* jdc - lists server name & port connections are on */
279 <      /*       a purely cosmetical change */
280 <      sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
281 <                           "Unauthorized client connection from %s [%s] on [%s/%u].",
282 <                           get_client_name(source_p, SHOW_IP),
283 <                           source_p->sockhost,
284 <                           source_p->localClient->listener->name,
285 <                           source_p->localClient->listener->port);
286 <      ilog(LOG_TYPE_IRCD,
287 <           "Unauthorized client connection from %s on [%s/%u].",
288 <           get_client_name(source_p, SHOW_IP),
289 <           source_p->localClient->listener->name,
290 <           source_p->localClient->listener->port);
291 <
292 <      exit_client(source_p, "You are not authorized to use this server");
293 <      break;
294 <
295 <   case BANNED_CLIENT:
296 <     exit_client(source_p, "Banned");
297 <     ++ServerStats.is_ref;
298 <     break;
266 >    if (!IsConfExemptLimits(conf))
267 >      return TOO_MANY;   /* Already at maximum allowed */
268  
269 <   case 0:
270 <   default:
302 <     break;
269 >    sendto_one_notice(client, &me, ":*** Your connection class is full, "
270 >                      "but you have exceed_limit = yes;");
271    }
272  
273 <  return (i < 0 ? 0 : 1);
273 >  return conf_attach(client, conf);
274   }
275  
276   /* verify_access()
277   *
278 < * inputs       - pointer to client to verify
279 < * output       - 0 if success -'ve if not
280 < * side effect  - find the first (best) I line to attach.
278 > * inputs       - pointer to client to verify
279 > * output       - 0 if success -'ve if not
280 > * side effect  - find the first (best) I line to attach.
281   */
282   static int
283 < verify_access(struct Client *client_p)
283 > verify_access(struct Client *client)
284   {
285 <  struct MaskItem *conf = NULL;
318 <  char non_ident[USERLEN + 1] = "~";
285 >  struct MaskItem *conf;
286  
287 <  if (IsGotId(client_p))
288 <  {
289 <    conf = find_address_conf(client_p->host, client_p->username,
323 <                             &client_p->localClient->ip,
324 <                             client_p->localClient->aftype,
325 <                             client_p->localClient->passwd);
326 <  }
287 >  if (HasFlag(client, FLAGS_GOTID))
288 >    conf = find_address_conf(client->host, client->username, &client->ip,
289 >                             client->connection->password);
290    else
291    {
292 <    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
330 <    conf = find_address_conf(client_p->host,non_ident,
331 <                             &client_p->localClient->ip,
332 <                             client_p->localClient->aftype,
333 <                             client_p->localClient->passwd);
334 <  }
335 <
336 <  if (conf)
337 <  {
338 <    if (IsConfClient(conf))
339 <    {
340 <      if (IsConfRedir(conf))
341 <      {
342 <        sendto_one_numeric(client_p, &me, RPL_REDIR,
343 <                           conf->name ? conf->name : "",
344 <                           conf->port);
345 <        return NOT_AUTHORIZED;
346 <      }
292 >    char non_ident[USERLEN + 1] = "~";
293  
294 <      if (IsConfDoIdentd(conf))
295 <        SetNeedId(client_p);
296 <
351 <      /* Thanks for spoof idea amm */
352 <      if (IsConfDoSpoofIp(conf))
353 <      {
354 <        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
355 <          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
356 <                               "%s spoofing: %s as %s",
357 <                               client_p->name, client_p->host, conf->name);
358 <        strlcpy(client_p->host, conf->name, sizeof(client_p->host));
359 <        AddFlag(client_p, FLAGS_IP_SPOOFING | FLAGS_AUTH_SPOOF);
360 <      }
361 <
362 <      return attach_iline(client_p, conf);
363 <    }
364 <    else if (IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
365 <    {
366 <      if (IsConfGline(conf))
367 <        sendto_one_notice(client_p, &me, ":*** G-lined");
368 <      sendto_one_notice(client_p, &me, ":*** Banned: %s", conf->reason);
369 <      return BANNED_CLIENT;
370 <    }
294 >    strlcpy(non_ident + 1, client->username, sizeof(non_ident) - 1);
295 >    conf = find_address_conf(client->host, non_ident, &client->ip,
296 >                             client->connection->password);
297    }
298  
299 <  return NOT_AUTHORIZED;
300 < }
375 <
376 < /* attach_iline()
377 < *
378 < * inputs       - client pointer
379 < *              - conf pointer
380 < * output       -
381 < * side effects - do actual attach
382 < */
383 < static int
384 < attach_iline(struct Client *client_p, struct MaskItem *conf)
385 < {
386 <  struct ClassItem *class = NULL;
387 <  struct ip_entry *ip_found;
388 <  int a_limit_reached = 0;
389 <  unsigned int local = 0, global = 0, ident = 0;
390 <
391 <  assert(conf->class);
392 <
393 <  ip_found = find_or_add_ip(&client_p->localClient->ip);
394 <  ip_found->count++;
395 <  SetIpHash(client_p);
396 <
397 <  class = conf->class;
299 >  if (conf == NULL)
300 >    return NOT_AUTHORIZED;
301  
302 <  count_user_host(client_p->username, client_p->host,
400 <                  &global, &local, &ident);
302 >  assert(IsConfClient(conf) || IsConfKill(conf));
303  
304 <  /* XXX blah. go down checking the various silly limits
403 <   * setting a_limit_reached if any limit is reached.
404 <   * - Dianora
405 <   */
406 <  if (class->max_total != 0 && class->ref_count >= class->max_total)
407 <    a_limit_reached = 1;
408 <  else if (class->max_perip != 0 && ip_found->count > class->max_perip)
409 <    a_limit_reached = 1;
410 <  else if (class->max_local != 0 && local >= class->max_local)
411 <    a_limit_reached = 1;
412 <  else if (class->max_global != 0 && global >= class->max_global)
413 <    a_limit_reached = 1;
414 <  else if (class->max_ident != 0 && ident >= class->max_ident &&
415 <           client_p->username[0] != '~')
416 <    a_limit_reached = 1;
417 <
418 <  if (a_limit_reached)
304 >  if (IsConfKill(conf))
305    {
306 <    if (!IsConfExemptLimits(conf))
307 <      return TOO_MANY;   /* Already at maximum allowed */
422 <
423 <    sendto_one_notice(client_p, &me, ":*** Your connection class is full, "
424 <                      "but you have exceed_limit = yes;");
306 >    sendto_one_notice(client, &me, ":*** Banned: %s", conf->reason);
307 >    return BANNED_CLIENT;
308    }
309  
310 <  return attach_conf(client_p, conf);
428 < }
429 <
430 < /* init_ip_hash_table()
431 < *
432 < * inputs               - NONE
433 < * output               - NONE
434 < * side effects         - allocate memory for ip_entry(s)
435 < *                      - clear the ip hash table
436 < */
437 < void
438 < init_ip_hash_table(void)
439 < {
440 <  ip_entry_pool = mp_pool_new(sizeof(struct ip_entry), MP_CHUNK_SIZE_IP_ENTRY);
441 <  memset(ip_hash_table, 0, sizeof(ip_hash_table));
442 < }
443 <
444 < /* find_or_add_ip()
445 < *
446 < * inputs       - pointer to struct irc_ssaddr
447 < * output       - pointer to a struct ip_entry
448 < * side effects -
449 < *
450 < * If the ip # was not found, a new struct ip_entry is created, and the ip
451 < * count set to 0.
452 < */
453 < static struct ip_entry *
454 < find_or_add_ip(struct irc_ssaddr *ip_in)
455 < {
456 <  struct ip_entry *ptr, *newptr;
457 <  int hash_index = hash_ip(ip_in), res;
458 <  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
459 < #ifdef IPV6
460 <  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
461 < #endif
462 <
463 <  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
310 >  if (IsConfRedir(conf))
311    {
312 < #ifdef IPV6
313 <    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
314 <      continue;
315 <    if (ip_in->ss.ss_family == AF_INET6)
469 <    {
470 <      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
471 <      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
472 <    }
473 <    else
474 < #endif
475 <    {
476 <      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
477 <      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
478 <    }
479 <    if (res == 0)
480 <    {
481 <      /* Found entry already in hash, return it. */
482 <      return ptr;
483 <    }
312 >    sendto_one_numeric(client, &me, RPL_REDIR,
313 >                       conf->name ? conf->name : "",
314 >                       conf->port);
315 >    return NOT_AUTHORIZED;
316    }
317  
318 <  if (ip_entries_count >= 2 * hard_fdlimit)
319 <    garbage_collect_ip_entries();
488 <
489 <  newptr = mp_pool_get(ip_entry_pool);
490 <  memset(newptr, 0, sizeof(*newptr));
491 <  ip_entries_count++;
492 <  memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
318 >  /* Preserve x->host in x->realhost before it gets overwritten. */
319 >  strlcpy(client->realhost, client->host, sizeof(client->realhost));
320  
321 <  newptr->next = ip_hash_table[hash_index];
322 <  ip_hash_table[hash_index] = newptr;
321 >  if (IsConfDoSpoofIp(conf))
322 >    strlcpy(client->host, conf->name, sizeof(client->host));
323  
324 <  return newptr;
324 >  return attach_iline(client, conf);
325   }
326  
327 < /* remove_one_ip()
327 > /* check_client()
328   *
329 < * inputs        - unsigned long IP address value
330 < * output        - NONE
331 < * side effects  - The ip address given, is looked up in ip hash table
332 < *                 and number of ip#'s for that ip decremented.
333 < *                 If ip # count reaches 0 and has expired,
334 < *                 the struct ip_entry is returned to the ip_entry_heap
329 > * inputs       - pointer to client
330 > * output       - 0 = Success
331 > *                NOT_AUTHORIZED    (-1) = Access denied (no I line match)
332 > *                IRCD_SOCKET_ERROR (-2) = Bad socket.
333 > *                I_LINE_FULL       (-3) = I-line is full
334 > *                TOO_MANY          (-4) = Too many connections from hostname
335 > *                BANNED_CLIENT     (-5) = K-lined
336 > * side effects - Ordinary client access check.
337 > *                Look for conf lines which have the same
338 > *                status as the flags passed.
339   */
340 < void
341 < remove_one_ip(struct irc_ssaddr *ip_in)
340 > bool
341 > conf_check_client(struct Client *client)
342   {
343 <  struct ip_entry *ptr;
344 <  struct ip_entry *last_ptr = NULL;
514 <  int hash_index = hash_ip(ip_in), res;
515 <  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
516 < #ifdef IPV6
517 <  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
518 < #endif
343 >  const char *error = NULL;
344 >  bool warn = true;
345  
346 <  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
346 >  switch (verify_access(client))
347    {
348 < #ifdef IPV6
349 <    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
350 <      continue;
351 <    if (ip_in->ss.ss_family == AF_INET6)
352 <    {
353 <      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
354 <      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
355 <    }
356 <    else
357 < #endif
358 <    {
359 <      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
360 <      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
535 <    }
536 <    if (res)
537 <      continue;
538 <    if (ptr->count > 0)
539 <      ptr->count--;
540 <    if (ptr->count == 0 &&
541 <        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
542 <    {
543 <      if (last_ptr != NULL)
544 <        last_ptr->next = ptr->next;
545 <      else
546 <        ip_hash_table[hash_index] = ptr->next;
547 <
548 <      mp_pool_release(ptr);
549 <      ip_entries_count--;
550 <      return;
551 <    }
552 <    last_ptr = ptr;
348 >    case TOO_MANY:
349 >      error = "too many connections on IP";
350 >      break;
351 >    case I_LINE_FULL:
352 >      error = "connection class is full";
353 >      break;
354 >    case NOT_AUTHORIZED:
355 >      error = "not authorized";
356 >      break;
357 >    case BANNED_CLIENT:
358 >      error = "banned from server";
359 >      warn = false;
360 >      break;
361    }
554 – }
362  
363 < /* hash_ip()
557 < *
558 < * input        - pointer to an irc_inaddr
559 < * output       - integer value used as index into hash table
560 < * side effects - hopefully, none
561 < */
562 < static int
563 < hash_ip(struct irc_ssaddr *addr)
564 < {
565 <  if (addr->ss.ss_family == AF_INET)
566 <  {
567 <    struct sockaddr_in *v4 = (struct sockaddr_in *)addr;
568 <    int hash;
569 <    uint32_t ip;
570 <
571 <    ip   = ntohl(v4->sin_addr.s_addr);
572 <    hash = ((ip >> 12) + ip) & (IP_HASH_SIZE-1);
573 <    return hash;
574 <  }
575 < #ifdef IPV6
576 <  else
363 >  if (error)
364    {
365 <    int hash;
366 <    struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)addr;
580 <    uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
581 <
582 <    hash  = ip[0] ^ ip[3];
583 <    hash ^= hash >> 16;
584 <    hash ^= hash >> 8;
585 <    hash  = hash & (IP_HASH_SIZE - 1);
586 <    return hash;
587 <  }
588 < #else
589 <  return 0;
590 < #endif
591 < }
365 >    char buf[REASONLEN + 1];
366 >    snprintf(buf, sizeof(buf), "Connection rejected - %s", error);
367  
368 < /* count_ip_hash()
594 < *
595 < * inputs        - pointer to counter of number of ips hashed
596 < *               - pointer to memory used for ip hash
597 < * output        - returned via pointers input
598 < * side effects  - NONE
599 < *
600 < * number of hashed ip #'s is counted up, plus the amount of memory
601 < * used in the hash.
602 < */
603 < void
604 < count_ip_hash(unsigned int *number_ips_stored, uint64_t *mem_ips_stored)
605 < {
606 <  struct ip_entry *ptr;
607 <  int i;
368 >    ++ServerStats.is_ref;
369  
370 <  *number_ips_stored = 0;
371 <  *mem_ips_stored    = 0;
370 >    if (warn == true)
371 >      sendto_realops_flags(UMODE_REJ, L_ALL, SEND_NOTICE, "Rejecting client connection from %s: %s",
372 >                           client_get_name(client, SHOW_IP), error);
373  
374 <  for (i = 0; i < IP_HASH_SIZE; i++)
375 <  {
376 <    for (ptr = ip_hash_table[i]; ptr; ptr = ptr->next)
377 <    {
616 <      *number_ips_stored += 1;
617 <      *mem_ips_stored += sizeof(struct ip_entry);
618 <    }
374 >    ilog(LOG_TYPE_IRCD, "Rejecting client connection from %s: %s",
375 >         client_get_name(client, SHOW_IP), error);
376 >    exit_client(client, buf);
377 >    return false;
378    }
620 – }
379  
380 < /* garbage_collect_ip_entries()
623 < *
624 < * input        - NONE
625 < * output       - NONE
626 < * side effects - free up all ip entries with no connections
627 < */
628 < static void
629 < garbage_collect_ip_entries(void)
630 < {
631 <  struct ip_entry *ptr;
632 <  struct ip_entry *last_ptr;
633 <  struct ip_entry *next_ptr;
634 <  int i;
635 <
636 <  for (i = 0; i < IP_HASH_SIZE; i++)
637 <  {
638 <    last_ptr = NULL;
639 <
640 <    for (ptr = ip_hash_table[i]; ptr; ptr = next_ptr)
641 <    {
642 <      next_ptr = ptr->next;
643 <
644 <      if (ptr->count == 0 &&
645 <          (CurrentTime - ptr->last_attempt) >= ConfigFileEntry.throttle_time)
646 <      {
647 <        if (last_ptr != NULL)
648 <          last_ptr->next = ptr->next;
649 <        else
650 <          ip_hash_table[i] = ptr->next;
651 <        mp_pool_release(ptr);
652 <        ip_entries_count--;
653 <      }
654 <      else
655 <        last_ptr = ptr;
656 <    }
657 <  }
380 >  return true;
381   }
382  
383 < /* detach_conf()
384 < *
385 < * inputs       - pointer to client to detach
386 < *              - type of conf to detach
664 < * output       - 0 for success, -1 for failure
665 < * side effects - Disassociate configuration from the client.
666 < *                Also removes a class from the list if marked for deleting.
383 > /*! \brief Disassociate configuration from the client. Also removes a class
384 > *         from the list if marked for deleting.
385 > * \param client Client to operate on
386 > * \param type     Type of conf to detach
387   */
388   void
389 < detach_conf(struct Client *client_p, enum maskitem_type type)
389 > conf_detach(struct Client *client, enum maskitem_type type)
390   {
391 <  dlink_node *ptr = NULL, *ptr_next = NULL;
391 >  dlink_node *node, *node_next;
392  
393 <  DLINK_FOREACH_SAFE(ptr, ptr_next, client_p->localClient->confs.head)
393 >  DLINK_FOREACH_SAFE(node, node_next, client->connection->confs.head)
394    {
395 <    struct MaskItem *conf = ptr->data;
395 >    struct MaskItem *conf = node->data;
396  
397      assert(conf->type & (CONF_CLIENT | CONF_OPER | CONF_SERVER));
398      assert(conf->ref_count > 0);
# Line 681 | Line 401 | detach_conf(struct Client *client_p, enu
401      if (!(conf->type & type))
402        continue;
403  
404 <    dlinkDelete(ptr, &client_p->localClient->confs);
405 <    free_dlink_node(ptr);
404 >    dlinkDelete(node, &client->connection->confs);
405 >    free_dlink_node(node);
406  
407      if (conf->type == CONF_CLIENT)
408 <      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
408 >      class_ip_limit_remove(conf->class, &client->ip);
409  
410 <    if (--conf->class->ref_count == 0 && conf->class->active == 0)
410 >    if (--conf->class->ref_count == 0 && conf->class->active == false)
411      {
412        class_free(conf->class);
413        conf->class = NULL;
414      }
415  
416 <    if (--conf->ref_count == 0 && conf->active == 0)
416 >    if (--conf->ref_count == 0 && conf->active == false)
417        conf_free(conf);
418    }
419   }
420  
421 < /* attach_conf()
422 < *
423 < * inputs       - client pointer
424 < *              - conf pointer
425 < * output       -
706 < * side effects - Associate a specific configuration entry to a *local*
707 < *                client (this is the one which used in accepting the
708 < *                connection). Note, that this automatically changes the
709 < *                attachment if there was an old one...
421 > /*! \brief Associate a specific configuration entry to a *local* client (this
422 > *         is the one which used in accepting the connection). Note, that this
423 > *         automatically changes the attachment if there was an old one.
424 > * \param client Client to attach the conf to
425 > * \param conf Configuration record to attach
426   */
427   int
428 < attach_conf(struct Client *client_p, struct MaskItem *conf)
428 > conf_attach(struct Client *client, struct MaskItem *conf)
429   {
430 <  if (dlinkFind(&client_p->localClient->confs, conf))
430 >  if (dlinkFind(&client->connection->confs, conf))
431      return 1;
432  
433    if (conf->type == CONF_CLIENT)
434 <    if (cidr_limit_reached(IsConfExemptLimits(conf),
719 <                           &client_p->localClient->ip, conf->class))
434 >    if (class_ip_limit_add(conf->class, &client->ip, IsConfExemptLimits(conf)) == true)
435        return TOO_MANY;    /* Already at maximum allowed */
436  
437    conf->class->ref_count++;
438    conf->ref_count++;
439  
440 <  dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
726 <
727 <  return 0;
728 < }
729 <
730 < /* attach_connect_block()
731 < *
732 < * inputs       - pointer to server to attach
733 < *              - name of server
734 < *              - hostname of server
735 < * output       - true (1) if both are found, otherwise return false (0)
736 < * side effects - find connect block and attach them to connecting client
737 < */
738 < int
739 < attach_connect_block(struct Client *client_p, const char *name,
740 <                     const char *host)
741 < {
742 <  dlink_node *ptr;
743 <  struct MaskItem *conf = NULL;
744 <
745 <  assert(client_p != NULL);
746 <  assert(host != NULL);
747 <
748 <  if (client_p == NULL || host == NULL)
749 <    return 0;
750 <
751 <  DLINK_FOREACH(ptr, server_items.head)
752 <  {
753 <    conf = ptr->data;
754 <
755 <    if (match(conf->name, name) || match(conf->host, host))
756 <      continue;
757 <
758 <    attach_conf(client_p, conf);
759 <    return -1;
760 <  }
440 >  dlinkAdd(conf, make_dlink_node(), &client->connection->confs);
441  
442    return 0;
443   }
# Line 774 | Line 454 | attach_connect_block(struct Client *clie
454   struct MaskItem *
455   find_conf_name(dlink_list *list, const char *name, enum maskitem_type type)
456   {
457 <  dlink_node *ptr;
778 <  struct MaskItem* conf;
457 >  dlink_node *node = NULL;
458  
459 <  DLINK_FOREACH(ptr, list->head)
459 >  DLINK_FOREACH(node, list->head)
460    {
461 <    conf = ptr->data;
461 >    struct MaskItem *conf = node->data;
462  
463      if (conf->type == type)
464      {
465 <      if (conf->name && (irccmp(conf->name, name) == 0 ||
466 <                         !match(conf->name, name)))
788 <      return conf;
465 >      if (conf->name && !irccmp(conf->name, name))
466 >        return conf;
467      }
468    }
469  
470    return NULL;
471   }
472  
473 < /* map_to_list()
474 < *
475 < * inputs       - ConfType conf
798 < * output       - pointer to dlink_list to use
799 < * side effects - none
800 < */
801 < static dlink_list *
802 < map_to_list(enum maskitem_type type)
803 < {
804 <  switch(type)
805 <  {
806 <  case CONF_XLINE:
807 <    return(&xconf_items);
808 <    break;
809 <  case CONF_ULINE:
810 <    return(&uconf_items);
811 <    break;
812 <  case CONF_NRESV:
813 <    return(&nresv_items);
814 <    break;
815 <  case CONF_CRESV:
816 <    return(&cresv_items);
817 <  case CONF_OPER:
818 <    return(&oconf_items);
819 <    break;
820 <  case CONF_SERVER:
821 <    return(&server_items);
822 <    break;
823 <  case CONF_SERVICE:
824 <    return(&service_items);
825 <    break;
826 <  case CONF_CLUSTER:
827 <    return(&cluster_items);
828 <    break;
829 <  default:
830 <    return NULL;
831 <  }
832 < }
833 <
834 < /* find_matching_name_conf()
835 < *
836 < * inputs       - type of link list to look in
837 < *              - pointer to name string to find
838 < *              - pointer to user
839 < *              - pointer to host
840 < *              - optional flags to match on as well
841 < * output       - NULL or pointer to found struct MaskItem
842 < * side effects - looks for a match on name field
473 > /*! \brief Find a connect {} conf that has a name that matches \a name.
474 > * \param name Name to match
475 > * \param compare Pointer to function to be used for string matching
476   */
477   struct MaskItem *
478 < find_matching_name_conf(enum maskitem_type type, const char *name, const char *user,
846 <                        const char *host, unsigned int flags)
478 > connect_find(const char *name, int (*compare)(const char *, const char *))
479   {
480 <  dlink_node *ptr=NULL;
849 <  struct MaskItem *conf=NULL;
850 <  dlink_list *list_p = map_to_list(type);
480 >  dlink_node *node;
481  
482 <  switch (type)
482 >  DLINK_FOREACH(node, connect_items.head)
483    {
484 <  case CONF_SERVICE:
855 <    DLINK_FOREACH(ptr, list_p->head)
856 <    {
857 <      conf = ptr->data;
858 <
859 <      if (EmptyString(conf->name))
860 <        continue;
861 <      if ((name != NULL) && !irccmp(name, conf->name))
862 <        return conf;
863 <    }
864 <    break;
484 >    struct MaskItem *conf = node->data;
485  
486 <  case CONF_XLINE:
487 <  case CONF_ULINE:
868 <  case CONF_NRESV:
869 <  case CONF_CRESV:
870 <    DLINK_FOREACH(ptr, list_p->head)
871 <    {
872 <      conf = ptr->data;
873 <
874 <      if (EmptyString(conf->name))
875 <        continue;
876 <      if ((name != NULL) && !match(conf->name, name))
877 <      {
878 <        if ((user == NULL && (host == NULL)))
879 <          return conf;
880 <        if ((conf->flags & flags) != flags)
881 <          continue;
882 <        if (EmptyString(conf->user) || EmptyString(conf->host))
883 <          return conf;
884 <        if (!match(conf->user, user) && !match(conf->host, host))
885 <          return conf;
886 <      }
887 <    }
888 <      break;
889 <
890 <  case CONF_SERVER:
891 <    DLINK_FOREACH(ptr, list_p->head)
892 <    {
893 <      conf = ptr->data;
894 <
895 <      if ((name != NULL) && !match(name, conf->name))
896 <        return conf;
897 <      else if ((host != NULL) && !match(host, conf->host))
898 <        return conf;
899 <    }
900 <    break;
901 <
902 <  default:
903 <    break;
486 >    if (compare(name, conf->name) == 0)
487 >      return conf;
488    }
489 +
490    return NULL;
491   }
492  
# Line 915 | Line 500 | find_matching_name_conf(enum maskitem_ty
500   * side effects - looks for an exact match on name field
501   */
502   struct MaskItem *
503 < find_exact_name_conf(enum maskitem_type type, const struct Client *who, const char *name,
919 <                     const char *user, const char *host)
503 > operator_find(const struct Client *client, const char *name)
504   {
505 <  dlink_node *ptr = NULL;
922 <  struct MaskItem *conf;
923 <  dlink_list *list_p = map_to_list(type);
505 >  dlink_node *node;
506  
507 <  switch(type)
507 >  DLINK_FOREACH(node, operator_items.head)
508    {
509 <  case CONF_XLINE:
928 <  case CONF_ULINE:
929 <  case CONF_NRESV:
930 <  case CONF_CRESV:
931 <
932 <    DLINK_FOREACH(ptr, list_p->head)
933 <    {
934 <      conf = ptr->data;
935 <
936 <      if (EmptyString(conf->name))
937 <        continue;
509 >    struct MaskItem *conf = node->data;
510  
511 <      if (irccmp(conf->name, name) == 0)
940 <      {
941 <        if ((user == NULL && (host == NULL)))
942 <          return conf;
943 <        if (EmptyString(conf->user) || EmptyString(conf->host))
944 <          return conf;
945 <        if (!match(conf->user, user) && !match(conf->host, host))
946 <          return conf;
947 <      }
948 <    }
949 <    break;
950 <
951 <  case CONF_OPER:
952 <    DLINK_FOREACH(ptr, list_p->head)
511 >    if (irccmp(conf->name, name) == 0)
512      {
513 <      conf = ptr->data;
513 >      if (client == NULL)
514 >        return conf;
515  
516 <      if (EmptyString(conf->name))
516 >      if (conf->class->max_total &&
517 >          conf->class->max_total <= conf->class->ref_count)
518          continue;
519  
520 <      if (!irccmp(conf->name, name))
520 >      if (match(conf->user, client->username) == 0)
521        {
522 <        if (!who)
962 <          return conf;
963 <        if (EmptyString(conf->user) || EmptyString(conf->host))
964 <          return NULL;
965 <        if (!match(conf->user, who->username))
522 >        switch (conf->htype)
523          {
524 <          switch (conf->htype)
525 <          {
526 <            case HM_HOST:
527 <              if (!match(conf->host, who->host) || !match(conf->host, who->sockhost))
528 <                if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
529 <                  return conf;
530 <              break;
531 <            case HM_IPV4:
532 <              if (who->localClient->aftype == AF_INET)
533 <                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
534 <                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
535 <                    return conf;
979 <              break;
980 < #ifdef IPV6
981 <            case HM_IPV6:
982 <              if (who->localClient->aftype == AF_INET6)
983 <                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
984 <                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
985 <                    return conf;
986 <              break;
987 < #endif
988 <            default:
989 <              assert(0);
990 <          }
524 >          case HM_HOST:
525 >            if (match(conf->host, client->realhost) == 0 ||
526 >                match(conf->host, client->sockhost) == 0 || match(conf->host, client->host) == 0)
527 >              return conf;
528 >            break;
529 >          case HM_IPV6:
530 >          case HM_IPV4:
531 >            if (address_compare(&client->ip, conf->addr, false, false, conf->bits) == true)
532 >              return conf;
533 >            break;
534 >          default:
535 >            assert(0);
536          }
537        }
538      }
994 –
995 –    break;
996 –
997 –  case CONF_SERVER:
998 –    DLINK_FOREACH(ptr, list_p->head)
999 –    {
1000 –      conf = ptr->data;
1001 –
1002 –      if (EmptyString(conf->name))
1003 –        continue;
1004 –
1005 –      if (name == NULL)
1006 –      {
1007 –        if (EmptyString(conf->host))
1008 –          continue;
1009 –        if (irccmp(conf->host, host) == 0)
1010 –          return conf;
1011 –      }
1012 –      else if (irccmp(conf->name, name) == 0)
1013 –        return conf;
1014 –    }
1015 –
1016 –    break;
1017 –
1018 –  default:
1019 –    break;
539    }
540  
541    return NULL;
542   }
543  
544 < /* rehash()
1026 < *
1027 < * Actual REHASH service routine. Called with sig == 0 if it has been called
1028 < * as a result of an operator issuing this command, else assume it has been
1029 < * called as a result of the server receiving a HUP signal.
1030 < */
1031 < int
1032 < rehash(int sig)
1033 < {
1034 <  if (sig)
1035 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1036 <                         "Got signal SIGHUP, reloading configuration file(s)");
1037 <
1038 <  restart_resolver();
1039 <
1040 <  /* don't close listeners until we know we can go ahead with the rehash */
1041 <
1042 <  /* Check to see if we magically got(or lost) IPv6 support */
1043 <  check_can_use_v6();
1044 <
1045 <  read_conf_files(0);
1046 <
1047 <  if (ServerInfo.description)
1048 <    strlcpy(me.info, ServerInfo.description, sizeof(me.info));
1049 <
1050 <  load_conf_modules();
1051 <
1052 <  rehashed_klines = 1;
1053 <
1054 <  return 0;
1055 < }
1056 <
1057 < /* set_default_conf()
544 > /* conf_set_defaults()
545   *
546   * inputs       - NONE
547   * output       - NONE
# Line 1064 | Line 551 | rehash(int sig)
551   *                of values later, put them in validate_conf().
552   */
553   static void
554 < set_default_conf(void)
554 > conf_set_defaults(void)
555   {
556 <  /* verify init_class() ran, this should be an unnecessary check
557 <   * but its not much work.
556 >  /*
557 >   * Verify init_class() ran, this should be an unnecessary check
558 >   * but it's not much work.
559     */
560    assert(class_default == class_get_list()->tail->data);
561  
562 < #ifdef HAVE_LIBCRYPTO
563 <  ServerInfo.rsa_private_key = NULL;
564 <  ServerInfo.rsa_private_key_file = NULL;
565 < #endif
566 <
567 <  /* ServerInfo.name is not rehashable */
1080 <  /* ServerInfo.name = ServerInfo.name; */
1081 <  ServerInfo.description = NULL;
1082 <  ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1083 <  ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1084 <
1085 <  memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
1086 <  ServerInfo.specific_ipv4_vhost = 0;
1087 <  memset(&ServerInfo.ip6, 0, sizeof(ServerInfo.ip6));
1088 <  ServerInfo.specific_ipv6_vhost = 0;
1089 <
1090 <  ServerInfo.max_clients = MAXCLIENTS_MAX;
1091 <  ServerInfo.max_nick_length = 9;
1092 <  ServerInfo.max_topic_length = 80;
1093 <
1094 <  ServerInfo.hub = 0;
1095 <  ServerInfo.dns_host.sin_addr.s_addr = 0;
1096 <  ServerInfo.dns_host.sin_port = 0;
1097 <  AdminInfo.name = NULL;
1098 <  AdminInfo.email = NULL;
1099 <  AdminInfo.description = NULL;
562 >  ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
563 >  ConfigServerInfo.network_description = xstrdup(NETWORK_DESCRIPTION_DEFAULT);
564 >  ConfigServerInfo.default_max_clients = MAXCLIENTS_MAX;
565 >  ConfigServerInfo.max_nick_length = 9;
566 >  ConfigServerInfo.max_topic_length = 80;
567 >  ConfigServerInfo.hub = 0;
568  
569 <  log_del_all();
569 >  log_iterate(log_free);
570  
571 <  ConfigLoggingEntry.use_logging = 1;
571 >  ConfigLog.use_logging = 1;
572  
573 +  ConfigChannel.enable_extbans = 0;
574    ConfigChannel.disable_fake_channels = 0;
575 <  ConfigChannel.knock_delay = 300;
575 >  ConfigChannel.invite_client_count = 10;
576 >  ConfigChannel.invite_client_time = 300;
577 >  ConfigChannel.invite_delay_channel = 5;
578 >  ConfigChannel.invite_expire_time = 1800;
579 >  ConfigChannel.knock_client_count = 1;
580 >  ConfigChannel.knock_client_time = 300;
581    ConfigChannel.knock_delay_channel = 60;
582 <  ConfigChannel.max_chans_per_user = 25;
583 <  ConfigChannel.max_chans_per_oper = 50;
584 <  ConfigChannel.max_bans = 25;
585 <  ConfigChannel.default_split_user_count = 0;
586 <  ConfigChannel.default_split_server_count = 0;
587 <  ConfigChannel.no_join_on_split = 0;
1114 <  ConfigChannel.no_create_on_split = 0;
582 >  ConfigChannel.max_channels = 25;
583 >  ConfigChannel.max_invites = 20;
584 >  ConfigChannel.max_bans = 100;
585 >  ConfigChannel.max_bans_large = 500;
586 >  ConfigChannel.default_join_flood_count = 18;
587 >  ConfigChannel.default_join_flood_time = 6;
588  
589    ConfigServerHide.flatten_links = 0;
590 <  ConfigServerHide.links_delay = 300;
590 >  ConfigServerHide.flatten_links_delay = 300;
591    ConfigServerHide.hidden = 0;
592    ConfigServerHide.hide_servers = 0;
593    ConfigServerHide.hide_services = 0;
# Line 1122 | Line 595 | set_default_conf(void)
595    ConfigServerHide.hide_server_ips = 0;
596    ConfigServerHide.disable_remote_commands = 0;
597  
598 <  ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
599 <  ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
600 <  ConfigFileEntry.cycle_on_host_change = 1;
601 <  ConfigFileEntry.glines = 0;
602 <  ConfigFileEntry.gline_time = 12 * 3600;
603 <  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
604 <  ConfigFileEntry.gline_min_cidr = 16;
605 <  ConfigFileEntry.gline_min_cidr6 = 48;
606 <  ConfigFileEntry.invisible_on_connect = 1;
607 <  ConfigFileEntry.tkline_expire_notices = 1;
608 <  ConfigFileEntry.hide_spoof_ips = 1;
609 <  ConfigFileEntry.ignore_bogus_ts = 0;
610 <  ConfigFileEntry.disable_auth = 0;
611 <  ConfigFileEntry.kill_chase_time_limit = 90;
612 <  ConfigFileEntry.default_floodcount = 8;
613 <  ConfigFileEntry.failed_oper_notice = 1;
614 <  ConfigFileEntry.dots_in_ident = 0;
615 <  ConfigFileEntry.min_nonwildcard = 4;
616 <  ConfigFileEntry.min_nonwildcard_simple = 3;
617 <  ConfigFileEntry.max_accept = 20;
618 <  ConfigFileEntry.anti_nick_flood = 0;
619 <  ConfigFileEntry.max_nick_time = 20;
620 <  ConfigFileEntry.max_nick_changes = 5;
621 <  ConfigFileEntry.anti_spam_exit_message_time = 0;
622 <  ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
623 <  ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
624 <  ConfigFileEntry.warn_no_nline = 1;
625 <  ConfigFileEntry.stats_o_oper_only = 0;
626 <  ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
627 <  ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
628 <  ConfigFileEntry.stats_P_oper_only = 0;
629 <  ConfigFileEntry.stats_u_oper_only = 0;
630 <  ConfigFileEntry.caller_id_wait = 60;
631 <  ConfigFileEntry.opers_bypass_callerid = 0;
632 <  ConfigFileEntry.pace_wait = 10;
633 <  ConfigFileEntry.pace_wait_simple = 1;
634 <  ConfigFileEntry.short_motd = 0;
635 <  ConfigFileEntry.ping_cookie = 0;
636 <  ConfigFileEntry.no_oper_flood = 0;
637 <  ConfigFileEntry.true_no_oper_flood = 0;
638 <  ConfigFileEntry.oper_pass_resv = 1;
639 <  ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
640 <  ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
641 <  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
642 <    UMODE_OPERWALL | UMODE_WALLOP;
643 <  ConfigFileEntry.use_egd = 0;
644 <  ConfigFileEntry.egdpool_path = NULL;
1172 <  ConfigFileEntry.throttle_time = 10;
598 >  ConfigGeneral.away_count = 2;
599 >  ConfigGeneral.away_time = 10;
600 >  ConfigGeneral.max_monitor = 50;
601 >  ConfigGeneral.whowas_history_length = 15000;
602 >  ConfigGeneral.cycle_on_host_change = 1;
603 >  ConfigGeneral.dline_min_cidr = 16;
604 >  ConfigGeneral.dline_min_cidr6 = 48;
605 >  ConfigGeneral.kline_min_cidr = 16;
606 >  ConfigGeneral.kline_min_cidr6 = 48;
607 >  ConfigGeneral.invisible_on_connect = 1;
608 >  ConfigGeneral.disable_auth = 0;
609 >  ConfigGeneral.kill_chase_time_limit = 90;
610 >  ConfigGeneral.default_floodcount = 8;
611 >  ConfigGeneral.default_floodtime = 1;
612 >  ConfigGeneral.failed_oper_notice = 1;
613 >  ConfigGeneral.dots_in_ident = 0;
614 >  ConfigGeneral.min_nonwildcard = 4;
615 >  ConfigGeneral.min_nonwildcard_simple = 3;
616 >  ConfigGeneral.max_accept = 50;
617 >  ConfigGeneral.anti_nick_flood = 0;
618 >  ConfigGeneral.max_nick_time = 20;
619 >  ConfigGeneral.max_nick_changes = 5;
620 >  ConfigGeneral.anti_spam_exit_message_time = 0;
621 >  ConfigGeneral.ts_warn_delta = 30;
622 >  ConfigGeneral.ts_max_delta = 600;
623 >  ConfigGeneral.warn_no_connect_block = 1;
624 >  ConfigGeneral.stats_e_disabled = 0;
625 >  ConfigGeneral.stats_i_oper_only = 1;  /* 1 = masked */
626 >  ConfigGeneral.stats_k_oper_only = 1;  /* 1 = masked */
627 >  ConfigGeneral.stats_o_oper_only = 1;
628 >  ConfigGeneral.stats_m_oper_only = 1;
629 >  ConfigGeneral.stats_P_oper_only = 0;
630 >  ConfigGeneral.stats_u_oper_only = 0;
631 >  ConfigGeneral.caller_id_wait = 60;
632 >  ConfigGeneral.opers_bypass_callerid = 1;
633 >  ConfigGeneral.pace_wait = 10;
634 >  ConfigGeneral.pace_wait_simple = 1;
635 >  ConfigGeneral.short_motd = 0;
636 >  ConfigGeneral.ping_cookie = 0;
637 >  ConfigGeneral.no_oper_flood = 0;
638 >  ConfigGeneral.max_targets = MAX_TARGETS_DEFAULT;
639 >  ConfigGeneral.oper_only_umodes = UMODE_DEBUG | UMODE_LOCOPS | UMODE_HIDDEN | UMODE_FARCONNECT |
640 >                                   UMODE_EXTERNAL | UMODE_FLOOD | UMODE_NCHANGE |
641 >                                   UMODE_SPY | UMODE_SKILL | UMODE_REJ | UMODE_CCONN;
642 >  ConfigGeneral.oper_umodes = UMODE_FLOOD | UMODE_LOCOPS | UMODE_SERVNOTICE | UMODE_WALLOP;
643 >  ConfigGeneral.throttle_count = 1;
644 >  ConfigGeneral.throttle_time = 1;
645   }
646  
647   static void
648 < validate_conf(void)
648 > conf_validate(void)
649   {
650 <  if (ConfigFileEntry.ts_warn_delta < TS_WARN_DELTA_MIN)
651 <    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1180 <
1181 <  if (ConfigFileEntry.ts_max_delta < TS_MAX_DELTA_MIN)
1182 <    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
650 >  if (EmptyString(ConfigServerInfo.network_name))
651 >    ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
652  
653 <  if (ServerInfo.network_name == NULL)
654 <    ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1186 <
1187 <  if (ServerInfo.network_desc == NULL)
1188 <    ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1189 <
1190 <  if (ConfigFileEntry.service_name == NULL)
1191 <    ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1192 <
1193 <  ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
653 >  if (EmptyString(ConfigServerInfo.network_description))
654 >    ConfigServerInfo.network_description = xstrdup(NETWORK_DESCRIPTION_DEFAULT);
655   }
656  
657 < /* read_conf()
657 > /* conf_read()
658   *
659   * inputs       - file descriptor pointing to config file to use
660   * output       - None
661   * side effects - Read configuration file.
662   */
663   static void
664 < read_conf(FILE *file)
664 > conf_read(FILE *file)
665   {
666 <  lineno = 0;
666 >  lineno = 1;
667  
668 <  set_default_conf(); /* Set default values prior to conf parsing */
668 >  conf_set_defaults();  /* Set default values prior to conf parsing */
669    conf_parser_ctx.pass = 1;
670 <  yyparse();          /* pick up the classes first */
670 >  yyparse();  /* Pick up the classes first */
671  
672    rewind(file);
673  
674    conf_parser_ctx.pass = 2;
675 <  yyparse();          /* Load the values from the conf */
676 <  validate_conf();    /* Check to make sure some values are still okay. */
677 <                      /* Some global values are also loaded here. */
678 <  class_delete_marked();      /* Make sure classes are valid */
675 >  yyparse();  /* Load the values from the conf */
676 >  conf_validate();  /* Check to make sure some values are still okay. */
677 >                    /* Some global values are also loaded here. */
678 >  whowas_trim();  /* Attempt to trim whowas list if necessary */
679 >  class_delete_marked();  /* Delete unused classes that are marked for deletion */
680   }
681  
682 < /* lookup_confhost()
682 > /* conf_rehash()
683   *
684 < * start DNS lookups of all hostnames in the conf
685 < * line and convert an IP addresses in a.b.c.d number for to IP#s.
684 > * Actual REHASH service routine. Called with sig == 0 if it has been called
685 > * as a result of an operator issuing this command, else assume it has been
686 > * called as a result of the server receiving a HUP signal.
687   */
688   void
689 < lookup_confhost(struct MaskItem *conf)
689 > conf_rehash(bool sig)
690   {
691 <  struct addrinfo hints, *res;
1229 <
1230 <  /* Do name lookup now on hostnames given and store the
1231 <   * ip numbers in conf structure.
1232 <   */
1233 <  memset(&hints, 0, sizeof(hints));
1234 <
1235 <  hints.ai_family   = AF_UNSPEC;
1236 <  hints.ai_socktype = SOCK_STREAM;
1237 <
1238 <  /* Get us ready for a bind() and don't bother doing dns lookup */
1239 <  hints.ai_flags = AI_PASSIVE | AI_NUMERICHOST;
1240 <
1241 <  if (getaddrinfo(conf->host, NULL, &hints, &res))
691 >  if (sig == true)
692    {
693 <    conf_dns_lookup(conf);
694 <    return;
693 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
694 >                         "Got signal SIGHUP, reloading configuration file(s)");
695 >    ilog(LOG_TYPE_IRCD, "Got signal SIGHUP, reloading configuration file(s)");
696    }
697  
698 <  assert(res);
698 >  restart_resolver();
699  
700 <  memcpy(&conf->addr, res->ai_addr, res->ai_addrlen);
1250 <  conf->addr.ss_len = res->ai_addrlen;
1251 <  conf->addr.ss.ss_family = res->ai_family;
700 >  /* don't close listeners until we know we can go ahead with the rehash */
701  
702 <  freeaddrinfo(res);
702 >  conf_read_files(false);
703 >
704 >  load_conf_modules();
705 >  check_conf_klines();
706   }
707  
708   /* conf_connect_allowed()
# Line 1261 | Line 713 | lookup_confhost(struct MaskItem *conf)
713   * side effects - none
714   */
715   int
716 < conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
716 > conf_connect_allowed(struct irc_ssaddr *addr)
717   {
718 <  struct ip_entry *ip_found;
1267 <  struct MaskItem *conf = find_dline_conf(addr, aftype);
1268 <
1269 <  /* DLINE exempt also gets you out of static limits/pacing... */
1270 <  if (conf && (conf->type == CONF_EXEMPT))
1271 <    return 0;
718 >  const struct MaskItem *conf = find_dline_conf(addr);
719  
720    if (conf)
721 +  {
722 +    /* DLINE exempt also gets you out of static limits/pacing... */
723 +    if (conf->type == CONF_EXEMPT)
724 +      return 0;
725      return BANNED_CLIENT;
726 +  }
727  
728 <  ip_found = find_or_add_ip(addr);
729 <
1278 <  if ((CurrentTime - ip_found->last_attempt) <
1279 <      ConfigFileEntry.throttle_time)
728 >  struct ip_entry *ip_found = ipcache_record_find_or_add(addr);
729 >  if ((event_base->time.sec_monotonic - ip_found->last_attempt) < ConfigGeneral.throttle_time)
730    {
731 <    ip_found->last_attempt = CurrentTime;
732 <    return TOO_FAST;
731 >    if (ip_found->connection_count >= ConfigGeneral.throttle_count)
732 >      return TOO_FAST;
733 >
734 >    ++ip_found->connection_count;
735    }
736 +  else
737 +    ip_found->connection_count = 1;
738  
739 <  ip_found->last_attempt = CurrentTime;
739 >  ip_found->last_attempt = event_base->time.sec_monotonic;
740    return 0;
741   }
742  
# Line 1294 | Line 748 | conf_connect_allowed(struct irc_ssaddr *
748   *                This is an event started off in ircd.c
749   */
750   void
751 < cleanup_tklines(void *notused)
751 > cleanup_tklines(void *unused)
752   {
753    hostmask_expire_temporary();
754 <  expire_tklines(&xconf_items);
755 <  expire_tklines(&nresv_items);
1302 <  expire_tklines(&cresv_items);
754 >  gecos_expire();
755 >  resv_expire();
756   }
757  
758 < /* expire_tklines()
759 < *
760 < * inputs       - tkline list pointer
761 < * output       - NONE
762 < * side effects - expire tklines
758 > /*
759 > * Input: A client to find the active operator {} name for.
760 > * Output: The nick!user@host{oper} of the oper.
761 > *         "oper" is server name for remote opers
762 > * Side effects: None.
763   */
764 < static void
765 < expire_tklines(dlink_list *tklist)
764 > const char *
765 > get_oper_name(const struct Client *client)
766   {
767 <  dlink_node *ptr = NULL, *ptr_next = NULL;
1315 <  struct MaskItem *conf = NULL;
767 >  static char buf[IRCD_BUFSIZE];
768  
769 <  DLINK_FOREACH_SAFE(ptr, ptr_next, tklist->head)
770 <  {
1319 <    conf = ptr->data;
769 >  if (IsServer(client))
770 >    return client->name;
771  
772 <    if (!conf->until || conf->until > CurrentTime)
773 <      continue;
772 >  if (MyConnect(client))
773 >  {
774 >    const dlink_node *const node = client->connection->confs.head;
775  
776 <    if (conf->type == CONF_XLINE)
776 >    if (node)
777      {
778 <      if (ConfigFileEntry.tkline_expire_notices)
779 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
780 <                               "Temporary X-line for [%s] expired", conf->name);
781 <      conf_free(conf);
782 <    }
783 <    else if (conf->type == CONF_NRESV || conf->type == CONF_CRESV)
784 <    {
785 <      if (ConfigFileEntry.tkline_expire_notices)
1334 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1335 <                               "Temporary RESV for [%s] expired", conf->name);
1336 <      conf_free(conf);
778 >      const struct MaskItem *const conf = node->data;
779 >
780 >      if (conf->type == CONF_OPER)
781 >      {
782 >        snprintf(buf, sizeof(buf), "%s!%s@%s{%s}", client->name,
783 >                 client->username, client->host, conf->name);
784 >        return buf;
785 >      }
786      }
787 +
788 +    /*
789 +     * Probably should assert here for now. If there is an oper out there
790 +     * with no operator {} conf attached, it would be good for us to know...
791 +     */
792 +    assert(0);  /* Oper without oper conf! */
793    }
794 +
795 +  snprintf(buf, sizeof(buf), "%s!%s@%s{%s}", client->name,
796 +           client->username, client->host, client->servptr->name);
797 +  return buf;
798   }
799  
800 < /* oper_privs_as_string()
800 > /* conf_clear()
801   *
802 < * inputs        - pointer to client_p
803 < * output        - pointer to static string showing oper privs
804 < * side effects  - return as string, the oper privs as derived from port
805 < */
806 < static const struct oper_privs
807 < {
1349 <  const unsigned int flag;
1350 <  const unsigned char c;
1351 < } flag_list[] = {
1352 <  { OPER_FLAG_ADMIN,          'A' },
1353 <  { OPER_FLAG_REMOTEBAN,      'B' },
1354 <  { OPER_FLAG_DIE,            'D' },
1355 <  { OPER_FLAG_GLINE,          'G' },
1356 <  { OPER_FLAG_REHASH,         'H' },
1357 <  { OPER_FLAG_K,              'K' },
1358 <  { OPER_FLAG_OPERWALL,       'L' },
1359 <  { OPER_FLAG_KILL,           'N' },
1360 <  { OPER_FLAG_KILL_REMOTE,    'O' },
1361 <  { OPER_FLAG_CONNECT,        'P' },
1362 <  { OPER_FLAG_CONNECT_REMOTE, 'Q' },
1363 <  { OPER_FLAG_SQUIT,          'R' },
1364 <  { OPER_FLAG_SQUIT_REMOTE,   'S' },
1365 <  { OPER_FLAG_UNKLINE,        'U' },
1366 <  { OPER_FLAG_XLINE,          'X' },
1367 <  { 0, '\0' }
1368 < };
1369 <
1370 < char *
1371 < oper_privs_as_string(const unsigned int port)
802 > * inputs       - none
803 > * output       - none
804 > * side effects - Clear out the old configuration
805 > */
806 > static void
807 > conf_clear(void)
808   {
809 <  static char privs_out[IRCD_BUFSIZE];
810 <  char *privs_ptr = privs_out;
809 >  dlink_node *node = NULL, *node_next = NULL;
810 >  dlink_list *free_items [] = {
811 >    &connect_items, &operator_items, NULL
812 >  };
813 >
814 >  dlink_list ** iterator = free_items; /* C is dumb */
815  
816 <  for (const struct oper_privs *opriv = flag_list; opriv->flag; ++opriv)
816 >  /* We only need to free anything allocated by yyparse() here.
817 >   * Resetting structs, etc, is taken care of by conf_set_defaults().
818 >   */
819 >
820 >  for (; *iterator; iterator++)
821    {
822 <    if (port & opriv->flag)
823 <      *privs_ptr++ = opriv->c;
824 <    else
825 <      *privs_ptr++ = ToLower(opriv->c);
822 >    DLINK_FOREACH_SAFE(node, node_next, (*iterator)->head)
823 >    {
824 >      struct MaskItem *conf = node->data;
825 >
826 >      conf->active = false;
827 >      dlinkDelete(&conf->node, *iterator);
828 >
829 >      if (!conf->ref_count)
830 >        conf_free(conf);
831 >    }
832    }
833  
834 <  *privs_ptr = '\0';
834 >  /*
835 >   * Don't delete the class table, rather mark all entries for deletion.
836 >   * The table is cleaned up by class_delete_marked. - avalon
837 >   */
838 >  class_mark_for_deletion();
839 >
840 >  clear_out_address_conf();
841 >
842 >  modules_conf_clear();  /* Clear modules {} items */
843 >
844 >  motd_clear();  /* Clear motd {} items and re-cache default motd */
845 >
846 >  cluster_clear();  /* Clear cluster {} items */
847  
848 <  return privs_out;
848 >  gecos_clear();  /* Clear gecos {} items */
849 >
850 >  resv_clear();  /* Clear resv {} items */
851 >
852 >  service_clear();  /* Clear service {} items */
853 >
854 >  shared_clear();  /* Clear shared {} items */
855 >
856 >  pseudo_clear();  /* Clear pseudo {} items */
857 >
858 >  /* Clean out ConfigServerInfo */
859 >  xfree(ConfigServerInfo.description);
860 >  ConfigServerInfo.description = NULL;
861 >  xfree(ConfigServerInfo.network_name);
862 >  ConfigServerInfo.network_name = NULL;
863 >  xfree(ConfigServerInfo.network_description);
864 >  ConfigServerInfo.network_description = NULL;
865 >  xfree(ConfigServerInfo.rsa_private_key_file);
866 >  ConfigServerInfo.rsa_private_key_file = NULL;
867 >  xfree(ConfigServerInfo.tls_certificate_file);
868 >  ConfigServerInfo.tls_certificate_file = NULL;
869 >  xfree(ConfigServerInfo.tls_dh_param_file);
870 >  ConfigServerInfo.tls_dh_param_file = NULL;
871 >  xfree(ConfigServerInfo.tls_supported_groups);
872 >  ConfigServerInfo.tls_supported_groups = NULL;
873 >  xfree(ConfigServerInfo.tls_cipher_list);
874 >  ConfigServerInfo.tls_cipher_list = NULL;
875 >  xfree(ConfigServerInfo.tls_cipher_suites);
876 >  ConfigServerInfo.tls_cipher_suites = NULL;
877 >  xfree(ConfigServerInfo.tls_message_digest_algorithm);
878 >  ConfigServerInfo.tls_message_digest_algorithm = NULL;
879 >
880 >  /* Clean out ConfigAdminInfo */
881 >  xfree(ConfigAdminInfo.name);
882 >  ConfigAdminInfo.name = NULL;
883 >  xfree(ConfigAdminInfo.email);
884 >  ConfigAdminInfo.email = NULL;
885 >  xfree(ConfigAdminInfo.description);
886 >  ConfigAdminInfo.description = NULL;
887 >
888 >  /* Clean out ConfigServerHide */
889 >  xfree(ConfigServerHide.flatten_links_file);
890 >  ConfigServerHide.flatten_links_file = NULL;
891 >  xfree(ConfigServerHide.hidden_name);
892 >  ConfigServerHide.hidden_name = NULL;
893 >
894 >  /* Clean out listeners */
895 >  listener_close_marked();
896   }
897  
898 < /*
899 < * Input: A client to find the active oper{} name for.
1391 < * Output: The nick!user@host{oper} of the oper.
1392 < *         "oper" is server name for remote opers
1393 < * Side effects: None.
1394 < */
1395 < const char *
1396 < get_oper_name(const struct Client *client_p)
898 > static void
899 > conf_handle_tls(bool cold)
900   {
901 <  const dlink_node *cnode = NULL;
1399 <  /* +5 for !,@,{,} and null */
1400 <  static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
1401 <
1402 <  if (MyConnect(client_p))
901 >  if (tls_new_credentials() == false)
902    {
903 <    if ((cnode = client_p->localClient->confs.head))
903 >    if (cold == true)
904      {
905 <      const struct MaskItem *conf = cnode->data;
906 <
907 <      if (IsConfOperator(conf))
908 <      {
909 <        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
910 <                 client_p->username, client_p->host, conf->name);
911 <        return buffer;
912 <      }
905 >      ilog(LOG_TYPE_IRCD, "Error while initializing TLS");
906 >      exit(EXIT_FAILURE);
907 >    }
908 >    else
909 >    {
910 >      /* Failed to load new settings/certs, old ones remain active */
911 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
912 >                           "Error reloading TLS settings, check the ircd log"); // report_crypto_errors logs this
913      }
1415 –
1416 –    /* Probably should assert here for now. If there is an oper out there
1417 –     * with no oper{} conf attached, it would be good for us to know...
1418 –     */
1419 –    assert(0); /* Oper without oper conf! */
914    }
1421 –
1422 –  snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1423 –           client_p->username, client_p->host, client_p->servptr->name);
1424 –  return buffer;
915   }
916  
917   /* read_conf_files()
# Line 1431 | Line 921 | get_oper_name(const struct Client *clien
921   * side effects - read all conf files needed, ircd.conf kline.conf etc.
922   */
923   void
924 < read_conf_files(int cold)
924 > conf_read_files(bool cold)
925   {
926 <  const char *filename;
1437 <  char chanmodes[IRCD_BUFSIZE];
1438 <  char chanlimit[IRCD_BUFSIZE];
926 >  char buf[IRCD_BUFSIZE];
927  
928    conf_parser_ctx.boot = cold;
929 <  filename = ConfigFileEntry.configfile;
1442 <
1443 <  /* We need to know the initial filename for the yyerror() to report
1444 <     FIXME: The full path is in conffilenamebuf first time since we
1445 <             dont know anything else
929 >  conf_parser_ctx.conf_file = fopen(ConfigGeneral.configfile, "r");
930  
931 <     - Gozem 2002-07-21
1448 <  */
1449 <  strlcpy(conffilebuf, filename, sizeof(conffilebuf));
1450 <
1451 <  if ((conf_parser_ctx.conf_file = fopen(filename, "r")) == NULL)
931 >  if (conf_parser_ctx.conf_file == NULL)
932    {
933 <    if (cold)
933 >    if (cold == true)
934      {
935        ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
936 <           filename, strerror(errno));
937 <      exit(-1);
936 >           ConfigGeneral.configfile, strerror(errno));
937 >      exit(EXIT_FAILURE);
938      }
939      else
940      {
941 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
941 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
942                             "Unable to read configuration file '%s': %s",
943 <                           filename, strerror(errno));
943 >                           ConfigGeneral.configfile, strerror(errno));
944        return;
945      }
946    }
947  
1468 –  if (!cold)
1469 –    clear_out_old_conf();
1470 –
1471 –  read_conf(conf_parser_ctx.conf_file);
1472 –  fclose(conf_parser_ctx.conf_file);
1473 –
1474 –  log_reopen_all();
1475 –
1476 –  add_isupport("NICKLEN", NULL, ServerInfo.max_nick_length);
1477 –  add_isupport("NETWORK", ServerInfo.network_name, -1);
1478 –
1479 –  snprintf(chanmodes, sizeof(chanmodes), "beI:%d", ConfigChannel.max_bans);
1480 –  add_isupport("MAXLIST", chanmodes, -1);
1481 –  add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1482 –  add_isupport("CHANTYPES", "#", -1);
1483 –
1484 –  snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1485 –           ConfigChannel.max_chans_per_user);
1486 –  add_isupport("CHANLIMIT", chanlimit, -1);
1487 –  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,imnprstORS");
1488 –  add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
1489 –  add_isupport("TOPICLEN", NULL, ServerInfo.max_topic_length);
1490 –  add_isupport("CHANMODES", chanmodes, -1);
1491 –
948    /*
949 <   * message_locale may have changed.  rebuild isupport since it relies
950 <   * on strlen(form_str(RPL_ISUPPORT))
949 >   * We need to know the initial filename for the yyerror() to report
950 >   *
951 >   *  FIXME: The full path is in conffilenamebuf first time since we
952 >   *          don't know anything else
953 >   *
954 >   *  - Gozem 2002-07-21
955     */
956 <  rebuild_isupport_message_line();
1497 < }
956 >  strlcpy(conffilebuf, ConfigGeneral.configfile, sizeof(conffilebuf));
957  
958 < /* clear_out_old_conf()
959 < *
1501 < * inputs       - none
1502 < * output       - none
1503 < * side effects - Clear out the old configuration
1504 < */
1505 < static void
1506 < clear_out_old_conf(void)
1507 < {
1508 <  dlink_node *ptr = NULL, *next_ptr = NULL;
1509 <  struct MaskItem *conf;
1510 <  dlink_list *free_items [] = {
1511 <    &server_items,   &oconf_items,
1512 <     &uconf_items,   &xconf_items,
1513 <     &nresv_items, &cluster_items,  &service_items, &cresv_items, NULL
1514 <  };
958 >  if (cold == false)
959 >    conf_clear();
960  
961 <  dlink_list ** iterator = free_items; /* C is dumb */
961 >  conf_read(conf_parser_ctx.conf_file);
962 >  fclose(conf_parser_ctx.conf_file);
963  
964 <  /* We only need to free anything allocated by yyparse() here.
965 <   * Resetting structs, etc, is taken care of by set_default_conf().
1520 <   */
964 >  log_iterate(log_reopen);
965 >  conf_handle_tls(cold);
966  
967 <  for (; *iterator != NULL; iterator++)
968 <  {
1524 <    DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
1525 <    {
1526 <      conf = ptr->data;
967 >  isupport_add("NICKLEN", NULL, ConfigServerInfo.max_nick_length);
968 >  isupport_add("NETWORK", ConfigServerInfo.network_name, -1);
969  
970 <      dlinkDelete(&conf->node, map_to_list(conf->type));
970 >  snprintf(buf, sizeof(buf), "beI:%u", ConfigChannel.max_bans);
971 >  isupport_add("MAXLIST", buf, -1);
972  
973 <      /* XXX This is less than pretty */
974 <      if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
1532 <      {
1533 <        if (!conf->ref_count)
1534 <          conf_free(conf);
1535 <      }
1536 <      else if (conf->type == CONF_XLINE)
1537 <      {
1538 <        if (!conf->until)
1539 <          conf_free(conf);
1540 <      }
1541 <      else
1542 <        conf_free(conf);
1543 <    }
1544 <  }
973 >  isupport_add("MAXTARGETS", NULL, ConfigGeneral.max_targets);
974 >  isupport_add("CHANTYPES", "#", -1);
975  
976 <  motd_clear();
976 >  snprintf(buf, sizeof(buf), "#:%u", ConfigChannel.max_channels);
977 >  isupport_add("CHANLIMIT", buf, -1);
978  
979 <  /*
980 <   * don't delete the class table, rather mark all entries
1550 <   * for deletion. The table is cleaned up by class_delete_marked. - avalon
1551 <   */
1552 <  class_mark_for_deletion();
1553 <
1554 <  clear_out_address_conf();
979 >  isupport_add("CHANNELLEN", NULL, CHANNELLEN);
980 >  isupport_add("TOPICLEN", NULL, ConfigServerInfo.max_topic_length);
981  
982 <  /* clean out module paths */
983 <  mod_clear_paths();
1558 <
1559 <  /* clean out ServerInfo */
1560 <  MyFree(ServerInfo.description);
1561 <  ServerInfo.description = NULL;
1562 <  MyFree(ServerInfo.network_name);
1563 <  ServerInfo.network_name = NULL;
1564 <  MyFree(ServerInfo.network_desc);
1565 <  ServerInfo.network_desc = NULL;
1566 <  MyFree(ConfigFileEntry.egdpool_path);
1567 <  ConfigFileEntry.egdpool_path = NULL;
1568 < #ifdef HAVE_LIBCRYPTO
1569 <  if (ServerInfo.rsa_private_key)
1570 <  {
1571 <    RSA_free(ServerInfo.rsa_private_key);
1572 <    ServerInfo.rsa_private_key = NULL;
1573 <  }
1574 <
1575 <  MyFree(ServerInfo.rsa_private_key_file);
1576 <  ServerInfo.rsa_private_key_file = NULL;
1577 <
1578 <  if (ServerInfo.server_ctx)
1579 <    SSL_CTX_set_options(ServerInfo.server_ctx, SSL_OP_NO_SSLv2|
1580 <                                               SSL_OP_NO_SSLv3|
1581 <                                               SSL_OP_NO_TLSv1);
1582 <  if (ServerInfo.client_ctx)
1583 <    SSL_CTX_set_options(ServerInfo.client_ctx, SSL_OP_NO_SSLv2|
1584 <                                               SSL_OP_NO_SSLv3|
1585 <                                               SSL_OP_NO_TLSv1);
1586 < #endif
1587 <
1588 <  /* clean out AdminInfo */
1589 <  MyFree(AdminInfo.name);
1590 <  AdminInfo.name = NULL;
1591 <  MyFree(AdminInfo.email);
1592 <  AdminInfo.email = NULL;
1593 <  MyFree(AdminInfo.description);
1594 <  AdminInfo.description = NULL;
1595 <
1596 <  /* clean out listeners */
1597 <  close_listeners();
1598 <
1599 <  /* clean out general */
1600 <  MyFree(ConfigFileEntry.service_name);
1601 <  ConfigFileEntry.service_name = NULL;
982 >  snprintf(buf, sizeof(buf), "%s", "beI,k,l,cimnprstuCKLMNORST");
983 >  isupport_add("CHANMODES", buf, -1);
984   }
985  
986   /* conf_add_class_to_conf()
# Line 1608 | Line 990 | clear_out_old_conf(void)
990   * side effects - Add a class pointer to a conf
991   */
992   void
993 < conf_add_class_to_conf(struct MaskItem *conf, const char *class_name)
993 > conf_add_class_to_conf(struct MaskItem *conf, const char *name)
994   {
995 <  if (class_name == NULL)
995 >  if (EmptyString(name) || (conf->class = class_find(name, true)) == NULL)
996    {
997      conf->class = class_default;
998  
999 <    if (conf->type == CONF_CLIENT)
1000 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1619 <                           "Warning *** Defaulting to default class for %s@%s",
1620 <                           conf->user, conf->host);
1621 <    else
1622 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1623 <                           "Warning *** Defaulting to default class for %s",
1624 <                           conf->name);
1625 <  }
1626 <  else
1627 <    conf->class = class_find(class_name, 1);
1628 <
1629 <  if (conf->class == NULL)
1630 <  {
1631 <    if (conf->type == CONF_CLIENT)
1632 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
999 >    if (conf->type == CONF_CLIENT || conf->type == CONF_OPER)
1000 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1001                             "Warning *** Defaulting to default class for %s@%s",
1002                             conf->user, conf->host);
1003      else
1004 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1004 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1005                             "Warning *** Defaulting to default class for %s",
1006                             conf->name);
1639 –    conf->class = class_default;
1007    }
1008   }
1009  
# Line 1649 | Line 1016 | conf_add_class_to_conf(struct MaskItem *
1016   void
1017   yyerror(const char *msg)
1018   {
1652 –  char newlinebuf[IRCD_BUFSIZE];
1653 –
1019    if (conf_parser_ctx.pass != 1)
1020      return;
1021  
1022 <  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1023 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1022 >  const char *p = stripws(linebuf);
1023 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1024                         "\"%s\", line %u: %s: %s",
1025 <                       conffilebuf, lineno + 1, msg, newlinebuf);
1025 >                       conffilebuf, lineno, msg, p);
1026    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1027 <       conffilebuf, lineno + 1, msg, newlinebuf);
1027 >       conffilebuf, lineno, msg, p);
1028   }
1029  
1030   void
1031   conf_error_report(const char *msg)
1032   {
1033 <  char newlinebuf[IRCD_BUFSIZE];
1034 <
1670 <  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1671 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1033 >  const char *p = stripws(linebuf);
1034 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1035                         "\"%s\", line %u: %s: %s",
1036 <                       conffilebuf, lineno + 1, msg, newlinebuf);
1036 >                       conffilebuf, lineno, msg, p);
1037    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1038 <       conffilebuf, lineno + 1, msg, newlinebuf);
1038 >       conffilebuf, lineno, msg, p);
1039   }
1040  
1041   /*
# Line 1685 | Line 1048 | conf_error_report(const char *msg)
1048   * side effects - none
1049   * Originally written by Dianora (Diane, db@db.net)
1050   */
1051 < time_t
1051 > uintmax_t
1052   valid_tkline(const char *data, const int minutes)
1053   {
1054    const unsigned char *p = (const unsigned char *)data;
1055    unsigned char tmpch = '\0';
1056 <  time_t result = 0;
1056 >  uintmax_t result = 0;
1057  
1058    while ((tmpch = *p++))
1059    {
# Line 1703 | Line 1066 | valid_tkline(const char *data, const int
1066  
1067    /*
1068     * In the degenerate case where oper does a /quote kline 0 user@host :reason
1069 <   * i.e. they specifically use 0, I am going to return 1 instead
1070 <   * as a return value of non-zero is used to flag it as a temporary kline
1069 >   * i.e. they specifically use 0, I am going to return 1 instead as a return
1070 >   * value of non-zero is used to flag it as a temporary kline
1071     */
1072    if (result == 0)
1073      result = 1;
# Line 1713 | Line 1076 | valid_tkline(const char *data, const int
1076     * If the incoming time is in seconds convert it to minutes for the purpose
1077     * of this calculation
1078     */
1079 <  if (!minutes)
1079 >  if (minutes == 0)
1080      result = result / 60;
1081  
1082    if (result > MAX_TDKLINE_TIME)
1083      result = MAX_TDKLINE_TIME;
1084  
1085 <  result = result * 60;  /* turn it into seconds */
1085 >  result = result * 60;  /* Turn it into seconds */
1086  
1087    return result;
1088   }
# Line 1730 | Line 1093 | valid_tkline(const char *data, const int
1093   * outputs      - 1 if valid, else 0
1094   * side effects - none
1095   */
1096 < int
1096 > bool
1097   valid_wild_card_simple(const char *data)
1098   {
1099    const unsigned char *p = (const unsigned char *)data;
1100    unsigned char tmpch = '\0';
1101 <  int nonwild = 0;
1101 >  unsigned int nonwild = 0, wild = 0;
1102  
1103    while ((tmpch = *p++))
1104    {
1105 <    if (tmpch == '\\')
1105 >    if (tmpch == '\\' && *p)
1106      {
1107        ++p;
1108 <      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1109 <        return 1;
1108 >      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1109 >        return true;
1110      }
1111      else if (!IsMWildChar(tmpch))
1112      {
1113 <      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1114 <        return 1;
1113 >      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1114 >        return true;
1115      }
1116 +    else
1117 +      ++wild;
1118    }
1119  
1120 <  return 0;
1120 >  return wild == 0;
1121   }
1122  
1123   /* valid_wild_card()
# Line 1761 | Line 1126 | valid_wild_card_simple(const char *data)
1126   *              - int flag, 0 for no warning oper 1 for warning oper
1127   *              - count of following varargs to check
1128   * output       - 0 if not valid, 1 if valid
1129 < * side effects - NOTICE is given to source_p if warn is 1
1129 > * side effects - NOTICE is given to client if warn is 1
1130   */
1131 < int
1132 < valid_wild_card(struct Client *source_p, int warn, int count, ...)
1131 > bool
1132 > valid_wild_card(int count, ...)
1133   {
1134 <  char tmpch;
1135 <  int nonwild = 0;
1134 >  unsigned char tmpch = '\0';
1135 >  unsigned int nonwild = 0;
1136    va_list args;
1137  
1138    /*
# Line 1786 | Line 1151 | valid_wild_card(struct Client *source_p,
1151  
1152    while (count--)
1153    {
1154 <    const char *p = va_arg(args, const char *);
1154 >    const unsigned char *p = va_arg(args, const unsigned char *);
1155      if (p == NULL)
1156        continue;
1157  
# Line 1798 | Line 1163 | valid_wild_card(struct Client *source_p,
1163           * If we find enough non-wild characters, we can
1164           * break - no point in searching further.
1165           */
1166 <        if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1166 >        if (++nonwild >= ConfigGeneral.min_nonwildcard)
1167          {
1168            va_end(args);
1169 <          return 1;
1169 >          return true;
1170          }
1171        }
1172      }
1173    }
1174  
1810 –  if (warn)
1811 –    sendto_one_notice(source_p, &me,
1812 –                      ":Please include at least %d non-wildcard characters with the mask",
1813 –                      ConfigFileEntry.min_nonwildcard);
1175    va_end(args);
1176 <  return 0;
1176 >  return false;
1177   }
1178  
1179   /* XXX should this go into a separate file ? -Dianora */
# Line 1829 | Line 1190 | valid_wild_card(struct Client *source_p,
1190   *              - pointer to target_server to parse into if non NULL
1191   *              - pointer to reason to parse into
1192   *
1193 < * output       - 1 if valid, -1 if not valid
1193 > * output       - 1 if valid, 0 if not valid
1194   * side effects - A generalised k/d/x etc. line parser,
1195   *               "ALINE [time] user@host|string [ON] target :reason"
1196   *                will parse returning a parsed user, host if
# Line 1845 | Line 1206 | valid_wild_card(struct Client *source_p,
1206   *
1207   * - Dianora
1208   */
1209 < int
1210 < parse_aline(const char *cmd, struct Client *source_p,
1850 <            int parc, char **parv,
1851 <            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1852 <            char **target_server, char **reason)
1209 > bool
1210 > parse_aline(const char *cmd, struct Client *client, int parc, char **parv, struct aline_ctx *aline)
1211   {
1212 <  int found_tkline_time=0;
1213 <  static char def_reason[] = "No Reason";
1214 <  static char user[USERLEN*4+1];
1857 <  static char host[HOSTLEN*4+1];
1212 >  static char default_reason[] = CONF_NOREASON;
1213 >  static char user[USERLEN * 2 + 1];
1214 >  static char host[HOSTLEN * 2 + 1];
1215  
1216 <  parv++;
1217 <  parc--;
1216 >  ++parv;
1217 >  --parc;
1218  
1219 <  found_tkline_time = valid_tkline(*parv, TK_MINUTES);
1863 <
1864 <  if (found_tkline_time != 0)
1219 >  if (aline->add == true && (aline->duration = valid_tkline(*parv, TK_MINUTES)))
1220    {
1221 <    parv++;
1222 <    parc--;
1868 <
1869 <    if (tkline_time != NULL)
1870 <      *tkline_time = found_tkline_time;
1871 <    else
1872 <    {
1873 <      sendto_one_notice(source_p, &me, ":temp_line not supported by %s", cmd);
1874 <      return -1;
1875 <    }
1221 >    ++parv;
1222 >    --parc;
1223    }
1224  
1225    if (parc == 0)
1226    {
1227 <    sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1228 <    return -1;
1227 >    sendto_one_numeric(client, &me, ERR_NEEDMOREPARAMS, cmd);
1228 >    return false;
1229    }
1230  
1231 <  if (h_p == NULL)
1232 <    *up_p = *parv;
1231 >  if (aline->simple_mask == true)
1232 >  {
1233 >    aline->mask = *parv;
1234 >    aline->user = NULL;
1235 >    aline->host = NULL;
1236 >  }
1237    else
1238    {
1239 <    if (find_user_host(source_p, *parv, user, host, parse_flags) == 0)
1240 <      return -1;
1239 >    struct split_nuh_item nuh;
1240 >
1241 >    nuh.nuhmask  = *parv;
1242 >    nuh.nickptr  = NULL;
1243 >    nuh.userptr  = user;
1244 >    nuh.hostptr  = host;
1245 >
1246 >    nuh.nicksize = 0;
1247 >    nuh.usersize = sizeof(user);
1248 >    nuh.hostsize = sizeof(host);
1249  
1250 <    *up_p = user;
1251 <    *h_p = host;
1250 >    split_nuh(&nuh);
1251 >
1252 >    aline->mask = NULL;
1253 >    aline->user = user;
1254 >    aline->host = host;
1255    }
1256  
1257 <  parc--;
1258 <  parv++;
1257 >  ++parv;
1258 >  --parc;
1259  
1260 <  if (parc != 0)
1260 >  if (parc)
1261    {
1262      if (irccmp(*parv, "ON") == 0)
1263      {
1264 <      parc--;
1265 <      parv++;
1904 <
1905 <      if (target_server == NULL)
1906 <      {
1907 <        sendto_one_notice(source_p, &me, ":ON server not supported by %s", cmd);
1908 <        return -1;
1909 <      }
1264 >      ++parv;
1265 >      --parc;
1266  
1267 <      if (!HasOFlag(source_p, OPER_FLAG_REMOTEBAN))
1267 >      if (!HasOFlag(client, OPER_FLAG_REMOTEBAN))
1268        {
1269 <        sendto_one_numeric(source_p, &me, ERR_NOPRIVS, "remoteban");
1270 <        return -1;
1269 >        sendto_one_numeric(client, &me, ERR_NOPRIVS, "remoteban");
1270 >        return false;
1271        }
1272  
1273        if (parc == 0 || EmptyString(*parv))
1274        {
1275 <        sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1276 <        return -1;
1275 >        sendto_one_numeric(client, &me, ERR_NEEDMOREPARAMS, cmd);
1276 >        return false;
1277        }
1278  
1279 <      *target_server = *parv;
1280 <      parc--;
1281 <      parv++;
1279 >      aline->server = *parv;
1280 >      ++parv;
1281 >      --parc;
1282      }
1283      else
1284 <    {
1929 <      /* Make sure target_server *is* NULL if no ON server found
1930 <       * caller probably NULL'd it first, but no harm to do it again -db
1931 <       */
1932 <      if (target_server != NULL)
1933 <        *target_server = NULL;
1934 <    }
1284 >      aline->server = NULL;
1285    }
1286  
1287 <  if (h_p != NULL)
1287 >  if (aline->add == true)
1288    {
1289 <    if (strchr(user, '!') != NULL)
1290 <    {
1941 <      sendto_one_notice(source_p, &me, ":Invalid character '!' in kline");
1942 <      return -1;
1943 <    }
1944 <
1945 <    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 2, *up_p, *h_p))
1946 <      return -1;
1947 <  }
1948 <  else
1949 <    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 1, *up_p))
1950 <      return -1;
1951 <
1952 <  if (reason != NULL)
1953 <  {
1954 <    if (parc != 0 && !EmptyString(*parv))
1955 <    {
1956 <      *reason = *parv;
1957 <      if (!valid_comment(source_p, *reason, 1))
1958 <        return -1;
1959 <    }
1289 >    if (parc == 0 || EmptyString(*parv))
1290 >      aline->reason = default_reason;
1291      else
1292 <      *reason = def_reason;
1292 >      aline->reason = *parv;
1293    }
1294  
1295 <  return 1;
1965 < }
1966 <
1967 < /* find_user_host()
1968 < *
1969 < * inputs       - pointer to client placing kline
1970 < *              - pointer to user_host_or_nick
1971 < *              - pointer to user buffer
1972 < *              - pointer to host buffer
1973 < * output       - 0 if not ok to kline, 1 to kline i.e. if valid user host
1974 < * side effects -
1975 < */
1976 < static int
1977 < find_user_host(struct Client *source_p, char *user_host_or_nick,
1978 <               char *luser, char *lhost, unsigned int flags)
1979 < {
1980 <  struct Client *target_p = NULL;
1981 <  char *hostp = NULL;
1982 <
1983 <  if (lhost == NULL)
1984 <  {
1985 <    strlcpy(luser, user_host_or_nick, USERLEN*4 + 1);
1986 <    return 1;
1987 <  }
1988 <
1989 <  if ((hostp = strchr(user_host_or_nick, '@')) || *user_host_or_nick == '*')
1990 <  {
1991 <    /* Explicit user@host mask given */
1992 <
1993 <    if (hostp != NULL)                            /* I'm a little user@host */
1994 <    {
1995 <      *(hostp++) = '\0';                       /* short and squat */
1996 <      if (*user_host_or_nick)
1997 <        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1998 <      else
1999 <        strcpy(luser, "*");
2000 <
2001 <      if (*hostp)
2002 <        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2003 <      else
2004 <        strcpy(lhost, "*");
2005 <    }
2006 <    else
2007 <    {
2008 <      luser[0] = '*';             /* no @ found, assume its *@somehost */
2009 <      luser[1] = '\0';
2010 <      strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
2011 <    }
2012 <
2013 <    return 1;
2014 <  }
2015 <  else
2016 <  {
2017 <    /* Try to find user@host mask from nick */
2018 <    /* Okay to use source_p as the first param, because source_p == client_p */
2019 <    if ((target_p =
2020 <        find_chasing(source_p, user_host_or_nick)) == NULL)
2021 <      return 0;
2022 <
2023 <    if (IsExemptKline(target_p))
2024 <    {
2025 <      if (!IsServer(source_p))
2026 <        sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
2027 <      return 0;
2028 <    }
2029 <
2030 <    /*
2031 <     * turn the "user" bit into "*user", blow away '~'
2032 <     * if found in original user name (non-idented)
2033 <     */
2034 <    strlcpy(luser, target_p->username, USERLEN*4 + 1);
2035 <
2036 <    if (target_p->username[0] == '~')
2037 <      luser[0] = '*';
2038 <
2039 <    if (target_p->sockhost[0] == '\0' ||
2040 <        (target_p->sockhost[0] == '0' && target_p->sockhost[1] == '\0'))
2041 <      strlcpy(lhost, target_p->host, HOSTLEN*4 + 1);
2042 <    else
2043 <      strlcpy(lhost, target_p->sockhost, HOSTLEN*4 + 1);
2044 <    return 1;
2045 <  }
2046 <
2047 <  return 0;
2048 < }
2049 <
2050 < /* valid_comment()
2051 < *
2052 < * inputs       - pointer to client
2053 < *              - pointer to comment
2054 < * output       - 0 if no valid comment,
2055 < *              - 1 if valid
2056 < * side effects - truncates reason where necessary
2057 < */
2058 < int
2059 < valid_comment(struct Client *source_p, char *comment, int warn)
2060 < {
2061 <  if (strlen(comment) > REASONLEN)
2062 <    comment[REASONLEN-1] = '\0';
2063 <
2064 <  return 1;
1295 >  return true;
1296   }
1297  
1298   /* match_conf_password()
# Line 2071 | Line 1302 | valid_comment(struct Client *source_p, c
1302   * output       - 1 or 0 if match
1303   * side effects - none
1304   */
1305 < int
1305 > bool
1306   match_conf_password(const char *password, const struct MaskItem *conf)
1307   {
1308    const char *encr = NULL;
1309  
1310    if (EmptyString(password) || EmptyString(conf->passwd))
1311 <    return 0;
1311 >    return false;
1312  
1313    if (conf->flags & CONF_FLAGS_ENCRYPTED)
1314      encr = crypt(password, conf->passwd);
1315    else
1316      encr = password;
1317  
1318 <  return encr && !strcmp(encr, conf->passwd);
2088 < }
2089 <
2090 < /*
2091 < * cluster_a_line
2092 < *
2093 < * inputs       - client sending the cluster
2094 < *              - command name "KLINE" "XLINE" etc.
2095 < *              - capab -- CAP_KLN etc. from server.h
2096 < *              - cluster type -- CLUSTER_KLINE etc. from conf.h
2097 < *              - pattern and args to send along
2098 < * output       - none
2099 < * side effects - Take source_p send the pattern with args given
2100 < *                along to all servers that match capab and cluster type
2101 < */
2102 < void
2103 < cluster_a_line(struct Client *source_p, const char *command,
2104 <               int capab, int cluster_type, const char *pattern, ...)
2105 < {
2106 <  va_list args;
2107 <  char buffer[IRCD_BUFSIZE];
2108 <  const dlink_node *ptr = NULL;
2109 <
2110 <  va_start(args, pattern);
2111 <  vsnprintf(buffer, sizeof(buffer), pattern, args);
2112 <  va_end(args);
2113 <
2114 <  DLINK_FOREACH(ptr, cluster_items.head)
2115 <  {
2116 <    const struct MaskItem *conf = ptr->data;
2117 <
2118 <    if (conf->flags & cluster_type)
2119 <      sendto_match_servs(source_p, conf->name, CAP_CLUSTER|capab,
2120 <                         "%s %s %s", command, conf->name, buffer);
2121 <  }
1318 >  return encr && strcmp(encr, conf->passwd) == 0;
1319   }
1320  
1321   /*
# Line 2156 | Line 1353 | split_nuh(struct split_nuh_item *const i
1353  
1354    if (iptr->nickptr)
1355      strlcpy(iptr->nickptr, "*", iptr->nicksize);
1356 +
1357    if (iptr->userptr)
1358      strlcpy(iptr->userptr, "*", iptr->usersize);
1359 +
1360    if (iptr->hostptr)
1361      strlcpy(iptr->hostptr, "*", iptr->hostsize);
1362  
# Line 2165 | Line 1364 | split_nuh(struct split_nuh_item *const i
1364    {
1365      *p = '\0';
1366  
1367 <    if (iptr->nickptr && *iptr->nuhmask != '\0')
1367 >    if (iptr->nickptr && *iptr->nuhmask)
1368        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
1369  
1370      if ((q = strchr(++p, '@')))
1371      {
1372        *q++ = '\0';
1373  
1374 <      if (*p != '\0')
1374 >      if (*p)
1375          strlcpy(iptr->userptr, p, iptr->usersize);
1376  
1377 <      if (*q != '\0')
1377 >      if (*q)
1378          strlcpy(iptr->hostptr, q, iptr->hostsize);
1379      }
1380      else
1381      {
1382 <      if (*p != '\0')
1382 >      if (*p)
1383          strlcpy(iptr->userptr, p, iptr->usersize);
1384      }
1385    }
# Line 2192 | Line 1391 | split_nuh(struct split_nuh_item *const i
1391        /* if found a @ */
1392        *p++ = '\0';
1393  
1394 <      if (*iptr->nuhmask != '\0')
1394 >      if (*iptr->nuhmask)
1395          strlcpy(iptr->userptr, iptr->nuhmask, iptr->usersize);
1396  
1397 <      if (*p != '\0')
1397 >      if (*p)
1398          strlcpy(iptr->hostptr, p, iptr->hostsize);
1399      }
1400      else
1401      {
1402 <      /* no @ found */
1403 <      if (!iptr->nickptr || strpbrk(iptr->nuhmask, ".:"))
1402 >      /* No @ found */
1403 >      if (iptr->nickptr == NULL || strpbrk(iptr->nuhmask, ".:"))
1404          strlcpy(iptr->hostptr, iptr->nuhmask, iptr->hostsize);
1405        else
1406          strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);

Comparing ircd-hybrid/trunk/src/conf.c (property svn:keywords):
Revision 3347 by michael, Sun Apr 20 14:03:06 2014 UTC vs.
Revision 9880 by michael, Thu Jan 14 13:31:12 2021 UTC

# Line 1 | Line 1
1 < Id Revision
1 > Id

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)