ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/conf.c (file contents):
Revision 3347 by michael, Sun Apr 20 14:03:06 2014 UTC vs.
Revision 9553 by michael, Sun Jul 26 07:35:07 2020 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2020 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
# Line 27 | Line 27
27   #include "stdinc.h"
28   #include "list.h"
29   #include "ircd_defs.h"
30 + #include "parse.h"
31   #include "conf.h"
32 + #include "conf_cluster.h"
33 + #include "conf_gecos.h"
34 + #include "conf_pseudo.h"
35 + #include "conf_resv.h"
36 + #include "conf_service.h"
37 + #include "conf_shared.h"
38   #include "server.h"
32 – #include "resv.h"
39   #include "channel.h"
40   #include "client.h"
41   #include "event.h"
# Line 44 | Line 50
50   #include "log.h"
51   #include "send.h"
52   #include "memory.h"
47 – #include "mempool.h"
53   #include "res.h"
49 – #include "userhost.h"
54   #include "user.h"
55   #include "channel_mode.h"
52 – #include "parse.h"
56   #include "misc.h"
57   #include "conf_db.h"
58   #include "conf_class.h"
59   #include "motd.h"
60 + #include "ipcache.h"
61 + #include "isupport.h"
62 + #include "whowas.h"
63  
64  
65   struct config_channel_entry ConfigChannel;
66 < struct config_server_hide ConfigServerHide;
67 < struct config_file_entry ConfigFileEntry;
68 < struct logging_entry ConfigLoggingEntry = { .use_logging = 1 };
69 < struct server_info ServerInfo;
70 < struct admin_info AdminInfo;
66 > struct config_serverhide_entry ConfigServerHide;
67 > struct config_general_entry ConfigGeneral;
68 > struct config_log_entry ConfigLog = { .use_logging = 1 };
69 > struct config_serverinfo_entry ConfigServerInfo;
70 > struct config_admin_entry ConfigAdminInfo;
71 > struct conf_parser_context conf_parser_ctx;
72  
73   /* general conf items link list root, other than k lines etc. */
74 < dlink_list service_items = { NULL, NULL, 0 };
75 < dlink_list server_items  = { NULL, NULL, 0 };
69 < dlink_list cluster_items = { NULL, NULL, 0 };
70 < dlink_list oconf_items   = { NULL, NULL, 0 };
71 < dlink_list uconf_items   = { NULL, NULL, 0 };
72 < dlink_list xconf_items   = { NULL, NULL, 0 };
73 < dlink_list nresv_items   = { NULL, NULL, 0 };
74 < dlink_list cresv_items = { NULL, NULL, 0 };
74 > dlink_list connect_items;
75 > dlink_list operator_items;
76  
77   extern unsigned int lineno;
78   extern char linebuf[];
79   extern char conffilebuf[IRCD_BUFSIZE];
80   extern int yyparse(); /* defined in y.tab.c */
81  
81 – struct conf_parser_context conf_parser_ctx = { 0, 0, NULL };
82 –
83 – /* internally defined functions */
84 – static void read_conf(FILE *);
85 – static void clear_out_old_conf(void);
86 – static void expire_tklines(dlink_list *);
87 – static void garbage_collect_ip_entries(void);
88 – static int hash_ip(struct irc_ssaddr *);
89 – static int verify_access(struct Client *);
90 – static int attach_iline(struct Client *, struct MaskItem *);
91 – static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
92 – static dlink_list *map_to_list(enum maskitem_type);
93 – static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
94 –
95 –
96 – /* usually, with hash tables, you use a prime number...
97 – * but in this case I am dealing with ip addresses,
98 – * not ascii strings.
99 – */
100 – #define IP_HASH_SIZE 0x1000
101 –
102 – struct ip_entry
103 – {
104 –  struct irc_ssaddr ip;
105 –  unsigned int count;
106 –  time_t last_attempt;
107 –  struct ip_entry *next;
108 – };
109 –
110 – static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
111 – static mp_pool_t *ip_entry_pool = NULL;
112 – static int ip_entries_count = 0;
113 –
82  
83   /* conf_dns_callback()
84   *
# Line 123 | Line 91 | static int ip_entries_count = 0;
91   * if successful save hp in the conf item it was called with
92   */
93   static void
94 < conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
94 > conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name, size_t namelength)
95   {
96 <  struct MaskItem *conf = vptr;
96 >  struct MaskItem *const conf = vptr;
97  
98 <  conf->dns_pending = 0;
98 >  conf->dns_pending = false;
99  
100    if (addr)
101 <    memcpy(&conf->addr, addr, sizeof(conf->addr));
101 >    *conf->addr = *addr;
102    else
103 <    conf->dns_failed = 1;
103 >    conf->dns_failed = true;
104   }
105  
106 < /* conf_dns_lookup()
106 > /* conf_resolve_host()
107   *
108 < * do a nameserver lookup of the conf host
109 < * if the conf entry is currently doing a ns lookup do nothing, otherwise
142 < * allocate a dns_query and start ns lookup.
108 > * start DNS lookups of all hostnames in the conf
109 > * line and convert an IP addresses in a.b.c.d number for to IP#s.
110   */
111 < static void
111 > void
112   conf_dns_lookup(struct MaskItem *conf)
113   {
114 <  if (!conf->dns_pending)
114 >  struct addrinfo hints, *res;
115 >
116 >  /*
117 >   * Do name lookup now on hostnames given and store the
118 >   * ip numbers in conf structure.
119 >   */
120 >  memset(&hints, 0, sizeof(hints));
121 >
122 >  hints.ai_family = AF_UNSPEC;
123 >  hints.ai_socktype = SOCK_STREAM;
124 >
125 >  /* Get us ready for a bind() and don't bother doing dns lookup */
126 >  hints.ai_flags = AI_PASSIVE | AI_NUMERICHOST;
127 >
128 >  if (getaddrinfo(conf->host, NULL, &hints, &res))
129 >  {
130 >    /*
131 >     * By this point conf->host possibly is not a numerical network address. Do a nameserver
132 >     * lookup of the conf host. If the conf entry is currently doing a ns lookup do nothing.
133 >     */
134 >    if (conf->dns_pending == true)
135 >      return;
136 >
137 >    conf->dns_pending = true;
138 >
139 >    if (conf->aftype == AF_INET)
140 >      gethost_byname_type(conf_dns_callback, conf, conf->host, T_A);
141 >    else
142 >      gethost_byname_type(conf_dns_callback, conf, conf->host, T_AAAA);
143 >    return;
144 >  }
145 >
146 >  assert(res);
147 >
148 >  memcpy(conf->addr, res->ai_addr, res->ai_addrlen);
149 >  conf->addr->ss_len = res->ai_addrlen;
150 >
151 >  freeaddrinfo(res);
152 > }
153 >
154 > /* map_to_list()
155 > *
156 > * inputs       - ConfType conf
157 > * output       - pointer to dlink_list to use
158 > * side effects - none
159 > */
160 > static dlink_list *
161 > map_to_list(enum maskitem_type type)
162 > {
163 >  switch (type)
164    {
165 <    conf->dns_pending = 1;
166 <    gethost_byname(conf_dns_callback, conf, conf->host);
165 >    case CONF_OPER:
166 >      return &operator_items;
167 >      break;
168 >    case CONF_SERVER:
169 >      return &connect_items;
170 >      break;
171 >    default:
172 >      return NULL;
173    }
174   }
175  
176   struct MaskItem *
177   conf_make(enum maskitem_type type)
178   {
179 <  struct MaskItem *conf = MyMalloc(sizeof(*conf));
179 >  struct MaskItem *const conf = xcalloc(sizeof(*conf));
180    dlink_list *list = NULL;
181  
182    conf->type   = type;
183 <  conf->active = 1;
183 >  conf->active = true;
184    conf->aftype = AF_INET;
185  
186    if ((list = map_to_list(type)))
# Line 169 | Line 191 | conf_make(enum maskitem_type type)
191   void
192   conf_free(struct MaskItem *conf)
193   {
194 <  dlink_node *ptr = NULL, *ptr_next = NULL;
194 >  dlink_node *node = NULL, *node_next = NULL;
195    dlink_list *list = NULL;
196  
197 <  if (conf->node.next)
198 <    if ((list = map_to_list(conf->type)))
177 <      dlinkDelete(&conf->node, list);
197 >  if ((list = map_to_list(conf->type)))
198 >    dlinkFindDelete(list, conf);
199  
200 <  MyFree(conf->name);
200 >  xfree(conf->name);
201  
202 <  if (conf->dns_pending)
202 >  if (conf->dns_pending == true)
203      delete_resolver_queries(conf);
204    if (conf->passwd)
205      memset(conf->passwd, 0, strlen(conf->passwd));
# Line 187 | Line 208 | conf_free(struct MaskItem *conf)
208  
209    conf->class = NULL;
210  
211 <  MyFree(conf->passwd);
212 <  MyFree(conf->spasswd);
213 <  MyFree(conf->reason);
214 <  MyFree(conf->certfp);
215 <  MyFree(conf->user);
216 <  MyFree(conf->host);
217 < #ifdef HAVE_LIBCRYPTO
218 <  MyFree(conf->cipher_list);
211 >  xfree(conf->passwd);
212 >  xfree(conf->spasswd);
213 >  xfree(conf->reason);
214 >  xfree(conf->certfp);
215 >  xfree(conf->whois);
216 >  xfree(conf->user);
217 >  xfree(conf->host);
218 >  xfree(conf->addr);
219 >  xfree(conf->bind);
220 >  xfree(conf->cipher_list);
221  
222 <  if (conf->rsa_public_key)
200 <    RSA_free(conf->rsa_public_key);
201 < #endif
202 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->hub_list.head)
222 >  DLINK_FOREACH_SAFE(node, node_next, conf->hub_list.head)
223    {
224 <    MyFree(ptr->data);
225 <    dlinkDelete(ptr, &conf->hub_list);
226 <    free_dlink_node(ptr);
224 >    xfree(node->data);
225 >    dlinkDelete(node, &conf->hub_list);
226 >    free_dlink_node(node);
227    }
228  
229 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->leaf_list.head)
229 >  DLINK_FOREACH_SAFE(node, node_next, conf->leaf_list.head)
230 >  {
231 >    xfree(node->data);
232 >    dlinkDelete(node, &conf->leaf_list);
233 >    free_dlink_node(node);
234 >  }
235 >
236 >  xfree(conf);
237 > }
238 >
239 > /* attach_iline()
240 > *
241 > * inputs       - client pointer
242 > *              - conf pointer
243 > * output       -
244 > * side effects - do actual attach
245 > */
246 > static int
247 > attach_iline(struct Client *client, struct MaskItem *conf)
248 > {
249 >  const struct ClassItem *const class = conf->class;
250 >  bool a_limit_reached = false;
251 >
252 >  struct ip_entry *ipcache = ipcache_record_find_or_add(&client->ip);
253 >  ++ipcache->count_local;
254 >  AddFlag(client, FLAGS_IPHASH);
255 >
256 >  if (class->max_total && class->ref_count >= class->max_total)
257 >    a_limit_reached = true;
258 >  else if (class->max_perip_local && ipcache->count_local > class->max_perip_local)
259 >    a_limit_reached = true;
260 >  else if (class->max_perip_global &&
261 >           (ipcache->count_local + ipcache->count_remote) > class->max_perip_global)
262 >    a_limit_reached = true;
263 >
264 >  if (a_limit_reached == true)
265 >  {
266 >    if (!IsConfExemptLimits(conf))
267 >      return TOO_MANY;   /* Already at maximum allowed */
268 >
269 >    sendto_one_notice(client, &me, ":*** Your connection class is full, "
270 >                      "but you have exceed_limit = yes;");
271 >  }
272 >
273 >  return conf_attach(client, conf);
274 > }
275 >
276 > /* verify_access()
277 > *
278 > * inputs       - pointer to client to verify
279 > * output       - 0 if success -'ve if not
280 > * side effect  - find the first (best) I line to attach.
281 > */
282 > static int
283 > verify_access(struct Client *client)
284 > {
285 >  struct MaskItem *conf;
286 >
287 >  if (HasFlag(client, FLAGS_GOTID))
288 >    conf = find_address_conf(client->host, client->username, &client->ip,
289 >                             client->connection->password);
290 >  else
291    {
292 <    MyFree(ptr->data);
293 <    dlinkDelete(ptr, &conf->leaf_list);
294 <    free_dlink_node(ptr);
292 >    char non_ident[USERLEN + 1] = "~";
293 >
294 >    strlcpy(non_ident + 1, client->username, sizeof(non_ident) - 1);
295 >    conf = find_address_conf(client->host, non_ident, &client->ip,
296 >                             client->connection->password);
297    }
298  
299 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->exempt_list.head)
299 >  if (conf == NULL)
300 >    return NOT_AUTHORIZED;
301 >
302 >  assert(IsConfClient(conf) || IsConfKill(conf));
303 >
304 >  if (IsConfKill(conf))
305    {
306 <    struct exempt *exptr = ptr->data;
306 >    sendto_one_notice(client, &me, ":*** Banned: %s", conf->reason);
307 >    return BANNED_CLIENT;
308 >  }
309  
310 <    dlinkDelete(ptr, &conf->exempt_list);
311 <    MyFree(exptr->name);
312 <    MyFree(exptr->user);
313 <    MyFree(exptr->host);
314 <    MyFree(exptr);
310 >  if (IsConfRedir(conf))
311 >  {
312 >    sendto_one_numeric(client, &me, RPL_REDIR,
313 >                       conf->name ? conf->name : "",
314 >                       conf->port);
315 >    return NOT_AUTHORIZED;
316    }
317  
318 <  MyFree(conf);
318 >  /* Preserve x->host in x->realhost before it gets overwritten. */
319 >  strlcpy(client->realhost, client->host, sizeof(client->realhost));
320 >
321 >  if (IsConfDoSpoofIp(conf))
322 >    strlcpy(client->host, conf->name, sizeof(client->host));
323 >
324 >  return attach_iline(client, conf);
325   }
326  
327   /* check_client()
# Line 240 | Line 337 | conf_free(struct MaskItem *conf)
337   *                Look for conf lines which have the same
338   *                status as the flags passed.
339   */
340 < int
341 < check_client(struct Client *source_p)
340 > bool
341 > conf_check_client(struct Client *client)
342   {
343    int i;
344  
345 <  if ((i = verify_access(source_p)))
345 >  if ((i = verify_access(client)))
346      ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
347 <         source_p->name, source_p->sockhost);
347 >         client->name, client->sockhost);
348  
349    switch (i)
350    {
351      case TOO_MANY:
352        sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
353                             "Too many on IP for %s (%s).",
354 <                           get_client_name(source_p, SHOW_IP),
355 <                           source_p->sockhost);
354 >                           client_get_name(client, SHOW_IP),
355 >                           client->sockhost);
356        ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
357 <           get_client_name(source_p, SHOW_IP));
357 >           client_get_name(client, SHOW_IP));
358        ++ServerStats.is_ref;
359 <      exit_client(source_p, "No more connections allowed on that IP");
359 >      exit_client(client, "No more connections allowed on that IP");
360        break;
361  
362      case I_LINE_FULL:
363        sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
364 <                           "auth{} block is full for %s (%s).",
365 <                           get_client_name(source_p, SHOW_IP),
366 <                           source_p->sockhost);
364 >                           "auth {} block is full for %s (%s).",
365 >                           client_get_name(client, SHOW_IP),
366 >                           client->sockhost);
367        ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
368 <           get_client_name(source_p, SHOW_IP));
368 >           client_get_name(client, SHOW_IP));
369        ++ServerStats.is_ref;
370 <      exit_client(source_p, "No more connections allowed in your connection class");
370 >      exit_client(client, "No more connections allowed in your connection class");
371        break;
372  
373      case NOT_AUTHORIZED:
277 –      ++ServerStats.is_ref;
374        /* jdc - lists server name & port connections are on */
375        /*       a purely cosmetical change */
376        sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
377 <                           "Unauthorized client connection from %s [%s] on [%s/%u].",
378 <                           get_client_name(source_p, SHOW_IP),
379 <                           source_p->sockhost,
380 <                           source_p->localClient->listener->name,
381 <                           source_p->localClient->listener->port);
382 <      ilog(LOG_TYPE_IRCD,
383 <           "Unauthorized client connection from %s on [%s/%u].",
384 <           get_client_name(source_p, SHOW_IP),
289 <           source_p->localClient->listener->name,
290 <           source_p->localClient->listener->port);
377 >                           "Unauthorized client connection from %s on [%s/%u].",
378 >                           client_get_name(client, SHOW_IP),
379 >                           client->connection->listener->name,
380 >                           client->connection->listener->port);
381 >      ilog(LOG_TYPE_IRCD, "Unauthorized client connection from %s on [%s/%u].",
382 >           client_get_name(client, SHOW_IP),
383 >           client->connection->listener->name,
384 >           client->connection->listener->port);
385  
386 <      exit_client(source_p, "You are not authorized to use this server");
386 >      ++ServerStats.is_ref;
387 >      exit_client(client, "You are not authorized to use this server");
388        break;
389  
390 <   case BANNED_CLIENT:
391 <     exit_client(source_p, "Banned");
392 <     ++ServerStats.is_ref;
393 <     break;
299 <
300 <   case 0:
301 <   default:
302 <     break;
303 <  }
304 <
305 <  return (i < 0 ? 0 : 1);
306 < }
307 <
308 < /* verify_access()
309 < *
310 < * inputs       - pointer to client to verify
311 < * output       - 0 if success -'ve if not
312 < * side effect  - find the first (best) I line to attach.
313 < */
314 < static int
315 < verify_access(struct Client *client_p)
316 < {
317 <  struct MaskItem *conf = NULL;
318 <  char non_ident[USERLEN + 1] = "~";
319 <
320 <  if (IsGotId(client_p))
321 <  {
322 <    conf = find_address_conf(client_p->host, client_p->username,
323 <                             &client_p->localClient->ip,
324 <                             client_p->localClient->aftype,
325 <                             client_p->localClient->passwd);
326 <  }
327 <  else
328 <  {
329 <    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
330 <    conf = find_address_conf(client_p->host,non_ident,
331 <                             &client_p->localClient->ip,
332 <                             client_p->localClient->aftype,
333 <                             client_p->localClient->passwd);
334 <  }
335 <
336 <  if (conf)
337 <  {
338 <    if (IsConfClient(conf))
339 <    {
340 <      if (IsConfRedir(conf))
341 <      {
342 <        sendto_one_numeric(client_p, &me, RPL_REDIR,
343 <                           conf->name ? conf->name : "",
344 <                           conf->port);
345 <        return NOT_AUTHORIZED;
346 <      }
347 <
348 <      if (IsConfDoIdentd(conf))
349 <        SetNeedId(client_p);
350 <
351 <      /* Thanks for spoof idea amm */
352 <      if (IsConfDoSpoofIp(conf))
353 <      {
354 <        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
355 <          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
356 <                               "%s spoofing: %s as %s",
357 <                               client_p->name, client_p->host, conf->name);
358 <        strlcpy(client_p->host, conf->name, sizeof(client_p->host));
359 <        AddFlag(client_p, FLAGS_IP_SPOOFING | FLAGS_AUTH_SPOOF);
360 <      }
361 <
362 <      return attach_iline(client_p, conf);
363 <    }
364 <    else if (IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
365 <    {
366 <      if (IsConfGline(conf))
367 <        sendto_one_notice(client_p, &me, ":*** G-lined");
368 <      sendto_one_notice(client_p, &me, ":*** Banned: %s", conf->reason);
369 <      return BANNED_CLIENT;
370 <    }
371 <  }
372 <
373 <  return NOT_AUTHORIZED;
374 < }
375 <
376 < /* attach_iline()
377 < *
378 < * inputs       - client pointer
379 < *              - conf pointer
380 < * output       -
381 < * side effects - do actual attach
382 < */
383 < static int
384 < attach_iline(struct Client *client_p, struct MaskItem *conf)
385 < {
386 <  struct ClassItem *class = NULL;
387 <  struct ip_entry *ip_found;
388 <  int a_limit_reached = 0;
389 <  unsigned int local = 0, global = 0, ident = 0;
390 <
391 <  assert(conf->class);
392 <
393 <  ip_found = find_or_add_ip(&client_p->localClient->ip);
394 <  ip_found->count++;
395 <  SetIpHash(client_p);
396 <
397 <  class = conf->class;
398 <
399 <  count_user_host(client_p->username, client_p->host,
400 <                  &global, &local, &ident);
401 <
402 <  /* XXX blah. go down checking the various silly limits
403 <   * setting a_limit_reached if any limit is reached.
404 <   * - Dianora
405 <   */
406 <  if (class->max_total != 0 && class->ref_count >= class->max_total)
407 <    a_limit_reached = 1;
408 <  else if (class->max_perip != 0 && ip_found->count > class->max_perip)
409 <    a_limit_reached = 1;
410 <  else if (class->max_local != 0 && local >= class->max_local)
411 <    a_limit_reached = 1;
412 <  else if (class->max_global != 0 && global >= class->max_global)
413 <    a_limit_reached = 1;
414 <  else if (class->max_ident != 0 && ident >= class->max_ident &&
415 <           client_p->username[0] != '~')
416 <    a_limit_reached = 1;
417 <
418 <  if (a_limit_reached)
419 <  {
420 <    if (!IsConfExemptLimits(conf))
421 <      return TOO_MANY;   /* Already at maximum allowed */
422 <
423 <    sendto_one_notice(client_p, &me, ":*** Your connection class is full, "
424 <                      "but you have exceed_limit = yes;");
425 <  }
426 <
427 <  return attach_conf(client_p, conf);
428 < }
429 <
430 < /* init_ip_hash_table()
431 < *
432 < * inputs               - NONE
433 < * output               - NONE
434 < * side effects         - allocate memory for ip_entry(s)
435 < *                      - clear the ip hash table
436 < */
437 < void
438 < init_ip_hash_table(void)
439 < {
440 <  ip_entry_pool = mp_pool_new(sizeof(struct ip_entry), MP_CHUNK_SIZE_IP_ENTRY);
441 <  memset(ip_hash_table, 0, sizeof(ip_hash_table));
442 < }
443 <
444 < /* find_or_add_ip()
445 < *
446 < * inputs       - pointer to struct irc_ssaddr
447 < * output       - pointer to a struct ip_entry
448 < * side effects -
449 < *
450 < * If the ip # was not found, a new struct ip_entry is created, and the ip
451 < * count set to 0.
452 < */
453 < static struct ip_entry *
454 < find_or_add_ip(struct irc_ssaddr *ip_in)
455 < {
456 <  struct ip_entry *ptr, *newptr;
457 <  int hash_index = hash_ip(ip_in), res;
458 <  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
459 < #ifdef IPV6
460 <  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
461 < #endif
462 <
463 <  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
464 <  {
465 < #ifdef IPV6
466 <    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
467 <      continue;
468 <    if (ip_in->ss.ss_family == AF_INET6)
469 <    {
470 <      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
471 <      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
472 <    }
473 <    else
474 < #endif
475 <    {
476 <      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
477 <      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
478 <    }
479 <    if (res == 0)
480 <    {
481 <      /* Found entry already in hash, return it. */
482 <      return ptr;
483 <    }
484 <  }
485 <
486 <  if (ip_entries_count >= 2 * hard_fdlimit)
487 <    garbage_collect_ip_entries();
488 <
489 <  newptr = mp_pool_get(ip_entry_pool);
490 <  memset(newptr, 0, sizeof(*newptr));
491 <  ip_entries_count++;
492 <  memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
493 <
494 <  newptr->next = ip_hash_table[hash_index];
495 <  ip_hash_table[hash_index] = newptr;
496 <
497 <  return newptr;
498 < }
499 <
500 < /* remove_one_ip()
501 < *
502 < * inputs        - unsigned long IP address value
503 < * output        - NONE
504 < * side effects  - The ip address given, is looked up in ip hash table
505 < *                 and number of ip#'s for that ip decremented.
506 < *                 If ip # count reaches 0 and has expired,
507 < *                 the struct ip_entry is returned to the ip_entry_heap
508 < */
509 < void
510 < remove_one_ip(struct irc_ssaddr *ip_in)
511 < {
512 <  struct ip_entry *ptr;
513 <  struct ip_entry *last_ptr = NULL;
514 <  int hash_index = hash_ip(ip_in), res;
515 <  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
516 < #ifdef IPV6
517 <  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
518 < #endif
519 <
520 <  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
521 <  {
522 < #ifdef IPV6
523 <    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
524 <      continue;
525 <    if (ip_in->ss.ss_family == AF_INET6)
526 <    {
527 <      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
528 <      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
529 <    }
530 <    else
531 < #endif
532 <    {
533 <      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
534 <      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
535 <    }
536 <    if (res)
537 <      continue;
538 <    if (ptr->count > 0)
539 <      ptr->count--;
540 <    if (ptr->count == 0 &&
541 <        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
542 <    {
543 <      if (last_ptr != NULL)
544 <        last_ptr->next = ptr->next;
545 <      else
546 <        ip_hash_table[hash_index] = ptr->next;
547 <
548 <      mp_pool_release(ptr);
549 <      ip_entries_count--;
550 <      return;
551 <    }
552 <    last_ptr = ptr;
553 <  }
554 < }
555 <
556 < /* hash_ip()
557 < *
558 < * input        - pointer to an irc_inaddr
559 < * output       - integer value used as index into hash table
560 < * side effects - hopefully, none
561 < */
562 < static int
563 < hash_ip(struct irc_ssaddr *addr)
564 < {
565 <  if (addr->ss.ss_family == AF_INET)
566 <  {
567 <    struct sockaddr_in *v4 = (struct sockaddr_in *)addr;
568 <    int hash;
569 <    uint32_t ip;
570 <
571 <    ip   = ntohl(v4->sin_addr.s_addr);
572 <    hash = ((ip >> 12) + ip) & (IP_HASH_SIZE-1);
573 <    return hash;
574 <  }
575 < #ifdef IPV6
576 <  else
577 <  {
578 <    int hash;
579 <    struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)addr;
580 <    uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
581 <
582 <    hash  = ip[0] ^ ip[3];
583 <    hash ^= hash >> 16;
584 <    hash ^= hash >> 8;
585 <    hash  = hash & (IP_HASH_SIZE - 1);
586 <    return hash;
587 <  }
588 < #else
589 <  return 0;
590 < #endif
591 < }
592 <
593 < /* count_ip_hash()
594 < *
595 < * inputs        - pointer to counter of number of ips hashed
596 < *               - pointer to memory used for ip hash
597 < * output        - returned via pointers input
598 < * side effects  - NONE
599 < *
600 < * number of hashed ip #'s is counted up, plus the amount of memory
601 < * used in the hash.
602 < */
603 < void
604 < count_ip_hash(unsigned int *number_ips_stored, uint64_t *mem_ips_stored)
605 < {
606 <  struct ip_entry *ptr;
607 <  int i;
608 <
609 <  *number_ips_stored = 0;
610 <  *mem_ips_stored    = 0;
390 >    case BANNED_CLIENT:
391 >      ++ServerStats.is_ref;
392 >      exit_client(client, "Banned");
393 >      break;
394  
395 <  for (i = 0; i < IP_HASH_SIZE; i++)
396 <  {
397 <    for (ptr = ip_hash_table[i]; ptr; ptr = ptr->next)
615 <    {
616 <      *number_ips_stored += 1;
617 <      *mem_ips_stored += sizeof(struct ip_entry);
618 <    }
395 >    case 0:
396 >    default:
397 >      break;
398    }
620 – }
621 –
622 – /* garbage_collect_ip_entries()
623 – *
624 – * input        - NONE
625 – * output       - NONE
626 – * side effects - free up all ip entries with no connections
627 – */
628 – static void
629 – garbage_collect_ip_entries(void)
630 – {
631 –  struct ip_entry *ptr;
632 –  struct ip_entry *last_ptr;
633 –  struct ip_entry *next_ptr;
634 –  int i;
635 –
636 –  for (i = 0; i < IP_HASH_SIZE; i++)
637 –  {
638 –    last_ptr = NULL;
639 –
640 –    for (ptr = ip_hash_table[i]; ptr; ptr = next_ptr)
641 –    {
642 –      next_ptr = ptr->next;
399  
400 <      if (ptr->count == 0 &&
401 <          (CurrentTime - ptr->last_attempt) >= ConfigFileEntry.throttle_time)
402 <      {
647 <        if (last_ptr != NULL)
648 <          last_ptr->next = ptr->next;
649 <        else
650 <          ip_hash_table[i] = ptr->next;
651 <        mp_pool_release(ptr);
652 <        ip_entries_count--;
653 <      }
654 <      else
655 <        last_ptr = ptr;
656 <    }
657 <  }
400 >  if (i < 0)
401 >    return false;
402 >  return true;
403   }
404  
405 < /* detach_conf()
406 < *
407 < * inputs       - pointer to client to detach
408 < *              - type of conf to detach
664 < * output       - 0 for success, -1 for failure
665 < * side effects - Disassociate configuration from the client.
666 < *                Also removes a class from the list if marked for deleting.
405 > /*! \brief Disassociate configuration from the client. Also removes a class
406 > *         from the list if marked for deleting.
407 > * \param client Client to operate on
408 > * \param type     Type of conf to detach
409   */
410   void
411 < detach_conf(struct Client *client_p, enum maskitem_type type)
411 > conf_detach(struct Client *client, enum maskitem_type type)
412   {
413 <  dlink_node *ptr = NULL, *ptr_next = NULL;
413 >  dlink_node *node, *node_next;
414  
415 <  DLINK_FOREACH_SAFE(ptr, ptr_next, client_p->localClient->confs.head)
415 >  DLINK_FOREACH_SAFE(node, node_next, client->connection->confs.head)
416    {
417 <    struct MaskItem *conf = ptr->data;
417 >    struct MaskItem *conf = node->data;
418  
419      assert(conf->type & (CONF_CLIENT | CONF_OPER | CONF_SERVER));
420      assert(conf->ref_count > 0);
# Line 681 | Line 423 | detach_conf(struct Client *client_p, enu
423      if (!(conf->type & type))
424        continue;
425  
426 <    dlinkDelete(ptr, &client_p->localClient->confs);
427 <    free_dlink_node(ptr);
426 >    dlinkDelete(node, &client->connection->confs);
427 >    free_dlink_node(node);
428  
429      if (conf->type == CONF_CLIENT)
430 <      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
430 >      class_ip_limit_remove(conf->class, &client->ip);
431  
432 <    if (--conf->class->ref_count == 0 && conf->class->active == 0)
432 >    if (--conf->class->ref_count == 0 && conf->class->active == false)
433      {
434        class_free(conf->class);
435        conf->class = NULL;
436      }
437  
438 <    if (--conf->ref_count == 0 && conf->active == 0)
438 >    if (--conf->ref_count == 0 && conf->active == false)
439        conf_free(conf);
440    }
441   }
442  
443 < /* attach_conf()
444 < *
445 < * inputs       - client pointer
446 < *              - conf pointer
447 < * output       -
706 < * side effects - Associate a specific configuration entry to a *local*
707 < *                client (this is the one which used in accepting the
708 < *                connection). Note, that this automatically changes the
709 < *                attachment if there was an old one...
443 > /*! \brief Associate a specific configuration entry to a *local* client (this
444 > *         is the one which used in accepting the connection). Note, that this
445 > *         automatically changes the attachment if there was an old one.
446 > * \param client Client to attach the conf to
447 > * \param conf Configuration record to attach
448   */
449   int
450 < attach_conf(struct Client *client_p, struct MaskItem *conf)
450 > conf_attach(struct Client *client, struct MaskItem *conf)
451   {
452 <  if (dlinkFind(&client_p->localClient->confs, conf))
452 >  if (dlinkFind(&client->connection->confs, conf))
453      return 1;
454  
455    if (conf->type == CONF_CLIENT)
456 <    if (cidr_limit_reached(IsConfExemptLimits(conf),
719 <                           &client_p->localClient->ip, conf->class))
456 >    if (class_ip_limit_add(conf->class, &client->ip, IsConfExemptLimits(conf)) == true)
457        return TOO_MANY;    /* Already at maximum allowed */
458  
459    conf->class->ref_count++;
460    conf->ref_count++;
461  
462 <  dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
726 <
727 <  return 0;
728 < }
729 <
730 < /* attach_connect_block()
731 < *
732 < * inputs       - pointer to server to attach
733 < *              - name of server
734 < *              - hostname of server
735 < * output       - true (1) if both are found, otherwise return false (0)
736 < * side effects - find connect block and attach them to connecting client
737 < */
738 < int
739 < attach_connect_block(struct Client *client_p, const char *name,
740 <                     const char *host)
741 < {
742 <  dlink_node *ptr;
743 <  struct MaskItem *conf = NULL;
744 <
745 <  assert(client_p != NULL);
746 <  assert(host != NULL);
747 <
748 <  if (client_p == NULL || host == NULL)
749 <    return 0;
750 <
751 <  DLINK_FOREACH(ptr, server_items.head)
752 <  {
753 <    conf = ptr->data;
754 <
755 <    if (match(conf->name, name) || match(conf->host, host))
756 <      continue;
757 <
758 <    attach_conf(client_p, conf);
759 <    return -1;
760 <  }
462 >  dlinkAdd(conf, make_dlink_node(), &client->connection->confs);
463  
464    return 0;
465   }
# Line 774 | Line 476 | attach_connect_block(struct Client *clie
476   struct MaskItem *
477   find_conf_name(dlink_list *list, const char *name, enum maskitem_type type)
478   {
479 <  dlink_node *ptr;
778 <  struct MaskItem* conf;
479 >  dlink_node *node = NULL;
480  
481 <  DLINK_FOREACH(ptr, list->head)
481 >  DLINK_FOREACH(node, list->head)
482    {
483 <    conf = ptr->data;
483 >    struct MaskItem *conf = node->data;
484  
485      if (conf->type == type)
486      {
487 <      if (conf->name && (irccmp(conf->name, name) == 0 ||
488 <                         !match(conf->name, name)))
788 <      return conf;
487 >      if (conf->name && !irccmp(conf->name, name))
488 >        return conf;
489      }
490    }
491  
492    return NULL;
493   }
494  
495 < /* map_to_list()
496 < *
497 < * inputs       - ConfType conf
798 < * output       - pointer to dlink_list to use
799 < * side effects - none
800 < */
801 < static dlink_list *
802 < map_to_list(enum maskitem_type type)
803 < {
804 <  switch(type)
805 <  {
806 <  case CONF_XLINE:
807 <    return(&xconf_items);
808 <    break;
809 <  case CONF_ULINE:
810 <    return(&uconf_items);
811 <    break;
812 <  case CONF_NRESV:
813 <    return(&nresv_items);
814 <    break;
815 <  case CONF_CRESV:
816 <    return(&cresv_items);
817 <  case CONF_OPER:
818 <    return(&oconf_items);
819 <    break;
820 <  case CONF_SERVER:
821 <    return(&server_items);
822 <    break;
823 <  case CONF_SERVICE:
824 <    return(&service_items);
825 <    break;
826 <  case CONF_CLUSTER:
827 <    return(&cluster_items);
828 <    break;
829 <  default:
830 <    return NULL;
831 <  }
832 < }
833 <
834 < /* find_matching_name_conf()
835 < *
836 < * inputs       - type of link list to look in
837 < *              - pointer to name string to find
838 < *              - pointer to user
839 < *              - pointer to host
840 < *              - optional flags to match on as well
841 < * output       - NULL or pointer to found struct MaskItem
842 < * side effects - looks for a match on name field
495 > /*! \brief Find a connect {} conf that has a name that matches \a name.
496 > * \param name Name to match
497 > * \param compare Pointer to function to be used for string matching
498   */
499   struct MaskItem *
500 < find_matching_name_conf(enum maskitem_type type, const char *name, const char *user,
846 <                        const char *host, unsigned int flags)
500 > connect_find(const char *name, int (*compare)(const char *, const char *))
501   {
502 <  dlink_node *ptr=NULL;
849 <  struct MaskItem *conf=NULL;
850 <  dlink_list *list_p = map_to_list(type);
502 >  dlink_node *node;
503  
504 <  switch (type)
504 >  DLINK_FOREACH(node, connect_items.head)
505    {
506 <  case CONF_SERVICE:
855 <    DLINK_FOREACH(ptr, list_p->head)
856 <    {
857 <      conf = ptr->data;
506 >    struct MaskItem *conf = node->data;
507  
508 <      if (EmptyString(conf->name))
509 <        continue;
861 <      if ((name != NULL) && !irccmp(name, conf->name))
862 <        return conf;
863 <    }
864 <    break;
865 <
866 <  case CONF_XLINE:
867 <  case CONF_ULINE:
868 <  case CONF_NRESV:
869 <  case CONF_CRESV:
870 <    DLINK_FOREACH(ptr, list_p->head)
871 <    {
872 <      conf = ptr->data;
873 <
874 <      if (EmptyString(conf->name))
875 <        continue;
876 <      if ((name != NULL) && !match(conf->name, name))
877 <      {
878 <        if ((user == NULL && (host == NULL)))
879 <          return conf;
880 <        if ((conf->flags & flags) != flags)
881 <          continue;
882 <        if (EmptyString(conf->user) || EmptyString(conf->host))
883 <          return conf;
884 <        if (!match(conf->user, user) && !match(conf->host, host))
885 <          return conf;
886 <      }
887 <    }
888 <      break;
889 <
890 <  case CONF_SERVER:
891 <    DLINK_FOREACH(ptr, list_p->head)
892 <    {
893 <      conf = ptr->data;
894 <
895 <      if ((name != NULL) && !match(name, conf->name))
896 <        return conf;
897 <      else if ((host != NULL) && !match(host, conf->host))
898 <        return conf;
899 <    }
900 <    break;
901 <
902 <  default:
903 <    break;
508 >    if (compare(name, conf->name) == 0)
509 >      return conf;
510    }
511 +
512    return NULL;
513   }
514  
# Line 915 | Line 522 | find_matching_name_conf(enum maskitem_ty
522   * side effects - looks for an exact match on name field
523   */
524   struct MaskItem *
525 < find_exact_name_conf(enum maskitem_type type, const struct Client *who, const char *name,
919 <                     const char *user, const char *host)
525 > operator_find(const struct Client *who, const char *name)
526   {
527 <  dlink_node *ptr = NULL;
922 <  struct MaskItem *conf;
923 <  dlink_list *list_p = map_to_list(type);
527 >  dlink_node *node;
528  
529 <  switch(type)
529 >  DLINK_FOREACH(node, operator_items.head)
530    {
531 <  case CONF_XLINE:
928 <  case CONF_ULINE:
929 <  case CONF_NRESV:
930 <  case CONF_CRESV:
931 <
932 <    DLINK_FOREACH(ptr, list_p->head)
933 <    {
934 <      conf = ptr->data;
935 <
936 <      if (EmptyString(conf->name))
937 <        continue;
938 <
939 <      if (irccmp(conf->name, name) == 0)
940 <      {
941 <        if ((user == NULL && (host == NULL)))
942 <          return conf;
943 <        if (EmptyString(conf->user) || EmptyString(conf->host))
944 <          return conf;
945 <        if (!match(conf->user, user) && !match(conf->host, host))
946 <          return conf;
947 <      }
948 <    }
949 <    break;
531 >    struct MaskItem *conf = node->data;
532  
533 <  case CONF_OPER:
952 <    DLINK_FOREACH(ptr, list_p->head)
533 >    if (irccmp(conf->name, name) == 0)
534      {
535 <      conf = ptr->data;
536 <
956 <      if (EmptyString(conf->name))
957 <        continue;
535 >      if (who == NULL)
536 >        return conf;
537  
538 <      if (!irccmp(conf->name, name))
538 >      if (match(conf->user, who->username) == 0)
539        {
540 <        if (!who)
962 <          return conf;
963 <        if (EmptyString(conf->user) || EmptyString(conf->host))
964 <          return NULL;
965 <        if (!match(conf->user, who->username))
540 >        switch (conf->htype)
541          {
542 <          switch (conf->htype)
543 <          {
544 <            case HM_HOST:
545 <              if (!match(conf->host, who->host) || !match(conf->host, who->sockhost))
546 <                if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
542 >          case HM_HOST:
543 >            if (match(conf->host, who->host) == 0 || match(conf->host, who->sockhost) == 0)
544 >              if (conf->class->max_total == 0 || conf->class->ref_count < conf->class->max_total)
545 >                return conf;
546 >            break;
547 >          case HM_IPV4:
548 >            if (who->ip.ss.ss_family == AF_INET)
549 >              if (match_ipv4(&who->ip, conf->addr, conf->bits))
550 >                if (conf->class->max_total == 0 || conf->class->ref_count < conf->class->max_total)
551 >                  return conf;
552 >            break;
553 >          case HM_IPV6:
554 >            if (who->ip.ss.ss_family == AF_INET6)
555 >              if (match_ipv6(&who->ip, conf->addr, conf->bits))
556 >                if (conf->class->max_total == 0 || conf->class->ref_count < conf->class->max_total)
557                    return conf;
558 <              break;
559 <            case HM_IPV4:
560 <              if (who->localClient->aftype == AF_INET)
976 <                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
977 <                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
978 <                    return conf;
979 <              break;
980 < #ifdef IPV6
981 <            case HM_IPV6:
982 <              if (who->localClient->aftype == AF_INET6)
983 <                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
984 <                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
985 <                    return conf;
986 <              break;
987 < #endif
988 <            default:
989 <              assert(0);
990 <          }
558 >            break;
559 >          default:
560 >            assert(0);
561          }
562        }
563      }
994 –
995 –    break;
996 –
997 –  case CONF_SERVER:
998 –    DLINK_FOREACH(ptr, list_p->head)
999 –    {
1000 –      conf = ptr->data;
1001 –
1002 –      if (EmptyString(conf->name))
1003 –        continue;
1004 –
1005 –      if (name == NULL)
1006 –      {
1007 –        if (EmptyString(conf->host))
1008 –          continue;
1009 –        if (irccmp(conf->host, host) == 0)
1010 –          return conf;
1011 –      }
1012 –      else if (irccmp(conf->name, name) == 0)
1013 –        return conf;
1014 –    }
1015 –
1016 –    break;
1017 –
1018 –  default:
1019 –    break;
564    }
565  
566    return NULL;
567   }
568  
569 < /* rehash()
1026 < *
1027 < * Actual REHASH service routine. Called with sig == 0 if it has been called
1028 < * as a result of an operator issuing this command, else assume it has been
1029 < * called as a result of the server receiving a HUP signal.
1030 < */
1031 < int
1032 < rehash(int sig)
1033 < {
1034 <  if (sig)
1035 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1036 <                         "Got signal SIGHUP, reloading configuration file(s)");
1037 <
1038 <  restart_resolver();
1039 <
1040 <  /* don't close listeners until we know we can go ahead with the rehash */
1041 <
1042 <  /* Check to see if we magically got(or lost) IPv6 support */
1043 <  check_can_use_v6();
1044 <
1045 <  read_conf_files(0);
1046 <
1047 <  if (ServerInfo.description)
1048 <    strlcpy(me.info, ServerInfo.description, sizeof(me.info));
1049 <
1050 <  load_conf_modules();
1051 <
1052 <  rehashed_klines = 1;
1053 <
1054 <  return 0;
1055 < }
1056 <
1057 < /* set_default_conf()
569 > /* conf_set_defaults()
570   *
571   * inputs       - NONE
572   * output       - NONE
# Line 1064 | Line 576 | rehash(int sig)
576   *                of values later, put them in validate_conf().
577   */
578   static void
579 < set_default_conf(void)
579 > conf_set_defaults(void)
580   {
581 <  /* verify init_class() ran, this should be an unnecessary check
582 <   * but its not much work.
581 >  /*
582 >   * Verify init_class() ran, this should be an unnecessary check
583 >   * but it's not much work.
584     */
585    assert(class_default == class_get_list()->tail->data);
586  
587 < #ifdef HAVE_LIBCRYPTO
588 <  ServerInfo.rsa_private_key = NULL;
589 <  ServerInfo.rsa_private_key_file = NULL;
590 < #endif
591 <
592 <  /* ServerInfo.name is not rehashable */
1080 <  /* ServerInfo.name = ServerInfo.name; */
1081 <  ServerInfo.description = NULL;
1082 <  ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1083 <  ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1084 <
1085 <  memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
1086 <  ServerInfo.specific_ipv4_vhost = 0;
1087 <  memset(&ServerInfo.ip6, 0, sizeof(ServerInfo.ip6));
1088 <  ServerInfo.specific_ipv6_vhost = 0;
1089 <
1090 <  ServerInfo.max_clients = MAXCLIENTS_MAX;
1091 <  ServerInfo.max_nick_length = 9;
1092 <  ServerInfo.max_topic_length = 80;
1093 <
1094 <  ServerInfo.hub = 0;
1095 <  ServerInfo.dns_host.sin_addr.s_addr = 0;
1096 <  ServerInfo.dns_host.sin_port = 0;
1097 <  AdminInfo.name = NULL;
1098 <  AdminInfo.email = NULL;
1099 <  AdminInfo.description = NULL;
587 >  ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
588 >  ConfigServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
589 >  ConfigServerInfo.default_max_clients = MAXCLIENTS_MAX;
590 >  ConfigServerInfo.max_nick_length = 9;
591 >  ConfigServerInfo.max_topic_length = 80;
592 >  ConfigServerInfo.hub = 0;
593  
594 <  log_del_all();
594 >  log_iterate(log_free);
595  
596 <  ConfigLoggingEntry.use_logging = 1;
596 >  ConfigLog.use_logging = 1;
597  
598 +  ConfigChannel.enable_extbans = 0;
599    ConfigChannel.disable_fake_channels = 0;
600 <  ConfigChannel.knock_delay = 300;
600 >  ConfigChannel.invite_client_count = 10;
601 >  ConfigChannel.invite_client_time = 300;
602 >  ConfigChannel.invite_delay_channel = 5;
603 >  ConfigChannel.invite_expire_time = 1800;
604 >  ConfigChannel.knock_client_count = 1;
605 >  ConfigChannel.knock_client_time = 300;
606    ConfigChannel.knock_delay_channel = 60;
607 <  ConfigChannel.max_chans_per_user = 25;
608 <  ConfigChannel.max_chans_per_oper = 50;
609 <  ConfigChannel.max_bans = 25;
610 <  ConfigChannel.default_split_user_count = 0;
611 <  ConfigChannel.default_split_server_count = 0;
612 <  ConfigChannel.no_join_on_split = 0;
1114 <  ConfigChannel.no_create_on_split = 0;
607 >  ConfigChannel.max_channels = 25;
608 >  ConfigChannel.max_invites = 20;
609 >  ConfigChannel.max_bans = 100;
610 >  ConfigChannel.max_bans_large = 500;
611 >  ConfigChannel.default_join_flood_count = 18;
612 >  ConfigChannel.default_join_flood_time = 6;
613  
614    ConfigServerHide.flatten_links = 0;
615 <  ConfigServerHide.links_delay = 300;
615 >  ConfigServerHide.flatten_links_delay = 300;
616    ConfigServerHide.hidden = 0;
617    ConfigServerHide.hide_servers = 0;
618    ConfigServerHide.hide_services = 0;
# Line 1122 | Line 620 | set_default_conf(void)
620    ConfigServerHide.hide_server_ips = 0;
621    ConfigServerHide.disable_remote_commands = 0;
622  
623 <  ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
624 <  ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
625 <  ConfigFileEntry.cycle_on_host_change = 1;
626 <  ConfigFileEntry.glines = 0;
627 <  ConfigFileEntry.gline_time = 12 * 3600;
628 <  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
629 <  ConfigFileEntry.gline_min_cidr = 16;
630 <  ConfigFileEntry.gline_min_cidr6 = 48;
631 <  ConfigFileEntry.invisible_on_connect = 1;
632 <  ConfigFileEntry.tkline_expire_notices = 1;
633 <  ConfigFileEntry.hide_spoof_ips = 1;
634 <  ConfigFileEntry.ignore_bogus_ts = 0;
635 <  ConfigFileEntry.disable_auth = 0;
636 <  ConfigFileEntry.kill_chase_time_limit = 90;
637 <  ConfigFileEntry.default_floodcount = 8;
638 <  ConfigFileEntry.failed_oper_notice = 1;
639 <  ConfigFileEntry.dots_in_ident = 0;
640 <  ConfigFileEntry.min_nonwildcard = 4;
641 <  ConfigFileEntry.min_nonwildcard_simple = 3;
642 <  ConfigFileEntry.max_accept = 20;
643 <  ConfigFileEntry.anti_nick_flood = 0;
644 <  ConfigFileEntry.max_nick_time = 20;
645 <  ConfigFileEntry.max_nick_changes = 5;
646 <  ConfigFileEntry.anti_spam_exit_message_time = 0;
647 <  ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
648 <  ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
649 <  ConfigFileEntry.warn_no_nline = 1;
650 <  ConfigFileEntry.stats_o_oper_only = 0;
651 <  ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
652 <  ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
653 <  ConfigFileEntry.stats_P_oper_only = 0;
654 <  ConfigFileEntry.stats_u_oper_only = 0;
655 <  ConfigFileEntry.caller_id_wait = 60;
656 <  ConfigFileEntry.opers_bypass_callerid = 0;
657 <  ConfigFileEntry.pace_wait = 10;
658 <  ConfigFileEntry.pace_wait_simple = 1;
659 <  ConfigFileEntry.short_motd = 0;
660 <  ConfigFileEntry.ping_cookie = 0;
661 <  ConfigFileEntry.no_oper_flood = 0;
662 <  ConfigFileEntry.true_no_oper_flood = 0;
663 <  ConfigFileEntry.oper_pass_resv = 1;
664 <  ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
665 <  ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
666 <  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
667 <    UMODE_OPERWALL | UMODE_WALLOP;
668 <  ConfigFileEntry.use_egd = 0;
669 <  ConfigFileEntry.egdpool_path = NULL;
1172 <  ConfigFileEntry.throttle_time = 10;
623 >  ConfigGeneral.away_count = 2;
624 >  ConfigGeneral.away_time = 10;
625 >  ConfigGeneral.max_watch = 50;
626 >  ConfigGeneral.whowas_history_length = 15000;
627 >  ConfigGeneral.cycle_on_host_change = 1;
628 >  ConfigGeneral.dline_min_cidr = 16;
629 >  ConfigGeneral.dline_min_cidr6 = 48;
630 >  ConfigGeneral.kline_min_cidr = 16;
631 >  ConfigGeneral.kline_min_cidr6 = 48;
632 >  ConfigGeneral.invisible_on_connect = 1;
633 >  ConfigGeneral.disable_auth = 0;
634 >  ConfigGeneral.kill_chase_time_limit = 90;
635 >  ConfigGeneral.default_floodcount = 8;
636 >  ConfigGeneral.default_floodtime = 1;
637 >  ConfigGeneral.failed_oper_notice = 1;
638 >  ConfigGeneral.dots_in_ident = 0;
639 >  ConfigGeneral.min_nonwildcard = 4;
640 >  ConfigGeneral.min_nonwildcard_simple = 3;
641 >  ConfigGeneral.max_accept = 50;
642 >  ConfigGeneral.anti_nick_flood = 0;
643 >  ConfigGeneral.max_nick_time = 20;
644 >  ConfigGeneral.max_nick_changes = 5;
645 >  ConfigGeneral.anti_spam_exit_message_time = 0;
646 >  ConfigGeneral.ts_warn_delta = 30;
647 >  ConfigGeneral.ts_max_delta = 600;
648 >  ConfigGeneral.warn_no_connect_block = 1;
649 >  ConfigGeneral.stats_e_disabled = 0;
650 >  ConfigGeneral.stats_i_oper_only = 1;  /* 1 = masked */
651 >  ConfigGeneral.stats_k_oper_only = 1;  /* 1 = masked */
652 >  ConfigGeneral.stats_o_oper_only = 1;
653 >  ConfigGeneral.stats_m_oper_only = 1;
654 >  ConfigGeneral.stats_P_oper_only = 0;
655 >  ConfigGeneral.stats_u_oper_only = 0;
656 >  ConfigGeneral.caller_id_wait = 60;
657 >  ConfigGeneral.opers_bypass_callerid = 1;
658 >  ConfigGeneral.pace_wait = 10;
659 >  ConfigGeneral.pace_wait_simple = 1;
660 >  ConfigGeneral.short_motd = 0;
661 >  ConfigGeneral.ping_cookie = 0;
662 >  ConfigGeneral.no_oper_flood = 0;
663 >  ConfigGeneral.max_targets = MAX_TARGETS_DEFAULT;
664 >  ConfigGeneral.oper_only_umodes = UMODE_DEBUG | UMODE_LOCOPS | UMODE_HIDDEN | UMODE_FARCONNECT |
665 >                                   UMODE_UNAUTH | UMODE_EXTERNAL | UMODE_BOTS | UMODE_NCHANGE |
666 >                                   UMODE_SPY | UMODE_FULL | UMODE_SKILL | UMODE_REJ | UMODE_CCONN;
667 >  ConfigGeneral.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE | UMODE_WALLOP;
668 >  ConfigGeneral.throttle_count = 1;
669 >  ConfigGeneral.throttle_time = 1;
670   }
671  
672   static void
673 < validate_conf(void)
673 > conf_validate(void)
674   {
675 <  if (ConfigFileEntry.ts_warn_delta < TS_WARN_DELTA_MIN)
676 <    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1180 <
1181 <  if (ConfigFileEntry.ts_max_delta < TS_MAX_DELTA_MIN)
1182 <    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1183 <
1184 <  if (ServerInfo.network_name == NULL)
1185 <    ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1186 <
1187 <  if (ServerInfo.network_desc == NULL)
1188 <    ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
675 >  if (EmptyString(ConfigServerInfo.network_name))
676 >    ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
677  
678 <  if (ConfigFileEntry.service_name == NULL)
679 <    ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1192 <
1193 <  ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
678 >  if (EmptyString(ConfigServerInfo.network_desc))
679 >    ConfigServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
680   }
681  
682 < /* read_conf()
682 > /* conf_read()
683   *
684   * inputs       - file descriptor pointing to config file to use
685   * output       - None
686   * side effects - Read configuration file.
687   */
688   static void
689 < read_conf(FILE *file)
689 > conf_read(FILE *file)
690   {
691 <  lineno = 0;
691 >  lineno = 1;
692  
693 <  set_default_conf(); /* Set default values prior to conf parsing */
693 >  conf_set_defaults();  /* Set default values prior to conf parsing */
694    conf_parser_ctx.pass = 1;
695 <  yyparse();          /* pick up the classes first */
695 >  yyparse();  /* Pick up the classes first */
696  
697    rewind(file);
698  
699    conf_parser_ctx.pass = 2;
700 <  yyparse();          /* Load the values from the conf */
701 <  validate_conf();    /* Check to make sure some values are still okay. */
702 <                      /* Some global values are also loaded here. */
703 <  class_delete_marked();      /* Make sure classes are valid */
700 >  yyparse();  /* Load the values from the conf */
701 >  conf_validate();  /* Check to make sure some values are still okay. */
702 >                    /* Some global values are also loaded here. */
703 >  whowas_trim();  /* Attempt to trim whowas list if necessary */
704 >  class_delete_marked();  /* Delete unused classes that are marked for deletion */
705   }
706  
707 < /* lookup_confhost()
707 > /* conf_rehash()
708   *
709 < * start DNS lookups of all hostnames in the conf
710 < * line and convert an IP addresses in a.b.c.d number for to IP#s.
709 > * Actual REHASH service routine. Called with sig == 0 if it has been called
710 > * as a result of an operator issuing this command, else assume it has been
711 > * called as a result of the server receiving a HUP signal.
712   */
713   void
714 < lookup_confhost(struct MaskItem *conf)
714 > conf_rehash(bool sig)
715   {
716 <  struct addrinfo hints, *res;
1229 <
1230 <  /* Do name lookup now on hostnames given and store the
1231 <   * ip numbers in conf structure.
1232 <   */
1233 <  memset(&hints, 0, sizeof(hints));
1234 <
1235 <  hints.ai_family   = AF_UNSPEC;
1236 <  hints.ai_socktype = SOCK_STREAM;
1237 <
1238 <  /* Get us ready for a bind() and don't bother doing dns lookup */
1239 <  hints.ai_flags = AI_PASSIVE | AI_NUMERICHOST;
1240 <
1241 <  if (getaddrinfo(conf->host, NULL, &hints, &res))
716 >  if (sig == true)
717    {
718 <    conf_dns_lookup(conf);
719 <    return;
718 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
719 >                         "Got signal SIGHUP, reloading configuration file(s)");
720 >    ilog(LOG_TYPE_IRCD, "Got signal SIGHUP, reloading configuration file(s)");
721    }
722  
723 <  assert(res);
723 >  restart_resolver();
724 >
725 >  /* don't close listeners until we know we can go ahead with the rehash */
726  
727 <  memcpy(&conf->addr, res->ai_addr, res->ai_addrlen);
1250 <  conf->addr.ss_len = res->ai_addrlen;
1251 <  conf->addr.ss.ss_family = res->ai_family;
727 >  conf_read_files(false);
728  
729 <  freeaddrinfo(res);
729 >  load_conf_modules();
730 >  check_conf_klines();
731   }
732  
733   /* conf_connect_allowed()
# Line 1261 | Line 738 | lookup_confhost(struct MaskItem *conf)
738   * side effects - none
739   */
740   int
741 < conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
741 > conf_connect_allowed(struct irc_ssaddr *addr)
742   {
743 <  struct ip_entry *ip_found;
1267 <  struct MaskItem *conf = find_dline_conf(addr, aftype);
1268 <
1269 <  /* DLINE exempt also gets you out of static limits/pacing... */
1270 <  if (conf && (conf->type == CONF_EXEMPT))
1271 <    return 0;
743 >  const struct MaskItem *conf = find_dline_conf(addr);
744  
745    if (conf)
746 +  {
747 +    /* DLINE exempt also gets you out of static limits/pacing... */
748 +    if (conf->type == CONF_EXEMPT)
749 +      return 0;
750      return BANNED_CLIENT;
751 +  }
752  
753 <  ip_found = find_or_add_ip(addr);
754 <
1278 <  if ((CurrentTime - ip_found->last_attempt) <
1279 <      ConfigFileEntry.throttle_time)
753 >  struct ip_entry *ip_found = ipcache_record_find_or_add(addr);
754 >  if ((event_base->time.sec_monotonic - ip_found->last_attempt) < ConfigGeneral.throttle_time)
755    {
756 <    ip_found->last_attempt = CurrentTime;
757 <    return TOO_FAST;
756 >    if (ip_found->connection_count >= ConfigGeneral.throttle_count)
757 >      return TOO_FAST;
758 >
759 >    ++ip_found->connection_count;
760    }
761 +  else
762 +    ip_found->connection_count = 1;
763  
764 <  ip_found->last_attempt = CurrentTime;
764 >  ip_found->last_attempt = event_base->time.sec_monotonic;
765    return 0;
766   }
767  
# Line 1294 | Line 773 | conf_connect_allowed(struct irc_ssaddr *
773   *                This is an event started off in ircd.c
774   */
775   void
776 < cleanup_tklines(void *notused)
776 > cleanup_tklines(void *unused)
777   {
778    hostmask_expire_temporary();
779 <  expire_tklines(&xconf_items);
780 <  expire_tklines(&nresv_items);
1302 <  expire_tklines(&cresv_items);
779 >  gecos_expire();
780 >  resv_expire();
781   }
782  
783 < /* expire_tklines()
784 < *
785 < * inputs       - tkline list pointer
786 < * output       - NONE
787 < * side effects - expire tklines
783 > /*
784 > * Input: A client to find the active operator {} name for.
785 > * Output: The nick!user@host{oper} of the oper.
786 > *         "oper" is server name for remote opers
787 > * Side effects: None.
788   */
789 < static void
790 < expire_tklines(dlink_list *tklist)
789 > const char *
790 > get_oper_name(const struct Client *client)
791   {
792 <  dlink_node *ptr = NULL, *ptr_next = NULL;
1315 <  struct MaskItem *conf = NULL;
792 >  static char buffer[IRCD_BUFSIZE];
793  
794 <  DLINK_FOREACH_SAFE(ptr, ptr_next, tklist->head)
795 <  {
1319 <    conf = ptr->data;
794 >  if (IsServer(client))
795 >    return client->name;
796  
797 <    if (!conf->until || conf->until > CurrentTime)
798 <      continue;
797 >  if (MyConnect(client))
798 >  {
799 >    const dlink_node *const node = client->connection->confs.head;
800  
801 <    if (conf->type == CONF_XLINE)
1325 <    {
1326 <      if (ConfigFileEntry.tkline_expire_notices)
1327 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1328 <                               "Temporary X-line for [%s] expired", conf->name);
1329 <      conf_free(conf);
1330 <    }
1331 <    else if (conf->type == CONF_NRESV || conf->type == CONF_CRESV)
801 >    if (node)
802      {
803 <      if (ConfigFileEntry.tkline_expire_notices)
804 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
805 <                               "Temporary RESV for [%s] expired", conf->name);
806 <      conf_free(conf);
803 >      const struct MaskItem *const conf = node->data;
804 >
805 >      if (conf->type == CONF_OPER)
806 >      {
807 >        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client->name,
808 >                 client->username, client->host, conf->name);
809 >        return buffer;
810 >      }
811      }
812 +
813 +    /*
814 +     * Probably should assert here for now. If there is an oper out there
815 +     * with no operator {} conf attached, it would be good for us to know...
816 +     */
817 +    assert(0);  /* Oper without oper conf! */
818    }
819 +
820 +  snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client->name,
821 +           client->username, client->host, client->servptr->name);
822 +  return buffer;
823   }
824  
825 < /* oper_privs_as_string()
825 > /* conf_clear()
826   *
827 < * inputs        - pointer to client_p
828 < * output        - pointer to static string showing oper privs
829 < * side effects  - return as string, the oper privs as derived from port
830 < */
831 < static const struct oper_privs
832 < {
1349 <  const unsigned int flag;
1350 <  const unsigned char c;
1351 < } flag_list[] = {
1352 <  { OPER_FLAG_ADMIN,          'A' },
1353 <  { OPER_FLAG_REMOTEBAN,      'B' },
1354 <  { OPER_FLAG_DIE,            'D' },
1355 <  { OPER_FLAG_GLINE,          'G' },
1356 <  { OPER_FLAG_REHASH,         'H' },
1357 <  { OPER_FLAG_K,              'K' },
1358 <  { OPER_FLAG_OPERWALL,       'L' },
1359 <  { OPER_FLAG_KILL,           'N' },
1360 <  { OPER_FLAG_KILL_REMOTE,    'O' },
1361 <  { OPER_FLAG_CONNECT,        'P' },
1362 <  { OPER_FLAG_CONNECT_REMOTE, 'Q' },
1363 <  { OPER_FLAG_SQUIT,          'R' },
1364 <  { OPER_FLAG_SQUIT_REMOTE,   'S' },
1365 <  { OPER_FLAG_UNKLINE,        'U' },
1366 <  { OPER_FLAG_XLINE,          'X' },
1367 <  { 0, '\0' }
1368 < };
1369 <
1370 < char *
1371 < oper_privs_as_string(const unsigned int port)
827 > * inputs       - none
828 > * output       - none
829 > * side effects - Clear out the old configuration
830 > */
831 > static void
832 > conf_clear(void)
833   {
834 <  static char privs_out[IRCD_BUFSIZE];
835 <  char *privs_ptr = privs_out;
834 >  dlink_node *node = NULL, *node_next = NULL;
835 >  dlink_list *free_items [] = {
836 >    &connect_items, &operator_items, NULL
837 >  };
838 >
839 >  dlink_list ** iterator = free_items; /* C is dumb */
840 >
841 >  /* We only need to free anything allocated by yyparse() here.
842 >   * Resetting structs, etc, is taken care of by conf_set_defaults().
843 >   */
844  
845 <  for (const struct oper_privs *opriv = flag_list; opriv->flag; ++opriv)
845 >  for (; *iterator; iterator++)
846    {
847 <    if (port & opriv->flag)
848 <      *privs_ptr++ = opriv->c;
849 <    else
850 <      *privs_ptr++ = ToLower(opriv->c);
847 >    DLINK_FOREACH_SAFE(node, node_next, (*iterator)->head)
848 >    {
849 >      struct MaskItem *conf = node->data;
850 >
851 >      conf->active = false;
852 >      dlinkDelete(&conf->node, *iterator);
853 >
854 >      if (!conf->ref_count)
855 >        conf_free(conf);
856 >    }
857    }
858  
859 <  *privs_ptr = '\0';
859 >  /*
860 >   * Don't delete the class table, rather mark all entries for deletion.
861 >   * The table is cleaned up by class_delete_marked. - avalon
862 >   */
863 >  class_mark_for_deletion();
864  
865 <  return privs_out;
865 >  clear_out_address_conf();
866 >
867 >  modules_conf_clear();  /* Clear modules {} items */
868 >
869 >  motd_clear();  /* Clear motd {} items and re-cache default motd */
870 >
871 >  cluster_clear();  /* Clear cluster {} items */
872 >
873 >  gecos_clear();  /* Clear gecos {} items */
874 >
875 >  resv_clear();  /* Clear resv {} items */
876 >
877 >  service_clear();  /* Clear service {} items */
878 >
879 >  shared_clear();  /* Clear shared {} items */
880 >
881 >  pseudo_clear();  /* Clear pseudo {} items */
882 >
883 >  /* Clean out ConfigServerInfo */
884 >  xfree(ConfigServerInfo.description);
885 >  ConfigServerInfo.description = NULL;
886 >  xfree(ConfigServerInfo.network_name);
887 >  ConfigServerInfo.network_name = NULL;
888 >  xfree(ConfigServerInfo.network_desc);
889 >  ConfigServerInfo.network_desc = NULL;
890 >  xfree(ConfigServerInfo.rsa_private_key_file);
891 >  ConfigServerInfo.rsa_private_key_file = NULL;
892 >  xfree(ConfigServerInfo.tls_certificate_file);
893 >  ConfigServerInfo.tls_certificate_file = NULL;
894 >  xfree(ConfigServerInfo.tls_dh_param_file);
895 >  ConfigServerInfo.tls_dh_param_file = NULL;
896 >  xfree(ConfigServerInfo.tls_supported_groups);
897 >  ConfigServerInfo.tls_supported_groups = NULL;
898 >  xfree(ConfigServerInfo.tls_cipher_list);
899 >  ConfigServerInfo.tls_cipher_list = NULL;
900 >  xfree(ConfigServerInfo.tls_cipher_suites);
901 >  ConfigServerInfo.tls_cipher_suites = NULL;
902 >  xfree(ConfigServerInfo.tls_message_digest_algorithm);
903 >  ConfigServerInfo.tls_message_digest_algorithm = NULL;
904 >
905 >  /* Clean out ConfigAdminInfo */
906 >  xfree(ConfigAdminInfo.name);
907 >  ConfigAdminInfo.name = NULL;
908 >  xfree(ConfigAdminInfo.email);
909 >  ConfigAdminInfo.email = NULL;
910 >  xfree(ConfigAdminInfo.description);
911 >  ConfigAdminInfo.description = NULL;
912 >
913 >  /* Clean out ConfigServerHide */
914 >  xfree(ConfigServerHide.flatten_links_file);
915 >  ConfigServerHide.flatten_links_file = NULL;
916 >  xfree(ConfigServerHide.hidden_name);
917 >  ConfigServerHide.hidden_name = NULL;
918 >
919 >  /* Clean out listeners */
920 >  listener_close_marked();
921   }
922  
923 < /*
924 < * Input: A client to find the active oper{} name for.
1391 < * Output: The nick!user@host{oper} of the oper.
1392 < *         "oper" is server name for remote opers
1393 < * Side effects: None.
1394 < */
1395 < const char *
1396 < get_oper_name(const struct Client *client_p)
923 > static void
924 > conf_handle_tls(bool cold)
925   {
926 <  const dlink_node *cnode = NULL;
1399 <  /* +5 for !,@,{,} and null */
1400 <  static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
1401 <
1402 <  if (MyConnect(client_p))
926 >  if (tls_new_credentials() == false)
927    {
928 <    if ((cnode = client_p->localClient->confs.head))
928 >    if (cold == true)
929      {
930 <      const struct MaskItem *conf = cnode->data;
931 <
932 <      if (IsConfOperator(conf))
933 <      {
934 <        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
935 <                 client_p->username, client_p->host, conf->name);
936 <        return buffer;
937 <      }
930 >      ilog(LOG_TYPE_IRCD, "Error while initializing TLS");
931 >      exit(EXIT_FAILURE);
932 >    }
933 >    else
934 >    {
935 >      /* Failed to load new settings/certs, old ones remain active */
936 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
937 >                           "Error reloading TLS settings, check the ircd log"); // report_crypto_errors logs this
938      }
1415 –
1416 –    /* Probably should assert here for now. If there is an oper out there
1417 –     * with no oper{} conf attached, it would be good for us to know...
1418 –     */
1419 –    assert(0); /* Oper without oper conf! */
939    }
1421 –
1422 –  snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1423 –           client_p->username, client_p->host, client_p->servptr->name);
1424 –  return buffer;
940   }
941  
942   /* read_conf_files()
# Line 1431 | Line 946 | get_oper_name(const struct Client *clien
946   * side effects - read all conf files needed, ircd.conf kline.conf etc.
947   */
948   void
949 < read_conf_files(int cold)
949 > conf_read_files(bool cold)
950   {
951 <  const char *filename;
1437 <  char chanmodes[IRCD_BUFSIZE];
1438 <  char chanlimit[IRCD_BUFSIZE];
951 >  char buf[IRCD_BUFSIZE];
952  
953    conf_parser_ctx.boot = cold;
954 <  filename = ConfigFileEntry.configfile;
1442 <
1443 <  /* We need to know the initial filename for the yyerror() to report
1444 <     FIXME: The full path is in conffilenamebuf first time since we
1445 <             dont know anything else
1446 <
1447 <     - Gozem 2002-07-21
1448 <  */
1449 <  strlcpy(conffilebuf, filename, sizeof(conffilebuf));
954 >  conf_parser_ctx.conf_file = fopen(ConfigGeneral.configfile, "r");
955  
956 <  if ((conf_parser_ctx.conf_file = fopen(filename, "r")) == NULL)
956 >  if (conf_parser_ctx.conf_file == NULL)
957    {
958 <    if (cold)
958 >    if (cold == true)
959      {
960        ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
961 <           filename, strerror(errno));
962 <      exit(-1);
961 >           ConfigGeneral.configfile, strerror(errno));
962 >      exit(EXIT_FAILURE);
963      }
964      else
965      {
966 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
966 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
967                             "Unable to read configuration file '%s': %s",
968 <                           filename, strerror(errno));
968 >                           ConfigGeneral.configfile, strerror(errno));
969        return;
970      }
971    }
972  
1468 –  if (!cold)
1469 –    clear_out_old_conf();
1470 –
1471 –  read_conf(conf_parser_ctx.conf_file);
1472 –  fclose(conf_parser_ctx.conf_file);
1473 –
1474 –  log_reopen_all();
1475 –
1476 –  add_isupport("NICKLEN", NULL, ServerInfo.max_nick_length);
1477 –  add_isupport("NETWORK", ServerInfo.network_name, -1);
1478 –
1479 –  snprintf(chanmodes, sizeof(chanmodes), "beI:%d", ConfigChannel.max_bans);
1480 –  add_isupport("MAXLIST", chanmodes, -1);
1481 –  add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1482 –  add_isupport("CHANTYPES", "#", -1);
1483 –
1484 –  snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1485 –           ConfigChannel.max_chans_per_user);
1486 –  add_isupport("CHANLIMIT", chanlimit, -1);
1487 –  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,imnprstORS");
1488 –  add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
1489 –  add_isupport("TOPICLEN", NULL, ServerInfo.max_topic_length);
1490 –  add_isupport("CHANMODES", chanmodes, -1);
1491 –
973    /*
974 <   * message_locale may have changed.  rebuild isupport since it relies
975 <   * on strlen(form_str(RPL_ISUPPORT))
974 >   * We need to know the initial filename for the yyerror() to report
975 >   *
976 >   *  FIXME: The full path is in conffilenamebuf first time since we
977 >   *          don't know anything else
978 >   *
979 >   *  - Gozem 2002-07-21
980     */
981 <  rebuild_isupport_message_line();
1497 < }
981 >  strlcpy(conffilebuf, ConfigGeneral.configfile, sizeof(conffilebuf));
982  
983 < /* clear_out_old_conf()
984 < *
1501 < * inputs       - none
1502 < * output       - none
1503 < * side effects - Clear out the old configuration
1504 < */
1505 < static void
1506 < clear_out_old_conf(void)
1507 < {
1508 <  dlink_node *ptr = NULL, *next_ptr = NULL;
1509 <  struct MaskItem *conf;
1510 <  dlink_list *free_items [] = {
1511 <    &server_items,   &oconf_items,
1512 <     &uconf_items,   &xconf_items,
1513 <     &nresv_items, &cluster_items,  &service_items, &cresv_items, NULL
1514 <  };
1515 <
1516 <  dlink_list ** iterator = free_items; /* C is dumb */
983 >  if (cold == false)
984 >    conf_clear();
985  
986 <  /* We only need to free anything allocated by yyparse() here.
987 <   * Resetting structs, etc, is taken care of by set_default_conf().
1520 <   */
1521 <
1522 <  for (; *iterator != NULL; iterator++)
1523 <  {
1524 <    DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
1525 <    {
1526 <      conf = ptr->data;
986 >  conf_read(conf_parser_ctx.conf_file);
987 >  fclose(conf_parser_ctx.conf_file);
988  
989 <      dlinkDelete(&conf->node, map_to_list(conf->type));
989 >  log_iterate(log_reopen);
990 >  conf_handle_tls(cold);
991  
992 <      /* XXX This is less than pretty */
993 <      if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
1532 <      {
1533 <        if (!conf->ref_count)
1534 <          conf_free(conf);
1535 <      }
1536 <      else if (conf->type == CONF_XLINE)
1537 <      {
1538 <        if (!conf->until)
1539 <          conf_free(conf);
1540 <      }
1541 <      else
1542 <        conf_free(conf);
1543 <    }
1544 <  }
992 >  isupport_add("NICKLEN", NULL, ConfigServerInfo.max_nick_length);
993 >  isupport_add("NETWORK", ConfigServerInfo.network_name, -1);
994  
995 <  motd_clear();
995 >  snprintf(buf, sizeof(buf), "beI:%u", ConfigChannel.max_bans);
996 >  isupport_add("MAXLIST", buf, -1);
997  
998 <  /*
999 <   * don't delete the class table, rather mark all entries
1550 <   * for deletion. The table is cleaned up by class_delete_marked. - avalon
1551 <   */
1552 <  class_mark_for_deletion();
998 >  isupport_add("MAXTARGETS", NULL, ConfigGeneral.max_targets);
999 >  isupport_add("CHANTYPES", "#", -1);
1000  
1001 <  clear_out_address_conf();
1001 >  snprintf(buf, sizeof(buf), "#:%u", ConfigChannel.max_channels);
1002 >  isupport_add("CHANLIMIT", buf, -1);
1003  
1004 <  /* clean out module paths */
1005 <  mod_clear_paths();
1004 >  isupport_add("CHANNELLEN", NULL, CHANNELLEN);
1005 >  isupport_add("TOPICLEN", NULL, ConfigServerInfo.max_topic_length);
1006  
1007 <  /* clean out ServerInfo */
1008 <  MyFree(ServerInfo.description);
1561 <  ServerInfo.description = NULL;
1562 <  MyFree(ServerInfo.network_name);
1563 <  ServerInfo.network_name = NULL;
1564 <  MyFree(ServerInfo.network_desc);
1565 <  ServerInfo.network_desc = NULL;
1566 <  MyFree(ConfigFileEntry.egdpool_path);
1567 <  ConfigFileEntry.egdpool_path = NULL;
1568 < #ifdef HAVE_LIBCRYPTO
1569 <  if (ServerInfo.rsa_private_key)
1570 <  {
1571 <    RSA_free(ServerInfo.rsa_private_key);
1572 <    ServerInfo.rsa_private_key = NULL;
1573 <  }
1574 <
1575 <  MyFree(ServerInfo.rsa_private_key_file);
1576 <  ServerInfo.rsa_private_key_file = NULL;
1577 <
1578 <  if (ServerInfo.server_ctx)
1579 <    SSL_CTX_set_options(ServerInfo.server_ctx, SSL_OP_NO_SSLv2|
1580 <                                               SSL_OP_NO_SSLv3|
1581 <                                               SSL_OP_NO_TLSv1);
1582 <  if (ServerInfo.client_ctx)
1583 <    SSL_CTX_set_options(ServerInfo.client_ctx, SSL_OP_NO_SSLv2|
1584 <                                               SSL_OP_NO_SSLv3|
1585 <                                               SSL_OP_NO_TLSv1);
1586 < #endif
1587 <
1588 <  /* clean out AdminInfo */
1589 <  MyFree(AdminInfo.name);
1590 <  AdminInfo.name = NULL;
1591 <  MyFree(AdminInfo.email);
1592 <  AdminInfo.email = NULL;
1593 <  MyFree(AdminInfo.description);
1594 <  AdminInfo.description = NULL;
1595 <
1596 <  /* clean out listeners */
1597 <  close_listeners();
1598 <
1599 <  /* clean out general */
1600 <  MyFree(ConfigFileEntry.service_name);
1601 <  ConfigFileEntry.service_name = NULL;
1007 >  snprintf(buf, sizeof(buf), "%s", "beI,k,l,cimnprstuCKLMNORST");
1008 >  isupport_add("CHANMODES", buf, -1);
1009   }
1010  
1011   /* conf_add_class_to_conf()
# Line 1608 | Line 1015 | clear_out_old_conf(void)
1015   * side effects - Add a class pointer to a conf
1016   */
1017   void
1018 < conf_add_class_to_conf(struct MaskItem *conf, const char *class_name)
1018 > conf_add_class_to_conf(struct MaskItem *conf, const char *name)
1019   {
1020 <  if (class_name == NULL)
1020 >  if (EmptyString(name) || (conf->class = class_find(name, true)) == NULL)
1021    {
1022      conf->class = class_default;
1023  
1024 <    if (conf->type == CONF_CLIENT)
1025 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1024 >    if (conf->type == CONF_CLIENT || conf->type == CONF_OPER)
1025 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1026                             "Warning *** Defaulting to default class for %s@%s",
1027                             conf->user, conf->host);
1028      else
1029 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1029 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1030                             "Warning *** Defaulting to default class for %s",
1031                             conf->name);
1032    }
1626 –  else
1627 –    conf->class = class_find(class_name, 1);
1628 –
1629 –  if (conf->class == NULL)
1630 –  {
1631 –    if (conf->type == CONF_CLIENT)
1632 –      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1633 –                           "Warning *** Defaulting to default class for %s@%s",
1634 –                           conf->user, conf->host);
1635 –    else
1636 –      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1637 –                           "Warning *** Defaulting to default class for %s",
1638 –                           conf->name);
1639 –    conf->class = class_default;
1640 –  }
1033   }
1034  
1035   /* yyerror()
# Line 1649 | Line 1041 | conf_add_class_to_conf(struct MaskItem *
1041   void
1042   yyerror(const char *msg)
1043   {
1652 –  char newlinebuf[IRCD_BUFSIZE];
1653 –
1044    if (conf_parser_ctx.pass != 1)
1045      return;
1046  
1047 <  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1048 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1047 >  const char *p = stripws(linebuf);
1048 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1049                         "\"%s\", line %u: %s: %s",
1050 <                       conffilebuf, lineno + 1, msg, newlinebuf);
1050 >                       conffilebuf, lineno, msg, p);
1051    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1052 <       conffilebuf, lineno + 1, msg, newlinebuf);
1052 >       conffilebuf, lineno, msg, p);
1053   }
1054  
1055   void
1056   conf_error_report(const char *msg)
1057   {
1058 <  char newlinebuf[IRCD_BUFSIZE];
1059 <
1670 <  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1671 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1058 >  const char *p = stripws(linebuf);
1059 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1060                         "\"%s\", line %u: %s: %s",
1061 <                       conffilebuf, lineno + 1, msg, newlinebuf);
1061 >                       conffilebuf, lineno, msg, p);
1062    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1063 <       conffilebuf, lineno + 1, msg, newlinebuf);
1063 >       conffilebuf, lineno, msg, p);
1064   }
1065  
1066   /*
# Line 1685 | Line 1073 | conf_error_report(const char *msg)
1073   * side effects - none
1074   * Originally written by Dianora (Diane, db@db.net)
1075   */
1076 < time_t
1076 > uintmax_t
1077   valid_tkline(const char *data, const int minutes)
1078   {
1079    const unsigned char *p = (const unsigned char *)data;
1080    unsigned char tmpch = '\0';
1081 <  time_t result = 0;
1081 >  uintmax_t result = 0;
1082  
1083    while ((tmpch = *p++))
1084    {
# Line 1703 | Line 1091 | valid_tkline(const char *data, const int
1091  
1092    /*
1093     * In the degenerate case where oper does a /quote kline 0 user@host :reason
1094 <   * i.e. they specifically use 0, I am going to return 1 instead
1095 <   * as a return value of non-zero is used to flag it as a temporary kline
1094 >   * i.e. they specifically use 0, I am going to return 1 instead as a return
1095 >   * value of non-zero is used to flag it as a temporary kline
1096     */
1097    if (result == 0)
1098      result = 1;
# Line 1713 | Line 1101 | valid_tkline(const char *data, const int
1101     * If the incoming time is in seconds convert it to minutes for the purpose
1102     * of this calculation
1103     */
1104 <  if (!minutes)
1104 >  if (minutes == 0)
1105      result = result / 60;
1106  
1107    if (result > MAX_TDKLINE_TIME)
1108      result = MAX_TDKLINE_TIME;
1109  
1110 <  result = result * 60;  /* turn it into seconds */
1110 >  result = result * 60;  /* Turn it into seconds */
1111  
1112    return result;
1113   }
# Line 1730 | Line 1118 | valid_tkline(const char *data, const int
1118   * outputs      - 1 if valid, else 0
1119   * side effects - none
1120   */
1121 < int
1121 > bool
1122   valid_wild_card_simple(const char *data)
1123   {
1124    const unsigned char *p = (const unsigned char *)data;
1125    unsigned char tmpch = '\0';
1126 <  int nonwild = 0;
1126 >  unsigned int nonwild = 0, wild = 0;
1127  
1128    while ((tmpch = *p++))
1129    {
1130 <    if (tmpch == '\\')
1130 >    if (tmpch == '\\' && *p)
1131      {
1132        ++p;
1133 <      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1134 <        return 1;
1133 >      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1134 >        return true;
1135      }
1136      else if (!IsMWildChar(tmpch))
1137      {
1138 <      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1139 <        return 1;
1138 >      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1139 >        return true;
1140      }
1141 +    else
1142 +      ++wild;
1143    }
1144  
1145 <  return 0;
1145 >  return wild == 0;
1146   }
1147  
1148   /* valid_wild_card()
# Line 1761 | Line 1151 | valid_wild_card_simple(const char *data)
1151   *              - int flag, 0 for no warning oper 1 for warning oper
1152   *              - count of following varargs to check
1153   * output       - 0 if not valid, 1 if valid
1154 < * side effects - NOTICE is given to source_p if warn is 1
1154 > * side effects - NOTICE is given to client if warn is 1
1155   */
1156 < int
1157 < valid_wild_card(struct Client *source_p, int warn, int count, ...)
1156 > bool
1157 > valid_wild_card(int count, ...)
1158   {
1159 <  char tmpch;
1160 <  int nonwild = 0;
1159 >  unsigned char tmpch = '\0';
1160 >  unsigned int nonwild = 0;
1161    va_list args;
1162  
1163    /*
# Line 1786 | Line 1176 | valid_wild_card(struct Client *source_p,
1176  
1177    while (count--)
1178    {
1179 <    const char *p = va_arg(args, const char *);
1179 >    const unsigned char *p = va_arg(args, const unsigned char *);
1180      if (p == NULL)
1181        continue;
1182  
# Line 1798 | Line 1188 | valid_wild_card(struct Client *source_p,
1188           * If we find enough non-wild characters, we can
1189           * break - no point in searching further.
1190           */
1191 <        if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1191 >        if (++nonwild >= ConfigGeneral.min_nonwildcard)
1192          {
1193            va_end(args);
1194 <          return 1;
1194 >          return true;
1195          }
1196        }
1197      }
1198    }
1199  
1810 –  if (warn)
1811 –    sendto_one_notice(source_p, &me,
1812 –                      ":Please include at least %d non-wildcard characters with the mask",
1813 –                      ConfigFileEntry.min_nonwildcard);
1200    va_end(args);
1201 <  return 0;
1201 >  return false;
1202   }
1203  
1204   /* XXX should this go into a separate file ? -Dianora */
# Line 1829 | Line 1215 | valid_wild_card(struct Client *source_p,
1215   *              - pointer to target_server to parse into if non NULL
1216   *              - pointer to reason to parse into
1217   *
1218 < * output       - 1 if valid, -1 if not valid
1218 > * output       - 1 if valid, 0 if not valid
1219   * side effects - A generalised k/d/x etc. line parser,
1220   *               "ALINE [time] user@host|string [ON] target :reason"
1221   *                will parse returning a parsed user, host if
# Line 1845 | Line 1231 | valid_wild_card(struct Client *source_p,
1231   *
1232   * - Dianora
1233   */
1234 < int
1235 < parse_aline(const char *cmd, struct Client *source_p,
1850 <            int parc, char **parv,
1851 <            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1852 <            char **target_server, char **reason)
1234 > bool
1235 > parse_aline(const char *cmd, struct Client *client, int parc, char **parv, struct aline_ctx *aline)
1236   {
1237 <  int found_tkline_time=0;
1238 <  static char def_reason[] = "No Reason";
1239 <  static char user[USERLEN*4+1];
1857 <  static char host[HOSTLEN*4+1];
1858 <
1859 <  parv++;
1860 <  parc--;
1237 >  static char default_reason[] = CONF_NOREASON;
1238 >  static char user[USERLEN * 2 + 1];
1239 >  static char host[HOSTLEN * 2 + 1];
1240  
1241 <  found_tkline_time = valid_tkline(*parv, TK_MINUTES);
1241 >  ++parv;
1242 >  --parc;
1243  
1244 <  if (found_tkline_time != 0)
1244 >  if (aline->add == true && (aline->duration = valid_tkline(*parv, TK_MINUTES)))
1245    {
1246 <    parv++;
1247 <    parc--;
1868 <
1869 <    if (tkline_time != NULL)
1870 <      *tkline_time = found_tkline_time;
1871 <    else
1872 <    {
1873 <      sendto_one_notice(source_p, &me, ":temp_line not supported by %s", cmd);
1874 <      return -1;
1875 <    }
1246 >    ++parv;
1247 >    --parc;
1248    }
1249  
1250    if (parc == 0)
1251    {
1252 <    sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1253 <    return -1;
1252 >    sendto_one_numeric(client, &me, ERR_NEEDMOREPARAMS, cmd);
1253 >    return false;
1254    }
1255  
1256 <  if (h_p == NULL)
1257 <    *up_p = *parv;
1256 >  if (aline->simple_mask == true)
1257 >  {
1258 >    aline->mask = *parv;
1259 >    aline->user = NULL;
1260 >    aline->host = NULL;
1261 >  }
1262    else
1263    {
1264 <    if (find_user_host(source_p, *parv, user, host, parse_flags) == 0)
1889 <      return -1;
1264 >    struct split_nuh_item nuh;
1265  
1266 <    *up_p = user;
1267 <    *h_p = host;
1266 >    nuh.nuhmask  = *parv;
1267 >    nuh.nickptr  = NULL;
1268 >    nuh.userptr  = user;
1269 >    nuh.hostptr  = host;
1270 >
1271 >    nuh.nicksize = 0;
1272 >    nuh.usersize = sizeof(user);
1273 >    nuh.hostsize = sizeof(host);
1274 >
1275 >    split_nuh(&nuh);
1276 >
1277 >    aline->mask = NULL;
1278 >    aline->user = user;
1279 >    aline->host = host;
1280    }
1281  
1282 <  parc--;
1283 <  parv++;
1282 >  ++parv;
1283 >  --parc;
1284  
1285 <  if (parc != 0)
1285 >  if (parc)
1286    {
1287      if (irccmp(*parv, "ON") == 0)
1288      {
1289 <      parc--;
1290 <      parv++;
1289 >      ++parv;
1290 >      --parc;
1291  
1292 <      if (target_server == NULL)
1292 >      if (!HasOFlag(client, OPER_FLAG_REMOTEBAN))
1293        {
1294 <        sendto_one_notice(source_p, &me, ":ON server not supported by %s", cmd);
1295 <        return -1;
1909 <      }
1910 <
1911 <      if (!HasOFlag(source_p, OPER_FLAG_REMOTEBAN))
1912 <      {
1913 <        sendto_one_numeric(source_p, &me, ERR_NOPRIVS, "remoteban");
1914 <        return -1;
1294 >        sendto_one_numeric(client, &me, ERR_NOPRIVS, "remoteban");
1295 >        return false;
1296        }
1297  
1298        if (parc == 0 || EmptyString(*parv))
1299        {
1300 <        sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1301 <        return -1;
1300 >        sendto_one_numeric(client, &me, ERR_NEEDMOREPARAMS, cmd);
1301 >        return false;
1302        }
1303  
1304 <      *target_server = *parv;
1305 <      parc--;
1306 <      parv++;
1926 <    }
1927 <    else
1928 <    {
1929 <      /* Make sure target_server *is* NULL if no ON server found
1930 <       * caller probably NULL'd it first, but no harm to do it again -db
1931 <       */
1932 <      if (target_server != NULL)
1933 <        *target_server = NULL;
1934 <    }
1935 <  }
1936 <
1937 <  if (h_p != NULL)
1938 <  {
1939 <    if (strchr(user, '!') != NULL)
1940 <    {
1941 <      sendto_one_notice(source_p, &me, ":Invalid character '!' in kline");
1942 <      return -1;
1943 <    }
1944 <
1945 <    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 2, *up_p, *h_p))
1946 <      return -1;
1947 <  }
1948 <  else
1949 <    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 1, *up_p))
1950 <      return -1;
1951 <
1952 <  if (reason != NULL)
1953 <  {
1954 <    if (parc != 0 && !EmptyString(*parv))
1955 <    {
1956 <      *reason = *parv;
1957 <      if (!valid_comment(source_p, *reason, 1))
1958 <        return -1;
1304 >      aline->server = *parv;
1305 >      ++parv;
1306 >      --parc;
1307      }
1308      else
1309 <      *reason = def_reason;
1309 >      aline->server = NULL;
1310    }
1311  
1312 <  return 1;
1965 < }
1966 <
1967 < /* find_user_host()
1968 < *
1969 < * inputs       - pointer to client placing kline
1970 < *              - pointer to user_host_or_nick
1971 < *              - pointer to user buffer
1972 < *              - pointer to host buffer
1973 < * output       - 0 if not ok to kline, 1 to kline i.e. if valid user host
1974 < * side effects -
1975 < */
1976 < static int
1977 < find_user_host(struct Client *source_p, char *user_host_or_nick,
1978 <               char *luser, char *lhost, unsigned int flags)
1979 < {
1980 <  struct Client *target_p = NULL;
1981 <  char *hostp = NULL;
1982 <
1983 <  if (lhost == NULL)
1984 <  {
1985 <    strlcpy(luser, user_host_or_nick, USERLEN*4 + 1);
1986 <    return 1;
1987 <  }
1988 <
1989 <  if ((hostp = strchr(user_host_or_nick, '@')) || *user_host_or_nick == '*')
1990 <  {
1991 <    /* Explicit user@host mask given */
1992 <
1993 <    if (hostp != NULL)                            /* I'm a little user@host */
1994 <    {
1995 <      *(hostp++) = '\0';                       /* short and squat */
1996 <      if (*user_host_or_nick)
1997 <        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1998 <      else
1999 <        strcpy(luser, "*");
2000 <
2001 <      if (*hostp)
2002 <        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2003 <      else
2004 <        strcpy(lhost, "*");
2005 <    }
2006 <    else
2007 <    {
2008 <      luser[0] = '*';             /* no @ found, assume its *@somehost */
2009 <      luser[1] = '\0';
2010 <      strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
2011 <    }
2012 <
2013 <    return 1;
2014 <  }
2015 <  else
1312 >  if (aline->add == true)
1313    {
1314 <    /* Try to find user@host mask from nick */
1315 <    /* Okay to use source_p as the first param, because source_p == client_p */
2019 <    if ((target_p =
2020 <        find_chasing(source_p, user_host_or_nick)) == NULL)
2021 <      return 0;
2022 <
2023 <    if (IsExemptKline(target_p))
2024 <    {
2025 <      if (!IsServer(source_p))
2026 <        sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
2027 <      return 0;
2028 <    }
2029 <
2030 <    /*
2031 <     * turn the "user" bit into "*user", blow away '~'
2032 <     * if found in original user name (non-idented)
2033 <     */
2034 <    strlcpy(luser, target_p->username, USERLEN*4 + 1);
2035 <
2036 <    if (target_p->username[0] == '~')
2037 <      luser[0] = '*';
2038 <
2039 <    if (target_p->sockhost[0] == '\0' ||
2040 <        (target_p->sockhost[0] == '0' && target_p->sockhost[1] == '\0'))
2041 <      strlcpy(lhost, target_p->host, HOSTLEN*4 + 1);
1314 >    if (parc == 0 || EmptyString(*parv))
1315 >      aline->reason = default_reason;
1316      else
1317 <      strlcpy(lhost, target_p->sockhost, HOSTLEN*4 + 1);
2044 <    return 1;
1317 >      aline->reason = *parv;
1318    }
1319  
1320 <  return 0;
2048 < }
2049 <
2050 < /* valid_comment()
2051 < *
2052 < * inputs       - pointer to client
2053 < *              - pointer to comment
2054 < * output       - 0 if no valid comment,
2055 < *              - 1 if valid
2056 < * side effects - truncates reason where necessary
2057 < */
2058 < int
2059 < valid_comment(struct Client *source_p, char *comment, int warn)
2060 < {
2061 <  if (strlen(comment) > REASONLEN)
2062 <    comment[REASONLEN-1] = '\0';
2063 <
2064 <  return 1;
1320 >  return true;
1321   }
1322  
1323   /* match_conf_password()
# Line 2071 | Line 1327 | valid_comment(struct Client *source_p, c
1327   * output       - 1 or 0 if match
1328   * side effects - none
1329   */
1330 < int
1330 > bool
1331   match_conf_password(const char *password, const struct MaskItem *conf)
1332   {
1333    const char *encr = NULL;
1334  
1335    if (EmptyString(password) || EmptyString(conf->passwd))
1336 <    return 0;
1336 >    return false;
1337  
1338    if (conf->flags & CONF_FLAGS_ENCRYPTED)
1339      encr = crypt(password, conf->passwd);
1340    else
1341      encr = password;
1342  
1343 <  return encr && !strcmp(encr, conf->passwd);
2088 < }
2089 <
2090 < /*
2091 < * cluster_a_line
2092 < *
2093 < * inputs       - client sending the cluster
2094 < *              - command name "KLINE" "XLINE" etc.
2095 < *              - capab -- CAP_KLN etc. from server.h
2096 < *              - cluster type -- CLUSTER_KLINE etc. from conf.h
2097 < *              - pattern and args to send along
2098 < * output       - none
2099 < * side effects - Take source_p send the pattern with args given
2100 < *                along to all servers that match capab and cluster type
2101 < */
2102 < void
2103 < cluster_a_line(struct Client *source_p, const char *command,
2104 <               int capab, int cluster_type, const char *pattern, ...)
2105 < {
2106 <  va_list args;
2107 <  char buffer[IRCD_BUFSIZE];
2108 <  const dlink_node *ptr = NULL;
2109 <
2110 <  va_start(args, pattern);
2111 <  vsnprintf(buffer, sizeof(buffer), pattern, args);
2112 <  va_end(args);
2113 <
2114 <  DLINK_FOREACH(ptr, cluster_items.head)
2115 <  {
2116 <    const struct MaskItem *conf = ptr->data;
2117 <
2118 <    if (conf->flags & cluster_type)
2119 <      sendto_match_servs(source_p, conf->name, CAP_CLUSTER|capab,
2120 <                         "%s %s %s", command, conf->name, buffer);
2121 <  }
1343 >  return encr && strcmp(encr, conf->passwd) == 0;
1344   }
1345  
1346   /*
# Line 2156 | Line 1378 | split_nuh(struct split_nuh_item *const i
1378  
1379    if (iptr->nickptr)
1380      strlcpy(iptr->nickptr, "*", iptr->nicksize);
1381 +
1382    if (iptr->userptr)
1383      strlcpy(iptr->userptr, "*", iptr->usersize);
1384 +
1385    if (iptr->hostptr)
1386      strlcpy(iptr->hostptr, "*", iptr->hostsize);
1387  
# Line 2165 | Line 1389 | split_nuh(struct split_nuh_item *const i
1389    {
1390      *p = '\0';
1391  
1392 <    if (iptr->nickptr && *iptr->nuhmask != '\0')
1392 >    if (iptr->nickptr && *iptr->nuhmask)
1393        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
1394  
1395      if ((q = strchr(++p, '@')))
1396      {
1397        *q++ = '\0';
1398  
1399 <      if (*p != '\0')
1399 >      if (*p)
1400          strlcpy(iptr->userptr, p, iptr->usersize);
1401  
1402 <      if (*q != '\0')
1402 >      if (*q)
1403          strlcpy(iptr->hostptr, q, iptr->hostsize);
1404      }
1405      else
1406      {
1407 <      if (*p != '\0')
1407 >      if (*p)
1408          strlcpy(iptr->userptr, p, iptr->usersize);
1409      }
1410    }
# Line 2192 | Line 1416 | split_nuh(struct split_nuh_item *const i
1416        /* if found a @ */
1417        *p++ = '\0';
1418  
1419 <      if (*iptr->nuhmask != '\0')
1419 >      if (*iptr->nuhmask)
1420          strlcpy(iptr->userptr, iptr->nuhmask, iptr->usersize);
1421  
1422 <      if (*p != '\0')
1422 >      if (*p)
1423          strlcpy(iptr->hostptr, p, iptr->hostsize);
1424      }
1425      else
1426      {
1427 <      /* no @ found */
1428 <      if (!iptr->nickptr || strpbrk(iptr->nuhmask, ".:"))
1427 >      /* No @ found */
1428 >      if (iptr->nickptr == NULL || strpbrk(iptr->nuhmask, ".:"))
1429          strlcpy(iptr->hostptr, iptr->nuhmask, iptr->hostsize);
1430        else
1431          strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);

Comparing ircd-hybrid/trunk/src/conf.c (property svn:keywords):
Revision 3347 by michael, Sun Apr 20 14:03:06 2014 UTC vs.
Revision 9553 by michael, Sun Jul 26 07:35:07 2020 UTC

# Line 1 | Line 1
1 < Id Revision
1 > Id

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)