ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/conf.c (file contents):
Revision 3347 by michael, Sun Apr 20 14:03:06 2014 UTC vs.
Revision 6700 by michael, Thu Oct 29 13:12:04 2015 UTC

# Line 1 | Line 1
1   /*
2   *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (c) 1997-2014 ircd-hybrid development team
4 > *  Copyright (c) 1997-2015 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
# Line 28 | Line 28
28   #include "list.h"
29   #include "ircd_defs.h"
30   #include "conf.h"
31 + #include "conf_pseudo.h"
32   #include "server.h"
33   #include "resv.h"
34   #include "channel.h"
# Line 44 | Line 45
45   #include "log.h"
46   #include "send.h"
47   #include "memory.h"
47 – #include "mempool.h"
48   #include "res.h"
49   #include "userhost.h"
50   #include "user.h"
# Line 54 | Line 54
54   #include "conf_db.h"
55   #include "conf_class.h"
56   #include "motd.h"
57 + #include "ipcache.h"
58 + #include "isupport.h"
59  
60  
61   struct config_channel_entry ConfigChannel;
62 < struct config_server_hide ConfigServerHide;
63 < struct config_file_entry ConfigFileEntry;
64 < struct logging_entry ConfigLoggingEntry = { .use_logging = 1 };
65 < struct server_info ServerInfo;
66 < struct admin_info AdminInfo;
62 > struct config_serverhide_entry ConfigServerHide;
63 > struct config_general_entry ConfigGeneral;
64 > struct config_log_entry ConfigLog = { .use_logging = 1 };
65 > struct config_serverinfo_entry ConfigServerInfo;
66 > struct config_admin_entry ConfigAdminInfo;
67 > struct conf_parser_context conf_parser_ctx;
68  
69   /* general conf items link list root, other than k lines etc. */
70 < dlink_list service_items = { NULL, NULL, 0 };
71 < dlink_list server_items  = { NULL, NULL, 0 };
72 < dlink_list cluster_items = { NULL, NULL, 0 };
73 < dlink_list oconf_items   = { NULL, NULL, 0 };
74 < dlink_list uconf_items   = { NULL, NULL, 0 };
75 < dlink_list xconf_items   = { NULL, NULL, 0 };
76 < dlink_list nresv_items   = { NULL, NULL, 0 };
77 < dlink_list cresv_items = { NULL, NULL, 0 };
70 > dlink_list service_items;
71 > dlink_list server_items;
72 > dlink_list cluster_items;
73 > dlink_list operator_items;
74 > dlink_list shared_items;
75 > dlink_list xconf_items;
76 > dlink_list nresv_items;
77 > dlink_list cresv_items;
78  
79   extern unsigned int lineno;
80   extern char linebuf[];
81   extern char conffilebuf[IRCD_BUFSIZE];
82   extern int yyparse(); /* defined in y.tab.c */
83  
81 – struct conf_parser_context conf_parser_ctx = { 0, 0, NULL };
82 –
83 – /* internally defined functions */
84 – static void read_conf(FILE *);
85 – static void clear_out_old_conf(void);
86 – static void expire_tklines(dlink_list *);
87 – static void garbage_collect_ip_entries(void);
88 – static int hash_ip(struct irc_ssaddr *);
89 – static int verify_access(struct Client *);
90 – static int attach_iline(struct Client *, struct MaskItem *);
91 – static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
92 – static dlink_list *map_to_list(enum maskitem_type);
93 – static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
94 –
95 –
96 – /* usually, with hash tables, you use a prime number...
97 – * but in this case I am dealing with ip addresses,
98 – * not ascii strings.
99 – */
100 – #define IP_HASH_SIZE 0x1000
101 –
102 – struct ip_entry
103 – {
104 –  struct irc_ssaddr ip;
105 –  unsigned int count;
106 –  time_t last_attempt;
107 –  struct ip_entry *next;
108 – };
109 –
110 – static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
111 – static mp_pool_t *ip_entry_pool = NULL;
112 – static int ip_entries_count = 0;
113 –
84  
85   /* conf_dns_callback()
86   *
# Line 123 | Line 93 | static int ip_entries_count = 0;
93   * if successful save hp in the conf item it was called with
94   */
95   static void
96 < conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
96 > conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name, size_t namelength)
97   {
98 <  struct MaskItem *conf = vptr;
98 >  struct MaskItem *const conf = vptr;
99  
100    conf->dns_pending = 0;
101  
# Line 144 | Line 114 | conf_dns_callback(void *vptr, const stru
114   static void
115   conf_dns_lookup(struct MaskItem *conf)
116   {
117 <  if (!conf->dns_pending)
117 >  if (conf->dns_pending)
118 >    return;
119 >
120 >  conf->dns_pending = 1;
121 >
122 >  if (conf->aftype == AF_INET)
123 >    gethost_byname_type(conf_dns_callback, conf, conf->host, T_A);
124 >  else
125 >    gethost_byname_type(conf_dns_callback, conf, conf->host, T_AAAA);
126 > }
127 >
128 > /* map_to_list()
129 > *
130 > * inputs       - ConfType conf
131 > * output       - pointer to dlink_list to use
132 > * side effects - none
133 > */
134 > static dlink_list *
135 > map_to_list(enum maskitem_type type)
136 > {
137 >  switch (type)
138    {
139 <    conf->dns_pending = 1;
140 <    gethost_byname(conf_dns_callback, conf, conf->host);
139 >    case CONF_XLINE:
140 >      return &xconf_items;
141 >      break;
142 >    case CONF_SHARED:
143 >      return &shared_items;
144 >      break;
145 >    case CONF_NRESV:
146 >      return &nresv_items;
147 >      break;
148 >    case CONF_CRESV:
149 >      return &cresv_items;
150 >      break;
151 >    case CONF_OPER:
152 >      return &operator_items;
153 >      break;
154 >    case CONF_SERVER:
155 >      return &server_items;
156 >      break;
157 >    case CONF_SERVICE:
158 >      return &service_items;
159 >      break;
160 >    case CONF_CLUSTER:
161 >      return &cluster_items;
162 >      break;
163 >    default:
164 >      return NULL;
165    }
166   }
167  
168   struct MaskItem *
169   conf_make(enum maskitem_type type)
170   {
171 <  struct MaskItem *conf = MyMalloc(sizeof(*conf));
171 >  struct MaskItem *const conf = MyCalloc(sizeof(*conf));
172    dlink_list *list = NULL;
173  
174    conf->type   = type;
# Line 169 | Line 183 | conf_make(enum maskitem_type type)
183   void
184   conf_free(struct MaskItem *conf)
185   {
186 <  dlink_node *ptr = NULL, *ptr_next = NULL;
186 >  dlink_node *node = NULL, *node_next = NULL;
187    dlink_list *list = NULL;
188  
189 <  if (conf->node.next)
190 <    if ((list = map_to_list(conf->type)))
177 <      dlinkDelete(&conf->node, list);
189 >  if ((list = map_to_list(conf->type)))
190 >    dlinkFindDelete(list, conf);
191  
192    MyFree(conf->name);
193  
# Line 191 | Line 204 | conf_free(struct MaskItem *conf)
204    MyFree(conf->spasswd);
205    MyFree(conf->reason);
206    MyFree(conf->certfp);
207 +  MyFree(conf->whois);
208    MyFree(conf->user);
209    MyFree(conf->host);
210   #ifdef HAVE_LIBCRYPTO
# Line 199 | Line 213 | conf_free(struct MaskItem *conf)
213    if (conf->rsa_public_key)
214      RSA_free(conf->rsa_public_key);
215   #endif
216 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->hub_list.head)
216 >  DLINK_FOREACH_SAFE(node, node_next, conf->hub_list.head)
217    {
218 <    MyFree(ptr->data);
219 <    dlinkDelete(ptr, &conf->hub_list);
220 <    free_dlink_node(ptr);
218 >    MyFree(node->data);
219 >    dlinkDelete(node, &conf->hub_list);
220 >    free_dlink_node(node);
221    }
222  
223 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->leaf_list.head)
223 >  DLINK_FOREACH_SAFE(node, node_next, conf->leaf_list.head)
224    {
225 <    MyFree(ptr->data);
226 <    dlinkDelete(ptr, &conf->leaf_list);
227 <    free_dlink_node(ptr);
225 >    MyFree(node->data);
226 >    dlinkDelete(node, &conf->leaf_list);
227 >    free_dlink_node(node);
228    }
229  
230 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->exempt_list.head)
230 >  DLINK_FOREACH_SAFE(node, node_next, conf->exempt_list.head)
231    {
232 <    struct exempt *exptr = ptr->data;
232 >    struct exempt *exptr = node->data;
233  
234 <    dlinkDelete(ptr, &conf->exempt_list);
234 >    dlinkDelete(node, &conf->exempt_list);
235      MyFree(exptr->name);
236      MyFree(exptr->user);
237      MyFree(exptr->host);
# Line 227 | Line 241 | conf_free(struct MaskItem *conf)
241    MyFree(conf);
242   }
243  
230 – /* check_client()
231 – *
232 – * inputs       - pointer to client
233 – * output       - 0 = Success
234 – *                NOT_AUTHORIZED    (-1) = Access denied (no I line match)
235 – *                IRCD_SOCKET_ERROR (-2) = Bad socket.
236 – *                I_LINE_FULL       (-3) = I-line is full
237 – *                TOO_MANY          (-4) = Too many connections from hostname
238 – *                BANNED_CLIENT     (-5) = K-lined
239 – * side effects - Ordinary client access check.
240 – *                Look for conf lines which have the same
241 – *                status as the flags passed.
242 – */
243 – int
244 – check_client(struct Client *source_p)
245 – {
246 –  int i;
247 –
248 –  if ((i = verify_access(source_p)))
249 –    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
250 –         source_p->name, source_p->sockhost);
251 –
252 –  switch (i)
253 –  {
254 –    case TOO_MANY:
255 –      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
256 –                           "Too many on IP for %s (%s).",
257 –                           get_client_name(source_p, SHOW_IP),
258 –                           source_p->sockhost);
259 –      ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
260 –           get_client_name(source_p, SHOW_IP));
261 –      ++ServerStats.is_ref;
262 –      exit_client(source_p, "No more connections allowed on that IP");
263 –      break;
264 –
265 –    case I_LINE_FULL:
266 –      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
267 –                           "auth{} block is full for %s (%s).",
268 –                           get_client_name(source_p, SHOW_IP),
269 –                           source_p->sockhost);
270 –      ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
271 –           get_client_name(source_p, SHOW_IP));
272 –      ++ServerStats.is_ref;
273 –      exit_client(source_p, "No more connections allowed in your connection class");
274 –      break;
275 –
276 –    case NOT_AUTHORIZED:
277 –      ++ServerStats.is_ref;
278 –      /* jdc - lists server name & port connections are on */
279 –      /*       a purely cosmetical change */
280 –      sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
281 –                           "Unauthorized client connection from %s [%s] on [%s/%u].",
282 –                           get_client_name(source_p, SHOW_IP),
283 –                           source_p->sockhost,
284 –                           source_p->localClient->listener->name,
285 –                           source_p->localClient->listener->port);
286 –      ilog(LOG_TYPE_IRCD,
287 –           "Unauthorized client connection from %s on [%s/%u].",
288 –           get_client_name(source_p, SHOW_IP),
289 –           source_p->localClient->listener->name,
290 –           source_p->localClient->listener->port);
291 –
292 –      exit_client(source_p, "You are not authorized to use this server");
293 –      break;
294 –
295 –   case BANNED_CLIENT:
296 –     exit_client(source_p, "Banned");
297 –     ++ServerStats.is_ref;
298 –     break;
299 –
300 –   case 0:
301 –   default:
302 –     break;
303 –  }
304 –
305 –  return (i < 0 ? 0 : 1);
306 – }
307 –
308 – /* verify_access()
309 – *
310 – * inputs       - pointer to client to verify
311 – * output       - 0 if success -'ve if not
312 – * side effect  - find the first (best) I line to attach.
313 – */
314 – static int
315 – verify_access(struct Client *client_p)
316 – {
317 –  struct MaskItem *conf = NULL;
318 –  char non_ident[USERLEN + 1] = "~";
319 –
320 –  if (IsGotId(client_p))
321 –  {
322 –    conf = find_address_conf(client_p->host, client_p->username,
323 –                             &client_p->localClient->ip,
324 –                             client_p->localClient->aftype,
325 –                             client_p->localClient->passwd);
326 –  }
327 –  else
328 –  {
329 –    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
330 –    conf = find_address_conf(client_p->host,non_ident,
331 –                             &client_p->localClient->ip,
332 –                             client_p->localClient->aftype,
333 –                             client_p->localClient->passwd);
334 –  }
335 –
336 –  if (conf)
337 –  {
338 –    if (IsConfClient(conf))
339 –    {
340 –      if (IsConfRedir(conf))
341 –      {
342 –        sendto_one_numeric(client_p, &me, RPL_REDIR,
343 –                           conf->name ? conf->name : "",
344 –                           conf->port);
345 –        return NOT_AUTHORIZED;
346 –      }
347 –
348 –      if (IsConfDoIdentd(conf))
349 –        SetNeedId(client_p);
350 –
351 –      /* Thanks for spoof idea amm */
352 –      if (IsConfDoSpoofIp(conf))
353 –      {
354 –        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
355 –          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
356 –                               "%s spoofing: %s as %s",
357 –                               client_p->name, client_p->host, conf->name);
358 –        strlcpy(client_p->host, conf->name, sizeof(client_p->host));
359 –        AddFlag(client_p, FLAGS_IP_SPOOFING | FLAGS_AUTH_SPOOF);
360 –      }
361 –
362 –      return attach_iline(client_p, conf);
363 –    }
364 –    else if (IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
365 –    {
366 –      if (IsConfGline(conf))
367 –        sendto_one_notice(client_p, &me, ":*** G-lined");
368 –      sendto_one_notice(client_p, &me, ":*** Banned: %s", conf->reason);
369 –      return BANNED_CLIENT;
370 –    }
371 –  }
372 –
373 –  return NOT_AUTHORIZED;
374 – }
375 –
244   /* attach_iline()
245   *
246 < * inputs       - client pointer
247 < *              - conf pointer
248 < * output       -
249 < * side effects - do actual attach
246 > * inputs       - client pointer
247 > *              - conf pointer
248 > * output       -
249 > * side effects - do actual attach
250   */
251   static int
252   attach_iline(struct Client *client_p, struct MaskItem *conf)
253   {
254 <  struct ClassItem *class = NULL;
254 >  const struct ClassItem *const class = conf->class;
255    struct ip_entry *ip_found;
256    int a_limit_reached = 0;
257    unsigned int local = 0, global = 0, ident = 0;
258  
259 <  assert(conf->class);
392 <
393 <  ip_found = find_or_add_ip(&client_p->localClient->ip);
259 >  ip_found = ipcache_find_or_add_address(&client_p->connection->ip);
260    ip_found->count++;
261 <  SetIpHash(client_p);
396 <
397 <  class = conf->class;
261 >  AddFlag(client_p, FLAGS_IPHASH);
262  
263 <  count_user_host(client_p->username, client_p->host,
264 <                  &global, &local, &ident);
263 >  userhost_count(client_p->username, client_p->host,
264 >                 &global, &local, &ident);
265  
266    /* XXX blah. go down checking the various silly limits
267     * setting a_limit_reached if any limit is reached.
268     * - Dianora
269     */
270 <  if (class->max_total != 0 && class->ref_count >= class->max_total)
270 >  if (class->max_total && class->ref_count >= class->max_total)
271      a_limit_reached = 1;
272 <  else if (class->max_perip != 0 && ip_found->count > class->max_perip)
272 >  else if (class->max_perip && ip_found->count > class->max_perip)
273      a_limit_reached = 1;
274 <  else if (class->max_local != 0 && local >= class->max_local)
274 >  else if (class->max_local && local >= class->max_local)
275      a_limit_reached = 1;
276 <  else if (class->max_global != 0 && global >= class->max_global)
276 >  else if (class->max_global && global >= class->max_global)
277      a_limit_reached = 1;
278 <  else if (class->max_ident != 0 && ident >= class->max_ident &&
278 >  else if (class->max_ident && ident >= class->max_ident &&
279             client_p->username[0] != '~')
280      a_limit_reached = 1;
281  
# Line 427 | Line 291 | attach_iline(struct Client *client_p, st
291    return attach_conf(client_p, conf);
292   }
293  
294 < /* init_ip_hash_table()
431 < *
432 < * inputs               - NONE
433 < * output               - NONE
434 < * side effects         - allocate memory for ip_entry(s)
435 < *                      - clear the ip hash table
436 < */
437 < void
438 < init_ip_hash_table(void)
439 < {
440 <  ip_entry_pool = mp_pool_new(sizeof(struct ip_entry), MP_CHUNK_SIZE_IP_ENTRY);
441 <  memset(ip_hash_table, 0, sizeof(ip_hash_table));
442 < }
443 <
444 < /* find_or_add_ip()
445 < *
446 < * inputs       - pointer to struct irc_ssaddr
447 < * output       - pointer to a struct ip_entry
448 < * side effects -
294 > /* verify_access()
295   *
296 < * If the ip # was not found, a new struct ip_entry is created, and the ip
297 < * count set to 0.
296 > * inputs       - pointer to client to verify
297 > * output       - 0 if success -'ve if not
298 > * side effect  - find the first (best) I line to attach.
299   */
300 < static struct ip_entry *
301 < find_or_add_ip(struct irc_ssaddr *ip_in)
300 > static int
301 > verify_access(struct Client *client_p)
302   {
303 <  struct ip_entry *ptr, *newptr;
457 <  int hash_index = hash_ip(ip_in), res;
458 <  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
459 < #ifdef IPV6
460 <  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
461 < #endif
303 >  struct MaskItem *conf = NULL;
304  
305 <  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
305 >  if (HasFlag(client_p, FLAGS_GOTID))
306    {
307 < #ifdef IPV6
308 <    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
309 <      continue;
310 <    if (ip_in->ss.ss_family == AF_INET6)
469 <    {
470 <      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
471 <      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
472 <    }
473 <    else
474 < #endif
475 <    {
476 <      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
477 <      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
478 <    }
479 <    if (res == 0)
480 <    {
481 <      /* Found entry already in hash, return it. */
482 <      return ptr;
483 <    }
307 >    conf = find_address_conf(client_p->host, client_p->username,
308 >                             &client_p->connection->ip,
309 >                             client_p->connection->aftype,
310 >                             client_p->connection->password);
311    }
312 +  else
313 +  {
314 +    char non_ident[USERLEN + 1] = "~";
315  
316 <  if (ip_entries_count >= 2 * hard_fdlimit)
317 <    garbage_collect_ip_entries();
318 <
319 <  newptr = mp_pool_get(ip_entry_pool);
320 <  memset(newptr, 0, sizeof(*newptr));
321 <  ip_entries_count++;
492 <  memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
493 <
494 <  newptr->next = ip_hash_table[hash_index];
495 <  ip_hash_table[hash_index] = newptr;
316 >    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
317 >    conf = find_address_conf(client_p->host, non_ident,
318 >                             &client_p->connection->ip,
319 >                             client_p->connection->aftype,
320 >                             client_p->connection->password);
321 >  }
322  
323 <  return newptr;
324 < }
323 >  if (!conf)
324 >    return NOT_AUTHORIZED;
325  
326 < /* remove_one_ip()
501 < *
502 < * inputs        - unsigned long IP address value
503 < * output        - NONE
504 < * side effects  - The ip address given, is looked up in ip hash table
505 < *                 and number of ip#'s for that ip decremented.
506 < *                 If ip # count reaches 0 and has expired,
507 < *                 the struct ip_entry is returned to the ip_entry_heap
508 < */
509 < void
510 < remove_one_ip(struct irc_ssaddr *ip_in)
511 < {
512 <  struct ip_entry *ptr;
513 <  struct ip_entry *last_ptr = NULL;
514 <  int hash_index = hash_ip(ip_in), res;
515 <  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
516 < #ifdef IPV6
517 <  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
518 < #endif
326 >  assert(IsConfClient(conf) || IsConfKill(conf));
327  
328 <  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
328 >  if (IsConfClient(conf))
329    {
330 < #ifdef IPV6
523 <    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
524 <      continue;
525 <    if (ip_in->ss.ss_family == AF_INET6)
526 <    {
527 <      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
528 <      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
529 <    }
530 <    else
531 < #endif
330 >    if (IsConfRedir(conf))
331      {
332 <      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
333 <      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
332 >      sendto_one_numeric(client_p, &me, RPL_REDIR,
333 >                         conf->name ? conf->name : "",
334 >                         conf->port);
335 >      return NOT_AUTHORIZED;
336      }
337 <    if (res)
338 <      continue;
538 <    if (ptr->count > 0)
539 <      ptr->count--;
540 <    if (ptr->count == 0 &&
541 <        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
337 >
338 >    if (IsConfDoSpoofIp(conf))
339      {
340 <      if (last_ptr != NULL)
341 <        last_ptr->next = ptr->next;
342 <      else
546 <        ip_hash_table[hash_index] = ptr->next;
340 >      if (IsConfSpoofNotice(conf))
341 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE, "%s spoofing: %s as %s",
342 >                             client_p->name, client_p->host, conf->name);
343  
344 <      mp_pool_release(ptr);
549 <      ip_entries_count--;
550 <      return;
344 >      strlcpy(client_p->host, conf->name, sizeof(client_p->host));
345      }
552 –    last_ptr = ptr;
553 –  }
554 – }
346  
347 < /* hash_ip()
557 < *
558 < * input        - pointer to an irc_inaddr
559 < * output       - integer value used as index into hash table
560 < * side effects - hopefully, none
561 < */
562 < static int
563 < hash_ip(struct irc_ssaddr *addr)
564 < {
565 <  if (addr->ss.ss_family == AF_INET)
566 <  {
567 <    struct sockaddr_in *v4 = (struct sockaddr_in *)addr;
568 <    int hash;
569 <    uint32_t ip;
570 <
571 <    ip   = ntohl(v4->sin_addr.s_addr);
572 <    hash = ((ip >> 12) + ip) & (IP_HASH_SIZE-1);
573 <    return hash;
347 >    return attach_iline(client_p, conf);
348    }
349 < #ifdef IPV6
350 <  else
351 <  {
578 <    int hash;
579 <    struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)addr;
580 <    uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
581 <
582 <    hash  = ip[0] ^ ip[3];
583 <    hash ^= hash >> 16;
584 <    hash ^= hash >> 8;
585 <    hash  = hash & (IP_HASH_SIZE - 1);
586 <    return hash;
587 <  }
588 < #else
589 <  return 0;
590 < #endif
349 >
350 >  sendto_one_notice(client_p, &me, ":*** Banned: %s", conf->reason);
351 >  return BANNED_CLIENT;
352   }
353  
354 < /* count_ip_hash()
594 < *
595 < * inputs        - pointer to counter of number of ips hashed
596 < *               - pointer to memory used for ip hash
597 < * output        - returned via pointers input
598 < * side effects  - NONE
354 > /* check_client()
355   *
356 < * number of hashed ip #'s is counted up, plus the amount of memory
357 < * used in the hash.
356 > * inputs       - pointer to client
357 > * output       - 0 = Success
358 > *                NOT_AUTHORIZED    (-1) = Access denied (no I line match)
359 > *                IRCD_SOCKET_ERROR (-2) = Bad socket.
360 > *                I_LINE_FULL       (-3) = I-line is full
361 > *                TOO_MANY          (-4) = Too many connections from hostname
362 > *                BANNED_CLIENT     (-5) = K-lined
363 > * side effects - Ordinary client access check.
364 > *                Look for conf lines which have the same
365 > *                status as the flags passed.
366   */
367 < void
368 < count_ip_hash(unsigned int *number_ips_stored, uint64_t *mem_ips_stored)
367 > int
368 > check_client(struct Client *source_p)
369   {
606 –  struct ip_entry *ptr;
370    int i;
371  
372 <  *number_ips_stored = 0;
373 <  *mem_ips_stored    = 0;
372 >  if ((i = verify_access(source_p)))
373 >    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
374 >         source_p->name, source_p->sockhost);
375  
376 <  for (i = 0; i < IP_HASH_SIZE; i++)
376 >  switch (i)
377    {
378 <    for (ptr = ip_hash_table[i]; ptr; ptr = ptr->next)
379 <    {
380 <      *number_ips_stored += 1;
381 <      *mem_ips_stored += sizeof(struct ip_entry);
382 <    }
383 <  }
384 < }
378 >    case TOO_MANY:
379 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
380 >                           "Too many on IP for %s (%s).",
381 >                           get_client_name(source_p, SHOW_IP),
382 >                           source_p->sockhost);
383 >      ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
384 >           get_client_name(source_p, SHOW_IP));
385 >      ++ServerStats.is_ref;
386 >      exit_client(source_p, "No more connections allowed on that IP");
387 >      break;
388  
389 < /* garbage_collect_ip_entries()
390 < *
391 < * input        - NONE
392 < * output       - NONE
393 < * side effects - free up all ip entries with no connections
394 < */
395 < static void
396 < garbage_collect_ip_entries(void)
397 < {
398 <  struct ip_entry *ptr;
632 <  struct ip_entry *last_ptr;
633 <  struct ip_entry *next_ptr;
634 <  int i;
389 >    case I_LINE_FULL:
390 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
391 >                           "auth {} block is full for %s (%s).",
392 >                           get_client_name(source_p, SHOW_IP),
393 >                           source_p->sockhost);
394 >      ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
395 >           get_client_name(source_p, SHOW_IP));
396 >      ++ServerStats.is_ref;
397 >      exit_client(source_p, "No more connections allowed in your connection class");
398 >      break;
399  
400 <  for (i = 0; i < IP_HASH_SIZE; i++)
401 <  {
402 <    last_ptr = NULL;
400 >    case NOT_AUTHORIZED:
401 >      /* jdc - lists server name & port connections are on */
402 >      /*       a purely cosmetical change */
403 >      sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
404 >                           "Unauthorized client connection from %s [%s] on [%s/%u].",
405 >                           get_client_name(source_p, SHOW_IP),
406 >                           source_p->sockhost,
407 >                           source_p->connection->listener->name,
408 >                           source_p->connection->listener->port);
409 >      ilog(LOG_TYPE_IRCD, "Unauthorized client connection from %s on [%s/%u].",
410 >           get_client_name(source_p, SHOW_IP),
411 >           source_p->connection->listener->name,
412 >           source_p->connection->listener->port);
413  
414 <    for (ptr = ip_hash_table[i]; ptr; ptr = next_ptr)
415 <    {
416 <      next_ptr = ptr->next;
414 >      ++ServerStats.is_ref;
415 >      exit_client(source_p, "You are not authorized to use this server");
416 >      break;
417  
418 <      if (ptr->count == 0 &&
419 <          (CurrentTime - ptr->last_attempt) >= ConfigFileEntry.throttle_time)
420 <      {
421 <        if (last_ptr != NULL)
422 <          last_ptr->next = ptr->next;
423 <        else
424 <          ip_hash_table[i] = ptr->next;
425 <        mp_pool_release(ptr);
652 <        ip_entries_count--;
653 <      }
654 <      else
655 <        last_ptr = ptr;
656 <    }
418 >    case BANNED_CLIENT:
419 >      ++ServerStats.is_ref;
420 >      exit_client(source_p, "Banned");
421 >      break;
422 >
423 >    case 0:
424 >    default:
425 >      break;
426    }
427 +
428 +  return !(i < 0);
429   }
430  
431   /* detach_conf()
# Line 668 | Line 439 | garbage_collect_ip_entries(void)
439   void
440   detach_conf(struct Client *client_p, enum maskitem_type type)
441   {
442 <  dlink_node *ptr = NULL, *ptr_next = NULL;
442 >  dlink_node *node = NULL, *node_next = NULL;
443  
444 <  DLINK_FOREACH_SAFE(ptr, ptr_next, client_p->localClient->confs.head)
444 >  DLINK_FOREACH_SAFE(node, node_next, client_p->connection->confs.head)
445    {
446 <    struct MaskItem *conf = ptr->data;
446 >    struct MaskItem *conf = node->data;
447  
448      assert(conf->type & (CONF_CLIENT | CONF_OPER | CONF_SERVER));
449      assert(conf->ref_count > 0);
# Line 681 | Line 452 | detach_conf(struct Client *client_p, enu
452      if (!(conf->type & type))
453        continue;
454  
455 <    dlinkDelete(ptr, &client_p->localClient->confs);
456 <    free_dlink_node(ptr);
455 >    dlinkDelete(node, &client_p->connection->confs);
456 >    free_dlink_node(node);
457  
458      if (conf->type == CONF_CLIENT)
459 <      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
459 >      remove_from_cidr_check(&client_p->connection->ip, conf->class);
460  
461      if (--conf->class->ref_count == 0 && conf->class->active == 0)
462      {
# Line 711 | Line 482 | detach_conf(struct Client *client_p, enu
482   int
483   attach_conf(struct Client *client_p, struct MaskItem *conf)
484   {
485 <  if (dlinkFind(&client_p->localClient->confs, conf))
485 >  if (dlinkFind(&client_p->connection->confs, conf))
486      return 1;
487  
488    if (conf->type == CONF_CLIENT)
489      if (cidr_limit_reached(IsConfExemptLimits(conf),
490 <                           &client_p->localClient->ip, conf->class))
490 >                           &client_p->connection->ip, conf->class))
491        return TOO_MANY;    /* Already at maximum allowed */
492  
493    conf->class->ref_count++;
494    conf->ref_count++;
495  
496 <  dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
496 >  dlinkAdd(conf, make_dlink_node(), &client_p->connection->confs);
497  
498    return 0;
499   }
# Line 739 | Line 510 | int
510   attach_connect_block(struct Client *client_p, const char *name,
511                       const char *host)
512   {
513 <  dlink_node *ptr;
743 <  struct MaskItem *conf = NULL;
513 >  dlink_node *node = NULL;
514  
515 <  assert(client_p != NULL);
746 <  assert(host != NULL);
747 <
748 <  if (client_p == NULL || host == NULL)
749 <    return 0;
515 >  assert(host);
516  
517 <  DLINK_FOREACH(ptr, server_items.head)
517 >  DLINK_FOREACH(node, server_items.head)
518    {
519 <    conf = ptr->data;
519 >    struct MaskItem *conf = node->data;
520  
521      if (match(conf->name, name) || match(conf->host, host))
522        continue;
523  
524      attach_conf(client_p, conf);
525 <    return -1;
525 >    return 1;
526    }
527  
528    return 0;
# Line 774 | Line 540 | attach_connect_block(struct Client *clie
540   struct MaskItem *
541   find_conf_name(dlink_list *list, const char *name, enum maskitem_type type)
542   {
543 <  dlink_node *ptr;
778 <  struct MaskItem* conf;
543 >  dlink_node *node = NULL;
544  
545 <  DLINK_FOREACH(ptr, list->head)
545 >  DLINK_FOREACH(node, list->head)
546    {
547 <    conf = ptr->data;
547 >    struct MaskItem *conf = node->data;
548  
549      if (conf->type == type)
550      {
551 <      if (conf->name && (irccmp(conf->name, name) == 0 ||
552 <                         !match(conf->name, name)))
788 <      return conf;
551 >      if (conf->name && !irccmp(conf->name, name))
552 >        return conf;
553      }
554    }
555  
556    return NULL;
557   }
558  
795 – /* map_to_list()
796 – *
797 – * inputs       - ConfType conf
798 – * output       - pointer to dlink_list to use
799 – * side effects - none
800 – */
801 – static dlink_list *
802 – map_to_list(enum maskitem_type type)
803 – {
804 –  switch(type)
805 –  {
806 –  case CONF_XLINE:
807 –    return(&xconf_items);
808 –    break;
809 –  case CONF_ULINE:
810 –    return(&uconf_items);
811 –    break;
812 –  case CONF_NRESV:
813 –    return(&nresv_items);
814 –    break;
815 –  case CONF_CRESV:
816 –    return(&cresv_items);
817 –  case CONF_OPER:
818 –    return(&oconf_items);
819 –    break;
820 –  case CONF_SERVER:
821 –    return(&server_items);
822 –    break;
823 –  case CONF_SERVICE:
824 –    return(&service_items);
825 –    break;
826 –  case CONF_CLUSTER:
827 –    return(&cluster_items);
828 –    break;
829 –  default:
830 –    return NULL;
831 –  }
832 – }
833 –
559   /* find_matching_name_conf()
560   *
561   * inputs       - type of link list to look in
# Line 845 | Line 570 | struct MaskItem *
570   find_matching_name_conf(enum maskitem_type type, const char *name, const char *user,
571                          const char *host, unsigned int flags)
572   {
573 <  dlink_node *ptr=NULL;
574 <  struct MaskItem *conf=NULL;
575 <  dlink_list *list_p = map_to_list(type);
573 >  dlink_node *node = NULL;
574 >  dlink_list *list = map_to_list(type);
575 >  struct MaskItem *conf = NULL;
576  
577    switch (type)
578    {
579    case CONF_SERVICE:
580 <    DLINK_FOREACH(ptr, list_p->head)
580 >    DLINK_FOREACH(node, list->head)
581      {
582 <      conf = ptr->data;
582 >      conf = node->data;
583  
584        if (EmptyString(conf->name))
585          continue;
586 <      if ((name != NULL) && !irccmp(name, conf->name))
586 >      if (name && !irccmp(name, conf->name))
587          return conf;
588      }
589      break;
590  
591    case CONF_XLINE:
592 <  case CONF_ULINE:
592 >  case CONF_SHARED:
593    case CONF_NRESV:
594    case CONF_CRESV:
595 <    DLINK_FOREACH(ptr, list_p->head)
595 >    DLINK_FOREACH(node, list->head)
596      {
597 <      conf = ptr->data;
597 >      conf = node->data;
598  
599        if (EmptyString(conf->name))
600          continue;
601 <      if ((name != NULL) && !match(conf->name, name))
601 >      if (name && !match(conf->name, name))
602        {
603          if ((user == NULL && (host == NULL)))
604            return conf;
# Line 888 | Line 613 | find_matching_name_conf(enum maskitem_ty
613        break;
614  
615    case CONF_SERVER:
616 <    DLINK_FOREACH(ptr, list_p->head)
616 >    DLINK_FOREACH(node, list->head)
617      {
618 <      conf = ptr->data;
618 >      conf = node->data;
619  
620 <      if ((name != NULL) && !match(name, conf->name))
620 >      if (name && !match(name, conf->name))
621          return conf;
622 <      else if ((host != NULL) && !match(host, conf->host))
622 >      if (host && !match(host, conf->host))
623          return conf;
624      }
625      break;
# Line 918 | Line 643 | struct MaskItem *
643   find_exact_name_conf(enum maskitem_type type, const struct Client *who, const char *name,
644                       const char *user, const char *host)
645   {
646 <  dlink_node *ptr = NULL;
647 <  struct MaskItem *conf;
648 <  dlink_list *list_p = map_to_list(type);
646 >  dlink_node *node = NULL;
647 >  dlink_list *list = map_to_list(type);
648 >  struct MaskItem *conf = NULL;
649  
650    switch(type)
651    {
652    case CONF_XLINE:
653 <  case CONF_ULINE:
653 >  case CONF_SHARED:
654    case CONF_NRESV:
655    case CONF_CRESV:
656  
657 <    DLINK_FOREACH(ptr, list_p->head)
657 >    DLINK_FOREACH(node, list->head)
658      {
659 <      conf = ptr->data;
659 >      conf = node->data;
660  
661        if (EmptyString(conf->name))
662          continue;
# Line 949 | Line 674 | find_exact_name_conf(enum maskitem_type
674      break;
675  
676    case CONF_OPER:
677 <    DLINK_FOREACH(ptr, list_p->head)
677 >    DLINK_FOREACH(node, list->head)
678      {
679 <      conf = ptr->data;
679 >      conf = node->data;
680  
681        if (EmptyString(conf->name))
682          continue;
# Line 972 | Line 697 | find_exact_name_conf(enum maskitem_type
697                    return conf;
698                break;
699              case HM_IPV4:
700 <              if (who->localClient->aftype == AF_INET)
701 <                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
700 >              if (who->connection->aftype == AF_INET)
701 >                if (match_ipv4(&who->connection->ip, &conf->addr, conf->bits))
702                    if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
703                      return conf;
704                break;
980 – #ifdef IPV6
705              case HM_IPV6:
706 <              if (who->localClient->aftype == AF_INET6)
707 <                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
706 >              if (who->connection->aftype == AF_INET6)
707 >                if (match_ipv6(&who->connection->ip, &conf->addr, conf->bits))
708                    if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
709                      return conf;
710                break;
987 – #endif
711              default:
712                assert(0);
713            }
# Line 995 | Line 718 | find_exact_name_conf(enum maskitem_type
718      break;
719  
720    case CONF_SERVER:
721 <    DLINK_FOREACH(ptr, list_p->head)
721 >    DLINK_FOREACH(node, list->head)
722      {
723 <      conf = ptr->data;
723 >      conf = node->data;
724  
725        if (EmptyString(conf->name))
726          continue;
# Line 1022 | Line 745 | find_exact_name_conf(enum maskitem_type
745    return NULL;
746   }
747  
1025 – /* rehash()
1026 – *
1027 – * Actual REHASH service routine. Called with sig == 0 if it has been called
1028 – * as a result of an operator issuing this command, else assume it has been
1029 – * called as a result of the server receiving a HUP signal.
1030 – */
1031 – int
1032 – rehash(int sig)
1033 – {
1034 –  if (sig)
1035 –    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1036 –                         "Got signal SIGHUP, reloading configuration file(s)");
1037 –
1038 –  restart_resolver();
1039 –
1040 –  /* don't close listeners until we know we can go ahead with the rehash */
1041 –
1042 –  /* Check to see if we magically got(or lost) IPv6 support */
1043 –  check_can_use_v6();
1044 –
1045 –  read_conf_files(0);
1046 –
1047 –  if (ServerInfo.description)
1048 –    strlcpy(me.info, ServerInfo.description, sizeof(me.info));
1049 –
1050 –  load_conf_modules();
1051 –
1052 –  rehashed_klines = 1;
1053 –
1054 –  return 0;
1055 – }
1056 –
748   /* set_default_conf()
749   *
750   * inputs       - NONE
# Line 1072 | Line 763 | set_default_conf(void)
763    assert(class_default == class_get_list()->tail->data);
764  
765   #ifdef HAVE_LIBCRYPTO
766 <  ServerInfo.rsa_private_key = NULL;
767 <  ServerInfo.rsa_private_key_file = NULL;
766 > #if OPENSSL_VERSION_NUMBER >= 0x009080FFL && !defined(OPENSSL_NO_ECDH)
767 >  {
768 >    EC_KEY *key = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
769 >
770 >    if (key)
771 >    {
772 >      SSL_CTX_set_tmp_ecdh(ConfigServerInfo.server_ctx, key);
773 >      EC_KEY_free(key);
774 >    }
775 >  }
776 >
777 >  SSL_CTX_set_options(ConfigServerInfo.server_ctx, SSL_OP_SINGLE_ECDH_USE);
778   #endif
779  
780 <  /* ServerInfo.name is not rehashable */
781 <  /* ServerInfo.name = ServerInfo.name; */
782 <  ServerInfo.description = NULL;
783 <  ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
784 <  ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
785 <
786 <  memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
787 <  ServerInfo.specific_ipv4_vhost = 0;
788 <  memset(&ServerInfo.ip6, 0, sizeof(ServerInfo.ip6));
789 <  ServerInfo.specific_ipv6_vhost = 0;
790 <
791 <  ServerInfo.max_clients = MAXCLIENTS_MAX;
792 <  ServerInfo.max_nick_length = 9;
793 <  ServerInfo.max_topic_length = 80;
794 <
795 <  ServerInfo.hub = 0;
1095 <  ServerInfo.dns_host.sin_addr.s_addr = 0;
1096 <  ServerInfo.dns_host.sin_port = 0;
1097 <  AdminInfo.name = NULL;
1098 <  AdminInfo.email = NULL;
1099 <  AdminInfo.description = NULL;
780 >  SSL_CTX_set_cipher_list(ConfigServerInfo.server_ctx, "EECDH+HIGH:EDH+HIGH:HIGH:!aNULL");
781 >  ConfigServerInfo.message_digest_algorithm = EVP_sha256();
782 > #endif
783 >
784 >  ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
785 >  ConfigServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
786 >
787 >  memset(&ConfigServerInfo.ip, 0, sizeof(ConfigServerInfo.ip));
788 >  ConfigServerInfo.specific_ipv4_vhost = 0;
789 >  memset(&ConfigServerInfo.ip6, 0, sizeof(ConfigServerInfo.ip6));
790 >  ConfigServerInfo.specific_ipv6_vhost = 0;
791 >
792 >  ConfigServerInfo.default_max_clients = MAXCLIENTS_MAX;
793 >  ConfigServerInfo.max_nick_length = 9;
794 >  ConfigServerInfo.max_topic_length = 80;
795 >  ConfigServerInfo.hub = 0;
796  
797    log_del_all();
798  
799 <  ConfigLoggingEntry.use_logging = 1;
799 >  ConfigLog.use_logging = 1;
800  
801    ConfigChannel.disable_fake_channels = 0;
802 <  ConfigChannel.knock_delay = 300;
802 >  ConfigChannel.invite_client_count = 10;
803 >  ConfigChannel.invite_client_time = 300;
804 >  ConfigChannel.knock_client_count = 1;
805 >  ConfigChannel.knock_client_time = 300;
806    ConfigChannel.knock_delay_channel = 60;
807 <  ConfigChannel.max_chans_per_user = 25;
1109 <  ConfigChannel.max_chans_per_oper = 50;
807 >  ConfigChannel.max_channels = 25;
808    ConfigChannel.max_bans = 25;
809 <  ConfigChannel.default_split_user_count = 0;
810 <  ConfigChannel.default_split_server_count = 0;
1113 <  ConfigChannel.no_join_on_split = 0;
1114 <  ConfigChannel.no_create_on_split = 0;
809 >  ConfigChannel.default_join_flood_count = 18;
810 >  ConfigChannel.default_join_flood_time = 6;
811  
812    ConfigServerHide.flatten_links = 0;
813 <  ConfigServerHide.links_delay = 300;
813 >  ConfigServerHide.flatten_links_delay = 300;
814    ConfigServerHide.hidden = 0;
815    ConfigServerHide.hide_servers = 0;
816    ConfigServerHide.hide_services = 0;
# Line 1122 | Line 818 | set_default_conf(void)
818    ConfigServerHide.hide_server_ips = 0;
819    ConfigServerHide.disable_remote_commands = 0;
820  
821 <  ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
822 <  ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
823 <  ConfigFileEntry.cycle_on_host_change = 1;
824 <  ConfigFileEntry.glines = 0;
825 <  ConfigFileEntry.gline_time = 12 * 3600;
826 <  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
827 <  ConfigFileEntry.gline_min_cidr = 16;
828 <  ConfigFileEntry.gline_min_cidr6 = 48;
829 <  ConfigFileEntry.invisible_on_connect = 1;
830 <  ConfigFileEntry.tkline_expire_notices = 1;
831 <  ConfigFileEntry.hide_spoof_ips = 1;
832 <  ConfigFileEntry.ignore_bogus_ts = 0;
833 <  ConfigFileEntry.disable_auth = 0;
834 <  ConfigFileEntry.kill_chase_time_limit = 90;
835 <  ConfigFileEntry.default_floodcount = 8;
836 <  ConfigFileEntry.failed_oper_notice = 1;
837 <  ConfigFileEntry.dots_in_ident = 0;
838 <  ConfigFileEntry.min_nonwildcard = 4;
839 <  ConfigFileEntry.min_nonwildcard_simple = 3;
840 <  ConfigFileEntry.max_accept = 20;
841 <  ConfigFileEntry.anti_nick_flood = 0;
842 <  ConfigFileEntry.max_nick_time = 20;
843 <  ConfigFileEntry.max_nick_changes = 5;
844 <  ConfigFileEntry.anti_spam_exit_message_time = 0;
845 <  ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
846 <  ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
847 <  ConfigFileEntry.warn_no_nline = 1;
848 <  ConfigFileEntry.stats_o_oper_only = 0;
849 <  ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
850 <  ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
851 <  ConfigFileEntry.stats_P_oper_only = 0;
852 <  ConfigFileEntry.stats_u_oper_only = 0;
853 <  ConfigFileEntry.caller_id_wait = 60;
854 <  ConfigFileEntry.opers_bypass_callerid = 0;
855 <  ConfigFileEntry.pace_wait = 10;
856 <  ConfigFileEntry.pace_wait_simple = 1;
857 <  ConfigFileEntry.short_motd = 0;
858 <  ConfigFileEntry.ping_cookie = 0;
859 <  ConfigFileEntry.no_oper_flood = 0;
860 <  ConfigFileEntry.true_no_oper_flood = 0;
861 <  ConfigFileEntry.oper_pass_resv = 1;
862 <  ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
863 <  ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
864 <  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
865 <    UMODE_OPERWALL | UMODE_WALLOP;
866 <  ConfigFileEntry.use_egd = 0;
867 <  ConfigFileEntry.egdpool_path = NULL;
1172 <  ConfigFileEntry.throttle_time = 10;
821 >  ConfigGeneral.away_count = 2;
822 >  ConfigGeneral.away_time = 10;
823 >  ConfigGeneral.max_watch = WATCHSIZE_DEFAULT;
824 >  ConfigGeneral.cycle_on_host_change = 1;
825 >  ConfigGeneral.dline_min_cidr = 16;
826 >  ConfigGeneral.dline_min_cidr6 = 48;
827 >  ConfigGeneral.kline_min_cidr = 16;
828 >  ConfigGeneral.kline_min_cidr6 = 48;
829 >  ConfigGeneral.invisible_on_connect = 1;
830 >  ConfigGeneral.tkline_expire_notices = 1;
831 >  ConfigGeneral.ignore_bogus_ts = 0;
832 >  ConfigGeneral.disable_auth = 0;
833 >  ConfigGeneral.kill_chase_time_limit = 90;
834 >  ConfigGeneral.default_floodcount = 8;
835 >  ConfigGeneral.failed_oper_notice = 1;
836 >  ConfigGeneral.dots_in_ident = 0;
837 >  ConfigGeneral.min_nonwildcard = 4;
838 >  ConfigGeneral.min_nonwildcard_simple = 3;
839 >  ConfigGeneral.max_accept = 20;
840 >  ConfigGeneral.anti_nick_flood = 0;
841 >  ConfigGeneral.max_nick_time = 20;
842 >  ConfigGeneral.max_nick_changes = 5;
843 >  ConfigGeneral.anti_spam_exit_message_time = 0;
844 >  ConfigGeneral.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
845 >  ConfigGeneral.ts_max_delta = TS_MAX_DELTA_DEFAULT;
846 >  ConfigGeneral.warn_no_connect_block = 1;
847 >  ConfigGeneral.stats_e_disabled = 0;
848 >  ConfigGeneral.stats_i_oper_only = 1;  /* 1 = masked */
849 >  ConfigGeneral.stats_k_oper_only = 1;  /* 1 = masked */
850 >  ConfigGeneral.stats_o_oper_only = 1;
851 >  ConfigGeneral.stats_m_oper_only = 1;
852 >  ConfigGeneral.stats_P_oper_only = 0;
853 >  ConfigGeneral.stats_u_oper_only = 0;
854 >  ConfigGeneral.caller_id_wait = 60;
855 >  ConfigGeneral.opers_bypass_callerid = 0;
856 >  ConfigGeneral.pace_wait = 10;
857 >  ConfigGeneral.pace_wait_simple = 1;
858 >  ConfigGeneral.short_motd = 0;
859 >  ConfigGeneral.ping_cookie = 0;
860 >  ConfigGeneral.no_oper_flood = 0;
861 >  ConfigGeneral.max_targets = MAX_TARGETS_DEFAULT;
862 >  ConfigGeneral.oper_only_umodes = UMODE_DEBUG | UMODE_LOCOPS | UMODE_HIDDEN | UMODE_FARCONNECT |
863 >                                   UMODE_UNAUTH | UMODE_EXTERNAL | UMODE_BOTS | UMODE_NCHANGE |
864 >                                   UMODE_SPY | UMODE_FULL | UMODE_SKILL | UMODE_REJ | UMODE_CCONN;
865 >  ConfigGeneral.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE | UMODE_WALLOP;
866 >  ConfigGeneral.throttle_count = 1;
867 >  ConfigGeneral.throttle_time = 1;
868   }
869  
870   static void
871   validate_conf(void)
872   {
873 <  if (ConfigFileEntry.ts_warn_delta < TS_WARN_DELTA_MIN)
874 <    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
873 >  if (ConfigGeneral.ts_warn_delta < TS_WARN_DELTA_MIN)
874 >    ConfigGeneral.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
875  
876 <  if (ConfigFileEntry.ts_max_delta < TS_MAX_DELTA_MIN)
877 <    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
876 >  if (ConfigGeneral.ts_max_delta < TS_MAX_DELTA_MIN)
877 >    ConfigGeneral.ts_max_delta = TS_MAX_DELTA_DEFAULT;
878  
879 <  if (ServerInfo.network_name == NULL)
880 <    ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
879 >  if (EmptyString(ConfigServerInfo.network_name))
880 >    ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
881  
882 <  if (ServerInfo.network_desc == NULL)
883 <    ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
882 >  if (EmptyString(ConfigServerInfo.network_desc))
883 >    ConfigServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
884  
885 <  if (ConfigFileEntry.service_name == NULL)
1191 <    ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1192 <
1193 <  ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
885 >  ConfigGeneral.max_watch = IRCD_MAX(ConfigGeneral.max_watch, WATCHSIZE_MIN);
886   }
887  
888   /* read_conf()
# Line 1204 | Line 896 | read_conf(FILE *file)
896   {
897    lineno = 0;
898  
899 <  set_default_conf(); /* Set default values prior to conf parsing */
899 >  set_default_conf();  /* Set default values prior to conf parsing */
900    conf_parser_ctx.pass = 1;
901 <  yyparse();          /* pick up the classes first */
901 >  yyparse();  /* Pick up the classes first */
902  
903    rewind(file);
904  
905    conf_parser_ctx.pass = 2;
906 <  yyparse();          /* Load the values from the conf */
907 <  validate_conf();    /* Check to make sure some values are still okay. */
908 <                      /* Some global values are also loaded here. */
909 <  class_delete_marked();      /* Make sure classes are valid */
906 >  yyparse();  /* Load the values from the conf */
907 >  validate_conf();  /* Check to make sure some values are still okay. */
908 >                    /* Some global values are also loaded here. */
909 >  class_delete_marked();  /* Delete unused classes that are marked for deletion */
910 > }
911 >
912 > /* conf_rehash()
913 > *
914 > * Actual REHASH service routine. Called with sig == 0 if it has been called
915 > * as a result of an operator issuing this command, else assume it has been
916 > * called as a result of the server receiving a HUP signal.
917 > */
918 > void
919 > conf_rehash(int sig)
920 > {
921 >  if (sig)
922 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
923 >                         "Got signal SIGHUP, reloading configuration file(s)");
924 >
925 >  restart_resolver();
926 >
927 >  /* don't close listeners until we know we can go ahead with the rehash */
928 >
929 >  read_conf_files(0);
930 >
931 >  load_conf_modules();
932 >  check_conf_klines();
933   }
934  
935   /* lookup_confhost()
# Line 1227 | Line 942 | lookup_confhost(struct MaskItem *conf)
942   {
943    struct addrinfo hints, *res;
944  
945 <  /* Do name lookup now on hostnames given and store the
945 >  /*
946 >   * Do name lookup now on hostnames given and store the
947     * ip numbers in conf structure.
948     */
949    memset(&hints, 0, sizeof(hints));
# Line 1263 | Line 979 | lookup_confhost(struct MaskItem *conf)
979   int
980   conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
981   {
982 <  struct ip_entry *ip_found;
983 <  struct MaskItem *conf = find_dline_conf(addr, aftype);
1268 <
1269 <  /* DLINE exempt also gets you out of static limits/pacing... */
1270 <  if (conf && (conf->type == CONF_EXEMPT))
1271 <    return 0;
982 >  struct ip_entry *ip_found = NULL;
983 >  const struct MaskItem *conf = find_dline_conf(addr, aftype);
984  
985    if (conf)
986 +  {
987 +    /* DLINE exempt also gets you out of static limits/pacing... */
988 +    if (conf->type == CONF_EXEMPT)
989 +      return 0;
990      return BANNED_CLIENT;
991 +  }
992  
993 <  ip_found = find_or_add_ip(addr);
993 >  ip_found = ipcache_find_or_add_address(addr);
994  
995 <  if ((CurrentTime - ip_found->last_attempt) <
1279 <      ConfigFileEntry.throttle_time)
995 >  if ((CurrentTime - ip_found->last_attempt) < ConfigGeneral.throttle_time)
996    {
997 <    ip_found->last_attempt = CurrentTime;
998 <    return TOO_FAST;
997 >    if (ip_found->connection_count >= ConfigGeneral.throttle_count)
998 >      return TOO_FAST;
999 >
1000 >    ++ip_found->connection_count;
1001    }
1002 +  else
1003 +    ip_found->connection_count = 1;
1004  
1005    ip_found->last_attempt = CurrentTime;
1006    return 0;
1007   }
1008  
1289 – /* cleanup_tklines()
1290 – *
1291 – * inputs       - NONE
1292 – * output       - NONE
1293 – * side effects - call function to expire temporary k/d lines
1294 – *                This is an event started off in ircd.c
1295 – */
1296 – void
1297 – cleanup_tklines(void *notused)
1298 – {
1299 –  hostmask_expire_temporary();
1300 –  expire_tklines(&xconf_items);
1301 –  expire_tklines(&nresv_items);
1302 –  expire_tklines(&cresv_items);
1303 – }
1304 –
1009   /* expire_tklines()
1010   *
1011   * inputs       - tkline list pointer
# Line 1309 | Line 1013 | cleanup_tklines(void *notused)
1013   * side effects - expire tklines
1014   */
1015   static void
1016 < expire_tklines(dlink_list *tklist)
1016 > expire_tklines(dlink_list *list)
1017   {
1018 <  dlink_node *ptr = NULL, *ptr_next = NULL;
1315 <  struct MaskItem *conf = NULL;
1018 >  dlink_node *node = NULL, *node_next = NULL;
1019  
1020 <  DLINK_FOREACH_SAFE(ptr, ptr_next, tklist->head)
1020 >  DLINK_FOREACH_SAFE(node, node_next, list->head)
1021    {
1022 <    conf = ptr->data;
1022 >    struct MaskItem *conf = node->data;
1023  
1024      if (!conf->until || conf->until > CurrentTime)
1025        continue;
1026  
1027 <    if (conf->type == CONF_XLINE)
1028 <    {
1029 <      if (ConfigFileEntry.tkline_expire_notices)
1030 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1328 <                               "Temporary X-line for [%s] expired", conf->name);
1329 <      conf_free(conf);
1330 <    }
1331 <    else if (conf->type == CONF_NRESV || conf->type == CONF_CRESV)
1332 <    {
1333 <      if (ConfigFileEntry.tkline_expire_notices)
1334 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1335 <                               "Temporary RESV for [%s] expired", conf->name);
1336 <      conf_free(conf);
1337 <    }
1027 >    if (ConfigGeneral.tkline_expire_notices)
1028 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE, "Temporary %s for [%s] expired",
1029 >                           (conf->type == CONF_XLINE) ? "X-line" : "RESV", conf->name);
1030 >    conf_free(conf);
1031    }
1032   }
1033  
1034 + /* cleanup_tklines()
1035 + *
1036 + * inputs       - NONE
1037 + * output       - NONE
1038 + * side effects - call function to expire temporary k/d lines
1039 + *                This is an event started off in ircd.c
1040 + */
1041 + void
1042 + cleanup_tklines(void *unused)
1043 + {
1044 +  hostmask_expire_temporary();
1045 +  expire_tklines(&xconf_items);
1046 +  expire_tklines(&nresv_items);
1047 +  expire_tklines(&cresv_items);
1048 + }
1049 +
1050   /* oper_privs_as_string()
1051   *
1052   * inputs        - pointer to client_p
# Line 1350 | Line 1059 | static const struct oper_privs
1059    const unsigned char c;
1060   } flag_list[] = {
1061    { OPER_FLAG_ADMIN,          'A' },
1062 <  { OPER_FLAG_REMOTEBAN,      'B' },
1063 <  { OPER_FLAG_DIE,            'D' },
1064 <  { OPER_FLAG_GLINE,          'G' },
1065 <  { OPER_FLAG_REHASH,         'H' },
1066 <  { OPER_FLAG_K,              'K' },
1067 <  { OPER_FLAG_OPERWALL,       'L' },
1068 <  { OPER_FLAG_KILL,           'N' },
1069 <  { OPER_FLAG_KILL_REMOTE,    'O' },
1070 <  { OPER_FLAG_CONNECT,        'P' },
1071 <  { OPER_FLAG_CONNECT_REMOTE, 'Q' },
1072 <  { OPER_FLAG_SQUIT,          'R' },
1073 <  { OPER_FLAG_SQUIT_REMOTE,   'S' },
1074 <  { OPER_FLAG_UNKLINE,        'U' },
1075 <  { OPER_FLAG_XLINE,          'X' },
1062 >  { OPER_FLAG_CLOSE,          'B' },
1063 >  { OPER_FLAG_CONNECT,        'C' },
1064 >  { OPER_FLAG_CONNECT_REMOTE, 'D' },
1065 >  { OPER_FLAG_DIE,            'E' },
1066 >  { OPER_FLAG_DLINE,          'F' },
1067 >  { OPER_FLAG_GLOBOPS,        'G' },
1068 >  { OPER_FLAG_JOIN_RESV,      'H' },
1069 >  { OPER_FLAG_KILL,           'I' },
1070 >  { OPER_FLAG_KILL_REMOTE,    'J' },
1071 >  { OPER_FLAG_KLINE,          'K' },
1072 >  { OPER_FLAG_LOCOPS,         'L' },
1073 >  { OPER_FLAG_MODULE,         'M' },
1074 >  { OPER_FLAG_NICK_RESV,      'N' },
1075 >  { OPER_FLAG_OPME,           'O' },
1076 >  { OPER_FLAG_REHASH,         'P' },
1077 >  { OPER_FLAG_REMOTEBAN,      'Q' },
1078 >  { OPER_FLAG_RESTART,        'R' },
1079 >  { OPER_FLAG_RESV,           'S' },
1080 >  { OPER_FLAG_SET,            'T' },
1081 >  { OPER_FLAG_SQUIT,          'U' },
1082 >  { OPER_FLAG_SQUIT_REMOTE,   'V' },
1083 >  { OPER_FLAG_UNDLINE,        'W' },
1084 >  { OPER_FLAG_UNKLINE,        'X' },
1085 >  { OPER_FLAG_UNRESV,         'Y' },
1086 >  { OPER_FLAG_UNXLINE,        'Z' },
1087 >  { OPER_FLAG_WALLOPS,        'a' },
1088 >  { OPER_FLAG_XLINE,          'b' },
1089    { 0, '\0' }
1090   };
1091  
1092 < char *
1092 > const char *
1093   oper_privs_as_string(const unsigned int port)
1094   {
1095    static char privs_out[IRCD_BUFSIZE];
1096    char *privs_ptr = privs_out;
1097  
1098    for (const struct oper_privs *opriv = flag_list; opriv->flag; ++opriv)
1377 –  {
1099      if (port & opriv->flag)
1100        *privs_ptr++ = opriv->c;
1101 <    else
1102 <      *privs_ptr++ = ToLower(opriv->c);
1103 <  }
1101 >
1102 >  if (privs_ptr == privs_out)
1103 >    *privs_ptr++ = '0';
1104  
1105    *privs_ptr = '\0';
1106  
# Line 1387 | Line 1108 | oper_privs_as_string(const unsigned int
1108   }
1109  
1110   /*
1111 < * Input: A client to find the active oper{} name for.
1111 > * Input: A client to find the active operator {} name for.
1112   * Output: The nick!user@host{oper} of the oper.
1113   *         "oper" is server name for remote opers
1114   * Side effects: None.
# Line 1395 | Line 1116 | oper_privs_as_string(const unsigned int
1116   const char *
1117   get_oper_name(const struct Client *client_p)
1118   {
1119 <  const dlink_node *cnode = NULL;
1120 <  /* +5 for !,@,{,} and null */
1121 <  static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
1119 >  static char buffer[IRCD_BUFSIZE];
1120 >
1121 >  if (IsServer(client_p))
1122 >    return client_p->name;
1123  
1124    if (MyConnect(client_p))
1125    {
1126 <    if ((cnode = client_p->localClient->confs.head))
1126 >    const dlink_node *const node = client_p->connection->confs.head;
1127 >
1128 >    if (node)
1129      {
1130 <      const struct MaskItem *conf = cnode->data;
1130 >      const struct MaskItem *const conf = node->data;
1131  
1132 <      if (IsConfOperator(conf))
1132 >      if (conf->type == CONF_OPER)
1133        {
1134          snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1135                   client_p->username, client_p->host, conf->name);
# Line 1413 | Line 1137 | get_oper_name(const struct Client *clien
1137        }
1138      }
1139  
1140 <    /* Probably should assert here for now. If there is an oper out there
1141 <     * with no oper{} conf attached, it would be good for us to know...
1140 >    /*
1141 >     * Probably should assert here for now. If there is an oper out there
1142 >     * with no operator {} conf attached, it would be good for us to know...
1143       */
1144 <    assert(0); /* Oper without oper conf! */
1144 >    assert(0);  /* Oper without oper conf! */
1145    }
1146  
1147    snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
# Line 1424 | Line 1149 | get_oper_name(const struct Client *clien
1149    return buffer;
1150   }
1151  
1152 + /* clear_out_old_conf()
1153 + *
1154 + * inputs       - none
1155 + * output       - none
1156 + * side effects - Clear out the old configuration
1157 + */
1158 + static void
1159 + clear_out_old_conf(void)
1160 + {
1161 +  dlink_node *node = NULL, *node_next = NULL;
1162 +  dlink_list *free_items [] = {
1163 +    &server_items,   &operator_items,
1164 +     &shared_items,   &xconf_items,
1165 +     &nresv_items, &cluster_items,  &service_items, &cresv_items, NULL
1166 +  };
1167 +
1168 +  dlink_list ** iterator = free_items; /* C is dumb */
1169 +
1170 +  /* We only need to free anything allocated by yyparse() here.
1171 +   * Resetting structs, etc, is taken care of by set_default_conf().
1172 +   */
1173 +
1174 +  for (; *iterator; iterator++)
1175 +  {
1176 +    DLINK_FOREACH_SAFE(node, node_next, (*iterator)->head)
1177 +    {
1178 +      struct MaskItem *conf = node->data;
1179 +
1180 +      conf->active = 0;
1181 +
1182 +      if (!IsConfDatabase(conf))
1183 +      {
1184 +        dlinkDelete(&conf->node, *iterator);
1185 +
1186 +        if (!conf->ref_count)
1187 +          conf_free(conf);
1188 +      }
1189 +    }
1190 +  }
1191 +
1192 +  motd_clear();
1193 +
1194 +  /*
1195 +   * Don't delete the class table, rather mark all entries for deletion.
1196 +   * The table is cleaned up by class_delete_marked. - avalon
1197 +   */
1198 +  class_mark_for_deletion();
1199 +
1200 +  clear_out_address_conf();
1201 +
1202 +  /* Clean out module paths */
1203 +  mod_clear_paths();
1204 +
1205 +  pseudo_clear();
1206 +
1207 +  /* Clean out ConfigServerInfo */
1208 +  MyFree(ConfigServerInfo.description);
1209 +  ConfigServerInfo.description = NULL;
1210 +  MyFree(ConfigServerInfo.network_name);
1211 +  ConfigServerInfo.network_name = NULL;
1212 +  MyFree(ConfigServerInfo.network_desc);
1213 +  ConfigServerInfo.network_desc = NULL;
1214 + #ifdef HAVE_LIBCRYPTO
1215 +  if (ConfigServerInfo.rsa_private_key)
1216 +  {
1217 +    RSA_free(ConfigServerInfo.rsa_private_key);
1218 +    ConfigServerInfo.rsa_private_key = NULL;
1219 +  }
1220 +
1221 +  MyFree(ConfigServerInfo.rsa_private_key_file);
1222 +  ConfigServerInfo.rsa_private_key_file = NULL;
1223 + #endif
1224 +
1225 +  /* Clean out ConfigAdminInfo */
1226 +  MyFree(ConfigAdminInfo.name);
1227 +  ConfigAdminInfo.name = NULL;
1228 +  MyFree(ConfigAdminInfo.email);
1229 +  ConfigAdminInfo.email = NULL;
1230 +  MyFree(ConfigAdminInfo.description);
1231 +  ConfigAdminInfo.description = NULL;
1232 +
1233 +  MyFree(ConfigServerHide.flatten_links_file);
1234 +  ConfigServerHide.flatten_links_file = NULL;
1235 +
1236 +  /* Clean out listeners */
1237 +  listener_close_marked();
1238 + }
1239 +
1240   /* read_conf_files()
1241   *
1242   * inputs       - cold start YES or NO
# Line 1433 | Line 1246 | get_oper_name(const struct Client *clien
1246   void
1247   read_conf_files(int cold)
1248   {
1249 <  const char *filename;
1250 <  char chanmodes[IRCD_BUFSIZE];
1251 <  char chanlimit[IRCD_BUFSIZE];
1249 >  const char *filename = NULL;
1250 >  char chanmodes[IRCD_BUFSIZE] = "";
1251 >  char chanlimit[IRCD_BUFSIZE] = "";
1252  
1253    conf_parser_ctx.boot = cold;
1254 <  filename = ConfigFileEntry.configfile;
1254 >  filename = ConfigGeneral.configfile;
1255  
1256    /* We need to know the initial filename for the yyerror() to report
1257       FIXME: The full path is in conffilenamebuf first time since we
1258 <             dont know anything else
1258 >             don't know anything else
1259  
1260       - Gozem 2002-07-21
1261    */
# Line 1454 | Line 1267 | read_conf_files(int cold)
1267      {
1268        ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
1269             filename, strerror(errno));
1270 <      exit(-1);
1270 >      exit(EXIT_FAILURE);
1271      }
1272      else
1273      {
1274 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1274 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1275                             "Unable to read configuration file '%s': %s",
1276                             filename, strerror(errno));
1277        return;
# Line 1473 | Line 1286 | read_conf_files(int cold)
1286  
1287    log_reopen_all();
1288  
1289 <  add_isupport("NICKLEN", NULL, ServerInfo.max_nick_length);
1290 <  add_isupport("NETWORK", ServerInfo.network_name, -1);
1289 >  isupport_add("NICKLEN", NULL, ConfigServerInfo.max_nick_length);
1290 >  isupport_add("NETWORK", ConfigServerInfo.network_name, -1);
1291  
1292    snprintf(chanmodes, sizeof(chanmodes), "beI:%d", ConfigChannel.max_bans);
1293 <  add_isupport("MAXLIST", chanmodes, -1);
1294 <  add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1295 <  add_isupport("CHANTYPES", "#", -1);
1293 >  isupport_add("MAXLIST", chanmodes, -1);
1294 >  isupport_add("MAXTARGETS", NULL, ConfigGeneral.max_targets);
1295 >  isupport_add("CHANTYPES", "#", -1);
1296  
1297    snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1298 <           ConfigChannel.max_chans_per_user);
1299 <  add_isupport("CHANLIMIT", chanlimit, -1);
1300 <  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,imnprstORS");
1301 <  add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
1302 <  add_isupport("TOPICLEN", NULL, ServerInfo.max_topic_length);
1303 <  add_isupport("CHANMODES", chanmodes, -1);
1298 >           ConfigChannel.max_channels);
1299 >  isupport_add("CHANLIMIT", chanlimit, -1);
1300 >  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,cimnprstCMORS");
1301 >  isupport_add("CHANNELLEN", NULL, CHANNELLEN);
1302 >  isupport_add("TOPICLEN", NULL, ConfigServerInfo.max_topic_length);
1303 >  isupport_add("CHANMODES", chanmodes, -1);
1304  
1305    /*
1306     * message_locale may have changed.  rebuild isupport since it relies
1307     * on strlen(form_str(RPL_ISUPPORT))
1308     */
1309 <  rebuild_isupport_message_line();
1497 < }
1498 <
1499 < /* clear_out_old_conf()
1500 < *
1501 < * inputs       - none
1502 < * output       - none
1503 < * side effects - Clear out the old configuration
1504 < */
1505 < static void
1506 < clear_out_old_conf(void)
1507 < {
1508 <  dlink_node *ptr = NULL, *next_ptr = NULL;
1509 <  struct MaskItem *conf;
1510 <  dlink_list *free_items [] = {
1511 <    &server_items,   &oconf_items,
1512 <     &uconf_items,   &xconf_items,
1513 <     &nresv_items, &cluster_items,  &service_items, &cresv_items, NULL
1514 <  };
1515 <
1516 <  dlink_list ** iterator = free_items; /* C is dumb */
1517 <
1518 <  /* We only need to free anything allocated by yyparse() here.
1519 <   * Resetting structs, etc, is taken care of by set_default_conf().
1520 <   */
1521 <
1522 <  for (; *iterator != NULL; iterator++)
1523 <  {
1524 <    DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
1525 <    {
1526 <      conf = ptr->data;
1527 <
1528 <      dlinkDelete(&conf->node, map_to_list(conf->type));
1529 <
1530 <      /* XXX This is less than pretty */
1531 <      if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
1532 <      {
1533 <        if (!conf->ref_count)
1534 <          conf_free(conf);
1535 <      }
1536 <      else if (conf->type == CONF_XLINE)
1537 <      {
1538 <        if (!conf->until)
1539 <          conf_free(conf);
1540 <      }
1541 <      else
1542 <        conf_free(conf);
1543 <    }
1544 <  }
1545 <
1546 <  motd_clear();
1547 <
1548 <  /*
1549 <   * don't delete the class table, rather mark all entries
1550 <   * for deletion. The table is cleaned up by class_delete_marked. - avalon
1551 <   */
1552 <  class_mark_for_deletion();
1553 <
1554 <  clear_out_address_conf();
1555 <
1556 <  /* clean out module paths */
1557 <  mod_clear_paths();
1558 <
1559 <  /* clean out ServerInfo */
1560 <  MyFree(ServerInfo.description);
1561 <  ServerInfo.description = NULL;
1562 <  MyFree(ServerInfo.network_name);
1563 <  ServerInfo.network_name = NULL;
1564 <  MyFree(ServerInfo.network_desc);
1565 <  ServerInfo.network_desc = NULL;
1566 <  MyFree(ConfigFileEntry.egdpool_path);
1567 <  ConfigFileEntry.egdpool_path = NULL;
1568 < #ifdef HAVE_LIBCRYPTO
1569 <  if (ServerInfo.rsa_private_key)
1570 <  {
1571 <    RSA_free(ServerInfo.rsa_private_key);
1572 <    ServerInfo.rsa_private_key = NULL;
1573 <  }
1574 <
1575 <  MyFree(ServerInfo.rsa_private_key_file);
1576 <  ServerInfo.rsa_private_key_file = NULL;
1577 <
1578 <  if (ServerInfo.server_ctx)
1579 <    SSL_CTX_set_options(ServerInfo.server_ctx, SSL_OP_NO_SSLv2|
1580 <                                               SSL_OP_NO_SSLv3|
1581 <                                               SSL_OP_NO_TLSv1);
1582 <  if (ServerInfo.client_ctx)
1583 <    SSL_CTX_set_options(ServerInfo.client_ctx, SSL_OP_NO_SSLv2|
1584 <                                               SSL_OP_NO_SSLv3|
1585 <                                               SSL_OP_NO_TLSv1);
1586 < #endif
1587 <
1588 <  /* clean out AdminInfo */
1589 <  MyFree(AdminInfo.name);
1590 <  AdminInfo.name = NULL;
1591 <  MyFree(AdminInfo.email);
1592 <  AdminInfo.email = NULL;
1593 <  MyFree(AdminInfo.description);
1594 <  AdminInfo.description = NULL;
1595 <
1596 <  /* clean out listeners */
1597 <  close_listeners();
1598 <
1599 <  /* clean out general */
1600 <  MyFree(ConfigFileEntry.service_name);
1601 <  ConfigFileEntry.service_name = NULL;
1309 >  isupport_rebuild();
1310   }
1311  
1312   /* conf_add_class_to_conf()
# Line 1608 | Line 1316 | clear_out_old_conf(void)
1316   * side effects - Add a class pointer to a conf
1317   */
1318   void
1319 < conf_add_class_to_conf(struct MaskItem *conf, const char *class_name)
1319 > conf_add_class_to_conf(struct MaskItem *conf, const char *name)
1320   {
1321 <  if (class_name == NULL)
1321 >  if (EmptyString(name) || (conf->class = class_find(name, 1)) == NULL)
1322    {
1323      conf->class = class_default;
1324  
1325 <    if (conf->type == CONF_CLIENT)
1326 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1325 >    if (conf->type == CONF_CLIENT || conf->type == CONF_OPER)
1326 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1327                             "Warning *** Defaulting to default class for %s@%s",
1328                             conf->user, conf->host);
1329      else
1330 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1330 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1331                             "Warning *** Defaulting to default class for %s",
1332                             conf->name);
1333    }
1626 –  else
1627 –    conf->class = class_find(class_name, 1);
1628 –
1629 –  if (conf->class == NULL)
1630 –  {
1631 –    if (conf->type == CONF_CLIENT)
1632 –      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1633 –                           "Warning *** Defaulting to default class for %s@%s",
1634 –                           conf->user, conf->host);
1635 –    else
1636 –      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1637 –                           "Warning *** Defaulting to default class for %s",
1638 –                           conf->name);
1639 –    conf->class = class_default;
1640 –  }
1334   }
1335  
1336   /* yyerror()
# Line 1655 | Line 1348 | yyerror(const char *msg)
1348      return;
1349  
1350    strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1351 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1351 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1352                         "\"%s\", line %u: %s: %s",
1353                         conffilebuf, lineno + 1, msg, newlinebuf);
1354    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
# Line 1668 | Line 1361 | conf_error_report(const char *msg)
1361    char newlinebuf[IRCD_BUFSIZE];
1362  
1363    strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1364 <  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1364 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1365                         "\"%s\", line %u: %s: %s",
1366                         conffilebuf, lineno + 1, msg, newlinebuf);
1367    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
# Line 1703 | Line 1396 | valid_tkline(const char *data, const int
1396  
1397    /*
1398     * In the degenerate case where oper does a /quote kline 0 user@host :reason
1399 <   * i.e. they specifically use 0, I am going to return 1 instead
1400 <   * as a return value of non-zero is used to flag it as a temporary kline
1399 >   * i.e. they specifically use 0, I am going to return 1 instead as a return
1400 >   * value of non-zero is used to flag it as a temporary kline
1401     */
1402    if (result == 0)
1403      result = 1;
# Line 1719 | Line 1412 | valid_tkline(const char *data, const int
1412    if (result > MAX_TDKLINE_TIME)
1413      result = MAX_TDKLINE_TIME;
1414  
1415 <  result = result * 60;  /* turn it into seconds */
1415 >  result = result * 60;  /* Turn it into seconds */
1416  
1417    return result;
1418   }
# Line 1735 | Line 1428 | valid_wild_card_simple(const char *data)
1428   {
1429    const unsigned char *p = (const unsigned char *)data;
1430    unsigned char tmpch = '\0';
1431 <  int nonwild = 0;
1431 >  unsigned int nonwild = 0, wild = 0;
1432  
1433    while ((tmpch = *p++))
1434    {
1435 <    if (tmpch == '\\')
1435 >    if (tmpch == '\\' && *p)
1436      {
1437        ++p;
1438 <      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1438 >      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1439          return 1;
1440      }
1441      else if (!IsMWildChar(tmpch))
1442      {
1443 <      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1443 >      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1444          return 1;
1445      }
1446 +    else
1447 +      ++wild;
1448    }
1449  
1450 <  return 0;
1450 >  return !wild;
1451   }
1452  
1453   /* valid_wild_card()
# Line 1764 | Line 1459 | valid_wild_card_simple(const char *data)
1459   * side effects - NOTICE is given to source_p if warn is 1
1460   */
1461   int
1462 < valid_wild_card(struct Client *source_p, int warn, int count, ...)
1462 > valid_wild_card(struct Client *source_p, int count, ...)
1463   {
1464 <  char tmpch;
1465 <  int nonwild = 0;
1464 >  unsigned char tmpch = '\0';
1465 >  unsigned int nonwild = 0;
1466    va_list args;
1467  
1468    /*
# Line 1786 | Line 1481 | valid_wild_card(struct Client *source_p,
1481  
1482    while (count--)
1483    {
1484 <    const char *p = va_arg(args, const char *);
1484 >    const unsigned char *p = va_arg(args, const unsigned char *);
1485      if (p == NULL)
1486        continue;
1487  
# Line 1798 | Line 1493 | valid_wild_card(struct Client *source_p,
1493           * If we find enough non-wild characters, we can
1494           * break - no point in searching further.
1495           */
1496 <        if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1496 >        if (++nonwild >= ConfigGeneral.min_nonwildcard)
1497          {
1498            va_end(args);
1499            return 1;
# Line 1807 | Line 1502 | valid_wild_card(struct Client *source_p,
1502      }
1503    }
1504  
1505 <  if (warn)
1505 >  if (IsClient(source_p))
1506      sendto_one_notice(source_p, &me,
1507 <                      ":Please include at least %d non-wildcard characters with the mask",
1508 <                      ConfigFileEntry.min_nonwildcard);
1507 >                      ":Please include at least %u non-wildcard characters with the mask",
1508 >                      ConfigGeneral.min_nonwildcard);
1509    va_end(args);
1510    return 0;
1511   }
1512  
1513 + /* find_user_host()
1514 + *
1515 + * inputs       - pointer to client placing kline
1516 + *              - pointer to user_host_or_nick
1517 + *              - pointer to user buffer
1518 + *              - pointer to host buffer
1519 + * output       - 0 if not ok to kline, 1 to kline i.e. if valid user host
1520 + * side effects -
1521 + */
1522 + static int
1523 + find_user_host(struct Client *source_p, char *user_host_or_nick,
1524 +               char *luser, char *lhost)
1525 + {
1526 +  struct Client *target_p = NULL;
1527 +  char *hostp = NULL;
1528 +
1529 +  if (lhost == NULL)
1530 +  {
1531 +    strlcpy(luser, user_host_or_nick, USERLEN*4 + 1);
1532 +    return 1;
1533 +  }
1534 +
1535 +  if ((hostp = strchr(user_host_or_nick, '@')) || *user_host_or_nick == '*')
1536 +  {
1537 +    /* Explicit user@host mask given */
1538 +    if (hostp)                            /* I'm a little user@host */
1539 +    {
1540 +      *(hostp++) = '\0';                       /* short and squat */
1541 +
1542 +      if (*user_host_or_nick)
1543 +        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1544 +      else
1545 +        strcpy(luser, "*");
1546 +
1547 +      if (*hostp)
1548 +        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
1549 +      else
1550 +        strcpy(lhost, "*");
1551 +    }
1552 +    else
1553 +    {
1554 +      luser[0] = '*';             /* no @ found, assume its *@somehost */
1555 +      luser[1] = '\0';
1556 +      strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
1557 +    }
1558 +
1559 +    return 1;
1560 +  }
1561 +  else
1562 +  {
1563 +    /* Try to find user@host mask from nick */
1564 +    /* Okay to use source_p as the first param, because source_p == client_p */
1565 +    if ((target_p =
1566 +        find_chasing(source_p, user_host_or_nick)) == NULL)
1567 +      return 0;  /* find_chasing sends ERR_NOSUCHNICK */
1568 +
1569 +    if (HasFlag(target_p, FLAGS_EXEMPTKLINE))
1570 +    {
1571 +      if (IsClient(source_p))
1572 +        sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
1573 +      return 0;
1574 +    }
1575 +
1576 +    /*
1577 +     * Turn the "user" bit into "*user", blow away '~'
1578 +     * if found in original user name (non-idented)
1579 +     */
1580 +    strlcpy(luser, target_p->username, USERLEN*4 + 1);
1581 +
1582 +    if (target_p->username[0] == '~')
1583 +      luser[0] = '*';
1584 +
1585 +    if (!strcmp(target_p->sockhost, "0"))
1586 +      strlcpy(lhost, target_p->host, HOSTLEN*4 + 1);
1587 +    else
1588 +      strlcpy(lhost, target_p->sockhost, HOSTLEN*4 + 1);
1589 +    return 1;
1590 +  }
1591 +
1592 +  return 0;
1593 + }
1594 +
1595   /* XXX should this go into a separate file ? -Dianora */
1596   /* parse_aline
1597   *
# Line 1829 | Line 1606 | valid_wild_card(struct Client *source_p,
1606   *              - pointer to target_server to parse into if non NULL
1607   *              - pointer to reason to parse into
1608   *
1609 < * output       - 1 if valid, -1 if not valid
1609 > * output       - 1 if valid, 0 if not valid
1610   * side effects - A generalised k/d/x etc. line parser,
1611   *               "ALINE [time] user@host|string [ON] target :reason"
1612   *                will parse returning a parsed user, host if
# Line 1852 | Line 1629 | parse_aline(const char *cmd, struct Clie
1629              char **target_server, char **reason)
1630   {
1631    int found_tkline_time=0;
1632 <  static char def_reason[] = "No Reason";
1632 >  static char default_reason[] = CONF_NOREASON;
1633    static char user[USERLEN*4+1];
1634    static char host[HOSTLEN*4+1];
1635  
# Line 1861 | Line 1638 | parse_aline(const char *cmd, struct Clie
1638  
1639    found_tkline_time = valid_tkline(*parv, TK_MINUTES);
1640  
1641 <  if (found_tkline_time != 0)
1641 >  if (found_tkline_time)
1642    {
1643      parv++;
1644      parc--;
1645  
1646 <    if (tkline_time != NULL)
1646 >    if (tkline_time)
1647        *tkline_time = found_tkline_time;
1648      else
1649      {
1650        sendto_one_notice(source_p, &me, ":temp_line not supported by %s", cmd);
1651 <      return -1;
1651 >      return 0;
1652      }
1653    }
1654  
1655    if (parc == 0)
1656    {
1657      sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1658 <    return -1;
1658 >    return 0;
1659    }
1660  
1661    if (h_p == NULL)
1662      *up_p = *parv;
1663    else
1664    {
1665 <    if (find_user_host(source_p, *parv, user, host, parse_flags) == 0)
1666 <      return -1;
1665 >    if (find_user_host(source_p, *parv, user, host) == 0)
1666 >      return 0;
1667  
1668      *up_p = user;
1669      *h_p = host;
# Line 1895 | Line 1672 | parse_aline(const char *cmd, struct Clie
1672    parc--;
1673    parv++;
1674  
1675 <  if (parc != 0)
1675 >  if (parc)
1676    {
1677      if (irccmp(*parv, "ON") == 0)
1678      {
1679        parc--;
1680        parv++;
1681  
1905 –      if (target_server == NULL)
1906 –      {
1907 –        sendto_one_notice(source_p, &me, ":ON server not supported by %s", cmd);
1908 –        return -1;
1909 –      }
1910 –
1682        if (!HasOFlag(source_p, OPER_FLAG_REMOTEBAN))
1683        {
1684          sendto_one_numeric(source_p, &me, ERR_NOPRIVS, "remoteban");
1685 <        return -1;
1685 >        return 0;
1686        }
1687  
1688        if (parc == 0 || EmptyString(*parv))
1689        {
1690          sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1691 <        return -1;
1691 >        return 0;
1692        }
1693  
1694        *target_server = *parv;
# Line 1929 | Line 1700 | parse_aline(const char *cmd, struct Clie
1700        /* Make sure target_server *is* NULL if no ON server found
1701         * caller probably NULL'd it first, but no harm to do it again -db
1702         */
1703 <      if (target_server != NULL)
1703 >      if (target_server)
1704          *target_server = NULL;
1705      }
1706    }
1707  
1708 <  if (h_p != NULL)
1708 >  if (h_p)
1709    {
1710 <    if (strchr(user, '!') != NULL)
1710 >    if (strchr(user, '!'))
1711      {
1712        sendto_one_notice(source_p, &me, ":Invalid character '!' in kline");
1713 <      return -1;
1713 >      return 0;
1714      }
1715  
1716 <    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 2, *up_p, *h_p))
1717 <      return -1;
1716 >    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 2, *up_p, *h_p))
1717 >      return 0;
1718    }
1719    else
1720 <    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 1, *up_p))
1721 <      return -1;
1720 >    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, *up_p))
1721 >      return 0;
1722  
1723 <  if (reason != NULL)
1723 >  if (reason)
1724    {
1725 <    if (parc != 0 && !EmptyString(*parv))
1955 <    {
1725 >    if (parc && !EmptyString(*parv))
1726        *reason = *parv;
1957 –      if (!valid_comment(source_p, *reason, 1))
1958 –        return -1;
1959 –    }
1727      else
1728 <      *reason = def_reason;
1728 >      *reason = default_reason;
1729    }
1730  
1731    return 1;
1732   }
1733  
1967 – /* find_user_host()
1968 – *
1969 – * inputs       - pointer to client placing kline
1970 – *              - pointer to user_host_or_nick
1971 – *              - pointer to user buffer
1972 – *              - pointer to host buffer
1973 – * output       - 0 if not ok to kline, 1 to kline i.e. if valid user host
1974 – * side effects -
1975 – */
1976 – static int
1977 – find_user_host(struct Client *source_p, char *user_host_or_nick,
1978 –               char *luser, char *lhost, unsigned int flags)
1979 – {
1980 –  struct Client *target_p = NULL;
1981 –  char *hostp = NULL;
1982 –
1983 –  if (lhost == NULL)
1984 –  {
1985 –    strlcpy(luser, user_host_or_nick, USERLEN*4 + 1);
1986 –    return 1;
1987 –  }
1988 –
1989 –  if ((hostp = strchr(user_host_or_nick, '@')) || *user_host_or_nick == '*')
1990 –  {
1991 –    /* Explicit user@host mask given */
1992 –
1993 –    if (hostp != NULL)                            /* I'm a little user@host */
1994 –    {
1995 –      *(hostp++) = '\0';                       /* short and squat */
1996 –      if (*user_host_or_nick)
1997 –        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1998 –      else
1999 –        strcpy(luser, "*");
2000 –
2001 –      if (*hostp)
2002 –        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2003 –      else
2004 –        strcpy(lhost, "*");
2005 –    }
2006 –    else
2007 –    {
2008 –      luser[0] = '*';             /* no @ found, assume its *@somehost */
2009 –      luser[1] = '\0';
2010 –      strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
2011 –    }
2012 –
2013 –    return 1;
2014 –  }
2015 –  else
2016 –  {
2017 –    /* Try to find user@host mask from nick */
2018 –    /* Okay to use source_p as the first param, because source_p == client_p */
2019 –    if ((target_p =
2020 –        find_chasing(source_p, user_host_or_nick)) == NULL)
2021 –      return 0;
2022 –
2023 –    if (IsExemptKline(target_p))
2024 –    {
2025 –      if (!IsServer(source_p))
2026 –        sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
2027 –      return 0;
2028 –    }
2029 –
2030 –    /*
2031 –     * turn the "user" bit into "*user", blow away '~'
2032 –     * if found in original user name (non-idented)
2033 –     */
2034 –    strlcpy(luser, target_p->username, USERLEN*4 + 1);
2035 –
2036 –    if (target_p->username[0] == '~')
2037 –      luser[0] = '*';
2038 –
2039 –    if (target_p->sockhost[0] == '\0' ||
2040 –        (target_p->sockhost[0] == '0' && target_p->sockhost[1] == '\0'))
2041 –      strlcpy(lhost, target_p->host, HOSTLEN*4 + 1);
2042 –    else
2043 –      strlcpy(lhost, target_p->sockhost, HOSTLEN*4 + 1);
2044 –    return 1;
2045 –  }
2046 –
2047 –  return 0;
2048 – }
2049 –
2050 – /* valid_comment()
2051 – *
2052 – * inputs       - pointer to client
2053 – *              - pointer to comment
2054 – * output       - 0 if no valid comment,
2055 – *              - 1 if valid
2056 – * side effects - truncates reason where necessary
2057 – */
2058 – int
2059 – valid_comment(struct Client *source_p, char *comment, int warn)
2060 – {
2061 –  if (strlen(comment) > REASONLEN)
2062 –    comment[REASONLEN-1] = '\0';
2063 –
2064 –  return 1;
2065 – }
2066 –
1734   /* match_conf_password()
1735   *
1736   * inputs       - pointer to given password
# Line 2092 | Line 1759 | match_conf_password(const char *password
1759   *
1760   * inputs       - client sending the cluster
1761   *              - command name "KLINE" "XLINE" etc.
1762 < *              - capab -- CAP_KLN etc. from server.h
1762 > *              - capab -- CAPAB_KLN etc. from server.h
1763   *              - cluster type -- CLUSTER_KLINE etc. from conf.h
1764   *              - pattern and args to send along
1765   * output       - none
# Line 2100 | Line 1767 | match_conf_password(const char *password
1767   *                along to all servers that match capab and cluster type
1768   */
1769   void
1770 < cluster_a_line(struct Client *source_p, const char *command,
1771 <               int capab, int cluster_type, const char *pattern, ...)
1770 > cluster_a_line(struct Client *source_p, const char *command, unsigned int capab,
1771 >               unsigned int cluster_type, const char *pattern, ...)
1772   {
1773    va_list args;
1774 <  char buffer[IRCD_BUFSIZE];
1775 <  const dlink_node *ptr = NULL;
1774 >  char buffer[IRCD_BUFSIZE] = "";
1775 >  const dlink_node *node = NULL;
1776  
1777    va_start(args, pattern);
1778    vsnprintf(buffer, sizeof(buffer), pattern, args);
1779    va_end(args);
1780  
1781 <  DLINK_FOREACH(ptr, cluster_items.head)
1781 >  DLINK_FOREACH(node, cluster_items.head)
1782    {
1783 <    const struct MaskItem *conf = ptr->data;
1783 >    const struct MaskItem *conf = node->data;
1784  
1785      if (conf->flags & cluster_type)
1786 <      sendto_match_servs(source_p, conf->name, CAP_CLUSTER|capab,
1786 >      sendto_match_servs(source_p, conf->name, CAPAB_CLUSTER | capab,
1787                           "%s %s %s", command, conf->name, buffer);
1788    }
1789   }
# Line 2156 | Line 1823 | split_nuh(struct split_nuh_item *const i
1823  
1824    if (iptr->nickptr)
1825      strlcpy(iptr->nickptr, "*", iptr->nicksize);
1826 +
1827    if (iptr->userptr)
1828      strlcpy(iptr->userptr, "*", iptr->usersize);
1829 +
1830    if (iptr->hostptr)
1831      strlcpy(iptr->hostptr, "*", iptr->hostsize);
1832  
# Line 2165 | Line 1834 | split_nuh(struct split_nuh_item *const i
1834    {
1835      *p = '\0';
1836  
1837 <    if (iptr->nickptr && *iptr->nuhmask != '\0')
1837 >    if (iptr->nickptr && *iptr->nuhmask)
1838        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
1839  
1840      if ((q = strchr(++p, '@')))
1841      {
1842        *q++ = '\0';
1843  
1844 <      if (*p != '\0')
1844 >      if (*p)
1845          strlcpy(iptr->userptr, p, iptr->usersize);
1846  
1847 <      if (*q != '\0')
1847 >      if (*q)
1848          strlcpy(iptr->hostptr, q, iptr->hostsize);
1849      }
1850      else
1851      {
1852 <      if (*p != '\0')
1852 >      if (*p)
1853          strlcpy(iptr->userptr, p, iptr->usersize);
1854      }
1855    }
# Line 2192 | Line 1861 | split_nuh(struct split_nuh_item *const i
1861        /* if found a @ */
1862        *p++ = '\0';
1863  
1864 <      if (*iptr->nuhmask != '\0')
1864 >      if (*iptr->nuhmask)
1865          strlcpy(iptr->userptr, iptr->nuhmask, iptr->usersize);
1866  
1867 <      if (*p != '\0')
1867 >      if (*p)
1868          strlcpy(iptr->hostptr, p, iptr->hostsize);
1869      }
1870      else
1871      {
1872 <      /* no @ found */
1872 >      /* No @ found */
1873        if (!iptr->nickptr || strpbrk(iptr->nuhmask, ".:"))
1874          strlcpy(iptr->hostptr, iptr->nuhmask, iptr->hostsize);
1875        else

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)