ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing:
ircd-hybrid-7.2/src/s_conf.c (file contents), Revision 1013 by michael, Sun Oct 18 14:26:49 2009 UTC vs.
ircd-hybrid/trunk/src/conf.c (file contents), Revision 3347 by michael, Sun Apr 20 14:03:06 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_conf.c: Configuration file functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 18 | Line 17
17   *  along with this program; if not, write to the Free Software
18   *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file conf.c
23 > * \brief Configuration file functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29   #include "ircd_defs.h"
30 < #include "balloc.h"
31 < #include "s_conf.h"
30 < #include "s_serv.h"
30 > #include "conf.h"
31 > #include "server.h"
32   #include "resv.h"
33   #include "channel.h"
34   #include "client.h"
34 – #include "common.h"
35   #include "event.h"
36 – #include "hash.h"
37 – #include "hook.h"
36   #include "irc_string.h"
39 – #include "sprintf_irc.h"
37   #include "s_bsd.h"
41 – #include "irc_getaddrinfo.h"
38   #include "ircd.h"
39   #include "listener.h"
40   #include "hostmask.h"
41   #include "modules.h"
42   #include "numeric.h"
43   #include "fdlist.h"
44 < #include "s_log.h"
44 > #include "log.h"
45   #include "send.h"
50 – #include "s_gline.h"
51 – #include "fileio.h"
46   #include "memory.h"
47 < #include "irc_res.h"
47 > #include "mempool.h"
48 > #include "res.h"
49   #include "userhost.h"
50 < #include "s_user.h"
50 > #include "user.h"
51   #include "channel_mode.h"
52 + #include "parse.h"
53 + #include "misc.h"
54 + #include "conf_db.h"
55 + #include "conf_class.h"
56 + #include "motd.h"
57 +
58  
59 < struct Callback *client_check_cb = NULL;
59 > struct config_channel_entry ConfigChannel;
60   struct config_server_hide ConfigServerHide;
61 + struct config_file_entry ConfigFileEntry;
62 + struct logging_entry ConfigLoggingEntry = { .use_logging = 1 };
63 + struct server_info ServerInfo;
64 + struct admin_info AdminInfo;
65  
66   /* general conf items link list root, other than k lines etc. */
67 + dlink_list service_items = { NULL, NULL, 0 };
68   dlink_list server_items  = { NULL, NULL, 0 };
69   dlink_list cluster_items = { NULL, NULL, 0 };
64 – dlink_list hub_items     = { NULL, NULL, 0 };
65 – dlink_list leaf_items    = { NULL, NULL, 0 };
70   dlink_list oconf_items   = { NULL, NULL, 0 };
71   dlink_list uconf_items   = { NULL, NULL, 0 };
72   dlink_list xconf_items   = { NULL, NULL, 0 };
69 – dlink_list rxconf_items  = { NULL, NULL, 0 };
70 – dlink_list rkconf_items  = { NULL, NULL, 0 };
73   dlink_list nresv_items   = { NULL, NULL, 0 };
74 < dlink_list class_items   = { NULL, NULL, 0 };
73 < dlink_list gdeny_items   = { NULL, NULL, 0 };
74 <
75 < dlink_list temporary_klines  = { NULL, NULL, 0 };
76 < dlink_list temporary_dlines  = { NULL, NULL, 0 };
77 < dlink_list temporary_xlines  = { NULL, NULL, 0 };
78 < dlink_list temporary_rklines = { NULL, NULL, 0 };
79 < dlink_list temporary_glines  = { NULL, NULL, 0 };
80 < dlink_list temporary_rxlines = { NULL, NULL, 0 };
81 < dlink_list temporary_resv = { NULL, NULL, 0 };
74 > dlink_list cresv_items = { NULL, NULL, 0 };
75  
76   extern unsigned int lineno;
77   extern char linebuf[];
78   extern char conffilebuf[IRCD_BUFSIZE];
86 – extern char yytext[];
79   extern int yyparse(); /* defined in y.tab.c */
80  
81   struct conf_parser_context conf_parser_ctx = { 0, 0, NULL };
82  
83   /* internally defined functions */
84 < static void lookup_confhost(struct ConfItem *);
93 < static void set_default_conf(void);
94 < static void validate_conf(void);
95 < static void read_conf(FBFILE *);
84 > static void read_conf(FILE *);
85   static void clear_out_old_conf(void);
97 – static void flush_deleted_I_P(void);
86   static void expire_tklines(dlink_list *);
87   static void garbage_collect_ip_entries(void);
88   static int hash_ip(struct irc_ssaddr *);
89 < static int verify_access(struct Client *, const char *);
90 < static int attach_iline(struct Client *, struct ConfItem *);
89 > static int verify_access(struct Client *);
90 > static int attach_iline(struct Client *, struct MaskItem *);
91   static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
92 < static void parse_conf_file(int, int);
105 < static dlink_list *map_to_list(ConfType);
106 < static struct AccessItem *find_regexp_kline(const char *[]);
92 > static dlink_list *map_to_list(enum maskitem_type);
93   static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
94  
109 – /*
110 – * bit_len
111 – */
112 – static int cidr_limit_reached(int, struct irc_ssaddr *, struct ClassItem *);
113 – static void remove_from_cidr_check(struct irc_ssaddr *, struct ClassItem *);
114 – static void destroy_cidr_class(struct ClassItem *);
115 –
116 – static void flags_to_ascii(unsigned int, const unsigned int[], char *, int);
117 –
118 – /* address of default class conf */
119 – static struct ConfItem *class_default;
95  
96   /* usually, with hash tables, you use a prime number...
97   * but in this case I am dealing with ip addresses,
# Line 127 | Line 102 | static struct ConfItem *class_default;
102   struct ip_entry
103   {
104    struct irc_ssaddr ip;
105 <  int count;
105 >  unsigned int count;
106    time_t last_attempt;
107    struct ip_entry *next;
108   };
109  
110   static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
111 < static BlockHeap *ip_entry_heap = NULL;
111 > static mp_pool_t *ip_entry_pool = NULL;
112   static int ip_entries_count = 0;
113  
114  
140 – void *
141 – map_to_conf(struct ConfItem *aconf)
142 – {
143 –  void *conf;
144 –  conf = (void *)((uintptr_t)aconf +
145 –                  (uintptr_t)sizeof(struct ConfItem));
146 –  return(conf);
147 – }
148 –
149 – struct ConfItem *
150 – unmap_conf_item(void *aconf)
151 – {
152 –  struct ConfItem *conf;
153 –
154 –  conf = (struct ConfItem *)((uintptr_t)aconf -
155 –                             (uintptr_t)sizeof(struct ConfItem));
156 –  return(conf);
157 – }
158 –
115   /* conf_dns_callback()
116   *
117 < * inputs       - pointer to struct AccessItem
117 > * inputs       - pointer to struct MaskItem
118   *              - pointer to DNSReply reply
119   * output       - none
120   * side effects - called when resolver query finishes
# Line 169 | Line 125 | unmap_conf_item(void *aconf)
125   static void
126   conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
127   {
128 <  struct AccessItem *aconf = vptr;
128 >  struct MaskItem *conf = vptr;
129  
130 <  aconf->dns_pending = 0;
130 >  conf->dns_pending = 0;
131  
132 <  if (addr != NULL)
133 <    memcpy(&aconf->ipnum, addr, sizeof(aconf->ipnum));
132 >  if (addr)
133 >    memcpy(&conf->addr, addr, sizeof(conf->addr));
134    else
135 <    aconf->dns_failed = 1;
135 >    conf->dns_failed = 1;
136   }
137  
138   /* conf_dns_lookup()
# Line 186 | Line 142 | conf_dns_callback(void *vptr, const stru
142   * allocate a dns_query and start ns lookup.
143   */
144   static void
145 < conf_dns_lookup(struct AccessItem *aconf)
145 > conf_dns_lookup(struct MaskItem *conf)
146   {
147 <  if (!aconf->dns_pending)
147 >  if (!conf->dns_pending)
148    {
149 <    aconf->dns_pending = 1;
150 <    gethost_byname(conf_dns_callback, aconf, aconf->host);
149 >    conf->dns_pending = 1;
150 >    gethost_byname(conf_dns_callback, conf, conf->host);
151    }
152   }
153  
154 < /* make_conf_item()
155 < *
200 < * inputs       - type of item
201 < * output       - pointer to new conf entry
202 < * side effects - none
203 < */
204 < struct ConfItem *
205 < make_conf_item(ConfType type)
154 > struct MaskItem *
155 > conf_make(enum maskitem_type type)
156   {
157 <  struct ConfItem *conf = NULL;
158 <  struct AccessItem *aconf = NULL;
209 <  struct ClassItem *aclass = NULL;
210 <  int status = 0;
211 <
212 <  switch (type)
213 <  {
214 <  case DLINE_TYPE:
215 <  case EXEMPTDLINE_TYPE:
216 <  case GLINE_TYPE:
217 <  case KLINE_TYPE:
218 <  case CLIENT_TYPE:
219 <  case OPER_TYPE:
220 <  case SERVER_TYPE:
221 <    conf = MyMalloc(sizeof(struct ConfItem) +
222 <                    sizeof(struct AccessItem));
223 <    aconf = map_to_conf(conf);
224 <    aconf->aftype = AF_INET;
225 <
226 <    /* Yes, sigh. switch on type again */
227 <    switch (type)
228 <    {
229 <    case EXEMPTDLINE_TYPE:
230 <      status = CONF_EXEMPTDLINE;
231 <      break;
232 <
233 <    case DLINE_TYPE:
234 <      status = CONF_DLINE;
235 <      break;
157 >  struct MaskItem *conf = MyMalloc(sizeof(*conf));
158 >  dlink_list *list = NULL;
159  
160 <    case KLINE_TYPE:
161 <      status = CONF_KLINE;
162 <      break;
240 <
241 <    case GLINE_TYPE:
242 <      status = CONF_GLINE;
243 <      break;
244 <
245 <    case CLIENT_TYPE:
246 <      status = CONF_CLIENT;
247 <      break;
248 <
249 <    case OPER_TYPE:
250 <      status = CONF_OPERATOR;
251 <      dlinkAdd(conf, &conf->node, &oconf_items);
252 <      break;
253 <
254 <    case SERVER_TYPE:
255 <      status = CONF_SERVER;
256 <      dlinkAdd(conf, &conf->node, &server_items);
257 <      break;
258 <
259 <    default:
260 <      break;
261 <    }
262 <    aconf->status = status;
263 <    break;
264 <
265 <  case LEAF_TYPE:
266 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
267 <                                       sizeof(struct MatchItem));
268 <    dlinkAdd(conf, &conf->node, &leaf_items);
269 <    break;
270 <
271 <  case HUB_TYPE:
272 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
273 <                                       sizeof(struct MatchItem));
274 <    dlinkAdd(conf, &conf->node, &hub_items);
275 <    break;
276 <
277 <  case ULINE_TYPE:
278 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
279 <                                       sizeof(struct MatchItem));
280 <    dlinkAdd(conf, &conf->node, &uconf_items);
281 <    break;
282 <
283 <  case GDENY_TYPE:
284 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
285 <                                       sizeof(struct AccessItem));
286 <    dlinkAdd(conf, &conf->node, &gdeny_items);
287 <    break;
288 <
289 <  case XLINE_TYPE:
290 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
291 <                                       sizeof(struct MatchItem));
292 <    dlinkAdd(conf, &conf->node, &xconf_items);
293 <    break;
294 < #ifdef HAVE_LIBPCRE
295 <  case RXLINE_TYPE:
296 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
297 <                                       sizeof(struct MatchItem));
298 <    dlinkAdd(conf, &conf->node, &rxconf_items);
299 <    break;
300 <
301 <  case RKLINE_TYPE:
302 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
303 <                                       sizeof(struct AccessItem));
304 <    aconf = map_to_conf(conf);
305 <    aconf->status = CONF_KLINE;
306 <    dlinkAdd(conf, &conf->node, &rkconf_items);
307 <    break;
308 < #endif
309 <  case CLUSTER_TYPE:
310 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem));
311 <    dlinkAdd(conf, &conf->node, &cluster_items);
312 <    break;
313 <
314 <  case CRESV_TYPE:
315 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
316 <                                       sizeof(struct ResvChannel));
317 <    break;
318 <
319 <  case NRESV_TYPE:
320 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
321 <                                       sizeof(struct MatchItem));
322 <    dlinkAdd(conf, &conf->node, &nresv_items);
323 <    break;
324 <
325 <  case CLASS_TYPE:
326 <    conf = MyMalloc(sizeof(struct ConfItem) +
327 <                           sizeof(struct ClassItem));
328 <    dlinkAdd(conf, &conf->node, &class_items);
329 <
330 <    aclass = map_to_conf(conf);
331 <    aclass->active = 1;
332 <    ConFreq(aclass) = DEFAULT_CONNECTFREQUENCY;
333 <    PingFreq(aclass) = DEFAULT_PINGFREQUENCY;
334 <    MaxTotal(aclass) = MAXIMUM_LINKS_DEFAULT;
335 <    MaxSendq(aclass) = DEFAULT_SENDQ;
336 <
337 <    break;
338 <
339 <  default:
340 <    conf = NULL;
341 <    break;
342 <  }
343 <
344 <  /* XXX Yes, this will core if default is hit. I want it to for now - db */
345 <  conf->type = type;
160 >  conf->type   = type;
161 >  conf->active = 1;
162 >  conf->aftype = AF_INET;
163  
164 +  if ((list = map_to_list(type)))
165 +    dlinkAdd(conf, &conf->node, list);
166    return conf;
167   }
168  
169   void
170 < delete_conf_item(struct ConfItem *conf)
170 > conf_free(struct MaskItem *conf)
171   {
172 <  dlink_node *m = NULL;
173 <  struct MatchItem *match_item;
174 <  struct AccessItem *aconf;
175 <  ConfType type = conf->type;
172 >  dlink_node *ptr = NULL, *ptr_next = NULL;
173 >  dlink_list *list = NULL;
174 >
175 >  if (conf->node.next)
176 >    if ((list = map_to_list(conf->type)))
177 >      dlinkDelete(&conf->node, list);
178  
179    MyFree(conf->name);
359 –  conf->name = NULL;
180  
181 <  switch(type)
182 <  {
183 <  case DLINE_TYPE:
184 <  case EXEMPTDLINE_TYPE:
185 <  case GLINE_TYPE:
186 <  case KLINE_TYPE:
187 <  case CLIENT_TYPE:
188 <  case OPER_TYPE:
189 <  case SERVER_TYPE:
190 <    aconf = map_to_conf(conf);
191 <
192 <    if (aconf->dns_pending)
193 <      delete_resolver_queries(aconf);
194 <    if (aconf->passwd != NULL)
195 <      memset(aconf->passwd, 0, strlen(aconf->passwd));
376 <    if (aconf->spasswd != NULL)
377 <      memset(aconf->spasswd, 0, strlen(aconf->spasswd));
378 <    aconf->class_ptr = NULL;
379 <
380 <    MyFree(aconf->passwd);
381 <    MyFree(aconf->spasswd);
382 <    MyFree(aconf->reason);
383 <    MyFree(aconf->oper_reason);
384 <    MyFree(aconf->user);
385 <    MyFree(aconf->host);
386 <    MyFree(aconf->fakename);
181 >  if (conf->dns_pending)
182 >    delete_resolver_queries(conf);
183 >  if (conf->passwd)
184 >    memset(conf->passwd, 0, strlen(conf->passwd));
185 >  if (conf->spasswd)
186 >    memset(conf->spasswd, 0, strlen(conf->spasswd));
187 >
188 >  conf->class = NULL;
189 >
190 >  MyFree(conf->passwd);
191 >  MyFree(conf->spasswd);
192 >  MyFree(conf->reason);
193 >  MyFree(conf->certfp);
194 >  MyFree(conf->user);
195 >  MyFree(conf->host);
196   #ifdef HAVE_LIBCRYPTO
197 <    if (aconf->rsa_public_key)
389 <      RSA_free(aconf->rsa_public_key);
390 <    MyFree(aconf->rsa_public_key_file);
391 < #endif
197 >  MyFree(conf->cipher_list);
198  
199 <    /* Yes, sigh. switch on type again */
200 <    switch(type)
395 <    {
396 <    case EXEMPTDLINE_TYPE:
397 <    case DLINE_TYPE:
398 <    case GLINE_TYPE:
399 <    case KLINE_TYPE:
400 <    case CLIENT_TYPE:
401 <      MyFree(conf);
402 <      break;
403 <
404 <    case OPER_TYPE:
405 <      aconf = map_to_conf(conf);
406 <      if (!IsConfIllegal(aconf))
407 <        dlinkDelete(&conf->node, &oconf_items);
408 <      MyFree(conf);
409 <      break;
410 <
411 <    case SERVER_TYPE:
412 <      aconf = map_to_conf(conf);
413 <      if (!IsConfIllegal(aconf))
414 <        dlinkDelete(&conf->node, &server_items);
415 <      MyFree(conf);
416 <      break;
417 <
418 <    default:
419 <      break;
420 <    }
421 <    break;
422 <
423 <  case HUB_TYPE:
424 <    match_item = map_to_conf(conf);
425 <    MyFree(match_item->user);
426 <    MyFree(match_item->host);
427 <    MyFree(match_item->reason);
428 <    MyFree(match_item->oper_reason);
429 <    /* If marked illegal, its already been pulled off of the hub_items list */
430 <    if (!match_item->illegal)
431 <      dlinkDelete(&conf->node, &hub_items);
432 <    MyFree(conf);
433 <    break;
434 <
435 <  case LEAF_TYPE:
436 <    match_item = map_to_conf(conf);
437 <    MyFree(match_item->user);
438 <    MyFree(match_item->host);
439 <    MyFree(match_item->reason);
440 <    MyFree(match_item->oper_reason);
441 <    /* If marked illegal, its already been pulled off of the leaf_items list */
442 <    if (!match_item->illegal)
443 <      dlinkDelete(&conf->node, &leaf_items);
444 <    MyFree(conf);
445 <    break;
446 <
447 <  case ULINE_TYPE:
448 <    match_item = map_to_conf(conf);
449 <    MyFree(match_item->user);
450 <    MyFree(match_item->host);
451 <    MyFree(match_item->reason);
452 <    MyFree(match_item->oper_reason);
453 <    dlinkDelete(&conf->node, &uconf_items);
454 <    MyFree(conf);
455 <    break;
456 <
457 <  case XLINE_TYPE:
458 <    match_item = map_to_conf(conf);
459 <    MyFree(match_item->user);
460 <    MyFree(match_item->host);
461 <    MyFree(match_item->reason);
462 <    MyFree(match_item->oper_reason);
463 <    dlinkDelete(&conf->node, &xconf_items);
464 <    MyFree(conf);
465 <    break;
466 < #ifdef HAVE_LIBPCRE
467 <  case RKLINE_TYPE:
468 <    aconf = map_to_conf(conf);
469 <    MyFree(aconf->regexuser);
470 <    MyFree(aconf->regexhost);
471 <    MyFree(aconf->user);
472 <    MyFree(aconf->host);
473 <    MyFree(aconf->reason);
474 <    MyFree(aconf->oper_reason);
475 <    dlinkDelete(&conf->node, &rkconf_items);
476 <    MyFree(conf);
477 <    break;
478 <
479 <  case RXLINE_TYPE:
480 <    MyFree(conf->regexpname);
481 <    match_item = map_to_conf(conf);
482 <    MyFree(match_item->user);
483 <    MyFree(match_item->host);
484 <    MyFree(match_item->reason);
485 <    MyFree(match_item->oper_reason);
486 <    dlinkDelete(&conf->node, &rxconf_items);
487 <    MyFree(conf);
488 <    break;
199 >  if (conf->rsa_public_key)
200 >    RSA_free(conf->rsa_public_key);
201   #endif
202 <  case NRESV_TYPE:
203 <    match_item = map_to_conf(conf);
204 <    MyFree(match_item->user);
205 <    MyFree(match_item->host);
206 <    MyFree(match_item->reason);
495 <    MyFree(match_item->oper_reason);
496 <    dlinkDelete(&conf->node, &nresv_items);
497 <
498 <    if (conf->flags & CONF_FLAGS_TEMPORARY)
499 <      if ((m = dlinkFindDelete(&temporary_resv, conf)) != NULL)
500 <        free_dlink_node(m);
501 <
502 <    MyFree(conf);
503 <    break;
504 <
505 <  case GDENY_TYPE:
506 <    aconf = map_to_conf(conf);
507 <    MyFree(aconf->user);
508 <    MyFree(aconf->host);
509 <    dlinkDelete(&conf->node, &gdeny_items);
510 <    MyFree(conf);
511 <    break;
512 <
513 <  case CLUSTER_TYPE:
514 <    dlinkDelete(&conf->node, &cluster_items);
515 <    MyFree(conf);
516 <    break;
517 <
518 <  case CRESV_TYPE:
519 <    if (conf->flags & CONF_FLAGS_TEMPORARY)
520 <      if ((m = dlinkFindDelete(&temporary_resv, conf)) != NULL)
521 <        free_dlink_node(m);
522 <
523 <    MyFree(conf);
524 <    break;
525 <
526 <  case CLASS_TYPE:
527 <    dlinkDelete(&conf->node, &class_items);
528 <    MyFree(conf);
529 <    break;
530 <
531 <  default:
532 <    break;
202 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->hub_list.head)
203 >  {
204 >    MyFree(ptr->data);
205 >    dlinkDelete(ptr, &conf->hub_list);
206 >    free_dlink_node(ptr);
207    }
534 – }
535 –
536 – /* free_access_item()
537 – *
538 – * inputs       - pointer to conf to free
539 – * output       - none
540 – * side effects - crucial password fields are zeroed, conf is freed
541 – */
542 – void
543 – free_access_item(struct AccessItem *aconf)
544 – {
545 –  struct ConfItem *conf;
546 –
547 –  if (aconf == NULL)
548 –    return;
549 –  conf = unmap_conf_item(aconf);
550 –  delete_conf_item(conf);
551 – }
208  
209 < static const unsigned int shared_bit_table[] =
554 <  { 'K', 'k', 'U', 'X', 'x', 'Y', 'Q', 'q', 'R', 'L', 0};
555 <
556 < /* report_confitem_types()
557 < *
558 < * inputs       - pointer to client requesting confitem report
559 < *              - ConfType to report
560 < * output       - none
561 < * side effects -
562 < */
563 < void
564 < report_confitem_types(struct Client *source_p, ConfType type, int temp)
565 < {
566 <  dlink_node *ptr = NULL;
567 <  struct ConfItem *conf = NULL;
568 <  struct AccessItem *aconf = NULL;
569 <  struct MatchItem *matchitem = NULL;
570 <  struct ClassItem *classitem = NULL;
571 <  char buf[12];
572 <  char *p = NULL;
573 <  const char *pfx = NULL;
574 <
575 <  switch (type)
209 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->leaf_list.head)
210    {
211 <  case GDENY_TYPE:
212 <    DLINK_FOREACH(ptr, gdeny_items.head)
213 <    {
214 <      conf = ptr->data;
581 <      aconf = map_to_conf(conf);
582 <
583 <      p = buf;
584 <
585 <      if (aconf->flags & GDENY_BLOCK)
586 <        *p++ = 'B';
587 <      else
588 <        *p++ = 'b';
589 <
590 <      if (aconf->flags & GDENY_REJECT)
591 <        *p++ = 'R';
592 <      else
593 <        *p++ = 'r';
594 <
595 <      *p = '\0';
596 <
597 <      sendto_one(source_p, ":%s %d %s V %s@%s %s %s",
598 <                 me.name, RPL_STATSDEBUG, source_p->name,
599 <                 aconf->user, aconf->host, conf->name, buf);
600 <    }
601 <    break;
602 <
603 <  case XLINE_TYPE:
604 <    DLINK_FOREACH(ptr, xconf_items.head)
605 <    {
606 <      conf = ptr->data;
607 <      matchitem = map_to_conf(conf);
608 <
609 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
610 <                 me.name, source_p->name,
611 <                 matchitem->hold ? "x": "X", matchitem->count,
612 <                 conf->name, matchitem->reason);
613 <    }
614 <    break;
615 <
616 < #ifdef HAVE_LIBPCRE
617 <  case RXLINE_TYPE:
618 <    DLINK_FOREACH(ptr, rxconf_items.head)
619 <    {
620 <      conf = ptr->data;
621 <      matchitem = map_to_conf(conf);
622 <
623 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
624 <                 me.name, source_p->name,
625 <                 matchitem->hold ? "xR": "XR", matchitem->count,
626 <                 conf->name, matchitem->reason);
627 <    }
628 <    break;
629 <
630 <  case RKLINE_TYPE:
631 <    pfx = temp ? "kR" : "KR";
632 <
633 <    DLINK_FOREACH(ptr, rkconf_items.head)
634 <    {
635 <      aconf = map_to_conf((conf = ptr->data));
636 <
637 <      if (temp && !(conf->flags & CONF_FLAGS_TEMPORARY))
638 <        continue;
639 <
640 <      sendto_one(source_p, form_str(RPL_STATSKLINE), me.name,
641 <                 source_p->name, pfx, aconf->host, aconf->user,
642 <                 aconf->reason, aconf->oper_reason ? aconf->oper_reason : "");
643 <    }
644 <    break;
645 < #endif
646 <
647 <  case ULINE_TYPE:
648 <    DLINK_FOREACH(ptr, uconf_items.head)
649 <    {
650 <      conf = ptr->data;
651 <      matchitem = map_to_conf(conf);
652 <
653 <      p = buf;
654 <
655 <      /* some of these are redundant for the sake of
656 <       * consistency with cluster{} flags
657 <       */
658 <      *p++ = 'c';
659 <      flags_to_ascii(matchitem->action, shared_bit_table, p, 0);
660 <
661 <      sendto_one(source_p, form_str(RPL_STATSULINE),
662 <                 me.name, source_p->name, conf->name,
663 <                 matchitem->user?matchitem->user: "*",
664 <                 matchitem->host?matchitem->host: "*", buf);
665 <    }
666 <
667 <    DLINK_FOREACH(ptr, cluster_items.head)
668 <    {
669 <      conf = ptr->data;
670 <
671 <      p = buf;
672 <
673 <      *p++ = 'C';
674 <      flags_to_ascii(conf->flags, shared_bit_table, p, 0);
675 <
676 <      sendto_one(source_p, form_str(RPL_STATSULINE),
677 <                 me.name, source_p->name, conf->name,
678 <                 "*", "*", buf);
679 <    }
680 <
681 <    break;
682 <
683 <  case OPER_TYPE:
684 <    DLINK_FOREACH(ptr, oconf_items.head)
685 <    {
686 <      conf = ptr->data;
687 <      aconf = map_to_conf(conf);
688 <
689 <      /* Don't allow non opers to see oper privs */
690 <      if (IsOper(source_p))
691 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
692 <                   me.name, source_p->name, 'O', aconf->user, aconf->host,
693 <                   conf->name, oper_privs_as_string(aconf->port),
694 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
695 <      else
696 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
697 <                   me.name, source_p->name, 'O', aconf->user, aconf->host,
698 <                   conf->name, "0",
699 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
700 <    }
701 <    break;
702 <
703 <  case CLASS_TYPE:
704 <    DLINK_FOREACH(ptr, class_items.head)
705 <    {
706 <      conf = ptr->data;
707 <      classitem = map_to_conf(conf);
708 <      sendto_one(source_p, form_str(RPL_STATSYLINE),
709 <                 me.name, source_p->name, 'Y',
710 <                 conf->name, PingFreq(classitem),
711 <                 ConFreq(classitem),
712 <                 MaxTotal(classitem), MaxSendq(classitem),
713 <                 CurrUserCount(classitem),
714 <                 classitem->active ? "active" : "disabled");
715 <    }
716 <    break;
717 <
718 <  case CONF_TYPE:
719 <  case CLIENT_TYPE:
720 <    break;
721 <
722 <  case SERVER_TYPE:
723 <    DLINK_FOREACH(ptr, server_items.head)
724 <    {
725 <      p = buf;
726 <
727 <      conf = ptr->data;
728 <      aconf = map_to_conf(conf);
729 <
730 <      buf[0] = '\0';
731 <
732 <      if (IsConfAllowAutoConn(aconf))
733 <        *p++ = 'A';
734 <      if (IsConfCryptLink(aconf))
735 <        *p++ = 'C';
736 <      if (aconf->fakename)
737 <        *p++ = 'M';
738 <      if (IsConfTopicBurst(aconf))
739 <        *p++ = 'T';
740 <      if (IsConfCompressed(aconf))
741 <        *p++ = 'Z';
742 <      if (buf[0] == '\0')
743 <        *p++ = '*';
744 <
745 <      *p = '\0';
746 <
747 <      /*
748 <       * Allow admins to see actual ips unless hide_server_ips is enabled
749 <       */
750 <      if (!ConfigServerHide.hide_server_ips && IsAdmin(source_p))
751 <        sendto_one(source_p, form_str(RPL_STATSCLINE),
752 <                   me.name, source_p->name, 'C', aconf->host,
753 <                   buf, conf->name, aconf->port,
754 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
755 <        else
756 <          sendto_one(source_p, form_str(RPL_STATSCLINE),
757 <                     me.name, source_p->name, 'C',
758 <                     "*@127.0.0.1", buf, conf->name, aconf->port,
759 <                     aconf->class_ptr ? aconf->class_ptr->name : "<default>");
760 <    }
761 <    break;
762 <
763 <  case HUB_TYPE:
764 <    DLINK_FOREACH(ptr, hub_items.head)
765 <    {
766 <      conf = ptr->data;
767 <      matchitem = map_to_conf(conf);
768 <      sendto_one(source_p, form_str(RPL_STATSHLINE), me.name,
769 <                 source_p->name, 'H', matchitem->host, conf->name, 0, "*");
770 <    }
771 <    break;
211 >    MyFree(ptr->data);
212 >    dlinkDelete(ptr, &conf->leaf_list);
213 >    free_dlink_node(ptr);
214 >  }
215  
216 <  case LEAF_TYPE:
217 <    DLINK_FOREACH(ptr, leaf_items.head)
218 <    {
776 <      conf = ptr->data;
777 <      matchitem = map_to_conf(conf);
778 <      sendto_one(source_p, form_str(RPL_STATSLLINE), me.name,
779 <                 source_p->name, 'L', matchitem->host, conf->name, 0, "*");
780 <    }
781 <    break;
216 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->exempt_list.head)
217 >  {
218 >    struct exempt *exptr = ptr->data;
219  
220 <  case GLINE_TYPE:
221 <  case KLINE_TYPE:
222 <  case DLINE_TYPE:
223 <  case EXEMPTDLINE_TYPE:
224 <  case CRESV_TYPE:
788 <  case NRESV_TYPE:
789 <  case CLUSTER_TYPE:
790 <  default:
791 <    break;
220 >    dlinkDelete(ptr, &conf->exempt_list);
221 >    MyFree(exptr->name);
222 >    MyFree(exptr->user);
223 >    MyFree(exptr->host);
224 >    MyFree(exptr);
225    }
226 +
227 +  MyFree(conf);
228   }
229  
230   /* check_client()
# Line 805 | Line 240 | report_confitem_types(struct Client *sou
240   *                Look for conf lines which have the same
241   *                status as the flags passed.
242   */
243 < static void *
244 < check_client(va_list args)
243 > int
244 > check_client(struct Client *source_p)
245   {
811 –  struct Client *source_p = va_arg(args, struct Client *);
812 –  const char *username = va_arg(args, const char *);
246    int i;
247 <
248 <  /* I'm already in big trouble if source_p->localClient is NULL -db */
249 <  if ((i = verify_access(source_p, username)))
817 <    ilog(L_INFO, "Access denied: %s[%s]",
247 >
248 >  if ((i = verify_access(source_p)))
249 >    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
250           source_p->name, source_p->sockhost);
251  
252    switch (i)
253    {
254      case TOO_MANY:
255 <      sendto_realops_flags(UMODE_FULL, L_ALL,
255 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
256                             "Too many on IP for %s (%s).",
257 <                           get_client_name(source_p, SHOW_IP),
258 <                           source_p->sockhost);
259 <      ilog(L_INFO,"Too many connections on IP from %s.",
260 <           get_client_name(source_p, SHOW_IP));
257 >                           get_client_name(source_p, SHOW_IP),
258 >                           source_p->sockhost);
259 >      ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
260 >           get_client_name(source_p, SHOW_IP));
261        ++ServerStats.is_ref;
262 <      exit_client(source_p, &me, "No more connections allowed on that IP");
262 >      exit_client(source_p, "No more connections allowed on that IP");
263        break;
264  
265      case I_LINE_FULL:
266 <      sendto_realops_flags(UMODE_FULL, L_ALL,
267 <                           "I-line is full for %s (%s).",
268 <                           get_client_name(source_p, SHOW_IP),
269 <                           source_p->sockhost);
270 <      ilog(L_INFO,"Too many connections from %s.",
271 <           get_client_name(source_p, SHOW_IP));
266 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
267 >                           "auth{} block is full for %s (%s).",
268 >                           get_client_name(source_p, SHOW_IP),
269 >                           source_p->sockhost);
270 >      ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
271 >           get_client_name(source_p, SHOW_IP));
272        ++ServerStats.is_ref;
273 <      exit_client(source_p, &me,
842 <                "No more connections allowed in your connection class");
273 >      exit_client(source_p, "No more connections allowed in your connection class");
274        break;
275  
276      case NOT_AUTHORIZED:
277        ++ServerStats.is_ref;
278        /* jdc - lists server name & port connections are on */
279        /*       a purely cosmetical change */
280 <      sendto_realops_flags(UMODE_UNAUTH, L_ALL,
281 <                           "Unauthorized client connection from %s [%s] on [%s/%u].",
282 <                           get_client_name(source_p, SHOW_IP),
283 <                           source_p->sockhost,
284 <                           source_p->localClient->listener->name,
285 <                           source_p->localClient->listener->port);
286 <      ilog(L_INFO,
287 <          "Unauthorized client connection from %s on [%s/%u].",
288 <          get_client_name(source_p, SHOW_IP),
289 <          source_p->localClient->listener->name,
290 <          source_p->localClient->listener->port);
291 <
292 <      /* XXX It is prolematical whether it is better to use the
862 <       * capture reject code here or rely on the connecting too fast code.
863 <       * - Dianora
864 <       */
865 <      if (REJECT_HOLD_TIME > 0)
866 <      {
867 <        sendto_one(source_p, ":%s NOTICE %s :You are not authorized to use this server",
868 <                   me.name, source_p->name);
869 <        source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
870 <        SetCaptured(source_p);
871 <      }
872 <      else
873 <        exit_client(source_p, &me, "You are not authorized to use this server");
280 >      sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
281 >                           "Unauthorized client connection from %s [%s] on [%s/%u].",
282 >                           get_client_name(source_p, SHOW_IP),
283 >                           source_p->sockhost,
284 >                           source_p->localClient->listener->name,
285 >                           source_p->localClient->listener->port);
286 >      ilog(LOG_TYPE_IRCD,
287 >           "Unauthorized client connection from %s on [%s/%u].",
288 >           get_client_name(source_p, SHOW_IP),
289 >           source_p->localClient->listener->name,
290 >           source_p->localClient->listener->port);
291 >
292 >      exit_client(source_p, "You are not authorized to use this server");
293        break;
294  
295     case BANNED_CLIENT:
296 <     /*
878 <      * Don't exit them immediately, play with them a bit.
879 <      * - Dianora
880 <      */
881 <     if (REJECT_HOLD_TIME > 0)
882 <     {
883 <       source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
884 <       SetCaptured(source_p);
885 <     }
886 <     else
887 <       exit_client(source_p, &me, "Banned");
296 >     exit_client(source_p, "Banned");
297       ++ServerStats.is_ref;
298       break;
299  
# Line 893 | Line 302 | check_client(va_list args)
302       break;
303    }
304  
305 <  return (i < 0 ? NULL : source_p);
305 >  return (i < 0 ? 0 : 1);
306   }
307  
308   /* verify_access()
309   *
310   * inputs       - pointer to client to verify
902 – *              - pointer to proposed username
311   * output       - 0 if success -'ve if not
312   * side effect  - find the first (best) I line to attach.
313   */
314   static int
315 < verify_access(struct Client *client_p, const char *username)
315 > verify_access(struct Client *client_p)
316   {
317 <  struct AccessItem *aconf = NULL, *rkconf = NULL;
318 <  struct ConfItem *conf = NULL;
911 <  char non_ident[USERLEN + 1] = { '~', '\0' };
912 <  const char *uhi[3];
317 >  struct MaskItem *conf = NULL;
318 >  char non_ident[USERLEN + 1] = "~";
319  
320    if (IsGotId(client_p))
321    {
322 <    aconf = find_address_conf(client_p->host, client_p->username,
323 <                             &client_p->localClient->ip,
324 <                             client_p->localClient->aftype,
322 >    conf = find_address_conf(client_p->host, client_p->username,
323 >                             &client_p->localClient->ip,
324 >                             client_p->localClient->aftype,
325                               client_p->localClient->passwd);
326    }
327    else
328    {
329 <    strlcpy(non_ident+1, username, sizeof(non_ident)-1);
330 <    aconf = find_address_conf(client_p->host,non_ident,
331 <                             &client_p->localClient->ip,
332 <                             client_p->localClient->aftype,
333 <                             client_p->localClient->passwd);
329 >    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
330 >    conf = find_address_conf(client_p->host,non_ident,
331 >                             &client_p->localClient->ip,
332 >                             client_p->localClient->aftype,
333 >                             client_p->localClient->passwd);
334    }
335  
336 <  uhi[0] = IsGotId(client_p) ? client_p->username : non_ident;
931 <  uhi[1] = client_p->host;
932 <  uhi[2] = client_p->sockhost;
933 <
934 <  rkconf = find_regexp_kline(uhi);
935 <
936 <  if (aconf != NULL)
336 >  if (conf)
337    {
338 <    if (IsConfClient(aconf) && !rkconf)
338 >    if (IsConfClient(conf))
339      {
340 <      conf = unmap_conf_item(aconf);
941 <
942 <      if (IsConfRedir(aconf))
340 >      if (IsConfRedir(conf))
341        {
342 <        sendto_one(client_p, form_str(RPL_REDIR),
343 <                   me.name, client_p->name,
344 <                   conf->name ? conf->name : "",
345 <                   aconf->port);
948 <        return(NOT_AUTHORIZED);
342 >        sendto_one_numeric(client_p, &me, RPL_REDIR,
343 >                           conf->name ? conf->name : "",
344 >                           conf->port);
345 >        return NOT_AUTHORIZED;
346        }
347  
348 <      if (IsConfDoIdentd(aconf))
349 <        SetNeedId(client_p);
348 >      if (IsConfDoIdentd(conf))
349 >        SetNeedId(client_p);
350  
351        /* Thanks for spoof idea amm */
352 <      if (IsConfDoSpoofIp(aconf))
352 >      if (IsConfDoSpoofIp(conf))
353        {
354 <        conf = unmap_conf_item(aconf);
355 <
356 <        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(aconf))
960 <          sendto_realops_flags(UMODE_ALL, L_ADMIN, "%s spoofing: %s as %s",
354 >        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
355 >          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
356 >                               "%s spoofing: %s as %s",
357                                 client_p->name, client_p->host, conf->name);
358          strlcpy(client_p->host, conf->name, sizeof(client_p->host));
359 <        SetIPSpoof(client_p);
359 >        AddFlag(client_p, FLAGS_IP_SPOOFING | FLAGS_AUTH_SPOOF);
360        }
361  
362 <      return(attach_iline(client_p, conf));
362 >      return attach_iline(client_p, conf);
363      }
364 <    else if (rkconf || IsConfKill(aconf) || (ConfigFileEntry.glines && IsConfGline(aconf)))
364 >    else if (IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
365      {
366 <      /* XXX */
367 <      aconf = rkconf ? rkconf : aconf;
368 <      if (IsConfGline(aconf))
369 <        sendto_one(client_p, ":%s NOTICE %s :*** G-lined", me.name,
974 <                   client_p->name);
975 <      if (ConfigFileEntry.kline_with_reason)
976 <        sendto_one(client_p, ":%s NOTICE %s :*** Banned %s",
977 <                  me.name, client_p->name, aconf->reason);
978 <      return(BANNED_CLIENT);
366 >      if (IsConfGline(conf))
367 >        sendto_one_notice(client_p, &me, ":*** G-lined");
368 >      sendto_one_notice(client_p, &me, ":*** Banned: %s", conf->reason);
369 >      return BANNED_CLIENT;
370      }
371    }
372  
373 <  return(NOT_AUTHORIZED);
373 >  return NOT_AUTHORIZED;
374   }
375  
376   /* attach_iline()
# Line 990 | Line 381 | verify_access(struct Client *client_p, c
381   * side effects - do actual attach
382   */
383   static int
384 < attach_iline(struct Client *client_p, struct ConfItem *conf)
384 > attach_iline(struct Client *client_p, struct MaskItem *conf)
385   {
386 <  struct AccessItem *aconf;
996 <  struct ClassItem *aclass;
386 >  struct ClassItem *class = NULL;
387    struct ip_entry *ip_found;
388    int a_limit_reached = 0;
389 <  int local = 0, global = 0, ident = 0;
389 >  unsigned int local = 0, global = 0, ident = 0;
390 >
391 >  assert(conf->class);
392  
393    ip_found = find_or_add_ip(&client_p->localClient->ip);
394    ip_found->count++;
395    SetIpHash(client_p);
396  
397 <  aconf = map_to_conf(conf);
1006 <  if (aconf->class_ptr == NULL)
1007 <    return NOT_AUTHORIZED;  /* If class is missing, this is best */
1008 <
1009 <  aclass = map_to_conf(aconf->class_ptr);
397 >  class = conf->class;
398  
399    count_user_host(client_p->username, client_p->host,
400                    &global, &local, &ident);
# Line 1015 | Line 403 | attach_iline(struct Client *client_p, st
403     * setting a_limit_reached if any limit is reached.
404     * - Dianora
405     */
406 <  if (MaxTotal(aclass) != 0 && CurrUserCount(aclass) >= MaxTotal(aclass))
406 >  if (class->max_total != 0 && class->ref_count >= class->max_total)
407      a_limit_reached = 1;
408 <  else if (MaxPerIp(aclass) != 0 && ip_found->count > MaxPerIp(aclass))
408 >  else if (class->max_perip != 0 && ip_found->count > class->max_perip)
409      a_limit_reached = 1;
410 <  else if (MaxLocal(aclass) != 0 && local >= MaxLocal(aclass))
410 >  else if (class->max_local != 0 && local >= class->max_local)
411      a_limit_reached = 1;
412 <  else if (MaxGlobal(aclass) != 0 && global >= MaxGlobal(aclass))
412 >  else if (class->max_global != 0 && global >= class->max_global)
413      a_limit_reached = 1;
414 <  else if (MaxIdent(aclass) != 0 && ident >= MaxIdent(aclass) &&
414 >  else if (class->max_ident != 0 && ident >= class->max_ident &&
415             client_p->username[0] != '~')
416      a_limit_reached = 1;
417  
418    if (a_limit_reached)
419    {
420 <    if (!IsConfExemptLimits(aconf))
420 >    if (!IsConfExemptLimits(conf))
421        return TOO_MANY;   /* Already at maximum allowed */
422  
423 <    sendto_one(client_p,
424 <               ":%s NOTICE %s :*** Your connection class is full, "
1037 <               "but you have exceed_limit = yes;", me.name, client_p->name);
423 >    sendto_one_notice(client_p, &me, ":*** Your connection class is full, "
424 >                      "but you have exceed_limit = yes;");
425    }
426  
427    return attach_conf(client_p, conf);
# Line 1050 | Line 437 | attach_iline(struct Client *client_p, st
437   void
438   init_ip_hash_table(void)
439   {
440 <  ip_entry_heap = BlockHeapCreate("ip", sizeof(struct ip_entry),
1054 <    2 * hard_fdlimit);
440 >  ip_entry_pool = mp_pool_new(sizeof(struct ip_entry), MP_CHUNK_SIZE_IP_ENTRY);
441    memset(ip_hash_table, 0, sizeof(ip_hash_table));
442   }
443  
# Line 1100 | Line 486 | find_or_add_ip(struct irc_ssaddr *ip_in)
486    if (ip_entries_count >= 2 * hard_fdlimit)
487      garbage_collect_ip_entries();
488  
489 <  newptr = BlockHeapAlloc(ip_entry_heap);
489 >  newptr = mp_pool_get(ip_entry_pool);
490 >  memset(newptr, 0, sizeof(*newptr));
491    ip_entries_count++;
492    memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
493  
# Line 1151 | Line 538 | remove_one_ip(struct irc_ssaddr *ip_in)
538      if (ptr->count > 0)
539        ptr->count--;
540      if (ptr->count == 0 &&
541 <        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
541 >        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
542      {
543        if (last_ptr != NULL)
544 <        last_ptr->next = ptr->next;
544 >        last_ptr->next = ptr->next;
545        else
546 <        ip_hash_table[hash_index] = ptr->next;
546 >        ip_hash_table[hash_index] = ptr->next;
547  
548 <      BlockHeapFree(ip_entry_heap, ptr);
548 >      mp_pool_release(ptr);
549        ip_entries_count--;
550        return;
551      }
# Line 1179 | Line 566 | hash_ip(struct irc_ssaddr *addr)
566    {
567      struct sockaddr_in *v4 = (struct sockaddr_in *)addr;
568      int hash;
569 <    u_int32_t ip;
569 >    uint32_t ip;
570  
571      ip   = ntohl(v4->sin_addr.s_addr);
572      hash = ((ip >> 12) + ip) & (IP_HASH_SIZE-1);
# Line 1190 | Line 577 | hash_ip(struct irc_ssaddr *addr)
577    {
578      int hash;
579      struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)addr;
580 <    u_int32_t *ip = (u_int32_t *)&v6->sin6_addr.s6_addr;
580 >    uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
581  
582      hash  = ip[0] ^ ip[3];
583 <    hash ^= hash >> 16;  
584 <    hash ^= hash >> 8;  
583 >    hash ^= hash >> 16;
584 >    hash ^= hash >> 8;
585      hash  = hash & (IP_HASH_SIZE - 1);
586      return hash;
587    }
# Line 1205 | Line 592 | hash_ip(struct irc_ssaddr *addr)
592  
593   /* count_ip_hash()
594   *
595 < * inputs        - pointer to counter of number of ips hashed
595 > * inputs        - pointer to counter of number of ips hashed
596   *               - pointer to memory used for ip hash
597   * output        - returned via pointers input
598   * side effects  - NONE
# Line 1261 | Line 648 | garbage_collect_ip_entries(void)
648            last_ptr->next = ptr->next;
649          else
650            ip_hash_table[i] = ptr->next;
651 <        BlockHeapFree(ip_entry_heap, ptr);
651 >        mp_pool_release(ptr);
652          ip_entries_count--;
653        }
654        else
# Line 1278 | Line 665 | garbage_collect_ip_entries(void)
665   * side effects - Disassociate configuration from the client.
666   *                Also removes a class from the list if marked for deleting.
667   */
668 < int
669 < detach_conf(struct Client *client_p, ConfType type)
668 > void
669 > detach_conf(struct Client *client_p, enum maskitem_type type)
670   {
671 <  dlink_node *ptr, *next_ptr;
1285 <  struct ConfItem *conf;
1286 <  struct ClassItem *aclass;
1287 <  struct AccessItem *aconf;
1288 <  struct ConfItem *aclass_conf;
1289 <  struct MatchItem *match_item;
671 >  dlink_node *ptr = NULL, *ptr_next = NULL;
672  
673 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->localClient->confs.head)
673 >  DLINK_FOREACH_SAFE(ptr, ptr_next, client_p->localClient->confs.head)
674    {
675 <    conf = ptr->data;
1294 <
1295 <    if (type == CONF_TYPE || conf->type == type)
1296 <    {
1297 <      dlinkDelete(ptr, &client_p->localClient->confs);
1298 <      free_dlink_node(ptr);
1299 <
1300 <      switch (conf->type)
1301 <      {
1302 <      case CLIENT_TYPE:
1303 <      case OPER_TYPE:
1304 <      case SERVER_TYPE:
1305 <        aconf = map_to_conf(conf);
1306 <
1307 <        assert(aconf->clients > 0);
1308 <
1309 <        if ((aclass_conf = ClassPtr(aconf)) != NULL)
1310 <        {
1311 <          aclass = map_to_conf(aclass_conf);
675 >    struct MaskItem *conf = ptr->data;
676  
677 <          assert(aclass->curr_user_count > 0);
677 >    assert(conf->type & (CONF_CLIENT | CONF_OPER | CONF_SERVER));
678 >    assert(conf->ref_count > 0);
679 >    assert(conf->class->ref_count > 0);
680  
681 <          if (conf->type == CLIENT_TYPE)
682 <            remove_from_cidr_check(&client_p->localClient->ip, aclass);
1317 <          if (--aclass->curr_user_count == 0 && aclass->active == 0)
1318 <            delete_conf_item(aclass_conf);
1319 <        }
681 >    if (!(conf->type & type))
682 >      continue;
683  
684 <        if (--aconf->clients == 0 && IsConfIllegal(aconf))
685 <          delete_conf_item(conf);
684 >    dlinkDelete(ptr, &client_p->localClient->confs);
685 >    free_dlink_node(ptr);
686  
687 <        break;
687 >    if (conf->type == CONF_CLIENT)
688 >      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
689  
690 <      case LEAF_TYPE:
691 <      case HUB_TYPE:
692 <        match_item = map_to_conf(conf);
693 <        if (match_item->ref_count == 0 && match_item->illegal)
1330 <          delete_conf_item(conf);
1331 <        break;
1332 <      default:
1333 <        break;
1334 <      }
1335 <
1336 <      if (type != CONF_TYPE)
1337 <        return 0;
690 >    if (--conf->class->ref_count == 0 && conf->class->active == 0)
691 >    {
692 >      class_free(conf->class);
693 >      conf->class = NULL;
694      }
1339 –  }
695  
696 <  return -1;
696 >    if (--conf->ref_count == 0 && conf->active == 0)
697 >      conf_free(conf);
698 >  }
699   }
700  
701   /* attach_conf()
# Line 1352 | Line 709 | detach_conf(struct Client *client_p, Con
709   *                attachment if there was an old one...
710   */
711   int
712 < attach_conf(struct Client *client_p, struct ConfItem *conf)
712 > attach_conf(struct Client *client_p, struct MaskItem *conf)
713   {
714 <  if (dlinkFind(&client_p->localClient->confs, conf) != NULL)
714 >  if (dlinkFind(&client_p->localClient->confs, conf))
715      return 1;
716  
717 <  if (conf->type == CLIENT_TYPE ||
718 <      conf->type == SERVER_TYPE ||
719 <      conf->type == OPER_TYPE)
720 <  {
1364 <    struct AccessItem *aconf = map_to_conf(conf);
1365 <    struct ClassItem *aclass = map_to_conf(aconf->class_ptr);
1366 <
1367 <    if (IsConfIllegal(aconf))
1368 <      return NOT_AUTHORIZED;
1369 <
1370 <    if (conf->type == CLIENT_TYPE)
1371 <      if (cidr_limit_reached(IsConfExemptLimits(aconf),
1372 <                             &client_p->localClient->ip, aclass))
1373 <        return TOO_MANY;    /* Already at maximum allowed */
717 >  if (conf->type == CONF_CLIENT)
718 >    if (cidr_limit_reached(IsConfExemptLimits(conf),
719 >                           &client_p->localClient->ip, conf->class))
720 >      return TOO_MANY;    /* Already at maximum allowed */
721  
722 <    CurrUserCount(aclass)++;
723 <    aconf->clients++;
1377 <  }
1378 <  else if (conf->type == HUB_TYPE || conf->type == LEAF_TYPE)
1379 <  {
1380 <    struct MatchItem *match_item = map_to_conf(conf);
1381 <    match_item->ref_count++;
1382 <  }
722 >  conf->class->ref_count++;
723 >  conf->ref_count++;
724  
725    dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
726  
# Line 1399 | Line 740 | attach_connect_block(struct Client *clie
740                       const char *host)
741   {
742    dlink_node *ptr;
743 <  struct ConfItem *conf;
1403 <  struct AccessItem *aconf;
743 >  struct MaskItem *conf = NULL;
744  
745    assert(client_p != NULL);
746    assert(host != NULL);
# Line 1411 | Line 751 | attach_connect_block(struct Client *clie
751    DLINK_FOREACH(ptr, server_items.head)
752    {
753      conf = ptr->data;
1414 –    aconf = map_to_conf(conf);
754  
755 <    if (match(conf->name, name) == 0 || match(aconf->host, host) == 0)
755 >    if (match(conf->name, name) || match(conf->host, host))
756        continue;
757  
758      attach_conf(client_p, conf);
# Line 1423 | Line 762 | attach_connect_block(struct Client *clie
762    return 0;
763   }
764  
1426 – /* find_conf_exact()
1427 – *
1428 – * inputs       - type of ConfItem
1429 – *              - pointer to name to find
1430 – *              - pointer to username to find
1431 – *              - pointer to host to find
1432 – * output       - NULL or pointer to conf found
1433 – * side effects - find a conf entry which matches the hostname
1434 – *                and has the same name.
1435 – */
1436 – struct ConfItem *
1437 – find_conf_exact(ConfType type, const char *name, const char *user,
1438 –                const char *host)
1439 – {
1440 –  dlink_node *ptr;
1441 –  dlink_list *list_p;
1442 –  struct ConfItem *conf = NULL;
1443 –  struct AccessItem *aconf;
1444 –
1445 –  /* Only valid for OPER_TYPE and ...? */
1446 –  list_p = map_to_list(type);
1447 –
1448 –  DLINK_FOREACH(ptr, (*list_p).head)
1449 –  {
1450 –    conf = ptr->data;
1451 –
1452 –    if (conf->name == NULL)
1453 –      continue;
1454 –    aconf = map_to_conf(conf);
1455 –    if (aconf->host == NULL)
1456 –      continue;
1457 –    if (irccmp(conf->name, name) != 0)
1458 –      continue;
1459 –
1460 –    /*
1461 –    ** Accept if the *real* hostname (usually sockethost)
1462 –    ** socket host) matches *either* host or name field
1463 –    ** of the configuration.
1464 –    */
1465 –    if (!match(aconf->host, host) || !match(aconf->user, user))
1466 –      continue;
1467 –    if (type == OPER_TYPE)
1468 –    {
1469 –      struct ClassItem *aclass = map_to_conf(aconf->class_ptr);
1470 –
1471 –      if (aconf->clients >= MaxTotal(aclass))
1472 –        continue;
1473 –    }
1474 –
1475 –    return conf;
1476 –  }
1477 –
1478 –  return NULL;
1479 – }
1480 –
765   /* find_conf_name()
766   *
767   * inputs       - pointer to conf link list to search
# Line 1487 | Line 771 | find_conf_exact(ConfType type, const cha
771   * side effects - find a conf entry which matches the name
772   *                and has the given mask.
773   */
774 < struct ConfItem *
775 < find_conf_name(dlink_list *list, const char *name, ConfType type)
774 > struct MaskItem *
775 > find_conf_name(dlink_list *list, const char *name, enum maskitem_type type)
776   {
777    dlink_node *ptr;
778 <  struct ConfItem* conf;
778 >  struct MaskItem* conf;
779  
780    DLINK_FOREACH(ptr, list->head)
781    {
782      conf = ptr->data;
783 <    
783 >
784      if (conf->type == type)
785      {
786        if (conf->name && (irccmp(conf->name, name) == 0 ||
787 <                         match(conf->name, name)))
787 >                         !match(conf->name, name)))
788        return conf;
789      }
790    }
# Line 1515 | Line 799 | find_conf_name(dlink_list *list, const c
799   * side effects - none
800   */
801   static dlink_list *
802 < map_to_list(ConfType type)
802 > map_to_list(enum maskitem_type type)
803   {
804    switch(type)
805    {
806 <  case RXLINE_TYPE:
1523 <    return(&rxconf_items);
1524 <    break;
1525 <  case XLINE_TYPE:
806 >  case CONF_XLINE:
807      return(&xconf_items);
808      break;
809 <  case ULINE_TYPE:
809 >  case CONF_ULINE:
810      return(&uconf_items);
811      break;
812 <  case NRESV_TYPE:
812 >  case CONF_NRESV:
813      return(&nresv_items);
814      break;
815 <  case OPER_TYPE:
815 >  case CONF_CRESV:
816 >    return(&cresv_items);
817 >  case CONF_OPER:
818      return(&oconf_items);
819      break;
820 <  case CLASS_TYPE:
1538 <    return(&class_items);
1539 <    break;
1540 <  case SERVER_TYPE:
820 >  case CONF_SERVER:
821      return(&server_items);
822      break;
823 <  case CLUSTER_TYPE:
823 >  case CONF_SERVICE:
824 >    return(&service_items);
825 >    break;
826 >  case CONF_CLUSTER:
827      return(&cluster_items);
828      break;
1546 –  case CONF_TYPE:
1547 –  case GLINE_TYPE:
1548 –  case KLINE_TYPE:
1549 –  case DLINE_TYPE:
1550 –  case CRESV_TYPE:
829    default:
830      return NULL;
831    }
# Line 1559 | Line 837 | map_to_list(ConfType type)
837   *              - pointer to name string to find
838   *              - pointer to user
839   *              - pointer to host
840 < *              - optional action to match on as well
841 < * output       - NULL or pointer to found struct MatchItem
840 > *              - optional flags to match on as well
841 > * output       - NULL or pointer to found struct MaskItem
842   * side effects - looks for a match on name field
843   */
844 < struct ConfItem *
845 < find_matching_name_conf(ConfType type, const char *name, const char *user,
846 <                        const char *host, int action)
844 > struct MaskItem *
845 > find_matching_name_conf(enum maskitem_type type, const char *name, const char *user,
846 >                        const char *host, unsigned int flags)
847   {
848    dlink_node *ptr=NULL;
849 <  struct ConfItem *conf=NULL;
1572 <  struct AccessItem *aconf=NULL;
1573 <  struct MatchItem *match_item=NULL;
849 >  struct MaskItem *conf=NULL;
850    dlink_list *list_p = map_to_list(type);
851  
852    switch (type)
853    {
854 < #ifdef HAVE_LIBPCRE
855 <  case RXLINE_TYPE:
856 <      DLINK_FOREACH(ptr, list_p->head)
857 <      {
1582 <        conf = ptr->data;
1583 <        assert(conf->regexpname);
854 >  case CONF_SERVICE:
855 >    DLINK_FOREACH(ptr, list_p->head)
856 >    {
857 >      conf = ptr->data;
858  
859 <        if (!ircd_pcre_exec(conf->regexpname, name))
860 <          return conf;
861 <      }
862 <      break;
863 < #endif
864 <  case XLINE_TYPE:
865 <  case ULINE_TYPE:
866 <  case NRESV_TYPE:
859 >      if (EmptyString(conf->name))
860 >        continue;
861 >      if ((name != NULL) && !irccmp(name, conf->name))
862 >        return conf;
863 >    }
864 >    break;
865 >
866 >  case CONF_XLINE:
867 >  case CONF_ULINE:
868 >  case CONF_NRESV:
869 >  case CONF_CRESV:
870      DLINK_FOREACH(ptr, list_p->head)
871      {
872        conf = ptr->data;
873  
1597 –      match_item = map_to_conf(conf);
874        if (EmptyString(conf->name))
875 <        continue;
876 <      if ((name != NULL) && match_esc(conf->name, name))
875 >        continue;
876 >      if ((name != NULL) && !match(conf->name, name))
877        {
878 <        if ((user == NULL && (host == NULL)))
879 <          return conf;
880 <        if ((match_item->action & action) != action)
878 >        if ((user == NULL && (host == NULL)))
879 >          return conf;
880 >        if ((conf->flags & flags) != flags)
881            continue;
882 <        if (EmptyString(match_item->user) || EmptyString(match_item->host))
883 <          return conf;
884 <        if (match(match_item->user, user) && match(match_item->host, host))
885 <          return conf;
882 >        if (EmptyString(conf->user) || EmptyString(conf->host))
883 >          return conf;
884 >        if (!match(conf->user, user) && !match(conf->host, host))
885 >          return conf;
886        }
887      }
888        break;
889  
890 <  case SERVER_TYPE:
890 >  case CONF_SERVER:
891      DLINK_FOREACH(ptr, list_p->head)
892      {
893        conf = ptr->data;
1618 –      aconf = map_to_conf(conf);
894  
895 <      if ((name != NULL) && match_esc(name, conf->name))
895 >      if ((name != NULL) && !match(name, conf->name))
896          return conf;
897 <      else if ((host != NULL) && match_esc(host, aconf->host))
897 >      else if ((host != NULL) && !match(host, conf->host))
898          return conf;
899      }
900      break;
901 <  
901 >
902    default:
903      break;
904    }
# Line 1636 | Line 911 | find_matching_name_conf(ConfType type, c
911   *              - pointer to name string to find
912   *              - pointer to user
913   *              - pointer to host
914 < * output       - NULL or pointer to found struct MatchItem
914 > * output       - NULL or pointer to found struct MaskItem
915   * side effects - looks for an exact match on name field
916   */
917 < struct ConfItem *
918 < find_exact_name_conf(ConfType type, const char *name,
917 > struct MaskItem *
918 > find_exact_name_conf(enum maskitem_type type, const struct Client *who, const char *name,
919                       const char *user, const char *host)
920   {
921    dlink_node *ptr = NULL;
922 <  struct AccessItem *aconf;
923 <  struct ConfItem *conf;
1649 <  struct MatchItem *match_item;
1650 <  dlink_list *list_p;
1651 <
1652 <  list_p = map_to_list(type);
922 >  struct MaskItem *conf;
923 >  dlink_list *list_p = map_to_list(type);
924  
925    switch(type)
926    {
927 <  case RXLINE_TYPE:
928 <  case XLINE_TYPE:
929 <  case ULINE_TYPE:
930 <  case NRESV_TYPE:
927 >  case CONF_XLINE:
928 >  case CONF_ULINE:
929 >  case CONF_NRESV:
930 >  case CONF_CRESV:
931  
932      DLINK_FOREACH(ptr, list_p->head)
933      {
934        conf = ptr->data;
935 <      match_item = (struct MatchItem *)map_to_conf(conf);
935 >
936        if (EmptyString(conf->name))
937 <        continue;
938 <    
937 >        continue;
938 >
939        if (irccmp(conf->name, name) == 0)
940        {
941 <        if ((user == NULL && (host == NULL)))
942 <          return (conf);
943 <        if (EmptyString(match_item->user) || EmptyString(match_item->host))
944 <          return (conf);
945 <        if (match(match_item->user, user) && match(match_item->host, host))
946 <          return (conf);
941 >        if ((user == NULL && (host == NULL)))
942 >          return conf;
943 >        if (EmptyString(conf->user) || EmptyString(conf->host))
944 >          return conf;
945 >        if (!match(conf->user, user) && !match(conf->host, host))
946 >          return conf;
947        }
948      }
949      break;
950  
951 <  case OPER_TYPE:
951 >  case CONF_OPER:
952      DLINK_FOREACH(ptr, list_p->head)
953      {
954        conf = ptr->data;
955 <      aconf = (struct AccessItem *)map_to_conf(conf);
955 >
956        if (EmptyString(conf->name))
957 <        continue;
958 <    
959 <      if (irccmp(conf->name, name) == 0)
957 >        continue;
958 >
959 >      if (!irccmp(conf->name, name))
960        {
961 <        if ((user == NULL && (host == NULL)))
962 <          return (conf);
963 <        if (EmptyString(aconf->user) || EmptyString(aconf->host))
964 <          return (conf);
965 <        if (match(aconf->user, user) && match(aconf->host, host))
966 <          return (conf);
961 >        if (!who)
962 >          return conf;
963 >        if (EmptyString(conf->user) || EmptyString(conf->host))
964 >          return NULL;
965 >        if (!match(conf->user, who->username))
966 >        {
967 >          switch (conf->htype)
968 >          {
969 >            case HM_HOST:
970 >              if (!match(conf->host, who->host) || !match(conf->host, who->sockhost))
971 >                if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
972 >                  return conf;
973 >              break;
974 >            case HM_IPV4:
975 >              if (who->localClient->aftype == AF_INET)
976 >                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
977 >                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
978 >                    return conf;
979 >              break;
980 > #ifdef IPV6
981 >            case HM_IPV6:
982 >              if (who->localClient->aftype == AF_INET6)
983 >                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
984 >                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
985 >                    return conf;
986 >              break;
987 > #endif
988 >            default:
989 >              assert(0);
990 >          }
991 >        }
992        }
993      }
994 +
995      break;
996  
997 <  case SERVER_TYPE:
997 >  case CONF_SERVER:
998      DLINK_FOREACH(ptr, list_p->head)
999      {
1000        conf = ptr->data;
1001 <      aconf = (struct AccessItem *)map_to_conf(conf);
1001 >
1002        if (EmptyString(conf->name))
1003 <        continue;
1004 <    
1003 >        continue;
1004 >
1005        if (name == NULL)
1006        {
1007 <        if (EmptyString(aconf->host))
1008 <          continue;
1009 <        if (irccmp(aconf->host, host) == 0)
1010 <          return(conf);
1007 >        if (EmptyString(conf->host))
1008 >          continue;
1009 >        if (irccmp(conf->host, host) == 0)
1010 >          return conf;
1011        }
1012        else if (irccmp(conf->name, name) == 0)
1013 <      {
1717 <          return (conf);
1718 <      }
1013 >        return conf;
1014      }
1720 –    break;
1015  
1722 –  case CLASS_TYPE:
1723 –    DLINK_FOREACH(ptr, list_p->head)
1724 –    {
1725 –      conf = ptr->data;
1726 –      if (EmptyString(conf->name))
1727 –        continue;
1728 –    
1729 –      if (irccmp(conf->name, name) == 0)
1730 –        return (conf);
1731 –    }
1016      break;
1017  
1018    default:
1019      break;
1020    }
1021 <  return(NULL);
1021 >
1022 >  return NULL;
1023   }
1024  
1025   /* rehash()
# Line 1746 | Line 1031 | find_exact_name_conf(ConfType type, cons
1031   int
1032   rehash(int sig)
1033   {
1034 <  if (sig != 0)
1035 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1036 <                         "Got signal SIGHUP, reloading ircd.conf file");
1034 >  if (sig)
1035 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1036 >                         "Got signal SIGHUP, reloading configuration file(s)");
1037  
1038    restart_resolver();
1039  
# Line 1759 | Line 1044 | rehash(int sig)
1044  
1045    read_conf_files(0);
1046  
1047 <  if (ServerInfo.description != NULL)
1047 >  if (ServerInfo.description)
1048      strlcpy(me.info, ServerInfo.description, sizeof(me.info));
1049  
1765 – #ifndef STATIC_MODULES
1050    load_conf_modules();
1767 – #endif
1768 –
1769 –  flush_deleted_I_P();
1051  
1052    rehashed_klines = 1;
1053  
1054 <  if (ConfigLoggingEntry.use_logging)
1774 <    reopen_log(logFileName);
1775 <
1776 <  return(0);
1054 >  return 0;
1055   }
1056  
1057   /* set_default_conf()
# Line 1791 | Line 1069 | set_default_conf(void)
1069    /* verify init_class() ran, this should be an unnecessary check
1070     * but its not much work.
1071     */
1072 <  assert(class_default == (struct ConfItem *) class_items.tail->data);
1072 >  assert(class_default == class_get_list()->tail->data);
1073  
1074   #ifdef HAVE_LIBCRYPTO
1075    ServerInfo.rsa_private_key = NULL;
# Line 1801 | Line 1079 | set_default_conf(void)
1079    /* ServerInfo.name is not rehashable */
1080    /* ServerInfo.name = ServerInfo.name; */
1081    ServerInfo.description = NULL;
1082 <  DupString(ServerInfo.network_name, NETWORK_NAME_DEFAULT);
1083 <  DupString(ServerInfo.network_desc, NETWORK_DESC_DEFAULT);
1082 >  ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1083 >  ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1084  
1085    memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
1086    ServerInfo.specific_ipv4_vhost = 0;
# Line 1810 | Line 1088 | set_default_conf(void)
1088    ServerInfo.specific_ipv6_vhost = 0;
1089  
1090    ServerInfo.max_clients = MAXCLIENTS_MAX;
1091 +  ServerInfo.max_nick_length = 9;
1092 +  ServerInfo.max_topic_length = 80;
1093  
1094    ServerInfo.hub = 0;
1815 –  delete_capability("HUB");
1095    ServerInfo.dns_host.sin_addr.s_addr = 0;
1096    ServerInfo.dns_host.sin_port = 0;
1097    AdminInfo.name = NULL;
1098    AdminInfo.email = NULL;
1099    AdminInfo.description = NULL;
1100  
1101 <  set_log_level(L_NOTICE);
1101 >  log_del_all();
1102 >
1103    ConfigLoggingEntry.use_logging = 1;
1104 <  ConfigLoggingEntry.operlog[0] = '\0';
1105 <  ConfigLoggingEntry.userlog[0] = '\0';
1826 <  ConfigLoggingEntry.klinelog[0] = '\0';
1827 <  ConfigLoggingEntry.glinelog[0] = '\0';
1828 <  ConfigLoggingEntry.killlog[0] = '\0';
1829 <  ConfigLoggingEntry.operspylog[0] = '\0';
1830 <  ConfigLoggingEntry.ioerrlog[0] = '\0';
1831 <  ConfigLoggingEntry.failed_operlog[0] = '\0';
1832 <
1833 <  ConfigChannel.disable_fake_channels = NO;
1834 <  ConfigChannel.restrict_channels = NO;
1835 <  ConfigChannel.disable_local_channels = NO;
1836 <  ConfigChannel.use_invex = YES;
1837 <  ConfigChannel.use_except = YES;
1838 <  ConfigChannel.use_knock = YES;
1104 >
1105 >  ConfigChannel.disable_fake_channels = 0;
1106    ConfigChannel.knock_delay = 300;
1107    ConfigChannel.knock_delay_channel = 60;
1108 <  ConfigChannel.max_chans_per_user = 15;
1109 <  ConfigChannel.quiet_on_ban = YES;
1108 >  ConfigChannel.max_chans_per_user = 25;
1109 >  ConfigChannel.max_chans_per_oper = 50;
1110    ConfigChannel.max_bans = 25;
1111    ConfigChannel.default_split_user_count = 0;
1112    ConfigChannel.default_split_server_count = 0;
1113 <  ConfigChannel.no_join_on_split = NO;
1114 <  ConfigChannel.no_create_on_split = NO;
1848 <  ConfigChannel.burst_topicwho = YES;
1113 >  ConfigChannel.no_join_on_split = 0;
1114 >  ConfigChannel.no_create_on_split = 0;
1115  
1116 <  ConfigServerHide.flatten_links = NO;
1116 >  ConfigServerHide.flatten_links = 0;
1117    ConfigServerHide.links_delay = 300;
1118 <  ConfigServerHide.hidden = NO;
1119 <  ConfigServerHide.disable_hidden = NO;
1120 <  ConfigServerHide.hide_servers = NO;
1121 <  DupString(ConfigServerHide.hidden_name, NETWORK_NAME_DEFAULT);
1122 <  ConfigServerHide.hide_server_ips = NO;
1118 >  ConfigServerHide.hidden = 0;
1119 >  ConfigServerHide.hide_servers = 0;
1120 >  ConfigServerHide.hide_services = 0;
1121 >  ConfigServerHide.hidden_name = xstrdup(NETWORK_NAME_DEFAULT);
1122 >  ConfigServerHide.hide_server_ips = 0;
1123 >  ConfigServerHide.disable_remote_commands = 0;
1124  
1125 <  
1125 >  ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1126    ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
1127 +  ConfigFileEntry.cycle_on_host_change = 1;
1128 +  ConfigFileEntry.glines = 0;
1129 +  ConfigFileEntry.gline_time = 12 * 3600;
1130 +  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
1131    ConfigFileEntry.gline_min_cidr = 16;
1132    ConfigFileEntry.gline_min_cidr6 = 48;
1133 <  ConfigFileEntry.invisible_on_connect = YES;
1134 <  ConfigFileEntry.burst_away = NO;
1135 <  ConfigFileEntry.use_whois_actually = YES;
1136 <  ConfigFileEntry.tkline_expire_notices = YES;
1137 <  ConfigFileEntry.hide_spoof_ips = YES;
1867 <  ConfigFileEntry.ignore_bogus_ts = NO;
1868 <  ConfigFileEntry.disable_auth = NO;
1869 <  ConfigFileEntry.disable_remote = NO;
1133 >  ConfigFileEntry.invisible_on_connect = 1;
1134 >  ConfigFileEntry.tkline_expire_notices = 1;
1135 >  ConfigFileEntry.hide_spoof_ips = 1;
1136 >  ConfigFileEntry.ignore_bogus_ts = 0;
1137 >  ConfigFileEntry.disable_auth = 0;
1138    ConfigFileEntry.kill_chase_time_limit = 90;
1139 <  ConfigFileEntry.default_floodcount = 8; /* XXX */
1140 <  ConfigFileEntry.failed_oper_notice = YES;
1141 <  ConfigFileEntry.dots_in_ident = 0;      /* XXX */
1874 <  ConfigFileEntry.dot_in_ip6_addr = YES;
1139 >  ConfigFileEntry.default_floodcount = 8;
1140 >  ConfigFileEntry.failed_oper_notice = 1;
1141 >  ConfigFileEntry.dots_in_ident = 0;
1142    ConfigFileEntry.min_nonwildcard = 4;
1143    ConfigFileEntry.min_nonwildcard_simple = 3;
1144    ConfigFileEntry.max_accept = 20;
1145 <  ConfigFileEntry.anti_nick_flood = NO;   /* XXX */
1145 >  ConfigFileEntry.anti_nick_flood = 0;
1146    ConfigFileEntry.max_nick_time = 20;
1147    ConfigFileEntry.max_nick_changes = 5;
1148 <  ConfigFileEntry.anti_spam_exit_message_time = 0;  /* XXX */
1148 >  ConfigFileEntry.anti_spam_exit_message_time = 0;
1149    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1150 <  ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;  /* XXX */
1151 <  ConfigFileEntry.kline_with_reason = YES;
1152 <  ConfigFileEntry.kline_reason = NULL;
1886 <  ConfigFileEntry.warn_no_nline = YES;
1887 <  ConfigFileEntry.stats_o_oper_only = NO; /* XXX */
1150 >  ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1151 >  ConfigFileEntry.warn_no_nline = 1;
1152 >  ConfigFileEntry.stats_o_oper_only = 0;
1153    ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
1154    ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
1155 <  ConfigFileEntry.stats_P_oper_only = NO;
1155 >  ConfigFileEntry.stats_P_oper_only = 0;
1156 >  ConfigFileEntry.stats_u_oper_only = 0;
1157    ConfigFileEntry.caller_id_wait = 60;
1158 <  ConfigFileEntry.opers_bypass_callerid = NO;
1158 >  ConfigFileEntry.opers_bypass_callerid = 0;
1159    ConfigFileEntry.pace_wait = 10;
1160    ConfigFileEntry.pace_wait_simple = 1;
1161 <  ConfigFileEntry.short_motd = NO;
1162 <  ConfigFileEntry.ping_cookie = NO;
1163 <  ConfigFileEntry.no_oper_flood = NO;     /* XXX */
1164 <  ConfigFileEntry.true_no_oper_flood = NO;  /* XXX */
1165 <  ConfigFileEntry.oper_pass_resv = YES;
1900 <  ConfigFileEntry.glines = NO;            /* XXX */
1901 <  ConfigFileEntry.gline_time = 12 * 3600; /* XXX */
1902 <  ConfigFileEntry.idletime = 0;
1161 >  ConfigFileEntry.short_motd = 0;
1162 >  ConfigFileEntry.ping_cookie = 0;
1163 >  ConfigFileEntry.no_oper_flood = 0;
1164 >  ConfigFileEntry.true_no_oper_flood = 0;
1165 >  ConfigFileEntry.oper_pass_resv = 1;
1166    ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
1167 <  ConfigFileEntry.client_flood = CLIENT_FLOOD_DEFAULT;
1905 <  ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;  /* XXX */
1167 >  ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
1168    ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
1169 <    UMODE_OPERWALL | UMODE_WALLOP;        /* XXX */
1170 <  DupString(ConfigFileEntry.servlink_path, SLPATH);
1909 < #ifdef HAVE_LIBCRYPTO
1910 <  /* jdc -- This is our default value for a cipher.  According to the
1911 <   *        CRYPTLINK document (doc/cryptlink.txt), BF/128 must be supported
1912 <   *        under all circumstances if cryptlinks are enabled.  So,
1913 <   *        this will be our default.
1914 <   *
1915 <   *        NOTE: I apologise for the hard-coded value of "1" (BF/128).
1916 <   *              This should be moved into a find_cipher() routine.
1917 <   */
1918 <  ConfigFileEntry.default_cipher_preference = &CipherTable[1];
1919 < #endif
1920 <  ConfigFileEntry.use_egd = NO;
1169 >    UMODE_OPERWALL | UMODE_WALLOP;
1170 >  ConfigFileEntry.use_egd = 0;
1171    ConfigFileEntry.egdpool_path = NULL;
1922 – #ifdef HAVE_LIBZ
1923 –  ConfigFileEntry.compression_level = 0;
1924 – #endif
1172    ConfigFileEntry.throttle_time = 10;
1173   }
1174  
1175 < /* read_conf()
1175 > static void
1176 > validate_conf(void)
1177 > {
1178 >  if (ConfigFileEntry.ts_warn_delta < TS_WARN_DELTA_MIN)
1179 >    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1180 >
1181 >  if (ConfigFileEntry.ts_max_delta < TS_MAX_DELTA_MIN)
1182 >    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1183 >
1184 >  if (ServerInfo.network_name == NULL)
1185 >    ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1186 >
1187 >  if (ServerInfo.network_desc == NULL)
1188 >    ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1189 >
1190 >  if (ConfigFileEntry.service_name == NULL)
1191 >    ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1192 >
1193 >  ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
1194 > }
1195 >
1196 > /* read_conf()
1197   *
1198   * inputs       - file descriptor pointing to config file to use
1199   * output       - None
1200   * side effects - Read configuration file.
1201   */
1202   static void
1203 < read_conf(FBFILE *file)
1203 > read_conf(FILE *file)
1204   {
1205    lineno = 0;
1206  
1207    set_default_conf(); /* Set default values prior to conf parsing */
1208    conf_parser_ctx.pass = 1;
1209 <  yyparse();          /* pick up the classes first */
1209 >  yyparse();          /* pick up the classes first */
1210  
1211 <  fbrewind(file);
1211 >  rewind(file);
1212  
1213    conf_parser_ctx.pass = 2;
1214    yyparse();          /* Load the values from the conf */
1215    validate_conf();    /* Check to make sure some values are still okay. */
1216                        /* Some global values are also loaded here. */
1217 <  check_class();      /* Make sure classes are valid */
1950 < }
1951 <
1952 < static void
1953 < validate_conf(void)
1954 < {
1955 <  if (ConfigFileEntry.ts_warn_delta < TS_WARN_DELTA_MIN)
1956 <    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1957 <
1958 <  if (ConfigFileEntry.ts_max_delta < TS_MAX_DELTA_MIN)
1959 <    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1960 <
1961 <  if (ConfigFileEntry.servlink_path == NULL)
1962 <    DupString(ConfigFileEntry.servlink_path, SLPATH);
1963 <
1964 <  if (ServerInfo.network_name == NULL)
1965 <    DupString(ServerInfo.network_name,NETWORK_NAME_DEFAULT);
1966 <
1967 <  if (ServerInfo.network_desc == NULL)
1968 <    DupString(ServerInfo.network_desc,NETWORK_DESC_DEFAULT);
1969 <
1970 <  if ((ConfigFileEntry.client_flood < CLIENT_FLOOD_MIN) ||
1971 <      (ConfigFileEntry.client_flood > CLIENT_FLOOD_MAX))
1972 <    ConfigFileEntry.client_flood = CLIENT_FLOOD_MAX;
1973 <
1974 <  ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
1217 >  class_delete_marked();      /* Make sure classes are valid */
1218   }
1219  
1220   /* lookup_confhost()
# Line 1979 | Line 1222 | validate_conf(void)
1222   * start DNS lookups of all hostnames in the conf
1223   * line and convert an IP addresses in a.b.c.d number for to IP#s.
1224   */
1225 < static void
1226 < lookup_confhost(struct ConfItem *conf)
1225 > void
1226 > lookup_confhost(struct MaskItem *conf)
1227   {
1985 –  struct AccessItem *aconf;
1228    struct addrinfo hints, *res;
1229  
1988 –  aconf = map_to_conf(conf);
1989 –
1990 –  if (EmptyString(aconf->host) ||
1991 –      EmptyString(aconf->user))
1992 –  {
1993 –    ilog(L_ERROR, "Host/server name error: (%s) (%s)",
1994 –         aconf->host, conf->name);
1995 –    return;
1996 –  }
1997 –
1998 –  if (strchr(aconf->host, '*') ||
1999 –      strchr(aconf->host, '?'))
2000 –    return;
2001 –
1230    /* Do name lookup now on hostnames given and store the
1231     * ip numbers in conf structure.
1232     */
# Line 2010 | Line 1238 | lookup_confhost(struct ConfItem *conf)
1238    /* Get us ready for a bind() and don't bother doing dns lookup */
1239    hints.ai_flags = AI_PASSIVE | AI_NUMERICHOST;
1240  
1241 <  if (irc_getaddrinfo(aconf->host, NULL, &hints, &res))
1241 >  if (getaddrinfo(conf->host, NULL, &hints, &res))
1242    {
1243 <    conf_dns_lookup(aconf);
1243 >    conf_dns_lookup(conf);
1244      return;
1245    }
1246  
1247 <  assert(res != NULL);
1247 >  assert(res);
1248  
1249 <  memcpy(&aconf->ipnum, res->ai_addr, res->ai_addrlen);
1250 <  aconf->ipnum.ss_len = res->ai_addrlen;
1251 <  aconf->ipnum.ss.ss_family = res->ai_family;
1252 <  irc_freeaddrinfo(res);
1249 >  memcpy(&conf->addr, res->ai_addr, res->ai_addrlen);
1250 >  conf->addr.ss_len = res->ai_addrlen;
1251 >  conf->addr.ss.ss_family = res->ai_family;
1252 >
1253 >  freeaddrinfo(res);
1254   }
1255  
1256   /* conf_connect_allowed()
# Line 2035 | Line 1264 | int
1264   conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
1265   {
1266    struct ip_entry *ip_found;
1267 <  struct AccessItem *aconf = find_dline_conf(addr, aftype);
1267 >  struct MaskItem *conf = find_dline_conf(addr, aftype);
1268  
1269    /* DLINE exempt also gets you out of static limits/pacing... */
1270 <  if (aconf && (aconf->status & CONF_EXEMPTDLINE))
1270 >  if (conf && (conf->type == CONF_EXEMPT))
1271      return 0;
1272  
1273 <  if (aconf != NULL)
1273 >  if (conf)
1274      return BANNED_CLIENT;
1275  
1276    ip_found = find_or_add_ip(addr);
# Line 2057 | Line 1286 | conf_connect_allowed(struct irc_ssaddr *
1286    return 0;
1287   }
1288  
2060 – static struct AccessItem *
2061 – find_regexp_kline(const char *uhi[])
2062 – {
2063 – #ifdef HAVE_LIBPCRE
2064 –  const dlink_node *ptr = NULL;
2065 –
2066 –  DLINK_FOREACH(ptr, rkconf_items.head)
2067 –  {
2068 –    struct AccessItem *aptr = map_to_conf(ptr->data);
2069 –
2070 –    assert(aptr->regexuser);
2071 –    assert(aptr->regexhost);
2072 –
2073 –    if (!ircd_pcre_exec(aptr->regexuser, uhi[0]) &&
2074 –        (!ircd_pcre_exec(aptr->regexhost, uhi[1]) ||
2075 –         !ircd_pcre_exec(aptr->regexhost, uhi[2])))
2076 –      return aptr;
2077 –  }
2078 – #endif
2079 –  return NULL;
2080 – }
2081 –
2082 – /* find_kill()
2083 – *
2084 – * inputs       - pointer to client structure
2085 – * output       - pointer to struct AccessItem if found
2086 – * side effects - See if this user is klined already,
2087 – *                and if so, return struct AccessItem pointer
2088 – */
2089 – struct AccessItem *
2090 – find_kill(struct Client *client_p)
2091 – {
2092 –  struct AccessItem *aconf = NULL;
2093 –  const char *uhi[3];
2094 –
2095 –  uhi[0] = client_p->username;
2096 –  uhi[1] = client_p->host;
2097 –  uhi[2] = client_p->sockhost;
2098 –
2099 –  assert(client_p != NULL);
2100 –
2101 –  aconf = find_kline_conf(client_p->host, client_p->username,
2102 –                          &client_p->localClient->ip,
2103 –                          client_p->localClient->aftype);
2104 –  if (aconf == NULL)
2105 –    aconf = find_regexp_kline(uhi);
2106 –
2107 –  if (aconf && (aconf->status & CONF_KLINE))
2108 –    return aconf;
2109 –
2110 –  return NULL;
2111 – }
2112 –
2113 – struct AccessItem *
2114 – find_gline(struct Client *client_p)
2115 – {
2116 –  struct AccessItem *aconf;
2117 –
2118 –  assert(client_p != NULL);
2119 –
2120 –  aconf = find_gline_conf(client_p->host, client_p->username,
2121 –                          &client_p->localClient->ip,
2122 –                          client_p->localClient->aftype);
2123 –
2124 –  if (aconf && (aconf->status & CONF_GLINE))
2125 –    return aconf;
2126 –
2127 –  return NULL;
2128 – }
2129 –
2130 – /* add_temp_line()
2131 – *
2132 – * inputs        - pointer to struct ConfItem
2133 – * output        - none
2134 – * Side effects  - links in given struct ConfItem into
2135 – *                 temporary *line link list
2136 – */
2137 – void
2138 – add_temp_line(struct ConfItem *conf)
2139 – {
2140 –  struct AccessItem *aconf;
2141 –
2142 –  if (conf->type == DLINE_TYPE)
2143 –  {
2144 –    aconf = map_to_conf(conf);
2145 –    SetConfTemporary(aconf);
2146 –    dlinkAdd(conf, &conf->node, &temporary_dlines);
2147 –    MyFree(aconf->user);
2148 –    aconf->user = NULL;
2149 –    add_conf_by_address(CONF_DLINE, aconf);
2150 –  }
2151 –  else if (conf->type == KLINE_TYPE)
2152 –  {
2153 –    aconf = map_to_conf(conf);
2154 –    SetConfTemporary(aconf);
2155 –    dlinkAdd(conf, &conf->node, &temporary_klines);
2156 –    add_conf_by_address(CONF_KILL, aconf);
2157 –  }
2158 –  else if (conf->type == GLINE_TYPE)
2159 –  {
2160 –    aconf = map_to_conf(conf);
2161 –    SetConfTemporary(aconf);
2162 –    dlinkAdd(conf, &conf->node, &temporary_glines);
2163 –    add_conf_by_address(CONF_GLINE, aconf);
2164 –  }
2165 –  else if (conf->type == XLINE_TYPE)
2166 –  {
2167 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2168 –    dlinkAdd(conf, make_dlink_node(), &temporary_xlines);
2169 –  }
2170 –  else if (conf->type == RXLINE_TYPE)
2171 –  {
2172 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2173 –    dlinkAdd(conf, make_dlink_node(), &temporary_rxlines);
2174 –  }
2175 –  else if (conf->type == RKLINE_TYPE)
2176 –  {
2177 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2178 –    dlinkAdd(conf, make_dlink_node(), &temporary_rklines);
2179 –  }
2180 –  else if ((conf->type == NRESV_TYPE) || (conf->type == CRESV_TYPE))
2181 –  {
2182 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2183 –    dlinkAdd(conf, make_dlink_node(), &temporary_resv);
2184 –  }
2185 – }
2186 –
1289   /* cleanup_tklines()
1290   *
1291   * inputs       - NONE
# Line 2194 | Line 1296 | add_temp_line(struct ConfItem *conf)
1296   void
1297   cleanup_tklines(void *notused)
1298   {
1299 <  expire_tklines(&temporary_glines);
1300 <  expire_tklines(&temporary_klines);
1301 <  expire_tklines(&temporary_dlines);
1302 <  expire_tklines(&temporary_xlines);
2201 <  expire_tklines(&temporary_rxlines);
2202 <  expire_tklines(&temporary_rklines);
2203 <  expire_tklines(&temporary_resv);
1299 >  hostmask_expire_temporary();
1300 >  expire_tklines(&xconf_items);
1301 >  expire_tklines(&nresv_items);
1302 >  expire_tklines(&cresv_items);
1303   }
1304  
1305   /* expire_tklines()
# Line 2212 | Line 1311 | cleanup_tklines(void *notused)
1311   static void
1312   expire_tklines(dlink_list *tklist)
1313   {
1314 <  dlink_node *ptr;
1315 <  dlink_node *next_ptr;
2217 <  struct ConfItem *conf;
2218 <  struct MatchItem *xconf;
2219 <  struct MatchItem *nconf;
2220 <  struct AccessItem *aconf;
2221 <  struct ResvChannel *cconf;
1314 >  dlink_node *ptr = NULL, *ptr_next = NULL;
1315 >  struct MaskItem *conf = NULL;
1316  
1317 <  DLINK_FOREACH_SAFE(ptr, next_ptr, tklist->head)
1317 >  DLINK_FOREACH_SAFE(ptr, ptr_next, tklist->head)
1318    {
1319      conf = ptr->data;
2226 –    if (conf->type == GLINE_TYPE ||
2227 –        conf->type == KLINE_TYPE ||
2228 –        conf->type == DLINE_TYPE)
2229 –    {
2230 –      aconf = (struct AccessItem *)map_to_conf(conf);
2231 –      if (aconf->hold <= CurrentTime)
2232 –      {
2233 –        /* XXX - Do we want GLINE expiry notices?? */
2234 –        /* Alert opers that a TKline expired - Hwy */
2235 –        if (ConfigFileEntry.tkline_expire_notices)
2236 –        {
2237 –          if (aconf->status & CONF_KILL)
2238 –          {
2239 –            sendto_realops_flags(UMODE_ALL, L_ALL,
2240 –                                 "Temporary K-line for [%s@%s] expired",
2241 –                                 (aconf->user) ? aconf->user : "*",
2242 –                                 (aconf->host) ? aconf->host : "*");
2243 –          }
2244 –          else if (conf->type == DLINE_TYPE)
2245 –          {
2246 –            sendto_realops_flags(UMODE_ALL, L_ALL,
2247 –                                 "Temporary D-line for [%s] expired",
2248 –                                 (aconf->host) ? aconf->host : "*");
2249 –          }
2250 –        }
1320  
1321 <        dlinkDelete(ptr, tklist);
1322 <        delete_one_address_conf(aconf->host, aconf);
1323 <      }
1324 <    }
2256 <    else if (conf->type == XLINE_TYPE ||
2257 <             conf->type == RXLINE_TYPE)
2258 <    {
2259 <      xconf = (struct MatchItem *)map_to_conf(conf);
2260 <      if (xconf->hold <= CurrentTime)
2261 <      {
2262 <        if (ConfigFileEntry.tkline_expire_notices)
2263 <          sendto_realops_flags(UMODE_ALL, L_ALL,
2264 <                               "Temporary X-line for [%s] %sexpired", conf->name,
2265 <                               conf->type == RXLINE_TYPE ? "(REGEX) " : "");
2266 <        dlinkDelete(ptr, tklist);
2267 <        free_dlink_node(ptr);
2268 <        delete_conf_item(conf);
2269 <      }
2270 <    }
2271 <    else if (conf->type == RKLINE_TYPE)
1321 >    if (!conf->until || conf->until > CurrentTime)
1322 >      continue;
1323 >
1324 >    if (conf->type == CONF_XLINE)
1325      {
1326 <      aconf = map_to_conf(conf);
1327 <      if (aconf->hold <= CurrentTime)
1328 <      {
1329 <        if (ConfigFileEntry.tkline_expire_notices)
2277 <           sendto_realops_flags(UMODE_ALL, L_ALL,
2278 <                                "Temporary K-line for [%s@%s] (REGEX) expired",
2279 <                                (aconf->user) ? aconf->user : "*",
2280 <                                (aconf->host) ? aconf->host : "*");
2281 <        dlinkDelete(ptr, tklist);
2282 <        free_dlink_node(ptr);
2283 <        delete_conf_item(conf);
2284 <      }
1326 >      if (ConfigFileEntry.tkline_expire_notices)
1327 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1328 >                               "Temporary X-line for [%s] expired", conf->name);
1329 >      conf_free(conf);
1330      }
1331 <    else if (conf->type == NRESV_TYPE)
1331 >    else if (conf->type == CONF_NRESV || conf->type == CONF_CRESV)
1332      {
1333 <      nconf = (struct MatchItem *)map_to_conf(conf);
1334 <      if (nconf->hold <= CurrentTime)
2290 <      {
2291 <        if (ConfigFileEntry.tkline_expire_notices)
2292 <          sendto_realops_flags(UMODE_ALL, L_ALL,
1333 >      if (ConfigFileEntry.tkline_expire_notices)
1334 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1335                                 "Temporary RESV for [%s] expired", conf->name);
1336 <        dlinkDelete(ptr, tklist);
2295 <        free_dlink_node(ptr);
2296 <        delete_conf_item(conf);
2297 <      }
2298 <    }
2299 <    else if (conf->type == CRESV_TYPE)
2300 <    {
2301 <      cconf = (struct ResvChannel *)map_to_conf(conf);
2302 <      if (cconf->hold <= CurrentTime)
2303 <      {
2304 <        if (ConfigFileEntry.tkline_expire_notices)
2305 <          sendto_realops_flags(UMODE_ALL, L_ALL,
2306 <                               "Temporary RESV for [%s] expired", cconf->name);
2307 <        delete_channel_resv(cconf);
2308 <      }
1336 >      conf_free(conf);
1337      }
1338    }
1339   }
# Line 2318 | Line 1346 | expire_tklines(dlink_list *tklist)
1346   */
1347   static const struct oper_privs
1348   {
1349 <  const unsigned int oprivs;
2322 <  const unsigned int hidden;
1349 >  const unsigned int flag;
1350    const unsigned char c;
1351   } flag_list[] = {
1352 <  { OPER_FLAG_ADMIN,       OPER_FLAG_HIDDEN_ADMIN,  'A' },
1353 <  { OPER_FLAG_REMOTEBAN,   0,                       'B' },
1354 <  { OPER_FLAG_DIE,         0,                       'D' },
1355 <  { OPER_FLAG_GLINE,       0,                       'G' },
1356 <  { OPER_FLAG_REHASH,      0,                       'H' },
1357 <  { OPER_FLAG_K,           0,                       'K' },
1358 <  { OPER_FLAG_OPERWALL,    0,                       'L' },
1359 <  { OPER_FLAG_N,           0,                       'N' },
1360 <  { OPER_FLAG_GLOBAL_KILL, 0,                       'O' },
1361 <  { OPER_FLAG_REMOTE,      0,                       'R' },
1362 <  { OPER_FLAG_OPER_SPY,    0,                       'S' },
1363 <  { OPER_FLAG_UNKLINE,     0,                       'U' },
1364 <  { OPER_FLAG_X,           0,                       'X' },
1365 <  { 0, 0, '\0' }
1352 >  { OPER_FLAG_ADMIN,          'A' },
1353 >  { OPER_FLAG_REMOTEBAN,      'B' },
1354 >  { OPER_FLAG_DIE,            'D' },
1355 >  { OPER_FLAG_GLINE,          'G' },
1356 >  { OPER_FLAG_REHASH,         'H' },
1357 >  { OPER_FLAG_K,              'K' },
1358 >  { OPER_FLAG_OPERWALL,       'L' },
1359 >  { OPER_FLAG_KILL,           'N' },
1360 >  { OPER_FLAG_KILL_REMOTE,    'O' },
1361 >  { OPER_FLAG_CONNECT,        'P' },
1362 >  { OPER_FLAG_CONNECT_REMOTE, 'Q' },
1363 >  { OPER_FLAG_SQUIT,          'R' },
1364 >  { OPER_FLAG_SQUIT_REMOTE,   'S' },
1365 >  { OPER_FLAG_UNKLINE,        'U' },
1366 >  { OPER_FLAG_XLINE,          'X' },
1367 >  { 0, '\0' }
1368   };
1369  
1370   char *
1371   oper_privs_as_string(const unsigned int port)
1372   {
1373 <  static char privs_out[16];
1373 >  static char privs_out[IRCD_BUFSIZE];
1374    char *privs_ptr = privs_out;
2346 –  unsigned int i = 0;
1375  
1376 <  for (; flag_list[i].oprivs; ++i)
1376 >  for (const struct oper_privs *opriv = flag_list; opriv->flag; ++opriv)
1377    {
1378 <    if ((port & flag_list[i].oprivs) &&
1379 <        (port & flag_list[i].hidden) == 0)
2352 <      *privs_ptr++ = flag_list[i].c;
1378 >    if (port & opriv->flag)
1379 >      *privs_ptr++ = opriv->c;
1380      else
1381 <      *privs_ptr++ = ToLowerTab[flag_list[i].c];
1381 >      *privs_ptr++ = ToLower(opriv->c);
1382    }
1383  
1384    *privs_ptr = '\0';
# Line 2365 | Line 1392 | oper_privs_as_string(const unsigned int
1392   *         "oper" is server name for remote opers
1393   * Side effects: None.
1394   */
1395 < char *
1395 > const char *
1396   get_oper_name(const struct Client *client_p)
1397   {
1398 <  dlink_node *cnode;
2372 <  struct ConfItem *conf;
2373 <  struct AccessItem *aconf;
2374 <
1398 >  const dlink_node *cnode = NULL;
1399    /* +5 for !,@,{,} and null */
1400 <  static char buffer[NICKLEN+USERLEN+HOSTLEN+HOSTLEN+5];
1400 >  static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
1401  
1402    if (MyConnect(client_p))
1403    {
1404 <    DLINK_FOREACH(cnode, client_p->localClient->confs.head)
1404 >    if ((cnode = client_p->localClient->confs.head))
1405      {
1406 <      conf = cnode->data;
2383 <      aconf = map_to_conf(conf);
1406 >      const struct MaskItem *conf = cnode->data;
1407  
1408 <      if (IsConfOperator(aconf))
1408 >      if (IsConfOperator(conf))
1409        {
1410 <        ircsprintf(buffer, "%s!%s@%s{%s}", client_p->name,
1411 <                   client_p->username, client_p->host,
1412 <                   conf->name);
2390 <        return buffer;
1410 >        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1411 >                 client_p->username, client_p->host, conf->name);
1412 >        return buffer;
1413        }
1414      }
1415  
1416 <    /* Probably should assert here for now. If there is an oper out there
1416 >    /* Probably should assert here for now. If there is an oper out there
1417       * with no oper{} conf attached, it would be good for us to know...
1418       */
1419      assert(0); /* Oper without oper conf! */
1420    }
1421  
1422 <  ircsprintf(buffer, "%s!%s@%s{%s}", client_p->name,
1423 <             client_p->username, client_p->host, client_p->servptr->name);
1422 >  snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1423 >           client_p->username, client_p->host, client_p->servptr->name);
1424    return buffer;
1425   }
1426  
# Line 2412 | Line 1434 | void
1434   read_conf_files(int cold)
1435   {
1436    const char *filename;
1437 <  char chanmodes[32];
1438 <  char chanlimit[32];
1437 >  char chanmodes[IRCD_BUFSIZE];
1438 >  char chanlimit[IRCD_BUFSIZE];
1439  
1440    conf_parser_ctx.boot = cold;
1441 <  filename = get_conf_name(CONF_TYPE);
1441 >  filename = ConfigFileEntry.configfile;
1442  
1443    /* We need to know the initial filename for the yyerror() to report
1444       FIXME: The full path is in conffilenamebuf first time since we
1445               dont know anything else
1446  
1447 <     - Gozem 2002-07-21
1447 >     - Gozem 2002-07-21
1448    */
1449    strlcpy(conffilebuf, filename, sizeof(conffilebuf));
1450  
1451 <  if ((conf_parser_ctx.conf_file = fbopen(filename, "r")) == NULL)
1451 >  if ((conf_parser_ctx.conf_file = fopen(filename, "r")) == NULL)
1452    {
1453      if (cold)
1454      {
1455 <      ilog(L_CRIT, "Unable to read configuration file '%s': %s",
1455 >      ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
1456             filename, strerror(errno));
1457        exit(-1);
1458      }
1459      else
1460      {
1461 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1462 <                           "Unable to read configuration file '%s': %s",
1463 <                           filename, strerror(errno));
1461 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1462 >                           "Unable to read configuration file '%s': %s",
1463 >                           filename, strerror(errno));
1464        return;
1465      }
1466    }
# Line 2447 | Line 1469 | read_conf_files(int cold)
1469      clear_out_old_conf();
1470  
1471    read_conf(conf_parser_ctx.conf_file);
1472 <  fbclose(conf_parser_ctx.conf_file);
1472 >  fclose(conf_parser_ctx.conf_file);
1473  
1474 +  log_reopen_all();
1475 +
1476 +  add_isupport("NICKLEN", NULL, ServerInfo.max_nick_length);
1477    add_isupport("NETWORK", ServerInfo.network_name, -1);
1478 <  ircsprintf(chanmodes, "b%s%s:%d", ConfigChannel.use_except ? "e" : "",
1479 <             ConfigChannel.use_invex ? "I" : "", ConfigChannel.max_bans);
1478 >
1479 >  snprintf(chanmodes, sizeof(chanmodes), "beI:%d", ConfigChannel.max_bans);
1480    add_isupport("MAXLIST", chanmodes, -1);
1481    add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1482 <  if (ConfigChannel.disable_local_channels)
1483 <    add_isupport("CHANTYPES", "#", -1);
1484 <  else
1485 <    add_isupport("CHANTYPES", "#&", -1);
2461 <  ircsprintf(chanlimit, "%s:%d", ConfigChannel.disable_local_channels ? "#" : "#&",
2462 <             ConfigChannel.max_chans_per_user);
1482 >  add_isupport("CHANTYPES", "#", -1);
1483 >
1484 >  snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1485 >           ConfigChannel.max_chans_per_user);
1486    add_isupport("CHANLIMIT", chanlimit, -1);
1487 <  ircsprintf(chanmodes, "%s%s%s", ConfigChannel.use_except ? "e" : "",
2465 <             ConfigChannel.use_invex ? "I" : "", "b,k,l,imnpst");
1487 >  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,imnprstORS");
1488    add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
1489 <  if (ConfigChannel.use_except)
2468 <    add_isupport("EXCEPTS", "e", -1);
2469 <  if (ConfigChannel.use_invex)
2470 <    add_isupport("INVEX", "I", -1);
1489 >  add_isupport("TOPICLEN", NULL, ServerInfo.max_topic_length);
1490    add_isupport("CHANMODES", chanmodes, -1);
1491  
1492    /*
# Line 2475 | Line 1494 | read_conf_files(int cold)
1494     * on strlen(form_str(RPL_ISUPPORT))
1495     */
1496    rebuild_isupport_message_line();
2478 –
2479 – #ifdef HAVE_LIBPCRE
2480 –  parse_conf_file(RKLINE_TYPE, cold);
2481 –  parse_conf_file(RXLINE_TYPE, cold);
2482 – #endif
2483 –  parse_conf_file(KLINE_TYPE, cold);
2484 –  parse_conf_file(DLINE_TYPE, cold);
2485 –  parse_conf_file(XLINE_TYPE, cold);
2486 –  parse_conf_file(NRESV_TYPE, cold);
2487 –  parse_conf_file(CRESV_TYPE, cold);
2488 – }
2489 –
2490 – /* parse_conf_file()
2491 – *
2492 – * inputs       - type of conf file to parse
2493 – * output       - none
2494 – * side effects - conf file for givenconf type is opened and read then parsed
2495 – */
2496 – static void
2497 – parse_conf_file(int type, int cold)
2498 – {
2499 –  FBFILE *file = NULL;
2500 –  const char *filename = get_conf_name(type);
2501 –
2502 –  if ((file = fbopen(filename, "r")) == NULL)
2503 –  {
2504 –    if (cold)
2505 –      ilog(L_ERROR, "Unable to read configuration file '%s': %s",
2506 –           filename, strerror(errno));
2507 –    else
2508 –      sendto_realops_flags(UMODE_ALL, L_ALL,
2509 –                    "Unable to read configuration file '%s': %s",
2510 –                           filename, strerror(errno));
2511 –  }
2512 –  else
2513 –  {
2514 –    parse_csv_file(file, type);
2515 –    fbclose(file);
2516 –  }
1497   }
1498  
1499   /* clear_out_old_conf()
# Line 2526 | Line 1506 | static void
1506   clear_out_old_conf(void)
1507   {
1508    dlink_node *ptr = NULL, *next_ptr = NULL;
1509 <  struct ConfItem *conf;
2530 <  struct AccessItem *aconf;
2531 <  struct ClassItem *cltmp;
2532 <  struct MatchItem *match_item;
1509 >  struct MaskItem *conf;
1510    dlink_list *free_items [] = {
1511 <    &server_items,   &oconf_items,    &hub_items, &leaf_items,
1512 <     &uconf_items,   &xconf_items, &rxconf_items, &rkconf_items,
1513 <     &nresv_items, &cluster_items,  &gdeny_items, NULL
1511 >    &server_items,   &oconf_items,
1512 >     &uconf_items,   &xconf_items,
1513 >     &nresv_items, &cluster_items,  &service_items, &cresv_items, NULL
1514    };
1515  
1516    dlink_list ** iterator = free_items; /* C is dumb */
# Line 2541 | Line 1518 | clear_out_old_conf(void)
1518    /* We only need to free anything allocated by yyparse() here.
1519     * Resetting structs, etc, is taken care of by set_default_conf().
1520     */
1521 <  
1521 >
1522    for (; *iterator != NULL; iterator++)
1523    {
1524      DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
1525      {
1526        conf = ptr->data;
2550 –      /* XXX This is less than pretty */
2551 –      if (conf->type == SERVER_TYPE)
2552 –      {
2553 –        aconf = map_to_conf(conf);
1527  
1528 <        if (aconf->clients != 0)
2556 <        {
2557 <          SetConfIllegal(aconf);
2558 <          dlinkDelete(&conf->node, &server_items);
2559 <        }
2560 <        else
2561 <        {
2562 <          delete_conf_item(conf);
2563 <        }
2564 <      }
2565 <      else if (conf->type == OPER_TYPE)
2566 <      {
2567 <        aconf = map_to_conf(conf);
1528 >      dlinkDelete(&conf->node, map_to_list(conf->type));
1529  
1530 <        if (aconf->clients != 0)
1531 <        {
2571 <          SetConfIllegal(aconf);
2572 <          dlinkDelete(&conf->node, &oconf_items);
2573 <        }
2574 <        else
2575 <        {
2576 <          delete_conf_item(conf);
2577 <        }
2578 <      }
2579 <      else if (conf->type == CLIENT_TYPE)
1530 >      /* XXX This is less than pretty */
1531 >      if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
1532        {
1533 <        aconf = map_to_conf(conf);
1534 <
2583 <        if (aconf->clients != 0)
2584 <        {
2585 <          SetConfIllegal(aconf);
2586 <        }
2587 <        else
2588 <        {
2589 <          delete_conf_item(conf);
2590 <        }
1533 >        if (!conf->ref_count)
1534 >          conf_free(conf);
1535        }
1536 <      else if (conf->type == XLINE_TYPE  ||
2593 <               conf->type == RXLINE_TYPE ||
2594 <               conf->type == RKLINE_TYPE)
1536 >      else if (conf->type == CONF_XLINE)
1537        {
1538 <        /* temporary (r)xlines are also on
1539 <         * the (r)xconf items list */
2598 <        if (conf->flags & CONF_FLAGS_TEMPORARY)
2599 <          continue;
2600 <
2601 <        delete_conf_item(conf);
1538 >        if (!conf->until)
1539 >          conf_free(conf);
1540        }
1541        else
1542 <      {
2605 <        if ((conf->type == LEAF_TYPE) || (conf->type == HUB_TYPE))
2606 <        {
2607 <          match_item = map_to_conf(conf);
2608 <          if (match_item->ref_count <= 0)
2609 <            delete_conf_item(conf);
2610 <          else
2611 <          {
2612 <            match_item->illegal = 1;
2613 <            dlinkDelete(&conf->node, *iterator);
2614 <          }
2615 <        }
2616 <        else
2617 <          delete_conf_item(conf);
2618 <      }
1542 >        conf_free(conf);
1543      }
1544    }
1545  
1546 +  motd_clear();
1547 +
1548    /*
1549     * don't delete the class table, rather mark all entries
1550 <   * for deletion. The table is cleaned up by check_class. - avalon
1550 >   * for deletion. The table is cleaned up by class_delete_marked. - avalon
1551     */
1552 <  DLINK_FOREACH(ptr, class_items.head)
2627 <  {
2628 <    cltmp = map_to_conf(ptr->data);
2629 <
2630 <    if (ptr != class_items.tail)  /* never mark the "default" class */
2631 <      cltmp->active = 0;
2632 <  }
1552 >  class_mark_for_deletion();
1553  
1554    clear_out_address_conf();
1555  
1556    /* clean out module paths */
2637 – #ifndef STATIC_MODULES
1557    mod_clear_paths();
2639 – #endif
1558  
1559    /* clean out ServerInfo */
1560    MyFree(ServerInfo.description);
# Line 2648 | Line 1566 | clear_out_old_conf(void)
1566    MyFree(ConfigFileEntry.egdpool_path);
1567    ConfigFileEntry.egdpool_path = NULL;
1568   #ifdef HAVE_LIBCRYPTO
1569 <  if (ServerInfo.rsa_private_key != NULL)
1569 >  if (ServerInfo.rsa_private_key)
1570    {
1571      RSA_free(ServerInfo.rsa_private_key);
1572      ServerInfo.rsa_private_key = NULL;
# Line 2656 | Line 1574 | clear_out_old_conf(void)
1574  
1575    MyFree(ServerInfo.rsa_private_key_file);
1576    ServerInfo.rsa_private_key_file = NULL;
2659 – #endif
1577  
1578 <  /* clean out old resvs from the conf */
1579 <  clear_conf_resv();
1578 >  if (ServerInfo.server_ctx)
1579 >    SSL_CTX_set_options(ServerInfo.server_ctx, SSL_OP_NO_SSLv2|
1580 >                                               SSL_OP_NO_SSLv3|
1581 >                                               SSL_OP_NO_TLSv1);
1582 >  if (ServerInfo.client_ctx)
1583 >    SSL_CTX_set_options(ServerInfo.client_ctx, SSL_OP_NO_SSLv2|
1584 >                                               SSL_OP_NO_SSLv3|
1585 >                                               SSL_OP_NO_TLSv1);
1586 > #endif
1587  
1588    /* clean out AdminInfo */
1589    MyFree(AdminInfo.name);
# Line 2669 | Line 1593 | clear_out_old_conf(void)
1593    MyFree(AdminInfo.description);
1594    AdminInfo.description = NULL;
1595  
2672 –  /* operator{} and class{} blocks are freed above */
1596    /* clean out listeners */
1597    close_listeners();
1598  
2676 –  /* auth{}, quarantine{}, shared{}, connect{}, kill{}, deny{},
2677 –   * exempt{} and gecos{} blocks are freed above too
2678 –   */
2679 –
1599    /* clean out general */
1600 <  MyFree(ConfigFileEntry.servlink_path);
1601 <  ConfigFileEntry.servlink_path = NULL;
2683 < #ifdef HAVE_LIBCRYPTO
2684 <  ConfigFileEntry.default_cipher_preference = NULL;
2685 < #endif /* HAVE_LIBCRYPTO */
2686 <  delete_isupport("INVEX");
2687 <  delete_isupport("EXCEPTS");
2688 < }
2689 <
2690 < /* flush_deleted_I_P()
2691 < *
2692 < * inputs       - none
2693 < * output       - none
2694 < * side effects - This function removes I/P conf items
2695 < */
2696 < static void
2697 < flush_deleted_I_P(void)
2698 < {
2699 <  dlink_node *ptr;
2700 <  dlink_node *next_ptr;
2701 <  struct ConfItem *conf;
2702 <  struct AccessItem *aconf;
2703 <  dlink_list * free_items [] = {
2704 <    &server_items, &oconf_items, NULL
2705 <  };
2706 <  dlink_list ** iterator = free_items; /* C is dumb */
2707 <
2708 <  /* flush out deleted I and P lines
2709 <   * although still in use.
2710 <   */
2711 <  for (; *iterator != NULL; iterator++)
2712 <  {
2713 <    DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
2714 <    {
2715 <      conf = ptr->data;
2716 <      aconf = (struct AccessItem *)map_to_conf(conf);
2717 <
2718 <      if (IsConfIllegal(aconf))
2719 <      {
2720 <        dlinkDelete(ptr, *iterator);
2721 <
2722 <        if (aconf->clients == 0)
2723 <          delete_conf_item(conf);
2724 <      }
2725 <    }
2726 <  }
2727 < }
2728 <
2729 < /* get_conf_name()
2730 < *
2731 < * inputs       - type of conf file to return name of file for
2732 < * output       - pointer to filename for type of conf
2733 < * side effects - none
2734 < */
2735 < const char *
2736 < get_conf_name(ConfType type)
2737 < {
2738 <  switch (type)
2739 <  {
2740 <    case CONF_TYPE:
2741 <      return ConfigFileEntry.configfile;
2742 <      break;
2743 <    case KLINE_TYPE:
2744 <      return ConfigFileEntry.klinefile;
2745 <      break;
2746 <    case RKLINE_TYPE:
2747 <      return ConfigFileEntry.rklinefile;
2748 <      break;
2749 <    case DLINE_TYPE:
2750 <      return ConfigFileEntry.dlinefile;
2751 <      break;
2752 <    case XLINE_TYPE:
2753 <      return ConfigFileEntry.xlinefile;
2754 <      break;
2755 <    case RXLINE_TYPE:
2756 <      return ConfigFileEntry.rxlinefile;
2757 <      break;
2758 <    case CRESV_TYPE:
2759 <      return ConfigFileEntry.cresvfile;
2760 <      break;
2761 <    case NRESV_TYPE:
2762 <      return ConfigFileEntry.nresvfile;
2763 <      break;
2764 <    case GLINE_TYPE:
2765 <      return ConfigFileEntry.glinefile;
2766 <      break;
2767 <
2768 <    default:
2769 <      return NULL;  /* This should NEVER HAPPEN since we call this function
2770 <                       only with the above values, this will cause us to core
2771 <                       at some point if this happens so we know where it was */
2772 <  }
2773 < }
2774 <
2775 < #define BAD_PING (-1)
2776 <
2777 < /* get_conf_ping()
2778 < *
2779 < * inputs       - pointer to struct AccessItem
2780 < *              - pointer to a variable that receives ping warning time
2781 < * output       - ping frequency
2782 < * side effects - NONE
2783 < */
2784 < static int
2785 < get_conf_ping(struct ConfItem *conf, int *pingwarn)
2786 < {
2787 <  struct ClassItem *aclass;
2788 <  struct AccessItem *aconf;
2789 <
2790 <  if (conf != NULL)
2791 <  {
2792 <    aconf = (struct AccessItem *)map_to_conf(conf);
2793 <    if (aconf->class_ptr != NULL)
2794 <    {
2795 <      aclass = (struct ClassItem *)map_to_conf(aconf->class_ptr);
2796 <      *pingwarn = PingWarning(aclass);
2797 <      return PingFreq(aclass);
2798 <    }
2799 <  }
2800 <
2801 <  return BAD_PING;
2802 < }
2803 <
2804 < /* get_client_class()
2805 < *
2806 < * inputs       - pointer to client struct
2807 < * output       - pointer to name of class
2808 < * side effects - NONE
2809 < */
2810 < const char *
2811 < get_client_class(struct Client *target_p)
2812 < {
2813 <  dlink_node *ptr;
2814 <  struct ConfItem *conf;
2815 <  struct AccessItem *aconf;
2816 <
2817 <  if (target_p != NULL && !IsMe(target_p) &&
2818 <      target_p->localClient->confs.head != NULL)
2819 <  {
2820 <    DLINK_FOREACH(ptr, target_p->localClient->confs.head)
2821 <    {
2822 <      conf = ptr->data;
2823 <
2824 <      if (conf->type == CLIENT_TYPE || conf->type == SERVER_TYPE ||
2825 <          conf->type == OPER_TYPE)
2826 <      {
2827 <        aconf = (struct AccessItem *) map_to_conf(conf);
2828 <        if (aconf->class_ptr != NULL)
2829 <          return aconf->class_ptr->name;
2830 <      }
2831 <    }
2832 <  }
2833 <
2834 <  return "default";
2835 < }
2836 <
2837 < /* get_client_ping()
2838 < *
2839 < * inputs       - pointer to client struct
2840 < *              - pointer to a variable that receives ping warning time
2841 < * output       - ping frequency
2842 < * side effects - NONE
2843 < */
2844 < int
2845 < get_client_ping(struct Client *target_p, int *pingwarn)
2846 < {
2847 <  int ping;
2848 <  struct ConfItem *conf;
2849 <  dlink_node *nlink;
2850 <
2851 <  if (target_p->localClient->confs.head != NULL)
2852 <    DLINK_FOREACH(nlink, target_p->localClient->confs.head)
2853 <    {
2854 <      conf = nlink->data;
2855 <
2856 <      if ((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2857 <          (conf->type == OPER_TYPE))
2858 <      {
2859 <        ping = get_conf_ping(conf, pingwarn);
2860 <        if (ping > 0)
2861 <          return ping;
2862 <      }
2863 <    }
2864 <
2865 <  *pingwarn = 0;
2866 <  return DEFAULT_PINGFREQUENCY;
2867 < }
2868 <
2869 < /* find_class()
2870 < *
2871 < * inputs       - string name of class
2872 < * output       - corresponding Class pointer
2873 < * side effects - NONE
2874 < */
2875 < struct ConfItem *
2876 < find_class(const char *classname)
2877 < {
2878 <  struct ConfItem *conf;
2879 <
2880 <  if ((conf = find_exact_name_conf(CLASS_TYPE, classname, NULL, NULL)) != NULL)
2881 <    return conf;
2882 <
2883 <  return class_default;
2884 < }
2885 <
2886 < /* check_class()
2887 < *
2888 < * inputs       - NONE
2889 < * output       - NONE
2890 < * side effects -
2891 < */
2892 < void
2893 < check_class(void)
2894 < {
2895 <  dlink_node *ptr = NULL, *next_ptr = NULL;
2896 <
2897 <  DLINK_FOREACH_SAFE(ptr, next_ptr, class_items.head)
2898 <  {
2899 <    struct ClassItem *aclass = map_to_conf(ptr->data);
2900 <
2901 <    if (!aclass->active && !CurrUserCount(aclass))
2902 <    {
2903 <      destroy_cidr_class(aclass);
2904 <      delete_conf_item(ptr->data);
2905 <    }
2906 <  }
2907 < }
2908 <
2909 < /* init_class()
2910 < *
2911 < * inputs       - NONE
2912 < * output       - NONE
2913 < * side effects -
2914 < */
2915 < void
2916 < init_class(void)
2917 < {
2918 <  struct ClassItem *aclass;
2919 <
2920 <  class_default = make_conf_item(CLASS_TYPE);
2921 <
2922 <  aclass = map_to_conf(class_default);
2923 <  aclass->active = 1;
2924 <  DupString(class_default->name, "default");
2925 <  ConFreq(aclass)  = DEFAULT_CONNECTFREQUENCY;
2926 <  PingFreq(aclass) = DEFAULT_PINGFREQUENCY;
2927 <  MaxTotal(aclass) = MAXIMUM_LINKS_DEFAULT;
2928 <  MaxSendq(aclass) = DEFAULT_SENDQ;
2929 <
2930 <  client_check_cb = register_callback("check_client", check_client);
2931 < }
2932 <
2933 < /* get_sendq()
2934 < *
2935 < * inputs       - pointer to client
2936 < * output       - sendq for this client as found from its class
2937 < * side effects - NONE
2938 < */
2939 < unsigned int
2940 < get_sendq(struct Client *client_p)
2941 < {
2942 <  unsigned int sendq = DEFAULT_SENDQ;
2943 <  dlink_node *ptr;
2944 <  struct ConfItem *conf;
2945 <  struct ConfItem *class_conf;
2946 <  struct ClassItem *aclass;
2947 <  struct AccessItem *aconf;
2948 <
2949 <  if (client_p && !IsMe(client_p) && (client_p->localClient->confs.head))
2950 <  {
2951 <    DLINK_FOREACH(ptr, client_p->localClient->confs.head)
2952 <    {
2953 <      conf = ptr->data;
2954 <      if ((conf->type == SERVER_TYPE) || (conf->type == OPER_TYPE)
2955 <          || (conf->type == CLIENT_TYPE))
2956 <      {
2957 <        aconf = (struct AccessItem *)map_to_conf(conf);
2958 <        if ((class_conf = aconf->class_ptr) == NULL)
2959 <          continue;
2960 <        aclass = (struct ClassItem *)map_to_conf(class_conf);
2961 <        sendq = MaxSendq(aclass);
2962 <        return sendq;
2963 <      }
2964 <    }
2965 <  }
2966 <  /* XXX return a default?
2967 <   * if here, then there wasn't an attached conf with a sendq
2968 <   * that is very bad -Dianora
2969 <   */
2970 <  return DEFAULT_SENDQ;
1600 >  MyFree(ConfigFileEntry.service_name);
1601 >  ConfigFileEntry.service_name = NULL;
1602   }
1603  
1604   /* conf_add_class_to_conf()
1605   *
1606   * inputs       - pointer to config item
1607   * output       - NONE
1608 < * side effects - Add a class pointer to a conf
1608 > * side effects - Add a class pointer to a conf
1609   */
1610   void
1611 < conf_add_class_to_conf(struct ConfItem *conf, const char *class_name)
1611 > conf_add_class_to_conf(struct MaskItem *conf, const char *class_name)
1612   {
1613 <  struct AccessItem *aconf = map_to_conf(conf);
2983 <  struct ClassItem *class = NULL;
2984 <
2985 <  if (class_name == NULL)
1613 >  if (class_name == NULL)
1614    {
1615 <    aconf->class_ptr = class_default;
1615 >    conf->class = class_default;
1616  
1617 <    if (conf->type == CLIENT_TYPE)
1618 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1619 <                           "Warning *** Defaulting to default class for %s@%s",
1620 <                           aconf->user, aconf->host);
1617 >    if (conf->type == CONF_CLIENT)
1618 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1619 >                           "Warning *** Defaulting to default class for %s@%s",
1620 >                           conf->user, conf->host);
1621      else
1622 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1623 <                           "Warning *** Defaulting to default class for %s",
1624 <                           conf->name);
1622 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1623 >                           "Warning *** Defaulting to default class for %s",
1624 >                           conf->name);
1625    }
1626    else
1627 <    aconf->class_ptr = find_class(class_name);
3000 <
3001 <  if (aconf->class_ptr)
3002 <    class = map_to_conf(aconf->class_ptr);
1627 >    conf->class = class_find(class_name, 1);
1628  
1629 <  if (aconf->class_ptr == NULL || !class->active)
1629 >  if (conf->class == NULL)
1630    {
1631 <    if (conf->type == CLIENT_TYPE)
1632 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1633 <                           "Warning *** Defaulting to default class for %s@%s",
1634 <                           aconf->user, aconf->host);
1631 >    if (conf->type == CONF_CLIENT)
1632 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1633 >                           "Warning *** Defaulting to default class for %s@%s",
1634 >                           conf->user, conf->host);
1635      else
1636 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1637 <                           "Warning *** Defaulting to default class for %s",
1638 <                           conf->name);
1639 <    aconf->class_ptr = class_default;
3015 <  }
3016 < }
3017 <
3018 < /* conf_add_server()
3019 < *
3020 < * inputs       - pointer to config item
3021 < *              - pointer to link count already on this conf
3022 < * output       - NONE
3023 < * side effects - Add a connect block
3024 < */
3025 < int
3026 < conf_add_server(struct ConfItem *conf, const char *class_name)
3027 < {
3028 <  struct AccessItem *aconf;
3029 <  struct split_nuh_item nuh;
3030 <  char conf_user[USERLEN + 1];
3031 <  char conf_host[HOSTLEN + 1];
3032 <
3033 <  aconf = map_to_conf(conf);
3034 <
3035 <  conf_add_class_to_conf(conf, class_name);
3036 <
3037 <  if (!aconf->host || !conf->name)
3038 <  {
3039 <    sendto_realops_flags(UMODE_ALL, L_ALL, "Bad connect block");
3040 <    ilog(L_WARN, "Bad connect block");
3041 <    return -1;
1636 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1637 >                           "Warning *** Defaulting to default class for %s",
1638 >                           conf->name);
1639 >    conf->class = class_default;
1640    }
3043 –
3044 –  if (EmptyString(aconf->passwd) && !IsConfCryptLink(aconf))
3045 –  {
3046 –    sendto_realops_flags(UMODE_ALL, L_ALL, "Bad connect block, name %s",
3047 –                         conf->name);
3048 –    ilog(L_WARN, "Bad connect block, host %s", conf->name);
3049 –    return -1;
3050 –  }
3051 –
3052 –  nuh.nuhmask  = aconf->host;
3053 –  nuh.nickptr  = NULL;
3054 –  nuh.userptr  = conf_user;
3055 –  nuh.hostptr  = conf_host;
3056 –
3057 –  nuh.nicksize = 0;
3058 –  nuh.usersize = sizeof(conf_user);
3059 –  nuh.hostsize = sizeof(conf_host);
3060 –
3061 –  split_nuh(&nuh);
3062 –
3063 –  MyFree(aconf->host);
3064 –  aconf->host = NULL;
3065 –
3066 –  DupString(aconf->user, conf_user); /* somehow username checking for servers
3067 –                                 got lost in H6/7, will have to be re-added */
3068 –  DupString(aconf->host, conf_host);
3069 –
3070 –  lookup_confhost(conf);
3071 –
3072 –  return 0;
1641   }
1642  
1643   /* yyerror()
# Line 3087 | Line 1655 | yyerror(const char *msg)
1655      return;
1656  
1657    strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1658 <  sendto_realops_flags(UMODE_ALL, L_ALL, "\"%s\", line %u: %s: %s",
1658 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1659 >                       "\"%s\", line %u: %s: %s",
1660                         conffilebuf, lineno + 1, msg, newlinebuf);
1661 <  ilog(L_WARN, "\"%s\", line %u: %s: %s",
1661 >  ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1662         conffilebuf, lineno + 1, msg, newlinebuf);
1663   }
1664  
1665 < int
1666 < conf_fbgets(char *lbuf, unsigned int max_size, FBFILE *fb)
1665 > void
1666 > conf_error_report(const char *msg)
1667   {
1668 <  if (fbgets(lbuf, max_size, fb) == NULL)
3100 <    return 0;
3101 <
3102 <  return strlen(lbuf);
3103 < }
1668 >  char newlinebuf[IRCD_BUFSIZE];
1669  
1670 < int
1671 < conf_yy_fatal_error(const char *msg)
1672 < {
1673 <  return 0;
1670 >  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1671 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1672 >                       "\"%s\", line %u: %s: %s",
1673 >                       conffilebuf, lineno + 1, msg, newlinebuf);
1674 >  ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1675 >       conffilebuf, lineno + 1, msg, newlinebuf);
1676   }
1677  
1678   /*
1679   * valid_tkline()
1680 < *
1680 > *
1681   * inputs       - pointer to ascii string to check
1682   *              - whether the specified time is in seconds or minutes
1683   * output       - -1 not enough parameters
# Line 3119 | Line 1686 | conf_yy_fatal_error(const char *msg)
1686   * Originally written by Dianora (Diane, db@db.net)
1687   */
1688   time_t
1689 < valid_tkline(char *p, int minutes)
1689 > valid_tkline(const char *data, const int minutes)
1690   {
1691 +  const unsigned char *p = (const unsigned char *)data;
1692 +  unsigned char tmpch = '\0';
1693    time_t result = 0;
1694  
1695 <  while (*p)
1695 >  while ((tmpch = *p++))
1696    {
1697 <    if (IsDigit(*p))
3129 <    {
3130 <      result *= 10;
3131 <      result += ((*p) & 0xF);
3132 <      p++;
3133 <    }
3134 <    else
1697 >    if (!IsDigit(tmpch))
1698        return 0;
1699 +
1700 +    result *= 10;
1701 +    result += (tmpch & 0xF);
1702    }
1703  
1704 <  /* in the degenerate case where oper does a /quote kline 0 user@host :reason
1704 >  /*
1705 >   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1706     * i.e. they specifically use 0, I am going to return 1 instead
1707     * as a return value of non-zero is used to flag it as a temporary kline
1708     */
3142 –
1709    if (result == 0)
1710      result = 1;
1711  
1712 <  /*
1712 >  /*
1713     * If the incoming time is in seconds convert it to minutes for the purpose
1714     * of this calculation
1715     */
1716    if (!minutes)
1717 <    result = result / (time_t)60;
1717 >    result = result / 60;
1718  
1719    if (result > MAX_TDKLINE_TIME)
1720      result = MAX_TDKLINE_TIME;
1721  
1722 <  result = result * (time_t)60;  /* turn it into seconds */
1722 >  result = result * 60;  /* turn it into seconds */
1723  
1724    return result;
1725   }
1726  
1727 + /* valid_wild_card_simple()
1728 + *
1729 + * inputs       - data to check for sufficient non-wildcard characters
1730 + * outputs      - 1 if valid, else 0
1731 + * side effects - none
1732 + */
1733 + int
1734 + valid_wild_card_simple(const char *data)
1735 + {
1736 +  const unsigned char *p = (const unsigned char *)data;
1737 +  unsigned char tmpch = '\0';
1738 +  int nonwild = 0;
1739 +
1740 +  while ((tmpch = *p++))
1741 +  {
1742 +    if (tmpch == '\\')
1743 +    {
1744 +      ++p;
1745 +      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1746 +        return 1;
1747 +    }
1748 +    else if (!IsMWildChar(tmpch))
1749 +    {
1750 +      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1751 +        return 1;
1752 +    }
1753 +  }
1754 +
1755 +  return 0;
1756 + }
1757 +
1758   /* valid_wild_card()
1759   *
1760   * input        - pointer to client
# Line 3169 | Line 1766 | valid_tkline(char *p, int minutes)
1766   int
1767   valid_wild_card(struct Client *source_p, int warn, int count, ...)
1768   {
3172 –  char *p;
1769    char tmpch;
1770    int nonwild = 0;
1771    va_list args;
# Line 3190 | Line 1786 | valid_wild_card(struct Client *source_p,
1786  
1787    while (count--)
1788    {
1789 <    p = va_arg(args, char *);
1789 >    const char *p = va_arg(args, const char *);
1790      if (p == NULL)
1791        continue;
1792  
# Line 3203 | Line 1799 | valid_wild_card(struct Client *source_p,
1799           * break - no point in searching further.
1800           */
1801          if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1802 +        {
1803 +          va_end(args);
1804            return 1;
1805 +        }
1806        }
1807      }
1808    }
1809  
1810    if (warn)
1811 <    sendto_one(source_p, ":%s NOTICE %s :Please include at least %d non-wildcard characters with the mask",
1812 <               me.name, source_p->name, ConfigFileEntry.min_nonwildcard);
1811 >    sendto_one_notice(source_p, &me,
1812 >                      ":Please include at least %d non-wildcard characters with the mask",
1813 >                      ConfigFileEntry.min_nonwildcard);
1814 >  va_end(args);
1815    return 0;
1816   }
1817  
# Line 3224 | Line 1825 | valid_wild_card(struct Client *source_p,
1825   *              - parse_flags bit map of things to test
1826   *              - pointer to user or string to parse into
1827   *              - pointer to host or NULL to parse into if non NULL
1828 < *              - pointer to optional tkline time or NULL
1828 > *              - pointer to optional tkline time or NULL
1829   *              - pointer to target_server to parse into if non NULL
1830   *              - pointer to reason to parse into
1831   *
# Line 3246 | Line 1847 | valid_wild_card(struct Client *source_p,
1847   */
1848   int
1849   parse_aline(const char *cmd, struct Client *source_p,
1850 <            int parc, char **parv,
1851 <            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1852 <            char **target_server, char **reason)
1850 >            int parc, char **parv,
1851 >            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1852 >            char **target_server, char **reason)
1853   {
1854    int found_tkline_time=0;
1855    static char def_reason[] = "No Reason";
# Line 3269 | Line 1870 | parse_aline(const char *cmd, struct Clie
1870        *tkline_time = found_tkline_time;
1871      else
1872      {
1873 <      sendto_one(source_p, ":%s NOTICE %s :temp_line not supported by %s",
3273 <                 me.name, source_p->name, cmd);
1873 >      sendto_one_notice(source_p, &me, ":temp_line not supported by %s", cmd);
1874        return -1;
1875      }
1876    }
1877  
1878    if (parc == 0)
1879    {
1880 <    sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
3281 <               me.name, source_p->name, cmd);
1880 >    sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1881      return -1;
1882    }
1883  
# Line 3292 | Line 1891 | parse_aline(const char *cmd, struct Clie
1891      *up_p = user;
1892      *h_p = host;
1893    }
1894 <
1894 >
1895    parc--;
1896    parv++;
1897  
# Line 3305 | Line 1904 | parse_aline(const char *cmd, struct Clie
1904  
1905        if (target_server == NULL)
1906        {
1907 <        sendto_one(source_p, ":%s NOTICE %s :ON server not supported by %s",
1908 <                   me.name, source_p->name, cmd);
3310 <        return -1;
1907 >        sendto_one_notice(source_p, &me, ":ON server not supported by %s", cmd);
1908 >        return -1;
1909        }
1910  
1911 <      if (!IsOperRemoteBan(source_p))
1911 >      if (!HasOFlag(source_p, OPER_FLAG_REMOTEBAN))
1912        {
1913 <        sendto_one(source_p, form_str(ERR_NOPRIVS),
3316 <                   me.name, source_p->name, "remoteban");
1913 >        sendto_one_numeric(source_p, &me, ERR_NOPRIVS, "remoteban");
1914          return -1;
1915        }
1916  
1917        if (parc == 0 || EmptyString(*parv))
1918        {
1919 <        sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
1920 <                   me.name, source_p->name, cmd);
3324 <        return -1;
1919 >        sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1920 >        return -1;
1921        }
1922  
1923        *target_server = *parv;
# Line 3334 | Line 1930 | parse_aline(const char *cmd, struct Clie
1930         * caller probably NULL'd it first, but no harm to do it again -db
1931         */
1932        if (target_server != NULL)
1933 <        *target_server = NULL;
1933 >        *target_server = NULL;
1934      }
1935    }
1936  
# Line 3342 | Line 1938 | parse_aline(const char *cmd, struct Clie
1938    {
1939      if (strchr(user, '!') != NULL)
1940      {
1941 <      sendto_one(source_p, ":%s NOTICE %s :Invalid character '!' in kline",
3346 <                 me.name, source_p->name);
1941 >      sendto_one_notice(source_p, &me, ":Invalid character '!' in kline");
1942        return -1;
1943      }
1944  
1945 <    if ((parse_flags & AWILD) && !valid_wild_card(source_p, YES, 2, *up_p, *h_p))
1945 >    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 2, *up_p, *h_p))
1946        return -1;
1947    }
1948    else
1949 <    if ((parse_flags & AWILD) && !valid_wild_card(source_p, YES, 1, *up_p))
1949 >    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 1, *up_p))
1950        return -1;
1951  
1952    if (reason != NULL)
# Line 3359 | Line 1954 | parse_aline(const char *cmd, struct Clie
1954      if (parc != 0 && !EmptyString(*parv))
1955      {
1956        *reason = *parv;
1957 <      if (!valid_comment(source_p, *reason, YES))
1958 <        return -1;
1957 >      if (!valid_comment(source_p, *reason, 1))
1958 >        return -1;
1959      }
1960      else
1961        *reason = def_reason;
# Line 3399 | Line 1994 | find_user_host(struct Client *source_p,
1994      {
1995        *(hostp++) = '\0';                       /* short and squat */
1996        if (*user_host_or_nick)
1997 <        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1997 >        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1998        else
1999 <        strcpy(luser, "*");
1999 >        strcpy(luser, "*");
2000 >
2001        if (*hostp)
2002 <        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2002 >        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2003        else
2004 <        strcpy(lhost, "*");
2004 >        strcpy(lhost, "*");
2005      }
2006      else
2007      {
2008        luser[0] = '*';             /* no @ found, assume its *@somehost */
2009 <      luser[1] = '\0';    
2009 >      luser[1] = '\0';
2010        strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
2011      }
2012 <    
2012 >
2013      return 1;
2014    }
2015 <  else if (!(flags & NOUSERLOOKUP))
2015 >  else
2016    {
2017      /* Try to find user@host mask from nick */
2018      /* Okay to use source_p as the first param, because source_p == client_p */
2019 <    if ((target_p =
2020 <        find_chasing(source_p, source_p, user_host_or_nick, NULL)) == NULL)
2019 >    if ((target_p =
2020 >        find_chasing(source_p, user_host_or_nick)) == NULL)
2021        return 0;
2022  
2023      if (IsExemptKline(target_p))
2024      {
2025        if (!IsServer(source_p))
2026 <        sendto_one(source_p,
3431 <                   ":%s NOTICE %s :%s is E-lined",
3432 <                   me.name, source_p->name, target_p->name);
2026 >        sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
2027        return 0;
2028      }
2029  
# Line 3464 | Line 2058 | find_user_host(struct Client *source_p,
2058   int
2059   valid_comment(struct Client *source_p, char *comment, int warn)
2060   {
3467 –  if (strchr(comment, '"'))
3468 –  {
3469 –    if (warn)
3470 –      sendto_one(source_p, ":%s NOTICE %s :Invalid character '\"' in comment",
3471 –                 me.name, source_p->name);
3472 –    return 0;
3473 –  }
3474 –
2061    if (strlen(comment) > REASONLEN)
2062      comment[REASONLEN-1] = '\0';
2063  
# Line 3486 | Line 2072 | valid_comment(struct Client *source_p, c
2072   * side effects - none
2073   */
2074   int
2075 < match_conf_password(const char *password, const struct AccessItem *aconf)
2075 > match_conf_password(const char *password, const struct MaskItem *conf)
2076   {
2077    const char *encr = NULL;
2078  
2079 <  if (password == NULL || aconf->passwd == NULL)
2079 >  if (EmptyString(password) || EmptyString(conf->passwd))
2080      return 0;
2081  
2082 <  if (aconf->flags & CONF_FLAGS_ENCRYPTED)
2083 <  {
3498 <    /* use first two chars of the password they send in as salt */
3499 <    /* If the password in the conf is MD5, and ircd is linked
3500 <     * to scrypt on FreeBSD, or the standard crypt library on
3501 <     * glibc Linux, then this code will work fine on generating
3502 <     * the proper encrypted hash for comparison.
3503 <     */
3504 <    if (*aconf->passwd)
3505 <      encr = crypt(password, aconf->passwd);
3506 <    else
3507 <      encr = "";
3508 <  }
2082 >  if (conf->flags & CONF_FLAGS_ENCRYPTED)
2083 >    encr = crypt(password, conf->passwd);
2084    else
2085      encr = password;
2086  
2087 <  return !strcmp(encr, aconf->passwd);
2087 >  return encr && !strcmp(encr, conf->passwd);
2088   }
2089  
2090   /*
# Line 3517 | Line 2092 | match_conf_password(const char *password
2092   *
2093   * inputs       - client sending the cluster
2094   *              - command name "KLINE" "XLINE" etc.
2095 < *              - capab -- CAP_KLN etc. from s_serv.h
2096 < *              - cluster type -- CLUSTER_KLINE etc. from s_conf.h
2095 > *              - capab -- CAP_KLN etc. from server.h
2096 > *              - cluster type -- CLUSTER_KLINE etc. from conf.h
2097   *              - pattern and args to send along
2098   * output       - none
2099   * side effects - Take source_p send the pattern with args given
# Line 3538 | Line 2113 | cluster_a_line(struct Client *source_p,
2113  
2114    DLINK_FOREACH(ptr, cluster_items.head)
2115    {
2116 <    const struct ConfItem *conf = ptr->data;
2116 >    const struct MaskItem *conf = ptr->data;
2117  
2118      if (conf->flags & cluster_type)
2119        sendto_match_servs(source_p, conf->name, CAP_CLUSTER|capab,
2120 <                         "%s %s %s", command, conf->name, buffer);
2120 >                         "%s %s %s", command, conf->name, buffer);
2121    }
2122   }
2123  
# Line 3593 | Line 2168 | split_nuh(struct split_nuh_item *const i
2168      if (iptr->nickptr && *iptr->nuhmask != '\0')
2169        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
2170  
2171 <    if ((q = strchr(++p, '@'))) {
2171 >    if ((q = strchr(++p, '@')))
2172 >    {
2173        *q++ = '\0';
2174  
2175        if (*p != '\0')
# Line 3632 | Line 2208 | split_nuh(struct split_nuh_item *const i
2208      }
2209    }
2210   }
3635 –
3636 – /*
3637 – * flags_to_ascii
3638 – *
3639 – * inputs       - flags is a bitmask
3640 – *              - pointer to table of ascii letters corresponding
3641 – *                to each bit
3642 – *              - flag 1 for convert ToLower if bit missing
3643 – *                0 if ignore.
3644 – * output       - none
3645 – * side effects - string pointed to by p has bitmap chars written to it
3646 – */
3647 – static void
3648 – flags_to_ascii(unsigned int flags, const unsigned int bit_table[], char *p,
3649 –               int lowerit)
3650 – {
3651 –  unsigned int mask = 1;
3652 –  int i = 0;
3653 –
3654 –  for (mask = 1; (mask != 0) && (bit_table[i] != 0); mask <<= 1, i++)
3655 –  {
3656 –    if (flags & mask)
3657 –      *p++ = bit_table[i];
3658 –    else if (lowerit)
3659 –      *p++ = ToLower(bit_table[i]);
3660 –  }
3661 –  *p = '\0';
3662 – }
3663 –
3664 – /*
3665 – * cidr_limit_reached
3666 – *
3667 – * inputs       - int flag allowing over_rule of limits
3668 – *              - pointer to the ip to be added
3669 – *              - pointer to the class
3670 – * output       - non zero if limit reached
3671 – *                0 if limit not reached
3672 – * side effects -
3673 – */
3674 – static int
3675 – cidr_limit_reached(int over_rule,
3676 –                   struct irc_ssaddr *ip, struct ClassItem *aclass)
3677 – {
3678 –  dlink_node *ptr = NULL;
3679 –  struct CidrItem *cidr;
3680 –
3681 –  if (NumberPerCidr(aclass) <= 0)
3682 –    return 0;
3683 –
3684 –  if (ip->ss.ss_family == AF_INET)
3685 –  {
3686 –    if (CidrBitlenIPV4(aclass) <= 0)
3687 –      return 0;
3688 –
3689 –    DLINK_FOREACH(ptr, aclass->list_ipv4.head)
3690 –    {
3691 –      cidr = ptr->data;
3692 –      if (match_ipv4(ip, &cidr->mask, CidrBitlenIPV4(aclass)))
3693 –      {
3694 –        if (!over_rule && (cidr->number_on_this_cidr >= NumberPerCidr(aclass)))
3695 –          return -1;
3696 –        cidr->number_on_this_cidr++;
3697 –        return 0;
3698 –      }
3699 –    }
3700 –    cidr = MyMalloc(sizeof(struct CidrItem));
3701 –    cidr->number_on_this_cidr = 1;
3702 –    cidr->mask = *ip;
3703 –    mask_addr(&cidr->mask, CidrBitlenIPV4(aclass));
3704 –    dlinkAdd(cidr, &cidr->node, &aclass->list_ipv4);
3705 –  }
3706 – #ifdef IPV6
3707 –  else if (CidrBitlenIPV6(aclass) > 0)
3708 –  {
3709 –    DLINK_FOREACH(ptr, aclass->list_ipv6.head)
3710 –    {
3711 –      cidr = ptr->data;
3712 –      if (match_ipv6(ip, &cidr->mask, CidrBitlenIPV6(aclass)))
3713 –      {
3714 –        if (!over_rule && (cidr->number_on_this_cidr >= NumberPerCidr(aclass)))
3715 –          return -1;
3716 –        cidr->number_on_this_cidr++;
3717 –        return 0;
3718 –      }
3719 –    }
3720 –    cidr = MyMalloc(sizeof(struct CidrItem));
3721 –    cidr->number_on_this_cidr = 1;
3722 –    cidr->mask = *ip;
3723 –    mask_addr(&cidr->mask, CidrBitlenIPV6(aclass));
3724 –    dlinkAdd(cidr, &cidr->node, &aclass->list_ipv6);
3725 –  }
3726 – #endif
3727 –  return 0;
3728 – }
3729 –
3730 – /*
3731 – * remove_from_cidr_check
3732 – *
3733 – * inputs       - pointer to the ip to be removed
3734 – *              - pointer to the class
3735 – * output       - NONE
3736 – * side effects -
3737 – */
3738 – static void
3739 – remove_from_cidr_check(struct irc_ssaddr *ip, struct ClassItem *aclass)
3740 – {
3741 –  dlink_node *ptr = NULL;
3742 –  dlink_node *next_ptr = NULL;
3743 –  struct CidrItem *cidr;
3744 –
3745 –  if (NumberPerCidr(aclass) == 0)
3746 –    return;
3747 –
3748 –  if (ip->ss.ss_family == AF_INET)
3749 –  {
3750 –    if (CidrBitlenIPV4(aclass) <= 0)
3751 –      return;
3752 –
3753 –    DLINK_FOREACH_SAFE(ptr, next_ptr, aclass->list_ipv4.head)
3754 –    {
3755 –      cidr = ptr->data;
3756 –      if (match_ipv4(ip, &cidr->mask, CidrBitlenIPV4(aclass)))
3757 –      {
3758 –        cidr->number_on_this_cidr--;
3759 –        if (cidr->number_on_this_cidr == 0)
3760 –        {
3761 –          dlinkDelete(ptr, &aclass->list_ipv4);
3762 –          MyFree(cidr);
3763 –          return;
3764 –        }
3765 –      }
3766 –    }
3767 –  }
3768 – #ifdef IPV6
3769 –  else if (CidrBitlenIPV6(aclass) > 0)
3770 –  {
3771 –    DLINK_FOREACH_SAFE(ptr, next_ptr, aclass->list_ipv6.head)
3772 –    {
3773 –      cidr = ptr->data;
3774 –      if (match_ipv6(ip, &cidr->mask, CidrBitlenIPV6(aclass)))
3775 –      {
3776 –        cidr->number_on_this_cidr--;
3777 –        if (cidr->number_on_this_cidr == 0)
3778 –        {
3779 –          dlinkDelete(ptr, &aclass->list_ipv6);
3780 –          MyFree(cidr);
3781 –          return;
3782 –        }
3783 –      }
3784 –    }
3785 –  }
3786 – #endif
3787 – }
3788 –
3789 – static void
3790 – rebuild_cidr_list(int aftype, struct ConfItem *oldcl, struct ClassItem *newcl,
3791 –                  dlink_list *old_list, dlink_list *new_list, int changed)
3792 – {
3793 –  dlink_node *ptr;
3794 –  struct Client *client_p;
3795 –  struct ConfItem *conf;
3796 –  struct AccessItem *aconf;
3797 –
3798 –  if (!changed)
3799 –  {
3800 –    *new_list = *old_list;
3801 –    old_list->head = old_list->tail = NULL;
3802 –    old_list->length = 0;
3803 –    return;
3804 –  }
3805 –
3806 –  DLINK_FOREACH(ptr, local_client_list.head)
3807 –  {
3808 –    client_p = ptr->data;
3809 –    if (client_p->localClient->aftype != aftype)
3810 –      continue;
3811 –    if (dlink_list_length(&client_p->localClient->confs) == 0)
3812 –      continue;
3813 –
3814 –    conf = client_p->localClient->confs.tail->data;
3815 –    if (conf->type == CLIENT_TYPE)
3816 –    {
3817 –      aconf = map_to_conf(conf);
3818 –      if (aconf->class_ptr == oldcl)
3819 –        cidr_limit_reached(1, &client_p->localClient->ip, newcl);
3820 –    }
3821 –  }
3822 – }
3823 –
3824 – /*
3825 – * rebuild_cidr_class
3826 – *
3827 – * inputs       - pointer to old conf
3828 – *              - pointer to new_class
3829 – * output       - none
3830 – * side effects - rebuilds the class link list of cidr blocks
3831 – */
3832 – void
3833 – rebuild_cidr_class(struct ConfItem *conf, struct ClassItem *new_class)
3834 – {
3835 –  struct ClassItem *old_class = map_to_conf(conf);
3836 –
3837 –  if (NumberPerCidr(old_class) > 0 && NumberPerCidr(new_class) > 0)
3838 –  {
3839 –    if (CidrBitlenIPV4(old_class) > 0 && CidrBitlenIPV4(new_class) > 0)
3840 –      rebuild_cidr_list(AF_INET, conf, new_class,
3841 –                        &old_class->list_ipv4, &new_class->list_ipv4,
3842 –                        CidrBitlenIPV4(old_class) != CidrBitlenIPV4(new_class));
3843 –
3844 – #ifdef IPV6
3845 –    if (CidrBitlenIPV6(old_class) > 0 && CidrBitlenIPV6(new_class) > 0)
3846 –      rebuild_cidr_list(AF_INET6, conf, new_class,
3847 –                        &old_class->list_ipv6, &new_class->list_ipv6,
3848 –                        CidrBitlenIPV6(old_class) != CidrBitlenIPV6(new_class));
3849 – #endif
3850 –  }
3851 –
3852 –  destroy_cidr_class(old_class);
3853 – }
3854 –
3855 – /*
3856 – * destroy_cidr_list
3857 – *
3858 – * inputs       - pointer to class dlink list of cidr blocks
3859 – * output       - none
3860 – * side effects - completely destroys the class link list of cidr blocks
3861 – */
3862 – static void
3863 – destroy_cidr_list(dlink_list *list)
3864 – {
3865 –  dlink_node *ptr = NULL, *next_ptr = NULL;
3866 –
3867 –  DLINK_FOREACH_SAFE(ptr, next_ptr, list->head)
3868 –  {
3869 –    dlinkDelete(ptr, list);
3870 –    MyFree(ptr->data);
3871 –  }
3872 – }
3873 –
3874 – /*
3875 – * destroy_cidr_class
3876 – *
3877 – * inputs       - pointer to class
3878 – * output       - none
3879 – * side effects - completely destroys the class link list of cidr blocks
3880 – */
3881 – static void
3882 – destroy_cidr_class(struct ClassItem *aclass)
3883 – {
3884 –  destroy_cidr_list(&aclass->list_ipv4);
3885 –  destroy_cidr_list(&aclass->list_ipv6);
3886 – }

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)