ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/conf.c (file contents):
Revision 1645 by michael, Wed Nov 7 12:25:02 2012 UTC vs.
Revision 8593 by michael, Sun Oct 21 18:11:04 2018 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  conf.c: Configuration file functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2018 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 16 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file conf.c
23 > * \brief Configuration file functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29   #include "ircd_defs.h"
30 < #include "balloc.h"
30 > #include "parse.h"
31   #include "conf.h"
32 < #include "s_serv.h"
33 < #include "resv.h"
32 > #include "conf_cluster.h"
33 > #include "conf_gecos.h"
34 > #include "conf_pseudo.h"
35 > #include "conf_resv.h"
36 > #include "conf_service.h"
37 > #include "conf_shared.h"
38 > #include "server.h"
39   #include "channel.h"
40   #include "client.h"
41   #include "event.h"
35 #include "hook.h"
42   #include "irc_string.h"
43   #include "s_bsd.h"
44   #include "ircd.h"
# Line 43 | Line 49
49   #include "fdlist.h"
50   #include "log.h"
51   #include "send.h"
46 #include "s_gline.h"
52   #include "memory.h"
53 < #include "irc_res.h"
54 < #include "userhost.h"
50 < #include "s_user.h"
53 > #include "res.h"
54 > #include "user.h"
55   #include "channel_mode.h"
56 < #include "parse.h"
53 < #include "s_misc.h"
56 > #include "misc.h"
57   #include "conf_db.h"
58   #include "conf_class.h"
59 + #include "motd.h"
60 + #include "ipcache.h"
61 + #include "isupport.h"
62 + #include "whowas.h"
63 +
64  
65 < struct config_server_hide ConfigServerHide;
65 > struct config_channel_entry ConfigChannel;
66 > struct config_serverhide_entry ConfigServerHide;
67 > struct config_general_entry ConfigGeneral;
68 > struct config_log_entry ConfigLog = { .use_logging = 1 };
69 > struct config_serverinfo_entry ConfigServerInfo;
70 > struct config_admin_entry ConfigAdminInfo;
71 > struct conf_parser_context conf_parser_ctx;
72  
73   /* general conf items link list root, other than k lines etc. */
74 < dlink_list service_items = { NULL, NULL, 0 };
75 < dlink_list server_items  = { NULL, NULL, 0 };
62 < dlink_list cluster_items = { NULL, NULL, 0 };
63 < dlink_list oconf_items   = { NULL, NULL, 0 };
64 < dlink_list uconf_items   = { NULL, NULL, 0 };
65 < dlink_list xconf_items   = { NULL, NULL, 0 };
66 < dlink_list rxconf_items  = { NULL, NULL, 0 };
67 < dlink_list rkconf_items  = { NULL, NULL, 0 };
68 < dlink_list nresv_items   = { NULL, NULL, 0 };
69 < dlink_list temporary_resv = { NULL, NULL, 0 };
74 > dlink_list connect_items;
75 > dlink_list operator_items;
76  
77   extern unsigned int lineno;
78   extern char linebuf[];
79   extern char conffilebuf[IRCD_BUFSIZE];
80   extern int yyparse(); /* defined in y.tab.c */
81  
76 struct conf_parser_context conf_parser_ctx = { 0, 0, NULL };
77
78 /* internally defined functions */
79 static void read_conf(FILE *);
80 static void clear_out_old_conf(void);
81 static void expire_tklines(dlink_list *);
82 static void garbage_collect_ip_entries(void);
83 static int hash_ip(struct irc_ssaddr *);
84 static int verify_access(struct Client *);
85 static int attach_iline(struct Client *, struct MaskItem *);
86 static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
87 static dlink_list *map_to_list(enum maskitem_type);
88 static struct MaskItem *find_regexp_kline(const char *[]);
89 static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
90
91
92 /* usually, with hash tables, you use a prime number...
93 * but in this case I am dealing with ip addresses,
94 * not ascii strings.
95 */
96 #define IP_HASH_SIZE 0x1000
97
98 struct ip_entry
99 {
100  struct irc_ssaddr ip;
101  unsigned int count;
102  time_t last_attempt;
103  struct ip_entry *next;
104 };
105
106 static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
107 static BlockHeap *ip_entry_heap = NULL;
108 static int ip_entries_count = 0;
109
82  
83   /* conf_dns_callback()
84   *
# Line 119 | Line 91 | static int ip_entries_count = 0;
91   * if successful save hp in the conf item it was called with
92   */
93   static void
94 < conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
94 > conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name, size_t namelength)
95   {
96 <  struct MaskItem *conf = vptr;
96 >  struct MaskItem *const conf = vptr;
97  
98    conf->dns_pending = 0;
99  
100 <  if (addr != NULL)
100 >  if (addr)
101      memcpy(&conf->addr, addr, sizeof(conf->addr));
102    else
103      conf->dns_failed = 1;
# Line 140 | Line 112 | conf_dns_callback(void *vptr, const stru
112   static void
113   conf_dns_lookup(struct MaskItem *conf)
114   {
115 <  if (!conf->dns_pending)
115 >  if (conf->dns_pending)
116 >    return;
117 >
118 >  conf->dns_pending = 1;
119 >
120 >  if (conf->aftype == AF_INET)
121 >    gethost_byname_type(conf_dns_callback, conf, conf->host, T_A);
122 >  else
123 >    gethost_byname_type(conf_dns_callback, conf, conf->host, T_AAAA);
124 > }
125 >
126 > /* map_to_list()
127 > *
128 > * inputs       - ConfType conf
129 > * output       - pointer to dlink_list to use
130 > * side effects - none
131 > */
132 > static dlink_list *
133 > map_to_list(enum maskitem_type type)
134 > {
135 >  switch (type)
136    {
137 <    conf->dns_pending = 1;
138 <    gethost_byname(conf_dns_callback, conf, conf->host);
137 >    case CONF_OPER:
138 >      return &operator_items;
139 >      break;
140 >    case CONF_SERVER:
141 >      return &connect_items;
142 >      break;
143 >    default:
144 >      return NULL;
145    }
146   }
147  
148   struct MaskItem *
149   conf_make(enum maskitem_type type)
150   {
151 <  struct MaskItem *conf = MyMalloc(sizeof(*conf));
151 >  struct MaskItem *const conf = xcalloc(sizeof(*conf));
152    dlink_list *list = NULL;
153  
154    conf->type   = type;
# Line 165 | Line 163 | conf_make(enum maskitem_type type)
163   void
164   conf_free(struct MaskItem *conf)
165   {
166 <  dlink_node *ptr = NULL, *ptr_next = NULL;
166 >  dlink_node *node = NULL, *node_next = NULL;
167    dlink_list *list = NULL;
168  
169 <  if (conf->node.next)
170 <    if ((list = map_to_list(conf->type)))
173 <      dlinkDelete(&conf->node, list);
169 >  if ((list = map_to_list(conf->type)))
170 >    dlinkFindDelete(list, conf);
171  
172 <  MyFree(conf->name);
172 >  xfree(conf->name);
173  
174    if (conf->dns_pending)
175      delete_resolver_queries(conf);
176 <  if (conf->passwd != NULL)
176 >  if (conf->passwd)
177      memset(conf->passwd, 0, strlen(conf->passwd));
178 <  if (conf->spasswd != NULL)
178 >  if (conf->spasswd)
179      memset(conf->spasswd, 0, strlen(conf->spasswd));
180  
181    conf->class = NULL;
182  
183 <  MyFree(conf->passwd);
184 <  MyFree(conf->spasswd);
185 <  MyFree(conf->reason);
186 <  MyFree(conf->user);
187 <  MyFree(conf->host);
188 <  MyFree(conf->regexuser);
189 <  MyFree(conf->regexhost);
190 < #ifdef HAVE_LIBCRYPTO
194 <  MyFree(conf->cipher_list);
183 >  xfree(conf->passwd);
184 >  xfree(conf->spasswd);
185 >  xfree(conf->reason);
186 >  xfree(conf->certfp);
187 >  xfree(conf->whois);
188 >  xfree(conf->user);
189 >  xfree(conf->host);
190 >  xfree(conf->cipher_list);
191  
192 <  if (conf->rsa_public_key)
197 <    RSA_free(conf->rsa_public_key);
198 <
199 <  MyFree(conf->rsa_public_key_file);
200 < #endif
201 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->hub_list.head)
192 >  DLINK_FOREACH_SAFE(node, node_next, conf->hub_list.head)
193    {
194 <    MyFree(ptr->data);
195 <    free_dlink_node(ptr);
194 >    xfree(node->data);
195 >    dlinkDelete(node, &conf->hub_list);
196 >    free_dlink_node(node);
197    }
198  
199 <  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->leaf_list.head)
199 >  DLINK_FOREACH_SAFE(node, node_next, conf->leaf_list.head)
200    {
201 <    MyFree(ptr->data);
202 <    free_dlink_node(ptr);
201 >    xfree(node->data);
202 >    dlinkDelete(node, &conf->leaf_list);
203 >    free_dlink_node(node);
204    }
205  
206 <  MyFree(conf);
206 >  xfree(conf);
207   }
208  
209 < static const struct shared_flags
210 < {
211 <  const unsigned int type;
212 <  const unsigned char letter;
213 < } flag_table[] = {
214 <  { SHARED_KLINE,   'K' },
222 <  { SHARED_UNKLINE, 'U' },
223 <  { SHARED_XLINE,   'X' },
224 <  { SHARED_UNXLINE, 'Y' },
225 <  { SHARED_RESV,    'Q' },
226 <  { SHARED_UNRESV,  'R' },
227 <  { SHARED_LOCOPS,  'L' },
228 <  { SHARED_DLINE,   'D' },
229 <  { SHARED_UNDLINE, 'E' },
230 <  { 0, '\0' }
231 < };
232 <
233 < /*
234 < * inputs       - pointer to client requesting confitem report
235 < *              - ConfType to report
236 < * output       - none
237 < * side effects -
209 > /* attach_iline()
210 > *
211 > * inputs       - client pointer
212 > *              - conf pointer
213 > * output       -
214 > * side effects - do actual attach
215   */
216 < void
217 < report_confitem_types(struct Client *source_p, enum maskitem_type type)
216 > static int
217 > attach_iline(struct Client *client_p, struct MaskItem *conf)
218   {
219 <  dlink_node *ptr = NULL, *dptr = NULL;
220 <  struct MaskItem *conf = NULL;
244 <  const struct ClassItem *class = NULL;
245 <  const struct shared_flags *shared = NULL;
246 <  char buf[12];
247 <  char *p = NULL;
248 <
249 <  switch (type)
250 <  {
251 <  case CONF_XLINE:
252 <    DLINK_FOREACH(ptr, xconf_items.head)
253 <    {
254 <      conf = ptr->data;
255 <
256 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
257 <                 me.name, source_p->name,
258 <                 conf->hold ? "x": "X", conf->count,
259 <                 conf->name, conf->reason);
260 <    }
261 <    break;
262 <
263 < #ifdef HAVE_LIBPCRE
264 <  case CONF_RXLINE:
265 <    DLINK_FOREACH(ptr, rxconf_items.head)
266 <    {
267 <      conf = ptr->data;
268 <
269 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
270 <                 me.name, source_p->name,
271 <                 "XR", conf->count,
272 <                 conf->name, conf->reason);
273 <    }
274 <    break;
275 <
276 <  case CONF_RKLINE:
277 <    DLINK_FOREACH(ptr, rkconf_items.head)
278 <    {
279 <      conf = ptr->data;
280 <
281 <      sendto_one(source_p, form_str(RPL_STATSKLINE), me.name,
282 <                 source_p->name, "KR", conf->host, conf->user,
283 <                 conf->reason);
284 <    }
285 <    break;
286 < #endif
287 <
288 <  case CONF_ULINE:
289 <    shared = flag_table;
290 <    DLINK_FOREACH(ptr, uconf_items.head)
291 <    {
292 <      conf = ptr->data;
293 <
294 <      p = buf;
295 <
296 <      *p++ = 'c';
297 <      for (; shared->type; ++shared)
298 <        if (shared->type & conf->flags)
299 <          *p++ = shared->letter;
300 <        else
301 <          *p++ = ToLower(shared->letter);
219 >  const struct ClassItem *const class = conf->class;
220 >  int a_limit_reached = 0;
221  
222 <      sendto_one(source_p, form_str(RPL_STATSULINE),
223 <                 me.name, source_p->name, conf->name,
224 <                 conf->user?conf->user: "*",
306 <                 conf->host?conf->host: "*", buf);
307 <    }
222 >  struct ip_entry *ipcache = ipcache_record_find_or_add(&client_p->ip);
223 >  ++ipcache->count_local;
224 >  AddFlag(client_p, FLAGS_IPHASH);
225  
226 <    shared = flag_table;
227 <    DLINK_FOREACH(ptr, cluster_items.head)
228 <    {
229 <      conf = ptr->data;
226 >  if (class->max_total && class->ref_count >= class->max_total)
227 >    a_limit_reached = 1;
228 >  else if (class->max_perip_local && ipcache->count_local > class->max_perip_local)
229 >    a_limit_reached = 1;
230 >  else if (class->max_perip_global &&
231 >           (ipcache->count_local + ipcache->count_remote) > class->max_perip_global)
232 >    a_limit_reached = 1;
233  
234 <      p = buf;
234 >  if (a_limit_reached)
235 >  {
236 >    if (!IsConfExemptLimits(conf))
237 >      return TOO_MANY;   /* Already at maximum allowed */
238  
239 <      *p++ = 'C';
240 <      for (; shared->type; ++shared)
241 <        if (shared->type & conf->flags)
319 <          *p++ = shared->letter;
320 <        else
321 <          *p++ = ToLower(shared->letter);
239 >    sendto_one_notice(client_p, &me, ":*** Your connection class is full, "
240 >                      "but you have exceed_limit = yes;");
241 >  }
242  
243 <      sendto_one(source_p, form_str(RPL_STATSULINE),
244 <                 me.name, source_p->name, conf->name,
325 <                 "*", "*", buf);
326 <    }
243 >  return conf_attach(client_p, conf);
244 > }
245  
246 <    break;
246 > /* verify_access()
247 > *
248 > * inputs       - pointer to client to verify
249 > * output       - 0 if success -'ve if not
250 > * side effect  - find the first (best) I line to attach.
251 > */
252 > static int
253 > verify_access(struct Client *client_p)
254 > {
255 >  struct MaskItem *conf = NULL;
256  
257 <  case CONF_OPER:
258 <    DLINK_FOREACH(ptr, oconf_items.head)
259 <    {
260 <      conf = ptr->data;
257 >  if (HasFlag(client_p, FLAGS_GOTID))
258 >  {
259 >    conf = find_address_conf(client_p->host, client_p->username,
260 >                             &client_p->ip,
261 >                             client_p->ip.ss.ss_family,
262 >                             client_p->connection->password);
263 >  }
264 >  else
265 >  {
266 >    char non_ident[USERLEN + 1] = "~";
267  
268 <      /* Don't allow non opers to see oper privs */
269 <      if (HasUMode(source_p, UMODE_OPER))
270 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
271 <                   me.name, source_p->name, 'O', conf->user, conf->host,
272 <                   conf->name, oper_privs_as_string(conf->port),
273 <                   conf->class ? conf->class->name : "<default>");
341 <      else
342 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
343 <                   me.name, source_p->name, 'O', conf->user, conf->host,
344 <                   conf->name, "0",
345 <                   conf->class ? conf->class->name : "<default>");
346 <    }
347 <    break;
348 <
349 <  case CONF_CLASS:
350 <    DLINK_FOREACH(ptr, class_get_list()->head)
351 <    {
352 <      class = ptr->data;
353 <      sendto_one(source_p, form_str(RPL_STATSYLINE),
354 <                 me.name, source_p->name, 'Y',
355 <                 class->name, class->ping_freq,
356 <                 class->con_freq,
357 <                 class->max_total, class->max_sendq,
358 <                 class->max_recvq,
359 <                 class->ref_count,
360 <                 class->number_per_cidr, class->cidr_bitlen_ipv4,
361 <                 class->number_per_cidr, class->cidr_bitlen_ipv6,
362 <                 class->active ? "active" : "disabled");
363 <    }
364 <    break;
365 <
366 <  case CONF_SERVICE:
367 <    DLINK_FOREACH(ptr, service_items.head)
368 <    {
369 <      conf = ptr->data;
370 <      sendto_one(source_p, form_str(RPL_STATSSERVICE),
371 <                 me.name, source_p->name, 'S', "*", conf->name, 0, 0);
372 <    }
373 <    break;
374 <
375 <  case CONF_SERVER:
376 <    DLINK_FOREACH(ptr, server_items.head)
377 <    {
378 <      p = buf;
379 <      conf = ptr->data;
380 <
381 <      buf[0] = '\0';
382 <
383 <      if (IsConfAllowAutoConn(conf))
384 <        *p++ = 'A';
385 <      if (IsConfSSL(conf))
386 <        *p++ = 'S';
387 <      if (buf[0] == '\0')
388 <        *p++ = '*';
268 >    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
269 >    conf = find_address_conf(client_p->host, non_ident,
270 >                             &client_p->ip,
271 >                             client_p->ip.ss.ss_family,
272 >                             client_p->connection->password);
273 >  }
274  
275 <      *p = '\0';
275 >  if (!conf)
276 >    return NOT_AUTHORIZED;
277  
278 <      /*
393 <       * Allow admins to see actual ips unless hide_server_ips is enabled
394 <       */
395 <      if (!ConfigServerHide.hide_server_ips && HasUMode(source_p, UMODE_ADMIN))
396 <        sendto_one(source_p, form_str(RPL_STATSCLINE),
397 <                   me.name, source_p->name, 'C', conf->host,
398 <                   buf, conf->name, conf->port,
399 <                   conf->class ? conf->class->name : "<default>");
400 <        else
401 <          sendto_one(source_p, form_str(RPL_STATSCLINE),
402 <                     me.name, source_p->name, 'C',
403 <                     "*@127.0.0.1", buf, conf->name, conf->port,
404 <                     conf->class ? conf->class->name : "<default>");
405 <    }
406 <    break;
278 >  assert(IsConfClient(conf) || IsConfKill(conf));
279  
280 <  case CONF_HUB:
281 <    DLINK_FOREACH(ptr, server_items.head)
280 >  if (IsConfClient(conf))
281 >  {
282 >    if (IsConfRedir(conf))
283      {
284 <      conf = ptr->data;
285 <
286 <      DLINK_FOREACH(dptr, conf->hub_list.head)
287 <        sendto_one(source_p, form_str(RPL_STATSHLINE), me.name,
415 <                   source_p->name, 'H', dptr->data, conf->name, 0, "*");
284 >      sendto_one_numeric(client_p, &me, RPL_REDIR,
285 >                         conf->name ? conf->name : "",
286 >                         conf->port);
287 >      return NOT_AUTHORIZED;
288      }
289  
290 <    DLINK_FOREACH(ptr, server_items.head)
290 >    if (IsConfDoSpoofIp(conf))
291      {
292 <      conf = ptr->data;
292 >      if (IsConfSpoofNotice(conf))
293 >        sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE, "%s spoofing: %s as %s",
294 >                             client_p->name, client_p->host, conf->name);
295  
296 <      DLINK_FOREACH(dptr, conf->leaf_list.head)
423 <        sendto_one(source_p, form_str(RPL_STATSLLINE), me.name,
424 <                   source_p->name, 'L', dptr->data, conf->name, 0, "*");
296 >      strlcpy(client_p->host, conf->name, sizeof(client_p->host));
297      }
298  
299 <    break;
428 <
429 <  default:
430 <    break;
299 >    return attach_iline(client_p, conf);
300    }
301 +
302 +  sendto_one_notice(client_p, &me, ":*** Banned: %s", conf->reason);
303 +  return BANNED_CLIENT;
304   }
305  
306   /* check_client()
# Line 448 | Line 320 | int
320   check_client(struct Client *source_p)
321   {
322    int i;
323 <
323 >
324    if ((i = verify_access(source_p)))
325 <    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
325 >    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
326           source_p->name, source_p->sockhost);
327  
328    switch (i)
# Line 458 | Line 330 | check_client(struct Client *source_p)
330      case TOO_MANY:
331        sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
332                             "Too many on IP for %s (%s).",
333 <                           get_client_name(source_p, SHOW_IP),
334 <                           source_p->sockhost);
333 >                           client_get_name(source_p, SHOW_IP),
334 >                           source_p->sockhost);
335        ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
336 <           get_client_name(source_p, SHOW_IP));
336 >           client_get_name(source_p, SHOW_IP));
337        ++ServerStats.is_ref;
338 <      exit_client(source_p, &me, "No more connections allowed on that IP");
338 >      exit_client(source_p, "No more connections allowed on that IP");
339        break;
340  
341      case I_LINE_FULL:
342        sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
343 <                           "auth{} block is full for %s (%s).",
344 <                           get_client_name(source_p, SHOW_IP),
345 <                           source_p->sockhost);
343 >                           "auth {} block is full for %s (%s).",
344 >                           client_get_name(source_p, SHOW_IP),
345 >                           source_p->sockhost);
346        ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
347 <           get_client_name(source_p, SHOW_IP));
347 >           client_get_name(source_p, SHOW_IP));
348        ++ServerStats.is_ref;
349 <      exit_client(source_p, &me,
478 <                "No more connections allowed in your connection class");
349 >      exit_client(source_p, "No more connections allowed in your connection class");
350        break;
351  
352      case NOT_AUTHORIZED:
482      ++ServerStats.is_ref;
353        /* jdc - lists server name & port connections are on */
354        /*       a purely cosmetical change */
355        sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
356 <                           "Unauthorized client connection from %s [%s] on [%s/%u].",
357 <                           get_client_name(source_p, SHOW_IP),
358 <                           source_p->sockhost,
359 <                           source_p->localClient->listener->name,
360 <                           source_p->localClient->listener->port);
361 <      ilog(LOG_TYPE_IRCD,
362 <          "Unauthorized client connection from %s on [%s/%u].",
363 <          get_client_name(source_p, SHOW_IP),
494 <          source_p->localClient->listener->name,
495 <          source_p->localClient->listener->port);
356 >                           "Unauthorized client connection from %s on [%s/%u].",
357 >                           client_get_name(source_p, SHOW_IP),
358 >                           source_p->connection->listener->name,
359 >                           source_p->connection->listener->port);
360 >      ilog(LOG_TYPE_IRCD, "Unauthorized client connection from %s on [%s/%u].",
361 >           client_get_name(source_p, SHOW_IP),
362 >           source_p->connection->listener->name,
363 >           source_p->connection->listener->port);
364  
365 <      exit_client(source_p, &me, "You are not authorized to use this server");
365 >      ++ServerStats.is_ref;
366 >      exit_client(source_p, "You are not authorized to use this server");
367        break;
368  
369 <   case BANNED_CLIENT:
370 <     exit_client(source_p, &me, "Banned");
371 <     ++ServerStats.is_ref;
372 <     break;
504 <
505 <   case 0:
506 <   default:
507 <     break;
508 <  }
509 <
510 <  return (i < 0 ? 0 : 1);
511 < }
512 <
513 < /* verify_access()
514 < *
515 < * inputs       - pointer to client to verify
516 < * output       - 0 if success -'ve if not
517 < * side effect  - find the first (best) I line to attach.
518 < */
519 < static int
520 < verify_access(struct Client *client_p)
521 < {
522 <  struct MaskItem *conf = NULL, *rkconf = NULL;
523 <  char non_ident[USERLEN + 1] = { '~', '\0' };
524 <  const char *uhi[3];
525 <
526 <  if (IsGotId(client_p))
527 <  {
528 <    conf = find_address_conf(client_p->host, client_p->username,
529 <                             &client_p->localClient->ip,
530 <                             client_p->localClient->aftype,
531 <                             client_p->localClient->passwd);
532 <  }
533 <  else
534 <  {
535 <    strlcpy(non_ident+1, client_p->username, sizeof(non_ident)-1);
536 <    conf = find_address_conf(client_p->host,non_ident,
537 <                             &client_p->localClient->ip,
538 <                             client_p->localClient->aftype,
539 <                             client_p->localClient->passwd);
540 <  }
541 <
542 <  uhi[0] = IsGotId(client_p) ? client_p->username : non_ident;
543 <  uhi[1] = client_p->host;
544 <  uhi[2] = client_p->sockhost;
545 <
546 <  rkconf = find_regexp_kline(uhi);
547 <
548 <  if (conf != NULL)
549 <  {
550 <    if (IsConfClient(conf) && !rkconf)
551 <    {
552 <      if (IsConfRedir(conf))
553 <      {
554 <        sendto_one(client_p, form_str(RPL_REDIR),
555 <                   me.name, client_p->name,
556 <                   conf->name ? conf->name : "",
557 <                   conf->port);
558 <        return(NOT_AUTHORIZED);
559 <      }
560 <
561 <      if (IsConfDoIdentd(conf))
562 <        SetNeedId(client_p);
563 <
564 <      /* Thanks for spoof idea amm */
565 <      if (IsConfDoSpoofIp(conf))
566 <      {
567 <        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
568 <          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
569 <                               "%s spoofing: %s as %s",
570 <                               client_p->name, client_p->host, conf->name);
571 <        strlcpy(client_p->host, conf->name, sizeof(client_p->host));
572 <        SetIPSpoof(client_p);
573 <      }
574 <
575 <      return(attach_iline(client_p, conf));
576 <    }
577 <    else if (rkconf || IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
578 <    {
579 <      /* XXX */
580 <      conf = rkconf ? rkconf : conf;
581 <      if (IsConfGline(conf))
582 <        sendto_one(client_p, ":%s NOTICE %s :*** G-lined", me.name,
583 <                   client_p->name);
584 <      sendto_one(client_p, ":%s NOTICE %s :*** Banned: %s",
585 <                 me.name, client_p->name, conf->reason);
586 <      return(BANNED_CLIENT);
587 <    }
588 <  }
589 <
590 <  return(NOT_AUTHORIZED);
591 < }
592 <
593 < /* attach_iline()
594 < *
595 < * inputs       - client pointer
596 < *              - conf pointer
597 < * output       -
598 < * side effects - do actual attach
599 < */
600 < static int
601 < attach_iline(struct Client *client_p, struct MaskItem *conf)
602 < {
603 <  struct ClassItem *class = NULL;
604 <  struct ip_entry *ip_found;
605 <  int a_limit_reached = 0;
606 <  unsigned int local = 0, global = 0, ident = 0;
607 <
608 <  ip_found = find_or_add_ip(&client_p->localClient->ip);
609 <  ip_found->count++;
610 <  SetIpHash(client_p);
611 <
612 <  if (conf->class == NULL)
613 <    return NOT_AUTHORIZED;  /* If class is missing, this is best */
614 <
615 <  class = conf->class;
616 <
617 <  count_user_host(client_p->username, client_p->host,
618 <                  &global, &local, &ident);
619 <
620 <  /* XXX blah. go down checking the various silly limits
621 <   * setting a_limit_reached if any limit is reached.
622 <   * - Dianora
623 <   */
624 <  if (class->max_total != 0 && class->ref_count >= class->max_total)
625 <    a_limit_reached = 1;
626 <  else if (class->max_perip != 0 && ip_found->count > class->max_perip)
627 <    a_limit_reached = 1;
628 <  else if (class->max_local != 0 && local >= class->max_local)
629 <    a_limit_reached = 1;
630 <  else if (class->max_global != 0 && global >= class->max_global)
631 <    a_limit_reached = 1;
632 <  else if (class->max_ident != 0 && ident >= class->max_ident &&
633 <           client_p->username[0] != '~')
634 <    a_limit_reached = 1;
635 <
636 <  if (a_limit_reached)
637 <  {
638 <    if (!IsConfExemptLimits(conf))
639 <      return TOO_MANY;   /* Already at maximum allowed */
640 <
641 <    sendto_one(client_p,
642 <               ":%s NOTICE %s :*** Your connection class is full, "
643 <               "but you have exceed_limit = yes;", me.name, client_p->name);
644 <  }
645 <
646 <  return attach_conf(client_p, conf);
647 < }
648 <
649 < /* init_ip_hash_table()
650 < *
651 < * inputs               - NONE
652 < * output               - NONE
653 < * side effects         - allocate memory for ip_entry(s)
654 < *                      - clear the ip hash table
655 < */
656 < void
657 < init_ip_hash_table(void)
658 < {
659 <  ip_entry_heap = BlockHeapCreate("ip", sizeof(struct ip_entry),
660 <    2 * hard_fdlimit);
661 <  memset(ip_hash_table, 0, sizeof(ip_hash_table));
662 < }
663 <
664 < /* find_or_add_ip()
665 < *
666 < * inputs       - pointer to struct irc_ssaddr
667 < * output       - pointer to a struct ip_entry
668 < * side effects -
669 < *
670 < * If the ip # was not found, a new struct ip_entry is created, and the ip
671 < * count set to 0.
672 < */
673 < static struct ip_entry *
674 < find_or_add_ip(struct irc_ssaddr *ip_in)
675 < {
676 <  struct ip_entry *ptr, *newptr;
677 <  int hash_index = hash_ip(ip_in), res;
678 <  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
679 < #ifdef IPV6
680 <  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
681 < #endif
682 <
683 <  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
684 <  {
685 < #ifdef IPV6
686 <    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
687 <      continue;
688 <    if (ip_in->ss.ss_family == AF_INET6)
689 <    {
690 <      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
691 <      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
692 <    }
693 <    else
694 < #endif
695 <    {
696 <      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
697 <      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
698 <    }
699 <    if (res == 0)
700 <    {
701 <      /* Found entry already in hash, return it. */
702 <      return ptr;
703 <    }
704 <  }
705 <
706 <  if (ip_entries_count >= 2 * hard_fdlimit)
707 <    garbage_collect_ip_entries();
708 <
709 <  newptr = BlockHeapAlloc(ip_entry_heap);
710 <  ip_entries_count++;
711 <  memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
712 <
713 <  newptr->next = ip_hash_table[hash_index];
714 <  ip_hash_table[hash_index] = newptr;
715 <
716 <  return newptr;
717 < }
718 <
719 < /* remove_one_ip()
720 < *
721 < * inputs        - unsigned long IP address value
722 < * output        - NONE
723 < * side effects  - The ip address given, is looked up in ip hash table
724 < *                 and number of ip#'s for that ip decremented.
725 < *                 If ip # count reaches 0 and has expired,
726 < *                 the struct ip_entry is returned to the ip_entry_heap
727 < */
728 < void
729 < remove_one_ip(struct irc_ssaddr *ip_in)
730 < {
731 <  struct ip_entry *ptr;
732 <  struct ip_entry *last_ptr = NULL;
733 <  int hash_index = hash_ip(ip_in), res;
734 <  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
735 < #ifdef IPV6
736 <  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
737 < #endif
738 <
739 <  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
740 <  {
741 < #ifdef IPV6
742 <    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
743 <      continue;
744 <    if (ip_in->ss.ss_family == AF_INET6)
745 <    {
746 <      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
747 <      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
748 <    }
749 <    else
750 < #endif
751 <    {
752 <      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
753 <      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
754 <    }
755 <    if (res)
756 <      continue;
757 <    if (ptr->count > 0)
758 <      ptr->count--;
759 <    if (ptr->count == 0 &&
760 <        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
761 <    {
762 <      if (last_ptr != NULL)
763 <        last_ptr->next = ptr->next;
764 <      else
765 <        ip_hash_table[hash_index] = ptr->next;
369 >    case BANNED_CLIENT:
370 >      ++ServerStats.is_ref;
371 >      exit_client(source_p, "Banned");
372 >      break;
373  
374 <      BlockHeapFree(ip_entry_heap, ptr);
375 <      ip_entries_count--;
376 <      return;
770 <    }
771 <    last_ptr = ptr;
374 >    case 0:
375 >    default:
376 >      break;
377    }
773 }
774
775 /* hash_ip()
776 *
777 * input        - pointer to an irc_inaddr
778 * output       - integer value used as index into hash table
779 * side effects - hopefully, none
780 */
781 static int
782 hash_ip(struct irc_ssaddr *addr)
783 {
784  if (addr->ss.ss_family == AF_INET)
785  {
786    struct sockaddr_in *v4 = (struct sockaddr_in *)addr;
787    int hash;
788    uint32_t ip;
378  
379 <    ip   = ntohl(v4->sin_addr.s_addr);
791 <    hash = ((ip >> 12) + ip) & (IP_HASH_SIZE-1);
792 <    return hash;
793 <  }
794 < #ifdef IPV6
795 <  else
796 <  {
797 <    int hash;
798 <    struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)addr;
799 <    uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
800 <
801 <    hash  = ip[0] ^ ip[3];
802 <    hash ^= hash >> 16;  
803 <    hash ^= hash >> 8;  
804 <    hash  = hash & (IP_HASH_SIZE - 1);
805 <    return hash;
806 <  }
807 < #else
808 <  return 0;
809 < #endif
379 >  return !(i < 0);
380   }
381  
382 < /* count_ip_hash()
383 < *
384 < * inputs        - pointer to counter of number of ips hashed
385 < *               - pointer to memory used for ip hash
816 < * output        - returned via pointers input
817 < * side effects  - NONE
818 < *
819 < * number of hashed ip #'s is counted up, plus the amount of memory
820 < * used in the hash.
382 > /*! \brief Disassociate configuration from the client. Also removes a class
383 > *         from the list if marked for deleting.
384 > * \param client_p Client to operate on
385 > * \param type     Type of conf to detach
386   */
387   void
388 < count_ip_hash(unsigned int *number_ips_stored, uint64_t *mem_ips_stored)
388 > conf_detach(struct Client *client_p, enum maskitem_type type)
389   {
390 <  struct ip_entry *ptr;
826 <  int i;
827 <
828 <  *number_ips_stored = 0;
829 <  *mem_ips_stored    = 0;
390 >  dlink_node *node, *node_next;
391  
392 <  for (i = 0; i < IP_HASH_SIZE; i++)
392 >  DLINK_FOREACH_SAFE(node, node_next, client_p->connection->confs.head)
393    {
394 <    for (ptr = ip_hash_table[i]; ptr; ptr = ptr->next)
834 <    {
835 <      *number_ips_stored += 1;
836 <      *mem_ips_stored += sizeof(struct ip_entry);
837 <    }
838 <  }
839 < }
840 <
841 < /* garbage_collect_ip_entries()
842 < *
843 < * input        - NONE
844 < * output       - NONE
845 < * side effects - free up all ip entries with no connections
846 < */
847 < static void
848 < garbage_collect_ip_entries(void)
849 < {
850 <  struct ip_entry *ptr;
851 <  struct ip_entry *last_ptr;
852 <  struct ip_entry *next_ptr;
853 <  int i;
854 <
855 <  for (i = 0; i < IP_HASH_SIZE; i++)
856 <  {
857 <    last_ptr = NULL;
858 <
859 <    for (ptr = ip_hash_table[i]; ptr; ptr = next_ptr)
860 <    {
861 <      next_ptr = ptr->next;
862 <
863 <      if (ptr->count == 0 &&
864 <          (CurrentTime - ptr->last_attempt) >= ConfigFileEntry.throttle_time)
865 <      {
866 <        if (last_ptr != NULL)
867 <          last_ptr->next = ptr->next;
868 <        else
869 <          ip_hash_table[i] = ptr->next;
870 <        BlockHeapFree(ip_entry_heap, ptr);
871 <        ip_entries_count--;
872 <      }
873 <      else
874 <        last_ptr = ptr;
875 <    }
876 <  }
877 < }
878 <
879 < /* detach_conf()
880 < *
881 < * inputs       - pointer to client to detach
882 < *              - type of conf to detach
883 < * output       - 0 for success, -1 for failure
884 < * side effects - Disassociate configuration from the client.
885 < *                Also removes a class from the list if marked for deleting.
886 < */
887 < void
888 < detach_conf(struct Client *client_p, enum maskitem_type type)
889 < {
890 <  dlink_node *ptr = NULL, *next_ptr = NULL;
891 <
892 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->localClient->confs.head)
893 <  {
894 <    struct MaskItem *conf = ptr->data;
394 >    struct MaskItem *conf = node->data;
395  
396      assert(conf->type & (CONF_CLIENT | CONF_OPER | CONF_SERVER));
397      assert(conf->ref_count > 0);
# Line 900 | Line 400 | detach_conf(struct Client *client_p, enu
400      if (!(conf->type & type))
401        continue;
402  
403 <    dlinkDelete(ptr, &client_p->localClient->confs);
404 <    free_dlink_node(ptr);
403 >    dlinkDelete(node, &client_p->connection->confs);
404 >    free_dlink_node(node);
405  
406      if (conf->type == CONF_CLIENT)
407 <      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
407 >      remove_from_cidr_check(&client_p->ip, conf->class);
408  
409      if (--conf->class->ref_count == 0 && conf->class->active == 0)
410      {
# Line 917 | Line 417 | detach_conf(struct Client *client_p, enu
417    }
418   }
419  
420 < /* attach_conf()
421 < *
422 < * inputs       - client pointer
423 < *              - conf pointer
424 < * output       -
925 < * side effects - Associate a specific configuration entry to a *local*
926 < *                client (this is the one which used in accepting the
927 < *                connection). Note, that this automatically changes the
928 < *                attachment if there was an old one...
420 > /*! \brief Associate a specific configuration entry to a *local* client (this
421 > *         is the one which used in accepting the connection). Note, that this
422 > *         automatically changes the attachment if there was an old one.
423 > * \param client_p Client to attach the conf to
424 > * \param conf Configuration record to attach
425   */
426   int
427 < attach_conf(struct Client *client_p, struct MaskItem *conf)
427 > conf_attach(struct Client *client_p, struct MaskItem *conf)
428   {
429 <  if (dlinkFind(&client_p->localClient->confs, conf) != NULL)
429 >  if (dlinkFind(&client_p->connection->confs, conf))
430      return 1;
431  
432    if (conf->type == CONF_CLIENT)
433      if (cidr_limit_reached(IsConfExemptLimits(conf),
434 <                           &client_p->localClient->ip, conf->class))
434 >                           &client_p->ip, conf->class))
435        return TOO_MANY;    /* Already at maximum allowed */
436  
437    conf->class->ref_count++;
438    conf->ref_count++;
439  
440 <  dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
945 <
946 <  return 0;
947 < }
948 <
949 < /* attach_connect_block()
950 < *
951 < * inputs       - pointer to server to attach
952 < *              - name of server
953 < *              - hostname of server
954 < * output       - true (1) if both are found, otherwise return false (0)
955 < * side effects - find connect block and attach them to connecting client
956 < */
957 < int
958 < attach_connect_block(struct Client *client_p, const char *name,
959 <                     const char *host)
960 < {
961 <  dlink_node *ptr;
962 <  struct MaskItem *conf = NULL;
963 <
964 <  assert(client_p != NULL);
965 <  assert(host != NULL);
966 <
967 <  if (client_p == NULL || host == NULL)
968 <    return 0;
969 <
970 <  DLINK_FOREACH(ptr, server_items.head)
971 <  {
972 <    conf = ptr->data;
973 <
974 <    if (match(conf->name, name) == 0 || match(conf->host, host) == 0)
975 <      continue;
976 <
977 <    attach_conf(client_p, conf);
978 <    return -1;
979 <  }
440 >  dlinkAdd(conf, make_dlink_node(), &client_p->connection->confs);
441  
442    return 0;
443   }
# Line 993 | Line 454 | attach_connect_block(struct Client *clie
454   struct MaskItem *
455   find_conf_name(dlink_list *list, const char *name, enum maskitem_type type)
456   {
457 <  dlink_node *ptr;
997 <  struct MaskItem* conf;
457 >  dlink_node *node = NULL;
458  
459 <  DLINK_FOREACH(ptr, list->head)
459 >  DLINK_FOREACH(node, list->head)
460    {
461 <    conf = ptr->data;
462 <    
461 >    struct MaskItem *conf = node->data;
462 >
463      if (conf->type == type)
464      {
465 <      if (conf->name && (irccmp(conf->name, name) == 0 ||
466 <                         match(conf->name, name)))
1007 <      return conf;
465 >      if (conf->name && !irccmp(conf->name, name))
466 >        return conf;
467      }
468    }
469  
470    return NULL;
471   }
472  
473 < /* map_to_list()
474 < *
475 < * inputs       - ConfType conf
1017 < * output       - pointer to dlink_list to use
1018 < * side effects - none
1019 < */
1020 < static dlink_list *
1021 < map_to_list(enum maskitem_type type)
1022 < {
1023 <  switch(type)
1024 <  {
1025 <  case CONF_RKLINE:
1026 <    return(&rkconf_items);
1027 <    break;
1028 <  case CONF_RXLINE:
1029 <    return(&rxconf_items);
1030 <    break;
1031 <  case CONF_XLINE:
1032 <    return(&xconf_items);
1033 <    break;
1034 <  case CONF_ULINE:
1035 <    return(&uconf_items);
1036 <    break;
1037 <  case CONF_NRESV:
1038 <    return(&nresv_items);
1039 <    break;
1040 <  case CONF_OPER:
1041 <    return(&oconf_items);
1042 <    break;
1043 <  case CONF_SERVER:
1044 <    return(&server_items);
1045 <    break;
1046 <  case CONF_SERVICE:
1047 <    return(&service_items);
1048 <    break;
1049 <  case CONF_CLUSTER:
1050 <    return(&cluster_items);
1051 <    break;
1052 <  default:
1053 <    return NULL;
1054 <  }
1055 < }
1056 <
1057 < /* find_matching_name_conf()
1058 < *
1059 < * inputs       - type of link list to look in
1060 < *              - pointer to name string to find
1061 < *              - pointer to user
1062 < *              - pointer to host
1063 < *              - optional flags to match on as well
1064 < * output       - NULL or pointer to found struct MaskItem
1065 < * side effects - looks for a match on name field
473 > /*! \brief Find a connect {} conf that has a name that matches \a name.
474 > * \param name Name to match
475 > * \param compare Pointer to function to be used for string matching
476   */
477   struct MaskItem *
478 < find_matching_name_conf(enum maskitem_type type, const char *name, const char *user,
1069 <                        const char *host, unsigned int flags)
478 > connect_find(const char *name, int (*compare)(const char *, const char *))
479   {
480 <  dlink_node *ptr=NULL;
1072 <  struct MaskItem *conf=NULL;
1073 <  dlink_list *list_p = map_to_list(type);
480 >  dlink_node *node;
481  
482 <  switch (type)
482 >  DLINK_FOREACH(node, connect_items.head)
483    {
484 < #ifdef HAVE_LIBPCRE
1078 <  case CONF_RXLINE:
1079 <      DLINK_FOREACH(ptr, list_p->head)
1080 <      {
1081 <        conf = ptr->data;
1082 <        assert(conf->regexpname);
1083 <
1084 <        if (!ircd_pcre_exec(conf->regexuser, name))
1085 <          return conf;
1086 <      }
1087 <      break;
1088 < #endif
1089 <  case CONF_SERVICE:
1090 <    DLINK_FOREACH(ptr, list_p->head)
1091 <    {
1092 <      conf = ptr->data;
1093 <
1094 <      if (EmptyString(conf->name))
1095 <        continue;
1096 <      if ((name != NULL) && !irccmp(name, conf->name))
1097 <        return conf;
1098 <    }
1099 <    break;
1100 <
1101 <  case CONF_XLINE:
1102 <  case CONF_ULINE:
1103 <  case CONF_NRESV:
1104 <    DLINK_FOREACH(ptr, list_p->head)
1105 <    {
1106 <      conf = ptr->data;
1107 <
1108 <      if (EmptyString(conf->name))
1109 <        continue;
1110 <      if ((name != NULL) && match_esc(conf->name, name))
1111 <      {
1112 <        if ((user == NULL && (host == NULL)))
1113 <          return conf;
1114 <        if ((conf->flags & flags) != flags)
1115 <          continue;
1116 <        if (EmptyString(conf->user) || EmptyString(conf->host))
1117 <          return conf;
1118 <        if (match(conf->user, user) && match(conf->host, host))
1119 <          return conf;
1120 <      }
1121 <    }
1122 <      break;
484 >    struct MaskItem *conf = node->data;
485  
486 <  case CONF_SERVER:
487 <    DLINK_FOREACH(ptr, list_p->head)
1126 <    {
1127 <      conf = ptr->data;
1128 <
1129 <      if ((name != NULL) && match(name, conf->name))
1130 <        return conf;
1131 <      else if ((host != NULL) && match(host, conf->host))
1132 <        return conf;
1133 <    }
1134 <    break;
1135 <  
1136 <  default:
1137 <    break;
486 >    if (!compare(name, conf->name))
487 >      return conf;
488    }
489 +
490    return NULL;
491   }
492  
# Line 1149 | Line 500 | find_matching_name_conf(enum maskitem_ty
500   * side effects - looks for an exact match on name field
501   */
502   struct MaskItem *
503 < find_exact_name_conf(enum maskitem_type type, const struct Client *who, const char *name,
1153 <                     const char *user, const char *host)
503 > operator_find(const struct Client *who, const char *name)
504   {
505 <  dlink_node *ptr = NULL;
1156 <  struct MaskItem *conf;
1157 <  dlink_list *list_p = map_to_list(type);
505 >  dlink_node *node = NULL;
506  
507 <  switch(type)
507 >  DLINK_FOREACH(node, operator_items.head)
508    {
509 <  case CONF_RXLINE:
1162 <  case CONF_XLINE:
1163 <  case CONF_ULINE:
1164 <  case CONF_NRESV:
1165 <
1166 <    DLINK_FOREACH(ptr, list_p->head)
1167 <    {
1168 <      conf = ptr->data;
509 >    struct MaskItem *conf = node->data;
510  
511 <      if (EmptyString(conf->name))
1171 <        continue;
1172 <    
1173 <      if (irccmp(conf->name, name) == 0)
1174 <      {
1175 <        if ((user == NULL && (host == NULL)))
1176 <          return (conf);
1177 <        if (EmptyString(conf->user) || EmptyString(conf->host))
1178 <          return (conf);
1179 <        if (match(conf->user, user) && match(conf->host, host))
1180 <          return (conf);
1181 <      }
1182 <    }
1183 <    break;
1184 <
1185 <  case CONF_OPER:
1186 <    DLINK_FOREACH(ptr, list_p->head)
511 >    if (!irccmp(conf->name, name))
512      {
513 <      conf = ptr->data;
514 <
1190 <      if (EmptyString(conf->name))
1191 <        continue;
513 >      if (!who)
514 >        return conf;
515  
516 <      if (!irccmp(conf->name, name))
516 >      if (!match(conf->user, who->username))
517        {
518 <        if (!who)
1196 <          return conf;
1197 <        if (EmptyString(conf->user) || EmptyString(conf->host))
1198 <          return NULL;
1199 <        if (match(conf->user, who->username))
518 >        switch (conf->htype)
519          {
520 <          switch (conf->htype)
521 <          {
522 <            case HM_HOST:
523 <              if (match(conf->host, who->host) || match(conf->host, who->sockhost))
520 >          case HM_HOST:
521 >            if (!match(conf->host, who->host) || !match(conf->host, who->sockhost))
522 >              if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
523 >                return conf;
524 >            break;
525 >          case HM_IPV4:
526 >            if (who->ip.ss.ss_family == AF_INET)
527 >              if (match_ipv4(&who->ip, &conf->addr, conf->bits))
528                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
529                    return conf;
530 <              break;
531 <            case HM_IPV4:
532 <              if (who->localClient->aftype == AF_INET)
533 <                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
534 <                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
535 <                    return conf;
536 <              break;
537 < #ifdef IPV6
538 <            case HM_IPV6:
1216 <              if (who->localClient->aftype == AF_INET6)
1217 <                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
1218 <                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
1219 <                    return conf;
1220 <              break;
1221 < #endif
1222 <            default:
1223 <              assert(0);
1224 <          }
530 >            break;
531 >          case HM_IPV6:
532 >            if (who->ip.ss.ss_family == AF_INET6)
533 >              if (match_ipv6(&who->ip, &conf->addr, conf->bits))
534 >                if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
535 >                  return conf;
536 >            break;
537 >          default:
538 >            assert(0);
539          }
540        }
541      }
1228
1229    break;
1230
1231  case CONF_SERVER:
1232    DLINK_FOREACH(ptr, list_p->head)
1233    {
1234      conf = ptr->data;
1235
1236      if (EmptyString(conf->name))
1237        continue;
1238    
1239      if (name == NULL)
1240      {
1241        if (EmptyString(conf->host))
1242          continue;
1243        if (irccmp(conf->host, host) == 0)
1244          return(conf);
1245      }
1246      else if (irccmp(conf->name, name) == 0)
1247      {
1248          return (conf);
1249      }
1250    }
1251    break;
1252
1253  default:
1254    break;
542    }
1256  return(NULL);
1257 }
1258
1259 /* rehash()
1260 *
1261 * Actual REHASH service routine. Called with sig == 0 if it has been called
1262 * as a result of an operator issuing this command, else assume it has been
1263 * called as a result of the server receiving a HUP signal.
1264 */
1265 int
1266 rehash(int sig)
1267 {
1268  if (sig != 0)
1269    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1270                         "Got signal SIGHUP, reloading ircd.conf file");
1271
1272  restart_resolver();
543  
544 <  /* don't close listeners until we know we can go ahead with the rehash */
1275 <
1276 <  /* Check to see if we magically got(or lost) IPv6 support */
1277 <  check_can_use_v6();
1278 <
1279 <  read_conf_files(0);
1280 <
1281 <  if (ServerInfo.description != NULL)
1282 <    strlcpy(me.info, ServerInfo.description, sizeof(me.info));
1283 <
1284 <  load_conf_modules();
1285 <
1286 <  rehashed_klines = 1;
1287 < /* XXX */
1288 <  if (ConfigLoggingEntry.use_logging)
1289 <    log_close_all();
1290 <
1291 <  return(0);
544 >  return NULL;
545   }
546  
547   /* set_default_conf()
# Line 1308 | Line 561 | set_default_conf(void)
561     */
562    assert(class_default == class_get_list()->tail->data);
563  
564 < #ifdef HAVE_LIBCRYPTO
565 <  ServerInfo.rsa_private_key = NULL;
566 <  ServerInfo.rsa_private_key_file = NULL;
567 < #endif
568 <
569 <  /* ServerInfo.name is not rehashable */
570 <  /* ServerInfo.name = ServerInfo.name; */
571 <  ServerInfo.description = NULL;
572 <  DupString(ServerInfo.network_name, NETWORK_NAME_DEFAULT);
573 <  DupString(ServerInfo.network_desc, NETWORK_DESC_DEFAULT);
574 <
575 <  memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
1323 <  ServerInfo.specific_ipv4_vhost = 0;
1324 <  memset(&ServerInfo.ip6, 0, sizeof(ServerInfo.ip6));
1325 <  ServerInfo.specific_ipv6_vhost = 0;
1326 <
1327 <  ServerInfo.max_clients = MAXCLIENTS_MAX;
1328 <
1329 <  ServerInfo.hub = 0;
1330 <  ServerInfo.dns_host.sin_addr.s_addr = 0;
1331 <  ServerInfo.dns_host.sin_port = 0;
1332 <  AdminInfo.name = NULL;
1333 <  AdminInfo.email = NULL;
1334 <  AdminInfo.description = NULL;
564 >  ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
565 >  ConfigServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
566 >
567 >  memset(&ConfigServerInfo.ip, 0, sizeof(ConfigServerInfo.ip));
568 >  ConfigServerInfo.specific_ipv4_vhost = 0;
569 >  memset(&ConfigServerInfo.ip6, 0, sizeof(ConfigServerInfo.ip6));
570 >  ConfigServerInfo.specific_ipv6_vhost = 0;
571 >
572 >  ConfigServerInfo.default_max_clients = MAXCLIENTS_MAX;
573 >  ConfigServerInfo.max_nick_length = 9;
574 >  ConfigServerInfo.max_topic_length = 80;
575 >  ConfigServerInfo.hub = 0;
576  
577 <  log_close_all();
577 >  log_iterate(log_free);
578  
579 <  ConfigLoggingEntry.use_logging = 1;
579 >  ConfigLog.use_logging = 1;
580  
581    ConfigChannel.disable_fake_channels = 0;
582 <  ConfigChannel.restrict_channels = 0;
583 <  ConfigChannel.knock_delay = 300;
582 >  ConfigChannel.invite_client_count = 10;
583 >  ConfigChannel.invite_client_time = 300;
584 >  ConfigChannel.invite_delay_channel = 5;
585 >  ConfigChannel.invite_expire_time = 1800;
586 >  ConfigChannel.knock_client_count = 1;
587 >  ConfigChannel.knock_client_time = 300;
588    ConfigChannel.knock_delay_channel = 60;
589 <  ConfigChannel.max_chans_per_user = 25;
590 <  ConfigChannel.max_chans_per_oper = 50;
591 <  ConfigChannel.quiet_on_ban = 1;
592 <  ConfigChannel.max_bans = 25;
593 <  ConfigChannel.default_split_user_count = 0;
594 <  ConfigChannel.default_split_server_count = 0;
1350 <  ConfigChannel.no_join_on_split = 0;
1351 <  ConfigChannel.no_create_on_split = 0;
589 >  ConfigChannel.max_channels = 25;
590 >  ConfigChannel.max_invites = 20;
591 >  ConfigChannel.max_bans = 100;
592 >  ConfigChannel.max_bans_large = 500;
593 >  ConfigChannel.default_join_flood_count = 18;
594 >  ConfigChannel.default_join_flood_time = 6;
595  
596    ConfigServerHide.flatten_links = 0;
597 <  ConfigServerHide.links_delay = 300;
597 >  ConfigServerHide.flatten_links_delay = 300;
598    ConfigServerHide.hidden = 0;
599    ConfigServerHide.hide_servers = 0;
600 <  DupString(ConfigServerHide.hidden_name, NETWORK_NAME_DEFAULT);
600 >  ConfigServerHide.hide_services = 0;
601 >  ConfigServerHide.hidden_name = xstrdup(NETWORK_NAME_DEFAULT);
602    ConfigServerHide.hide_server_ips = 0;
603 +  ConfigServerHide.disable_remote_commands = 0;
604  
605 <  
606 <  DupString(ConfigFileEntry.service_name, SERVICE_NAME_DEFAULT);
607 <  ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
608 <  ConfigFileEntry.glines = 0;
609 <  ConfigFileEntry.gline_time = 12 * 3600;
610 <  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
611 <  ConfigFileEntry.gline_min_cidr = 16;
612 <  ConfigFileEntry.gline_min_cidr6 = 48;
613 <  ConfigFileEntry.invisible_on_connect = 1;
614 <  ConfigFileEntry.tkline_expire_notices = 1;
615 <  ConfigFileEntry.hide_spoof_ips = 1;
616 <  ConfigFileEntry.ignore_bogus_ts = 0;
617 <  ConfigFileEntry.disable_auth = 0;
618 <  ConfigFileEntry.disable_remote = 0;
619 <  ConfigFileEntry.kill_chase_time_limit = 90;
620 <  ConfigFileEntry.default_floodcount = 8;
621 <  ConfigFileEntry.failed_oper_notice = 1;
622 <  ConfigFileEntry.dots_in_ident = 0;
623 <  ConfigFileEntry.min_nonwildcard = 4;
624 <  ConfigFileEntry.min_nonwildcard_simple = 3;
625 <  ConfigFileEntry.max_accept = 20;
626 <  ConfigFileEntry.anti_nick_flood = 0;
627 <  ConfigFileEntry.max_nick_time = 20;
628 <  ConfigFileEntry.max_nick_changes = 5;
629 <  ConfigFileEntry.anti_spam_exit_message_time = 0;
630 <  ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
631 <  ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
632 <  ConfigFileEntry.warn_no_nline = 1;
633 <  ConfigFileEntry.stats_o_oper_only = 0;
634 <  ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
635 <  ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
636 <  ConfigFileEntry.stats_P_oper_only = 0;
637 <  ConfigFileEntry.caller_id_wait = 60;
638 <  ConfigFileEntry.opers_bypass_callerid = 0;
639 <  ConfigFileEntry.pace_wait = 10;
640 <  ConfigFileEntry.pace_wait_simple = 1;
641 <  ConfigFileEntry.short_motd = 0;
642 <  ConfigFileEntry.ping_cookie = 0;
643 <  ConfigFileEntry.no_oper_flood = 0;
644 <  ConfigFileEntry.true_no_oper_flood = 0;
645 <  ConfigFileEntry.oper_pass_resv = 1;
646 <  ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
647 <  ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
648 <  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
649 <    UMODE_OPERWALL | UMODE_WALLOP;
650 <  ConfigFileEntry.use_egd = 0;
651 <  ConfigFileEntry.egdpool_path = NULL;
652 <  ConfigFileEntry.throttle_time = 10;
605 >  ConfigGeneral.away_count = 2;
606 >  ConfigGeneral.away_time = 10;
607 >  ConfigGeneral.max_watch = 50;
608 >  ConfigGeneral.whowas_history_length = 15000;
609 >  ConfigGeneral.cycle_on_host_change = 1;
610 >  ConfigGeneral.dline_min_cidr = 16;
611 >  ConfigGeneral.dline_min_cidr6 = 48;
612 >  ConfigGeneral.kline_min_cidr = 16;
613 >  ConfigGeneral.kline_min_cidr6 = 48;
614 >  ConfigGeneral.invisible_on_connect = 1;
615 >  ConfigGeneral.tkline_expire_notices = 1;
616 >  ConfigGeneral.ignore_bogus_ts = 0;
617 >  ConfigGeneral.disable_auth = 0;
618 >  ConfigGeneral.kill_chase_time_limit = 90;
619 >  ConfigGeneral.default_floodcount = 8;
620 >  ConfigGeneral.default_floodtime = 1;
621 >  ConfigGeneral.failed_oper_notice = 1;
622 >  ConfigGeneral.dots_in_ident = 0;
623 >  ConfigGeneral.min_nonwildcard = 4;
624 >  ConfigGeneral.min_nonwildcard_simple = 3;
625 >  ConfigGeneral.max_accept = 50;
626 >  ConfigGeneral.anti_nick_flood = 0;
627 >  ConfigGeneral.max_nick_time = 20;
628 >  ConfigGeneral.max_nick_changes = 5;
629 >  ConfigGeneral.anti_spam_exit_message_time = 0;
630 >  ConfigGeneral.ts_warn_delta = 30;
631 >  ConfigGeneral.ts_max_delta = 600;
632 >  ConfigGeneral.warn_no_connect_block = 1;
633 >  ConfigGeneral.stats_e_disabled = 0;
634 >  ConfigGeneral.stats_i_oper_only = 1;  /* 1 = masked */
635 >  ConfigGeneral.stats_k_oper_only = 1;  /* 1 = masked */
636 >  ConfigGeneral.stats_o_oper_only = 1;
637 >  ConfigGeneral.stats_m_oper_only = 1;
638 >  ConfigGeneral.stats_P_oper_only = 0;
639 >  ConfigGeneral.stats_u_oper_only = 0;
640 >  ConfigGeneral.caller_id_wait = 60;
641 >  ConfigGeneral.opers_bypass_callerid = 1;
642 >  ConfigGeneral.pace_wait = 10;
643 >  ConfigGeneral.pace_wait_simple = 1;
644 >  ConfigGeneral.short_motd = 0;
645 >  ConfigGeneral.ping_cookie = 0;
646 >  ConfigGeneral.no_oper_flood = 0;
647 >  ConfigGeneral.max_targets = MAX_TARGETS_DEFAULT;
648 >  ConfigGeneral.oper_only_umodes = UMODE_DEBUG | UMODE_LOCOPS | UMODE_HIDDEN | UMODE_FARCONNECT |
649 >                                   UMODE_UNAUTH | UMODE_EXTERNAL | UMODE_BOTS | UMODE_NCHANGE |
650 >                                   UMODE_SPY | UMODE_FULL | UMODE_SKILL | UMODE_REJ | UMODE_CCONN;
651 >  ConfigGeneral.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE | UMODE_WALLOP;
652 >  ConfigGeneral.throttle_count = 1;
653 >  ConfigGeneral.throttle_time = 1;
654   }
655  
656   static void
657   validate_conf(void)
658   {
659 <  if (ConfigFileEntry.ts_warn_delta < TS_WARN_DELTA_MIN)
660 <    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1415 <
1416 <  if (ConfigFileEntry.ts_max_delta < TS_MAX_DELTA_MIN)
1417 <    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
659 >  if (EmptyString(ConfigServerInfo.network_name))
660 >    ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
661  
662 <  if (ServerInfo.network_name == NULL)
663 <    DupString(ServerInfo.network_name,NETWORK_NAME_DEFAULT);
1421 <
1422 <  if (ServerInfo.network_desc == NULL)
1423 <    DupString(ServerInfo.network_desc,NETWORK_DESC_DEFAULT);
1424 <
1425 <  if (ConfigFileEntry.service_name == NULL)
1426 <    DupString(ConfigFileEntry.service_name, SERVICE_NAME_DEFAULT);
1427 <
1428 <  ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
662 >  if (EmptyString(ConfigServerInfo.network_desc))
663 >    ConfigServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
664   }
665  
666 < /* read_conf()
666 > /* read_conf()
667   *
668   * inputs       - file descriptor pointing to config file to use
669   * output       - None
# Line 1437 | Line 672 | validate_conf(void)
672   static void
673   read_conf(FILE *file)
674   {
675 <  lineno = 0;
675 >  lineno = 1;
676  
677 <  set_default_conf(); /* Set default values prior to conf parsing */
677 >  set_default_conf();  /* Set default values prior to conf parsing */
678    conf_parser_ctx.pass = 1;
679 <  yyparse();          /* pick up the classes first */
679 >  yyparse();  /* Pick up the classes first */
680  
681    rewind(file);
682  
683    conf_parser_ctx.pass = 2;
684 <  yyparse();          /* Load the values from the conf */
685 <  validate_conf();    /* Check to make sure some values are still okay. */
686 <                      /* Some global values are also loaded here. */
687 <  class_delete_marked();      /* Make sure classes are valid */
684 >  yyparse();  /* Load the values from the conf */
685 >  validate_conf();  /* Check to make sure some values are still okay. */
686 >                    /* Some global values are also loaded here. */
687 >  whowas_trim();  /* Attempt to trim whowas list if necessary */
688 >  class_delete_marked();  /* Delete unused classes that are marked for deletion */
689 > }
690 >
691 > /* conf_rehash()
692 > *
693 > * Actual REHASH service routine. Called with sig == 0 if it has been called
694 > * as a result of an operator issuing this command, else assume it has been
695 > * called as a result of the server receiving a HUP signal.
696 > */
697 > void
698 > conf_rehash(int sig)
699 > {
700 >  if (sig)
701 >  {
702 >    sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
703 >                         "Got signal SIGHUP, reloading configuration file(s)");
704 >    ilog(LOG_TYPE_IRCD, "Got signal SIGHUP, reloading configuration file(s)");
705 >  }
706 >
707 >  restart_resolver();
708 >
709 >  /* don't close listeners until we know we can go ahead with the rehash */
710 >
711 >  read_conf_files(0);
712 >
713 >  load_conf_modules();
714 >  check_conf_klines();
715   }
716  
717   /* lookup_confhost()
# Line 1457 | Line 719 | read_conf(FILE *file)
719   * start DNS lookups of all hostnames in the conf
720   * line and convert an IP addresses in a.b.c.d number for to IP#s.
721   */
722 < static void
722 > void
723   lookup_confhost(struct MaskItem *conf)
724   {
725    struct addrinfo hints, *res;
726  
727 <  if (has_wildcards(conf->host))
728 <  {
1467 <    ilog(LOG_TYPE_IRCD, "Host/server name error: (%s) (%s)",
1468 <         conf->host, conf->name);
1469 <    return;
1470 <  }
1471 <
1472 <  /* Do name lookup now on hostnames given and store the
727 >  /*
728 >   * Do name lookup now on hostnames given and store the
729     * ip numbers in conf structure.
730     */
731    memset(&hints, 0, sizeof(hints));
# Line 1486 | Line 742 | lookup_confhost(struct MaskItem *conf)
742      return;
743    }
744  
745 <  assert(res != NULL);
745 >  assert(res);
746  
747    memcpy(&conf->addr, res->ai_addr, res->ai_addrlen);
748    conf->addr.ss_len = res->ai_addrlen;
# Line 1505 | Line 761 | lookup_confhost(struct MaskItem *conf)
761   int
762   conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
763   {
764 <  struct ip_entry *ip_found;
765 <  struct MaskItem *conf = find_dline_conf(addr, aftype);
764 >  struct ip_entry *ip_found = NULL;
765 >  const struct MaskItem *conf = find_dline_conf(addr, aftype);
766  
767 <  /* DLINE exempt also gets you out of static limits/pacing... */
1512 <  if (conf && (conf->type == CONF_EXEMPT))
1513 <    return 0;
1514 <
1515 <  if (conf != NULL)
1516 <    return BANNED_CLIENT;
1517 <
1518 <  ip_found = find_or_add_ip(addr);
1519 <
1520 <  if ((CurrentTime - ip_found->last_attempt) <
1521 <      ConfigFileEntry.throttle_time)
767 >  if (conf)
768    {
769 <    ip_found->last_attempt = CurrentTime;
770 <    return TOO_FAST;
769 >    /* DLINE exempt also gets you out of static limits/pacing... */
770 >    if (conf->type == CONF_EXEMPT)
771 >      return 0;
772 >    return BANNED_CLIENT;
773    }
774  
775 <  ip_found->last_attempt = CurrentTime;
1528 <  return 0;
1529 < }
1530 <
1531 < static struct MaskItem *
1532 < find_regexp_kline(const char *uhi[])
1533 < {
1534 < #ifdef HAVE_LIBPCRE
1535 <  const dlink_node *ptr = NULL;
775 >  ip_found = ipcache_record_find_or_add(addr);
776  
777 <  DLINK_FOREACH(ptr, rkconf_items.head)
777 >  if ((CurrentTime - ip_found->last_attempt) < ConfigGeneral.throttle_time)
778    {
779 <    struct MaskItem *aptr = ptr->data;
779 >    if (ip_found->connection_count >= ConfigGeneral.throttle_count)
780 >      return TOO_FAST;
781  
782 <    assert(aptr->regexuser);
1542 <    assert(aptr->regexhost);
1543 <
1544 <    if (!ircd_pcre_exec(aptr->regexuser, uhi[0]) &&
1545 <        (!ircd_pcre_exec(aptr->regexhost, uhi[1]) ||
1546 <         !ircd_pcre_exec(aptr->regexhost, uhi[2])))
1547 <      return aptr;
782 >    ++ip_found->connection_count;
783    }
784 < #endif
785 <  return NULL;
1551 < }
1552 <
1553 < /* find_kill()
1554 < *
1555 < * inputs       - pointer to client structure
1556 < * output       - pointer to struct MaskItem if found
1557 < * side effects - See if this user is klined already,
1558 < *                and if so, return struct MaskItem pointer
1559 < */
1560 < struct MaskItem *
1561 < find_kill(struct Client *client_p)
1562 < {
1563 <  struct MaskItem *conf = NULL;
1564 <  const char *uhi[3];
1565 <
1566 <  uhi[0] = client_p->username;
1567 <  uhi[1] = client_p->host;
1568 <  uhi[2] = client_p->sockhost;
1569 <
1570 <  assert(client_p != NULL);
1571 <
1572 <  conf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
1573 <                              CONF_KLINE, client_p->localClient->aftype,
1574 <                              client_p->username, NULL, 1);
1575 <  if (conf == NULL)
1576 <    conf = find_regexp_kline(uhi);
1577 <
1578 <  return conf;
1579 < }
1580 <
1581 < struct MaskItem *
1582 < find_gline(struct Client *client_p)
1583 < {
1584 <  struct MaskItem *conf;
1585 <
1586 <  assert(client_p != NULL);
784 >  else
785 >    ip_found->connection_count = 1;
786  
787 <  conf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
788 <                              CONF_GLINE, client_p->localClient->aftype,
1590 <                              client_p->username, NULL, 1);
1591 <  return conf;
787 >  ip_found->last_attempt = CurrentTime;
788 >  return 0;
789   }
790  
791   /* cleanup_tklines()
# Line 1599 | Line 796 | find_gline(struct Client *client_p)
796   *                This is an event started off in ircd.c
797   */
798   void
799 < cleanup_tklines(void *notused)
799 > cleanup_tklines(void *unused)
800   {
801    hostmask_expire_temporary();
802 <  expire_tklines(&xconf_items);
803 <  expire_tklines(&nresv_items);
1607 <  expire_tklines(&resv_channel_list);
1608 < }
1609 <
1610 < /* expire_tklines()
1611 < *
1612 < * inputs       - tkline list pointer
1613 < * output       - NONE
1614 < * side effects - expire tklines
1615 < */
1616 < static void
1617 < expire_tklines(dlink_list *tklist)
1618 < {
1619 <  dlink_node *ptr;
1620 <  dlink_node *next_ptr;
1621 <  struct MaskItem *conf;
1622 <
1623 <  DLINK_FOREACH_SAFE(ptr, next_ptr, tklist->head)
1624 <  {
1625 <    conf = ptr->data;
1626 <
1627 <    if (!conf->hold || conf->hold > CurrentTime)
1628 <      continue;
1629 <
1630 <    if (conf->type == CONF_XLINE)
1631 <    {
1632 <      if (ConfigFileEntry.tkline_expire_notices)
1633 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1634 <                               "Temporary X-line for [%s] expired", conf->name);
1635 <      conf_free(conf);
1636 <    }
1637 <    else if (conf->type == CONF_NRESV)
1638 <    {
1639 <      if (ConfigFileEntry.tkline_expire_notices)
1640 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1641 <                               "Temporary RESV for [%s] expired", conf->name);
1642 <      conf_free(conf);
1643 <    }
1644 <    else if (conf->type == CONF_CRESV)
1645 <    {
1646 <      if (ConfigFileEntry.tkline_expire_notices)
1647 <        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1648 <                               "Temporary RESV for [%s] expired", conf->name);
1649 <      delete_channel_resv(conf);
1650 <    }
1651 <  }
802 >  gecos_expire();
803 >  resv_expire();
804   }
805  
806   /* oper_privs_as_string()
# Line 1657 | Line 809 | expire_tklines(dlink_list *tklist)
809   * output        - pointer to static string showing oper privs
810   * side effects  - return as string, the oper privs as derived from port
811   */
812 < static const struct oper_privs
812 > static const struct oper_flags
813   {
814    const unsigned int flag;
815    const unsigned char c;
816 < } flag_list[] = {
817 <  { OPER_FLAG_ADMIN,       'A' },
818 <  { OPER_FLAG_REMOTEBAN,   'B' },
819 <  { OPER_FLAG_DIE,         'D' },
820 <  { OPER_FLAG_GLINE,       'G' },
821 <  { OPER_FLAG_REHASH,      'H' },
822 <  { OPER_FLAG_K,           'K' },
823 <  { OPER_FLAG_OPERWALL,    'L' },
824 <  { OPER_FLAG_N,           'N' },
825 <  { OPER_FLAG_GLOBAL_KILL, 'O' },
826 <  { OPER_FLAG_REMOTE,      'R' },
827 <  { OPER_FLAG_OPER_SPY,    'S' },
828 <  { OPER_FLAG_UNKLINE,     'U' },
829 <  { OPER_FLAG_X,           'X' },
816 > } flag_table[] = {
817 >  { OPER_FLAG_ADMIN,          'A' },
818 >  { OPER_FLAG_CLOSE,          'B' },
819 >  { OPER_FLAG_CONNECT,        'C' },
820 >  { OPER_FLAG_CONNECT_REMOTE, 'D' },
821 >  { OPER_FLAG_DIE,            'E' },
822 >  { OPER_FLAG_DLINE,          'F' },
823 >  { OPER_FLAG_GLOBOPS,        'G' },
824 >  { OPER_FLAG_JOIN_RESV,      'H' },
825 >  { OPER_FLAG_KILL,           'I' },
826 >  { OPER_FLAG_KILL_REMOTE,    'J' },
827 >  { OPER_FLAG_KLINE,          'K' },
828 >  { OPER_FLAG_LOCOPS,         'L' },
829 >  { OPER_FLAG_MODULE,         'M' },
830 >  { OPER_FLAG_NICK_RESV,      'N' },
831 >  { OPER_FLAG_OPME,           'O' },
832 >  { OPER_FLAG_REHASH,         'P' },
833 >  { OPER_FLAG_REMOTEBAN,      'Q' },
834 >  { OPER_FLAG_RESTART,        'R' },
835 >  { OPER_FLAG_RESV,           'S' },
836 >  { OPER_FLAG_SET,            'T' },
837 >  { OPER_FLAG_SQUIT,          'U' },
838 >  { OPER_FLAG_SQUIT_REMOTE,   'V' },
839 >  { OPER_FLAG_UNDLINE,        'W' },
840 >  { OPER_FLAG_UNKLINE,        'X' },
841 >  { OPER_FLAG_UNRESV,         'Y' },
842 >  { OPER_FLAG_UNXLINE,        'Z' },
843 >  { OPER_FLAG_WALLOPS,        'a' },
844 >  { OPER_FLAG_XLINE,          'b' },
845    { 0, '\0' }
846   };
847  
848 < char *
849 < oper_privs_as_string(const unsigned int port)
848 > const char *
849 > oper_privs_as_string(const unsigned int flags)
850   {
851 <  static char privs_out[16];
852 <  char *privs_ptr = privs_out;
1686 <  const struct oper_privs *opriv = flag_list;
851 >  static char buf[sizeof(flag_table) / sizeof(flag_table[0])];
852 >  char *p = buf;
853  
854 <  for (; opriv->flag; ++opriv)
855 <  {
856 <    if (port & opriv->flag)
857 <      *privs_ptr++ = opriv->c;
858 <    else
859 <      *privs_ptr++ = ToLower(opriv->c);
1694 <  }
854 >  for (const struct oper_flags *tab = flag_table; tab->flag; ++tab)
855 >    if (flags & tab->flag)
856 >      *p++ = tab->c;
857 >
858 >  if (p == buf)
859 >    *p++ = '0';
860  
861 <  *privs_ptr = '\0';
861 >  *p = '\0';
862  
863 <  return privs_out;
863 >  return buf;
864   }
865  
866   /*
867 < * Input: A client to find the active oper{} name for.
867 > * Input: A client to find the active operator {} name for.
868   * Output: The nick!user@host{oper} of the oper.
869   *         "oper" is server name for remote opers
870   * Side effects: None.
# Line 1707 | Line 872 | oper_privs_as_string(const unsigned int
872   const char *
873   get_oper_name(const struct Client *client_p)
874   {
875 <  dlink_node *cnode = NULL;
876 <  /* +5 for !,@,{,} and null */
877 <  static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
875 >  static char buffer[IRCD_BUFSIZE];
876 >
877 >  if (IsServer(client_p))
878 >    return client_p->name;
879  
880    if (MyConnect(client_p))
881    {
882 <    if ((cnode = client_p->localClient->confs.head))
882 >    const dlink_node *const node = client_p->connection->confs.head;
883 >
884 >    if (node)
885      {
886 <      struct MaskItem *conf = cnode->data;
886 >      const struct MaskItem *const conf = node->data;
887  
888 <      if (IsConfOperator(conf))
888 >      if (conf->type == CONF_OPER)
889        {
890 <        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
890 >        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
891                   client_p->username, client_p->host, conf->name);
892 <        return buffer;
892 >        return buffer;
893        }
894      }
895  
896 <    /* Probably should assert here for now. If there is an oper out there
897 <     * with no oper{} conf attached, it would be good for us to know...
896 >    /*
897 >     * Probably should assert here for now. If there is an oper out there
898 >     * with no operator {} conf attached, it would be good for us to know...
899       */
900 <    assert(0); /* Oper without oper conf! */
900 >    assert(0);  /* Oper without oper conf! */
901    }
902  
903    snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
904 <           client_p->username, client_p->host, client_p->servptr->name);
904 >           client_p->username, client_p->host, client_p->servptr->name);
905    return buffer;
906   }
907  
1739 /* read_conf_files()
1740 *
1741 * inputs       - cold start YES or NO
1742 * output       - none
1743 * side effects - read all conf files needed, ircd.conf kline.conf etc.
1744 */
1745 void
1746 read_conf_files(int cold)
1747 {
1748  const char *filename;
1749  char chanmodes[32];
1750  char chanlimit[32];
1751
1752  conf_parser_ctx.boot = cold;
1753  filename = ConfigFileEntry.configfile;
1754
1755  /* We need to know the initial filename for the yyerror() to report
1756     FIXME: The full path is in conffilenamebuf first time since we
1757             dont know anything else
1758
1759     - Gozem 2002-07-21
1760  */
1761  strlcpy(conffilebuf, filename, sizeof(conffilebuf));
1762
1763  if ((conf_parser_ctx.conf_file = fopen(filename, "r")) == NULL)
1764  {
1765    if (cold)
1766    {
1767      ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
1768           filename, strerror(errno));
1769      exit(-1);
1770    }
1771    else
1772    {
1773      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1774                           "Unable to read configuration file '%s': %s",
1775                           filename, strerror(errno));
1776      return;
1777    }
1778  }
1779
1780  if (!cold)
1781    clear_out_old_conf();
1782
1783  read_conf(conf_parser_ctx.conf_file);
1784  fclose(conf_parser_ctx.conf_file);
1785
1786  add_isupport("NETWORK", ServerInfo.network_name, -1);
1787  snprintf(chanmodes, sizeof(chanmodes), "beI:%d",
1788           ConfigChannel.max_bans);
1789  add_isupport("MAXLIST", chanmodes, -1);
1790  add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1791
1792  add_isupport("CHANTYPES", "#", -1);
1793
1794  snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1795           ConfigChannel.max_chans_per_user);
1796  add_isupport("CHANLIMIT", chanlimit, -1);
1797  snprintf(chanmodes, sizeof(chanmodes), "%s",
1798           "beI,k,l,imnprstORS");
1799  add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
1800
1801  add_isupport("EXCEPTS", "e", -1);
1802  add_isupport("INVEX", "I", -1);
1803  add_isupport("CHANMODES", chanmodes, -1);
1804
1805  /*
1806   * message_locale may have changed.  rebuild isupport since it relies
1807   * on strlen(form_str(RPL_ISUPPORT))
1808   */
1809  rebuild_isupport_message_line();
1810 }
1811
908   /* clear_out_old_conf()
909   *
910   * inputs       - none
# Line 1818 | Line 914 | read_conf_files(int cold)
914   static void
915   clear_out_old_conf(void)
916   {
917 <  dlink_node *ptr = NULL, *next_ptr = NULL;
1822 <  struct MaskItem *conf;
917 >  dlink_node *node = NULL, *node_next = NULL;
918    dlink_list *free_items [] = {
919 <    &server_items,   &oconf_items,
1825 <     &uconf_items,   &xconf_items, &rxconf_items, &rkconf_items,
1826 <     &nresv_items, &cluster_items,  &service_items, NULL
919 >    &connect_items, &operator_items, NULL
920    };
921  
922    dlink_list ** iterator = free_items; /* C is dumb */
# Line 1831 | Line 924 | clear_out_old_conf(void)
924    /* We only need to free anything allocated by yyparse() here.
925     * Resetting structs, etc, is taken care of by set_default_conf().
926     */
927 <  
928 <  for (; *iterator != NULL; iterator++)
927 >
928 >  for (; *iterator; iterator++)
929    {
930 <    DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
930 >    DLINK_FOREACH_SAFE(node, node_next, (*iterator)->head)
931      {
932 <      conf = ptr->data;
932 >      struct MaskItem *conf = node->data;
933  
934 <      dlinkDelete(&conf->node, map_to_list(conf->type));
934 >      conf->active = 0;
935 >      dlinkDelete(&conf->node, *iterator);
936  
937 <      /* XXX This is less than pretty */
1844 <      if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
1845 <      {
1846 <        if (!conf->ref_count)
1847 <          conf_free(conf);
1848 <      }
1849 <      else if (conf->type == CONF_XLINE  ||
1850 <               conf->type == CONF_RXLINE ||
1851 <               conf->type == CONF_RKLINE)
1852 <      {
1853 <        if (!conf->hold)
1854 <          conf_free(conf);
1855 <      }
1856 <      else
937 >      if (!conf->ref_count)
938          conf_free(conf);
939      }
940    }
941  
942    /*
943 <   * don't delete the class table, rather mark all entries
944 <   * for deletion. The table is cleaned up by class_delete_marked. - avalon
943 >   * Don't delete the class table, rather mark all entries for deletion.
944 >   * The table is cleaned up by class_delete_marked. - avalon
945     */
946    class_mark_for_deletion();
947  
948    clear_out_address_conf();
949  
950 <  /* clean out module paths */
951 <  mod_clear_paths();
950 >  modules_conf_clear();  /* Clear modules {} items */
951 >
952 >  motd_clear();  /* Clear motd {} items and re-cache default motd */
953 >
954 >  cluster_clear();  /* Clear cluster {} items */
955  
956 <  /* clean out ServerInfo */
1873 <  MyFree(ServerInfo.description);
1874 <  ServerInfo.description = NULL;
1875 <  MyFree(ServerInfo.network_name);
1876 <  ServerInfo.network_name = NULL;
1877 <  MyFree(ServerInfo.network_desc);
1878 <  ServerInfo.network_desc = NULL;
1879 <  MyFree(ConfigFileEntry.egdpool_path);
1880 <  ConfigFileEntry.egdpool_path = NULL;
1881 < #ifdef HAVE_LIBCRYPTO
1882 <  if (ServerInfo.rsa_private_key != NULL)
1883 <  {
1884 <    RSA_free(ServerInfo.rsa_private_key);
1885 <    ServerInfo.rsa_private_key = NULL;
1886 <  }
1887 <
1888 <  MyFree(ServerInfo.rsa_private_key_file);
1889 <  ServerInfo.rsa_private_key_file = NULL;
1890 <
1891 <  if (ServerInfo.server_ctx)
1892 <    SSL_CTX_set_options(ServerInfo.server_ctx, SSL_OP_NO_SSLv2|
1893 <                                               SSL_OP_NO_SSLv3|
1894 <                                               SSL_OP_NO_TLSv1);
1895 <  if (ServerInfo.client_ctx)
1896 <    SSL_CTX_set_options(ServerInfo.client_ctx, SSL_OP_NO_SSLv2|
1897 <                                               SSL_OP_NO_SSLv3|
1898 <                                               SSL_OP_NO_TLSv1);
1899 < #endif
1900 <
1901 <  /* clean out old resvs from the conf */
1902 <  clear_conf_resv();
1903 <
1904 <  /* clean out AdminInfo */
1905 <  MyFree(AdminInfo.name);
1906 <  AdminInfo.name = NULL;
1907 <  MyFree(AdminInfo.email);
1908 <  AdminInfo.email = NULL;
1909 <  MyFree(AdminInfo.description);
1910 <  AdminInfo.description = NULL;
1911 <
1912 <  /* clean out listeners */
1913 <  close_listeners();
1914 <
1915 <  /* clean out general */
1916 <  MyFree(ConfigFileEntry.service_name);
1917 <  ConfigFileEntry.service_name = NULL;
956 >  gecos_clear();  /* Clear gecos {} items */
957  
958 <  delete_isupport("INVEX");
959 <  delete_isupport("EXCEPTS");
958 >  resv_clear();  /* Clear resv {} items */
959 >
960 >  service_clear();  /* Clear service {} items */
961 >
962 >  shared_clear();  /* Clear shared {} items */
963 >
964 >  pseudo_clear();  /* Clear pseudo {} items */
965 >
966 >  /* Clean out ConfigServerInfo */
967 >  xfree(ConfigServerInfo.description);
968 >  ConfigServerInfo.description = NULL;
969 >  xfree(ConfigServerInfo.network_name);
970 >  ConfigServerInfo.network_name = NULL;
971 >  xfree(ConfigServerInfo.network_desc);
972 >  ConfigServerInfo.network_desc = NULL;
973 >  xfree(ConfigServerInfo.rsa_private_key_file);
974 >  ConfigServerInfo.rsa_private_key_file = NULL;
975 >  xfree(ConfigServerInfo.ssl_certificate_file);
976 >  ConfigServerInfo.ssl_certificate_file = NULL;
977 >  xfree(ConfigServerInfo.ssl_dh_param_file);
978 >  ConfigServerInfo.ssl_dh_param_file = NULL;
979 >  xfree(ConfigServerInfo.ssl_dh_elliptic_curve);
980 >  ConfigServerInfo.ssl_dh_elliptic_curve = NULL;
981 >  xfree(ConfigServerInfo.ssl_cipher_list);
982 >  ConfigServerInfo.ssl_cipher_list = NULL;
983 >  xfree(ConfigServerInfo.ssl_message_digest_algorithm);
984 >  ConfigServerInfo.ssl_message_digest_algorithm = NULL;
985 >
986 >  /* Clean out ConfigAdminInfo */
987 >  xfree(ConfigAdminInfo.name);
988 >  ConfigAdminInfo.name = NULL;
989 >  xfree(ConfigAdminInfo.email);
990 >  ConfigAdminInfo.email = NULL;
991 >  xfree(ConfigAdminInfo.description);
992 >  ConfigAdminInfo.description = NULL;
993 >
994 >  /* Clean out ConfigServerHide */
995 >  xfree(ConfigServerHide.flatten_links_file);
996 >  ConfigServerHide.flatten_links_file = NULL;
997 >  xfree(ConfigServerHide.hidden_name);
998 >  ConfigServerHide.hidden_name = NULL;
999 >
1000 >  /* Clean out listeners */
1001 >  listener_close_marked();
1002   }
1003  
1004 < /* conf_add_class_to_conf()
1004 > static void
1005 > conf_handle_tls(int cold)
1006 > {
1007 >  if (!tls_new_cred())
1008 >  {
1009 >    if (cold)
1010 >    {
1011 >      ilog(LOG_TYPE_IRCD, "Error while initializing TLS");
1012 >      exit(EXIT_FAILURE);
1013 >    }
1014 >    else
1015 >    {
1016 >      /* Failed to load new settings/certs, old ones remain active */
1017 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ALL, SEND_NOTICE,
1018 >                           "Error reloading TLS settings, check the ircd log"); // report_crypto_errors logs this
1019 >    }
1020 >  }
1021 > }
1022 >
1023 > /* read_conf_files()
1024   *
1025 < * inputs       - pointer to config item
1026 < * output       - NONE
1027 < * side effects - Add a class pointer to a conf
1025 > * inputs       - cold start YES or NO
1026 > * output       - none
1027 > * side effects - read all conf files needed, ircd.conf kline.conf etc.
1028   */
1029   void
1030 < conf_add_class_to_conf(struct MaskItem *conf, const char *class_name)
1030 > read_conf_files(int cold)
1031   {
1032 <  struct ClassItem *class = NULL;
1032 >  const char *filename = NULL;
1033 >  char chanmodes[IRCD_BUFSIZE] = "";
1034 >  char chanlimit[IRCD_BUFSIZE] = "";
1035  
1036 <  if (class_name == NULL)
1037 <  {
1936 <    conf->class = class_default;
1036 >  conf_parser_ctx.boot = cold;
1037 >  filename = ConfigGeneral.configfile;
1038  
1039 <    if (conf->type == CONF_CLIENT)
1040 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1041 <                           "Warning *** Defaulting to default class for %s@%s",
1042 <                           conf->user, conf->host);
1043 <    else
1044 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1045 <                           "Warning *** Defaulting to default class for %s",
1945 <                           conf->name);
1946 <  }
1947 <  else
1948 <    conf->class = class_find(class_name, 1);
1039 >  /* We need to know the initial filename for the yyerror() to report
1040 >     FIXME: The full path is in conffilenamebuf first time since we
1041 >             don't know anything else
1042 >
1043 >     - Gozem 2002-07-21
1044 >  */
1045 >  strlcpy(conffilebuf, filename, sizeof(conffilebuf));
1046  
1047 <  if (conf->class == NULL)
1047 >  if ((conf_parser_ctx.conf_file = fopen(filename, "r")) == NULL)
1048    {
1049 <    if (conf->type == CONF_CLIENT)
1050 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1051 <                           "Warning *** Defaulting to default class for %s@%s",
1052 <                           conf->user, conf->host);
1049 >    if (cold)
1050 >    {
1051 >      ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
1052 >           filename, strerror(errno));
1053 >      exit(EXIT_FAILURE);
1054 >    }
1055      else
1056 <      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1057 <                           "Warning *** Defaulting to default class for %s",
1058 <                           conf->name);
1059 <    conf->class = class_default;
1056 >    {
1057 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1058 >                           "Unable to read configuration file '%s': %s",
1059 >                           filename, strerror(errno));
1060 >      return;
1061 >    }
1062    }
1063 +
1064 +  if (!cold)
1065 +    clear_out_old_conf();
1066 +
1067 +  read_conf(conf_parser_ctx.conf_file);
1068 +  fclose(conf_parser_ctx.conf_file);
1069 +
1070 +  log_iterate(log_reopen);
1071 +  conf_handle_tls(cold);
1072 +
1073 +  isupport_add("NICKLEN", NULL, ConfigServerInfo.max_nick_length);
1074 +  isupport_add("NETWORK", ConfigServerInfo.network_name, -1);
1075 +
1076 +  snprintf(chanmodes, sizeof(chanmodes), "beI:%u", ConfigChannel.max_bans);
1077 +  isupport_add("MAXLIST", chanmodes, -1);
1078 +  isupport_add("MAXTARGETS", NULL, ConfigGeneral.max_targets);
1079 +  isupport_add("CHANTYPES", "#", -1);
1080 +
1081 +  snprintf(chanlimit, sizeof(chanlimit), "#:%u",
1082 +           ConfigChannel.max_channels);
1083 +  isupport_add("CHANLIMIT", chanlimit, -1);
1084 +  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,cimnprstuCLMNORST");
1085 +  isupport_add("CHANNELLEN", NULL, CHANNELLEN);
1086 +  isupport_add("TOPICLEN", NULL, ConfigServerInfo.max_topic_length);
1087 +  isupport_add("CHANMODES", chanmodes, -1);
1088   }
1089  
1090 < /* conf_add_server()
1090 > /* conf_add_class_to_conf()
1091   *
1092   * inputs       - pointer to config item
1967 *              - pointer to link count already on this conf
1093   * output       - NONE
1094 < * side effects - Add a connect block
1094 > * side effects - Add a class pointer to a conf
1095   */
1096 < int
1097 < conf_add_server(struct MaskItem *conf, const char *class_name)
1096 > void
1097 > conf_add_class_to_conf(struct MaskItem *conf, const char *name)
1098   {
1099 <  conf_add_class_to_conf(conf, class_name);
1975 <
1976 <  if (EmptyString(conf->host) || EmptyString(conf->name))
1099 >  if (EmptyString(name) || (conf->class = class_find(name, 1)) == NULL)
1100    {
1101 <    sendto_realops_flags(UMODE_ALL, L_ALL,  SEND_NOTICE,
1979 <                         "Bad connect block");
1980 <    ilog(LOG_TYPE_IRCD, "Bad connect block");
1981 <    return -1;
1982 <  }
1101 >    conf->class = class_default;
1102  
1103 <  if (EmptyString(conf->passwd))
1104 <  {
1105 <    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1106 <                         "Bad connect block, name %s",
1107 <                         conf->name);
1108 <    ilog(LOG_TYPE_IRCD, "Bad connect block, host %s", conf->name);
1109 <    return -1;
1103 >    if (conf->type == CONF_CLIENT || conf->type == CONF_OPER)
1104 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1105 >                           "Warning *** Defaulting to default class for %s@%s",
1106 >                           conf->user, conf->host);
1107 >    else
1108 >      sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1109 >                           "Warning *** Defaulting to default class for %s",
1110 >                           conf->name);
1111    }
1992
1993  lookup_confhost(conf);
1994
1995  return 0;
1112   }
1113  
1114   /* yyerror()
# Line 2004 | Line 1120 | conf_add_server(struct MaskItem *conf, c
1120   void
1121   yyerror(const char *msg)
1122   {
2007  char newlinebuf[IRCD_BUFSIZE];
2008
1123    if (conf_parser_ctx.pass != 1)
1124      return;
1125  
1126 <  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1127 <  sendto_realops_flags(UMODE_ALL, L_ALL,  SEND_NOTICE,
1126 >  const char *p = stripws(linebuf);
1127 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1128                         "\"%s\", line %u: %s: %s",
1129 <                       conffilebuf, lineno + 1, msg, newlinebuf);
1129 >                       conffilebuf, lineno, msg, p);
1130    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1131 <       conffilebuf, lineno + 1, msg, newlinebuf);
1131 >       conffilebuf, lineno, msg, p);
1132 > }
1133 >
1134 > void
1135 > conf_error_report(const char *msg)
1136 > {
1137 >  const char *p = stripws(linebuf);
1138 >  sendto_realops_flags(UMODE_SERVNOTICE, L_ADMIN, SEND_NOTICE,
1139 >                       "\"%s\", line %u: %s: %s",
1140 >                       conffilebuf, lineno, msg, p);
1141 >  ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1142 >       conffilebuf, lineno, msg, p);
1143   }
1144  
1145   /*
1146   * valid_tkline()
1147 < *
1147 > *
1148   * inputs       - pointer to ascii string to check
1149   *              - whether the specified time is in seconds or minutes
1150   * output       - -1 not enough parameters
# Line 2027 | Line 1152 | yyerror(const char *msg)
1152   * side effects - none
1153   * Originally written by Dianora (Diane, db@db.net)
1154   */
1155 < time_t
1156 < valid_tkline(const char *p, int minutes)
1155 > uintmax_t
1156 > valid_tkline(const char *data, const int minutes)
1157   {
1158 <  time_t result = 0;
1158 >  const unsigned char *p = (const unsigned char *)data;
1159 >  unsigned char tmpch = '\0';
1160 >  uintmax_t result = 0;
1161  
1162 <  for (; *p; ++p)
1162 >  while ((tmpch = *p++))
1163    {
1164 <    if (!IsDigit(*p))
1164 >    if (!IsDigit(tmpch))
1165        return 0;
1166  
1167      result *= 10;
1168 <    result += ((*p) & 0xF);
1168 >    result += (tmpch & 0xF);
1169    }
1170  
1171    /*
1172 <   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1173 <   * i.e. they specifically use 0, I am going to return 1 instead
1174 <   * as a return value of non-zero is used to flag it as a temporary kline
1172 >   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1173 >   * i.e. they specifically use 0, I am going to return 1 instead as a return
1174 >   * value of non-zero is used to flag it as a temporary kline
1175     */
1176    if (result == 0)
1177      result = 1;
1178  
1179 <  /*
1179 >  /*
1180     * If the incoming time is in seconds convert it to minutes for the purpose
1181     * of this calculation
1182     */
1183 <  if (!minutes)
1184 <    result = result / (time_t)60;
1183 >  if (minutes == 0)
1184 >    result = result / 60;
1185  
1186    if (result > MAX_TDKLINE_TIME)
1187      result = MAX_TDKLINE_TIME;
1188  
1189 <  result = result * (time_t)60;  /* turn it into seconds */
1189 >  result = result * 60;  /* Turn it into seconds */
1190  
1191    return result;
1192   }
1193  
1194 + /* valid_wild_card_simple()
1195 + *
1196 + * inputs       - data to check for sufficient non-wildcard characters
1197 + * outputs      - 1 if valid, else 0
1198 + * side effects - none
1199 + */
1200 + int
1201 + valid_wild_card_simple(const char *data)
1202 + {
1203 +  const unsigned char *p = (const unsigned char *)data;
1204 +  unsigned char tmpch = '\0';
1205 +  unsigned int nonwild = 0, wild = 0;
1206 +
1207 +  while ((tmpch = *p++))
1208 +  {
1209 +    if (tmpch == '\\' && *p)
1210 +    {
1211 +      ++p;
1212 +      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1213 +        return 1;
1214 +    }
1215 +    else if (!IsMWildChar(tmpch))
1216 +    {
1217 +      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1218 +        return 1;
1219 +    }
1220 +    else
1221 +      ++wild;
1222 +  }
1223 +
1224 +  return !wild;
1225 + }
1226 +
1227   /* valid_wild_card()
1228   *
1229   * input        - pointer to client
# Line 2073 | Line 1233 | valid_tkline(const char *p, int minutes)
1233   * side effects - NOTICE is given to source_p if warn is 1
1234   */
1235   int
1236 < valid_wild_card(struct Client *source_p, int warn, int count, ...)
1236 > valid_wild_card(int count, ...)
1237   {
1238 <  char *p;
1239 <  char tmpch;
2080 <  int nonwild = 0;
1238 >  unsigned char tmpch = '\0';
1239 >  unsigned int nonwild = 0;
1240    va_list args;
1241  
1242    /*
# Line 2096 | Line 1255 | valid_wild_card(struct Client *source_p,
1255  
1256    while (count--)
1257    {
1258 <    p = va_arg(args, char *);
1258 >    const unsigned char *p = va_arg(args, const unsigned char *);
1259      if (p == NULL)
1260        continue;
1261  
# Line 2108 | Line 1267 | valid_wild_card(struct Client *source_p,
1267           * If we find enough non-wild characters, we can
1268           * break - no point in searching further.
1269           */
1270 <        if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1270 >        if (++nonwild >= ConfigGeneral.min_nonwildcard)
1271 >        {
1272 >          va_end(args);
1273            return 1;
1274 +        }
1275        }
1276      }
1277    }
1278  
1279 <  if (warn)
1280 <    sendto_one(source_p, ":%s NOTICE %s :Please include at least %d non-wildcard characters with the mask",
1281 <               me.name, source_p->name, ConfigFileEntry.min_nonwildcard);
1279 >  va_end(args);
1280 >  return 0;
1281 > }
1282 >
1283 > /* find_user_host()
1284 > *
1285 > * inputs       - pointer to client placing kline
1286 > *              - pointer to user_host_or_nick
1287 > *              - pointer to user buffer
1288 > *              - pointer to host buffer
1289 > * output       - 0 if not ok to kline, 1 to kline i.e. if valid user host
1290 > * side effects -
1291 > */
1292 > static int
1293 > find_user_host(struct Client *source_p, char *user_host_or_nick,
1294 >               char *luser, char *lhost)
1295 > {
1296 >  struct Client *target_p = NULL;
1297 >  char *hostp = NULL;
1298 >
1299 >  if (lhost == NULL)
1300 >  {
1301 >    strlcpy(luser, user_host_or_nick, USERLEN*4 + 1);
1302 >    return 1;
1303 >  }
1304 >
1305 >  if ((hostp = strchr(user_host_or_nick, '@')) || *user_host_or_nick == '*')
1306 >  {
1307 >    /* Explicit user@host mask given */
1308 >    if (hostp)                            /* I'm a little user@host */
1309 >    {
1310 >      *(hostp++) = '\0';                       /* short and squat */
1311 >
1312 >      if (*user_host_or_nick)
1313 >        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1314 >      else
1315 >        strcpy(luser, "*");
1316 >
1317 >      if (*hostp)
1318 >        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
1319 >      else
1320 >        strcpy(lhost, "*");
1321 >    }
1322 >    else
1323 >    {
1324 >      luser[0] = '*';             /* no @ found, assume its *@somehost */
1325 >      luser[1] = '\0';
1326 >      strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
1327 >    }
1328 >
1329 >    return 1;
1330 >  }
1331 >  else
1332 >  {
1333 >    /* Try to find user@host mask from nick */
1334 >    /* Okay to use source_p as the first param, because source_p == client_p */
1335 >    if ((target_p =
1336 >        find_chasing(source_p, user_host_or_nick)) == NULL)
1337 >      return 0;  /* find_chasing sends ERR_NOSUCHNICK */
1338 >
1339 >    if (HasFlag(target_p, FLAGS_EXEMPTKLINE))
1340 >    {
1341 >      if (IsClient(source_p))
1342 >        sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
1343 >      return 0;
1344 >    }
1345 >
1346 >    /*
1347 >     * Turn the "user" bit into "*user", blow away '~'
1348 >     * if found in original user name (non-idented)
1349 >     */
1350 >    strlcpy(luser, target_p->username, USERLEN*4 + 1);
1351 >
1352 >    if (target_p->username[0] == '~')
1353 >      luser[0] = '*';
1354 >
1355 >    strlcpy(lhost, target_p->sockhost, HOSTLEN*4 + 1);
1356 >    return 1;
1357 >  }
1358 >
1359    return 0;
1360   }
1361  
# Line 2130 | Line 1369 | valid_wild_card(struct Client *source_p,
1369   *              - parse_flags bit map of things to test
1370   *              - pointer to user or string to parse into
1371   *              - pointer to host or NULL to parse into if non NULL
1372 < *              - pointer to optional tkline time or NULL
1372 > *              - pointer to optional tkline time or NULL
1373   *              - pointer to target_server to parse into if non NULL
1374   *              - pointer to reason to parse into
1375   *
1376 < * output       - 1 if valid, -1 if not valid
1376 > * output       - 1 if valid, 0 if not valid
1377   * side effects - A generalised k/d/x etc. line parser,
1378   *               "ALINE [time] user@host|string [ON] target :reason"
1379   *                will parse returning a parsed user, host if
# Line 2152 | Line 1391 | valid_wild_card(struct Client *source_p,
1391   */
1392   int
1393   parse_aline(const char *cmd, struct Client *source_p,
1394 <            int parc, char **parv,
1395 <            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1396 <            char **target_server, char **reason)
1394 >            int parc, char **parv,
1395 >            char **up_p, char **h_p, uintmax_t *tkline_time,
1396 >            char **target_server, char **reason)
1397   {
1398 <  int found_tkline_time=0;
1399 <  static char def_reason[] = "No Reason";
1398 >  uintmax_t found_tkline_time=0;
1399 >  static char default_reason[] = CONF_NOREASON;
1400    static char user[USERLEN*4+1];
1401    static char host[HOSTLEN*4+1];
1402  
# Line 2166 | Line 1405 | parse_aline(const char *cmd, struct Clie
1405  
1406    found_tkline_time = valid_tkline(*parv, TK_MINUTES);
1407  
1408 <  if (found_tkline_time != 0)
1408 >  if (found_tkline_time)
1409    {
1410      parv++;
1411      parc--;
1412  
1413 <    if (tkline_time != NULL)
1413 >    if (tkline_time)
1414        *tkline_time = found_tkline_time;
1415      else
1416      {
1417 <      sendto_one(source_p, ":%s NOTICE %s :temp_line not supported by %s",
1418 <                 me.name, source_p->name, cmd);
2180 <      return -1;
1417 >      sendto_one_notice(source_p, &me, ":temp_line not supported by %s", cmd);
1418 >      return 0;
1419      }
1420    }
1421  
1422    if (parc == 0)
1423    {
1424 <    sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
1425 <               me.name, source_p->name, cmd);
2188 <    return -1;
1424 >    sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1425 >    return 0;
1426    }
1427  
1428    if (h_p == NULL)
1429      *up_p = *parv;
1430    else
1431    {
1432 <    if (find_user_host(source_p, *parv, user, host, parse_flags) == 0)
1433 <      return -1;
1432 >    if (find_user_host(source_p, *parv, user, host) == 0)
1433 >      return 0;
1434  
1435      *up_p = user;
1436      *h_p = host;
1437    }
1438 <
1438 >
1439    parc--;
1440    parv++;
1441  
1442 <  if (parc != 0)
1442 >  if (parc)
1443    {
1444      if (irccmp(*parv, "ON") == 0)
1445      {
1446        parc--;
1447        parv++;
1448  
2212      if (target_server == NULL)
2213      {
2214        sendto_one(source_p, ":%s NOTICE %s :ON server not supported by %s",
2215                   me.name, source_p->name, cmd);
2216        return -1;
2217      }
2218
1449        if (!HasOFlag(source_p, OPER_FLAG_REMOTEBAN))
1450        {
1451 <        sendto_one(source_p, form_str(ERR_NOPRIVS),
1452 <                   me.name, source_p->name, "remoteban");
2223 <        return -1;
1451 >        sendto_one_numeric(source_p, &me, ERR_NOPRIVS, "remoteban");
1452 >        return 0;
1453        }
1454  
1455        if (parc == 0 || EmptyString(*parv))
1456        {
1457 <        sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
1458 <                   me.name, source_p->name, cmd);
2230 <        return -1;
1457 >        sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1458 >        return 0;
1459        }
1460  
1461        *target_server = *parv;
# Line 2239 | Line 1467 | parse_aline(const char *cmd, struct Clie
1467        /* Make sure target_server *is* NULL if no ON server found
1468         * caller probably NULL'd it first, but no harm to do it again -db
1469         */
1470 <      if (target_server != NULL)
1471 <        *target_server = NULL;
2244 <    }
2245 <  }
2246 <
2247 <  if (h_p != NULL)
2248 <  {
2249 <    if (strchr(user, '!') != NULL)
2250 <    {
2251 <      sendto_one(source_p, ":%s NOTICE %s :Invalid character '!' in kline",
2252 <                 me.name, source_p->name);
2253 <      return -1;
1470 >      if (target_server)
1471 >        *target_server = NULL;
1472      }
2255
2256    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 2, *up_p, *h_p))
2257      return -1;
1473    }
2259  else
2260    if ((parse_flags & AWILD) && !valid_wild_card(source_p, 1, 1, *up_p))
2261      return -1;
1474  
1475 <  if (reason != NULL)
1475 >  if (reason)
1476    {
1477 <    if (parc != 0 && !EmptyString(*parv))
2266 <    {
1477 >    if (parc && !EmptyString(*parv))
1478        *reason = *parv;
2268      if (!valid_comment(source_p, *reason, 1))
2269        return -1;
2270    }
2271    else
2272      *reason = def_reason;
2273  }
2274
2275  return 1;
2276 }
2277
2278 /* find_user_host()
2279 *
2280 * inputs       - pointer to client placing kline
2281 *              - pointer to user_host_or_nick
2282 *              - pointer to user buffer
2283 *              - pointer to host buffer
2284 * output       - 0 if not ok to kline, 1 to kline i.e. if valid user host
2285 * side effects -
2286 */
2287 static int
2288 find_user_host(struct Client *source_p, char *user_host_or_nick,
2289               char *luser, char *lhost, unsigned int flags)
2290 {
2291  struct Client *target_p = NULL;
2292  char *hostp = NULL;
2293
2294  if (lhost == NULL)
2295  {
2296    strlcpy(luser, user_host_or_nick, USERLEN*4 + 1);
2297    return 1;
2298  }
2299
2300  if ((hostp = strchr(user_host_or_nick, '@')) || *user_host_or_nick == '*')
2301  {
2302    /* Explicit user@host mask given */
2303
2304    if (hostp != NULL)                            /* I'm a little user@host */
2305    {
2306      *(hostp++) = '\0';                       /* short and squat */
2307      if (*user_host_or_nick)
2308        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
2309      else
2310        strcpy(luser, "*");
2311      if (*hostp)
2312        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2313      else
2314        strcpy(lhost, "*");
2315    }
2316    else
2317    {
2318      luser[0] = '*';             /* no @ found, assume its *@somehost */
2319      luser[1] = '\0';    
2320      strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
2321    }
2322    
2323    return 1;
2324  }
2325  else
2326  {
2327    /* Try to find user@host mask from nick */
2328    /* Okay to use source_p as the first param, because source_p == client_p */
2329    if ((target_p =
2330        find_chasing(source_p, source_p, user_host_or_nick, NULL)) == NULL)
2331      return 0;
2332
2333    if (IsExemptKline(target_p))
2334    {
2335      if (!IsServer(source_p))
2336        sendto_one(source_p,
2337                   ":%s NOTICE %s :%s is E-lined",
2338                   me.name, source_p->name, target_p->name);
2339      return 0;
2340    }
2341
2342    /*
2343     * turn the "user" bit into "*user", blow away '~'
2344     * if found in original user name (non-idented)
2345     */
2346    strlcpy(luser, target_p->username, USERLEN*4 + 1);
2347
2348    if (target_p->username[0] == '~')
2349      luser[0] = '*';
2350
2351    if (target_p->sockhost[0] == '\0' ||
2352        (target_p->sockhost[0] == '0' && target_p->sockhost[1] == '\0'))
2353      strlcpy(lhost, target_p->host, HOSTLEN*4 + 1);
1479      else
1480 <      strlcpy(lhost, target_p->sockhost, HOSTLEN*4 + 1);
2356 <    return 1;
1480 >      *reason = default_reason;
1481    }
1482  
2359  return 0;
2360 }
2361
2362 /* valid_comment()
2363 *
2364 * inputs       - pointer to client
2365 *              - pointer to comment
2366 * output       - 0 if no valid comment,
2367 *              - 1 if valid
2368 * side effects - truncates reason where necessary
2369 */
2370 int
2371 valid_comment(struct Client *source_p, char *comment, int warn)
2372 {
2373  if (strlen(comment) > REASONLEN)
2374    comment[REASONLEN-1] = '\0';
2375
1483    return 1;
1484   }
1485  
# Line 2396 | Line 1503 | match_conf_password(const char *password
1503    else
1504      encr = password;
1505  
1506 <  return !strcmp(encr, conf->passwd);
2400 < }
2401 <
2402 < /*
2403 < * cluster_a_line
2404 < *
2405 < * inputs       - client sending the cluster
2406 < *              - command name "KLINE" "XLINE" etc.
2407 < *              - capab -- CAP_KLN etc. from s_serv.h
2408 < *              - cluster type -- CLUSTER_KLINE etc. from conf.h
2409 < *              - pattern and args to send along
2410 < * output       - none
2411 < * side effects - Take source_p send the pattern with args given
2412 < *                along to all servers that match capab and cluster type
2413 < */
2414 < void
2415 < cluster_a_line(struct Client *source_p, const char *command,
2416 <               int capab, int cluster_type, const char *pattern, ...)
2417 < {
2418 <  va_list args;
2419 <  char buffer[IRCD_BUFSIZE];
2420 <  const dlink_node *ptr = NULL;
2421 <
2422 <  va_start(args, pattern);
2423 <  vsnprintf(buffer, sizeof(buffer), pattern, args);
2424 <  va_end(args);
2425 <
2426 <  DLINK_FOREACH(ptr, cluster_items.head)
2427 <  {
2428 <    const struct MaskItem *conf = ptr->data;
2429 <
2430 <    if (conf->flags & cluster_type)
2431 <      sendto_match_servs(source_p, conf->name, CAP_CLUSTER|capab,
2432 <                         "%s %s %s", command, conf->name, buffer);
2433 <  }
1506 >  return encr && !strcmp(encr, conf->passwd);
1507   }
1508  
1509   /*
# Line 2468 | Line 1541 | split_nuh(struct split_nuh_item *const i
1541  
1542    if (iptr->nickptr)
1543      strlcpy(iptr->nickptr, "*", iptr->nicksize);
1544 +
1545    if (iptr->userptr)
1546      strlcpy(iptr->userptr, "*", iptr->usersize);
1547 +
1548    if (iptr->hostptr)
1549      strlcpy(iptr->hostptr, "*", iptr->hostsize);
1550  
# Line 2477 | Line 1552 | split_nuh(struct split_nuh_item *const i
1552    {
1553      *p = '\0';
1554  
1555 <    if (iptr->nickptr && *iptr->nuhmask != '\0')
1555 >    if (iptr->nickptr && *iptr->nuhmask)
1556        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
1557  
1558 <    if ((q = strchr(++p, '@'))) {
1558 >    if ((q = strchr(++p, '@')))
1559 >    {
1560        *q++ = '\0';
1561  
1562 <      if (*p != '\0')
1562 >      if (*p)
1563          strlcpy(iptr->userptr, p, iptr->usersize);
1564  
1565 <      if (*q != '\0')
1565 >      if (*q)
1566          strlcpy(iptr->hostptr, q, iptr->hostsize);
1567      }
1568      else
1569      {
1570 <      if (*p != '\0')
1570 >      if (*p)
1571          strlcpy(iptr->userptr, p, iptr->usersize);
1572      }
1573    }
# Line 2503 | Line 1579 | split_nuh(struct split_nuh_item *const i
1579        /* if found a @ */
1580        *p++ = '\0';
1581  
1582 <      if (*iptr->nuhmask != '\0')
1582 >      if (*iptr->nuhmask)
1583          strlcpy(iptr->userptr, iptr->nuhmask, iptr->usersize);
1584  
1585 <      if (*p != '\0')
1585 >      if (*p)
1586          strlcpy(iptr->hostptr, p, iptr->hostsize);
1587      }
1588      else
1589      {
1590 <      /* no @ found */
1590 >      /* No @ found */
1591        if (!iptr->nickptr || strpbrk(iptr->nuhmask, ".:"))
1592          strlcpy(iptr->hostptr, iptr->nuhmask, iptr->hostsize);
1593        else

Comparing ircd-hybrid/trunk/src/conf.c (property svn:keywords):
Revision 1645 by michael, Wed Nov 7 12:25:02 2012 UTC vs.
Revision 8593 by michael, Sun Oct 21 18:11:04 2018 UTC

# Line 1 | Line 1
1 < Id Revision
1 > Id

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)