ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing ircd-hybrid/trunk/src/conf.c (file contents):
Revision 3110 by michael, Thu Mar 6 20:33:17 2014 UTC vs.
Revision 4744 by michael, Thu Oct 16 11:46:19 2014 UTC

# Line 15 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20   */
21  
# Line 28 | Line 28
28   #include "list.h"
29   #include "ircd_defs.h"
30   #include "conf.h"
31 < #include "s_serv.h"
31 > #include "conf_pseudo.h"
32 > #include "server.h"
33   #include "resv.h"
34   #include "channel.h"
35   #include "client.h"
36   #include "event.h"
36 #include "hook.h"
37   #include "irc_string.h"
38   #include "s_bsd.h"
39   #include "ircd.h"
# Line 44 | Line 44
44   #include "fdlist.h"
45   #include "log.h"
46   #include "send.h"
47 #include "s_gline.h"
47   #include "memory.h"
48 < #include "mempool.h"
50 < #include "irc_res.h"
48 > #include "res.h"
49   #include "userhost.h"
50 < #include "s_user.h"
50 > #include "user.h"
51   #include "channel_mode.h"
52   #include "parse.h"
53 < #include "s_misc.h"
53 > #include "misc.h"
54   #include "conf_db.h"
55   #include "conf_class.h"
56   #include "motd.h"
57 + #include "ipcache.h"
58  
59  
61 struct config_channel_entry ConfigChannel;
62 struct config_server_hide ConfigServerHide;
63 struct config_file_entry ConfigFileEntry;
64 struct logging_entry ConfigLoggingEntry = { .use_logging = 1 };
65 struct server_info ServerInfo;
66 struct admin_info AdminInfo;
67
60   /* general conf items link list root, other than k lines etc. */
61   dlink_list service_items = { NULL, NULL, 0 };
62   dlink_list server_items  = { NULL, NULL, 0 };
# Line 73 | Line 65 | dlink_list oconf_items   = { NULL, NULL,
65   dlink_list uconf_items   = { NULL, NULL, 0 };
66   dlink_list xconf_items   = { NULL, NULL, 0 };
67   dlink_list nresv_items   = { NULL, NULL, 0 };
68 < dlink_list cresv_items = { NULL, NULL, 0 };
68 > dlink_list cresv_items   = { NULL, NULL, 0 };
69  
70   extern unsigned int lineno;
71   extern char linebuf[];
72   extern char conffilebuf[IRCD_BUFSIZE];
73   extern int yyparse(); /* defined in y.tab.c */
74  
83 struct conf_parser_context conf_parser_ctx = { 0, 0, NULL };
84
75   /* internally defined functions */
76   static void read_conf(FILE *);
77   static void clear_out_old_conf(void);
78   static void expire_tklines(dlink_list *);
89 static void garbage_collect_ip_entries(void);
90 static int hash_ip(struct irc_ssaddr *);
79   static int verify_access(struct Client *);
80   static int attach_iline(struct Client *, struct MaskItem *);
93 static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
81   static dlink_list *map_to_list(enum maskitem_type);
82   static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
83  
84  
98 /* usually, with hash tables, you use a prime number...
99 * but in this case I am dealing with ip addresses,
100 * not ascii strings.
101 */
102 #define IP_HASH_SIZE 0x1000
103
104 struct ip_entry
105 {
106  struct irc_ssaddr ip;
107  unsigned int count;
108  time_t last_attempt;
109  struct ip_entry *next;
110 };
111
112 static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
113 static mp_pool_t *ip_entry_pool = NULL;
114 static int ip_entries_count = 0;
115
116
85   /* conf_dns_callback()
86   *
87   * inputs       - pointer to struct MaskItem
# Line 125 | Line 93 | static int ip_entries_count = 0;
93   * if successful save hp in the conf item it was called with
94   */
95   static void
96 < conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
96 > conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name, size_t namelength)
97   {
98    struct MaskItem *conf = vptr;
99  
100    conf->dns_pending = 0;
101  
102 <  if (addr != NULL)
102 >  if (addr)
103      memcpy(&conf->addr, addr, sizeof(conf->addr));
104    else
105      conf->dns_failed = 1;
# Line 149 | Line 117 | conf_dns_lookup(struct MaskItem *conf)
117    if (!conf->dns_pending)
118    {
119      conf->dns_pending = 1;
120 <    gethost_byname(conf_dns_callback, conf, conf->host);
120 >
121 >    if (conf->aftype == AF_INET)
122 >      gethost_byname_type(conf_dns_callback, conf, conf->host, T_A);
123 >    else
124 >      gethost_byname_type(conf_dns_callback, conf, conf->host, T_AAAA);
125    }
126   }
127  
128   struct MaskItem *
129   conf_make(enum maskitem_type type)
130   {
131 <  struct MaskItem *conf = MyMalloc(sizeof(*conf));
131 >  struct MaskItem *conf = MyCalloc(sizeof(*conf));
132    dlink_list *list = NULL;
133  
134    conf->type   = type;
# Line 174 | Line 146 | conf_free(struct MaskItem *conf)
146    dlink_node *ptr = NULL, *ptr_next = NULL;
147    dlink_list *list = NULL;
148  
149 <  if (conf->node.next)
150 <    if ((list = map_to_list(conf->type)))
179 <      dlinkDelete(&conf->node, list);
149 >  if ((list = map_to_list(conf->type)))
150 >    dlinkFindDelete(list, conf);
151  
152    MyFree(conf->name);
153  
154    if (conf->dns_pending)
155      delete_resolver_queries(conf);
156 <  if (conf->passwd != NULL)
156 >  if (conf->passwd)
157      memset(conf->passwd, 0, strlen(conf->passwd));
158 <  if (conf->spasswd != NULL)
158 >  if (conf->spasswd)
159      memset(conf->spasswd, 0, strlen(conf->spasswd));
160  
161    conf->class = NULL;
# Line 261 | Line 232 | check_client(struct Client *source_p)
232        ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
233             get_client_name(source_p, SHOW_IP));
234        ++ServerStats.is_ref;
235 <      exit_client(source_p, &me, "No more connections allowed on that IP");
235 >      exit_client(source_p, "No more connections allowed on that IP");
236        break;
237  
238      case I_LINE_FULL:
# Line 272 | Line 243 | check_client(struct Client *source_p)
243        ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
244             get_client_name(source_p, SHOW_IP));
245        ++ServerStats.is_ref;
246 <      exit_client(source_p, &me,
276 <                  "No more connections allowed in your connection class");
246 >      exit_client(source_p, "No more connections allowed in your connection class");
247        break;
248  
249      case NOT_AUTHORIZED:
# Line 284 | Line 254 | check_client(struct Client *source_p)
254                             "Unauthorized client connection from %s [%s] on [%s/%u].",
255                             get_client_name(source_p, SHOW_IP),
256                             source_p->sockhost,
257 <                           source_p->localClient->listener->name,
258 <                           source_p->localClient->listener->port);
257 >                           source_p->connection->listener->name,
258 >                           source_p->connection->listener->port);
259        ilog(LOG_TYPE_IRCD,
260             "Unauthorized client connection from %s on [%s/%u].",
261             get_client_name(source_p, SHOW_IP),
262 <           source_p->localClient->listener->name,
263 <           source_p->localClient->listener->port);
262 >           source_p->connection->listener->name,
263 >           source_p->connection->listener->port);
264  
265 <      exit_client(source_p, &me, "You are not authorized to use this server");
265 >      exit_client(source_p, "You are not authorized to use this server");
266        break;
267  
268     case BANNED_CLIENT:
269 <     exit_client(source_p, &me, "Banned");
269 >     exit_client(source_p, "Banned");
270       ++ServerStats.is_ref;
271       break;
272  
# Line 318 | Line 288 | static int
288   verify_access(struct Client *client_p)
289   {
290    struct MaskItem *conf = NULL;
291 <  char non_ident[USERLEN + 1] = { '~', '\0' };
291 >  char non_ident[USERLEN + 1] = "~";
292  
293    if (IsGotId(client_p))
294    {
295      conf = find_address_conf(client_p->host, client_p->username,
296 <                             &client_p->localClient->ip,
297 <                             client_p->localClient->aftype,
298 <                             client_p->localClient->passwd);
296 >                             &client_p->connection->ip,
297 >                             client_p->connection->aftype,
298 >                             client_p->connection->password);
299    }
300    else
301    {
302      strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
303      conf = find_address_conf(client_p->host,non_ident,
304 <                             &client_p->localClient->ip,
305 <                             client_p->localClient->aftype,
306 <                             client_p->localClient->passwd);
304 >                             &client_p->connection->ip,
305 >                             client_p->connection->aftype,
306 >                             client_p->connection->password);
307    }
308  
309 <  if (conf != NULL)
309 >  if (conf)
310    {
311      if (IsConfClient(conf))
312      {
# Line 354 | Line 324 | verify_access(struct Client *client_p)
324        /* Thanks for spoof idea amm */
325        if (IsConfDoSpoofIp(conf))
326        {
327 <        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
327 >        if (!ConfigGeneral.hide_spoof_ips && IsConfSpoofNotice(conf))
328            sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
329                                 "%s spoofing: %s as %s",
330                                 client_p->name, client_p->host, conf->name);
# Line 364 | Line 334 | verify_access(struct Client *client_p)
334  
335        return attach_iline(client_p, conf);
336      }
337 <    else if (IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
337 >    else if (IsConfKill(conf) || (ConfigGeneral.glines && IsConfGline(conf)))
338      {
339        if (IsConfGline(conf))
340          sendto_one_notice(client_p, &me, ":*** G-lined");
# Line 386 | Line 356 | verify_access(struct Client *client_p)
356   static int
357   attach_iline(struct Client *client_p, struct MaskItem *conf)
358   {
359 <  struct ClassItem *class = NULL;
359 >  const struct ClassItem *class = conf->class;
360    struct ip_entry *ip_found;
361    int a_limit_reached = 0;
362    unsigned int local = 0, global = 0, ident = 0;
363  
364 <  assert(conf->class);
395 <
396 <  ip_found = find_or_add_ip(&client_p->localClient->ip);
364 >  ip_found = ipcache_find_or_add_address(&client_p->connection->ip);
365    ip_found->count++;
366 <  SetIpHash(client_p);
399 <
400 <  class = conf->class;
366 >  AddFlag(client_p, FLAGS_IPHASH);
367  
368    count_user_host(client_p->username, client_p->host,
369                    &global, &local, &ident);
# Line 406 | Line 372 | attach_iline(struct Client *client_p, st
372     * setting a_limit_reached if any limit is reached.
373     * - Dianora
374     */
375 <  if (class->max_total != 0 && class->ref_count >= class->max_total)
375 >  if (class->max_total && class->ref_count >= class->max_total)
376      a_limit_reached = 1;
377 <  else if (class->max_perip != 0 && ip_found->count > class->max_perip)
377 >  else if (class->max_perip && ip_found->count > class->max_perip)
378      a_limit_reached = 1;
379 <  else if (class->max_local != 0 && local >= class->max_local)
379 >  else if (class->max_local && local >= class->max_local)
380      a_limit_reached = 1;
381 <  else if (class->max_global != 0 && global >= class->max_global)
381 >  else if (class->max_global && global >= class->max_global)
382      a_limit_reached = 1;
383 <  else if (class->max_ident != 0 && ident >= class->max_ident &&
383 >  else if (class->max_ident && ident >= class->max_ident &&
384             client_p->username[0] != '~')
385      a_limit_reached = 1;
386  
# Line 430 | Line 396 | attach_iline(struct Client *client_p, st
396    return attach_conf(client_p, conf);
397   }
398  
433 /* init_ip_hash_table()
434 *
435 * inputs               - NONE
436 * output               - NONE
437 * side effects         - allocate memory for ip_entry(s)
438 *                      - clear the ip hash table
439 */
440 void
441 init_ip_hash_table(void)
442 {
443  ip_entry_pool = mp_pool_new(sizeof(struct ip_entry), MP_CHUNK_SIZE_IP_ENTRY);
444  memset(ip_hash_table, 0, sizeof(ip_hash_table));
445 }
446
447 /* find_or_add_ip()
448 *
449 * inputs       - pointer to struct irc_ssaddr
450 * output       - pointer to a struct ip_entry
451 * side effects -
452 *
453 * If the ip # was not found, a new struct ip_entry is created, and the ip
454 * count set to 0.
455 */
456 static struct ip_entry *
457 find_or_add_ip(struct irc_ssaddr *ip_in)
458 {
459  struct ip_entry *ptr, *newptr;
460  int hash_index = hash_ip(ip_in), res;
461  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
462 #ifdef IPV6
463  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
464 #endif
465
466  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
467  {
468 #ifdef IPV6
469    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
470      continue;
471    if (ip_in->ss.ss_family == AF_INET6)
472    {
473      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
474      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
475    }
476    else
477 #endif
478    {
479      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
480      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
481    }
482    if (res == 0)
483    {
484      /* Found entry already in hash, return it. */
485      return ptr;
486    }
487  }
488
489  if (ip_entries_count >= 2 * hard_fdlimit)
490    garbage_collect_ip_entries();
491
492  newptr = mp_pool_get(ip_entry_pool);
493  memset(newptr, 0, sizeof(*newptr));
494  ip_entries_count++;
495  memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
496
497  newptr->next = ip_hash_table[hash_index];
498  ip_hash_table[hash_index] = newptr;
499
500  return newptr;
501 }
502
503 /* remove_one_ip()
504 *
505 * inputs        - unsigned long IP address value
506 * output        - NONE
507 * side effects  - The ip address given, is looked up in ip hash table
508 *                 and number of ip#'s for that ip decremented.
509 *                 If ip # count reaches 0 and has expired,
510 *                 the struct ip_entry is returned to the ip_entry_heap
511 */
512 void
513 remove_one_ip(struct irc_ssaddr *ip_in)
514 {
515  struct ip_entry *ptr;
516  struct ip_entry *last_ptr = NULL;
517  int hash_index = hash_ip(ip_in), res;
518  struct sockaddr_in *v4 = (struct sockaddr_in *)ip_in, *ptr_v4;
519 #ifdef IPV6
520  struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)ip_in, *ptr_v6;
521 #endif
522
523  for (ptr = ip_hash_table[hash_index]; ptr; ptr = ptr->next)
524  {
525 #ifdef IPV6
526    if (ptr->ip.ss.ss_family != ip_in->ss.ss_family)
527      continue;
528    if (ip_in->ss.ss_family == AF_INET6)
529    {
530      ptr_v6 = (struct sockaddr_in6 *)&ptr->ip;
531      res = memcmp(&v6->sin6_addr, &ptr_v6->sin6_addr, sizeof(struct in6_addr));
532    }
533    else
534 #endif
535    {
536      ptr_v4 = (struct sockaddr_in *)&ptr->ip;
537      res = memcmp(&v4->sin_addr, &ptr_v4->sin_addr, sizeof(struct in_addr));
538    }
539    if (res)
540      continue;
541    if (ptr->count > 0)
542      ptr->count--;
543    if (ptr->count == 0 &&
544        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
545    {
546      if (last_ptr != NULL)
547        last_ptr->next = ptr->next;
548      else
549        ip_hash_table[hash_index] = ptr->next;
550
551      mp_pool_release(ptr);
552      ip_entries_count--;
553      return;
554    }
555    last_ptr = ptr;
556  }
557 }
558
559 /* hash_ip()
560 *
561 * input        - pointer to an irc_inaddr
562 * output       - integer value used as index into hash table
563 * side effects - hopefully, none
564 */
565 static int
566 hash_ip(struct irc_ssaddr *addr)
567 {
568  if (addr->ss.ss_family == AF_INET)
569  {
570    struct sockaddr_in *v4 = (struct sockaddr_in *)addr;
571    int hash;
572    uint32_t ip;
573
574    ip   = ntohl(v4->sin_addr.s_addr);
575    hash = ((ip >> 12) + ip) & (IP_HASH_SIZE-1);
576    return hash;
577  }
578 #ifdef IPV6
579  else
580  {
581    int hash;
582    struct sockaddr_in6 *v6 = (struct sockaddr_in6 *)addr;
583    uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
584
585    hash  = ip[0] ^ ip[3];
586    hash ^= hash >> 16;
587    hash ^= hash >> 8;
588    hash  = hash & (IP_HASH_SIZE - 1);
589    return hash;
590  }
591 #else
592  return 0;
593 #endif
594 }
595
596 /* count_ip_hash()
597 *
598 * inputs        - pointer to counter of number of ips hashed
599 *               - pointer to memory used for ip hash
600 * output        - returned via pointers input
601 * side effects  - NONE
602 *
603 * number of hashed ip #'s is counted up, plus the amount of memory
604 * used in the hash.
605 */
606 void
607 count_ip_hash(unsigned int *number_ips_stored, uint64_t *mem_ips_stored)
608 {
609  struct ip_entry *ptr;
610  int i;
611
612  *number_ips_stored = 0;
613  *mem_ips_stored    = 0;
614
615  for (i = 0; i < IP_HASH_SIZE; i++)
616  {
617    for (ptr = ip_hash_table[i]; ptr; ptr = ptr->next)
618    {
619      *number_ips_stored += 1;
620      *mem_ips_stored += sizeof(struct ip_entry);
621    }
622  }
623 }
624
625 /* garbage_collect_ip_entries()
626 *
627 * input        - NONE
628 * output       - NONE
629 * side effects - free up all ip entries with no connections
630 */
631 static void
632 garbage_collect_ip_entries(void)
633 {
634  struct ip_entry *ptr;
635  struct ip_entry *last_ptr;
636  struct ip_entry *next_ptr;
637  int i;
638
639  for (i = 0; i < IP_HASH_SIZE; i++)
640  {
641    last_ptr = NULL;
642
643    for (ptr = ip_hash_table[i]; ptr; ptr = next_ptr)
644    {
645      next_ptr = ptr->next;
646
647      if (ptr->count == 0 &&
648          (CurrentTime - ptr->last_attempt) >= ConfigFileEntry.throttle_time)
649      {
650        if (last_ptr != NULL)
651          last_ptr->next = ptr->next;
652        else
653          ip_hash_table[i] = ptr->next;
654        mp_pool_release(ptr);
655        ip_entries_count--;
656      }
657      else
658        last_ptr = ptr;
659    }
660  }
661 }
662
399   /* detach_conf()
400   *
401   * inputs       - pointer to client to detach
# Line 671 | Line 407 | garbage_collect_ip_entries(void)
407   void
408   detach_conf(struct Client *client_p, enum maskitem_type type)
409   {
410 <  dlink_node *ptr = NULL, *next_ptr = NULL;
410 >  dlink_node *ptr = NULL, *ptr_next = NULL;
411  
412 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->localClient->confs.head)
412 >  DLINK_FOREACH_SAFE(ptr, ptr_next, client_p->connection->confs.head)
413    {
414      struct MaskItem *conf = ptr->data;
415  
# Line 684 | Line 420 | detach_conf(struct Client *client_p, enu
420      if (!(conf->type & type))
421        continue;
422  
423 <    dlinkDelete(ptr, &client_p->localClient->confs);
423 >    dlinkDelete(ptr, &client_p->connection->confs);
424      free_dlink_node(ptr);
425  
426      if (conf->type == CONF_CLIENT)
427 <      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
427 >      remove_from_cidr_check(&client_p->connection->ip, conf->class);
428  
429      if (--conf->class->ref_count == 0 && conf->class->active == 0)
430      {
# Line 714 | Line 450 | detach_conf(struct Client *client_p, enu
450   int
451   attach_conf(struct Client *client_p, struct MaskItem *conf)
452   {
453 <  if (dlinkFind(&client_p->localClient->confs, conf) != NULL)
453 >  if (dlinkFind(&client_p->connection->confs, conf))
454      return 1;
455  
456    if (conf->type == CONF_CLIENT)
457      if (cidr_limit_reached(IsConfExemptLimits(conf),
458 <                           &client_p->localClient->ip, conf->class))
458 >                           &client_p->connection->ip, conf->class))
459        return TOO_MANY;    /* Already at maximum allowed */
460  
461    conf->class->ref_count++;
462    conf->ref_count++;
463  
464 <  dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
464 >  dlinkAdd(conf, make_dlink_node(), &client_p->connection->confs);
465  
466    return 0;
467   }
# Line 786 | Line 522 | find_conf_name(dlink_list *list, const c
522  
523      if (conf->type == type)
524      {
525 <      if (conf->name && (irccmp(conf->name, name) == 0 ||
526 <                         !match(conf->name, name)))
791 <      return conf;
525 >      if (conf->name && !irccmp(conf->name, name))
526 >        return conf;
527      }
528    }
529  
# Line 975 | Line 710 | find_exact_name_conf(enum maskitem_type
710                    return conf;
711                break;
712              case HM_IPV4:
713 <              if (who->localClient->aftype == AF_INET)
714 <                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
713 >              if (who->connection->aftype == AF_INET)
714 >                if (match_ipv4(&who->connection->ip, &conf->addr, conf->bits))
715                    if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
716                      return conf;
717                break;
983 #ifdef IPV6
718              case HM_IPV6:
719 <              if (who->localClient->aftype == AF_INET6)
720 <                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
719 >              if (who->connection->aftype == AF_INET6)
720 >                if (match_ipv6(&who->connection->ip, &conf->addr, conf->bits))
721                    if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
722                      return conf;
723                break;
990 #endif
724              default:
725                assert(0);
726            }
# Line 1034 | Line 767 | find_exact_name_conf(enum maskitem_type
767   int
768   rehash(int sig)
769   {
770 <  if (sig != 0)
770 >  if (sig)
771      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
772                           "Got signal SIGHUP, reloading configuration file(s)");
773  
# Line 1042 | Line 775 | rehash(int sig)
775  
776    /* don't close listeners until we know we can go ahead with the rehash */
777  
1045  /* Check to see if we magically got(or lost) IPv6 support */
1046  check_can_use_v6();
1047
778    read_conf_files(0);
779  
1050  if (ServerInfo.description != NULL)
1051    strlcpy(me.info, ServerInfo.description, sizeof(me.info));
1052
780    load_conf_modules();
781 <
1055 <  rehashed_klines = 1;
781 >  check_conf_klines();
782  
783    return 0;
784   }
# Line 1075 | Line 801 | set_default_conf(void)
801    assert(class_default == class_get_list()->tail->data);
802  
803   #ifdef HAVE_LIBCRYPTO
804 <  ServerInfo.rsa_private_key = NULL;
805 <  ServerInfo.rsa_private_key_file = NULL;
804 > #if OPENSSL_VERSION_NUMBER >= 0x009080FFL && !defined(OPENSSL_NO_ECDH)
805 >  {
806 >    EC_KEY *key = EC_KEY_new_by_curve_name(NID_X9_62_prime256v1);
807 >
808 >    if (key)
809 >    {
810 >      SSL_CTX_set_tmp_ecdh(ConfigServerInfo.server_ctx, key);
811 >      EC_KEY_free(key);
812 >    }
813 >  }
814 >
815 >  SSL_CTX_set_options(ConfigServerInfo.server_ctx, SSL_OP_SINGLE_ECDH_USE);
816 > #endif
817 >
818 >  ConfigServerInfo.message_digest_algorithm = EVP_sha256();
819 >  ConfigServerInfo.rsa_private_key = NULL;
820 >  ConfigServerInfo.rsa_private_key_file = NULL;
821   #endif
822  
823 <  /* ServerInfo.name is not rehashable */
824 <  /* ServerInfo.name = ServerInfo.name; */
825 <  ServerInfo.description = NULL;
826 <  ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
827 <  ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
828 <
829 <  memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
830 <  ServerInfo.specific_ipv4_vhost = 0;
831 <  memset(&ServerInfo.ip6, 0, sizeof(ServerInfo.ip6));
832 <  ServerInfo.specific_ipv6_vhost = 0;
833 <
834 <  ServerInfo.max_clients = MAXCLIENTS_MAX;
835 <  ServerInfo.max_nick_length = 9;
836 <  ServerInfo.max_topic_length = 80;
837 <
838 <  ServerInfo.hub = 0;
839 <  ServerInfo.dns_host.sin_addr.s_addr = 0;
840 <  ServerInfo.dns_host.sin_port = 0;
841 <  AdminInfo.name = NULL;
1101 <  AdminInfo.email = NULL;
1102 <  AdminInfo.description = NULL;
823 >  /* ConfigServerInfo.name is not rehashable */
824 >  /* ConfigServerInfo.name = ConfigServerInfo.name; */
825 >  ConfigServerInfo.description = NULL;
826 >  ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
827 >  ConfigServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
828 >
829 >  memset(&ConfigServerInfo.ip, 0, sizeof(ConfigServerInfo.ip));
830 >  ConfigServerInfo.specific_ipv4_vhost = 0;
831 >  memset(&ConfigServerInfo.ip6, 0, sizeof(ConfigServerInfo.ip6));
832 >  ConfigServerInfo.specific_ipv6_vhost = 0;
833 >
834 >  ConfigServerInfo.max_clients = MAXCLIENTS_MAX;
835 >  ConfigServerInfo.max_nick_length = 9;
836 >  ConfigServerInfo.max_topic_length = 80;
837 >  ConfigServerInfo.hub = 0;
838 >
839 >  ConfigAdminInfo.name = NULL;
840 >  ConfigAdminInfo.email = NULL;
841 >  ConfigAdminInfo.description = NULL;
842  
843    log_del_all();
844  
845 <  ConfigLoggingEntry.use_logging = 1;
845 >  ConfigLog.use_logging = 1;
846  
847    ConfigChannel.disable_fake_channels = 0;
848 <  ConfigChannel.knock_delay = 300;
848 >  ConfigChannel.invite_client_count = 10;
849 >  ConfigChannel.invite_client_time = 300;
850 >  ConfigChannel.knock_client_count = 1;
851 >  ConfigChannel.knock_client_time = 300;
852    ConfigChannel.knock_delay_channel = 60;
853 <  ConfigChannel.max_chans_per_user = 25;
1112 <  ConfigChannel.max_chans_per_oper = 50;
853 >  ConfigChannel.max_channels = 25;
854    ConfigChannel.max_bans = 25;
855    ConfigChannel.default_split_user_count = 0;
856    ConfigChannel.default_split_server_count = 0;
# Line 1125 | Line 866 | set_default_conf(void)
866    ConfigServerHide.hide_server_ips = 0;
867    ConfigServerHide.disable_remote_commands = 0;
868  
869 <  ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
870 <  ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
871 <  ConfigFileEntry.cycle_on_host_change = 1;
872 <  ConfigFileEntry.glines = 0;
873 <  ConfigFileEntry.gline_time = 12 * 3600;
874 <  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
875 <  ConfigFileEntry.gline_min_cidr = 16;
876 <  ConfigFileEntry.gline_min_cidr6 = 48;
877 <  ConfigFileEntry.invisible_on_connect = 1;
878 <  ConfigFileEntry.tkline_expire_notices = 1;
879 <  ConfigFileEntry.hide_spoof_ips = 1;
880 <  ConfigFileEntry.ignore_bogus_ts = 0;
881 <  ConfigFileEntry.disable_auth = 0;
882 <  ConfigFileEntry.kill_chase_time_limit = 90;
883 <  ConfigFileEntry.default_floodcount = 8;
884 <  ConfigFileEntry.failed_oper_notice = 1;
885 <  ConfigFileEntry.dots_in_ident = 0;
886 <  ConfigFileEntry.min_nonwildcard = 4;
887 <  ConfigFileEntry.min_nonwildcard_simple = 3;
888 <  ConfigFileEntry.max_accept = 20;
889 <  ConfigFileEntry.anti_nick_flood = 0;
890 <  ConfigFileEntry.max_nick_time = 20;
891 <  ConfigFileEntry.max_nick_changes = 5;
892 <  ConfigFileEntry.anti_spam_exit_message_time = 0;
893 <  ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
894 <  ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
895 <  ConfigFileEntry.warn_no_nline = 1;
896 <  ConfigFileEntry.stats_o_oper_only = 0;
897 <  ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
898 <  ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
899 <  ConfigFileEntry.stats_P_oper_only = 0;
900 <  ConfigFileEntry.stats_u_oper_only = 0;
901 <  ConfigFileEntry.caller_id_wait = 60;
902 <  ConfigFileEntry.opers_bypass_callerid = 0;
903 <  ConfigFileEntry.pace_wait = 10;
904 <  ConfigFileEntry.pace_wait_simple = 1;
905 <  ConfigFileEntry.short_motd = 0;
906 <  ConfigFileEntry.ping_cookie = 0;
907 <  ConfigFileEntry.no_oper_flood = 0;
908 <  ConfigFileEntry.true_no_oper_flood = 0;
909 <  ConfigFileEntry.oper_pass_resv = 1;
910 <  ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
911 <  ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
912 <  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
913 <    UMODE_OPERWALL | UMODE_WALLOP;
914 <  ConfigFileEntry.use_egd = 0;
915 <  ConfigFileEntry.egdpool_path = NULL;
916 <  ConfigFileEntry.throttle_time = 10;
869 >  ConfigGeneral.away_count = 2;
870 >  ConfigGeneral.away_time = 10;
871 >  ConfigGeneral.max_watch = WATCHSIZE_DEFAULT;
872 >  ConfigGeneral.cycle_on_host_change = 1;
873 >  ConfigGeneral.glines = 0;
874 >  ConfigGeneral.gline_time = 12 * 3600;
875 >  ConfigGeneral.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
876 >  ConfigGeneral.gline_min_cidr = 16;
877 >  ConfigGeneral.gline_min_cidr6 = 48;
878 >  ConfigGeneral.invisible_on_connect = 1;
879 >  ConfigGeneral.tkline_expire_notices = 1;
880 >  ConfigGeneral.hide_spoof_ips = 1;
881 >  ConfigGeneral.ignore_bogus_ts = 0;
882 >  ConfigGeneral.disable_auth = 0;
883 >  ConfigGeneral.kill_chase_time_limit = 90;
884 >  ConfigGeneral.default_floodcount = 8;
885 >  ConfigGeneral.failed_oper_notice = 1;
886 >  ConfigGeneral.dots_in_ident = 0;
887 >  ConfigGeneral.min_nonwildcard = 4;
888 >  ConfigGeneral.min_nonwildcard_simple = 3;
889 >  ConfigGeneral.max_accept = 20;
890 >  ConfigGeneral.anti_nick_flood = 0;
891 >  ConfigGeneral.max_nick_time = 20;
892 >  ConfigGeneral.max_nick_changes = 5;
893 >  ConfigGeneral.anti_spam_exit_message_time = 0;
894 >  ConfigGeneral.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
895 >  ConfigGeneral.ts_max_delta = TS_MAX_DELTA_DEFAULT;
896 >  ConfigGeneral.warn_no_connect_block = 1;
897 >  ConfigGeneral.stats_e_disabled = 0;
898 >  ConfigGeneral.stats_o_oper_only = 0;
899 >  ConfigGeneral.stats_k_oper_only = 1;  /* 1 = masked */
900 >  ConfigGeneral.stats_i_oper_only = 1;  /* 1 = masked */
901 >  ConfigGeneral.stats_P_oper_only = 0;
902 >  ConfigGeneral.stats_u_oper_only = 0;
903 >  ConfigGeneral.caller_id_wait = 60;
904 >  ConfigGeneral.opers_bypass_callerid = 0;
905 >  ConfigGeneral.pace_wait = 10;
906 >  ConfigGeneral.pace_wait_simple = 1;
907 >  ConfigGeneral.short_motd = 0;
908 >  ConfigGeneral.ping_cookie = 0;
909 >  ConfigGeneral.no_oper_flood = 0;
910 >  ConfigGeneral.true_no_oper_flood = 0;
911 >  ConfigGeneral.oper_pass_resv = 1;
912 >  ConfigGeneral.max_targets = MAX_TARGETS_DEFAULT;
913 >  ConfigGeneral.oper_only_umodes = UMODE_DEBUG;
914 >  ConfigGeneral.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE | UMODE_WALLOP;
915 >  ConfigGeneral.throttle_count = 1;
916 >  ConfigGeneral.throttle_time = 1;
917   }
918  
919   static void
920   validate_conf(void)
921   {
922 <  if (ConfigFileEntry.ts_warn_delta < TS_WARN_DELTA_MIN)
923 <    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1183 <
1184 <  if (ConfigFileEntry.ts_max_delta < TS_MAX_DELTA_MIN)
1185 <    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
922 >  if (ConfigGeneral.ts_warn_delta < TS_WARN_DELTA_MIN)
923 >    ConfigGeneral.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
924  
925 <  if (ServerInfo.network_name == NULL)
926 <    ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
925 >  if (ConfigGeneral.ts_max_delta < TS_MAX_DELTA_MIN)
926 >    ConfigGeneral.ts_max_delta = TS_MAX_DELTA_DEFAULT;
927  
928 <  if (ServerInfo.network_desc == NULL)
929 <    ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
928 >  if (ConfigServerInfo.network_name == NULL)
929 >    ConfigServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
930  
931 <  if (ConfigFileEntry.service_name == NULL)
932 <    ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
931 >  if (ConfigServerInfo.network_desc == NULL)
932 >    ConfigServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
933  
934 <  ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
934 >  ConfigGeneral.max_watch = IRCD_MAX(ConfigGeneral.max_watch, WATCHSIZE_MIN);
935   }
936  
937   /* read_conf()
# Line 1207 | Line 945 | read_conf(FILE *file)
945   {
946    lineno = 0;
947  
948 <  set_default_conf(); /* Set default values prior to conf parsing */
948 >  set_default_conf();  /* Set default values prior to conf parsing */
949    conf_parser_ctx.pass = 1;
950 <  yyparse();          /* pick up the classes first */
950 >  yyparse();  /* Pick up the classes first */
951  
952    rewind(file);
953  
954    conf_parser_ctx.pass = 2;
955 <  yyparse();          /* Load the values from the conf */
956 <  validate_conf();    /* Check to make sure some values are still okay. */
957 <                      /* Some global values are also loaded here. */
958 <  class_delete_marked();      /* Make sure classes are valid */
955 >  yyparse();  /* Load the values from the conf */
956 >  validate_conf();  /* Check to make sure some values are still okay. */
957 >                    /* Some global values are also loaded here. */
958 >  class_delete_marked();  /* Delete unused classes that are marked for deletion */
959   }
960  
961   /* lookup_confhost()
# Line 1230 | Line 968 | lookup_confhost(struct MaskItem *conf)
968   {
969    struct addrinfo hints, *res;
970  
971 <  /* Do name lookup now on hostnames given and store the
971 >  /*
972 >   * Do name lookup now on hostnames given and store the
973     * ip numbers in conf structure.
974     */
975    memset(&hints, 0, sizeof(hints));
# Line 1247 | Line 986 | lookup_confhost(struct MaskItem *conf)
986      return;
987    }
988  
989 <  assert(res != NULL);
989 >  assert(res);
990  
991    memcpy(&conf->addr, res->ai_addr, res->ai_addrlen);
992    conf->addr.ss_len = res->ai_addrlen;
# Line 1266 | Line 1005 | lookup_confhost(struct MaskItem *conf)
1005   int
1006   conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
1007   {
1008 <  struct ip_entry *ip_found;
1008 >  struct ip_entry *ip_found = NULL;
1009    struct MaskItem *conf = find_dline_conf(addr, aftype);
1010  
1011    /* DLINE exempt also gets you out of static limits/pacing... */
1012    if (conf && (conf->type == CONF_EXEMPT))
1013      return 0;
1014  
1015 <  if (conf != NULL)
1015 >  if (conf)
1016      return BANNED_CLIENT;
1017  
1018 <  ip_found = find_or_add_ip(addr);
1018 >  ip_found = ipcache_find_or_add_address(addr);
1019  
1020 <  if ((CurrentTime - ip_found->last_attempt) <
1282 <      ConfigFileEntry.throttle_time)
1020 >  if ((CurrentTime - ip_found->last_attempt) < ConfigGeneral.throttle_time)
1021    {
1022 <    ip_found->last_attempt = CurrentTime;
1023 <    return TOO_FAST;
1022 >    if (ip_found->connection_count >= ConfigGeneral.throttle_count)
1023 >      return TOO_FAST;
1024 >
1025 >    ++ip_found->connection_count;
1026    }
1027 +  else
1028 +    ip_found->connection_count = 1;
1029  
1030    ip_found->last_attempt = CurrentTime;
1031    return 0;
# Line 1297 | Line 1039 | conf_connect_allowed(struct irc_ssaddr *
1039   *                This is an event started off in ircd.c
1040   */
1041   void
1042 < cleanup_tklines(void *notused)
1042 > cleanup_tklines(void *unused)
1043   {
1044    hostmask_expire_temporary();
1045    expire_tklines(&xconf_items);
# Line 1314 | Line 1056 | cleanup_tklines(void *notused)
1056   static void
1057   expire_tklines(dlink_list *tklist)
1058   {
1059 <  dlink_node *ptr;
1060 <  dlink_node *next_ptr;
1319 <  struct MaskItem *conf;
1059 >  dlink_node *ptr = NULL, *ptr_next = NULL;
1060 >  struct MaskItem *conf = NULL;
1061  
1062 <  DLINK_FOREACH_SAFE(ptr, next_ptr, tklist->head)
1062 >  DLINK_FOREACH_SAFE(ptr, ptr_next, tklist->head)
1063    {
1064      conf = ptr->data;
1065  
# Line 1327 | Line 1068 | expire_tklines(dlink_list *tklist)
1068  
1069      if (conf->type == CONF_XLINE)
1070      {
1071 <      if (ConfigFileEntry.tkline_expire_notices)
1071 >      if (ConfigGeneral.tkline_expire_notices)
1072          sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1073                                 "Temporary X-line for [%s] expired", conf->name);
1074        conf_free(conf);
1075      }
1076      else if (conf->type == CONF_NRESV || conf->type == CONF_CRESV)
1077      {
1078 <      if (ConfigFileEntry.tkline_expire_notices)
1078 >      if (ConfigGeneral.tkline_expire_notices)
1079          sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1080                                 "Temporary RESV for [%s] expired", conf->name);
1081        conf_free(conf);
# Line 1358 | Line 1099 | static const struct oper_privs
1099    { OPER_FLAG_DIE,            'D' },
1100    { OPER_FLAG_GLINE,          'G' },
1101    { OPER_FLAG_REHASH,         'H' },
1102 <  { OPER_FLAG_K,              'K' },
1362 <  { OPER_FLAG_OPERWALL,       'L' },
1102 >  { OPER_FLAG_KLINE,          'K' },
1103    { OPER_FLAG_KILL,           'N' },
1104    { OPER_FLAG_KILL_REMOTE,    'O' },
1105    { OPER_FLAG_CONNECT,        'P' },
# Line 1376 | Line 1116 | oper_privs_as_string(const unsigned int
1116   {
1117    static char privs_out[IRCD_BUFSIZE];
1118    char *privs_ptr = privs_out;
1379  const struct oper_privs *opriv = flag_list;
1119  
1120 <  for (; opriv->flag; ++opriv)
1120 >  for (const struct oper_privs *opriv = flag_list; opriv->flag; ++opriv)
1121    {
1122      if (port & opriv->flag)
1123        *privs_ptr++ = opriv->c;
# Line 1392 | Line 1131 | oper_privs_as_string(const unsigned int
1131   }
1132  
1133   /*
1134 < * Input: A client to find the active oper{} name for.
1134 > * Input: A client to find the active operator {} name for.
1135   * Output: The nick!user@host{oper} of the oper.
1136   *         "oper" is server name for remote opers
1137   * Side effects: None.
# Line 1404 | Line 1143 | get_oper_name(const struct Client *clien
1143    /* +5 for !,@,{,} and null */
1144    static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
1145  
1146 +  if (IsServer(client_p))
1147 +    return client_p->name;
1148 +
1149    if (MyConnect(client_p))
1150    {
1151 <    if ((cnode = client_p->localClient->confs.head))
1151 >    if ((cnode = client_p->connection->confs.head))
1152      {
1153        const struct MaskItem *conf = cnode->data;
1154  
# Line 1418 | Line 1160 | get_oper_name(const struct Client *clien
1160        }
1161      }
1162  
1163 <    /* Probably should assert here for now. If there is an oper out there
1164 <     * with no oper{} conf attached, it would be good for us to know...
1163 >    /*
1164 >     * Probably should assert here for now. If there is an oper out there
1165 >     * with no operator {} conf attached, it would be good for us to know...
1166       */
1167 <    assert(0); /* Oper without oper conf! */
1167 >    assert(0);  /* Oper without oper conf! */
1168    }
1169  
1170    snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
# Line 1438 | Line 1181 | get_oper_name(const struct Client *clien
1181   void
1182   read_conf_files(int cold)
1183   {
1184 <  const char *filename;
1185 <  char chanmodes[IRCD_BUFSIZE];
1186 <  char chanlimit[IRCD_BUFSIZE];
1184 >  const char *filename = NULL;
1185 >  char chanmodes[IRCD_BUFSIZE] = "";
1186 >  char chanlimit[IRCD_BUFSIZE] = "";
1187  
1188    conf_parser_ctx.boot = cold;
1189 <  filename = ConfigFileEntry.configfile;
1189 >  filename = ConfigGeneral.configfile;
1190  
1191    /* We need to know the initial filename for the yyerror() to report
1192       FIXME: The full path is in conffilenamebuf first time since we
1193 <             dont know anything else
1193 >             don't know anything else
1194  
1195       - Gozem 2002-07-21
1196    */
# Line 1478 | Line 1221 | read_conf_files(int cold)
1221  
1222    log_reopen_all();
1223  
1224 <  add_isupport("NICKLEN", NULL, ServerInfo.max_nick_length);
1225 <  add_isupport("NETWORK", ServerInfo.network_name, -1);
1224 >  add_isupport("NICKLEN", NULL, ConfigServerInfo.max_nick_length);
1225 >  add_isupport("NETWORK", ConfigServerInfo.network_name, -1);
1226  
1227    snprintf(chanmodes, sizeof(chanmodes), "beI:%d", ConfigChannel.max_bans);
1228    add_isupport("MAXLIST", chanmodes, -1);
1229 <  add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1229 >  add_isupport("MAXTARGETS", NULL, ConfigGeneral.max_targets);
1230    add_isupport("CHANTYPES", "#", -1);
1231  
1232    snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1233 <           ConfigChannel.max_chans_per_user);
1233 >           ConfigChannel.max_channels);
1234    add_isupport("CHANLIMIT", chanlimit, -1);
1235 <  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,imnprstORS");
1236 <  add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
1237 <  add_isupport("TOPICLEN", NULL, ServerInfo.max_topic_length);
1235 >  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,cimnprstMORS");
1236 >  add_isupport("CHANNELLEN", NULL, CHANNELLEN);
1237 >  add_isupport("TOPICLEN", NULL, ConfigServerInfo.max_topic_length);
1238    add_isupport("CHANMODES", chanmodes, -1);
1239  
1240    /*
# Line 1511 | Line 1254 | static void
1254   clear_out_old_conf(void)
1255   {
1256    dlink_node *ptr = NULL, *next_ptr = NULL;
1514  struct MaskItem *conf;
1257    dlink_list *free_items [] = {
1258      &server_items,   &oconf_items,
1259       &uconf_items,   &xconf_items,
# Line 1528 | Line 1270 | clear_out_old_conf(void)
1270    {
1271      DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
1272      {
1273 <      conf = ptr->data;
1273 >      struct MaskItem *conf = ptr->data;
1274  
1275 <      dlinkDelete(&conf->node, map_to_list(conf->type));
1275 >      conf->active = 0;
1276 >      dlinkDelete(&conf->node, *iterator);
1277  
1278        /* XXX This is less than pretty */
1279        if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
# Line 1561 | Line 1304 | clear_out_old_conf(void)
1304    /* clean out module paths */
1305    mod_clear_paths();
1306  
1307 <  /* clean out ServerInfo */
1308 <  MyFree(ServerInfo.description);
1309 <  ServerInfo.description = NULL;
1310 <  MyFree(ServerInfo.network_name);
1311 <  ServerInfo.network_name = NULL;
1312 <  MyFree(ServerInfo.network_desc);
1313 <  ServerInfo.network_desc = NULL;
1314 <  MyFree(ConfigFileEntry.egdpool_path);
1315 <  ConfigFileEntry.egdpool_path = NULL;
1307 >  pseudo_clear();
1308 >
1309 >  /* clean out ConfigServerInfo */
1310 >  MyFree(ConfigServerInfo.description);
1311 >  ConfigServerInfo.description = NULL;
1312 >  MyFree(ConfigServerInfo.network_name);
1313 >  ConfigServerInfo.network_name = NULL;
1314 >  MyFree(ConfigServerInfo.network_desc);
1315 >  ConfigServerInfo.network_desc = NULL;
1316   #ifdef HAVE_LIBCRYPTO
1317 <  if (ServerInfo.rsa_private_key != NULL)
1317 >  if (ConfigServerInfo.rsa_private_key)
1318    {
1319 <    RSA_free(ServerInfo.rsa_private_key);
1320 <    ServerInfo.rsa_private_key = NULL;
1319 >    RSA_free(ConfigServerInfo.rsa_private_key);
1320 >    ConfigServerInfo.rsa_private_key = NULL;
1321    }
1322  
1323 <  MyFree(ServerInfo.rsa_private_key_file);
1324 <  ServerInfo.rsa_private_key_file = NULL;
1582 <
1583 <  if (ServerInfo.server_ctx)
1584 <    SSL_CTX_set_options(ServerInfo.server_ctx, SSL_OP_NO_SSLv2|
1585 <                                               SSL_OP_NO_SSLv3|
1586 <                                               SSL_OP_NO_TLSv1);
1587 <  if (ServerInfo.client_ctx)
1588 <    SSL_CTX_set_options(ServerInfo.client_ctx, SSL_OP_NO_SSLv2|
1589 <                                               SSL_OP_NO_SSLv3|
1590 <                                               SSL_OP_NO_TLSv1);
1323 >  MyFree(ConfigServerInfo.rsa_private_key_file);
1324 >  ConfigServerInfo.rsa_private_key_file = NULL;
1325   #endif
1326  
1327 <  /* clean out AdminInfo */
1328 <  MyFree(AdminInfo.name);
1329 <  AdminInfo.name = NULL;
1330 <  MyFree(AdminInfo.email);
1331 <  AdminInfo.email = NULL;
1332 <  MyFree(AdminInfo.description);
1333 <  AdminInfo.description = NULL;
1327 >  /* clean out ConfigAdminInfo */
1328 >  MyFree(ConfigAdminInfo.name);
1329 >  ConfigAdminInfo.name = NULL;
1330 >  MyFree(ConfigAdminInfo.email);
1331 >  ConfigAdminInfo.email = NULL;
1332 >  MyFree(ConfigAdminInfo.description);
1333 >  ConfigAdminInfo.description = NULL;
1334  
1335    /* clean out listeners */
1336    close_listeners();
1603
1604  /* clean out general */
1605  MyFree(ConfigFileEntry.service_name);
1606  ConfigFileEntry.service_name = NULL;
1337   }
1338  
1339   /* conf_add_class_to_conf()
# Line 1740 | Line 1470 | valid_wild_card_simple(const char *data)
1470   {
1471    const unsigned char *p = (const unsigned char *)data;
1472    unsigned char tmpch = '\0';
1473 <  int nonwild = 0;
1473 >  unsigned int nonwild = 0;
1474  
1475    while ((tmpch = *p++))
1476    {
1477 <    if (tmpch == '\\')
1477 >    if (tmpch == '\\' && *p)
1478      {
1479        ++p;
1480 <      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1480 >      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1481          return 1;
1482      }
1483      else if (!IsMWildChar(tmpch))
1484      {
1485 <      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1485 >      if (++nonwild >= ConfigGeneral.min_nonwildcard_simple)
1486          return 1;
1487      }
1488    }
# Line 1771 | Line 1501 | valid_wild_card_simple(const char *data)
1501   int
1502   valid_wild_card(struct Client *source_p, int warn, int count, ...)
1503   {
1504 <  char tmpch;
1505 <  int nonwild = 0;
1504 >  unsigned char tmpch = '\0';
1505 >  unsigned int nonwild = 0;
1506    va_list args;
1507  
1508    /*
# Line 1791 | Line 1521 | valid_wild_card(struct Client *source_p,
1521  
1522    while (count--)
1523    {
1524 <    const char *p = va_arg(args, const char *);
1524 >    const unsigned char *p = va_arg(args, const unsigned char *);
1525      if (p == NULL)
1526        continue;
1527  
# Line 1803 | Line 1533 | valid_wild_card(struct Client *source_p,
1533           * If we find enough non-wild characters, we can
1534           * break - no point in searching further.
1535           */
1536 <        if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1536 >        if (++nonwild >= ConfigGeneral.min_nonwildcard)
1537          {
1538            va_end(args);
1539            return 1;
# Line 1814 | Line 1544 | valid_wild_card(struct Client *source_p,
1544  
1545    if (warn)
1546      sendto_one_notice(source_p, &me,
1547 <                      ":Please include at least %d non-wildcard characters with the mask",
1548 <                      ConfigFileEntry.min_nonwildcard);
1547 >                      ":Please include at least %u non-wildcard characters with the mask",
1548 >                      ConfigGeneral.min_nonwildcard);
1549    va_end(args);
1550    return 0;
1551   }
# Line 1857 | Line 1587 | parse_aline(const char *cmd, struct Clie
1587              char **target_server, char **reason)
1588   {
1589    int found_tkline_time=0;
1590 <  static char def_reason[] = "No Reason";
1590 >  static char def_reason[] = CONF_NOREASON;
1591    static char user[USERLEN*4+1];
1592    static char host[HOSTLEN*4+1];
1593  
# Line 2022 | Line 1752 | find_user_host(struct Client *source_p,
1752      /* Try to find user@host mask from nick */
1753      /* Okay to use source_p as the first param, because source_p == client_p */
1754      if ((target_p =
1755 <        find_chasing(source_p, user_host_or_nick, NULL)) == NULL)
1756 <      return 0;
1755 >        find_chasing(source_p, user_host_or_nick)) == NULL)
1756 >      return 0;  /* find_chasing sends ERR_NOSUCHNICK */
1757  
1758      if (IsExemptKline(target_p))
1759      {
1760 <      if (!IsServer(source_p))
1760 >      if (IsClient(source_p))
1761          sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
1762        return 0;
1763      }
# Line 2041 | Line 1771 | find_user_host(struct Client *source_p,
1771      if (target_p->username[0] == '~')
1772        luser[0] = '*';
1773  
1774 <    if (target_p->sockhost[0] == '\0' ||
2045 <        (target_p->sockhost[0] == '0' && target_p->sockhost[1] == '\0'))
1774 >    if (!strcmp(target_p->sockhost, "0"))
1775        strlcpy(lhost, target_p->host, HOSTLEN*4 + 1);
1776      else
1777        strlcpy(lhost, target_p->sockhost, HOSTLEN*4 + 1);
# Line 2089 | Line 1818 | match_conf_password(const char *password
1818    else
1819      encr = password;
1820  
1821 <  return !strcmp(encr, conf->passwd);
1821 >  return encr && !strcmp(encr, conf->passwd);
1822   }
1823  
1824   /*
# Line 2097 | Line 1826 | match_conf_password(const char *password
1826   *
1827   * inputs       - client sending the cluster
1828   *              - command name "KLINE" "XLINE" etc.
1829 < *              - capab -- CAP_KLN etc. from s_serv.h
1829 > *              - capab -- CAP_KLN etc. from server.h
1830   *              - cluster type -- CLUSTER_KLINE etc. from conf.h
1831   *              - pattern and args to send along
1832   * output       - none
# Line 2109 | Line 1838 | cluster_a_line(struct Client *source_p,
1838                 int capab, int cluster_type, const char *pattern, ...)
1839   {
1840    va_list args;
1841 <  char buffer[IRCD_BUFSIZE];
1841 >  char buffer[IRCD_BUFSIZE] = "";
1842    const dlink_node *ptr = NULL;
1843  
1844    va_start(args, pattern);
# Line 2170 | Line 1899 | split_nuh(struct split_nuh_item *const i
1899    {
1900      *p = '\0';
1901  
1902 <    if (iptr->nickptr && *iptr->nuhmask != '\0')
1902 >    if (iptr->nickptr && *iptr->nuhmask)
1903        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
1904  
1905      if ((q = strchr(++p, '@')))
1906      {
1907        *q++ = '\0';
1908  
1909 <      if (*p != '\0')
1909 >      if (*p)
1910          strlcpy(iptr->userptr, p, iptr->usersize);
1911  
1912 <      if (*q != '\0')
1912 >      if (*q)
1913          strlcpy(iptr->hostptr, q, iptr->hostsize);
1914      }
1915      else
1916      {
1917 <      if (*p != '\0')
1917 >      if (*p)
1918          strlcpy(iptr->userptr, p, iptr->usersize);
1919      }
1920    }
# Line 2197 | Line 1926 | split_nuh(struct split_nuh_item *const i
1926        /* if found a @ */
1927        *p++ = '\0';
1928  
1929 <      if (*iptr->nuhmask != '\0')
1929 >      if (*iptr->nuhmask)
1930          strlcpy(iptr->userptr, iptr->nuhmask, iptr->usersize);
1931  
1932 <      if (*p != '\0')
1932 >      if (*p)
1933          strlcpy(iptr->hostptr, p, iptr->hostsize);
1934      }
1935      else

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)