ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing:
ircd-hybrid-8/src/conf.c (file contents), Revision 1393 by michael, Wed May 2 19:17:37 2012 UTC vs.
ircd-hybrid/trunk/src/conf.c (file contents), Revision 4313 by michael, Thu Jul 31 18:50:11 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  conf.c: Configuration file functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 18 | Line 17
17   *  along with this program; if not, write to the Free Software
18   *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file conf.c
23 > * \brief Configuration file functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29   #include "ircd_defs.h"
28 – #include "balloc.h"
30   #include "conf.h"
31 < #include "s_serv.h"
31 > #include "server.h"
32   #include "resv.h"
33   #include "channel.h"
34   #include "client.h"
35   #include "event.h"
35 – #include "hook.h"
36   #include "irc_string.h"
37   #include "s_bsd.h"
38   #include "ircd.h"
# Line 43 | Line 43
43   #include "fdlist.h"
44   #include "log.h"
45   #include "send.h"
46 – #include "s_gline.h"
46   #include "memory.h"
47 < #include "irc_res.h"
47 > #include "mempool.h"
48 > #include "res.h"
49   #include "userhost.h"
50 < #include "s_user.h"
50 > #include "user.h"
51   #include "channel_mode.h"
52   #include "parse.h"
53 < #include "s_misc.h"
53 > #include "misc.h"
54 > #include "conf_db.h"
55 > #include "conf_class.h"
56 > #include "motd.h"
57  
55 – struct Callback *client_check_cb = NULL;
56 – struct config_server_hide ConfigServerHide;
58  
59   /* general conf items link list root, other than k lines etc. */
60   dlink_list service_items = { NULL, NULL, 0 };
# Line 62 | Line 63 | dlink_list cluster_items = { NULL, NULL,
63   dlink_list oconf_items   = { NULL, NULL, 0 };
64   dlink_list uconf_items   = { NULL, NULL, 0 };
65   dlink_list xconf_items   = { NULL, NULL, 0 };
65 – dlink_list rxconf_items  = { NULL, NULL, 0 };
66 – dlink_list rkconf_items  = { NULL, NULL, 0 };
66   dlink_list nresv_items   = { NULL, NULL, 0 };
67 < dlink_list class_items   = { NULL, NULL, 0 };
69 < dlink_list gdeny_items   = { NULL, NULL, 0 };
70 <
71 < dlink_list temporary_xlines  = { NULL, NULL, 0 };
72 < dlink_list temporary_resv = { NULL, NULL, 0 };
67 > dlink_list cresv_items   = { NULL, NULL, 0 };
68  
69   extern unsigned int lineno;
70   extern char linebuf[];
71   extern char conffilebuf[IRCD_BUFSIZE];
72   extern int yyparse(); /* defined in y.tab.c */
73  
79 – struct conf_parser_context conf_parser_ctx = { 0, 0, NULL };
80 –
74   /* internally defined functions */
75   static void read_conf(FILE *);
76   static void clear_out_old_conf(void);
84 – static void flush_deleted_I_P(void);
77   static void expire_tklines(dlink_list *);
78   static void garbage_collect_ip_entries(void);
79   static int hash_ip(struct irc_ssaddr *);
80 < static int verify_access(struct Client *, const char *);
81 < static int attach_iline(struct Client *, struct ConfItem *);
80 > static int verify_access(struct Client *);
81 > static int attach_iline(struct Client *, struct MaskItem *);
82   static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
83 < static void parse_conf_file(int, int);
92 < static dlink_list *map_to_list(ConfType);
93 < static struct AccessItem *find_regexp_kline(const char *[]);
83 > static dlink_list *map_to_list(enum maskitem_type);
84   static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
85  
96 – /*
97 – * bit_len
98 – */
99 – static int cidr_limit_reached(int, struct irc_ssaddr *, struct ClassItem *);
100 – static void remove_from_cidr_check(struct irc_ssaddr *, struct ClassItem *);
101 – static void destroy_cidr_class(struct ClassItem *);
102 –
103 – static void flags_to_ascii(unsigned int, const unsigned int[], char *, int);
104 –
105 – /* address of default class conf */
106 – static struct ConfItem *class_default;
86  
87   /* usually, with hash tables, you use a prime number...
88   * but in this case I am dealing with ip addresses,
# Line 114 | Line 93 | static struct ConfItem *class_default;
93   struct ip_entry
94   {
95    struct irc_ssaddr ip;
96 <  int count;
97 <  time_t last_attempt;
96 >  unsigned int count;  /**< Number of registered users using this IP */
97 >  unsigned int connection_count;  /**< Number of connections from this IP in the last throttle_time duration */
98 >  time_t last_attempt;  /**< The last time someone connected from this IP */
99    struct ip_entry *next;
100   };
101  
102   static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
103 < static BlockHeap *ip_entry_heap = NULL;
103 > static mp_pool_t *ip_entry_pool = NULL;
104   static int ip_entries_count = 0;
105  
106  
127 – void *
128 – map_to_conf(struct ConfItem *aconf)
129 – {
130 –  void *conf;
131 –  conf = (void *)((uintptr_t)aconf +
132 –                  (uintptr_t)sizeof(struct ConfItem));
133 –  return(conf);
134 – }
135 –
136 – struct ConfItem *
137 – unmap_conf_item(void *aconf)
138 – {
139 –  struct ConfItem *conf;
140 –
141 –  conf = (struct ConfItem *)((uintptr_t)aconf -
142 –                             (uintptr_t)sizeof(struct ConfItem));
143 –  return(conf);
144 – }
145 –
107   /* conf_dns_callback()
108   *
109 < * inputs       - pointer to struct AccessItem
109 > * inputs       - pointer to struct MaskItem
110   *              - pointer to DNSReply reply
111   * output       - none
112   * side effects - called when resolver query finishes
# Line 156 | Line 117 | unmap_conf_item(void *aconf)
117   static void
118   conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
119   {
120 <  struct AccessItem *aconf = vptr;
120 >  struct MaskItem *conf = vptr;
121  
122 <  aconf->dns_pending = 0;
122 >  conf->dns_pending = 0;
123  
124 <  if (addr != NULL)
125 <    memcpy(&aconf->addr, addr, sizeof(aconf->addr));
124 >  if (addr)
125 >    memcpy(&conf->addr, addr, sizeof(conf->addr));
126    else
127 <    aconf->dns_failed = 1;
127 >    conf->dns_failed = 1;
128   }
129  
130   /* conf_dns_lookup()
# Line 173 | Line 134 | conf_dns_callback(void *vptr, const stru
134   * allocate a dns_query and start ns lookup.
135   */
136   static void
137 < conf_dns_lookup(struct AccessItem *aconf)
137 > conf_dns_lookup(struct MaskItem *conf)
138   {
139 <  if (!aconf->dns_pending)
139 >  if (!conf->dns_pending)
140    {
141 <    aconf->dns_pending = 1;
142 <    gethost_byname(conf_dns_callback, aconf, aconf->host);
141 >    conf->dns_pending = 1;
142 >    gethost_byname(conf_dns_callback, conf, conf->host);
143    }
144   }
145  
146 < /* make_conf_item()
147 < *
187 < * inputs       - type of item
188 < * output       - pointer to new conf entry
189 < * side effects - none
190 < */
191 < struct ConfItem *
192 < make_conf_item(ConfType type)
146 > struct MaskItem *
147 > conf_make(enum maskitem_type type)
148   {
149 <  struct ConfItem *conf = NULL;
150 <  struct AccessItem *aconf = NULL;
196 <  struct ClassItem *aclass = NULL;
197 <  int status = 0;
198 <
199 <  switch (type)
200 <  {
201 <  case DLINE_TYPE:
202 <  case EXEMPTDLINE_TYPE:
203 <  case GLINE_TYPE:
204 <  case KLINE_TYPE:
205 <  case CLIENT_TYPE:
206 <  case OPER_TYPE:
207 <  case SERVER_TYPE:
208 <    conf = MyMalloc(sizeof(struct ConfItem) +
209 <                    sizeof(struct AccessItem));
210 <    aconf = map_to_conf(conf);
211 <    aconf->aftype = AF_INET;
212 <
213 <    /* Yes, sigh. switch on type again */
214 <    switch (type)
215 <    {
216 <    case EXEMPTDLINE_TYPE:
217 <      status = CONF_EXEMPTDLINE;
218 <      break;
219 <
220 <    case DLINE_TYPE:
221 <      status = CONF_DLINE;
222 <      break;
223 <
224 <    case KLINE_TYPE:
225 <      status = CONF_KLINE;
226 <      break;
227 <
228 <    case GLINE_TYPE:
229 <      status = CONF_GLINE;
230 <      break;
231 <
232 <    case CLIENT_TYPE:
233 <      status = CONF_CLIENT;
234 <      break;
235 <
236 <    case OPER_TYPE:
237 <      status = CONF_OPERATOR;
238 <      dlinkAdd(conf, &conf->node, &oconf_items);
239 <      break;
240 <
241 <    case SERVER_TYPE:
242 <      status = CONF_SERVER;
243 <      dlinkAdd(conf, &conf->node, &server_items);
244 <      break;
245 <
246 <    default:
247 <      break;
248 <    }
249 <    aconf->status = status;
250 <    break;
251 <
252 <  case ULINE_TYPE:
253 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
254 <                                       sizeof(struct MatchItem));
255 <    dlinkAdd(conf, &conf->node, &uconf_items);
256 <    break;
257 <
258 <  case GDENY_TYPE:
259 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
260 <                                       sizeof(struct AccessItem));
261 <    dlinkAdd(conf, &conf->node, &gdeny_items);
262 <    break;
149 >  struct MaskItem *conf = MyCalloc(sizeof(*conf));
150 >  dlink_list *list = NULL;
151  
152 <  case XLINE_TYPE:
153 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
154 <                                       sizeof(struct MatchItem));
267 <    dlinkAdd(conf, &conf->node, &xconf_items);
268 <    break;
269 < #ifdef HAVE_LIBPCRE
270 <  case RXLINE_TYPE:
271 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
272 <                                       sizeof(struct MatchItem));
273 <    dlinkAdd(conf, &conf->node, &rxconf_items);
274 <    break;
275 <
276 <  case RKLINE_TYPE:
277 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
278 <                                       sizeof(struct AccessItem));
279 <    aconf = map_to_conf(conf);
280 <    aconf->status = CONF_KLINE;
281 <    dlinkAdd(conf, &conf->node, &rkconf_items);
282 <    break;
283 < #endif
284 <  case CLUSTER_TYPE:
285 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem));
286 <    dlinkAdd(conf, &conf->node, &cluster_items);
287 <    break;
288 <
289 <  case CRESV_TYPE:
290 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
291 <                                       sizeof(struct ResvChannel));
292 <    break;
293 <
294 <  case NRESV_TYPE:
295 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
296 <                                       sizeof(struct MatchItem));
297 <    dlinkAdd(conf, &conf->node, &nresv_items);
298 <    break;
299 <
300 <  case SERVICE_TYPE:
301 <    status = CONF_SERVICE;
302 <    conf = MyMalloc(sizeof(struct ConfItem));
303 <    dlinkAdd(conf, &conf->node, &service_items);
304 <    break;
305 <
306 <  case CLASS_TYPE:
307 <    conf = MyMalloc(sizeof(struct ConfItem) +
308 <                           sizeof(struct ClassItem));
309 <    dlinkAdd(conf, &conf->node, &class_items);
310 <
311 <    aclass = map_to_conf(conf);
312 <    aclass->active = 1;
313 <    aclass->con_freq = DEFAULT_CONNECTFREQUENCY;
314 <    aclass->ping_freq = DEFAULT_PINGFREQUENCY;
315 <    aclass->max_total = MAXIMUM_LINKS_DEFAULT;
316 <    aclass->max_sendq = DEFAULT_SENDQ;
317 <
318 <    break;
319 <
320 <  default:
321 <    conf = NULL;
322 <    break;
323 <  }
324 <
325 <  /* XXX Yes, this will core if default is hit. I want it to for now - db */
326 <  conf->type = type;
152 >  conf->type   = type;
153 >  conf->active = 1;
154 >  conf->aftype = AF_INET;
155  
156 +  if ((list = map_to_list(type)))
157 +    dlinkAdd(conf, &conf->node, list);
158    return conf;
159   }
160  
161   void
162 < delete_conf_item(struct ConfItem *conf)
162 > conf_free(struct MaskItem *conf)
163   {
164 <  dlink_node *m = NULL, *m_next = NULL;
165 <  struct MatchItem *match_item;
166 <  struct AccessItem *aconf;
167 <  ConfType type = conf->type;
164 >  dlink_node *ptr = NULL, *ptr_next = NULL;
165 >  dlink_list *list = NULL;
166 >
167 >  if (conf->node.next)
168 >    if ((list = map_to_list(conf->type)))
169 >      dlinkDelete(&conf->node, list);
170  
171    MyFree(conf->name);
340 –  conf->name = NULL;
172  
173 <  switch(type)
174 <  {
175 <  case DLINE_TYPE:
176 <  case EXEMPTDLINE_TYPE:
177 <  case GLINE_TYPE:
178 <  case KLINE_TYPE:
179 <  case CLIENT_TYPE:
180 <  case OPER_TYPE:
181 <  case SERVER_TYPE:
182 <    aconf = map_to_conf(conf);
183 <
184 <    if (aconf->dns_pending)
185 <      delete_resolver_queries(aconf);
186 <    if (aconf->passwd != NULL)
187 <      memset(aconf->passwd, 0, strlen(aconf->passwd));
357 <    if (aconf->spasswd != NULL)
358 <      memset(aconf->spasswd, 0, strlen(aconf->spasswd));
359 <    aconf->class_ptr = NULL;
360 <
361 <    MyFree(aconf->passwd);
362 <    MyFree(aconf->spasswd);
363 <    MyFree(aconf->reason);
364 <    MyFree(aconf->oper_reason);
365 <    MyFree(aconf->user);
366 <    MyFree(aconf->host);
367 <    MyFree(aconf->cipher_list);
173 >  if (conf->dns_pending)
174 >    delete_resolver_queries(conf);
175 >  if (conf->passwd)
176 >    memset(conf->passwd, 0, strlen(conf->passwd));
177 >  if (conf->spasswd)
178 >    memset(conf->spasswd, 0, strlen(conf->spasswd));
179 >
180 >  conf->class = NULL;
181 >
182 >  MyFree(conf->passwd);
183 >  MyFree(conf->spasswd);
184 >  MyFree(conf->reason);
185 >  MyFree(conf->certfp);
186 >  MyFree(conf->user);
187 >  MyFree(conf->host);
188   #ifdef HAVE_LIBCRYPTO
189 <    if (aconf->rsa_public_key)
370 <      RSA_free(aconf->rsa_public_key);
371 <    MyFree(aconf->rsa_public_key_file);
372 < #endif
373 <
374 <    /* Yes, sigh. switch on type again */
375 <    switch(type)
376 <    {
377 <    case EXEMPTDLINE_TYPE:
378 <    case DLINE_TYPE:
379 <    case GLINE_TYPE:
380 <    case KLINE_TYPE:
381 <    case CLIENT_TYPE:
382 <      MyFree(conf);
383 <      break;
189 >  MyFree(conf->cipher_list);
190  
191 <    case OPER_TYPE:
192 <      aconf = map_to_conf(conf);
387 <      if (!IsConfIllegal(aconf))
388 <        dlinkDelete(&conf->node, &oconf_items);
389 <      MyFree(conf);
390 <      break;
391 <
392 <    case SERVER_TYPE:
393 <      aconf = map_to_conf(conf);
394 <
395 <      DLINK_FOREACH_SAFE(m, m_next, aconf->hub_list.head)
396 <      {
397 <        MyFree(m->data);
398 <        free_dlink_node(m);
399 <      }
400 <
401 <      DLINK_FOREACH_SAFE(m, m_next, aconf->leaf_list.head)
402 <      {
403 <        MyFree(m->data);
404 <        free_dlink_node(m);  
405 <      }
406 <
407 <      if (!IsConfIllegal(aconf))
408 <        dlinkDelete(&conf->node, &server_items);
409 <      MyFree(conf);
410 <      break;
411 <
412 <    default:
413 <      break;
414 <    }
415 <    break;
416 <
417 <  case ULINE_TYPE:
418 <    match_item = map_to_conf(conf);
419 <    MyFree(match_item->user);
420 <    MyFree(match_item->host);
421 <    MyFree(match_item->reason);
422 <    MyFree(match_item->oper_reason);
423 <    dlinkDelete(&conf->node, &uconf_items);
424 <    MyFree(conf);
425 <    break;
426 <
427 <  case XLINE_TYPE:
428 <    match_item = map_to_conf(conf);
429 <    MyFree(match_item->user);
430 <    MyFree(match_item->host);
431 <    MyFree(match_item->reason);
432 <    MyFree(match_item->oper_reason);
433 <    dlinkDelete(&conf->node, &xconf_items);
434 <    MyFree(conf);
435 <    break;
436 < #ifdef HAVE_LIBPCRE
437 <  case RKLINE_TYPE:
438 <    aconf = map_to_conf(conf);
439 <    MyFree(aconf->regexuser);
440 <    MyFree(aconf->regexhost);
441 <    MyFree(aconf->user);
442 <    MyFree(aconf->host);
443 <    MyFree(aconf->reason);
444 <    MyFree(aconf->oper_reason);
445 <    dlinkDelete(&conf->node, &rkconf_items);
446 <    MyFree(conf);
447 <    break;
448 <
449 <  case RXLINE_TYPE:
450 <    MyFree(conf->regexpname);
451 <    match_item = map_to_conf(conf);
452 <    MyFree(match_item->user);
453 <    MyFree(match_item->host);
454 <    MyFree(match_item->reason);
455 <    MyFree(match_item->oper_reason);
456 <    dlinkDelete(&conf->node, &rxconf_items);
457 <    MyFree(conf);
458 <    break;
191 >  if (conf->rsa_public_key)
192 >    RSA_free(conf->rsa_public_key);
193   #endif
194 <  case NRESV_TYPE:
195 <    match_item = map_to_conf(conf);
196 <    MyFree(match_item->user);
197 <    MyFree(match_item->host);
198 <    MyFree(match_item->reason);
465 <    MyFree(match_item->oper_reason);
466 <    dlinkDelete(&conf->node, &nresv_items);
467 <
468 <    if (conf->flags & CONF_FLAGS_TEMPORARY)
469 <      if ((m = dlinkFindDelete(&temporary_resv, conf)) != NULL)
470 <        free_dlink_node(m);
471 <
472 <    MyFree(conf);
473 <    break;
474 <
475 <  case GDENY_TYPE:
476 <    aconf = map_to_conf(conf);
477 <    MyFree(aconf->user);
478 <    MyFree(aconf->host);
479 <    dlinkDelete(&conf->node, &gdeny_items);
480 <    MyFree(conf);
481 <    break;
482 <
483 <  case CLUSTER_TYPE:
484 <    dlinkDelete(&conf->node, &cluster_items);
485 <    MyFree(conf);
486 <    break;
487 <
488 <  case CRESV_TYPE:
489 <    if (conf->flags & CONF_FLAGS_TEMPORARY)
490 <      if ((m = dlinkFindDelete(&temporary_resv, conf)) != NULL)
491 <        free_dlink_node(m);
492 <
493 <    MyFree(conf);
494 <    break;
495 <
496 <  case CLASS_TYPE:
497 <    dlinkDelete(&conf->node, &class_items);
498 <    MyFree(conf);
499 <    break;
500 <
501 <  case SERVICE_TYPE:
502 <    dlinkDelete(&conf->node, &service_items);
503 <    MyFree(conf);
504 <    break;
505 <
506 <  default:
507 <    break;
194 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->hub_list.head)
195 >  {
196 >    MyFree(ptr->data);
197 >    dlinkDelete(ptr, &conf->hub_list);
198 >    free_dlink_node(ptr);
199    }
509 – }
510 –
511 – /* free_access_item()
512 – *
513 – * inputs       - pointer to conf to free
514 – * output       - none
515 – * side effects - crucial password fields are zeroed, conf is freed
516 – */
517 – void
518 – free_access_item(struct AccessItem *aconf)
519 – {
520 –  struct ConfItem *conf;
521 –
522 –  if (aconf == NULL)
523 –    return;
524 –  conf = unmap_conf_item(aconf);
525 –  delete_conf_item(conf);
526 – }
527 –
528 – static const unsigned int shared_bit_table[] =
529 –  { 'K', 'k', 'U', 'X', 'x', 'Y', 'Q', 'q', 'R', 'L', 0};
530 –
531 – /* report_confitem_types()
532 – *
533 – * inputs       - pointer to client requesting confitem report
534 – *              - ConfType to report
535 – * output       - none
536 – * side effects -
537 – */
538 – void
539 – report_confitem_types(struct Client *source_p, ConfType type)
540 – {
541 –  dlink_node *ptr = NULL, *dptr = NULL;
542 –  struct ConfItem *conf = NULL;
543 –  struct AccessItem *aconf = NULL;
544 –  struct MatchItem *matchitem = NULL;
545 –  struct ClassItem *classitem = NULL;
546 –  char buf[12];
547 –  char *p = NULL;
200  
201 <  switch (type)
201 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->leaf_list.head)
202    {
203 <  case GDENY_TYPE:
204 <    DLINK_FOREACH(ptr, gdeny_items.head)
205 <    {
206 <      conf = ptr->data;
555 <      aconf = map_to_conf(conf);
556 <
557 <      p = buf;
558 <
559 <      if (aconf->flags & GDENY_BLOCK)
560 <        *p++ = 'B';
561 <      else
562 <        *p++ = 'b';
563 <
564 <      if (aconf->flags & GDENY_REJECT)
565 <        *p++ = 'R';
566 <      else
567 <        *p++ = 'r';
568 <
569 <      *p = '\0';
570 <
571 <      sendto_one(source_p, ":%s %d %s V %s@%s %s %s",
572 <                 me.name, RPL_STATSDEBUG, source_p->name,
573 <                 aconf->user, aconf->host, conf->name, buf);
574 <    }
575 <    break;
576 <
577 <  case XLINE_TYPE:
578 <    DLINK_FOREACH(ptr, xconf_items.head)
579 <    {
580 <      conf = ptr->data;
581 <      matchitem = map_to_conf(conf);
582 <
583 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
584 <                 me.name, source_p->name,
585 <                 matchitem->hold ? "x": "X", matchitem->count,
586 <                 conf->name, matchitem->reason);
587 <    }
588 <    break;
589 <
590 < #ifdef HAVE_LIBPCRE
591 <  case RXLINE_TYPE:
592 <    DLINK_FOREACH(ptr, rxconf_items.head)
593 <    {
594 <      conf = ptr->data;
595 <      matchitem = map_to_conf(conf);
596 <
597 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
598 <                 me.name, source_p->name,
599 <                 "XR", matchitem->count,
600 <                 conf->name, matchitem->reason);
601 <    }
602 <    break;
603 <
604 <  case RKLINE_TYPE:
605 <    DLINK_FOREACH(ptr, rkconf_items.head)
606 <    {
607 <      aconf = map_to_conf((conf = ptr->data));
608 <
609 <      sendto_one(source_p, form_str(RPL_STATSKLINE), me.name,
610 <                 source_p->name, "KR", aconf->host, aconf->user,
611 <                 aconf->reason, aconf->oper_reason ? aconf->oper_reason : "");
612 <    }
613 <    break;
614 < #endif
615 <
616 <  case ULINE_TYPE:
617 <    DLINK_FOREACH(ptr, uconf_items.head)
618 <    {
619 <      conf = ptr->data;
620 <      matchitem = map_to_conf(conf);
621 <
622 <      p = buf;
623 <
624 <      /* some of these are redundant for the sake of
625 <       * consistency with cluster{} flags
626 <       */
627 <      *p++ = 'c';
628 <      flags_to_ascii(matchitem->action, shared_bit_table, p, 0);
629 <
630 <      sendto_one(source_p, form_str(RPL_STATSULINE),
631 <                 me.name, source_p->name, conf->name,
632 <                 matchitem->user?matchitem->user: "*",
633 <                 matchitem->host?matchitem->host: "*", buf);
634 <    }
635 <
636 <    DLINK_FOREACH(ptr, cluster_items.head)
637 <    {
638 <      conf = ptr->data;
639 <
640 <      p = buf;
641 <
642 <      *p++ = 'C';
643 <      flags_to_ascii(conf->flags, shared_bit_table, p, 0);
644 <
645 <      sendto_one(source_p, form_str(RPL_STATSULINE),
646 <                 me.name, source_p->name, conf->name,
647 <                 "*", "*", buf);
648 <    }
649 <
650 <    break;
651 <
652 <  case OPER_TYPE:
653 <    DLINK_FOREACH(ptr, oconf_items.head)
654 <    {
655 <      conf = ptr->data;
656 <      aconf = map_to_conf(conf);
657 <
658 <      /* Don't allow non opers to see oper privs */
659 <      if (HasUMode(source_p, UMODE_OPER))
660 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
661 <                   me.name, source_p->name, 'O', aconf->user, aconf->host,
662 <                   conf->name, oper_privs_as_string(aconf->port),
663 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
664 <      else
665 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
666 <                   me.name, source_p->name, 'O', aconf->user, aconf->host,
667 <                   conf->name, "0",
668 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
669 <    }
670 <    break;
671 <
672 <  case CLASS_TYPE:
673 <    DLINK_FOREACH(ptr, class_items.head)
674 <    {
675 <      conf = ptr->data;
676 <      classitem = map_to_conf(conf);
677 <      sendto_one(source_p, form_str(RPL_STATSYLINE),
678 <                 me.name, source_p->name, 'Y',
679 <                 conf->name, classitem->ping_freq,
680 <                 classitem->con_freq,
681 <                 classitem->max_total, classitem->max_sendq,
682 <                 classitem->curr_user_count,
683 <                 classitem->active ? "active" : "disabled");
684 <    }
685 <    break;
686 <
687 <  case CONF_TYPE:
688 <  case CLIENT_TYPE:
689 <    break;
690 <
691 <  case SERVICE_TYPE:
692 <    DLINK_FOREACH(ptr, service_items.head)
693 <    {
694 <      conf = ptr->data;
695 <      sendto_one(source_p, form_str(RPL_STATSSERVICE),
696 <                 me.name, source_p->name, 'S', "*", conf->name, 0, 0);
697 <    }
698 <    break;
699 <
700 <  case SERVER_TYPE:
701 <    DLINK_FOREACH(ptr, server_items.head)
702 <    {
703 <      p = buf;
704 <
705 <      conf = ptr->data;
706 <      aconf = map_to_conf(conf);
707 <
708 <      buf[0] = '\0';
709 <
710 <      if (IsConfAllowAutoConn(aconf))
711 <        *p++ = 'A';
712 <      if (IsConfSSL(aconf))
713 <        *p++ = 'S';
714 <      if (IsConfTopicBurst(aconf))
715 <        *p++ = 'T';
716 <      if (buf[0] == '\0')
717 <        *p++ = '*';
718 <
719 <      *p = '\0';
720 <
721 <      /*
722 <       * Allow admins to see actual ips unless hide_server_ips is enabled
723 <       */
724 <      if (!ConfigServerHide.hide_server_ips && HasUMode(source_p, UMODE_ADMIN))
725 <        sendto_one(source_p, form_str(RPL_STATSCLINE),
726 <                   me.name, source_p->name, 'C', aconf->host,
727 <                   buf, conf->name, aconf->port,
728 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
729 <        else
730 <          sendto_one(source_p, form_str(RPL_STATSCLINE),
731 <                     me.name, source_p->name, 'C',
732 <                     "*@127.0.0.1", buf, conf->name, aconf->port,
733 <                     aconf->class_ptr ? aconf->class_ptr->name : "<default>");
734 <    }
735 <    break;
736 <
737 <  case HUB_TYPE:
738 <    DLINK_FOREACH(ptr, server_items.head)
739 <    {
740 <      conf = ptr->data;
741 <      aconf = map_to_conf(conf);
742 <
743 <      DLINK_FOREACH(dptr, aconf->hub_list.head)
744 <        sendto_one(source_p, form_str(RPL_STATSHLINE), me.name,
745 <                   source_p->name, 'H', dptr->data, conf->name, 0, "*");
746 <    }
747 <    break;
748 <
749 <  case LEAF_TYPE:
750 <    DLINK_FOREACH(ptr, server_items.head)
751 <    {
752 <      conf = ptr->data;
753 <      aconf = map_to_conf(conf);
203 >    MyFree(ptr->data);
204 >    dlinkDelete(ptr, &conf->leaf_list);
205 >    free_dlink_node(ptr);
206 >  }
207  
208 <      DLINK_FOREACH(dptr, aconf->leaf_list.head)
209 <        sendto_one(source_p, form_str(RPL_STATSLLINE), me.name,
210 <                   source_p->name, 'L', dptr->data, conf->name, 0, "*");
758 <    }
759 <    break;
208 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->exempt_list.head)
209 >  {
210 >    struct exempt *exptr = ptr->data;
211  
212 <  case GLINE_TYPE:
213 <  case KLINE_TYPE:
214 <  case DLINE_TYPE:
215 <  case EXEMPTDLINE_TYPE:
216 <  case CRESV_TYPE:
766 <  case NRESV_TYPE:
767 <  case CLUSTER_TYPE:
768 <  default:
769 <    break;
212 >    dlinkDelete(ptr, &conf->exempt_list);
213 >    MyFree(exptr->name);
214 >    MyFree(exptr->user);
215 >    MyFree(exptr->host);
216 >    MyFree(exptr);
217    }
218 +
219 +  MyFree(conf);
220   }
221  
222   /* check_client()
# Line 783 | Line 232 | report_confitem_types(struct Client *sou
232   *                Look for conf lines which have the same
233   *                status as the flags passed.
234   */
235 < static void *
236 < check_client(va_list args)
235 > int
236 > check_client(struct Client *source_p)
237   {
789 –  struct Client *source_p = va_arg(args, struct Client *);
790 –  const char *username = va_arg(args, const char *);
238    int i;
239 <
240 <  /* I'm already in big trouble if source_p->localClient is NULL -db */
241 <  if ((i = verify_access(source_p, username)))
795 <    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
239 >
240 >  if ((i = verify_access(source_p)))
241 >    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
242           source_p->name, source_p->sockhost);
243  
244    switch (i)
245    {
246      case TOO_MANY:
247 <      sendto_realops_flags(UMODE_FULL, L_ALL,
247 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
248                             "Too many on IP for %s (%s).",
249 <                           get_client_name(source_p, SHOW_IP),
250 <                           source_p->sockhost);
249 >                           get_client_name(source_p, SHOW_IP),
250 >                           source_p->sockhost);
251        ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
252 <           get_client_name(source_p, SHOW_IP));
252 >           get_client_name(source_p, SHOW_IP));
253        ++ServerStats.is_ref;
254 <      exit_client(source_p, &me, "No more connections allowed on that IP");
254 >      exit_client(source_p, "No more connections allowed on that IP");
255        break;
256  
257      case I_LINE_FULL:
258 <      sendto_realops_flags(UMODE_FULL, L_ALL,
259 <                           "I-line is full for %s (%s).",
260 <                           get_client_name(source_p, SHOW_IP),
261 <                           source_p->sockhost);
258 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
259 >                           "auth{} block is full for %s (%s).",
260 >                           get_client_name(source_p, SHOW_IP),
261 >                           source_p->sockhost);
262        ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
263 <           get_client_name(source_p, SHOW_IP));
263 >           get_client_name(source_p, SHOW_IP));
264        ++ServerStats.is_ref;
265 <      exit_client(source_p, &me,
820 <                "No more connections allowed in your connection class");
265 >      exit_client(source_p, "No more connections allowed in your connection class");
266        break;
267  
268      case NOT_AUTHORIZED:
269        ++ServerStats.is_ref;
270        /* jdc - lists server name & port connections are on */
271        /*       a purely cosmetical change */
272 <      sendto_realops_flags(UMODE_UNAUTH, L_ALL,
273 <                           "Unauthorized client connection from %s [%s] on [%s/%u].",
274 <                           get_client_name(source_p, SHOW_IP),
275 <                           source_p->sockhost,
276 <                           source_p->localClient->listener->name,
277 <                           source_p->localClient->listener->port);
272 >      sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
273 >                           "Unauthorized client connection from %s [%s] on [%s/%u].",
274 >                           get_client_name(source_p, SHOW_IP),
275 >                           source_p->sockhost,
276 >                           source_p->localClient->listener->name,
277 >                           source_p->localClient->listener->port);
278        ilog(LOG_TYPE_IRCD,
279 <          "Unauthorized client connection from %s on [%s/%u].",
280 <          get_client_name(source_p, SHOW_IP),
281 <          source_p->localClient->listener->name,
282 <          source_p->localClient->listener->port);
283 <
284 <      /* XXX It is prolematical whether it is better to use the
840 <       * capture reject code here or rely on the connecting too fast code.
841 <       * - Dianora
842 <       */
843 <      if (REJECT_HOLD_TIME > 0)
844 <      {
845 <        sendto_one(source_p, ":%s NOTICE %s :You are not authorized to use this server",
846 <                   me.name, source_p->name);
847 <        source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
848 <        SetCaptured(source_p);
849 <      }
850 <      else
851 <        exit_client(source_p, &me, "You are not authorized to use this server");
279 >           "Unauthorized client connection from %s on [%s/%u].",
280 >           get_client_name(source_p, SHOW_IP),
281 >           source_p->localClient->listener->name,
282 >           source_p->localClient->listener->port);
283 >
284 >      exit_client(source_p, "You are not authorized to use this server");
285        break;
286  
287     case BANNED_CLIENT:
288 <     /*
856 <      * Don't exit them immediately, play with them a bit.
857 <      * - Dianora
858 <      */
859 <     if (REJECT_HOLD_TIME > 0)
860 <     {
861 <       source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
862 <       SetCaptured(source_p);
863 <     }
864 <     else
865 <       exit_client(source_p, &me, "Banned");
288 >     exit_client(source_p, "Banned");
289       ++ServerStats.is_ref;
290       break;
291  
# Line 871 | Line 294 | check_client(va_list args)
294       break;
295    }
296  
297 <  return (i < 0 ? NULL : source_p);
297 >  return (i < 0 ? 0 : 1);
298   }
299  
300   /* verify_access()
301   *
302   * inputs       - pointer to client to verify
880 – *              - pointer to proposed username
303   * output       - 0 if success -'ve if not
304   * side effect  - find the first (best) I line to attach.
305   */
306   static int
307 < verify_access(struct Client *client_p, const char *username)
307 > verify_access(struct Client *client_p)
308   {
309 <  struct AccessItem *aconf = NULL, *rkconf = NULL;
310 <  struct ConfItem *conf = NULL;
889 <  char non_ident[USERLEN + 1] = { '~', '\0' };
890 <  const char *uhi[3];
309 >  struct MaskItem *conf = NULL;
310 >  char non_ident[USERLEN + 1] = "~";
311  
312    if (IsGotId(client_p))
313    {
314 <    aconf = find_address_conf(client_p->host, client_p->username,
315 <                             &client_p->localClient->ip,
316 <                             client_p->localClient->aftype,
314 >    conf = find_address_conf(client_p->host, client_p->username,
315 >                             &client_p->localClient->ip,
316 >                             client_p->localClient->aftype,
317                               client_p->localClient->passwd);
318    }
319    else
320    {
321 <    strlcpy(non_ident+1, username, sizeof(non_ident)-1);
322 <    aconf = find_address_conf(client_p->host,non_ident,
323 <                             &client_p->localClient->ip,
324 <                             client_p->localClient->aftype,
325 <                             client_p->localClient->passwd);
321 >    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
322 >    conf = find_address_conf(client_p->host,non_ident,
323 >                             &client_p->localClient->ip,
324 >                             client_p->localClient->aftype,
325 >                             client_p->localClient->passwd);
326    }
327  
328 <  uhi[0] = IsGotId(client_p) ? client_p->username : non_ident;
909 <  uhi[1] = client_p->host;
910 <  uhi[2] = client_p->sockhost;
911 <
912 <  rkconf = find_regexp_kline(uhi);
913 <
914 <  if (aconf != NULL)
328 >  if (conf)
329    {
330 <    if (IsConfClient(aconf) && !rkconf)
330 >    if (IsConfClient(conf))
331      {
332 <      conf = unmap_conf_item(aconf);
919 <
920 <      if (IsConfRedir(aconf))
332 >      if (IsConfRedir(conf))
333        {
334 <        sendto_one(client_p, form_str(RPL_REDIR),
335 <                   me.name, client_p->name,
336 <                   conf->name ? conf->name : "",
337 <                   aconf->port);
926 <        return(NOT_AUTHORIZED);
334 >        sendto_one_numeric(client_p, &me, RPL_REDIR,
335 >                           conf->name ? conf->name : "",
336 >                           conf->port);
337 >        return NOT_AUTHORIZED;
338        }
339  
340 <      if (IsConfDoIdentd(aconf))
341 <        SetNeedId(client_p);
340 >      if (IsConfDoIdentd(conf))
341 >        SetNeedId(client_p);
342  
343        /* Thanks for spoof idea amm */
344 <      if (IsConfDoSpoofIp(aconf))
344 >      if (IsConfDoSpoofIp(conf))
345        {
346 <        conf = unmap_conf_item(aconf);
347 <
348 <        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(aconf))
938 <          sendto_realops_flags(UMODE_ALL, L_ADMIN, "%s spoofing: %s as %s",
346 >        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
347 >          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
348 >                               "%s spoofing: %s as %s",
349                                 client_p->name, client_p->host, conf->name);
350          strlcpy(client_p->host, conf->name, sizeof(client_p->host));
351 <        SetIPSpoof(client_p);
351 >        AddFlag(client_p, FLAGS_IP_SPOOFING | FLAGS_AUTH_SPOOF);
352        }
353  
354 <      return(attach_iline(client_p, conf));
354 >      return attach_iline(client_p, conf);
355      }
356 <    else if (rkconf || IsConfKill(aconf) || (ConfigFileEntry.glines && IsConfGline(aconf)))
356 >    else if (IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
357      {
358 <      /* XXX */
359 <      aconf = rkconf ? rkconf : aconf;
360 <      if (IsConfGline(aconf))
361 <        sendto_one(client_p, ":%s NOTICE %s :*** G-lined", me.name,
952 <                   client_p->name);
953 <      if (ConfigFileEntry.kline_with_reason)
954 <        sendto_one(client_p, ":%s NOTICE %s :*** Banned %s",
955 <                  me.name, client_p->name, aconf->reason);
956 <      return(BANNED_CLIENT);
358 >      if (IsConfGline(conf))
359 >        sendto_one_notice(client_p, &me, ":*** G-lined");
360 >      sendto_one_notice(client_p, &me, ":*** Banned: %s", conf->reason);
361 >      return BANNED_CLIENT;
362      }
363    }
364  
365 <  return(NOT_AUTHORIZED);
365 >  return NOT_AUTHORIZED;
366   }
367  
368   /* attach_iline()
# Line 968 | Line 373 | verify_access(struct Client *client_p, c
373   * side effects - do actual attach
374   */
375   static int
376 < attach_iline(struct Client *client_p, struct ConfItem *conf)
376 > attach_iline(struct Client *client_p, struct MaskItem *conf)
377   {
378 <  struct AccessItem *aconf;
974 <  struct ClassItem *aclass;
378 >  struct ClassItem *class = NULL;
379    struct ip_entry *ip_found;
380    int a_limit_reached = 0;
381 <  int local = 0, global = 0, ident = 0;
381 >  unsigned int local = 0, global = 0, ident = 0;
382 >
383 >  assert(conf->class);
384  
385    ip_found = find_or_add_ip(&client_p->localClient->ip);
386    ip_found->count++;
387    SetIpHash(client_p);
388  
389 <  aconf = map_to_conf(conf);
984 <  if (aconf->class_ptr == NULL)
985 <    return NOT_AUTHORIZED;  /* If class is missing, this is best */
986 <
987 <  aclass = map_to_conf(aconf->class_ptr);
389 >  class = conf->class;
390  
391    count_user_host(client_p->username, client_p->host,
392                    &global, &local, &ident);
# Line 993 | Line 395 | attach_iline(struct Client *client_p, st
395     * setting a_limit_reached if any limit is reached.
396     * - Dianora
397     */
398 <  if (aclass->max_total != 0 && aclass->curr_user_count >= aclass->max_total)
398 >  if (class->max_total && class->ref_count >= class->max_total)
399      a_limit_reached = 1;
400 <  else if (aclass->max_perip != 0 && ip_found->count > aclass->max_perip)
400 >  else if (class->max_perip && ip_found->count > class->max_perip)
401      a_limit_reached = 1;
402 <  else if (aclass->max_local != 0 && local >= aclass->max_local)
402 >  else if (class->max_local && local >= class->max_local)
403      a_limit_reached = 1;
404 <  else if (aclass->max_global != 0 && global >= aclass->max_global)
404 >  else if (class->max_global && global >= class->max_global)
405      a_limit_reached = 1;
406 <  else if (aclass->max_ident != 0 && ident >= aclass->max_ident &&
406 >  else if (class->max_ident && ident >= class->max_ident &&
407             client_p->username[0] != '~')
408      a_limit_reached = 1;
409  
410    if (a_limit_reached)
411    {
412 <    if (!IsConfExemptLimits(aconf))
412 >    if (!IsConfExemptLimits(conf))
413        return TOO_MANY;   /* Already at maximum allowed */
414  
415 <    sendto_one(client_p,
416 <               ":%s NOTICE %s :*** Your connection class is full, "
1015 <               "but you have exceed_limit = yes;", me.name, client_p->name);
415 >    sendto_one_notice(client_p, &me, ":*** Your connection class is full, "
416 >                      "but you have exceed_limit = yes;");
417    }
418  
419    return attach_conf(client_p, conf);
# Line 1028 | Line 429 | attach_iline(struct Client *client_p, st
429   void
430   init_ip_hash_table(void)
431   {
432 <  ip_entry_heap = BlockHeapCreate("ip", sizeof(struct ip_entry),
1032 <    2 * hard_fdlimit);
432 >  ip_entry_pool = mp_pool_new(sizeof(struct ip_entry), MP_CHUNK_SIZE_IP_ENTRY);
433    memset(ip_hash_table, 0, sizeof(ip_hash_table));
434   }
435  
# Line 1078 | Line 478 | find_or_add_ip(struct irc_ssaddr *ip_in)
478    if (ip_entries_count >= 2 * hard_fdlimit)
479      garbage_collect_ip_entries();
480  
481 <  newptr = BlockHeapAlloc(ip_entry_heap);
481 >  newptr = mp_pool_get(ip_entry_pool);
482 >
483    ip_entries_count++;
484    memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
485  
# Line 1129 | Line 530 | remove_one_ip(struct irc_ssaddr *ip_in)
530      if (ptr->count > 0)
531        ptr->count--;
532      if (ptr->count == 0 &&
533 <        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
533 >        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
534      {
535        if (last_ptr != NULL)
536 <        last_ptr->next = ptr->next;
536 >        last_ptr->next = ptr->next;
537        else
538 <        ip_hash_table[hash_index] = ptr->next;
538 >        ip_hash_table[hash_index] = ptr->next;
539  
540 <      BlockHeapFree(ip_entry_heap, ptr);
540 >      mp_pool_release(ptr);
541        ip_entries_count--;
542        return;
543      }
# Line 1171 | Line 572 | hash_ip(struct irc_ssaddr *addr)
572      uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
573  
574      hash  = ip[0] ^ ip[3];
575 <    hash ^= hash >> 16;  
576 <    hash ^= hash >> 8;  
575 >    hash ^= hash >> 16;
576 >    hash ^= hash >> 8;
577      hash  = hash & (IP_HASH_SIZE - 1);
578      return hash;
579    }
# Line 1183 | Line 584 | hash_ip(struct irc_ssaddr *addr)
584  
585   /* count_ip_hash()
586   *
587 < * inputs        - pointer to counter of number of ips hashed
587 > * inputs        - pointer to counter of number of ips hashed
588   *               - pointer to memory used for ip hash
589   * output        - returned via pointers input
590   * side effects  - NONE
# Line 1195 | Line 596 | void
596   count_ip_hash(unsigned int *number_ips_stored, uint64_t *mem_ips_stored)
597   {
598    struct ip_entry *ptr;
1198 –  int i;
599  
600    *number_ips_stored = 0;
601    *mem_ips_stored    = 0;
602  
603 <  for (i = 0; i < IP_HASH_SIZE; i++)
603 >  for (unsigned int i = 0; i < IP_HASH_SIZE; ++i)
604    {
605      for (ptr = ip_hash_table[i]; ptr; ptr = ptr->next)
606      {
# Line 1222 | Line 622 | garbage_collect_ip_entries(void)
622    struct ip_entry *ptr;
623    struct ip_entry *last_ptr;
624    struct ip_entry *next_ptr;
1225 –  int i;
625  
626 <  for (i = 0; i < IP_HASH_SIZE; i++)
626 >  for (unsigned int i = 0; i < IP_HASH_SIZE; ++i)
627    {
628      last_ptr = NULL;
629  
# Line 1239 | Line 638 | garbage_collect_ip_entries(void)
638            last_ptr->next = ptr->next;
639          else
640            ip_hash_table[i] = ptr->next;
641 <        BlockHeapFree(ip_entry_heap, ptr);
641 >        mp_pool_release(ptr);
642          ip_entries_count--;
643        }
644        else
# Line 1256 | Line 655 | garbage_collect_ip_entries(void)
655   * side effects - Disassociate configuration from the client.
656   *                Also removes a class from the list if marked for deleting.
657   */
658 < int
659 < detach_conf(struct Client *client_p, ConfType type)
658 > void
659 > detach_conf(struct Client *client_p, enum maskitem_type type)
660   {
661 <  dlink_node *ptr, *next_ptr;
1263 <  struct ConfItem *conf;
1264 <  struct ClassItem *aclass;
1265 <  struct AccessItem *aconf;
1266 <  struct ConfItem *aclass_conf;
1267 <  struct MatchItem *match_item;
661 >  dlink_node *ptr = NULL, *ptr_next = NULL;
662  
663 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->localClient->confs.head)
663 >  DLINK_FOREACH_SAFE(ptr, ptr_next, client_p->localClient->confs.head)
664    {
665 <    conf = ptr->data;
1272 <
1273 <    if (type == CONF_TYPE || conf->type == type)
1274 <    {
1275 <      dlinkDelete(ptr, &client_p->localClient->confs);
1276 <      free_dlink_node(ptr);
1277 <
1278 <      switch (conf->type)
1279 <      {
1280 <      case CLIENT_TYPE:
1281 <      case OPER_TYPE:
1282 <      case SERVER_TYPE:
1283 <        aconf = map_to_conf(conf);
1284 <
1285 <        assert(aconf->clients > 0);
1286 <
1287 <        if ((aclass_conf = aconf->class_ptr) != NULL)
1288 <        {
1289 <          aclass = map_to_conf(aclass_conf);
665 >    struct MaskItem *conf = ptr->data;
666  
667 <          assert(aclass->curr_user_count > 0);
667 >    assert(conf->type & (CONF_CLIENT | CONF_OPER | CONF_SERVER));
668 >    assert(conf->ref_count > 0);
669 >    assert(conf->class->ref_count > 0);
670  
671 <          if (conf->type == CLIENT_TYPE)
672 <            remove_from_cidr_check(&client_p->localClient->ip, aclass);
1295 <          if (--aclass->curr_user_count == 0 && aclass->active == 0)
1296 <            delete_conf_item(aclass_conf);
1297 <        }
671 >    if (!(conf->type & type))
672 >      continue;
673  
674 <        if (--aconf->clients == 0 && IsConfIllegal(aconf))
675 <          delete_conf_item(conf);
674 >    dlinkDelete(ptr, &client_p->localClient->confs);
675 >    free_dlink_node(ptr);
676  
677 <        break;
678 <      default:
1304 <        break;
1305 <      }
677 >    if (conf->type == CONF_CLIENT)
678 >      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
679  
680 <      if (type != CONF_TYPE)
681 <        return 0;
680 >    if (--conf->class->ref_count == 0 && conf->class->active == 0)
681 >    {
682 >      class_free(conf->class);
683 >      conf->class = NULL;
684      }
1310 –  }
685  
686 <  return -1;
686 >    if (--conf->ref_count == 0 && conf->active == 0)
687 >      conf_free(conf);
688 >  }
689   }
690  
691   /* attach_conf()
# Line 1323 | Line 699 | detach_conf(struct Client *client_p, Con
699   *                attachment if there was an old one...
700   */
701   int
702 < attach_conf(struct Client *client_p, struct ConfItem *conf)
702 > attach_conf(struct Client *client_p, struct MaskItem *conf)
703   {
704 <  if (dlinkFind(&client_p->localClient->confs, conf) != NULL)
704 >  if (dlinkFind(&client_p->localClient->confs, conf))
705      return 1;
706  
707 <  if (conf->type == CLIENT_TYPE ||
708 <      conf->type == SERVER_TYPE ||
709 <      conf->type == OPER_TYPE)
710 <  {
1335 <    struct AccessItem *aconf = map_to_conf(conf);
1336 <    struct ClassItem *aclass = map_to_conf(aconf->class_ptr);
1337 <
1338 <    if (IsConfIllegal(aconf))
1339 <      return NOT_AUTHORIZED;
1340 <
1341 <    if (conf->type == CLIENT_TYPE)
1342 <      if (cidr_limit_reached(IsConfExemptLimits(aconf),
1343 <                             &client_p->localClient->ip, aclass))
1344 <        return TOO_MANY;    /* Already at maximum allowed */
707 >  if (conf->type == CONF_CLIENT)
708 >    if (cidr_limit_reached(IsConfExemptLimits(conf),
709 >                           &client_p->localClient->ip, conf->class))
710 >      return TOO_MANY;    /* Already at maximum allowed */
711  
712 <    aclass->curr_user_count++;
713 <    aconf->clients++;
1348 <  }
712 >  conf->class->ref_count++;
713 >  conf->ref_count++;
714  
715    dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
716  
# Line 1365 | Line 730 | attach_connect_block(struct Client *clie
730                       const char *host)
731   {
732    dlink_node *ptr;
733 <  struct ConfItem *conf;
1369 <  struct AccessItem *aconf;
733 >  struct MaskItem *conf = NULL;
734  
735    assert(client_p != NULL);
736    assert(host != NULL);
# Line 1377 | Line 741 | attach_connect_block(struct Client *clie
741    DLINK_FOREACH(ptr, server_items.head)
742    {
743      conf = ptr->data;
1380 –    aconf = map_to_conf(conf);
744  
745 <    if (match(conf->name, name) == 0 || match(aconf->host, host) == 0)
745 >    if (match(conf->name, name) || match(conf->host, host))
746        continue;
747  
748      attach_conf(client_p, conf);
# Line 1389 | Line 752 | attach_connect_block(struct Client *clie
752    return 0;
753   }
754  
1392 – /* find_conf_exact()
1393 – *
1394 – * inputs       - type of ConfItem
1395 – *              - pointer to name to find
1396 – *              - pointer to username to find
1397 – *              - pointer to host to find
1398 – * output       - NULL or pointer to conf found
1399 – * side effects - find a conf entry which matches the hostname
1400 – *                and has the same name.
1401 – */
1402 – struct ConfItem *
1403 – find_conf_exact(ConfType type, const char *name, const char *user,
1404 –                const char *host)
1405 – {
1406 –  dlink_node *ptr;
1407 –  dlink_list *list_p;
1408 –  struct ConfItem *conf = NULL;
1409 –  struct AccessItem *aconf;
1410 –
1411 –  /* Only valid for OPER_TYPE and ...? */
1412 –  list_p = map_to_list(type);
1413 –
1414 –  DLINK_FOREACH(ptr, (*list_p).head)
1415 –  {
1416 –    conf = ptr->data;
1417 –
1418 –    if (conf->name == NULL)
1419 –      continue;
1420 –    aconf = map_to_conf(conf);
1421 –    if (aconf->host == NULL)
1422 –      continue;
1423 –    if (irccmp(conf->name, name) != 0)
1424 –      continue;
1425 –
1426 –    /*
1427 –    ** Accept if the *real* hostname (usually sockethost)
1428 –    ** socket host) matches *either* host or name field
1429 –    ** of the configuration.
1430 –    */
1431 –    if (!match(aconf->host, host) || !match(aconf->user, user))
1432 –      continue;
1433 –    if (type == OPER_TYPE)
1434 –    {
1435 –      struct ClassItem *aclass = map_to_conf(aconf->class_ptr);
1436 –
1437 –      if (aconf->clients >= aclass->max_total)
1438 –        continue;
1439 –    }
1440 –
1441 –    return conf;
1442 –  }
1443 –
1444 –  return NULL;
1445 – }
1446 –
755   /* find_conf_name()
756   *
757   * inputs       - pointer to conf link list to search
# Line 1453 | Line 761 | find_conf_exact(ConfType type, const cha
761   * side effects - find a conf entry which matches the name
762   *                and has the given mask.
763   */
764 < struct ConfItem *
765 < find_conf_name(dlink_list *list, const char *name, ConfType type)
764 > struct MaskItem *
765 > find_conf_name(dlink_list *list, const char *name, enum maskitem_type type)
766   {
767    dlink_node *ptr;
768 <  struct ConfItem* conf;
768 >  struct MaskItem* conf;
769  
770    DLINK_FOREACH(ptr, list->head)
771    {
772      conf = ptr->data;
773 <    
773 >
774      if (conf->type == type)
775      {
776 <      if (conf->name && (irccmp(conf->name, name) == 0 ||
777 <                         match(conf->name, name)))
776 >      if (conf->name && (!irccmp(conf->name, name) ||
777 >                         !match(conf->name, name)))
778        return conf;
779      }
780    }
# Line 1481 | Line 789 | find_conf_name(dlink_list *list, const c
789   * side effects - none
790   */
791   static dlink_list *
792 < map_to_list(ConfType type)
792 > map_to_list(enum maskitem_type type)
793   {
794    switch(type)
795    {
796 <  case RXLINE_TYPE:
1489 <    return(&rxconf_items);
1490 <    break;
1491 <  case XLINE_TYPE:
796 >  case CONF_XLINE:
797      return(&xconf_items);
798      break;
799 <  case ULINE_TYPE:
799 >  case CONF_ULINE:
800      return(&uconf_items);
801      break;
802 <  case NRESV_TYPE:
802 >  case CONF_NRESV:
803      return(&nresv_items);
804      break;
805 <  case OPER_TYPE:
805 >  case CONF_CRESV:
806 >    return(&cresv_items);
807 >  case CONF_OPER:
808      return(&oconf_items);
809      break;
810 <  case CLASS_TYPE:
1504 <    return(&class_items);
1505 <    break;
1506 <  case SERVER_TYPE:
810 >  case CONF_SERVER:
811      return(&server_items);
812      break;
813 <  case SERVICE_TYPE:
813 >  case CONF_SERVICE:
814      return(&service_items);
815      break;
816 <  case CLUSTER_TYPE:
816 >  case CONF_CLUSTER:
817      return(&cluster_items);
818      break;
1515 –  case CONF_TYPE:
1516 –  case GLINE_TYPE:
1517 –  case KLINE_TYPE:
1518 –  case DLINE_TYPE:
1519 –  case CRESV_TYPE:
819    default:
820      return NULL;
821    }
# Line 1528 | Line 827 | map_to_list(ConfType type)
827   *              - pointer to name string to find
828   *              - pointer to user
829   *              - pointer to host
830 < *              - optional action to match on as well
831 < * output       - NULL or pointer to found struct MatchItem
830 > *              - optional flags to match on as well
831 > * output       - NULL or pointer to found struct MaskItem
832   * side effects - looks for a match on name field
833   */
834 < struct ConfItem *
835 < find_matching_name_conf(ConfType type, const char *name, const char *user,
836 <                        const char *host, int action)
834 > struct MaskItem *
835 > find_matching_name_conf(enum maskitem_type type, const char *name, const char *user,
836 >                        const char *host, unsigned int flags)
837   {
838    dlink_node *ptr=NULL;
839 <  struct ConfItem *conf=NULL;
1541 <  struct AccessItem *aconf=NULL;
1542 <  struct MatchItem *match_item=NULL;
839 >  struct MaskItem *conf=NULL;
840    dlink_list *list_p = map_to_list(type);
841  
842    switch (type)
843    {
844 < #ifdef HAVE_LIBPCRE
1548 <  case RXLINE_TYPE:
1549 <      DLINK_FOREACH(ptr, list_p->head)
1550 <      {
1551 <        conf = ptr->data;
1552 <        assert(conf->regexpname);
1553 <
1554 <        if (!ircd_pcre_exec(conf->regexpname, name))
1555 <          return conf;
1556 <      }
1557 <      break;
1558 < #endif
1559 <  case SERVICE_TYPE:
844 >  case CONF_SERVICE:
845      DLINK_FOREACH(ptr, list_p->head)
846      {
847        conf = ptr->data;
# Line 1568 | Line 853 | find_matching_name_conf(ConfType type, c
853      }
854      break;
855  
856 <  case XLINE_TYPE:
857 <  case ULINE_TYPE:
858 <  case NRESV_TYPE:
856 >  case CONF_XLINE:
857 >  case CONF_ULINE:
858 >  case CONF_NRESV:
859 >  case CONF_CRESV:
860      DLINK_FOREACH(ptr, list_p->head)
861      {
862        conf = ptr->data;
863  
1578 –      match_item = map_to_conf(conf);
864        if (EmptyString(conf->name))
865 <        continue;
866 <      if ((name != NULL) && match_esc(conf->name, name))
865 >        continue;
866 >      if ((name != NULL) && !match(conf->name, name))
867        {
868 <        if ((user == NULL && (host == NULL)))
869 <          return conf;
870 <        if ((match_item->action & action) != action)
868 >        if ((user == NULL && (host == NULL)))
869 >          return conf;
870 >        if ((conf->flags & flags) != flags)
871            continue;
872 <        if (EmptyString(match_item->user) || EmptyString(match_item->host))
873 <          return conf;
874 <        if (match(match_item->user, user) && match(match_item->host, host))
875 <          return conf;
872 >        if (EmptyString(conf->user) || EmptyString(conf->host))
873 >          return conf;
874 >        if (!match(conf->user, user) && !match(conf->host, host))
875 >          return conf;
876        }
877      }
878        break;
879  
880 <  case SERVER_TYPE:
880 >  case CONF_SERVER:
881      DLINK_FOREACH(ptr, list_p->head)
882      {
883        conf = ptr->data;
1599 –      aconf = map_to_conf(conf);
884  
885 <      if ((name != NULL) && match_esc(name, conf->name))
885 >      if ((name != NULL) && !match(name, conf->name))
886          return conf;
887 <      else if ((host != NULL) && match_esc(host, aconf->host))
887 >      else if ((host != NULL) && !match(host, conf->host))
888          return conf;
889      }
890      break;
891 <  
891 >
892    default:
893      break;
894    }
# Line 1617 | Line 901 | find_matching_name_conf(ConfType type, c
901   *              - pointer to name string to find
902   *              - pointer to user
903   *              - pointer to host
904 < * output       - NULL or pointer to found struct MatchItem
904 > * output       - NULL or pointer to found struct MaskItem
905   * side effects - looks for an exact match on name field
906   */
907 < struct ConfItem *
908 < find_exact_name_conf(ConfType type, const struct Client *who, const char *name,
907 > struct MaskItem *
908 > find_exact_name_conf(enum maskitem_type type, const struct Client *who, const char *name,
909                       const char *user, const char *host)
910   {
911    dlink_node *ptr = NULL;
912 <  struct AccessItem *aconf;
913 <  struct ConfItem *conf;
1630 <  struct MatchItem *match_item;
1631 <  dlink_list *list_p;
1632 <
1633 <  list_p = map_to_list(type);
912 >  struct MaskItem *conf;
913 >  dlink_list *list_p = map_to_list(type);
914  
915    switch(type)
916    {
917 <  case RXLINE_TYPE:
918 <  case XLINE_TYPE:
919 <  case ULINE_TYPE:
920 <  case NRESV_TYPE:
917 >  case CONF_XLINE:
918 >  case CONF_ULINE:
919 >  case CONF_NRESV:
920 >  case CONF_CRESV:
921  
922      DLINK_FOREACH(ptr, list_p->head)
923      {
924        conf = ptr->data;
925 <      match_item = (struct MatchItem *)map_to_conf(conf);
925 >
926        if (EmptyString(conf->name))
927 <        continue;
928 <    
927 >        continue;
928 >
929        if (irccmp(conf->name, name) == 0)
930        {
931 <        if ((user == NULL && (host == NULL)))
932 <          return (conf);
933 <        if (EmptyString(match_item->user) || EmptyString(match_item->host))
934 <          return (conf);
935 <        if (match(match_item->user, user) && match(match_item->host, host))
936 <          return (conf);
931 >        if ((user == NULL && (host == NULL)))
932 >          return conf;
933 >        if (EmptyString(conf->user) || EmptyString(conf->host))
934 >          return conf;
935 >        if (!match(conf->user, user) && !match(conf->host, host))
936 >          return conf;
937        }
938      }
939      break;
940  
941 <  case OPER_TYPE:
941 >  case CONF_OPER:
942      DLINK_FOREACH(ptr, list_p->head)
943      {
944        conf = ptr->data;
1665 –      aconf = map_to_conf(conf);
945  
946        if (EmptyString(conf->name))
947          continue;
# Line 1671 | Line 950 | find_exact_name_conf(ConfType type, cons
950        {
951          if (!who)
952            return conf;
953 <        if (EmptyString(aconf->user) || EmptyString(aconf->host))
954 <          return conf;
955 <        if (match(aconf->user, who->username))
953 >        if (EmptyString(conf->user) || EmptyString(conf->host))
954 >          return NULL;
955 >        if (!match(conf->user, who->username))
956          {
957 <          switch (aconf->type)
957 >          switch (conf->htype)
958            {
959              case HM_HOST:
960 <              if (match(aconf->host, who->host) || match(aconf->host, who->sockhost))
961 <                return conf;
960 >              if (!match(conf->host, who->host) || !match(conf->host, who->sockhost))
961 >                if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
962 >                  return conf;
963                break;
964              case HM_IPV4:
965                if (who->localClient->aftype == AF_INET)
966 <                if (match_ipv4(&who->localClient->ip, &aconf->addr, aconf->bits))
967 <                  return conf;
966 >                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
967 >                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
968 >                    return conf;
969                break;
970   #ifdef IPV6
971              case HM_IPV6:
972                if (who->localClient->aftype == AF_INET6)
973 <                if (match_ipv6(&who->localClient->ip, &aconf->addr, aconf->bits))
974 <                  return conf;
973 >                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
974 >                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
975 >                    return conf;
976                break;
977   #endif
978              default:
# Line 1702 | Line 984 | find_exact_name_conf(ConfType type, cons
984  
985      break;
986  
987 <  case SERVER_TYPE:
987 >  case CONF_SERVER:
988      DLINK_FOREACH(ptr, list_p->head)
989      {
990        conf = ptr->data;
991 <      aconf = (struct AccessItem *)map_to_conf(conf);
991 >
992        if (EmptyString(conf->name))
993 <        continue;
994 <    
993 >        continue;
994 >
995        if (name == NULL)
996        {
997 <        if (EmptyString(aconf->host))
998 <          continue;
999 <        if (irccmp(aconf->host, host) == 0)
1000 <          return(conf);
997 >        if (EmptyString(conf->host))
998 >          continue;
999 >        if (irccmp(conf->host, host) == 0)
1000 >          return conf;
1001        }
1002        else if (irccmp(conf->name, name) == 0)
1003 <      {
1722 <          return (conf);
1723 <      }
1003 >        return conf;
1004      }
1725 –    break;
1005  
1727 –  case CLASS_TYPE:
1728 –    DLINK_FOREACH(ptr, list_p->head)
1729 –    {
1730 –      conf = ptr->data;
1731 –      if (EmptyString(conf->name))
1732 –        continue;
1733 –    
1734 –      if (irccmp(conf->name, name) == 0)
1735 –        return (conf);
1736 –    }
1006      break;
1007  
1008    default:
1009      break;
1010    }
1011 <  return(NULL);
1011 >
1012 >  return NULL;
1013   }
1014  
1015   /* rehash()
# Line 1751 | Line 1021 | find_exact_name_conf(ConfType type, cons
1021   int
1022   rehash(int sig)
1023   {
1024 <  if (sig != 0)
1025 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1026 <                         "Got signal SIGHUP, reloading ircd.conf file");
1024 >  if (sig)
1025 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1026 >                         "Got signal SIGHUP, reloading configuration file(s)");
1027  
1028    restart_resolver();
1029  
# Line 1764 | Line 1034 | rehash(int sig)
1034  
1035    read_conf_files(0);
1036  
1037 <  if (ServerInfo.description != NULL)
1037 >  if (ServerInfo.description)
1038      strlcpy(me.info, ServerInfo.description, sizeof(me.info));
1039  
1040    load_conf_modules();
1041 +  check_conf_klines();
1042  
1043 <  flush_deleted_I_P();
1773 <
1774 <  rehashed_klines = 1;
1775 < /* XXX */
1776 <  if (ConfigLoggingEntry.use_logging)
1777 <    log_close_all();
1778 <
1779 <  return(0);
1043 >  return 0;
1044   }
1045  
1046   /* set_default_conf()
# Line 1794 | Line 1058 | set_default_conf(void)
1058    /* verify init_class() ran, this should be an unnecessary check
1059     * but its not much work.
1060     */
1061 <  assert(class_default == (struct ConfItem *) class_items.tail->data);
1061 >  assert(class_default == class_get_list()->tail->data);
1062  
1063   #ifdef HAVE_LIBCRYPTO
1064 +  ServerInfo.message_digest_algorithm = EVP_sha256();
1065    ServerInfo.rsa_private_key = NULL;
1066    ServerInfo.rsa_private_key_file = NULL;
1067   #endif
# Line 1804 | Line 1069 | set_default_conf(void)
1069    /* ServerInfo.name is not rehashable */
1070    /* ServerInfo.name = ServerInfo.name; */
1071    ServerInfo.description = NULL;
1072 <  DupString(ServerInfo.network_name, NETWORK_NAME_DEFAULT);
1073 <  DupString(ServerInfo.network_desc, NETWORK_DESC_DEFAULT);
1072 >  ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1073 >  ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1074  
1075    memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
1076    ServerInfo.specific_ipv4_vhost = 0;
# Line 1813 | Line 1078 | set_default_conf(void)
1078    ServerInfo.specific_ipv6_vhost = 0;
1079  
1080    ServerInfo.max_clients = MAXCLIENTS_MAX;
1081 <
1081 >  ServerInfo.max_nick_length = 9;
1082 >  ServerInfo.max_topic_length = 80;
1083    ServerInfo.hub = 0;
1084    ServerInfo.dns_host.sin_addr.s_addr = 0;
1085    ServerInfo.dns_host.sin_port = 0;
1086 +
1087    AdminInfo.name = NULL;
1088    AdminInfo.email = NULL;
1089    AdminInfo.description = NULL;
1090  
1091 <  log_close_all();
1091 >  log_del_all();
1092  
1093    ConfigLoggingEntry.use_logging = 1;
1094  
1095    ConfigChannel.disable_fake_channels = 0;
1096 <  ConfigChannel.restrict_channels = 0;
1097 <  ConfigChannel.disable_local_channels = 0;
1098 <  ConfigChannel.use_invex = 1;
1099 <  ConfigChannel.use_except = 1;
1833 <  ConfigChannel.use_knock = 1;
1834 <  ConfigChannel.knock_delay = 300;
1096 >  ConfigChannel.invite_client_count = 10;
1097 >  ConfigChannel.invite_client_time = 300;
1098 >  ConfigChannel.knock_client_count = 1;
1099 >  ConfigChannel.knock_client_time = 300;
1100    ConfigChannel.knock_delay_channel = 60;
1101 <  ConfigChannel.max_chans_per_user = 15;
1837 <  ConfigChannel.quiet_on_ban = 1;
1101 >  ConfigChannel.max_channels = 25;
1102    ConfigChannel.max_bans = 25;
1103    ConfigChannel.default_split_user_count = 0;
1104    ConfigChannel.default_split_server_count = 0;
1105    ConfigChannel.no_join_on_split = 0;
1106    ConfigChannel.no_create_on_split = 0;
1843 –  ConfigChannel.burst_topicwho = 1;
1107  
1108    ConfigServerHide.flatten_links = 0;
1109    ConfigServerHide.links_delay = 300;
1110    ConfigServerHide.hidden = 0;
1848 –  ConfigServerHide.disable_hidden = 0;
1111    ConfigServerHide.hide_servers = 0;
1112 <  DupString(ConfigServerHide.hidden_name, NETWORK_NAME_DEFAULT);
1112 >  ConfigServerHide.hide_services = 0;
1113 >  ConfigServerHide.hidden_name = xstrdup(NETWORK_NAME_DEFAULT);
1114    ConfigServerHide.hide_server_ips = 0;
1115 +  ConfigServerHide.disable_remote_commands = 0;
1116  
1117 <  
1118 <  DupString(ConfigFileEntry.service_name, SERVICE_NAME_DEFAULT);
1117 >  ConfigFileEntry.away_count = 2;
1118 >  ConfigFileEntry.away_time = 10;
1119 >  ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1120    ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
1121 +  ConfigFileEntry.cycle_on_host_change = 1;
1122 +  ConfigFileEntry.glines = 0;
1123 +  ConfigFileEntry.gline_time = 12 * 3600;
1124 +  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
1125    ConfigFileEntry.gline_min_cidr = 16;
1126    ConfigFileEntry.gline_min_cidr6 = 48;
1127    ConfigFileEntry.invisible_on_connect = 1;
1859 –  ConfigFileEntry.burst_away = 0;
1860 –  ConfigFileEntry.use_whois_actually = 1;
1128    ConfigFileEntry.tkline_expire_notices = 1;
1129    ConfigFileEntry.hide_spoof_ips = 1;
1130    ConfigFileEntry.ignore_bogus_ts = 0;
1131    ConfigFileEntry.disable_auth = 0;
1865 –  ConfigFileEntry.disable_remote = 0;
1132    ConfigFileEntry.kill_chase_time_limit = 90;
1133    ConfigFileEntry.default_floodcount = 8;
1134    ConfigFileEntry.failed_oper_notice = 1;
# Line 1876 | Line 1142 | set_default_conf(void)
1142    ConfigFileEntry.anti_spam_exit_message_time = 0;
1143    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1144    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1145 <  ConfigFileEntry.kline_with_reason = 1;
1146 <  ConfigFileEntry.kline_reason = NULL;
1881 <  ConfigFileEntry.warn_no_nline = 1;
1145 >  ConfigFileEntry.warn_no_connect_block = 1;
1146 >  ConfigFileEntry.stats_e_disabled = 0;
1147    ConfigFileEntry.stats_o_oper_only = 0;
1148 <  ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
1149 <  ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
1148 >  ConfigFileEntry.stats_k_oper_only = 1;  /* 1 = masked */
1149 >  ConfigFileEntry.stats_i_oper_only = 1;  /* 1 = masked */
1150    ConfigFileEntry.stats_P_oper_only = 0;
1151 +  ConfigFileEntry.stats_u_oper_only = 0;
1152    ConfigFileEntry.caller_id_wait = 60;
1153    ConfigFileEntry.opers_bypass_callerid = 0;
1154    ConfigFileEntry.pace_wait = 10;
# Line 1892 | Line 1158 | set_default_conf(void)
1158    ConfigFileEntry.no_oper_flood = 0;
1159    ConfigFileEntry.true_no_oper_flood = 0;
1160    ConfigFileEntry.oper_pass_resv = 1;
1895 –  ConfigFileEntry.glines = 0;
1896 –  ConfigFileEntry.gline_time = 12 * 3600;
1161    ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
1898 –  ConfigFileEntry.client_flood = CLIENT_FLOOD_DEFAULT;
1162    ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
1163 <  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
1164 <    UMODE_OPERWALL | UMODE_WALLOP;
1165 <  ConfigFileEntry.use_egd = 0;
1903 <  ConfigFileEntry.egdpool_path = NULL;
1904 <  ConfigFileEntry.throttle_time = 10;
1163 >  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE | UMODE_WALLOP;
1164 >  ConfigFileEntry.throttle_count = 1;
1165 >  ConfigFileEntry.throttle_time = 1;
1166   }
1167  
1168   static void
# Line 1914 | Line 1175 | validate_conf(void)
1175      ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1176  
1177    if (ServerInfo.network_name == NULL)
1178 <    DupString(ServerInfo.network_name,NETWORK_NAME_DEFAULT);
1178 >    ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1179  
1180    if (ServerInfo.network_desc == NULL)
1181 <    DupString(ServerInfo.network_desc,NETWORK_DESC_DEFAULT);
1181 >    ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1182  
1183    if (ConfigFileEntry.service_name == NULL)
1184 <    DupString(ConfigFileEntry.service_name, SERVICE_NAME_DEFAULT);
1924 <
1925 <  if ((ConfigFileEntry.client_flood < CLIENT_FLOOD_MIN) ||
1926 <      (ConfigFileEntry.client_flood > CLIENT_FLOOD_MAX))
1927 <    ConfigFileEntry.client_flood = CLIENT_FLOOD_MAX;
1184 >    ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1185  
1186    ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
1187   }
1188  
1189 < /* read_conf()
1189 > /* read_conf()
1190   *
1191   * inputs       - file descriptor pointing to config file to use
1192   * output       - None
# Line 1940 | Line 1197 | read_conf(FILE *file)
1197   {
1198    lineno = 0;
1199  
1200 <  set_default_conf(); /* Set default values prior to conf parsing */
1200 >  set_default_conf();  /* Set default values prior to conf parsing */
1201    conf_parser_ctx.pass = 1;
1202 <  yyparse();          /* pick up the classes first */
1202 >  yyparse();  /* Pick up the classes first */
1203  
1204    rewind(file);
1205  
1206    conf_parser_ctx.pass = 2;
1207 <  yyparse();          /* Load the values from the conf */
1208 <  validate_conf();    /* Check to make sure some values are still okay. */
1209 <                      /* Some global values are also loaded here. */
1210 <  check_class();      /* Make sure classes are valid */
1207 >  yyparse();  /* Load the values from the conf */
1208 >  validate_conf();  /* Check to make sure some values are still okay. */
1209 >                    /* Some global values are also loaded here. */
1210 >  class_delete_marked();  /* Delete unused classes that are marked for deletion */
1211   }
1212  
1213   /* lookup_confhost()
# Line 1958 | Line 1215 | read_conf(FILE *file)
1215   * start DNS lookups of all hostnames in the conf
1216   * line and convert an IP addresses in a.b.c.d number for to IP#s.
1217   */
1218 < static void
1219 < lookup_confhost(struct ConfItem *conf)
1218 > void
1219 > lookup_confhost(struct MaskItem *conf)
1220   {
1964 –  struct AccessItem *aconf;
1221    struct addrinfo hints, *res;
1222  
1223 <  aconf = map_to_conf(conf);
1224 <
1969 <  if (EmptyString(aconf->host) ||
1970 <      EmptyString(aconf->user))
1971 <  {
1972 <    ilog(LOG_TYPE_IRCD, "Host/server name error: (%s) (%s)",
1973 <         aconf->host, conf->name);
1974 <    return;
1975 <  }
1976 <
1977 <  if (strchr(aconf->host, '*') ||
1978 <      strchr(aconf->host, '?'))
1979 <    return;
1980 <
1981 <  /* Do name lookup now on hostnames given and store the
1223 >  /*
1224 >   * Do name lookup now on hostnames given and store the
1225     * ip numbers in conf structure.
1226     */
1227    memset(&hints, 0, sizeof(hints));
# Line 1989 | Line 1232 | lookup_confhost(struct ConfItem *conf)
1232    /* Get us ready for a bind() and don't bother doing dns lookup */
1233    hints.ai_flags = AI_PASSIVE | AI_NUMERICHOST;
1234  
1235 <  if (getaddrinfo(aconf->host, NULL, &hints, &res))
1235 >  if (getaddrinfo(conf->host, NULL, &hints, &res))
1236    {
1237 <    conf_dns_lookup(aconf);
1237 >    conf_dns_lookup(conf);
1238      return;
1239    }
1240  
1241 <  assert(res != NULL);
1241 >  assert(res);
1242 >
1243 >  memcpy(&conf->addr, res->ai_addr, res->ai_addrlen);
1244 >  conf->addr.ss_len = res->ai_addrlen;
1245 >  conf->addr.ss.ss_family = res->ai_family;
1246  
2000 –  memcpy(&aconf->addr, res->ai_addr, res->ai_addrlen);
2001 –  aconf->addr.ss_len = res->ai_addrlen;
2002 –  aconf->addr.ss.ss_family = res->ai_family;
1247    freeaddrinfo(res);
1248   }
1249  
# Line 2013 | Line 1257 | lookup_confhost(struct ConfItem *conf)
1257   int
1258   conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
1259   {
1260 <  struct ip_entry *ip_found;
1261 <  struct AccessItem *aconf = find_dline_conf(addr, aftype);
1260 >  struct ip_entry *ip_found = NULL;
1261 >  struct MaskItem *conf = find_dline_conf(addr, aftype);
1262  
1263    /* DLINE exempt also gets you out of static limits/pacing... */
1264 <  if (aconf && (aconf->status & CONF_EXEMPTDLINE))
1264 >  if (conf && (conf->type == CONF_EXEMPT))
1265      return 0;
1266  
1267 <  if (aconf != NULL)
1267 >  if (conf)
1268      return BANNED_CLIENT;
1269  
1270    ip_found = find_or_add_ip(addr);
1271  
1272 <  if ((CurrentTime - ip_found->last_attempt) <
2029 <      ConfigFileEntry.throttle_time)
1272 >  if ((CurrentTime - ip_found->last_attempt) < ConfigFileEntry.throttle_time)
1273    {
1274 <    ip_found->last_attempt = CurrentTime;
1275 <    return TOO_FAST;
1274 >    if (ip_found->connection_count >= ConfigFileEntry.throttle_count)
1275 >      return TOO_FAST;
1276 >
1277 >    ++ip_found->connection_count;
1278    }
1279 +  else
1280 +    ip_found->connection_count = 1;
1281  
1282    ip_found->last_attempt = CurrentTime;
1283    return 0;
1284   }
1285  
2039 – static struct AccessItem *
2040 – find_regexp_kline(const char *uhi[])
2041 – {
2042 – #ifdef HAVE_LIBPCRE
2043 –  const dlink_node *ptr = NULL;
2044 –
2045 –  DLINK_FOREACH(ptr, rkconf_items.head)
2046 –  {
2047 –    struct AccessItem *aptr = map_to_conf(ptr->data);
2048 –
2049 –    assert(aptr->regexuser);
2050 –    assert(aptr->regexhost);
2051 –
2052 –    if (!ircd_pcre_exec(aptr->regexuser, uhi[0]) &&
2053 –        (!ircd_pcre_exec(aptr->regexhost, uhi[1]) ||
2054 –         !ircd_pcre_exec(aptr->regexhost, uhi[2])))
2055 –      return aptr;
2056 –  }
2057 – #endif
2058 –  return NULL;
2059 – }
2060 –
2061 – /* find_kill()
2062 – *
2063 – * inputs       - pointer to client structure
2064 – * output       - pointer to struct AccessItem if found
2065 – * side effects - See if this user is klined already,
2066 – *                and if so, return struct AccessItem pointer
2067 – */
2068 – struct AccessItem *
2069 – find_kill(struct Client *client_p)
2070 – {
2071 –  struct AccessItem *aconf = NULL;
2072 –  const char *uhi[3];
2073 –
2074 –  uhi[0] = client_p->username;
2075 –  uhi[1] = client_p->host;
2076 –  uhi[2] = client_p->sockhost;
2077 –
2078 –  assert(client_p != NULL);
2079 –
2080 –  aconf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
2081 –                               CONF_KLINE, client_p->localClient->aftype,
2082 –                               client_p->username, NULL, 1);
2083 –  if (aconf == NULL)
2084 –    aconf = find_regexp_kline(uhi);
2085 –
2086 –  return aconf;
2087 – }
2088 –
2089 – struct AccessItem *
2090 – find_gline(struct Client *client_p)
2091 – {
2092 –  struct AccessItem *aconf;
2093 –
2094 –  assert(client_p != NULL);
2095 –
2096 –  aconf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
2097 –                               CONF_GLINE, client_p->localClient->aftype,
2098 –                               client_p->username, NULL, 1);
2099 –  return aconf;
2100 – }
2101 –
2102 – /* add_temp_line()
2103 – *
2104 – * inputs        - pointer to struct ConfItem
2105 – * output        - none
2106 – * Side effects  - links in given struct ConfItem into
2107 – *                 temporary *line link list
2108 – */
2109 – void
2110 – add_temp_line(struct ConfItem *conf)
2111 – {
2112 –  if (conf->type == XLINE_TYPE)
2113 –  {
2114 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2115 –    dlinkAdd(conf, make_dlink_node(), &temporary_xlines);
2116 –  }
2117 –  else if ((conf->type == NRESV_TYPE) || (conf->type == CRESV_TYPE))
2118 –  {
2119 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2120 –    dlinkAdd(conf, make_dlink_node(), &temporary_resv);
2121 –  }
2122 – }
2123 –
1286   /* cleanup_tklines()
1287   *
1288   * inputs       - NONE
# Line 2132 | Line 1294 | void
1294   cleanup_tklines(void *notused)
1295   {
1296    hostmask_expire_temporary();
1297 <  expire_tklines(&temporary_xlines);
1298 <  expire_tklines(&temporary_resv);
1297 >  expire_tklines(&xconf_items);
1298 >  expire_tklines(&nresv_items);
1299 >  expire_tklines(&cresv_items);
1300   }
1301  
1302   /* expire_tklines()
# Line 2145 | Line 1308 | cleanup_tklines(void *notused)
1308   static void
1309   expire_tklines(dlink_list *tklist)
1310   {
1311 <  dlink_node *ptr;
1312 <  dlink_node *next_ptr;
2150 <  struct ConfItem *conf;
2151 <  struct MatchItem *xconf;
2152 <  struct MatchItem *nconf;
2153 <  struct ResvChannel *cconf;
1311 >  dlink_node *ptr = NULL, *ptr_next = NULL;
1312 >  struct MaskItem *conf = NULL;
1313  
1314 <  DLINK_FOREACH_SAFE(ptr, next_ptr, tklist->head)
1314 >  DLINK_FOREACH_SAFE(ptr, ptr_next, tklist->head)
1315    {
1316      conf = ptr->data;
1317  
1318 <    if (conf->type == XLINE_TYPE)
1318 >    if (!conf->until || conf->until > CurrentTime)
1319 >      continue;
1320 >
1321 >    if (conf->type == CONF_XLINE)
1322      {
1323 <      xconf = (struct MatchItem *)map_to_conf(conf);
1324 <      if (xconf->hold <= CurrentTime)
1325 <      {
1326 <        if (ConfigFileEntry.tkline_expire_notices)
2165 <          sendto_realops_flags(UMODE_ALL, L_ALL,
2166 <                               "Temporary X-line for [%s] sexpired", conf->name);
2167 <        dlinkDelete(ptr, tklist);
2168 <        free_dlink_node(ptr);
2169 <        delete_conf_item(conf);
2170 <      }
1323 >      if (ConfigFileEntry.tkline_expire_notices)
1324 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1325 >                               "Temporary X-line for [%s] expired", conf->name);
1326 >      conf_free(conf);
1327      }
1328 <    else if (conf->type == NRESV_TYPE)
1328 >    else if (conf->type == CONF_NRESV || conf->type == CONF_CRESV)
1329      {
1330 <      nconf = (struct MatchItem *)map_to_conf(conf);
1331 <      if (nconf->hold <= CurrentTime)
2176 <      {
2177 <        if (ConfigFileEntry.tkline_expire_notices)
2178 <          sendto_realops_flags(UMODE_ALL, L_ALL,
1330 >      if (ConfigFileEntry.tkline_expire_notices)
1331 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1332                                 "Temporary RESV for [%s] expired", conf->name);
1333 <        dlinkDelete(ptr, tklist);
2181 <        free_dlink_node(ptr);
2182 <        delete_conf_item(conf);
2183 <      }
2184 <    }
2185 <    else if (conf->type == CRESV_TYPE)
2186 <    {
2187 <      cconf = (struct ResvChannel *)map_to_conf(conf);
2188 <      if (cconf->hold <= CurrentTime)
2189 <      {
2190 <        if (ConfigFileEntry.tkline_expire_notices)
2191 <          sendto_realops_flags(UMODE_ALL, L_ALL,
2192 <                               "Temporary RESV for [%s] expired", cconf->name);
2193 <        delete_channel_resv(cconf);
2194 <      }
1333 >      conf_free(conf);
1334      }
1335    }
1336   }
# Line 2204 | Line 1343 | expire_tklines(dlink_list *tklist)
1343   */
1344   static const struct oper_privs
1345   {
1346 <  const unsigned int oprivs;
1346 >  const unsigned int flag;
1347    const unsigned char c;
1348   } flag_list[] = {
1349 <  { OPER_FLAG_ADMIN,       'A' },
1350 <  { OPER_FLAG_REMOTEBAN,   'B' },
1351 <  { OPER_FLAG_DIE,         'D' },
1352 <  { OPER_FLAG_GLINE,       'G' },
1353 <  { OPER_FLAG_REHASH,      'H' },
1354 <  { OPER_FLAG_K,           'K' },
1355 <  { OPER_FLAG_OPERWALL,    'L' },
1356 <  { OPER_FLAG_N,           'N' },
1357 <  { OPER_FLAG_GLOBAL_KILL, 'O' },
1358 <  { OPER_FLAG_REMOTE,      'R' },
1359 <  { OPER_FLAG_OPER_SPY,    'S' },
1360 <  { OPER_FLAG_UNKLINE,     'U' },
1361 <  { OPER_FLAG_X,           'X' },
1349 >  { OPER_FLAG_ADMIN,          'A' },
1350 >  { OPER_FLAG_REMOTEBAN,      'B' },
1351 >  { OPER_FLAG_DIE,            'D' },
1352 >  { OPER_FLAG_GLINE,          'G' },
1353 >  { OPER_FLAG_REHASH,         'H' },
1354 >  { OPER_FLAG_KLINE,          'K' },
1355 >  { OPER_FLAG_KILL,           'N' },
1356 >  { OPER_FLAG_KILL_REMOTE,    'O' },
1357 >  { OPER_FLAG_CONNECT,        'P' },
1358 >  { OPER_FLAG_CONNECT_REMOTE, 'Q' },
1359 >  { OPER_FLAG_SQUIT,          'R' },
1360 >  { OPER_FLAG_SQUIT_REMOTE,   'S' },
1361 >  { OPER_FLAG_UNKLINE,        'U' },
1362 >  { OPER_FLAG_XLINE,          'X' },
1363    { 0, '\0' }
1364   };
1365  
1366   char *
1367   oper_privs_as_string(const unsigned int port)
1368   {
1369 <  static char privs_out[16];
1369 >  static char privs_out[IRCD_BUFSIZE];
1370    char *privs_ptr = privs_out;
2231 –  unsigned int i = 0;
1371  
1372 <  for (; flag_list[i].oprivs; ++i)
1372 >  for (const struct oper_privs *opriv = flag_list; opriv->flag; ++opriv)
1373    {
1374 <    if (port & flag_list[i].oprivs)
1375 <      *privs_ptr++ = flag_list[i].c;
1374 >    if (port & opriv->flag)
1375 >      *privs_ptr++ = opriv->c;
1376      else
1377 <      *privs_ptr++ = ToLowerTab[flag_list[i].c];
1377 >      *privs_ptr++ = ToLower(opriv->c);
1378    }
1379  
1380    *privs_ptr = '\0';
# Line 2244 | Line 1383 | oper_privs_as_string(const unsigned int
1383   }
1384  
1385   /*
1386 < * Input: A client to find the active oper{} name for.
1386 > * Input: A client to find the active operator {} name for.
1387   * Output: The nick!user@host{oper} of the oper.
1388   *         "oper" is server name for remote opers
1389   * Side effects: None.
# Line 2252 | Line 1391 | oper_privs_as_string(const unsigned int
1391   const char *
1392   get_oper_name(const struct Client *client_p)
1393   {
1394 <  dlink_node *cnode = NULL;
1394 >  const dlink_node *cnode = NULL;
1395    /* +5 for !,@,{,} and null */
1396    static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
1397  
# Line 2260 | Line 1399 | get_oper_name(const struct Client *clien
1399    {
1400      if ((cnode = client_p->localClient->confs.head))
1401      {
1402 <      struct ConfItem *conf = cnode->data;
2264 <      const struct AccessItem *aconf = map_to_conf(conf);
1402 >      const struct MaskItem *conf = cnode->data;
1403  
1404 <      if (IsConfOperator(aconf))
1404 >      if (IsConfOperator(conf))
1405        {
1406 <        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1406 >        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1407                   client_p->username, client_p->host, conf->name);
1408 <        return buffer;
1408 >        return buffer;
1409        }
1410      }
1411  
1412 <    /* Probably should assert here for now. If there is an oper out there
1413 <     * with no oper{} conf attached, it would be good for us to know...
1412 >    /*
1413 >     * Probably should assert here for now. If there is an oper out there
1414 >     * with no operator {} conf attached, it would be good for us to know...
1415       */
1416 <    assert(0); /* Oper without oper conf! */
1416 >    assert(0);  /* Oper without oper conf! */
1417    }
1418  
1419    snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1420 <           client_p->username, client_p->host, client_p->servptr->name);
1420 >           client_p->username, client_p->host, client_p->servptr->name);
1421    return buffer;
1422   }
1423  
# Line 2291 | Line 1430 | get_oper_name(const struct Client *clien
1430   void
1431   read_conf_files(int cold)
1432   {
1433 <  const char *filename;
1434 <  char chanmodes[32];
1435 <  char chanlimit[32];
1433 >  const char *filename = NULL;
1434 >  char chanmodes[IRCD_BUFSIZE] = "";
1435 >  char chanlimit[IRCD_BUFSIZE] = "";
1436  
1437    conf_parser_ctx.boot = cold;
1438 <  filename = get_conf_name(CONF_TYPE);
1438 >  filename = ConfigFileEntry.configfile;
1439  
1440    /* We need to know the initial filename for the yyerror() to report
1441       FIXME: The full path is in conffilenamebuf first time since we
1442 <             dont know anything else
1442 >             don't know anything else
1443  
1444 <     - Gozem 2002-07-21
1444 >     - Gozem 2002-07-21
1445    */
1446    strlcpy(conffilebuf, filename, sizeof(conffilebuf));
1447  
# Line 2316 | Line 1455 | read_conf_files(int cold)
1455      }
1456      else
1457      {
1458 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1459 <                           "Unable to read configuration file '%s': %s",
1460 <                           filename, strerror(errno));
1458 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1459 >                           "Unable to read configuration file '%s': %s",
1460 >                           filename, strerror(errno));
1461        return;
1462      }
1463    }
# Line 2329 | Line 1468 | read_conf_files(int cold)
1468    read_conf(conf_parser_ctx.conf_file);
1469    fclose(conf_parser_ctx.conf_file);
1470  
1471 +  log_reopen_all();
1472 +
1473 +  add_isupport("NICKLEN", NULL, ServerInfo.max_nick_length);
1474    add_isupport("NETWORK", ServerInfo.network_name, -1);
1475 <  snprintf(chanmodes, sizeof(chanmodes), "b%s%s:%d",
1476 <           ConfigChannel.use_except ? "e" : "",
2335 <           ConfigChannel.use_invex ? "I" : "", ConfigChannel.max_bans);
1475 >
1476 >  snprintf(chanmodes, sizeof(chanmodes), "beI:%d", ConfigChannel.max_bans);
1477    add_isupport("MAXLIST", chanmodes, -1);
1478    add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1479 +  add_isupport("CHANTYPES", "#", -1);
1480  
1481 <  if (ConfigChannel.disable_local_channels)
1482 <    add_isupport("CHANTYPES", "#", -1);
2341 <  else
2342 <    add_isupport("CHANTYPES", "#&", -1);
2343 <
2344 <  snprintf(chanlimit, sizeof(chanlimit), "%s:%d",
2345 <           ConfigChannel.disable_local_channels ? "#" : "#&",
2346 <           ConfigChannel.max_chans_per_user);
1481 >  snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1482 >           ConfigChannel.max_channels);
1483    add_isupport("CHANLIMIT", chanlimit, -1);
1484 <  snprintf(chanmodes, sizeof(chanmodes), "%s%s%s",
1485 <           ConfigChannel.use_except ? "e" : "",
1486 <           ConfigChannel.use_invex ? "I" : "", "b,k,l,imnprstORS");
2351 <  add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
2352 <
2353 <  if (ConfigChannel.use_except)
2354 <    add_isupport("EXCEPTS", "e", -1);
2355 <  if (ConfigChannel.use_invex)
2356 <    add_isupport("INVEX", "I", -1);
1484 >  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,cimnprstMORS");
1485 >  add_isupport("CHANNELLEN", NULL, CHANNELLEN);
1486 >  add_isupport("TOPICLEN", NULL, ServerInfo.max_topic_length);
1487    add_isupport("CHANMODES", chanmodes, -1);
1488  
1489    /*
# Line 2361 | Line 1491 | read_conf_files(int cold)
1491     * on strlen(form_str(RPL_ISUPPORT))
1492     */
1493    rebuild_isupport_message_line();
2364 –
2365 – #ifdef HAVE_LIBPCRE
2366 –  parse_conf_file(RKLINE_TYPE, cold);
2367 –  parse_conf_file(RXLINE_TYPE, cold);
2368 – #endif
2369 –  parse_conf_file(KLINE_TYPE, cold);
2370 –  parse_conf_file(DLINE_TYPE, cold);
2371 –  parse_conf_file(XLINE_TYPE, cold);
2372 –  parse_conf_file(NRESV_TYPE, cold);
2373 –  parse_conf_file(CRESV_TYPE, cold);
2374 – }
2375 –
2376 – /* parse_conf_file()
2377 – *
2378 – * inputs       - type of conf file to parse
2379 – * output       - none
2380 – * side effects - conf file for givenconf type is opened and read then parsed
2381 – */
2382 – static void
2383 – parse_conf_file(int type, int cold)
2384 – {
2385 –  FILE *file = NULL;
2386 –  const char *filename = get_conf_name(type);
2387 –
2388 –  if ((file = fopen(filename, "r")) == NULL)
2389 –  {
2390 –    if (cold)
2391 –      ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
2392 –           filename, strerror(errno));
2393 –    else
2394 –      sendto_realops_flags(UMODE_ALL, L_ALL,
2395 –                    "Unable to read configuration file '%s': %s",
2396 –                           filename, strerror(errno));
2397 –  }
2398 –  else
2399 –  {
2400 –    parse_csv_file(file, type);
2401 –    fclose(file);
2402 –  }
1494   }
1495  
1496   /* clear_out_old_conf()
# Line 2412 | Line 1503 | static void
1503   clear_out_old_conf(void)
1504   {
1505    dlink_node *ptr = NULL, *next_ptr = NULL;
1506 <  struct ConfItem *conf;
2416 <  struct AccessItem *aconf;
2417 <  struct ClassItem *cltmp;
2418 <  struct MatchItem *match_item;
1506 >  struct MaskItem *conf;
1507    dlink_list *free_items [] = {
1508      &server_items,   &oconf_items,
1509 <     &uconf_items,   &xconf_items, &rxconf_items, &rkconf_items,
1510 <     &nresv_items, &cluster_items,  &gdeny_items, &service_items, NULL
1509 >     &uconf_items,   &xconf_items,
1510 >     &nresv_items, &cluster_items,  &service_items, &cresv_items, NULL
1511    };
1512  
1513    dlink_list ** iterator = free_items; /* C is dumb */
# Line 2427 | Line 1515 | clear_out_old_conf(void)
1515    /* We only need to free anything allocated by yyparse() here.
1516     * Resetting structs, etc, is taken care of by set_default_conf().
1517     */
1518 <  
1518 >
1519    for (; *iterator != NULL; iterator++)
1520    {
1521      DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
1522      {
1523        conf = ptr->data;
2436 –      /* XXX This is less than pretty */
2437 –      if (conf->type == SERVER_TYPE)
2438 –      {
2439 –        aconf = map_to_conf(conf);
1524  
1525 <        if (aconf->clients != 0)
2442 <        {
2443 <          SetConfIllegal(aconf);
2444 <          dlinkDelete(&conf->node, &server_items);
2445 <        }
2446 <        else
2447 <        {
2448 <          delete_conf_item(conf);
2449 <        }
2450 <      }
2451 <      else if (conf->type == OPER_TYPE)
2452 <      {
2453 <        aconf = map_to_conf(conf);
1525 >      dlinkDelete(&conf->node, map_to_list(conf->type));
1526  
1527 <        if (aconf->clients != 0)
1528 <        {
2457 <          SetConfIllegal(aconf);
2458 <          dlinkDelete(&conf->node, &oconf_items);
2459 <        }
2460 <        else
2461 <        {
2462 <          delete_conf_item(conf);
2463 <        }
2464 <      }
2465 <      else if (conf->type == XLINE_TYPE  ||
2466 <               conf->type == RXLINE_TYPE ||
2467 <               conf->type == RKLINE_TYPE)
1527 >      /* XXX This is less than pretty */
1528 >      if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
1529        {
1530 <        /* temporary (r)xlines are also on
1531 <         * the (r)xconf items list */
2471 <        if (conf->flags & CONF_FLAGS_TEMPORARY)
2472 <          continue;
2473 <
2474 <        delete_conf_item(conf);
1530 >        if (!conf->ref_count)
1531 >          conf_free(conf);
1532        }
1533 <      else
1533 >      else if (conf->type == CONF_XLINE)
1534        {
1535 <          delete_conf_item(conf);
1535 >        if (!conf->until)
1536 >          conf_free(conf);
1537        }
1538 +      else
1539 +        conf_free(conf);
1540      }
1541    }
1542  
1543 +  motd_clear();
1544 +
1545    /*
1546     * don't delete the class table, rather mark all entries
1547 <   * for deletion. The table is cleaned up by check_class. - avalon
1547 >   * for deletion. The table is cleaned up by class_delete_marked. - avalon
1548     */
1549 <  DLINK_FOREACH(ptr, class_items.head)
2488 <  {
2489 <    cltmp = map_to_conf(ptr->data);
2490 <
2491 <    if (ptr != class_items.tail)  /* never mark the "default" class */
2492 <      cltmp->active = 0;
2493 <  }
1549 >  class_mark_for_deletion();
1550  
1551    clear_out_address_conf();
1552  
# Line 2504 | Line 1560 | clear_out_old_conf(void)
1560    ServerInfo.network_name = NULL;
1561    MyFree(ServerInfo.network_desc);
1562    ServerInfo.network_desc = NULL;
2507 –  MyFree(ConfigFileEntry.egdpool_path);
2508 –  ConfigFileEntry.egdpool_path = NULL;
1563   #ifdef HAVE_LIBCRYPTO
1564 <  if (ServerInfo.rsa_private_key != NULL)
1564 >  if (ServerInfo.rsa_private_key)
1565    {
1566      RSA_free(ServerInfo.rsa_private_key);
1567      ServerInfo.rsa_private_key = NULL;
# Line 2515 | Line 1569 | clear_out_old_conf(void)
1569  
1570    MyFree(ServerInfo.rsa_private_key_file);
1571    ServerInfo.rsa_private_key_file = NULL;
2518 –
2519 –  if (ServerInfo.server_ctx)
2520 –    SSL_CTX_set_options(ServerInfo.server_ctx, SSL_OP_NO_SSLv2|
2521 –                                               SSL_OP_NO_SSLv3|
2522 –                                               SSL_OP_NO_TLSv1);
2523 –  if (ServerInfo.client_ctx)
2524 –    SSL_CTX_set_options(ServerInfo.client_ctx, SSL_OP_NO_SSLv2|
2525 –                                               SSL_OP_NO_SSLv3|
2526 –                                               SSL_OP_NO_TLSv1);
1572   #endif
1573  
2529 –  /* clean out old resvs from the conf */
2530 –  clear_conf_resv();
2531 –
1574    /* clean out AdminInfo */
1575    MyFree(AdminInfo.name);
1576    AdminInfo.name = NULL;
# Line 2537 | Line 1579 | clear_out_old_conf(void)
1579    MyFree(AdminInfo.description);
1580    AdminInfo.description = NULL;
1581  
2540 –  /* operator{} and class{} blocks are freed above */
1582    /* clean out listeners */
1583    close_listeners();
1584  
2544 –  /* auth{}, quarantine{}, shared{}, connect{}, kill{}, deny{},
2545 –   * exempt{} and gecos{} blocks are freed above too
2546 –   */
2547 –
1585    /* clean out general */
1586    MyFree(ConfigFileEntry.service_name);
1587    ConfigFileEntry.service_name = NULL;
2551 –
2552 –  delete_isupport("INVEX");
2553 –  delete_isupport("EXCEPTS");
2554 – }
2555 –
2556 – /* flush_deleted_I_P()
2557 – *
2558 – * inputs       - none
2559 – * output       - none
2560 – * side effects - This function removes I/P conf items
2561 – */
2562 – static void
2563 – flush_deleted_I_P(void)
2564 – {
2565 –  dlink_node *ptr;
2566 –  dlink_node *next_ptr;
2567 –  struct ConfItem *conf;
2568 –  struct AccessItem *aconf;
2569 –  dlink_list * free_items [] = {
2570 –    &server_items, &oconf_items, NULL
2571 –  };
2572 –  dlink_list ** iterator = free_items; /* C is dumb */
2573 –
2574 –  /* flush out deleted I and P lines
2575 –   * although still in use.
2576 –   */
2577 –  for (; *iterator != NULL; iterator++)
2578 –  {
2579 –    DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
2580 –    {
2581 –      conf = ptr->data;
2582 –      aconf = (struct AccessItem *)map_to_conf(conf);
2583 –
2584 –      if (IsConfIllegal(aconf))
2585 –      {
2586 –        dlinkDelete(ptr, *iterator);
2587 –
2588 –        if (aconf->clients == 0)
2589 –          delete_conf_item(conf);
2590 –      }
2591 –    }
2592 –  }
2593 – }
2594 –
2595 – /* get_conf_name()
2596 – *
2597 – * inputs       - type of conf file to return name of file for
2598 – * output       - pointer to filename for type of conf
2599 – * side effects - none
2600 – */
2601 – const char *
2602 – get_conf_name(ConfType type)
2603 – {
2604 –  switch (type)
2605 –  {
2606 –    case CONF_TYPE:
2607 –      return ConfigFileEntry.configfile;
2608 –      break;
2609 –    case KLINE_TYPE:
2610 –      return ConfigFileEntry.klinefile;
2611 –      break;
2612 –    case RKLINE_TYPE:
2613 –      return ConfigFileEntry.rklinefile;
2614 –      break;
2615 –    case DLINE_TYPE:
2616 –      return ConfigFileEntry.dlinefile;
2617 –      break;
2618 –    case XLINE_TYPE:
2619 –      return ConfigFileEntry.xlinefile;
2620 –      break;
2621 –    case RXLINE_TYPE:
2622 –      return ConfigFileEntry.rxlinefile;
2623 –      break;
2624 –    case CRESV_TYPE:
2625 –      return ConfigFileEntry.cresvfile;
2626 –      break;
2627 –    case NRESV_TYPE:
2628 –      return ConfigFileEntry.nresvfile;
2629 –      break;
2630 –    case GLINE_TYPE:
2631 –      return ConfigFileEntry.glinefile;
2632 –      break;
2633 –
2634 –    default:
2635 –      return NULL;  /* This should NEVER HAPPEN since we call this function
2636 –                       only with the above values, this will cause us to core
2637 –                       at some point if this happens so we know where it was */
2638 –  }
2639 – }
2640 –
2641 – #define BAD_PING (-1)
2642 –
2643 – /* get_conf_ping()
2644 – *
2645 – * inputs       - pointer to struct AccessItem
2646 – *              - pointer to a variable that receives ping warning time
2647 – * output       - ping frequency
2648 – * side effects - NONE
2649 – */
2650 – static int
2651 – get_conf_ping(struct ConfItem *conf, int *pingwarn)
2652 – {
2653 –  struct ClassItem *aclass;
2654 –  struct AccessItem *aconf;
2655 –
2656 –  if (conf != NULL)
2657 –  {
2658 –    aconf = (struct AccessItem *)map_to_conf(conf);
2659 –    if (aconf->class_ptr != NULL)
2660 –    {
2661 –      aclass = (struct ClassItem *)map_to_conf(aconf->class_ptr);
2662 –      *pingwarn = aclass->ping_warning;
2663 –      return aclass->ping_freq;
2664 –    }
2665 –  }
2666 –
2667 –  return BAD_PING;
2668 – }
2669 –
2670 – /* get_client_class()
2671 – *
2672 – * inputs       - pointer to client struct
2673 – * output       - pointer to name of class
2674 – * side effects - NONE
2675 – */
2676 – const char *
2677 – get_client_class(struct Client *target_p)
2678 – {
2679 –  dlink_node *cnode = NULL;
2680 –  struct AccessItem *aconf = NULL;
2681 –
2682 –  assert(!IsMe(target_p));
2683 –
2684 –  if ((cnode = target_p->localClient->confs.head))
2685 –  {
2686 –    struct ConfItem *conf = cnode->data;
2687 –
2688 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2689 –          (conf->type == OPER_TYPE));
2690 –
2691 –    aconf = map_to_conf(conf);
2692 –    if (aconf->class_ptr != NULL)
2693 –      return aconf->class_ptr->name;
2694 –  }
2695 –
2696 –  return "default";
2697 – }
2698 –
2699 – /* get_client_ping()
2700 – *
2701 – * inputs       - pointer to client struct
2702 – *              - pointer to a variable that receives ping warning time
2703 – * output       - ping frequency
2704 – * side effects - NONE
2705 – */
2706 – int
2707 – get_client_ping(struct Client *target_p, int *pingwarn)
2708 – {
2709 –  int ping = 0;
2710 –  dlink_node *cnode = NULL;
2711 –
2712 –  if ((cnode = target_p->localClient->confs.head))
2713 –  {
2714 –    struct ConfItem *conf = cnode->data;
2715 –
2716 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2717 –          (conf->type == OPER_TYPE));
2718 –
2719 –    ping = get_conf_ping(conf, pingwarn);
2720 –    if (ping > 0)
2721 –      return ping;
2722 –  }
2723 –
2724 –  *pingwarn = 0;
2725 –  return DEFAULT_PINGFREQUENCY;
2726 – }
2727 –
2728 – /* find_class()
2729 – *
2730 – * inputs       - string name of class
2731 – * output       - corresponding Class pointer
2732 – * side effects - NONE
2733 – */
2734 – struct ConfItem *
2735 – find_class(const char *classname)
2736 – {
2737 –  struct ConfItem *conf;
2738 –
2739 –  if ((conf = find_exact_name_conf(CLASS_TYPE, NULL, classname, NULL, NULL)) != NULL)
2740 –    return conf;
2741 –
2742 –  return class_default;
2743 – }
2744 –
2745 – /* check_class()
2746 – *
2747 – * inputs       - NONE
2748 – * output       - NONE
2749 – * side effects -
2750 – */
2751 – void
2752 – check_class(void)
2753 – {
2754 –  dlink_node *ptr = NULL, *next_ptr = NULL;
2755 –
2756 –  DLINK_FOREACH_SAFE(ptr, next_ptr, class_items.head)
2757 –  {
2758 –    struct ClassItem *aclass = map_to_conf(ptr->data);
2759 –
2760 –    if (!aclass->active && !aclass->curr_user_count)
2761 –    {
2762 –      destroy_cidr_class(aclass);
2763 –      delete_conf_item(ptr->data);
2764 –    }
2765 –  }
2766 – }
2767 –
2768 – /* init_class()
2769 – *
2770 – * inputs       - NONE
2771 – * output       - NONE
2772 – * side effects -
2773 – */
2774 – void
2775 – init_class(void)
2776 – {
2777 –  struct ClassItem *aclass;
2778 –
2779 –  class_default = make_conf_item(CLASS_TYPE);
2780 –
2781 –  aclass = map_to_conf(class_default);
2782 –  aclass->active = 1;
2783 –  DupString(class_default->name, "default");
2784 –  aclass->con_freq  = DEFAULT_CONNECTFREQUENCY;
2785 –  aclass->ping_freq = DEFAULT_PINGFREQUENCY;
2786 –  aclass->max_total = MAXIMUM_LINKS_DEFAULT;
2787 –  aclass->max_sendq = DEFAULT_SENDQ;
2788 –
2789 –  client_check_cb = register_callback("check_client", check_client);
2790 – }
2791 –
2792 – /* get_sendq()
2793 – *
2794 – * inputs       - pointer to client
2795 – * output       - sendq for this client as found from its class
2796 – * side effects - NONE
2797 – */
2798 – unsigned int
2799 – get_sendq(struct Client *client_p)
2800 – {
2801 –  unsigned int sendq = DEFAULT_SENDQ;
2802 –  dlink_node *cnode;
2803 –  struct ConfItem *class_conf;
2804 –  struct ClassItem *aclass;
2805 –  struct AccessItem *aconf;
2806 –
2807 –  assert(!IsMe(client_p));
2808 –
2809 –  if ((cnode = client_p->localClient->confs.head))
2810 –  {
2811 –    struct ConfItem *conf = cnode->data;
2812 –
2813 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2814 –          (conf->type == OPER_TYPE));
2815 –
2816 –    aconf = map_to_conf(conf);
2817 –
2818 –    if ((class_conf = aconf->class_ptr) == NULL)
2819 –      return DEFAULT_SENDQ; /* TBV: shouldn't be possible at all */
2820 –
2821 –    aclass = map_to_conf(class_conf);
2822 –    sendq = aclass->max_sendq;
2823 –    return sendq;
2824 –  }
2825 –
2826 –  /* XXX return a default?
2827 –   * if here, then there wasn't an attached conf with a sendq
2828 –   * that is very bad -Dianora
2829 –   */
2830 –  return DEFAULT_SENDQ;
1588   }
1589  
1590   /* conf_add_class_to_conf()
1591   *
1592   * inputs       - pointer to config item
1593   * output       - NONE
1594 < * side effects - Add a class pointer to a conf
1594 > * side effects - Add a class pointer to a conf
1595   */
1596   void
1597 < conf_add_class_to_conf(struct ConfItem *conf, const char *class_name)
1597 > conf_add_class_to_conf(struct MaskItem *conf, const char *class_name)
1598   {
1599 <  struct AccessItem *aconf = map_to_conf(conf);
2843 <  struct ClassItem *class = NULL;
2844 <
2845 <  if (class_name == NULL)
1599 >  if (class_name == NULL)
1600    {
1601 <    aconf->class_ptr = class_default;
1601 >    conf->class = class_default;
1602  
1603 <    if (conf->type == CLIENT_TYPE)
1604 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1605 <                           "Warning *** Defaulting to default class for %s@%s",
1606 <                           aconf->user, aconf->host);
1603 >    if (conf->type == CONF_CLIENT)
1604 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1605 >                           "Warning *** Defaulting to default class for %s@%s",
1606 >                           conf->user, conf->host);
1607      else
1608 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1609 <                           "Warning *** Defaulting to default class for %s",
1610 <                           conf->name);
1608 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1609 >                           "Warning *** Defaulting to default class for %s",
1610 >                           conf->name);
1611    }
1612    else
1613 <    aconf->class_ptr = find_class(class_name);
1613 >    conf->class = class_find(class_name, 1);
1614  
1615 <  if (aconf->class_ptr)
2862 <    class = map_to_conf(aconf->class_ptr);
2863 <
2864 <  if (aconf->class_ptr == NULL || !class->active)
1615 >  if (conf->class == NULL)
1616    {
1617 <    if (conf->type == CLIENT_TYPE)
1618 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1619 <                           "Warning *** Defaulting to default class for %s@%s",
1620 <                           aconf->user, aconf->host);
1617 >    if (conf->type == CONF_CLIENT)
1618 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1619 >                           "Warning *** Defaulting to default class for %s@%s",
1620 >                           conf->user, conf->host);
1621      else
1622 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1623 <                           "Warning *** Defaulting to default class for %s",
1624 <                           conf->name);
1625 <    aconf->class_ptr = class_default;
2875 <  }
2876 < }
2877 <
2878 < /* conf_add_server()
2879 < *
2880 < * inputs       - pointer to config item
2881 < *              - pointer to link count already on this conf
2882 < * output       - NONE
2883 < * side effects - Add a connect block
2884 < */
2885 < int
2886 < conf_add_server(struct ConfItem *conf, const char *class_name)
2887 < {
2888 <  struct AccessItem *aconf = map_to_conf(conf);
2889 <
2890 <  conf_add_class_to_conf(conf, class_name);
2891 <
2892 <  if (!aconf->host || !conf->name)
2893 <  {
2894 <    sendto_realops_flags(UMODE_ALL, L_ALL, "Bad connect block");
2895 <    ilog(LOG_TYPE_IRCD, "Bad connect block");
2896 <    return -1;
2897 <  }
2898 <
2899 <  if (EmptyString(aconf->passwd))
2900 <  {
2901 <    sendto_realops_flags(UMODE_ALL, L_ALL, "Bad connect block, name %s",
2902 <                         conf->name);
2903 <    ilog(LOG_TYPE_IRCD, "Bad connect block, host %s", conf->name);
2904 <    return -1;
1622 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1623 >                           "Warning *** Defaulting to default class for %s",
1624 >                           conf->name);
1625 >    conf->class = class_default;
1626    }
2906 –
2907 –  lookup_confhost(conf);
2908 –
2909 –  return 0;
1627   }
1628  
1629   /* yyerror()
# Line 2924 | Line 1641 | yyerror(const char *msg)
1641      return;
1642  
1643    strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1644 <  sendto_realops_flags(UMODE_ALL, L_ALL, "\"%s\", line %u: %s: %s",
1644 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1645 >                       "\"%s\", line %u: %s: %s",
1646 >                       conffilebuf, lineno + 1, msg, newlinebuf);
1647 >  ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1648 >       conffilebuf, lineno + 1, msg, newlinebuf);
1649 > }
1650 >
1651 > void
1652 > conf_error_report(const char *msg)
1653 > {
1654 >  char newlinebuf[IRCD_BUFSIZE];
1655 >
1656 >  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1657 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1658 >                       "\"%s\", line %u: %s: %s",
1659                         conffilebuf, lineno + 1, msg, newlinebuf);
1660    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1661         conffilebuf, lineno + 1, msg, newlinebuf);
# Line 2932 | Line 1663 | yyerror(const char *msg)
1663  
1664   /*
1665   * valid_tkline()
1666 < *
1666 > *
1667   * inputs       - pointer to ascii string to check
1668   *              - whether the specified time is in seconds or minutes
1669   * output       - -1 not enough parameters
# Line 2941 | Line 1672 | yyerror(const char *msg)
1672   * Originally written by Dianora (Diane, db@db.net)
1673   */
1674   time_t
1675 < valid_tkline(const char *p, int minutes)
1675 > valid_tkline(const char *data, const int minutes)
1676   {
1677 +  const unsigned char *p = (const unsigned char *)data;
1678 +  unsigned char tmpch = '\0';
1679    time_t result = 0;
1680  
1681 <  for (; *p; ++p)
1681 >  while ((tmpch = *p++))
1682    {
1683 <    if (!IsDigit(*p))
1683 >    if (!IsDigit(tmpch))
1684        return 0;
1685  
1686      result *= 10;
1687 <    result += ((*p) & 0xF);
1687 >    result += (tmpch & 0xF);
1688    }
1689  
1690    /*
1691 <   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1691 >   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1692     * i.e. they specifically use 0, I am going to return 1 instead
1693     * as a return value of non-zero is used to flag it as a temporary kline
1694     */
1695    if (result == 0)
1696      result = 1;
1697  
1698 <  /*
1698 >  /*
1699     * If the incoming time is in seconds convert it to minutes for the purpose
1700     * of this calculation
1701     */
1702    if (!minutes)
1703 <    result = result / (time_t)60;
1703 >    result = result / 60;
1704  
1705    if (result > MAX_TDKLINE_TIME)
1706      result = MAX_TDKLINE_TIME;
1707  
1708 <  result = result * (time_t)60;  /* turn it into seconds */
1708 >  result = result * 60;  /* turn it into seconds */
1709  
1710    return result;
1711   }
1712  
1713 + /* valid_wild_card_simple()
1714 + *
1715 + * inputs       - data to check for sufficient non-wildcard characters
1716 + * outputs      - 1 if valid, else 0
1717 + * side effects - none
1718 + */
1719 + int
1720 + valid_wild_card_simple(const char *data)
1721 + {
1722 +  const unsigned char *p = (const unsigned char *)data;
1723 +  unsigned char tmpch = '\0';
1724 +  unsigned int nonwild = 0;
1725 +
1726 +  while ((tmpch = *p++))
1727 +  {
1728 +    if (tmpch == '\\' && *p)
1729 +    {
1730 +      ++p;
1731 +      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1732 +        return 1;
1733 +    }
1734 +    else if (!IsMWildChar(tmpch))
1735 +    {
1736 +      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1737 +        return 1;
1738 +    }
1739 +  }
1740 +
1741 +  return 0;
1742 + }
1743 +
1744   /* valid_wild_card()
1745   *
1746   * input        - pointer to client
# Line 2988 | Line 1752 | valid_tkline(const char *p, int minutes)
1752   int
1753   valid_wild_card(struct Client *source_p, int warn, int count, ...)
1754   {
1755 <  char *p;
1756 <  char tmpch;
2993 <  int nonwild = 0;
1755 >  unsigned char tmpch = '\0';
1756 >  unsigned int nonwild = 0;
1757    va_list args;
1758  
1759    /*
# Line 3009 | Line 1772 | valid_wild_card(struct Client *source_p,
1772  
1773    while (count--)
1774    {
1775 <    p = va_arg(args, char *);
1775 >    const unsigned char *p = va_arg(args, const unsigned char *);
1776      if (p == NULL)
1777        continue;
1778  
# Line 3022 | Line 1785 | valid_wild_card(struct Client *source_p,
1785           * break - no point in searching further.
1786           */
1787          if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1788 +        {
1789 +          va_end(args);
1790            return 1;
1791 +        }
1792        }
1793      }
1794    }
1795  
1796    if (warn)
1797 <    sendto_one(source_p, ":%s NOTICE %s :Please include at least %d non-wildcard characters with the mask",
1798 <               me.name, source_p->name, ConfigFileEntry.min_nonwildcard);
1797 >    sendto_one_notice(source_p, &me,
1798 >                      ":Please include at least %u non-wildcard characters with the mask",
1799 >                      ConfigFileEntry.min_nonwildcard);
1800 >  va_end(args);
1801    return 0;
1802   }
1803  
# Line 3043 | Line 1811 | valid_wild_card(struct Client *source_p,
1811   *              - parse_flags bit map of things to test
1812   *              - pointer to user or string to parse into
1813   *              - pointer to host or NULL to parse into if non NULL
1814 < *              - pointer to optional tkline time or NULL
1814 > *              - pointer to optional tkline time or NULL
1815   *              - pointer to target_server to parse into if non NULL
1816   *              - pointer to reason to parse into
1817   *
# Line 3065 | Line 1833 | valid_wild_card(struct Client *source_p,
1833   */
1834   int
1835   parse_aline(const char *cmd, struct Client *source_p,
1836 <            int parc, char **parv,
1837 <            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1838 <            char **target_server, char **reason)
1836 >            int parc, char **parv,
1837 >            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1838 >            char **target_server, char **reason)
1839   {
1840    int found_tkline_time=0;
1841 <  static char def_reason[] = "No Reason";
1841 >  static char def_reason[] = CONF_NOREASON;
1842    static char user[USERLEN*4+1];
1843    static char host[HOSTLEN*4+1];
1844  
# Line 3088 | Line 1856 | parse_aline(const char *cmd, struct Clie
1856        *tkline_time = found_tkline_time;
1857      else
1858      {
1859 <      sendto_one(source_p, ":%s NOTICE %s :temp_line not supported by %s",
3092 <                 me.name, source_p->name, cmd);
1859 >      sendto_one_notice(source_p, &me, ":temp_line not supported by %s", cmd);
1860        return -1;
1861      }
1862    }
1863  
1864    if (parc == 0)
1865    {
1866 <    sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
3100 <               me.name, source_p->name, cmd);
1866 >    sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1867      return -1;
1868    }
1869  
# Line 3111 | Line 1877 | parse_aline(const char *cmd, struct Clie
1877      *up_p = user;
1878      *h_p = host;
1879    }
1880 <
1880 >
1881    parc--;
1882    parv++;
1883  
# Line 3124 | Line 1890 | parse_aline(const char *cmd, struct Clie
1890  
1891        if (target_server == NULL)
1892        {
1893 <        sendto_one(source_p, ":%s NOTICE %s :ON server not supported by %s",
1894 <                   me.name, source_p->name, cmd);
3129 <        return -1;
1893 >        sendto_one_notice(source_p, &me, ":ON server not supported by %s", cmd);
1894 >        return -1;
1895        }
1896  
1897        if (!HasOFlag(source_p, OPER_FLAG_REMOTEBAN))
1898        {
1899 <        sendto_one(source_p, form_str(ERR_NOPRIVS),
3135 <                   me.name, source_p->name, "remoteban");
1899 >        sendto_one_numeric(source_p, &me, ERR_NOPRIVS, "remoteban");
1900          return -1;
1901        }
1902  
1903        if (parc == 0 || EmptyString(*parv))
1904        {
1905 <        sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
1906 <                   me.name, source_p->name, cmd);
3143 <        return -1;
1905 >        sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1906 >        return -1;
1907        }
1908  
1909        *target_server = *parv;
# Line 3153 | Line 1916 | parse_aline(const char *cmd, struct Clie
1916         * caller probably NULL'd it first, but no harm to do it again -db
1917         */
1918        if (target_server != NULL)
1919 <        *target_server = NULL;
1919 >        *target_server = NULL;
1920      }
1921    }
1922  
# Line 3161 | Line 1924 | parse_aline(const char *cmd, struct Clie
1924    {
1925      if (strchr(user, '!') != NULL)
1926      {
1927 <      sendto_one(source_p, ":%s NOTICE %s :Invalid character '!' in kline",
3165 <                 me.name, source_p->name);
1927 >      sendto_one_notice(source_p, &me, ":Invalid character '!' in kline");
1928        return -1;
1929      }
1930  
# Line 3179 | Line 1941 | parse_aline(const char *cmd, struct Clie
1941      {
1942        *reason = *parv;
1943        if (!valid_comment(source_p, *reason, 1))
1944 <        return -1;
1944 >        return -1;
1945      }
1946      else
1947        *reason = def_reason;
# Line 3218 | Line 1980 | find_user_host(struct Client *source_p,
1980      {
1981        *(hostp++) = '\0';                       /* short and squat */
1982        if (*user_host_or_nick)
1983 <        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1983 >        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
1984        else
1985 <        strcpy(luser, "*");
1985 >        strcpy(luser, "*");
1986 >
1987        if (*hostp)
1988 <        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
1988 >        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
1989        else
1990 <        strcpy(lhost, "*");
1990 >        strcpy(lhost, "*");
1991      }
1992      else
1993      {
1994        luser[0] = '*';             /* no @ found, assume its *@somehost */
1995 <      luser[1] = '\0';    
1995 >      luser[1] = '\0';
1996        strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
1997      }
1998 <    
1998 >
1999      return 1;
2000    }
2001 <  else if (!(flags & NOUSERLOOKUP))
2001 >  else
2002    {
2003      /* Try to find user@host mask from nick */
2004      /* Okay to use source_p as the first param, because source_p == client_p */
2005 <    if ((target_p =
2006 <        find_chasing(source_p, source_p, user_host_or_nick, NULL)) == NULL)
2007 <      return 0;
2005 >    if ((target_p =
2006 >        find_chasing(source_p, user_host_or_nick)) == NULL)
2007 >      return 0;  /* find_chasing sends ERR_NOSUCHNICK */
2008  
2009      if (IsExemptKline(target_p))
2010      {
2011        if (!IsServer(source_p))
2012 <        sendto_one(source_p,
3250 <                   ":%s NOTICE %s :%s is E-lined",
3251 <                   me.name, source_p->name, target_p->name);
2012 >        sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
2013        return 0;
2014      }
2015  
# Line 3283 | Line 2044 | find_user_host(struct Client *source_p,
2044   int
2045   valid_comment(struct Client *source_p, char *comment, int warn)
2046   {
3286 –  if (strchr(comment, '"'))
3287 –  {
3288 –    if (warn)
3289 –      sendto_one(source_p, ":%s NOTICE %s :Invalid character '\"' in comment",
3290 –                 me.name, source_p->name);
3291 –    return 0;
3292 –  }
3293 –
2047    if (strlen(comment) > REASONLEN)
2048      comment[REASONLEN-1] = '\0';
2049  
# Line 3305 | Line 2058 | valid_comment(struct Client *source_p, c
2058   * side effects - none
2059   */
2060   int
2061 < match_conf_password(const char *password, const struct AccessItem *aconf)
2061 > match_conf_password(const char *password, const struct MaskItem *conf)
2062   {
2063    const char *encr = NULL;
2064  
2065 <  if (EmptyString(password) || EmptyString(aconf->passwd))
2065 >  if (EmptyString(password) || EmptyString(conf->passwd))
2066      return 0;
2067  
2068 <  if (aconf->flags & CONF_FLAGS_ENCRYPTED)
2069 <    encr = crypt(password, aconf->passwd);
2068 >  if (conf->flags & CONF_FLAGS_ENCRYPTED)
2069 >    encr = crypt(password, conf->passwd);
2070    else
2071      encr = password;
2072  
2073 <  return !strcmp(encr, aconf->passwd);
2073 >  return encr && !strcmp(encr, conf->passwd);
2074   }
2075  
2076   /*
# Line 3325 | Line 2078 | match_conf_password(const char *password
2078   *
2079   * inputs       - client sending the cluster
2080   *              - command name "KLINE" "XLINE" etc.
2081 < *              - capab -- CAP_KLN etc. from s_serv.h
2081 > *              - capab -- CAP_KLN etc. from server.h
2082   *              - cluster type -- CLUSTER_KLINE etc. from conf.h
2083   *              - pattern and args to send along
2084   * output       - none
# Line 3337 | Line 2090 | cluster_a_line(struct Client *source_p,
2090                 int capab, int cluster_type, const char *pattern, ...)
2091   {
2092    va_list args;
2093 <  char buffer[IRCD_BUFSIZE];
2093 >  char buffer[IRCD_BUFSIZE] = "";
2094    const dlink_node *ptr = NULL;
2095  
2096    va_start(args, pattern);
# Line 3346 | Line 2099 | cluster_a_line(struct Client *source_p,
2099  
2100    DLINK_FOREACH(ptr, cluster_items.head)
2101    {
2102 <    const struct ConfItem *conf = ptr->data;
2102 >    const struct MaskItem *conf = ptr->data;
2103  
2104      if (conf->flags & cluster_type)
2105        sendto_match_servs(source_p, conf->name, CAP_CLUSTER|capab,
2106 <                         "%s %s %s", command, conf->name, buffer);
2106 >                         "%s %s %s", command, conf->name, buffer);
2107    }
2108   }
2109  
# Line 3398 | Line 2151 | split_nuh(struct split_nuh_item *const i
2151    {
2152      *p = '\0';
2153  
2154 <    if (iptr->nickptr && *iptr->nuhmask != '\0')
2154 >    if (iptr->nickptr && *iptr->nuhmask)
2155        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
2156  
2157 <    if ((q = strchr(++p, '@'))) {
2157 >    if ((q = strchr(++p, '@')))
2158 >    {
2159        *q++ = '\0';
2160  
2161 <      if (*p != '\0')
2161 >      if (*p)
2162          strlcpy(iptr->userptr, p, iptr->usersize);
2163  
2164 <      if (*q != '\0')
2164 >      if (*q)
2165          strlcpy(iptr->hostptr, q, iptr->hostsize);
2166      }
2167      else
2168      {
2169 <      if (*p != '\0')
2169 >      if (*p)
2170          strlcpy(iptr->userptr, p, iptr->usersize);
2171      }
2172    }
# Line 3424 | Line 2178 | split_nuh(struct split_nuh_item *const i
2178        /* if found a @ */
2179        *p++ = '\0';
2180  
2181 <      if (*iptr->nuhmask != '\0')
2181 >      if (*iptr->nuhmask)
2182          strlcpy(iptr->userptr, iptr->nuhmask, iptr->usersize);
2183  
2184 <      if (*p != '\0')
2184 >      if (*p)
2185          strlcpy(iptr->hostptr, p, iptr->hostsize);
2186      }
2187      else
# Line 3440 | Line 2194 | split_nuh(struct split_nuh_item *const i
2194      }
2195    }
2196   }
3443 –
3444 – /*
3445 – * flags_to_ascii
3446 – *
3447 – * inputs       - flags is a bitmask
3448 – *              - pointer to table of ascii letters corresponding
3449 – *                to each bit
3450 – *              - flag 1 for convert ToLower if bit missing
3451 – *                0 if ignore.
3452 – * output       - none
3453 – * side effects - string pointed to by p has bitmap chars written to it
3454 – */
3455 – static void
3456 – flags_to_ascii(unsigned int flags, const unsigned int bit_table[], char *p,
3457 –               int lowerit)
3458 – {
3459 –  unsigned int mask = 1;
3460 –  int i = 0;
3461 –
3462 –  for (mask = 1; (mask != 0) && (bit_table[i] != 0); mask <<= 1, i++)
3463 –  {
3464 –    if (flags & mask)
3465 –      *p++ = bit_table[i];
3466 –    else if (lowerit)
3467 –      *p++ = ToLower(bit_table[i]);
3468 –  }
3469 –  *p = '\0';
3470 – }
3471 –
3472 – /*
3473 – * cidr_limit_reached
3474 – *
3475 – * inputs       - int flag allowing over_rule of limits
3476 – *              - pointer to the ip to be added
3477 – *              - pointer to the class
3478 – * output       - non zero if limit reached
3479 – *                0 if limit not reached
3480 – * side effects -
3481 – */
3482 – static int
3483 – cidr_limit_reached(int over_rule,
3484 –                   struct irc_ssaddr *ip, struct ClassItem *aclass)
3485 – {
3486 –  dlink_node *ptr = NULL;
3487 –  struct CidrItem *cidr;
3488 –
3489 –  if (aclass->number_per_cidr <= 0)
3490 –    return 0;
3491 –
3492 –  if (ip->ss.ss_family == AF_INET)
3493 –  {
3494 –    if (aclass->cidr_bitlen_ipv4 <= 0)
3495 –      return 0;
3496 –
3497 –    DLINK_FOREACH(ptr, aclass->list_ipv4.head)
3498 –    {
3499 –      cidr = ptr->data;
3500 –      if (match_ipv4(ip, &cidr->mask, aclass->cidr_bitlen_ipv4))
3501 –      {
3502 –        if (!over_rule && (cidr->number_on_this_cidr >= aclass->number_per_cidr))
3503 –          return -1;
3504 –        cidr->number_on_this_cidr++;
3505 –        return 0;
3506 –      }
3507 –    }
3508 –    cidr = MyMalloc(sizeof(struct CidrItem));
3509 –    cidr->number_on_this_cidr = 1;
3510 –    cidr->mask = *ip;
3511 –    mask_addr(&cidr->mask, aclass->cidr_bitlen_ipv4);
3512 –    dlinkAdd(cidr, &cidr->node, &aclass->list_ipv4);
3513 –  }
3514 – #ifdef IPV6
3515 –  else if (aclass->cidr_bitlen_ipv6 > 0)
3516 –  {
3517 –    DLINK_FOREACH(ptr, aclass->list_ipv6.head)
3518 –    {
3519 –      cidr = ptr->data;
3520 –      if (match_ipv6(ip, &cidr->mask, aclass->cidr_bitlen_ipv6))
3521 –      {
3522 –        if (!over_rule && (cidr->number_on_this_cidr >= aclass->number_per_cidr))
3523 –          return -1;
3524 –        cidr->number_on_this_cidr++;
3525 –        return 0;
3526 –      }
3527 –    }
3528 –    cidr = MyMalloc(sizeof(struct CidrItem));
3529 –    cidr->number_on_this_cidr = 1;
3530 –    cidr->mask = *ip;
3531 –    mask_addr(&cidr->mask, aclass->cidr_bitlen_ipv6);
3532 –    dlinkAdd(cidr, &cidr->node, &aclass->list_ipv6);
3533 –  }
3534 – #endif
3535 –  return 0;
3536 – }
3537 –
3538 – /*
3539 – * remove_from_cidr_check
3540 – *
3541 – * inputs       - pointer to the ip to be removed
3542 – *              - pointer to the class
3543 – * output       - NONE
3544 – * side effects -
3545 – */
3546 – static void
3547 – remove_from_cidr_check(struct irc_ssaddr *ip, struct ClassItem *aclass)
3548 – {
3549 –  dlink_node *ptr = NULL;
3550 –  dlink_node *next_ptr = NULL;
3551 –  struct CidrItem *cidr;
3552 –
3553 –  if (aclass->number_per_cidr == 0)
3554 –    return;
3555 –
3556 –  if (ip->ss.ss_family == AF_INET)
3557 –  {
3558 –    if (aclass->cidr_bitlen_ipv4 <= 0)
3559 –      return;
3560 –
3561 –    DLINK_FOREACH_SAFE(ptr, next_ptr, aclass->list_ipv4.head)
3562 –    {
3563 –      cidr = ptr->data;
3564 –      if (match_ipv4(ip, &cidr->mask, aclass->cidr_bitlen_ipv4))
3565 –      {
3566 –        cidr->number_on_this_cidr--;
3567 –        if (cidr->number_on_this_cidr == 0)
3568 –        {
3569 –          dlinkDelete(ptr, &aclass->list_ipv4);
3570 –          MyFree(cidr);
3571 –          return;
3572 –        }
3573 –      }
3574 –    }
3575 –  }
3576 – #ifdef IPV6
3577 –  else if (aclass->cidr_bitlen_ipv6 > 0)
3578 –  {
3579 –    DLINK_FOREACH_SAFE(ptr, next_ptr, aclass->list_ipv6.head)
3580 –    {
3581 –      cidr = ptr->data;
3582 –      if (match_ipv6(ip, &cidr->mask, aclass->cidr_bitlen_ipv6))
3583 –      {
3584 –        cidr->number_on_this_cidr--;
3585 –        if (cidr->number_on_this_cidr == 0)
3586 –        {
3587 –          dlinkDelete(ptr, &aclass->list_ipv6);
3588 –          MyFree(cidr);
3589 –          return;
3590 –        }
3591 –      }
3592 –    }
3593 –  }
3594 – #endif
3595 – }
3596 –
3597 – static void
3598 – rebuild_cidr_list(int aftype, struct ConfItem *oldcl, struct ClassItem *newcl,
3599 –                  dlink_list *old_list, dlink_list *new_list, int changed)
3600 – {
3601 –  dlink_node *ptr;
3602 –  struct Client *client_p;
3603 –  struct ConfItem *conf;
3604 –  struct AccessItem *aconf;
3605 –
3606 –  if (!changed)
3607 –  {
3608 –    *new_list = *old_list;
3609 –    old_list->head = old_list->tail = NULL;
3610 –    old_list->length = 0;
3611 –    return;
3612 –  }
3613 –
3614 –  DLINK_FOREACH(ptr, local_client_list.head)
3615 –  {
3616 –    client_p = ptr->data;
3617 –    if (client_p->localClient->aftype != aftype)
3618 –      continue;
3619 –    if (dlink_list_length(&client_p->localClient->confs) == 0)
3620 –      continue;
3621 –
3622 –    conf = client_p->localClient->confs.tail->data;
3623 –    if (conf->type == CLIENT_TYPE)
3624 –    {
3625 –      aconf = map_to_conf(conf);
3626 –      if (aconf->class_ptr == oldcl)
3627 –        cidr_limit_reached(1, &client_p->localClient->ip, newcl);
3628 –    }
3629 –  }
3630 – }
3631 –
3632 – /*
3633 – * rebuild_cidr_class
3634 – *
3635 – * inputs       - pointer to old conf
3636 – *              - pointer to new_class
3637 – * output       - none
3638 – * side effects - rebuilds the class link list of cidr blocks
3639 – */
3640 – void
3641 – rebuild_cidr_class(struct ConfItem *conf, struct ClassItem *new_class)
3642 – {
3643 –  struct ClassItem *old_class = map_to_conf(conf);
3644 –
3645 –  if (old_class->number_per_cidr > 0 && new_class->number_per_cidr > 0)
3646 –  {
3647 –    if (old_class->cidr_bitlen_ipv4 > 0 && new_class->cidr_bitlen_ipv4 > 0)
3648 –      rebuild_cidr_list(AF_INET, conf, new_class,
3649 –                        &old_class->list_ipv4, &new_class->list_ipv4,
3650 –                        old_class->cidr_bitlen_ipv4 != new_class->cidr_bitlen_ipv4);
3651 –
3652 – #ifdef IPV6
3653 –    if (old_class->cidr_bitlen_ipv6 > 0 && new_class->cidr_bitlen_ipv6 > 0)
3654 –      rebuild_cidr_list(AF_INET6, conf, new_class,
3655 –                        &old_class->list_ipv6, &new_class->list_ipv6,
3656 –                        old_class->cidr_bitlen_ipv6 != new_class->cidr_bitlen_ipv6);
3657 – #endif
3658 –  }
3659 –
3660 –  destroy_cidr_class(old_class);
3661 – }
3662 –
3663 – /*
3664 – * destroy_cidr_list
3665 – *
3666 – * inputs       - pointer to class dlink list of cidr blocks
3667 – * output       - none
3668 – * side effects - completely destroys the class link list of cidr blocks
3669 – */
3670 – static void
3671 – destroy_cidr_list(dlink_list *list)
3672 – {
3673 –  dlink_node *ptr = NULL, *next_ptr = NULL;
3674 –
3675 –  DLINK_FOREACH_SAFE(ptr, next_ptr, list->head)
3676 –  {
3677 –    dlinkDelete(ptr, list);
3678 –    MyFree(ptr->data);
3679 –  }
3680 – }
3681 –
3682 – /*
3683 – * destroy_cidr_class
3684 – *
3685 – * inputs       - pointer to class
3686 – * output       - none
3687 – * side effects - completely destroys the class link list of cidr blocks
3688 – */
3689 – static void
3690 – destroy_cidr_class(struct ClassItem *aclass)
3691 – {
3692 –  destroy_cidr_list(&aclass->list_ipv4);
3693 –  destroy_cidr_list(&aclass->list_ipv6);
3694 – }

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)