ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing:
ircd-hybrid-8/src/conf.c (file contents), Revision 1393 by michael, Wed May 2 19:17:37 2012 UTC vs.
ircd-hybrid/trunk/src/conf.c (file contents), Revision 3929 by michael, Mon Jun 9 14:56:25 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  conf.c: Configuration file functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 18 | Line 17
17   *  along with this program; if not, write to the Free Software
18   *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file conf.c
23 > * \brief Configuration file functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29   #include "ircd_defs.h"
28 – #include "balloc.h"
30   #include "conf.h"
31 < #include "s_serv.h"
31 > #include "server.h"
32   #include "resv.h"
33   #include "channel.h"
34   #include "client.h"
35   #include "event.h"
35 – #include "hook.h"
36   #include "irc_string.h"
37   #include "s_bsd.h"
38   #include "ircd.h"
# Line 43 | Line 43
43   #include "fdlist.h"
44   #include "log.h"
45   #include "send.h"
46 – #include "s_gline.h"
46   #include "memory.h"
47 < #include "irc_res.h"
47 > #include "mempool.h"
48 > #include "res.h"
49   #include "userhost.h"
50 < #include "s_user.h"
50 > #include "user.h"
51   #include "channel_mode.h"
52   #include "parse.h"
53 < #include "s_misc.h"
53 > #include "misc.h"
54 > #include "conf_db.h"
55 > #include "conf_class.h"
56 > #include "motd.h"
57  
58 < struct Callback *client_check_cb = NULL;
58 >
59 > struct config_channel_entry ConfigChannel;
60   struct config_server_hide ConfigServerHide;
61 + struct config_file_entry ConfigFileEntry;
62 + struct logging_entry ConfigLoggingEntry = { .use_logging = 1 };
63 + struct server_info ServerInfo;
64 + struct admin_info AdminInfo;
65  
66   /* general conf items link list root, other than k lines etc. */
67   dlink_list service_items = { NULL, NULL, 0 };
# Line 62 | Line 70 | dlink_list cluster_items = { NULL, NULL,
70   dlink_list oconf_items   = { NULL, NULL, 0 };
71   dlink_list uconf_items   = { NULL, NULL, 0 };
72   dlink_list xconf_items   = { NULL, NULL, 0 };
65 – dlink_list rxconf_items  = { NULL, NULL, 0 };
66 – dlink_list rkconf_items  = { NULL, NULL, 0 };
73   dlink_list nresv_items   = { NULL, NULL, 0 };
74 < dlink_list class_items   = { NULL, NULL, 0 };
69 < dlink_list gdeny_items   = { NULL, NULL, 0 };
70 <
71 < dlink_list temporary_xlines  = { NULL, NULL, 0 };
72 < dlink_list temporary_resv = { NULL, NULL, 0 };
74 > dlink_list cresv_items = { NULL, NULL, 0 };
75  
76   extern unsigned int lineno;
77   extern char linebuf[];
# Line 81 | Line 83 | struct conf_parser_context conf_parser_c
83   /* internally defined functions */
84   static void read_conf(FILE *);
85   static void clear_out_old_conf(void);
84 – static void flush_deleted_I_P(void);
86   static void expire_tklines(dlink_list *);
87   static void garbage_collect_ip_entries(void);
88   static int hash_ip(struct irc_ssaddr *);
89 < static int verify_access(struct Client *, const char *);
90 < static int attach_iline(struct Client *, struct ConfItem *);
89 > static int verify_access(struct Client *);
90 > static int attach_iline(struct Client *, struct MaskItem *);
91   static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
92 < static void parse_conf_file(int, int);
92 < static dlink_list *map_to_list(ConfType);
93 < static struct AccessItem *find_regexp_kline(const char *[]);
92 > static dlink_list *map_to_list(enum maskitem_type);
93   static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
94  
96 – /*
97 – * bit_len
98 – */
99 – static int cidr_limit_reached(int, struct irc_ssaddr *, struct ClassItem *);
100 – static void remove_from_cidr_check(struct irc_ssaddr *, struct ClassItem *);
101 – static void destroy_cidr_class(struct ClassItem *);
102 –
103 – static void flags_to_ascii(unsigned int, const unsigned int[], char *, int);
104 –
105 – /* address of default class conf */
106 – static struct ConfItem *class_default;
95  
96   /* usually, with hash tables, you use a prime number...
97   * but in this case I am dealing with ip addresses,
# Line 114 | Line 102 | static struct ConfItem *class_default;
102   struct ip_entry
103   {
104    struct irc_ssaddr ip;
105 <  int count;
106 <  time_t last_attempt;
105 >  unsigned int count;  /**< Number of registered users using this IP */
106 >  unsigned int connection_count;  /**< Number of connections from this IP in the last throttle_time duration */
107 >  time_t last_attempt;  /**< The last time someone connected from this IP */
108    struct ip_entry *next;
109   };
110  
111   static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
112 < static BlockHeap *ip_entry_heap = NULL;
112 > static mp_pool_t *ip_entry_pool = NULL;
113   static int ip_entries_count = 0;
114  
115  
127 – void *
128 – map_to_conf(struct ConfItem *aconf)
129 – {
130 –  void *conf;
131 –  conf = (void *)((uintptr_t)aconf +
132 –                  (uintptr_t)sizeof(struct ConfItem));
133 –  return(conf);
134 – }
135 –
136 – struct ConfItem *
137 – unmap_conf_item(void *aconf)
138 – {
139 –  struct ConfItem *conf;
140 –
141 –  conf = (struct ConfItem *)((uintptr_t)aconf -
142 –                             (uintptr_t)sizeof(struct ConfItem));
143 –  return(conf);
144 – }
145 –
116   /* conf_dns_callback()
117   *
118 < * inputs       - pointer to struct AccessItem
118 > * inputs       - pointer to struct MaskItem
119   *              - pointer to DNSReply reply
120   * output       - none
121   * side effects - called when resolver query finishes
# Line 156 | Line 126 | unmap_conf_item(void *aconf)
126   static void
127   conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
128   {
129 <  struct AccessItem *aconf = vptr;
129 >  struct MaskItem *conf = vptr;
130  
131 <  aconf->dns_pending = 0;
131 >  conf->dns_pending = 0;
132  
133 <  if (addr != NULL)
134 <    memcpy(&aconf->addr, addr, sizeof(aconf->addr));
133 >  if (addr)
134 >    memcpy(&conf->addr, addr, sizeof(conf->addr));
135    else
136 <    aconf->dns_failed = 1;
136 >    conf->dns_failed = 1;
137   }
138  
139   /* conf_dns_lookup()
# Line 173 | Line 143 | conf_dns_callback(void *vptr, const stru
143   * allocate a dns_query and start ns lookup.
144   */
145   static void
146 < conf_dns_lookup(struct AccessItem *aconf)
146 > conf_dns_lookup(struct MaskItem *conf)
147   {
148 <  if (!aconf->dns_pending)
148 >  if (!conf->dns_pending)
149    {
150 <    aconf->dns_pending = 1;
151 <    gethost_byname(conf_dns_callback, aconf, aconf->host);
150 >    conf->dns_pending = 1;
151 >    gethost_byname(conf_dns_callback, conf, conf->host);
152    }
153   }
154  
155 < /* make_conf_item()
156 < *
187 < * inputs       - type of item
188 < * output       - pointer to new conf entry
189 < * side effects - none
190 < */
191 < struct ConfItem *
192 < make_conf_item(ConfType type)
155 > struct MaskItem *
156 > conf_make(enum maskitem_type type)
157   {
158 <  struct ConfItem *conf = NULL;
159 <  struct AccessItem *aconf = NULL;
196 <  struct ClassItem *aclass = NULL;
197 <  int status = 0;
198 <
199 <  switch (type)
200 <  {
201 <  case DLINE_TYPE:
202 <  case EXEMPTDLINE_TYPE:
203 <  case GLINE_TYPE:
204 <  case KLINE_TYPE:
205 <  case CLIENT_TYPE:
206 <  case OPER_TYPE:
207 <  case SERVER_TYPE:
208 <    conf = MyMalloc(sizeof(struct ConfItem) +
209 <                    sizeof(struct AccessItem));
210 <    aconf = map_to_conf(conf);
211 <    aconf->aftype = AF_INET;
212 <
213 <    /* Yes, sigh. switch on type again */
214 <    switch (type)
215 <    {
216 <    case EXEMPTDLINE_TYPE:
217 <      status = CONF_EXEMPTDLINE;
218 <      break;
219 <
220 <    case DLINE_TYPE:
221 <      status = CONF_DLINE;
222 <      break;
223 <
224 <    case KLINE_TYPE:
225 <      status = CONF_KLINE;
226 <      break;
227 <
228 <    case GLINE_TYPE:
229 <      status = CONF_GLINE;
230 <      break;
231 <
232 <    case CLIENT_TYPE:
233 <      status = CONF_CLIENT;
234 <      break;
235 <
236 <    case OPER_TYPE:
237 <      status = CONF_OPERATOR;
238 <      dlinkAdd(conf, &conf->node, &oconf_items);
239 <      break;
240 <
241 <    case SERVER_TYPE:
242 <      status = CONF_SERVER;
243 <      dlinkAdd(conf, &conf->node, &server_items);
244 <      break;
245 <
246 <    default:
247 <      break;
248 <    }
249 <    aconf->status = status;
250 <    break;
251 <
252 <  case ULINE_TYPE:
253 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
254 <                                       sizeof(struct MatchItem));
255 <    dlinkAdd(conf, &conf->node, &uconf_items);
256 <    break;
257 <
258 <  case GDENY_TYPE:
259 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
260 <                                       sizeof(struct AccessItem));
261 <    dlinkAdd(conf, &conf->node, &gdeny_items);
262 <    break;
158 >  struct MaskItem *conf = MyCalloc(sizeof(*conf));
159 >  dlink_list *list = NULL;
160  
161 <  case XLINE_TYPE:
162 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
163 <                                       sizeof(struct MatchItem));
267 <    dlinkAdd(conf, &conf->node, &xconf_items);
268 <    break;
269 < #ifdef HAVE_LIBPCRE
270 <  case RXLINE_TYPE:
271 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
272 <                                       sizeof(struct MatchItem));
273 <    dlinkAdd(conf, &conf->node, &rxconf_items);
274 <    break;
275 <
276 <  case RKLINE_TYPE:
277 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
278 <                                       sizeof(struct AccessItem));
279 <    aconf = map_to_conf(conf);
280 <    aconf->status = CONF_KLINE;
281 <    dlinkAdd(conf, &conf->node, &rkconf_items);
282 <    break;
283 < #endif
284 <  case CLUSTER_TYPE:
285 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem));
286 <    dlinkAdd(conf, &conf->node, &cluster_items);
287 <    break;
288 <
289 <  case CRESV_TYPE:
290 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
291 <                                       sizeof(struct ResvChannel));
292 <    break;
293 <
294 <  case NRESV_TYPE:
295 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
296 <                                       sizeof(struct MatchItem));
297 <    dlinkAdd(conf, &conf->node, &nresv_items);
298 <    break;
299 <
300 <  case SERVICE_TYPE:
301 <    status = CONF_SERVICE;
302 <    conf = MyMalloc(sizeof(struct ConfItem));
303 <    dlinkAdd(conf, &conf->node, &service_items);
304 <    break;
305 <
306 <  case CLASS_TYPE:
307 <    conf = MyMalloc(sizeof(struct ConfItem) +
308 <                           sizeof(struct ClassItem));
309 <    dlinkAdd(conf, &conf->node, &class_items);
310 <
311 <    aclass = map_to_conf(conf);
312 <    aclass->active = 1;
313 <    aclass->con_freq = DEFAULT_CONNECTFREQUENCY;
314 <    aclass->ping_freq = DEFAULT_PINGFREQUENCY;
315 <    aclass->max_total = MAXIMUM_LINKS_DEFAULT;
316 <    aclass->max_sendq = DEFAULT_SENDQ;
317 <
318 <    break;
319 <
320 <  default:
321 <    conf = NULL;
322 <    break;
323 <  }
324 <
325 <  /* XXX Yes, this will core if default is hit. I want it to for now - db */
326 <  conf->type = type;
161 >  conf->type   = type;
162 >  conf->active = 1;
163 >  conf->aftype = AF_INET;
164  
165 +  if ((list = map_to_list(type)))
166 +    dlinkAdd(conf, &conf->node, list);
167    return conf;
168   }
169  
170   void
171 < delete_conf_item(struct ConfItem *conf)
171 > conf_free(struct MaskItem *conf)
172   {
173 <  dlink_node *m = NULL, *m_next = NULL;
174 <  struct MatchItem *match_item;
175 <  struct AccessItem *aconf;
176 <  ConfType type = conf->type;
173 >  dlink_node *ptr = NULL, *ptr_next = NULL;
174 >  dlink_list *list = NULL;
175 >
176 >  if (conf->node.next)
177 >    if ((list = map_to_list(conf->type)))
178 >      dlinkDelete(&conf->node, list);
179  
180    MyFree(conf->name);
340 –  conf->name = NULL;
181  
182 <  switch(type)
183 <  {
184 <  case DLINE_TYPE:
185 <  case EXEMPTDLINE_TYPE:
186 <  case GLINE_TYPE:
187 <  case KLINE_TYPE:
188 <  case CLIENT_TYPE:
189 <  case OPER_TYPE:
190 <  case SERVER_TYPE:
191 <    aconf = map_to_conf(conf);
192 <
193 <    if (aconf->dns_pending)
194 <      delete_resolver_queries(aconf);
195 <    if (aconf->passwd != NULL)
196 <      memset(aconf->passwd, 0, strlen(aconf->passwd));
357 <    if (aconf->spasswd != NULL)
358 <      memset(aconf->spasswd, 0, strlen(aconf->spasswd));
359 <    aconf->class_ptr = NULL;
360 <
361 <    MyFree(aconf->passwd);
362 <    MyFree(aconf->spasswd);
363 <    MyFree(aconf->reason);
364 <    MyFree(aconf->oper_reason);
365 <    MyFree(aconf->user);
366 <    MyFree(aconf->host);
367 <    MyFree(aconf->cipher_list);
182 >  if (conf->dns_pending)
183 >    delete_resolver_queries(conf);
184 >  if (conf->passwd)
185 >    memset(conf->passwd, 0, strlen(conf->passwd));
186 >  if (conf->spasswd)
187 >    memset(conf->spasswd, 0, strlen(conf->spasswd));
188 >
189 >  conf->class = NULL;
190 >
191 >  MyFree(conf->passwd);
192 >  MyFree(conf->spasswd);
193 >  MyFree(conf->reason);
194 >  MyFree(conf->certfp);
195 >  MyFree(conf->user);
196 >  MyFree(conf->host);
197   #ifdef HAVE_LIBCRYPTO
198 <    if (aconf->rsa_public_key)
370 <      RSA_free(aconf->rsa_public_key);
371 <    MyFree(aconf->rsa_public_key_file);
372 < #endif
373 <
374 <    /* Yes, sigh. switch on type again */
375 <    switch(type)
376 <    {
377 <    case EXEMPTDLINE_TYPE:
378 <    case DLINE_TYPE:
379 <    case GLINE_TYPE:
380 <    case KLINE_TYPE:
381 <    case CLIENT_TYPE:
382 <      MyFree(conf);
383 <      break;
198 >  MyFree(conf->cipher_list);
199  
200 <    case OPER_TYPE:
201 <      aconf = map_to_conf(conf);
387 <      if (!IsConfIllegal(aconf))
388 <        dlinkDelete(&conf->node, &oconf_items);
389 <      MyFree(conf);
390 <      break;
391 <
392 <    case SERVER_TYPE:
393 <      aconf = map_to_conf(conf);
394 <
395 <      DLINK_FOREACH_SAFE(m, m_next, aconf->hub_list.head)
396 <      {
397 <        MyFree(m->data);
398 <        free_dlink_node(m);
399 <      }
400 <
401 <      DLINK_FOREACH_SAFE(m, m_next, aconf->leaf_list.head)
402 <      {
403 <        MyFree(m->data);
404 <        free_dlink_node(m);  
405 <      }
406 <
407 <      if (!IsConfIllegal(aconf))
408 <        dlinkDelete(&conf->node, &server_items);
409 <      MyFree(conf);
410 <      break;
411 <
412 <    default:
413 <      break;
414 <    }
415 <    break;
416 <
417 <  case ULINE_TYPE:
418 <    match_item = map_to_conf(conf);
419 <    MyFree(match_item->user);
420 <    MyFree(match_item->host);
421 <    MyFree(match_item->reason);
422 <    MyFree(match_item->oper_reason);
423 <    dlinkDelete(&conf->node, &uconf_items);
424 <    MyFree(conf);
425 <    break;
426 <
427 <  case XLINE_TYPE:
428 <    match_item = map_to_conf(conf);
429 <    MyFree(match_item->user);
430 <    MyFree(match_item->host);
431 <    MyFree(match_item->reason);
432 <    MyFree(match_item->oper_reason);
433 <    dlinkDelete(&conf->node, &xconf_items);
434 <    MyFree(conf);
435 <    break;
436 < #ifdef HAVE_LIBPCRE
437 <  case RKLINE_TYPE:
438 <    aconf = map_to_conf(conf);
439 <    MyFree(aconf->regexuser);
440 <    MyFree(aconf->regexhost);
441 <    MyFree(aconf->user);
442 <    MyFree(aconf->host);
443 <    MyFree(aconf->reason);
444 <    MyFree(aconf->oper_reason);
445 <    dlinkDelete(&conf->node, &rkconf_items);
446 <    MyFree(conf);
447 <    break;
448 <
449 <  case RXLINE_TYPE:
450 <    MyFree(conf->regexpname);
451 <    match_item = map_to_conf(conf);
452 <    MyFree(match_item->user);
453 <    MyFree(match_item->host);
454 <    MyFree(match_item->reason);
455 <    MyFree(match_item->oper_reason);
456 <    dlinkDelete(&conf->node, &rxconf_items);
457 <    MyFree(conf);
458 <    break;
200 >  if (conf->rsa_public_key)
201 >    RSA_free(conf->rsa_public_key);
202   #endif
203 <  case NRESV_TYPE:
204 <    match_item = map_to_conf(conf);
205 <    MyFree(match_item->user);
206 <    MyFree(match_item->host);
207 <    MyFree(match_item->reason);
465 <    MyFree(match_item->oper_reason);
466 <    dlinkDelete(&conf->node, &nresv_items);
467 <
468 <    if (conf->flags & CONF_FLAGS_TEMPORARY)
469 <      if ((m = dlinkFindDelete(&temporary_resv, conf)) != NULL)
470 <        free_dlink_node(m);
471 <
472 <    MyFree(conf);
473 <    break;
474 <
475 <  case GDENY_TYPE:
476 <    aconf = map_to_conf(conf);
477 <    MyFree(aconf->user);
478 <    MyFree(aconf->host);
479 <    dlinkDelete(&conf->node, &gdeny_items);
480 <    MyFree(conf);
481 <    break;
482 <
483 <  case CLUSTER_TYPE:
484 <    dlinkDelete(&conf->node, &cluster_items);
485 <    MyFree(conf);
486 <    break;
487 <
488 <  case CRESV_TYPE:
489 <    if (conf->flags & CONF_FLAGS_TEMPORARY)
490 <      if ((m = dlinkFindDelete(&temporary_resv, conf)) != NULL)
491 <        free_dlink_node(m);
492 <
493 <    MyFree(conf);
494 <    break;
495 <
496 <  case CLASS_TYPE:
497 <    dlinkDelete(&conf->node, &class_items);
498 <    MyFree(conf);
499 <    break;
500 <
501 <  case SERVICE_TYPE:
502 <    dlinkDelete(&conf->node, &service_items);
503 <    MyFree(conf);
504 <    break;
505 <
506 <  default:
507 <    break;
203 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->hub_list.head)
204 >  {
205 >    MyFree(ptr->data);
206 >    dlinkDelete(ptr, &conf->hub_list);
207 >    free_dlink_node(ptr);
208    }
509 – }
510 –
511 – /* free_access_item()
512 – *
513 – * inputs       - pointer to conf to free
514 – * output       - none
515 – * side effects - crucial password fields are zeroed, conf is freed
516 – */
517 – void
518 – free_access_item(struct AccessItem *aconf)
519 – {
520 –  struct ConfItem *conf;
209  
210 <  if (aconf == NULL)
523 <    return;
524 <  conf = unmap_conf_item(aconf);
525 <  delete_conf_item(conf);
526 < }
527 <
528 < static const unsigned int shared_bit_table[] =
529 <  { 'K', 'k', 'U', 'X', 'x', 'Y', 'Q', 'q', 'R', 'L', 0};
530 <
531 < /* report_confitem_types()
532 < *
533 < * inputs       - pointer to client requesting confitem report
534 < *              - ConfType to report
535 < * output       - none
536 < * side effects -
537 < */
538 < void
539 < report_confitem_types(struct Client *source_p, ConfType type)
540 < {
541 <  dlink_node *ptr = NULL, *dptr = NULL;
542 <  struct ConfItem *conf = NULL;
543 <  struct AccessItem *aconf = NULL;
544 <  struct MatchItem *matchitem = NULL;
545 <  struct ClassItem *classitem = NULL;
546 <  char buf[12];
547 <  char *p = NULL;
548 <
549 <  switch (type)
210 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->leaf_list.head)
211    {
212 <  case GDENY_TYPE:
213 <    DLINK_FOREACH(ptr, gdeny_items.head)
214 <    {
215 <      conf = ptr->data;
555 <      aconf = map_to_conf(conf);
556 <
557 <      p = buf;
558 <
559 <      if (aconf->flags & GDENY_BLOCK)
560 <        *p++ = 'B';
561 <      else
562 <        *p++ = 'b';
563 <
564 <      if (aconf->flags & GDENY_REJECT)
565 <        *p++ = 'R';
566 <      else
567 <        *p++ = 'r';
568 <
569 <      *p = '\0';
570 <
571 <      sendto_one(source_p, ":%s %d %s V %s@%s %s %s",
572 <                 me.name, RPL_STATSDEBUG, source_p->name,
573 <                 aconf->user, aconf->host, conf->name, buf);
574 <    }
575 <    break;
576 <
577 <  case XLINE_TYPE:
578 <    DLINK_FOREACH(ptr, xconf_items.head)
579 <    {
580 <      conf = ptr->data;
581 <      matchitem = map_to_conf(conf);
582 <
583 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
584 <                 me.name, source_p->name,
585 <                 matchitem->hold ? "x": "X", matchitem->count,
586 <                 conf->name, matchitem->reason);
587 <    }
588 <    break;
589 <
590 < #ifdef HAVE_LIBPCRE
591 <  case RXLINE_TYPE:
592 <    DLINK_FOREACH(ptr, rxconf_items.head)
593 <    {
594 <      conf = ptr->data;
595 <      matchitem = map_to_conf(conf);
596 <
597 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
598 <                 me.name, source_p->name,
599 <                 "XR", matchitem->count,
600 <                 conf->name, matchitem->reason);
601 <    }
602 <    break;
603 <
604 <  case RKLINE_TYPE:
605 <    DLINK_FOREACH(ptr, rkconf_items.head)
606 <    {
607 <      aconf = map_to_conf((conf = ptr->data));
608 <
609 <      sendto_one(source_p, form_str(RPL_STATSKLINE), me.name,
610 <                 source_p->name, "KR", aconf->host, aconf->user,
611 <                 aconf->reason, aconf->oper_reason ? aconf->oper_reason : "");
612 <    }
613 <    break;
614 < #endif
615 <
616 <  case ULINE_TYPE:
617 <    DLINK_FOREACH(ptr, uconf_items.head)
618 <    {
619 <      conf = ptr->data;
620 <      matchitem = map_to_conf(conf);
621 <
622 <      p = buf;
623 <
624 <      /* some of these are redundant for the sake of
625 <       * consistency with cluster{} flags
626 <       */
627 <      *p++ = 'c';
628 <      flags_to_ascii(matchitem->action, shared_bit_table, p, 0);
629 <
630 <      sendto_one(source_p, form_str(RPL_STATSULINE),
631 <                 me.name, source_p->name, conf->name,
632 <                 matchitem->user?matchitem->user: "*",
633 <                 matchitem->host?matchitem->host: "*", buf);
634 <    }
635 <
636 <    DLINK_FOREACH(ptr, cluster_items.head)
637 <    {
638 <      conf = ptr->data;
639 <
640 <      p = buf;
641 <
642 <      *p++ = 'C';
643 <      flags_to_ascii(conf->flags, shared_bit_table, p, 0);
644 <
645 <      sendto_one(source_p, form_str(RPL_STATSULINE),
646 <                 me.name, source_p->name, conf->name,
647 <                 "*", "*", buf);
648 <    }
649 <
650 <    break;
651 <
652 <  case OPER_TYPE:
653 <    DLINK_FOREACH(ptr, oconf_items.head)
654 <    {
655 <      conf = ptr->data;
656 <      aconf = map_to_conf(conf);
657 <
658 <      /* Don't allow non opers to see oper privs */
659 <      if (HasUMode(source_p, UMODE_OPER))
660 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
661 <                   me.name, source_p->name, 'O', aconf->user, aconf->host,
662 <                   conf->name, oper_privs_as_string(aconf->port),
663 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
664 <      else
665 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
666 <                   me.name, source_p->name, 'O', aconf->user, aconf->host,
667 <                   conf->name, "0",
668 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
669 <    }
670 <    break;
671 <
672 <  case CLASS_TYPE:
673 <    DLINK_FOREACH(ptr, class_items.head)
674 <    {
675 <      conf = ptr->data;
676 <      classitem = map_to_conf(conf);
677 <      sendto_one(source_p, form_str(RPL_STATSYLINE),
678 <                 me.name, source_p->name, 'Y',
679 <                 conf->name, classitem->ping_freq,
680 <                 classitem->con_freq,
681 <                 classitem->max_total, classitem->max_sendq,
682 <                 classitem->curr_user_count,
683 <                 classitem->active ? "active" : "disabled");
684 <    }
685 <    break;
686 <
687 <  case CONF_TYPE:
688 <  case CLIENT_TYPE:
689 <    break;
690 <
691 <  case SERVICE_TYPE:
692 <    DLINK_FOREACH(ptr, service_items.head)
693 <    {
694 <      conf = ptr->data;
695 <      sendto_one(source_p, form_str(RPL_STATSSERVICE),
696 <                 me.name, source_p->name, 'S', "*", conf->name, 0, 0);
697 <    }
698 <    break;
699 <
700 <  case SERVER_TYPE:
701 <    DLINK_FOREACH(ptr, server_items.head)
702 <    {
703 <      p = buf;
704 <
705 <      conf = ptr->data;
706 <      aconf = map_to_conf(conf);
707 <
708 <      buf[0] = '\0';
709 <
710 <      if (IsConfAllowAutoConn(aconf))
711 <        *p++ = 'A';
712 <      if (IsConfSSL(aconf))
713 <        *p++ = 'S';
714 <      if (IsConfTopicBurst(aconf))
715 <        *p++ = 'T';
716 <      if (buf[0] == '\0')
717 <        *p++ = '*';
718 <
719 <      *p = '\0';
720 <
721 <      /*
722 <       * Allow admins to see actual ips unless hide_server_ips is enabled
723 <       */
724 <      if (!ConfigServerHide.hide_server_ips && HasUMode(source_p, UMODE_ADMIN))
725 <        sendto_one(source_p, form_str(RPL_STATSCLINE),
726 <                   me.name, source_p->name, 'C', aconf->host,
727 <                   buf, conf->name, aconf->port,
728 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
729 <        else
730 <          sendto_one(source_p, form_str(RPL_STATSCLINE),
731 <                     me.name, source_p->name, 'C',
732 <                     "*@127.0.0.1", buf, conf->name, aconf->port,
733 <                     aconf->class_ptr ? aconf->class_ptr->name : "<default>");
734 <    }
735 <    break;
736 <
737 <  case HUB_TYPE:
738 <    DLINK_FOREACH(ptr, server_items.head)
739 <    {
740 <      conf = ptr->data;
741 <      aconf = map_to_conf(conf);
742 <
743 <      DLINK_FOREACH(dptr, aconf->hub_list.head)
744 <        sendto_one(source_p, form_str(RPL_STATSHLINE), me.name,
745 <                   source_p->name, 'H', dptr->data, conf->name, 0, "*");
746 <    }
747 <    break;
748 <
749 <  case LEAF_TYPE:
750 <    DLINK_FOREACH(ptr, server_items.head)
751 <    {
752 <      conf = ptr->data;
753 <      aconf = map_to_conf(conf);
212 >    MyFree(ptr->data);
213 >    dlinkDelete(ptr, &conf->leaf_list);
214 >    free_dlink_node(ptr);
215 >  }
216  
217 <      DLINK_FOREACH(dptr, aconf->leaf_list.head)
218 <        sendto_one(source_p, form_str(RPL_STATSLLINE), me.name,
219 <                   source_p->name, 'L', dptr->data, conf->name, 0, "*");
758 <    }
759 <    break;
217 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->exempt_list.head)
218 >  {
219 >    struct exempt *exptr = ptr->data;
220  
221 <  case GLINE_TYPE:
222 <  case KLINE_TYPE:
223 <  case DLINE_TYPE:
224 <  case EXEMPTDLINE_TYPE:
225 <  case CRESV_TYPE:
766 <  case NRESV_TYPE:
767 <  case CLUSTER_TYPE:
768 <  default:
769 <    break;
221 >    dlinkDelete(ptr, &conf->exempt_list);
222 >    MyFree(exptr->name);
223 >    MyFree(exptr->user);
224 >    MyFree(exptr->host);
225 >    MyFree(exptr);
226    }
227 +
228 +  MyFree(conf);
229   }
230  
231   /* check_client()
# Line 783 | Line 241 | report_confitem_types(struct Client *sou
241   *                Look for conf lines which have the same
242   *                status as the flags passed.
243   */
244 < static void *
245 < check_client(va_list args)
244 > int
245 > check_client(struct Client *source_p)
246   {
789 –  struct Client *source_p = va_arg(args, struct Client *);
790 –  const char *username = va_arg(args, const char *);
247    int i;
248 <
249 <  /* I'm already in big trouble if source_p->localClient is NULL -db */
250 <  if ((i = verify_access(source_p, username)))
795 <    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
248 >
249 >  if ((i = verify_access(source_p)))
250 >    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
251           source_p->name, source_p->sockhost);
252  
253    switch (i)
254    {
255      case TOO_MANY:
256 <      sendto_realops_flags(UMODE_FULL, L_ALL,
256 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
257                             "Too many on IP for %s (%s).",
258 <                           get_client_name(source_p, SHOW_IP),
259 <                           source_p->sockhost);
258 >                           get_client_name(source_p, SHOW_IP),
259 >                           source_p->sockhost);
260        ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
261 <           get_client_name(source_p, SHOW_IP));
261 >           get_client_name(source_p, SHOW_IP));
262        ++ServerStats.is_ref;
263 <      exit_client(source_p, &me, "No more connections allowed on that IP");
263 >      exit_client(source_p, "No more connections allowed on that IP");
264        break;
265  
266      case I_LINE_FULL:
267 <      sendto_realops_flags(UMODE_FULL, L_ALL,
268 <                           "I-line is full for %s (%s).",
269 <                           get_client_name(source_p, SHOW_IP),
270 <                           source_p->sockhost);
267 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
268 >                           "auth{} block is full for %s (%s).",
269 >                           get_client_name(source_p, SHOW_IP),
270 >                           source_p->sockhost);
271        ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
272 <           get_client_name(source_p, SHOW_IP));
272 >           get_client_name(source_p, SHOW_IP));
273        ++ServerStats.is_ref;
274 <      exit_client(source_p, &me,
820 <                "No more connections allowed in your connection class");
274 >      exit_client(source_p, "No more connections allowed in your connection class");
275        break;
276  
277      case NOT_AUTHORIZED:
278        ++ServerStats.is_ref;
279        /* jdc - lists server name & port connections are on */
280        /*       a purely cosmetical change */
281 <      sendto_realops_flags(UMODE_UNAUTH, L_ALL,
282 <                           "Unauthorized client connection from %s [%s] on [%s/%u].",
283 <                           get_client_name(source_p, SHOW_IP),
284 <                           source_p->sockhost,
285 <                           source_p->localClient->listener->name,
286 <                           source_p->localClient->listener->port);
281 >      sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
282 >                           "Unauthorized client connection from %s [%s] on [%s/%u].",
283 >                           get_client_name(source_p, SHOW_IP),
284 >                           source_p->sockhost,
285 >                           source_p->localClient->listener->name,
286 >                           source_p->localClient->listener->port);
287        ilog(LOG_TYPE_IRCD,
288 <          "Unauthorized client connection from %s on [%s/%u].",
289 <          get_client_name(source_p, SHOW_IP),
290 <          source_p->localClient->listener->name,
291 <          source_p->localClient->listener->port);
292 <
293 <      /* XXX It is prolematical whether it is better to use the
840 <       * capture reject code here or rely on the connecting too fast code.
841 <       * - Dianora
842 <       */
843 <      if (REJECT_HOLD_TIME > 0)
844 <      {
845 <        sendto_one(source_p, ":%s NOTICE %s :You are not authorized to use this server",
846 <                   me.name, source_p->name);
847 <        source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
848 <        SetCaptured(source_p);
849 <      }
850 <      else
851 <        exit_client(source_p, &me, "You are not authorized to use this server");
288 >           "Unauthorized client connection from %s on [%s/%u].",
289 >           get_client_name(source_p, SHOW_IP),
290 >           source_p->localClient->listener->name,
291 >           source_p->localClient->listener->port);
292 >
293 >      exit_client(source_p, "You are not authorized to use this server");
294        break;
295  
296     case BANNED_CLIENT:
297 <     /*
856 <      * Don't exit them immediately, play with them a bit.
857 <      * - Dianora
858 <      */
859 <     if (REJECT_HOLD_TIME > 0)
860 <     {
861 <       source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
862 <       SetCaptured(source_p);
863 <     }
864 <     else
865 <       exit_client(source_p, &me, "Banned");
297 >     exit_client(source_p, "Banned");
298       ++ServerStats.is_ref;
299       break;
300  
# Line 871 | Line 303 | check_client(va_list args)
303       break;
304    }
305  
306 <  return (i < 0 ? NULL : source_p);
306 >  return (i < 0 ? 0 : 1);
307   }
308  
309   /* verify_access()
310   *
311   * inputs       - pointer to client to verify
880 – *              - pointer to proposed username
312   * output       - 0 if success -'ve if not
313   * side effect  - find the first (best) I line to attach.
314   */
315   static int
316 < verify_access(struct Client *client_p, const char *username)
316 > verify_access(struct Client *client_p)
317   {
318 <  struct AccessItem *aconf = NULL, *rkconf = NULL;
319 <  struct ConfItem *conf = NULL;
889 <  char non_ident[USERLEN + 1] = { '~', '\0' };
890 <  const char *uhi[3];
318 >  struct MaskItem *conf = NULL;
319 >  char non_ident[USERLEN + 1] = "~";
320  
321    if (IsGotId(client_p))
322    {
323 <    aconf = find_address_conf(client_p->host, client_p->username,
324 <                             &client_p->localClient->ip,
325 <                             client_p->localClient->aftype,
323 >    conf = find_address_conf(client_p->host, client_p->username,
324 >                             &client_p->localClient->ip,
325 >                             client_p->localClient->aftype,
326                               client_p->localClient->passwd);
327    }
328    else
329    {
330 <    strlcpy(non_ident+1, username, sizeof(non_ident)-1);
331 <    aconf = find_address_conf(client_p->host,non_ident,
332 <                             &client_p->localClient->ip,
333 <                             client_p->localClient->aftype,
334 <                             client_p->localClient->passwd);
330 >    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
331 >    conf = find_address_conf(client_p->host,non_ident,
332 >                             &client_p->localClient->ip,
333 >                             client_p->localClient->aftype,
334 >                             client_p->localClient->passwd);
335    }
336  
337 <  uhi[0] = IsGotId(client_p) ? client_p->username : non_ident;
909 <  uhi[1] = client_p->host;
910 <  uhi[2] = client_p->sockhost;
911 <
912 <  rkconf = find_regexp_kline(uhi);
913 <
914 <  if (aconf != NULL)
337 >  if (conf)
338    {
339 <    if (IsConfClient(aconf) && !rkconf)
339 >    if (IsConfClient(conf))
340      {
341 <      conf = unmap_conf_item(aconf);
919 <
920 <      if (IsConfRedir(aconf))
341 >      if (IsConfRedir(conf))
342        {
343 <        sendto_one(client_p, form_str(RPL_REDIR),
344 <                   me.name, client_p->name,
345 <                   conf->name ? conf->name : "",
346 <                   aconf->port);
926 <        return(NOT_AUTHORIZED);
343 >        sendto_one_numeric(client_p, &me, RPL_REDIR,
344 >                           conf->name ? conf->name : "",
345 >                           conf->port);
346 >        return NOT_AUTHORIZED;
347        }
348  
349 <      if (IsConfDoIdentd(aconf))
350 <        SetNeedId(client_p);
349 >      if (IsConfDoIdentd(conf))
350 >        SetNeedId(client_p);
351  
352        /* Thanks for spoof idea amm */
353 <      if (IsConfDoSpoofIp(aconf))
353 >      if (IsConfDoSpoofIp(conf))
354        {
355 <        conf = unmap_conf_item(aconf);
356 <
357 <        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(aconf))
938 <          sendto_realops_flags(UMODE_ALL, L_ADMIN, "%s spoofing: %s as %s",
355 >        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
356 >          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
357 >                               "%s spoofing: %s as %s",
358                                 client_p->name, client_p->host, conf->name);
359          strlcpy(client_p->host, conf->name, sizeof(client_p->host));
360 <        SetIPSpoof(client_p);
360 >        AddFlag(client_p, FLAGS_IP_SPOOFING | FLAGS_AUTH_SPOOF);
361        }
362  
363 <      return(attach_iline(client_p, conf));
363 >      return attach_iline(client_p, conf);
364      }
365 <    else if (rkconf || IsConfKill(aconf) || (ConfigFileEntry.glines && IsConfGline(aconf)))
365 >    else if (IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
366      {
367 <      /* XXX */
368 <      aconf = rkconf ? rkconf : aconf;
369 <      if (IsConfGline(aconf))
370 <        sendto_one(client_p, ":%s NOTICE %s :*** G-lined", me.name,
952 <                   client_p->name);
953 <      if (ConfigFileEntry.kline_with_reason)
954 <        sendto_one(client_p, ":%s NOTICE %s :*** Banned %s",
955 <                  me.name, client_p->name, aconf->reason);
956 <      return(BANNED_CLIENT);
367 >      if (IsConfGline(conf))
368 >        sendto_one_notice(client_p, &me, ":*** G-lined");
369 >      sendto_one_notice(client_p, &me, ":*** Banned: %s", conf->reason);
370 >      return BANNED_CLIENT;
371      }
372    }
373  
374 <  return(NOT_AUTHORIZED);
374 >  return NOT_AUTHORIZED;
375   }
376  
377   /* attach_iline()
# Line 968 | Line 382 | verify_access(struct Client *client_p, c
382   * side effects - do actual attach
383   */
384   static int
385 < attach_iline(struct Client *client_p, struct ConfItem *conf)
385 > attach_iline(struct Client *client_p, struct MaskItem *conf)
386   {
387 <  struct AccessItem *aconf;
974 <  struct ClassItem *aclass;
387 >  struct ClassItem *class = NULL;
388    struct ip_entry *ip_found;
389    int a_limit_reached = 0;
390 <  int local = 0, global = 0, ident = 0;
390 >  unsigned int local = 0, global = 0, ident = 0;
391 >
392 >  assert(conf->class);
393  
394    ip_found = find_or_add_ip(&client_p->localClient->ip);
395    ip_found->count++;
396    SetIpHash(client_p);
397  
398 <  aconf = map_to_conf(conf);
984 <  if (aconf->class_ptr == NULL)
985 <    return NOT_AUTHORIZED;  /* If class is missing, this is best */
986 <
987 <  aclass = map_to_conf(aconf->class_ptr);
398 >  class = conf->class;
399  
400    count_user_host(client_p->username, client_p->host,
401                    &global, &local, &ident);
# Line 993 | Line 404 | attach_iline(struct Client *client_p, st
404     * setting a_limit_reached if any limit is reached.
405     * - Dianora
406     */
407 <  if (aclass->max_total != 0 && aclass->curr_user_count >= aclass->max_total)
407 >  if (class->max_total && class->ref_count >= class->max_total)
408      a_limit_reached = 1;
409 <  else if (aclass->max_perip != 0 && ip_found->count > aclass->max_perip)
409 >  else if (class->max_perip && ip_found->count > class->max_perip)
410      a_limit_reached = 1;
411 <  else if (aclass->max_local != 0 && local >= aclass->max_local)
411 >  else if (class->max_local && local >= class->max_local)
412      a_limit_reached = 1;
413 <  else if (aclass->max_global != 0 && global >= aclass->max_global)
413 >  else if (class->max_global && global >= class->max_global)
414      a_limit_reached = 1;
415 <  else if (aclass->max_ident != 0 && ident >= aclass->max_ident &&
415 >  else if (class->max_ident && ident >= class->max_ident &&
416             client_p->username[0] != '~')
417      a_limit_reached = 1;
418  
419    if (a_limit_reached)
420    {
421 <    if (!IsConfExemptLimits(aconf))
421 >    if (!IsConfExemptLimits(conf))
422        return TOO_MANY;   /* Already at maximum allowed */
423  
424 <    sendto_one(client_p,
425 <               ":%s NOTICE %s :*** Your connection class is full, "
1015 <               "but you have exceed_limit = yes;", me.name, client_p->name);
424 >    sendto_one_notice(client_p, &me, ":*** Your connection class is full, "
425 >                      "but you have exceed_limit = yes;");
426    }
427  
428    return attach_conf(client_p, conf);
# Line 1028 | Line 438 | attach_iline(struct Client *client_p, st
438   void
439   init_ip_hash_table(void)
440   {
441 <  ip_entry_heap = BlockHeapCreate("ip", sizeof(struct ip_entry),
1032 <    2 * hard_fdlimit);
441 >  ip_entry_pool = mp_pool_new(sizeof(struct ip_entry), MP_CHUNK_SIZE_IP_ENTRY);
442    memset(ip_hash_table, 0, sizeof(ip_hash_table));
443   }
444  
# Line 1078 | Line 487 | find_or_add_ip(struct irc_ssaddr *ip_in)
487    if (ip_entries_count >= 2 * hard_fdlimit)
488      garbage_collect_ip_entries();
489  
490 <  newptr = BlockHeapAlloc(ip_entry_heap);
490 >  newptr = mp_pool_get(ip_entry_pool);
491 >  memset(newptr, 0, sizeof(*newptr));
492    ip_entries_count++;
493    memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
494  
# Line 1129 | Line 539 | remove_one_ip(struct irc_ssaddr *ip_in)
539      if (ptr->count > 0)
540        ptr->count--;
541      if (ptr->count == 0 &&
542 <        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
542 >        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
543      {
544        if (last_ptr != NULL)
545 <        last_ptr->next = ptr->next;
545 >        last_ptr->next = ptr->next;
546        else
547 <        ip_hash_table[hash_index] = ptr->next;
547 >        ip_hash_table[hash_index] = ptr->next;
548  
549 <      BlockHeapFree(ip_entry_heap, ptr);
549 >      mp_pool_release(ptr);
550        ip_entries_count--;
551        return;
552      }
# Line 1171 | Line 581 | hash_ip(struct irc_ssaddr *addr)
581      uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
582  
583      hash  = ip[0] ^ ip[3];
584 <    hash ^= hash >> 16;  
585 <    hash ^= hash >> 8;  
584 >    hash ^= hash >> 16;
585 >    hash ^= hash >> 8;
586      hash  = hash & (IP_HASH_SIZE - 1);
587      return hash;
588    }
# Line 1183 | Line 593 | hash_ip(struct irc_ssaddr *addr)
593  
594   /* count_ip_hash()
595   *
596 < * inputs        - pointer to counter of number of ips hashed
596 > * inputs        - pointer to counter of number of ips hashed
597   *               - pointer to memory used for ip hash
598   * output        - returned via pointers input
599   * side effects  - NONE
# Line 1195 | Line 605 | void
605   count_ip_hash(unsigned int *number_ips_stored, uint64_t *mem_ips_stored)
606   {
607    struct ip_entry *ptr;
1198 –  int i;
608  
609    *number_ips_stored = 0;
610    *mem_ips_stored    = 0;
611  
612 <  for (i = 0; i < IP_HASH_SIZE; i++)
612 >  for (unsigned int i = 0; i < IP_HASH_SIZE; ++i)
613    {
614      for (ptr = ip_hash_table[i]; ptr; ptr = ptr->next)
615      {
# Line 1222 | Line 631 | garbage_collect_ip_entries(void)
631    struct ip_entry *ptr;
632    struct ip_entry *last_ptr;
633    struct ip_entry *next_ptr;
1225 –  int i;
634  
635 <  for (i = 0; i < IP_HASH_SIZE; i++)
635 >  for (unsigned int i = 0; i < IP_HASH_SIZE; ++i)
636    {
637      last_ptr = NULL;
638  
# Line 1239 | Line 647 | garbage_collect_ip_entries(void)
647            last_ptr->next = ptr->next;
648          else
649            ip_hash_table[i] = ptr->next;
650 <        BlockHeapFree(ip_entry_heap, ptr);
650 >        mp_pool_release(ptr);
651          ip_entries_count--;
652        }
653        else
# Line 1256 | Line 664 | garbage_collect_ip_entries(void)
664   * side effects - Disassociate configuration from the client.
665   *                Also removes a class from the list if marked for deleting.
666   */
667 < int
668 < detach_conf(struct Client *client_p, ConfType type)
667 > void
668 > detach_conf(struct Client *client_p, enum maskitem_type type)
669   {
670 <  dlink_node *ptr, *next_ptr;
1263 <  struct ConfItem *conf;
1264 <  struct ClassItem *aclass;
1265 <  struct AccessItem *aconf;
1266 <  struct ConfItem *aclass_conf;
1267 <  struct MatchItem *match_item;
670 >  dlink_node *ptr = NULL, *ptr_next = NULL;
671  
672 <  DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->localClient->confs.head)
672 >  DLINK_FOREACH_SAFE(ptr, ptr_next, client_p->localClient->confs.head)
673    {
674 <    conf = ptr->data;
1272 <
1273 <    if (type == CONF_TYPE || conf->type == type)
1274 <    {
1275 <      dlinkDelete(ptr, &client_p->localClient->confs);
1276 <      free_dlink_node(ptr);
1277 <
1278 <      switch (conf->type)
1279 <      {
1280 <      case CLIENT_TYPE:
1281 <      case OPER_TYPE:
1282 <      case SERVER_TYPE:
1283 <        aconf = map_to_conf(conf);
1284 <
1285 <        assert(aconf->clients > 0);
1286 <
1287 <        if ((aclass_conf = aconf->class_ptr) != NULL)
1288 <        {
1289 <          aclass = map_to_conf(aclass_conf);
674 >    struct MaskItem *conf = ptr->data;
675  
676 <          assert(aclass->curr_user_count > 0);
676 >    assert(conf->type & (CONF_CLIENT | CONF_OPER | CONF_SERVER));
677 >    assert(conf->ref_count > 0);
678 >    assert(conf->class->ref_count > 0);
679  
680 <          if (conf->type == CLIENT_TYPE)
681 <            remove_from_cidr_check(&client_p->localClient->ip, aclass);
1295 <          if (--aclass->curr_user_count == 0 && aclass->active == 0)
1296 <            delete_conf_item(aclass_conf);
1297 <        }
680 >    if (!(conf->type & type))
681 >      continue;
682  
683 <        if (--aconf->clients == 0 && IsConfIllegal(aconf))
684 <          delete_conf_item(conf);
683 >    dlinkDelete(ptr, &client_p->localClient->confs);
684 >    free_dlink_node(ptr);
685  
686 <        break;
687 <      default:
1304 <        break;
1305 <      }
686 >    if (conf->type == CONF_CLIENT)
687 >      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
688  
689 <      if (type != CONF_TYPE)
690 <        return 0;
689 >    if (--conf->class->ref_count == 0 && conf->class->active == 0)
690 >    {
691 >      class_free(conf->class);
692 >      conf->class = NULL;
693      }
1310 –  }
694  
695 <  return -1;
695 >    if (--conf->ref_count == 0 && conf->active == 0)
696 >      conf_free(conf);
697 >  }
698   }
699  
700   /* attach_conf()
# Line 1323 | Line 708 | detach_conf(struct Client *client_p, Con
708   *                attachment if there was an old one...
709   */
710   int
711 < attach_conf(struct Client *client_p, struct ConfItem *conf)
711 > attach_conf(struct Client *client_p, struct MaskItem *conf)
712   {
713 <  if (dlinkFind(&client_p->localClient->confs, conf) != NULL)
713 >  if (dlinkFind(&client_p->localClient->confs, conf))
714      return 1;
715  
716 <  if (conf->type == CLIENT_TYPE ||
717 <      conf->type == SERVER_TYPE ||
718 <      conf->type == OPER_TYPE)
719 <  {
1335 <    struct AccessItem *aconf = map_to_conf(conf);
1336 <    struct ClassItem *aclass = map_to_conf(aconf->class_ptr);
1337 <
1338 <    if (IsConfIllegal(aconf))
1339 <      return NOT_AUTHORIZED;
1340 <
1341 <    if (conf->type == CLIENT_TYPE)
1342 <      if (cidr_limit_reached(IsConfExemptLimits(aconf),
1343 <                             &client_p->localClient->ip, aclass))
1344 <        return TOO_MANY;    /* Already at maximum allowed */
716 >  if (conf->type == CONF_CLIENT)
717 >    if (cidr_limit_reached(IsConfExemptLimits(conf),
718 >                           &client_p->localClient->ip, conf->class))
719 >      return TOO_MANY;    /* Already at maximum allowed */
720  
721 <    aclass->curr_user_count++;
722 <    aconf->clients++;
1348 <  }
721 >  conf->class->ref_count++;
722 >  conf->ref_count++;
723  
724    dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
725  
# Line 1365 | Line 739 | attach_connect_block(struct Client *clie
739                       const char *host)
740   {
741    dlink_node *ptr;
742 <  struct ConfItem *conf;
1369 <  struct AccessItem *aconf;
742 >  struct MaskItem *conf = NULL;
743  
744    assert(client_p != NULL);
745    assert(host != NULL);
# Line 1377 | Line 750 | attach_connect_block(struct Client *clie
750    DLINK_FOREACH(ptr, server_items.head)
751    {
752      conf = ptr->data;
1380 –    aconf = map_to_conf(conf);
753  
754 <    if (match(conf->name, name) == 0 || match(aconf->host, host) == 0)
754 >    if (match(conf->name, name) || match(conf->host, host))
755        continue;
756  
757      attach_conf(client_p, conf);
# Line 1389 | Line 761 | attach_connect_block(struct Client *clie
761    return 0;
762   }
763  
1392 – /* find_conf_exact()
1393 – *
1394 – * inputs       - type of ConfItem
1395 – *              - pointer to name to find
1396 – *              - pointer to username to find
1397 – *              - pointer to host to find
1398 – * output       - NULL or pointer to conf found
1399 – * side effects - find a conf entry which matches the hostname
1400 – *                and has the same name.
1401 – */
1402 – struct ConfItem *
1403 – find_conf_exact(ConfType type, const char *name, const char *user,
1404 –                const char *host)
1405 – {
1406 –  dlink_node *ptr;
1407 –  dlink_list *list_p;
1408 –  struct ConfItem *conf = NULL;
1409 –  struct AccessItem *aconf;
1410 –
1411 –  /* Only valid for OPER_TYPE and ...? */
1412 –  list_p = map_to_list(type);
1413 –
1414 –  DLINK_FOREACH(ptr, (*list_p).head)
1415 –  {
1416 –    conf = ptr->data;
1417 –
1418 –    if (conf->name == NULL)
1419 –      continue;
1420 –    aconf = map_to_conf(conf);
1421 –    if (aconf->host == NULL)
1422 –      continue;
1423 –    if (irccmp(conf->name, name) != 0)
1424 –      continue;
1425 –
1426 –    /*
1427 –    ** Accept if the *real* hostname (usually sockethost)
1428 –    ** socket host) matches *either* host or name field
1429 –    ** of the configuration.
1430 –    */
1431 –    if (!match(aconf->host, host) || !match(aconf->user, user))
1432 –      continue;
1433 –    if (type == OPER_TYPE)
1434 –    {
1435 –      struct ClassItem *aclass = map_to_conf(aconf->class_ptr);
1436 –
1437 –      if (aconf->clients >= aclass->max_total)
1438 –        continue;
1439 –    }
1440 –
1441 –    return conf;
1442 –  }
1443 –
1444 –  return NULL;
1445 – }
1446 –
764   /* find_conf_name()
765   *
766   * inputs       - pointer to conf link list to search
# Line 1453 | Line 770 | find_conf_exact(ConfType type, const cha
770   * side effects - find a conf entry which matches the name
771   *                and has the given mask.
772   */
773 < struct ConfItem *
774 < find_conf_name(dlink_list *list, const char *name, ConfType type)
773 > struct MaskItem *
774 > find_conf_name(dlink_list *list, const char *name, enum maskitem_type type)
775   {
776    dlink_node *ptr;
777 <  struct ConfItem* conf;
777 >  struct MaskItem* conf;
778  
779    DLINK_FOREACH(ptr, list->head)
780    {
781      conf = ptr->data;
782 <    
782 >
783      if (conf->type == type)
784      {
785 <      if (conf->name && (irccmp(conf->name, name) == 0 ||
786 <                         match(conf->name, name)))
785 >      if (conf->name && (!irccmp(conf->name, name) ||
786 >                         !match(conf->name, name)))
787        return conf;
788      }
789    }
# Line 1481 | Line 798 | find_conf_name(dlink_list *list, const c
798   * side effects - none
799   */
800   static dlink_list *
801 < map_to_list(ConfType type)
801 > map_to_list(enum maskitem_type type)
802   {
803    switch(type)
804    {
805 <  case RXLINE_TYPE:
1489 <    return(&rxconf_items);
1490 <    break;
1491 <  case XLINE_TYPE:
805 >  case CONF_XLINE:
806      return(&xconf_items);
807      break;
808 <  case ULINE_TYPE:
808 >  case CONF_ULINE:
809      return(&uconf_items);
810      break;
811 <  case NRESV_TYPE:
811 >  case CONF_NRESV:
812      return(&nresv_items);
813      break;
814 <  case OPER_TYPE:
814 >  case CONF_CRESV:
815 >    return(&cresv_items);
816 >  case CONF_OPER:
817      return(&oconf_items);
818      break;
819 <  case CLASS_TYPE:
1504 <    return(&class_items);
1505 <    break;
1506 <  case SERVER_TYPE:
819 >  case CONF_SERVER:
820      return(&server_items);
821      break;
822 <  case SERVICE_TYPE:
822 >  case CONF_SERVICE:
823      return(&service_items);
824      break;
825 <  case CLUSTER_TYPE:
825 >  case CONF_CLUSTER:
826      return(&cluster_items);
827      break;
1515 –  case CONF_TYPE:
1516 –  case GLINE_TYPE:
1517 –  case KLINE_TYPE:
1518 –  case DLINE_TYPE:
1519 –  case CRESV_TYPE:
828    default:
829      return NULL;
830    }
# Line 1528 | Line 836 | map_to_list(ConfType type)
836   *              - pointer to name string to find
837   *              - pointer to user
838   *              - pointer to host
839 < *              - optional action to match on as well
840 < * output       - NULL or pointer to found struct MatchItem
839 > *              - optional flags to match on as well
840 > * output       - NULL or pointer to found struct MaskItem
841   * side effects - looks for a match on name field
842   */
843 < struct ConfItem *
844 < find_matching_name_conf(ConfType type, const char *name, const char *user,
845 <                        const char *host, int action)
843 > struct MaskItem *
844 > find_matching_name_conf(enum maskitem_type type, const char *name, const char *user,
845 >                        const char *host, unsigned int flags)
846   {
847    dlink_node *ptr=NULL;
848 <  struct ConfItem *conf=NULL;
1541 <  struct AccessItem *aconf=NULL;
1542 <  struct MatchItem *match_item=NULL;
848 >  struct MaskItem *conf=NULL;
849    dlink_list *list_p = map_to_list(type);
850  
851    switch (type)
852    {
853 < #ifdef HAVE_LIBPCRE
1548 <  case RXLINE_TYPE:
1549 <      DLINK_FOREACH(ptr, list_p->head)
1550 <      {
1551 <        conf = ptr->data;
1552 <        assert(conf->regexpname);
1553 <
1554 <        if (!ircd_pcre_exec(conf->regexpname, name))
1555 <          return conf;
1556 <      }
1557 <      break;
1558 < #endif
1559 <  case SERVICE_TYPE:
853 >  case CONF_SERVICE:
854      DLINK_FOREACH(ptr, list_p->head)
855      {
856        conf = ptr->data;
# Line 1568 | Line 862 | find_matching_name_conf(ConfType type, c
862      }
863      break;
864  
865 <  case XLINE_TYPE:
866 <  case ULINE_TYPE:
867 <  case NRESV_TYPE:
865 >  case CONF_XLINE:
866 >  case CONF_ULINE:
867 >  case CONF_NRESV:
868 >  case CONF_CRESV:
869      DLINK_FOREACH(ptr, list_p->head)
870      {
871        conf = ptr->data;
872  
1578 –      match_item = map_to_conf(conf);
873        if (EmptyString(conf->name))
874 <        continue;
875 <      if ((name != NULL) && match_esc(conf->name, name))
874 >        continue;
875 >      if ((name != NULL) && !match(conf->name, name))
876        {
877 <        if ((user == NULL && (host == NULL)))
878 <          return conf;
879 <        if ((match_item->action & action) != action)
877 >        if ((user == NULL && (host == NULL)))
878 >          return conf;
879 >        if ((conf->flags & flags) != flags)
880            continue;
881 <        if (EmptyString(match_item->user) || EmptyString(match_item->host))
882 <          return conf;
883 <        if (match(match_item->user, user) && match(match_item->host, host))
884 <          return conf;
881 >        if (EmptyString(conf->user) || EmptyString(conf->host))
882 >          return conf;
883 >        if (!match(conf->user, user) && !match(conf->host, host))
884 >          return conf;
885        }
886      }
887        break;
888  
889 <  case SERVER_TYPE:
889 >  case CONF_SERVER:
890      DLINK_FOREACH(ptr, list_p->head)
891      {
892        conf = ptr->data;
1599 –      aconf = map_to_conf(conf);
893  
894 <      if ((name != NULL) && match_esc(name, conf->name))
894 >      if ((name != NULL) && !match(name, conf->name))
895          return conf;
896 <      else if ((host != NULL) && match_esc(host, aconf->host))
896 >      else if ((host != NULL) && !match(host, conf->host))
897          return conf;
898      }
899      break;
900 <  
900 >
901    default:
902      break;
903    }
# Line 1617 | Line 910 | find_matching_name_conf(ConfType type, c
910   *              - pointer to name string to find
911   *              - pointer to user
912   *              - pointer to host
913 < * output       - NULL or pointer to found struct MatchItem
913 > * output       - NULL or pointer to found struct MaskItem
914   * side effects - looks for an exact match on name field
915   */
916 < struct ConfItem *
917 < find_exact_name_conf(ConfType type, const struct Client *who, const char *name,
916 > struct MaskItem *
917 > find_exact_name_conf(enum maskitem_type type, const struct Client *who, const char *name,
918                       const char *user, const char *host)
919   {
920    dlink_node *ptr = NULL;
921 <  struct AccessItem *aconf;
922 <  struct ConfItem *conf;
1630 <  struct MatchItem *match_item;
1631 <  dlink_list *list_p;
1632 <
1633 <  list_p = map_to_list(type);
921 >  struct MaskItem *conf;
922 >  dlink_list *list_p = map_to_list(type);
923  
924    switch(type)
925    {
926 <  case RXLINE_TYPE:
927 <  case XLINE_TYPE:
928 <  case ULINE_TYPE:
929 <  case NRESV_TYPE:
926 >  case CONF_XLINE:
927 >  case CONF_ULINE:
928 >  case CONF_NRESV:
929 >  case CONF_CRESV:
930  
931      DLINK_FOREACH(ptr, list_p->head)
932      {
933        conf = ptr->data;
934 <      match_item = (struct MatchItem *)map_to_conf(conf);
934 >
935        if (EmptyString(conf->name))
936 <        continue;
937 <    
936 >        continue;
937 >
938        if (irccmp(conf->name, name) == 0)
939        {
940 <        if ((user == NULL && (host == NULL)))
941 <          return (conf);
942 <        if (EmptyString(match_item->user) || EmptyString(match_item->host))
943 <          return (conf);
944 <        if (match(match_item->user, user) && match(match_item->host, host))
945 <          return (conf);
940 >        if ((user == NULL && (host == NULL)))
941 >          return conf;
942 >        if (EmptyString(conf->user) || EmptyString(conf->host))
943 >          return conf;
944 >        if (!match(conf->user, user) && !match(conf->host, host))
945 >          return conf;
946        }
947      }
948      break;
949  
950 <  case OPER_TYPE:
950 >  case CONF_OPER:
951      DLINK_FOREACH(ptr, list_p->head)
952      {
953        conf = ptr->data;
1665 –      aconf = map_to_conf(conf);
954  
955        if (EmptyString(conf->name))
956          continue;
# Line 1671 | Line 959 | find_exact_name_conf(ConfType type, cons
959        {
960          if (!who)
961            return conf;
962 <        if (EmptyString(aconf->user) || EmptyString(aconf->host))
963 <          return conf;
964 <        if (match(aconf->user, who->username))
962 >        if (EmptyString(conf->user) || EmptyString(conf->host))
963 >          return NULL;
964 >        if (!match(conf->user, who->username))
965          {
966 <          switch (aconf->type)
966 >          switch (conf->htype)
967            {
968              case HM_HOST:
969 <              if (match(aconf->host, who->host) || match(aconf->host, who->sockhost))
970 <                return conf;
969 >              if (!match(conf->host, who->host) || !match(conf->host, who->sockhost))
970 >                if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
971 >                  return conf;
972                break;
973              case HM_IPV4:
974                if (who->localClient->aftype == AF_INET)
975 <                if (match_ipv4(&who->localClient->ip, &aconf->addr, aconf->bits))
976 <                  return conf;
975 >                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
976 >                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
977 >                    return conf;
978                break;
979   #ifdef IPV6
980              case HM_IPV6:
981                if (who->localClient->aftype == AF_INET6)
982 <                if (match_ipv6(&who->localClient->ip, &aconf->addr, aconf->bits))
983 <                  return conf;
982 >                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
983 >                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
984 >                    return conf;
985                break;
986   #endif
987              default:
# Line 1702 | Line 993 | find_exact_name_conf(ConfType type, cons
993  
994      break;
995  
996 <  case SERVER_TYPE:
996 >  case CONF_SERVER:
997      DLINK_FOREACH(ptr, list_p->head)
998      {
999        conf = ptr->data;
1000 <      aconf = (struct AccessItem *)map_to_conf(conf);
1000 >
1001        if (EmptyString(conf->name))
1002 <        continue;
1003 <    
1002 >        continue;
1003 >
1004        if (name == NULL)
1005        {
1006 <        if (EmptyString(aconf->host))
1007 <          continue;
1008 <        if (irccmp(aconf->host, host) == 0)
1009 <          return(conf);
1006 >        if (EmptyString(conf->host))
1007 >          continue;
1008 >        if (irccmp(conf->host, host) == 0)
1009 >          return conf;
1010        }
1011        else if (irccmp(conf->name, name) == 0)
1012 <      {
1722 <          return (conf);
1723 <      }
1012 >        return conf;
1013      }
1725 –    break;
1014  
1727 –  case CLASS_TYPE:
1728 –    DLINK_FOREACH(ptr, list_p->head)
1729 –    {
1730 –      conf = ptr->data;
1731 –      if (EmptyString(conf->name))
1732 –        continue;
1733 –    
1734 –      if (irccmp(conf->name, name) == 0)
1735 –        return (conf);
1736 –    }
1015      break;
1016  
1017    default:
1018      break;
1019    }
1020 <  return(NULL);
1020 >
1021 >  return NULL;
1022   }
1023  
1024   /* rehash()
# Line 1751 | Line 1030 | find_exact_name_conf(ConfType type, cons
1030   int
1031   rehash(int sig)
1032   {
1033 <  if (sig != 0)
1034 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1035 <                         "Got signal SIGHUP, reloading ircd.conf file");
1033 >  if (sig)
1034 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1035 >                         "Got signal SIGHUP, reloading configuration file(s)");
1036  
1037    restart_resolver();
1038  
# Line 1764 | Line 1043 | rehash(int sig)
1043  
1044    read_conf_files(0);
1045  
1046 <  if (ServerInfo.description != NULL)
1046 >  if (ServerInfo.description)
1047      strlcpy(me.info, ServerInfo.description, sizeof(me.info));
1048  
1049    load_conf_modules();
1050 +  check_conf_klines();
1051  
1052 <  flush_deleted_I_P();
1773 <
1774 <  rehashed_klines = 1;
1775 < /* XXX */
1776 <  if (ConfigLoggingEntry.use_logging)
1777 <    log_close_all();
1778 <
1779 <  return(0);
1052 >  return 0;
1053   }
1054  
1055   /* set_default_conf()
# Line 1794 | Line 1067 | set_default_conf(void)
1067    /* verify init_class() ran, this should be an unnecessary check
1068     * but its not much work.
1069     */
1070 <  assert(class_default == (struct ConfItem *) class_items.tail->data);
1070 >  assert(class_default == class_get_list()->tail->data);
1071  
1072   #ifdef HAVE_LIBCRYPTO
1073    ServerInfo.rsa_private_key = NULL;
# Line 1804 | Line 1077 | set_default_conf(void)
1077    /* ServerInfo.name is not rehashable */
1078    /* ServerInfo.name = ServerInfo.name; */
1079    ServerInfo.description = NULL;
1080 <  DupString(ServerInfo.network_name, NETWORK_NAME_DEFAULT);
1081 <  DupString(ServerInfo.network_desc, NETWORK_DESC_DEFAULT);
1080 >  ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1081 >  ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1082  
1083    memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
1084    ServerInfo.specific_ipv4_vhost = 0;
# Line 1813 | Line 1086 | set_default_conf(void)
1086    ServerInfo.specific_ipv6_vhost = 0;
1087  
1088    ServerInfo.max_clients = MAXCLIENTS_MAX;
1089 +  ServerInfo.max_nick_length = 9;
1090 +  ServerInfo.max_topic_length = 80;
1091  
1092    ServerInfo.hub = 0;
1093    ServerInfo.dns_host.sin_addr.s_addr = 0;
# Line 1821 | Line 1096 | set_default_conf(void)
1096    AdminInfo.email = NULL;
1097    AdminInfo.description = NULL;
1098  
1099 <  log_close_all();
1099 >  log_del_all();
1100  
1101    ConfigLoggingEntry.use_logging = 1;
1102  
1103    ConfigChannel.disable_fake_channels = 0;
1104 <  ConfigChannel.restrict_channels = 0;
1105 <  ConfigChannel.disable_local_channels = 0;
1106 <  ConfigChannel.use_invex = 1;
1107 <  ConfigChannel.use_except = 1;
1833 <  ConfigChannel.use_knock = 1;
1834 <  ConfigChannel.knock_delay = 300;
1104 >  ConfigChannel.invite_client_count = 10;
1105 >  ConfigChannel.invite_client_time = 300;
1106 >  ConfigChannel.knock_client_count = 1;
1107 >  ConfigChannel.knock_client_time = 300;
1108    ConfigChannel.knock_delay_channel = 60;
1109 <  ConfigChannel.max_chans_per_user = 15;
1110 <  ConfigChannel.quiet_on_ban = 1;
1109 >  ConfigChannel.max_chans_per_user = 25;
1110 >  ConfigChannel.max_chans_per_oper = 50;
1111    ConfigChannel.max_bans = 25;
1112    ConfigChannel.default_split_user_count = 0;
1113    ConfigChannel.default_split_server_count = 0;
1114    ConfigChannel.no_join_on_split = 0;
1115    ConfigChannel.no_create_on_split = 0;
1843 –  ConfigChannel.burst_topicwho = 1;
1116  
1117    ConfigServerHide.flatten_links = 0;
1118    ConfigServerHide.links_delay = 300;
1119    ConfigServerHide.hidden = 0;
1848 –  ConfigServerHide.disable_hidden = 0;
1120    ConfigServerHide.hide_servers = 0;
1121 <  DupString(ConfigServerHide.hidden_name, NETWORK_NAME_DEFAULT);
1121 >  ConfigServerHide.hide_services = 0;
1122 >  ConfigServerHide.hidden_name = xstrdup(NETWORK_NAME_DEFAULT);
1123    ConfigServerHide.hide_server_ips = 0;
1124 +  ConfigServerHide.disable_remote_commands = 0;
1125  
1126 <  
1854 <  DupString(ConfigFileEntry.service_name, SERVICE_NAME_DEFAULT);
1126 >  ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1127    ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
1128 +  ConfigFileEntry.cycle_on_host_change = 1;
1129 +  ConfigFileEntry.glines = 0;
1130 +  ConfigFileEntry.gline_time = 12 * 3600;
1131 +  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
1132    ConfigFileEntry.gline_min_cidr = 16;
1133    ConfigFileEntry.gline_min_cidr6 = 48;
1134    ConfigFileEntry.invisible_on_connect = 1;
1859 –  ConfigFileEntry.burst_away = 0;
1860 –  ConfigFileEntry.use_whois_actually = 1;
1135    ConfigFileEntry.tkline_expire_notices = 1;
1136    ConfigFileEntry.hide_spoof_ips = 1;
1137    ConfigFileEntry.ignore_bogus_ts = 0;
1138    ConfigFileEntry.disable_auth = 0;
1865 –  ConfigFileEntry.disable_remote = 0;
1139    ConfigFileEntry.kill_chase_time_limit = 90;
1140    ConfigFileEntry.default_floodcount = 8;
1141    ConfigFileEntry.failed_oper_notice = 1;
# Line 1876 | Line 1149 | set_default_conf(void)
1149    ConfigFileEntry.anti_spam_exit_message_time = 0;
1150    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1151    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1152 <  ConfigFileEntry.kline_with_reason = 1;
1153 <  ConfigFileEntry.kline_reason = NULL;
1881 <  ConfigFileEntry.warn_no_nline = 1;
1152 >  ConfigFileEntry.warn_no_connect_block = 1;
1153 >  ConfigFileEntry.stats_e_disabled = 0;
1154    ConfigFileEntry.stats_o_oper_only = 0;
1155 <  ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
1156 <  ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
1155 >  ConfigFileEntry.stats_k_oper_only = 1;  /* 1 = masked */
1156 >  ConfigFileEntry.stats_i_oper_only = 1;  /* 1 = masked */
1157    ConfigFileEntry.stats_P_oper_only = 0;
1158 +  ConfigFileEntry.stats_u_oper_only = 0;
1159    ConfigFileEntry.caller_id_wait = 60;
1160    ConfigFileEntry.opers_bypass_callerid = 0;
1161    ConfigFileEntry.pace_wait = 10;
# Line 1892 | Line 1165 | set_default_conf(void)
1165    ConfigFileEntry.no_oper_flood = 0;
1166    ConfigFileEntry.true_no_oper_flood = 0;
1167    ConfigFileEntry.oper_pass_resv = 1;
1895 –  ConfigFileEntry.glines = 0;
1896 –  ConfigFileEntry.gline_time = 12 * 3600;
1168    ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
1898 –  ConfigFileEntry.client_flood = CLIENT_FLOOD_DEFAULT;
1169    ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
1170 <  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
1901 <    UMODE_OPERWALL | UMODE_WALLOP;
1170 >  ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE | UMODE_WALLOP;
1171    ConfigFileEntry.use_egd = 0;
1172    ConfigFileEntry.egdpool_path = NULL;
1173 +  ConfigFileEntry.throttle_count = 0;
1174    ConfigFileEntry.throttle_time = 10;
1175   }
1176  
# Line 1914 | Line 1184 | validate_conf(void)
1184      ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1185  
1186    if (ServerInfo.network_name == NULL)
1187 <    DupString(ServerInfo.network_name,NETWORK_NAME_DEFAULT);
1187 >    ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1188  
1189    if (ServerInfo.network_desc == NULL)
1190 <    DupString(ServerInfo.network_desc,NETWORK_DESC_DEFAULT);
1190 >    ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1191  
1192    if (ConfigFileEntry.service_name == NULL)
1193 <    DupString(ConfigFileEntry.service_name, SERVICE_NAME_DEFAULT);
1924 <
1925 <  if ((ConfigFileEntry.client_flood < CLIENT_FLOOD_MIN) ||
1926 <      (ConfigFileEntry.client_flood > CLIENT_FLOOD_MAX))
1927 <    ConfigFileEntry.client_flood = CLIENT_FLOOD_MAX;
1193 >    ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1194  
1195    ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
1196   }
1197  
1198 < /* read_conf()
1198 > /* read_conf()
1199   *
1200   * inputs       - file descriptor pointing to config file to use
1201   * output       - None
# Line 1940 | Line 1206 | read_conf(FILE *file)
1206   {
1207    lineno = 0;
1208  
1209 <  set_default_conf(); /* Set default values prior to conf parsing */
1209 >  set_default_conf();  /* Set default values prior to conf parsing */
1210    conf_parser_ctx.pass = 1;
1211 <  yyparse();          /* pick up the classes first */
1211 >  yyparse();  /* Pick up the classes first */
1212  
1213    rewind(file);
1214  
1215    conf_parser_ctx.pass = 2;
1216 <  yyparse();          /* Load the values from the conf */
1217 <  validate_conf();    /* Check to make sure some values are still okay. */
1218 <                      /* Some global values are also loaded here. */
1219 <  check_class();      /* Make sure classes are valid */
1216 >  yyparse();  /* Load the values from the conf */
1217 >  validate_conf();  /* Check to make sure some values are still okay. */
1218 >                    /* Some global values are also loaded here. */
1219 >  class_delete_marked();  /* Delete unused classes that are marked for deletion */
1220   }
1221  
1222   /* lookup_confhost()
# Line 1958 | Line 1224 | read_conf(FILE *file)
1224   * start DNS lookups of all hostnames in the conf
1225   * line and convert an IP addresses in a.b.c.d number for to IP#s.
1226   */
1227 < static void
1228 < lookup_confhost(struct ConfItem *conf)
1227 > void
1228 > lookup_confhost(struct MaskItem *conf)
1229   {
1964 –  struct AccessItem *aconf;
1230    struct addrinfo hints, *res;
1231  
1232 <  aconf = map_to_conf(conf);
1233 <
1969 <  if (EmptyString(aconf->host) ||
1970 <      EmptyString(aconf->user))
1971 <  {
1972 <    ilog(LOG_TYPE_IRCD, "Host/server name error: (%s) (%s)",
1973 <         aconf->host, conf->name);
1974 <    return;
1975 <  }
1976 <
1977 <  if (strchr(aconf->host, '*') ||
1978 <      strchr(aconf->host, '?'))
1979 <    return;
1980 <
1981 <  /* Do name lookup now on hostnames given and store the
1232 >  /*
1233 >   * Do name lookup now on hostnames given and store the
1234     * ip numbers in conf structure.
1235     */
1236    memset(&hints, 0, sizeof(hints));
# Line 1989 | Line 1241 | lookup_confhost(struct ConfItem *conf)
1241    /* Get us ready for a bind() and don't bother doing dns lookup */
1242    hints.ai_flags = AI_PASSIVE | AI_NUMERICHOST;
1243  
1244 <  if (getaddrinfo(aconf->host, NULL, &hints, &res))
1244 >  if (getaddrinfo(conf->host, NULL, &hints, &res))
1245    {
1246 <    conf_dns_lookup(aconf);
1246 >    conf_dns_lookup(conf);
1247      return;
1248    }
1249  
1250 <  assert(res != NULL);
1250 >  assert(res);
1251 >
1252 >  memcpy(&conf->addr, res->ai_addr, res->ai_addrlen);
1253 >  conf->addr.ss_len = res->ai_addrlen;
1254 >  conf->addr.ss.ss_family = res->ai_family;
1255  
2000 –  memcpy(&aconf->addr, res->ai_addr, res->ai_addrlen);
2001 –  aconf->addr.ss_len = res->ai_addrlen;
2002 –  aconf->addr.ss.ss_family = res->ai_family;
1256    freeaddrinfo(res);
1257   }
1258  
# Line 2013 | Line 1266 | lookup_confhost(struct ConfItem *conf)
1266   int
1267   conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
1268   {
1269 <  struct ip_entry *ip_found;
1270 <  struct AccessItem *aconf = find_dline_conf(addr, aftype);
1269 >  struct ip_entry *ip_found = NULL;
1270 >  struct MaskItem *conf = find_dline_conf(addr, aftype);
1271  
1272    /* DLINE exempt also gets you out of static limits/pacing... */
1273 <  if (aconf && (aconf->status & CONF_EXEMPTDLINE))
1273 >  if (conf && (conf->type == CONF_EXEMPT))
1274      return 0;
1275  
1276 <  if (aconf != NULL)
1276 >  if (conf)
1277      return BANNED_CLIENT;
1278  
1279    ip_found = find_or_add_ip(addr);
1280 +  ++ip_found->connection_count;
1281  
1282 <  if ((CurrentTime - ip_found->last_attempt) <
2029 <      ConfigFileEntry.throttle_time)
1282 >  if ((CurrentTime - ip_found->last_attempt) < ConfigFileEntry.throttle_time)
1283    {
1284 <    ip_found->last_attempt = CurrentTime;
1285 <    return TOO_FAST;
1284 >    if (ip_found->connection_count >= ConfigFileEntry.throttle_count)
1285 >    {
1286 >      ip_found->last_attempt = CurrentTime;
1287 >      return TOO_FAST;
1288 >    }
1289    }
1290 +  else
1291 +    ip_found->connection_count = 1;
1292  
1293    ip_found->last_attempt = CurrentTime;
1294    return 0;
1295   }
1296  
2039 – static struct AccessItem *
2040 – find_regexp_kline(const char *uhi[])
2041 – {
2042 – #ifdef HAVE_LIBPCRE
2043 –  const dlink_node *ptr = NULL;
2044 –
2045 –  DLINK_FOREACH(ptr, rkconf_items.head)
2046 –  {
2047 –    struct AccessItem *aptr = map_to_conf(ptr->data);
2048 –
2049 –    assert(aptr->regexuser);
2050 –    assert(aptr->regexhost);
2051 –
2052 –    if (!ircd_pcre_exec(aptr->regexuser, uhi[0]) &&
2053 –        (!ircd_pcre_exec(aptr->regexhost, uhi[1]) ||
2054 –         !ircd_pcre_exec(aptr->regexhost, uhi[2])))
2055 –      return aptr;
2056 –  }
2057 – #endif
2058 –  return NULL;
2059 – }
2060 –
2061 – /* find_kill()
2062 – *
2063 – * inputs       - pointer to client structure
2064 – * output       - pointer to struct AccessItem if found
2065 – * side effects - See if this user is klined already,
2066 – *                and if so, return struct AccessItem pointer
2067 – */
2068 – struct AccessItem *
2069 – find_kill(struct Client *client_p)
2070 – {
2071 –  struct AccessItem *aconf = NULL;
2072 –  const char *uhi[3];
2073 –
2074 –  uhi[0] = client_p->username;
2075 –  uhi[1] = client_p->host;
2076 –  uhi[2] = client_p->sockhost;
2077 –
2078 –  assert(client_p != NULL);
2079 –
2080 –  aconf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
2081 –                               CONF_KLINE, client_p->localClient->aftype,
2082 –                               client_p->username, NULL, 1);
2083 –  if (aconf == NULL)
2084 –    aconf = find_regexp_kline(uhi);
2085 –
2086 –  return aconf;
2087 – }
2088 –
2089 – struct AccessItem *
2090 – find_gline(struct Client *client_p)
2091 – {
2092 –  struct AccessItem *aconf;
2093 –
2094 –  assert(client_p != NULL);
2095 –
2096 –  aconf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
2097 –                               CONF_GLINE, client_p->localClient->aftype,
2098 –                               client_p->username, NULL, 1);
2099 –  return aconf;
2100 – }
2101 –
2102 – /* add_temp_line()
2103 – *
2104 – * inputs        - pointer to struct ConfItem
2105 – * output        - none
2106 – * Side effects  - links in given struct ConfItem into
2107 – *                 temporary *line link list
2108 – */
2109 – void
2110 – add_temp_line(struct ConfItem *conf)
2111 – {
2112 –  if (conf->type == XLINE_TYPE)
2113 –  {
2114 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2115 –    dlinkAdd(conf, make_dlink_node(), &temporary_xlines);
2116 –  }
2117 –  else if ((conf->type == NRESV_TYPE) || (conf->type == CRESV_TYPE))
2118 –  {
2119 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2120 –    dlinkAdd(conf, make_dlink_node(), &temporary_resv);
2121 –  }
2122 – }
2123 –
1297   /* cleanup_tklines()
1298   *
1299   * inputs       - NONE
# Line 2132 | Line 1305 | void
1305   cleanup_tklines(void *notused)
1306   {
1307    hostmask_expire_temporary();
1308 <  expire_tklines(&temporary_xlines);
1309 <  expire_tklines(&temporary_resv);
1308 >  expire_tklines(&xconf_items);
1309 >  expire_tklines(&nresv_items);
1310 >  expire_tklines(&cresv_items);
1311   }
1312  
1313   /* expire_tklines()
# Line 2145 | Line 1319 | cleanup_tklines(void *notused)
1319   static void
1320   expire_tklines(dlink_list *tklist)
1321   {
1322 <  dlink_node *ptr;
1323 <  dlink_node *next_ptr;
2150 <  struct ConfItem *conf;
2151 <  struct MatchItem *xconf;
2152 <  struct MatchItem *nconf;
2153 <  struct ResvChannel *cconf;
1322 >  dlink_node *ptr = NULL, *ptr_next = NULL;
1323 >  struct MaskItem *conf = NULL;
1324  
1325 <  DLINK_FOREACH_SAFE(ptr, next_ptr, tklist->head)
1325 >  DLINK_FOREACH_SAFE(ptr, ptr_next, tklist->head)
1326    {
1327      conf = ptr->data;
1328  
1329 <    if (conf->type == XLINE_TYPE)
1329 >    if (!conf->until || conf->until > CurrentTime)
1330 >      continue;
1331 >
1332 >    if (conf->type == CONF_XLINE)
1333      {
1334 <      xconf = (struct MatchItem *)map_to_conf(conf);
1335 <      if (xconf->hold <= CurrentTime)
1336 <      {
1337 <        if (ConfigFileEntry.tkline_expire_notices)
2165 <          sendto_realops_flags(UMODE_ALL, L_ALL,
2166 <                               "Temporary X-line for [%s] sexpired", conf->name);
2167 <        dlinkDelete(ptr, tklist);
2168 <        free_dlink_node(ptr);
2169 <        delete_conf_item(conf);
2170 <      }
1334 >      if (ConfigFileEntry.tkline_expire_notices)
1335 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1336 >                               "Temporary X-line for [%s] expired", conf->name);
1337 >      conf_free(conf);
1338      }
1339 <    else if (conf->type == NRESV_TYPE)
1339 >    else if (conf->type == CONF_NRESV || conf->type == CONF_CRESV)
1340      {
1341 <      nconf = (struct MatchItem *)map_to_conf(conf);
1342 <      if (nconf->hold <= CurrentTime)
2176 <      {
2177 <        if (ConfigFileEntry.tkline_expire_notices)
2178 <          sendto_realops_flags(UMODE_ALL, L_ALL,
1341 >      if (ConfigFileEntry.tkline_expire_notices)
1342 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1343                                 "Temporary RESV for [%s] expired", conf->name);
1344 <        dlinkDelete(ptr, tklist);
2181 <        free_dlink_node(ptr);
2182 <        delete_conf_item(conf);
2183 <      }
2184 <    }
2185 <    else if (conf->type == CRESV_TYPE)
2186 <    {
2187 <      cconf = (struct ResvChannel *)map_to_conf(conf);
2188 <      if (cconf->hold <= CurrentTime)
2189 <      {
2190 <        if (ConfigFileEntry.tkline_expire_notices)
2191 <          sendto_realops_flags(UMODE_ALL, L_ALL,
2192 <                               "Temporary RESV for [%s] expired", cconf->name);
2193 <        delete_channel_resv(cconf);
2194 <      }
1344 >      conf_free(conf);
1345      }
1346    }
1347   }
# Line 2204 | Line 1354 | expire_tklines(dlink_list *tklist)
1354   */
1355   static const struct oper_privs
1356   {
1357 <  const unsigned int oprivs;
1357 >  const unsigned int flag;
1358    const unsigned char c;
1359   } flag_list[] = {
1360 <  { OPER_FLAG_ADMIN,       'A' },
1361 <  { OPER_FLAG_REMOTEBAN,   'B' },
1362 <  { OPER_FLAG_DIE,         'D' },
1363 <  { OPER_FLAG_GLINE,       'G' },
1364 <  { OPER_FLAG_REHASH,      'H' },
1365 <  { OPER_FLAG_K,           'K' },
1366 <  { OPER_FLAG_OPERWALL,    'L' },
1367 <  { OPER_FLAG_N,           'N' },
1368 <  { OPER_FLAG_GLOBAL_KILL, 'O' },
1369 <  { OPER_FLAG_REMOTE,      'R' },
1370 <  { OPER_FLAG_OPER_SPY,    'S' },
1371 <  { OPER_FLAG_UNKLINE,     'U' },
1372 <  { OPER_FLAG_X,           'X' },
1360 >  { OPER_FLAG_ADMIN,          'A' },
1361 >  { OPER_FLAG_REMOTEBAN,      'B' },
1362 >  { OPER_FLAG_DIE,            'D' },
1363 >  { OPER_FLAG_GLINE,          'G' },
1364 >  { OPER_FLAG_REHASH,         'H' },
1365 >  { OPER_FLAG_K,              'K' },
1366 >  { OPER_FLAG_KILL,           'N' },
1367 >  { OPER_FLAG_KILL_REMOTE,    'O' },
1368 >  { OPER_FLAG_CONNECT,        'P' },
1369 >  { OPER_FLAG_CONNECT_REMOTE, 'Q' },
1370 >  { OPER_FLAG_SQUIT,          'R' },
1371 >  { OPER_FLAG_SQUIT_REMOTE,   'S' },
1372 >  { OPER_FLAG_UNKLINE,        'U' },
1373 >  { OPER_FLAG_XLINE,          'X' },
1374    { 0, '\0' }
1375   };
1376  
1377   char *
1378   oper_privs_as_string(const unsigned int port)
1379   {
1380 <  static char privs_out[16];
1380 >  static char privs_out[IRCD_BUFSIZE];
1381    char *privs_ptr = privs_out;
2231 –  unsigned int i = 0;
1382  
1383 <  for (; flag_list[i].oprivs; ++i)
1383 >  for (const struct oper_privs *opriv = flag_list; opriv->flag; ++opriv)
1384    {
1385 <    if (port & flag_list[i].oprivs)
1386 <      *privs_ptr++ = flag_list[i].c;
1385 >    if (port & opriv->flag)
1386 >      *privs_ptr++ = opriv->c;
1387      else
1388 <      *privs_ptr++ = ToLowerTab[flag_list[i].c];
1388 >      *privs_ptr++ = ToLower(opriv->c);
1389    }
1390  
1391    *privs_ptr = '\0';
# Line 2252 | Line 1402 | oper_privs_as_string(const unsigned int
1402   const char *
1403   get_oper_name(const struct Client *client_p)
1404   {
1405 <  dlink_node *cnode = NULL;
1405 >  const dlink_node *cnode = NULL;
1406    /* +5 for !,@,{,} and null */
1407    static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
1408  
# Line 2260 | Line 1410 | get_oper_name(const struct Client *clien
1410    {
1411      if ((cnode = client_p->localClient->confs.head))
1412      {
1413 <      struct ConfItem *conf = cnode->data;
2264 <      const struct AccessItem *aconf = map_to_conf(conf);
1413 >      const struct MaskItem *conf = cnode->data;
1414  
1415 <      if (IsConfOperator(aconf))
1415 >      if (IsConfOperator(conf))
1416        {
1417 <        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1417 >        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1418                   client_p->username, client_p->host, conf->name);
1419 <        return buffer;
1419 >        return buffer;
1420        }
1421      }
1422  
1423 <    /* Probably should assert here for now. If there is an oper out there
1423 >    /* Probably should assert here for now. If there is an oper out there
1424       * with no oper{} conf attached, it would be good for us to know...
1425       */
1426      assert(0); /* Oper without oper conf! */
1427    }
1428  
1429    snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1430 <           client_p->username, client_p->host, client_p->servptr->name);
1430 >           client_p->username, client_p->host, client_p->servptr->name);
1431    return buffer;
1432   }
1433  
# Line 2291 | Line 1440 | get_oper_name(const struct Client *clien
1440   void
1441   read_conf_files(int cold)
1442   {
1443 <  const char *filename;
1444 <  char chanmodes[32];
1445 <  char chanlimit[32];
1443 >  const char *filename = NULL;
1444 >  char chanmodes[IRCD_BUFSIZE] = "";
1445 >  char chanlimit[IRCD_BUFSIZE] = "";
1446  
1447    conf_parser_ctx.boot = cold;
1448 <  filename = get_conf_name(CONF_TYPE);
1448 >  filename = ConfigFileEntry.configfile;
1449  
1450    /* We need to know the initial filename for the yyerror() to report
1451       FIXME: The full path is in conffilenamebuf first time since we
1452               dont know anything else
1453  
1454 <     - Gozem 2002-07-21
1454 >     - Gozem 2002-07-21
1455    */
1456    strlcpy(conffilebuf, filename, sizeof(conffilebuf));
1457  
# Line 2316 | Line 1465 | read_conf_files(int cold)
1465      }
1466      else
1467      {
1468 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1469 <                           "Unable to read configuration file '%s': %s",
1470 <                           filename, strerror(errno));
1468 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1469 >                           "Unable to read configuration file '%s': %s",
1470 >                           filename, strerror(errno));
1471        return;
1472      }
1473    }
# Line 2329 | Line 1478 | read_conf_files(int cold)
1478    read_conf(conf_parser_ctx.conf_file);
1479    fclose(conf_parser_ctx.conf_file);
1480  
1481 +  log_reopen_all();
1482 +
1483 +  add_isupport("NICKLEN", NULL, ServerInfo.max_nick_length);
1484    add_isupport("NETWORK", ServerInfo.network_name, -1);
1485 <  snprintf(chanmodes, sizeof(chanmodes), "b%s%s:%d",
1486 <           ConfigChannel.use_except ? "e" : "",
2335 <           ConfigChannel.use_invex ? "I" : "", ConfigChannel.max_bans);
1485 >
1486 >  snprintf(chanmodes, sizeof(chanmodes), "beI:%d", ConfigChannel.max_bans);
1487    add_isupport("MAXLIST", chanmodes, -1);
1488    add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1489 +  add_isupport("CHANTYPES", "#", -1);
1490  
1491 <  if (ConfigChannel.disable_local_channels)
1492 <    add_isupport("CHANTYPES", "#", -1);
2341 <  else
2342 <    add_isupport("CHANTYPES", "#&", -1);
2343 <
2344 <  snprintf(chanlimit, sizeof(chanlimit), "%s:%d",
2345 <           ConfigChannel.disable_local_channels ? "#" : "#&",
2346 <           ConfigChannel.max_chans_per_user);
1491 >  snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1492 >           ConfigChannel.max_chans_per_user);
1493    add_isupport("CHANLIMIT", chanlimit, -1);
1494 <  snprintf(chanmodes, sizeof(chanmodes), "%s%s%s",
1495 <           ConfigChannel.use_except ? "e" : "",
1496 <           ConfigChannel.use_invex ? "I" : "", "b,k,l,imnprstORS");
2351 <  add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
2352 <
2353 <  if (ConfigChannel.use_except)
2354 <    add_isupport("EXCEPTS", "e", -1);
2355 <  if (ConfigChannel.use_invex)
2356 <    add_isupport("INVEX", "I", -1);
1494 >  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,imnprstORS");
1495 >  add_isupport("CHANNELLEN", NULL, CHANNELLEN);
1496 >  add_isupport("TOPICLEN", NULL, ServerInfo.max_topic_length);
1497    add_isupport("CHANMODES", chanmodes, -1);
1498  
1499    /*
# Line 2361 | Line 1501 | read_conf_files(int cold)
1501     * on strlen(form_str(RPL_ISUPPORT))
1502     */
1503    rebuild_isupport_message_line();
2364 –
2365 – #ifdef HAVE_LIBPCRE
2366 –  parse_conf_file(RKLINE_TYPE, cold);
2367 –  parse_conf_file(RXLINE_TYPE, cold);
2368 – #endif
2369 –  parse_conf_file(KLINE_TYPE, cold);
2370 –  parse_conf_file(DLINE_TYPE, cold);
2371 –  parse_conf_file(XLINE_TYPE, cold);
2372 –  parse_conf_file(NRESV_TYPE, cold);
2373 –  parse_conf_file(CRESV_TYPE, cold);
2374 – }
2375 –
2376 – /* parse_conf_file()
2377 – *
2378 – * inputs       - type of conf file to parse
2379 – * output       - none
2380 – * side effects - conf file for givenconf type is opened and read then parsed
2381 – */
2382 – static void
2383 – parse_conf_file(int type, int cold)
2384 – {
2385 –  FILE *file = NULL;
2386 –  const char *filename = get_conf_name(type);
2387 –
2388 –  if ((file = fopen(filename, "r")) == NULL)
2389 –  {
2390 –    if (cold)
2391 –      ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
2392 –           filename, strerror(errno));
2393 –    else
2394 –      sendto_realops_flags(UMODE_ALL, L_ALL,
2395 –                    "Unable to read configuration file '%s': %s",
2396 –                           filename, strerror(errno));
2397 –  }
2398 –  else
2399 –  {
2400 –    parse_csv_file(file, type);
2401 –    fclose(file);
2402 –  }
1504   }
1505  
1506   /* clear_out_old_conf()
# Line 2412 | Line 1513 | static void
1513   clear_out_old_conf(void)
1514   {
1515    dlink_node *ptr = NULL, *next_ptr = NULL;
1516 <  struct ConfItem *conf;
2416 <  struct AccessItem *aconf;
2417 <  struct ClassItem *cltmp;
2418 <  struct MatchItem *match_item;
1516 >  struct MaskItem *conf;
1517    dlink_list *free_items [] = {
1518      &server_items,   &oconf_items,
1519 <     &uconf_items,   &xconf_items, &rxconf_items, &rkconf_items,
1520 <     &nresv_items, &cluster_items,  &gdeny_items, &service_items, NULL
1519 >     &uconf_items,   &xconf_items,
1520 >     &nresv_items, &cluster_items,  &service_items, &cresv_items, NULL
1521    };
1522  
1523    dlink_list ** iterator = free_items; /* C is dumb */
# Line 2427 | Line 1525 | clear_out_old_conf(void)
1525    /* We only need to free anything allocated by yyparse() here.
1526     * Resetting structs, etc, is taken care of by set_default_conf().
1527     */
1528 <  
1528 >
1529    for (; *iterator != NULL; iterator++)
1530    {
1531      DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
1532      {
1533        conf = ptr->data;
2436 –      /* XXX This is less than pretty */
2437 –      if (conf->type == SERVER_TYPE)
2438 –      {
2439 –        aconf = map_to_conf(conf);
1534  
1535 <        if (aconf->clients != 0)
2442 <        {
2443 <          SetConfIllegal(aconf);
2444 <          dlinkDelete(&conf->node, &server_items);
2445 <        }
2446 <        else
2447 <        {
2448 <          delete_conf_item(conf);
2449 <        }
2450 <      }
2451 <      else if (conf->type == OPER_TYPE)
2452 <      {
2453 <        aconf = map_to_conf(conf);
1535 >      dlinkDelete(&conf->node, map_to_list(conf->type));
1536  
1537 <        if (aconf->clients != 0)
1538 <        {
2457 <          SetConfIllegal(aconf);
2458 <          dlinkDelete(&conf->node, &oconf_items);
2459 <        }
2460 <        else
2461 <        {
2462 <          delete_conf_item(conf);
2463 <        }
2464 <      }
2465 <      else if (conf->type == XLINE_TYPE  ||
2466 <               conf->type == RXLINE_TYPE ||
2467 <               conf->type == RKLINE_TYPE)
1537 >      /* XXX This is less than pretty */
1538 >      if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
1539        {
1540 <        /* temporary (r)xlines are also on
1541 <         * the (r)xconf items list */
2471 <        if (conf->flags & CONF_FLAGS_TEMPORARY)
2472 <          continue;
2473 <
2474 <        delete_conf_item(conf);
1540 >        if (!conf->ref_count)
1541 >          conf_free(conf);
1542        }
1543 <      else
1543 >      else if (conf->type == CONF_XLINE)
1544        {
1545 <          delete_conf_item(conf);
1545 >        if (!conf->until)
1546 >          conf_free(conf);
1547        }
1548 +      else
1549 +        conf_free(conf);
1550      }
1551    }
1552  
1553 +  motd_clear();
1554 +
1555    /*
1556     * don't delete the class table, rather mark all entries
1557 <   * for deletion. The table is cleaned up by check_class. - avalon
1557 >   * for deletion. The table is cleaned up by class_delete_marked. - avalon
1558     */
1559 <  DLINK_FOREACH(ptr, class_items.head)
2488 <  {
2489 <    cltmp = map_to_conf(ptr->data);
2490 <
2491 <    if (ptr != class_items.tail)  /* never mark the "default" class */
2492 <      cltmp->active = 0;
2493 <  }
1559 >  class_mark_for_deletion();
1560  
1561    clear_out_address_conf();
1562  
# Line 2507 | Line 1573 | clear_out_old_conf(void)
1573    MyFree(ConfigFileEntry.egdpool_path);
1574    ConfigFileEntry.egdpool_path = NULL;
1575   #ifdef HAVE_LIBCRYPTO
1576 <  if (ServerInfo.rsa_private_key != NULL)
1576 >  if (ServerInfo.rsa_private_key)
1577    {
1578      RSA_free(ServerInfo.rsa_private_key);
1579      ServerInfo.rsa_private_key = NULL;
# Line 2526 | Line 1592 | clear_out_old_conf(void)
1592                                                 SSL_OP_NO_TLSv1);
1593   #endif
1594  
2529 –  /* clean out old resvs from the conf */
2530 –  clear_conf_resv();
2531 –
1595    /* clean out AdminInfo */
1596    MyFree(AdminInfo.name);
1597    AdminInfo.name = NULL;
# Line 2537 | Line 1600 | clear_out_old_conf(void)
1600    MyFree(AdminInfo.description);
1601    AdminInfo.description = NULL;
1602  
2540 –  /* operator{} and class{} blocks are freed above */
1603    /* clean out listeners */
1604    close_listeners();
1605  
2544 –  /* auth{}, quarantine{}, shared{}, connect{}, kill{}, deny{},
2545 –   * exempt{} and gecos{} blocks are freed above too
2546 –   */
2547 –
1606    /* clean out general */
1607    MyFree(ConfigFileEntry.service_name);
1608    ConfigFileEntry.service_name = NULL;
2551 –
2552 –  delete_isupport("INVEX");
2553 –  delete_isupport("EXCEPTS");
2554 – }
2555 –
2556 – /* flush_deleted_I_P()
2557 – *
2558 – * inputs       - none
2559 – * output       - none
2560 – * side effects - This function removes I/P conf items
2561 – */
2562 – static void
2563 – flush_deleted_I_P(void)
2564 – {
2565 –  dlink_node *ptr;
2566 –  dlink_node *next_ptr;
2567 –  struct ConfItem *conf;
2568 –  struct AccessItem *aconf;
2569 –  dlink_list * free_items [] = {
2570 –    &server_items, &oconf_items, NULL
2571 –  };
2572 –  dlink_list ** iterator = free_items; /* C is dumb */
2573 –
2574 –  /* flush out deleted I and P lines
2575 –   * although still in use.
2576 –   */
2577 –  for (; *iterator != NULL; iterator++)
2578 –  {
2579 –    DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
2580 –    {
2581 –      conf = ptr->data;
2582 –      aconf = (struct AccessItem *)map_to_conf(conf);
2583 –
2584 –      if (IsConfIllegal(aconf))
2585 –      {
2586 –        dlinkDelete(ptr, *iterator);
2587 –
2588 –        if (aconf->clients == 0)
2589 –          delete_conf_item(conf);
2590 –      }
2591 –    }
2592 –  }
2593 – }
2594 –
2595 – /* get_conf_name()
2596 – *
2597 – * inputs       - type of conf file to return name of file for
2598 – * output       - pointer to filename for type of conf
2599 – * side effects - none
2600 – */
2601 – const char *
2602 – get_conf_name(ConfType type)
2603 – {
2604 –  switch (type)
2605 –  {
2606 –    case CONF_TYPE:
2607 –      return ConfigFileEntry.configfile;
2608 –      break;
2609 –    case KLINE_TYPE:
2610 –      return ConfigFileEntry.klinefile;
2611 –      break;
2612 –    case RKLINE_TYPE:
2613 –      return ConfigFileEntry.rklinefile;
2614 –      break;
2615 –    case DLINE_TYPE:
2616 –      return ConfigFileEntry.dlinefile;
2617 –      break;
2618 –    case XLINE_TYPE:
2619 –      return ConfigFileEntry.xlinefile;
2620 –      break;
2621 –    case RXLINE_TYPE:
2622 –      return ConfigFileEntry.rxlinefile;
2623 –      break;
2624 –    case CRESV_TYPE:
2625 –      return ConfigFileEntry.cresvfile;
2626 –      break;
2627 –    case NRESV_TYPE:
2628 –      return ConfigFileEntry.nresvfile;
2629 –      break;
2630 –    case GLINE_TYPE:
2631 –      return ConfigFileEntry.glinefile;
2632 –      break;
2633 –
2634 –    default:
2635 –      return NULL;  /* This should NEVER HAPPEN since we call this function
2636 –                       only with the above values, this will cause us to core
2637 –                       at some point if this happens so we know where it was */
2638 –  }
2639 – }
2640 –
2641 – #define BAD_PING (-1)
2642 –
2643 – /* get_conf_ping()
2644 – *
2645 – * inputs       - pointer to struct AccessItem
2646 – *              - pointer to a variable that receives ping warning time
2647 – * output       - ping frequency
2648 – * side effects - NONE
2649 – */
2650 – static int
2651 – get_conf_ping(struct ConfItem *conf, int *pingwarn)
2652 – {
2653 –  struct ClassItem *aclass;
2654 –  struct AccessItem *aconf;
2655 –
2656 –  if (conf != NULL)
2657 –  {
2658 –    aconf = (struct AccessItem *)map_to_conf(conf);
2659 –    if (aconf->class_ptr != NULL)
2660 –    {
2661 –      aclass = (struct ClassItem *)map_to_conf(aconf->class_ptr);
2662 –      *pingwarn = aclass->ping_warning;
2663 –      return aclass->ping_freq;
2664 –    }
2665 –  }
2666 –
2667 –  return BAD_PING;
2668 – }
2669 –
2670 – /* get_client_class()
2671 – *
2672 – * inputs       - pointer to client struct
2673 – * output       - pointer to name of class
2674 – * side effects - NONE
2675 – */
2676 – const char *
2677 – get_client_class(struct Client *target_p)
2678 – {
2679 –  dlink_node *cnode = NULL;
2680 –  struct AccessItem *aconf = NULL;
2681 –
2682 –  assert(!IsMe(target_p));
2683 –
2684 –  if ((cnode = target_p->localClient->confs.head))
2685 –  {
2686 –    struct ConfItem *conf = cnode->data;
2687 –
2688 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2689 –          (conf->type == OPER_TYPE));
2690 –
2691 –    aconf = map_to_conf(conf);
2692 –    if (aconf->class_ptr != NULL)
2693 –      return aconf->class_ptr->name;
2694 –  }
2695 –
2696 –  return "default";
2697 – }
2698 –
2699 – /* get_client_ping()
2700 – *
2701 – * inputs       - pointer to client struct
2702 – *              - pointer to a variable that receives ping warning time
2703 – * output       - ping frequency
2704 – * side effects - NONE
2705 – */
2706 – int
2707 – get_client_ping(struct Client *target_p, int *pingwarn)
2708 – {
2709 –  int ping = 0;
2710 –  dlink_node *cnode = NULL;
2711 –
2712 –  if ((cnode = target_p->localClient->confs.head))
2713 –  {
2714 –    struct ConfItem *conf = cnode->data;
2715 –
2716 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2717 –          (conf->type == OPER_TYPE));
2718 –
2719 –    ping = get_conf_ping(conf, pingwarn);
2720 –    if (ping > 0)
2721 –      return ping;
2722 –  }
2723 –
2724 –  *pingwarn = 0;
2725 –  return DEFAULT_PINGFREQUENCY;
2726 – }
2727 –
2728 – /* find_class()
2729 – *
2730 – * inputs       - string name of class
2731 – * output       - corresponding Class pointer
2732 – * side effects - NONE
2733 – */
2734 – struct ConfItem *
2735 – find_class(const char *classname)
2736 – {
2737 –  struct ConfItem *conf;
2738 –
2739 –  if ((conf = find_exact_name_conf(CLASS_TYPE, NULL, classname, NULL, NULL)) != NULL)
2740 –    return conf;
2741 –
2742 –  return class_default;
2743 – }
2744 –
2745 – /* check_class()
2746 – *
2747 – * inputs       - NONE
2748 – * output       - NONE
2749 – * side effects -
2750 – */
2751 – void
2752 – check_class(void)
2753 – {
2754 –  dlink_node *ptr = NULL, *next_ptr = NULL;
2755 –
2756 –  DLINK_FOREACH_SAFE(ptr, next_ptr, class_items.head)
2757 –  {
2758 –    struct ClassItem *aclass = map_to_conf(ptr->data);
2759 –
2760 –    if (!aclass->active && !aclass->curr_user_count)
2761 –    {
2762 –      destroy_cidr_class(aclass);
2763 –      delete_conf_item(ptr->data);
2764 –    }
2765 –  }
2766 – }
2767 –
2768 – /* init_class()
2769 – *
2770 – * inputs       - NONE
2771 – * output       - NONE
2772 – * side effects -
2773 – */
2774 – void
2775 – init_class(void)
2776 – {
2777 –  struct ClassItem *aclass;
2778 –
2779 –  class_default = make_conf_item(CLASS_TYPE);
2780 –
2781 –  aclass = map_to_conf(class_default);
2782 –  aclass->active = 1;
2783 –  DupString(class_default->name, "default");
2784 –  aclass->con_freq  = DEFAULT_CONNECTFREQUENCY;
2785 –  aclass->ping_freq = DEFAULT_PINGFREQUENCY;
2786 –  aclass->max_total = MAXIMUM_LINKS_DEFAULT;
2787 –  aclass->max_sendq = DEFAULT_SENDQ;
2788 –
2789 –  client_check_cb = register_callback("check_client", check_client);
2790 – }
2791 –
2792 – /* get_sendq()
2793 – *
2794 – * inputs       - pointer to client
2795 – * output       - sendq for this client as found from its class
2796 – * side effects - NONE
2797 – */
2798 – unsigned int
2799 – get_sendq(struct Client *client_p)
2800 – {
2801 –  unsigned int sendq = DEFAULT_SENDQ;
2802 –  dlink_node *cnode;
2803 –  struct ConfItem *class_conf;
2804 –  struct ClassItem *aclass;
2805 –  struct AccessItem *aconf;
2806 –
2807 –  assert(!IsMe(client_p));
2808 –
2809 –  if ((cnode = client_p->localClient->confs.head))
2810 –  {
2811 –    struct ConfItem *conf = cnode->data;
2812 –
2813 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2814 –          (conf->type == OPER_TYPE));
2815 –
2816 –    aconf = map_to_conf(conf);
2817 –
2818 –    if ((class_conf = aconf->class_ptr) == NULL)
2819 –      return DEFAULT_SENDQ; /* TBV: shouldn't be possible at all */
2820 –
2821 –    aclass = map_to_conf(class_conf);
2822 –    sendq = aclass->max_sendq;
2823 –    return sendq;
2824 –  }
2825 –
2826 –  /* XXX return a default?
2827 –   * if here, then there wasn't an attached conf with a sendq
2828 –   * that is very bad -Dianora
2829 –   */
2830 –  return DEFAULT_SENDQ;
1609   }
1610  
1611   /* conf_add_class_to_conf()
1612   *
1613   * inputs       - pointer to config item
1614   * output       - NONE
1615 < * side effects - Add a class pointer to a conf
1615 > * side effects - Add a class pointer to a conf
1616   */
1617   void
1618 < conf_add_class_to_conf(struct ConfItem *conf, const char *class_name)
1618 > conf_add_class_to_conf(struct MaskItem *conf, const char *class_name)
1619   {
1620 <  struct AccessItem *aconf = map_to_conf(conf);
2843 <  struct ClassItem *class = NULL;
2844 <
2845 <  if (class_name == NULL)
1620 >  if (class_name == NULL)
1621    {
1622 <    aconf->class_ptr = class_default;
1622 >    conf->class = class_default;
1623  
1624 <    if (conf->type == CLIENT_TYPE)
1625 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1626 <                           "Warning *** Defaulting to default class for %s@%s",
1627 <                           aconf->user, aconf->host);
1624 >    if (conf->type == CONF_CLIENT)
1625 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1626 >                           "Warning *** Defaulting to default class for %s@%s",
1627 >                           conf->user, conf->host);
1628      else
1629 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1630 <                           "Warning *** Defaulting to default class for %s",
1631 <                           conf->name);
1629 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1630 >                           "Warning *** Defaulting to default class for %s",
1631 >                           conf->name);
1632    }
1633    else
1634 <    aconf->class_ptr = find_class(class_name);
2860 <
2861 <  if (aconf->class_ptr)
2862 <    class = map_to_conf(aconf->class_ptr);
1634 >    conf->class = class_find(class_name, 1);
1635  
1636 <  if (aconf->class_ptr == NULL || !class->active)
1636 >  if (conf->class == NULL)
1637    {
1638 <    if (conf->type == CLIENT_TYPE)
1639 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1640 <                           "Warning *** Defaulting to default class for %s@%s",
1641 <                           aconf->user, aconf->host);
1638 >    if (conf->type == CONF_CLIENT)
1639 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1640 >                           "Warning *** Defaulting to default class for %s@%s",
1641 >                           conf->user, conf->host);
1642      else
1643 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1644 <                           "Warning *** Defaulting to default class for %s",
1645 <                           conf->name);
1646 <    aconf->class_ptr = class_default;
1643 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1644 >                           "Warning *** Defaulting to default class for %s",
1645 >                           conf->name);
1646 >    conf->class = class_default;
1647    }
1648   }
1649  
2878 – /* conf_add_server()
2879 – *
2880 – * inputs       - pointer to config item
2881 – *              - pointer to link count already on this conf
2882 – * output       - NONE
2883 – * side effects - Add a connect block
2884 – */
2885 – int
2886 – conf_add_server(struct ConfItem *conf, const char *class_name)
2887 – {
2888 –  struct AccessItem *aconf = map_to_conf(conf);
2889 –
2890 –  conf_add_class_to_conf(conf, class_name);
2891 –
2892 –  if (!aconf->host || !conf->name)
2893 –  {
2894 –    sendto_realops_flags(UMODE_ALL, L_ALL, "Bad connect block");
2895 –    ilog(LOG_TYPE_IRCD, "Bad connect block");
2896 –    return -1;
2897 –  }
2898 –
2899 –  if (EmptyString(aconf->passwd))
2900 –  {
2901 –    sendto_realops_flags(UMODE_ALL, L_ALL, "Bad connect block, name %s",
2902 –                         conf->name);
2903 –    ilog(LOG_TYPE_IRCD, "Bad connect block, host %s", conf->name);
2904 –    return -1;
2905 –  }
2906 –
2907 –  lookup_confhost(conf);
2908 –
2909 –  return 0;
2910 – }
2911 –
1650   /* yyerror()
1651   *
1652   * inputs       - message from parser
# Line 2924 | Line 1662 | yyerror(const char *msg)
1662      return;
1663  
1664    strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1665 <  sendto_realops_flags(UMODE_ALL, L_ALL, "\"%s\", line %u: %s: %s",
1665 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1666 >                       "\"%s\", line %u: %s: %s",
1667 >                       conffilebuf, lineno + 1, msg, newlinebuf);
1668 >  ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1669 >       conffilebuf, lineno + 1, msg, newlinebuf);
1670 > }
1671 >
1672 > void
1673 > conf_error_report(const char *msg)
1674 > {
1675 >  char newlinebuf[IRCD_BUFSIZE];
1676 >
1677 >  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1678 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1679 >                       "\"%s\", line %u: %s: %s",
1680                         conffilebuf, lineno + 1, msg, newlinebuf);
1681    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1682         conffilebuf, lineno + 1, msg, newlinebuf);
# Line 2932 | Line 1684 | yyerror(const char *msg)
1684  
1685   /*
1686   * valid_tkline()
1687 < *
1687 > *
1688   * inputs       - pointer to ascii string to check
1689   *              - whether the specified time is in seconds or minutes
1690   * output       - -1 not enough parameters
# Line 2941 | Line 1693 | yyerror(const char *msg)
1693   * Originally written by Dianora (Diane, db@db.net)
1694   */
1695   time_t
1696 < valid_tkline(const char *p, int minutes)
1696 > valid_tkline(const char *data, const int minutes)
1697   {
1698 +  const unsigned char *p = (const unsigned char *)data;
1699 +  unsigned char tmpch = '\0';
1700    time_t result = 0;
1701  
1702 <  for (; *p; ++p)
1702 >  while ((tmpch = *p++))
1703    {
1704 <    if (!IsDigit(*p))
1704 >    if (!IsDigit(tmpch))
1705        return 0;
1706  
1707      result *= 10;
1708 <    result += ((*p) & 0xF);
1708 >    result += (tmpch & 0xF);
1709    }
1710  
1711    /*
1712 <   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1712 >   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1713     * i.e. they specifically use 0, I am going to return 1 instead
1714     * as a return value of non-zero is used to flag it as a temporary kline
1715     */
1716    if (result == 0)
1717      result = 1;
1718  
1719 <  /*
1719 >  /*
1720     * If the incoming time is in seconds convert it to minutes for the purpose
1721     * of this calculation
1722     */
1723    if (!minutes)
1724 <    result = result / (time_t)60;
1724 >    result = result / 60;
1725  
1726    if (result > MAX_TDKLINE_TIME)
1727      result = MAX_TDKLINE_TIME;
1728  
1729 <  result = result * (time_t)60;  /* turn it into seconds */
1729 >  result = result * 60;  /* turn it into seconds */
1730  
1731    return result;
1732   }
1733  
1734 + /* valid_wild_card_simple()
1735 + *
1736 + * inputs       - data to check for sufficient non-wildcard characters
1737 + * outputs      - 1 if valid, else 0
1738 + * side effects - none
1739 + */
1740 + int
1741 + valid_wild_card_simple(const char *data)
1742 + {
1743 +  const unsigned char *p = (const unsigned char *)data;
1744 +  unsigned char tmpch = '\0';
1745 +  unsigned int nonwild = 0;
1746 +
1747 +  while ((tmpch = *p++))
1748 +  {
1749 +    if (tmpch == '\\')
1750 +    {
1751 +      ++p;
1752 +      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1753 +        return 1;
1754 +    }
1755 +    else if (!IsMWildChar(tmpch))
1756 +    {
1757 +      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1758 +        return 1;
1759 +    }
1760 +  }
1761 +
1762 +  return 0;
1763 + }
1764 +
1765   /* valid_wild_card()
1766   *
1767   * input        - pointer to client
# Line 2988 | Line 1773 | valid_tkline(const char *p, int minutes)
1773   int
1774   valid_wild_card(struct Client *source_p, int warn, int count, ...)
1775   {
1776 <  char *p;
1777 <  char tmpch;
2993 <  int nonwild = 0;
1776 >  char tmpch = '\0';
1777 >  unsigned int nonwild = 0;
1778    va_list args;
1779  
1780    /*
# Line 3009 | Line 1793 | valid_wild_card(struct Client *source_p,
1793  
1794    while (count--)
1795    {
1796 <    p = va_arg(args, char *);
1796 >    const char *p = va_arg(args, const char *);
1797      if (p == NULL)
1798        continue;
1799  
# Line 3022 | Line 1806 | valid_wild_card(struct Client *source_p,
1806           * break - no point in searching further.
1807           */
1808          if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1809 +        {
1810 +          va_end(args);
1811            return 1;
1812 +        }
1813        }
1814      }
1815    }
1816  
1817    if (warn)
1818 <    sendto_one(source_p, ":%s NOTICE %s :Please include at least %d non-wildcard characters with the mask",
1819 <               me.name, source_p->name, ConfigFileEntry.min_nonwildcard);
1818 >    sendto_one_notice(source_p, &me,
1819 >                      ":Please include at least %d non-wildcard characters with the mask",
1820 >                      ConfigFileEntry.min_nonwildcard);
1821 >  va_end(args);
1822    return 0;
1823   }
1824  
# Line 3043 | Line 1832 | valid_wild_card(struct Client *source_p,
1832   *              - parse_flags bit map of things to test
1833   *              - pointer to user or string to parse into
1834   *              - pointer to host or NULL to parse into if non NULL
1835 < *              - pointer to optional tkline time or NULL
1835 > *              - pointer to optional tkline time or NULL
1836   *              - pointer to target_server to parse into if non NULL
1837   *              - pointer to reason to parse into
1838   *
# Line 3065 | Line 1854 | valid_wild_card(struct Client *source_p,
1854   */
1855   int
1856   parse_aline(const char *cmd, struct Client *source_p,
1857 <            int parc, char **parv,
1858 <            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1859 <            char **target_server, char **reason)
1857 >            int parc, char **parv,
1858 >            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1859 >            char **target_server, char **reason)
1860   {
1861    int found_tkline_time=0;
1862 <  static char def_reason[] = "No Reason";
1862 >  static char def_reason[] = CONF_NOREASON;
1863    static char user[USERLEN*4+1];
1864    static char host[HOSTLEN*4+1];
1865  
# Line 3088 | Line 1877 | parse_aline(const char *cmd, struct Clie
1877        *tkline_time = found_tkline_time;
1878      else
1879      {
1880 <      sendto_one(source_p, ":%s NOTICE %s :temp_line not supported by %s",
3092 <                 me.name, source_p->name, cmd);
1880 >      sendto_one_notice(source_p, &me, ":temp_line not supported by %s", cmd);
1881        return -1;
1882      }
1883    }
1884  
1885    if (parc == 0)
1886    {
1887 <    sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
3100 <               me.name, source_p->name, cmd);
1887 >    sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1888      return -1;
1889    }
1890  
# Line 3111 | Line 1898 | parse_aline(const char *cmd, struct Clie
1898      *up_p = user;
1899      *h_p = host;
1900    }
1901 <
1901 >
1902    parc--;
1903    parv++;
1904  
# Line 3124 | Line 1911 | parse_aline(const char *cmd, struct Clie
1911  
1912        if (target_server == NULL)
1913        {
1914 <        sendto_one(source_p, ":%s NOTICE %s :ON server not supported by %s",
1915 <                   me.name, source_p->name, cmd);
3129 <        return -1;
1914 >        sendto_one_notice(source_p, &me, ":ON server not supported by %s", cmd);
1915 >        return -1;
1916        }
1917  
1918        if (!HasOFlag(source_p, OPER_FLAG_REMOTEBAN))
1919        {
1920 <        sendto_one(source_p, form_str(ERR_NOPRIVS),
3135 <                   me.name, source_p->name, "remoteban");
1920 >        sendto_one_numeric(source_p, &me, ERR_NOPRIVS, "remoteban");
1921          return -1;
1922        }
1923  
1924        if (parc == 0 || EmptyString(*parv))
1925        {
1926 <        sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
1927 <                   me.name, source_p->name, cmd);
3143 <        return -1;
1926 >        sendto_one_numeric(source_p, &me, ERR_NEEDMOREPARAMS, cmd);
1927 >        return -1;
1928        }
1929  
1930        *target_server = *parv;
# Line 3153 | Line 1937 | parse_aline(const char *cmd, struct Clie
1937         * caller probably NULL'd it first, but no harm to do it again -db
1938         */
1939        if (target_server != NULL)
1940 <        *target_server = NULL;
1940 >        *target_server = NULL;
1941      }
1942    }
1943  
# Line 3161 | Line 1945 | parse_aline(const char *cmd, struct Clie
1945    {
1946      if (strchr(user, '!') != NULL)
1947      {
1948 <      sendto_one(source_p, ":%s NOTICE %s :Invalid character '!' in kline",
3165 <                 me.name, source_p->name);
1948 >      sendto_one_notice(source_p, &me, ":Invalid character '!' in kline");
1949        return -1;
1950      }
1951  
# Line 3179 | Line 1962 | parse_aline(const char *cmd, struct Clie
1962      {
1963        *reason = *parv;
1964        if (!valid_comment(source_p, *reason, 1))
1965 <        return -1;
1965 >        return -1;
1966      }
1967      else
1968        *reason = def_reason;
# Line 3218 | Line 2001 | find_user_host(struct Client *source_p,
2001      {
2002        *(hostp++) = '\0';                       /* short and squat */
2003        if (*user_host_or_nick)
2004 <        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
2004 >        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
2005        else
2006 <        strcpy(luser, "*");
2006 >        strcpy(luser, "*");
2007 >
2008        if (*hostp)
2009 <        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2009 >        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2010        else
2011 <        strcpy(lhost, "*");
2011 >        strcpy(lhost, "*");
2012      }
2013      else
2014      {
2015        luser[0] = '*';             /* no @ found, assume its *@somehost */
2016 <      luser[1] = '\0';    
2016 >      luser[1] = '\0';
2017        strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
2018      }
2019 <    
2019 >
2020      return 1;
2021    }
2022 <  else if (!(flags & NOUSERLOOKUP))
2022 >  else
2023    {
2024      /* Try to find user@host mask from nick */
2025      /* Okay to use source_p as the first param, because source_p == client_p */
2026 <    if ((target_p =
2027 <        find_chasing(source_p, source_p, user_host_or_nick, NULL)) == NULL)
2028 <      return 0;
2026 >    if ((target_p =
2027 >        find_chasing(source_p, user_host_or_nick)) == NULL)
2028 >      return 0;  /* find_chasing sends ERR_NOSUCHNICK */
2029  
2030      if (IsExemptKline(target_p))
2031      {
2032        if (!IsServer(source_p))
2033 <        sendto_one(source_p,
3250 <                   ":%s NOTICE %s :%s is E-lined",
3251 <                   me.name, source_p->name, target_p->name);
2033 >        sendto_one_notice(source_p, &me, ":%s is E-lined", target_p->name);
2034        return 0;
2035      }
2036  
# Line 3283 | Line 2065 | find_user_host(struct Client *source_p,
2065   int
2066   valid_comment(struct Client *source_p, char *comment, int warn)
2067   {
3286 –  if (strchr(comment, '"'))
3287 –  {
3288 –    if (warn)
3289 –      sendto_one(source_p, ":%s NOTICE %s :Invalid character '\"' in comment",
3290 –                 me.name, source_p->name);
3291 –    return 0;
3292 –  }
3293 –
2068    if (strlen(comment) > REASONLEN)
2069      comment[REASONLEN-1] = '\0';
2070  
# Line 3305 | Line 2079 | valid_comment(struct Client *source_p, c
2079   * side effects - none
2080   */
2081   int
2082 < match_conf_password(const char *password, const struct AccessItem *aconf)
2082 > match_conf_password(const char *password, const struct MaskItem *conf)
2083   {
2084    const char *encr = NULL;
2085  
2086 <  if (EmptyString(password) || EmptyString(aconf->passwd))
2086 >  if (EmptyString(password) || EmptyString(conf->passwd))
2087      return 0;
2088  
2089 <  if (aconf->flags & CONF_FLAGS_ENCRYPTED)
2090 <    encr = crypt(password, aconf->passwd);
2089 >  if (conf->flags & CONF_FLAGS_ENCRYPTED)
2090 >    encr = crypt(password, conf->passwd);
2091    else
2092      encr = password;
2093  
2094 <  return !strcmp(encr, aconf->passwd);
2094 >  return encr && !strcmp(encr, conf->passwd);
2095   }
2096  
2097   /*
# Line 3325 | Line 2099 | match_conf_password(const char *password
2099   *
2100   * inputs       - client sending the cluster
2101   *              - command name "KLINE" "XLINE" etc.
2102 < *              - capab -- CAP_KLN etc. from s_serv.h
2102 > *              - capab -- CAP_KLN etc. from server.h
2103   *              - cluster type -- CLUSTER_KLINE etc. from conf.h
2104   *              - pattern and args to send along
2105   * output       - none
# Line 3337 | Line 2111 | cluster_a_line(struct Client *source_p,
2111                 int capab, int cluster_type, const char *pattern, ...)
2112   {
2113    va_list args;
2114 <  char buffer[IRCD_BUFSIZE];
2114 >  char buffer[IRCD_BUFSIZE] = "";
2115    const dlink_node *ptr = NULL;
2116  
2117    va_start(args, pattern);
# Line 3346 | Line 2120 | cluster_a_line(struct Client *source_p,
2120  
2121    DLINK_FOREACH(ptr, cluster_items.head)
2122    {
2123 <    const struct ConfItem *conf = ptr->data;
2123 >    const struct MaskItem *conf = ptr->data;
2124  
2125      if (conf->flags & cluster_type)
2126        sendto_match_servs(source_p, conf->name, CAP_CLUSTER|capab,
2127 <                         "%s %s %s", command, conf->name, buffer);
2127 >                         "%s %s %s", command, conf->name, buffer);
2128    }
2129   }
2130  
# Line 3398 | Line 2172 | split_nuh(struct split_nuh_item *const i
2172    {
2173      *p = '\0';
2174  
2175 <    if (iptr->nickptr && *iptr->nuhmask != '\0')
2175 >    if (iptr->nickptr && *iptr->nuhmask)
2176        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
2177  
2178 <    if ((q = strchr(++p, '@'))) {
2178 >    if ((q = strchr(++p, '@')))
2179 >    {
2180        *q++ = '\0';
2181  
2182 <      if (*p != '\0')
2182 >      if (*p)
2183          strlcpy(iptr->userptr, p, iptr->usersize);
2184  
2185 <      if (*q != '\0')
2185 >      if (*q)
2186          strlcpy(iptr->hostptr, q, iptr->hostsize);
2187      }
2188      else
2189      {
2190 <      if (*p != '\0')
2190 >      if (*p)
2191          strlcpy(iptr->userptr, p, iptr->usersize);
2192      }
2193    }
# Line 3424 | Line 2199 | split_nuh(struct split_nuh_item *const i
2199        /* if found a @ */
2200        *p++ = '\0';
2201  
2202 <      if (*iptr->nuhmask != '\0')
2202 >      if (*iptr->nuhmask)
2203          strlcpy(iptr->userptr, iptr->nuhmask, iptr->usersize);
2204  
2205 <      if (*p != '\0')
2205 >      if (*p)
2206          strlcpy(iptr->hostptr, p, iptr->hostsize);
2207      }
2208      else
# Line 3440 | Line 2215 | split_nuh(struct split_nuh_item *const i
2215      }
2216    }
2217   }
3443 –
3444 – /*
3445 – * flags_to_ascii
3446 – *
3447 – * inputs       - flags is a bitmask
3448 – *              - pointer to table of ascii letters corresponding
3449 – *                to each bit
3450 – *              - flag 1 for convert ToLower if bit missing
3451 – *                0 if ignore.
3452 – * output       - none
3453 – * side effects - string pointed to by p has bitmap chars written to it
3454 – */
3455 – static void
3456 – flags_to_ascii(unsigned int flags, const unsigned int bit_table[], char *p,
3457 –               int lowerit)
3458 – {
3459 –  unsigned int mask = 1;
3460 –  int i = 0;
3461 –
3462 –  for (mask = 1; (mask != 0) && (bit_table[i] != 0); mask <<= 1, i++)
3463 –  {
3464 –    if (flags & mask)
3465 –      *p++ = bit_table[i];
3466 –    else if (lowerit)
3467 –      *p++ = ToLower(bit_table[i]);
3468 –  }
3469 –  *p = '\0';
3470 – }
3471 –
3472 – /*
3473 – * cidr_limit_reached
3474 – *
3475 – * inputs       - int flag allowing over_rule of limits
3476 – *              - pointer to the ip to be added
3477 – *              - pointer to the class
3478 – * output       - non zero if limit reached
3479 – *                0 if limit not reached
3480 – * side effects -
3481 – */
3482 – static int
3483 – cidr_limit_reached(int over_rule,
3484 –                   struct irc_ssaddr *ip, struct ClassItem *aclass)
3485 – {
3486 –  dlink_node *ptr = NULL;
3487 –  struct CidrItem *cidr;
3488 –
3489 –  if (aclass->number_per_cidr <= 0)
3490 –    return 0;
3491 –
3492 –  if (ip->ss.ss_family == AF_INET)
3493 –  {
3494 –    if (aclass->cidr_bitlen_ipv4 <= 0)
3495 –      return 0;
3496 –
3497 –    DLINK_FOREACH(ptr, aclass->list_ipv4.head)
3498 –    {
3499 –      cidr = ptr->data;
3500 –      if (match_ipv4(ip, &cidr->mask, aclass->cidr_bitlen_ipv4))
3501 –      {
3502 –        if (!over_rule && (cidr->number_on_this_cidr >= aclass->number_per_cidr))
3503 –          return -1;
3504 –        cidr->number_on_this_cidr++;
3505 –        return 0;
3506 –      }
3507 –    }
3508 –    cidr = MyMalloc(sizeof(struct CidrItem));
3509 –    cidr->number_on_this_cidr = 1;
3510 –    cidr->mask = *ip;
3511 –    mask_addr(&cidr->mask, aclass->cidr_bitlen_ipv4);
3512 –    dlinkAdd(cidr, &cidr->node, &aclass->list_ipv4);
3513 –  }
3514 – #ifdef IPV6
3515 –  else if (aclass->cidr_bitlen_ipv6 > 0)
3516 –  {
3517 –    DLINK_FOREACH(ptr, aclass->list_ipv6.head)
3518 –    {
3519 –      cidr = ptr->data;
3520 –      if (match_ipv6(ip, &cidr->mask, aclass->cidr_bitlen_ipv6))
3521 –      {
3522 –        if (!over_rule && (cidr->number_on_this_cidr >= aclass->number_per_cidr))
3523 –          return -1;
3524 –        cidr->number_on_this_cidr++;
3525 –        return 0;
3526 –      }
3527 –    }
3528 –    cidr = MyMalloc(sizeof(struct CidrItem));
3529 –    cidr->number_on_this_cidr = 1;
3530 –    cidr->mask = *ip;
3531 –    mask_addr(&cidr->mask, aclass->cidr_bitlen_ipv6);
3532 –    dlinkAdd(cidr, &cidr->node, &aclass->list_ipv6);
3533 –  }
3534 – #endif
3535 –  return 0;
3536 – }
3537 –
3538 – /*
3539 – * remove_from_cidr_check
3540 – *
3541 – * inputs       - pointer to the ip to be removed
3542 – *              - pointer to the class
3543 – * output       - NONE
3544 – * side effects -
3545 – */
3546 – static void
3547 – remove_from_cidr_check(struct irc_ssaddr *ip, struct ClassItem *aclass)
3548 – {
3549 –  dlink_node *ptr = NULL;
3550 –  dlink_node *next_ptr = NULL;
3551 –  struct CidrItem *cidr;
3552 –
3553 –  if (aclass->number_per_cidr == 0)
3554 –    return;
3555 –
3556 –  if (ip->ss.ss_family == AF_INET)
3557 –  {
3558 –    if (aclass->cidr_bitlen_ipv4 <= 0)
3559 –      return;
3560 –
3561 –    DLINK_FOREACH_SAFE(ptr, next_ptr, aclass->list_ipv4.head)
3562 –    {
3563 –      cidr = ptr->data;
3564 –      if (match_ipv4(ip, &cidr->mask, aclass->cidr_bitlen_ipv4))
3565 –      {
3566 –        cidr->number_on_this_cidr--;
3567 –        if (cidr->number_on_this_cidr == 0)
3568 –        {
3569 –          dlinkDelete(ptr, &aclass->list_ipv4);
3570 –          MyFree(cidr);
3571 –          return;
3572 –        }
3573 –      }
3574 –    }
3575 –  }
3576 – #ifdef IPV6
3577 –  else if (aclass->cidr_bitlen_ipv6 > 0)
3578 –  {
3579 –    DLINK_FOREACH_SAFE(ptr, next_ptr, aclass->list_ipv6.head)
3580 –    {
3581 –      cidr = ptr->data;
3582 –      if (match_ipv6(ip, &cidr->mask, aclass->cidr_bitlen_ipv6))
3583 –      {
3584 –        cidr->number_on_this_cidr--;
3585 –        if (cidr->number_on_this_cidr == 0)
3586 –        {
3587 –          dlinkDelete(ptr, &aclass->list_ipv6);
3588 –          MyFree(cidr);
3589 –          return;
3590 –        }
3591 –      }
3592 –    }
3593 –  }
3594 – #endif
3595 – }
3596 –
3597 – static void
3598 – rebuild_cidr_list(int aftype, struct ConfItem *oldcl, struct ClassItem *newcl,
3599 –                  dlink_list *old_list, dlink_list *new_list, int changed)
3600 – {
3601 –  dlink_node *ptr;
3602 –  struct Client *client_p;
3603 –  struct ConfItem *conf;
3604 –  struct AccessItem *aconf;
3605 –
3606 –  if (!changed)
3607 –  {
3608 –    *new_list = *old_list;
3609 –    old_list->head = old_list->tail = NULL;
3610 –    old_list->length = 0;
3611 –    return;
3612 –  }
3613 –
3614 –  DLINK_FOREACH(ptr, local_client_list.head)
3615 –  {
3616 –    client_p = ptr->data;
3617 –    if (client_p->localClient->aftype != aftype)
3618 –      continue;
3619 –    if (dlink_list_length(&client_p->localClient->confs) == 0)
3620 –      continue;
3621 –
3622 –    conf = client_p->localClient->confs.tail->data;
3623 –    if (conf->type == CLIENT_TYPE)
3624 –    {
3625 –      aconf = map_to_conf(conf);
3626 –      if (aconf->class_ptr == oldcl)
3627 –        cidr_limit_reached(1, &client_p->localClient->ip, newcl);
3628 –    }
3629 –  }
3630 – }
3631 –
3632 – /*
3633 – * rebuild_cidr_class
3634 – *
3635 – * inputs       - pointer to old conf
3636 – *              - pointer to new_class
3637 – * output       - none
3638 – * side effects - rebuilds the class link list of cidr blocks
3639 – */
3640 – void
3641 – rebuild_cidr_class(struct ConfItem *conf, struct ClassItem *new_class)
3642 – {
3643 –  struct ClassItem *old_class = map_to_conf(conf);
3644 –
3645 –  if (old_class->number_per_cidr > 0 && new_class->number_per_cidr > 0)
3646 –  {
3647 –    if (old_class->cidr_bitlen_ipv4 > 0 && new_class->cidr_bitlen_ipv4 > 0)
3648 –      rebuild_cidr_list(AF_INET, conf, new_class,
3649 –                        &old_class->list_ipv4, &new_class->list_ipv4,
3650 –                        old_class->cidr_bitlen_ipv4 != new_class->cidr_bitlen_ipv4);
3651 –
3652 – #ifdef IPV6
3653 –    if (old_class->cidr_bitlen_ipv6 > 0 && new_class->cidr_bitlen_ipv6 > 0)
3654 –      rebuild_cidr_list(AF_INET6, conf, new_class,
3655 –                        &old_class->list_ipv6, &new_class->list_ipv6,
3656 –                        old_class->cidr_bitlen_ipv6 != new_class->cidr_bitlen_ipv6);
3657 – #endif
3658 –  }
3659 –
3660 –  destroy_cidr_class(old_class);
3661 – }
3662 –
3663 – /*
3664 – * destroy_cidr_list
3665 – *
3666 – * inputs       - pointer to class dlink list of cidr blocks
3667 – * output       - none
3668 – * side effects - completely destroys the class link list of cidr blocks
3669 – */
3670 – static void
3671 – destroy_cidr_list(dlink_list *list)
3672 – {
3673 –  dlink_node *ptr = NULL, *next_ptr = NULL;
3674 –
3675 –  DLINK_FOREACH_SAFE(ptr, next_ptr, list->head)
3676 –  {
3677 –    dlinkDelete(ptr, list);
3678 –    MyFree(ptr->data);
3679 –  }
3680 – }
3681 –
3682 – /*
3683 – * destroy_cidr_class
3684 – *
3685 – * inputs       - pointer to class
3686 – * output       - none
3687 – * side effects - completely destroys the class link list of cidr blocks
3688 – */
3689 – static void
3690 – destroy_cidr_class(struct ClassItem *aclass)
3691 – {
3692 –  destroy_cidr_list(&aclass->list_ipv4);
3693 –  destroy_cidr_list(&aclass->list_ipv6);
3694 – }

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)