ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/conf.c
(Generate patch)

Comparing:
ircd-hybrid-8/src/conf.c (file contents), Revision 1393 by michael, Wed May 2 19:17:37 2012 UTC vs.
ircd-hybrid/trunk/src/conf.c (file contents), Revision 3022 by michael, Mon Feb 24 20:41:16 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  conf.c: Configuration file functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2002 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 18 | Line 17
17   *  along with this program; if not, write to the Free Software
18   *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file conf.c
23 > * \brief Configuration file functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
28   #include "list.h"
29   #include "ircd_defs.h"
28 – #include "balloc.h"
30   #include "conf.h"
31   #include "s_serv.h"
32   #include "resv.h"
# Line 45 | Line 46
46   #include "send.h"
47   #include "s_gline.h"
48   #include "memory.h"
49 + #include "mempool.h"
50   #include "irc_res.h"
51   #include "userhost.h"
52   #include "s_user.h"
53   #include "channel_mode.h"
54   #include "parse.h"
55   #include "s_misc.h"
56 + #include "conf_db.h"
57 + #include "conf_class.h"
58 + #include "motd.h"
59  
60 < struct Callback *client_check_cb = NULL;
60 >
61 > struct config_channel_entry ConfigChannel;
62   struct config_server_hide ConfigServerHide;
63 + struct config_file_entry ConfigFileEntry;
64 + struct logging_entry ConfigLoggingEntry = { .use_logging = 1 };
65 + struct server_info ServerInfo;
66 + struct admin_info AdminInfo;
67  
68   /* general conf items link list root, other than k lines etc. */
69   dlink_list service_items = { NULL, NULL, 0 };
# Line 62 | Line 72 | dlink_list cluster_items = { NULL, NULL,
72   dlink_list oconf_items   = { NULL, NULL, 0 };
73   dlink_list uconf_items   = { NULL, NULL, 0 };
74   dlink_list xconf_items   = { NULL, NULL, 0 };
65 – dlink_list rxconf_items  = { NULL, NULL, 0 };
66 – dlink_list rkconf_items  = { NULL, NULL, 0 };
75   dlink_list nresv_items   = { NULL, NULL, 0 };
76 < dlink_list class_items   = { NULL, NULL, 0 };
69 < dlink_list gdeny_items   = { NULL, NULL, 0 };
70 <
71 < dlink_list temporary_xlines  = { NULL, NULL, 0 };
72 < dlink_list temporary_resv = { NULL, NULL, 0 };
76 > dlink_list cresv_items = { NULL, NULL, 0 };
77  
78   extern unsigned int lineno;
79   extern char linebuf[];
# Line 81 | Line 85 | struct conf_parser_context conf_parser_c
85   /* internally defined functions */
86   static void read_conf(FILE *);
87   static void clear_out_old_conf(void);
84 – static void flush_deleted_I_P(void);
88   static void expire_tklines(dlink_list *);
89   static void garbage_collect_ip_entries(void);
90   static int hash_ip(struct irc_ssaddr *);
91 < static int verify_access(struct Client *, const char *);
92 < static int attach_iline(struct Client *, struct ConfItem *);
91 > static int verify_access(struct Client *);
92 > static int attach_iline(struct Client *, struct MaskItem *);
93   static struct ip_entry *find_or_add_ip(struct irc_ssaddr *);
94 < static void parse_conf_file(int, int);
92 < static dlink_list *map_to_list(ConfType);
93 < static struct AccessItem *find_regexp_kline(const char *[]);
94 > static dlink_list *map_to_list(enum maskitem_type);
95   static int find_user_host(struct Client *, char *, char *, char *, unsigned int);
96  
96 – /*
97 – * bit_len
98 – */
99 – static int cidr_limit_reached(int, struct irc_ssaddr *, struct ClassItem *);
100 – static void remove_from_cidr_check(struct irc_ssaddr *, struct ClassItem *);
101 – static void destroy_cidr_class(struct ClassItem *);
102 –
103 – static void flags_to_ascii(unsigned int, const unsigned int[], char *, int);
104 –
105 – /* address of default class conf */
106 – static struct ConfItem *class_default;
97  
98   /* usually, with hash tables, you use a prime number...
99   * but in this case I am dealing with ip addresses,
# Line 114 | Line 104 | static struct ConfItem *class_default;
104   struct ip_entry
105   {
106    struct irc_ssaddr ip;
107 <  int count;
107 >  unsigned int count;
108    time_t last_attempt;
109    struct ip_entry *next;
110   };
111  
112   static struct ip_entry *ip_hash_table[IP_HASH_SIZE];
113 < static BlockHeap *ip_entry_heap = NULL;
113 > static mp_pool_t *ip_entry_pool = NULL;
114   static int ip_entries_count = 0;
115  
116  
127 – void *
128 – map_to_conf(struct ConfItem *aconf)
129 – {
130 –  void *conf;
131 –  conf = (void *)((uintptr_t)aconf +
132 –                  (uintptr_t)sizeof(struct ConfItem));
133 –  return(conf);
134 – }
135 –
136 – struct ConfItem *
137 – unmap_conf_item(void *aconf)
138 – {
139 –  struct ConfItem *conf;
140 –
141 –  conf = (struct ConfItem *)((uintptr_t)aconf -
142 –                             (uintptr_t)sizeof(struct ConfItem));
143 –  return(conf);
144 – }
145 –
117   /* conf_dns_callback()
118   *
119 < * inputs       - pointer to struct AccessItem
119 > * inputs       - pointer to struct MaskItem
120   *              - pointer to DNSReply reply
121   * output       - none
122   * side effects - called when resolver query finishes
# Line 156 | Line 127 | unmap_conf_item(void *aconf)
127   static void
128   conf_dns_callback(void *vptr, const struct irc_ssaddr *addr, const char *name)
129   {
130 <  struct AccessItem *aconf = vptr;
130 >  struct MaskItem *conf = vptr;
131  
132 <  aconf->dns_pending = 0;
132 >  conf->dns_pending = 0;
133  
134    if (addr != NULL)
135 <    memcpy(&aconf->addr, addr, sizeof(aconf->addr));
135 >    memcpy(&conf->addr, addr, sizeof(conf->addr));
136    else
137 <    aconf->dns_failed = 1;
137 >    conf->dns_failed = 1;
138   }
139  
140   /* conf_dns_lookup()
# Line 173 | Line 144 | conf_dns_callback(void *vptr, const stru
144   * allocate a dns_query and start ns lookup.
145   */
146   static void
147 < conf_dns_lookup(struct AccessItem *aconf)
147 > conf_dns_lookup(struct MaskItem *conf)
148   {
149 <  if (!aconf->dns_pending)
149 >  if (!conf->dns_pending)
150    {
151 <    aconf->dns_pending = 1;
152 <    gethost_byname(conf_dns_callback, aconf, aconf->host);
151 >    conf->dns_pending = 1;
152 >    gethost_byname(conf_dns_callback, conf, conf->host);
153    }
154   }
155  
156 < /* make_conf_item()
157 < *
187 < * inputs       - type of item
188 < * output       - pointer to new conf entry
189 < * side effects - none
190 < */
191 < struct ConfItem *
192 < make_conf_item(ConfType type)
156 > struct MaskItem *
157 > conf_make(enum maskitem_type type)
158   {
159 <  struct ConfItem *conf = NULL;
160 <  struct AccessItem *aconf = NULL;
196 <  struct ClassItem *aclass = NULL;
197 <  int status = 0;
198 <
199 <  switch (type)
200 <  {
201 <  case DLINE_TYPE:
202 <  case EXEMPTDLINE_TYPE:
203 <  case GLINE_TYPE:
204 <  case KLINE_TYPE:
205 <  case CLIENT_TYPE:
206 <  case OPER_TYPE:
207 <  case SERVER_TYPE:
208 <    conf = MyMalloc(sizeof(struct ConfItem) +
209 <                    sizeof(struct AccessItem));
210 <    aconf = map_to_conf(conf);
211 <    aconf->aftype = AF_INET;
212 <
213 <    /* Yes, sigh. switch on type again */
214 <    switch (type)
215 <    {
216 <    case EXEMPTDLINE_TYPE:
217 <      status = CONF_EXEMPTDLINE;
218 <      break;
219 <
220 <    case DLINE_TYPE:
221 <      status = CONF_DLINE;
222 <      break;
223 <
224 <    case KLINE_TYPE:
225 <      status = CONF_KLINE;
226 <      break;
227 <
228 <    case GLINE_TYPE:
229 <      status = CONF_GLINE;
230 <      break;
231 <
232 <    case CLIENT_TYPE:
233 <      status = CONF_CLIENT;
234 <      break;
235 <
236 <    case OPER_TYPE:
237 <      status = CONF_OPERATOR;
238 <      dlinkAdd(conf, &conf->node, &oconf_items);
239 <      break;
240 <
241 <    case SERVER_TYPE:
242 <      status = CONF_SERVER;
243 <      dlinkAdd(conf, &conf->node, &server_items);
244 <      break;
245 <
246 <    default:
247 <      break;
248 <    }
249 <    aconf->status = status;
250 <    break;
251 <
252 <  case ULINE_TYPE:
253 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
254 <                                       sizeof(struct MatchItem));
255 <    dlinkAdd(conf, &conf->node, &uconf_items);
256 <    break;
257 <
258 <  case GDENY_TYPE:
259 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
260 <                                       sizeof(struct AccessItem));
261 <    dlinkAdd(conf, &conf->node, &gdeny_items);
262 <    break;
159 >  struct MaskItem *conf = MyMalloc(sizeof(*conf));
160 >  dlink_list *list = NULL;
161  
162 <  case XLINE_TYPE:
163 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
164 <                                       sizeof(struct MatchItem));
267 <    dlinkAdd(conf, &conf->node, &xconf_items);
268 <    break;
269 < #ifdef HAVE_LIBPCRE
270 <  case RXLINE_TYPE:
271 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
272 <                                       sizeof(struct MatchItem));
273 <    dlinkAdd(conf, &conf->node, &rxconf_items);
274 <    break;
275 <
276 <  case RKLINE_TYPE:
277 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
278 <                                       sizeof(struct AccessItem));
279 <    aconf = map_to_conf(conf);
280 <    aconf->status = CONF_KLINE;
281 <    dlinkAdd(conf, &conf->node, &rkconf_items);
282 <    break;
283 < #endif
284 <  case CLUSTER_TYPE:
285 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem));
286 <    dlinkAdd(conf, &conf->node, &cluster_items);
287 <    break;
288 <
289 <  case CRESV_TYPE:
290 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
291 <                                       sizeof(struct ResvChannel));
292 <    break;
293 <
294 <  case NRESV_TYPE:
295 <    conf = (struct ConfItem *)MyMalloc(sizeof(struct ConfItem) +
296 <                                       sizeof(struct MatchItem));
297 <    dlinkAdd(conf, &conf->node, &nresv_items);
298 <    break;
299 <
300 <  case SERVICE_TYPE:
301 <    status = CONF_SERVICE;
302 <    conf = MyMalloc(sizeof(struct ConfItem));
303 <    dlinkAdd(conf, &conf->node, &service_items);
304 <    break;
305 <
306 <  case CLASS_TYPE:
307 <    conf = MyMalloc(sizeof(struct ConfItem) +
308 <                           sizeof(struct ClassItem));
309 <    dlinkAdd(conf, &conf->node, &class_items);
310 <
311 <    aclass = map_to_conf(conf);
312 <    aclass->active = 1;
313 <    aclass->con_freq = DEFAULT_CONNECTFREQUENCY;
314 <    aclass->ping_freq = DEFAULT_PINGFREQUENCY;
315 <    aclass->max_total = MAXIMUM_LINKS_DEFAULT;
316 <    aclass->max_sendq = DEFAULT_SENDQ;
317 <
318 <    break;
319 <
320 <  default:
321 <    conf = NULL;
322 <    break;
323 <  }
324 <
325 <  /* XXX Yes, this will core if default is hit. I want it to for now - db */
326 <  conf->type = type;
162 >  conf->type   = type;
163 >  conf->active = 1;
164 >  conf->aftype = AF_INET;
165  
166 +  if ((list = map_to_list(type)))
167 +    dlinkAdd(conf, &conf->node, list);
168    return conf;
169   }
170  
171   void
172 < delete_conf_item(struct ConfItem *conf)
172 > conf_free(struct MaskItem *conf)
173   {
174 <  dlink_node *m = NULL, *m_next = NULL;
175 <  struct MatchItem *match_item;
176 <  struct AccessItem *aconf;
177 <  ConfType type = conf->type;
174 >  dlink_node *ptr = NULL, *ptr_next = NULL;
175 >  dlink_list *list = NULL;
176 >
177 >  if (conf->node.next)
178 >    if ((list = map_to_list(conf->type)))
179 >      dlinkDelete(&conf->node, list);
180  
181    MyFree(conf->name);
340 –  conf->name = NULL;
182  
183 <  switch(type)
184 <  {
185 <  case DLINE_TYPE:
186 <  case EXEMPTDLINE_TYPE:
187 <  case GLINE_TYPE:
188 <  case KLINE_TYPE:
189 <  case CLIENT_TYPE:
190 <  case OPER_TYPE:
191 <  case SERVER_TYPE:
192 <    aconf = map_to_conf(conf);
193 <
194 <    if (aconf->dns_pending)
195 <      delete_resolver_queries(aconf);
196 <    if (aconf->passwd != NULL)
197 <      memset(aconf->passwd, 0, strlen(aconf->passwd));
357 <    if (aconf->spasswd != NULL)
358 <      memset(aconf->spasswd, 0, strlen(aconf->spasswd));
359 <    aconf->class_ptr = NULL;
360 <
361 <    MyFree(aconf->passwd);
362 <    MyFree(aconf->spasswd);
363 <    MyFree(aconf->reason);
364 <    MyFree(aconf->oper_reason);
365 <    MyFree(aconf->user);
366 <    MyFree(aconf->host);
367 <    MyFree(aconf->cipher_list);
183 >  if (conf->dns_pending)
184 >    delete_resolver_queries(conf);
185 >  if (conf->passwd != NULL)
186 >    memset(conf->passwd, 0, strlen(conf->passwd));
187 >  if (conf->spasswd != NULL)
188 >    memset(conf->spasswd, 0, strlen(conf->spasswd));
189 >
190 >  conf->class = NULL;
191 >
192 >  MyFree(conf->passwd);
193 >  MyFree(conf->spasswd);
194 >  MyFree(conf->reason);
195 >  MyFree(conf->certfp);
196 >  MyFree(conf->user);
197 >  MyFree(conf->host);
198   #ifdef HAVE_LIBCRYPTO
199 <    if (aconf->rsa_public_key)
370 <      RSA_free(aconf->rsa_public_key);
371 <    MyFree(aconf->rsa_public_key_file);
372 < #endif
373 <
374 <    /* Yes, sigh. switch on type again */
375 <    switch(type)
376 <    {
377 <    case EXEMPTDLINE_TYPE:
378 <    case DLINE_TYPE:
379 <    case GLINE_TYPE:
380 <    case KLINE_TYPE:
381 <    case CLIENT_TYPE:
382 <      MyFree(conf);
383 <      break;
199 >  MyFree(conf->cipher_list);
200  
201 <    case OPER_TYPE:
202 <      aconf = map_to_conf(conf);
387 <      if (!IsConfIllegal(aconf))
388 <        dlinkDelete(&conf->node, &oconf_items);
389 <      MyFree(conf);
390 <      break;
391 <
392 <    case SERVER_TYPE:
393 <      aconf = map_to_conf(conf);
394 <
395 <      DLINK_FOREACH_SAFE(m, m_next, aconf->hub_list.head)
396 <      {
397 <        MyFree(m->data);
398 <        free_dlink_node(m);
399 <      }
400 <
401 <      DLINK_FOREACH_SAFE(m, m_next, aconf->leaf_list.head)
402 <      {
403 <        MyFree(m->data);
404 <        free_dlink_node(m);  
405 <      }
406 <
407 <      if (!IsConfIllegal(aconf))
408 <        dlinkDelete(&conf->node, &server_items);
409 <      MyFree(conf);
410 <      break;
411 <
412 <    default:
413 <      break;
414 <    }
415 <    break;
416 <
417 <  case ULINE_TYPE:
418 <    match_item = map_to_conf(conf);
419 <    MyFree(match_item->user);
420 <    MyFree(match_item->host);
421 <    MyFree(match_item->reason);
422 <    MyFree(match_item->oper_reason);
423 <    dlinkDelete(&conf->node, &uconf_items);
424 <    MyFree(conf);
425 <    break;
426 <
427 <  case XLINE_TYPE:
428 <    match_item = map_to_conf(conf);
429 <    MyFree(match_item->user);
430 <    MyFree(match_item->host);
431 <    MyFree(match_item->reason);
432 <    MyFree(match_item->oper_reason);
433 <    dlinkDelete(&conf->node, &xconf_items);
434 <    MyFree(conf);
435 <    break;
436 < #ifdef HAVE_LIBPCRE
437 <  case RKLINE_TYPE:
438 <    aconf = map_to_conf(conf);
439 <    MyFree(aconf->regexuser);
440 <    MyFree(aconf->regexhost);
441 <    MyFree(aconf->user);
442 <    MyFree(aconf->host);
443 <    MyFree(aconf->reason);
444 <    MyFree(aconf->oper_reason);
445 <    dlinkDelete(&conf->node, &rkconf_items);
446 <    MyFree(conf);
447 <    break;
448 <
449 <  case RXLINE_TYPE:
450 <    MyFree(conf->regexpname);
451 <    match_item = map_to_conf(conf);
452 <    MyFree(match_item->user);
453 <    MyFree(match_item->host);
454 <    MyFree(match_item->reason);
455 <    MyFree(match_item->oper_reason);
456 <    dlinkDelete(&conf->node, &rxconf_items);
457 <    MyFree(conf);
458 <    break;
201 >  if (conf->rsa_public_key)
202 >    RSA_free(conf->rsa_public_key);
203   #endif
204 <  case NRESV_TYPE:
205 <    match_item = map_to_conf(conf);
206 <    MyFree(match_item->user);
207 <    MyFree(match_item->host);
208 <    MyFree(match_item->reason);
465 <    MyFree(match_item->oper_reason);
466 <    dlinkDelete(&conf->node, &nresv_items);
467 <
468 <    if (conf->flags & CONF_FLAGS_TEMPORARY)
469 <      if ((m = dlinkFindDelete(&temporary_resv, conf)) != NULL)
470 <        free_dlink_node(m);
471 <
472 <    MyFree(conf);
473 <    break;
474 <
475 <  case GDENY_TYPE:
476 <    aconf = map_to_conf(conf);
477 <    MyFree(aconf->user);
478 <    MyFree(aconf->host);
479 <    dlinkDelete(&conf->node, &gdeny_items);
480 <    MyFree(conf);
481 <    break;
482 <
483 <  case CLUSTER_TYPE:
484 <    dlinkDelete(&conf->node, &cluster_items);
485 <    MyFree(conf);
486 <    break;
487 <
488 <  case CRESV_TYPE:
489 <    if (conf->flags & CONF_FLAGS_TEMPORARY)
490 <      if ((m = dlinkFindDelete(&temporary_resv, conf)) != NULL)
491 <        free_dlink_node(m);
492 <
493 <    MyFree(conf);
494 <    break;
495 <
496 <  case CLASS_TYPE:
497 <    dlinkDelete(&conf->node, &class_items);
498 <    MyFree(conf);
499 <    break;
500 <
501 <  case SERVICE_TYPE:
502 <    dlinkDelete(&conf->node, &service_items);
503 <    MyFree(conf);
504 <    break;
505 <
506 <  default:
507 <    break;
204 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->hub_list.head)
205 >  {
206 >    MyFree(ptr->data);
207 >    dlinkDelete(ptr, &conf->hub_list);
208 >    free_dlink_node(ptr);
209    }
509 – }
510 –
511 – /* free_access_item()
512 – *
513 – * inputs       - pointer to conf to free
514 – * output       - none
515 – * side effects - crucial password fields are zeroed, conf is freed
516 – */
517 – void
518 – free_access_item(struct AccessItem *aconf)
519 – {
520 –  struct ConfItem *conf;
210  
211 <  if (aconf == NULL)
523 <    return;
524 <  conf = unmap_conf_item(aconf);
525 <  delete_conf_item(conf);
526 < }
527 <
528 < static const unsigned int shared_bit_table[] =
529 <  { 'K', 'k', 'U', 'X', 'x', 'Y', 'Q', 'q', 'R', 'L', 0};
530 <
531 < /* report_confitem_types()
532 < *
533 < * inputs       - pointer to client requesting confitem report
534 < *              - ConfType to report
535 < * output       - none
536 < * side effects -
537 < */
538 < void
539 < report_confitem_types(struct Client *source_p, ConfType type)
540 < {
541 <  dlink_node *ptr = NULL, *dptr = NULL;
542 <  struct ConfItem *conf = NULL;
543 <  struct AccessItem *aconf = NULL;
544 <  struct MatchItem *matchitem = NULL;
545 <  struct ClassItem *classitem = NULL;
546 <  char buf[12];
547 <  char *p = NULL;
548 <
549 <  switch (type)
211 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->leaf_list.head)
212    {
213 <  case GDENY_TYPE:
214 <    DLINK_FOREACH(ptr, gdeny_items.head)
215 <    {
216 <      conf = ptr->data;
555 <      aconf = map_to_conf(conf);
556 <
557 <      p = buf;
558 <
559 <      if (aconf->flags & GDENY_BLOCK)
560 <        *p++ = 'B';
561 <      else
562 <        *p++ = 'b';
563 <
564 <      if (aconf->flags & GDENY_REJECT)
565 <        *p++ = 'R';
566 <      else
567 <        *p++ = 'r';
568 <
569 <      *p = '\0';
570 <
571 <      sendto_one(source_p, ":%s %d %s V %s@%s %s %s",
572 <                 me.name, RPL_STATSDEBUG, source_p->name,
573 <                 aconf->user, aconf->host, conf->name, buf);
574 <    }
575 <    break;
576 <
577 <  case XLINE_TYPE:
578 <    DLINK_FOREACH(ptr, xconf_items.head)
579 <    {
580 <      conf = ptr->data;
581 <      matchitem = map_to_conf(conf);
582 <
583 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
584 <                 me.name, source_p->name,
585 <                 matchitem->hold ? "x": "X", matchitem->count,
586 <                 conf->name, matchitem->reason);
587 <    }
588 <    break;
589 <
590 < #ifdef HAVE_LIBPCRE
591 <  case RXLINE_TYPE:
592 <    DLINK_FOREACH(ptr, rxconf_items.head)
593 <    {
594 <      conf = ptr->data;
595 <      matchitem = map_to_conf(conf);
596 <
597 <      sendto_one(source_p, form_str(RPL_STATSXLINE),
598 <                 me.name, source_p->name,
599 <                 "XR", matchitem->count,
600 <                 conf->name, matchitem->reason);
601 <    }
602 <    break;
603 <
604 <  case RKLINE_TYPE:
605 <    DLINK_FOREACH(ptr, rkconf_items.head)
606 <    {
607 <      aconf = map_to_conf((conf = ptr->data));
608 <
609 <      sendto_one(source_p, form_str(RPL_STATSKLINE), me.name,
610 <                 source_p->name, "KR", aconf->host, aconf->user,
611 <                 aconf->reason, aconf->oper_reason ? aconf->oper_reason : "");
612 <    }
613 <    break;
614 < #endif
615 <
616 <  case ULINE_TYPE:
617 <    DLINK_FOREACH(ptr, uconf_items.head)
618 <    {
619 <      conf = ptr->data;
620 <      matchitem = map_to_conf(conf);
621 <
622 <      p = buf;
623 <
624 <      /* some of these are redundant for the sake of
625 <       * consistency with cluster{} flags
626 <       */
627 <      *p++ = 'c';
628 <      flags_to_ascii(matchitem->action, shared_bit_table, p, 0);
629 <
630 <      sendto_one(source_p, form_str(RPL_STATSULINE),
631 <                 me.name, source_p->name, conf->name,
632 <                 matchitem->user?matchitem->user: "*",
633 <                 matchitem->host?matchitem->host: "*", buf);
634 <    }
635 <
636 <    DLINK_FOREACH(ptr, cluster_items.head)
637 <    {
638 <      conf = ptr->data;
639 <
640 <      p = buf;
641 <
642 <      *p++ = 'C';
643 <      flags_to_ascii(conf->flags, shared_bit_table, p, 0);
644 <
645 <      sendto_one(source_p, form_str(RPL_STATSULINE),
646 <                 me.name, source_p->name, conf->name,
647 <                 "*", "*", buf);
648 <    }
649 <
650 <    break;
651 <
652 <  case OPER_TYPE:
653 <    DLINK_FOREACH(ptr, oconf_items.head)
654 <    {
655 <      conf = ptr->data;
656 <      aconf = map_to_conf(conf);
657 <
658 <      /* Don't allow non opers to see oper privs */
659 <      if (HasUMode(source_p, UMODE_OPER))
660 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
661 <                   me.name, source_p->name, 'O', aconf->user, aconf->host,
662 <                   conf->name, oper_privs_as_string(aconf->port),
663 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
664 <      else
665 <        sendto_one(source_p, form_str(RPL_STATSOLINE),
666 <                   me.name, source_p->name, 'O', aconf->user, aconf->host,
667 <                   conf->name, "0",
668 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
669 <    }
670 <    break;
671 <
672 <  case CLASS_TYPE:
673 <    DLINK_FOREACH(ptr, class_items.head)
674 <    {
675 <      conf = ptr->data;
676 <      classitem = map_to_conf(conf);
677 <      sendto_one(source_p, form_str(RPL_STATSYLINE),
678 <                 me.name, source_p->name, 'Y',
679 <                 conf->name, classitem->ping_freq,
680 <                 classitem->con_freq,
681 <                 classitem->max_total, classitem->max_sendq,
682 <                 classitem->curr_user_count,
683 <                 classitem->active ? "active" : "disabled");
684 <    }
685 <    break;
686 <
687 <  case CONF_TYPE:
688 <  case CLIENT_TYPE:
689 <    break;
690 <
691 <  case SERVICE_TYPE:
692 <    DLINK_FOREACH(ptr, service_items.head)
693 <    {
694 <      conf = ptr->data;
695 <      sendto_one(source_p, form_str(RPL_STATSSERVICE),
696 <                 me.name, source_p->name, 'S', "*", conf->name, 0, 0);
697 <    }
698 <    break;
699 <
700 <  case SERVER_TYPE:
701 <    DLINK_FOREACH(ptr, server_items.head)
702 <    {
703 <      p = buf;
704 <
705 <      conf = ptr->data;
706 <      aconf = map_to_conf(conf);
707 <
708 <      buf[0] = '\0';
709 <
710 <      if (IsConfAllowAutoConn(aconf))
711 <        *p++ = 'A';
712 <      if (IsConfSSL(aconf))
713 <        *p++ = 'S';
714 <      if (IsConfTopicBurst(aconf))
715 <        *p++ = 'T';
716 <      if (buf[0] == '\0')
717 <        *p++ = '*';
718 <
719 <      *p = '\0';
720 <
721 <      /*
722 <       * Allow admins to see actual ips unless hide_server_ips is enabled
723 <       */
724 <      if (!ConfigServerHide.hide_server_ips && HasUMode(source_p, UMODE_ADMIN))
725 <        sendto_one(source_p, form_str(RPL_STATSCLINE),
726 <                   me.name, source_p->name, 'C', aconf->host,
727 <                   buf, conf->name, aconf->port,
728 <                   aconf->class_ptr ? aconf->class_ptr->name : "<default>");
729 <        else
730 <          sendto_one(source_p, form_str(RPL_STATSCLINE),
731 <                     me.name, source_p->name, 'C',
732 <                     "*@127.0.0.1", buf, conf->name, aconf->port,
733 <                     aconf->class_ptr ? aconf->class_ptr->name : "<default>");
734 <    }
735 <    break;
736 <
737 <  case HUB_TYPE:
738 <    DLINK_FOREACH(ptr, server_items.head)
739 <    {
740 <      conf = ptr->data;
741 <      aconf = map_to_conf(conf);
742 <
743 <      DLINK_FOREACH(dptr, aconf->hub_list.head)
744 <        sendto_one(source_p, form_str(RPL_STATSHLINE), me.name,
745 <                   source_p->name, 'H', dptr->data, conf->name, 0, "*");
746 <    }
747 <    break;
748 <
749 <  case LEAF_TYPE:
750 <    DLINK_FOREACH(ptr, server_items.head)
751 <    {
752 <      conf = ptr->data;
753 <      aconf = map_to_conf(conf);
213 >    MyFree(ptr->data);
214 >    dlinkDelete(ptr, &conf->leaf_list);
215 >    free_dlink_node(ptr);
216 >  }
217  
218 <      DLINK_FOREACH(dptr, aconf->leaf_list.head)
219 <        sendto_one(source_p, form_str(RPL_STATSLLINE), me.name,
220 <                   source_p->name, 'L', dptr->data, conf->name, 0, "*");
758 <    }
759 <    break;
218 >  DLINK_FOREACH_SAFE(ptr, ptr_next, conf->exempt_list.head)
219 >  {
220 >    struct exempt *exptr = ptr->data;
221  
222 <  case GLINE_TYPE:
223 <  case KLINE_TYPE:
224 <  case DLINE_TYPE:
225 <  case EXEMPTDLINE_TYPE:
226 <  case CRESV_TYPE:
766 <  case NRESV_TYPE:
767 <  case CLUSTER_TYPE:
768 <  default:
769 <    break;
222 >    dlinkDelete(ptr, &conf->exempt_list);
223 >    MyFree(exptr->name);
224 >    MyFree(exptr->user);
225 >    MyFree(exptr->host);
226 >    MyFree(exptr);
227    }
228 +
229 +  MyFree(conf);
230   }
231  
232   /* check_client()
# Line 783 | Line 242 | report_confitem_types(struct Client *sou
242   *                Look for conf lines which have the same
243   *                status as the flags passed.
244   */
245 < static void *
246 < check_client(va_list args)
245 > int
246 > check_client(struct Client *source_p)
247   {
789 –  struct Client *source_p = va_arg(args, struct Client *);
790 –  const char *username = va_arg(args, const char *);
248    int i;
249 <
250 <  /* I'm already in big trouble if source_p->localClient is NULL -db */
251 <  if ((i = verify_access(source_p, username)))
795 <    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
249 >
250 >  if ((i = verify_access(source_p)))
251 >    ilog(LOG_TYPE_IRCD, "Access denied: %s[%s]",
252           source_p->name, source_p->sockhost);
253  
254    switch (i)
255    {
256      case TOO_MANY:
257 <      sendto_realops_flags(UMODE_FULL, L_ALL,
257 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
258                             "Too many on IP for %s (%s).",
259 <                           get_client_name(source_p, SHOW_IP),
260 <                           source_p->sockhost);
259 >                           get_client_name(source_p, SHOW_IP),
260 >                           source_p->sockhost);
261        ilog(LOG_TYPE_IRCD, "Too many connections on IP from %s.",
262 <           get_client_name(source_p, SHOW_IP));
262 >           get_client_name(source_p, SHOW_IP));
263        ++ServerStats.is_ref;
264        exit_client(source_p, &me, "No more connections allowed on that IP");
265        break;
266  
267      case I_LINE_FULL:
268 <      sendto_realops_flags(UMODE_FULL, L_ALL,
269 <                           "I-line is full for %s (%s).",
270 <                           get_client_name(source_p, SHOW_IP),
271 <                           source_p->sockhost);
268 >      sendto_realops_flags(UMODE_FULL, L_ALL, SEND_NOTICE,
269 >                           "auth{} block is full for %s (%s).",
270 >                           get_client_name(source_p, SHOW_IP),
271 >                           source_p->sockhost);
272        ilog(LOG_TYPE_IRCD, "Too many connections from %s.",
273 <           get_client_name(source_p, SHOW_IP));
273 >           get_client_name(source_p, SHOW_IP));
274        ++ServerStats.is_ref;
275 <      exit_client(source_p, &me,
276 <                "No more connections allowed in your connection class");
275 >      exit_client(source_p, &me,
276 >                  "No more connections allowed in your connection class");
277        break;
278  
279      case NOT_AUTHORIZED:
280        ++ServerStats.is_ref;
281        /* jdc - lists server name & port connections are on */
282        /*       a purely cosmetical change */
283 <      sendto_realops_flags(UMODE_UNAUTH, L_ALL,
284 <                           "Unauthorized client connection from %s [%s] on [%s/%u].",
285 <                           get_client_name(source_p, SHOW_IP),
286 <                           source_p->sockhost,
287 <                           source_p->localClient->listener->name,
288 <                           source_p->localClient->listener->port);
283 >      sendto_realops_flags(UMODE_UNAUTH, L_ALL, SEND_NOTICE,
284 >                           "Unauthorized client connection from %s [%s] on [%s/%u].",
285 >                           get_client_name(source_p, SHOW_IP),
286 >                           source_p->sockhost,
287 >                           source_p->localClient->listener->name,
288 >                           source_p->localClient->listener->port);
289        ilog(LOG_TYPE_IRCD,
290 <          "Unauthorized client connection from %s on [%s/%u].",
291 <          get_client_name(source_p, SHOW_IP),
292 <          source_p->localClient->listener->name,
293 <          source_p->localClient->listener->port);
294 <
295 <      /* XXX It is prolematical whether it is better to use the
840 <       * capture reject code here or rely on the connecting too fast code.
841 <       * - Dianora
842 <       */
843 <      if (REJECT_HOLD_TIME > 0)
844 <      {
845 <        sendto_one(source_p, ":%s NOTICE %s :You are not authorized to use this server",
846 <                   me.name, source_p->name);
847 <        source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
848 <        SetCaptured(source_p);
849 <      }
850 <      else
851 <        exit_client(source_p, &me, "You are not authorized to use this server");
290 >           "Unauthorized client connection from %s on [%s/%u].",
291 >           get_client_name(source_p, SHOW_IP),
292 >           source_p->localClient->listener->name,
293 >           source_p->localClient->listener->port);
294 >
295 >      exit_client(source_p, &me, "You are not authorized to use this server");
296        break;
297  
298     case BANNED_CLIENT:
299 <     /*
856 <      * Don't exit them immediately, play with them a bit.
857 <      * - Dianora
858 <      */
859 <     if (REJECT_HOLD_TIME > 0)
860 <     {
861 <       source_p->localClient->reject_delay = CurrentTime + REJECT_HOLD_TIME;
862 <       SetCaptured(source_p);
863 <     }
864 <     else
865 <       exit_client(source_p, &me, "Banned");
299 >     exit_client(source_p, &me, "Banned");
300       ++ServerStats.is_ref;
301       break;
302  
# Line 871 | Line 305 | check_client(va_list args)
305       break;
306    }
307  
308 <  return (i < 0 ? NULL : source_p);
308 >  return (i < 0 ? 0 : 1);
309   }
310  
311   /* verify_access()
312   *
313   * inputs       - pointer to client to verify
880 – *              - pointer to proposed username
314   * output       - 0 if success -'ve if not
315   * side effect  - find the first (best) I line to attach.
316   */
317   static int
318 < verify_access(struct Client *client_p, const char *username)
318 > verify_access(struct Client *client_p)
319   {
320 <  struct AccessItem *aconf = NULL, *rkconf = NULL;
888 <  struct ConfItem *conf = NULL;
320 >  struct MaskItem *conf = NULL;
321    char non_ident[USERLEN + 1] = { '~', '\0' };
890 –  const char *uhi[3];
322  
323    if (IsGotId(client_p))
324    {
325 <    aconf = find_address_conf(client_p->host, client_p->username,
326 <                             &client_p->localClient->ip,
327 <                             client_p->localClient->aftype,
325 >    conf = find_address_conf(client_p->host, client_p->username,
326 >                             &client_p->localClient->ip,
327 >                             client_p->localClient->aftype,
328                               client_p->localClient->passwd);
329    }
330    else
331    {
332 <    strlcpy(non_ident+1, username, sizeof(non_ident)-1);
333 <    aconf = find_address_conf(client_p->host,non_ident,
334 <                             &client_p->localClient->ip,
335 <                             client_p->localClient->aftype,
336 <                             client_p->localClient->passwd);
332 >    strlcpy(non_ident + 1, client_p->username, sizeof(non_ident) - 1);
333 >    conf = find_address_conf(client_p->host,non_ident,
334 >                             &client_p->localClient->ip,
335 >                             client_p->localClient->aftype,
336 >                             client_p->localClient->passwd);
337    }
338  
339 <  uhi[0] = IsGotId(client_p) ? client_p->username : non_ident;
909 <  uhi[1] = client_p->host;
910 <  uhi[2] = client_p->sockhost;
911 <
912 <  rkconf = find_regexp_kline(uhi);
913 <
914 <  if (aconf != NULL)
339 >  if (conf != NULL)
340    {
341 <    if (IsConfClient(aconf) && !rkconf)
341 >    if (IsConfClient(conf))
342      {
343 <      conf = unmap_conf_item(aconf);
919 <
920 <      if (IsConfRedir(aconf))
343 >      if (IsConfRedir(conf))
344        {
345          sendto_one(client_p, form_str(RPL_REDIR),
346                     me.name, client_p->name,
347                     conf->name ? conf->name : "",
348 <                   aconf->port);
349 <        return(NOT_AUTHORIZED);
348 >                   conf->port);
349 >        return NOT_AUTHORIZED;
350        }
351  
352 <      if (IsConfDoIdentd(aconf))
353 <        SetNeedId(client_p);
352 >      if (IsConfDoIdentd(conf))
353 >        SetNeedId(client_p);
354  
355        /* Thanks for spoof idea amm */
356 <      if (IsConfDoSpoofIp(aconf))
356 >      if (IsConfDoSpoofIp(conf))
357        {
358 <        conf = unmap_conf_item(aconf);
359 <
360 <        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(aconf))
938 <          sendto_realops_flags(UMODE_ALL, L_ADMIN, "%s spoofing: %s as %s",
358 >        if (!ConfigFileEntry.hide_spoof_ips && IsConfSpoofNotice(conf))
359 >          sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
360 >                               "%s spoofing: %s as %s",
361                                 client_p->name, client_p->host, conf->name);
362          strlcpy(client_p->host, conf->name, sizeof(client_p->host));
363 <        SetIPSpoof(client_p);
363 >        AddFlag(client_p, FLAGS_IP_SPOOFING | FLAGS_AUTH_SPOOF);
364        }
365  
366 <      return(attach_iline(client_p, conf));
366 >      return attach_iline(client_p, conf);
367      }
368 <    else if (rkconf || IsConfKill(aconf) || (ConfigFileEntry.glines && IsConfGline(aconf)))
368 >    else if (IsConfKill(conf) || (ConfigFileEntry.glines && IsConfGline(conf)))
369      {
370 <      /* XXX */
949 <      aconf = rkconf ? rkconf : aconf;
950 <      if (IsConfGline(aconf))
370 >      if (IsConfGline(conf))
371          sendto_one(client_p, ":%s NOTICE %s :*** G-lined", me.name,
372                     client_p->name);
373 <      if (ConfigFileEntry.kline_with_reason)
374 <        sendto_one(client_p, ":%s NOTICE %s :*** Banned %s",
375 <                  me.name, client_p->name, aconf->reason);
956 <      return(BANNED_CLIENT);
373 >      sendto_one(client_p, ":%s NOTICE %s :*** Banned: %s",
374 >                 me.name, client_p->name, conf->reason);
375 >      return BANNED_CLIENT;
376      }
377    }
378  
379 <  return(NOT_AUTHORIZED);
379 >  return NOT_AUTHORIZED;
380   }
381  
382   /* attach_iline()
# Line 968 | Line 387 | verify_access(struct Client *client_p, c
387   * side effects - do actual attach
388   */
389   static int
390 < attach_iline(struct Client *client_p, struct ConfItem *conf)
390 > attach_iline(struct Client *client_p, struct MaskItem *conf)
391   {
392 <  struct AccessItem *aconf;
974 <  struct ClassItem *aclass;
392 >  struct ClassItem *class = NULL;
393    struct ip_entry *ip_found;
394    int a_limit_reached = 0;
395 <  int local = 0, global = 0, ident = 0;
395 >  unsigned int local = 0, global = 0, ident = 0;
396 >
397 >  assert(conf->class);
398  
399    ip_found = find_or_add_ip(&client_p->localClient->ip);
400    ip_found->count++;
401    SetIpHash(client_p);
402  
403 <  aconf = map_to_conf(conf);
984 <  if (aconf->class_ptr == NULL)
985 <    return NOT_AUTHORIZED;  /* If class is missing, this is best */
986 <
987 <  aclass = map_to_conf(aconf->class_ptr);
403 >  class = conf->class;
404  
405    count_user_host(client_p->username, client_p->host,
406                    &global, &local, &ident);
# Line 993 | Line 409 | attach_iline(struct Client *client_p, st
409     * setting a_limit_reached if any limit is reached.
410     * - Dianora
411     */
412 <  if (aclass->max_total != 0 && aclass->curr_user_count >= aclass->max_total)
412 >  if (class->max_total != 0 && class->ref_count >= class->max_total)
413      a_limit_reached = 1;
414 <  else if (aclass->max_perip != 0 && ip_found->count > aclass->max_perip)
414 >  else if (class->max_perip != 0 && ip_found->count > class->max_perip)
415      a_limit_reached = 1;
416 <  else if (aclass->max_local != 0 && local >= aclass->max_local)
416 >  else if (class->max_local != 0 && local >= class->max_local)
417      a_limit_reached = 1;
418 <  else if (aclass->max_global != 0 && global >= aclass->max_global)
418 >  else if (class->max_global != 0 && global >= class->max_global)
419      a_limit_reached = 1;
420 <  else if (aclass->max_ident != 0 && ident >= aclass->max_ident &&
420 >  else if (class->max_ident != 0 && ident >= class->max_ident &&
421             client_p->username[0] != '~')
422      a_limit_reached = 1;
423  
424    if (a_limit_reached)
425    {
426 <    if (!IsConfExemptLimits(aconf))
426 >    if (!IsConfExemptLimits(conf))
427        return TOO_MANY;   /* Already at maximum allowed */
428  
429      sendto_one(client_p,
# Line 1028 | Line 444 | attach_iline(struct Client *client_p, st
444   void
445   init_ip_hash_table(void)
446   {
447 <  ip_entry_heap = BlockHeapCreate("ip", sizeof(struct ip_entry),
1032 <    2 * hard_fdlimit);
447 >  ip_entry_pool = mp_pool_new(sizeof(struct ip_entry), MP_CHUNK_SIZE_IP_ENTRY);
448    memset(ip_hash_table, 0, sizeof(ip_hash_table));
449   }
450  
# Line 1078 | Line 493 | find_or_add_ip(struct irc_ssaddr *ip_in)
493    if (ip_entries_count >= 2 * hard_fdlimit)
494      garbage_collect_ip_entries();
495  
496 <  newptr = BlockHeapAlloc(ip_entry_heap);
496 >  newptr = mp_pool_get(ip_entry_pool);
497 >  memset(newptr, 0, sizeof(*newptr));
498    ip_entries_count++;
499    memcpy(&newptr->ip, ip_in, sizeof(struct irc_ssaddr));
500  
# Line 1129 | Line 545 | remove_one_ip(struct irc_ssaddr *ip_in)
545      if (ptr->count > 0)
546        ptr->count--;
547      if (ptr->count == 0 &&
548 <        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
548 >        (CurrentTime-ptr->last_attempt) >= ConfigFileEntry.throttle_time)
549      {
550        if (last_ptr != NULL)
551 <        last_ptr->next = ptr->next;
551 >        last_ptr->next = ptr->next;
552        else
553 <        ip_hash_table[hash_index] = ptr->next;
553 >        ip_hash_table[hash_index] = ptr->next;
554  
555 <      BlockHeapFree(ip_entry_heap, ptr);
555 >      mp_pool_release(ptr);
556        ip_entries_count--;
557        return;
558      }
# Line 1171 | Line 587 | hash_ip(struct irc_ssaddr *addr)
587      uint32_t *ip = (uint32_t *)&v6->sin6_addr.s6_addr;
588  
589      hash  = ip[0] ^ ip[3];
590 <    hash ^= hash >> 16;  
591 <    hash ^= hash >> 8;  
590 >    hash ^= hash >> 16;
591 >    hash ^= hash >> 8;
592      hash  = hash & (IP_HASH_SIZE - 1);
593      return hash;
594    }
# Line 1183 | Line 599 | hash_ip(struct irc_ssaddr *addr)
599  
600   /* count_ip_hash()
601   *
602 < * inputs        - pointer to counter of number of ips hashed
602 > * inputs        - pointer to counter of number of ips hashed
603   *               - pointer to memory used for ip hash
604   * output        - returned via pointers input
605   * side effects  - NONE
# Line 1239 | Line 655 | garbage_collect_ip_entries(void)
655            last_ptr->next = ptr->next;
656          else
657            ip_hash_table[i] = ptr->next;
658 <        BlockHeapFree(ip_entry_heap, ptr);
658 >        mp_pool_release(ptr);
659          ip_entries_count--;
660        }
661        else
# Line 1256 | Line 672 | garbage_collect_ip_entries(void)
672   * side effects - Disassociate configuration from the client.
673   *                Also removes a class from the list if marked for deleting.
674   */
675 < int
676 < detach_conf(struct Client *client_p, ConfType type)
675 > void
676 > detach_conf(struct Client *client_p, enum maskitem_type type)
677   {
678 <  dlink_node *ptr, *next_ptr;
1263 <  struct ConfItem *conf;
1264 <  struct ClassItem *aclass;
1265 <  struct AccessItem *aconf;
1266 <  struct ConfItem *aclass_conf;
1267 <  struct MatchItem *match_item;
678 >  dlink_node *ptr = NULL, *next_ptr = NULL;
679  
680    DLINK_FOREACH_SAFE(ptr, next_ptr, client_p->localClient->confs.head)
681    {
682 <    conf = ptr->data;
1272 <
1273 <    if (type == CONF_TYPE || conf->type == type)
1274 <    {
1275 <      dlinkDelete(ptr, &client_p->localClient->confs);
1276 <      free_dlink_node(ptr);
1277 <
1278 <      switch (conf->type)
1279 <      {
1280 <      case CLIENT_TYPE:
1281 <      case OPER_TYPE:
1282 <      case SERVER_TYPE:
1283 <        aconf = map_to_conf(conf);
1284 <
1285 <        assert(aconf->clients > 0);
682 >    struct MaskItem *conf = ptr->data;
683  
684 <        if ((aclass_conf = aconf->class_ptr) != NULL)
685 <        {
686 <          aclass = map_to_conf(aclass_conf);
1290 <
1291 <          assert(aclass->curr_user_count > 0);
684 >    assert(conf->type & (CONF_CLIENT | CONF_OPER | CONF_SERVER));
685 >    assert(conf->ref_count > 0);
686 >    assert(conf->class->ref_count > 0);
687  
688 <          if (conf->type == CLIENT_TYPE)
689 <            remove_from_cidr_check(&client_p->localClient->ip, aclass);
1295 <          if (--aclass->curr_user_count == 0 && aclass->active == 0)
1296 <            delete_conf_item(aclass_conf);
1297 <        }
688 >    if (!(conf->type & type))
689 >      continue;
690  
691 <        if (--aconf->clients == 0 && IsConfIllegal(aconf))
692 <          delete_conf_item(conf);
691 >    dlinkDelete(ptr, &client_p->localClient->confs);
692 >    free_dlink_node(ptr);
693  
694 <        break;
695 <      default:
1304 <        break;
1305 <      }
694 >    if (conf->type == CONF_CLIENT)
695 >      remove_from_cidr_check(&client_p->localClient->ip, conf->class);
696  
697 <      if (type != CONF_TYPE)
698 <        return 0;
697 >    if (--conf->class->ref_count == 0 && conf->class->active == 0)
698 >    {
699 >      class_free(conf->class);
700 >      conf->class = NULL;
701      }
1310 –  }
702  
703 <  return -1;
703 >    if (--conf->ref_count == 0 && conf->active == 0)
704 >      conf_free(conf);
705 >  }
706   }
707  
708   /* attach_conf()
# Line 1323 | Line 716 | detach_conf(struct Client *client_p, Con
716   *                attachment if there was an old one...
717   */
718   int
719 < attach_conf(struct Client *client_p, struct ConfItem *conf)
719 > attach_conf(struct Client *client_p, struct MaskItem *conf)
720   {
721    if (dlinkFind(&client_p->localClient->confs, conf) != NULL)
722      return 1;
723  
724 <  if (conf->type == CLIENT_TYPE ||
725 <      conf->type == SERVER_TYPE ||
726 <      conf->type == OPER_TYPE)
727 <  {
1335 <    struct AccessItem *aconf = map_to_conf(conf);
1336 <    struct ClassItem *aclass = map_to_conf(aconf->class_ptr);
1337 <
1338 <    if (IsConfIllegal(aconf))
1339 <      return NOT_AUTHORIZED;
1340 <
1341 <    if (conf->type == CLIENT_TYPE)
1342 <      if (cidr_limit_reached(IsConfExemptLimits(aconf),
1343 <                             &client_p->localClient->ip, aclass))
1344 <        return TOO_MANY;    /* Already at maximum allowed */
724 >  if (conf->type == CONF_CLIENT)
725 >    if (cidr_limit_reached(IsConfExemptLimits(conf),
726 >                           &client_p->localClient->ip, conf->class))
727 >      return TOO_MANY;    /* Already at maximum allowed */
728  
729 <    aclass->curr_user_count++;
730 <    aconf->clients++;
1348 <  }
729 >  conf->class->ref_count++;
730 >  conf->ref_count++;
731  
732    dlinkAdd(conf, make_dlink_node(), &client_p->localClient->confs);
733  
# Line 1365 | Line 747 | attach_connect_block(struct Client *clie
747                       const char *host)
748   {
749    dlink_node *ptr;
750 <  struct ConfItem *conf;
1369 <  struct AccessItem *aconf;
750 >  struct MaskItem *conf = NULL;
751  
752    assert(client_p != NULL);
753    assert(host != NULL);
# Line 1377 | Line 758 | attach_connect_block(struct Client *clie
758    DLINK_FOREACH(ptr, server_items.head)
759    {
760      conf = ptr->data;
1380 –    aconf = map_to_conf(conf);
761  
762 <    if (match(conf->name, name) == 0 || match(aconf->host, host) == 0)
762 >    if (match(conf->name, name) || match(conf->host, host))
763        continue;
764  
765      attach_conf(client_p, conf);
# Line 1389 | Line 769 | attach_connect_block(struct Client *clie
769    return 0;
770   }
771  
1392 – /* find_conf_exact()
1393 – *
1394 – * inputs       - type of ConfItem
1395 – *              - pointer to name to find
1396 – *              - pointer to username to find
1397 – *              - pointer to host to find
1398 – * output       - NULL or pointer to conf found
1399 – * side effects - find a conf entry which matches the hostname
1400 – *                and has the same name.
1401 – */
1402 – struct ConfItem *
1403 – find_conf_exact(ConfType type, const char *name, const char *user,
1404 –                const char *host)
1405 – {
1406 –  dlink_node *ptr;
1407 –  dlink_list *list_p;
1408 –  struct ConfItem *conf = NULL;
1409 –  struct AccessItem *aconf;
1410 –
1411 –  /* Only valid for OPER_TYPE and ...? */
1412 –  list_p = map_to_list(type);
1413 –
1414 –  DLINK_FOREACH(ptr, (*list_p).head)
1415 –  {
1416 –    conf = ptr->data;
1417 –
1418 –    if (conf->name == NULL)
1419 –      continue;
1420 –    aconf = map_to_conf(conf);
1421 –    if (aconf->host == NULL)
1422 –      continue;
1423 –    if (irccmp(conf->name, name) != 0)
1424 –      continue;
1425 –
1426 –    /*
1427 –    ** Accept if the *real* hostname (usually sockethost)
1428 –    ** socket host) matches *either* host or name field
1429 –    ** of the configuration.
1430 –    */
1431 –    if (!match(aconf->host, host) || !match(aconf->user, user))
1432 –      continue;
1433 –    if (type == OPER_TYPE)
1434 –    {
1435 –      struct ClassItem *aclass = map_to_conf(aconf->class_ptr);
1436 –
1437 –      if (aconf->clients >= aclass->max_total)
1438 –        continue;
1439 –    }
1440 –
1441 –    return conf;
1442 –  }
1443 –
1444 –  return NULL;
1445 – }
1446 –
772   /* find_conf_name()
773   *
774   * inputs       - pointer to conf link list to search
# Line 1453 | Line 778 | find_conf_exact(ConfType type, const cha
778   * side effects - find a conf entry which matches the name
779   *                and has the given mask.
780   */
781 < struct ConfItem *
782 < find_conf_name(dlink_list *list, const char *name, ConfType type)
781 > struct MaskItem *
782 > find_conf_name(dlink_list *list, const char *name, enum maskitem_type type)
783   {
784    dlink_node *ptr;
785 <  struct ConfItem* conf;
785 >  struct MaskItem* conf;
786  
787    DLINK_FOREACH(ptr, list->head)
788    {
789      conf = ptr->data;
790 <    
790 >
791      if (conf->type == type)
792      {
793        if (conf->name && (irccmp(conf->name, name) == 0 ||
794 <                         match(conf->name, name)))
794 >                         !match(conf->name, name)))
795        return conf;
796      }
797    }
# Line 1481 | Line 806 | find_conf_name(dlink_list *list, const c
806   * side effects - none
807   */
808   static dlink_list *
809 < map_to_list(ConfType type)
809 > map_to_list(enum maskitem_type type)
810   {
811    switch(type)
812    {
813 <  case RXLINE_TYPE:
1489 <    return(&rxconf_items);
1490 <    break;
1491 <  case XLINE_TYPE:
813 >  case CONF_XLINE:
814      return(&xconf_items);
815      break;
816 <  case ULINE_TYPE:
816 >  case CONF_ULINE:
817      return(&uconf_items);
818      break;
819 <  case NRESV_TYPE:
819 >  case CONF_NRESV:
820      return(&nresv_items);
821      break;
822 <  case OPER_TYPE:
822 >  case CONF_CRESV:
823 >    return(&cresv_items);
824 >  case CONF_OPER:
825      return(&oconf_items);
826      break;
827 <  case CLASS_TYPE:
1504 <    return(&class_items);
1505 <    break;
1506 <  case SERVER_TYPE:
827 >  case CONF_SERVER:
828      return(&server_items);
829      break;
830 <  case SERVICE_TYPE:
830 >  case CONF_SERVICE:
831      return(&service_items);
832      break;
833 <  case CLUSTER_TYPE:
833 >  case CONF_CLUSTER:
834      return(&cluster_items);
835      break;
1515 –  case CONF_TYPE:
1516 –  case GLINE_TYPE:
1517 –  case KLINE_TYPE:
1518 –  case DLINE_TYPE:
1519 –  case CRESV_TYPE:
836    default:
837      return NULL;
838    }
# Line 1528 | Line 844 | map_to_list(ConfType type)
844   *              - pointer to name string to find
845   *              - pointer to user
846   *              - pointer to host
847 < *              - optional action to match on as well
848 < * output       - NULL or pointer to found struct MatchItem
847 > *              - optional flags to match on as well
848 > * output       - NULL or pointer to found struct MaskItem
849   * side effects - looks for a match on name field
850   */
851 < struct ConfItem *
852 < find_matching_name_conf(ConfType type, const char *name, const char *user,
853 <                        const char *host, int action)
851 > struct MaskItem *
852 > find_matching_name_conf(enum maskitem_type type, const char *name, const char *user,
853 >                        const char *host, unsigned int flags)
854   {
855    dlink_node *ptr=NULL;
856 <  struct ConfItem *conf=NULL;
1541 <  struct AccessItem *aconf=NULL;
1542 <  struct MatchItem *match_item=NULL;
856 >  struct MaskItem *conf=NULL;
857    dlink_list *list_p = map_to_list(type);
858  
859    switch (type)
860    {
861 < #ifdef HAVE_LIBPCRE
1548 <  case RXLINE_TYPE:
1549 <      DLINK_FOREACH(ptr, list_p->head)
1550 <      {
1551 <        conf = ptr->data;
1552 <        assert(conf->regexpname);
1553 <
1554 <        if (!ircd_pcre_exec(conf->regexpname, name))
1555 <          return conf;
1556 <      }
1557 <      break;
1558 < #endif
1559 <  case SERVICE_TYPE:
861 >  case CONF_SERVICE:
862      DLINK_FOREACH(ptr, list_p->head)
863      {
864        conf = ptr->data;
# Line 1568 | Line 870 | find_matching_name_conf(ConfType type, c
870      }
871      break;
872  
873 <  case XLINE_TYPE:
874 <  case ULINE_TYPE:
875 <  case NRESV_TYPE:
873 >  case CONF_XLINE:
874 >  case CONF_ULINE:
875 >  case CONF_NRESV:
876 >  case CONF_CRESV:
877      DLINK_FOREACH(ptr, list_p->head)
878      {
879        conf = ptr->data;
880  
1578 –      match_item = map_to_conf(conf);
881        if (EmptyString(conf->name))
882 <        continue;
883 <      if ((name != NULL) && match_esc(conf->name, name))
882 >        continue;
883 >      if ((name != NULL) && !match(conf->name, name))
884        {
885 <        if ((user == NULL && (host == NULL)))
886 <          return conf;
887 <        if ((match_item->action & action) != action)
885 >        if ((user == NULL && (host == NULL)))
886 >          return conf;
887 >        if ((conf->flags & flags) != flags)
888            continue;
889 <        if (EmptyString(match_item->user) || EmptyString(match_item->host))
890 <          return conf;
891 <        if (match(match_item->user, user) && match(match_item->host, host))
892 <          return conf;
889 >        if (EmptyString(conf->user) || EmptyString(conf->host))
890 >          return conf;
891 >        if (!match(conf->user, user) && !match(conf->host, host))
892 >          return conf;
893        }
894      }
895        break;
896  
897 <  case SERVER_TYPE:
897 >  case CONF_SERVER:
898      DLINK_FOREACH(ptr, list_p->head)
899      {
900        conf = ptr->data;
1599 –      aconf = map_to_conf(conf);
901  
902 <      if ((name != NULL) && match_esc(name, conf->name))
902 >      if ((name != NULL) && !match(name, conf->name))
903          return conf;
904 <      else if ((host != NULL) && match_esc(host, aconf->host))
904 >      else if ((host != NULL) && !match(host, conf->host))
905          return conf;
906      }
907      break;
908 <  
908 >
909    default:
910      break;
911    }
# Line 1617 | Line 918 | find_matching_name_conf(ConfType type, c
918   *              - pointer to name string to find
919   *              - pointer to user
920   *              - pointer to host
921 < * output       - NULL or pointer to found struct MatchItem
921 > * output       - NULL or pointer to found struct MaskItem
922   * side effects - looks for an exact match on name field
923   */
924 < struct ConfItem *
925 < find_exact_name_conf(ConfType type, const struct Client *who, const char *name,
924 > struct MaskItem *
925 > find_exact_name_conf(enum maskitem_type type, const struct Client *who, const char *name,
926                       const char *user, const char *host)
927   {
928    dlink_node *ptr = NULL;
929 <  struct AccessItem *aconf;
930 <  struct ConfItem *conf;
1630 <  struct MatchItem *match_item;
1631 <  dlink_list *list_p;
1632 <
1633 <  list_p = map_to_list(type);
929 >  struct MaskItem *conf;
930 >  dlink_list *list_p = map_to_list(type);
931  
932    switch(type)
933    {
934 <  case RXLINE_TYPE:
935 <  case XLINE_TYPE:
936 <  case ULINE_TYPE:
937 <  case NRESV_TYPE:
934 >  case CONF_XLINE:
935 >  case CONF_ULINE:
936 >  case CONF_NRESV:
937 >  case CONF_CRESV:
938  
939      DLINK_FOREACH(ptr, list_p->head)
940      {
941        conf = ptr->data;
942 <      match_item = (struct MatchItem *)map_to_conf(conf);
942 >
943        if (EmptyString(conf->name))
944 <        continue;
945 <    
944 >        continue;
945 >
946        if (irccmp(conf->name, name) == 0)
947        {
948 <        if ((user == NULL && (host == NULL)))
949 <          return (conf);
950 <        if (EmptyString(match_item->user) || EmptyString(match_item->host))
951 <          return (conf);
952 <        if (match(match_item->user, user) && match(match_item->host, host))
953 <          return (conf);
948 >        if ((user == NULL && (host == NULL)))
949 >          return conf;
950 >        if (EmptyString(conf->user) || EmptyString(conf->host))
951 >          return conf;
952 >        if (!match(conf->user, user) && !match(conf->host, host))
953 >          return conf;
954        }
955      }
956      break;
957  
958 <  case OPER_TYPE:
958 >  case CONF_OPER:
959      DLINK_FOREACH(ptr, list_p->head)
960      {
961        conf = ptr->data;
1665 –      aconf = map_to_conf(conf);
962  
963        if (EmptyString(conf->name))
964          continue;
# Line 1671 | Line 967 | find_exact_name_conf(ConfType type, cons
967        {
968          if (!who)
969            return conf;
970 <        if (EmptyString(aconf->user) || EmptyString(aconf->host))
971 <          return conf;
972 <        if (match(aconf->user, who->username))
970 >        if (EmptyString(conf->user) || EmptyString(conf->host))
971 >          return NULL;
972 >        if (!match(conf->user, who->username))
973          {
974 <          switch (aconf->type)
974 >          switch (conf->htype)
975            {
976              case HM_HOST:
977 <              if (match(aconf->host, who->host) || match(aconf->host, who->sockhost))
978 <                return conf;
977 >              if (!match(conf->host, who->host) || !match(conf->host, who->sockhost))
978 >                if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
979 >                  return conf;
980                break;
981              case HM_IPV4:
982                if (who->localClient->aftype == AF_INET)
983 <                if (match_ipv4(&who->localClient->ip, &aconf->addr, aconf->bits))
984 <                  return conf;
983 >                if (match_ipv4(&who->localClient->ip, &conf->addr, conf->bits))
984 >                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
985 >                    return conf;
986                break;
987   #ifdef IPV6
988              case HM_IPV6:
989                if (who->localClient->aftype == AF_INET6)
990 <                if (match_ipv6(&who->localClient->ip, &aconf->addr, aconf->bits))
991 <                  return conf;
990 >                if (match_ipv6(&who->localClient->ip, &conf->addr, conf->bits))
991 >                  if (!conf->class->max_total || conf->class->ref_count < conf->class->max_total)
992 >                    return conf;
993                break;
994   #endif
995              default:
# Line 1702 | Line 1001 | find_exact_name_conf(ConfType type, cons
1001  
1002      break;
1003  
1004 <  case SERVER_TYPE:
1004 >  case CONF_SERVER:
1005      DLINK_FOREACH(ptr, list_p->head)
1006      {
1007        conf = ptr->data;
1008 <      aconf = (struct AccessItem *)map_to_conf(conf);
1008 >
1009        if (EmptyString(conf->name))
1010 <        continue;
1011 <    
1010 >        continue;
1011 >
1012        if (name == NULL)
1013        {
1014 <        if (EmptyString(aconf->host))
1015 <          continue;
1016 <        if (irccmp(aconf->host, host) == 0)
1017 <          return(conf);
1014 >        if (EmptyString(conf->host))
1015 >          continue;
1016 >        if (irccmp(conf->host, host) == 0)
1017 >          return conf;
1018        }
1019        else if (irccmp(conf->name, name) == 0)
1020 <      {
1722 <          return (conf);
1723 <      }
1020 >        return conf;
1021      }
1725 –    break;
1022  
1727 –  case CLASS_TYPE:
1728 –    DLINK_FOREACH(ptr, list_p->head)
1729 –    {
1730 –      conf = ptr->data;
1731 –      if (EmptyString(conf->name))
1732 –        continue;
1733 –    
1734 –      if (irccmp(conf->name, name) == 0)
1735 –        return (conf);
1736 –    }
1023      break;
1024  
1025    default:
1026      break;
1027    }
1028 <  return(NULL);
1028 >
1029 >  return NULL;
1030   }
1031  
1032   /* rehash()
# Line 1752 | Line 1039 | int
1039   rehash(int sig)
1040   {
1041    if (sig != 0)
1042 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1043 <                         "Got signal SIGHUP, reloading ircd.conf file");
1042 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1043 >                         "Got signal SIGHUP, reloading configuration file(s)");
1044  
1045    restart_resolver();
1046  
# Line 1769 | Line 1056 | rehash(int sig)
1056  
1057    load_conf_modules();
1058  
1772 –  flush_deleted_I_P();
1773 –
1059    rehashed_klines = 1;
1775 – /* XXX */
1776 –  if (ConfigLoggingEntry.use_logging)
1777 –    log_close_all();
1060  
1061 <  return(0);
1061 >  return 0;
1062   }
1063  
1064   /* set_default_conf()
# Line 1794 | Line 1076 | set_default_conf(void)
1076    /* verify init_class() ran, this should be an unnecessary check
1077     * but its not much work.
1078     */
1079 <  assert(class_default == (struct ConfItem *) class_items.tail->data);
1079 >  assert(class_default == class_get_list()->tail->data);
1080  
1081   #ifdef HAVE_LIBCRYPTO
1082    ServerInfo.rsa_private_key = NULL;
# Line 1804 | Line 1086 | set_default_conf(void)
1086    /* ServerInfo.name is not rehashable */
1087    /* ServerInfo.name = ServerInfo.name; */
1088    ServerInfo.description = NULL;
1089 <  DupString(ServerInfo.network_name, NETWORK_NAME_DEFAULT);
1090 <  DupString(ServerInfo.network_desc, NETWORK_DESC_DEFAULT);
1089 >  ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1090 >  ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1091  
1092    memset(&ServerInfo.ip, 0, sizeof(ServerInfo.ip));
1093    ServerInfo.specific_ipv4_vhost = 0;
# Line 1813 | Line 1095 | set_default_conf(void)
1095    ServerInfo.specific_ipv6_vhost = 0;
1096  
1097    ServerInfo.max_clients = MAXCLIENTS_MAX;
1098 +  ServerInfo.max_nick_length = 9;
1099 +  ServerInfo.max_topic_length = 80;
1100  
1101    ServerInfo.hub = 0;
1102    ServerInfo.dns_host.sin_addr.s_addr = 0;
# Line 1821 | Line 1105 | set_default_conf(void)
1105    AdminInfo.email = NULL;
1106    AdminInfo.description = NULL;
1107  
1108 <  log_close_all();
1108 >  log_del_all();
1109  
1110    ConfigLoggingEntry.use_logging = 1;
1111  
1112    ConfigChannel.disable_fake_channels = 0;
1829 –  ConfigChannel.restrict_channels = 0;
1830 –  ConfigChannel.disable_local_channels = 0;
1831 –  ConfigChannel.use_invex = 1;
1832 –  ConfigChannel.use_except = 1;
1833 –  ConfigChannel.use_knock = 1;
1113    ConfigChannel.knock_delay = 300;
1114    ConfigChannel.knock_delay_channel = 60;
1115 <  ConfigChannel.max_chans_per_user = 15;
1116 <  ConfigChannel.quiet_on_ban = 1;
1115 >  ConfigChannel.max_chans_per_user = 25;
1116 >  ConfigChannel.max_chans_per_oper = 50;
1117    ConfigChannel.max_bans = 25;
1118    ConfigChannel.default_split_user_count = 0;
1119    ConfigChannel.default_split_server_count = 0;
1120    ConfigChannel.no_join_on_split = 0;
1121    ConfigChannel.no_create_on_split = 0;
1843 –  ConfigChannel.burst_topicwho = 1;
1122  
1123    ConfigServerHide.flatten_links = 0;
1124    ConfigServerHide.links_delay = 300;
1125    ConfigServerHide.hidden = 0;
1848 –  ConfigServerHide.disable_hidden = 0;
1126    ConfigServerHide.hide_servers = 0;
1127 <  DupString(ConfigServerHide.hidden_name, NETWORK_NAME_DEFAULT);
1127 >  ConfigServerHide.hide_services = 0;
1128 >  ConfigServerHide.hidden_name = xstrdup(NETWORK_NAME_DEFAULT);
1129    ConfigServerHide.hide_server_ips = 0;
1130 +  ConfigServerHide.disable_remote_commands = 0;
1131  
1132 <  
1854 <  DupString(ConfigFileEntry.service_name, SERVICE_NAME_DEFAULT);
1132 >  ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1133    ConfigFileEntry.max_watch = WATCHSIZE_DEFAULT;
1134 +  ConfigFileEntry.cycle_on_host_change = 1;
1135 +  ConfigFileEntry.glines = 0;
1136 +  ConfigFileEntry.gline_time = 12 * 3600;
1137 +  ConfigFileEntry.gline_request_time = GLINE_REQUEST_EXPIRE_DEFAULT;
1138    ConfigFileEntry.gline_min_cidr = 16;
1139    ConfigFileEntry.gline_min_cidr6 = 48;
1140    ConfigFileEntry.invisible_on_connect = 1;
1859 –  ConfigFileEntry.burst_away = 0;
1860 –  ConfigFileEntry.use_whois_actually = 1;
1141    ConfigFileEntry.tkline_expire_notices = 1;
1142    ConfigFileEntry.hide_spoof_ips = 1;
1143    ConfigFileEntry.ignore_bogus_ts = 0;
1144    ConfigFileEntry.disable_auth = 0;
1865 –  ConfigFileEntry.disable_remote = 0;
1145    ConfigFileEntry.kill_chase_time_limit = 90;
1146    ConfigFileEntry.default_floodcount = 8;
1147    ConfigFileEntry.failed_oper_notice = 1;
# Line 1876 | Line 1155 | set_default_conf(void)
1155    ConfigFileEntry.anti_spam_exit_message_time = 0;
1156    ConfigFileEntry.ts_warn_delta = TS_WARN_DELTA_DEFAULT;
1157    ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1879 –  ConfigFileEntry.kline_with_reason = 1;
1880 –  ConfigFileEntry.kline_reason = NULL;
1158    ConfigFileEntry.warn_no_nline = 1;
1159    ConfigFileEntry.stats_o_oper_only = 0;
1160    ConfigFileEntry.stats_k_oper_only = 1;  /* masked */
1161    ConfigFileEntry.stats_i_oper_only = 1;  /* masked */
1162    ConfigFileEntry.stats_P_oper_only = 0;
1163 +  ConfigFileEntry.stats_u_oper_only = 0;
1164    ConfigFileEntry.caller_id_wait = 60;
1165    ConfigFileEntry.opers_bypass_callerid = 0;
1166    ConfigFileEntry.pace_wait = 10;
# Line 1892 | Line 1170 | set_default_conf(void)
1170    ConfigFileEntry.no_oper_flood = 0;
1171    ConfigFileEntry.true_no_oper_flood = 0;
1172    ConfigFileEntry.oper_pass_resv = 1;
1895 –  ConfigFileEntry.glines = 0;
1896 –  ConfigFileEntry.gline_time = 12 * 3600;
1173    ConfigFileEntry.max_targets = MAX_TARGETS_DEFAULT;
1898 –  ConfigFileEntry.client_flood = CLIENT_FLOOD_DEFAULT;
1174    ConfigFileEntry.oper_only_umodes = UMODE_DEBUG;
1175    ConfigFileEntry.oper_umodes = UMODE_BOTS | UMODE_LOCOPS | UMODE_SERVNOTICE |
1176      UMODE_OPERWALL | UMODE_WALLOP;
# Line 1914 | Line 1189 | validate_conf(void)
1189      ConfigFileEntry.ts_max_delta = TS_MAX_DELTA_DEFAULT;
1190  
1191    if (ServerInfo.network_name == NULL)
1192 <    DupString(ServerInfo.network_name,NETWORK_NAME_DEFAULT);
1192 >    ServerInfo.network_name = xstrdup(NETWORK_NAME_DEFAULT);
1193  
1194    if (ServerInfo.network_desc == NULL)
1195 <    DupString(ServerInfo.network_desc,NETWORK_DESC_DEFAULT);
1195 >    ServerInfo.network_desc = xstrdup(NETWORK_DESC_DEFAULT);
1196  
1197    if (ConfigFileEntry.service_name == NULL)
1198 <    DupString(ConfigFileEntry.service_name, SERVICE_NAME_DEFAULT);
1924 <
1925 <  if ((ConfigFileEntry.client_flood < CLIENT_FLOOD_MIN) ||
1926 <      (ConfigFileEntry.client_flood > CLIENT_FLOOD_MAX))
1927 <    ConfigFileEntry.client_flood = CLIENT_FLOOD_MAX;
1198 >    ConfigFileEntry.service_name = xstrdup(SERVICE_NAME_DEFAULT);
1199  
1200    ConfigFileEntry.max_watch = IRCD_MAX(ConfigFileEntry.max_watch, WATCHSIZE_MIN);
1201   }
1202  
1203 < /* read_conf()
1203 > /* read_conf()
1204   *
1205   * inputs       - file descriptor pointing to config file to use
1206   * output       - None
# Line 1942 | Line 1213 | read_conf(FILE *file)
1213  
1214    set_default_conf(); /* Set default values prior to conf parsing */
1215    conf_parser_ctx.pass = 1;
1216 <  yyparse();          /* pick up the classes first */
1216 >  yyparse();          /* pick up the classes first */
1217  
1218    rewind(file);
1219  
# Line 1950 | Line 1221 | read_conf(FILE *file)
1221    yyparse();          /* Load the values from the conf */
1222    validate_conf();    /* Check to make sure some values are still okay. */
1223                        /* Some global values are also loaded here. */
1224 <  check_class();      /* Make sure classes are valid */
1224 >  class_delete_marked();      /* Make sure classes are valid */
1225   }
1226  
1227   /* lookup_confhost()
# Line 1958 | Line 1229 | read_conf(FILE *file)
1229   * start DNS lookups of all hostnames in the conf
1230   * line and convert an IP addresses in a.b.c.d number for to IP#s.
1231   */
1232 < static void
1233 < lookup_confhost(struct ConfItem *conf)
1232 > void
1233 > lookup_confhost(struct MaskItem *conf)
1234   {
1964 –  struct AccessItem *aconf;
1235    struct addrinfo hints, *res;
1236  
1967 –  aconf = map_to_conf(conf);
1968 –
1969 –  if (EmptyString(aconf->host) ||
1970 –      EmptyString(aconf->user))
1971 –  {
1972 –    ilog(LOG_TYPE_IRCD, "Host/server name error: (%s) (%s)",
1973 –         aconf->host, conf->name);
1974 –    return;
1975 –  }
1976 –
1977 –  if (strchr(aconf->host, '*') ||
1978 –      strchr(aconf->host, '?'))
1979 –    return;
1980 –
1237    /* Do name lookup now on hostnames given and store the
1238     * ip numbers in conf structure.
1239     */
# Line 1989 | Line 1245 | lookup_confhost(struct ConfItem *conf)
1245    /* Get us ready for a bind() and don't bother doing dns lookup */
1246    hints.ai_flags = AI_PASSIVE | AI_NUMERICHOST;
1247  
1248 <  if (getaddrinfo(aconf->host, NULL, &hints, &res))
1248 >  if (getaddrinfo(conf->host, NULL, &hints, &res))
1249    {
1250 <    conf_dns_lookup(aconf);
1250 >    conf_dns_lookup(conf);
1251      return;
1252    }
1253  
1254    assert(res != NULL);
1255  
1256 <  memcpy(&aconf->addr, res->ai_addr, res->ai_addrlen);
1257 <  aconf->addr.ss_len = res->ai_addrlen;
1258 <  aconf->addr.ss.ss_family = res->ai_family;
1256 >  memcpy(&conf->addr, res->ai_addr, res->ai_addrlen);
1257 >  conf->addr.ss_len = res->ai_addrlen;
1258 >  conf->addr.ss.ss_family = res->ai_family;
1259 >
1260    freeaddrinfo(res);
1261   }
1262  
# Line 2014 | Line 1271 | int
1271   conf_connect_allowed(struct irc_ssaddr *addr, int aftype)
1272   {
1273    struct ip_entry *ip_found;
1274 <  struct AccessItem *aconf = find_dline_conf(addr, aftype);
1274 >  struct MaskItem *conf = find_dline_conf(addr, aftype);
1275  
1276    /* DLINE exempt also gets you out of static limits/pacing... */
1277 <  if (aconf && (aconf->status & CONF_EXEMPTDLINE))
1277 >  if (conf && (conf->type == CONF_EXEMPT))
1278      return 0;
1279  
1280 <  if (aconf != NULL)
1280 >  if (conf != NULL)
1281      return BANNED_CLIENT;
1282  
1283    ip_found = find_or_add_ip(addr);
# Line 2036 | Line 1293 | conf_connect_allowed(struct irc_ssaddr *
1293    return 0;
1294   }
1295  
2039 – static struct AccessItem *
2040 – find_regexp_kline(const char *uhi[])
2041 – {
2042 – #ifdef HAVE_LIBPCRE
2043 –  const dlink_node *ptr = NULL;
2044 –
2045 –  DLINK_FOREACH(ptr, rkconf_items.head)
2046 –  {
2047 –    struct AccessItem *aptr = map_to_conf(ptr->data);
2048 –
2049 –    assert(aptr->regexuser);
2050 –    assert(aptr->regexhost);
2051 –
2052 –    if (!ircd_pcre_exec(aptr->regexuser, uhi[0]) &&
2053 –        (!ircd_pcre_exec(aptr->regexhost, uhi[1]) ||
2054 –         !ircd_pcre_exec(aptr->regexhost, uhi[2])))
2055 –      return aptr;
2056 –  }
2057 – #endif
2058 –  return NULL;
2059 – }
2060 –
2061 – /* find_kill()
2062 – *
2063 – * inputs       - pointer to client structure
2064 – * output       - pointer to struct AccessItem if found
2065 – * side effects - See if this user is klined already,
2066 – *                and if so, return struct AccessItem pointer
2067 – */
2068 – struct AccessItem *
2069 – find_kill(struct Client *client_p)
2070 – {
2071 –  struct AccessItem *aconf = NULL;
2072 –  const char *uhi[3];
2073 –
2074 –  uhi[0] = client_p->username;
2075 –  uhi[1] = client_p->host;
2076 –  uhi[2] = client_p->sockhost;
2077 –
2078 –  assert(client_p != NULL);
2079 –
2080 –  aconf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
2081 –                               CONF_KLINE, client_p->localClient->aftype,
2082 –                               client_p->username, NULL, 1);
2083 –  if (aconf == NULL)
2084 –    aconf = find_regexp_kline(uhi);
2085 –
2086 –  return aconf;
2087 – }
2088 –
2089 – struct AccessItem *
2090 – find_gline(struct Client *client_p)
2091 – {
2092 –  struct AccessItem *aconf;
2093 –
2094 –  assert(client_p != NULL);
2095 –
2096 –  aconf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
2097 –                               CONF_GLINE, client_p->localClient->aftype,
2098 –                               client_p->username, NULL, 1);
2099 –  return aconf;
2100 – }
2101 –
2102 – /* add_temp_line()
2103 – *
2104 – * inputs        - pointer to struct ConfItem
2105 – * output        - none
2106 – * Side effects  - links in given struct ConfItem into
2107 – *                 temporary *line link list
2108 – */
2109 – void
2110 – add_temp_line(struct ConfItem *conf)
2111 – {
2112 –  if (conf->type == XLINE_TYPE)
2113 –  {
2114 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2115 –    dlinkAdd(conf, make_dlink_node(), &temporary_xlines);
2116 –  }
2117 –  else if ((conf->type == NRESV_TYPE) || (conf->type == CRESV_TYPE))
2118 –  {
2119 –    conf->flags |= CONF_FLAGS_TEMPORARY;
2120 –    dlinkAdd(conf, make_dlink_node(), &temporary_resv);
2121 –  }
2122 – }
2123 –
1296   /* cleanup_tklines()
1297   *
1298   * inputs       - NONE
# Line 2132 | Line 1304 | void
1304   cleanup_tklines(void *notused)
1305   {
1306    hostmask_expire_temporary();
1307 <  expire_tklines(&temporary_xlines);
1308 <  expire_tklines(&temporary_resv);
1307 >  expire_tklines(&xconf_items);
1308 >  expire_tklines(&nresv_items);
1309 >  expire_tklines(&cresv_items);
1310   }
1311  
1312   /* expire_tklines()
# Line 2147 | Line 1320 | expire_tklines(dlink_list *tklist)
1320   {
1321    dlink_node *ptr;
1322    dlink_node *next_ptr;
1323 <  struct ConfItem *conf;
2151 <  struct MatchItem *xconf;
2152 <  struct MatchItem *nconf;
2153 <  struct ResvChannel *cconf;
1323 >  struct MaskItem *conf;
1324  
1325    DLINK_FOREACH_SAFE(ptr, next_ptr, tklist->head)
1326    {
1327      conf = ptr->data;
1328  
1329 <    if (conf->type == XLINE_TYPE)
1329 >    if (!conf->until || conf->until > CurrentTime)
1330 >      continue;
1331 >
1332 >    if (conf->type == CONF_XLINE)
1333      {
1334 <      xconf = (struct MatchItem *)map_to_conf(conf);
1335 <      if (xconf->hold <= CurrentTime)
1336 <      {
1337 <        if (ConfigFileEntry.tkline_expire_notices)
2165 <          sendto_realops_flags(UMODE_ALL, L_ALL,
2166 <                               "Temporary X-line for [%s] sexpired", conf->name);
2167 <        dlinkDelete(ptr, tklist);
2168 <        free_dlink_node(ptr);
2169 <        delete_conf_item(conf);
2170 <      }
1334 >      if (ConfigFileEntry.tkline_expire_notices)
1335 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1336 >                               "Temporary X-line for [%s] expired", conf->name);
1337 >      conf_free(conf);
1338      }
1339 <    else if (conf->type == NRESV_TYPE)
1339 >    else if (conf->type == CONF_NRESV || conf->type == CONF_CRESV)
1340      {
1341 <      nconf = (struct MatchItem *)map_to_conf(conf);
1342 <      if (nconf->hold <= CurrentTime)
2176 <      {
2177 <        if (ConfigFileEntry.tkline_expire_notices)
2178 <          sendto_realops_flags(UMODE_ALL, L_ALL,
1341 >      if (ConfigFileEntry.tkline_expire_notices)
1342 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1343                                 "Temporary RESV for [%s] expired", conf->name);
1344 <        dlinkDelete(ptr, tklist);
2181 <        free_dlink_node(ptr);
2182 <        delete_conf_item(conf);
2183 <      }
2184 <    }
2185 <    else if (conf->type == CRESV_TYPE)
2186 <    {
2187 <      cconf = (struct ResvChannel *)map_to_conf(conf);
2188 <      if (cconf->hold <= CurrentTime)
2189 <      {
2190 <        if (ConfigFileEntry.tkline_expire_notices)
2191 <          sendto_realops_flags(UMODE_ALL, L_ALL,
2192 <                               "Temporary RESV for [%s] expired", cconf->name);
2193 <        delete_channel_resv(cconf);
2194 <      }
1344 >      conf_free(conf);
1345      }
1346    }
1347   }
# Line 2204 | Line 1354 | expire_tklines(dlink_list *tklist)
1354   */
1355   static const struct oper_privs
1356   {
1357 <  const unsigned int oprivs;
1357 >  const unsigned int flag;
1358    const unsigned char c;
1359   } flag_list[] = {
1360 <  { OPER_FLAG_ADMIN,       'A' },
1361 <  { OPER_FLAG_REMOTEBAN,   'B' },
1362 <  { OPER_FLAG_DIE,         'D' },
1363 <  { OPER_FLAG_GLINE,       'G' },
1364 <  { OPER_FLAG_REHASH,      'H' },
1365 <  { OPER_FLAG_K,           'K' },
1366 <  { OPER_FLAG_OPERWALL,    'L' },
1367 <  { OPER_FLAG_N,           'N' },
1368 <  { OPER_FLAG_GLOBAL_KILL, 'O' },
1369 <  { OPER_FLAG_REMOTE,      'R' },
1370 <  { OPER_FLAG_OPER_SPY,    'S' },
1371 <  { OPER_FLAG_UNKLINE,     'U' },
1372 <  { OPER_FLAG_X,           'X' },
1360 >  { OPER_FLAG_ADMIN,          'A' },
1361 >  { OPER_FLAG_REMOTEBAN,      'B' },
1362 >  { OPER_FLAG_DIE,            'D' },
1363 >  { OPER_FLAG_GLINE,          'G' },
1364 >  { OPER_FLAG_REHASH,         'H' },
1365 >  { OPER_FLAG_K,              'K' },
1366 >  { OPER_FLAG_OPERWALL,       'L' },
1367 >  { OPER_FLAG_KILL,           'N' },
1368 >  { OPER_FLAG_KILL_REMOTE,    'O' },
1369 >  { OPER_FLAG_CONNECT,        'P' },
1370 >  { OPER_FLAG_CONNECT_REMOTE, 'Q' },
1371 >  { OPER_FLAG_SQUIT,          'R' },
1372 >  { OPER_FLAG_SQUIT_REMOTE,   'S' },
1373 >  { OPER_FLAG_UNKLINE,        'U' },
1374 >  { OPER_FLAG_XLINE,          'X' },
1375    { 0, '\0' }
1376   };
1377  
1378   char *
1379   oper_privs_as_string(const unsigned int port)
1380   {
1381 <  static char privs_out[16];
1381 >  static char privs_out[IRCD_BUFSIZE];
1382    char *privs_ptr = privs_out;
1383 <  unsigned int i = 0;
1383 >  const struct oper_privs *opriv = flag_list;
1384  
1385 <  for (; flag_list[i].oprivs; ++i)
1385 >  for (; opriv->flag; ++opriv)
1386    {
1387 <    if (port & flag_list[i].oprivs)
1388 <      *privs_ptr++ = flag_list[i].c;
1387 >    if (port & opriv->flag)
1388 >      *privs_ptr++ = opriv->c;
1389      else
1390 <      *privs_ptr++ = ToLowerTab[flag_list[i].c];
1390 >      *privs_ptr++ = ToLower(opriv->c);
1391    }
1392  
1393    *privs_ptr = '\0';
# Line 2252 | Line 1404 | oper_privs_as_string(const unsigned int
1404   const char *
1405   get_oper_name(const struct Client *client_p)
1406   {
1407 <  dlink_node *cnode = NULL;
1407 >  const dlink_node *cnode = NULL;
1408    /* +5 for !,@,{,} and null */
1409    static char buffer[NICKLEN + USERLEN + HOSTLEN + HOSTLEN + 5];
1410  
# Line 2260 | Line 1412 | get_oper_name(const struct Client *clien
1412    {
1413      if ((cnode = client_p->localClient->confs.head))
1414      {
1415 <      struct ConfItem *conf = cnode->data;
2264 <      const struct AccessItem *aconf = map_to_conf(conf);
1415 >      const struct MaskItem *conf = cnode->data;
1416  
1417 <      if (IsConfOperator(aconf))
1417 >      if (IsConfOperator(conf))
1418        {
1419 <        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1419 >        snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1420                   client_p->username, client_p->host, conf->name);
1421 <        return buffer;
1421 >        return buffer;
1422        }
1423      }
1424  
1425 <    /* Probably should assert here for now. If there is an oper out there
1425 >    /* Probably should assert here for now. If there is an oper out there
1426       * with no oper{} conf attached, it would be good for us to know...
1427       */
1428      assert(0); /* Oper without oper conf! */
1429    }
1430  
1431    snprintf(buffer, sizeof(buffer), "%s!%s@%s{%s}", client_p->name,
1432 <           client_p->username, client_p->host, client_p->servptr->name);
1432 >           client_p->username, client_p->host, client_p->servptr->name);
1433    return buffer;
1434   }
1435  
# Line 2292 | Line 1443 | void
1443   read_conf_files(int cold)
1444   {
1445    const char *filename;
1446 <  char chanmodes[32];
1447 <  char chanlimit[32];
1446 >  char chanmodes[IRCD_BUFSIZE];
1447 >  char chanlimit[IRCD_BUFSIZE];
1448  
1449    conf_parser_ctx.boot = cold;
1450 <  filename = get_conf_name(CONF_TYPE);
1450 >  filename = ConfigFileEntry.configfile;
1451  
1452    /* We need to know the initial filename for the yyerror() to report
1453       FIXME: The full path is in conffilenamebuf first time since we
1454               dont know anything else
1455  
1456 <     - Gozem 2002-07-21
1456 >     - Gozem 2002-07-21
1457    */
1458    strlcpy(conffilebuf, filename, sizeof(conffilebuf));
1459  
# Line 2316 | Line 1467 | read_conf_files(int cold)
1467      }
1468      else
1469      {
1470 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1471 <                           "Unable to read configuration file '%s': %s",
1472 <                           filename, strerror(errno));
1470 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1471 >                           "Unable to read configuration file '%s': %s",
1472 >                           filename, strerror(errno));
1473        return;
1474      }
1475    }
# Line 2329 | Line 1480 | read_conf_files(int cold)
1480    read_conf(conf_parser_ctx.conf_file);
1481    fclose(conf_parser_ctx.conf_file);
1482  
1483 +  log_reopen_all();
1484 +
1485 +  add_isupport("NICKLEN", NULL, ServerInfo.max_nick_length);
1486    add_isupport("NETWORK", ServerInfo.network_name, -1);
1487 <  snprintf(chanmodes, sizeof(chanmodes), "b%s%s:%d",
1488 <           ConfigChannel.use_except ? "e" : "",
2335 <           ConfigChannel.use_invex ? "I" : "", ConfigChannel.max_bans);
1487 >
1488 >  snprintf(chanmodes, sizeof(chanmodes), "beI:%d", ConfigChannel.max_bans);
1489    add_isupport("MAXLIST", chanmodes, -1);
1490    add_isupport("MAXTARGETS", NULL, ConfigFileEntry.max_targets);
1491 +  add_isupport("CHANTYPES", "#", -1);
1492  
1493 <  if (ConfigChannel.disable_local_channels)
1494 <    add_isupport("CHANTYPES", "#", -1);
2341 <  else
2342 <    add_isupport("CHANTYPES", "#&", -1);
2343 <
2344 <  snprintf(chanlimit, sizeof(chanlimit), "%s:%d",
2345 <           ConfigChannel.disable_local_channels ? "#" : "#&",
2346 <           ConfigChannel.max_chans_per_user);
1493 >  snprintf(chanlimit, sizeof(chanlimit), "#:%d",
1494 >           ConfigChannel.max_chans_per_user);
1495    add_isupport("CHANLIMIT", chanlimit, -1);
1496 <  snprintf(chanmodes, sizeof(chanmodes), "%s%s%s",
2349 <           ConfigChannel.use_except ? "e" : "",
2350 <           ConfigChannel.use_invex ? "I" : "", "b,k,l,imnprstORS");
1496 >  snprintf(chanmodes, sizeof(chanmodes), "%s", "beI,k,l,imnprstORS");
1497    add_isupport("CHANNELLEN", NULL, LOCAL_CHANNELLEN);
1498 <
2353 <  if (ConfigChannel.use_except)
2354 <    add_isupport("EXCEPTS", "e", -1);
2355 <  if (ConfigChannel.use_invex)
2356 <    add_isupport("INVEX", "I", -1);
1498 >  add_isupport("TOPICLEN", NULL, ServerInfo.max_topic_length);
1499    add_isupport("CHANMODES", chanmodes, -1);
1500  
1501    /*
# Line 2361 | Line 1503 | read_conf_files(int cold)
1503     * on strlen(form_str(RPL_ISUPPORT))
1504     */
1505    rebuild_isupport_message_line();
2364 –
2365 – #ifdef HAVE_LIBPCRE
2366 –  parse_conf_file(RKLINE_TYPE, cold);
2367 –  parse_conf_file(RXLINE_TYPE, cold);
2368 – #endif
2369 –  parse_conf_file(KLINE_TYPE, cold);
2370 –  parse_conf_file(DLINE_TYPE, cold);
2371 –  parse_conf_file(XLINE_TYPE, cold);
2372 –  parse_conf_file(NRESV_TYPE, cold);
2373 –  parse_conf_file(CRESV_TYPE, cold);
2374 – }
2375 –
2376 – /* parse_conf_file()
2377 – *
2378 – * inputs       - type of conf file to parse
2379 – * output       - none
2380 – * side effects - conf file for givenconf type is opened and read then parsed
2381 – */
2382 – static void
2383 – parse_conf_file(int type, int cold)
2384 – {
2385 –  FILE *file = NULL;
2386 –  const char *filename = get_conf_name(type);
2387 –
2388 –  if ((file = fopen(filename, "r")) == NULL)
2389 –  {
2390 –    if (cold)
2391 –      ilog(LOG_TYPE_IRCD, "Unable to read configuration file '%s': %s",
2392 –           filename, strerror(errno));
2393 –    else
2394 –      sendto_realops_flags(UMODE_ALL, L_ALL,
2395 –                    "Unable to read configuration file '%s': %s",
2396 –                           filename, strerror(errno));
2397 –  }
2398 –  else
2399 –  {
2400 –    parse_csv_file(file, type);
2401 –    fclose(file);
2402 –  }
1506   }
1507  
1508   /* clear_out_old_conf()
# Line 2412 | Line 1515 | static void
1515   clear_out_old_conf(void)
1516   {
1517    dlink_node *ptr = NULL, *next_ptr = NULL;
1518 <  struct ConfItem *conf;
2416 <  struct AccessItem *aconf;
2417 <  struct ClassItem *cltmp;
2418 <  struct MatchItem *match_item;
1518 >  struct MaskItem *conf;
1519    dlink_list *free_items [] = {
1520      &server_items,   &oconf_items,
1521 <     &uconf_items,   &xconf_items, &rxconf_items, &rkconf_items,
1522 <     &nresv_items, &cluster_items,  &gdeny_items, &service_items, NULL
1521 >     &uconf_items,   &xconf_items,
1522 >     &nresv_items, &cluster_items,  &service_items, &cresv_items, NULL
1523    };
1524  
1525    dlink_list ** iterator = free_items; /* C is dumb */
# Line 2427 | Line 1527 | clear_out_old_conf(void)
1527    /* We only need to free anything allocated by yyparse() here.
1528     * Resetting structs, etc, is taken care of by set_default_conf().
1529     */
1530 <  
1530 >
1531    for (; *iterator != NULL; iterator++)
1532    {
1533      DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
1534      {
1535        conf = ptr->data;
2436 –      /* XXX This is less than pretty */
2437 –      if (conf->type == SERVER_TYPE)
2438 –      {
2439 –        aconf = map_to_conf(conf);
1536  
1537 <        if (aconf->clients != 0)
2442 <        {
2443 <          SetConfIllegal(aconf);
2444 <          dlinkDelete(&conf->node, &server_items);
2445 <        }
2446 <        else
2447 <        {
2448 <          delete_conf_item(conf);
2449 <        }
2450 <      }
2451 <      else if (conf->type == OPER_TYPE)
2452 <      {
2453 <        aconf = map_to_conf(conf);
1537 >      dlinkDelete(&conf->node, map_to_list(conf->type));
1538  
1539 <        if (aconf->clients != 0)
1540 <        {
2457 <          SetConfIllegal(aconf);
2458 <          dlinkDelete(&conf->node, &oconf_items);
2459 <        }
2460 <        else
2461 <        {
2462 <          delete_conf_item(conf);
2463 <        }
2464 <      }
2465 <      else if (conf->type == XLINE_TYPE  ||
2466 <               conf->type == RXLINE_TYPE ||
2467 <               conf->type == RKLINE_TYPE)
1539 >      /* XXX This is less than pretty */
1540 >      if (conf->type == CONF_SERVER || conf->type == CONF_OPER)
1541        {
1542 <        /* temporary (r)xlines are also on
1543 <         * the (r)xconf items list */
2471 <        if (conf->flags & CONF_FLAGS_TEMPORARY)
2472 <          continue;
2473 <
2474 <        delete_conf_item(conf);
1542 >        if (!conf->ref_count)
1543 >          conf_free(conf);
1544        }
1545 <      else
1545 >      else if (conf->type == CONF_XLINE)
1546        {
1547 <          delete_conf_item(conf);
1547 >        if (!conf->until)
1548 >          conf_free(conf);
1549        }
1550 +      else
1551 +        conf_free(conf);
1552      }
1553    }
1554  
1555 +  motd_clear();
1556 +
1557    /*
1558     * don't delete the class table, rather mark all entries
1559 <   * for deletion. The table is cleaned up by check_class. - avalon
1559 >   * for deletion. The table is cleaned up by class_delete_marked. - avalon
1560     */
1561 <  DLINK_FOREACH(ptr, class_items.head)
2488 <  {
2489 <    cltmp = map_to_conf(ptr->data);
2490 <
2491 <    if (ptr != class_items.tail)  /* never mark the "default" class */
2492 <      cltmp->active = 0;
2493 <  }
1561 >  class_mark_for_deletion();
1562  
1563    clear_out_address_conf();
1564  
# Line 2526 | Line 1594 | clear_out_old_conf(void)
1594                                                 SSL_OP_NO_TLSv1);
1595   #endif
1596  
2529 –  /* clean out old resvs from the conf */
2530 –  clear_conf_resv();
2531 –
1597    /* clean out AdminInfo */
1598    MyFree(AdminInfo.name);
1599    AdminInfo.name = NULL;
# Line 2537 | Line 1602 | clear_out_old_conf(void)
1602    MyFree(AdminInfo.description);
1603    AdminInfo.description = NULL;
1604  
2540 –  /* operator{} and class{} blocks are freed above */
1605    /* clean out listeners */
1606    close_listeners();
1607  
2544 –  /* auth{}, quarantine{}, shared{}, connect{}, kill{}, deny{},
2545 –   * exempt{} and gecos{} blocks are freed above too
2546 –   */
2547 –
1608    /* clean out general */
1609    MyFree(ConfigFileEntry.service_name);
1610    ConfigFileEntry.service_name = NULL;
2551 –
2552 –  delete_isupport("INVEX");
2553 –  delete_isupport("EXCEPTS");
2554 – }
2555 –
2556 – /* flush_deleted_I_P()
2557 – *
2558 – * inputs       - none
2559 – * output       - none
2560 – * side effects - This function removes I/P conf items
2561 – */
2562 – static void
2563 – flush_deleted_I_P(void)
2564 – {
2565 –  dlink_node *ptr;
2566 –  dlink_node *next_ptr;
2567 –  struct ConfItem *conf;
2568 –  struct AccessItem *aconf;
2569 –  dlink_list * free_items [] = {
2570 –    &server_items, &oconf_items, NULL
2571 –  };
2572 –  dlink_list ** iterator = free_items; /* C is dumb */
2573 –
2574 –  /* flush out deleted I and P lines
2575 –   * although still in use.
2576 –   */
2577 –  for (; *iterator != NULL; iterator++)
2578 –  {
2579 –    DLINK_FOREACH_SAFE(ptr, next_ptr, (*iterator)->head)
2580 –    {
2581 –      conf = ptr->data;
2582 –      aconf = (struct AccessItem *)map_to_conf(conf);
2583 –
2584 –      if (IsConfIllegal(aconf))
2585 –      {
2586 –        dlinkDelete(ptr, *iterator);
2587 –
2588 –        if (aconf->clients == 0)
2589 –          delete_conf_item(conf);
2590 –      }
2591 –    }
2592 –  }
2593 – }
2594 –
2595 – /* get_conf_name()
2596 – *
2597 – * inputs       - type of conf file to return name of file for
2598 – * output       - pointer to filename for type of conf
2599 – * side effects - none
2600 – */
2601 – const char *
2602 – get_conf_name(ConfType type)
2603 – {
2604 –  switch (type)
2605 –  {
2606 –    case CONF_TYPE:
2607 –      return ConfigFileEntry.configfile;
2608 –      break;
2609 –    case KLINE_TYPE:
2610 –      return ConfigFileEntry.klinefile;
2611 –      break;
2612 –    case RKLINE_TYPE:
2613 –      return ConfigFileEntry.rklinefile;
2614 –      break;
2615 –    case DLINE_TYPE:
2616 –      return ConfigFileEntry.dlinefile;
2617 –      break;
2618 –    case XLINE_TYPE:
2619 –      return ConfigFileEntry.xlinefile;
2620 –      break;
2621 –    case RXLINE_TYPE:
2622 –      return ConfigFileEntry.rxlinefile;
2623 –      break;
2624 –    case CRESV_TYPE:
2625 –      return ConfigFileEntry.cresvfile;
2626 –      break;
2627 –    case NRESV_TYPE:
2628 –      return ConfigFileEntry.nresvfile;
2629 –      break;
2630 –    case GLINE_TYPE:
2631 –      return ConfigFileEntry.glinefile;
2632 –      break;
2633 –
2634 –    default:
2635 –      return NULL;  /* This should NEVER HAPPEN since we call this function
2636 –                       only with the above values, this will cause us to core
2637 –                       at some point if this happens so we know where it was */
2638 –  }
2639 – }
2640 –
2641 – #define BAD_PING (-1)
2642 –
2643 – /* get_conf_ping()
2644 – *
2645 – * inputs       - pointer to struct AccessItem
2646 – *              - pointer to a variable that receives ping warning time
2647 – * output       - ping frequency
2648 – * side effects - NONE
2649 – */
2650 – static int
2651 – get_conf_ping(struct ConfItem *conf, int *pingwarn)
2652 – {
2653 –  struct ClassItem *aclass;
2654 –  struct AccessItem *aconf;
2655 –
2656 –  if (conf != NULL)
2657 –  {
2658 –    aconf = (struct AccessItem *)map_to_conf(conf);
2659 –    if (aconf->class_ptr != NULL)
2660 –    {
2661 –      aclass = (struct ClassItem *)map_to_conf(aconf->class_ptr);
2662 –      *pingwarn = aclass->ping_warning;
2663 –      return aclass->ping_freq;
2664 –    }
2665 –  }
2666 –
2667 –  return BAD_PING;
2668 – }
2669 –
2670 – /* get_client_class()
2671 – *
2672 – * inputs       - pointer to client struct
2673 – * output       - pointer to name of class
2674 – * side effects - NONE
2675 – */
2676 – const char *
2677 – get_client_class(struct Client *target_p)
2678 – {
2679 –  dlink_node *cnode = NULL;
2680 –  struct AccessItem *aconf = NULL;
2681 –
2682 –  assert(!IsMe(target_p));
2683 –
2684 –  if ((cnode = target_p->localClient->confs.head))
2685 –  {
2686 –    struct ConfItem *conf = cnode->data;
2687 –
2688 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2689 –          (conf->type == OPER_TYPE));
2690 –
2691 –    aconf = map_to_conf(conf);
2692 –    if (aconf->class_ptr != NULL)
2693 –      return aconf->class_ptr->name;
2694 –  }
2695 –
2696 –  return "default";
2697 – }
2698 –
2699 – /* get_client_ping()
2700 – *
2701 – * inputs       - pointer to client struct
2702 – *              - pointer to a variable that receives ping warning time
2703 – * output       - ping frequency
2704 – * side effects - NONE
2705 – */
2706 – int
2707 – get_client_ping(struct Client *target_p, int *pingwarn)
2708 – {
2709 –  int ping = 0;
2710 –  dlink_node *cnode = NULL;
2711 –
2712 –  if ((cnode = target_p->localClient->confs.head))
2713 –  {
2714 –    struct ConfItem *conf = cnode->data;
2715 –
2716 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2717 –          (conf->type == OPER_TYPE));
2718 –
2719 –    ping = get_conf_ping(conf, pingwarn);
2720 –    if (ping > 0)
2721 –      return ping;
2722 –  }
2723 –
2724 –  *pingwarn = 0;
2725 –  return DEFAULT_PINGFREQUENCY;
2726 – }
2727 –
2728 – /* find_class()
2729 – *
2730 – * inputs       - string name of class
2731 – * output       - corresponding Class pointer
2732 – * side effects - NONE
2733 – */
2734 – struct ConfItem *
2735 – find_class(const char *classname)
2736 – {
2737 –  struct ConfItem *conf;
2738 –
2739 –  if ((conf = find_exact_name_conf(CLASS_TYPE, NULL, classname, NULL, NULL)) != NULL)
2740 –    return conf;
2741 –
2742 –  return class_default;
2743 – }
2744 –
2745 – /* check_class()
2746 – *
2747 – * inputs       - NONE
2748 – * output       - NONE
2749 – * side effects -
2750 – */
2751 – void
2752 – check_class(void)
2753 – {
2754 –  dlink_node *ptr = NULL, *next_ptr = NULL;
2755 –
2756 –  DLINK_FOREACH_SAFE(ptr, next_ptr, class_items.head)
2757 –  {
2758 –    struct ClassItem *aclass = map_to_conf(ptr->data);
2759 –
2760 –    if (!aclass->active && !aclass->curr_user_count)
2761 –    {
2762 –      destroy_cidr_class(aclass);
2763 –      delete_conf_item(ptr->data);
2764 –    }
2765 –  }
2766 – }
2767 –
2768 – /* init_class()
2769 – *
2770 – * inputs       - NONE
2771 – * output       - NONE
2772 – * side effects -
2773 – */
2774 – void
2775 – init_class(void)
2776 – {
2777 –  struct ClassItem *aclass;
2778 –
2779 –  class_default = make_conf_item(CLASS_TYPE);
2780 –
2781 –  aclass = map_to_conf(class_default);
2782 –  aclass->active = 1;
2783 –  DupString(class_default->name, "default");
2784 –  aclass->con_freq  = DEFAULT_CONNECTFREQUENCY;
2785 –  aclass->ping_freq = DEFAULT_PINGFREQUENCY;
2786 –  aclass->max_total = MAXIMUM_LINKS_DEFAULT;
2787 –  aclass->max_sendq = DEFAULT_SENDQ;
2788 –
2789 –  client_check_cb = register_callback("check_client", check_client);
2790 – }
2791 –
2792 – /* get_sendq()
2793 – *
2794 – * inputs       - pointer to client
2795 – * output       - sendq for this client as found from its class
2796 – * side effects - NONE
2797 – */
2798 – unsigned int
2799 – get_sendq(struct Client *client_p)
2800 – {
2801 –  unsigned int sendq = DEFAULT_SENDQ;
2802 –  dlink_node *cnode;
2803 –  struct ConfItem *class_conf;
2804 –  struct ClassItem *aclass;
2805 –  struct AccessItem *aconf;
2806 –
2807 –  assert(!IsMe(client_p));
2808 –
2809 –  if ((cnode = client_p->localClient->confs.head))
2810 –  {
2811 –    struct ConfItem *conf = cnode->data;
2812 –
2813 –    assert((conf->type == CLIENT_TYPE) || (conf->type == SERVER_TYPE) ||
2814 –          (conf->type == OPER_TYPE));
2815 –
2816 –    aconf = map_to_conf(conf);
2817 –
2818 –    if ((class_conf = aconf->class_ptr) == NULL)
2819 –      return DEFAULT_SENDQ; /* TBV: shouldn't be possible at all */
2820 –
2821 –    aclass = map_to_conf(class_conf);
2822 –    sendq = aclass->max_sendq;
2823 –    return sendq;
2824 –  }
2825 –
2826 –  /* XXX return a default?
2827 –   * if here, then there wasn't an attached conf with a sendq
2828 –   * that is very bad -Dianora
2829 –   */
2830 –  return DEFAULT_SENDQ;
1611   }
1612  
1613   /* conf_add_class_to_conf()
1614   *
1615   * inputs       - pointer to config item
1616   * output       - NONE
1617 < * side effects - Add a class pointer to a conf
1617 > * side effects - Add a class pointer to a conf
1618   */
1619   void
1620 < conf_add_class_to_conf(struct ConfItem *conf, const char *class_name)
1620 > conf_add_class_to_conf(struct MaskItem *conf, const char *class_name)
1621   {
1622 <  struct AccessItem *aconf = map_to_conf(conf);
2843 <  struct ClassItem *class = NULL;
2844 <
2845 <  if (class_name == NULL)
1622 >  if (class_name == NULL)
1623    {
1624 <    aconf->class_ptr = class_default;
1624 >    conf->class = class_default;
1625  
1626 <    if (conf->type == CLIENT_TYPE)
1627 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1628 <                           "Warning *** Defaulting to default class for %s@%s",
1629 <                           aconf->user, aconf->host);
1626 >    if (conf->type == CONF_CLIENT)
1627 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1628 >                           "Warning *** Defaulting to default class for %s@%s",
1629 >                           conf->user, conf->host);
1630      else
1631 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1632 <                           "Warning *** Defaulting to default class for %s",
1633 <                           conf->name);
1631 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1632 >                           "Warning *** Defaulting to default class for %s",
1633 >                           conf->name);
1634    }
1635    else
1636 <    aconf->class_ptr = find_class(class_name);
2860 <
2861 <  if (aconf->class_ptr)
2862 <    class = map_to_conf(aconf->class_ptr);
1636 >    conf->class = class_find(class_name, 1);
1637  
1638 <  if (aconf->class_ptr == NULL || !class->active)
1638 >  if (conf->class == NULL)
1639    {
1640 <    if (conf->type == CLIENT_TYPE)
1641 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1642 <                           "Warning *** Defaulting to default class for %s@%s",
1643 <                           aconf->user, aconf->host);
1640 >    if (conf->type == CONF_CLIENT)
1641 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1642 >                           "Warning *** Defaulting to default class for %s@%s",
1643 >                           conf->user, conf->host);
1644      else
1645 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1646 <                           "Warning *** Defaulting to default class for %s",
1647 <                           conf->name);
1648 <    aconf->class_ptr = class_default;
1645 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1646 >                           "Warning *** Defaulting to default class for %s",
1647 >                           conf->name);
1648 >    conf->class = class_default;
1649    }
1650   }
1651  
2878 – /* conf_add_server()
2879 – *
2880 – * inputs       - pointer to config item
2881 – *              - pointer to link count already on this conf
2882 – * output       - NONE
2883 – * side effects - Add a connect block
2884 – */
2885 – int
2886 – conf_add_server(struct ConfItem *conf, const char *class_name)
2887 – {
2888 –  struct AccessItem *aconf = map_to_conf(conf);
2889 –
2890 –  conf_add_class_to_conf(conf, class_name);
2891 –
2892 –  if (!aconf->host || !conf->name)
2893 –  {
2894 –    sendto_realops_flags(UMODE_ALL, L_ALL, "Bad connect block");
2895 –    ilog(LOG_TYPE_IRCD, "Bad connect block");
2896 –    return -1;
2897 –  }
2898 –
2899 –  if (EmptyString(aconf->passwd))
2900 –  {
2901 –    sendto_realops_flags(UMODE_ALL, L_ALL, "Bad connect block, name %s",
2902 –                         conf->name);
2903 –    ilog(LOG_TYPE_IRCD, "Bad connect block, host %s", conf->name);
2904 –    return -1;
2905 –  }
2906 –
2907 –  lookup_confhost(conf);
2908 –
2909 –  return 0;
2910 – }
2911 –
1652   /* yyerror()
1653   *
1654   * inputs       - message from parser
# Line 2924 | Line 1664 | yyerror(const char *msg)
1664      return;
1665  
1666    strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1667 <  sendto_realops_flags(UMODE_ALL, L_ALL, "\"%s\", line %u: %s: %s",
1667 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1668 >                       "\"%s\", line %u: %s: %s",
1669 >                       conffilebuf, lineno + 1, msg, newlinebuf);
1670 >  ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1671 >       conffilebuf, lineno + 1, msg, newlinebuf);
1672 > }
1673 >
1674 > void
1675 > conf_error_report(const char *msg)
1676 > {
1677 >  char newlinebuf[IRCD_BUFSIZE];
1678 >
1679 >  strip_tabs(newlinebuf, linebuf, sizeof(newlinebuf));
1680 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1681 >                       "\"%s\", line %u: %s: %s",
1682                         conffilebuf, lineno + 1, msg, newlinebuf);
1683    ilog(LOG_TYPE_IRCD, "\"%s\", line %u: %s: %s",
1684         conffilebuf, lineno + 1, msg, newlinebuf);
# Line 2932 | Line 1686 | yyerror(const char *msg)
1686  
1687   /*
1688   * valid_tkline()
1689 < *
1689 > *
1690   * inputs       - pointer to ascii string to check
1691   *              - whether the specified time is in seconds or minutes
1692   * output       - -1 not enough parameters
# Line 2941 | Line 1695 | yyerror(const char *msg)
1695   * Originally written by Dianora (Diane, db@db.net)
1696   */
1697   time_t
1698 < valid_tkline(const char *p, int minutes)
1698 > valid_tkline(const char *data, const int minutes)
1699   {
1700 +  const unsigned char *p = (const unsigned char *)data;
1701 +  unsigned char tmpch = '\0';
1702    time_t result = 0;
1703  
1704 <  for (; *p; ++p)
1704 >  while ((tmpch = *p++))
1705    {
1706 <    if (!IsDigit(*p))
1706 >    if (!IsDigit(tmpch))
1707        return 0;
1708  
1709      result *= 10;
1710 <    result += ((*p) & 0xF);
1710 >    result += (tmpch & 0xF);
1711    }
1712  
1713    /*
1714 <   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1714 >   * In the degenerate case where oper does a /quote kline 0 user@host :reason
1715     * i.e. they specifically use 0, I am going to return 1 instead
1716     * as a return value of non-zero is used to flag it as a temporary kline
1717     */
1718    if (result == 0)
1719      result = 1;
1720  
1721 <  /*
1721 >  /*
1722     * If the incoming time is in seconds convert it to minutes for the purpose
1723     * of this calculation
1724     */
1725    if (!minutes)
1726 <    result = result / (time_t)60;
1726 >    result = result / 60;
1727  
1728    if (result > MAX_TDKLINE_TIME)
1729      result = MAX_TDKLINE_TIME;
1730  
1731 <  result = result * (time_t)60;  /* turn it into seconds */
1731 >  result = result * 60;  /* turn it into seconds */
1732  
1733    return result;
1734   }
1735  
1736 + /* valid_wild_card_simple()
1737 + *
1738 + * inputs       - data to check for sufficient non-wildcard characters
1739 + * outputs      - 1 if valid, else 0
1740 + * side effects - none
1741 + */
1742 + int
1743 + valid_wild_card_simple(const char *data)
1744 + {
1745 +  const unsigned char *p = (const unsigned char *)data;
1746 +  unsigned char tmpch = '\0';
1747 +  int nonwild = 0;
1748 +
1749 +  while ((tmpch = *p++))
1750 +  {
1751 +    if (tmpch == '\\')
1752 +    {
1753 +      ++p;
1754 +      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1755 +        return 1;
1756 +    }
1757 +    else if (!IsMWildChar(tmpch))
1758 +    {
1759 +      if (++nonwild >= ConfigFileEntry.min_nonwildcard_simple)
1760 +        return 1;
1761 +    }
1762 +  }
1763 +
1764 +  return 0;
1765 + }
1766 +
1767   /* valid_wild_card()
1768   *
1769   * input        - pointer to client
# Line 2988 | Line 1775 | valid_tkline(const char *p, int minutes)
1775   int
1776   valid_wild_card(struct Client *source_p, int warn, int count, ...)
1777   {
2991 –  char *p;
1778    char tmpch;
1779    int nonwild = 0;
1780    va_list args;
# Line 3009 | Line 1795 | valid_wild_card(struct Client *source_p,
1795  
1796    while (count--)
1797    {
1798 <    p = va_arg(args, char *);
1798 >    const char *p = va_arg(args, const char *);
1799      if (p == NULL)
1800        continue;
1801  
# Line 3022 | Line 1808 | valid_wild_card(struct Client *source_p,
1808           * break - no point in searching further.
1809           */
1810          if (++nonwild >= ConfigFileEntry.min_nonwildcard)
1811 +        {
1812 +          va_end(args);
1813            return 1;
1814 +        }
1815        }
1816      }
1817    }
# Line 3030 | Line 1819 | valid_wild_card(struct Client *source_p,
1819    if (warn)
1820      sendto_one(source_p, ":%s NOTICE %s :Please include at least %d non-wildcard characters with the mask",
1821                 me.name, source_p->name, ConfigFileEntry.min_nonwildcard);
1822 +  va_end(args);
1823    return 0;
1824   }
1825  
# Line 3043 | Line 1833 | valid_wild_card(struct Client *source_p,
1833   *              - parse_flags bit map of things to test
1834   *              - pointer to user or string to parse into
1835   *              - pointer to host or NULL to parse into if non NULL
1836 < *              - pointer to optional tkline time or NULL
1836 > *              - pointer to optional tkline time or NULL
1837   *              - pointer to target_server to parse into if non NULL
1838   *              - pointer to reason to parse into
1839   *
# Line 3065 | Line 1855 | valid_wild_card(struct Client *source_p,
1855   */
1856   int
1857   parse_aline(const char *cmd, struct Client *source_p,
1858 <            int parc, char **parv,
1859 <            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1860 <            char **target_server, char **reason)
1858 >            int parc, char **parv,
1859 >            int parse_flags, char **up_p, char **h_p, time_t *tkline_time,
1860 >            char **target_server, char **reason)
1861   {
1862    int found_tkline_time=0;
1863    static char def_reason[] = "No Reason";
# Line 3089 | Line 1879 | parse_aline(const char *cmd, struct Clie
1879      else
1880      {
1881        sendto_one(source_p, ":%s NOTICE %s :temp_line not supported by %s",
1882 <                 me.name, source_p->name, cmd);
1882 >                 me.name, source_p->name, cmd);
1883        return -1;
1884      }
1885    }
# Line 3111 | Line 1901 | parse_aline(const char *cmd, struct Clie
1901      *up_p = user;
1902      *h_p = host;
1903    }
1904 <
1904 >
1905    parc--;
1906    parv++;
1907  
# Line 3124 | Line 1914 | parse_aline(const char *cmd, struct Clie
1914  
1915        if (target_server == NULL)
1916        {
1917 <        sendto_one(source_p, ":%s NOTICE %s :ON server not supported by %s",
1918 <                   me.name, source_p->name, cmd);
1919 <        return -1;
1917 >        sendto_one(source_p, ":%s NOTICE %s :ON server not supported by %s",
1918 >                   me.name, source_p->name, cmd);
1919 >        return -1;
1920        }
1921  
1922        if (!HasOFlag(source_p, OPER_FLAG_REMOTEBAN))
# Line 3138 | Line 1928 | parse_aline(const char *cmd, struct Clie
1928  
1929        if (parc == 0 || EmptyString(*parv))
1930        {
1931 <        sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
1932 <                   me.name, source_p->name, cmd);
1933 <        return -1;
1931 >        sendto_one(source_p, form_str(ERR_NEEDMOREPARAMS),
1932 >                   me.name, source_p->name, cmd);
1933 >        return -1;
1934        }
1935  
1936        *target_server = *parv;
# Line 3153 | Line 1943 | parse_aline(const char *cmd, struct Clie
1943         * caller probably NULL'd it first, but no harm to do it again -db
1944         */
1945        if (target_server != NULL)
1946 <        *target_server = NULL;
1946 >        *target_server = NULL;
1947      }
1948    }
1949  
# Line 3179 | Line 1969 | parse_aline(const char *cmd, struct Clie
1969      {
1970        *reason = *parv;
1971        if (!valid_comment(source_p, *reason, 1))
1972 <        return -1;
1972 >        return -1;
1973      }
1974      else
1975        *reason = def_reason;
# Line 3218 | Line 2008 | find_user_host(struct Client *source_p,
2008      {
2009        *(hostp++) = '\0';                       /* short and squat */
2010        if (*user_host_or_nick)
2011 <        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
2011 >        strlcpy(luser, user_host_or_nick, USERLEN*4 + 1); /* here is my user */
2012        else
2013 <        strcpy(luser, "*");
2013 >        strcpy(luser, "*");
2014 >
2015        if (*hostp)
2016 <        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2016 >        strlcpy(lhost, hostp, HOSTLEN + 1);    /* here is my host */
2017        else
2018 <        strcpy(lhost, "*");
2018 >        strcpy(lhost, "*");
2019      }
2020      else
2021      {
2022        luser[0] = '*';             /* no @ found, assume its *@somehost */
2023 <      luser[1] = '\0';    
2023 >      luser[1] = '\0';
2024        strlcpy(lhost, user_host_or_nick, HOSTLEN*4 + 1);
2025      }
2026 <    
2026 >
2027      return 1;
2028    }
2029 <  else if (!(flags & NOUSERLOOKUP))
2029 >  else
2030    {
2031      /* Try to find user@host mask from nick */
2032      /* Okay to use source_p as the first param, because source_p == client_p */
2033 <    if ((target_p =
2034 <        find_chasing(source_p, source_p, user_host_or_nick, NULL)) == NULL)
2033 >    if ((target_p =
2034 >        find_chasing(source_p, user_host_or_nick, NULL)) == NULL)
2035        return 0;
2036  
2037      if (IsExemptKline(target_p))
2038      {
2039        if (!IsServer(source_p))
2040 <        sendto_one(source_p,
2041 <                   ":%s NOTICE %s :%s is E-lined",
2042 <                   me.name, source_p->name, target_p->name);
2040 >        sendto_one(source_p,
2041 >                   ":%s NOTICE %s :%s is E-lined",
2042 >                   me.name, source_p->name, target_p->name);
2043        return 0;
2044      }
2045  
# Line 3283 | Line 2074 | find_user_host(struct Client *source_p,
2074   int
2075   valid_comment(struct Client *source_p, char *comment, int warn)
2076   {
3286 –  if (strchr(comment, '"'))
3287 –  {
3288 –    if (warn)
3289 –      sendto_one(source_p, ":%s NOTICE %s :Invalid character '\"' in comment",
3290 –                 me.name, source_p->name);
3291 –    return 0;
3292 –  }
3293 –
2077    if (strlen(comment) > REASONLEN)
2078      comment[REASONLEN-1] = '\0';
2079  
# Line 3305 | Line 2088 | valid_comment(struct Client *source_p, c
2088   * side effects - none
2089   */
2090   int
2091 < match_conf_password(const char *password, const struct AccessItem *aconf)
2091 > match_conf_password(const char *password, const struct MaskItem *conf)
2092   {
2093    const char *encr = NULL;
2094  
2095 <  if (EmptyString(password) || EmptyString(aconf->passwd))
2095 >  if (EmptyString(password) || EmptyString(conf->passwd))
2096      return 0;
2097  
2098 <  if (aconf->flags & CONF_FLAGS_ENCRYPTED)
2099 <    encr = crypt(password, aconf->passwd);
2098 >  if (conf->flags & CONF_FLAGS_ENCRYPTED)
2099 >    encr = crypt(password, conf->passwd);
2100    else
2101      encr = password;
2102  
2103 <  return !strcmp(encr, aconf->passwd);
2103 >  return !strcmp(encr, conf->passwd);
2104   }
2105  
2106   /*
# Line 3346 | Line 2129 | cluster_a_line(struct Client *source_p,
2129  
2130    DLINK_FOREACH(ptr, cluster_items.head)
2131    {
2132 <    const struct ConfItem *conf = ptr->data;
2132 >    const struct MaskItem *conf = ptr->data;
2133  
2134      if (conf->flags & cluster_type)
2135        sendto_match_servs(source_p, conf->name, CAP_CLUSTER|capab,
2136 <                         "%s %s %s", command, conf->name, buffer);
2136 >                         "%s %s %s", command, conf->name, buffer);
2137    }
2138   }
2139  
# Line 3401 | Line 2184 | split_nuh(struct split_nuh_item *const i
2184      if (iptr->nickptr && *iptr->nuhmask != '\0')
2185        strlcpy(iptr->nickptr, iptr->nuhmask, iptr->nicksize);
2186  
2187 <    if ((q = strchr(++p, '@'))) {
2187 >    if ((q = strchr(++p, '@')))
2188 >    {
2189        *q++ = '\0';
2190  
2191        if (*p != '\0')
# Line 3440 | Line 2224 | split_nuh(struct split_nuh_item *const i
2224      }
2225    }
2226   }
3443 –
3444 – /*
3445 – * flags_to_ascii
3446 – *
3447 – * inputs       - flags is a bitmask
3448 – *              - pointer to table of ascii letters corresponding
3449 – *                to each bit
3450 – *              - flag 1 for convert ToLower if bit missing
3451 – *                0 if ignore.
3452 – * output       - none
3453 – * side effects - string pointed to by p has bitmap chars written to it
3454 – */
3455 – static void
3456 – flags_to_ascii(unsigned int flags, const unsigned int bit_table[], char *p,
3457 –               int lowerit)
3458 – {
3459 –  unsigned int mask = 1;
3460 –  int i = 0;
3461 –
3462 –  for (mask = 1; (mask != 0) && (bit_table[i] != 0); mask <<= 1, i++)
3463 –  {
3464 –    if (flags & mask)
3465 –      *p++ = bit_table[i];
3466 –    else if (lowerit)
3467 –      *p++ = ToLower(bit_table[i]);
3468 –  }
3469 –  *p = '\0';
3470 – }
3471 –
3472 – /*
3473 – * cidr_limit_reached
3474 – *
3475 – * inputs       - int flag allowing over_rule of limits
3476 – *              - pointer to the ip to be added
3477 – *              - pointer to the class
3478 – * output       - non zero if limit reached
3479 – *                0 if limit not reached
3480 – * side effects -
3481 – */
3482 – static int
3483 – cidr_limit_reached(int over_rule,
3484 –                   struct irc_ssaddr *ip, struct ClassItem *aclass)
3485 – {
3486 –  dlink_node *ptr = NULL;
3487 –  struct CidrItem *cidr;
3488 –
3489 –  if (aclass->number_per_cidr <= 0)
3490 –    return 0;
3491 –
3492 –  if (ip->ss.ss_family == AF_INET)
3493 –  {
3494 –    if (aclass->cidr_bitlen_ipv4 <= 0)
3495 –      return 0;
3496 –
3497 –    DLINK_FOREACH(ptr, aclass->list_ipv4.head)
3498 –    {
3499 –      cidr = ptr->data;
3500 –      if (match_ipv4(ip, &cidr->mask, aclass->cidr_bitlen_ipv4))
3501 –      {
3502 –        if (!over_rule && (cidr->number_on_this_cidr >= aclass->number_per_cidr))
3503 –          return -1;
3504 –        cidr->number_on_this_cidr++;
3505 –        return 0;
3506 –      }
3507 –    }
3508 –    cidr = MyMalloc(sizeof(struct CidrItem));
3509 –    cidr->number_on_this_cidr = 1;
3510 –    cidr->mask = *ip;
3511 –    mask_addr(&cidr->mask, aclass->cidr_bitlen_ipv4);
3512 –    dlinkAdd(cidr, &cidr->node, &aclass->list_ipv4);
3513 –  }
3514 – #ifdef IPV6
3515 –  else if (aclass->cidr_bitlen_ipv6 > 0)
3516 –  {
3517 –    DLINK_FOREACH(ptr, aclass->list_ipv6.head)
3518 –    {
3519 –      cidr = ptr->data;
3520 –      if (match_ipv6(ip, &cidr->mask, aclass->cidr_bitlen_ipv6))
3521 –      {
3522 –        if (!over_rule && (cidr->number_on_this_cidr >= aclass->number_per_cidr))
3523 –          return -1;
3524 –        cidr->number_on_this_cidr++;
3525 –        return 0;
3526 –      }
3527 –    }
3528 –    cidr = MyMalloc(sizeof(struct CidrItem));
3529 –    cidr->number_on_this_cidr = 1;
3530 –    cidr->mask = *ip;
3531 –    mask_addr(&cidr->mask, aclass->cidr_bitlen_ipv6);
3532 –    dlinkAdd(cidr, &cidr->node, &aclass->list_ipv6);
3533 –  }
3534 – #endif
3535 –  return 0;
3536 – }
3537 –
3538 – /*
3539 – * remove_from_cidr_check
3540 – *
3541 – * inputs       - pointer to the ip to be removed
3542 – *              - pointer to the class
3543 – * output       - NONE
3544 – * side effects -
3545 – */
3546 – static void
3547 – remove_from_cidr_check(struct irc_ssaddr *ip, struct ClassItem *aclass)
3548 – {
3549 –  dlink_node *ptr = NULL;
3550 –  dlink_node *next_ptr = NULL;
3551 –  struct CidrItem *cidr;
3552 –
3553 –  if (aclass->number_per_cidr == 0)
3554 –    return;
3555 –
3556 –  if (ip->ss.ss_family == AF_INET)
3557 –  {
3558 –    if (aclass->cidr_bitlen_ipv4 <= 0)
3559 –      return;
3560 –
3561 –    DLINK_FOREACH_SAFE(ptr, next_ptr, aclass->list_ipv4.head)
3562 –    {
3563 –      cidr = ptr->data;
3564 –      if (match_ipv4(ip, &cidr->mask, aclass->cidr_bitlen_ipv4))
3565 –      {
3566 –        cidr->number_on_this_cidr--;
3567 –        if (cidr->number_on_this_cidr == 0)
3568 –        {
3569 –          dlinkDelete(ptr, &aclass->list_ipv4);
3570 –          MyFree(cidr);
3571 –          return;
3572 –        }
3573 –      }
3574 –    }
3575 –  }
3576 – #ifdef IPV6
3577 –  else if (aclass->cidr_bitlen_ipv6 > 0)
3578 –  {
3579 –    DLINK_FOREACH_SAFE(ptr, next_ptr, aclass->list_ipv6.head)
3580 –    {
3581 –      cidr = ptr->data;
3582 –      if (match_ipv6(ip, &cidr->mask, aclass->cidr_bitlen_ipv6))
3583 –      {
3584 –        cidr->number_on_this_cidr--;
3585 –        if (cidr->number_on_this_cidr == 0)
3586 –        {
3587 –          dlinkDelete(ptr, &aclass->list_ipv6);
3588 –          MyFree(cidr);
3589 –          return;
3590 –        }
3591 –      }
3592 –    }
3593 –  }
3594 – #endif
3595 – }
3596 –
3597 – static void
3598 – rebuild_cidr_list(int aftype, struct ConfItem *oldcl, struct ClassItem *newcl,
3599 –                  dlink_list *old_list, dlink_list *new_list, int changed)
3600 – {
3601 –  dlink_node *ptr;
3602 –  struct Client *client_p;
3603 –  struct ConfItem *conf;
3604 –  struct AccessItem *aconf;
3605 –
3606 –  if (!changed)
3607 –  {
3608 –    *new_list = *old_list;
3609 –    old_list->head = old_list->tail = NULL;
3610 –    old_list->length = 0;
3611 –    return;
3612 –  }
3613 –
3614 –  DLINK_FOREACH(ptr, local_client_list.head)
3615 –  {
3616 –    client_p = ptr->data;
3617 –    if (client_p->localClient->aftype != aftype)
3618 –      continue;
3619 –    if (dlink_list_length(&client_p->localClient->confs) == 0)
3620 –      continue;
3621 –
3622 –    conf = client_p->localClient->confs.tail->data;
3623 –    if (conf->type == CLIENT_TYPE)
3624 –    {
3625 –      aconf = map_to_conf(conf);
3626 –      if (aconf->class_ptr == oldcl)
3627 –        cidr_limit_reached(1, &client_p->localClient->ip, newcl);
3628 –    }
3629 –  }
3630 – }
3631 –
3632 – /*
3633 – * rebuild_cidr_class
3634 – *
3635 – * inputs       - pointer to old conf
3636 – *              - pointer to new_class
3637 – * output       - none
3638 – * side effects - rebuilds the class link list of cidr blocks
3639 – */
3640 – void
3641 – rebuild_cidr_class(struct ConfItem *conf, struct ClassItem *new_class)
3642 – {
3643 –  struct ClassItem *old_class = map_to_conf(conf);
3644 –
3645 –  if (old_class->number_per_cidr > 0 && new_class->number_per_cidr > 0)
3646 –  {
3647 –    if (old_class->cidr_bitlen_ipv4 > 0 && new_class->cidr_bitlen_ipv4 > 0)
3648 –      rebuild_cidr_list(AF_INET, conf, new_class,
3649 –                        &old_class->list_ipv4, &new_class->list_ipv4,
3650 –                        old_class->cidr_bitlen_ipv4 != new_class->cidr_bitlen_ipv4);
3651 –
3652 – #ifdef IPV6
3653 –    if (old_class->cidr_bitlen_ipv6 > 0 && new_class->cidr_bitlen_ipv6 > 0)
3654 –      rebuild_cidr_list(AF_INET6, conf, new_class,
3655 –                        &old_class->list_ipv6, &new_class->list_ipv6,
3656 –                        old_class->cidr_bitlen_ipv6 != new_class->cidr_bitlen_ipv6);
3657 – #endif
3658 –  }
3659 –
3660 –  destroy_cidr_class(old_class);
3661 – }
3662 –
3663 – /*
3664 – * destroy_cidr_list
3665 – *
3666 – * inputs       - pointer to class dlink list of cidr blocks
3667 – * output       - none
3668 – * side effects - completely destroys the class link list of cidr blocks
3669 – */
3670 – static void
3671 – destroy_cidr_list(dlink_list *list)
3672 – {
3673 –  dlink_node *ptr = NULL, *next_ptr = NULL;
3674 –
3675 –  DLINK_FOREACH_SAFE(ptr, next_ptr, list->head)
3676 –  {
3677 –    dlinkDelete(ptr, list);
3678 –    MyFree(ptr->data);
3679 –  }
3680 – }
3681 –
3682 – /*
3683 – * destroy_cidr_class
3684 – *
3685 – * inputs       - pointer to class
3686 – * output       - none
3687 – * side effects - completely destroys the class link list of cidr blocks
3688 – */
3689 – static void
3690 – destroy_cidr_class(struct ClassItem *aclass)
3691 – {
3692 –  destroy_cidr_list(&aclass->list_ipv4);
3693 –  destroy_cidr_list(&aclass->list_ipv6);
3694 – }

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)