ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/trunk/src/client.c
(Generate patch)

Comparing:
ircd-hybrid-7.2/src/client.c (file contents), Revision 887 by michael, Thu Nov 1 11:54:48 2007 UTC vs.
ircd-hybrid/trunk/src/client.c (file contents), Revision 2739 by michael, Sat Jan 4 20:04:27 2014 UTC

# Line 23 | Line 23
23   */
24  
25   #include "stdinc.h"
26 < #include "tools.h"
26 > #include "list.h"
27   #include "client.h"
28   #include "channel_mode.h"
29 – #include "common.h"
29   #include "event.h"
30   #include "fdlist.h"
31   #include "hash.h"
32   #include "irc_string.h"
34 – #include "sprintf_irc.h"
33   #include "ircd.h"
36 – #include "list.h"
34   #include "s_gline.h"
35   #include "numeric.h"
36   #include "packet.h"
37   #include "s_auth.h"
38   #include "s_bsd.h"
39 < #include "s_conf.h"
40 < #include "s_log.h"
39 > #include "conf.h"
40 > #include "log.h"
41   #include "s_misc.h"
42   #include "s_serv.h"
43   #include "send.h"
# Line 48 | Line 45
45   #include "s_user.h"
46   #include "dbuf.h"
47   #include "memory.h"
48 + #include "mempool.h"
49   #include "hostmask.h"
52 – #include "balloc.h"
50   #include "listener.h"
51   #include "irc_res.h"
52   #include "userhost.h"
53   #include "watch.h"
54 + #include "rng_mt.h"
55 + #include "parse.h"
56  
57   dlink_list listing_client_list = { NULL, NULL, 0 };
58   /* Pointer to beginning of Client list */
# Line 67 | Line 66 | dlink_list oper_list = {NULL, NULL, 0};
66  
67   static EVH check_pings;
68  
69 < static BlockHeap *client_heap  = NULL;
70 < static BlockHeap *lclient_heap = NULL;
69 > static mp_pool_t *client_pool  = NULL;
70 > static mp_pool_t *lclient_pool = NULL;
71  
72   static dlink_list dead_list  = { NULL, NULL, 0};
73   static dlink_list abort_list = { NULL, NULL, 0};
# Line 77 | Line 76 | static dlink_node *eac_next;  /* next ab
76  
77   static void check_pings_list(dlink_list *);
78   static void check_unknowns_list(void);
79 < static void ban_them(struct Client *client_p, struct ConfItem *conf);
79 > static void ban_them(struct Client *, struct MaskItem *);
80  
81  
82 < /* init_client()
82 > /* client_init()
83   *
84   * inputs       - NONE
85   * output       - NONE
86   * side effects - initialize client free memory
87   */
88   void
89 < init_client(void)
89 > client_init(void)
90   {
91    /* start off the check ping event ..  -- adrian
92     * Every 30 seconds is plenty -- db
93     */
94 <  client_heap = BlockHeapCreate("client", sizeof(struct Client), CLIENT_HEAP_SIZE);
95 <  lclient_heap = BlockHeapCreate("local client", sizeof(struct LocalUser), LCLIENT_HEAP_SIZE);
94 >  client_pool = mp_pool_new(sizeof(struct Client), MP_CHUNK_SIZE_CLIENT);
95 >  lclient_pool = mp_pool_new(sizeof(struct LocalUser), MP_CHUNK_SIZE_LCLIENT);
96    eventAdd("check_pings", check_pings, NULL, 5);
97   }
98  
# Line 115 | Line 114 | init_client(void)
114   struct Client *
115   make_client(struct Client *from)
116   {
117 <  struct Client *client_p = BlockHeapAlloc(client_heap);
117 >  struct Client *client_p = mp_pool_get(client_pool);
118 >
119 >  memset(client_p, 0, sizeof(*client_p));
120  
121    if (from == NULL)
122    {
123 <    client_p->from  = client_p; /* 'from' of local client is self! */
124 <    client_p->since = client_p->lasttime = client_p->firsttime = CurrentTime;
123 >    client_p->from                      = client_p; /* 'from' of local client is self! */
124 >    client_p->localClient               = mp_pool_get(lclient_pool);
125  
126 <    client_p->localClient = BlockHeapAlloc(lclient_heap);
126 >    memset(client_p->localClient, 0, sizeof(*client_p->localClient));
127 >
128 >    client_p->localClient->since        = CurrentTime;
129 >    client_p->localClient->lasttime     = CurrentTime;
130 >    client_p->localClient->firsttime    = CurrentTime;
131      client_p->localClient->registration = REG_INIT;
132 +
133      /* as good a place as any... */
134 <    dlinkAdd(client_p, make_dlink_node(), &unknown_list);
134 >    dlinkAdd(client_p, &client_p->localClient->lclient_node, &unknown_list);
135    }
136    else
137      client_p->from = from; /* 'from' of local client is self! */
138  
139 +  client_p->idhnext = client_p;
140    client_p->hnext  = client_p;
141 <  client_p->status = STAT_UNKNOWN;
141 >  SetUnknown(client_p);
142    strcpy(client_p->username, "unknown");
143 +  strcpy(client_p->svid, "0");
144  
145    return client_p;
146   }
# Line 150 | Line 158 | free_client(struct Client *client_p)
158    assert(client_p != NULL);
159    assert(client_p != &me);
160    assert(client_p->hnext == client_p);
161 +  assert(client_p->idhnext == client_p);
162    assert(client_p->channel.head == NULL);
163    assert(dlink_list_length(&client_p->channel) == 0);
164 +  assert(dlink_list_length(&client_p->whowas) == 0);
165 +  assert(!IsServer(client_p) || (IsServer(client_p) && client_p->serv));
166  
156 –  MyFree(client_p->away);
167    MyFree(client_p->serv);
168 +  MyFree(client_p->certfp);
169  
170    if (MyConnect(client_p))
171    {
172      assert(client_p->localClient->invited.head == NULL);
173      assert(dlink_list_length(&client_p->localClient->invited) == 0);
174 +    assert(dlink_list_length(&client_p->localClient->watches) == 0);
175      assert(IsClosing(client_p) && IsDead(client_p));
176  
177      MyFree(client_p->localClient->response);
# Line 172 | Line 184 | free_client(struct Client *client_p)
184      {
185        assert(0 < client_p->localClient->listener->ref_count);
186        if (0 == --client_p->localClient->listener->ref_count &&
187 <          !client_p->localClient->listener->active)
187 >          !client_p->localClient->listener->active)
188          free_listener(client_p->localClient->listener);
189      }
190  
191      dbuf_clear(&client_p->localClient->buf_recvq);
192      dbuf_clear(&client_p->localClient->buf_sendq);
193  
194 <    BlockHeapFree(lclient_heap, client_p->localClient);
194 >    mp_pool_release(client_p->localClient);
195    }
196  
197 <  BlockHeapFree(client_heap, client_p);
197 >  mp_pool_release(client_p);
198   }
199  
200   /*
# Line 191 | Line 203 | free_client(struct Client *client_p)
203   *
204   * inputs       - NOT USED (from event)
205   * output       - next time_t when check_pings() should be called again
206 < * side effects -
206 > * side effects -
207   *
208   *
209   * A PING can be sent to clients as necessary.
# Line 213 | Line 225 | free_client(struct Client *client_p)
225  
226   static void
227   check_pings(void *notused)
228 < {              
228 > {
229    check_pings_list(&local_client_list);
230    check_pings_list(&serv_list);
231    check_unknowns_list();
# Line 223 | Line 235 | check_pings(void *notused)
235   *
236   * inputs       - pointer to list to check
237   * output       - NONE
238 < * side effects -
238 > * side effects -
239   */
240   static void
241   check_pings_list(dlink_list *list)
242   {
243 <  char scratch[32];        /* way too generous but... */
244 <  struct Client *client_p; /* current local client_p being examined */
245 <  int ping, pingwarn;      /* ping time value from client */
234 <  dlink_node *ptr, *next_ptr;
243 >  char scratch[IRCD_BUFSIZE];
244 >  int ping = 0;      /* ping time value from client */
245 >  dlink_node *ptr = NULL, *next_ptr = NULL;
246  
247    DLINK_FOREACH_SAFE(ptr, next_ptr, list->head)
248    {
249 <    client_p = ptr->data;
249 >    struct Client *client_p = ptr->data;
250  
251      /*
252      ** Note: No need to notify opers here. It's
# Line 244 | Line 255 | check_pings_list(dlink_list *list)
255      if (IsDead(client_p))
256      {
257        /* Ignore it, its been exited already */
247 –      continue;
248 –    }
249 –
250 –    if (client_p->localClient->reject_delay > 0)
251 –    {
252 –      if (client_p->localClient->reject_delay <= CurrentTime)
253 –        exit_client(client_p, &me, "Rejected");
258        continue;
259      }
260  
257 –    if (GlobalSetOptions.idletime && IsClient(client_p))
258 –    {
259 –      if (!IsExemptKline(client_p) && !IsOper(client_p) &&
260 –          !IsIdlelined(client_p) &&
261 –          ((CurrentTime - client_p->localClient->last) > GlobalSetOptions.idletime))
262 –      {
263 –        struct ConfItem *conf;
264 –        struct AccessItem *aconf;
265 –
266 –        conf = make_conf_item(KLINE_TYPE);
267 –        aconf = (struct AccessItem *)map_to_conf(conf);
268 –
269 –        DupString(aconf->host, client_p->host);
270 –        DupString(aconf->reason, "idle exceeder");
271 –        DupString(aconf->user, client_p->username);
272 –        aconf->hold = CurrentTime + 60;
273 –        add_temp_line(conf);
274 –
275 –        sendto_realops_flags(UMODE_ALL, L_ALL,
276 –                             "Idle time limit exceeded for %s - temp k-lining",
277 –                             get_client_name(client_p, HIDE_IP));
278 –        exit_client(client_p, &me, aconf->reason);
279 –        continue;
280 –      }
281 –    }
282 –
261      if (!IsRegistered(client_p))
262 <      ping = CONNECTTIMEOUT, pingwarn = 0;
262 >      ping = CONNECTTIMEOUT;
263      else
264 <      ping = get_client_ping(client_p, &pingwarn);
264 >      ping = get_client_ping(&client_p->localClient->confs);
265  
266 <    if (ping < CurrentTime - client_p->lasttime)
266 >    if (ping < CurrentTime - client_p->localClient->lasttime)
267      {
268        if (!IsPingSent(client_p))
269        {
270 <        /*
271 <         * if we havent PINGed the connection and we havent
272 <         * heard from it in a while, PING it to make sure
273 <         * it is still alive.
274 <         */
275 <        SetPingSent(client_p);
276 <        ClearPingWarning(client_p);
277 <        client_p->lasttime = CurrentTime - ping;
300 <        sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
270 >        /*
271 >         * if we havent PINGed the connection and we havent
272 >         * heard from it in a while, PING it to make sure
273 >         * it is still alive.
274 >         */
275 >        SetPingSent(client_p);
276 >        client_p->localClient->lasttime = CurrentTime - ping;
277 >        sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
278        }
279        else
280        {
281 <        if (CurrentTime - client_p->lasttime >= 2 * ping)
281 >        if (CurrentTime - client_p->localClient->lasttime >= 2 * ping)
282          {
283            /*
284             * If the client/server hasn't talked to us in 2*ping seconds
285             * and it has a ping time, then close its connection.
286             */
287            if (IsServer(client_p) || IsHandshake(client_p))
288 <          {
289 <            sendto_realops_flags(UMODE_ALL, L_ADMIN,
290 <                                 "No response from %s, closing link",
291 <                                 get_client_name(client_p, HIDE_IP));
292 <            sendto_realops_flags(UMODE_ALL, L_OPER,
293 <                                 "No response from %s, closing link",
294 <                                 get_client_name(client_p, MASK_IP));
295 <            ilog(L_NOTICE, "No response from %s, closing link",
296 <                 get_client_name(client_p, HIDE_IP));
297 <          }
288 >          {
289 >            sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
290 >                                 "No response from %s, closing link",
291 >                                 get_client_name(client_p, HIDE_IP));
292 >            sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
293 >                                 "No response from %s, closing link",
294 >                                 get_client_name(client_p, MASK_IP));
295 >            ilog(LOG_TYPE_IRCD, "No response from %s, closing link",
296 >                 get_client_name(client_p, HIDE_IP));
297 >          }
298  
299 <          ircsprintf(scratch, "Ping timeout: %d seconds",
300 <                     (int)(CurrentTime - client_p->lasttime));
299 >          snprintf(scratch, sizeof(scratch), "Ping timeout: %d seconds",
300 >                   (int)(CurrentTime - client_p->localClient->lasttime));
301            exit_client(client_p, &me, scratch);
302          }
326 –        else if (!IsPingWarning(client_p) && pingwarn > 0 &&
327 –                 (IsServer(client_p) || IsHandshake(client_p)) &&
328 –                 CurrentTime - client_p->lasttime >= ping + pingwarn)
329 –        {
330 –          /*
331 –           * If the server hasn't replied in pingwarn seconds after sending
332 –           * the PING, notify the opers so that they are aware of the problem.
333 –           */
334 –          SetPingWarning(client_p);
335 –          sendto_realops_flags(UMODE_ALL, L_ADMIN,
336 –                               "Warning, no response from %s in %d seconds",
337 –                               get_client_name(client_p, HIDE_IP), pingwarn);
338 –          sendto_realops_flags(UMODE_ALL, L_OPER,
339 –                               "Warning, no response from %s in %d seconds",
340 –                               get_client_name(client_p, MASK_IP), pingwarn);
341 –          ilog(L_NOTICE, "No response from %s in %d seconds",
342 –               get_client_name(client_p, HIDE_IP), pingwarn);
343 –        }
303        }
304      }
305    }
# Line 361 | Line 320 | check_unknowns_list(void)
320    {
321      struct Client *client_p = ptr->data;
322  
364 –    if (client_p->localClient->reject_delay > 0)
365 –    {
366 –      if (client_p->localClient->reject_delay <= CurrentTime)
367 –        exit_client(client_p, &me, "Rejected");
368 –      continue;
369 –    }
370 –
323      /*
324       * Check UNKNOWN connections - if they have been in this state
325       * for > 30s, close them.
326       */
327 <    if (IsAuthFinished(client_p) && (CurrentTime - client_p->firsttime) > 30)
327 >    if (IsAuthFinished(client_p) && (CurrentTime - client_p->localClient->firsttime) > 30)
328        exit_client(client_p, &me, "Registration timed out");
329    }
330   }
# Line 384 | Line 336 | check_unknowns_list(void)
336   * side effects - Check all connections for a pending kline against the
337   *                client, exit the client if a kline matches.
338   */
339 < void
339 > void
340   check_conf_klines(void)
341 < {              
341 > {
342    struct Client *client_p = NULL;       /* current local client_p being examined */
343 <  struct AccessItem *aconf = NULL;
392 <  struct ConfItem *conf = NULL;
343 >  struct MaskItem *conf = NULL;
344    dlink_node *ptr, *next_ptr;
345  
346    DLINK_FOREACH_SAFE(ptr, next_ptr, local_client_list.head)
# Line 401 | Line 352 | check_conf_klines(void)
352      if (IsDead(client_p) || !IsClient(client_p))
353        continue;
354  
355 <    /* if there is a returned struct ConfItem then kill it */
405 <    if ((aconf = find_dline_conf(&client_p->localClient->ip,
355 >    if ((conf = find_dline_conf(&client_p->localClient->ip,
356                                    client_p->localClient->aftype)) != NULL)
357      {
358 <      if (aconf->status & CONF_EXEMPTDLINE)
359 <        continue;
358 >      if (conf->type == CONF_EXEMPT)
359 >        continue;
360  
411 –      conf = unmap_conf_item(aconf);
361        ban_them(client_p, conf);
362        continue; /* and go examine next fd/client_p */
363      }
364  
365 <    if (ConfigFileEntry.glines && (aconf = find_gline(client_p)))
365 >    if (ConfigFileEntry.glines)
366      {
367 <      if (IsExemptKline(client_p) ||
368 <          IsExemptGline(client_p))
367 >      if ((conf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
368 >                                       CONF_GLINE, client_p->localClient->aftype,
369 >                                       client_p->username, NULL, 1)))
370        {
371 <        sendto_realops_flags(UMODE_ALL, L_ALL,
372 <                             "GLINE over-ruled for %s, client is %sline_exempt",
373 <                             get_client_name(client_p, HIDE_IP), IsExemptKline(client_p) ? "k" : "g");
371 >        if (IsExemptKline(client_p) ||
372 >            IsExemptGline(client_p))
373 >        {
374 >          sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
375 >                               "GLINE over-ruled for %s, client is %sline_exempt",
376 >                               get_client_name(client_p, HIDE_IP), IsExemptKline(client_p) ? "k" : "g");
377 >          continue;
378 >        }
379 >
380 >        ban_them(client_p, conf);
381 >        /* and go examine next fd/client_p */
382          continue;
383        }
384 +    }
385  
386 <      conf = unmap_conf_item(aconf);
387 <      ban_them(client_p, conf);
388 <      /* and go examine next fd/client_p */    
430 <      continue;
431 <    }
432 <
433 <    if ((aconf = find_kill(client_p)) != NULL)
386 >    if ((conf = find_conf_by_address(client_p->host, &client_p->localClient->ip,
387 >                                     CONF_KLINE, client_p->localClient->aftype,
388 >                                     client_p->username, NULL, 1)))
389      {
435 –
436 –      /* if there is a returned struct AccessItem.. then kill it */
390        if (IsExemptKline(client_p))
391        {
392 <        sendto_realops_flags(UMODE_ALL, L_ALL,
392 >        sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
393                               "KLINE over-ruled for %s, client is kline_exempt",
394                               get_client_name(client_p, HIDE_IP));
395          continue;
396        }
397  
445 –      conf = unmap_conf_item(aconf);
398        ban_them(client_p, conf);
399 <      continue;
399 >      continue;
400      }
401  
402 <    /* if there is a returned struct MatchItem then kill it */
403 <    if ((conf = find_matching_name_conf(XLINE_TYPE,  client_p->info,
452 <                                        NULL, NULL, 0)) != NULL ||
453 <        (conf = find_matching_name_conf(RXLINE_TYPE, client_p->info,
454 <                                        NULL, NULL, 0)) != NULL)
402 >    if ((conf = find_matching_name_conf(CONF_XLINE,  client_p->info,
403 >                                        NULL, NULL, 0)))
404      {
405        ban_them(client_p, conf);
406        continue;
# Line 463 | Line 412 | check_conf_klines(void)
412    {
413      client_p = ptr->data;
414  
415 <    if ((aconf = find_dline_conf(&client_p->localClient->ip,
416 <                                  client_p->localClient->aftype)))
415 >    if ((conf = find_dline_conf(&client_p->localClient->ip,
416 >                                 client_p->localClient->aftype)))
417      {
418 <      if (aconf->status & CONF_EXEMPTDLINE)
418 >      if (conf->type == CONF_EXEMPT)
419          continue;
420  
421        exit_client(client_p, &me, "D-lined");
# Line 478 | Line 427 | check_conf_klines(void)
427   * ban_them
428   *
429   * inputs       - pointer to client to ban
430 < *              - pointer to ConfItem
430 > *              - pointer to MaskItem
431   * output       - NONE
432   * side effects - given client_p is banned
433   */
434   static void
435 < ban_them(struct Client *client_p, struct ConfItem *conf)
435 > ban_them(struct Client *client_p, struct MaskItem *conf)
436   {
437 <  const char *user_reason = NULL;       /* What is sent to user */
489 <  const char *channel_reason = NULL;    /* What is sent to channel */
490 <  struct AccessItem *aconf = NULL;
491 <  struct MatchItem *xconf = NULL;
437 >  const char *user_reason = NULL;  /* What is sent to user */
438    const char *type_string = NULL;
439    const char dline_string[] = "D-line";
440    const char kline_string[] = "K-line";
# Line 497 | Line 443 | ban_them(struct Client *client_p, struct
443  
444    switch (conf->type)
445    {
446 <    case RKLINE_TYPE:
501 <    case KLINE_TYPE:
446 >    case CONF_KLINE:
447        type_string = kline_string;
503 –      aconf = map_to_conf(conf);
448        break;
449 <    case DLINE_TYPE:
449 >    case CONF_DLINE:
450        type_string = dline_string;
507 –      aconf = map_to_conf(conf);
451        break;
452 <    case GLINE_TYPE:
452 >    case CONF_GLINE:
453        type_string = gline_string;
511 –      aconf = map_to_conf(conf);
454        break;
455 <    case RXLINE_TYPE:
514 <    case XLINE_TYPE:
455 >    case CONF_XLINE:
456        type_string = xline_string;
457 <      xconf = map_to_conf(conf);
517 <      ++xconf->count;
457 >      ++conf->count;
458        break;
459      default:
460        assert(0);
461        break;
462    }
463  
464 <  if (ConfigFileEntry.kline_with_reason)
525 <  {
526 <    if (aconf != NULL)
527 <      user_reason = aconf->reason ? aconf->reason : type_string;
528 <    if (xconf != NULL)
529 <      user_reason = xconf->reason ? xconf->reason : type_string;
530 <  }
531 <  else
532 <    user_reason = type_string;
533 <
534 <  if (ConfigFileEntry.kline_reason != NULL)
535 <    channel_reason = ConfigFileEntry.kline_reason;
536 <  else
537 <    channel_reason = user_reason;
464 >  user_reason = conf->reason ? conf->reason : type_string;
465  
466 <  sendto_realops_flags(UMODE_ALL, L_ALL, "%s active for %s",
466 >  sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE, "%s active for %s",
467                         type_string, get_client_name(client_p, HIDE_IP));
468  
469    if (IsClient(client_p))
470      sendto_one(client_p, form_str(ERR_YOUREBANNEDCREEP),
471 <               me.name, client_p->name, user_reason);
471 >               me.name, client_p->name, user_reason);
472  
473 <  exit_client(client_p, &me, channel_reason);
473 >  exit_client(client_p, &me, user_reason);
474   }
475  
476   /* update_client_exit_stats()
477   *
478   * input        - pointer to client
479   * output       - NONE
480 < * side effects -
480 > * side effects -
481   */
482   static void
483   update_client_exit_stats(struct Client *client_p)
484   {
485 <  if (IsServer(client_p))
559 <  {
560 <    sendto_realops_flags(UMODE_EXTERNAL, L_ALL,
561 <                         "Server %s split from %s",
562 <                         client_p->name, client_p->servptr->name);
563 <  }
564 <  else if (IsClient(client_p))
485 >  if (IsClient(client_p))
486    {
487 +    assert(Count.total > 0);
488      --Count.total;
489 <    if (IsOper(client_p))
489 >    if (HasUMode(client_p, UMODE_OPER))
490        --Count.oper;
491 <    if (IsInvisible(client_p))
491 >    if (HasUMode(client_p, UMODE_INVISIBLE))
492        --Count.invisi;
493    }
494 +  else if (IsServer(client_p))
495 +    sendto_realops_flags(UMODE_EXTERNAL, L_ALL, SEND_NOTICE,
496 +                         "Server %s split from %s",
497 +                         client_p->name, client_p->servptr->name);
498  
499    if (splitchecking && !splitmode)
500      check_splitmode(NULL);
# Line 580 | Line 506 | update_client_exit_stats(struct Client *
506   * output       - return client pointer
507   * side effects - find person by (nick)name
508   */
583 – /* XXX - ugly wrapper */
509   struct Client *
510   find_person(const struct Client *client_p, const char *name)
511   {
512 <  struct Client *c2ptr;
512 >  struct Client *target_p = NULL;
513  
514    if (IsDigit(*name))
515    {
516 <    if ((c2ptr = hash_find_id(name)) != NULL)
517 <    {
593 <      /* invisible users shall not be found by UID guessing */
594 <      if (IsInvisible(c2ptr) && !IsServer(client_p))
595 <        c2ptr = NULL;
596 <    }
516 >    if (IsServer(client_p) || HasFlag(client_p, FLAGS_SERVICE))
517 >      target_p = hash_find_id(name);
518    }
519    else
520 <    c2ptr = find_client(name);
520 >    target_p = hash_find_client(name);
521  
522 <  return ((c2ptr != NULL && IsClient(c2ptr)) ? c2ptr : NULL);
522 >  return (target_p && IsClient(target_p)) ? target_p : NULL;
523   }
524  
525   /*
526 < * find_chasing - find the client structure for a nick name (user)
527 < *      using history mechanism if necessary. If the client is not found,
526 > * find_chasing - find the client structure for a nick name (name)
527 > *      using history mechanism if necessary. If the client is not found,
528   *      an error message (NO SUCH NICK) is generated. If the client was found
529   *      through the history, chasing will be 1 and otherwise 0.
530   */
531   struct Client *
532 < find_chasing(struct Client *client_p, struct Client *source_p, const char *user, int *chasing)
532 > find_chasing(struct Client *source_p, const char *name, int *const chasing)
533   {
534 <  struct Client *who = find_person(client_p, user);
534 >  struct Client *who = find_person(source_p->from, name);
535  
536    if (chasing)
537      *chasing = 0;
538  
539    if (who)
540 <    return(who);
540 >    return who;
541  
542 <  if (IsDigit(*user))
543 <    return(NULL);
542 >  if (IsDigit(*name))
543 >    return NULL;
544  
545 <  if ((who = get_history(user,
546 <                        (time_t)ConfigFileEntry.kill_chase_time_limit))
547 <                         == NULL)
545 >  if ((who = whowas_get_history(name,
546 >                         (time_t)ConfigFileEntry.kill_chase_time_limit))
547 >                         == NULL)
548    {
549      sendto_one(source_p, form_str(ERR_NOSUCHNICK),
550 <               me.name, source_p->name, user);
551 <    return(NULL);
550 >               me.name, source_p->name, name);
551 >    return NULL;
552    }
553  
554    if (chasing)
555      *chasing = 1;
556  
557 <  return(who);
557 >  return who;
558   }
559  
560   /*
# Line 655 | Line 576 | find_chasing(struct Client *client_p, st
576   *        to modify what it points!!!
577   */
578   const char *
579 < get_client_name(struct Client *client, int showip)
579 > get_client_name(const struct Client *client, enum addr_mask_type type)
580   {
581    static char nbuf[HOSTLEN * 2 + USERLEN + 5];
582  
583    assert(client != NULL);
584  
585 <  if (irccmp(client->name, client->host) == 0)
586 <    return(client->name);
585 >  if (!MyConnect(client))
586 >    return client->name;
587  
588 <  if (ConfigServerHide.hide_server_ips)
589 <    if (IsServer(client) || IsConnecting(client) || IsHandshake(client))
590 <      showip = MASK_IP;
588 >  if (IsServer(client) || IsConnecting(client) || IsHandshake(client))
589 >  {
590 >    if (!irccmp(client->name, client->host))
591 >      return client->name;
592 >    else if (ConfigServerHide.hide_server_ips)
593 >      type = MASK_IP;
594 >  }
595  
596    if (ConfigFileEntry.hide_spoof_ips)
597 <    if (showip == SHOW_IP && IsIPSpoof(client))
598 <      showip = MASK_IP;
597 >    if (type == SHOW_IP && IsIPSpoof(client))
598 >      type = MASK_IP;
599  
600    /* And finally, let's get the host information, ip or name */
601 <  switch (showip)
601 >  switch (type)
602    {
603      case SHOW_IP:
604 <      if (MyConnect(client))
605 <      {
606 <        ircsprintf(nbuf, "%s[%s@%s]", client->name, client->username,
607 <                   client->sockhost);
683 <        break;
684 <      }
604 >      snprintf(nbuf, sizeof(nbuf), "%s[%s@%s]",
605 >               client->name,
606 >               client->username, client->sockhost);
607 >      break;
608      case MASK_IP:
609 <      ircsprintf(nbuf, "%s[%s@255.255.255.255]", client->name,
610 <                 client->username);
609 >      if (client->localClient->aftype == AF_INET)
610 >        snprintf(nbuf, sizeof(nbuf), "%s[%s@255.255.255.255]",
611 >                 client->name, client->username);
612 >      else
613 >        snprintf(nbuf, sizeof(nbuf), "%s[%s@ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff]",
614 >                 client->name, client->username);
615        break;
616      default:
617 <      ircsprintf(nbuf, "%s[%s@%s]", client->name, client->username,
618 <                 client->host);
617 >      snprintf(nbuf, sizeof(nbuf), "%s[%s@%s]",
618 >               client->name,
619 >               client->username, client->host);
620    }
621  
622 <  return(nbuf);
622 >  return nbuf;
623   }
624  
625   void
626   free_exited_clients(void)
627   {
628    dlink_node *ptr = NULL, *next = NULL;
629 <  
629 >
630    DLINK_FOREACH_SAFE(ptr, next, dead_list.head)
631    {
632      free_client(ptr->data);
# Line 720 | Line 648 | exit_one_client(struct Client *source_p,
648  
649    assert(!IsMe(source_p));
650  
651 <  if (IsServer(source_p))
724 <  {
725 <    dlinkDelete(&source_p->lnode, &source_p->servptr->serv->servers);
726 <
727 <    if ((lp = dlinkFindDelete(&global_serv_list, source_p)) != NULL)
728 <      free_dlink_node(lp);
729 <
730 <    if (!MyConnect(source_p))
731 <    {
732 <      source_p->from->serv->dep_servers--;
733 <      assert(source_p->from->serv->dep_servers > 0);
734 <    }
735 <  }
736 <  else if (IsClient(source_p))
651 >  if (IsClient(source_p))
652    {
653      if (source_p->servptr->serv != NULL)
654 <      dlinkDelete(&source_p->lnode, &source_p->servptr->serv->users);
654 >      dlinkDelete(&source_p->lnode, &source_p->servptr->serv->client_list);
655  
656 <    /* If a person is on a channel, send a QUIT notice
657 <    ** to every client (person) on the same channel (so
658 <    ** that the client can show the "**signoff" message).
659 <    ** (Note: The notice is to the local clients *only*)
660 <    */
661 <    sendto_common_channels_local(source_p, 0, ":%s!%s@%s QUIT :%s",
656 >    /*
657 >     * If a person is on a channel, send a QUIT notice
658 >     * to every client (person) on the same channel (so
659 >     * that the client can show the "**signoff" message).
660 >     * (Note: The notice is to the local clients *only*)
661 >     */
662 >    sendto_common_channels_local(source_p, 0, 0, ":%s!%s@%s QUIT :%s",
663                                   source_p->name, source_p->username,
664                                   source_p->host, quitmsg);
665      DLINK_FOREACH_SAFE(lp, next_lp, source_p->channel.head)
666        remove_user_from_channel(lp->data);
667  
668 <    add_history(source_p, 0);
669 <    off_history(source_p);
668 >    whowas_add_history(source_p, 0);
669 >    whowas_off_history(source_p);
670  
671      watch_check_hash(source_p, RPL_LOGOFF);
672  
673 <    if (!MyConnect(source_p))
758 <    {
759 <      source_p->from->serv->dep_users--;
760 <      assert(source_p->from->serv->dep_users >= 0);
761 <    }
762 <    else
673 >    if (MyConnect(source_p))
674      {
675        /* Clean up invitefield */
676        DLINK_FOREACH_SAFE(lp, next_lp, source_p->localClient->invited.head)
# Line 768 | Line 679 | exit_one_client(struct Client *source_p,
679        del_all_accepts(source_p);
680      }
681    }
682 +  else if (IsServer(source_p))
683 +  {
684 +    dlinkDelete(&source_p->lnode, &source_p->servptr->serv->server_list);
685 +
686 +    if ((lp = dlinkFindDelete(&global_serv_list, source_p)) != NULL)
687 +      free_dlink_node(lp);
688 +  }
689  
690    /* Remove source_p from the client lists */
691    if (HasID(source_p))
# Line 807 | Line 725 | exit_one_client(struct Client *source_p,
725   static void
726   recurse_send_quits(struct Client *original_source_p, struct Client *source_p,
727                     struct Client *from, struct Client *to, const char *comment,
728 <                   const char *splitstr, const char *myname)
728 >                   const char *splitstr)
729   {
730    dlink_node *ptr, *next;
731    struct Client *target_p;
814 –  int hidden = match(myname, source_p->name);
732  
733    assert(to != source_p);  /* should be already removed from serv_list */
734  
735    /* If this server can handle quit storm (QS) removal
736     * of dependents, just send the SQUIT
820 –   *
821 –   * Always check *all* dependent servers if some of them are
822 –   * hidden behind fakename. If so, send out the QUITs -adx
737     */
738 <  if (hidden || !IsCapable(to, CAP_QS))
739 <    DLINK_FOREACH_SAFE(ptr, next, source_p->serv->users.head)
738 >  if (!IsCapable(to, CAP_QS))
739 >    DLINK_FOREACH_SAFE(ptr, next, source_p->serv->client_list.head)
740      {
741        target_p = ptr->data;
742        sendto_one(to, ":%s QUIT :%s", target_p->name, splitstr);
743      }
744  
745 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->servers.head)
745 >  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->server_list.head)
746      recurse_send_quits(original_source_p, ptr->data, from, to,
747 <                       comment, splitstr, myname);
747 >                       comment, splitstr);
748  
749 <  if (!hidden && ((source_p == original_source_p && to != from) ||
750 <                  !IsCapable(to, CAP_QS)))
749 >  if ((source_p == original_source_p && to != from) ||
750 >                  !IsCapable(to, CAP_QS))
751    {
752      /* don't use a prefix here - we have to be 100% sure the message
753       * will be accepted without Unknown prefix etc.. */
# Line 841 | Line 755 | recurse_send_quits(struct Client *origin
755    }
756   }
757  
758 < /*
758 > /*
759   * Remove all clients that depend on source_p; assumes all (S)QUITs have
760 < * already been sent.  we make sure to exit a server's dependent clients
761 < * and servers before the server itself; exit_one_client takes care of
760 > * already been sent.  we make sure to exit a server's dependent clients
761 > * and servers before the server itself; exit_one_client takes care of
762   * actually removing things off llists.   tweaked from +CSr31  -orabidoo
763   */
764   static void
# Line 852 | Line 766 | recurse_remove_clients(struct Client *so
766   {
767    dlink_node *ptr, *next;
768  
769 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->users.head)
769 >  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->client_list.head)
770      exit_one_client(ptr->data, quitmsg);
771  
772 <  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->servers.head)
772 >  DLINK_FOREACH_SAFE(ptr, next, source_p->serv->server_list.head)
773    {
774      recurse_remove_clients(ptr->data, quitmsg);
775      exit_one_client(ptr->data, quitmsg);
776    }
863 –
864 –  assert(source_p->serv->dep_servers == 1);
865 –  assert(source_p->serv->dep_users == 0);
777   }
778  
779   /*
# Line 874 | Line 785 | static void
785   remove_dependents(struct Client *source_p, struct Client *from,
786                    const char *comment, const char *splitstr)
787   {
788 <  struct Client *to;
878 <  struct ConfItem *conf;
879 <  static char myname[HOSTLEN+1];
880 <  dlink_node *ptr;
788 >  dlink_node *ptr = NULL;
789  
790    DLINK_FOREACH(ptr, serv_list.head)
791 <  {
792 <    to = ptr->data;
885 <
886 <    if ((conf = to->serv->sconf) != NULL)
887 <      strlcpy(myname, my_name_for_link(conf), sizeof(myname));
888 <    else
889 <      strlcpy(myname, me.name, sizeof(myname));
890 <    recurse_send_quits(source_p, source_p, from, to,
891 <                       comment, splitstr, myname);
892 <  }
791 >    recurse_send_quits(source_p, source_p, from, ptr->data,
792 >                       comment, splitstr);
793  
794    recurse_remove_clients(source_p, splitstr);
795   }
# Line 899 | Line 799 | remove_dependents(struct Client *source_
799   * this on any struct Client, regardless of its state.
800   *
801   * Note, you shouldn't exit remote _users_ without first doing
802 < * SetKilled and propagating a kill or similar message. However,
803 < * it is perfectly correct to call exit_client to force a _server_
802 > * AddFlag(x, FLAGS_KILLED) and propagating a kill or similar message.
803 > * However, it is perfectly correct to call exit_client to force a _server_
804   * quit (either local or remote one).
805   *
806   * inputs:       - a client pointer that is going to be exited
# Line 915 | Line 815 | remove_dependents(struct Client *source_
815   void
816   exit_client(struct Client *source_p, struct Client *from, const char *comment)
817   {
818 <  dlink_node *m;
818 >  dlink_node *m = NULL;
819  
820    if (MyConnect(source_p))
821    {
# Line 930 | Line 830 | exit_client(struct Client *source_p, str
830      if (IsIpHash(source_p))
831        remove_one_ip(&source_p->localClient->ip);
832  
833 <    delete_auth(source_p);
833 >    delete_auth(&source_p->localClient->auth);
834  
835 <    /* This source_p could have status of one of STAT_UNKNOWN, STAT_CONNECTING
835 >    /*
836 >     * This source_p could have status of one of STAT_UNKNOWN, STAT_CONNECTING
837       * STAT_HANDSHAKE or STAT_UNKNOWN
838       * all of which are lumped together into unknown_list
839       *
# Line 940 | Line 841 | exit_client(struct Client *source_p, str
841       */
842      if (!IsRegistered(source_p))
843      {
844 <      if ((m = dlinkFindDelete(&unknown_list, source_p)) != NULL)
845 <        free_dlink_node(m);
844 >      assert(dlinkFind(&unknown_list, source_p));
845 >
846 >      dlinkDelete(&source_p->localClient->lclient_node, &unknown_list);
847      }
848      else if (IsClient(source_p))
849      {
850 +      time_t on_for = CurrentTime - source_p->localClient->firsttime;
851 +      assert(Count.local > 0);
852        Count.local--;
853  
854 <      if (IsOper(source_p))
951 <      {
854 >      if (HasUMode(source_p, UMODE_OPER))
855          if ((m = dlinkFindDelete(&oper_list, source_p)) != NULL)
856            free_dlink_node(m);
954 –      }
857  
858 +      assert(dlinkFind(&local_client_list, source_p));
859        dlinkDelete(&source_p->localClient->lclient_node, &local_client_list);
860 +
861        if (source_p->localClient->list_task != NULL)
862          free_list_task(source_p->localClient->list_task, source_p);
863  
864        watch_del_watch_list(source_p);
865 <      sendto_realops_flags(UMODE_CCONN, L_ALL, "Client exiting: %s (%s@%s) [%s] [%s]",
865 >      sendto_realops_flags(UMODE_CCONN, L_ALL, SEND_NOTICE,
866 >                           "Client exiting: %s (%s@%s) [%s] [%s]",
867                             source_p->name, source_p->username, source_p->host, comment,
868                             ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
869                             "255.255.255.255" : source_p->sockhost);
870 <      sendto_realops_flags(UMODE_CCONN_FULL, L_ALL, "CLIEXIT: %s %s %s %s 0 %s",
871 <                           source_p->name,
872 <                           source_p->username,
873 <                           source_p->host,
874 <
875 <                           ConfigFileEntry.hide_spoof_ips && IsIPSpoof(source_p) ?
876 <                           "255.255.255.255" : source_p->sockhost,
877 <                           comment);
878 <    }
879 <
880 <    /* As soon as a client is known to be a server of some sort
881 <     * it has to be put on the serv_list, or SJOIN's to this new server
882 <     * from the connect burst will not be seen.
883 <     */
884 <    if (IsServer(source_p) || IsConnecting(source_p) ||
980 <        IsHandshake(source_p))
981 <    {
982 <      if ((m = dlinkFindDelete(&serv_list, source_p)) != NULL)
983 <      {
984 <        free_dlink_node(m);
985 <        unset_chcap_usage_counts(source_p);
986 <      }
987 <
988 <      if (IsServer(source_p))
989 <        Count.myserver--;
870 >      ilog(LOG_TYPE_USER, "%s (%3u:%02u:%02u): %s!%s@%s %llu/%llu",
871 >           myctime(source_p->localClient->firsttime), (unsigned int)(on_for / 3600),
872 >           (unsigned int)((on_for % 3600)/60), (unsigned int)(on_for % 60),
873 >           source_p->name, source_p->username, source_p->host,
874 >           source_p->localClient->send.bytes>>10,
875 >           source_p->localClient->recv.bytes>>10);
876 >    }
877 >    else if (IsServer(source_p))
878 >    {
879 >      assert(Count.myserver > 0);
880 >      --Count.myserver;
881 >
882 >      assert(dlinkFind(&serv_list, source_p));
883 >      dlinkDelete(&source_p->localClient->lclient_node, &serv_list);
884 >      unset_chcap_usage_counts(source_p);
885      }
886  
992 –    log_user_exit(source_p);
993 –
887      if (!IsDead(source_p))
888      {
889        if (IsServer(source_p))
890        {
891          /* for them, we are exiting the network */
892          sendto_one(source_p, ":%s SQUIT %s :%s",
893 <                   ID_or_name(from, source_p), me.name, comment);
893 >                   ID_or_name(from, source_p), me.name, comment);
894        }
895  
896        sendto_one(source_p, "ERROR :Closing Link: %s (%s)",
# Line 1017 | Line 910 | exit_client(struct Client *source_p, str
910      */
911      close_connection(source_p);
912    }
913 +  else if (IsClient(source_p) && HasFlag(source_p->servptr, FLAGS_EOB))
914 +    sendto_realops_flags(UMODE_FARCONNECT, L_ALL, SEND_NOTICE,
915 +                         "Client exiting at %s: %s (%s@%s) [%s]",
916 +                         source_p->servptr->name, source_p->name,
917 +                         source_p->username, source_p->host, comment);
918  
919    if (IsServer(source_p))
920    {
# Line 1027 | Line 925 | exit_client(struct Client *source_p, str
925  
926      if (ConfigServerHide.hide_servers)
927        /*
928 <       * Set netsplit message to "*.net *.split" to still show
928 >       * Set netsplit message to "*.net *.split" to still show
929         * that its a split, but hide the servers splitting
930         */
931        strcpy(splitstr, "*.net *.split");
# Line 1039 | Line 937 | exit_client(struct Client *source_p, str
937  
938      if (source_p->servptr == &me)
939      {
940 <      sendto_realops_flags(UMODE_ALL, L_ALL,
940 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
941                             "%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
942 <                           source_p->name, (int)(CurrentTime - source_p->firsttime),
942 >                           source_p->name, (int)(CurrentTime - source_p->localClient->firsttime),
943                             source_p->localClient->send.bytes >> 10,
944                             source_p->localClient->recv.bytes >> 10);
945 <      ilog(L_NOTICE, "%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
946 <           source_p->name, (int)(CurrentTime - source_p->firsttime),
945 >      ilog(LOG_TYPE_IRCD, "%s was connected for %d seconds.  %llu/%llu sendK/recvK.",
946 >           source_p->name, (int)(CurrentTime - source_p->localClient->firsttime),
947             source_p->localClient->send.bytes >> 10,
948             source_p->localClient->recv.bytes >> 10);
949      }
950    }
951 <  else if (IsClient(source_p) && !IsKilled(source_p))
951 >  else if (IsClient(source_p) && !HasFlag(source_p, FLAGS_KILLED))
952    {
953 <    sendto_server(from->from, NULL, CAP_TS6, NOCAPS,
953 >    sendto_server(from->from, CAP_TS6, NOCAPS,
954                    ":%s QUIT :%s", ID(source_p), comment);
955 <    sendto_server(from->from, NULL, NOCAPS, CAP_TS6,
955 >    sendto_server(from->from, NOCAPS, CAP_TS6,
956                    ":%s QUIT :%s", source_p->name, comment);
957    }
958  
# Line 1100 | Line 998 | dead_link_on_write(struct Client *client
998   void
999   dead_link_on_read(struct Client *client_p, int error)
1000   {
1001 <  char errmsg[255];
1001 >  char errmsg[IRCD_BUFSIZE];
1002    int current_error;
1003  
1004    if (IsDefunct(client_p))
# Line 1113 | Line 1011 | dead_link_on_read(struct Client *client_
1011  
1012    if (IsServer(client_p) || IsHandshake(client_p))
1013    {
1014 <    int connected = CurrentTime - client_p->firsttime;
1015 <      
1014 >    int connected = CurrentTime - client_p->localClient->firsttime;
1015 >
1016      if (error == 0)
1017      {
1018        /* Admins get the real IP */
1019 <      sendto_realops_flags(UMODE_ALL, L_ADMIN,
1020 <                           "Server %s closed the connection",
1021 <                           get_client_name(client_p, SHOW_IP));
1019 >      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1020 >                           "Server %s closed the connection",
1021 >                           get_client_name(client_p, SHOW_IP));
1022  
1023        /* Opers get a masked IP */
1024 <      sendto_realops_flags(UMODE_ALL, L_OPER,
1025 <                           "Server %s closed the connection",
1026 <                           get_client_name(client_p, MASK_IP));
1024 >      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
1025 >                           "Server %s closed the connection",
1026 >                           get_client_name(client_p, MASK_IP));
1027  
1028 <      ilog(L_NOTICE, "Server %s closed the connection",
1029 <           get_client_name(client_p, SHOW_IP));
1028 >      ilog(LOG_TYPE_IRCD, "Server %s closed the connection",
1029 >           get_client_name(client_p, SHOW_IP));
1030      }
1031      else
1032      {
1033        report_error(L_ADMIN, "Lost connection to %s: %s",
1034 <                   get_client_name(client_p, SHOW_IP), current_error);
1034 >                   get_client_name(client_p, SHOW_IP), current_error);
1035        report_error(L_OPER, "Lost connection to %s: %s",
1036 <                   get_client_name(client_p, MASK_IP), current_error);
1036 >                   get_client_name(client_p, MASK_IP), current_error);
1037      }
1038  
1039 <    sendto_realops_flags(UMODE_ALL, L_ALL,
1040 <                         "%s had been connected for %d day%s, %2d:%02d:%02d",
1041 <                         client_p->name, connected/86400,
1042 <                         (connected/86400 == 1) ? "" : "s",
1043 <                         (connected % 86400) / 3600, (connected % 3600) / 60,
1044 <                         connected % 60);
1039 >    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1040 >                         "%s had been connected for %d day%s, %2d:%02d:%02d",
1041 >                         client_p->name, connected/86400,
1042 >                         (connected/86400 == 1) ? "" : "s",
1043 >                         (connected % 86400) / 3600, (connected % 3600) / 60,
1044 >                         connected % 60);
1045    }
1046  
1047    if (error == 0)
1048      strlcpy(errmsg, "Remote host closed the connection",
1049              sizeof(errmsg));
1050    else
1051 <    ircsprintf(errmsg, "Read error: %s",
1052 <               strerror(current_error));
1051 >    snprintf(errmsg, sizeof(errmsg), "Read error: %s",
1052 >             strerror(current_error));
1053  
1054    exit_client(client_p, &me, errmsg);
1055   }
# Line 1170 | Line 1068 | exit_aborted_clients(void)
1068  
1069      if (target_p == NULL)
1070      {
1071 <      sendto_realops_flags(UMODE_ALL, L_ALL,
1071 >      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
1072                             "Warning: null client on abort_list!");
1073        dlinkDelete(ptr, &abort_list);
1074        free_dlink_node(ptr);
# Line 1184 | Line 1082 | exit_aborted_clients(void)
1082      else
1083        notice = "Write error: connection closed";
1084  
1085 <    exit_client(target_p, &me, notice);  
1085 >    exit_client(target_p, &me, notice);
1086      free_dlink_node(ptr);
1087    }
1088   }
# Line 1212 | Line 1110 | del_accept(struct split_nuh_item *accept
1110  
1111   struct split_nuh_item *
1112   find_accept(const char *nick, const char *user,
1113 <            const char *host, struct Client *client_p, int do_match)
1113 >            const char *host, struct Client *client_p,
1114 >            int (*cmpfunc)(const char *, const char *))
1115   {
1116    dlink_node *ptr = NULL;
1218 –  /* XXX We wouldn't need that if match() would return 0 on match */
1219 –  int (*cmpfunc)(const char *, const char *) = do_match ? match : irccmp;
1117  
1118    DLINK_FOREACH(ptr, client_p->localClient->acceptlist.head)
1119    {
1120      struct split_nuh_item *accept_p = ptr->data;
1121  
1122 <    if (cmpfunc(accept_p->nickptr, nick) == do_match &&
1123 <        cmpfunc(accept_p->userptr, user) == do_match &&
1124 <        cmpfunc(accept_p->hostptr, host) == do_match)
1122 >    if (!cmpfunc(accept_p->nickptr, nick) &&
1123 >        !cmpfunc(accept_p->userptr, user) &&
1124 >        !cmpfunc(accept_p->hostptr, host))
1125        return accept_p;
1126    }
1127  
# Line 1245 | Line 1142 | accept_message(struct Client *source,
1142    dlink_node *ptr = NULL;
1143  
1144    if (source == target || find_accept(source->name, source->username,
1145 <                                      source->host, target, 1))
1145 >                                      source->host, target, match))
1146      return 1;
1147  
1148 <  if (IsSoftCallerId(target))
1148 >  if (HasUMode(target, UMODE_SOFTCALLERID))
1149      DLINK_FOREACH(ptr, target->channel.head)
1150        if (IsMember(source, ((struct Membership *)ptr->data)->chptr))
1151          return 1;
# Line 1271 | Line 1168 | del_all_accepts(struct Client *client_p)
1168      del_accept(ptr->data, client_p);
1169   }
1170  
1171 < /* set_initial_nick()
1172 < *
1276 < * inputs
1277 < * output
1278 < * side effects -
1279 < *
1280 < * This function is only called to set up an initially registering
1281 < * client.
1282 < */
1283 < void
1284 < set_initial_nick(struct Client *client_p, struct Client *source_p,
1285 <                 const char *nick)
1171 > unsigned int
1172 > idle_time_get(const struct Client *source_p, const struct Client *target_p)
1173   {
1174 < char buf[USERLEN + 1];
1175 <
1176 <  /* Client setting NICK the first time */
1177 <  
1178 <  /* This had to be copied here to avoid problems.. */
1179 <  source_p->tsinfo = CurrentTime;
1180 <  source_p->localClient->registration &= ~REG_NEED_NICK;
1181 <
1182 <  if (source_p->name[0])
1183 <    hash_del_client(source_p);
1174 >  unsigned int idle = 0;
1175 >  unsigned int min_idle = 0;
1176 >  unsigned int max_idle = 0;
1177 >  const struct ClassItem *class = get_class_ptr(&target_p->localClient->confs);
1178 >
1179 >  if (!(class->flags & CLASS_FLAGS_FAKE_IDLE) || target_p == source_p)
1180 >    return CurrentTime - target_p->localClient->last_privmsg;
1181 >  if (HasUMode(source_p, UMODE_OPER) &&
1182 >      !(class->flags & CLASS_FLAGS_HIDE_IDLE_FROM_OPERS))
1183 >    return CurrentTime - target_p->localClient->last_privmsg;
1184  
1185 <  strlcpy(source_p->name, nick, sizeof(source_p->name));
1186 <  hash_add_client(source_p);
1185 >  min_idle = class->min_idle;
1186 >  max_idle = class->max_idle;
1187  
1188 <  /* fd_desc is long enough */
1189 <  fd_note(&client_p->localClient->fd, "Nick: %s", nick);
1303 <  
1304 <  if (!source_p->localClient->registration)
1305 <  {
1306 <    strlcpy(buf, source_p->username, sizeof(buf));
1188 >  if (min_idle == max_idle)
1189 >    return min_idle;
1190  
1191 <    /*
1192 <     * USER already received, now we have NICK.
1193 <     * *NOTE* For servers "NICK" *must* precede the
1194 <     * user message (giving USER before NICK is possible
1312 <     * only for local client connection!). register_user
1313 <     * may reject the client and call exit_client for it
1314 <     * --must test this and exit m_nick too!!!
1315 <     */
1316 <    register_local_user(client_p, source_p, nick, buf);
1317 <  }
1318 < }
1319 <
1320 < /* change_local_nick()
1321 < *
1322 < * inputs       - pointer to server
1323 < *              - pointer to client
1324 < *              - nick
1325 < * output       -
1326 < * side effects - changes nick of a LOCAL user
1327 < */
1328 < void
1329 < change_local_nick(struct Client *client_p, struct Client *source_p, const char *nick)
1330 < {
1331 <  int samenick = 0;
1332 <
1333 <  assert(source_p->name[0] && !EmptyString(nick));
1334 <
1335 <  /*
1336 <   * Client just changing his/her nick. If he/she is
1337 <   * on a channel, send note of change to all clients
1338 <   * on that channel. Propagate notice to other servers.
1339 <   */
1340 <  if ((source_p->localClient->last_nick_change +
1341 <       ConfigFileEntry.max_nick_time) < CurrentTime)
1342 <    source_p->localClient->number_of_nick_changes = 0;
1343 <  source_p->localClient->last_nick_change = CurrentTime;
1344 <  source_p->localClient->number_of_nick_changes++;
1345 <
1346 <  if ((ConfigFileEntry.anti_nick_flood &&
1347 <      (source_p->localClient->number_of_nick_changes
1348 <       <= ConfigFileEntry.max_nick_changes)) ||
1349 <     !ConfigFileEntry.anti_nick_flood ||
1350 <     (IsOper(source_p) && ConfigFileEntry.no_oper_flood))
1351 <  {
1352 <    samenick = !irccmp(source_p->name, nick);
1353 <
1354 <    if (!samenick)
1355 <    {
1356 <      source_p->tsinfo = CurrentTime;
1357 <      clear_ban_cache_client(source_p);
1358 <      watch_check_hash(source_p, RPL_LOGOFF);
1359 <    }
1360 <
1361 <    /* XXX - the format of this notice should eventually be changed
1362 <     * to either %s[%s@%s], or even better would be get_client_name() -bill
1363 <     */
1364 <    sendto_realops_flags(UMODE_NCHANGE, L_ALL, "Nick change: From %s to %s [%s@%s]",
1365 <                         source_p->name, nick, source_p->username, source_p->host);
1366 <    sendto_common_channels_local(source_p, 1, ":%s!%s@%s NICK :%s",
1367 <                                 source_p->name, source_p->username,
1368 <                                 source_p->host, nick);
1369 <    add_history(source_p, 1);
1370 <
1371 <    sendto_server(client_p, NULL, CAP_TS6, NOCAPS,
1372 <                  ":%s NICK %s :%lu",
1373 <                  ID(source_p), nick, (unsigned long)source_p->tsinfo);
1374 <    sendto_server(client_p, NULL, NOCAPS, CAP_TS6,
1375 <                  ":%s NICK %s :%lu",
1376 <                  source_p->name, nick, (unsigned long)source_p->tsinfo);
1191 >  if (class->flags & CLASS_FLAGS_RANDOM_IDLE)
1192 >    idle = genrand_int32();
1193 >  else
1194 >    idle = CurrentTime - target_p->localClient->last_privmsg;
1195  
1196 <    hash_del_client(source_p);
1197 <    strcpy(source_p->name, nick);
1198 <    hash_add_client(source_p);
1196 >  if (max_idle == 0)
1197 >    idle = 0;
1198 >  else
1199 >    idle %= max_idle;
1200  
1201 <    if (!samenick)
1202 <      watch_check_hash(source_p, RPL_LOGON);
1201 >  if (idle < min_idle)
1202 >    idle = min_idle + (idle % (max_idle - min_idle));
1203  
1204 <    /* fd_desc is long enough */
1386 <    fd_note(&client_p->localClient->fd, "Nick: %s", nick);
1387 <  }
1388 <  else
1389 <    sendto_one(source_p, form_str(ERR_NICKTOOFAST),
1390 <               me.name, source_p->name, source_p->name,
1391 <               nick, ConfigFileEntry.max_nick_time);
1204 >  return idle;
1205   }

Diff Legend

– Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)