ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/branches/8.2.x/src/server.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_serv.c (file contents), Revision 2463 by michael, Sat Aug 17 20:38:00 2013 UTC vs.
ircd-hybrid/branches/8.2.x/src/server.c (file contents), Revision 5459 by michael, Tue Feb 3 22:24:23 2015 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_serv.c: Server related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2005 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2015 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 16 | Line 15
15   *
16   *  You should have received a copy of the GNU General Public License
17   *  along with this program; if not, write to the Free Software
18 < *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
18 > *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file s_serv.c
23 > * \brief Server related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
# Line 28 | Line 30
30   #include "rsa.h"
31   #endif
32   #include "list.h"
31 #include "channel.h"
32 #include "channel_mode.h"
33   #include "client.h"
34 #include "dbuf.h"
34   #include "event.h"
36 #include "fdlist.h"
35   #include "hash.h"
36   #include "irc_string.h"
37   #include "ircd.h"
# Line 41 | Line 39
39   #include "s_bsd.h"
40   #include "numeric.h"
41   #include "packet.h"
44 #include "irc_res.h"
42   #include "conf.h"
43 < #include "s_serv.h"
43 > #include "server.h"
44   #include "log.h"
45 < #include "s_misc.h"
49 < #include "s_user.h"
45 > #include "user.h"
46   #include "send.h"
47   #include "memory.h"
48 < #include "channel.h" /* chcap_usage_counts stuff...*/
48 > #include "channel.h"
49   #include "parse.h"
50  
51   #define MIN_CONN_FREQ 300
52  
53   dlink_list flatten_links;
54 < static dlink_list cap_list = { NULL, NULL, 0 };
55 < static void server_burst(struct Client *);
60 < static void burst_all(struct Client *);
61 < static void send_tb(struct Client *client_p, struct Channel *chptr);
62 <
63 < static CNCB serv_connect_callback;
54 > static dlink_list cap_list;
55 > static void serv_connect_callback(fde_t *, int, void *);
56  
65 static void burst_members(struct Client *, struct Channel *);
57  
58   /*
59   * write_links_file
# Line 73 | Line 64 | static void burst_members(struct Client
64   *                but in no particular order.
65   */
66   void
67 < write_links_file(void *notused)
67 > write_links_file(void *unused)
68   {
69    FILE *file = NULL;
70 <  dlink_node *ptr = NULL, *ptr_next = NULL;
71 <  char buff[IRCD_BUFSIZE] = { '\0' };
70 >  dlink_node *node = NULL, *node_next = NULL;
71 >  char buff[IRCD_BUFSIZE] = "";
72  
73    if ((file = fopen(LIPATH, "w")) == NULL)
74      return;
75  
76 <  DLINK_FOREACH_SAFE(ptr, ptr_next, flatten_links.head)
76 >  DLINK_FOREACH_SAFE(node, node_next, flatten_links.head)
77    {
78 <    dlinkDelete(ptr, &flatten_links);
79 <    MyFree(ptr->data);
80 <    free_dlink_node(ptr);
78 >    dlinkDelete(node, &flatten_links);
79 >    MyFree(node->data);
80 >    free_dlink_node(node);
81    }
82  
83 <  DLINK_FOREACH(ptr, global_serv_list.head)
83 >  DLINK_FOREACH(node, global_server_list.head)
84    {
85 <    const struct Client *target_p = ptr->data;
85 >    const struct Client *target_p = node->data;
86  
87      /*
88       * Skip hidden servers, aswell as ourselves, since we already send
# Line 126 | Line 117 | read_links_file(void)
117   {
118    FILE *file = NULL;
119    char *p = NULL;
120 <  char buff[IRCD_BUFSIZE] = { '\0' };
120 >  char buff[IRCD_BUFSIZE] = "";
121  
122    if ((file = fopen(LIPATH, "r")) == NULL)
123      return;
124  
125    while (fgets(buff, sizeof(buff), file))
126    {
127 <    if ((p = strchr(buff, '\n')) != NULL)
127 >    if ((p = strchr(buff, '\n')))
128        *p = '\0';
129  
130      dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
# Line 162 | Line 153 | read_links_file(void)
153   *      returns: (see #defines)
154   */
155   int
156 < hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
156 > hunt_server(struct Client *source_p, const char *command,
157              const int server, const int parc, char *parv[])
158   {
159    struct Client *target_p = NULL;
160 <  struct Client *target_tmp = NULL;
170 <  dlink_node *ptr;
171 <  int wilds;
160 >  dlink_node *node = NULL;
161  
162    /* Assume it's me, if no server */
163    if (parc <= server || EmptyString(parv[server]))
164      return HUNTED_ISME;
165  
166 <  if (!strcmp(parv[server], me.id) || !match(parv[server], me.name))
167 <    return HUNTED_ISME;
166 >  if ((target_p = find_person(source_p, parv[server])) == NULL)
167 >    target_p = hash_find_server(parv[server]);
168  
169 <  /* These are to pickup matches that would cause the following
169 >  /*
170 >   * These are to pickup matches that would cause the following
171     * message to go in the wrong direction while doing quick fast
172     * non-matching lookups.
173     */
184  if (MyClient(source_p))
185    target_p = hash_find_client(parv[server]);
186  else
187    target_p = find_person(client_p, parv[server]);
188
174    if (target_p)
175      if (target_p->from == source_p->from && !MyConnect(target_p))
176        target_p = NULL;
177  
178 <  if (target_p == NULL && (target_p = hash_find_server(parv[server])))
194 <    if (target_p->from == source_p->from && !MyConnect(target_p))
195 <      target_p = NULL;
196 <
197 <  wilds = has_wildcards(parv[server]);
198 <
199 <  /* Again, if there are no wild cards involved in the server
200 <   * name, use the hash lookup
201 <   */
202 <  if (target_p == NULL)
178 >  if (!target_p && has_wildcards(parv[server]))
179    {
180 <    if (!wilds)
180 >    DLINK_FOREACH(node, global_client_list.head)
181      {
182 <      if (!(target_p = hash_find_server(parv[server])))
207 <      {
208 <        sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
209 <                   me.name, source_p->name, parv[server]);
210 <        return HUNTED_NOSUCH;
211 <      }
212 <    }
213 <    else
214 <    {
215 <      DLINK_FOREACH(ptr, global_client_list.head)
216 <      {
217 <        target_tmp = ptr->data;
182 >      struct Client *tmp = node->data;
183  
184 <        if (!match(parv[server], target_tmp->name))
185 <        {
186 <          if (target_tmp->from == source_p->from && !MyConnect(target_tmp))
187 <            continue;
188 <          target_p = ptr->data;
184 >      assert(IsMe(tmp) || IsServer(tmp) || IsClient(tmp));
185 >      if (!match(parv[server], tmp->name))
186 >      {
187 >        if (tmp->from == source_p->from && !MyConnect(tmp))
188 >          continue;
189  
190 <          if (IsRegistered(target_p) && (target_p != client_p))
191 <            break;
227 <        }
190 >        target_p = node->data;
191 >        break;
192        }
193      }
194    }
195  
196 <  if (target_p != NULL)
196 >  if (target_p)
197    {
198 <    if(!IsRegistered(target_p))
235 <    {
236 <      sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
237 <                 me.name, source_p->name, parv[server]);
238 <      return HUNTED_NOSUCH;
239 <    }
240 <
198 >    assert(IsMe(target_p) || IsServer(target_p) || IsClient(target_p));
199      if (IsMe(target_p) || MyClient(target_p))
200        return HUNTED_ISME;
201  
202 <    if (match(target_p->name, parv[server]))
203 <      parv[server] = target_p->name;
246 <
247 <    /* This is a little kludgy but should work... */
248 <    if (IsClient(source_p) &&
249 <        ((MyConnect(target_p) && IsCapable(target_p, CAP_TS6)) ||
250 <         (!MyConnect(target_p) && IsCapable(target_p->from, CAP_TS6))))
251 <      parv[0] = ID(source_p);
252 <
253 <    sendto_one(target_p, command, parv[0],
202 >    parv[server] = target_p->id;
203 >    sendto_one(target_p, command, source_p->id,
204                 parv[1], parv[2], parv[3], parv[4],
205                 parv[5], parv[6], parv[7], parv[8]);
206      return HUNTED_PASS;
207    }
208  
209 <  sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
260 <             me.name, source_p->name, parv[server]);
209 >  sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
210    return HUNTED_NOSUCH;
211   }
212  
# Line 274 | Line 223 | hunt_server(struct Client *client_p, str
223   void
224   try_connections(void *unused)
225   {
226 <  dlink_node *ptr = NULL;
227 <  struct MaskItem *conf;
279 <  int confrq;
226 >  dlink_node *node = NULL;
227 >  int confrq = 0;
228  
229    /* TODO: change this to set active flag to 0 when added to event! --Habeeb */
230    if (GlobalSetOptions.autoconn == 0)
231      return;
232  
233 <  DLINK_FOREACH(ptr, server_items.head)
233 >  DLINK_FOREACH(node, server_items.head)
234    {
235 <    conf = ptr->data;
235 >    struct MaskItem *conf = node->data;
236  
237      assert(conf->type == CONF_SERVER);
238  
239      /* Also when already connecting! (update holdtimes) --SRB
240       */
241 <    if (!conf->port ||!IsConfAllowAutoConn(conf))
241 >    if (!conf->port || !IsConfAllowAutoConn(conf))
242        continue;
243  
244  
# Line 303 | Line 251 | try_connections(void *unused)
251      if (conf->until > CurrentTime)
252        continue;
253  
254 <    if (conf->class == NULL)
255 <      confrq = DEFAULT_CONNECTFREQUENCY;
256 <    else
257 <    {
258 <      confrq = conf->class->con_freq;
311 <      if (confrq < MIN_CONN_FREQ)
312 <        confrq = MIN_CONN_FREQ;
313 <    }
254 >    assert(conf->class);
255 >
256 >    confrq = conf->class->con_freq;
257 >    if (confrq < MIN_CONN_FREQ)
258 >      confrq = MIN_CONN_FREQ;
259  
260      conf->until = CurrentTime + confrq;
261  
262 <    /* Found a CONNECT config with port specified, scan clients
262 >    /*
263 >     * Found a CONNECT config with port specified, scan clients
264       * and see if this server is already connected?
265       */
266 <    if (hash_find_server(conf->name) != NULL)
266 >    if (hash_find_server(conf->name))
267        continue;
268  
269      if (conf->class->ref_count < conf->class->max_total)
270      {
271        /* Go to the end of the list, if not already last */
272 <      if (ptr->next != NULL)
272 >      if (node->next)
273        {
274 <        dlinkDelete(ptr, &server_items);
274 >        dlinkDelete(node, &server_items);
275          dlinkAddTail(conf, &conf->node, &server_items);
276        }
277  
278        if (find_servconn_in_progress(conf->name))
279          return;
280  
281 <      /* We used to only print this if serv_connect() actually
281 >      /*
282 >       * We used to only print this if serv_connect() actually
283         * succeeded, but since comm_tcp_connect() can call the callback
284         * immediately if there is an error, we were getting error messages
285         * in the wrong order. SO, we just print out the activated line,
# Line 359 | Line 306 | try_connections(void *unused)
306   int
307   valid_servname(const char *name)
308   {
309 <  unsigned int length = 0;
363 <  unsigned int dots   = 0;
309 >  unsigned int dots = 0;
310    const char *p = name;
311  
312    for (; *p; ++p)
# Line 368 | Line 314 | valid_servname(const char *name)
314      if (!IsServChar(*p))
315        return 0;
316  
371    ++length;
372
317      if (*p == '.')
318        ++dots;
319    }
320  
321 <  return dots != 0 && length <= HOSTLEN;
321 >  return dots && (p - name) <= HOSTLEN;
322   }
323  
324   int
325   check_server(const char *name, struct Client *client_p)
326   {
327 <  dlink_node *ptr;
327 >  dlink_node *node = NULL;
328    struct MaskItem *conf        = NULL;
329    struct MaskItem *server_conf = NULL;
330    int error = -1;
331  
332 <  assert(client_p != NULL);
332 >  assert(client_p);
333  
334    /* loop through looking for all possible connect items that might work */
335 <  DLINK_FOREACH(ptr, server_items.head)
335 >  DLINK_FOREACH(node, server_items.head)
336    {
337 <    conf = ptr->data;
337 >    conf = node->data;
338  
339      if (match(name, conf->name))
340        continue;
# Line 404 | Line 348 | check_server(const char *name, struct Cl
348      {
349        error = -2;
350  
351 <      if (!match_conf_password(client_p->localClient->passwd, conf))
351 >      if (!match_conf_password(client_p->connection->password, conf))
352          return -2;
353  
354        if (!EmptyString(conf->certfp))
# Line 421 | Line 365 | check_server(const char *name, struct Cl
365    attach_conf(client_p, server_conf);
366  
367  
368 <  if (server_conf != NULL)
368 >  if (server_conf)
369    {
370      struct sockaddr_in *v4;
427 #ifdef IPV6
371      struct sockaddr_in6 *v6;
372 < #endif
372 >
373      switch (server_conf->aftype)
374      {
432 #ifdef IPV6
375        case AF_INET6:
376          v6 = (struct sockaddr_in6 *)&server_conf->addr;
377  
378          if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
379 <          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
379 >          memcpy(&server_conf->addr, &client_p->connection->ip, sizeof(struct irc_ssaddr));
380          break;
439 #endif
381        case AF_INET:
382          v4 = (struct sockaddr_in *)&server_conf->addr;
383  
384          if (v4->sin_addr.s_addr == INADDR_NONE)
385 <          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
385 >          memcpy(&server_conf->addr, &client_p->connection->ip, sizeof(struct irc_ssaddr));
386          break;
387      }
388    }
# Line 461 | Line 402 | check_server(const char *name, struct Cl
402   void
403   add_capability(const char *capab_name, int cap_flag, int add_to_default)
404   {
405 <  struct Capability *cap = MyMalloc(sizeof(*cap));
405 >  struct Capability *cap = MyCalloc(sizeof(*cap));
406  
407    cap->name = xstrdup(capab_name);
408    cap->cap = cap_flag;
# Line 480 | Line 421 | add_capability(const char *capab_name, i
421   int
422   delete_capability(const char *capab_name)
423   {
424 <  dlink_node *ptr;
484 <  dlink_node *next_ptr;
485 <  struct Capability *cap;
424 >  dlink_node *node = NULL, *node_next = NULL;
425  
426 <  DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
426 >  DLINK_FOREACH_SAFE(node, node_next, cap_list.head)
427    {
428 <    cap = ptr->data;
428 >    struct Capability *cap = node->data;
429  
430 <    if (cap->cap != 0)
430 >    if (cap->cap)
431      {
432 <      if (irccmp(cap->name, capab_name) == 0)
432 >      if (!irccmp(cap->name, capab_name))
433        {
434          default_server_capabs &= ~(cap->cap);
435 <        dlinkDelete(ptr, &cap_list);
435 >        dlinkDelete(node, &cap_list);
436          MyFree(cap->name);
437          MyFree(cap);
438        }
# Line 513 | Line 452 | delete_capability(const char *capab_name
452   unsigned int
453   find_capability(const char *capab)
454   {
455 <  const dlink_node *ptr = NULL;
455 >  const dlink_node *node = NULL;
456  
457 <  DLINK_FOREACH(ptr, cap_list.head)
457 >  DLINK_FOREACH(node, cap_list.head)
458    {
459 <    const struct Capability *cap = ptr->data;
459 >    const struct Capability *cap = node->data;
460  
461      if (cap->cap && !irccmp(cap->name, capab))
462        return cap->cap;
# Line 537 | Line 476 | find_capability(const char *capab)
476   void
477   send_capabilities(struct Client *client_p, int cap_can_send)
478   {
479 <  struct Capability *cap=NULL;
480 <  char msgbuf[IRCD_BUFSIZE];
542 <  char *t;
543 <  int tl;
544 <  dlink_node *ptr;
545 <
546 <  t = msgbuf;
479 >  char buf[IRCD_BUFSIZE] = "";
480 >  const dlink_node *node = NULL;
481  
482 <  DLINK_FOREACH(ptr, cap_list.head)
482 >  DLINK_FOREACH(node, cap_list.head)
483    {
484 <    cap = ptr->data;
484 >    const struct Capability *cap = node->data;
485  
486      if (cap->cap & (cap_can_send|default_server_capabs))
487      {
488 <      tl = sprintf(t, "%s ", cap->name);
489 <      t += tl;
488 >      strlcat(buf, cap->name, sizeof(buf));
489 >      if (node->next)
490 >        strlcat(buf, " ", sizeof(buf));
491      }
492    }
493  
494 <  *(t - 1) = '\0';
560 <  sendto_one(client_p, "CAPAB :%s", msgbuf);
561 < }
562 <
563 < /* sendnick_TS()
564 < *
565 < * inputs       - client (server) to send nick towards
566 < *          - client to send nick for
567 < * output       - NONE
568 < * side effects - NICK message is sent towards given client_p
569 < */
570 < void
571 < sendnick_TS(struct Client *client_p, struct Client *target_p)
572 < {
573 <  static char ubuf[12];
574 <
575 <  if (!IsClient(target_p))
576 <    return;
577 <
578 <  send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
579 <
580 <  if (ubuf[0] == '\0')
581 <  {
582 <    ubuf[0] = '+';
583 <    ubuf[1] = '\0';
584 <  }
585 <
586 <  if (IsCapable(client_p, CAP_SVS))
587 <  {
588 <    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
589 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
590 <                 target_p->servptr->id,
591 <                 target_p->name, target_p->hopcount + 1,
592 <                 (unsigned long) target_p->tsinfo,
593 <                 ubuf, target_p->username, target_p->host,
594 <                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
595 <                 "0" : target_p->sockhost, target_p->id,
596 <                 target_p->svid, target_p->info);
597 <    else
598 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s %s :%s",
599 <                 target_p->name, target_p->hopcount + 1,
600 <                 (unsigned long) target_p->tsinfo,
601 <                 ubuf, target_p->username, target_p->host,
602 <                 target_p->servptr->name, target_p->svid,
603 <                 target_p->info);
604 <  }
605 <  else
606 <  {
607 <    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
608 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
609 <                 target_p->servptr->id,
610 <                 target_p->name, target_p->hopcount + 1,
611 <                 (unsigned long) target_p->tsinfo,
612 <                 ubuf, target_p->username, target_p->host,
613 <                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
614 <                 "0" : target_p->sockhost, target_p->id, target_p->info);
615 <    else
616 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s :%s",
617 <                 target_p->name, target_p->hopcount + 1,
618 <                 (unsigned long) target_p->tsinfo,
619 <                 ubuf, target_p->username, target_p->host,
620 <                 target_p->servptr->name, target_p->info);
621 <  }
622 <
623 <  if (!EmptyString(target_p->certfp))
624 <    sendto_one(client_p, ":%s CERTFP %s",
625 <               ID_or_name(target_p, client_p), target_p->certfp);
626 <
627 <  if (target_p->away[0])
628 <    sendto_one(client_p, ":%s AWAY :%s", ID_or_name(target_p, client_p),
629 <               target_p->away);
630 <
494 >  sendto_one(client_p, "CAPAB :%s", buf);
495   }
496  
497   /*
# Line 641 | Line 505 | const char *
505   show_capabilities(const struct Client *target_p)
506   {
507    static char msgbuf[IRCD_BUFSIZE] = "";
508 <  const dlink_node *ptr = NULL;
508 >  const dlink_node *node = NULL;
509  
510    strlcpy(msgbuf, "TS", sizeof(msgbuf));
511  
512 <  DLINK_FOREACH(ptr, cap_list.head)
512 >  DLINK_FOREACH(node, cap_list.head)
513    {
514 <    const struct Capability *cap = ptr->data;
514 >    const struct Capability *cap = node->data;
515  
516      if (!IsCapable(target_p, cap->cap))
517        continue;
# Line 670 | Line 534 | struct Server *
534   make_server(struct Client *client_p)
535   {
536    if (client_p->serv == NULL)
537 <    client_p->serv = MyMalloc(sizeof(struct Server));
537 >    client_p->serv = MyCalloc(sizeof(struct Server));
538  
539    return client_p->serv;
540   }
541  
678 /* server_estab()
679 *
680 * inputs       - pointer to a struct Client
681 * output       -
682 * side effects -
683 */
684 void
685 server_estab(struct Client *client_p)
686 {
687  struct Client *target_p;
688  struct MaskItem *conf = NULL;
689  char *host;
690  const char *inpath;
691  static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
692  dlink_node *ptr;
693 #ifdef HAVE_LIBCRYPTO
694  const COMP_METHOD *compression = NULL, *expansion = NULL;
695 #endif
696
697  assert(client_p != NULL);
698
699  strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
700
701  inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
702  host   = client_p->name;
703
704  if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
705      == NULL)
706  {
707    /* This shouldn't happen, better tell the ops... -A1kmm */
708    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
709                         "Warning: Lost connect{} block "
710                         "for server %s(this shouldn't happen)!", host);
711    exit_client(client_p, &me, "Lost connect{} block!");
712    return;
713  }
714
715  MyFree(client_p->localClient->passwd);
716  client_p->localClient->passwd = NULL;
717
718  /* Its got identd, since its a server */
719  SetGotId(client_p);
720
721  /* If there is something in the serv_list, it might be this
722   * connecting server..
723   */
724  if (!ServerInfo.hub && serv_list.head)
725  {
726    if (client_p != serv_list.head->data || serv_list.head->next)
727    {
728      ++ServerStats.is_ref;
729      sendto_one(client_p, "ERROR :I'm a leaf not a hub");
730      exit_client(client_p, &me, "I'm a leaf");
731      return;
732    }
733  }
734
735  if (IsUnknown(client_p))
736  {
737    sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
738
739    send_capabilities(client_p, 0);
740
741    sendto_one(client_p, "SERVER %s 1 :%s%s",
742               me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
743  }
744
745  sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
746             (unsigned long)CurrentTime);
747
748  /* assumption here is if they passed the correct TS version, they also passed an SID */
749  if (IsCapable(client_p, CAP_TS6))
750    hash_add_id(client_p);
751
752  /* XXX Does this ever happen? I don't think so -db */
753  detach_conf(client_p, CONF_OPER);
754
755  /* *WARNING*
756  **    In the following code in place of plain server's
757  **    name we send what is returned by get_client_name
758  **    which may add the "sockhost" after the name. It's
759  **    *very* *important* that there is a SPACE between
760  **    the name and sockhost (if present). The receiving
761  **    server will start the information field from this
762  **    first blank and thus puts the sockhost into info.
763  **    ...a bit tricky, but you have been warned, besides
764  **    code is more neat this way...  --msa
765  */
766  client_p->servptr = &me;
767
768  if (IsClosing(client_p))
769    return;
770
771  SetServer(client_p);
772
773  /* Update the capability combination usage counts. -A1kmm */
774  set_chcap_usage_counts(client_p);
775
776  /* Some day, all these lists will be consolidated *sigh* */
777  dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
778
779  assert(dlinkFind(&unknown_list, client_p));
780
781  dlink_move_node(&client_p->localClient->lclient_node,
782                  &unknown_list, &serv_list);
783
784  Count.myserver++;
785
786  dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
787  hash_add_client(client_p);
788
789  /* doesnt duplicate client_p->serv if allocated this struct already */
790  make_server(client_p);
791
792  /* fixing eob timings.. -gnp */
793  client_p->localClient->firsttime = CurrentTime;
794
795  if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
796    AddFlag(client_p, FLAGS_SERVICE);
797
798  /* Show the real host/IP to admins */
799 #ifdef HAVE_LIBCRYPTO
800  if (client_p->localClient->fd.ssl)
801  {
802    compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
803    expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
804
805    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
806                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
807                         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
808                         compression ? SSL_COMP_get_name(compression) : "NONE",
809                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
810                         show_capabilities(client_p));
811    /* Now show the masked hostname/IP to opers */
812    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
813                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
814                         inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
815                         compression ? SSL_COMP_get_name(compression) : "NONE",
816                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
817                         show_capabilities(client_p));
818    ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
819         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
820         compression ? SSL_COMP_get_name(compression) : "NONE",
821         expansion ? SSL_COMP_get_name(expansion) : "NONE",
822         show_capabilities(client_p));
823  }
824  else
825 #endif
826  {
827    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
828                         "Link with %s established: (Capabilities: %s)",
829                         inpath_ip, show_capabilities(client_p));
830    /* Now show the masked hostname/IP to opers */
831    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
832                         "Link with %s established: (Capabilities: %s)",
833                         inpath, show_capabilities(client_p));
834    ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
835         inpath_ip, show_capabilities(client_p));
836  }
837
838  fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
839
840  /* Old sendto_serv_but_one() call removed because we now
841  ** need to send different names to different servers
842  ** (domain name matching) Send new server to other servers.
843  */
844  DLINK_FOREACH(ptr, serv_list.head)
845  {
846    target_p = ptr->data;
847
848    if (target_p == client_p)
849      continue;
850
851    if (IsCapable(target_p, CAP_TS6) && HasID(client_p))
852      sendto_one(target_p, ":%s SID %s 2 %s :%s%s",
853                 me.id, client_p->name, client_p->id,
854                 IsHidden(client_p) ? "(H) " : "",
855                 client_p->info);
856    else
857      sendto_one(target_p,":%s SERVER %s 2 :%s%s",
858                 me.name, client_p->name,
859                 IsHidden(client_p) ? "(H) " : "",
860                 client_p->info);
861  }
862
863  /*
864   * Pass on my client information to the new server
865   *
866   * First, pass only servers (idea is that if the link gets
867   * cancelled beacause the server was already there,
868   * there are no NICK's to be cancelled...). Of course,
869   * if cancellation occurs, all this info is sent anyway,
870   * and I guess the link dies when a read is attempted...? --msa
871   *
872   * Note: Link cancellation to occur at this point means
873   * that at least two servers from my fragment are building
874   * up connection this other fragment at the same time, it's
875   * a race condition, not the normal way of operation...
876   *
877   * ALSO NOTE: using the get_client_name for server names--
878   *    see previous *WARNING*!!! (Also, original inpath
879   *    is destroyed...)
880   */
881
882  DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
883  {
884    target_p = ptr->data;
885
886    /* target_p->from == target_p for target_p == client_p */
887    if (IsMe(target_p) || target_p->from == client_p)
888      continue;
889
890    if (IsCapable(client_p, CAP_TS6))
891    {
892      if (HasID(target_p))
893        sendto_one(client_p, ":%s SID %s %d %s :%s%s",
894                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
895                   target_p->id, IsHidden(target_p) ? "(H) " : "",
896                   target_p->info);
897      else  /* introducing non-ts6 server */
898        sendto_one(client_p, ":%s SERVER %s %d :%s%s",
899                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
900                   IsHidden(target_p) ? "(H) " : "", target_p->info);
901    }
902    else
903      sendto_one(client_p, ":%s SERVER %s %d :%s%s",
904                 target_p->servptr->name, target_p->name, target_p->hopcount+1,
905                 IsHidden(target_p) ? "(H) " : "", target_p->info);
906
907    if (HasFlag(target_p, FLAGS_EOB))
908      sendto_one(client_p, ":%s EOB", ID_or_name(client_p, target_p));
909  }
910
911  server_burst(client_p);
912 }
913
914 /* server_burst()
915 *
916 * inputs       - struct Client pointer server
917 *              -
918 * output       - none
919 * side effects - send a server burst
920 * bugs         - still too long
921 */
922 static void
923 server_burst(struct Client *client_p)
924 {
925  /* Send it in the shortened format with the TS, if
926  ** it's a TS server; walk the list of channels, sending
927  ** all the nicks that haven't been sent yet for each
928  ** channel, then send the channel itself -- it's less
929  ** obvious than sending all nicks first, but on the
930  ** receiving side memory will be allocated more nicely
931  ** saving a few seconds in the handling of a split
932  ** -orabidoo
933  */
934
935  burst_all(client_p);
936
937  /* EOB stuff is now in burst_all */
938  /* Always send a PING after connect burst is done */
939  sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
940 }
941
942 /* burst_all()
943 *
944 * inputs       - pointer to server to send burst to
945 * output       - NONE
946 * side effects - complete burst of channels/nicks is sent to client_p
947 */
948 static void
949 burst_all(struct Client *client_p)
950 {
951  dlink_node *ptr = NULL;
952
953  DLINK_FOREACH(ptr, global_channel_list.head)
954  {
955    struct Channel *chptr = ptr->data;
956
957    if (dlink_list_length(&chptr->members) != 0)
958    {
959      burst_members(client_p, chptr);
960      send_channel_modes(client_p, chptr);
961
962      if (IsCapable(client_p, CAP_TBURST))
963        send_tb(client_p, chptr);
964    }
965  }
966
967  /* also send out those that are not on any channel
968   */
969  DLINK_FOREACH(ptr, global_client_list.head)
970  {
971    struct Client *target_p = ptr->data;
972
973    if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
974      sendnick_TS(client_p, target_p);
975
976    DelFlag(target_p, FLAGS_BURSTED);
977  }
978
979  if (IsCapable(client_p, CAP_EOB))
980    sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
981 }
982
983 /*
984 * send_tb
985 *
986 * inputs       - pointer to Client
987 *              - pointer to channel
988 * output       - NONE
989 * side effects - Called on a server burst when
990 *                server is CAP_TBURST capable
991 */
992 static void
993 send_tb(struct Client *client_p, struct Channel *chptr)
994 {
995  /*
996   * We may also send an empty topic here, but only if topic_time isn't 0,
997   * i.e. if we had a topic that got unset.  This is required for syncing
998   * topics properly.
999   *
1000   * Imagine the following scenario: Our downlink introduces a channel
1001   * to us with a TS that is equal to ours, but the channel topic on
1002   * their side got unset while the servers were in splitmode, which means
1003   * their 'topic' is newer.  They simply wanted to unset it, so we have to
1004   * deal with it in a more sophisticated fashion instead of just resetting
1005   * it to their old topic they had before.  Read m_tburst.c:ms_tburst
1006   * for further information   -Michael
1007   */
1008  if (chptr->topic_time != 0)
1009    sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s",
1010               ID_or_name(&me, client_p),
1011               (unsigned long)chptr->channelts, chptr->chname,
1012               (unsigned long)chptr->topic_time,
1013               chptr->topic_info,
1014               chptr->topic);
1015 }
1016
1017 /* burst_members()
1018 *
1019 * inputs       - pointer to server to send members to
1020 *              - dlink_list pointer to membership list to send
1021 * output       - NONE
1022 * side effects -
1023 */
1024 static void
1025 burst_members(struct Client *client_p, struct Channel *chptr)
1026 {
1027  struct Client *target_p;
1028  struct Membership *ms;
1029  dlink_node *ptr;
1030
1031  DLINK_FOREACH(ptr, chptr->members.head)
1032  {
1033    ms       = ptr->data;
1034    target_p = ms->client_p;
1035
1036    if (!HasFlag(target_p, FLAGS_BURSTED))
1037    {
1038      AddFlag(target_p, FLAGS_BURSTED);
1039
1040      if (target_p->from != client_p)
1041        sendnick_TS(client_p, target_p);
1042    }
1043  }
1044 }
1045
542   /* New server connection code
543   * Based upon the stuff floating about in s_bsd.c
544   *   -- adrian
# Line 1067 | Line 563 | burst_members(struct Client *client_p, s
563   int
564   serv_connect(struct MaskItem *conf, struct Client *by)
565   {
566 <  struct Client *client_p;
567 <  char buf[HOSTIPLEN + 1];
566 >  struct Client *client_p = NULL;
567 >  char buf[HOSTIPLEN + 1] = "";
568  
569    /* conversion structs */
570    struct sockaddr_in *v4;
1075  /* Make sure conf is useful */
1076  assert(conf != NULL);
571  
572 +  /* Make sure conf is useful */
573 +  assert(conf);
574  
575 <  getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
575 >  getnameinfo((const struct sockaddr *)&conf->addr, conf->addr.ss_len,
576                buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
577    ilog(LOG_TYPE_IRCD, "Connect to %s[%s] @%s", conf->name, conf->host,
578         buf);
# Line 1087 | Line 583 | serv_connect(struct MaskItem *conf, stru
583      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
584                           "Error connecting to %s: DNS lookup for connect{} in progress.",
585                           conf->name);
586 <    return (0);
586 >    return 0;
587    }
588  
589    if (conf->dns_failed)
# Line 1095 | Line 591 | serv_connect(struct MaskItem *conf, stru
591      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
592                           "Error connecting to %s: DNS lookup for connect{} failed.",
593                           conf->name);
594 <    return (0);
594 >    return 0;
595    }
596  
597    /* Make sure this server isn't already connected
598     * Note: conf should ALWAYS be a valid C: line
599     */
600 <  if ((client_p = hash_find_server(conf->name)) != NULL)
600 >  if ((client_p = hash_find_server(conf->name)))
601    {
602      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
603                           "Server %s already present from %s",
# Line 1110 | Line 606 | serv_connect(struct MaskItem *conf, stru
606                           "Server %s already present from %s",
607                           conf->name, get_client_name(client_p, MASK_IP));
608      if (by && IsClient(by) && !MyClient(by))
609 <      sendto_one(by, ":%s NOTICE %s :Server %s already present from %s",
610 <                 me.name, by->name, conf->name,
1115 <                 get_client_name(client_p, MASK_IP));
609 >      sendto_one_notice(by, &me, ":Server %s already present from %s",
610 >                        conf->name, get_client_name(client_p, MASK_IP));
611      return 0;
612    }
613  
# Line 1127 | Line 622 | serv_connect(struct MaskItem *conf, stru
622    strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
623  
624    /* create a socket for the server connection */
625 <  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1131 <                SOCK_STREAM, 0, NULL) < 0)
625 >  if (comm_open(&client_p->connection->fd, conf->addr.ss.ss_family, SOCK_STREAM, 0, NULL) < 0)
626    {
627      /* Eek, failure to create the socket */
628 <    report_error(L_ALL, "opening stream socket to %s: %s",
629 <                 conf->name, errno);
628 >    report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
629 >
630      SetDead(client_p);
631 <    exit_client(client_p, &me, "Connection failed");
631 >    exit_client(client_p, "Connection failed");
632      return 0;
633    }
634  
635    /* servernames are always guaranteed under HOSTLEN chars */
636 <  fd_note(&client_p->localClient->fd, "Server: %s", conf->name);
636 >  fd_note(&client_p->connection->fd, "Server: %s", conf->name);
637  
638    /* Attach config entries to client here rather than in
639     * serv_connect_callback(). This to avoid null pointer references.
# Line 1147 | Line 641 | serv_connect(struct MaskItem *conf, stru
641    if (!attach_connect_block(client_p, conf->name, conf->host))
642    {
643      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
644 <                         "Host %s is not enabled for connecting: no connect{} block",
644 >                         "Host %s is not enabled for connecting: no connect {} block",
645                           conf->name);
646      if (by && IsClient(by) && !MyClient(by))
647 <      sendto_one(by, ":%s NOTICE %s :Connect to host %s failed.",
648 <                 me.name, by->name, client_p->name);
647 >      sendto_one_notice(by, &me, ":Connect to host %s failed: no connect {} block", client_p->name);
648 >
649      SetDead(client_p);
650 <    exit_client(client_p, client_p, "Connection failed");
650 >    exit_client(client_p, "Connection failed");
651      return 0;
652    }
653  
# Line 1171 | Line 665 | serv_connect(struct MaskItem *conf, stru
665      strlcpy(client_p->serv->by, "AutoConn.", sizeof(client_p->serv->by));
666  
667    SetConnecting(client_p);
668 <  dlinkAdd(client_p, &client_p->node, &global_client_list);
1175 <  /* from def_fam */
1176 <  client_p->localClient->aftype = conf->aftype;
668 >  client_p->connection->aftype = conf->aftype;
669  
670    /* Now, initiate the connection */
671    /* XXX assume that a non 0 type means a specific bind address
# Line 1183 | Line 675 | serv_connect(struct MaskItem *conf, stru
675    {
676      case AF_INET:
677        v4 = (struct sockaddr_in*)&conf->bind;
678 <      if (v4->sin_addr.s_addr != 0)
678 >      if (v4->sin_addr.s_addr)
679        {
680          struct irc_ssaddr ipn;
681          memset(&ipn, 0, sizeof(struct irc_ssaddr));
682          ipn.ss.ss_family = AF_INET;
683          ipn.ss_port = 0;
684          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
685 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
685 >        comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
686                           (struct sockaddr *)&ipn, ipn.ss_len,
687                           serv_connect_callback, client_p, conf->aftype,
688                           CONNECTTIMEOUT);
689        }
690 <      else if (ServerInfo.specific_ipv4_vhost)
690 >      else if (ConfigServerInfo.specific_ipv4_vhost)
691        {
692          struct irc_ssaddr ipn;
693          memset(&ipn, 0, sizeof(struct irc_ssaddr));
694          ipn.ss.ss_family = AF_INET;
695          ipn.ss_port = 0;
696 <        memcpy(&ipn, &ServerInfo.ip, sizeof(struct irc_ssaddr));
697 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
696 >        memcpy(&ipn, &ConfigServerInfo.ip, sizeof(struct irc_ssaddr));
697 >        comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
698                           (struct sockaddr *)&ipn, ipn.ss_len,
699                           serv_connect_callback, client_p, conf->aftype,
700                           CONNECTTIMEOUT);
701        }
702        else
703 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
703 >        comm_connect_tcp(&client_p->connection->fd, conf->host, conf->port,
704                           NULL, 0, serv_connect_callback, client_p, conf->aftype,
705                           CONNECTTIMEOUT);
706        break;
1215 #ifdef IPV6
707      case AF_INET6:
708        {
709          struct irc_ssaddr ipn;
# Line 1223 | Line 714 | serv_connect(struct MaskItem *conf, stru
714          v6conf = (struct sockaddr_in6 *)&conf->bind;
715          v6 = (struct sockaddr_in6 *)&ipn;
716  
717 <        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)) != 0)
717 >        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
718          {
719            memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
720            ipn.ss.ss_family = AF_INET6;
721            ipn.ss_port = 0;
722 <          comm_connect_tcp(&client_p->localClient->fd,
722 >          comm_connect_tcp(&client_p->connection->fd,
723                             conf->host, conf->port,
724                             (struct sockaddr *)&ipn, ipn.ss_len,
725                             serv_connect_callback, client_p,
726                             conf->aftype, CONNECTTIMEOUT);
727          }
728 <        else if (ServerInfo.specific_ipv6_vhost)
728 >        else if (ConfigServerInfo.specific_ipv6_vhost)
729          {
730 <          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
730 >          memcpy(&ipn, &ConfigServerInfo.ip6, sizeof(struct irc_ssaddr));
731            ipn.ss.ss_family = AF_INET6;
732            ipn.ss_port = 0;
733 <          comm_connect_tcp(&client_p->localClient->fd,
733 >          comm_connect_tcp(&client_p->connection->fd,
734                             conf->host, conf->port,
735                             (struct sockaddr *)&ipn, ipn.ss_len,
736                             serv_connect_callback, client_p,
737                             conf->aftype, CONNECTTIMEOUT);
738          }
739          else
740 <          comm_connect_tcp(&client_p->localClient->fd,
740 >          comm_connect_tcp(&client_p->connection->fd,
741                             conf->host, conf->port,
742                             NULL, 0, serv_connect_callback, client_p,
743                             conf->aftype, CONNECTTIMEOUT);
744        }
1254 #endif
745    }
746 +
747    return 1;
748   }
749  
# Line 1262 | Line 753 | finish_ssl_server_handshake(struct Clien
753   {
754    struct MaskItem *conf = NULL;
755  
756 <  conf = find_conf_name(&client_p->localClient->confs,
756 >  conf = find_conf_name(&client_p->connection->confs,
757                          client_p->name, CONF_SERVER);
758    if (conf == NULL)
759    {
# Line 1271 | Line 762 | finish_ssl_server_handshake(struct Clien
762      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
763                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
764  
765 <    exit_client(client_p, &me, "Lost connect{} block");
765 >    exit_client(client_p, "Lost connect{} block");
766      return;
767    }
768  
# Line 1299 | Line 790 | finish_ssl_server_handshake(struct Clien
790  
791    /* don't move to serv_list yet -- we haven't sent a burst! */
792    /* If we get here, we're ok, so lets start reading some data */
793 <  comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ, read_packet, client_p, 0);
793 >  comm_setselect(&client_p->connection->fd, COMM_SELECT_READ, read_packet, client_p, 0);
794   }
795  
796   static void
797 < ssl_server_handshake(fde_t *fd, struct Client *client_p)
797 > ssl_server_handshake(fde_t *fd, void *data)
798   {
799 +  struct Client *client_p = data;
800    X509 *cert = NULL;
801    int ret = 0;
802  
803 <  if ((ret = SSL_connect(client_p->localClient->fd.ssl)) <= 0)
803 >  if ((ret = SSL_connect(client_p->connection->fd.ssl)) <= 0)
804    {
805 <    switch (SSL_get_error(client_p->localClient->fd.ssl, ret))
805 >    if ((CurrentTime - client_p->connection->firsttime) > CONNECTTIMEOUT)
806 >    {
807 >      exit_client(client_p, "Timeout during SSL handshake");
808 >      return;
809 >    }
810 >
811 >    switch (SSL_get_error(client_p->connection->fd.ssl, ret))
812      {
813        case SSL_ERROR_WANT_WRITE:
814 <        comm_setselect(&client_p->localClient->fd, COMM_SELECT_WRITE,
815 <                       (PF *)ssl_server_handshake, client_p, 0);
814 >        comm_setselect(&client_p->connection->fd, COMM_SELECT_WRITE,
815 >                       ssl_server_handshake, client_p, CONNECTTIMEOUT);
816          return;
817        case SSL_ERROR_WANT_READ:
818 <        comm_setselect(&client_p->localClient->fd, COMM_SELECT_READ,
819 <                       (PF *)ssl_server_handshake, client_p, 0);
818 >        comm_setselect(&client_p->connection->fd, COMM_SELECT_READ,
819 >                       ssl_server_handshake, client_p, CONNECTTIMEOUT);
820          return;
821        default:
822        {
# Line 1326 | Line 824 | ssl_server_handshake(fde_t *fd, struct C
824          sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
825                               "Error connecting to %s: %s", client_p->name,
826                               sslerr ? sslerr : "unknown SSL error");
827 <        exit_client(client_p, client_p, "Error during SSL handshake");
827 >        exit_client(client_p, "Error during SSL handshake");
828          return;
829        }
830      }
831    }
832  
833 <  if ((cert = SSL_get_peer_certificate(client_p->localClient->fd.ssl)))
833 >  comm_settimeout(&client_p->connection->fd, 0, NULL, NULL);
834 >
835 >  if ((cert = SSL_get_peer_certificate(client_p->connection->fd.ssl)))
836    {
837 <    int res = SSL_get_verify_result(client_p->localClient->fd.ssl);
838 <    char buf[EVP_MAX_MD_SIZE * 2 + 1] = { '\0' };
839 <    unsigned char md[EVP_MAX_MD_SIZE] = { '\0' };
837 >    int res = SSL_get_verify_result(client_p->connection->fd.ssl);
838 >    char buf[EVP_MAX_MD_SIZE * 2 + 1] = "";
839 >    unsigned char md[EVP_MAX_MD_SIZE] = "";
840  
841      if (res == X509_V_OK || res == X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN ||
842          res == X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE ||
843          res == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT)
844      {
845 <      unsigned int i = 0, n = 0;
845 >      unsigned int n = 0;
846  
847 <      if (X509_digest(cert, EVP_sha256(), md, &n))
847 >      if (X509_digest(cert, ConfigServerInfo.message_digest_algorithm, md, &n))
848        {
849 <        for (; i < n; ++i)
1350 <          snprintf(buf + 2 * i, 3, "%02X", md[i]);
849 >        binary_to_hex(md, buf, n);
850          client_p->certfp = xstrdup(buf);
851        }
852      }
# Line 1363 | Line 862 | ssl_server_handshake(fde_t *fd, struct C
862   static void
863   ssl_connect_init(struct Client *client_p, struct MaskItem *conf, fde_t *fd)
864   {
865 <  if ((client_p->localClient->fd.ssl = SSL_new(ServerInfo.client_ctx)) == NULL)
865 >  if ((client_p->connection->fd.ssl = SSL_new(ConfigServerInfo.client_ctx)) == NULL)
866    {
867      ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
868           ERR_error_string(ERR_get_error(), NULL));
869      SetDead(client_p);
870 <    exit_client(client_p, client_p, "SSL_new failed");
870 >    exit_client(client_p, "SSL_new failed");
871      return;
872    }
873  
874    SSL_set_fd(fd->ssl, fd->fd);
875  
876    if (!EmptyString(conf->cipher_list))
877 <    SSL_set_cipher_list(client_p->localClient->fd.ssl, conf->cipher_list);
877 >    SSL_set_cipher_list(client_p->connection->fd.ssl, conf->cipher_list);
878  
879    ssl_server_handshake(NULL, client_p);
880   }
# Line 1395 | Line 894 | serv_connect_callback(fde_t *fd, int sta
894    struct Client *client_p = data;
895    struct MaskItem *conf = NULL;
896  
897 <  /* First, make sure its a real client! */
898 <  assert(client_p != NULL);
899 <  assert(&client_p->localClient->fd == fd);
897 >  /* First, make sure it's a real client! */
898 >  assert(client_p);
899 >  assert(&client_p->connection->fd == fd);
900  
901    /* Next, for backward purposes, record the ip of the server */
902 <  memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
902 >  memcpy(&client_p->connection->ip, &fd->connect.hostaddr,
903           sizeof(struct irc_ssaddr));
904 +
905    /* Check the status */
906    if (status != COMM_OK)
907    {
# Line 1430 | Line 930 | serv_connect_callback(fde_t *fd, int sta
930  
931    /* COMM_OK, so continue the connection procedure */
932    /* Get the C/N lines */
933 <  conf = find_conf_name(&client_p->localClient->confs,
933 >  conf = find_conf_name(&client_p->connection->confs,
934                          client_p->name, CONF_SERVER);
935    if (conf == NULL)
936    {
# Line 1439 | Line 939 | serv_connect_callback(fde_t *fd, int sta
939      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
940                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
941  
942 <    exit_client(client_p, &me, "Lost connect{} block");
942 >    exit_client(client_p, "Lost connect{} block");
943      return;
944    }
945  

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)