ViewVC Help
View File | Revision Log | Show Annotations | View Changeset | Root Listing
root/svn/ircd-hybrid/branches/8.2.x/src/server.c
(Generate patch)

Comparing:
ircd-hybrid/trunk/src/s_serv.c (file contents), Revision 2134 by michael, Wed May 29 18:59:39 2013 UTC vs.
ircd-hybrid/branches/8.2.x/src/server.c (file contents), Revision 3747 by michael, Sun Jun 1 17:15:40 2014 UTC

# Line 1 | Line 1
1   /*
2 < *  ircd-hybrid: an advanced Internet Relay Chat Daemon(ircd).
3 < *  s_serv.c: Server related functions.
2 > *  ircd-hybrid: an advanced, lightweight Internet Relay Chat Daemon (ircd)
3   *
4 < *  Copyright (C) 2005 by the past and present ircd coders, and others.
4 > *  Copyright (c) 1997-2014 ircd-hybrid development team
5   *
6   *  This program is free software; you can redistribute it and/or modify
7   *  it under the terms of the GNU General Public License as published by
# Line 18 | Line 17
17   *  along with this program; if not, write to the Free Software
18   *  Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307
19   *  USA
20 < *
21 < *  $Id$
20 > */
21 >
22 > /*! \file s_serv.c
23 > * \brief Server related functions.
24 > * \version $Id$
25   */
26  
27   #include "stdinc.h"
# Line 28 | Line 30
30   #include "rsa.h"
31   #endif
32   #include "list.h"
31 #include "channel.h"
32 #include "channel_mode.h"
33   #include "client.h"
34 #include "dbuf.h"
34   #include "event.h"
36 #include "fdlist.h"
35   #include "hash.h"
36   #include "irc_string.h"
37   #include "ircd.h"
# Line 41 | Line 39
39   #include "s_bsd.h"
40   #include "numeric.h"
41   #include "packet.h"
44 #include "irc_res.h"
42   #include "conf.h"
43 < #include "s_serv.h"
43 > #include "server.h"
44   #include "log.h"
45 < #include "s_misc.h"
49 < #include "s_user.h"
45 > #include "user.h"
46   #include "send.h"
47   #include "memory.h"
48 < #include "channel.h" /* chcap_usage_counts stuff...*/
48 > #include "channel.h"
49   #include "parse.h"
50  
51   #define MIN_CONN_FREQ 300
52  
53 + dlink_list flatten_links;
54   static dlink_list cap_list = { NULL, NULL, 0 };
58 static void server_burst(struct Client *);
59 static void burst_all(struct Client *);
60 static void send_tb(struct Client *client_p, struct Channel *chptr);
61
55   static CNCB serv_connect_callback;
56  
64 static void burst_members(struct Client *, struct Channel *);
57  
58   /*
59   * write_links_file
# Line 72 | Line 64 | static void burst_members(struct Client
64   *                but in no particular order.
65   */
66   void
67 < write_links_file(void* notused)
67 > write_links_file(void *notused)
68   {
69 <  MessageFileLine *next_mptr = NULL;
70 <  MessageFileLine *mptr = NULL;
71 <  MessageFileLine *currentMessageLine = NULL;
80 <  MessageFileLine *newMessageLine = NULL;
81 <  MessageFile *MessageFileptr = &ConfigFileEntry.linksfile;
82 <  FILE *file;
83 <  char buff[512];
84 <  dlink_node *ptr;
69 >  FILE *file = NULL;
70 >  dlink_node *ptr = NULL, *ptr_next = NULL;
71 >  char buff[IRCD_BUFSIZE] = "";
72  
73 <  if ((file = fopen(MessageFileptr->fileName, "w")) == NULL)
73 >  if ((file = fopen(LIPATH, "w")) == NULL)
74      return;
75  
76 <  for (mptr = MessageFileptr->contentsOfFile; mptr; mptr = next_mptr)
76 >  DLINK_FOREACH_SAFE(ptr, ptr_next, flatten_links.head)
77    {
78 <    next_mptr = mptr->next;
79 <    MyFree(mptr);
78 >    dlinkDelete(ptr, &flatten_links);
79 >    MyFree(ptr->data);
80 >    free_dlink_node(ptr);
81    }
82  
95  MessageFileptr->contentsOfFile = NULL;
96
83    DLINK_FOREACH(ptr, global_serv_list.head)
84    {
85      const struct Client *target_p = ptr->data;
86  
87 <    /* skip ourselves, we send ourselves in /links */
88 <    if (IsMe(target_p))
89 <      continue;
90 <
91 <    /* skip hidden servers */
106 <    if (IsHidden(target_p))
87 >    /*
88 >     * Skip hidden servers, aswell as ourselves, since we already send
89 >     * ourselves in /links
90 >     */
91 >    if (IsHidden(target_p) || IsMe(target_p))
92        continue;
93  
94      if (HasFlag(target_p, FLAGS_SERVICE) && ConfigServerHide.hide_services)
95        continue;
96  
112    newMessageLine = MyMalloc(sizeof(MessageFileLine));
113
97      /*
98       * Attempt to format the file in such a way it follows the usual links output
99       * ie  "servername uplink :hops info"
100       * Mostly for aesthetic reasons - makes it look pretty in mIRC ;)
101       * - madmax
102       */
103 <    snprintf(newMessageLine->line, sizeof(newMessageLine->line), "%s %s :1 %s",
104 <             target_p->name, me.name, target_p->info);
105 <
106 <    if (MessageFileptr->contentsOfFile)
107 <    {
125 <      if (currentMessageLine)
126 <        currentMessageLine->next = newMessageLine;
127 <      currentMessageLine = newMessageLine;
128 <    }
129 <    else
130 <    {
131 <      MessageFileptr->contentsOfFile = newMessageLine;
132 <      currentMessageLine = newMessageLine;
133 <    }
103 >    snprintf(buff, sizeof(buff), "%s %s :1 %s",   target_p->name,
104 >             me.name, target_p->info);
105 >    dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
106 >    snprintf(buff, sizeof(buff), "%s %s :1 %s\n", target_p->name,
107 >             me.name, target_p->info);
108  
135    snprintf(buff, sizeof(buff), "%s %s :1 %s\n",
136             target_p->name, me.name, target_p->info);
109      fputs(buff, file);
110    }
111  
112    fclose(file);
113   }
114  
115 + void
116 + read_links_file(void)
117 + {
118 +  FILE *file = NULL;
119 +  char *p = NULL;
120 +  char buff[IRCD_BUFSIZE] = "";
121 +
122 +  if ((file = fopen(LIPATH, "r")) == NULL)
123 +    return;
124 +
125 +  while (fgets(buff, sizeof(buff), file))
126 +  {
127 +    if ((p = strchr(buff, '\n')))
128 +      *p = '\0';
129 +
130 +    dlinkAddTail(xstrdup(buff), make_dlink_node(), &flatten_links);
131 +  }
132 +
133 +  fclose(file);
134 + }
135 +
136   /* hunt_server()
137   *      Do the basic thing in delivering the message (command)
138   *      across the relays to the specific server (server) for
# Line 160 | Line 153 | write_links_file(void* notused)
153   *      returns: (see #defines)
154   */
155   int
156 < hunt_server(struct Client *client_p, struct Client *source_p, const char *command,
156 > hunt_server(struct Client *source_p, const char *command,
157              const int server, const int parc, char *parv[])
158   {
159    struct Client *target_p = NULL;
160    struct Client *target_tmp = NULL;
161    dlink_node *ptr;
169  int wilds;
162  
163    /* Assume it's me, if no server */
164    if (parc <= server || EmptyString(parv[server]))
# Line 182 | Line 174 | hunt_server(struct Client *client_p, str
174    if (MyClient(source_p))
175      target_p = hash_find_client(parv[server]);
176    else
177 <    target_p = find_person(client_p, parv[server]);
177 >    target_p = find_person(source_p, parv[server]);
178  
179    if (target_p)
180      if (target_p->from == source_p->from && !MyConnect(target_p))
# Line 192 | Line 184 | hunt_server(struct Client *client_p, str
184      if (target_p->from == source_p->from && !MyConnect(target_p))
185        target_p = NULL;
186  
195  wilds = has_wildcards(parv[server]);
196
187    /* Again, if there are no wild cards involved in the server
188     * name, use the hash lookup
189     */
190    if (target_p == NULL)
191    {
192 <    if (!wilds)
192 >    if (!has_wildcards(parv[server]))
193      {
194        if (!(target_p = hash_find_server(parv[server])))
195        {
196 <        sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
197 <                   me.name, source_p->name, parv[server]);
208 <        return(HUNTED_NOSUCH);
196 >        sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
197 >        return HUNTED_NOSUCH;
198        }
199      }
200      else
# Line 220 | Line 209 | hunt_server(struct Client *client_p, str
209              continue;
210            target_p = ptr->data;
211  
212 <          if (IsRegistered(target_p) && (target_p != client_p))
212 >          if (IsRegistered(target_p) && (target_p != source_p->from))
213              break;
214          }
215        }
216      }
217    }
218  
219 <  if (target_p != NULL)
219 >  if (target_p)
220    {
221 <    if(!IsRegistered(target_p))
221 >    if (!IsRegistered(target_p))
222      {
223 <      sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
235 <                 me.name, source_p->name, parv[server]);
223 >      sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
224        return HUNTED_NOSUCH;
225      }
226  
# Line 243 | Line 231 | hunt_server(struct Client *client_p, str
231        parv[server] = target_p->name;
232  
233      /* This is a little kludgy but should work... */
234 <    if (IsClient(source_p) &&
247 <        ((MyConnect(target_p) && IsCapable(target_p, CAP_TS6)) ||
248 <         (!MyConnect(target_p) && IsCapable(target_p->from, CAP_TS6))))
249 <      parv[0] = ID(source_p);
250 <
251 <    sendto_one(target_p, command, parv[0],
234 >    sendto_one(target_p, command, ID_or_name(source_p, target_p),
235                 parv[1], parv[2], parv[3], parv[4],
236                 parv[5], parv[6], parv[7], parv[8]);
237      return HUNTED_PASS;
238 <  }
238 >  }
239  
240 <  sendto_one(source_p, form_str(ERR_NOSUCHSERVER),
258 <             me.name, source_p->name, parv[server]);
240 >  sendto_one_numeric(source_p, &me, ERR_NOSUCHSERVER, parv[server]);
241    return HUNTED_NOSUCH;
242   }
243  
# Line 273 | Line 255 | void
255   try_connections(void *unused)
256   {
257    dlink_node *ptr = NULL;
258 <  struct MaskItem *conf;
277 <  int confrq;
258 >  int confrq = 0;
259  
260    /* TODO: change this to set active flag to 0 when added to event! --Habeeb */
261    if (GlobalSetOptions.autoconn == 0)
# Line 282 | Line 263 | try_connections(void *unused)
263  
264    DLINK_FOREACH(ptr, server_items.head)
265    {
266 <    conf = ptr->data;
266 >    struct MaskItem *conf = ptr->data;
267  
268      assert(conf->type == CONF_SERVER);
269  
270 <    /* Also when already connecting! (update holdtimes) --SRB
270 >    /* Also when already connecting! (update holdtimes) --SRB
271       */
272      if (!conf->port ||!IsConfAllowAutoConn(conf))
273        continue;
# Line 312 | Line 293 | try_connections(void *unused)
293  
294      conf->until = CurrentTime + confrq;
295  
296 <    /* Found a CONNECT config with port specified, scan clients
296 >    /*
297 >     * Found a CONNECT config with port specified, scan clients
298       * and see if this server is already connected?
299       */
300 <    if (hash_find_server(conf->name) != NULL)
300 >    if (hash_find_server(conf->name))
301        continue;
302  
303      if (conf->class->ref_count < conf->class->max_total)
304      {
305        /* Go to the end of the list, if not already last */
306 <      if (ptr->next != NULL)
306 >      if (ptr->next)
307        {
308          dlinkDelete(ptr, &server_items);
309          dlinkAddTail(conf, &conf->node, &server_items);
# Line 330 | Line 312 | try_connections(void *unused)
312        if (find_servconn_in_progress(conf->name))
313          return;
314  
315 <      /* We used to only print this if serv_connect() actually
315 >      /*
316 >       * We used to only print this if serv_connect() actually
317         * succeeded, but since comm_tcp_connect() can call the callback
318         * immediately if there is an error, we were getting error messages
319         * in the wrong order. SO, we just print out the activated line,
# Line 357 | Line 340 | try_connections(void *unused)
340   int
341   valid_servname(const char *name)
342   {
343 <  unsigned int length = 0;
361 <  unsigned int dots   = 0;
343 >  unsigned int dots = 0;
344    const char *p = name;
345  
346    for (; *p; ++p)
# Line 366 | Line 348 | valid_servname(const char *name)
348      if (!IsServChar(*p))
349        return 0;
350  
369    ++length;
370
351      if (*p == '.')
352        ++dots;
353    }
354  
355 <  return dots != 0 && length <= HOSTLEN;
355 >  return dots && (p - name) <= HOSTLEN;
356   }
357  
358   int
# Line 383 | Line 363 | check_server(const char *name, struct Cl
363    struct MaskItem *server_conf = NULL;
364    int error = -1;
365  
366 <  assert(client_p != NULL);
366 >  assert(client_p);
367  
368    /* loop through looking for all possible connect items that might work */
369    DLINK_FOREACH(ptr, server_items.head)
# Line 397 | Line 377 | check_server(const char *name, struct Cl
377  
378      /* XXX: Fix me for IPv6                    */
379      /* XXX sockhost is the IPv4 ip as a string */
380 <    if (!match(conf->host, client_p->host) ||
380 >    if (!match(conf->host, client_p->host) ||
381          !match(conf->host, client_p->sockhost))
382      {
383        error = -2;
# Line 405 | Line 385 | check_server(const char *name, struct Cl
385        if (!match_conf_password(client_p->localClient->passwd, conf))
386          return -2;
387  
388 +      if (!EmptyString(conf->certfp))
389 +        if (EmptyString(client_p->certfp) || strcasecmp(client_p->certfp, conf->certfp))
390 +          return -4;
391 +
392        server_conf = conf;
393      }
394    }
395  
396    if (server_conf == NULL)
397 <    return(error);
397 >    return error;
398  
399    attach_conf(client_p, server_conf);
400  
401  
402 <  if (server_conf != NULL)
402 >  if (server_conf)
403    {
404      struct sockaddr_in *v4;
405   #ifdef IPV6
# Line 424 | Line 408 | check_server(const char *name, struct Cl
408      switch (server_conf->aftype)
409      {
410   #ifdef IPV6
411 <      case AF_INET6:
411 >      case AF_INET6:
412          v6 = (struct sockaddr_in6 *)&server_conf->addr;
413  
414          if (IN6_IS_ADDR_UNSPECIFIED(&v6->sin6_addr))
# Line 435 | Line 419 | check_server(const char *name, struct Cl
419          v4 = (struct sockaddr_in *)&server_conf->addr;
420  
421          if (v4->sin_addr.s_addr == INADDR_NONE)
422 <          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
422 >          memcpy(&server_conf->addr, &client_p->localClient->ip, sizeof(struct irc_ssaddr));
423          break;
424      }
425    }
426  
427 <  return(0);
427 >  return 0;
428   }
429  
430   /* add_capability()
# Line 455 | Line 439 | check_server(const char *name, struct Cl
439   void
440   add_capability(const char *capab_name, int cap_flag, int add_to_default)
441   {
442 <  struct Capability *cap = MyMalloc(sizeof(*cap));
442 >  struct Capability *cap = MyCalloc(sizeof(*cap));
443  
444    cap->name = xstrdup(capab_name);
445    cap->cap = cap_flag;
# Line 474 | Line 458 | add_capability(const char *capab_name, i
458   int
459   delete_capability(const char *capab_name)
460   {
461 <  dlink_node *ptr;
478 <  dlink_node *next_ptr;
479 <  struct Capability *cap;
461 >  dlink_node *ptr = NULL, *ptr_next = NULL;
462  
463 <  DLINK_FOREACH_SAFE(ptr, next_ptr, cap_list.head)
463 >  DLINK_FOREACH_SAFE(ptr, ptr_next, cap_list.head)
464    {
465 <    cap = ptr->data;
465 >    struct Capability *cap = ptr->data;
466  
467 <    if (cap->cap != 0)
467 >    if (cap->cap)
468      {
469 <      if (irccmp(cap->name, capab_name) == 0)
469 >      if (!irccmp(cap->name, capab_name))
470        {
471          default_server_capabs &= ~(cap->cap);
472          dlinkDelete(ptr, &cap_list);
# Line 531 | Line 513 | find_capability(const char *capab)
513   void
514   send_capabilities(struct Client *client_p, int cap_can_send)
515   {
516 <  struct Capability *cap=NULL;
517 <  char msgbuf[IRCD_BUFSIZE];
536 <  char *t;
537 <  int tl;
538 <  dlink_node *ptr;
539 <
540 <  t = msgbuf;
516 >  char buf[IRCD_BUFSIZE] = "";
517 >  const dlink_node *ptr = NULL;
518  
519    DLINK_FOREACH(ptr, cap_list.head)
520    {
521 <    cap = ptr->data;
521 >    const struct Capability *cap = ptr->data;
522  
523      if (cap->cap & (cap_can_send|default_server_capabs))
524      {
525 <      tl = sprintf(t, "%s ", cap->name);
526 <      t += tl;
525 >      strlcat(buf, cap->name, sizeof(buf));
526 >      if (ptr->next)
527 >        strlcat(buf, " ", sizeof(buf));
528      }
529    }
530  
531 <  *(t - 1) = '\0';
554 <  sendto_one(client_p, "CAPAB :%s", msgbuf);
555 < }
556 <
557 < /* sendnick_TS()
558 < *
559 < * inputs       - client (server) to send nick towards
560 < *          - client to send nick for
561 < * output       - NONE
562 < * side effects - NICK message is sent towards given client_p
563 < */
564 < void
565 < sendnick_TS(struct Client *client_p, struct Client *target_p)
566 < {
567 <  static char ubuf[12];
568 <
569 <  if (!IsClient(target_p))
570 <    return;
571 <
572 <  send_umode(NULL, target_p, 0, SEND_UMODES, ubuf);
573 <
574 <  if (ubuf[0] == '\0')
575 <  {
576 <    ubuf[0] = '+';
577 <    ubuf[1] = '\0';
578 <  }
579 <
580 <  if (IsCapable(client_p, CAP_SVS))
581 <  {
582 <    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
583 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s %s :%s",
584 <                 target_p->servptr->id,
585 <                 target_p->name, target_p->hopcount + 1,
586 <                 (unsigned long) target_p->tsinfo,
587 <                 ubuf, target_p->username, target_p->host,
588 <                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
589 <                 "0" : target_p->sockhost, target_p->id,
590 <                 target_p->svid, target_p->info);
591 <    else
592 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s %s :%s",
593 <                 target_p->name, target_p->hopcount + 1,
594 <                 (unsigned long) target_p->tsinfo,
595 <                 ubuf, target_p->username, target_p->host,
596 <                 target_p->servptr->name, target_p->svid,
597 <                 target_p->info);
598 <  }
599 <  else
600 <  {
601 <    if (HasID(target_p) && IsCapable(client_p, CAP_TS6))
602 <      sendto_one(client_p, ":%s UID %s %d %lu %s %s %s %s %s :%s",
603 <                 target_p->servptr->id,
604 <                 target_p->name, target_p->hopcount + 1,
605 <                 (unsigned long) target_p->tsinfo,
606 <                 ubuf, target_p->username, target_p->host,
607 <                 (MyClient(target_p) && IsIPSpoof(target_p)) ?
608 <                 "0" : target_p->sockhost, target_p->id, target_p->info);
609 <    else
610 <      sendto_one(client_p, "NICK %s %d %lu %s %s %s %s :%s",
611 <                 target_p->name, target_p->hopcount + 1,
612 <                 (unsigned long) target_p->tsinfo,
613 <                 ubuf, target_p->username, target_p->host,
614 <                 target_p->servptr->name, target_p->info);
615 <  }
616 <
617 <  if (target_p->away[0])
618 <    sendto_one(client_p, ":%s AWAY :%s", ID_or_name(target_p, client_p),
619 <               target_p->away);
620 <
531 >  sendto_one(client_p, "CAPAB :%s", buf);
532   }
533  
534   /*
# Line 628 | Line 539 | sendnick_TS(struct Client *client_p, str
539   * side effects - build up string representing capabilities of server listed
540   */
541   const char *
542 < show_capabilities(struct Client *target_p)
542 > show_capabilities(const struct Client *target_p)
543   {
544 <  static char msgbuf[IRCD_BUFSIZE];
545 <  char *t = msgbuf;
635 <  dlink_node *ptr;
544 >  static char msgbuf[IRCD_BUFSIZE] = "";
545 >  const dlink_node *ptr = NULL;
546  
547 <  t += sprintf(msgbuf, "TS ");
547 >  strlcpy(msgbuf, "TS", sizeof(msgbuf));
548  
549    DLINK_FOREACH(ptr, cap_list.head)
550    {
551      const struct Capability *cap = ptr->data;
552  
553 <    if (IsCapable(target_p, cap->cap))
554 <      t += sprintf(t, "%s ", cap->name);
553 >    if (!IsCapable(target_p, cap->cap))
554 >      continue;
555 >
556 >    strlcat(msgbuf,       " ", sizeof(msgbuf));
557 >    strlcat(msgbuf, cap->name, sizeof(msgbuf));
558    }
559  
647  *(t - 1) = '\0';
560    return msgbuf;
561   }
562  
# Line 659 | Line 571 | struct Server *
571   make_server(struct Client *client_p)
572   {
573    if (client_p->serv == NULL)
574 <    client_p->serv = MyMalloc(sizeof(struct Server));
574 >    client_p->serv = MyCalloc(sizeof(struct Server));
575  
576    return client_p->serv;
577   }
578  
667 /* server_estab()
668 *
669 * inputs       - pointer to a struct Client
670 * output       -
671 * side effects -
672 */
673 void
674 server_estab(struct Client *client_p)
675 {
676  struct Client *target_p;
677  struct MaskItem *conf = NULL;
678  char *host;
679  const char *inpath;
680  static char inpath_ip[HOSTLEN * 2 + USERLEN + 6];
681  dlink_node *ptr;
682 #ifdef HAVE_LIBCRYPTO
683  const COMP_METHOD *compression = NULL, *expansion = NULL;
684 #endif
685
686  assert(client_p != NULL);
687
688  strlcpy(inpath_ip, get_client_name(client_p, SHOW_IP), sizeof(inpath_ip));
689
690  inpath = get_client_name(client_p, MASK_IP); /* "refresh" inpath with host */
691  host   = client_p->name;
692
693  if ((conf = find_conf_name(&client_p->localClient->confs, host, CONF_SERVER))
694      == NULL)
695  {
696    /* This shouldn't happen, better tell the ops... -A1kmm */
697    sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
698                         "Warning: Lost connect{} block "
699                         "for server %s(this shouldn't happen)!", host);
700    exit_client(client_p, &me, "Lost connect{} block!");
701    return;
702  }
703
704  MyFree(client_p->localClient->passwd);
705  client_p->localClient->passwd = NULL;
706
707  /* Its got identd, since its a server */
708  SetGotId(client_p);
709
710  /* If there is something in the serv_list, it might be this
711   * connecting server..
712   */
713  if (!ServerInfo.hub && serv_list.head)  
714  {
715    if (client_p != serv_list.head->data || serv_list.head->next)
716    {
717      ++ServerStats.is_ref;
718      sendto_one(client_p, "ERROR :I'm a leaf not a hub");
719      exit_client(client_p, &me, "I'm a leaf");
720      return;
721    }
722  }
723
724  if (IsUnknown(client_p))
725  {
726    sendto_one(client_p, "PASS %s TS %d %s", conf->spasswd, TS_CURRENT, me.id);
727
728    send_capabilities(client_p, 0);
729
730    sendto_one(client_p, "SERVER %s 1 :%s%s",
731               me.name, ConfigServerHide.hidden ? "(H) " : "", me.info);
732  }
733
734  sendto_one(client_p, "SVINFO %d %d 0 :%lu", TS_CURRENT, TS_MIN,
735             (unsigned long)CurrentTime);
736
737  /* assumption here is if they passed the correct TS version, they also passed an SID */
738  if (IsCapable(client_p, CAP_TS6))
739    hash_add_id(client_p);
740
741  /* XXX Does this ever happen? I don't think so -db */
742  detach_conf(client_p, CONF_OPER);
743
744  /* *WARNING*
745  **    In the following code in place of plain server's
746  **    name we send what is returned by get_client_name
747  **    which may add the "sockhost" after the name. It's
748  **    *very* *important* that there is a SPACE between
749  **    the name and sockhost (if present). The receiving
750  **    server will start the information field from this
751  **    first blank and thus puts the sockhost into info.
752  **    ...a bit tricky, but you have been warned, besides
753  **    code is more neat this way...  --msa
754  */
755  client_p->servptr = &me;
756
757  if (IsClosing(client_p))
758    return;
759
760  SetServer(client_p);
761
762  /* Update the capability combination usage counts. -A1kmm */
763  set_chcap_usage_counts(client_p);
764
765  /* Some day, all these lists will be consolidated *sigh* */
766  dlinkAdd(client_p, &client_p->lnode, &me.serv->server_list);
767
768  assert(dlinkFind(&unknown_list, client_p));
769
770  dlink_move_node(&client_p->localClient->lclient_node,
771                  &unknown_list, &serv_list);
772
773  Count.myserver++;
774
775  dlinkAdd(client_p, make_dlink_node(), &global_serv_list);
776  hash_add_client(client_p);
777
778  /* doesnt duplicate client_p->serv if allocated this struct already */
779  make_server(client_p);
780
781  /* fixing eob timings.. -gnp */
782  client_p->localClient->firsttime = CurrentTime;
783
784  if (find_matching_name_conf(CONF_SERVICE, client_p->name, NULL, NULL, 0))
785    AddFlag(client_p, FLAGS_SERVICE);
786
787  /* Show the real host/IP to admins */
788 #ifdef HAVE_LIBCRYPTO
789  if (client_p->localClient->fd.ssl)
790  {
791    compression = SSL_get_current_compression(client_p->localClient->fd.ssl);
792    expansion   = SSL_get_current_expansion(client_p->localClient->fd.ssl);
793
794    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
795                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
796                         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
797                         compression ? SSL_COMP_get_name(compression) : "NONE",
798                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
799                         show_capabilities(client_p));
800    /* Now show the masked hostname/IP to opers */
801    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
802                         "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
803                         inpath, ssl_get_cipher(client_p->localClient->fd.ssl),
804                         compression ? SSL_COMP_get_name(compression) : "NONE",
805                         expansion ? SSL_COMP_get_name(expansion) : "NONE",
806                         show_capabilities(client_p));
807    ilog(LOG_TYPE_IRCD, "Link with %s established: [SSL: %s, Compression/Expansion method: %s/%s] (Capabilities: %s)",
808         inpath_ip, ssl_get_cipher(client_p->localClient->fd.ssl),
809         compression ? SSL_COMP_get_name(compression) : "NONE",
810         expansion ? SSL_COMP_get_name(expansion) : "NONE",
811         show_capabilities(client_p));
812  }
813  else
814 #endif
815  {
816    sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
817                         "Link with %s established: (Capabilities: %s)",
818                         inpath_ip, show_capabilities(client_p));
819    /* Now show the masked hostname/IP to opers */
820    sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
821                         "Link with %s established: (Capabilities: %s)",
822                         inpath, show_capabilities(client_p));
823    ilog(LOG_TYPE_IRCD, "Link with %s established: (Capabilities: %s)",
824         inpath_ip, show_capabilities(client_p));
825  }
826
827  fd_note(&client_p->localClient->fd, "Server: %s", client_p->name);
828
829  /* Old sendto_serv_but_one() call removed because we now
830  ** need to send different names to different servers
831  ** (domain name matching) Send new server to other servers.
832  */
833  DLINK_FOREACH(ptr, serv_list.head)
834  {
835    target_p = ptr->data;
836
837    if (target_p == client_p)
838      continue;
839
840    if (IsCapable(target_p, CAP_TS6) && HasID(client_p))
841      sendto_one(target_p, ":%s SID %s 2 %s :%s%s",
842                 me.id, client_p->name, client_p->id,
843                 IsHidden(client_p) ? "(H) " : "",
844                 client_p->info);
845    else
846      sendto_one(target_p,":%s SERVER %s 2 :%s%s",
847                 me.name, client_p->name,
848                 IsHidden(client_p) ? "(H) " : "",
849                 client_p->info);
850  }
851
852  /* Pass on my client information to the new server
853  **
854  ** First, pass only servers (idea is that if the link gets
855  ** cancelled beacause the server was already there,
856  ** there are no NICK's to be cancelled...). Of course,
857  ** if cancellation occurs, all this info is sent anyway,
858  ** and I guess the link dies when a read is attempted...? --msa
859  **
860  ** Note: Link cancellation to occur at this point means
861  ** that at least two servers from my fragment are building
862  ** up connection this other fragment at the same time, it's
863  ** a race condition, not the normal way of operation...
864  **
865  ** ALSO NOTE: using the get_client_name for server names--
866  **    see previous *WARNING*!!! (Also, original inpath
867  **    is destroyed...)
868  */
869
870  DLINK_FOREACH_PREV(ptr, global_serv_list.tail)
871  {
872    target_p = ptr->data;
873
874    /* target_p->from == target_p for target_p == client_p */
875    if (IsMe(target_p) || target_p->from == client_p)
876      continue;
877
878    if (IsCapable(client_p, CAP_TS6))
879    {
880      if (HasID(target_p))
881        sendto_one(client_p, ":%s SID %s %d %s :%s%s",
882                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
883                   target_p->id, IsHidden(target_p) ? "(H) " : "",
884                   target_p->info);
885      else  /* introducing non-ts6 server */
886        sendto_one(client_p, ":%s SERVER %s %d :%s%s",
887                   ID(target_p->servptr), target_p->name, target_p->hopcount+1,
888                   IsHidden(target_p) ? "(H) " : "", target_p->info);
889    }
890    else
891      sendto_one(client_p, ":%s SERVER %s %d :%s%s",
892                 target_p->servptr->name, target_p->name, target_p->hopcount+1,
893                 IsHidden(target_p) ? "(H) " : "", target_p->info);
894
895    if (HasFlag(target_p, FLAGS_EOB))
896      sendto_one(client_p, ":%s EOB", ID_or_name(client_p, target_p));
897  }
898
899  server_burst(client_p);
900 }
901
902 /* server_burst()
903 *
904 * inputs       - struct Client pointer server
905 *              -
906 * output       - none
907 * side effects - send a server burst
908 * bugs         - still too long
909 */
910 static void
911 server_burst(struct Client *client_p)
912 {
913  /* Send it in the shortened format with the TS, if
914  ** it's a TS server; walk the list of channels, sending
915  ** all the nicks that haven't been sent yet for each
916  ** channel, then send the channel itself -- it's less
917  ** obvious than sending all nicks first, but on the
918  ** receiving side memory will be allocated more nicely
919  ** saving a few seconds in the handling of a split
920  ** -orabidoo
921  */
922
923  burst_all(client_p);
924
925  /* EOB stuff is now in burst_all */
926  /* Always send a PING after connect burst is done */
927  sendto_one(client_p, "PING :%s", ID_or_name(&me, client_p));
928 }
929
930 /* burst_all()
931 *
932 * inputs       - pointer to server to send burst to
933 * output       - NONE
934 * side effects - complete burst of channels/nicks is sent to client_p
935 */
936 static void
937 burst_all(struct Client *client_p)
938 {
939  dlink_node *ptr = NULL;
940
941  DLINK_FOREACH(ptr, global_channel_list.head)
942  {
943    struct Channel *chptr = ptr->data;
944
945    if (dlink_list_length(&chptr->members) != 0)
946    {
947      burst_members(client_p, chptr);
948      send_channel_modes(client_p, chptr);
949
950      if (IsCapable(client_p, CAP_TBURST))
951        send_tb(client_p, chptr);
952    }
953  }
954
955  /* also send out those that are not on any channel
956   */
957  DLINK_FOREACH(ptr, global_client_list.head)
958  {
959    struct Client *target_p = ptr->data;
960
961    if (!HasFlag(target_p, FLAGS_BURSTED) && target_p->from != client_p)
962      sendnick_TS(client_p, target_p);
963    
964    DelFlag(target_p, FLAGS_BURSTED);
965  }
966
967  if (IsCapable(client_p, CAP_EOB))
968    sendto_one(client_p, ":%s EOB", ID_or_name(&me, client_p));
969 }
970
971 /*
972 * send_tb
973 *
974 * inputs       - pointer to Client
975 *              - pointer to channel
976 * output       - NONE
977 * side effects - Called on a server burst when
978 *                server is CAP_TBURST capable
979 */
980 static void
981 send_tb(struct Client *client_p, struct Channel *chptr)
982 {
983  /*
984   * We may also send an empty topic here, but only if topic_time isn't 0,
985   * i.e. if we had a topic that got unset.  This is required for syncing
986   * topics properly.
987   *
988   * Imagine the following scenario: Our downlink introduces a channel
989   * to us with a TS that is equal to ours, but the channel topic on
990   * their side got unset while the servers were in splitmode, which means
991   * their 'topic' is newer.  They simply wanted to unset it, so we have to
992   * deal with it in a more sophisticated fashion instead of just resetting
993   * it to their old topic they had before.  Read m_tburst.c:ms_tburst
994   * for further information   -Michael
995   */
996  if (chptr->topic_time != 0)
997    sendto_one(client_p, ":%s TBURST %lu %s %lu %s :%s",
998               ID_or_name(&me, client_p),
999               (unsigned long)chptr->channelts, chptr->chname,
1000               (unsigned long)chptr->topic_time,
1001               chptr->topic_info,
1002               chptr->topic);
1003 }
1004
1005 /* burst_members()
1006 *
1007 * inputs       - pointer to server to send members to
1008 *              - dlink_list pointer to membership list to send
1009 * output       - NONE
1010 * side effects -
1011 */
1012 static void
1013 burst_members(struct Client *client_p, struct Channel *chptr)
1014 {
1015  struct Client *target_p;
1016  struct Membership *ms;
1017  dlink_node *ptr;
1018
1019  DLINK_FOREACH(ptr, chptr->members.head)
1020  {
1021    ms       = ptr->data;
1022    target_p = ms->client_p;
1023
1024    if (!HasFlag(target_p, FLAGS_BURSTED))
1025    {
1026      AddFlag(target_p, FLAGS_BURSTED);
1027
1028      if (target_p->from != client_p)
1029        sendnick_TS(client_p, target_p);
1030    }
1031  }
1032 }
1033
579   /* New server connection code
580   * Based upon the stuff floating about in s_bsd.c
581   *   -- adrian
# Line 1038 | Line 583 | burst_members(struct Client *client_p, s
583  
584   /* serv_connect() - initiate a server connection
585   *
586 < * inputs       - pointer to conf
586 > * inputs       - pointer to conf
587   *              - pointer to client doing the connect
588   * output       -
589   * side effects -
# Line 1055 | Line 600 | burst_members(struct Client *client_p, s
600   int
601   serv_connect(struct MaskItem *conf, struct Client *by)
602   {
603 <  struct Client *client_p;
604 <  char buf[HOSTIPLEN + 1];
603 >  struct Client *client_p = NULL;
604 >  char buf[HOSTIPLEN + 1] = "";
605  
606    /* conversion structs */
607    struct sockaddr_in *v4;
1063  /* Make sure conf is useful */
1064  assert(conf != NULL);
608  
609 +  /* Make sure conf is useful */
610 +  assert(conf);
611  
612    getnameinfo((struct sockaddr *)&conf->addr, conf->addr.ss_len,
613                buf, sizeof(buf), NULL, 0, NI_NUMERICHOST);
# Line 1075 | Line 620 | serv_connect(struct MaskItem *conf, stru
620      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
621                           "Error connecting to %s: DNS lookup for connect{} in progress.",
622                           conf->name);
623 <    return (0);
623 >    return 0;
624    }
625  
626    if (conf->dns_failed)
# Line 1083 | Line 628 | serv_connect(struct MaskItem *conf, stru
628      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
629                           "Error connecting to %s: DNS lookup for connect{} failed.",
630                           conf->name);
631 <    return (0);
631 >    return 0;
632    }
633  
634    /* Make sure this server isn't already connected
635     * Note: conf should ALWAYS be a valid C: line
636     */
637 <  if ((client_p = hash_find_server(conf->name)) != NULL)
638 <  {
637 >  if ((client_p = hash_find_server(conf->name)))
638 >  {
639      sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
640                           "Server %s already present from %s",
641                           conf->name, get_client_name(client_p, SHOW_IP));
# Line 1098 | Line 643 | serv_connect(struct MaskItem *conf, stru
643                           "Server %s already present from %s",
644                           conf->name, get_client_name(client_p, MASK_IP));
645      if (by && IsClient(by) && !MyClient(by))
646 <      sendto_one(by, ":%s NOTICE %s :Server %s already present from %s",
647 <                 me.name, by->name, conf->name,
1103 <                 get_client_name(client_p, MASK_IP));
646 >      sendto_one_notice(by, &me, ":Server %s already present from %s",
647 >                        conf->name, get_client_name(client_p, MASK_IP));
648      return 0;
649    }
650 <    
650 >
651    /* Create a local client */
652    client_p = make_client(NULL);
653  
# Line 1114 | Line 658 | serv_connect(struct MaskItem *conf, stru
658    /* We already converted the ip once, so lets use it - stu */
659    strlcpy(client_p->sockhost, buf, sizeof(client_p->sockhost));
660  
661 <  /* create a socket for the server connection */
662 <  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family,
1119 <                SOCK_STREAM, 0, NULL) < 0)
661 >  /* create a socket for the server connection */
662 >  if (comm_open(&client_p->localClient->fd, conf->addr.ss.ss_family, SOCK_STREAM, 0, NULL) < 0)
663    {
664      /* Eek, failure to create the socket */
665 <    report_error(L_ALL, "opening stream socket to %s: %s",
666 <                 conf->name, errno);
665 >    report_error(L_ALL, "opening stream socket to %s: %s", conf->name, errno);
666 >
667      SetDead(client_p);
668 <    exit_client(client_p, &me, "Connection failed");
668 >    exit_client(client_p, "Connection failed");
669      return 0;
670    }
671  
# Line 1137 | Line 680 | serv_connect(struct MaskItem *conf, stru
680      sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
681                           "Host %s is not enabled for connecting: no connect{} block",
682                           conf->name);
683 <    if (by && IsClient(by) && !MyClient(by))  
684 <      sendto_one(by, ":%s NOTICE %s :Connect to host %s failed.",
685 <                 me.name, by->name, client_p->name);
683 >    if (by && IsClient(by) && !MyClient(by))
684 >      sendto_one_notice(by, &me, ":Connect to host %s failed.", client_p->name);
685 >
686      SetDead(client_p);
687 <    exit_client(client_p, client_p, "Connection failed");
687 >    exit_client(client_p, "Connection failed");
688      return 0;
689    }
690  
# Line 1160 | Line 703 | serv_connect(struct MaskItem *conf, stru
703  
704    SetConnecting(client_p);
705    dlinkAdd(client_p, &client_p->node, &global_client_list);
706 <  /* from def_fam */
706 >
707    client_p->localClient->aftype = conf->aftype;
708  
709    /* Now, initiate the connection */
710 <  /* XXX assume that a non 0 type means a specific bind address
710 >  /* XXX assume that a non 0 type means a specific bind address
711     * for this connect.
712     */
713    switch (conf->aftype)
714    {
715      case AF_INET:
716        v4 = (struct sockaddr_in*)&conf->bind;
717 <      if (v4->sin_addr.s_addr != 0)
717 >      if (v4->sin_addr.s_addr)
718        {
719          struct irc_ssaddr ipn;
720          memset(&ipn, 0, sizeof(struct irc_ssaddr));
# Line 1179 | Line 722 | serv_connect(struct MaskItem *conf, stru
722          ipn.ss_port = 0;
723          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
724          comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
725 <                         (struct sockaddr *)&ipn, ipn.ss_len,
725 >                         (struct sockaddr *)&ipn, ipn.ss_len,
726                           serv_connect_callback, client_p, conf->aftype,
727                           CONNECTTIMEOUT);
728        }
# Line 1196 | Line 739 | serv_connect(struct MaskItem *conf, stru
739                           CONNECTTIMEOUT);
740        }
741        else
742 <        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
743 <                         NULL, 0, serv_connect_callback, client_p, conf->aftype,
742 >        comm_connect_tcp(&client_p->localClient->fd, conf->host, conf->port,
743 >                         NULL, 0, serv_connect_callback, client_p, conf->aftype,
744                           CONNECTTIMEOUT);
745        break;
746   #ifdef IPV6
747      case AF_INET6:
748        {
749 <        struct irc_ssaddr ipn;
750 <        struct sockaddr_in6 *v6;
751 <        struct sockaddr_in6 *v6conf;
752 <
753 <        memset(&ipn, 0, sizeof(struct irc_ssaddr));
754 <        v6conf = (struct sockaddr_in6 *)&conf->bind;
755 <        v6 = (struct sockaddr_in6 *)&ipn;
756 <
757 <        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr,
1215 <                   sizeof(struct in6_addr)) != 0)
1216 <        {
1217 <          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
1218 <          ipn.ss.ss_family = AF_INET6;
1219 <          ipn.ss_port = 0;
1220 <          comm_connect_tcp(&client_p->localClient->fd,
1221 <                           conf->host, conf->port,
1222 <                           (struct sockaddr *)&ipn, ipn.ss_len,
1223 <                           serv_connect_callback, client_p,
1224 <                           conf->aftype, CONNECTTIMEOUT);
1225 <        }
1226 <        else if (ServerInfo.specific_ipv6_vhost)
749 >        struct irc_ssaddr ipn;
750 >        struct sockaddr_in6 *v6;
751 >        struct sockaddr_in6 *v6conf;
752 >
753 >        memset(&ipn, 0, sizeof(struct irc_ssaddr));
754 >        v6conf = (struct sockaddr_in6 *)&conf->bind;
755 >        v6 = (struct sockaddr_in6 *)&ipn;
756 >
757 >        if (memcmp(&v6conf->sin6_addr, &v6->sin6_addr, sizeof(struct in6_addr)))
758          {
759 <          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
760 <          ipn.ss.ss_family = AF_INET6;
761 <          ipn.ss_port = 0;
762 <          comm_connect_tcp(&client_p->localClient->fd,
763 <                           conf->host, conf->port,
764 <                           (struct sockaddr *)&ipn, ipn.ss_len,
765 <                           serv_connect_callback, client_p,
766 <                           conf->aftype, CONNECTTIMEOUT);
767 <        }
768 <        else
769 <          comm_connect_tcp(&client_p->localClient->fd,
770 <                           conf->host, conf->port,
771 <                           NULL, 0, serv_connect_callback, client_p,
772 <                           conf->aftype, CONNECTTIMEOUT);
759 >          memcpy(&ipn, &conf->bind, sizeof(struct irc_ssaddr));
760 >          ipn.ss.ss_family = AF_INET6;
761 >          ipn.ss_port = 0;
762 >          comm_connect_tcp(&client_p->localClient->fd,
763 >                           conf->host, conf->port,
764 >                           (struct sockaddr *)&ipn, ipn.ss_len,
765 >                           serv_connect_callback, client_p,
766 >                           conf->aftype, CONNECTTIMEOUT);
767 >        }
768 >        else if (ServerInfo.specific_ipv6_vhost)
769 >        {
770 >          memcpy(&ipn, &ServerInfo.ip6, sizeof(struct irc_ssaddr));
771 >          ipn.ss.ss_family = AF_INET6;
772 >          ipn.ss_port = 0;
773 >          comm_connect_tcp(&client_p->localClient->fd,
774 >                           conf->host, conf->port,
775 >                           (struct sockaddr *)&ipn, ipn.ss_len,
776 >                           serv_connect_callback, client_p,
777 >                           conf->aftype, CONNECTTIMEOUT);
778 >        }
779 >        else
780 >          comm_connect_tcp(&client_p->localClient->fd,
781 >                           conf->host, conf->port,
782 >                           NULL, 0, serv_connect_callback, client_p,
783 >                           conf->aftype, CONNECTTIMEOUT);
784        }
785   #endif
786    }
787 <  return (1);
787 >  return 1;
788   }
789  
790   #ifdef HAVE_LIBCRYPTO
# Line 1260 | Line 802 | finish_ssl_server_handshake(struct Clien
802      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
803                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
804  
805 <    exit_client(client_p, &me, "Lost connect{} block");
805 >    exit_client(client_p, "Lost connect{} block");
806      return;
807    }
808  
# Line 1294 | Line 836 | finish_ssl_server_handshake(struct Clien
836   static void
837   ssl_server_handshake(fde_t *fd, struct Client *client_p)
838   {
839 <  int ret;
840 <  int err;
839 >  X509 *cert = NULL;
840 >  int ret = 0;
841  
842 <  ret = SSL_connect(client_p->localClient->fd.ssl);
1301 <
1302 <  if (ret <= 0)
842 >  if ((ret = SSL_connect(client_p->localClient->fd.ssl)) <= 0)
843    {
844 <    switch ((err = SSL_get_error(client_p->localClient->fd.ssl, ret)))
844 >    switch (SSL_get_error(client_p->localClient->fd.ssl, ret))
845      {
846        case SSL_ERROR_WANT_WRITE:
847          comm_setselect(&client_p->localClient->fd, COMM_SELECT_WRITE,
# Line 1317 | Line 857 | ssl_server_handshake(fde_t *fd, struct C
857          sendto_realops_flags(UMODE_ALL, L_ALL, SEND_NOTICE,
858                               "Error connecting to %s: %s", client_p->name,
859                               sslerr ? sslerr : "unknown SSL error");
860 <        exit_client(client_p, client_p, "Error during SSL handshake");
860 >        exit_client(client_p, "Error during SSL handshake");
861          return;
862        }
863      }
864    }
865  
866 +  if ((cert = SSL_get_peer_certificate(client_p->localClient->fd.ssl)))
867 +  {
868 +    int res = SSL_get_verify_result(client_p->localClient->fd.ssl);
869 +    char buf[EVP_MAX_MD_SIZE * 2 + 1] = "";
870 +    unsigned char md[EVP_MAX_MD_SIZE] = "";
871 +
872 +    if (res == X509_V_OK || res == X509_V_ERR_SELF_SIGNED_CERT_IN_CHAIN ||
873 +        res == X509_V_ERR_UNABLE_TO_VERIFY_LEAF_SIGNATURE ||
874 +        res == X509_V_ERR_DEPTH_ZERO_SELF_SIGNED_CERT)
875 +    {
876 +      unsigned int n = 0;
877 +
878 +      if (X509_digest(cert, EVP_sha256(), md, &n))
879 +      {
880 +        for (unsigned int i = 0; i < n; ++i)
881 +          snprintf(buf + 2 * i, 3, "%02X", md[i]);
882 +        client_p->certfp = xstrdup(buf);
883 +      }
884 +    }
885 +    else
886 +      ilog(LOG_TYPE_IRCD, "Server %s!%s@%s gave bad SSL client certificate: %d",
887 +           client_p->name, client_p->username, client_p->host, res);
888 +    X509_free(cert);
889 +  }
890 +
891    finish_ssl_server_handshake(client_p);
892   }
893  
# Line 1334 | Line 899 | ssl_connect_init(struct Client *client_p
899      ilog(LOG_TYPE_IRCD, "SSL_new() ERROR! -- %s",
900           ERR_error_string(ERR_get_error(), NULL));
901      SetDead(client_p);
902 <    exit_client(client_p, client_p, "SSL_new failed");
902 >    exit_client(client_p, "SSL_new failed");
903      return;
904    }
905  
# Line 1348 | Line 913 | ssl_connect_init(struct Client *client_p
913   #endif
914  
915   /* serv_connect_callback() - complete a server connection.
916 < *
916 > *
917   * This routine is called after the server connection attempt has
918   * completed. If unsucessful, an error is sent to ops and the client
919   * is closed. If sucessful, it goes through the initialisation/check
# Line 1362 | Line 927 | serv_connect_callback(fde_t *fd, int sta
927    struct MaskItem *conf = NULL;
928  
929    /* First, make sure its a real client! */
930 <  assert(client_p != NULL);
930 >  assert(client_p);
931    assert(&client_p->localClient->fd == fd);
932  
933    /* Next, for backward purposes, record the ip of the server */
934    memcpy(&client_p->localClient->ip, &fd->connect.hostaddr,
935           sizeof(struct irc_ssaddr));
936 +
937    /* Check the status */
938    if (status != COMM_OK)
939    {
# Line 1405 | Line 971 | serv_connect_callback(fde_t *fd, int sta
971      sendto_realops_flags(UMODE_ALL, L_OPER, SEND_NOTICE,
972                           "Lost connect{} block for %s", get_client_name(client_p, MASK_IP));
973  
974 <    exit_client(client_p, &me, "Lost connect{} block");
974 >    exit_client(client_p, "Lost connect{} block");
975      return;
976    }
977  
# Line 1430 | Line 996 | serv_connect_callback(fde_t *fd, int sta
996    /* If we've been marked dead because a send failed, just exit
997     * here now and save everyone the trouble of us ever existing.
998     */
999 <  if (IsDead(client_p))
999 >  if (IsDead(client_p))
1000    {
1001        sendto_realops_flags(UMODE_ALL, L_ADMIN, SEND_NOTICE,
1002                             "%s[%s] went dead during handshake",
# Line 1460 | Line 1026 | find_servconn_in_progress(const char *na
1026        if (!match(name, cptr->name))
1027          return cptr;
1028    }
1029 <  
1029 >
1030    return NULL;
1031   }

Diff Legend

Removed lines
+ Added lines
< Changed lines (old)
> Changed lines (new)