/[svn]/ircd-hybrid/branches/8.0.x/src/parse.c
ViewVC logotype

Diff of /ircd-hybrid/branches/8.0.x/src/parse.c

Parent Directory Parent Directory | Revision Log Revision Log | View Patch Patch

revision 1681 by michael, Sat Oct 27 21:09:19 2012 UTC revision 1682 by michael, Tue Dec 18 18:45:27 2012 UTC
# Line 710  handle_numeric(char numeric[], struct Cl Line 710  handle_numeric(char numeric[], struct Cl
710         * unfortunately, it did not work. --Dianora         * unfortunately, it did not work. --Dianora
711         */         */
712    
713          /*
714           * Also ignoring ERR_NOTREGISTERED for now. A connecting server may send this
715           * in response to the "NOTICE AUTH ..." message upon registration. Normally
716           * the !IsServer() test in handle_numeric() would take care of this situation,
717           * but due to the fact that read_packet() in s_auth.c:release_auth_client() is
718           * called for the very first time _after_ ident/dns registration, it looks like
719           * the numeric (451) messages are queued up whereas meanwhile the serverlink
720           * succesfully establishes. Right after that, after IsServer() is true, the queued
721           * numeric messages will then be processed, and a notice is falsely sent to operators.
722           * The I/O engine will be rewritten soon (a mixture of libevent), so maybe this also
723           * will fix described behavior above, but for now we're just going to drop this message
724           * (no problem at all, we propably shouldn't process numeric destined to servers anyway)
725           * -Michael
726           */
727        /* Yes, a good compiler would have optimised this, but        /* Yes, a good compiler would have optimised this, but
728         * this is probably easier to read. -db         * this is probably easier to read. -db
729         */         */
730        num = atoi(numeric);        num = atoi(numeric);
731    
732        if ((num != ERR_NOSUCHNICK))        if ((num != ERR_NOSUCHNICK) && (num != ERR_NOTREGISTERED))
733          sendto_realops_flags(UMODE_ALL, L_ADMIN,          sendto_realops_flags(UMODE_ALL, L_ADMIN,
734                               "*** %s(via %s) sent a %s numeric to me: %s",                               "*** %s(via %s) sent a %s numeric to me: %s",
735                               source_p->name, client_p->name, numeric, buffer);                               source_p->name, client_p->name, numeric, buffer);

Legend:
Removed from v.1681  
changed lines
  Added in v.1682

svnadmin@ircd-hybrid.org
ViewVC Help
Powered by ViewVC 1.1.28